| *** shaohe_feng has quit IRC | 00:00 | |
| *** shaohe_feng has joined #openstack-nova | 00:02 | |
| *** shaohe_feng has quit IRC | 00:11 | |
| *** slaweq has joined #openstack-nova | 00:11 | |
| *** shaohe_feng has joined #openstack-nova | 00:12 | |
| *** linkmark has quit IRC | 00:12 | |
| *** slaweq has quit IRC | 00:16 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673 | 00:20 |
|---|---|---|
| *** medberry has joined #openstack-nova | 00:20 | |
| *** shaohe_feng has quit IRC | 00:21 | |
| *** shaohe_feng has joined #openstack-nova | 00:22 | |
| *** bigdogstl has joined #openstack-nova | 00:23 | |
| *** bigdogstl has quit IRC | 00:30 | |
| *** shaohe_feng has quit IRC | 00:31 | |
| *** shaohe_feng has joined #openstack-nova | 00:33 | |
| *** bigdogstl has joined #openstack-nova | 00:33 | |
| *** Kevin_Zheng has quit IRC | 00:35 | |
| *** tetsuro has joined #openstack-nova | 00:38 | |
| *** bigdogstl has quit IRC | 00:38 | |
| *** shaohe_feng has quit IRC | 00:41 | |
| *** shaohe_feng has joined #openstack-nova | 00:42 | |
| *** bigdogstl has joined #openstack-nova | 00:49 | |
| *** flwang1 has quit IRC | 00:50 | |
| *** shaohe_feng has quit IRC | 00:52 | |
| *** shaohe_feng has joined #openstack-nova | 00:53 | |
| *** tbachman has joined #openstack-nova | 00:57 | |
| *** shaohe_feng has quit IRC | 01:02 | |
| *** shaohe_feng has joined #openstack-nova | 01:03 | |
| *** bigdogstl has quit IRC | 01:03 | |
| *** mrsoul` has joined #openstack-nova | 01:10 | |
| *** bigdogstl has joined #openstack-nova | 01:11 | |
| *** shaohe_feng has quit IRC | 01:12 | |
| *** mrsoul has quit IRC | 01:13 | |
| *** phuongnh has joined #openstack-nova | 01:13 | |
| *** shaohe_feng has joined #openstack-nova | 01:13 | |
| *** liuzz has joined #openstack-nova | 01:14 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676 | 01:15 |
| *** flwang1 has joined #openstack-nova | 01:15 | |
| *** shaohe_feng has quit IRC | 01:22 | |
| *** hongbin has joined #openstack-nova | 01:23 | |
| *** shaohe_feng has joined #openstack-nova | 01:24 | |
| *** bigdogstl has quit IRC | 01:25 | |
| *** bigdogstl has joined #openstack-nova | 01:28 | |
| *** tiendc has joined #openstack-nova | 01:31 | |
| *** shaohe_feng has quit IRC | 01:33 | |
| *** r-daneel has joined #openstack-nova | 01:33 | |
| *** shaohe_feng has joined #openstack-nova | 01:34 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689 | 01:43 |
| *** shaohe_feng has quit IRC | 01:43 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709 | 01:44 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712 | 01:44 |
| *** shaohe_feng has joined #openstack-nova | 01:45 | |
| *** shaohe_feng has quit IRC | 01:53 | |
| *** shaohe_feng has joined #openstack-nova | 01:55 | |
| *** shaohe_feng has quit IRC | 02:03 | |
| *** shaohe_feng has joined #openstack-nova | 02:04 | |
| *** slaweq has joined #openstack-nova | 02:11 | |
| *** shaohe_feng has quit IRC | 02:14 | |
| *** shaohe_feng has joined #openstack-nova | 02:14 | |
| *** slaweq has quit IRC | 02:15 | |
| *** annp has joined #openstack-nova | 02:23 | |
| *** trungnv has joined #openstack-nova | 02:24 | |
| *** shaohe_feng has quit IRC | 02:24 | |
| *** shaohe_feng has joined #openstack-nova | 02:25 | |
| *** shaohe_feng has quit IRC | 02:34 | |
| *** shaohe_feng has joined #openstack-nova | 02:34 | |
| *** armaan has joined #openstack-nova | 02:37 | |
| *** armaan has quit IRC | 02:41 | |
| *** bigdogstl has quit IRC | 02:42 | |
| *** shaohe_feng has quit IRC | 02:44 | |
| *** shaohe_feng has joined #openstack-nova | 02:47 | |
| *** bigdogstl has joined #openstack-nova | 02:48 | |
| *** shaohe_feng has quit IRC | 02:55 | |
| *** psachin has joined #openstack-nova | 02:57 | |
| *** shaohe_feng has joined #openstack-nova | 02:57 | |
| *** bigdogstl has quit IRC | 03:01 | |
| *** gongysh has joined #openstack-nova | 03:04 | |
| *** shaohe_feng has quit IRC | 03:05 | |
| *** shaohe_feng has joined #openstack-nova | 03:05 | |
| *** slaweq has joined #openstack-nova | 03:11 | |
| *** shaohe_feng has quit IRC | 03:15 | |
| *** slaweq has quit IRC | 03:15 | |
| *** Bhujay has joined #openstack-nova | 03:16 | |
| *** shaohe_feng has joined #openstack-nova | 03:20 | |
| *** felipemonteiro__ has joined #openstack-nova | 03:24 | |
| *** shaohe_feng has quit IRC | 03:25 | |
| *** shaohe_feng has joined #openstack-nova | 03:27 | |
| *** Zames has joined #openstack-nova | 03:27 | |
| *** felipemonteiro_ has quit IRC | 03:27 | |
| *** Zames has quit IRC | 03:30 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:30 | |
| *** blkart has quit IRC | 03:33 | |
| *** blkart has joined #openstack-nova | 03:35 | |
| *** shaohe_feng has quit IRC | 03:36 | |
| *** shaohe_feng has joined #openstack-nova | 03:36 | |
| *** links has joined #openstack-nova | 03:39 | |
| *** udesale has joined #openstack-nova | 03:40 | |
| *** shaohe_feng has quit IRC | 03:46 | |
| *** shaohe_feng has joined #openstack-nova | 03:47 | |
| *** takashin has quit IRC | 03:53 | |
| *** shaohe_feng has quit IRC | 03:56 | |
| *** bigdogstl has joined #openstack-nova | 03:57 | |
| *** takashin has joined #openstack-nova | 03:58 | |
| *** kevinbenton has quit IRC | 04:00 | |
| *** shaohe_feng has joined #openstack-nova | 04:00 | |
| *** kevinbenton has joined #openstack-nova | 04:00 | |
| *** Dinesh_Bhor has quit IRC | 04:01 | |
| *** bigdogstl has quit IRC | 04:02 | |
| *** mschuppert has joined #openstack-nova | 04:05 | |
| *** itlinux has quit IRC | 04:06 | |
| *** shaohe_feng has quit IRC | 04:06 | |
| *** shaohe_feng has joined #openstack-nova | 04:07 | |
| *** Bhujay has quit IRC | 04:07 | |
| *** sambetts_ has quit IRC | 04:07 | |
| *** sambetts_ has joined #openstack-nova | 04:09 | |
| *** armaan has joined #openstack-nova | 04:12 | |
| *** links has quit IRC | 04:15 | |
| *** stakeda has joined #openstack-nova | 04:15 | |
| *** medberry has quit IRC | 04:16 | |
| *** armaan has quit IRC | 04:17 | |
| *** shaohe_feng has quit IRC | 04:17 | |
| *** shaohe_feng has joined #openstack-nova | 04:17 | |
| *** shaohe_feng has quit IRC | 04:27 | |
| *** shaohe_feng has joined #openstack-nova | 04:28 | |
| *** hoonetorg has quit IRC | 04:28 | |
| *** abhishekk has joined #openstack-nova | 04:32 | |
| *** links has joined #openstack-nova | 04:33 | |
| *** shaohe_feng has quit IRC | 04:37 | |
| *** shaohe_feng has joined #openstack-nova | 04:38 | |
| *** hongbin has quit IRC | 04:41 | |
| *** hoonetorg has joined #openstack-nova | 04:45 | |
| *** shaohe_feng has quit IRC | 04:47 | |
| *** shaohe_feng has joined #openstack-nova | 04:48 | |
| *** sapd1 has joined #openstack-nova | 04:52 | |
| *** armaan has joined #openstack-nova | 04:54 | |
| *** flwang1 has quit IRC | 04:56 | |
| *** shaohe_feng has quit IRC | 04:58 | |
| *** shaohe_feng has joined #openstack-nova | 04:58 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform compute_task notifications https://review.openstack.org/482629 | 04:58 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Create specs directory for Stein https://review.openstack.org/573602 | 04:59 |
| *** gongysh has quit IRC | 04:59 | |
| *** sapd1 has quit IRC | 05:00 | |
| *** armaan has quit IRC | 05:00 | |
| *** armaan has joined #openstack-nova | 05:01 | |
| *** sapd1 has joined #openstack-nova | 05:02 | |
| *** armaan_ has joined #openstack-nova | 05:03 | |
| *** phuongnh has quit IRC | 05:03 | |
| *** tiendc has quit IRC | 05:03 | |
| *** trungnv has quit IRC | 05:03 | |
| *** armaan_ has joined #openstack-nova | 05:04 | |
| *** phuongnh has joined #openstack-nova | 05:04 | |
| *** tiendc has joined #openstack-nova | 05:04 | |
| *** trungnv has joined #openstack-nova | 05:04 | |
| *** armaan has quit IRC | 05:06 | |
| *** shaohe_feng has quit IRC | 05:08 | |
| *** armaan_ has quit IRC | 05:08 | |
| *** shaohe_feng has joined #openstack-nova | 05:10 | |
| *** slaweq has joined #openstack-nova | 05:11 | |
| *** Bhujay has joined #openstack-nova | 05:14 | |
| *** slaweq has quit IRC | 05:15 | |
| *** giblet is now known as gibi | 05:18 | |
| *** shaohe_feng has quit IRC | 05:18 | |
| *** shaohe_feng has joined #openstack-nova | 05:19 | |
| *** felipemonteiro__ has quit IRC | 05:24 | |
| *** bkopilov has joined #openstack-nova | 05:25 | |
| *** shaohe_feng has quit IRC | 05:28 | |
| *** shaohe_feng has joined #openstack-nova | 05:29 | |
| *** gongysh has joined #openstack-nova | 05:30 | |
| openstackgerrit | Thomas Goirand proposed openstack/nova master: Remove "async" as variable name https://review.openstack.org/586782 | 05:31 |
| *** naichuans has joined #openstack-nova | 05:36 | |
| *** shaohe_feng has quit IRC | 05:39 | |
| *** shaohe_feng has joined #openstack-nova | 05:39 | |
| *** shaohe_feng has quit IRC | 05:49 | |
| *** shaohe_feng has joined #openstack-nova | 05:50 | |
| *** jaosorior has joined #openstack-nova | 05:51 | |
| *** sapd1 has quit IRC | 05:51 | |
| *** vivsoni has joined #openstack-nova | 05:53 | |
| *** shaohe_feng has quit IRC | 05:59 | |
| *** shaohe_feng has joined #openstack-nova | 06:00 | |
| *** takashin has quit IRC | 06:09 | |
| *** shaohe_feng has quit IRC | 06:09 | |
| *** slaweq has joined #openstack-nova | 06:11 | |
| *** alexchadin has joined #openstack-nova | 06:12 | |
| *** shaohe_feng has joined #openstack-nova | 06:13 | |
| *** alexchadin has quit IRC | 06:14 | |
| *** ratailor has joined #openstack-nova | 06:14 | |
| *** slaweq has quit IRC | 06:16 | |
| *** brault has quit IRC | 06:19 | |
| *** shaohe_feng has quit IRC | 06:20 | |
| *** shaohe_feng has joined #openstack-nova | 06:20 | |
| *** takashin has joined #openstack-nova | 06:21 | |
| *** swamireddy has quit IRC | 06:23 | |
| *** shaohe_feng has quit IRC | 06:30 | |
| *** melwitt has quit IRC | 06:31 | |
| *** sdake has quit IRC | 06:31 | |
| *** shaohe_feng has joined #openstack-nova | 06:32 | |
| *** melwitt has joined #openstack-nova | 06:32 | |
| *** melwitt is now known as Guest9714 | 06:32 | |
| *** sdake has joined #openstack-nova | 06:32 | |
| *** sdake has quit IRC | 06:32 | |
| *** sdake has joined #openstack-nova | 06:32 | |
| *** swamireddy has joined #openstack-nova | 06:37 | |
| *** threestrands has joined #openstack-nova | 06:38 | |
| *** threestrands has quit IRC | 06:38 | |
| *** threestrands has joined #openstack-nova | 06:38 | |
| *** shaohe_feng has quit IRC | 06:40 | |
| *** shaohe_feng has joined #openstack-nova | 06:40 | |
| *** sambetts_ has quit IRC | 06:41 | |
| *** rdopiera has joined #openstack-nova | 06:41 | |
| *** rdopiera has left #openstack-nova | 06:41 | |
| *** ccamacho has joined #openstack-nova | 06:44 | |
| *** sambetts_ has joined #openstack-nova | 06:45 | |
| *** janki has joined #openstack-nova | 06:47 | |
| *** shaohe_feng has quit IRC | 06:50 | |
| *** shaohe_feng has joined #openstack-nova | 06:51 | |
| openstackgerrit | Jake Yip proposed openstack/nova master: Add --before to nova-manage db archive_deleted_rows https://review.openstack.org/556751 | 06:54 |
| *** tetsuro has quit IRC | 06:56 | |
| *** slaweq has joined #openstack-nova | 06:56 | |
| openstackgerrit | Jake Yip proposed openstack/nova master: Add --before to nova-manage db archive_deleted_rows https://review.openstack.org/556751 | 06:56 |
| *** pcaruana has joined #openstack-nova | 06:56 | |
| *** Bhujay has quit IRC | 06:57 | |
| *** zhurong has joined #openstack-nova | 06:58 | |
| *** brault has joined #openstack-nova | 06:59 | |
| *** shaohe_feng has quit IRC | 07:01 | |
| *** shaohe_feng has joined #openstack-nova | 07:02 | |
| *** tesseract has joined #openstack-nova | 07:04 | |
| *** ispp has joined #openstack-nova | 07:04 | |
| *** rcernin has quit IRC | 07:09 | |
| *** shaohe_feng has quit IRC | 07:11 | |
| *** shaohe_feng has joined #openstack-nova | 07:12 | |
| *** pcaruana has quit IRC | 07:14 | |
| *** vishakha has joined #openstack-nova | 07:17 | |
| *** pcaruana has joined #openstack-nova | 07:18 | |
| *** tetsuro has joined #openstack-nova | 07:19 | |
| *** lpetrut has joined #openstack-nova | 07:20 | |
| vishakha | takashin : Hi, Waiting for your response https://review.openstack.org/#/c/580271/ | 07:21 |
| *** shaohe_feng has quit IRC | 07:21 | |
| *** shaohe_feng has joined #openstack-nova | 07:23 | |
| takashin | vishakha: okay. I will review it today. | 07:23 |
| vishakha | takashin, thanks Pl review this too https://review.openstack.org/#/c/586446/ | 07:25 |
| *** tetsuro has quit IRC | 07:25 | |
| *** tetsuro has joined #openstack-nova | 07:27 | |
| *** shaohe_feng has quit IRC | 07:31 | |
| *** threestrands has quit IRC | 07:32 | |
| *** shaohe_feng has joined #openstack-nova | 07:33 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:39 | |
| *** Bhujay has joined #openstack-nova | 07:40 | |
| *** PapaOurs is now known as bauzas | 07:41 | |
| *** shaohe_feng has quit IRC | 07:42 | |
| *** shaohe_feng has joined #openstack-nova | 07:42 | |
| *** peereb has joined #openstack-nova | 07:43 | |
| *** rpittau has joined #openstack-nova | 07:43 | |
| *** mgoddard has joined #openstack-nova | 07:47 | |
| *** jpena has joined #openstack-nova | 07:47 | |
| openstackgerrit | Merged openstack/nova master: Fix signature of _FakeImageService.download https://review.openstack.org/585747 | 07:48 |
| openstackgerrit | Merged openstack/nova master: api-ref: document user_data length restriction https://review.openstack.org/586388 | 07:48 |
| *** shaohe_feng has quit IRC | 07:52 | |
| *** Luzi has joined #openstack-nova | 07:52 | |
| *** shaohe_feng has joined #openstack-nova | 07:53 | |
| *** cdent has joined #openstack-nova | 07:55 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: libvirt: add method to configure migration speed https://review.openstack.org/586965 | 07:57 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: libvirt: add method to configure migration speed https://review.openstack.org/586965 | 07:58 |
| *** Bhujay has quit IRC | 08:02 | |
| *** liuyulong has joined #openstack-nova | 08:02 | |
| *** shaohe_feng has quit IRC | 08:02 | |
| *** shaohe_feng has joined #openstack-nova | 08:03 | |
| *** derekh has joined #openstack-nova | 08:08 | |
| *** ttsiouts has joined #openstack-nova | 08:09 | |
| *** zhurong has quit IRC | 08:09 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove unused stubbing function from test https://review.openstack.org/586968 | 08:11 |
| *** rmart04 has joined #openstack-nova | 08:11 | |
| *** shaohe_feng has quit IRC | 08:12 | |
| *** avolkov has joined #openstack-nova | 08:13 | |
| *** shaohe_feng has joined #openstack-nova | 08:14 | |
| *** mdnadeem has joined #openstack-nova | 08:14 | |
| *** tssurya has joined #openstack-nova | 08:21 | |
| *** s10 has joined #openstack-nova | 08:22 | |
| *** shaohe_feng has quit IRC | 08:23 | |
| *** shaohe_feng has joined #openstack-nova | 08:25 | |
| *** ispp has quit IRC | 08:28 | |
| *** mgoddard has quit IRC | 08:29 | |
| *** ispp has joined #openstack-nova | 08:32 | |
| *** shaohe_feng has quit IRC | 08:33 | |
| *** shaohe_feng has joined #openstack-nova | 08:34 | |
| *** Yingxin has joined #openstack-nova | 08:42 | |
| *** shaohe_feng has quit IRC | 08:43 | |
| *** shaohe_feng has joined #openstack-nova | 08:44 | |
| *** sean-k-mooney has joined #openstack-nova | 08:44 | |
| *** vishakha has quit IRC | 08:47 | |
| *** shaohe_feng has quit IRC | 08:53 | |
| *** shaohe_feng has joined #openstack-nova | 08:54 | |
| *** mdnadeem_ has joined #openstack-nova | 08:56 | |
| *** mdnadeem has quit IRC | 08:57 | |
| *** vishakha has joined #openstack-nova | 09:00 | |
| *** shaohe_feng has quit IRC | 09:04 | |
| kashyap | sean-k-mooney: Thanks for the review here: https://review.openstack.org/#/c/567258/ | 09:05 |
| *** shaohe_feng has joined #openstack-nova | 09:05 | |
| sean-k-mooney | did you get a chance to look into why the live migration was failing friday? | 09:06 |
| kashyap | sean-k-mooney: Darn, I haven't yet dug into the Tempest failures. And I'll be off from Wednesday for 2 1/2 weeks | 09:06 |
| kashyap | :-( | 09:06 |
| kashyap | sean-k-mooney: I looked at it a couple of times, there were Cloud Provider issues | 09:06 |
| kashyap | Let me look at it now | 09:07 |
| kashyap | sean-k-mooney: I wonder if we can get this merged by tomm... | 09:07 |
| *** shaohe_feng has quit IRC | 09:14 | |
| *** shaohe_feng has joined #openstack-nova | 09:16 | |
| openstackgerrit | huanhongda proposed openstack/nova master: Allow unicode keys for metadata https://review.openstack.org/536236 | 09:17 |
| *** sambetts_ is now known as sambetts | 09:19 | |
| sean-k-mooney | kashyap: well if you think its a cloud provider issue you chould just recheck. but this looked like it just did not migrate to the correct host so i would guesss there is a traceback in the n-cpu log | 09:21 |
| *** psachin` has joined #openstack-nova | 09:21 | |
| kashyap | sean-k-mooney: Right, I did 'recheck' 2 times, and got over the Cloud Provider issues. But just looking through https://orangebox.com/products/Do | 09:21 |
| kashyap | Err, http://logs.openstack.org/58/567258/10/check/nova-live-migration/17bbee9/job-output.txt.gz | 09:21 |
| kashyap | To find the right failure | 09:21 |
| bauzas | kashyap: yup, looks like infra has a cloud provider issue | 09:21 |
| *** psachin has quit IRC | 09:22 | |
| *** shaohe_feng has quit IRC | 09:24 | |
| *** shaohe_feng has joined #openstack-nova | 09:25 | |
| kashyap | bauzas: Hmm | 09:28 |
| kashyap | Still? | 09:28 |
| bauzas | no fresh news I know of, I'm afraid | 09:30 |
| sean-k-mooney | kashyap: looks to me like this was a failure in the code you changed http://logs.openstack.org/58/567258/10/check/nova-live-migration/17bbee9/logs/screen-n-cpu.txt.gz?level=DEBUG#_Jul_27_10_28_57_610656 | 09:30 |
| * kashyap clicks | 09:30 | |
| kashyap | sean-k-mooney: Ah, let me look | 09:31 |
| kashyap | sean-k-mooney: Which test failure is it? | 09:32 |
| kashyap | sean-k-mooney: Is there a page with a precise list of test failures? | 09:32 |
| sean-k-mooney | test_live_block_migration[id-1dce86b8-eb04-4c03-a9d8-9c1dc3ee0c7b] | 09:32 |
| sean-k-mooney | http://logs.openstack.org/58/567258/10/check/nova-live-migration/17bbee9/logs/testr_results.html.gz | 09:32 |
| kashyap | I see: http://logs.openstack.org/58/567258/10/check/nova-live-migration/17bbee9/job-output.txt.gz#_2018-07-27_10_29_43_862692 | 09:32 |
| kashyap | sean-k-mooney: Would be clearer if the HTML report will be in the top-level directory; thanks for the pointer! | 09:33 |
| sean-k-mooney | kashyap: it is on some gate jobs. when its not its usually in the logs dir | 09:33 |
| kashyap | I see, noted. | 09:34 |
| *** shaohe_feng has quit IRC | 09:34 | |
| sean-k-mooney | i just grabbed the instance uuid from the html report of the first failure then when to the n-cpu log and searched for a trasback with that uuid | 09:34 |
| *** dtantsur|afk is now known as dtantsur | 09:35 | |
| *** shaohe_feng has joined #openstack-nova | 09:35 | |
| kashyap | Yep, thank you for the (non-null) pointer | 09:35 |
| *** vishakha has quit IRC | 09:38 | |
| kashyap | sean-k-mooney: How can I reproduce this locally? | 09:42 |
| kashyap | sean-k-mooney: By running one of the Tempest tests? | 09:42 |
| sean-k-mooney | kashyap: tempest will work if you have a 2 node devstack running yes | 09:43 |
| sean-k-mooney | https://review.openstack.org/#/c/567258/10/nova/virt/libvirt/guest.py | 09:43 |
| *** abhishekk has quit IRC | 09:43 | |
| sean-k-mooney | you removed a null check on domain_xml | 09:43 |
| kashyap | sean-k-mooney: Afraid, need to set up afresh, and I'm doing last-minute stuff before I head out. | 09:43 |
| * kashyap clicks | 09:43 | |
| sean-k-mooney | could that be the issue | 09:43 |
| *** ratailor has quit IRC | 09:44 | |
| kashyap | sean-k-mooney: Aah, good pointer; let me look! | 09:44 |
| *** shaohe_feng has quit IRC | 09:45 | |
| *** shaohe_feng has joined #openstack-nova | 09:45 | |
| kashyap | sean-k-mooney: But 'domain_xml' is no longer needed | 09:45 |
| sean-k-mooney | its now destination_xml | 09:46 |
| sean-k-mooney | which you default to None and never check | 09:46 |
| *** Bhujay has joined #openstack-nova | 09:46 | |
| kashyap | Hmm, true. I need to put such a check for 'destination_xml' | 09:47 |
| sean-k-mooney | or you chould do 'params['destination_xml'] = destination_xml or ""' but really if you dont have a dest xml it should proably be the source xml? | 09:48 |
| sean-k-mooney | or just not add it to the params dict | 09:48 |
| kashyap | Hmm, that last option sounds cleaner: if 'destination_xml' is None, then don't add it to the 'params' dict | 09:49 |
| sean-k-mooney | im not sure what the preconditions on migrateToURI3 are | 09:49 |
| sean-k-mooney | in theory you should be able to test this with a functional test locally but i that is non trivail to write correctly | 09:50 |
| kashyap | Yeah | 09:50 |
| *** sapd has quit IRC | 09:51 | |
| *** vishakha has joined #openstack-nova | 09:51 | |
| kashyap | sean-k-mooney: Meanwhile, here is the API definition: https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainMigrateToURI3 | 09:52 |
| *** mdbooth has joined #openstack-nova | 09:52 | |
| *** AlexeyAbashkin has quit IRC | 09:53 | |
| kashyap | The Python bindings use the 'destination_xml', and the C equivalent: https://libvirt.org/html/libvirt-libvirt-domain.html#VIR_MIGRATE_PARAM_DEST_XML | 09:53 |
| *** shaohe_feng has quit IRC | 09:55 | |
| *** shaohe_feng has joined #openstack-nova | 09:57 | |
| sean-k-mooney | kashyap: im not seeing anything that explcitly eays the destination_xml is required. so maybe just omitting it for the params is correct | 09:57 |
| kashyap | sean-k-mooney: Yeah, so how about: http://paste.openstack.org/show/726818/ | 09:57 |
| sean-k-mooney | am you are always leaving it out in that case. | 09:58 |
| sean-k-mooney | just do if destination_xml: | 09:59 |
| sean-k-mooney | params['destination_xml'] = destination_xml | 09:59 |
| *** ratailor has joined #openstack-nova | 10:00 | |
| kashyap | Ah, let me try | 10:00 |
| kashyap | sean-k-mooney: Err, the 'else' thing had the wrong snippet | 10:03 |
| kashyap | Let me re-pase what I have: | 10:03 |
| kashyap | sean-k-mooney: http://paste.openstack.org/show/726820/ | 10:04 |
| *** shaohe_feng has quit IRC | 10:05 | |
| *** shaohe_feng has joined #openstack-nova | 10:06 | |
| *** bkopilov has quit IRC | 10:07 | |
| *** slaweq has quit IRC | 10:07 | |
| kashyap | Thanks for the discussion here! | 10:08 |
| *** slaweq has joined #openstack-nova | 10:09 | |
| *** brault has quit IRC | 10:10 | |
| *** shaohe_feng has quit IRC | 10:15 | |
| s10 | https://bugs.launchpad.net/nova/+bug/1322921 | 10:16 |
| openstack | Launchpad bug 1322921 in OpenStack Compute (nova) "hypervisor-servers command always search by wildcard as '%hypervisor_hostname%'" [Wishlist,Opinion] | 10:16 |
| *** shaohe_feng has joined #openstack-nova | 10:16 | |
| s10 | Could this bug be changed to another status? | 10:16 |
| s10 | Because this bug is awful. Execute: nova host-evaucate-live cmp2 | 10:16 |
| s10 | Result: all hosts cmp2* will be live evacuated. | 10:17 |
| kashyap | sean-k-mooney: Okay, I'll go with this: | 10:22 |
| kashyap | params = {} | 10:23 |
| kashyap | params['bandwidth'] = bandwidth | 10:23 |
| kashyap | params['migrate_disks'] = migrate_disks | 10:23 |
| kashyap | params['migrate_uri'] = migrate_uri | 10:23 |
| kashyap | if destination_xml: | 10:23 |
| kashyap | params['destination_xml'] = destination_xml | 10:23 |
| * kashyap goes to rework | 10:23 | |
| *** shaohe_feng has quit IRC | 10:26 | |
| *** jaosorior has quit IRC | 10:26 | |
| *** shaohe_feng has joined #openstack-nova | 10:29 | |
| *** shaohe_feng has quit IRC | 10:36 | |
| *** shaohe_feng has joined #openstack-nova | 10:38 | |
| *** savvas has quit IRC | 10:45 | |
| *** savvas has joined #openstack-nova | 10:45 | |
| *** shaohe_feng has quit IRC | 10:46 | |
| *** udesale has quit IRC | 10:47 | |
| *** shaohe_feng has joined #openstack-nova | 10:47 | |
| *** zzzeek has quit IRC | 10:49 | |
| *** jangutter has joined #openstack-nova | 10:53 | |
| *** zzzeek has joined #openstack-nova | 10:53 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove usage of migrateToURI{2} APIs https://review.openstack.org/567258 | 10:53 |
| *** phuongnh has quit IRC | 10:54 | |
| kashyap | sean-k-mooney: When you have a minute, please have a gander ^. I've addressed the 'destination_xml' and both your consistency nits | 10:54 |
| *** ratailor has quit IRC | 10:56 | |
| *** shaohe_feng has quit IRC | 10:56 | |
| *** shaohe_feng has joined #openstack-nova | 10:57 | |
| sean-k-mooney | kashyap: taking a look now. was on 1:1 call | 11:04 |
| *** gbarros has joined #openstack-nova | 11:06 | |
| *** AlexeyAbashkin has joined #openstack-nova | 11:06 | |
| *** shaohe_feng has quit IRC | 11:07 | |
| *** shaohe_feng has joined #openstack-nova | 11:07 | |
| kashyap | sean-k-mooney: Thank you. I normally don't expect instant turn-around :-) | 11:09 |
| * kashyap bbiab | 11:09 | |
| *** yasufum has joined #openstack-nova | 11:12 | |
| *** yasufum has quit IRC | 11:12 | |
| *** d063130_ has quit IRC | 11:13 | |
| *** sapcc-bot has quit IRC | 11:13 | |
| *** d063130_ has joined #openstack-nova | 11:13 | |
| *** sapcc-bot has joined #openstack-nova | 11:13 | |
| *** annp has quit IRC | 11:14 | |
| *** shaohe_feng has quit IRC | 11:17 | |
| *** shaohe_feng has joined #openstack-nova | 11:17 | |
| *** bkopilov has joined #openstack-nova | 11:24 | |
| *** tbachman has quit IRC | 11:25 | |
| *** shaohe_feng has quit IRC | 11:27 | |
| *** vivsoni has quit IRC | 11:28 | |
| *** shaohe_feng has joined #openstack-nova | 11:28 | |
| *** jpena is now known as jpena|lunch | 11:29 | |
| *** Shilpa has joined #openstack-nova | 11:30 | |
| *** jaosorior has joined #openstack-nova | 11:32 | |
| *** shaohe_feng has quit IRC | 11:37 | |
| *** vivsoni has joined #openstack-nova | 11:39 | |
| *** shaohe_feng has joined #openstack-nova | 11:39 | |
| openstackgerrit | Brin Zhang proposed openstack/nova stable/pike: Add unshelve instance error info to fault table https://review.openstack.org/583426 | 11:44 |
| *** wolverineav has joined #openstack-nova | 11:44 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enhance service restart in functional env https://review.openstack.org/512552 | 11:46 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reproduce bug 1724172 in the functional test env https://review.openstack.org/512553 | 11:46 |
| openstack | bug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Medium,In progress] https://launchpad.net/bugs/1724172 - Assigned to Balazs Gibizer (balazs-gibizer) | 11:46 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: cleanup evacuated instances not on hypervisor https://review.openstack.org/512623 | 11:46 |
| sean-k-mooney | kashyap: looking at the zuul jobs we are still hitting the same error http://logs.openstack.org/58/567258/11/check/nova-live-migration/93ce085/logs/screen-n-cpu.txt.gz#_Jul_30_11_39_23_991580 | 11:47 |
| *** shaohe_feng has quit IRC | 11:48 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fixtures: Track attachments within CinderFixtureNewAttachFlow https://review.openstack.org/587013 | 11:48 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug#1784353 https://review.openstack.org/587014 | 11:48 |
| *** shaohe_feng has joined #openstack-nova | 11:49 | |
| *** Shilpa has quit IRC | 11:51 | |
| *** Shilpa has joined #openstack-nova | 11:52 | |
| *** vishakha has quit IRC | 11:57 | |
| *** dabukalam has joined #openstack-nova | 11:58 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug#1784353 https://review.openstack.org/587014 | 11:58 |
| *** shaohe_feng has quit IRC | 11:58 | |
| *** shaohe_feng has joined #openstack-nova | 12:00 | |
| *** pchavva has joined #openstack-nova | 12:01 | |
| *** Luzi has quit IRC | 12:02 | |
| *** gbarros has quit IRC | 12:04 | |
| *** gbarros has joined #openstack-nova | 12:05 | |
| *** pchavva has quit IRC | 12:06 | |
| *** tiendc has quit IRC | 12:06 | |
| *** ttsiouts has quit IRC | 12:06 | |
| kashyap | sean-k-mooney: Hmm, Zul was so quick? | 12:07 |
| *** ttsiouts has joined #openstack-nova | 12:07 | |
| kashyap | Guess it's still running, isn't it? | 12:07 |
| sean-k-mooney | kashyap: no but you can get the live logs from zuul.openstack.org | 12:07 |
| sean-k-mooney | put 567258 into the filter | 12:08 |
| *** shaohe_feng has quit IRC | 12:08 | |
| sean-k-mooney | you can see the nova-live-migration sub job has completed so you can get to the logs | 12:08 |
| sean-k-mooney | if the job is still running you can connect to a telnet stream of the console but that is less useful | 12:09 |
| *** shaohe_feng has joined #openstack-nova | 12:09 | |
| *** vishakha has joined #openstack-nova | 12:10 | |
| kashyap | sean-k-mooney: Got a URL of the live log? | 12:12 |
| kashyap | Sorry for the sluggish responses, /me is shuffling b/n kitchen & IRC | 12:12 |
| kashyap | sean-k-mooney: /me goes to put that ID in the filter | 12:12 |
| kashyap | TIL | 12:13 |
| sean-k-mooney | most people dont know you can do this with the gate but its been like this for years. module some minor refinement with zuul v3 | 12:13 |
| sean-k-mooney | amy well here is a live log of your neutron-multinode subjob http://zuul.openstack.org/stream.html?uuid=6bc29a9c0ffb44339b36ee4b42b2b1b2&logfile=console.log | 12:14 |
| kashyap | Yeah, I see the URL here: http://logs.openstack.org/58/567258/11/check/nova-live-migration/93ce085/ | 12:14 |
| sean-k-mooney | kashyap: ya the migration subjob has finished so it has published everything to the normal log server | 12:14 |
| *** tbachman has joined #openstack-nova | 12:17 | |
| *** Luzi has joined #openstack-nova | 12:18 | |
| openstackgerrit | Vieri proposed openstack/osc-placement master: Add image link in README.rst https://review.openstack.org/586839 | 12:18 |
| *** mdnadeem_ has quit IRC | 12:18 | |
| *** mdnadeem has joined #openstack-nova | 12:18 | |
| *** mdnadeem_ has joined #openstack-nova | 12:18 | |
| *** shaohe_feng has quit IRC | 12:18 | |
| kashyap | sean-k-mooney: Nod; thanks for the education | 12:18 |
| *** peereb has quit IRC | 12:19 | |
| *** ratailor has joined #openstack-nova | 12:19 | |
| kashyap | sean-k-mooney: Hmm, indeed, still the same TypeError | 12:19 |
| kashyap | http://logs.openstack.org/58/567258/11/check/nova-live-migration/93ce085/logs/screen-n-cpu.txt.gz#_Jul_30_11_39_24_000563 | 12:19 |
| *** shaohe_feng has joined #openstack-nova | 12:20 | |
| sean-k-mooney | im currently trying to get a 2 node dev env up and running | 12:20 |
| kashyap | Oh, you mean, you might be able to run the Tempest test locally? | 12:21 |
| sean-k-mooney | when i get it stacked i can try and pull this down and see whats going on. i want to do some testing of the numa aware vswich code locally so i have to do a multinode deploy anyway | 12:21 |
| sean-k-mooney | kashyap: ya i have the hardware to do that | 12:21 |
| *** tbachman has quit IRC | 12:21 | |
| sean-k-mooney | just not the devstack cloud deployed | 12:21 |
| kashyap | Most excellent, would be curious | 12:22 |
| *** tbachman has joined #openstack-nova | 12:22 | |
| *** mdnadeem has quit IRC | 12:22 | |
| *** medberry has joined #openstack-nova | 12:23 | |
| kashyap | Hmm, maybe something else is None | 12:24 |
| kashyap | sean-k-mooney: Oh: 'migrate_disks' and 'migrate_uri' are None by default! | 12:25 |
| sean-k-mooney | kashyap: there used to be an if check on mirate_uri also. | 12:25 |
| sean-k-mooney | yes | 12:25 |
| sean-k-mooney | i would be surprised if it was migrate_disk however as it is normally a list | 12:26 |
| sean-k-mooney | the none type failure was expecting a sting so im guessing migrate_uri is more likely | 12:27 |
| * kashyap looks | 12:28 | |
| sean-k-mooney | we might want to add a debug line to print each of the values. | 12:28 |
| kashyap | sean-k-mooney: I think that's pretty much it, actually. | 12:29 |
| *** shaohe_feng has quit IRC | 12:29 | |
| kashyap | To be consistent, I'll do this: | 12:29 |
| kashyap | params = {} | 12:29 |
| kashyap | params['bandwidth'] = bandwidth | 12:29 |
| kashyap | if destination_xml: | 12:29 |
| kashyap | params['destination_xml'] = destination_xml | 12:29 |
| kashyap | if migrate_disks: | 12:29 |
| kashyap | params['migrate_disks'] = migrate_disks | 12:29 |
| kashyap | if migrate_uri: | 12:29 |
| kashyap | params['migrate_uri'] = migrate_uri | 12:29 |
| sean-k-mooney | ya that should work or at least help | 12:29 |
| * kashyap runs the tests, and pushes a patch out | 12:30 | |
| sean-k-mooney | im going to need to do an os reinstall on one of the nodes so it will be a while before i have a working env. | 12:30 |
| sean-k-mooney | devstack is not the happist running on a node that had a failed tripple quickstart previously | 12:30 |
| *** shaohe_feng has joined #openstack-nova | 12:31 | |
| kashyap | No worries | 12:31 |
| *** Eran_Kuris has quit IRC | 12:31 | |
| * kashyap used to use this for multi-node DevStack: https://kashyapc.fedorapeople.org/virt/openstack/multi-node-configs/Notes-for-Multi-Node-DevStack-Setup.txt | 12:31 | |
| * kashyap wonders how much of the "Some caveats [...]" section at the end is still valid | 12:32 | |
| *** jpena|lunch is now known as jpena | 12:32 | |
| sean-k-mooney | if i do a virtual multi node i just do it on a kolla-ansible deployed openstack cloud. | 12:33 |
| *** savvas has quit IRC | 12:33 | |
| *** savvas has joined #openstack-nova | 12:34 | |
| * kashyap does virtual, with nVMX | 12:35 | |
| sean-k-mooney | kashyap: ya i use nested virt too i just prefer using an opensck cloud to create my openstack dev enviornments | 12:38 |
| *** shaohe_feng has quit IRC | 12:39 | |
| *** shaohe_feng has joined #openstack-nova | 12:40 | |
| *** gbarros has quit IRC | 12:41 | |
| *** jaypipes has quit IRC | 12:43 | |
| *** jaypipes has joined #openstack-nova | 12:43 | |
| *** links has quit IRC | 12:44 | |
| *** tbachman has quit IRC | 12:45 | |
| *** tbachman has joined #openstack-nova | 12:46 | |
| *** Eran_Kuris has joined #openstack-nova | 12:48 | |
| *** mriedem has joined #openstack-nova | 12:49 | |
| *** mugsie has quit IRC | 12:49 | |
| *** mugsie has joined #openstack-nova | 12:49 | |
| *** mugsie has quit IRC | 12:49 | |
| *** mugsie has joined #openstack-nova | 12:49 | |
| *** shaohe_feng has quit IRC | 12:49 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: DNM: Explore limiting resource tracker update https://review.openstack.org/587050 | 12:50 |
| *** vladikr has joined #openstack-nova | 12:50 | |
| *** shaohe_feng has joined #openstack-nova | 12:50 | |
| *** tbachman has quit IRC | 12:50 | |
| *** lyan has joined #openstack-nova | 12:51 | |
| *** lyan is now known as Guest27464 | 12:51 | |
| *** tbachman has joined #openstack-nova | 12:52 | |
| openstackgerrit | Merged openstack/nova master: Use vif.vif_name in _set_config_VIFGeneric https://review.openstack.org/571461 | 12:53 |
| openstackgerrit | Merged openstack/nova master: tox: Silence psycopg2 warnings https://review.openstack.org/585352 | 12:53 |
| openstackgerrit | Merged openstack/nova master: doc: link to CERN summit video about upgrading from cells v1 to v2 https://review.openstack.org/585044 | 12:54 |
| openstackgerrit | Merged openstack/nova master: doc: link to AZ talk from the Rocky summit https://review.openstack.org/585045 | 12:54 |
| *** jmlowe has quit IRC | 12:55 | |
| *** edmondsw has joined #openstack-nova | 12:56 | |
| *** links has joined #openstack-nova | 12:56 | |
| *** shaohe_feng has quit IRC | 12:59 | |
| *** shaohe_feng has joined #openstack-nova | 13:00 | |
| *** ttsiouts has quit IRC | 13:03 | |
| *** rmart04 has quit IRC | 13:03 | |
| *** edmondsw has quit IRC | 13:06 | |
| *** ttsiouts has joined #openstack-nova | 13:06 | |
| *** Luzi has quit IRC | 13:08 | |
| *** janki has quit IRC | 13:08 | |
| *** janki has joined #openstack-nova | 13:08 | |
| *** tbachman has quit IRC | 13:09 | |
| *** jroll has quit IRC | 13:10 | |
| *** shaohe_feng has quit IRC | 13:10 | |
| *** jroll has joined #openstack-nova | 13:10 | |
| *** shaohe_feng has joined #openstack-nova | 13:10 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove usage of migrateToURI{2} APIs https://review.openstack.org/567258 | 13:11 |
| *** tbachman has joined #openstack-nova | 13:15 | |
| *** bnemec has joined #openstack-nova | 13:20 | |
| *** shaohe_feng has quit IRC | 13:20 | |
| *** shaohe_feng has joined #openstack-nova | 13:22 | |
| *** ttsiouts has quit IRC | 13:25 | |
| *** alexpilotti has joined #openstack-nova | 13:27 | |
| *** mhg has joined #openstack-nova | 13:27 | |
| *** ttsiouts has joined #openstack-nova | 13:28 | |
| *** r-daneel has quit IRC | 13:28 | |
| *** udesale has joined #openstack-nova | 13:30 | |
| *** shaohe_feng has quit IRC | 13:30 | |
| *** shaohe_feng has joined #openstack-nova | 13:30 | |
| *** tetsuro_ has joined #openstack-nova | 13:31 | |
| *** artom has joined #openstack-nova | 13:33 | |
| *** gongysh has quit IRC | 13:34 | |
| *** takashin_ has joined #openstack-nova | 13:35 | |
| *** udesale has quit IRC | 13:35 | |
| *** takashin_ has left #openstack-nova | 13:35 | |
| *** takashin has quit IRC | 13:36 | |
| *** burt has joined #openstack-nova | 13:40 | |
| *** shaohe_feng has quit IRC | 13:40 | |
| *** AlexeyAbashkin has quit IRC | 13:40 | |
| *** AlexeyAbashkin has joined #openstack-nova | 13:41 | |
| *** shaohe_feng has joined #openstack-nova | 13:41 | |
| dansmith | stephenfin: are you back? | 13:42 |
| *** yyz_ has joined #openstack-nova | 13:44 | |
| *** lbragstad has joined #openstack-nova | 13:46 | |
| openstackgerrit | Merged openstack/nova master: Add documentation for emulator threads policy https://review.openstack.org/579956 | 13:50 |
| *** cfriesen_ has joined #openstack-nova | 13:50 | |
| *** shaohe_feng has quit IRC | 13:51 | |
| kashyap | dansmith: IIRC, he's still off til 01-Aug. | 13:51 |
| *** shaohe_feng has joined #openstack-nova | 13:51 | |
| dansmith | ugh okay | 13:51 |
| dansmith | gibi: I replied here: https://review.openstack.org/#/c/585385/14 | 13:52 |
| dansmith | gibi: if you're happy with that I'd sure like to get that landed since the previous patches were predicated on those tests, which we're currently lacking in tree | 13:52 |
| *** takashin has joined #openstack-nova | 13:53 | |
| *** awaugama has joined #openstack-nova | 13:54 | |
| *** ratailor has quit IRC | 13:55 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add description for placement 1.26 https://review.openstack.org/587067 | 13:56 |
| *** jmlowe has joined #openstack-nova | 13:56 | |
| *** skooperit_ has joined #openstack-nova | 13:57 | |
| *** Eran_Kuris has quit IRC | 13:57 | |
| *** erlon has quit IRC | 13:58 | |
| *** Yan__ has quit IRC | 13:59 | |
| efried | Scheduler meeting in #openstack-meeting-alt | 13:59 |
| *** shaohe_feng has quit IRC | 14:01 | |
| *** shaohe_feng has joined #openstack-nova | 14:02 | |
| kashyap | sean-k-mooney: Yay! Now the 'nova-live-migration' job succeeds! | 14:02 |
| kashyap | sean-k-mooney: http://zuul.openstack.org/stream.html?uuid=0707146f416940f68506d5d994038158&logfile=console.log | 14:02 |
| kashyap | sean-k-mooney: Hmm, actually I jumped the gun toon soon :P It's "almost" success, because it's still in blue. | 14:02 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP compute: Recreate attachments during a reschedule https://review.openstack.org/587071 | 14:04 |
| *** cfriesen__ has joined #openstack-nova | 14:04 | |
| *** cfriesen_ has quit IRC | 14:04 | |
| *** erlon has joined #openstack-nova | 14:04 | |
| sean-k-mooney | kashyap: nice | 14:04 |
| kashyap | Not quite, I want to see the green label there :-) | 14:05 |
| sean-k-mooney | has well it will go green when it uploads the logs | 14:05 |
| sean-k-mooney | that said it is still running some of the tests | 14:05 |
| sean-k-mooney | they are passing now however so thats good | 14:06 |
| kashyap | But the failing test succeeded, though: tempest.api.compute.admin.test_live_migration.LiveMigrationTest.test_live_block_migration | 14:06 |
| *** psachin`` has joined #openstack-nova | 14:06 | |
| kashyap | Yep | 14:06 |
| *** psachin` has quit IRC | 14:06 | |
| gibi | dansmith: looking... | 14:07 |
| gibi | dansmith: I've removed the L96 fake_network.set_stub_network_methods(self) and removed L506 fake_network.unset_stub_network_methods(self) and the test started failing. Based on the code the two removed calls are reverse of each other so I expected that if I remove both then the test result is the same | 14:10 |
| dansmith | gibi: okay I thought you meant the unstubbing part specifically | 14:11 |
| *** mlavalle has joined #openstack-nova | 14:11 | |
| gibi | dansmith: I can push that change in a separate commit top of stephenfin's if that helps | 14:11 |
| *** shaohe_feng has quit IRC | 14:11 | |
| dansmith | well, I just don't want to end up without functional tests for this stuff, but I understand why you think this isn't working | 14:12 |
| dansmith | so let me dig in a bit I guess | 14:12 |
| *** shaohe_feng has joined #openstack-nova | 14:12 | |
| *** hongbin has joined #openstack-nova | 14:14 | |
| gibi | dansmith: I'm affraid we are missing something as this functional test is pretty complex. | 14:14 |
| *** antosh has joined #openstack-nova | 14:14 | |
| dansmith | I understand | 14:15 |
| gibi | dansmith: If we find nothing then I can accept to merge this as there are new tests that seems OK | 14:16 |
| dansmith | gibi: your comment about L96.. is that new test using that? I don't think it calls _run_build_test() | 14:17 |
| dansmith | because I thought these were stubbed way lower, which is why mriedem suggested just unstubbing in these couple new tests | 14:17 |
| dansmith | I also thought that this was stubbing neutronapi methods, | 14:18 |
| dansmith | but the fake_stub_network_methods() on L96 is stubbing out compute stuff | 14:18 |
| dansmith | unset will unset any that have been stubbed | 14:18 |
| gibi | dansmith: that could explain what I see. Let me dig in after the scheduler meeting | 14:19 |
| gibi | dansmith: in general I think these tests should work with non stubbed neutronv2/api | 14:19 |
| dansmith | gibi: I'm not sure how, we still have to return fake responses from neutron | 14:19 |
| gibi | dansmith: yeah, that is the only thing that need to be faked | 14:20 |
| *** shaohe_feng has quit IRC | 14:21 | |
| dansmith | well, it's using the neutronfixture, which seems like the right thing to do... | 14:22 |
| dansmith | ah | 14:23 |
| dansmith | gibi: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L79-L79 | 14:23 |
| dansmith | that is the test this inherits from, which stubs things out | 14:24 |
| dansmith | I think if we don't unstub them we don't call into our neutron fixture to return the augmented nw_info, which is why we don't see the new stuff unless we unstub | 14:24 |
| *** shaohe_feng has joined #openstack-nova | 14:24 | |
| dansmith | so NUMAServersTestWithNetworks->NUMAServersTestBase->ServersTestBase->the stubbing | 14:24 |
| gibi | dansmith: OK, then my expectation is that if I move the unstub to the NUMAServersTestBase.setup() then everything should pass | 14:25 |
| *** wolverineav has quit IRC | 14:26 | |
| dansmith | do you mean NUMAServersWithNetworksTest? | 14:26 |
| dansmith | I don't think this patch needs to change the other tests that are here | 14:26 |
| *** wolverineav has joined #openstack-nova | 14:26 | |
| gibi | dansmith: I theory both NUMAServersTestBase but I agree that in _this_ patch we should not change the other tests, so the NUMAServersTestBase change would be a followup | 14:27 |
| *** links has quit IRC | 14:27 | |
| gibi | s/both// | 14:27 |
| dansmith | I just moved it to setup and I think all these new ones pass.. will run the whole file to be sure | 14:27 |
| sean-k-mooney | dansmith: for the numa aware vswitch spec what is the expect behavior if you do not enable the numatopology fileter | 14:28 |
| dansmith | TBH, I'm not sure I see why moving it to setup matters, but.. | 14:28 |
| dansmith | sean-k-mooney: are you asking? | 14:28 |
| sean-k-mooney | dansmith: yes. with stephenfin code we do not validate the constratins on the compute node just in the schduler | 14:29 |
| *** vishakha has quit IRC | 14:29 | |
| sean-k-mooney | at least that is what i am seeing locally. | 14:29 |
| dansmith | sean-k-mooney: right, with the filter disabled this is just all ignored | 14:29 |
| sean-k-mooney | ya is that correct however? | 14:29 |
| dansmith | yes | 14:29 |
| sean-k-mooney | ok cool | 14:30 |
| *** vishakha has joined #openstack-nova | 14:30 | |
| sean-k-mooney | im guessing we dont want a late check like the anti affinity stuff to avoid retries? | 14:31 |
| dansmith | gibi: another test fails if I do that | 14:31 |
| gibi | dansmith: I thought originally that L96 was the stubbing for every NUMAServer tests (and I was wrong) and in general I want to have as small amount of stub in the functional tests as possible. Now that I know that we get the stubbing from a lot further base it means If I need to follow my principle then I have to do a bit more surgery _outside_ of the current patch | 14:31 |
| *** felipemonteiro__ has joined #openstack-nova | 14:31 | |
| dansmith | gibi: it's related to this series, but not this patch | 14:31 |
| dansmith | so if I change this I will have to update that test too | 14:31 |
| dansmith | gibi: totally agree with minimal stubbing in functional tests for sure | 14:31 |
| *** mriedem has quit IRC | 14:31 | |
| dansmith | this is testing fake libvirt with fake neutron, so... lots of stubbing required regardless :/ | 14:31 |
| gibi | dansmith: OK, I don't think any more that is worth to blow up the current patch | 14:32 |
| *** shaohe_feng has quit IRC | 14:32 | |
| dansmith | gibi: I will put the move and the related changes in a separate patch on top then if that's okay with you | 14:32 |
| gibi | dansmith: let's merge this as is and I will spend time on a followup to reduce the stubbing if possible | 14:32 |
| gibi | dansmith: that totally works for me | 14:32 |
| *** shaohe_feng has joined #openstack-nova | 14:32 | |
| *** udesale has joined #openstack-nova | 14:34 | |
| *** dklyle has joined #openstack-nova | 14:34 | |
| *** tidwellr has joined #openstack-nova | 14:35 | |
| *** ChanServ changes topic to "Current runways: abort-live-migration-in-queued-status / add-zvm-driver-rocky / glance-image-traits -- This channel is for Nova development. For support of Nova deployments, please use #openstack." | 14:37 | |
| mnaser | dansmith: whenever you're free, if you can add this to your queue -- https://review.openstack.org/#/c/586824/ (and the patch above it is more of a poc) -- with some info in the bug | 14:38 |
| *** dtantsur is now known as dtantsur|brb | 14:38 | |
| dansmith | alright | 14:39 |
| kashyap | mnaser: Maybe it's just me, but first paragraph in the commit message is confusing | 14:39 |
| *** mriedem has joined #openstack-nova | 14:39 | |
| kashyap | (And the patch above needs to be rebased I think) | 14:40 |
| dansmith | makes sense to me | 14:40 |
| kashyap | You have more context, though :-) But yeah, reading the whole message makes it clearer. | 14:42 |
| *** shaohe_feng has quit IRC | 14:42 | |
| *** shaohe_feng has joined #openstack-nova | 14:43 | |
| *** felipemonteiro_ has joined #openstack-nova | 14:43 | |
| mnaser | kashyap: yeah, it's still very much early and needs reviews :) | 14:44 |
| *** lyan has joined #openstack-nova | 14:45 | |
| mnaser | it was more of a rough "hey how's this to solve a problem" | 14:45 |
| * kashyap nods | 14:45 | |
| *** lyan is now known as Guest4506 | 14:45 | |
| *** egarbade has quit IRC | 14:45 | |
| *** Guest27464 has quit IRC | 14:46 | |
| *** felipemonteiro__ has quit IRC | 14:46 | |
| dansmith | gibi: the fix for the other test was in the create_port() handler of the fixture, so it was touched by this test and part of your other feedback anyway, | 14:46 |
| dansmith | gibi: so I'll just squash and update this patch | 14:46 |
| gibi | dansmith: OK, cool | 14:46 |
| *** ekhugen has quit IRC | 14:46 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add additional functional tests for NUMA networks https://review.openstack.org/585385 | 14:47 |
| dansmith | gibi: note that just moves it up one test level, not all the way to the top | 14:47 |
| kashyap | mdbooth: Not sure if you'll be able to today, but this is ready and fixed all the tests (including the live migration job): https://review.openstack.org/#/c/567258/ | 14:48 |
| mdbooth | kashyap: ack | 14:48 |
| kashyap | Gentle ping because you've reviewed it before. (And I'm off for 2 weeks from Wed.) | 14:48 |
| kashyap | mdbooth: Thanks! | 14:48 |
| *** slaweq has quit IRC | 14:48 | |
| *** ekhugen has joined #openstack-nova | 14:49 | |
| *** egarbade has joined #openstack-nova | 14:50 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Updated AggregateImagePropertiesIsolation filter illustration https://review.openstack.org/586317 | 14:50 |
| tetsuro_ | gibi: I'm going to rebase https://review.openstack.org/#/c/585672/ on gibi's 1.28 support one. | 14:51 |
| mriedem | lyarwood: looks like a backport to pike is using a method that doesn't even exist :( https://bugs.launchpad.net/nova/+bug/1783635 | 14:52 |
| openstack | Launchpad bug 1783635 in OpenStack Compute (nova) "Live migration failed.: AttributeError: 'Guest' object has no attribute 'migrate_configure_max_speed'" [Undecided,New] | 14:52 |
| tetsuro_ | gibi: Before pushing them, I'm looking into the functional test in https://review.openstack.org/#/c/527728/18 to pass rebased on the two. | 14:52 |
| tetsuro_ | gibi, lajos: Would you mind if I amend https://review.openstack.org/#/c/527728/18? | 14:52 |
| *** shaohe_feng has quit IRC | 14:52 | |
| *** imacdonn has quit IRC | 14:53 | |
| *** imacdonn has joined #openstack-nova | 14:53 | |
| *** shaohe_feng has joined #openstack-nova | 14:53 | |
| mriedem | lyarwood: i guess you figured that out already https://review.openstack.org/#/c/586965/ | 14:54 |
| gibi | tetsuro_: thanks for the heads-up. I have nothing agains the rebase. I talked to lajos before and he let me take over https://review.openstack.org/#/c/527728 so I think I can let you in his name to amend it :) | 14:54 |
| tetsuro_ | gibi: Thanks! | 14:56 |
| gibi | tetsuro_: regarding the rebase the patch adding support for 1.29 top of 1.28. That is also cool with me | 14:56 |
| tetsuro_ | Yup. That would be the right way to go. | 14:56 |
| gibi | tetsuro_: I will try to keep continue progressing support for 1.28 as my time allows during the RC period so we can merge it soon in Stein | 14:56 |
| *** felipemonteiro_ has quit IRC | 14:56 | |
| *** felipemonteiro_ has joined #openstack-nova | 14:57 | |
| *** medberry has quit IRC | 14:57 | |
| tetsuro_ | gibi: Cool. I can help the "change unit tests to pass" part if I finish the rebase and test work earlier than I think. | 14:58 |
| *** jamesdenton has joined #openstack-nova | 14:59 | |
| gibi | tetsuro_: I consider unit test secondary in 1.28 but thanks for any help with those. I'm more affraid of how to add proper functional coverage for the consumer generation conflict cases | 15:00 |
| tetsuro_ | gibi: yup, that sounds tough... | 15:00 |
| mriedem | dansmith: https://review.openstack.org/#/c/586965/ to unbreak live migration in pike | 15:01 |
| gibi | tetsuro_: I have some ideas but until I see them working I'm in doubt | 15:01 |
| *** slaweq has joined #openstack-nova | 15:01 | |
| mriedem | well, live migration + pike + linuxbridge, which we don't test in CI | 15:01 |
| dansmith | mriedem: is this because of that speed limit thing? | 15:02 |
| dansmith | for LB yeah | 15:02 |
| openstackgerrit | Merged openstack/nova master: tox: Reuse envdirs https://review.openstack.org/534382 | 15:02 |
| *** shaohe_feng has quit IRC | 15:02 | |
| *** janki has quit IRC | 15:03 | |
| tetsuro_ | gibi: But as many project (neutron, cyborg, blazar etc) are looking forward the feature we can just continue to work. | 15:03 |
| *** shaohe_feng has joined #openstack-nova | 15:03 | |
| tetsuro_ | gibi: Anyway, I should go to bed now, sorry. Thanks for your info. | 15:03 |
| *** Yan has joined #openstack-nova | 15:03 | |
| gibi | tetsuro_: yeah, not to mention that my work on bandwidth base scheduling also needs it :) | 15:04 |
| gibi | tetsuro_: thanks for the info too. good night! | 15:04 |
| tetsuro_ | gibi: Good day and night! | 15:04 |
| *** tetsuro_ has quit IRC | 15:05 | |
| *** takashin has left #openstack-nova | 15:05 | |
| *** tbachman has quit IRC | 15:08 | |
| *** fanzhang has quit IRC | 15:09 | |
| *** fanzhang has joined #openstack-nova | 15:09 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add unshelve instance error info to fault table https://review.openstack.org/583426 | 15:10 |
| *** shaohe_feng has quit IRC | 15:13 | |
| *** shaohe_feng has joined #openstack-nova | 15:14 | |
| *** skooperit_ has quit IRC | 15:15 | |
| *** tbachman has joined #openstack-nova | 15:16 | |
| *** pcaruana has quit IRC | 15:16 | |
| gibi | dansmith: thanks for the fix in https://review.openstack.org/#/c/585385 I'm +2 now | 15:16 |
| gibi | mriedem: ^^ you were +2 before | 15:17 |
| dansmith | gibi: thanks | 15:17 |
| *** ispp has quit IRC | 15:17 | |
| *** ispp has joined #openstack-nova | 15:19 | |
| *** tssurya has quit IRC | 15:22 | |
| *** yyz_ has quit IRC | 15:22 | |
| *** r-daneel has joined #openstack-nova | 15:23 | |
| *** shaohe_feng has quit IRC | 15:23 | |
| *** vladikr has quit IRC | 15:23 | |
| *** shaohe_feng has joined #openstack-nova | 15:25 | |
| *** gyee has joined #openstack-nova | 15:25 | |
| *** janki has joined #openstack-nova | 15:27 | |
| *** tbachman has quit IRC | 15:29 | |
| *** jchhatbar has joined #openstack-nova | 15:29 | |
| *** janki has quit IRC | 15:30 | |
| *** jchhatbar has quit IRC | 15:30 | |
| *** jchhatbar has joined #openstack-nova | 15:31 | |
| *** dave-mcc_ has joined #openstack-nova | 15:31 | |
| *** tssurya has joined #openstack-nova | 15:33 | |
| *** shaohe_feng has quit IRC | 15:33 | |
| *** dave-mccowan has quit IRC | 15:33 | |
| *** shaohe_feng has joined #openstack-nova | 15:34 | |
| *** tbachman has joined #openstack-nova | 15:34 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Add unshelve instance error info to fault table https://review.openstack.org/583422 | 15:35 |
| *** awaugama has quit IRC | 15:35 | |
| *** dave-mccowan has joined #openstack-nova | 15:35 | |
| *** vladikr has joined #openstack-nova | 15:36 | |
| *** dtantsur|brb is now known as dtantsur | 15:37 | |
| *** abhishekk has joined #openstack-nova | 15:37 | |
| *** dave-mcc_ has quit IRC | 15:38 | |
| *** dtruong_ has quit IRC | 15:39 | |
| *** shaohe_feng has quit IRC | 15:43 | |
| *** shaohe_feng has joined #openstack-nova | 15:45 | |
| *** Deepak has joined #openstack-nova | 15:45 | |
| *** tssurya has quit IRC | 15:49 | |
| *** tesseract has quit IRC | 15:49 | |
| *** ispp has quit IRC | 15:51 | |
| *** itlinux has joined #openstack-nova | 15:51 | |
| *** itlinux has quit IRC | 15:51 | |
| *** aarents1 is now known as aarents | 15:52 | |
| *** Bhujay has quit IRC | 15:53 | |
| *** shaohe_feng has quit IRC | 15:54 | |
| *** shaohe_feng has joined #openstack-nova | 15:55 | |
| *** psachin`` has quit IRC | 15:56 | |
| *** vladikr has quit IRC | 16:01 | |
| *** ircuser-1 has joined #openstack-nova | 16:03 | |
| *** shaohe_feng has quit IRC | 16:04 | |
| *** shaohe_feng has joined #openstack-nova | 16:05 | |
| *** yyz_ has joined #openstack-nova | 16:05 | |
| *** Sundar has joined #openstack-nova | 16:09 | |
| *** itlinux has joined #openstack-nova | 16:10 | |
| mnaser | well i sure don't run out of ways to find how broken this was :( | 16:11 |
| *** itlinux has quit IRC | 16:12 | |
| mnaser | instances is shown when listing instances (with ACTIVE state), getting the specific instance (nova show/delete/etc) gives 404, instance_mapping exists, it exists in instances table in the appropriate cell | 16:12 |
| *** itlinux has joined #openstack-nova | 16:12 | |
| mnaser | and no build request | 16:12 |
| mnaser | so things.. should be right? | 16:12 |
| *** shaohe_feng has quit IRC | 16:14 | |
| *** vladikr has joined #openstack-nova | 16:14 | |
| *** shaohe_feng has joined #openstack-nova | 16:15 | |
| Guest9714 | mnaser: instance_mapping with cell_id=None? | 16:15 |
| *** Guest9714 is now known as melwitt | 16:15 | |
| mnaser | melwitt: nope, it has an assigned cell_id | 16:16 |
| mnaser | and it exists in the assigned cell too | 16:16 |
| melwitt | but a 404 during delete? hm | 16:16 |
| mnaser | even 404 during get or anything | 16:16 |
| melwitt | yeah, that's unexpected | 16:16 |
| melwitt | (and wrong) | 16:17 |
| mnaser | i restarted the nova apis... thought maybe it was cache but it wasnt | 16:17 |
| mnaser | i mean afaik this should work .. https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2353-L2357 | 16:17 |
| *** mlavalle has quit IRC | 16:18 | |
| *** ttsiouts has quit IRC | 16:18 | |
| *** Deepak has quit IRC | 16:18 | |
| mriedem | mnaser: if the instance mapping failed to update the record with the cell mapping we are going to fail to target the instance in any cell, | 16:18 |
| mriedem | since we do'nt know which cell since the instance mapping is busted | 16:18 |
| mnaser | mriedem: but i manaully updated the instance_mapping in my cleanup, so the cell_id is correct in instance_mapping | 16:19 |
| melwitt | he said the instance mapping has a cell_id assigned | 16:19 |
| mriedem | what's the stacktrace on the 404 then? | 16:19 |
| mriedem | or i suppose there isn't one | 16:19 |
| mnaser | none, just an instance not found | 16:19 |
| *** mvk_ has quit IRC | 16:19 | |
| *** itlinux_ has joined #openstack-nova | 16:19 | |
| *** Sundar has quit IRC | 16:20 | |
| mnaser | mriedem: http://paste.openstack.org/show/726855/ | 16:20 |
| *** itlinux has quit IRC | 16:20 | |
| mnaser | and cell_id=5 is the one that uses 'nova' db | 16:20 |
| mriedem | and you're sure you don't have any services table entries with nova-osapi_compute that are <15/ | 16:22 |
| mriedem | ? | 16:22 |
| *** mlavalle has joined #openstack-nova | 16:22 | |
| *** Sundar has joined #openstack-nova | 16:23 | |
| mriedem | it would be looking in whatever [database]/connection database you're running for the nova.conf in the nova-api service | 16:23 |
| mriedem | so presumably cell0 | 16:23 |
| Sundar | efried: Please ping me when you have the time. I am open for the next half hour. | 16:23 |
| efried | Sundar: I'm here. Shall we talk in -cyborg? | 16:24 |
| mriedem | note that min service version *is* cached | 16:24 |
| Sundar | Sure | 16:24 |
| *** shaohe_feng has quit IRC | 16:24 | |
| mnaser | mriedem: http://paste.openstack.org/show/726857/ | 16:25 |
| mnaser | i'm pretty sure :X | 16:25 |
| mnaser | there are deleted service records < 15 | 16:25 |
| *** ccamacho has quit IRC | 16:26 | |
| mnaser | interesting | 16:26 |
| mriedem | mnaser: what db is your api config using? | 16:26 |
| mriedem | nova_cell0? | 16:26 |
| mnaser | nova_api | 16:26 |
| mriedem | no, | 16:26 |
| mriedem | [database]/connection | 16:26 |
| mnaser | nova | 16:27 |
| mnaser | also i did a log.error(instance_uuid inst_map) | 16:27 |
| mnaser | 729b5fb6-064c-4db4-b448-e01f5bc3d789: InstanceMapping(cell_mapping=CellMapping(e16503e7-b7dc-4f70-8c3e-87653c01481a),created_at=2018-07-30T15:31:56Z,id=8553936,instance_uuid=729b5fb6-064c-4db4-b448-e01f5bc3d789,project_id='55e74b674f714b869d14eb40ca004eb4',updated_at=2018-07-30T15:31:57Z) | 16:27 |
| mnaser | so it actually gets it | 16:27 |
| mnaser | adding a LOG.debug(instance) in the follow up | 16:28 |
| *** Sundar has quit IRC | 16:29 | |
| *** shaohe_feng has joined #openstack-nova | 16:29 | |
| *** mlavalle has quit IRC | 16:29 | |
| *** savvas has quit IRC | 16:30 | |
| *** savvas has joined #openstack-nova | 16:30 | |
| mnaser | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2355 | 16:30 |
| mnaser | it reaches here | 16:30 |
| *** AlexeyAbashkin has quit IRC | 16:30 | |
| *** mdnadeem_ has quit IRC | 16:31 | |
| mnaser | but then `objects.Instance.get_by_uuid` raises the exception i think | 16:31 |
| mriedem | and you should see get_or_set_cached_cell_and_set_connections in the logs for the lock | 16:31 |
| mriedem | and it will log the cell mapping uuid | 16:31 |
| *** felipemonteiro__ has joined #openstack-nova | 16:31 | |
| mriedem | at debug i mean | 16:31 |
| mnaser | well, I aded a LOG.error(inst_map.cell_mapping) and i see the cell mapping there on the request | 16:31 |
| mnaser | so i guess objects.Instance.get_by_uuid is raising some exception | 16:32 |
| mnaser | also | 16:32 |
| mriedem | can you also log the context.db_connection right before Instance.get_by_uuid? | 16:32 |
| mnaser | sure | 16:32 |
| mnaser | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2398-L2400 | 16:32 |
| mnaser | i think this is dead code | 16:32 |
| mriedem | it won't be a string, but needs to be not None | 16:32 |
| melwitt | usually, the only exception there would be InstanceNotFound but if deleted != 0 you wouldn't see it in 'nova list' either | 16:33 |
| mriedem | mnaser: "# NOTE(ameade): we still need to support integer ids for ec2" | 16:33 |
| *** felipemonteiro_ has quit IRC | 16:33 | |
| *** priteau has joined #openstack-nova | 16:33 | |
| mnaser | well the exception handles InvalidID | 16:33 |
| mnaser | but if uuidutils.is_uuid_like is raises that then you never end up in else: | 16:33 |
| mnaser | and if it doesn't, then InvalidID might never be raised | 16:34 |
| mnaser | but idk, it just seems a bit weird but anyways | 16:34 |
| mnaser | let me check context.db_connection | 16:34 |
| *** savvas has quit IRC | 16:34 | |
| *** shaohe_feng has quit IRC | 16:35 | |
| mnaser | mriedem: <oslo_db.sqlalchemy.enginefacade._TransactionContextManager object at 0x955e450> | 16:35 |
| *** shaohe_feng has joined #openstack-nova | 16:35 | |
| mriedem | ok | 16:35 |
| mnaser | i mean i could try to remember how to make sqlalchemy log sql queries | 16:35 |
| mnaser | i remember i did that at some point | 16:36 |
| *** s10 has quit IRC | 16:36 | |
| mriedem | mnaser: it's either https://docs.openstack.org/nova/latest/configuration/config.html#database.connection_debug or https://docs.openstack.org/nova/latest/configuration/config.html#database.connection_trace i think | 16:37 |
| mriedem | oh you know what... | 16:38 |
| mriedem | i bet i know what this is | 16:38 |
| mriedem | lazy-join on a deleted compute service by the instance record | 16:38 |
| mriedem | it's not the instance record that's the problem | 16:38 |
| mriedem | it's a related deleted service record that we can't load | 16:38 |
| mriedem | melwitt: remember that^ ? | 16:38 |
| *** savvas has joined #openstack-nova | 16:38 | |
| mriedem | mnaser: i'd query the db that the instance is for all nova-compute services with the same name as the instance.host | 16:39 |
| mriedem | are any of those deleted? | 16:39 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Use oslotest CaptureOutput fixture https://review.openstack.org/587129 | 16:39 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Use a non-nova log capture fixture https://review.openstack.org/587130 | 16:39 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Use a simplified WarningsFixture https://review.openstack.org/587131 | 16:39 |
| mriedem | it could be trying to set a uuid on a deleted service record | 16:39 |
| melwitt | yeah... thinking. the one I've got a patch up for is around generating a uuid for a deleted service record | 16:39 |
| mriedem | but that was with listing i thought, not sohw | 16:40 |
| mriedem | *show | 16:40 |
| *** mlavalle has joined #openstack-nova | 16:40 | |
| mriedem | mnaser: i'd probably put a try/except around that Instance.get_by_uuid to handle InstanceNotFound, LOG.exception and re-raise | 16:40 |
| mriedem | mnaser: to figure out where the InstanceNotFound originates from | 16:40 |
| *** sean-k-mooney has quit IRC | 16:41 | |
| melwitt | yeah, according to the bugs, that would raise ServiceNotFound or ServiceTooOld for listing | 16:41 |
| *** savvas has quit IRC | 16:43 | |
| *** udesale has quit IRC | 16:43 | |
| *** priteau has quit IRC | 16:44 | |
| *** yamahata has quit IRC | 16:45 | |
| *** shaohe_feng has quit IRC | 16:45 | |
| *** shaohe_feng has joined #openstack-nova | 16:46 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove superfluous network stubbing in func test https://review.openstack.org/587134 | 16:46 |
| anupn | Hi Folks, I have deployed an instance on ironic node, but that instance is unable to ping to the external network. Can you please suggest what things should I check for? my br-ex has got an external IP, and I can ping the internet from the host but not from the vm. | 16:49 |
| melwitt | anupn: hi, this is a development channel, not a support channel. pls see topic | 16:51 |
| anupn | melwitt: Ah ok! Will ask in the other channel | 16:52 |
| *** sean-k-mooney has joined #openstack-nova | 16:55 | |
| *** shaohe_feng has quit IRC | 16:55 | |
| *** savvas has joined #openstack-nova | 16:55 | |
| *** shaohe_feng has joined #openstack-nova | 16:57 | |
| *** idlemind has joined #openstack-nova | 16:58 | |
| mnaser | sorry, in a call, ill catch up on buffer in a sec | 16:59 |
| *** savvas has quit IRC | 17:00 | |
| *** derekh has quit IRC | 17:01 | |
| *** priteau has joined #openstack-nova | 17:02 | |
| *** savvas has joined #openstack-nova | 17:05 | |
| *** shaohe_feng has quit IRC | 17:05 | |
| *** shaohe_feng has joined #openstack-nova | 17:07 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Set default of oslo.privsep.daemon logging to INFO level https://review.openstack.org/586643 | 17:07 |
| *** sambetts is now known as sambetts|afk | 17:08 | |
| *** jpena is now known as jpena|off | 17:10 | |
| *** awaugama has joined #openstack-nova | 17:11 | |
| *** felipemonteiro_ has joined #openstack-nova | 17:12 | |
| *** felipemonteiro__ has quit IRC | 17:12 | |
| mnaser | ill do the try/raise, the service is actually existing | 17:13 |
| *** shaohe_feng has quit IRC | 17:16 | |
| *** shaohe_feng has joined #openstack-nova | 17:17 | |
| *** yamahata has joined #openstack-nova | 17:18 | |
| mnaser | http://paste.openstack.org/show/726864/ | 17:22 |
| mnaser | i feel like i need to take a step back and something weird is happening | 17:23 |
| openstackgerrit | Chris Dent proposed openstack/nova master: DNM: Explore limiting resource tracker update https://review.openstack.org/587050 | 17:23 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Extract _update_to_placement method in resource tracker https://review.openstack.org/587171 | 17:23 |
| *** tbachman has quit IRC | 17:24 | |
| melwitt | mnaser: so the deleted column for that instance != 0? I don't get how it's showing up in 'nova list' then | 17:25 |
| *** shaohe_feng has quit IRC | 17:26 | |
| *** shaohe_feng has joined #openstack-nova | 17:27 | |
| * mnaser has to hop on a call but will get back to this soon | 17:30 | |
| *** savvas has quit IRC | 17:31 | |
| *** savvas has joined #openstack-nova | 17:31 | |
| mnaser | melwitt: also btw i did some work here on trying to make it a single transaction (with a parent fix trying to be a less major change) -- https://review.openstack.org/#/c/586742/ if you have time to look at it | 17:31 |
| *** flwang1 has joined #openstack-nova | 17:31 | |
| melwitt | mnaser: will take a look, thanks | 17:31 |
| *** shaohe_feng has quit IRC | 17:36 | |
| *** shaohe_feng has joined #openstack-nova | 17:37 | |
| openstackgerrit | Merged openstack/nova stable/pike: libvirt: add method to configure migration speed https://review.openstack.org/586965 | 17:39 |
| *** shaohe_feng has quit IRC | 17:46 | |
| *** shaohe_feng has joined #openstack-nova | 17:48 | |
| *** s10 has joined #openstack-nova | 17:50 | |
| *** lpetrut has quit IRC | 17:52 | |
| openstackgerrit | Merged openstack/nova stable/pike: Make host_aggregate_map dictionary case-insensitive https://review.openstack.org/585335 | 17:54 |
| openstackgerrit | Merged openstack/nova stable/pike: Fix unbound local when saving an unchanged RequestSpec https://review.openstack.org/580951 | 17:54 |
| openstackgerrit | Merged openstack/nova stable/queens: Refactor _build_device_metadata https://review.openstack.org/581398 | 17:54 |
| openstackgerrit | Merged openstack/nova stable/queens: Consider hostdev devices when building metadata https://review.openstack.org/581399 | 17:55 |
| openstackgerrit | Merged openstack/nova master: Add additional functional tests for NUMA networks https://review.openstack.org/585385 | 17:55 |
| *** felipemonteiro__ has joined #openstack-nova | 17:55 | |
| *** shaohe_feng has quit IRC | 17:57 | |
| *** shaohe_feng has joined #openstack-nova | 17:57 | |
| *** felipemonteiro_ has quit IRC | 17:59 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Use of set_middleware_defaults https://review.openstack.org/587183 | 17:59 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Use own set_middleware_defaults https://review.openstack.org/587183 | 18:00 |
| *** jmlowe_ has joined #openstack-nova | 18:01 | |
| *** bigdogstl has joined #openstack-nova | 18:02 | |
| *** jmlowe has quit IRC | 18:03 | |
| *** savvas has quit IRC | 18:05 | |
| *** shaohe_feng has quit IRC | 18:07 | |
| *** cdent has quit IRC | 18:09 | |
| *** cdent has joined #openstack-nova | 18:09 | |
| *** shaohe_feng has joined #openstack-nova | 18:10 | |
| *** shaohe_feng has quit IRC | 18:17 | |
| *** shaohe_feng has joined #openstack-nova | 18:18 | |
| *** bigdogstl has quit IRC | 18:19 | |
| *** purplerbot has quit IRC | 18:27 | |
| *** bigdogstl has joined #openstack-nova | 18:27 | |
| *** shaohe_feng has quit IRC | 18:27 | |
| *** purplerbot has joined #openstack-nova | 18:28 | |
| *** shaohe_feng has joined #openstack-nova | 18:28 | |
| *** bigdogstl has quit IRC | 18:28 | |
| *** dtantsur is now known as dtantsur|afk | 18:31 | |
| efried | Hey folks, we're back with https://bugs.launchpad.net/nova/+bug/1737711 | 18:32 |
| openstack | Launchpad bug 1737711 in OpenStack Compute (nova) "nova boot failed when use the chinese metadata key and value" [Undecided,In progress] - Assigned to huanhongda (hongda) | 18:32 |
| efried | They've restricted the patch https://review.openstack.org/#/c/536236/ to just metadata keys (not extra_specs keys anymore). | 18:32 |
| efried | The bug still doesn't give a whole lot of detail as to the use case for this, but maybe it makes more sense to y'all, dansmith mriedem jaypipes | 18:34 |
| *** tbachman has joined #openstack-nova | 18:34 | |
| *** tbachman has quit IRC | 18:35 | |
| *** shaohe_feng has quit IRC | 18:38 | |
| melwitt | efried: fwiw, my initial read on that is we have more than one place where unicode keys won't work (as you mentioned extra_specs is another one) and IMHO it feels like it would be a small spec to propose to change all of them together in a consistent way to support unicode | 18:38 |
| melwitt | is the schema validation really the only thing preventing unicode from working? | 18:38 |
| efried | melwitt: Good question. No idea if they've tried... whatever it is they wanted to try, with their fix in place. | 18:39 |
| *** shaohe_feng has joined #openstack-nova | 18:39 | |
| efried | melwitt: Anyway, my position on this is that I don't have the background to be able to make a compelling argument to shut down the bug, or ask for it to be converted to a bp, or whatever. I need cavalry support (that would be you). | 18:39 |
| jaypipes | efried: I'm curious why the patch includes a change to add maxLength: 255 | 18:40 |
| efried | jaypipes: Yeah, that's redundant (already covered by the regex), but not really important to the question of whether we should do it at all... | 18:41 |
| *** savvas has joined #openstack-nova | 18:41 | |
| efried | jaypipes: I added a comment for ya :) | 18:42 |
| jaypipes | efried: right, but AFAICT, the regex doesn't change. | 18:42 |
| mriedem | stephenfin: where does the libvirt driver actually translate hw_cpu_policy and hw_cpu_thread_policy into something that goes in the guest xml? | 18:42 |
| efried | jaypipes: Right, that part of the delta is them making sure the extra_specs pattern does *not* change. | 18:42 |
| mriedem | stephenfin: _get_guest_cpu_config ? | 18:43 |
| *** jmlowe_ has quit IRC | 18:43 | |
| efried | jaypipes: Actually, they've correctly carried over the redundant maxLength from the metadata key pattern... | 18:44 |
| openstackgerrit | karim proposed openstack/nova master: Updated AggregateImagePropertiesIsolation filter illustration https://review.openstack.org/586317 | 18:44 |
| *** jmlowe has joined #openstack-nova | 18:44 | |
| efried | jaypipes: I suppose if you were being really particular, you could say they did the right thing, because you could get back a different schema error. | 18:44 |
| efried | jaypipes: But it's not about whether the patch is correct (it clearly isn't quite, yet). It's about whether we should allow it at all. Or if we do, if it needs to have microversion paperwork, a bp, a spec, etc. | 18:46 |
| melwitt | efried: understood. at the very least I'd think we'd want tempest tests to cover unicode metadata key cases to verify it for now and keep it working in the future. and I'd think we'd want to change all of the user-settable keys to support unicode at the same time (rather than pick only one). and that's a bigger change and one I'd expect to have a spec about that explains all of the changes needed to properly support unicode in keys | 18:47 |
| dansmith | and tests to cover metadata server and configdrive, amirite? | 18:47 |
| melwitt | that's just my opinion. any other opinions? | 18:47 |
| dansmith | personally I do not think unicode is worth the change to this, no surprises there | 18:47 |
| efried | you anglocentric, you | 18:48 |
| *** shaohe_feng has quit IRC | 18:48 | |
| mriedem | i wouldn't ask me, i'd ask alex_xu, ken'ichi, takashi and Kevin_Zheng | 18:49 |
| mriedem | i asked kevin long ago if huawei had any need for unicode in flavor extra specs and i believe he said no | 18:49 |
| mriedem | passing unicode metadata values through to the guest is probably an easier case to make | 18:49 |
| *** savvas has quit IRC | 18:49 | |
| melwitt | I didn't mean opinions on the validity of the change, just whether it would need a spec and review | 18:49 |
| dansmith | resources:<pileofpoo>=1 | 18:49 |
| *** savvas has joined #openstack-nova | 18:49 | |
| *** bigdogstl has joined #openstack-nova | 18:49 | |
| *** shaohe_feng has joined #openstack-nova | 18:50 | |
| mriedem | normal microversion behavior state diagram says that if i can make a request to cloud A and it works and make the same request to cloud B and it doesn't work, w/o microversions, it should probably be versioned - unless it's just a bug / something broken in existing support | 18:50 |
| mriedem | but this has never worked as far as i know | 18:51 |
| mriedem | so it's not a bug/regression, it's an RFE | 18:51 |
| dansmith | what do you do for keys that are unicode if retrieved from an older microversion? | 18:51 |
| dansmith | detect if they have unicode and exclude them? | 18:51 |
| mriedem | i thought you couldn't do that b/c of the existing schema? | 18:51 |
| mriedem | oh you mean, | 18:52 |
| efried | hypothetically if this change was made, even with a microversion | 18:52 |
| mriedem | set with unicode on newer microversion, retrieve with older microversion? | 18:52 |
| dansmith | mriedem: yeah | 18:52 |
| mriedem | dansmith: idk, detecting that would suck | 18:52 |
| dansmith | mriedem: yup | 18:52 |
| jaypipes | efried: I asked a question on the patch. | 18:52 |
| dansmith | mriedem: and be super confusing for people | 18:52 |
| mriedem | this is generally why we have specs for api behavior changes.... :) | 18:53 |
| dansmith | ahyup | 18:53 |
| efried | jaypipes: In the discussion from a few weeks ago (linked in the bug report) we talked about it not being a good idea for extra specs. I think it was in reaction to that that they reverted that part. | 18:53 |
| jaypipes | although I do like dansmith's pile of poo resource. | 18:53 |
| dansmith | jaypipes: one pile of poo please, affined to numa node #2 | 18:53 |
| jaypipes | side of fries with that, dansmith? | 18:54 |
| dansmith | jaypipes: only after some hand sanitizer | 18:54 |
| jaypipes | :) | 18:54 |
| efried | affinitizations for 914 points | 18:54 |
| *** bigdogstl has quit IRC | 18:54 | |
| sean-k-mooney | mriedem: does the api activly reject unicode? | 18:55 |
| efried | sean-k-mooney: We're talking about in metadata/extra_specs keys, where the schema is patters | 18:55 |
| efried | pattern-limited to ascii. | 18:55 |
| efried | so yeah | 18:55 |
| melwitt | efried: I'm going to comment on the patch | 18:56 |
| efried | melwitt: Okay, I was about to update the bug. | 18:56 |
| sean-k-mooney | efried: oh ok i was going to say we dont mandate a coralation type for the db so someone could have created a db with utf-8 set and would be able to store it | 18:56 |
| mriedem | sean-k-mooney: can you answer this question to stephen? "where does the libvirt driver actually translate hw_cpu_policy and hw_cpu_thread_policy into something that goes in the guest xml?" | 18:56 |
| melwitt | efried: feel free to do that | 18:57 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Use oslotest CaptureOutput fixture https://review.openstack.org/587129 | 18:57 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Use a non-nova log capture fixture https://review.openstack.org/587130 | 18:57 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Use a simplified WarningsFixture https://review.openstack.org/587131 | 18:57 |
| efried | melwitt: Procedurally, if we've deemed this to need a bp/spec, do I set the bug to Won't Fix? | 18:57 |
| mriedem | i don't think so, it would be a wishlist bug | 18:57 |
| mriedem | invalid -> wishlist or something | 18:58 |
| sean-k-mooney | mriedem: let me see if i can find it. i can i can give you the relevent xml snipit it generates | 18:58 |
| efried | ight | 18:58 |
| mriedem | all i mostly see is the giant hardware.py methods, | 18:58 |
| *** shaohe_feng has quit IRC | 18:58 | |
| mriedem | but can't link those up to where it's used by a driver | 18:58 |
| mriedem | maybe it's not directly set in the guest xml? maybe it's just used to determine which cpus to pin? | 18:59 |
| *** shaohe_feng has joined #openstack-nova | 18:59 | |
| sean-k-mooney | mriedem: its burried in the numa code | 19:00 |
| sean-k-mooney | mriedem: yes it just used to determin the pinning | 19:00 |
| efried | melwitt, mriedem: Do we have a helpful contributor link to the bp/spec process? | 19:00 |
| mriedem | yes | 19:00 |
| sean-k-mooney | it never gets into the xml itself | 19:00 |
| mriedem | https://docs.openstack.org/nova/latest/contributor/blueprints.html | 19:00 |
| mriedem | sean-k-mooney: ok then, that answers that, thanks | 19:00 |
| efried | ack | 19:01 |
| sean-k-mooney | mriedem: bassicaly we generate teh pinning here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4471-L4480 | 19:02 |
| *** awaugama_ has joined #openstack-nova | 19:02 | |
| *** yyz_ has quit IRC | 19:04 | |
| *** awaugama has quit IRC | 19:05 | |
| *** flwang1 has quit IRC | 19:05 | |
| *** MultipleCrashes has joined #openstack-nova | 19:06 | |
| MultipleCrashes | Anyone free to take up this review further : https://review.openstack.org/#/c/563418/ | 19:07 |
| *** tbachman has joined #openstack-nova | 19:08 | |
| *** shaohe_feng has quit IRC | 19:08 | |
| *** tbachman has quit IRC | 19:09 | |
| *** bigdogstl has joined #openstack-nova | 19:10 | |
| *** shaohe_feng has joined #openstack-nova | 19:12 | |
| *** cdent has quit IRC | 19:14 | |
| *** bigdogstl has quit IRC | 19:14 | |
| *** tbachman has joined #openstack-nova | 19:15 | |
| *** shaohe_feng has quit IRC | 19:19 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Updated AggregateImagePropertiesIsolation filter illustration https://review.openstack.org/586317 | 19:21 |
| *** shaohe_feng has joined #openstack-nova | 19:21 | |
| *** liuyulong has quit IRC | 19:22 | |
| *** liuyulong has joined #openstack-nova | 19:22 | |
| openstackgerrit | karim proposed openstack/nova master: Updated AggregateImagePropertiesIsolation filter illustration https://review.openstack.org/586317 | 19:25 |
| melwitt | MultipleCrashes: are you asking for review or help with updating the patch or both? | 19:26 |
| MultipleCrashes | I am new to it, in my knowledge we need a +2 for a merge ..mostly looking for a possibility of merge | 19:28 |
| *** shaohe_feng has quit IRC | 19:29 | |
| sean-k-mooney | MultipleCrashes: just looking at the bug you are getting a keysonte error form calling neutronport delete in a bulk delete of nova instnaces. | 19:30 |
| sean-k-mooney | this almost looks like we are ddosing the neuron api with too many requests at once | 19:31 |
| *** bigdogstl has joined #openstack-nova | 19:31 | |
| *** jmlowe has quit IRC | 19:31 | |
| *** antosh has quit IRC | 19:31 | |
| sean-k-mooney | retry is certenly one want to solve it but perhaps we should be ratelimiting | 19:31 |
| *** antosh has joined #openstack-nova | 19:32 | |
| *** shaohe_feng has joined #openstack-nova | 19:32 | |
| MultipleCrashes | yeah , apparently this happens when too many instances are simultaneously deleted , if we try a rate limiting there is possibility that the task of deleting the VMs might get interrupted. | 19:33 |
| MultipleCrashes | Eg:lets say we are deleting 1000 instances and the problem occurs at 550th (say) instance | 19:33 |
| *** awaugama_ has quit IRC | 19:34 | |
| MultipleCrashes | we would still like to continue the process, probably rate limit might stop further execution | 19:34 |
| melwitt | MultipleCrashes: the last comment on the review suggests a change to avoid logging error per retry and instead log info for the retry and then if all retries have failed, log error. otherwise the operator gets a false log error if one of the retries succeeds | 19:34 |
| melwitt | and by false I mean, operators consider "error" to mean action should be taken | 19:35 |
| *** bigdogstl has quit IRC | 19:35 | |
| sean-k-mooney | MultipleCrashes: well the error is stemming from data = neutron.list_ports(**search_opts). so in your case we would be doing 1000 concurrent requets to netron to list the ports for the 1000 instnaces. | 19:36 |
| MultipleCrashes | yeah, since with the retries we would also be having instance ids, so we would be able to figure out that the retires are being done for this particular intance | 19:36 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix formatting for vcpu_pin_set and reserved_huge_pages https://review.openstack.org/587206 | 19:37 |
| sean-k-mooney | melwitt: we have a rate limit for creatign new instaces. do you know is there an equivalent for delete? | 19:37 |
| MultipleCrashes | the deletion of instances would happen one-at-a-time and hence, only the retry will be for that particular instance. | 19:37 |
| dansmith | we don't have rate limiting for any API methods anymore, that I know of | 19:38 |
| sean-k-mooney | MultipleCrashes: im not sure about that. i would expect the api/conductor to call down to the compute nodes to do the delete and for those deleteions to work in paralle but i have not looked at that code path. | 19:39 |
| *** shaohe_feng has quit IRC | 19:39 | |
| sean-k-mooney | dansmith: well this would not be an api ratelimit it would be a limit in the conductor i guess | 19:39 |
| dansmith | sean-k-mooney: MultipleCrashes means we have no bulk delete api call | 19:39 |
| mriedem | nova-api does an rpc cast to the compute that is hosting the instance | 19:39 |
| dansmith | sean-k-mooney: so of course, all of them happen in parallel | 19:40 |
| dansmith | sean-k-mooney: we have no rate limits in conductor either | 19:40 |
| *** shaohe_feng has joined #openstack-nova | 19:40 | |
| dansmith | sean-k-mooney: we have the build and migrate counters in compute, but those aren't per-tenant | 19:40 |
| dansmith | but definitely don't have any such limits on delete | 19:40 |
| sean-k-mooney | dansmith: oh ok then ya i guess retry is the best we can currently do then. | 19:40 |
| MultipleCrashes | yeah, mostly is done via autoscale feature | 19:41 |
| MultipleCrashes | while scaling down | 19:41 |
| melwitt | MultipleCrashes: the suggestion isn't to use instance ids to figure out whether it's a retry. the suggestion is to move the retry decorator to the inner method _deallocate_network, so that the log error in _try_deallocate_network won't happen each retry attempt | 19:41 |
| MultipleCrashes | yeah, moving to _deallocate_network would mean we will have to save_and_reraise exception in that function | 19:42 |
| mriedem | "otherwise the operator gets a false log error if one of the retries succeeds" is definitely annoying and a red herring when you're actually trying to debug something, | 19:42 |
| MultipleCrashes | as we are doing retry based on exception which we are handling in _try_deallocate_network | 19:42 |
| mriedem | i know there is a persistent case of that in cinder-volume during volume delete i think which always throws me off | 19:42 |
| *** antosh has quit IRC | 19:43 | |
| mriedem | because it logs an error, then retries and succeeds | 19:43 |
| MultipleCrashes | this seems to be an intermittent issue, once in many time..possibly caused by transient network connectivity problem. | 19:44 |
| melwitt | MultipleCrashes: why? won't the RetryDecorator catch the ConnectFailure and retry and once retries expire it will propagate ConnectFailure up to _try_deallocate_network? | 19:45 |
| sean-k-mooney | MultipleCrashes: it could be connectivity but its more likely that its due to the number of neutron api calls. | 19:46 |
| mriedem | i thought at one point the bug said it was a keystone issue? | 19:46 |
| sean-k-mooney | mriedem: its a keysone connection failure on list port | 19:47 |
| mriedem | does it re-use the same token to delete all 1000 instances and the token times out? | 19:47 |
| sean-k-mooney | mriedem: i cant tell form "ConnectFailure: Unable to establish connection to http:/somehost:someport/v2.0/ports.json?device_id=someid" | 19:48 |
| MultipleCrashes | yeah , tried the way with _deallocate_network RetryDecorator .. doesn't function properly.Yeah agree neutron load via no of api calls could be a likely reason | 19:48 |
| sean-k-mooney | mriedem: the error is propagating form the keystone auth session _send_request method but i dont think its a keysone issue | 19:49 |
| *** shaohe_feng has quit IRC | 19:49 | |
| melwitt | MultipleCrashes: ok, it would be helpful to reply to the review comment and let the reviewer know why their suggestion doesn't work. fwiw, I thought it would have worked too | 19:50 |
| *** shaohe_feng has joined #openstack-nova | 19:50 | |
| melwitt | oh, my mistake, I guess the suggestion does say to add log info and reraise | 19:51 |
| *** bigdogstl has joined #openstack-nova | 19:51 | |
| melwitt | in the inner method. what I said, it wouldn't be possible to log the info part to say "retrying" | 19:52 |
| *** tbachman has quit IRC | 19:52 | |
| *** tbachman has joined #openstack-nova | 19:52 | |
| melwitt | it would be better to log the "retrying ..." so operators can know if they have retries going on for the network deallocation | 19:53 |
| sean-k-mooney | dansmith: ya the compute node max_concurrent_builds config option is the one i was thinking of originally but i had tought that was in the conductor. i guess not. | 19:54 |
| * sean-k-mooney note to self setting max_concurrent_builds=100 is likely excessive... | 19:55 | |
| *** bigdogstl has quit IRC | 19:55 | |
| *** cdent has joined #openstack-nova | 19:57 | |
| sean-k-mooney | melwitt: mriedem by the way do we care about https://review.openstack.org/#/c/584999/ for rocky or will i loop back to it in stien? | 19:59 |
| *** shaohe_feng has quit IRC | 20:00 | |
| mriedem | sean-k-mooney: i can -1 it for any release based on the commit message if you want | 20:00 |
| *** abhishekk has quit IRC | 20:00 | |
| *** shaohe_feng has joined #openstack-nova | 20:00 | |
| sean-k-mooney | hehe well if you want any changes please do | 20:00 |
| mriedem | done | 20:01 |
| melwitt | sean-k-mooney: bugs can be fixed any time so you don't need to target it to a specific release. that said, I agree the commit message doesn't explain anything about what's wrong or how/why the patch fixes it | 20:01 |
| mriedem | sean-k-mooney: max_concurrent_builds defaults to 10 | 20:01 |
| mriedem | not 100 | 20:01 |
| sean-k-mooney | mriedem: i know i used to think it wa for the conductor so used to locally set it to 100 | 20:02 |
| sean-k-mooney | since its for compute that is excessive | 20:02 |
| sean-k-mooney | melwitt: yes ture it does not. i have a detailed summay in the bug. ill copy the relevent bit into the commit | 20:03 |
| melwitt | sounds good | 20:03 |
| MultipleCrashes | looks like getting state of the retry count would be tricky, as it comes from within the RetryDecorator | 20:03 |
| MultipleCrashes | for logging | 20:03 |
| melwitt | MultipleCrashes: we don't need the retry count. the suggestion was just to LOG.info('Network allocation failed, retrying') so that the fact that it was retried is captured | 20:04 |
| melwitt | for the benefit of operators | 20:04 |
| melwitt | it's totally fine to add a save and reraise exception in _deallocate_network | 20:05 |
| *** vladikr has quit IRC | 20:05 | |
| mriedem | rather than monkey with _deallocate_network directly, just put the call to that in an inner method | 20:06 |
| melwitt | that works too | 20:07 |
| MultipleCrashes | yeah, that handler is a generic exception handler there..we would be retrying only in case we get this specific exception of ConnectFailure | 20:07 |
| *** savvas has quit IRC | 20:08 | |
| *** vladikr has joined #openstack-nova | 20:08 | |
| MultipleCrashes | so logging in there for 'retrying' would bring a log line even if we have a generic exception | 20:09 |
| mriedem | i left a comment | 20:09 |
| melwitt | in the inner method you catch ConnectFailure only and reraise that, right? | 20:09 |
| mriedem | the RetryDecorator itself will log at debug | 20:09 |
| mriedem | https://github.com/openstack/oslo.service/blob/master/oslo_service/loopingcall.py#L453 | 20:10 |
| *** shaohe_feng has quit IRC | 20:10 | |
| mriedem | so it should be easy to do what i added in the review comment | 20:10 |
| mriedem | so we only get 1 ERROR log if everything fails including the retries timing out | 20:10 |
| mriedem | i don't think we need additional extra log messages b/c the decorator itself does that | 20:11 |
| *** shaohe_feng has joined #openstack-nova | 20:11 | |
| melwitt | I think INFO was suggested since most operators run at INFO log level | 20:11 |
| mriedem | i wouldn't consider this INFO | 20:11 |
| melwitt | you won't know your deallocations are retrying unless you enable debug | 20:11 |
| mriedem | do you need to know that | 20:11 |
| mriedem | ? | 20:11 |
| mriedem | unless you're hitting failures | 20:11 |
| mriedem | and if you're hitting failures, you're probably gonna enable debug on compute | 20:11 |
| melwitt | based on what sean-k-mooney said, it could be a hint that neutron is under load. thought it would be good to know about that | 20:12 |
| mriedem | https://specs.openstack.org/openstack/openstack-specs/specs/log-guidelines.html#log-messages-at-info-and-above-should-be-a-unit-of-work | 20:12 |
| *** bigdogstl has joined #openstack-nova | 20:12 | |
| *** savvas has joined #openstack-nova | 20:12 | |
| mriedem | if we want to indicate there is a problem, | 20:13 |
| mriedem | i'd say it should be warning | 20:13 |
| mriedem | https://specs.openstack.org/openstack/openstack-specs/specs/log-guidelines.html#definition-of-log-levels | 20:13 |
| MultipleCrashes | hmm | 20:13 |
| *** cdent has quit IRC | 20:13 | |
| mriedem | clearly we need more highly paid engineers to paint this shed :) | 20:14 |
| sean-k-mooney | well if you have an extra brush i would be glad to help :P | 20:17 |
| *** bigdogstl has quit IRC | 20:17 | |
| *** jchhatbar has quit IRC | 20:18 | |
| *** avolkov has quit IRC | 20:18 | |
| sean-k-mooney | oh devstack stacked. back to testing stuff | 20:18 |
| *** jmlowe has joined #openstack-nova | 20:20 | |
| *** shaohe_feng has quit IRC | 20:20 | |
| *** shaohe_feng has joined #openstack-nova | 20:20 | |
| *** MultipleCrashes has quit IRC | 20:21 | |
| *** EranBD has joined #openstack-nova | 20:21 | |
| s10 | What is the easiest way to change hostname/nodename of the nova-compute host? If this host has instances, and all this instances should think after power on, that they are on host with a new hostname. | 20:22 |
| *** tbachman has quit IRC | 20:22 | |
| *** erlon has quit IRC | 20:23 | |
| sean-k-mooney | s10: instance can only tell they moved to a new host because the hashed hostid in the api will change | 20:23 |
| sean-k-mooney | if you change the hosts actull host name and restart the nova compute agent its going to endup with a different uuid as the uuid is based off the hostname by default | 20:25 |
| *** medberry has joined #openstack-nova | 20:26 | |
| sean-k-mooney | the instaces would still be assocated with the old compute host so the only simple and safe way to do it that i can think of would be to evactuate or migrate the instances first | 20:26 |
| melwitt | yeah, I was going to say, I think the only supported way to change the hostname stored in an instance record is to migrate the instance | 20:27 |
| *** medberry has quit IRC | 20:27 | |
| *** FL1SK has quit IRC | 20:27 | |
| *** medberry has joined #openstack-nova | 20:27 | |
| s10 | I'm talking about different thing. Lets assume, that /var/lib/nova/instances with vms disks are on the separate md (/dev/md1) on host1.openstack.example.org. Then this host breaks because of the memory or cpu issue, or something else. I want to save data of this vm, so evacuation is not the thing, so I extract disks of the /dev/md1 and put them in another server. | 20:28 |
| s10 | And then I had to set hostname of this new node to the hostname of old server. | 20:29 |
| s10 | But what if I don't want to name other physical machine as old one? | 20:29 |
| *** shaohe_feng has quit IRC | 20:30 | |
| s10 | I had to rename node in compute_nodes, services, nova_api, nova.instances, ml2_neutron port bindings... | 20:31 |
| melwitt | yeah, what you're talking about it migrating things manually, so if you're doing that, you'd have to figure out where all you'd need to update database records manually. we don't recommend this | 20:31 |
| *** shaohe_feng has joined #openstack-nova | 20:32 | |
| sean-k-mooney | s10: you also would have to update placement and the cells dbs in addtion to the normal nova one | 20:32 |
| *** medberry has quit IRC | 20:32 | |
| s10 | Yes, and this is too inconvenient. Would it be better to have some time of evacuate command, that would do all this steps, but without rebuilding instances? | 20:33 |
| sean-k-mooney | s10: the simpelste thing to do would be to pull the disk form the failed node. put them in a working node. migrate off the workloads then rename the new node to whatever it should be called give its physical location | 20:34 |
| melwitt | s10: maybe. I don't recall anyone proposing a spec like that. and I don't know if there are reasons why we don't have a command like that | 20:39 |
| s10 | This is how we do it now. But what if system disk (/) is on small m.2 ssd inside the server. So after the failure of this host we couldn't just take disks of the server, we need to pull server out of rack, open it, take this m.2 out and then put it in another server. | 20:39 |
| melwitt | dansmith: as the evacuate guru, do you happen to know why we don't have a command like "migrate all" from a fenced compute node that's forced down, similar to evacuate but moves disks too? are there tech difficulties around it? I don't remember if it's been proposed before | 20:40 |
| *** shaohe_feng has quit IRC | 20:41 | |
| s10 | All this operation will take much more time than just execution of evacuate --force --target-host command to move instances to the reserved compute node, that could be even be powered on all the time | 20:41 |
| *** shaohe_feng has joined #openstack-nova | 20:42 | |
| dansmith | melwitt: evacuate only works if the node is completely dead | 20:42 |
| dansmith | melwitt: it's destructive, doesn't preserve anything | 20:43 |
| cfriesen__ | melwitt: in my experience, the people that actually use "evacuate" will often be forcing down failed compute nodes and immediately evacuating the instances to new hosts. | 20:43 |
| dansmith | melwitt: marking the node down is the shortcut to the "is down" timer if you know better (i.e. you've fenced it yourself) | 20:43 |
| dansmith | if the node is not dead, then evacuate is not the operation you want | 20:44 |
| cfriesen__ | melwitt: if the node is fenced it's generally because it can't talk to the rest of the system | 20:44 |
| sean-k-mooney | dansmith: evacuate is also only usefull if your instance are using bfv right otherwise it not going to keep any data form the instces correct | 20:44 |
| cfriesen__ | sean-k-mooney: it keeps the IP addresses and such, which is useful for eg. heat | 20:45 |
| dansmith | melwitt: http://www.danplanet.com/blog/2016/03/03/evacuate-in-nova-one-command-to-confuse-us-all/ | 20:45 |
| melwitt | okay, thanks. yeah, so that's why it's a rebuild, because nova can't talk to the compute host at all | 20:45 |
| dansmith | sean-k-mooney: no, it's useful if you aren't on shared storage | 20:45 |
| dansmith | sean-k-mooney: if you care about uuid, networks, metadata, etc | 20:45 |
| dansmith | melwitt: right | 20:45 |
| melwitt | s10: what is your situation? compute host totally down? because if so, I don't think there's anything we can do about moving disks etc | 20:45 |
| sean-k-mooney | cfriesen__: true but if you were using local sotrage on the cmpute node its like doing a rebuild | 20:45 |
| cfriesen__ | sean-k-mooney: sure. but some applications are fine with that | 20:45 |
| dansmith | sean-k-mooney: ...which keeps the ips, like he said :) | 20:45 |
| melwitt | s10: if your compute host is up, you can disable the service (disable new scheduling to it) and then migrate all the instances off | 20:46 |
| melwitt | via the API | 20:46 |
| dansmith | right | 20:46 |
| sean-k-mooney | dansmith: yes that is true. i was ignroing that but i guess that could be usful if you have a statelesee workload. | 20:46 |
| dansmith | sean-k-mooney: or your workload keeps its state elsewhere | 20:47 |
| dansmith | sean-k-mooney: like a volume or a remote database | 20:47 |
| dansmith | your root disk doesn't need to be on a volume | 20:47 |
| s10 | melwitt: this is hypothetical situation, I'm thinking about ways to reduce downtime of instances. Situation is: compute node is down (kernel panic, powered off). I can pull disks with the instances data and put them in another host. But with current nova code I had to move system disks also and wait until system will boot on new hardware. | 20:47 |
| sean-k-mooney | dansmith: sure. i guess i was conflating not bfv with no cinider volumes. | 20:47 |
| *** lpetrut has joined #openstack-nova | 20:48 | |
| *** antosh has joined #openstack-nova | 20:48 | |
| cfriesen__ | S10: one possible issue you will run into is that neutron may need to be updated with suitable information as well, you may need to allocate SRIOV devices, the available CPUs on the new host might be different (for pinned CPUs), etc. | 20:48 |
| dansmith | s10: or not store your state in the ephemeral instance root disks in the first place... you know, like cloud and stuff :) | 20:48 |
| cfriesen__ | s10: also, any cinder connections will need to be rebuilt | 20:48 |
| dansmith | and if you're going to, you should probably be using ceph or cinder backing | 20:49 |
| s10 | cfriesen: this is not the issue, if recreate: | 20:49 |
| s10 | migration = {'source_compute': instance.host, | 20:49 |
| s10 | 'dest_compute': self.host, } | 20:49 |
| s10 | self.network_api.migrate_instance_finish(context, | 20:49 |
| s10 | instance, | 20:49 |
| s10 | migration) | 20:49 |
| s10 | This sets ports for instances on new host | 20:49 |
| sean-k-mooney | s10: also if your using routed netwroking you need to make sure your new host is on the same segment. | 20:49 |
| cfriesen__ | I'm talking about allocations, resource tracking, etc | 20:49 |
| cfriesen__ | placement, PCI device and CPU and hugepage claims, etc | 20:50 |
| s10 | dansmith: yes, but what if we want as much IOPS for instances as possible - this could only be archived with local NVMes, so red etc is not and option | 20:50 |
| *** flwang1 has joined #openstack-nova | 20:51 | |
| *** shaohe_feng has quit IRC | 20:51 | |
| dansmith | ack, fair enough | 20:51 |
| sean-k-mooney | s10: you dont need to keep all of your data on the nvme drivres. having an nvme backed epheral disk for scratch space or chacing is a more cloud friendly approch | 20:52 |
| *** shaohe_feng has joined #openstack-nova | 20:52 | |
| dansmith | yup | 20:52 |
| *** lpetrut has quit IRC | 20:52 | |
| dansmith | there's this triangle.. | 20:52 |
| dansmith | http://katharine-writes.com/wp-content/uploads/2014/03/Quality-Triangle.jpg | 20:53 |
| *** bigdogstl has joined #openstack-nova | 20:53 | |
| openstackgerrit | Merged openstack/nova master: Add description for placement 1.26 https://review.openstack.org/587067 | 20:53 |
| sean-k-mooney | dmcache and bcache in the kernel are actully great ways to cache /var/lib/nova/instances mounts from remote network filesystem using local nvmedrives | 20:56 |
| sean-k-mooney | i rembere looking to see if qemu could be configured to cache its remote disks via local fast storage but never found a way | 20:57 |
| dansmith | or just use something capable of doing it natively | 20:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Retry decorator fix for instances which go into ERROR state during bulk delete https://review.openstack.org/563418 | 20:57 |
| mriedem | jaypipes: melwitt: there you go ^ easy peasy | 20:57 |
| s10 | reserved host is a complete replica of the failed host, same cpus, no pic devices, same memory, in same network segment, only thing that should be changed is the hostname... | 20:58 |
| *** bigdogstl has quit IRC | 20:58 | |
| sean-k-mooney | ya i was trying to see if i could figure out how to cache vms backed by ceph using nvdim persistent memory without modifying qemu | 20:58 |
| *** mvk_ has joined #openstack-nova | 20:59 | |
| *** hamzy_ is now known as hamzy | 20:59 | |
| dansmith | yeah for transparent backing of block devices, dm-cache is the way | 20:59 |
| melwitt | mriedem: thanks | 20:59 |
| sean-k-mooney | s10: i was pritty sure we had a way to override the hostid of a compute node but i could not find it in the conf. that bacsically all you need. e.g. a way to forst the agent to think its on the old host without actully using the old host name on the phyical host | 21:00 |
| dansmith | ...or just transport the damn system disk :) | 21:00 |
| dansmith | you're walking across the aisle anyway :) | 21:00 |
| s10 | sean-k-mooney: i'm not sure, that we can tell that hostid to the neutron-ovs-agent same way :( | 21:01 |
| *** shaohe_feng has quit IRC | 21:01 | |
| sean-k-mooney | dansmith: ya that would likely be quicker then any workaround we can comup with bar adding a compute node uuid to the compute conf | 21:01 |
| sean-k-mooney | s10: the neutron agent definetly supports it | 21:01 |
| sean-k-mooney | its nova that is missing it | 21:02 |
| melwitt | yeah, I was gonna say, given all the things that would need to be updated, copying over the system disk sounds like the easiest and fastest way | 21:02 |
| *** shaohe_feng has joined #openstack-nova | 21:03 | |
| *** r-daneel has quit IRC | 21:03 | |
| sean-k-mooney | dansmith: melwitt out of interest is there any reason we could not allow an operator to choos the compute node uuid by setting it in the conf? | 21:03 |
| *** ThomasWhite has quit IRC | 21:03 | |
| *** ThomasWhite has joined #openstack-nova | 21:04 | |
| dansmith | sean-k-mooney: it's internal and more complicated to let them choose | 21:04 |
| dansmith | right now it can't change unless we change it or do things | 21:04 |
| dansmith | I can't really see a compelling reason to let them change it | 21:05 |
| sean-k-mooney | im not saying it a good idea. its a great way to shoot yourself in the foot and mess up our resouce tracking. but it would make s10 usecase doable without a lot of db hacking | 21:06 |
| s10 | Or can I just change compute_driver to Fake on reserved node, execute evacuate to this node and then just put disks from old host, and than change config back and restart nova-compute... | 21:07 |
| s10 | compute_driver=fake.FakeDriver. and than back to libvirt.LibvirtDriver. | 21:08 |
| *** r-daneel has joined #openstack-nova | 21:11 | |
| *** shaohe_feng has quit IRC | 21:11 | |
| sean-k-mooney | s10: that will likely take longer then pulling the os driver if your goal is to minimise guest downtime | 21:12 |
| *** masayukig has quit IRC | 21:13 | |
| *** priteau has quit IRC | 21:14 | |
| *** bigdogstl has joined #openstack-nova | 21:14 | |
| *** masayukig has joined #openstack-nova | 21:15 | |
| *** shaohe_feng has joined #openstack-nova | 21:15 | |
| *** itlinux_ has quit IRC | 21:16 | |
| *** itlinux has joined #openstack-nova | 21:17 | |
| s10 | sean-k-mooney: nova host-evacuate --target-host --force can be executed immediately after host failure. Same time, while instances are being "evacuated" to the fake host, support will pull disks from failed server and put them in the reserved, right after that we stop nova-compute, mount disks from old host, change nova config, start it again, and finally nova reboot for all instances. This will take much less time than moving system m.2 disk | 21:17 |
| *** bigdogstl has quit IRC | 21:19 | |
| s10 | Only physical operation that should be performed is moving disks. Other way requires opening the lid on the top of the server with dismounting it out of the rack. | 21:19 |
| mriedem | i highly suggest not using the --force option | 21:19 |
| mriedem | since it bypasses the scheduler and can mess things up if the target host is not actually a proper fit for the instance | 21:19 |
| dansmith | also, | 21:20 |
| dansmith | the fake driver will not have the right inventory in placement | 21:20 |
| dansmith | so your scheduler or conductor-based allocations would be all fubar | 21:20 |
| sean-k-mooney | mriedem: in this case s10 is forcing a migrate to a fake libvirt node so not sure it applies | 21:20 |
| dansmith | it definitely applies | 21:20 |
| sean-k-mooney | dansmith: oh because it skip the schduler and never update placement | 21:21 |
| mriedem | i'm not sure why using the fake virt driver in any of this is a good idea | 21:21 |
| s10 | yep. that is not the right way because of the inventory in placement. if we can't change it after. | 21:21 |
| dansmith | sean-k-mooney: not just that, but the inventory in placement that will come from the fake driver won't look anything like the inventory that the system will provide after you change it to libvirt | 21:21 |
| openstackgerrit | Merged openstack/nova master: Updated AggregateImagePropertiesIsolation filter illustration https://review.openstack.org/586317 | 21:21 |
| sean-k-mooney | s10: dumb question. why can you not put the os dirve in one of the hot swap bays so its just as easy to move as the other disks | 21:22 |
| *** shaohe_feng has quit IRC | 21:22 | |
| dansmith | sean-k-mooney: m2 drives on the motherboard are getting common for system drives today | 21:22 |
| dansmith | but of course, he could do that :) | 21:22 |
| dansmith | or buy systems with enough hot-swap bays | 21:22 |
| dansmith | or tell his vendor he doesn't like their placement of the m2 | 21:22 |
| dansmith | or use a system with a rear-mounted hot-swap bay for system drives | 21:23 |
| dansmith | lots of options | 21:23 |
| s10 | sean-k-mooney: because we have 4 slots for disk in 1U server. we use it all for storage disks or have to use one of them for system. | 21:23 |
| *** shaohe_feng has joined #openstack-nova | 21:23 | |
| sean-k-mooney | s10: ok but i have racked a lot of sytems in the intel dev lab. it really does not take that much time to pull an internal drive. for an m2 it 1 screw most of the time and you often dont need to even unrack the server. | 21:25 |
| sean-k-mooney | s10: if you really do have this requirement then fair enough but it seams like premature optimization unless you expect to have to do this often | 21:26 |
| s10 | sean-k-mooney: you are right, this is a premature optimisation. | 21:28 |
| *** shaohe_feng has quit IRC | 21:32 | |
| *** felipemonteiro__ has quit IRC | 21:34 | |
| *** shaohe_feng has joined #openstack-nova | 21:34 | |
| *** felipemonteiro__ has joined #openstack-nova | 21:34 | |
| *** antosh has quit IRC | 21:38 | |
| *** Guest4506 has quit IRC | 21:39 | |
| *** tidwellr has quit IRC | 21:40 | |
| *** shaohe_feng has quit IRC | 21:42 | |
| *** shaohe_feng has joined #openstack-nova | 21:43 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | 21:45 |
| openstackgerrit | Eric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033 | 21:45 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane https://review.openstack.org/584598 | 21:45 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599 | 21:45 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648 | 21:45 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034 | 21:45 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049 | 21:45 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | 21:45 |
| *** bnemec has quit IRC | 21:46 | |
| *** felipemonteiro has joined #openstack-nova | 21:52 | |
| *** shaohe_feng has quit IRC | 21:52 | |
| *** felipemonteiro__ has quit IRC | 21:53 | |
| *** felipemonteiro has quit IRC | 21:53 | |
| *** shaohe_feng has joined #openstack-nova | 21:54 | |
| *** felipemonteiro has joined #openstack-nova | 21:54 | |
| *** antosh has joined #openstack-nova | 21:58 | |
| *** itlinux has quit IRC | 21:59 | |
| *** tbachman has joined #openstack-nova | 22:00 | |
| *** rcernin has joined #openstack-nova | 22:02 | |
| *** shaohe_feng has quit IRC | 22:03 | |
| *** shaohe_feng has joined #openstack-nova | 22:03 | |
| *** Sundar has joined #openstack-nova | 22:06 | |
| *** shaohe_feng has quit IRC | 22:13 | |
| *** mlavalle has quit IRC | 22:14 | |
| *** shaohe_feng has joined #openstack-nova | 22:14 | |
| *** priteau has joined #openstack-nova | 22:14 | |
| *** Sundar has quit IRC | 22:15 | |
| *** threestrands has joined #openstack-nova | 22:18 | |
| *** shaohe_feng has quit IRC | 22:23 | |
| *** sapcc-bot has quit IRC | 22:24 | |
| *** d063130_ has quit IRC | 22:24 | |
| *** shaohe_feng has joined #openstack-nova | 22:24 | |
| *** d063130_ has joined #openstack-nova | 22:24 | |
| *** sapcc-bot has joined #openstack-nova | 22:24 | |
| *** wolverineav has quit IRC | 22:25 | |
| *** wolverineav has joined #openstack-nova | 22:26 | |
| *** wolverineav has quit IRC | 22:33 | |
| *** shaohe_feng has quit IRC | 22:33 | |
| *** shaohe_feng has joined #openstack-nova | 22:34 | |
| *** gongysh has joined #openstack-nova | 22:36 | |
| *** felipemonteiro has quit IRC | 22:40 | |
| *** linkmark has joined #openstack-nova | 22:40 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | 22:41 |
| *** shaohe_feng has quit IRC | 22:44 | |
| *** savvas has quit IRC | 22:45 | |
| *** savvas has joined #openstack-nova | 22:46 | |
| *** shaohe_feng has joined #openstack-nova | 22:47 | |
| *** savvas has quit IRC | 22:50 | |
| *** hongbin has quit IRC | 22:52 | |
| *** shaohe_feng has quit IRC | 22:54 | |
| *** shaohe_feng has joined #openstack-nova | 22:55 | |
| *** gongysh has quit IRC | 22:56 | |
| *** EranBD has quit IRC | 23:00 | |
| *** savvas has joined #openstack-nova | 23:01 | |
| *** shaohe_feng has quit IRC | 23:04 | |
| *** mschuppert has quit IRC | 23:04 | |
| *** shaohe_feng has joined #openstack-nova | 23:06 | |
| *** savvas has quit IRC | 23:06 | |
| mriedem | cfriesen__: where is the code for the nova api proxy thing for starlingx? | 23:07 |
| mriedem | is that in the nova staging repo? | 23:07 |
| *** liuyulong_ has joined #openstack-nova | 23:08 | |
| mriedem | i only see https://github.com/openstack/stx-nfv/tree/master/nova-api-proxy | 23:10 |
| *** liuyulong has quit IRC | 23:11 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova stable/pike: Refactor _build_device_metadata https://review.openstack.org/587248 | 23:14 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova stable/pike: Consider hostdev devices when building metadata https://review.openstack.org/587249 | 23:14 |
| *** shaohe_feng has quit IRC | 23:14 | |
| *** r-daneel has quit IRC | 23:16 | |
| *** shaohe_feng has joined #openstack-nova | 23:16 | |
| *** savvas has joined #openstack-nova | 23:23 | |
| *** shaohe_feng has quit IRC | 23:25 | |
| *** shaohe_feng has joined #openstack-nova | 23:26 | |
| cfriesen__ | mriedem: one sec | 23:27 |
| cfriesen__ | mriedem: You've got the right code. The proxy passes most things directly through to the "real" nova-api, while a subset of calls (see https://github.com/openstack/stx-nfv/blob/master/nova-api-proxy/nova-api-proxy/nova_api_proxy/apps/acceptor.py#L114) get forwarded to what we call the "VIM", which I think is now at "https://github.com/openstack/stx-nfv/tree/master/nfv/nfv-vim/nfv_vim" | 23:32 |
| cfriesen__ | mriedem: the reason for this is so that the vim can remain up-to-date about the state of the instance even in the face of races | 23:33 |
| cfriesen__ | I'm not very experienced in that area of the code...mostly I can just ignore it. | 23:34 |
| *** shaohe_feng has quit IRC | 23:35 | |
| *** shaohe_feng has joined #openstack-nova | 23:36 | |
| cfriesen__ | mriedem: the vim handles things like automated recovery if a qemu process crashes, or a compute node goes down. | 23:37 |
| cfriesen__ | mriedem: also things like pushing all instances off a node if we want to take it down for maintenance | 23:38 |
| *** s10 has quit IRC | 23:39 | |
| *** shaohe_feng has quit IRC | 23:45 | |
| *** shaohe_feng has joined #openstack-nova | 23:46 | |
| *** takashin has joined #openstack-nova | 23:51 | |
| *** antosh has quit IRC | 23:51 | |
| *** shaohe_feng has quit IRC | 23:55 | |
| *** shaohe_feng has joined #openstack-nova | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
