| *** namnh has joined #openstack-nova | 00:00 | |
| *** namnh has quit IRC | 00:01 | |
| *** ccamacho has quit IRC | 00:10 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix bad links for admin-guide https://review.openstack.org/580259 | 00:12 |
|---|---|---|
| openstackgerrit | Merged openstack/os-vif master: Update reno for stable/rocky https://review.openstack.org/586106 | 00:24 |
| mriedem | i have no idea how this can be happening https://review.openstack.org/#/c/588455/ | 00:26 |
| mriedem | if only we had some multi-node pci ci | 00:26 |
| openstackgerrit | Merged openstack/nova stable/queens: Add recreate test for RT.stats bug 1784705 https://review.openstack.org/587921 | 00:32 |
| openstack | bug 1784705 in OpenStack Compute (nova) queens "ResourceTracker.stats can leak across multiple ironic nodes" [High,In progress] https://launchpad.net/bugs/1784705 - Assigned to Matt Riedemann (mriedem) | 00:32 |
| *** ccamacho has joined #openstack-nova | 00:33 | |
| *** gyee has quit IRC | 00:38 | |
| *** Nel1x has joined #openstack-nova | 00:45 | |
| *** hongbin has joined #openstack-nova | 00:53 | |
| *** licanwei has joined #openstack-nova | 01:01 | |
| *** mriedem has quit IRC | 01:06 | |
| *** hongbin has quit IRC | 01:13 | |
| *** hongbin has joined #openstack-nova | 01:13 | |
| openstackgerrit | zhufl proposed openstack/nova master: xx_instance_type_id in list_migrations should be integer https://review.openstack.org/588481 | 01:23 |
| *** mhen has quit IRC | 01:26 | |
| *** mhen has joined #openstack-nova | 01:27 | |
| *** bbbbzhao_ has joined #openstack-nova | 01:38 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:50 | |
| *** mrsoul has joined #openstack-nova | 01:58 | |
| alex_xu | efried: yea, I'm working on it https://review.openstack.org/569011, we will discuss this in the PTG | 02:08 |
| *** gbarros has joined #openstack-nova | 02:35 | |
| *** yonglihe has joined #openstack-nova | 02:42 | |
| *** Dinesh_Bhor has quit IRC | 02:54 | |
| *** dave-mccowan has quit IRC | 02:57 | |
| *** dklyle has quit IRC | 02:58 | |
| *** Nel1x has quit IRC | 02:58 | |
| *** zhurong has joined #openstack-nova | 03:01 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:04 | |
| *** lei-zh has joined #openstack-nova | 03:08 | |
| *** itlinux_ has quit IRC | 03:13 | |
| *** psachin has joined #openstack-nova | 03:14 | |
| openstackgerrit | Merged openstack/nova stable/queens: Make ResourceTracker.stats node-specific https://review.openstack.org/587976 | 03:18 |
| openstackgerrit | Merged openstack/nova master: Fix none-ascii char in doc https://review.openstack.org/588422 | 03:18 |
| openstackgerrit | Merged openstack/nova master: Add microversion info in the os-server-groups API samples https://review.openstack.org/589006 | 03:19 |
| openstackgerrit | Merged openstack/nova master: api-ref: Add descriptions for rebuild https://review.openstack.org/588931 | 03:19 |
| *** gbarros has quit IRC | 03:25 | |
| *** gbarros has joined #openstack-nova | 03:36 | |
| *** gbarros has quit IRC | 03:49 | |
| *** hongbin has quit IRC | 03:51 | |
| *** erlon has quit IRC | 03:53 | |
| *** links has joined #openstack-nova | 03:56 | |
| *** jaosorior has joined #openstack-nova | 03:59 | |
| *** udesale has joined #openstack-nova | 04:00 | |
| *** lei-zh has quit IRC | 04:03 | |
| *** ratailor has joined #openstack-nova | 04:06 | |
| *** jaypipes has quit IRC | 04:11 | |
| *** jaypipes has joined #openstack-nova | 04:11 | |
| *** tetsuro has joined #openstack-nova | 04:18 | |
| *** zhurong has quit IRC | 04:20 | |
| *** jenglisch has quit IRC | 04:27 | |
| *** janki has joined #openstack-nova | 04:34 | |
| *** vivsoni has quit IRC | 04:54 | |
| *** vivsoni_ has joined #openstack-nova | 04:55 | |
| *** jarod_ has quit IRC | 05:07 | |
| *** takashin has joined #openstack-nova | 05:11 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] api-ref: add description for 1.29 https://review.openstack.org/589407 | 05:18 |
| *** stakeda has joined #openstack-nova | 05:25 | |
| *** jaosorior has quit IRC | 05:27 | |
| *** hoonetorg has quit IRC | 05:31 | |
| *** ccamacho has quit IRC | 05:32 | |
| *** Bhujay has joined #openstack-nova | 05:35 | |
| *** udesale has quit IRC | 05:42 | |
| *** hoonetorg has joined #openstack-nova | 05:52 | |
| *** zhurong has joined #openstack-nova | 05:57 | |
| gmann | API office hour time | 06:01 |
| gmann | #startmeeting nova api | 06:02 |
| openstack | Meeting started Wed Aug 8 06:02:14 2018 UTC and is due to finish in 60 minutes. The chair is gmann. Information about MeetBot at http://wiki.debian.org/MeetBot. | 06:02 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 06:02 |
| openstack | The meeting name has been set to 'nova_api' | 06:02 |
| gmann | who all here today? | 06:02 |
| gmann | PING List: gmann, alex_xu | 06:02 |
| alex_xu | o/ | 06:03 |
| *** hemna_ has quit IRC | 06:03 | |
| *** nicolasbock has joined #openstack-nova | 06:03 | |
| gmann | alex_xu: let's start | 06:04 |
| gmann | #topic Priorities | 06:04 |
| gmann | #link https://etherpad.openstack.org/p/rocky-nova-priorities-tracking | 06:04 |
| gmann | it will be quick update as Rocky FF already done | 06:04 |
| *** dpawlik has joined #openstack-nova | 06:05 | |
| gmann | there are 4 pending item from this which we need to continue in Stein | 06:05 |
| gmann | and after PTG we will update the priority for stein | 06:05 |
| *** hoonetorg has quit IRC | 06:06 | |
| gmann | i will continue the policy granular things as default roles are done in keystone now | 06:06 |
| gmann | #link this one https://review.openstack.org/#/c/547850/ | 06:06 |
| gmann | alex_xu: anything you have on this topic ? | 06:07 |
| alex_xu | gmann: why that depends on default roles in keystone? | 06:08 |
| gmann | that is do to the policy granular along with some meaningful defaults roles | 06:08 |
| *** dpawlik has quit IRC | 06:09 | |
| alex_xu | ok, i see | 06:09 |
| gmann | for example, in this spec i am proposing to make GET policy separate than POST/PUT so new GET policy should go with new default like reader, auditor etc | 06:09 |
| *** dpawlik has joined #openstack-nova | 06:09 | |
| gmann | which make sense | 06:09 |
| gmann | otherwsie we end up doing policy change twice | 06:09 |
| alex_xu | ok | 06:11 |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Use oslo_utils.uuidutils https://review.openstack.org/589717 | 06:11 |
| gmann | let's move next? | 06:11 |
| alex_xu | yea, nothing from me | 06:12 |
| gmann | #topic Bug Triage/Discussion | 06:12 |
| gmann | #link https://etherpad.openstack.org/p/nova-api-weekly-bug-report | 06:12 |
| gmann | updated this week report | 06:12 |
| gmann | there was 1 new bug which we can discuss here and keypair in-use bug | 06:13 |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Use uuidutils of oslo.utils https://review.openstack.org/589717 | 06:13 |
| gmann | #link https://bugs.launchpad.net/nova/+bug/1644457 | 06:13 |
| openstack | Launchpad bug 1644457 in OpenStack Compute (nova) "keypair quota error" [Medium,Confirmed] - Assigned to Vishakha Agarwal (vishakha.agarwal) | 06:13 |
| gmann | alex_xu: i agree with doc only update as of now on keypair things, and later if we need we should go with barbican integration as matt mentioned via sdague mail | 06:14 |
| gmann | i just updated the comment there. | 06:14 |
| alex_xu | gmann: yea, that the thing we can do now | 06:14 |
| gmann | alex_xu: +1 | 06:15 |
| gmann | vishakha: ^^ | 06:15 |
| gmann | next bug i want to discuss is new one show up - | 06:15 |
| gmann | #link https://bugs.launchpad.net/nova/+bug/1783338 | 06:15 |
| openstack | Launchpad bug 1783338 in OpenStack Compute (nova) "Unexpected exception in API method: ValueError: year is out of range" [Medium,Confirmed] - Assigned to Ghanshyam Mann (ghanshyammann) | 06:15 |
| vishakha | gmann yes I will update the doc | 06:15 |
| gmann | i commented and confirmed that. | 06:16 |
| gmann | vishakha: thanks | 06:16 |
| vishakha | gmann: thanks for the help | 06:16 |
| gmann | vishakha: you can just make clear in api-ref that in-use field will always be zero for keypairs. | 06:16 |
| vishakha | gmann: ok sure | 06:16 |
| gmann | and some more clarification like keypair is per user only not per projects | 06:17 |
| gmann | alex_xu: on second bug, error is that start or end dates in GET /simple-tenant-usage API is not iso8601 format. | 06:17 |
| gmann | it says year is out of range which i do not know why as attached screenshot in bug show year as '2018' | 06:18 |
| vishakha | gmann : ok | 06:18 |
| *** ccamacho has joined #openstack-nova | 06:18 | |
| gmann | one thing we are surly missing is to handle the value error which leads to 500 in this API | 06:18 |
| alex_xu | gmann: yea, we can update the query schema | 06:21 |
| gmann | as of now we just check string there | 06:21 |
| gmann | #link https://github.com/openstack/nova/blob/e8a73c400846b5be0f12a2eea32bd2c5c5aeb370/nova/api/openstack/compute/schemas/simple_tenant_usage.py#L22 | 06:21 |
| alex_xu | yea | 06:22 |
| gmann | need to check if iso8601 format there in json schema or we can do via custom format_checker also | 06:22 |
| alex_xu | I remember we have somewhere use it | 06:22 |
| alex_xu | change-since in server list API i guess | 06:23 |
| alex_xu | gmann: https://github.com/openstack/nova/blob/e8a73c400846b5be0f12a2eea32bd2c5c5aeb370/nova/api/openstack/compute/schemas/servers.py#L592 | 06:24 |
| gmann | ah yeah | 06:24 |
| gmann | #link https://github.com/openstack/nova/blob/e8a73c400846b5be0f12a2eea32bd2c5c5aeb370/nova/api/validation/validators.py#L47 | 06:24 |
| gmann | alex_xu: thanks, that will be quick | 06:24 |
| alex_xu | but the 2018 is out of range is very strange | 06:24 |
| gmann | i will update the patch for that | 06:24 |
| alex_xu | good to check that | 06:25 |
| gmann | yeah, not sure nova get 2018 or something else. ll get horizon and try out this one and will update on bug | 06:25 |
| alex_xu | but it only say 'year out of range', maybe the code doesn't see the 2018, it will be another value | 06:25 |
| alex_xu | yea | 06:25 |
| gmann | let's move to next bug | 06:26 |
| gmann | there is one high priority bug for href things | 06:26 |
| gmann | #link https://bugs.launchpad.net/nova/+bug/1705663 | 06:26 |
| openstack | Launchpad bug 1705663 in OpenStack Compute (nova) "Wrong href link returned when providing non-existed version in GET version API" [High,In progress] - Assigned to Zhenyu Zheng (zhengzhenyu) | 06:26 |
| gmann | i have not got chance to review Kevin_Zheng patch yet, alex_xu did you? | 06:27 |
| gmann | i think he update the PS | 06:27 |
| *** pcaruana has joined #openstack-nova | 06:27 | |
| alex_xu | gmann: no, I forget that one, probably try it today | 06:27 |
| Kevin_Zheng | o/ | 06:27 |
| gmann | alex_xu: thanks, i will also check but tomorrow only. | 06:27 |
| *** BrinZhang has joined #openstack-nova | 06:29 | |
| gmann | that's all from me on bug things, anything from your side ? | 06:29 |
| alex_xu | gmann: nothing from me | 06:29 |
| gmann | #topic Open Discussion | 06:30 |
| gmann | there is nothing on agend under open. if nothing we can close office houre early | 06:30 |
| *** ShilpaSD has joined #openstack-nova | 06:34 | |
| gmann | alex_xu: anything else ? | 06:35 |
| alex_xu | nothing from me | 06:37 |
| gmann | let's close then. thanks | 06:37 |
| gmann | #endmeeting | 06:37 |
| openstack | Meeting ended Wed Aug 8 06:37:32 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 06:37 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-08-08-06.02.html | 06:37 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-08-08-06.02.txt | 06:37 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-08-08-06.02.log.html | 06:37 |
| *** pooja_jadhav_ has joined #openstack-nova | 06:38 | |
| *** takashin has left #openstack-nova | 06:39 | |
| *** Cardoe_ has joined #openstack-nova | 06:42 | |
| *** vivsoni_ has quit IRC | 06:42 | |
| *** vivsoni__ has joined #openstack-nova | 06:42 | |
| *** Cardoe has quit IRC | 06:43 | |
| *** Cardoe_ is now known as Cardoe | 06:43 | |
| *** jaosorior has joined #openstack-nova | 06:44 | |
| *** s10 has joined #openstack-nova | 06:58 | |
| *** luksky has joined #openstack-nova | 06:59 | |
| *** Dinesh_Bhor has quit IRC | 07:03 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: api-ref: fix min_version for parent_provider_uuid in responses https://review.openstack.org/579577 | 07:05 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [placement] api-ref: add description for 1.29 https://review.openstack.org/589407 | 07:05 |
| *** adrianc has joined #openstack-nova | 07:05 | |
| *** s10 has quit IRC | 07:08 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:28 | |
| gibi | good morning nova | 07:30 |
| *** rcernin has quit IRC | 07:35 | |
| *** jaosorior has quit IRC | 07:38 | |
| *** jaosorior has joined #openstack-nova | 07:38 | |
| *** udesale has joined #openstack-nova | 07:40 | |
| *** jaosorior has quit IRC | 07:41 | |
| *** jaosorior has joined #openstack-nova | 07:41 | |
| *** jaosorior has quit IRC | 07:42 | |
| *** jaosorior has joined #openstack-nova | 07:43 | |
| *** jpena|off is now known as jpena | 07:46 | |
| *** chason has quit IRC | 07:49 | |
| *** adrianc has quit IRC | 07:53 | |
| *** sahid has joined #openstack-nova | 07:57 | |
| *** moshele has joined #openstack-nova | 08:02 | |
| *** tetsuro_ has joined #openstack-nova | 08:06 | |
| *** tetsuro has quit IRC | 08:07 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use placement 1.28 in scheduler report client https://review.openstack.org/583667 | 08:10 |
| ivve | hey guys.. the new migrate_configure_max_speed in guest.py (fix in pike https://bugs.launchpad.net/nova/+bug/1783635) but from queens.. bandwidth=0 but is capped @ 1024KB/sec | 08:14 |
| openstack | Launchpad bug 1783635 in OpenStack Compute (nova) pike "Live migration failed.: AttributeError: 'Guest' object has no attribute 'migrate_configure_max_speed'" [High,Fix committed] - Assigned to Lee Yarwood (lyarwood) | 08:14 |
| ivve | i've applied it manually for pike. 0 should be unlimited? | 08:15 |
| ivve | def migrate(self, destination, migrate_uri=None, params=None, flags=0, | 08:15 |
| ivve | domain_xml=None, bandwidth=0): | 08:15 |
| ivve | seems to set itself to 1 | 08:16 |
| ivve | im no good at debugging this so asking for help :) | 08:16 |
| ivve | note: cap is for entire host, not per vm | 08:18 |
| ivve | instance.. | 08:18 |
| *** cdent has joined #openstack-nova | 08:20 | |
| lyarwood | sahid: ^ I think bandwidth=0 is unlimited right? | 08:21 |
| lyarwood | https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainMigrateSetMaxSpeed doesn't help | 08:21 |
| ivve | it should be, but my migrations are 1024KB/sec capped | 08:22 |
| ivve | just evacuated a host and watched my bridge.. 1024KB | 08:22 |
| ivve | so it seems to set itself to 1 | 08:22 |
| ivve | 1MB/sec | 08:22 |
| lyarwood | ivve: live_migration_bandwidth isn't set in nova.conf? | 08:24 |
| ivve | is it meant to be set via nova configuration and/or metadata for hosts/instances? | 08:24 |
| ivve | lyarwood: let me check! | 08:24 |
| ivve | kinda stumbled upon this when i updated a pike | 08:25 |
| lyarwood | ivve: https://github.com/openstack/nova/blob/stable/pike/nova/virt/libvirt/driver.py#L6939-L6942 - you should see it logged here as well btw | 08:25 |
| *** zhurong has quit IRC | 08:26 | |
| ivve | so im guessing more issues will follow, not only the fix in bug 1783635 | 08:26 |
| openstack | bug 1783635 in OpenStack Compute (nova) pike "Live migration failed.: AttributeError: 'Guest' object has no attribute 'migrate_configure_max_speed'" [High,Fix committed] https://launchpad.net/bugs/1783635 - Assigned to Lee Yarwood (lyarwood) | 08:26 |
| ivve | well actually im wrong | 08:27 |
| sahid | lyarwood: yes but that can be overidden by the api call migrateToUri | 08:27 |
| ivve | thats for openstack-ansible to fix | 08:27 |
| ivve | i guess | 08:27 |
| *** tssurya has joined #openstack-nova | 08:27 | |
| lyarwood | ivve: that's the only other fix on top of 16.1.4 to do with migration AFAIK | 08:28 |
| ivve | lyarwood: you are right, the option is not even in nova.conf | 08:28 |
| ivve | setting it now and restarting, sec for confirmation | 08:29 |
| lyarwood | ivve: it should default to 0 | 08:30 |
| lyarwood | ivve: I was trying to ensure it wasn't set to 1 | 08:30 |
| *** stakeda has quit IRC | 08:31 | |
| lyarwood | sahid: it defaults to 0 there as well so I have no idea where 1 is coming from for ivve | 08:31 |
| ivve | it wasn't in the libvirt stanza at all | 08:31 |
| ivve | so im guessing defaults to 1 ? :D | 08:31 |
| sahid | 1 is comming is you are using linux bridge | 08:31 |
| sahid | to slow the migration | 08:31 |
| sahid | to let neutron configure the network on destination node | 08:32 |
| sahid | then neutron is sending an event to nova | 08:32 |
| sahid | and the migration can run at full speed | 08:33 |
| lyarwood | https://github.com/openstack/nova/blob/stable/pike/nova/virt/libvirt/driver.py#L6913-L6922 - yup my bad | 08:33 |
| lyarwood | sahid: does LB send events back once it's done? | 08:34 |
| lyarwood | sahid: is that why we are stuck at 1MB/s | 08:34 |
| ivve | yeah im using linux bridges | 08:36 |
| ivve | it seems it never speeds up | 08:38 |
| ivve | i will confirm | 08:39 |
| *** tetsuro_ has quit IRC | 08:41 | |
| sahid | there are some fix in neutron as well | 08:41 |
| ivve | perhaps neutron doesn't send the event. did it used to in pike 16.0.16? | 08:42 |
| ivve | aye feels like im missing some dep. fixes :D | 08:42 |
| ivve | i went from 16.0.16 -> 16.0.17 | 08:42 |
| ivve | there is also some issue between CPU i think | 08:43 |
| ivve | different cpu hosts are whining and don't want to migrate at all ;) | 08:43 |
| lyarwood | ivve: which version of neutron do you have? | 08:44 |
| lyarwood | ivve: as sahid says this needs >=11.0.5 | 08:44 |
| lyarwood | ivve: https://review.openstack.org/#/c/510013/ | 08:44 |
| *** amarao has joined #openstack-nova | 08:44 | |
| *** derekh has joined #openstack-nova | 08:46 | |
| ivve | neutron-server 11.0.6.dev47 | 08:47 |
| ivve | possibly some configuration then? | 08:48 |
| lyarwood | sahid: ^? | 08:49 |
| lyarwood | ivve: are you seeing the debug line logged by the agent? `Port %s not found, will not notify nova.` | 08:49 |
| mdbooth | owalsh: Did you see the Trilio thing on the ml? | 08:54 |
| ivve | checking | 08:55 |
| sahid | ivve: this part is in the agent, did you well upgrade neutron on the compute nodes? | 08:58 |
| ivve | yes it seems to be the same version | 08:59 |
| ivve | 11.0.6.dev47 | 08:59 |
| ivve | ah wait | 09:00 |
| ivve | you mean agent version | 09:00 |
| ivve | all agents pointing to that version | 09:01 |
| ivve | 11.0.6.dev47 | 09:01 |
| ivve | however since i think backport was missed to pike on the migration guest.py perhaps more things were missed? | 09:01 |
| sahid | hum.. | 09:01 |
| sahid | can you confiugre nova.conf in debug adn then start a live migration, then share the logs | 09:02 |
| ivve | i can't see any port not found error messages related to the migrations... | 09:02 |
| ivve | aye | 09:02 |
| sahid | thanks | 09:02 |
| mdbooth | lyarwood: Did I see some scuttlebutt around nominations for membership of the CIX tiger-tag-team? | 09:02 |
| lyarwood | mdbooth: wrong chat window ;) | 09:04 |
| mdbooth | lyarwood: Ah, so it is. | 09:04 |
| *** _pewp_ has quit IRC | 09:06 | |
| *** _pewp_ has joined #openstack-nova | 09:06 | |
| ivve | https://hastebin.com/epafobulet.http | 09:08 |
| ivve | and the other | 09:10 |
| ivve | https://hastebin.com/kevuhihuje.coffeescript | 09:10 |
| ivve | the first was receiving end, second was sending | 09:10 |
| ivve | on these two nodes i have configured the setting live_migration_bandwidth = 0 | 09:13 |
| ivve | even if it is assumed default | 09:13 |
| openstackgerrit | Kevin Zhao proposed openstack/nova master: Skip CPU comparison in Aarch64 https://review.openstack.org/589769 | 09:15 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Reduce calls to qemu-img during update_available_resource https://review.openstack.org/589513 | 09:21 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add workaround to stop use of qemu-img by the RT https://review.openstack.org/589567 | 09:21 |
| *** alexchadin has joined #openstack-nova | 09:28 | |
| *** efoley has joined #openstack-nova | 09:33 | |
| openstackgerrit | OpenStack Release Bot proposed openstack/osc-placement stable/rocky: Update .gitreview for stable/rocky https://review.openstack.org/589773 | 09:34 |
| openstackgerrit | OpenStack Release Bot proposed openstack/osc-placement stable/rocky: Update UPPER_CONSTRAINTS_FILE for stable/rocky https://review.openstack.org/589774 | 09:34 |
| openstackgerrit | OpenStack Release Bot proposed openstack/osc-placement master: Update reno for stable/rocky https://review.openstack.org/589775 | 09:34 |
| *** vivsoni__ has quit IRC | 09:39 | |
| *** luksky has quit IRC | 09:44 | |
| *** priteau has quit IRC | 09:45 | |
| *** priteau has joined #openstack-nova | 09:45 | |
| sahid | ivve: line 217 we can see Nova reonfiguring libvirt to use 0 | 09:45 |
| *** edmondsw has joined #openstack-nova | 09:45 | |
| sahid | can you try to configure live_migration_bandwidth to a large value instead of 0 | 09:47 |
| *** edmondsw has quit IRC | 09:49 | |
| *** ratailor_ has joined #openstack-nova | 09:56 | |
| *** ratailor_ has quit IRC | 09:56 | |
| *** ratailor has quit IRC | 09:58 | |
| *** vivsoni has joined #openstack-nova | 10:00 | |
| *** ratailor has joined #openstack-nova | 10:01 | |
| mardim | Hello guys one question | 10:01 |
| mardim | I booted an instance succesfully | 10:02 |
| mardim | But when I am trying to resize it I get novalid host was found error | 10:02 |
| mardim | I am using PIke | 10:02 |
| mardim | I am seeing the logs in scheduler and the ComputeFilter returns 0 hosts | 10:03 |
| *** ratailor has quit IRC | 10:03 | |
| mardim | I have only one compute node | 10:03 |
| mardim | Any idea ? | 10:03 |
| *** ratailor has joined #openstack-nova | 10:03 | |
| mardim | artom ^ | 10:03 |
| mardim | melwitt, ^ | 10:04 |
| *** ratailor has quit IRC | 10:04 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Add explicit functional-py36 tox target https://review.openstack.org/589825 | 10:05 |
| lyarwood | mardim: is allow_resize_to_same_host=True ? | 10:05 |
| cdent | gibi ^ | 10:05 |
| mardim | Yes it is | 10:05 |
| mardim | And I definitely have enough resources | 10:06 |
| mardim | because my compute node has 16 cpus | 10:06 |
| mardim | in hyperthreading | 10:06 |
| lyarwood | l~N | 10:14 |
| lyarwood | wait, this isn't mutt | 10:15 |
| lyarwood | mardim: kk, looks like people did use scheduler_default_filters=AllHostsFilter | 10:15 |
| lyarwood | mardim: in addition to help here, no idea if that's still required | 10:16 |
| lyarwood | mardim: http://madorn.com/resize-on-single-compute.html#.W2rC13ZKhhE | 10:16 |
| mardim | those are my openstack package : https://hastebin.com/useyohiwek.css | 10:16 |
| lyarwood | been a while since I tried this | 10:16 |
| mardim | Also I found this | 10:16 |
| mardim | https://bugs.launchpad.net/nova/+bug/1762596 | 10:16 |
| openstack | Launchpad bug 1762596 in OpenStack Compute (nova) "controller nova resize instance dont' work openstack Pike" [Undecided,Invalid] | 10:16 |
| *** tonyb has quit IRC | 10:16 | |
| mardim | maybe is realted | 10:16 |
| mardim | related | 10:16 |
| *** luksky has joined #openstack-nova | 10:16 | |
| mardim | lyarwood, I will try only with Allhosts | 10:17 |
| mardim | nad see what happens | 10:17 |
| mardim | Thanks | 10:17 |
| *** ratailor has joined #openstack-nova | 10:20 | |
| *** tonyb has joined #openstack-nova | 10:23 | |
| *** vivsoni has quit IRC | 10:23 | |
| *** vivsoni has joined #openstack-nova | 10:23 | |
| ivve | sahid: sorry i was afk for lunch a while there | 10:25 |
| ivve | sahid: testing large value, 1024 | 10:25 |
| *** vivsoni_ has joined #openstack-nova | 10:27 | |
| ivve | sahid: no change, still 1024kb/sec | 10:28 |
| *** vivsoni has quit IRC | 10:29 | |
| *** udesale has quit IRC | 10:30 | |
| *** mdbooth has quit IRC | 10:31 | |
| *** mdbooth has joined #openstack-nova | 10:31 | |
| *** efoley has quit IRC | 10:33 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Refactor cell_type in compute/api.py https://review.openstack.org/589833 | 10:38 |
| *** erlon has joined #openstack-nova | 10:38 | |
| openstackgerrit | Sergii Golovatiuk proposed openstack/nova master: Fix URI for IPv6 https://review.openstack.org/589548 | 10:43 |
| *** BrinZhang has quit IRC | 10:53 | |
| *** BrinZhang has joined #openstack-nova | 10:53 | |
| cdent | thanks gibi | 10:57 |
| *** jaosorior has quit IRC | 10:58 | |
| *** dave-mccowan has joined #openstack-nova | 10:59 | |
| *** jaosorior has joined #openstack-nova | 10:59 | |
| gibi | cdent: totally make sense, I had a similar change locally testing some py36 fix | 11:01 |
| cdent | yeah, I got sick of adding one every so often | 11:02 |
| *** rmart04 has joined #openstack-nova | 11:02 | |
| openstackgerrit | Sergii Golovatiuk proposed openstack/nova master: Fix URI for IPv6 https://review.openstack.org/589548 | 11:02 |
| openstackgerrit | Sergii Golovatiuk proposed openstack/nova master: Fix URI for IPv6 https://review.openstack.org/589548 | 11:05 |
| *** ratailor has quit IRC | 11:09 | |
| *** BrinZhang has quit IRC | 11:16 | |
| *** BrinZhang has joined #openstack-nova | 11:16 | |
| openstackgerrit | Chen proposed openstack/nova master: Update ssh configuration doc https://review.openstack.org/589844 | 11:20 |
| openstackgerrit | Chen proposed openstack/nova master: Update ssh configuration doc https://review.openstack.org/589844 | 11:23 |
| *** tbachman has joined #openstack-nova | 11:23 | |
| lyarwood | owalsh: re https://review.openstack.org/#/c/589548/2/nova/virt/libvirt/driver.py do we not have any code in nova or oslo that can do this for us already? | 11:33 |
| *** jpena is now known as jpena|lunch | 11:35 | |
| owalsh | lyarwood: did occur to me... and now that I actually look - https://docs.openstack.org/oslo.utils/latest/reference/netutils.html#oslo_utils.netutils.escape_ipv6 | 11:37 |
| lyarwood | owalsh: noice, sorry wasn't looking at the latest PS but still we should use that | 11:38 |
| lyarwood | owalsh: I can respin that now with tests | 11:38 |
| owalsh | lyarwood: cool, thanks | 11:38 |
| openstackgerrit | Merged openstack/nova master: Fix resize revert to use non-legacy alloc handling https://review.openstack.org/589425 | 11:42 |
| *** alexchadin has quit IRC | 11:47 | |
| *** chason has joined #openstack-nova | 11:52 | |
| *** alexchadin has joined #openstack-nova | 11:54 | |
| *** zhangbailin_ has joined #openstack-nova | 11:56 | |
| *** BrinZhang has quit IRC | 11:59 | |
| *** zhangbailin_ has quit IRC | 12:00 | |
| *** BrinZhang has joined #openstack-nova | 12:00 | |
| *** udesale has joined #openstack-nova | 12:05 | |
| *** udesale has quit IRC | 12:05 | |
| *** udesale has joined #openstack-nova | 12:06 | |
| *** udesale has quit IRC | 12:07 | |
| *** udesale has joined #openstack-nova | 12:08 | |
| *** udesale has quit IRC | 12:10 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Always escapte IPv6 addresses when used in migration URI https://review.openstack.org/589548 | 12:13 |
| lyarwood | owalsh: ^ needs a bug but that should be better | 12:13 |
| *** tssurya has quit IRC | 12:13 | |
| *** panda|rover is now known as panda|ruck | 12:25 | |
| *** slagle has joined #openstack-nova | 12:33 | |
| *** jpena|lunch is now known as jpena | 12:35 | |
| *** tssurya has joined #openstack-nova | 12:36 | |
| *** holser_ has joined #openstack-nova | 12:42 | |
| holser_ | lyarwood | 12:43 |
| artom | OK, this is starting to get annoying, and consistently reproducible - I can't get a devstack compute to "join" another devstack allinone - it errors out with "Didn't find service registered by hostname after 60 seconds" | 12:43 |
| artom | What am I doing wrong? | 12:43 |
| lyarwood | holser_: \o_ hey | 12:43 |
| * holser_ nods | 12:43 | |
| lyarwood | holser_: https://review.openstack.org/589548 - can you also create a bug for this so we can backport it into stable? | 12:43 |
| holser_ | concerning https://review.openstack.org/#/c/589548/ the valid case is u'[2001:0db8:85a3:0000:0000:8a2e:0370]:7334' | 12:43 |
| holser_ | sure I will create it now | 12:43 |
| lyarwood | holser_: thanks | 12:43 |
| lyarwood | holser_: in terms of what is being passed in or expected? | 12:44 |
| holser_ | what being passed | 12:44 |
| holser_ | we have comment from sahid which is valid | 12:45 |
| holser_ | also def _migrate_uri(dest): should be covered also | 12:45 |
| holser_ | uri = 'tcp://%s' % dest | 12:45 |
| lyarwood | holser_: kk, I'll leave that to you then | 12:46 |
| holser_ | sure... | 12:46 |
| * holser_ is writing bug report | 12:46 | |
| *** slagle has quit IRC | 12:48 | |
| *** tbachman has quit IRC | 12:50 | |
| *** mriedem has joined #openstack-nova | 12:59 | |
| *** BrinZhang has quit IRC | 13:04 | |
| *** edmondsw has joined #openstack-nova | 13:05 | |
| mdbooth | lyarwood: test_instance_action passes :) | 13:06 |
| mdbooth | lyarwood: Question is: what else did I break in the process? ;) | 13:06 |
| lyarwood | mdbooth: welcome to the house of cards that is that fixture :) | 13:07 |
| *** maciejjozefczyk has quit IRC | 13:11 | |
| *** psachin has quit IRC | 13:12 | |
| *** alexchadin has quit IRC | 13:14 | |
| mdbooth | lyarwood: Ok, everything in test_instance passes | 13:15 |
| *** gbarros has joined #openstack-nova | 13:15 | |
| mdbooth | lyarwood: Mind if I push it to let CI see what explodes? | 13:15 |
| mdbooth | Actually, lemme just run the python2 tests first. | 13:16 |
| * mdbooth only ran python3 so far | 13:16 | |
| mdbooth | Has to be a first for me | 13:16 |
| lyarwood | mdbooth: yeah go for it when you're ready | 13:16 |
| lyarwood | mdbooth: add yourself as a co-author while you're at it as well, assuming you've had a change things | 13:17 |
| lyarwood | to change things* even | 13:17 |
| *** tbachman has joined #openstack-nova | 13:19 | |
| *** alexchadin has joined #openstack-nova | 13:20 | |
| *** alexchadin has quit IRC | 13:22 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: fixtures: Track volume attachments within CinderFixtureNewAttachFlow https://review.openstack.org/587013 | 13:23 |
| mdbooth | lyarwood: ^^^ | 13:23 |
| *** tbachman has quit IRC | 13:23 | |
| mdbooth | Ended up having to go a bit back to basics. | 13:23 |
| mdbooth | Because the bugs weren't in the fixture code, but rather in the simplifications it was intentionally making. Like using volume_id instead of attachment_id all over the place. | 13:25 |
| mdbooth | As soon as we started asserting things about that, everything broke. | 13:25 |
| lyarwood | mdbooth: yup indeed, thanks for that, I'll rebase the other changes on to this once it passes and sort the other nits out | 13:26 |
| *** maciejjozefczyk has joined #openstack-nova | 13:26 | |
| *** maciejjozefczyk has quit IRC | 13:28 | |
| *** maciejjozefczyk has joined #openstack-nova | 13:30 | |
| *** alexchadin has joined #openstack-nova | 13:31 | |
| *** tbachman has joined #openstack-nova | 13:31 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] api-ref: add description for 1.29 https://review.openstack.org/589407 | 13:37 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: fixtures: Fail deleting non-existent attachment in CinderFixtureNewAttachFlow https://review.openstack.org/589900 | 13:37 |
| mdbooth | lyarwood: Incidentally ^^^ removes a workaround which was previously required. No idea if it's still required, will find out. | 13:38 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] api-ref: add description for 1.29 https://review.openstack.org/589407 | 13:38 |
| lyarwood | mdbooth: kk, we can merge it in if it passes now | 13:42 |
| mdbooth | lyarwood: ack | 13:43 |
| *** alexchadin has quit IRC | 13:44 | |
| *** alexchadin has joined #openstack-nova | 13:45 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update the parameter explain when updating a volume attachment https://review.openstack.org/565181 | 13:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update the parameter explain when updating a volume attachment https://review.openstack.org/565181 | 13:48 |
| *** _ix has joined #openstack-nova | 13:49 | |
| openstackgerrit | Merged openstack/python-novaclient master: Fix server strings in reboot operation https://review.openstack.org/588981 | 13:53 |
| mdbooth | lyarwood: functional failed again. Coffee, then I'll take another look. | 13:57 |
| *** alexchadin has quit IRC | 14:00 | |
| *** alexchadin has joined #openstack-nova | 14:00 | |
| *** alexchadin has quit IRC | 14:03 | |
| *** maciejjozefczyk has quit IRC | 14:07 | |
| *** awaugama has joined #openstack-nova | 14:07 | |
| *** _ix has quit IRC | 14:13 | |
| *** Bhujay has quit IRC | 14:18 | |
| *** hongbin has joined #openstack-nova | 14:18 | |
| mriedem | lyarwood: want to address the nit in https://review.openstack.org/#/c/589513/ and then i'll +2 | 14:19 |
| lyarwood | mriedem: yeah was about to ask if there was anything else before I hit it | 14:20 |
| *** HW-Peter has joined #openstack-nova | 14:21 | |
| *** _ix has joined #openstack-nova | 14:22 | |
| *** maciejjozefczyk has joined #openstack-nova | 14:22 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Reduce calls to qemu-img during update_available_resource https://review.openstack.org/589513 | 14:22 |
| dansmith | mriedem: fwiw, this was my idea: https://review.openstack.org/#/c/589567/3 | 14:24 |
| dansmith | mriedem: but I agree it would be nicer to do the thing that 95% of people need by default | 14:24 |
| lyarwood | yeah sorry the commit just had it the wrong way around | 14:25 |
| dansmith | mriedem: I just don't think jumping through a bunch of hoops to collect correct info that doesn't matter efficiently is worth it | 14:25 |
| lyarwood | you only need the workaround if you are using DiskFilter etc | 14:25 |
| dansmith | lyarwood: right, that'd be my preference | 14:25 |
| *** moshele has quit IRC | 14:29 | |
| mriedem | +2 on the bottom change | 14:30 |
| mriedem | did s10 say if that fixes the majority of the perf regression? | 14:31 |
| lyarwood | thanks I'll sort this other mess out now | 14:31 |
| lyarwood | mriedem: just brings the time down by 50%, 20 seconds without this, 10 seconds with this, previously 2 seconds. | 14:32 |
| lyarwood | mriedem: so the workaround should get us back to 2 seconds | 14:32 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: fixtures: Track volume attachments within CinderFixtureNewAttachFlow https://review.openstack.org/587013 | 14:33 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: fixtures: Fail deleting non-existent attachment in CinderFixtureNewAttachFlow https://review.openstack.org/589900 | 14:33 |
| mdbooth | lyarwood: Attempt 2 ^^^ | 14:33 |
| mdbooth | Nothing architectural: just a couple of external tests asserting a variable I'd deleted | 14:34 |
| efried | mriedem: o process guru, what do you think about swapping bug numbers here: https://review.openstack.org/#/c/401009/14//COMMIT_MSG@16 | 14:36 |
| *** Roamer` has quit IRC | 14:40 | |
| *** ccamacho has quit IRC | 14:43 | |
| *** ccamacho has joined #openstack-nova | 14:45 | |
| *** priteau has quit IRC | 14:53 | |
| * mriedem is talking to plumbers | 14:54 | |
| mriedem | efried: yeah i noticed that as well when i looked at that bug, | 14:55 |
| mriedem | https://review.openstack.org/#/c/447355/ marked it as closing the bug but it didn't really, it should have been partial | 14:55 |
| efried | mriedem: If you agree, I'll flip it and fast approve | 14:55 |
| efried | mriedem: Either that or mark the second bug as a dup | 14:56 |
| mriedem | let me look at what changed since i last +2ed it | 14:56 |
| melwitt | . | 14:59 |
| mriedem | efried: commented | 15:01 |
| efried | ack | 15:01 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix host validity check for live-migration https://review.openstack.org/401009 | 15:02 |
| efried | mriedem: Done and +A | 15:02 |
| *** priteau has joined #openstack-nova | 15:04 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: fixtures: Track volume attachments within CinderFixtureNewAttachFlow https://review.openstack.org/587013 | 15:05 |
| *** tbachman has quit IRC | 15:05 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: fixtures: Fail deleting non-existent attachment in CinderFixtureNewAttachFlow https://review.openstack.org/589900 | 15:05 |
| mdbooth | lyarwood: Attempt 3: I feel good about this one | 15:06 |
| *** chason has quit IRC | 15:06 | |
| *** chason has joined #openstack-nova | 15:07 | |
| *** chason has quit IRC | 15:07 | |
| *** chason has joined #openstack-nova | 15:07 | |
| *** links has quit IRC | 15:10 | |
| melwitt | dansmith: there are more updates to this bug from gnuoy, having to do with the redirection api being used https://bugs.launchpad.net/nova/+bug/1785235 | 15:11 |
| openstack | Launchpad bug 1785235 in OpenStack Compute (nova) "metadata retrieval fails when using a global nova-api-metadata service" [Undecided,Incomplete] - Assigned to Liam Young (gnuoy) | 15:11 |
| dansmith | melwitt: okay never heard back from him here that he moved to the non-allinone metadata service | 15:13 |
| melwitt | looking back at the IRC log from 2018-08-03, it looks like you said to run the metadata service with "the regular api server, and just not enable the osapi api if you want to only run metadata" | 15:13 |
| dansmith | right | 15:13 |
| melwitt | it seems like they haven't done that and I don't know how to tell him to do that, like what command and conf to use | 15:14 |
| gnuoy | hi there | 15:14 |
| gnuoy | I have tried moving away from a standalone server and that does work for me. | 15:14 |
| gnuoy | However, I was hoping to get to the bottom of the issue with the standalone service | 15:15 |
| melwitt | I thought we explained why that doesn't work, the database connection and message queue settings are intentionally not sent over RPC | 15:16 |
| dansmith | gnuoy: the standalone service is really just for running on compute nodes in multihost n-net mode, which doesn't make sense for a neutron and multi-cell environment | 15:16 |
| dansmith | which is why I said this is a doc bug if the regular api works for you | 15:16 |
| gnuoy | ok, then thats a misunderstanding on my part. I didn't appreciate the situation was explicit as: not expected to work with neutron and cells | 15:17 |
| gnuoy | in that case I'll update the bug saying that the central api service works for me. | 15:17 |
| *** ccamacho has quit IRC | 15:17 | |
| gnuoy | sorry for the noise. | 15:17 |
| dansmith | no problem, glad to hear that it works as we expect though :) | 15:18 |
| *** dpawlik has quit IRC | 15:19 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] api-ref: add description for 1.29 https://review.openstack.org/589407 | 15:21 |
| *** efoley has joined #openstack-nova | 15:22 | |
| *** amarao has quit IRC | 15:23 | |
| *** luksky has quit IRC | 15:24 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Avoid rp.get_by_uuid in allocation_candidates https://review.openstack.org/589941 | 15:29 |
| *** hemna_ has joined #openstack-nova | 15:34 | |
| *** pcaruana has quit IRC | 15:34 | |
| *** tbachman has joined #openstack-nova | 15:34 | |
| openstackgerrit | Liam Young proposed openstack/nova master: Remove Neutron MetaAPIProxy from cellsv2-layout https://review.openstack.org/588525 | 15:35 |
| openstackgerrit | Sergii Golovatiuk proposed openstack/nova master: libvirt: Always escape IPv6 addresses when used in migration URI https://review.openstack.org/589548 | 15:35 |
| *** gbarros has quit IRC | 15:36 | |
| gnuoy | dansmith, melwitt, fwiw I've had a go at updating the nova metadata verbage https://review.openstack.org/588525 | 15:36 |
| melwitt | cool, thanks | 15:39 |
| *** jlvillal is now known as jlv-sick | 15:40 | |
| *** rmart04 has quit IRC | 15:42 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: get provider IDs once when building summaries https://review.openstack.org/589945 | 15:42 |
| kosamara | efried: Since yaml seems a better way forward, the spec I would propose would include most of the points of your spec. The larger differences I see so far mostly amount to device discovery and no auto-generated traits (following jaypipes' comment). Also, I would focus on generating the RPs and split the interactions with instances to a follow-up spec. | 15:43 |
| efried | kosamara: Sounds good to me. As you're doing your writeup, it would be nice if you're careful to distinguish the responsibilities of the virt driver versus the compute manager. So for instance, the decision about whether to generate traits could/should (IMO) be left up to the individual driver. | 15:45 |
| mdbooth | Is zuul grumpy about something? | 15:46 |
| mdbooth | "Tenant openstack isn't ready" | 15:46 |
| kosamara | efried: OK. Thanks! I also left you some questions on your spec. | 15:48 |
| efried | kosamara: Okay, nice, thank you. I'll get to them this afternoon. | 15:48 |
| *** masayukig has quit IRC | 15:50 | |
| *** ShilpaSD has quit IRC | 15:53 | |
| *** dklyle has joined #openstack-nova | 15:55 | |
| *** gbarros has joined #openstack-nova | 15:56 | |
| *** tssurya has quit IRC | 15:57 | |
| *** david-lyle has joined #openstack-nova | 15:59 | |
| *** dklyle has quit IRC | 16:01 | |
| *** david-lyle is now known as dklyle | 16:02 | |
| *** sambetts|afk is now known as sambetts | 16:03 | |
| *** gbarros has quit IRC | 16:06 | |
| mriedem | melwitt: were you planning on closing out https://blueprints.launchpad.net/nova/+spec/versioned-notification-transformation-rocky since we're past FF? | 16:07 |
| mriedem | i assumed we'd close that out and pick up with a stein bp | 16:07 |
| gibi | mriedem, melwitt: I agree. I can create a new bp for stein | 16:07 |
| melwitt | mriedem: I was planning to close them tomorrow on RC day. are they supposed to be closed sooner than that usually? | 16:08 |
| *** derekh has quit IRC | 16:08 | |
| melwitt | the notification one and the mox one | 16:08 |
| dansmith | melwitt: did you see my comment about rpc aliases on the rc1 pad? | 16:08 |
| *** derekh has joined #openstack-nova | 16:09 | |
| melwitt | dansmith: I saw a comment yes, saying rc2 if we have one, else just before rc1 | 16:09 |
| dansmith | yup | 16:09 |
| melwitt | I don't think we're anticipating a rc2, are we mriedem? | 16:10 |
| dansmith | in the past we had an obligatory rc2 for translations or something, but not sure that happens anymore | 16:11 |
| dansmith | which is why I said that | 16:11 |
| melwitt | oh, I see | 16:11 |
| melwitt | I didn't know about that | 16:11 |
| mriedem | we shouldn't have an rc2 unless something gets reported as a major regression at the last minute | 16:12 |
| mriedem | things have actually been too quiet compared to what kind of stuff we'd had between FF and RC1 in previous relases (like ocata and pike) | 16:12 |
| mriedem | gibi: i added an item to the ptg etherpad about legacy notification deprecation | 16:13 |
| gibi | mriedem: thanks. I thought about that too as we have a good chance to finish the transformation in Stein | 16:13 |
| mriedem | unfortunately getting the projects consuming nova's notifications switched over to versioned would likely rest on our shoulders | 16:14 |
| gibi | mriedem: yeah, I understand. I don't know how will we have time for such work | 16:15 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add the guideline to write API reference https://review.openstack.org/569058 | 16:15 |
| gibi | mriedem: besides that we communicate the deprecation and help answering questions | 16:16 |
| mriedem | we probably won't | 16:16 |
| mriedem | searchlight is in maintenance mode | 16:16 |
| mriedem | designate has like 2 active contributors | 16:16 |
| mriedem | telemetry is in the same boat? | 16:16 |
| mriedem | not sure about mistral | 16:16 |
| mriedem | there are likely other projects consuming nova's notifications that i'm not thinking of, maybe blazar and masakari? | 16:16 |
| mriedem | i wonder if we could write some kind of conversion middleware | 16:17 |
| gibi | maybe watcher too but yeah | 16:17 |
| melwitt | have we sent a dev ML mail before about it? to find out who might be interested in switching over? | 16:17 |
| mriedem | for projects as a crutch until they can consume versioned notifications natively | 16:17 |
| mriedem | gibi had an etherpad at one point | 16:17 |
| *** gbarros has joined #openstack-nova | 16:17 | |
| mriedem | no other project has talked about switching over as far as i know, | 16:18 |
| *** gbarros has quit IRC | 16:18 | |
| mriedem | because as noted, they are short-staffed projects and doing that switch would be very low priority for them | 16:18 |
| melwitt | yeah. I wasn't sure if they knew about the new stuff or not | 16:18 |
| gibi | melwitt: there was couple of mails on the ML about the fact that we are woring on such transformation and I got positive response from telemetery at least | 16:18 |
| melwitt | a-ha, cool | 16:19 |
| *** masayukig has joined #openstack-nova | 16:19 | |
| *** dpawlik has joined #openstack-nova | 16:19 | |
| gibi | melwitt: but I'm totally agree to repeate the mail about the new interface, asking for current willingness to transform | 16:20 |
| melwitt | gibi: yeah, I know you've been sending the regular mails about notification work but I wasn't sure how much that translated to other projects realizing there are new features available that they might be interested in using. just a thought | 16:21 |
| gibi | melwitt: yeah. So I can write a mail to the bigger audience (even tagging the project mriedem listed about in the subject) about the current state of the work and asking them about the willingnes to transition to the new interface | 16:22 |
| melwitt | might be moot since as was said, the projects we can think of that consume notifications are really short-staffed at this point. other than maybe telemetry | 16:22 |
| melwitt | gibi: cool, might be worth a shot | 16:23 |
| gibi | melwitt: I made a note on my desk, I will do the mail tomorrow. | 16:24 |
| melwitt | k | 16:24 |
| *** dpawlik has quit IRC | 16:24 | |
| *** holser_ has quit IRC | 16:27 | |
| *** sahid has quit IRC | 16:27 | |
| *** moshele has joined #openstack-nova | 16:30 | |
| melwitt | mriedem: should I close out the notifications and mox blueprints now? when do you usually close them? | 16:31 |
| *** efoley has quit IRC | 16:31 | |
| *** imacdonn has quit IRC | 16:38 | |
| *** imacdonn has joined #openstack-nova | 16:39 | |
| mriedem | at FF | 16:39 |
| melwitt | ok | 16:41 |
| *** dklyle has quit IRC | 16:43 | |
| melwitt | versioned notifications bp from queens was closed at RC1, so I was following that https://blueprints.launchpad.net/nova/queens | 16:45 |
| *** moshele has quit IRC | 16:45 | |
| melwitt | next time I'll do FF | 16:45 |
| melwitt | mox and versioned notifications bps are now closed for rocky | 16:47 |
| *** gyee has joined #openstack-nova | 16:52 | |
| melwitt | dansmith: I think we're a go for the RPC version aliases since we're not anticipating a RC2 | 17:07 |
| dansmith | alright | 17:08 |
| dansmith | wow, zero compute rpc changes in rocky | 17:09 |
| dansmith | and we haven't updated the non-compute aliases in a while | 17:11 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Update compute rpc version alias for rocky https://review.openstack.org/589972 | 17:12 |
| melwitt | are we supposed to update them every release? | 17:13 |
| melwitt | yeah, I see conductor last one was ocata | 17:13 |
| dansmith | well, our docs say that you can use release names in the [upgrade_levels] things, | 17:13 |
| dansmith | but we don't really support anything other than compute being backlevel, so.. | 17:13 |
| melwitt | oh, ok | 17:14 |
| dansmith | also, we have't had rpc bumps in the other services in a long time, | 17:14 |
| dansmith | which also means that once you're a couple versions into the unchanged-ness, there's nothing really needing to be pinned to an old version | 17:14 |
| dansmith | so, all that is to say.. meh I guess? | 17:14 |
| melwitt | hey, it helps me understand it :) | 17:15 |
| *** derekh has quit IRC | 17:18 | |
| *** dklyle has joined #openstack-nova | 17:21 | |
| melwitt | any major rpc version bumps we want to do? https://wiki.openstack.org/wiki/RpcMajorVersionUpdates | 17:26 |
| melwitt | looking through https://wiki.openstack.org/wiki/Nova/ReleaseChecklist | 17:26 |
| melwitt | "Merge latest translations" what does that mean? | 17:27 |
| dansmith | translation patches which we don't have anymore I think | 17:29 |
| *** sambetts is now known as sambetts|afk | 17:29 | |
| melwitt | ah, ok | 17:29 |
| dansmith | I think we already discussed the major bumps.. I looked around and none seem particularly fruitful at the moment, | 17:29 |
| dansmith | and compute hasn't changed all cycle | 17:29 |
| melwitt | okay, thanks. I must not have connected the dots to this checklist | 17:30 |
| mriedem | the only thing i mentioned to dan earlier (a week or two ago) was scheduler rpcapi, | 17:32 |
| mriedem | there are some "drop in 5.x" stuff in there | 17:32 |
| mriedem | but nothing critical | 17:32 |
| dansmith | yeah, but I looked at it, I don't think it's worth the trouble | 17:32 |
| mriedem | this is also gross https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L325 | 17:33 |
| mriedem | but meh | 17:33 |
| mriedem | that code probably dies in stein when i can drop the legacy reqspec compat stuff | 17:33 |
| * mriedem sharpens the blade | 17:33 | |
| melwitt | heh | 17:33 |
| openstackgerrit | Merged openstack/nova master: conf: Deprecate 'network_manager' https://review.openstack.org/530923 | 17:40 |
| *** moshele has joined #openstack-nova | 17:40 | |
| *** moshele has quit IRC | 17:44 | |
| *** mdbooth has quit IRC | 17:57 | |
| *** dklyle has quit IRC | 17:57 | |
| openstackgerrit | Merged openstack/python-novaclient master: Use uuidutils of oslo.utils https://review.openstack.org/589717 | 18:00 |
| *** jpena is now known as jpena|off | 18:07 | |
| *** dklyle has joined #openstack-nova | 18:09 | |
| *** itlinux has joined #openstack-nova | 18:12 | |
| cdent | my stats thank you mriedem | 18:19 |
| *** moshele has joined #openstack-nova | 18:20 | |
| *** moshele has quit IRC | 18:21 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add functional test for affinity with multiple cells https://review.openstack.org/585073 | 18:23 |
| openstackgerrit | melanie witt proposed openstack/nova master: Make scheduler.utils.setup_instance_group query all cells https://review.openstack.org/540258 | 18:23 |
| mriedem | cdent: heh because i approved 2 changes in 2 days? | 18:28 |
| *** ircuser-1 has quit IRC | 18:30 | |
| *** dklyle has quit IRC | 18:31 | |
| *** dklyle has joined #openstack-nova | 18:34 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Use TLSv1.2 for secure VNC access https://review.openstack.org/589992 | 18:35 |
| *** janki has quit IRC | 18:37 | |
| cdent | mriedem: no for assigning that ancient bug t me | 18:46 |
| mriedem | oh heh | 18:47 |
| mriedem | yeah doing some late summer cleaning | 18:47 |
| *** sapd has quit IRC | 18:49 | |
| *** dklyle has quit IRC | 18:59 | |
| dansmith | mriedem: melwitt assuming no cells meeting today | 19:08 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: FakeDriver: adding and removing instances on live migration. https://review.openstack.org/243613 | 19:09 |
| mriedem | i don't think i have any major developments since last week, | 19:09 |
| mriedem | as of yesterday, it sounds like tssurya's handling a down cell spec will need to also account for doing server group calculations where members are in a down cell | 19:09 |
| mriedem | and what we do in that case | 19:09 |
| melwitt | yeah, that. and the multi-cell affinity bug fix of mine is finally ready for review again, I got a decent functional test working with it https://review.openstack.org/540258 | 19:10 |
| dansmith | ack, since FF I've been assuming we'll pick that up after things open up | 19:11 |
| dansmith | melwitt: yeah but not until after rc1 at least right? | 19:11 |
| melwitt | and got rid of the unit test malarkey | 19:11 |
| melwitt | dansmith: yeah. given the timing and the latentness + multi-cell-only nature, wait until after rc1 | 19:11 |
| melwitt | was just bringing it up for celly info | 19:13 |
| mriedem | in cells related news, i pushed up a fix for this over the weekend https://review.openstack.org/#/c/588943/ | 19:14 |
| mriedem | follows the same pattern as cleaning up instance mappings and reqspecs for archived instances | 19:14 |
| dansmith | ah yeah | 19:14 |
| melwitt | for the multi-cell affinity, I could also see it being, wait for stein and backport to rocky, queens, pike. whatever you all think is best | 19:17 |
| *** tbachman has quit IRC | 19:17 | |
| mriedem | you already said that was the plan above yeah? | 19:29 |
| mriedem | "yeah. given the timing and the latentness + multi-cell-only nature, wait until after rc1" | 19:29 |
| mriedem | maybe you meant rc2? | 19:30 |
| mriedem | tbc, we generally shouldn't assume/expect an rc2 | 19:30 |
| mriedem | otherwise we failed at rc1 | 19:30 |
| dansmith | I don't think we should do an rc2 for that | 19:30 |
| mriedem | i remember loving explaining how we did rc's upstream to our downstream PMs at ibm since i tried to model the same release process | 19:30 |
| mriedem | "ok so when do we do rc2 and rc3?" | 19:31 |
| mriedem | "we don't, get your fixes into rc1 or don't cut rc1" | 19:31 |
| mriedem | "BUT!!!" | 19:31 |
| dansmith | well, we did have those couple of cycles where we always had an rc2 for translations on the things we got into rc1 | 19:31 |
| mriedem | right, but the PMs at ibm planned for multiple candidates because they knew we had a backlog of bugs | 19:31 |
| mriedem | total waterfall | 19:31 |
| dansmith | heh yeah, and, | 19:31 |
| dansmith | why call it rc1 if there's no rc2 amirite/ | 19:32 |
| mriedem | that's deep | 19:32 |
| dansmith | it's like an outline with one bullet.. no larger sin. | 19:32 |
| melwitt | yeah, sorry, I meant rc2 vs wait until stein, that I was asking of you both | 19:32 |
| mriedem | i'd say stein | 19:32 |
| dansmith | for sure | 19:32 |
| melwitt | k, cool | 19:32 |
| mriedem | make sure there is no immediate regression, | 19:32 |
| mriedem | then backports | 19:32 |
| sean-k-mooney | mriedem: nova is pretty waterfall too in general that said the runways has made nova mor agile this cycle | 19:32 |
| * dansmith groans at the a-word | 19:33 | |
| mriedem | hey man | 19:33 |
| melwitt | so what about the placement perf thing? just try to land it for RC1 and not wait for RC2? | 19:33 |
| mriedem | melwitt: my understanding on that is there are 2 fixes | 19:33 |
| mriedem | cdent's is the more important of the two and is already approved | 19:33 |
| melwitt | that's correct. one is approved, other is up for review | 19:33 |
| mriedem | i.e. cdent's drops the perf by 50% | 19:33 |
| mriedem | jay's drops that another 50% | 19:33 |
| sean-k-mooney | dansmith: :) most of intel liked that word but followed water-scurm-fall developemnt instead | 19:34 |
| mriedem | i'm pretty sure my first 10 years at ibm the dev model was really code-and-fix | 19:34 |
| *** tbachman has joined #openstack-nova | 19:34 | |
| mriedem | the bestest of models | 19:34 |
| mriedem | melwitt: i'll defer to efried and cdent and the placement boyz on how comfortable they are on jay's fix for rc2 | 19:35 |
| sean-k-mooney | mriedem: by drops the perf by 50% do you mean makes it better or worse | 19:35 |
| mriedem | improves perf by 50% | 19:35 |
| sean-k-mooney | :) | 19:35 |
| mriedem | it's the dpdk of patches | 19:36 |
| sean-k-mooney | mriedem: really fast and imposible to debug | 19:36 |
| mriedem | heh that's a pretty good analogy for placement | 19:36 |
| melwitt | mriedem: okay, sounds fair. efried and cdent, let me know what you think of it once you've reviewed | 19:37 |
| jaypipes | melwitt: re: https://bugs.launchpad.net/nova/+bug/1746863, I thought we'd always said server groups were restricted to a single cell. is that not the case? | 19:38 |
| openstack | Launchpad bug 1746863 in OpenStack Compute (nova) "scheduler affinity doesn't work with multiple cells" [High,In progress] - Assigned to melanie witt (melwitt) | 19:38 |
| cdent | melwitt, mriedem : I'm happy to see them both go in | 19:38 |
| melwitt | what is your assessment of the risk of the change somehow making the final release worse? | 19:39 |
| *** tbachman has quit IRC | 19:39 | |
| mriedem | jaypipes: it's totally possible to have server group members wind up unintentionally in separate cells | 19:39 |
| mriedem | even if in an affinity group | 19:40 |
| cdent | melwitt: we talking about the placement thing on "final release worse"? the risk in those changes is very very low. the value is very very high. | 19:40 |
| melwitt | jaypipes: they are, in a sense that affinity means same host (cells or not) and anti-affinity means different hosts. but the bug is that if you land on hostA for your first instance, because we don't look for members in all cells, we won't find that a group member is on hostA and therefore we need to co-locate instance2 to hostA for affinity if you want to add another host. I hope that makes sense | 19:41 |
| sean-k-mooney | mriedem: jaypipes i guess mabe you should use dansmith's pre placement filter stuff to avoid that. | 19:41 |
| melwitt | jaypipes: *if you want to add another instance | 19:41 |
| sean-k-mooney | *could use | 19:41 |
| mriedem | sean-k-mooney: how? | 19:42 |
| melwitt | cdent: yeah, exactly. thanks for confirming it is low risk | 19:42 |
| mriedem | placement doesn't know about server groups | 19:42 |
| mriedem | nor cells | 19:42 |
| dansmith | well, if we had a same-resource-provider thing we could kindof hack up a thing to do it via placement | 19:42 |
| dansmith | but agree, it's not easy | 19:43 |
| dansmith | it would be trivial to just fail a boot request for affinity if we can't talk to the cell where the other members are | 19:43 |
| sean-k-mooney | mriedem: well the pre filter is for tenant affinity to a cell. i was thicnking if we had a request in a server group we could have a prefiltr that just picks a cell and only trys to place within that cell for the entire group | 19:43 |
| dansmith | since we clearly can't honor the affinity goal | 19:43 |
| dansmith | sean-k-mooney: that doesn't help us | 19:44 |
| dansmith | sean-k-mooney: you might not be keeping tenants to cells | 19:44 |
| mriedem | dansmith: yeah i think that's what gibi said on mel's patch | 19:45 |
| sean-k-mooney | dansmith: i was not suggesting it was a depency just that if we detected there was an affinity group the only consider 1 cell for the request | 19:45 |
| *** rmart04 has joined #openstack-nova | 19:45 | |
| dansmith | mriedem: ack, haven't looked | 19:45 |
| sean-k-mooney | dansmith: anyway it was just a tought. | 19:45 |
| mriedem | we can still race our way around affinity and wind up in different cells | 19:45 |
| *** rmart04 has quit IRC | 19:45 | |
| mriedem | if you create the servers at the same time | 19:45 |
| *** tbachman has joined #openstack-nova | 19:46 | |
| mriedem | and i think the late up-call doesn't help you there either | 19:46 |
| mriedem | but it's been awhile since i've thought about this | 19:46 |
| sean-k-mooney | ya ther isent really a way around that if you have multiple schdulers acitve. | 19:46 |
| dansmith | we should be able to handle the race to multiple cells I think | 19:46 |
| dansmith | if we're the first instance in a group, we schedule to any cell.. if we're not, we restrict to that cell, if we thought we were and then end up being the second one after a no-restriction thing, we reschedule | 19:47 |
| dansmith | should be easy to check the mappings of other members to see if they're set to catch the last case I think | 19:47 |
| sean-k-mooney | dansmith: would that not reqiure an up call from the compute to the top level cells db | 19:48 |
| dansmith | no | 19:48 |
| dansmith | it's all done in the scheduling superconductor loop | 19:48 |
| mriedem | we don't reschedule within superconductor... | 19:48 |
| dansmith | but we can | 19:49 |
| dansmith | we don't currently because we shouldn't need to | 19:49 |
| dansmith | scheduler re-queries if it can't claim resources, and conductor doesn't know if a compute will fail, so it can't reschedule at that point, | 19:49 |
| dansmith | but if we have a reason, like we go create the instance in a cell, and then learn we lost the race, we can reschedule before we map that instance | 19:49 |
| dansmith | you know, | 19:50 |
| dansmith | I was going to spout off another potential way to solve the need for the affinity upcall in a similar way, but I need to think about that for a sec | 19:52 |
| dansmith | but regardless for the cell race I think we can manage it in superconductor | 19:52 |
| sean-k-mooney | dansmith: is there any reason we dont create placement aggregates for cells out of interest? | 19:54 |
| *** awaugama has quit IRC | 19:55 | |
| melwitt | I hope somebody can write down these ideas somewhere so we don't forget in stein | 19:55 |
| sean-k-mooney | if we did that consider a cell is just a member-of right? | 19:55 |
| sean-k-mooney | all the info to create the aggregate is already in the cell mapping table | 19:56 |
| dansmith | sean-k-mooney: I don't want to leak cells outside of nova in any way | 19:56 |
| dansmith | sean-k-mooney: and I definitely don't want to auto-create aggregates in nova that align to cells | 19:56 |
| sean-k-mooney | dansmith: aggregates in placement auto-created by nova you mean | 19:57 |
| dansmith | sean-k-mooney: definitely not auto-created in nova, but probably not really in placement either | 19:57 |
| dansmith | we can already filter hosts by cell in the scheduler | 19:59 |
| sean-k-mooney | well a placement aggreate is just a group of resouce providers. there is no real inherint semantics beyond that. so you can model cells or regions or host aggregats equally | 19:59 |
| sean-k-mooney | dansmith: true but if there was a agregate associated with placement could ignore everything not in that aggregate | 20:00 |
| sean-k-mooney | anyway its just an idea. | 20:00 |
| openstackgerrit | Merged openstack/nova master: Refactor cell_type in compute/api.py https://review.openstack.org/589833 | 20:00 |
| *** dklyle has joined #openstack-nova | 20:05 | |
| *** ircuser-1 has joined #openstack-nova | 20:05 | |
| *** luzC has quit IRC | 20:07 | |
| *** luzC has joined #openstack-nova | 20:09 | |
| *** itlinux has quit IRC | 20:12 | |
| *** holser_ has joined #openstack-nova | 20:13 | |
| *** luksky has joined #openstack-nova | 20:13 | |
| melwitt | mriedem: don't forget to please review these ocata quota fixes before you go on vacay https://review.openstack.org/588416 and the one above it | 20:21 |
| mriedem | oh right | 20:22 |
| *** dpawlik has joined #openstack-nova | 20:24 | |
| *** cdent has quit IRC | 20:31 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add a prelude release note for the 18.0.0 Rocky GA https://review.openstack.org/589303 | 20:39 |
| *** slagle has joined #openstack-nova | 20:39 | |
| openstackgerrit | Sergii Golovatiuk proposed openstack/nova master: libvirt: Always escape IPv6 addresses when used in migration URI https://review.openstack.org/589548 | 20:51 |
| *** dpawlik has quit IRC | 20:57 | |
| *** dklyle has quit IRC | 20:58 | |
| *** tbachman has quit IRC | 21:00 | |
| *** dklyle has joined #openstack-nova | 21:02 | |
| *** gbarros has joined #openstack-nova | 21:06 | |
| openstackgerrit | Sergii Golovatiuk proposed openstack/nova master: libvirt: Always escape IPv6 addresses when used in migration URI https://review.openstack.org/589548 | 21:07 |
| *** dklyle has quit IRC | 21:07 | |
| *** pcaruana has joined #openstack-nova | 21:07 | |
| *** holser_ has quit IRC | 21:11 | |
| *** holser_ has joined #openstack-nova | 21:12 | |
| *** slagle has quit IRC | 21:13 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041 | 21:13 |
| *** slagle has joined #openstack-nova | 21:14 | |
| jaypipes | mriedem, dansmith: is there a way to boot a Nova VM on behalf of another user/project? | 21:16 |
| dansmith | I think that has been requested before | 21:16 |
| jaypipes | mriedem: alternately, is there a way to transfer ownership of an instance once its been created? | 21:16 |
| dansmith | also requested | 21:16 |
| jaypipes | pretty sure that latter thing has been requested a few times, yeah | 21:16 |
| melwitt | haha, Oath questions | 21:16 |
| dansmith | yup | 21:17 |
| jaypipes | :) | 21:17 |
| jaypipes | melwitt: yup. trying to see if we can chuck the "ytenant" patches. | 21:17 |
| melwitt | yeah, I kept talking about it for years "on behalf of" but there's not even support for that in keystone either, from what I understand. there's no such thing as a credential that records "I am A and I have obtained a token for B" | 21:18 |
| jaypipes | mriedem, dansmith: BTW, https://review.openstack.org/#/c/590041 is all about that "debugging scheduler filters" thing... | 21:18 |
| jaypipes | mriedem, dansmith: or rather the "NoValidHosts oh noes!" thing. | 21:19 |
| jaypipes | bnemec-pto: https://review.openstack.org/#/c/590041 | 21:19 |
| dansmith | both would be complicated, especially around image, flavor, and affinity things that would be violated by the new tenant | 21:19 |
| openstackgerrit | Merged openstack/nova master: xx_instance_type_id in list_migrations should be integer https://review.openstack.org/588481 | 21:19 |
| melwitt | yeah, transfer of ownership would be very difficult | 21:20 |
| *** priteau has quit IRC | 21:20 | |
| melwitt | but for "on behalf of", an idea I had was if we were to take a --project-id, --user-id parameter to nova boot, that you could pass if you're admin, then we create the instance with the given project/user instead of the admin's. and we'd have to record in the logs that it happened, "Project/user admin/admin has requested instance create for person/person" so it's traceable in some way | 21:23 |
| *** slagle has quit IRC | 21:23 | |
| dansmith | well, | 21:24 |
| dansmith | presumably you get admin's access to images and flavors? | 21:24 |
| dansmith | so what do we do if the user tries to rebuild? | 21:24 |
| dansmith | or resize? | 21:24 |
| dansmith | and do you get admin's affinity or the user's? | 21:24 |
| melwitt | the project/user recorded in the database will be theirs (the user's), not the admins | 21:24 |
| dansmith | what about when they rebuild/resize/etc? | 21:24 |
| melwitt | after the admin creates it, no more admin involved | 21:24 |
| dansmith | which means they can't rebuild if the admin built with an image they can't access yeah? | 21:25 |
| jaypipes | dansmith: it's a "let's have the admin hand-hold you for a little while, then after that, you can use it" sort of anti-feature. | 21:25 |
| melwitt | dansmith: yeah | 21:25 |
| dansmith | jaypipes: yes, anti-feature is a good name for it :) | 21:25 |
| melwitt | yeah. I can't really remember why they want it | 21:26 |
| dansmith | jaypipes: without a lot of inbuilt support for that workflow, it sounds like the kind of thing that will always have a million caveata | 21:26 |
| dansmith | like shelve | 21:26 |
| melwitt | because admin can act upon all user's instances already, except for create, if I'm remembering correctly | 21:26 |
| melwitt | that is, an admin can delete a normal user's instance, etc | 21:27 |
| dansmith | well, that's a terrible reason, but I know what you mean :) | 21:27 |
| melwitt | haha, sorry, wasn't using it as a reason | 21:27 |
| melwitt | I mentioned it in the context of, I can't remember why they need it for create, being that admin can already do everything else to normal user instances | 21:28 |
| dansmith | I know | 21:29 |
| *** gbarros has quit IRC | 21:29 | |
| *** mriedem has quit IRC | 21:30 | |
| *** mriedem has joined #openstack-nova | 21:31 | |
| melwitt | jaypipes: fwiw, you might be able to solve it at the keystone level, like if you could present keystone with admin creds and then receive back a token for another user (if you have the appropriate role), then it would be transparent to nova. the context nova receives would be for the wanted user | 21:31 |
| melwitt | like if there were a role, "Allowed to act on behalf of project X" that admin type users could be a part of | 21:32 |
| dansmith | or write a half page doc for your users on how to boot their first instance | 21:33 |
| mriedem | dansmith: we have a bug for that with shelve, | 21:34 |
| melwitt | yeah, I can't remember what it's for, something automated where a headless user is doing it | 21:34 |
| mriedem | user creates server, | 21:34 |
| mriedem | admin shelves it, | 21:34 |
| mriedem | user unshelves, | 21:34 |
| mriedem | kablammo | 21:34 |
| dansmith | boom | 21:35 |
| dansmith | heh yeah | 21:35 |
| mriedem | b/c user doesn't have access to the admin snapshot | 21:35 |
| dansmith | yar | 21:35 |
| melwitt | that's fun | 21:35 |
| melwitt | I guess the keystone idea would solve that issue | 21:35 |
| mriedem | i'm pretty sure it's a relatively straight-forward fix, just haven't ever had the proper motivation to work on it | 21:35 |
| mriedem | no no no | 21:35 |
| mriedem | when we snapshot, we make the instance owner (the user) have member access to the image | 21:35 |
| mriedem | glance has a thing for that | 21:36 |
| mriedem | https://specs.openstack.org/openstack/glance-specs/specs/api/v1/requesting_image_memberships.html | 21:36 |
| mriedem | https://specs.openstack.org/openstack/glance-specs/specs/api/v1/adding_a_member_to_an_image.html | 21:36 |
| melwitt | neat | 21:36 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1675791 | 21:37 |
| openstack | Launchpad bug 1675791 in OpenStack Compute (nova) "Instance created by demo user(non-admin), shelved by admin and unshelved by demo user --> ends up in error state " [Medium,Triaged] - Assigned to Damini Chopra (damini) | 21:37 |
| openstackgerrit | Merged openstack/nova master: Add explicit functional-py36 tox target https://review.openstack.org/589825 | 21:38 |
| openstackgerrit | Merged openstack/nova master: Add the guideline to write API reference https://review.openstack.org/569058 | 21:38 |
| mriedem | speaking of changing stuff on unshelve https://review.openstack.org/#/c/559828/ | 21:39 |
| melwitt | you've opened the shelve bug bin | 21:40 |
| mriedem | time to create a shelve sig | 21:42 |
| mriedem | / support group | 21:42 |
| mriedem | for admins that have enabled that api | 21:42 |
| melwitt | lol | 21:42 |
| *** gbarros has joined #openstack-nova | 21:46 | |
| mriedem | melwitt: dansmith: a couple of thoughts in this ocata-only func test https://review.openstack.org/#/c/588416/ | 21:53 |
| mriedem | if you wanted to make it less unit-y | 21:53 |
| dansmith | mriedem: I definitely think this is a unit test, as I said | 21:55 |
| mriedem | i guess you don't actually start conductor when using NoopConductorFixture | 21:55 |
| melwitt | argh, I thought I had to write it this way to fit in with the pattern of regression tests | 21:56 |
| melwitt | whichever one it needs to be, I always pick the wrong one :) | 21:56 |
| openstackgerrit | Merged openstack/nova master: Remove Neutron MetaAPIProxy from cellsv2-layout https://review.openstack.org/588525 | 21:56 |
| mriedem | i'm a tad confused on the stub in the 2nd test | 21:58 |
| melwitt | in what way? | 21:58 |
| mriedem | it says, | 21:59 |
| mriedem | "# Stub out the API to make the instance destroy raise InstanceNotFound, | 21:59 |
| mriedem | # simulating if conductor already deleted it." | 21:59 |
| mriedem | conductor only deletes the instance if conductor gets build request not found when it goes to delete the build request, right? | 21:59 |
| *** gbarros has quit IRC | 21:59 | |
| *** imacdonn has quit IRC | 21:59 | |
| mriedem | which only happens if _attempt_delete_of_buildrequest returns True right? | 21:59 |
| melwitt | yes. I glossed over that from writing up all the other comments. O tjoml | 21:59 |
| melwitt | *,I think | 22:00 |
| melwitt | yes | 22:00 |
| mriedem | so... | 22:00 |
| mriedem | aren't the first and 2nd tests really the same thing? | 22:00 |
| mriedem | or | 22:00 |
| mriedem | i guess one is saying, | 22:00 |
| melwitt | no because the first test will commit the reservations and the second one won't and will fall into the exception handling and rollback and refresh | 22:00 |
| mriedem | the 2nd is saying, | 22:00 |
| mriedem | between the time _lookup_instance returns the instance, another request deletes the build request, so conductor deletes the instance and then request 1 fails on instance.destroy()? | 22:01 |
| melwitt | the first test never goes into the except InstanceNotFound block | 22:01 |
| melwitt | yes | 22:01 |
| mriedem | i'm not following "no because the first test will commit the reservations and the second one won't and will fall into the exception handling and rollback and refresh" | 22:02 |
| *** pcaruana has quit IRC | 22:02 | |
| mriedem | but both _lookup_instance and instance.destroy() are in the same try/except InstanceNotFound in _delete_while_booting | 22:02 |
| melwitt | I just mean the first test will not cover the except InstanceNotFound block | 22:02 |
| mriedem | so the point is, each test is covering two ways we could raise in there | 22:02 |
| melwitt | _lookup_instance does not raise InstanceNotFound | 22:02 |
| melwitt | it returns (None, None) if it catches InstanceNotFound | 22:02 |
| mriedem | oh right | 22:03 |
| mriedem | ok | 22:03 |
| melwitt | so first case is _lookup_instance returns (None, None) because it found no instance. second case is instance was found but then instance.destroy() raises because conductor deleted it out from under us after we deleted the build request but before we got to instance.destroy() | 22:04 |
| melwitt | *we deleted the build request, found the instance, and then it was gone in that small window when we got to destroy | 22:05 |
| mriedem | ok | 22:06 |
| mriedem | well, up to you on if you or dansmith want my comments addressed, if you don't care, then i don't really care much either and i'll +W | 22:06 |
| *** nicolasbock has quit IRC | 22:06 | |
| *** moshele has joined #openstack-nova | 22:06 | |
| mriedem | also, | 22:07 |
| mriedem | you're sure you're not hitting this? https://github.com/openstack/nova/blob/stable/ocata/nova/compute/api.py#L1729 | 22:07 |
| dansmith | I don't like the test on multiple fronts, | 22:07 |
| mriedem | b/c i see you're not using the AllServicesCurrent fixture | 22:07 |
| dansmith | but it seems like the fix is worth getting in, nits on the test aside | 22:07 |
| melwitt | I'd rather not have to convert them to unit tests at this point but if you want me to change it, I will | 22:07 |
| mriedem | no i'm not talking about full on re-writing them as unit tests | 22:08 |
| mriedem | i just meant with stuff like the AllServicesCurrent fixture and NoopConductorFixture | 22:08 |
| mriedem | but we must not be hitting https://github.com/openstack/nova/blob/stable/ocata/nova/compute/api.py#L1729 because your change to the tests in the next patch are ok | 22:09 |
| melwitt | yeah ... seems like it would return early because of the service version but the test does pass after the fix, which means it's getting to the quota calls somehow | 22:09 |
| dansmith | because there are no services? | 22:09 |
| mriedem | the api service is running | 22:09 |
| dansmith | I don't see why we want noopconductor over just not starting it | 22:09 |
| dansmith | but it's all just forced because this should be a unit test where it doesn't matter anyway :) | 22:10 |
| *** edmondsw has quit IRC | 22:10 | |
| melwitt | SORRY GUYS for my blasphemous functional test | 22:10 |
| mriedem | i'm just surprised that fixture isn't needed is all i'm saying | 22:10 |
| mriedem | like, why do we even need it in the first place in other func tests is my point | 22:11 |
| mriedem | thou shalt be smoten with review nit-pickery | 22:11 |
| melwitt | we have definitely needed it before. I'm not sure what's going on here | 22:11 |
| melwitt | re: ServicesCurrent | 22:11 |
| dansmith | if you have no services you get back the current I think | 22:12 |
| dansmith | we used to return zero, | 22:12 |
| *** imacdonn has joined #openstack-nova | 22:12 | |
| melwitt | the api service doesn't count as a service? | 22:12 |
| melwitt | os_apicompute | 22:12 |
| mriedem | idk, might have something to do with wsgi-intercept usage in OSAPIFixture now | 22:13 |
| dansmith | you're not starting an api service for real here | 22:13 |
| dansmith | right | 22:13 |
| melwitt | O.o | 22:13 |
| dansmith | but anyway if this was A UNIT TEST | 22:13 |
| * dansmith twists the dagger a bit more | 22:13 | |
| mriedem | we used to | 22:13 |
| mriedem | self.osapi = service.WSGIService("osapi_compute") | 22:13 |
| mriedem | self.osapi.start() | 22:13 |
| mriedem | self.addCleanup(self.osapi.stop) | 22:13 |
| melwitt | :***( | 22:13 |
| mriedem | which is probably why AllServicesCurrent was added before | 22:13 |
| *** gbarros has joined #openstack-nova | 22:13 | |
| mriedem | +W | 22:15 |
| mriedem | moving onto soul crusher #2 | 22:15 |
| * melwitt holds off on celebrating | 22:16 | |
| *** rcernin has joined #openstack-nova | 22:19 | |
| *** moshele has quit IRC | 22:25 | |
| *** holser_ has quit IRC | 22:26 | |
| *** priteau has joined #openstack-nova | 22:26 | |
| mriedem | bazinga https://review.openstack.org/#/c/582413/8 | 22:27 |
| melwitt | argh | 22:28 |
| melwitt | ok that's not so bad | 22:29 |
| mriedem | do you want/need to hold the functional test patch below it out to add checks for core and ram usage? | 22:29 |
| mriedem | or just slap those into this one | 22:29 |
| melwitt | I'm fine with adding them to the second one | 22:30 |
| *** gbarros has quit IRC | 22:37 | |
| *** hamzy_ has joined #openstack-nova | 22:40 | |
| *** hamzy has quit IRC | 22:42 | |
| *** tbachman has joined #openstack-nova | 22:48 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Docs: Add guide to migrate instance with snapshot https://review.openstack.org/584442 | 22:50 |
| *** sapcc-bot has joined #openstack-nova | 22:53 | |
| *** hongbin has quit IRC | 22:54 | |
| *** zioproto_ has joined #openstack-nova | 22:55 | |
| *** gmann_ has joined #openstack-nova | 22:55 | |
| *** r-daneel has joined #openstack-nova | 22:59 | |
| mriedem | heh https://review.openstack.org/#/c/382853/ | 23:00 |
| mriedem | i knew i'd seen this recently | 23:00 |
| mriedem | https://github.com/starlingx-staging/stx-nova/commit/71acfeae0d1c59fdc77704527d763bd85a276f9a#diff-77f9348ab09642ba46409b6828af4af0R3245 | 23:00 |
| mriedem | oct of 2016 | 23:00 |
| *** lbragstad has quit IRC | 23:01 | |
| *** amotoki_ has joined #openstack-nova | 23:01 | |
| *** stephenfin_ has joined #openstack-nova | 23:02 | |
| *** sapcc-bot3 has quit IRC | 23:02 | |
| *** evrardjp has quit IRC | 23:02 | |
| *** SamYaple has quit IRC | 23:02 | |
| *** Tahvok has quit IRC | 23:02 | |
| *** kevinbenton has quit IRC | 23:02 | |
| *** adreznec has quit IRC | 23:02 | |
| *** weezhard has quit IRC | 23:02 | |
| *** amrith has quit IRC | 23:02 | |
| *** sean-k-mooney has quit IRC | 23:02 | |
| *** mtreinish has quit IRC | 23:02 | |
| *** penick has quit IRC | 23:02 | |
| *** stephenfin has quit IRC | 23:02 | |
| *** oanson has quit IRC | 23:02 | |
| *** Gorian has quit IRC | 23:02 | |
| *** dulek has quit IRC | 23:02 | |
| *** lucasagomes has quit IRC | 23:02 | |
| *** jogo has quit IRC | 23:02 | |
| *** amotoki has quit IRC | 23:02 | |
| *** dosaboy has quit IRC | 23:02 | |
| *** gmann has quit IRC | 23:02 | |
| *** zioproto has quit IRC | 23:02 | |
| *** gmann_ is now known as gmann | 23:02 | |
| *** zioproto_ is now known as zioproto | 23:02 | |
| *** Tahvok has joined #openstack-nova | 23:03 | |
| *** kevinbenton has joined #openstack-nova | 23:03 | |
| *** mtreinish has joined #openstack-nova | 23:04 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/ocata: [stable only] Handle quota usage during create/delete races https://review.openstack.org/582413 | 23:04 |
| *** mhen has quit IRC | 23:05 | |
| *** mhen has joined #openstack-nova | 23:08 | |
| *** jogo has joined #openstack-nova | 23:09 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update nova network info when doing rebuild for evacuate operation https://review.openstack.org/382853 | 23:11 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update nova network info when doing rebuild for evacuate operation https://review.openstack.org/382853 | 23:12 |
| mriedem | wow so that evacuate fix was approved in march of 2017, | 23:15 |
| mriedem | but apparently needed a rebase | 23:15 |
| mriedem | and then no one ever mentioned needing re-approval | 23:15 |
| melwitt | yikes | 23:17 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix instance evacuation with PCI devices https://review.openstack.org/590059 | 23:18 |
| *** luksky has quit IRC | 23:26 | |
| melwitt | I'm going to propose stable releases tomorrow. I meant to do it last week but didn't get to it | 23:29 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Update nova network info when doing rebuild for evacuate operation https://review.openstack.org/590062 | 23:33 |
| openstackgerrit | Merged openstack/nova master: get provider IDs once when building summaries https://review.openstack.org/589945 | 23:34 |
| *** slaweq has quit IRC | 23:37 | |
| *** slaweq has joined #openstack-nova | 23:38 | |
| *** BrinZhang has joined #openstack-nova | 23:49 | |
| *** BrinZhang has quit IRC | 23:54 | |
| *** BrinZhang has joined #openstack-nova | 23:54 | |
| *** zhangbailin_ has joined #openstack-nova | 23:54 | |
| *** moshele has joined #openstack-nova | 23:55 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Reduce calls to qemu-img during update_available_resource https://review.openstack.org/589513 | 23:57 |
| openstackgerrit | Merged openstack/nova master: Add tempest-slow job to run the tempest slow tests https://review.openstack.org/567697 | 23:57 |
| openstackgerrit | Merged openstack/nova master: Fix bad links for admin-guide https://review.openstack.org/580259 | 23:57 |
| openstackgerrit | Merged openstack/nova master: [placement] Avoid rp.get_by_uuid in allocation_candidates https://review.openstack.org/589941 | 23:57 |
| openstackgerrit | Merged openstack/nova master: api-ref: fix min_version for parent_provider_uuid in responses https://review.openstack.org/579577 | 23:57 |
| openstackgerrit | Merged openstack/nova master: doc: mark the max microversion for rocky https://review.openstack.org/589598 | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!