| *** mrsoul has joined #openstack-nova | 00:07 | |
| *** Sundar has quit IRC | 00:12 | |
| *** gbarros has quit IRC | 00:15 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: wait for live migration vif plug short timeout https://review.openstack.org/590585 | 00:15 |
|---|---|---|
| *** dklyle has quit IRC | 00:32 | |
| *** dklyle has joined #openstack-nova | 00:32 | |
| *** markvoelker has quit IRC | 00:35 | |
| *** slagle has quit IRC | 00:36 | |
| *** gbarros has joined #openstack-nova | 00:43 | |
| *** Nel1x has joined #openstack-nova | 00:44 | |
| *** tbachman has joined #openstack-nova | 00:45 | |
| *** mtreinish has quit IRC | 00:45 | |
| *** mtreinish has joined #openstack-nova | 00:46 | |
| *** bhagyashris has joined #openstack-nova | 00:49 | |
| *** BrinZhang has joined #openstack-nova | 00:50 | |
| *** mriedem has quit IRC | 00:52 | |
| *** gbarros has quit IRC | 00:54 | |
| *** hongbin has joined #openstack-nova | 01:00 | |
| *** mtreinish has quit IRC | 01:06 | |
| *** mtreinish has joined #openstack-nova | 01:08 | |
| *** slaweq has joined #openstack-nova | 01:11 | |
| *** slaweq has quit IRC | 01:16 | |
| *** mhen has quit IRC | 01:22 | |
| *** zhurong has joined #openstack-nova | 01:23 | |
| *** mhen has joined #openstack-nova | 01:24 | |
| *** alex_xu has joined #openstack-nova | 01:27 | |
| *** mrsoul has quit IRC | 01:36 | |
| *** lbragstad has quit IRC | 01:45 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:55 | |
| *** Bhujay has joined #openstack-nova | 01:57 | |
| openstackgerrit | liuyamin proposed openstack/python-novaclient master: Replace os-client-config to openstacksdk https://review.openstack.org/590141 | 01:58 |
| openstackgerrit | Merged openstack/nova master: Update compute rpc version alias for rocky https://review.openstack.org/589972 | 02:05 |
| *** gbarros has joined #openstack-nova | 02:11 | |
| *** zhurong has quit IRC | 02:23 | |
| *** psachin has joined #openstack-nova | 02:48 | |
| *** Nel1x has quit IRC | 03:04 | |
| *** gbarros has quit IRC | 03:05 | |
| openstackgerrit | Chen proposed openstack/nova stable/ocata: Fix host validity check for live-migration https://review.openstack.org/590611 | 03:06 |
| *** bhagyashris has quit IRC | 03:07 | |
| *** gbarros has joined #openstack-nova | 03:07 | |
| openstackgerrit | Chen proposed openstack/nova stable/ocata: Fix host validity check for live-migration https://review.openstack.org/590611 | 03:10 |
| *** slaweq has joined #openstack-nova | 03:11 | |
| *** trungnv has joined #openstack-nova | 03:12 | |
| *** slaweq has quit IRC | 03:15 | |
| *** trungnv has quit IRC | 03:19 | |
| *** hongbin has quit IRC | 03:19 | |
| openstackgerrit | Chen proposed openstack/nova master: Add additional info to resource provider aggregates update API https://review.openstack.org/590243 | 03:21 |
| *** gbarros has quit IRC | 03:30 | |
| *** udesale has joined #openstack-nova | 03:49 | |
| *** BrinZhang has quit IRC | 03:50 | |
| *** BrinZhang has joined #openstack-nova | 03:51 | |
| *** Bhujay has quit IRC | 03:51 | |
| *** bhagyashris has joined #openstack-nova | 04:19 | |
| *** janki has joined #openstack-nova | 04:25 | |
| *** Bhujay has joined #openstack-nova | 04:43 | |
| *** BrinZhang has quit IRC | 04:45 | |
| *** BrinZhang has joined #openstack-nova | 04:46 | |
| *** artom has quit IRC | 04:50 | |
| *** bhagyashris has quit IRC | 04:55 | |
| openstackgerrit | Vishakha Agarwal proposed openstack/nova master: Quota details for key_pair "in_use" is 0. https://review.openstack.org/590081 | 05:04 |
| *** slaweq has joined #openstack-nova | 05:11 | |
| *** slaweq has quit IRC | 05:16 | |
| *** janki has quit IRC | 05:19 | |
| *** janki has joined #openstack-nova | 05:28 | |
| *** hoonetorg has joined #openstack-nova | 05:28 | |
| *** bhagyashris has joined #openstack-nova | 05:29 | |
| *** sambetts_ has quit IRC | 05:32 | |
| *** sambetts_ has joined #openstack-nova | 05:36 | |
| *** Dinesh_Bhor has quit IRC | 05:43 | |
| *** ratailor has joined #openstack-nova | 05:43 | |
| openstackgerrit | Rajesh Tailor proposed openstack/nova stable/ocata: Return 400 when compute host is not found https://review.openstack.org/590649 | 05:50 |
| *** nicolasbock has joined #openstack-nova | 05:50 | |
| *** BrinZhang has quit IRC | 05:51 | |
| *** BrinZhang has joined #openstack-nova | 05:52 | |
| *** brinzh has joined #openstack-nova | 05:52 | |
| *** brinzh has quit IRC | 05:53 | |
| *** BrinZhang has quit IRC | 05:53 | |
| *** brinzhang has joined #openstack-nova | 05:54 | |
| openstackgerrit | huanhongda proposed openstack/nova master: Destroy evacuated instance while unset nova-compute forced_down https://review.openstack.org/587807 | 05:56 |
| *** ratailor has quit IRC | 05:58 | |
| *** ratailor has joined #openstack-nova | 06:16 | |
| *** ratailor has quit IRC | 06:20 | |
| *** brinzhang has quit IRC | 06:22 | |
| *** brinzhang has joined #openstack-nova | 06:23 | |
| *** ratailor has joined #openstack-nova | 06:24 | |
| *** janki has quit IRC | 06:41 | |
| *** pcaruana has joined #openstack-nova | 06:43 | |
| *** bhagyashris has quit IRC | 06:48 | |
| *** ccamacho has joined #openstack-nova | 06:50 | |
| *** mvpnitesh has joined #openstack-nova | 07:01 | |
| mvpnitesh | hi all, i'm create a vm using Heat, the VM's are not getting created , they are failing with the below errors "ERROR nova.cells.messaging AttributeError: 'NoneType' object has no attribute 'identity'" and "{"message": "'NoneType' object has no attribute 'hosts'", "code": 500, "details": " File | | 07:03 |
| mvpnitesh | | | \"/opt/stack/nova/nova/conductor/manager.py\", line 585, in build_instances | | 07:03 |
| mvpnitesh | | | instance_uuids, | | 07:03 |
| mvpnitesh | | | return_alternates=True) | | 07:03 |
| mvpnitesh | | | File \"/opt/stack/nova/nova/conductor/manager.py\", line 720, in | | 07:03 |
| mvpnitesh | | | _schedule_instances | | 07:03 |
| mvpnitesh | | | scheduler_utils.setup_instance_group(context, request_spec) | | 07:03 |
| mvpnitesh | | | File | | 07:03 |
| mvpnitesh | | | \"/opt/stack/nova/nova/scheduler/utils.py\", line 836, in setup_instance_group " | 07:04 |
| *** slaweq has joined #openstack-nova | 07:05 | |
| *** slaweq has quit IRC | 07:06 | |
| *** evrardjp has joined #openstack-nova | 07:06 | |
| *** slaweq has joined #openstack-nova | 07:06 | |
| *** rcernin has quit IRC | 07:07 | |
| *** holser_ has joined #openstack-nova | 07:10 | |
| *** jaosorior has quit IRC | 07:15 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: block_device: Rollback volumes to in-use on DeviceDetachFailed https://review.openstack.org/590439 | 07:18 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: block_device: Rollback volumes to in-use on DeviceDetachFailed https://review.openstack.org/590439 | 07:20 |
| *** maciejjozefczyk has quit IRC | 07:24 | |
| *** ratailor has quit IRC | 07:25 | |
| *** janki has joined #openstack-nova | 07:27 | |
| *** brinzhang has quit IRC | 07:37 | |
| *** brinzhang has joined #openstack-nova | 07:38 | |
| *** udesale has quit IRC | 07:51 | |
| *** udesale has joined #openstack-nova | 07:51 | |
| *** jpena|off is now known as jpena | 07:55 | |
| *** josecastroleon has quit IRC | 07:58 | |
| *** josecastroleon has joined #openstack-nova | 07:59 | |
| *** mvpnitesh has quit IRC | 08:00 | |
| *** psachin has quit IRC | 08:13 | |
| *** priteau has joined #openstack-nova | 08:15 | |
| *** ratailor has joined #openstack-nova | 08:17 | |
| lyarwood | mdbooth: https://review.openstack.org/#/c/590439/ - simple bugfix if you have a second to review. | 08:20 |
| * mdbooth looks | 08:21 | |
| *** Bhujay has quit IRC | 08:23 | |
| *** psachin has joined #openstack-nova | 08:27 | |
| *** janki has quit IRC | 08:32 | |
| mdbooth | lyarwood: I wonder... what happens if we detach a volume, the detach times out in the guest, then we do roll-detaching. Then the detach succeeds in the guest (after the timeout). If we try to detach again, will the second attempt to detach from the guest fail now that it's already detached? | 08:32 |
| mdbooth | lyarwood: That doesn't impact your patch, btw | 08:32 |
| mdbooth | I just thought of it | 08:32 |
| *** derekh has joined #openstack-nova | 08:33 | |
| lyarwood | iirc that raises NoDisk or something | 08:33 |
| lyarwood | I think we catch that above | 08:33 |
| lyarwood | and continue with the cinder removal | 08:33 |
| lyarwood | DiskNotFound | 08:33 |
| lyarwood | even | 08:33 |
| *** lyarwood is now known as lyaaaaaaaaaaaaaa | 08:34 | |
| *** lyaaaaaaaaaaaaaa is now known as lyaaaaaarwood | 08:34 | |
| *** mdbooth is now known as mdb007h | 08:36 | |
| openstackgerrit | huanhongda proposed openstack/nova master: Destroy evacuated instance while unset nova-compute forced_down https://review.openstack.org/587807 | 08:41 |
| *** janki has joined #openstack-nova | 08:43 | |
| *** mvpnitesh has joined #openstack-nova | 08:56 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove patching the mock lib https://review.openstack.org/590709 | 08:59 |
| mvpnitesh | hi all, i'm creating a VM using HEAT, i'm getting the below error "{"message": "'NoneType' object has no attribute 'hosts'", "code": 500, "details": " File | 09:03 |
| mvpnitesh | \"/opt/stack/nova/nova/conductor/manager.py\", line 586, in build_instances | 09:03 |
| mvpnitesh | instance_uuids, | 09:03 |
| mvpnitesh | return_alternates=True) | 09:03 |
| mvpnitesh | File \"/opt/stack/nova/nova/conductor/manager.py\", line 714, in | 09:03 |
| mvpnitesh | _schedule_instances | 09:03 |
| mvpnitesh | scheduler_utils.setup_instance_group(context, request_spec) | 09:03 |
| mvpnitesh | File | 09:03 |
| mvpnitesh | \"/opt/stack/nova/nova/scheduler/utils.py\", line 707, in setup_instance_group | 09:03 |
| mvpnitesh | 09:03 | |
| mvpnitesh | request_spec.instance_group.hosts = list(group_info.hosts) " | 09:03 |
| *** rmart04 has joined #openstack-nova | 09:04 | |
| *** rmart04 has quit IRC | 09:05 | |
| lyaaaaaarwood | mvpnitesh: which version are you using? | 09:05 |
| mvpnitesh | i'm using master and i faced the same issue on Queens also | 09:06 |
| mvpnitesh | <lyaaaaaarwood>: Actually i'm creating a magnum cluster, i'm getting this error. If i create a normal instance using heat, i'm not getting any error | 09:07 |
| *** rmart04 has joined #openstack-nova | 09:08 | |
| *** rmart04 has quit IRC | 09:10 | |
| *** rmart04 has joined #openstack-nova | 09:11 | |
| *** tssurya has joined #openstack-nova | 09:20 | |
| *** josecastroleon has quit IRC | 09:20 | |
| lyaaaaaarwood | mvpnitesh: sorry, not sure why but request_spec.instance_group appears to be None | 09:21 |
| lyaaaaaarwood | mvpnitesh: you can workaround this by adding a simple `if request_spec.instance_group and [..]` to the conditional at the end of setup_instance_group | 09:23 |
| lyaaaaaarwood | mvpnitesh: btw can you write this up in a bug please? | 09:23 |
| mvpnitesh | lyaaaaaarwood: Sure. I'm getting this error http://paste.openstack.org/show/727798/ in nova-cell-region and http://paste.openstack.org/show/727799/ in nova-cell-child | 09:24 |
| lyaaaaaarwood | mvpnitesh: that's with the workaround? | 09:25 |
| lyaaaaaarwood | mvpnitesh: there's obviously more to this that I'm missing | 09:25 |
| mvpnitesh | lyaaaaaarwood: No without work around. Now i've to test the work around code. | 09:28 |
| *** Bhujay has joined #openstack-nova | 09:31 | |
| *** cdent has joined #openstack-nova | 09:31 | |
| *** josecastroleon has joined #openstack-nova | 09:38 | |
| *** tbachman_ has joined #openstack-nova | 09:46 | |
| *** tbachman has quit IRC | 09:46 | |
| *** tbachman_ is now known as tbachman | 09:46 | |
| *** jaosorior has joined #openstack-nova | 09:48 | |
| openstackgerrit | OpenStack Release Bot proposed openstack/nova stable/rocky: Update .gitreview for stable/rocky https://review.openstack.org/590730 | 09:53 |
| openstackgerrit | OpenStack Release Bot proposed openstack/nova stable/rocky: Update UPPER_CONSTRAINTS_FILE for stable/rocky https://review.openstack.org/590731 | 09:53 |
| openstackgerrit | OpenStack Release Bot proposed openstack/nova master: Update reno for stable/rocky https://review.openstack.org/590732 | 09:54 |
| *** gibi is now known as giblet | 09:56 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP scheduler: check request_spec.instance_group before updating https://review.openstack.org/590733 | 09:59 |
| lyaaaaaarwood | mvpnitesh: ^ | 09:59 |
| mvpnitesh | lyaaaaaarwood: Thankyou :) | 10:05 |
| *** kosamara has quit IRC | 10:05 | |
| openstackgerrit | jichenjc proposed openstack/nova master: add zvm into support matrix https://review.openstack.org/532720 | 10:20 |
| openstackgerrit | jichenjc proposed openstack/nova master: Add zvm admin intro and hypervisor information https://review.openstack.org/533125 | 10:20 |
| openstackgerrit | jichenjc proposed openstack/nova master: Add zvm CI information https://review.openstack.org/533512 | 10:20 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use placement 1.28 in scheduler report client https://review.openstack.org/583667 | 10:30 |
| openstackgerrit | Merged openstack/nova stable/pike: Add recreate test for RT.stats bug 1784705 https://review.openstack.org/588036 | 10:30 |
| openstack | bug 1784705 in OpenStack Compute (nova) pike "ResourceTracker.stats can leak across multiple ironic nodes" [High,In progress] https://launchpad.net/bugs/1784705 - Assigned to Matt Riedemann (mriedem) | 10:30 |
| *** panda|ruck|off is now known as panda|ruck | 10:33 | |
| *** udesale has quit IRC | 10:36 | |
| gryf | hi guys, is there a chance to merge this https://review.openstack.org/#/c/536351/3 ? | 10:47 |
| *** udesale has joined #openstack-nova | 10:47 | |
| *** dave-mccowan has joined #openstack-nova | 10:55 | |
| openstackgerrit | Chris Dent proposed openstack/nova stable/pike: [placement] Retry allocation writes server side https://review.openstack.org/590745 | 10:57 |
| *** rpittau has quit IRC | 11:00 | |
| *** dave-mccowan has quit IRC | 11:00 | |
| *** dtantsur|afk is now known as dtantsur | 11:01 | |
| *** jpena is now known as jpena|lunch | 11:06 | |
| *** erlon has quit IRC | 11:06 | |
| *** holser_ has quit IRC | 11:18 | |
| *** nicolasbock has quit IRC | 11:19 | |
| *** mvpnitesh has quit IRC | 11:33 | |
| *** udesale has quit IRC | 11:41 | |
| *** udesale has joined #openstack-nova | 11:42 | |
| *** cdent has quit IRC | 11:58 | |
| *** cdent has joined #openstack-nova | 12:01 | |
| *** jpena|lunch is now known as jpena | 12:02 | |
| *** jaosorior has quit IRC | 12:03 | |
| *** mriedem has joined #openstack-nova | 12:05 | |
| *** ratailor has quit IRC | 12:05 | |
| *** brinzhang has quit IRC | 12:07 | |
| *** _ix has joined #openstack-nova | 12:08 | |
| *** mriedem has quit IRC | 12:17 | |
| *** mriedem_ has joined #openstack-nova | 12:19 | |
| mriedem_ | sup! | 12:19 |
| mriedem_ | sean-k-mooney: how are you feeling about this after i re-worked it? https://review.openstack.org/#/c/587498/ | 12:22 |
| *** rpittau has joined #openstack-nova | 12:23 | |
| mriedem_ | no sahid around today? | 12:24 |
| lyaaaaaarwood | mriedem_: nope, he's out on PTO | 12:25 |
| *** mchlumsky has joined #openstack-nova | 12:26 | |
| mriedem_ | blast | 12:27 |
| mriedem_ | EU | 12:27 |
| sean-k-mooney | looking | 12:28 |
| *** udesale has quit IRC | 12:34 | |
| sean-k-mooney | mriedem_: im not sure NotImplementedError() is the most descriptive you could have chosen but it works | 12:34 |
| *** giblet is now known as giblet_ofr | 12:34 | |
| *** giblet_ofr is now known as giblet_off | 12:34 | |
| *** janki has quit IRC | 12:35 | |
| *** holser_ has joined #openstack-nova | 12:35 | |
| mriedem_ | dansmith: so i just had put a bunch of links to logs on the CI failure into your revert patch, but then must have accidentally closed the tab and it's gone now :( | 12:37 |
| *** psachin has quit IRC | 12:39 | |
| *** holser_ has quit IRC | 12:41 | |
| *** holser_ has joined #openstack-nova | 12:41 | |
| sean-k-mooney | mriedem_: are they still stored in gerrit on a different versions? or were they just never saved to the server | 12:41 |
| mriedem_ | dansmith: re-added | 12:44 |
| mriedem_ | sob, devstack overwrites my plugging timeout setting http://logs.openstack.org/08/553608/10/check/neutron-tempest-linuxbridge/2b303c2/logs/devstacklog.txt.gz#_2018-08-10_00_50_06_570 | 12:45 |
| mriedem_ | but the timeout definitely happens | 12:49 |
| mriedem_ | takes 30 seconds to transfer the guest | 12:49 |
| mriedem_ | then tempest tears down and deletes the server | 12:49 |
| mriedem_ | then we eventually see the plugging timeout after that | 12:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: fix GET /flavors?is_public description https://review.openstack.org/588092 | 12:49 |
| lyaaaaaarwood | mriedem_: just looking at the volume reschedule lack of cleanup issue we spoke about yesterday, do you have a super simple way to cause a reschedule with two computes in devstack? | 12:52 |
| lyaaaaaarwood | mriedem_: I've manually raised the Reschedule exception but instances are just ending up in an ERROR state and not being built on the other compute. | 12:53 |
| lyaaaaaarwood | and that compute is fine, has resources etc | 12:54 |
| mriedem_ | lyaaaaaarwood: so it's not rescheduling at all? | 13:01 |
| lyaaaaaarwood | mriedem_: Nope, doesn't appear to be, that was with --min-count | 13:02 |
| mriedem_ | --min-count shouldn't have anything to do with it | 13:03 |
| mriedem_ | lyaaaaaarwood: anything in the compute or cell1 conductor logs? | 13:03 |
| mriedem_ | are both computes reporting in? | 13:03 |
| mriedem_ | i.e. openstack hypervisor list shows but computes as up? | 13:03 |
| mriedem_ | and both are reporting into placement? | 13:03 |
| mriedem_ | openstack resource provider list | 13:04 |
| mriedem_ | gotta go, bbiab on the plane | 13:06 |
| *** mriedem_ has quit IRC | 13:06 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Move static _get_power_off_values to compute_utils https://review.openstack.org/578822 | 13:13 |
| *** eharney has joined #openstack-nova | 13:14 | |
| lyaaaaaarwood | huh so Alternates: [] is likely the cause | 13:17 |
| lyaaaaaarwood | http://paste.openstack.org/show/727812/ is the example | 13:17 |
| *** jaypipes is now known as leakypipes | 13:21 | |
| leakypipes | lyaaaaaarwood: aye aye matey, how be yur Friday? | 13:22 |
| lyaaaaaarwood | leakypipes: morning morning, it would be grand if these instances would reschedule arghhhhh! | 13:27 |
| lyaaaaaarwood | leakypipes: any news on your 2.0 blog post? | 13:28 |
| leakypipes | lyaaaaaarwood: just wrapping it up now after a little feedback from mordred. I'll be publishing it in an hour or two. | 13:28 |
| * mordred has opinions aboutthings | 13:28 | |
| leakypipes | lyaaaaaarwood: everyone shall hate me, so I've been preparing for that inevitability. | 13:28 |
| * leakypipes waits for the inevitable quip of "but Jay, everybody *already* hates you..." | 13:30 | |
| *** dpawlik has quit IRC | 13:30 | |
| lyaaaaaarwood | leakypipes: dansmith isn't online yet | 13:30 |
| dansmith | excuse me? | 13:30 |
| lyaaaaaarwood | whops | 13:30 |
| lyaaaaaarwood | morning | 13:31 |
| dansmith | wassup? | 13:31 |
| *** dansmith is now known as SteelyDan | 13:31 | |
| lyaaaaaarwood | SteelyDan: https://review.openstack.org/#/c/590439/ - would you mind? | 13:32 |
| SteelyDan | oh I mind | 13:32 |
| SteelyDan | I mind greatly | 13:32 |
| leakypipes | hahhaha | 13:33 |
| *** efried is now known as fried_rice | 13:35 | |
| *** holser_ has quit IRC | 13:35 | |
| *** holser_ has joined #openstack-nova | 13:36 | |
| * tobias-urdin sneak peeks -- wonder if its friday feelings in here | 13:36 | |
| SteelyDan | lyaaaaaarwood: oh you should have told me that ^ was cleaning up a mess I made | 13:38 |
| SteelyDan | I would have been less.. me.. about it | 13:38 |
| *** gbarros has joined #openstack-nova | 13:39 | |
| lyaaaaaarwood | SteelyDan: haha no issues | 13:39 |
| *** ratailor has joined #openstack-nova | 13:45 | |
| *** jistr is now known as jistr|call | 13:46 | |
| *** awaugama has joined #openstack-nova | 13:50 | |
| melwitt | . | 13:59 |
| *** jistr|call is now known as jistr | 14:00 | |
| *** hongbin_ has joined #openstack-nova | 14:03 | |
| *** eharney has quit IRC | 14:13 | |
| fried_rice | melwitt: Do we need bug tags to backport things to Rocky at this stage for RC2? | 14:21 |
| melwitt | fried_rice: what do you mean by bug tags? | 14:23 |
| melwitt | backport potential? | 14:23 |
| fried_rice | melwitt: Closes-Bug: #XXXX which is required for backporting "normally". | 14:23 |
| fried_rice | in the commit message | 14:23 |
| fried_rice | (well, I guess the existence of the bug is the important thing) | 14:24 |
| *** gbarros has quit IRC | 14:24 | |
| melwitt | oh, yeah ok, you're asking if we need a bug for something we want to backport. yes, usually. I can't remember if we ever do it without a bug | 14:24 |
| *** eharney has joined #openstack-nova | 14:26 | |
| fried_rice | lyaaaaaarwood: Do you happen to know this answer? ^ I.e. if there's a "grace period" for RCs where we don't use bugs to backport? | 14:31 |
| SteelyDan | definitely needs bugs | 14:32 |
| SteelyDan | unless it's something super procedural or something, but not sure what that would be | 14:32 |
| SteelyDan | things going into rc2 should be very prescribed anyway | 14:33 |
| melwitt | I think he means something not going into rc2, right fried_rice? | 14:33 |
| fried_rice | yes, that's what I mean | 14:33 |
| SteelyDan | he says "to backport" so.. | 14:33 |
| fried_rice | I just didn't know if, because we haven't "released" it yet, it doesn't technically count as a "backport", even though it's a cherry-pick to a non-master branch. | 14:34 |
| SteelyDan | that would be something going *into* rc2 | 14:34 |
| fried_rice | right, that's what I'm asking. | 14:34 |
| fried_rice | Mechanically, that still entails a cherry-pick to stable/rocky, right? | 14:34 |
| lyaaaaaarwood | fried_rice: no idea sorry, the stable branches are core managed until GA | 14:35 |
| SteelyDan | fried_rice: something going into rc2 right now requires a lot of scrutiny, a bug, and some agreement | 14:35 |
| fried_rice | SteelyDan: Okay, that's what I was looking for, thanks. | 14:35 |
| melwitt | lyaaaaaarwood: we had rc1 yesterday and we're going to have an rc2 to fix some things. | 14:37 |
| fried_rice | melwitt: wherezat etherpad again? | 14:37 |
| melwitt | the RC todos? https://etherpad.openstack.org/p/nova-rocky-release-candidate-todo | 14:37 |
| fried_rice | thx | 14:38 |
| lyaaaaaarwood | melwitt: and rc2 is tagged from the stable/rocky branch right? | 14:39 |
| *** gbarros has joined #openstack-nova | 14:39 | |
| melwitt | lyaaaaaarwood: it must be ... this is new to me so I'm not sure. smcginnis can you enlighten me? ^ | 14:39 |
| SteelyDan | yeah has to be :) | 14:39 |
| melwitt | ok. so stable stays frozen for some time until the final release deadline I'm guessing | 14:40 |
| lyaaaaaarwood | melwitt: yeah, so my point before was just that as a stable core I don't get +2/+W on stable/rocky until after GA | 14:40 |
| openstackgerrit | Merged openstack/nova stable/pike: Make ResourceTracker.stats node-specific https://review.openstack.org/588037 | 14:40 |
| melwitt | *stable/rocky | 14:40 |
| SteelyDan | yes | 14:40 |
| *** hongbin has joined #openstack-nova | 14:40 | |
| melwitt | lyaaaaaarwood: ok, got it | 14:40 |
| melwitt | okay, I think I understand now, thank you | 14:40 |
| *** hongbin has quit IRC | 14:41 | |
| *** hongbin has joined #openstack-nova | 14:42 | |
| *** hongbin has quit IRC | 14:42 | |
| fried_rice | um, if you don't get to +A stable/rocky, who does? (It ain't me - I still only have +1 powers there) | 14:45 |
| fried_rice | or you just mean you're not supposed to? | 14:45 |
| lyaaaaaarwood | yeah for past releases I didn't get it until after GA | 14:46 |
| lyaaaaaarwood | but I have it now | 14:46 |
| SteelyDan | I do too, so it must be on stable maint already | 14:46 |
| lyaaaaaarwood | I guess someone just copied the stable ACLs across | 14:46 |
| SteelyDan | fried_rice: why are you asking? anything you want to go to rc2 needs to be discussed heavily | 14:46 |
| *** ccamacho has quit IRC | 14:47 | |
| sean-k-mooney | fried_rice: +A on stable branch is the stable maintenance team so https://review.openstack.org/#/admin/groups/540,members | 14:47 |
| fried_rice | SteelyDan: So that I know whether open bugs and tag the patches, which I clearly do, which I'm gonna do now. | 14:47 |
| fried_rice | SteelyDan: Also adding them to the etherpad. | 14:47 |
| fried_rice | Learning process, here. | 14:47 |
| fried_rice | (As in, I'm learning what the process is) | 14:48 |
| SteelyDan | fried_rice: anything you want to *propose* for rc should get rocky-rc-potential tag in launchpad | 14:49 |
| SteelyDan | and then discuss here | 14:49 |
| fried_rice | SteelyDan: Roger, thanks. | 14:49 |
| sean-k-mooney | SteelyDan: at this point that would have to sepcificaly be a bug too and not have documentation impact? | 14:50 |
| sean-k-mooney | i was never clear on how RC fixes and string freeze mixed | 14:50 |
| SteelyDan | scrutiny goes up as the rc counter does | 14:51 |
| SteelyDan | rc1 fixes are regressions and serious things | 14:51 |
| SteelyDan | rc2 fixes are really only super serious things | 14:51 |
| SteelyDan | rc3 things have to involve the queen | 14:51 |
| *** tssurya has quit IRC | 14:52 | |
| SteelyDan | the only thing I've heard about for rc2 so far is this thing that makes live migration effectively broken for people on LB | 14:52 |
| SteelyDan | which is, you know, pretty damn serious | 14:52 |
| sean-k-mooney | SteelyDan: about that. the reason that was broken was basically the same reason we broke livimigraton with odl right | 14:53 |
| sean-k-mooney | we cant rely on teh plug event form neutron | 14:53 |
| SteelyDan | sean-k-mooney: I don't know about the latter, but matt did say ODL doesn't send plug events for live migration, so.. probably? | 14:54 |
| fried_rice | SteelyDan: But as soon as the release happens, we get a lot less serious about what we allow to be backported? | 14:54 |
| sean-k-mooney | have we deleted nova net this release because if we havent then you would never have that event either | 14:54 |
| SteelyDan | fried_rice: as soon as the release happens then rocky becomes like any other stable | 14:55 |
| SteelyDan | we have not deleted nova net | 14:55 |
| SteelyDan | but we don't wait for events if we're using nova net | 14:55 |
| SteelyDan | obviously | 14:55 |
| sean-k-mooney | SteelyDan: did the code in sahids patch pecificaly check for that | 14:56 |
| SteelyDan | all of the neutron event waiter code does | 14:56 |
| SteelyDan | he copied it from boot, so should be in there | 14:57 |
| fried_rice | is Matt already pto at this point? | 14:57 |
| sean-k-mooney | ok i was just wondering if that patch would have broken nova-net migration also | 14:57 |
| SteelyDan | if utils.is_neutron() and deadline: | 14:57 |
| *** hamzy_ is now known as hamzy | 14:57 | |
| sean-k-mooney | which would be another reason to revert if it had | 14:57 |
| SteelyDan | sean-k-mooney: ^ | 14:57 |
| sean-k-mooney | ah ok cool | 14:57 |
| melwitt | fried_rice: matt's not on PTO, traveling to china for work | 14:58 |
| fried_rice | melwitt: Oh, is he still going to be working on code? | 14:59 |
| melwitt | but I do think he's gone already and won't be around during US hours next week | 14:59 |
| *** Bhujay has quit IRC | 14:59 | |
| *** Bhujay has joined #openstack-nova | 15:00 | |
| fried_rice | melwitt: Currently just wondering whether I (or someone) should take over his patch that's on the rc2 candidate list | 15:00 |
| melwitt | not sure, depends on his schedule while he's over there, I imagine | 15:00 |
| sean-k-mooney | fried_rice: i think he said he would try to be back online again later | 15:00 |
| SteelyDan | fried_rice: which patch is that? | 15:01 |
| fried_rice | SteelyDan: https://review.openstack.org/#/c/590445/ | 15:02 |
| *** gbarros has quit IRC | 15:02 | |
| melwitt | SteelyDan: that's right, mriedem also wanted to land the "stop spamming the placement logs" patch for rc2 | 15:02 |
| SteelyDan | fried_rice: ack | 15:02 |
| SteelyDan | melwitt: ack | 15:02 |
| SteelyDan | acks for everyone | 15:02 |
| melwitt | you get an ack and you get an ack and | 15:02 |
| fried_rice | Can I get an aaaar, maybe from lyaaaaaarwood? | 15:03 |
| sean-k-mooney | fried_rice: look like cdent would like some rewording of the commit message first | 15:04 |
| fried_rice | Yeah, I'm going to ask cdent to fix it up himself, assuming that's all that's needed. | 15:04 |
| *** dpawlik has joined #openstack-nova | 15:05 | |
| cdent | yeah, I can fix that. I wasn't sure if matt was still around or not, and wasn't sure if people would really care, but that thing has proven a source of confusion before, so I didn't want us to add to it | 15:05 |
| SteelyDan | fried_rice: is this the bug you were asking about? because that patch should have a bug and be rc-potential tagged, IMHO | 15:05 |
| sean-k-mooney | i have not done anything with the logging filters but it looks reaonable at a glance | 15:05 |
| fried_rice | SteelyDan: I was actually asking about | 15:06 |
| fried_rice | https://review.openstack.org/#/c/590388/ - big perf improvement in the (for now and the near future) most common code path in GET /allocation_candidates | 15:06 |
| fried_rice | https://review.openstack.org/#/c/590041/ - debug logging in GET /allocation_candidates per http://lists.openstack.org/pipermail/openstack-dev/2018-August/132735.html | 15:06 |
| fried_rice | SteelyDan: But yeah, Matt's needs a bug too. <== cdent (If you're still super busy, I can open that up and update the commit message whenever you're done with your reword) | 15:06 |
| *** ratailor has quit IRC | 15:07 | |
| SteelyDan | fried_rice: that placement perf one going into rc2 concerns me | 15:07 |
| fried_rice | leakypipes: heads up ^ | 15:07 |
| SteelyDan | seems like good as-soon-as-we-release fodder | 15:07 |
| fried_rice | SteelyDan: Okay, that wfm; just know for sure we want it to be in Rocky. | 15:08 |
| cdent | fried_rice: i'm almost ready to context switch, so will catch up with you in a few minutes on what needs to be done | 15:08 |
| SteelyDan | it's a lot of change, no test change (presumably because it's a refactor) but.. man. | 15:08 |
| fried_rice | cdent: ack | 15:08 |
| fried_rice | SteelyDan: Yeah, confidence comes from the fact that it *didn't* break the dozen layers of testing sitting above it. | 15:08 |
| SteelyDan | it's just perf, not a critical fix, so backport after the release, IMHO | 15:08 |
| SteelyDan | I'll comment on th epad | 15:08 |
| fried_rice | Then I imagine the other one (split-out with debug messages) will be similar. | 15:09 |
| *** dpawlik has quit IRC | 15:09 | |
| SteelyDan | commented on that as well | 15:11 |
| fried_rice | rgr. I still don't quite understand what motivates the decision to put something in rc or not. Like, why is the "gold" release significant? Clearly we find bugs later and fix them, so nobody is going to be running with gold for long, are they? | 15:12 |
| cdent | fried_rice: i too have that confusion | 15:13 |
| fried_rice | I mean, I get that the process is the process, and I'm not trying to buck it (unless it really is nonsensical and just there out of momentum). Just trying to understand it. | 15:13 |
| cdent | ditto | 15:13 |
| SteelyDan | fried_rice: here you go: https://docs.openstack.org/project-team-guide/release-management.html#release-candidate-period-release-3 | 15:14 |
| *** gbarros has joined #openstack-nova | 15:16 | |
| leakypipes | fried_rice: was breakfasting... reading back. | 15:17 |
| leakypipes | SteelyDan: which perf patch are we referring to? the "use simple code paths when possible" one? | 15:17 |
| SteelyDan | leakypipes: the one that fried_rice put on the rc etherpad | 15:17 |
| SteelyDan | I've since closed it | 15:17 |
| sean-k-mooney | leakypipes: this one https://review.openstack.org/#/c/590388/ | 15:19 |
| leakypipes | sean-k-mooney: ack. I'm not going to get into the conversation about what should go in RC/stable/whatevs. That patch reduces the scheduling time for a common request for CPU, RAM and disk by around 300%. I think it's good as is but I've given up arguing about releases and RCs and whatnot. | 15:20 |
| leakypipes | sean-k-mooney: I'm more than comfortable if it goes in to an RC or if it doesn't. really won't bother me either way. | 15:21 |
| sean-k-mooney | leakypipes: o really just looking at it now. | 15:22 |
| sean-k-mooney | i take it its just avoiding a lot of work id did not need to do in the simple cases | 15:23 |
| leakypipes | sean-k-mooney: correct. | 15:24 |
| *** itlinux has joined #openstack-nova | 15:24 | |
| sean-k-mooney | cool well im going to switch to my other laptop and see if i can get triplo to finish deploying in vms... | 15:26 |
| sean-k-mooney | o/ | 15:26 |
| *** hvvcben has joined #openstack-nova | 15:30 | |
| leakypipes | sean-k-mooney: sorry, it's technically a 70% decrease in runtime. | 15:30 |
| *** mriedem has joined #openstack-nova | 15:30 | |
| mriedem | hey party people | 15:30 |
| leakypipes | sean-k-mooney: 3.69 seconds vs 1.10 seconds to perform the allocation candidates search for 1000 providers having inventory of CPU, RAM and disk | 15:31 |
| openstackgerrit | Chris Dent proposed openstack/nova master: placement: ignore policy scope check failures if not enforcing scope https://review.openstack.org/590445 | 15:31 |
| sean-k-mooney | leakypipes: clearly you should repeat the calulation 2 more times just to be sure . | 15:32 |
| sean-k-mooney | you would still finish faster :) | 15:32 |
| leakypipes | heh | 15:32 |
| fried_rice | mriedem: O hey mon, we took over ---^ because we thought you were out til at least Monday | 15:33 |
| mriedem | where is dan? | 15:34 |
| leakypipes | I was thinking of ((1.10-3.69)/1.10)*100 which would be ~235% increase in time. But the percentage decrease from 3.69 -> 1.10 is ((3.69-1.10)/3.69)*100 is ~70% decrease in time | 15:34 |
| melwitt | mriedem: SteelyDan | 15:34 |
| mriedem | oh | 15:34 |
| mriedem | SteelyDan: got that vif plug timeout to 30 seconds, hit it here http://logs.openstack.org/08/553608/11/check/neutron-tempest-linuxbridge/992de45/logs/screen-n-cpu.txt.gz#_Aug_10_13_45_47_903132 | 15:35 |
| mriedem | that's a timeout before the guest transfer completed | 15:35 |
| openstackgerrit | Merged openstack/nova master: block_device: Rollback volumes to in-use on DeviceDetachFailed https://review.openstack.org/590439 | 15:35 |
| mriedem | but it still completes http://logs.openstack.org/08/553608/11/check/neutron-tempest-linuxbridge/992de45/logs/screen-n-cpu.txt.gz#_Aug_10_13_46_13_027466 | 15:35 |
| openstackgerrit | Merged openstack/nova master: Nix 'new in 1.19' from 1.19 sections for rp aggs https://review.openstack.org/590389 | 15:35 |
| SteelyDan | yeah I saw all the comments | 15:35 |
| mriedem | this time was a bit different, more realistic but yeah | 15:36 |
| mriedem | either way it validates what we expected to happen | 15:36 |
| SteelyDan | yup | 15:36 |
| mriedem | lyaaaaaarwood: are you going to push backports for https://review.openstack.org/#/c/590439/ ? | 15:36 |
| *** Bhujay has quit IRC | 15:36 | |
| mriedem | SteelyDan: you going to touch up that reno? | 15:36 |
| mriedem | or are we waiting for sahid yet? he's on PTO | 15:36 |
| SteelyDan | mriedem: oh yeah, forgot but I can | 15:36 |
| mriedem | lemme -1 stat pad quick | 15:36 |
| *** Bhujay has joined #openstack-nova | 15:37 | |
| SteelyDan | personally I'd rather see this go in so we have soak on the changes to the driver, even though we won't exercise the waiting code | 15:37 |
| lyaaaaaarwood | mriedem: yup will do | 15:37 |
| *** rajinir has joined #openstack-nova | 15:37 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: block_device: Rollback volumes to in-use on DeviceDetachFailed https://review.openstack.org/590801 | 15:37 |
| mriedem | melwitt: now that we have a stable/rocky branch you get to create the stein series https://bugs.launchpad.net/nova | 15:38 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: block_device: Rollback volumes to in-use on DeviceDetachFailed https://review.openstack.org/590803 | 15:38 |
| melwitt | ok | 15:38 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: block_device: Rollback volumes to in-use on DeviceDetachFailed https://review.openstack.org/590804 | 15:39 |
| melwitt | mriedem: were you thinking of the DeviceDetachFailed one for rc2? from what I understand, we release rc2 from stable/rocky so we hold non-rc2 things until after the final rocky release deadline | 15:39 |
| mriedem | melwitt: we can, but it's also extremely low risk | 15:40 |
| mriedem | and we'll backport it anyway | 15:41 |
| melwitt | ok, just making sure I understood | 15:41 |
| SteelyDan | that one is a regression so it makes sense anyway right? | 15:42 |
| melwitt | mriedem: I thought we already have a stein series? https://launchpad.net/nova/stein | 15:42 |
| mriedem | SteelyDan: yes it is, and we also backported it to queens and pike | 15:42 |
| mriedem | so it's going back either way | 15:42 |
| SteelyDan | yeah | 15:43 |
| mriedem | melwitt: hmm, bugs marked against rocky are marked as fixed even though these 2 aren't yet | 15:43 |
| mriedem | might be the dev focus setting | 15:43 |
| melwitt | \:| | 15:43 |
| mriedem | melwitt: change stein status to active dev | 15:43 |
| mriedem | and rocky to current stable or whatever | 15:44 |
| melwitt | oh I see | 15:44 |
| mriedem | and dev focus = stein | 15:44 |
| mriedem | we can also mark r3 and rc1 as released in https://launchpad.net/nova/rocky and add a nrc2 | 15:44 |
| melwitt | got the dev focus. looking for the current stable setting | 15:44 |
| mriedem | that's on the rocky one | 15:45 |
| mriedem | change the status | 15:45 |
| melwitt | oh thanks. got it | 15:45 |
| mriedem | eventually you'll want to register milestones for stein as well | 15:46 |
| mriedem | based on the stein release schedule | 15:46 |
| melwitt | ok | 15:46 |
| mriedem | i don't think any of this is written down anywhere, | 15:46 |
| mriedem | i never bothered to since it's once every 6 months and it's pretty straight-forward | 15:46 |
| *** rpittau has quit IRC | 15:48 | |
| melwitt | hm, looks like I need to update the release notes link for rocky in openstack/releases | 15:48 |
| mriedem | in other news, the guy in the row in front of me ate, i'm pretty sure, at least 4 mcdonalds breakfast sandwiches and now the entire back half of the plane smells like greasy sausage and biscuit | 15:49 |
| mriedem | melwitt: yup - you can do that once we cut stable/rocky | 15:49 |
| melwitt | stable/rocky has been cut automatically because of rc1 | 15:49 |
| mriedem | right | 15:49 |
| melwitt | oh | 15:49 |
| mriedem | *you can do that now | 15:49 |
| mriedem | i always 2-stepped that | 15:50 |
| melwitt | what's the benefit of 2-stepping it? | 15:50 |
| mriedem | because i don't think the docs link exists until after the branch is created | 15:50 |
| melwitt | ah, ok | 15:50 |
| mriedem | you could also work in smcginnis' marketing speak edits on the highlights | 15:50 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Revert "libvirt: slow live-migration to ensure network is ready" https://review.openstack.org/590538 | 15:50 |
| melwitt | k | 15:51 |
| mriedem | SteelyDan: +2 | 15:53 |
| *** hvvcben has quit IRC | 15:56 | |
| *** ShilpaSD_ has joined #openstack-nova | 15:57 | |
| *** rmart04 has quit IRC | 15:57 | |
| *** gbarros has quit IRC | 15:59 | |
| melwitt | mriedem: release note link and marketing speak proposed https://review.openstack.org/590812 | 16:00 |
| melwitt | I set queens from "current stable release" => "supported" also | 16:02 |
| mriedem | yeah good idea | 16:05 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Adds a test for _get_provider_ids_matching() https://review.openstack.org/590150 | 16:07 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: use simple code paths when possible https://review.openstack.org/590388 | 16:07 |
| openstackgerrit | Eric Fried proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041 | 16:07 |
| mdb007h | Just reviewing https://review.openstack.org/#/c/504885/8 . Do we run the db migration check functional tests against a real mysql db in any CI job? | 16:08 |
| *** fried_rice is now known as fried_rolls | 16:08 | |
| *** mdb007h has quit IRC | 16:14 | |
| mriedem | melwitt: commnts on that release patch | 16:14 |
| melwitt | ok | 16:15 |
| *** Bhujay has quit IRC | 16:15 | |
| melwitt | I had thought I needed to make that change to *create* the docs at the rocky link. how wrong I was | 16:18 |
| *** jpena is now known as jpena|off | 16:22 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Revert "libvirt: add method to configure migration speed" https://review.openstack.org/590814 | 16:23 |
| mriedem | might want to ask clarkb when those get generated from stable | 16:24 |
| mriedem | or doug | 16:24 |
| melwitt | ok | 16:24 |
| mriedem | i bet we're missing a patch https://github.com/openstack/nova/blob/master/releasenotes/source/index.rst | 16:24 |
| mriedem | https://review.openstack.org/#/c/590732/ | 16:25 |
| melwitt | oh, oops | 16:25 |
| mriedem | blam http://logs.openstack.org/32/590732/1/check/build-openstack-releasenotes/7dc073e/html/ | 16:25 |
| melwitt | TIL | 16:26 |
| mriedem | i don't know if we need that in stable/rocky/ | 16:26 |
| mriedem | ? | 16:26 |
| mriedem | question for doug | 16:26 |
| mriedem | and we're landing.... | 16:26 |
| mriedem | bbiab | 16:27 |
| *** mriedem has quit IRC | 16:27 | |
| melwitt | doug says no, the release notes job always runs on master | 16:31 |
| *** purplerbot has quit IRC | 16:38 | |
| tbachman | no more purplerbot? | 16:41 |
| melwitt | SteelyDan: doug recommends a fast-approve of this .gitreview update for stable/rocky, if you could pls take a look https://review.openstack.org/590730 | 16:41 |
| SteelyDan | done | 16:43 |
| *** holser_ has quit IRC | 16:43 | |
| melwitt | ty | 16:43 |
| *** panda|ruck is now known as panda|ruck|off | 16:48 | |
| *** derekh has quit IRC | 17:01 | |
| *** dtantsur is now known as dtantsur|afk | 17:01 | |
| *** hoonetorg has quit IRC | 17:04 | |
| *** N3l1x has joined #openstack-nova | 17:13 | |
| *** hoonetorg has joined #openstack-nova | 17:19 | |
| *** gyee has joined #openstack-nova | 17:21 | |
| *** erlon has joined #openstack-nova | 17:24 | |
| *** eharney_ has joined #openstack-nova | 17:30 | |
| *** erlon has quit IRC | 17:33 | |
| *** eharney has quit IRC | 17:33 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Adds a test for _get_provider_ids_matching() https://review.openstack.org/590150 | 17:35 |
| openstackgerrit | Chris Dent proposed openstack/nova master: placement: use simple code paths when possible https://review.openstack.org/590388 | 17:35 |
| openstackgerrit | Chris Dent proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041 | 17:35 |
| *** priteau has quit IRC | 17:52 | |
| *** purplerbot has joined #openstack-nova | 17:56 | |
| openstackgerrit | Merged openstack/nova master: Update reno for stable/rocky https://review.openstack.org/590732 | 17:57 |
| openstackgerrit | Merged openstack/nova stable/rocky: Update .gitreview for stable/rocky https://review.openstack.org/590730 | 17:57 |
| openstackgerrit | Merged openstack/nova master: Quota details for key_pair "in_use" is 0. https://review.openstack.org/590081 | 17:57 |
| *** kosamara has joined #openstack-nova | 18:00 | |
| openstackgerrit | Marcus Furlong proposed openstack/nova master: improve migration script https://review.openstack.org/591030 | 18:09 |
| *** gbarros has joined #openstack-nova | 18:12 | |
| *** erlon has joined #openstack-nova | 18:14 | |
| *** erlon has quit IRC | 18:24 | |
| melwitt | SteelyDan: added comments to the revert patch. I think some unit test coverage specific to the speed limit patch was missed for reverting. let me know if I'm mistaken | 18:29 |
| SteelyDan | looking through them now | 18:30 |
| SteelyDan | most of this was conflicted out since these tests were all modified since this patch | 18:31 |
| openstackgerrit | Konstantinos Samaras-Tsakiris proposed openstack/nova-specs master: Placement model for PCI devices https://review.openstack.org/591037 | 18:31 |
| SteelyDan | it's not a straight revert regardless, so I guess I'm not sure I see the point of putting things back like the bandwidth thing as that pattern then got copied in the params stuff afterwards in some places | 18:31 |
| SteelyDan | and like the virtapi thing makes no difference | 18:31 |
| SteelyDan | and the networkinfo | 18:32 |
| SteelyDan | but the things to collect the events are probably dead now | 18:32 |
| SteelyDan | not sure I'm going to get to this before I have to relocate for the day but I'll try | 18:32 |
| melwitt | okay, it just seems like test_live_migration_main and test_live_migration_ovs_vif are duplicates of one another, essentially | 18:32 |
| SteelyDan | probably yeah | 18:33 |
| melwitt | since the networkinfo part is taken out, that was the difference between them, I thought. ok, I can add a follow up to clean that part up since you've got to run soon | 18:33 |
| melwitt | since it's just extra duplicated unit test coverage | 18:34 |
| SteelyDan | I'll take a shot and let you know if I don't push something up | 18:34 |
| melwitt | ok | 18:34 |
| SteelyDan | yeah, the second test being a duplicate now makes sense | 18:34 |
| openstackgerrit | Chris Dent proposed openstack/nova stable/ocata: [placement] Retry allocation writes server side https://review.openstack.org/591042 | 18:36 |
| SteelyDan | maybe that will all just come out easy, lemme stash and try | 18:38 |
| kosamara | efried: Hi! I've asked you some more questions on your spec. In the meantime I've published my take for review and expect to change it depending on your answers. | 18:45 |
| kosamara | efried: https://review.openstack.org/#/c/591037/ | 18:46 |
| fried_rolls | kosamara: Neat, this one: https://review.openstack.org/591037 ? | 18:46 |
| fried_rolls | okay, cool. | 18:46 |
| *** fried_rolls is now known as fried_rice | 18:47 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Revert "libvirt: slow live-migration to ensure network is ready" https://review.openstack.org/590538 | 18:48 |
| *** tssurya has joined #openstack-nova | 18:51 | |
| *** gbarros has quit IRC | 18:52 | |
| *** eharney_ is now known as eharney | 18:52 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Revert "libvirt: slow live-migration to ensure network is ready" https://review.openstack.org/590538 | 19:18 |
| *** pcaruana has quit IRC | 19:19 | |
| *** dpawlik has joined #openstack-nova | 19:20 | |
| *** dpawlik has quit IRC | 19:24 | |
| openstackgerrit | Matthew Edmonds proposed openstack/nova master: Make Xen code py3-compatible https://review.openstack.org/591061 | 19:25 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test case for multiple forbidden traits https://review.openstack.org/591070 | 19:43 |
| *** eharney has quit IRC | 19:45 | |
| *** priteau has joined #openstack-nova | 19:47 | |
| *** eharney has joined #openstack-nova | 19:57 | |
| *** itlinux has quit IRC | 19:59 | |
| *** ivve has joined #openstack-nova | 19:59 | |
| openstackgerrit | Merged openstack/nova master: Add additional info to resource provider aggregates update API https://review.openstack.org/590243 | 19:59 |
| openstackgerrit | Matthew Edmonds proposed openstack/nova master: Make Xen code py3-compatible https://review.openstack.org/591061 | 20:04 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041 | 20:11 |
| openstackgerrit | Eric Fried proposed openstack/nova master: DNM: demo https://review.openstack.org/591073 | 20:11 |
| *** priteau has quit IRC | 20:12 | |
| leakypipes | fried_rice: one sec. pulling your test patch onto the bottom. | 20:12 |
| fried_rice | leakypipes: Cool beans. I just posted my comments, as well as --^ another patch demoing some of them | 20:13 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: use simple code paths when possible https://review.openstack.org/590388 | 20:13 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041 | 20:13 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Adds a test for _get_provider_ids_matching() https://review.openstack.org/590150 | 20:13 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Test case for multiple forbidden traits https://review.openstack.org/591070 | 20:13 |
| leakypipes | fried_rice: et voila ^ | 20:13 |
| fried_rice | leakypipes: You put it on top | 20:14 |
| fried_rice | leakypipes: You also reordered the other test patch to the top. | 20:15 |
| fried_rice | leakypipes: For ease of backportage, perhaps we should squash both test patches into Gigantor. | 20:17 |
| *** cdent has quit IRC | 20:17 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Adds a test for _get_provider_ids_matching() https://review.openstack.org/590150 | 20:19 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: Test case for multiple forbidden traits https://review.openstack.org/591070 | 20:19 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: use simple code paths when possible https://review.openstack.org/590388 | 20:20 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041 | 20:20 |
| leakypipes | fried_rice: sorry bout that. fixed. | 20:20 |
| fried_rice | leakypipes: Okay, please see comments in PS6 - at least one blocker remaining. | 20:20 |
| fried_rice | s/at least// | 20:20 |
| openstackgerrit | melanie witt proposed openstack/nova master: Handle unicode characters in migration params https://review.openstack.org/591080 | 20:35 |
| *** eharney has quit IRC | 20:46 | |
| *** awaugama has quit IRC | 20:58 | |
| openstackgerrit | Merged openstack/nova master: Remove patching the mock lib https://review.openstack.org/590709 | 21:00 |
| *** mchlumsky has quit IRC | 21:11 | |
| *** dave-mccowan has joined #openstack-nova | 21:30 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041 | 21:47 |
| leakypipes | fried_rice: ^^ | 21:48 |
| fried_rice | ack | 21:48 |
| fried_rice | leakypipes: Just a few minor things. | 22:02 |
| *** imacdonn has quit IRC | 22:12 | |
| *** imacdonn has joined #openstack-nova | 22:13 | |
| *** dave-mccowan has quit IRC | 22:19 | |
| *** tssurya has quit IRC | 22:21 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041 | 22:31 |
| *** leakypipes has quit IRC | 22:31 | |
| *** ivve has quit IRC | 22:40 | |
| *** hongbin_ has quit IRC | 23:00 | |
| *** elod has quit IRC | 23:15 | |
| *** elod has joined #openstack-nova | 23:22 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!