*** gouthamr has joined #openstack-nova | 00:03 | |
openstackgerrit | Sam Morrison proposed openstack/nova master: Allow ability for non admin users to use all filters on server list. https://review.openstack.org/526558 | 00:04 |
---|---|---|
*** gyee has quit IRC | 00:13 | |
*** brinzhang has joined #openstack-nova | 00:14 | |
*** mriedem has quit IRC | 00:15 | |
*** mriedem has joined #openstack-nova | 00:19 | |
*** claudiub has quit IRC | 00:21 | |
*** mmedvede_ has joined #openstack-nova | 00:24 | |
*** mmedvede has quit IRC | 00:24 | |
*** gryf has quit IRC | 00:24 | |
*** mmedvede_ is now known as mmedvede | 00:24 | |
*** jamesdenton has joined #openstack-nova | 00:26 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | 00:36 |
*** tetsuro_ has quit IRC | 00:40 | |
*** Nel1x has joined #openstack-nova | 00:45 | |
mriedem | anyone, off the top of your head, does shelve of a volume-backed server create a snapshot of the root volume like createImage will? | 00:47 |
* mriedem looks | 00:47 | |
mriedem | oh we don't even snapshot for volume-backed | 00:48 |
mriedem | we just offload | 00:48 |
mriedem | well hells to the yeah | 00:49 |
mriedem | something went right with shelve for a change | 00:49 |
*** imacdonn has quit IRC | 00:49 | |
*** imacdonn has joined #openstack-nova | 00:50 | |
*** cdent has quit IRC | 00:51 | |
*** tetsuro has joined #openstack-nova | 00:54 | |
*** gcb_ has quit IRC | 01:00 | |
*** markvoelker has joined #openstack-nova | 01:06 | |
*** harlowja has quit IRC | 01:06 | |
*** tommylikehu has joined #openstack-nova | 01:11 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | 01:12 |
Kevin_Zheng | :) | 01:16 |
*** mrsoul has joined #openstack-nova | 01:21 | |
*** masayukig has joined #openstack-nova | 01:27 | |
*** Dinesh_Bhor has joined #openstack-nova | 01:29 | |
*** markvoelker has quit IRC | 01:40 | |
*** Dinesh_Bhor has quit IRC | 01:43 | |
*** mriedem has quit IRC | 01:48 | |
*** Dinesh_Bhor has joined #openstack-nova | 01:55 | |
*** hongbin has joined #openstack-nova | 01:57 | |
*** deepak_mourya__ has joined #openstack-nova | 02:21 | |
*** vishakha_ has joined #openstack-nova | 02:22 | |
*** BlackDex_ has joined #openstack-nova | 02:26 | |
*** dave-mccowan has quit IRC | 02:27 | |
*** alex_xu has joined #openstack-nova | 02:27 | |
*** Dinesh_Bhor has quit IRC | 02:27 | |
*** dansmith has joined #openstack-nova | 02:28 | |
*** BlackDex has quit IRC | 02:29 | |
*** hemna_ has quit IRC | 02:29 | |
*** tommylikehu has quit IRC | 02:29 | |
*** jogo has quit IRC | 02:29 | |
*** yonglihe has quit IRC | 02:29 | |
*** whoami-rajat has quit IRC | 02:29 | |
*** hughsaunders has quit IRC | 02:29 | |
*** vishakha has quit IRC | 02:29 | |
*** deepak_mourya_ has quit IRC | 02:29 | |
*** htimsnad has quit IRC | 02:29 | |
*** antonym has quit IRC | 02:29 | |
*** deepak_mourya__ is now known as deepak_mourya_ | 02:29 | |
*** vishakha_ is now known as vishakha | 02:29 | |
*** hughsaunders has joined #openstack-nova | 02:31 | |
*** jogo has joined #openstack-nova | 02:36 | |
*** hemna_ has joined #openstack-nova | 02:37 | |
openstackgerrit | zhufl proposed openstack/nova master: Blacklist test_create_server_with_tags for nova-cells-v1 https://review.openstack.org/595399 | 02:37 |
*** markvoelker has joined #openstack-nova | 02:37 | |
*** Dinesh_Bhor has joined #openstack-nova | 02:39 | |
*** psachin has joined #openstack-nova | 02:46 | |
*** Nel1x has quit IRC | 02:53 | |
*** Dinesh_Bhor has quit IRC | 03:01 | |
*** Dinesh_Bhor has joined #openstack-nova | 03:09 | |
*** masayukig has quit IRC | 03:09 | |
*** markvoelker has quit IRC | 03:11 | |
*** masayukig has joined #openstack-nova | 03:11 | |
*** hongbin_ has joined #openstack-nova | 03:21 | |
openstackgerrit | Chen proposed openstack/nova master: Normalize dashless 'resource provider create' uuid https://review.openstack.org/567191 | 03:24 |
*** hongbin has quit IRC | 03:24 | |
*** nicolasbock has quit IRC | 03:44 | |
*** Dinesh_Bhor has quit IRC | 03:45 | |
*** udesale has joined #openstack-nova | 03:47 | |
*** markvoelker has joined #openstack-nova | 04:08 | |
openstackgerrit | Chen proposed openstack/nova master: Fix create_resource_provider docstring https://review.openstack.org/595453 | 04:12 |
*** moshele has joined #openstack-nova | 04:19 | |
*** moshele has quit IRC | 04:22 | |
*** Dinesh_Bhor has joined #openstack-nova | 04:30 | |
*** abhishekk has joined #openstack-nova | 04:38 | |
*** Dinesh_Bhor has quit IRC | 04:40 | |
*** markvoelker has quit IRC | 04:41 | |
*** whoami-rajat has joined #openstack-nova | 04:48 | |
openstackgerrit | melanie witt proposed openstack/nova master: Correct the release notes related to nova-consoleauth https://review.openstack.org/595455 | 04:57 |
*** links has joined #openstack-nova | 05:00 | |
*** Dinesh_Bhor has joined #openstack-nova | 05:04 | |
*** ccamacho has quit IRC | 05:11 | |
*** ccamacho has joined #openstack-nova | 05:12 | |
*** holser_ has joined #openstack-nova | 05:13 | |
*** Dinesh_Bhor has quit IRC | 05:17 | |
*** Dinesh_Bhor has joined #openstack-nova | 05:17 | |
*** ccamacho has quit IRC | 05:19 | |
*** hongbin_ has quit IRC | 05:19 | |
*** moshele has joined #openstack-nova | 05:26 | |
*** moshele has quit IRC | 05:29 | |
*** liuyulong has joined #openstack-nova | 05:38 | |
*** markvoelker has joined #openstack-nova | 05:38 | |
*** holser_ has quit IRC | 05:40 | |
*** janki has joined #openstack-nova | 05:40 | |
*** lei-zh has joined #openstack-nova | 05:40 | |
*** gryf has joined #openstack-nova | 05:42 | |
*** Cardoe has quit IRC | 05:48 | |
*** Cardoe has joined #openstack-nova | 05:49 | |
*** lei-zh1 has joined #openstack-nova | 05:55 | |
*** lei-zh has quit IRC | 05:58 | |
*** dpawlik has joined #openstack-nova | 06:06 | |
*** ccamacho has joined #openstack-nova | 06:07 | |
*** ratailor has joined #openstack-nova | 06:09 | |
*** dpawlik has quit IRC | 06:10 | |
*** markvoelker has quit IRC | 06:12 | |
*** dpawlik has joined #openstack-nova | 06:13 | |
*** adrianc has joined #openstack-nova | 06:17 | |
*** moshele has joined #openstack-nova | 06:27 | |
*** jchhatbar has joined #openstack-nova | 06:31 | |
*** janki has quit IRC | 06:31 | |
*** pcaruana has joined #openstack-nova | 06:33 | |
openstackgerrit | zhufl proposed openstack/nova master: Blacklist test_create_server_with_tags for nova-cells-v1 https://review.openstack.org/595399 | 06:50 |
*** rcernin has quit IRC | 06:59 | |
*** markvoelker has joined #openstack-nova | 07:09 | |
*** sahid has joined #openstack-nova | 07:13 | |
*** hoonetorg has quit IRC | 07:17 | |
*** lei-zh1 has quit IRC | 07:22 | |
*** jchhatba_ has joined #openstack-nova | 07:24 | |
*** jchhatbar has quit IRC | 07:25 | |
*** hoonetorg has joined #openstack-nova | 07:29 | |
*** lei-zh1 has joined #openstack-nova | 07:32 | |
*** Dinesh_Bhor has quit IRC | 07:33 | |
*** jpena|off is now known as jpena | 07:36 | |
*** alexchadin has joined #openstack-nova | 07:38 | |
*** tssurya has joined #openstack-nova | 07:39 | |
zigo | http://paste.openstack.org/show/728659/ <--- Excuse my french but ... WTF ?!? | 07:41 |
*** markvoelker has quit IRC | 07:42 | |
*** jchhatba_ has quit IRC | 07:46 | |
*** Dinesh_Bhor has joined #openstack-nova | 07:47 | |
*** hoonetorg has quit IRC | 07:48 | |
*** jchhatba_ has joined #openstack-nova | 07:48 | |
*** ratailor has quit IRC | 07:49 | |
*** jchhatba_ has quit IRC | 07:50 | |
*** jchhatba_ has joined #openstack-nova | 07:50 | |
*** alexchadin has quit IRC | 07:55 | |
*** hoonetorg has joined #openstack-nova | 08:00 | |
*** alexchadin has joined #openstack-nova | 08:01 | |
*** owalsh has quit IRC | 08:03 | |
*** jaosorior has quit IRC | 08:10 | |
*** Dinesh_Bhor has quit IRC | 08:14 | |
*** cdent has joined #openstack-nova | 08:20 | |
*** Luzi has joined #openstack-nova | 08:23 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Only lock when race condition happens in context.set_target_cell https://review.openstack.org/595530 | 08:25 |
*** obre has joined #openstack-nova | 08:30 | |
*** dtantsur|afk is now known as dtantsur | 08:33 | |
*** markvoelker has joined #openstack-nova | 08:39 | |
*** davidsha has joined #openstack-nova | 08:44 | |
*** sean-k-mooney has joined #openstack-nova | 08:46 | |
*** tetsuro has quit IRC | 08:47 | |
*** owalsh has joined #openstack-nova | 08:48 | |
*** owalsh_ has joined #openstack-nova | 08:50 | |
*** owalsh has quit IRC | 08:53 | |
*** owalsh has joined #openstack-nova | 08:55 | |
*** gcb_ has joined #openstack-nova | 08:55 | |
*** owalsh_ has quit IRC | 08:56 | |
*** Dinesh_Bhor has joined #openstack-nova | 08:56 | |
*** jaosorior has joined #openstack-nova | 09:08 | |
*** mgoddard has joined #openstack-nova | 09:09 | |
*** markvoelker has quit IRC | 09:13 | |
*** gcb_ has quit IRC | 09:13 | |
*** jchhatba_ has quit IRC | 09:14 | |
*** jchhatba_ has joined #openstack-nova | 09:14 | |
*** egonzalez has joined #openstack-nova | 09:15 | |
*** gcb_ has joined #openstack-nova | 09:19 | |
*** Guest92900 has quit IRC | 09:19 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Only lock when race condition happens in context.set_target_cell https://review.openstack.org/595530 | 09:21 |
*** sambetts_ has joined #openstack-nova | 09:22 | |
*** lei-zh1 has quit IRC | 09:31 | |
*** holser_ has joined #openstack-nova | 09:34 | |
*** jchhatbar has joined #openstack-nova | 09:36 | |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add functional test to verify presence of policy https://review.openstack.org/595559 | 09:39 |
*** jchhatba_ has quit IRC | 09:39 | |
*** adrianc has quit IRC | 09:47 | |
*** sahid has quit IRC | 09:52 | |
*** jaosorior has quit IRC | 09:54 | |
*** adrianc has joined #openstack-nova | 09:54 | |
*** jchhatbar has quit IRC | 09:58 | |
*** markvoelker has joined #openstack-nova | 10:10 | |
*** vipul has quit IRC | 10:10 | |
*** claudiub has joined #openstack-nova | 10:14 | |
*** Dinesh_Bhor has quit IRC | 10:25 | |
*** donghm has joined #openstack-nova | 10:30 | |
*** tetsuro has joined #openstack-nova | 10:30 | |
*** chason has quit IRC | 10:39 | |
*** tetsuro has quit IRC | 10:40 | |
*** tetsuro_ has joined #openstack-nova | 10:40 | |
*** chason has joined #openstack-nova | 10:41 | |
*** alexchadin has quit IRC | 10:41 | |
*** alexchadin has joined #openstack-nova | 10:41 | |
*** alexchadin has quit IRC | 10:42 | |
*** markvoelker has quit IRC | 10:43 | |
*** abhishekk has quit IRC | 10:43 | |
*** dave-mccowan has joined #openstack-nova | 10:46 | |
*** jchhatbar has joined #openstack-nova | 10:46 | |
*** Dinesh_Bhor has joined #openstack-nova | 10:49 | |
*** tetsuro has joined #openstack-nova | 10:50 | |
*** tetsuro_ has quit IRC | 10:50 | |
*** tetsuro has quit IRC | 10:51 | |
*** tetsuro_ has joined #openstack-nova | 10:51 | |
*** Dinesh_Bhor has quit IRC | 10:52 | |
*** tetsuro has joined #openstack-nova | 10:54 | |
*** tetsuro_ has quit IRC | 10:54 | |
*** erlon has joined #openstack-nova | 10:56 | |
*** jpena is now known as jpena|lunch | 11:03 | |
*** alexchadin has joined #openstack-nova | 11:13 | |
*** sahid has joined #openstack-nova | 11:14 | |
*** holser_ has quit IRC | 11:15 | |
*** alexchadin has quit IRC | 11:18 | |
*** nicolasbock has joined #openstack-nova | 11:22 | |
*** udesale has quit IRC | 11:31 | |
openstackgerrit | Moshe Levi proposed openstack/nova master: libvirt: set vfio driver in interface hostdev https://review.openstack.org/595592 | 11:33 |
*** mriedem has joined #openstack-nova | 11:33 | |
mriedem | ahoy mateys! | 11:34 |
* kashyap waves | 11:35 | |
*** markvoelker has joined #openstack-nova | 11:40 | |
sean-k-mooney | mriedem: so i have not got a chance to test your patches for the livemigration issue yet(ill do that today) but i have noticed one other issue. | 11:42 |
sean-k-mooney | its not so much a bug just something unfortunate | 11:42 |
*** jaypipes has joined #openstack-nova | 11:42 | |
sean-k-mooney | mriedem: when hybrid_plug=false and we are not useing dpdk we hit https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/ovs.py#L216-L223 | 11:44 |
sean-k-mooney | in this config os-vif only creates the bridge and the actual pluggin is done by the hypervior e.g. libvirt | 11:44 |
sean-k-mooney | so we dont get the speed up on live migrate | 11:44 |
mriedem | what speed up on live migrate? | 11:47 |
sean-k-mooney | i know how to fix this in two way and ill start working on it after i test your changes but ya. i noticed up to a 20 second network outage when using kernel ovs with ovs contrac firewall driver but none when using ip tables as a result. | 11:47 |
*** mdrabe has quit IRC | 11:47 | |
sean-k-mooney | ya mriedem effectivly the plug does not happen untill libvirt creates the vm on the dest. | 11:47 |
mriedem | ok | 11:48 |
mriedem | i'll take your word for it :) | 11:48 |
jaypipes | morning supernovas | 11:48 |
mriedem | hello jay | 11:48 |
sean-k-mooney | mriedem: its the same behavior as before multiple port bindings so not a regression or bug just not faster. | 11:48 |
sean-k-mooney | jaypipes: enjoy your PTO? | 11:48 |
jaypipes | mriedem: luckily not much happened or was discussed on the ML while I was away | 11:48 |
jaypipes | sean-k-mooney: very much, thank you Sean. :) | 11:49 |
*** moshele has quit IRC | 11:49 | |
mriedem | gibi: can you take a look at this rc3-related bug workaround? https://review.openstack.org/#/c/594508/ - rc3 is supposed to be today | 11:49 |
mriedem | gibi: but withhold a +W until sean-k-mooney is able to test it in his env | 11:49 |
* mriedem assumes gibi will love it immediately and want to +W so hard | 11:50 | |
gibi | mriedem: ack, witholding my love but reading the patch ;) | 11:51 |
sean-k-mooney | mriedem: oh i forgot RC3 was today. i need to restack but i should have the env running in 20 mins or so | 11:53 |
*** jaosorior has joined #openstack-nova | 11:54 | |
mriedem | sean-k-mooney: *no pressure!* | 11:54 |
*** alexchadin has joined #openstack-nova | 12:02 | |
*** moshele has joined #openstack-nova | 12:07 | |
*** alexchadin has quit IRC | 12:07 | |
*** kosamara has joined #openstack-nova | 12:08 | |
mriedem | moshele: can you report a bug for https://review.openstack.org/#/c/595592/ ? | 12:09 |
mriedem | it's a regression in rocky | 12:09 |
*** jpena|lunch is now known as jpena | 12:09 | |
*** alexchadin has joined #openstack-nova | 12:09 | |
moshele | mriedem: sure I will | 12:11 |
mriedem | melwitt: ^ | 12:11 |
mriedem | throw it on the big board donny! | 12:11 |
* cdent wonders what it must be like to go bowling with mriedem | 12:11 | |
mriedem | it's fun | 12:12 |
mriedem | sahid: you should take a look at moshele's patch | 12:13 |
mriedem | moshele: what sets the driver_name to vhost? | 12:13 |
*** markvoelker has quit IRC | 12:14 | |
moshele | mriedem: the macvtap port which is virtio tap connected to VF so for that case it should be fine | 12:14 |
sahid | mriedem ah yes this bug has been reported downstream yesterday i think | 12:14 |
sahid | moshele: thanks for your patch | 12:15 |
moshele | sahid: np :) | 12:15 |
mriedem | moshele: sorry i don't understand that statement, | 12:15 |
mriedem | looking at your paste | 12:15 |
mriedem | : libvirtError: unsupported configuration: Unknown PCI device <driver name='vhost'/> has been specified | 12:15 |
mriedem | and looking at https://review.openstack.org/#/c/595592/1/nova/virt/libvirt/designer.py | 12:15 |
mriedem | i guess in this case the net_type was 'direct'? | 12:16 |
*** pcaruana has quit IRC | 12:16 | |
mriedem | so L120 | 12:16 |
*** pcaruana has joined #openstack-nova | 12:16 | |
sahid | mriedem: are you sure vfio is a valid driver? | 12:17 |
sahid | moshele: | 12:17 |
*** ykarel has joined #openstack-nova | 12:17 | |
ykarel | jroll, hi | 12:17 |
moshele | shaid: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/virtualization_deployment_and_administration_guide/sect-pci_devices-pci_passthrough | 12:17 |
moshele | sahid: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/virtualization_deployment_and_administration_guide/sect-pci_devices-pci_passthrough | 12:18 |
ykarel | jroll, can u check https://bugs.launchpad.net/tripleo/+bug/1787910/comments/13 | 12:19 |
openstack | Launchpad bug 1787910 in tripleo "OVB overcloud deploy fails on nova placement errors" [Critical,Triaged] - Assigned to Marios Andreou (marios-b) | 12:19 |
sahid | ok thanks, because i remeber of a bug in libvirt for vhostuser interface interface, when you basically set it to vhostuser (which is the driver used) libvirt is reaisng an error | 12:19 |
moshele | mriedem: no the net_type 'direct' is for macvtap port for port direct which is hostdev we don't set the driver name | 12:19 |
mriedem | moshele: yeah i figured it out, | 12:20 |
mriedem | the comment is busted in the code, | 12:20 |
mriedem | i left a comment about fixing it :) | 12:20 |
moshele | mriedem: the problem is with this https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L166-L176 | 12:21 |
moshele | mriedem: driver is not specified it put vhost | 12:21 |
ykarel | mriedem, or u can check https://bugs.launchpad.net/tripleo/+bug/1787910/comments/13 | 12:21 |
openstack | Launchpad bug 1787910 in tripleo "OVB overcloud deploy fails on nova placement errors" [Critical,Triaged] - Assigned to Marios Andreou (marios-b) | 12:21 |
mriedem | aha | 12:22 |
mriedem | moshele: ok | 12:22 |
moshele | mriedem: I send the mail because I am not sure about the fix. I know that my fix solve direct port | 12:23 |
mriedem | i'd ask jangutter but he's not around | 12:23 |
sahid | moshele: perhaps it's better to use None, lbvirt might have some kind of fallback, example using vfio but if available on host fallback to uio | 12:24 |
mriedem | moshele: vnic_type = 'direct' right? | 12:24 |
zigo | Hi there ! | 12:24 |
zigo | Any idea why I'm getting this when building the Nova Debian package? https://stretch-rocky.infomaniak.ch/job/nova/9/console | 12:24 |
zigo | (see the end of unit test run...) | 12:24 |
sahid | it's what is done for vhost, norammy by default, libvirt use vhost but fallback to qemu if vhost module is not loaded on host | 12:25 |
mriedem | zigo: you'll need to put that in a paste | 12:25 |
moshele | mriedem: yes | 12:25 |
mriedem | or give out creds | 12:25 |
zigo | Sure. | 12:25 |
zigo | mriedem: http://paste.openstack.org/show/728679/ | 12:25 |
zigo | From where is comming the MIMEAccept object? Is that nova's internal? | 12:26 |
zigo | A grep in nova shows nothing ... | 12:27 |
moshele | sahid: but this port will set driver name to vhost if it None https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L166-L176 | 12:27 |
mriedem | ykarel: i'll let jroll look at that b/c https://review.openstack.org/#/c/565841 was master only atm which is stein, and today is rocky rc3 so i'm focused on what we need to get done for rc3 | 12:27 |
moshele | sahid: s/port/part | 12:27 |
ykarel | mriedem, no prob, Thanks | 12:27 |
ykarel | rocky is more priority now | 12:27 |
mriedem | zigo: i'd guess the wsgi-intercept library | 12:28 |
mriedem | cdent: ^ | 12:28 |
mriedem | http://paste.openstack.org/show/728679/ | 12:28 |
*** holser_ has joined #openstack-nova | 12:28 | |
* cdent looks | 12:28 | |
mriedem | well best_matches = req.accept.acceptable_offers(types) is clearly in placement code | 12:29 |
cdent | zigo, looks webob | 12:29 |
sahid | moshele: hum... it's complicated, because if you set it to None, the LibvirtConfig will not generate the tx/rx args | 12:29 |
mriedem | yeah | 12:29 |
cdent | acceptable_offer is new in webob 1.8.x I think | 12:29 |
mriedem | sahid: but it looks like we default to vhost if rx/tx is configured https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L166-L176 | 12:30 |
mriedem | so driver_name will always be at least vhost? | 12:30 |
mriedem | which doesn't work for net_type == 'hostdev'? | 12:30 |
cdent | zigo: my guess is that the webob is not up to date with minimum requirements? | 12:30 |
zigo | cdent: Yeah, that should be it, thanks! | 12:30 |
mriedem | https://github.com/openstack/nova/blob/master/lower-constraints.txt#L170 fwiw | 12:31 |
mriedem | 1.8.2 | 12:31 |
zigo | Debian version is 1:1.7.3-2 | 12:31 |
cdent | zigo: I'm glad it was that easy :) | 12:31 |
zigo | Thanks guys. | 12:31 |
zigo | Will update it. | 12:31 |
sahid | yes yes, it's just i don't think we should specically set it to vfio, i think we should not set it at all for hostdev | 12:31 |
sahid | but if we do that tx/rx are then ignored | 12:31 |
jroll | mriedem: ykarel: I'm looking at this, I'm confused what is special about tripleo jobs here, as this works fine in our ironic jobs | 12:31 |
sahid | https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/config.py#L1390 | 12:32 |
jroll | oh wait, it's probably the flavors | 12:32 |
mriedem | sahid: yup | 12:32 |
mriedem | but if rx is configured, | 12:33 |
mriedem | and driver is None, | 12:33 |
mriedem | we hard-code to vhost | 12:33 |
mriedem | https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L169 | 12:33 |
mriedem | but apparently that doesn't work | 12:33 |
mriedem | : libvirtError: unsupported configuration: Unknown PCI device <driver name='vhost'/> has been specified | 12:33 |
mriedem | http://paste.openstack.org/show/728666/ | 12:33 |
sahid | can't we do something like that? https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L432 | 12:34 |
mriedem | heh, that TODO is overwriting the thing done in get_base_config which is based on another TODO | 12:34 |
mriedem | and here https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L519 | 12:35 |
moshele | sahid.mriedem : we can skip it for vnic_type direct in https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L166-L176 | 12:35 |
mriedem | sahid: which vnic_type did you test the rx queue stuff with? | 12:35 |
jroll | ykarel: posted a comment on the bug | 12:36 |
moshele | sahid, mriedem ^ | 12:36 |
ykarel | jroll, checking | 12:36 |
mriedem | moshele: but what about the other sriov types? https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/network/model.py#L111 | 12:36 |
sahid | get_config_vhostuser and _set_config_VIFHostUser are the same thing, one is native Nova the other for os-vif | 12:36 |
mriedem | i know | 12:36 |
sahid | ah sorry i did not have undersdoot the qustion so | 12:37 |
mriedem | so are direct and macvtap the only supported vnic types for rx/tx queues? | 12:37 |
moshele | mriedem: they are got beacuse the macvtap is also virtio and also the virtio forwarder | 12:37 |
moshele | mriedem: s/got/good | 12:37 |
*** dims_ is now known as dims | 12:37 | |
sahid | all vnic that are using virtio | 12:37 |
sahid | can have rc/tx queues | 12:37 |
moshele | sahid: SR-IOV passthrough is not virtio | 12:38 |
moshele | sahid: meaning vnic_type direct | 12:38 |
mriedem | alright, i'm clearly in over my head here in the nfv waters. my main concern is today is rc3 and it doesn't sound like we know what the correct solution is. so i'm wondering if we should just release note a known limitation and put something in the rx/tx config option help saying it's only supported by one specifiv vnic_type for now based on the one we know that works | 12:38 |
sahid | yes, but you are talking about SRIOV+mactap right? | 12:38 |
moshele | sahid: also direct_physocal should work | 12:38 |
mriedem | i would rather release rocky stating *what we know works* | 12:38 |
mriedem | not what *should* or *might* work | 12:39 |
moshele | sahid: not it breack SR-IOV passthoght | 12:39 |
moshele | mriedem: agree we need more time on this to find a good solution | 12:39 |
sahid | yes | 12:39 |
mriedem | so what do we know works? vnic_type='macvtap'? | 12:40 |
moshele | mriedem: I will check it with Mellanox QA hope to have answer next week | 12:41 |
moshele | mriedem: as I see it we need to skip such config for vnic_type direct and physical_direct, but I will check to be sure ... | 12:41 |
ykarel | jroll, flavors created like: https://logs.rdoproject.org/openstack-periodic/git.openstack.org/openstack-infra/tripleo-ci/master/legacy-periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset002-master-upload/9a25ebd/logs/undercloud/home/zuul/overcloud_prep_images.log.txt.gz#_2018-08-21_13_14_01 | 12:42 |
ykarel | jroll, is that wrong ? | 12:42 |
moshele | sahid, mriedem: I have to go I will update you guys next week | 12:43 |
jroll | ykarel: hm, that looks right. looks like maybe there's a bug in nova that doesn't override flavor.ram with flavor.properties['resources:MEMORY_MB']? this definitely used to work | 12:44 |
jroll | ykarel: I don't have time to dig into that code right now though, sorry | 12:44 |
ykarel | jroll, what can be reason for phys_ram=0:- phys_ram=0MB used_ram=0MB phys_disk=0GB used_disk=0GB total_vcpus=0 used_vcpus=0 pci_stats=[] | 12:44 |
openstackgerrit | Merged openstack/nova master: [placement] Regex consts for placement schema https://review.openstack.org/591863 | 12:45 |
ykarel | jroll, no issue, ^^ | 12:45 |
jroll | ykarel: baremetal resources no longer report ram/cpu/disk, we only rely on resource classes | 12:45 |
*** moshele has quit IRC | 12:45 | |
ykarel | jroll, in devstack ironic i saw phys_ram=384 | 12:45 |
jroll | ykarel: on master? I'd like to see that :) | 12:46 |
ykarel | jroll, yes http://logs.openstack.org/42/588942/1/check/ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode/4e2e0d5/logs/subnode-2/screen-n-cpu.txt.gz#_Aug_22_03_30_57_227367 | 12:46 |
mriedem | ok so moshele said rx/tx isn't support for vnic_type direct* is what i heard | 12:47 |
jroll | ykarel: that's a stable/pike patch | 12:47 |
ykarel | :( | 12:47 |
sean-k-mooney | jroll: the code works the otherway in nova. we calulate teh resources dictionary from flavor if not set not the other way around | 12:47 |
ykarel | jroll, okk, will check some master one :) | 12:47 |
jaypipes | mriedem: weird how vif plugging succeeds before the libvirt XML file is even defined...? | 12:48 |
jroll | sean-k-mooney: we explicitly agreed at some point that those resource classes in the flavor's properties would override the direct flavor properties. so I say it's a bug, if nova agrees that it isn't a bug, then ironic has docs bugs and ironic flavors have a UX problem :( | 12:48 |
jroll | sean-k-mooney: and the code did work this way in the past | 12:49 |
jaypipes | sean-k-mooney: I trust whatever jroll says and remembers. | 12:49 |
jroll | jaypipes: I'm putting that on my wall and will remember it in the future :D | 12:50 |
sean-k-mooney | im not that familar with the ironic code path so your proably right | 12:50 |
ykarel | jroll, correct in master phys_ram=0, jroll ok will try to understand placement now :) and see i can find anything there | 12:50 |
ykarel | then | 12:50 |
jaypipes | jroll: deal. :) | 12:50 |
mriedem | i also remember the flavor override thing | 12:51 |
ykarel | jroll, can this be the possible cause:- Details: There are no compute resource providers in the Placement | | 12:51 |
ykarel | | service but there are 2 compute nodes in the deployment. | | 12:51 |
ykarel | | This means no compute nodes are reporting into the | | 12:51 |
ykarel | | Placement service and need to be upgraded and/or fixed. | | 12:51 |
ykarel | | See | 12:51 |
*** ykarel has quit IRC | 12:51 | |
mriedem | not sure if it was in a spec though, if not - probably in some old ptg etherpad | 12:51 |
jroll | whoops | 12:51 |
*** ykarel has joined #openstack-nova | 12:51 | |
mriedem | i'm pretty sure edleafe had included the flavor overwrite stuff in the utility method for this... | 12:52 |
jroll | ykarel: the cause is a bug in the code that does overrides in the flavor, I'm sure of it :) | 12:52 |
jroll | in the short term you can remove the top-level ram/cpu/disk properties from your flavor to work around it | 12:52 |
mriedem | i'd be in this path https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L367 | 12:52 |
jroll | which is fine for CI, but not awesome for users | 12:52 |
ykarel | jroll, ack will try that | 12:53 |
ykarel | and wait for the fix in nova | 12:53 |
mriedem | https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/custom-resource-classes-in-flavors.html | 12:53 |
mriedem | jroll: this isn't regressed in rocky right? it's just a master thing | 12:54 |
jroll | mriedem: I don't know | 12:54 |
jroll | mriedem: everything I know about the bug is here in channel | 12:54 |
*** udesale has joined #openstack-nova | 12:54 | |
openstackgerrit | melanie witt proposed openstack/nova master: Correct the release notes related to nova-consoleauth https://review.openstack.org/595455 | 12:54 |
jroll | mriedem: it could have regressed in rocky, but was masked by the fact we were still reporting cpu/ram/disk for the ironic nodes | 12:55 |
mriedem | https://github.com/openstack/nova/blob/cc436c2b2a2dad974c4d28871851a456ebd80e48/nova/scheduler/utils.py#L220 | 12:55 |
*** Tomatosoup1 has joined #openstack-nova | 12:58 | |
jroll | man this code is not super easy to understand | 12:58 |
mriedem | this is the old code https://review.openstack.org/#/c/515223/12/nova/scheduler/utils.py@a224 | 12:58 |
mriedem | it wasn't before either | 12:59 |
*** mdrabe has joined #openstack-nova | 12:59 | |
Tomatosoup1 | hello | 12:59 |
Tomatosoup1 | i would like to set up SNAT network on one of the openstack VM, how may i do it? docs are mentioning SNAT but only in theoretical way | 13:01 |
jroll | mriedem: so that first link, are you saying it should work as advertised? | 13:01 |
mriedem | w/o a functional test showing it works, idk | 13:01 |
mriedem | if it was regressed, it's been broken since queens | 13:02 |
mriedem | with https://review.openstack.org/#/c/515223/ | 13:02 |
jroll | awesome | 13:02 |
mriedem | :) this is why i was easing into the "remove the old flavor support for baremetal" pool | 13:02 |
jroll | yeah, glad we didn't kill it at the tail end of rocky | 13:03 |
mriedem | you remember talking about it though right? | 13:03 |
mriedem | like 2 weeks ago | 13:03 |
jroll | about removing it? or about this bug? | 13:03 |
mriedem | removing it | 13:03 |
jroll | yeah | 13:03 |
jroll | I can say "you win" if that's what you're looking for :) | 13:04 |
mriedem | YES | 13:04 |
* jroll gives mriedem a cookie | 13:04 | |
mriedem | i would take some eggs and toast | 13:04 |
jroll | okay, I shall go make them | 13:05 |
mriedem | thanks babe | 13:05 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge keypair extension response into server view builder https://review.openstack.org/584748 | 13:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge server usage extension response into server view builder https://review.openstack.org/585262 | 13:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge security groups extension response into server view builder https://review.openstack.org/585475 | 13:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Merge extended_status extension response into server view builder https://review.openstack.org/592092 | 13:06 |
mriedem | tssurya: fyi ^ i'm trying to keep gmann's series straight and rebased so we can flush it through | 13:07 |
mriedem | Tomatosoup1: see channel topic please | 13:08 |
Tomatosoup1 | mriedem, sorry! | 13:09 |
tssurya | mriedem: noted thanks :) I need extended_volumes also, probably we will have it when he is back | 13:09 |
*** Tomatosoup1 has left #openstack-nova | 13:09 | |
*** jaosorior has quit IRC | 13:09 | |
sean-k-mooney | are there any known bugs with pysaml2? my devstack is failing to install it. im wondering do we need a version cap | 13:09 |
*** marvin_mhg has quit IRC | 13:10 | |
*** lennyb has quit IRC | 13:10 | |
mriedem | tssurya: he's out for another week, | 13:12 |
mriedem | these changes are pretty mechanical so could probably just do it yourself | 13:12 |
mriedem | following the pattern, | 13:12 |
mriedem | the hardest part would be the unit test stuff | 13:12 |
tssurya | ah okay, I didn't want to step into his stuff, but if that's okay I can get it up and update them | 13:12 |
mriedem | sean-k-mooney: upper-constraints should restrict it in devstack | 13:13 |
*** mgoddard has quit IRC | 13:15 | |
*** jdillaman has joined #openstack-nova | 13:17 | |
edmondsw | in my devstack I'm seeing a lot of "DEBUG nova.notifications.objects.base [None req-af08f64a-756e-4b43-8357-fd879d3bbbc9 None None] Defaulting the value of the field 'numa_membw_values' to None in MetricPayload due to 'Cannot load 'numa_membw_values' in the base class' {{(pid=145045) populate_schema /opt/stack/nova/nova/notifications/objects/base.py:142}}" | 13:18 |
edmondsw | but I can't find anything that would ever actually set numa_membw_values, outside of tests | 13:18 |
edmondsw | should that be removed? What am I missing? | 13:19 |
edmondsw | or set to Null here? https://github.com/openstack/nova/blob/baf858b03d55273f92fc115ea5c8f71c0bbb6582/nova/compute/monitors/cpu/virt_driver.py#L42 | 13:22 |
edmondsw | if it's only ever null, though... | 13:23 |
sean-k-mooney | mriedem: its trying to install 4.6.0 and thats failing on my system. | 13:24 |
*** bodgix has quit IRC | 13:24 | |
sean-k-mooney | ill pin locally to 4.5 for now | 13:25 |
*** bodgix has joined #openstack-nova | 13:25 | |
*** bodgix has left #openstack-nova | 13:25 | |
*** BlackDex_ is now known as BlackDex | 13:26 | |
sean-k-mooney | edmondsw: numa_membw_values being memory bandwidth? i think that is only supported skylake or newer intel chips and on skylake its broken becaue but memory reand and memory write counters were actully the read value | 13:29 |
edmondsw | sean-k-mooney unclear from the code I've found | 13:29 |
*** marvin_mhg has joined #openstack-nova | 13:30 | |
edmondsw | I wonder if this was added with the intention of having a followup that used it and maybe that just never happened | 13:30 |
sean-k-mooney | perhaps that or there is patch in review that has not landed yet | 13:31 |
*** gbarros has joined #openstack-nova | 13:31 | |
*** tbachman has joined #openstack-nova | 13:31 | |
*** adrianc has quit IRC | 13:34 | |
*** adrianc has joined #openstack-nova | 13:35 | |
*** liuyulong has quit IRC | 13:35 | |
stephenfin | mriedem: Does we need to wait for blueprint approval for [1] or can I start flushing them through? [1] https://review.openstack.org/#/q/topic:bp/api-extensions-merge-stein+status:open | 13:37 |
stephenfin | mriedem: Wait, it's specless and approved. Ignore me | 13:38 |
zigo | mriedem: cdent: I now know why I missed the webob version, it's because I forgot the EPOCH ... | 13:39 |
zigo | 1:1.8.2 is what's needed, not 1.8.2 ... | 13:39 |
zigo | :/ | 13:39 |
mriedem | stephenfin: right some are already approved/merged | 13:39 |
stephenfin | ack | 13:39 |
*** alexchadin has quit IRC | 13:39 | |
*** psachin has quit IRC | 13:40 | |
mriedem | edmondsw: a notification is trying to build a payload from the MonitorMetric object which has unset fields which don't have default values | 13:41 |
mriedem | but if it's nullable we can just set it to None | 13:41 |
mriedem | since 'numa_membw_values': fields.DictOfIntegersField(nullable=True), that's what we do | 13:42 |
edmondsw | mriedem yep, my point is that I think it's always going to be unset and thus DEBUG logs will always have a bunch of these messages filling them because nowhere is it ever set that I can find | 13:43 |
mriedem | we also get that a ton for flavor stuff i think | 13:43 |
mriedem | or used to | 13:43 |
edmondsw | and if that's the case, why does the schema have it in the first place? | 13:43 |
mriedem | i would be ok with dropping the 'defaulting to None' debug log | 13:44 |
mriedem | but it's up to gibi | 13:44 |
mriedem | or change to TRACE if we ever get a TRACE log level | 13:44 |
edmondsw | I can ignore it, it's not a big deal to me... just thought I'd ask | 13:44 |
mriedem | it bothers me too | 13:44 |
* gibi is reading back | 13:45 | |
openstackgerrit | Eric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033 | 13:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider raise https://review.openstack.org/584598 | 13:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599 | 13:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648 | 13:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034 | 13:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049 | 13:45 |
openstackgerrit | Eric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | 13:45 |
ykarel | jroll, mriedem openstack flavor unset --property resources:VCPU --property resources:DISK_GB --property resources:MEMORY_MB <flavor> didn't help, or i tried something wrong | 13:47 |
*** eharney has joined #openstack-nova | 13:48 | |
gibi | mriedem: as the MonitorMetric.numa_membw_values is also nullable I think when nova creates the MonitorMetric object it fails to set the default value of that field | 13:49 |
mriedem | there is no default value | 13:49 |
mriedem | but it is nullable | 13:49 |
mriedem | i guess you mean fails to initialize the field to None? | 13:49 |
gibi | mriedem: ohh, my bad | 13:49 |
gibi | mriedem: I mixed nullable and default value | 13:50 |
*** rnoriega has joined #openstack-nova | 13:53 | |
gibi | mriedem: if an ovo is valid with unset fields then I cannot do anything else than remove the debug log | 13:54 |
*** rnoriega has quit IRC | 13:54 | |
mriedem | yeah i don' think the debug log adds much besides noise - if the field is unset and can't be lazy-loaded and is nullable and set it to None, great | 13:55 |
mriedem | that's what should happen | 13:55 |
*** rnoriega has joined #openstack-nova | 13:55 | |
mriedem | if we can't do that - i.e. it's not nullable, then we fail and log an error | 13:55 |
*** jchhatbar has quit IRC | 13:55 | |
mriedem | like that flavor.disabled thing we had to fix | 13:55 |
gibi | mriedem: yeah. Then I will file a bug and propose the removal. | 13:55 |
mriedem | i can report a "logs are noisy" bug if you want for tracking | 13:56 |
mriedem | ah ok | 13:56 |
mriedem | :) | 13:56 |
*** kosamara has quit IRC | 13:56 | |
melwitt | nova meeting in 4 minutes | 13:56 |
*** kosamara has joined #openstack-nova | 13:56 | |
gibi | mriedem: I'm not fully happy with ovos with unset fields but we use the ovos that way a lot in nova | 13:56 |
mdbooth | melwitt: We may have to continue that discussion another time, then ;) | 13:56 |
*** takashin has joined #openstack-nova | 13:57 | |
mdbooth | melwitt dansmith: Incidentally, were you trying to grok https://review.openstack.org/#/c/578846/7/nova/virt/libvirt/driver.py 1002-> ? | 13:57 |
mdbooth | melwitt dansmith: Because if so I don't grok that either, but it's not new code. | 13:57 |
mdbooth | It came from old code line 1066-> | 13:58 |
mdbooth | As I put in the comment, I'm pretty sure it's wrong, though, but I wasn't going to change it in this patch | 13:59 |
dansmith | mdbooth: I'm not saying I don't grok it, I'm saying it's a lot of change | 13:59 |
dansmith | "code motion" or not :) | 13:59 |
*** awaugama has joined #openstack-nova | 13:59 | |
dansmith | we have a meeting in 30 seconds and then I can look in more detail, | 13:59 |
melwitt | yeah, it was just me who said I couldn't follow the change so far | 13:59 |
mdbooth | dansmith: It updates _create_image() to return whether or not it created anything | 13:59 |
dansmith | but I was saying that mriedem and melwitt and cfriesen at least have context on this and probably can get back up to speed quicker than I can even start | 13:59 |
mriedem | this is about the time i muse about an evacuate test in the gate | 14:00 |
jroll | ykarel: what I meant was e.g. openstack flavor set --memory-mb 0 $flavor | 14:00 |
jroll | or the equivalent | 14:00 |
dansmith | mdbooth: see? ^ | 14:00 |
mriedem | run a nova tempest plugin test in serial, | 14:00 |
mdbooth | mriedem: I wrote one :) | 14:00 |
mriedem | 2 node CI | 14:00 |
mriedem | force down one host, | 14:00 |
mriedem | evacuate to the other | 14:00 |
ykarel | jroll, okk my bad, will try that | 14:00 |
mriedem | run in both ceph and non-ceph jobs | 14:00 |
mdbooth | mriedem: Ah, that would be better of course. Mine's in functional. | 14:00 |
mriedem | mdbooth: you wrote a functional test with stubs yes? | 14:00 |
mdbooth | mriedem: right. | 14:01 |
mdbooth | mriedem: It runs quite a lot of code, though. It runs the libvirt driver. | 14:01 |
mdbooth | mriedem: And it tests all 4 combinations of shared/nonshared instance storage and block. | 14:02 |
mriedem | johnthetubaguy: since you're around, you've been summoned several times on https://review.openstack.org/#/c/536351/ | 14:02 |
johnthetubaguy | oh sorry, looking | 14:03 |
*** mlavalle has joined #openstack-nova | 14:03 | |
melwitt | sahid: are you still around? would you be able to advise us on how to document the issue in https://review.openstack.org/#/c/595592/ for the config option help and release notes? | 14:04 |
*** dpawlik has quit IRC | 14:05 | |
sahid | melwitt: yes sure i will try to reply to Matt with the most information that i have | 14:06 |
openstackgerrit | Merged openstack/nova master: Merge extended server attributes extension response https://review.openstack.org/584590 | 14:06 |
melwitt | great, thank you sahid | 14:06 |
*** r-daneel has joined #openstack-nova | 14:07 | |
melwitt | we're trying to get the information straight to document the situation for RC3 whose deadline is today | 14:07 |
*** gbarros has quit IRC | 14:09 | |
mdbooth | mriedem: We were discussing https://review.openstack.org/#/c/578846/ btw, which is a completely new approach. Described in the commit message: "This change modifies spawn in the libvirt driver such that it only cleans up resources it created." | 14:09 |
mriedem | nova meeting, and rc3 fires | 14:10 |
mriedem | so i'm not looking into that today | 14:10 |
mriedem | or soon | 14:10 |
mdbooth | mriedem: ack | 14:10 |
*** gbarros has joined #openstack-nova | 14:11 | |
ykarel | jroll, i tried creating a new flavor as i can't find update command for ram and it says:- Invalid input for field/attribute ram. Value: 0. 0 is less than the minimum of 1 (HTTP 400) (Request-ID: req-1545b718-80c2-4c08-bcba-356a21535b47) | 14:12 |
mriedem | johnthetubaguy: thanks | 14:12 |
mriedem | ykarel: ram must be at least 1 per the api schema | 14:13 |
mriedem | same for vcpus | 14:13 |
mriedem | root_gb can be 0 | 14:13 |
mriedem | http://eavesdrop.openstack.org/meetings/nova/2018/nova.2018-08-16-21.00.html | 14:13 |
mriedem | oops | 14:13 |
mriedem | 'required': ['name', 'ram', 'vcpus', 'disk'], | 14:13 |
jroll | ugh | 14:13 |
ykarel | mriedem, but to avoid that nova bug, jroll suggested to use 0 | 14:13 |
mriedem | the api says otherwise | 14:13 |
mriedem | for ironic, the flavor values will likely just be informational, | 14:14 |
mriedem | and then the extra spec resources: are meant to override i thought | 14:14 |
jroll | right | 14:14 |
jroll | which isn't working in these tripleo jobs | 14:14 |
* jroll wonders how ironic jobs work | 14:14 | |
jroll | https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L2083 | 14:14 |
*** brinzhang has quit IRC | 14:15 | |
jroll | ah, we don't enable cpu/ram/disk filters | 14:15 |
ykarel | hmm in tripleo we have those enabled | 14:17 |
ykarel | enabled_filters=RetryFilter,AvailabilityZoneFilter,ComputeFilter,ComputeCapabilitiesFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter | 14:18 |
ykarel | enabled_filters=RetryFilter,TripleOCapabilitiesFilter,ComputeCapabilitiesFilter,AvailabilityZoneFilter,RamFilter,DiskFilter,ComputeFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter | 14:18 |
jroll | right | 14:18 |
jroll | are you also using VMs here? | 14:18 |
ykarel | no, just ironic | 14:18 |
ykarel | bms | 14:18 |
jroll | ah, I'd kill those filters then, they aren't necessary | 14:19 |
jaypipes | enabled_filters should not include RamFilter, DiskFilter or ComputeFilter. | 14:19 |
jroll | and please do file a bug about the override thing, if you would | 14:19 |
jaypipes | perhaps this is the thing I was referring to when I mentioned triple-o was still relying on non-resource-class world. | 14:19 |
jroll | jaypipes: oh, we don't need those filters anywhere now, right? | 14:19 |
jaypipes | jroll: correct. | 14:19 |
jroll | even for VMs? | 14:19 |
jroll | nice | 14:19 |
jaypipes | yes, even for VMs. | 14:19 |
jaypipes | actually, lemme verify... | 14:20 |
jaypipes | there was a CoreFilter too I think, and I can't remember whether it was that or ComputeFilter which filters out "disabled" nodes. | 14:20 |
jaypipes | jroll, ykarel: you don't need CoreFilter, DiskFilter and RamFilter. ComputeFilter is still needed | 14:21 |
sean-k-mooney | ComuteFilter does the disabled host i think | 14:21 |
mriedem | correction! | 14:21 |
jaypipes | it filters out "disabled" nodes | 14:21 |
mriedem | you need those filters for caching scheduler | 14:21 |
mriedem | which doesn't use placement | 14:21 |
jaypipes | oh ffs, yes. | 14:21 |
mriedem | otherwise what jay said | 14:21 |
jroll | gdi mriedem | 14:22 |
mriedem | hey, if mgagne_ gives the ok at the ptg that we can drop the caching scheduler, then we can | 14:23 |
*** gbarros has quit IRC | 14:23 | |
sean-k-mooney | mriedem: we are deleting the cachingschduler this cycle right? | 14:23 |
sean-k-mooney | ah ptg topic | 14:23 |
mriedem | sean-k-mooney: idk, we were going to drop nova-net in rocky ... | 14:23 |
sean-k-mooney | ya... stein for that? | 14:23 |
sean-k-mooney | the caching schduiler could be kicked out of tree like the ec2 api if people really wanted it for some reason. that is still a plug point right? | 14:24 |
sean-k-mooney | e.g. you can provide your own schduler driver | 14:24 |
mriedem | yes i think so | 14:25 |
mriedem | via stevedore extensions | 14:25 |
melwitt | johnthetubaguy: I pinged you a long time ago about https://review.openstack.org/533168 that you reviewed in the past, if you can get a chance to look at it | 14:25 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Create functional libvirt test base class https://review.openstack.org/407055 | 14:25 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Move mocking to setUp https://review.openstack.org/595802 | 14:25 |
sean-k-mooney | mriedem: ya so we could split it out if there was concerns into its own repo but ingeneral not ship it | 14:25 |
ykarel | jaypipes, jroll ack, so those filters are not needed anymore, then any reason to keep them still? | 14:25 |
johnthetubaguy | melwitt: that does have my name all over it, will try take a look | 14:25 |
jroll | ykarel: the only reason to keep them is if you use the caching scheduler | 14:26 |
jaypipes | please tell me triple-o isn't setting up the caching scheduler. | 14:26 |
mriedem | it's not | 14:26 |
sean-k-mooney | mriedem: if we did that we could move the filters that are only needed with the cahcein scheduler also | 14:26 |
mriedem | well, i assume it's not :) | 14:26 |
jaypipes | yay. I can step back from the edge. | 14:26 |
mriedem | The Edge (tm)? | 14:27 |
melwitt | johnthetubaguy: sweet, thanks | 14:27 |
jaypipes | mriedem: touche | 14:27 |
ykarel | jroll, how that's configured, caching scheduler | 14:27 |
jroll | heh | 14:28 |
sean-k-mooney | jaypipes: by default no there is a conf override thing in tripleo so someone could set teh conf values manually but im pretty sure that would make the deployment unsupported downstream | 14:28 |
jroll | ykarel: conf.scheduler.scheduler_driver | 14:28 |
sean-k-mooney | ykarel: now that you know. please never set it to anything other then the filter schduler | 14:29 |
ykarel | jroll, driver=filter_scheduler | 14:29 |
ykarel | jroll, sean-k-mooney we have ^^ | 14:29 |
jroll | cue denver: <tripleo> we rely on the caching scheduler, please don't remove it! | 14:30 |
sean-k-mooney | jroll: at this point anything we have so much stuff using placement im not even sure you could deploy a fucntional nova with the caching schduler unless you never migrate or resize anything | 14:31 |
jroll | sean-k-mooney: if anyone can hack it, it's tripleo ;D | 14:32 |
jaypipes | sean-k-mooney: "that would make the deployment unsupported downstream" wait, what!? but I thought triple-o wasn't a RH product? :P | 14:33 |
sean-k-mooney | jaypipes: i was refering to OSP | 14:33 |
jaypipes | sean-k-mooney: ok dokey. :) | 14:33 |
sean-k-mooney | e.g. osp being the downstream | 14:33 |
sean-k-mooney | tripplo has too many names | 14:33 |
jaypipes | sean-k-mooney: and you just gave it another ;) "tripplo" | 14:34 |
sean-k-mooney | its tripleo, rdo director, osp director and apex | 14:34 |
jaypipes | sean-k-mooney: oh, you mean exactly what RH did with OpenShift? | 14:34 |
jaypipes | sean-k-mooney: or at least, *the current incarnation* of OpenShift. | 14:34 |
*** ccamacho has quit IRC | 14:35 | |
sean-k-mooney | Openshift is (kubernetes + extentions) and i think its called Openshift container platform or somthing as down stream product. i should proable know that... | 14:36 |
jaypipes | sean-k-mooney: yes, I'm referring to the evolving meaning of openshift(.com/org) over the last 5 years... | 14:36 |
*** r-daneel has quit IRC | 14:37 | |
*** Bhujay has joined #openstack-nova | 14:39 | |
mgagne_ | mriedem: I don't think the caching scheduler will be needed anymore if placement does the job and I can migrate to it easily. we tested that already I think | 14:41 |
mriedem | mgagne_: i hoped that's what you'd say, based on earlire discussions re heal_allocations | 14:41 |
*** Luzi has quit IRC | 14:41 | |
mgagne_ | mriedem: if caching scheduler can still be used in a out of tree fashion, there is a plan B if anything goes wrong. | 14:41 |
mriedem | yes, that's possible | 14:43 |
sahid | mriedem, melwitt not sure of what you can put in the release note or config doc instead of don't mix rx/tx queue size option if you don't use guests with only virtio devices :/ | 14:45 |
sahid | i commented a think we could have a patch which is limiting the impact | 14:45 |
*** sapd1 has quit IRC | 14:49 | |
gibi | edmondsw, mriedem: bug about the noise debug log https://bugs.launchpad.net/nova/+bug/1788634 | 14:49 |
openstack | Launchpad bug 1788634 in OpenStack Compute (nova) "Noisy DEBUG log: Defaulting the value of the field 'numa_membw_values' to None in MetricPayload" [Low,Confirmed] - Assigned to Balazs Gibizer (balazs-gibizer) | 14:49 |
sean-k-mooney | sahid: well enduses can change the interface model by uploading an imagge and setting the vif_modle in the metatdat | 14:49 |
*** Swami has joined #openstack-nova | 14:50 | |
sean-k-mooney | sahid: so the nova code needs to handel that correctly and not set the queue lenght in that case | 14:50 |
edmondsw | gibi cool, tx | 14:50 |
*** sapd1 has joined #openstack-nova | 14:50 | |
*** moshele has joined #openstack-nova | 14:54 | |
sahid | sean-k-mooney: yes and only virtio model works with queues, so is user is setting something else, we don't want use queues | 14:54 |
sahid | did i miss something? | 14:55 |
sean-k-mooney | sahid: right, no just makeing sure that is the current behavior. i belive we check for that in the code but if we dont its a bug | 14:56 |
sahid | a even less impacting solution is to reproduce what is done https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/virt/libvirt/vif.py#L153 | 14:57 |
sahid | for rx/tx queue block | 14:57 |
*** rpittau has quit IRC | 14:57 | |
kosamara | Continuing from the meeting on https://review.openstack.org/#/c/579897 | 15:00 |
jaypipes | stephenfin: you fixing up https://review.openstack.org/#/c/595802/? | 15:01 |
stephenfin | jaypipes: as we speak | 15:01 |
*** takashin has left #openstack-nova | 15:01 | |
kosamara | dansmith: I don't propose a new knob actually. The same condition that triggers "hide_hypervisor_id" will additionally hide the hyperv signature, if it's a windows guest. | 15:01 |
melwitt | sahid: ack | 15:02 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove noisy DEBUG log https://review.openstack.org/595810 | 15:02 |
gibi | edmondsw, mriedem: ^^ | 15:02 |
dansmith | kosamara: okay I see, my mistaked | 15:02 |
kosamara | this is functionality that the "hide_hypervisor_id" feature already promises, but currently doesn't work for Windows guests. | 15:02 |
dansmith | kosamara: I think that we probably shouldn't have that feature, but that's just MHO and I'm wrong a lot. Also, I'm a terrible person. | 15:03 |
jaypipes | stephenfin: ack. cuz me likey that series. | 15:03 |
kosamara | dansmith: Self-sarcasm is usually a sign to the opposite :P | 15:04 |
mriedem | edmondsw: https://bugs.launchpad.net/nova/+bug/1788634/comments/3 | 15:04 |
openstack | Launchpad bug 1788634 in OpenStack Compute (nova) "Noisy DEBUG log: Defaulting the value of the field 'numa_membw_values' to None in MetricPayload" [Low,In progress] - Assigned to Balazs Gibizer (balazs-gibizer) | 15:04 |
jaypipes | kosamara: like dansmith I am also a terrible person. | 15:04 |
jaypipes | kosamara: and no, we're not being sarcastic, :P | 15:04 |
mriedem | edmondsw: tl;dr the object changes were added for the numa bw metric but the implementation wasn't | 15:06 |
mriedem | b/c we decided around the time of the newton midcycle meeting that nova as a stats gatherer was dumb | 15:06 |
edmondsw | mriedem got it | 15:06 |
*** itlinux__ has joined #openstack-nova | 15:06 | |
edmondsw | tx for the history | 15:06 |
mriedem | and that field likely shouldn't be in the notification payload | 15:07 |
mriedem | now that you mention it | 15:07 |
mriedem | but dropping it would be a major version bump i think - gibi agree? | 15:07 |
edmondsw | mriedem gibi so should the solution be to remove the log statement or to remove numa_membw_values from the schema? | 15:07 |
gibi | mriedem: yepp, I was in the process of typing this comment | 15:07 |
edmondsw | or to keep it in the schema but start setting it to None explicitly | 15:07 |
gibi | mriedem, edmondsw: I think the notification change should be tight to the cleanup of this half done feature | 15:08 |
kosamara | jaypipes, dansmith: terrible or not, thanks a lot for the discussion. | 15:08 |
mriedem | gibi: edmondsw: looking at http://logs.openstack.org/97/579897/4/check/tempest-full/53d05dc/controller/logs/screen-n-cpu.txt.gz | 15:08 |
mriedem | "Defaulting the value of the field" shows up over 1K times | 15:08 |
mriedem | so i think the debug log should go away regardless | 15:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Move mocking to setUp https://review.openstack.org/595802 | 15:09 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Create functional libvirt test base class https://review.openstack.org/407055 | 15:09 |
mriedem | Flavor.projects is a huge one | 15:09 |
mriedem | since flavor is in all instance payloads | 15:09 |
gibi | mriedem: I agree that we need to drop the debug log | 15:09 |
gibi | mriedem: regardless of the notificaton change | 15:10 |
mriedem | +2 | 15:10 |
gibi | mriedem: or more like independently | 15:10 |
*** hamzy has quit IRC | 15:10 | |
edmondsw | +1 from me | 15:11 |
ykarel | mriedem, jaypipes jroll sean-k-mooney Thanks, i commented https://bugs.launchpad.net/tripleo/+bug/1787910/comments/16, please correct if i added something wrong there | 15:11 |
openstack | Launchpad bug 1787910 in tripleo "OVB overcloud deploy fails on nova placement errors" [Critical,Triaged] - Assigned to Marios Andreou (marios-b) | 15:11 |
gibi | awesome :) | 15:11 |
jroll | ykarel: thanks! looks good to me | 15:12 |
openstackgerrit | Merged openstack/nova master: Fix nits in resource_provider.py https://review.openstack.org/588470 | 15:12 |
sean-k-mooney | mriedem: ok i finally got to a point where i could test https://review.openstack.org/#/c/594508/2. the error is still being thrown from qemu but the newroking on the vm is not broken anymore | 15:12 |
sean-k-mooney | mriedem: so that looks good to me. ill +1 it upstream | 15:13 |
mriedem | sean-k-mooney: awesome, can you note in the review so gibi can "put his love on it" or whatever he said earlier? | 15:13 |
mriedem | sean-k-mooney: thanks | 15:13 |
mriedem | i'm pretty sure gibi sexually harassed my patch | 15:13 |
edmondsw | efried https://docs.openstack.org/nova/latest/contributor/policies.html#metrics-gathering says there is "not yet a clear replacement"... is that still true, or does the placement service fill that role now? | 15:13 |
mriedem | placement doesn't gather metrics | 15:13 |
mriedem | but you could probably report metrics type things into placement to be used during nova scheduling | 15:14 |
gibi | mriedem: I think you started it ;) "* mriedem assumes gibi will love it immediately and want to +W so hard" | 15:14 |
mriedem | like the nw bw stuff gibi is working on | 15:14 |
mriedem | gibi: ha | 15:14 |
*** itlinux__ is now known as itlinux | 15:15 | |
*** itlinux is now known as 59NAABP8D | 15:15 | |
efried | "report metrics type things into placement"? mind blown | 15:15 |
gibi | I'm not sure how the available and used nw bw in placement relates to metrics but yeah | 15:16 |
sean-k-mooney | efried: metric type things? | 15:16 |
efried | sean-k-mooney: Don't look at me. It was mriedem's zany idea | 15:17 |
sean-k-mooney | i obvioulsy missed somthing while debuging my devstack setup | 15:17 |
*** 59NAABP8D has quit IRC | 15:17 | |
edmondsw | efried you can probably blame me there | 15:17 |
edmondsw | I don't know that either of us were suggesting it should be done, just wondering | 15:18 |
sean-k-mooney | edmondsw: placement does not store metrics no | 15:18 |
*** itlinux has joined #openstack-nova | 15:18 | |
sean-k-mooney | edmondsw: also it likely never will | 15:18 |
edmondsw | I don't really know why nova ever used metrics for scheduling | 15:18 |
mriedem | it was an ibm feature | 15:18 |
edmondsw | ha | 15:18 |
mriedem | you probably should remmeber this | 15:19 |
mriedem | i'm pretty sure it was powervc relatd | 15:19 |
mriedem | *related | 15:19 |
mriedem | sudipta biswas | 15:19 |
sean-k-mooney | edmondsw: but bandwidth based schduling is different then metric based suchduling that was keed off network usage | 15:19 |
mriedem | it was for metrics weighers | 15:19 |
jaypipes | hold up... somebody said metrics and placement in the same breath... /me perks up | 15:19 |
sean-k-mooney | edmondsw: for gibi's bandwith based schduling work we are tracking bandwidth as a consumable resouce which is exactly what placement was designed for | 15:20 |
edmondsw | sean-k-mooney yep, understood | 15:20 |
*** dklyle has quit IRC | 15:20 | |
sean-k-mooney | jaypipes: yep the comment i made was that was not a thing | 15:20 |
gibi | ohh I see the relation between nw bw and metrics. If neutron would report physically used nw bw to placement that would be the metric | 15:20 |
efried | jaypipes: I'm going to tag providers with dynamic traits like CUSTOM_CPU_CYCLES_SINCE_LAST_RESET_<NNNN>, updated every periodic via update_provider_tree. | 15:20 |
sean-k-mooney | gibi: ya but we dont want to contiunally update allocation to model real usage. at would be an abuse of the datamodel in placement | 15:21 |
gibi | sean-k-mooney: totally agree | 15:21 |
gibi | sean-k-mooney: I never wanted to do that | 15:22 |
* jaypipes orders straightjacket for efried from Amazon | 15:22 | |
mriedem | do they sell those? | 15:23 |
sean-k-mooney | gibi: i have seen a really old poc for bandwidth based schduling using celomiter metrics in the past | 15:23 |
efried | I was expecting something along the lines of "over my cooling corpse" | 15:23 |
* edmondsw wants to watch jaypipes try to put that on efried | 15:23 | |
jaypipes | mriedem: https://www.amazon.com/Posey-Straight-Jacket-MEDIUM/dp/B001ANOR6E | 15:23 |
efried | mriedem: https://www.amazon.com/Freebily-Leather-Straitjacket-Straight-Costume/dp/B07B8KV2NQ/ref=sr_1_2?ie=UTF8&qid=1535037811&sr=8-2&keywords=straightjacket | 15:23 |
jaypipes | efried: :P | 15:23 |
sean-k-mooney | efried: what you do in the privacy of your out of tree virt driver is fine just so long as that never happens in the nova tree :) | 15:24 |
jaypipes | "Customers also bought..." section is awesome. | 15:24 |
mriedem | i suggested to my wife last night that while in berlin we should shop for something like that | 15:24 |
jaypipes | heh | 15:24 |
mriedem | b/c my german stereotype includes 80s synth music and leather | 15:24 |
efried | I like how it's other-legit-restraint other-legit-restraint kinky-s&m-thing other-legit-restraint... | 15:25 |
*** macza has joined #openstack-nova | 15:26 | |
openstackgerrit | Chen proposed openstack/nova master: Fix create_resource_provider docstring https://review.openstack.org/595453 | 15:31 |
*** ykarel is now known as ykarel|away | 15:32 | |
*** hamzy has joined #openstack-nova | 15:35 | |
*** Bhujay has quit IRC | 15:35 | |
*** pcaruana has quit IRC | 15:36 | |
*** dklyle has joined #openstack-nova | 15:37 | |
mriedem | so anyone that cares about this placement extract / governance thing should probably be in the tc channel as of about an hour ago | 15:43 |
*** ykarel|away has quit IRC | 15:51 | |
*** ttsiouts has joined #openstack-nova | 15:55 | |
*** itlinux is now known as itlinux-away | 15:58 | |
*** gyee has joined #openstack-nova | 15:59 | |
*** itlinux-away is now known as itlinux | 16:00 | |
*** itlinux is now known as itlinux-away | 16:00 | |
*** ttsiouts has quit IRC | 16:00 | |
*** links has quit IRC | 16:02 | |
*** ttsiouts has joined #openstack-nova | 16:03 | |
*** moshele has quit IRC | 16:04 | |
*** mriedem is now known as mriedem_sudsy | 16:04 | |
*** ttsiouts has quit IRC | 16:04 | |
*** itlinux-away is now known as itlinux | 16:05 | |
*** itlinux is now known as itlinux-away | 16:05 | |
*** itlinux-away is now known as itlinux | 16:06 | |
*** itlinux is now known as itlinux-away | 16:07 | |
*** ttsiouts has joined #openstack-nova | 16:08 | |
openstackgerrit | Merged openstack/nova master: placement: use single-shot INSERT/DELETE agg https://review.openstack.org/592654 | 16:08 |
*** icey has quit IRC | 16:09 | |
*** icey has joined #openstack-nova | 16:10 | |
*** itlinux-away is now known as itlinux | 16:13 | |
*** itlinux is now known as itlinux-away | 16:14 | |
*** harlowja has joined #openstack-nova | 16:17 | |
*** itlinux-away is now known as itlinux | 16:18 | |
*** itlinux is now known as itlinux-away | 16:18 | |
*** Bhujay has joined #openstack-nova | 16:19 | |
*** itlinux-away is now known as itlinux | 16:21 | |
*** davidsha has quit IRC | 16:24 | |
*** jpena is now known as jpena|off | 16:25 | |
*** mriedem_sudsy is now known as mriedem | 16:26 | |
*** ttsiouts has quit IRC | 16:30 | |
*** ttsiouts has joined #openstack-nova | 16:30 | |
sean-k-mooney | mriedem: am im going to drop for dinner. i might be online later. was there anything else you wanted me to take a look at for RC3? | 16:32 |
mriedem | sean-k-mooney: no i think we're good, thanks again | 16:35 |
*** ttsiouts has quit IRC | 16:35 | |
sean-k-mooney | mriedem: no worries. | 16:35 |
sean-k-mooney | o/ | 16:35 |
*** moshele has joined #openstack-nova | 16:36 | |
*** sahid has quit IRC | 16:36 | |
*** sean-k-mooney has quit IRC | 16:36 | |
*** udesale has quit IRC | 16:40 | |
*** harlowja has quit IRC | 16:40 | |
*** Swami has quit IRC | 16:49 | |
mriedem | melwitt: questions in https://review.openstack.org/#/c/595455/ | 16:55 |
melwitt | looking | 16:56 |
*** gbarros has joined #openstack-nova | 16:57 | |
melwitt | mriedem: replied. I think you answered my question though, I need to call out cells v1 in both places | 17:02 |
melwitt | I was worried about people confusing it with cells v2. maybe I'll say cells v1, legacy cells | 17:02 |
*** davidsha has joined #openstack-nova | 17:03 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Make instance_list perform per-cell batching https://review.openstack.org/593131 | 17:04 |
openstackgerrit | Dan Smith proposed openstack/nova master: Record cell success/failure/timeout in CrossCellLister https://review.openstack.org/594265 | 17:04 |
openstackgerrit | Dan Smith proposed openstack/nova master: Optimize global marker re-lookup in multi_cell_list https://review.openstack.org/594577 | 17:04 |
*** Bhujay has quit IRC | 17:08 | |
*** moshele has quit IRC | 17:09 | |
mriedem | at this point, anyone using cells v1 knows what we mean when we say v1 | 17:13 |
mriedem | https://docs.openstack.org/nova/latest/user/cells.html | 17:14 |
mriedem | for people that don't know the difference, ^ i hope they can read | 17:14 |
*** sambetts_ is now known as sambetts|afk | 17:15 | |
melwitt | maybe I'll link to that too | 17:16 |
melwitt | well yeah, I was worried about the inverse. non cells v1 people thinking they have cells v1 because they have "cells" | 17:16 |
mriedem | i think specifically calling out cells "v1" makes that clear | 17:24 |
mriedem | if i don't know, i'm likely going to ask, "there are multiple versions?" | 17:24 |
*** penick has joined #openstack-nova | 17:25 | |
*** penick has quit IRC | 17:27 | |
*** holser_ has quit IRC | 17:28 | |
mriedem | jaypipes: i just want to say, before i go "meet the teacher", that if you hadn't birthed placement from your loins it wouldn't exist, so, you know, thanks and stuff | 17:35 |
mriedem | that seems to be lost a bit in this | 17:36 |
*** mriedem is now known as mriedem_away | 17:36 | |
*** holser_ has joined #openstack-nova | 17:36 | |
jaypipes | mriedem_away: there's lots of contributors to placement. but thank you. | 17:37 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: tests: Create functional libvirt test base class https://review.openstack.org/407055 | 17:37 |
*** gbarros has quit IRC | 17:46 | |
*** dtantsur is now known as dtantsur|afk | 17:46 | |
*** noonedeadpunk has quit IRC | 17:49 | |
*** tssurya has quit IRC | 17:52 | |
*** holser_ has quit IRC | 17:53 | |
*** N3l1x has joined #openstack-nova | 18:01 | |
*** adrianc has quit IRC | 18:08 | |
*** bbbbzhao_ has quit IRC | 18:14 | |
*** mriedem_away is now known as mriedem | 18:17 | |
*** r-daneel has joined #openstack-nova | 18:24 | |
*** penick has joined #openstack-nova | 18:26 | |
mriedem | melwitt: so i'm not strong on this vif type / virtio stuff in https://review.openstack.org/#/c/595592/ | 18:29 |
mriedem | i can take a crack at a reno, which based on sahid's comment would be, "rx/tx queues only work with vif_model=virtio" | 18:29 |
mriedem | which is (1) configurable per image with the hw_vif_model property or globally in nova.conf via the (2) [libvirt]/use_virtio_for_bridges option | 18:30 |
melwitt | mriedem: ack. did stephenfin give any ideas too or? | 18:31 |
mriedem | but without someone around that understands this to actually ack my wording it's tough | 18:31 |
mriedem | not in the patch | 18:31 |
mriedem | or ic | 18:31 |
mriedem | *irc | 18:31 |
mriedem | so no | 18:31 |
melwitt | dangit | 18:32 |
dansmith | mriedem: I think that's legit | 18:33 |
dansmith | setting the queues only works with certain versions of qemu, libvirt, and on certain vif types | 18:34 |
mriedem | from moshe's paste, | 18:34 |
mriedem | he's not using virtio vif model b/c it's not in the interface xml | 18:34 |
mriedem | so he must have use_virtio_for_bridges=False in nova.conf | 18:34 |
dansmith | I dunno about the interacton with that config though | 18:34 |
mriedem | getting things to work is basically the hellraiser cube | 18:35 |
mriedem | the release note for the feature says, "Only supported for vhost/vhostuser interfaces" | 18:36 |
mriedem | so, | 18:36 |
mriedem | i think we're probably covered enough here | 18:37 |
mriedem | i can't really wordsmith this better than what's already in the reno | 18:37 |
mriedem | or config option help | 18:37 |
mriedem | and given these options don't have default values, you have to opt into it | 18:37 |
mriedem | so buyer beware | 18:37 |
mriedem | https://github.com/openstack/nova/blob/e731813796764a1034e7e16a6c154c8831984c9b/releasenotes/notes/bp-libvirt-virtio-set-queue-sizes-6c54a2ce3dc30d18.yaml#L6 | 18:38 |
mriedem | https://github.com/openstack/nova/blob/34956bea4beb8e5ba474b42ba777eb88a5eadd76/nova/conf/libvirt.py#L1213 | 18:38 |
*** r-daneel_ has joined #openstack-nova | 18:38 | |
*** hemna_ has quit IRC | 18:39 | |
*** _hemna has quit IRC | 18:39 | |
*** r-daneel has quit IRC | 18:40 | |
*** r-daneel_ is now known as r-daneel | 18:40 | |
*** gcb_ has quit IRC | 18:41 | |
mriedem | melwitt: so punt on that for rc3 is what i'm saying | 18:41 |
melwitt | that is ideal. thanks | 18:42 |
*** efried is now known as efried_afk | 18:43 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: libvirt: Don't react to VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED events https://review.openstack.org/595864 | 18:44 |
mriedem | ^ is the other one you needed | 18:44 |
*** pcaruana has joined #openstack-nova | 18:52 | |
mriedem | dansmith: melwitt: btw, our public cloud guy was fine with the option to 500 if users are listing and have servers in down cells | 18:52 |
dansmith | sweet | 18:52 |
melwitt | *thumbs up* | 18:53 |
*** davidsha has quit IRC | 18:56 | |
*** cdent has quit IRC | 19:02 | |
*** tssurya has joined #openstack-nova | 19:02 | |
*** awaugama has quit IRC | 19:07 | |
*** pcaruana has quit IRC | 19:09 | |
*** awaugama has joined #openstack-nova | 19:10 | |
*** awaugama has joined #openstack-nova | 19:16 | |
*** gcb_ has joined #openstack-nova | 19:18 | |
openstackgerrit | melanie witt proposed openstack/nova master: Correct the release notes related to nova-consoleauth https://review.openstack.org/595455 | 19:21 |
*** awaugama has quit IRC | 19:21 | |
*** awaugama has joined #openstack-nova | 19:22 | |
openstackgerrit | melanie witt proposed openstack/nova master: Correct the release notes related to nova-consoleauth https://review.openstack.org/595455 | 19:24 |
*** eharney has quit IRC | 19:25 | |
melwitt | mriedem: ^ updated the release note patch | 19:28 |
mriedem | so the config option help doesn't need to be updated? | 19:29 |
melwitt | oh, sorry. I missed that | 19:30 |
mriedem | looks ok otherwise | 19:32 |
mriedem | just update the option help and i think we're good | 19:32 |
openstackgerrit | melanie witt proposed openstack/nova master: Correct the release notes related to nova-consoleauth https://review.openstack.org/595455 | 19:37 |
melwitt | mriedem ^ | 19:41 |
*** mdrabe has quit IRC | 19:41 | |
*** mdrabe has joined #openstack-nova | 19:43 | |
*** awaugama has quit IRC | 19:45 | |
*** jaypipes has quit IRC | 19:46 | |
*** jaypipes has joined #openstack-nova | 19:47 | |
*** gbarros has joined #openstack-nova | 19:57 | |
*** holser_ has joined #openstack-nova | 20:05 | |
*** panda has quit IRC | 20:05 | |
openstackgerrit | Merged openstack/nova stable/rocky: block_device: Rollback volumes to in-use on DeviceDetachFailed https://review.openstack.org/590801 | 20:17 |
openstackgerrit | Merged openstack/nova stable/queens: block_device: Rollback volumes to in-use on DeviceDetachFailed https://review.openstack.org/590803 | 20:17 |
*** gbarros has quit IRC | 20:34 | |
mriedem | melwitt: +2 | 20:38 |
mriedem | now to find another core | 20:38 |
melwitt | thanks | 20:38 |
melwitt | jaypipes: are you still around? can you hit this for rc3 please? https://review.openstack.org/595455 | 20:39 |
melwitt | going to have to wait for APAC folk, methinks | 20:46 |
*** holser_ has quit IRC | 20:47 | |
*** hamzy has quit IRC | 20:48 | |
mriedem | is dansmith around? | 20:50 |
*** gbarros has joined #openstack-nova | 20:50 | |
melwitt | no, he started his day at 5am today so is off by now | 20:50 |
mriedem | oh | 20:51 |
melwitt | had a 5am meeting | 20:51 |
mriedem | and efried_afk is afk | 20:51 |
mriedem | how about i just +W? | 20:51 |
melwitt | could. I was thinking I have to be around to get stable cores for the stable/rocky backports anyway, so wasn't sure | 20:52 |
mriedem | tonyb is here for stable | 20:52 |
melwitt | https://review.openstack.org/594508 hasn't merged yet, still need review on the backport | 20:52 |
melwitt | once that merges | 20:52 |
mriedem | https://review.openstack.org/#/c/595455/ approved, can you propose the backport? | 20:54 |
melwitt | yarp. I should have proposed the other one too so you could review it. wasn't thinking | 20:54 |
openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Correct the release notes related to nova-consoleauth https://review.openstack.org/595890 | 20:55 |
melwitt | dangit, cherry-pick button doesn't do -x | 20:55 |
mriedem | not until it's merged | 20:55 |
melwitt | oh ok | 20:55 |
melwitt | that's what I get for trying buttons | 20:55 |
openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Correct the release notes related to nova-consoleauth https://review.openstack.org/595890 | 20:57 |
dansmith | mriedem: melwitt I put another +2 on 595455 | 21:01 |
dansmith | is that all? | 21:01 |
mriedem | and https://review.openstack.org/#/c/595864/ | 21:02 |
melwitt | dansmith: need stable review for this https://review.openstack.org/595864 master change not merged yet, so we'll have to hold till later for the second +2 | 21:03 |
melwitt | meaning, I'll ask tonyb after the master change lands | 21:03 |
melwitt | for the +W | 21:03 |
openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Handling a down cell https://review.openstack.org/595892 | 21:03 |
dansmith | melwitt: okay I slapped a +2 on there | 21:04 |
melwitt | thx | 21:05 |
*** erlon has quit IRC | 21:05 | |
melwitt | ok, cool. just have to babysit the patches through the gate, get tonyb for the backports, then should be good to go | 21:06 |
*** david-lyle has joined #openstack-nova | 21:15 | |
*** gbarros has quit IRC | 21:15 | |
openstackgerrit | Merged openstack/nova master: Normalize dashless 'resource provider create' uuid https://review.openstack.org/567191 | 21:16 |
*** dklyle has quit IRC | 21:17 | |
*** owalsh_ has joined #openstack-nova | 21:22 | |
*** owalsh has quit IRC | 21:25 | |
*** dpawlik has joined #openstack-nova | 21:26 | |
*** owalsh_ has quit IRC | 21:26 | |
*** owalsh has joined #openstack-nova | 21:27 | |
openstackgerrit | Merged openstack/nova master: libvirt: Don't react to VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED events https://review.openstack.org/594508 | 21:30 |
*** dpawlik has quit IRC | 21:30 | |
openstackgerrit | Merged openstack/nova master: Update contributor guide for Stein https://review.openstack.org/591258 | 21:30 |
openstackgerrit | Merged openstack/nova master: [placement] Add functional test to verify presence of policy https://review.openstack.org/595559 | 21:30 |
mriedem | tonyb: can you hit this for RC3? https://review.openstack.org/#/c/595864/ | 21:34 |
*** panda has joined #openstack-nova | 21:34 | |
tonyb | mriedem: done | 21:37 |
tonyb | anything else you need for RC3 you knwo where I am | 21:38 |
mriedem | the bottom of the world? | 21:40 |
*** dpawlik has joined #openstack-nova | 21:40 | |
*** tssurya has quit IRC | 21:42 | |
*** tssurya has joined #openstack-nova | 21:42 | |
*** mriedem is now known as mriedem_afk | 21:43 | |
*** tssurya has quit IRC | 21:43 | |
*** dpawlik has quit IRC | 21:45 | |
*** rcernin has joined #openstack-nova | 21:46 | |
* melwitt will bbl | 22:08 | |
*** r-daneel_ has joined #openstack-nova | 22:08 | |
*** r-daneel has quit IRC | 22:10 | |
*** r-daneel_ is now known as r-daneel | 22:10 | |
*** owalsh has quit IRC | 22:18 | |
*** owalsh has joined #openstack-nova | 22:22 | |
*** N3l1x has quit IRC | 22:35 | |
openstackgerrit | Merged openstack/nova master: Add functional test for affinity with multiple cells https://review.openstack.org/585073 | 22:50 |
*** threestrands has joined #openstack-nova | 22:53 | |
*** hamzy has joined #openstack-nova | 23:18 | |
*** macza has quit IRC | 23:21 | |
*** mlavalle has quit IRC | 23:28 | |
*** jaypipes has quit IRC | 23:33 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!