Thursday, 2018-09-20

*** gyee has quit IRC00:42
*** imacdonn has quit IRC00:49
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Add support changes-before for microversion 2.66  https://review.openstack.org/60354900:57
*** hongbin_ has joined #openstack-nova01:00
*** jogo has quit IRC01:00
*** yankcrime has quit IRC01:00
*** ebbex has quit IRC01:00
*** vabada has quit IRC01:00
*** tobias-urdin has quit IRC01:00
openstackgerritTetsuro Nakamura proposed openstack/nova-specs master: Spec: allocation candidates in tree  https://review.openstack.org/60358501:07
*** tetsuro has joined #openstack-nova01:07
*** mriedem_away has quit IRC01:08
*** imacdonn has joined #openstack-nova01:09
*** slaweq has joined #openstack-nova01:11
openstackgerritTao Li proposed openstack/python-novaclient master: Remove the unused instance-name  https://review.openstack.org/60252001:12
*** imacdonn has quit IRC01:14
*** imacdonn has joined #openstack-nova01:15
*** slaweq has quit IRC01:16
*** mhen has quit IRC01:18
*** mhen has joined #openstack-nova01:21
*** mrsoul has joined #openstack-nova01:25
*** Kevin_Zheng has joined #openstack-nova01:34
lbragstadgmann sounds good01:35
*** erlon has joined #openstack-nova01:35
*** _pewp_ has quit IRC01:46
*** _pewp_ has joined #openstack-nova01:47
*** _hemna has quit IRC01:47
*** _hemna has joined #openstack-nova01:49
*** erlon has quit IRC01:52
*** Dinesh_Bhor has joined #openstack-nova02:04
*** hoonetorg has quit IRC02:04
*** cfriesen has quit IRC02:09
*** jiteka has quit IRC02:11
*** eandersson has quit IRC02:11
*** jiteka has joined #openstack-nova02:11
*** tbachman has quit IRC02:12
*** tbachman has joined #openstack-nova02:15
*** jiteka has quit IRC02:15
*** hoonetorg has joined #openstack-nova02:17
*** jiteka has joined #openstack-nova02:18
*** eandersson has joined #openstack-nova02:24
*** eandersson has quit IRC02:31
openstackgerritSundar Nadathur proposed openstack/nova-specs master: Nova Cyborg interaction specification.  https://review.openstack.org/60395502:33
*** jiteka has quit IRC02:41
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Add support changes-before for microversion 2.66  https://review.openstack.org/60354902:50
*** jiteka has joined #openstack-nova02:52
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3)  https://review.openstack.org/57410402:57
*** jiteka has quit IRC03:01
*** hongbin_ has quit IRC03:02
*** slaweq has joined #openstack-nova03:11
*** Dinesh_Bhor has quit IRC03:11
*** Dinesh_Bhor has joined #openstack-nova03:12
openstackgerritfupingxie proposed openstack/python-novaclient master: Do not translate log messages.  https://review.openstack.org/60396203:12
*** slaweq has quit IRC03:16
*** sapd1_ has quit IRC03:45
*** sapd1 has joined #openstack-nova03:45
*** Dinesh_Bhor has quit IRC03:50
*** udesale has joined #openstack-nova03:53
*** tetsuro has quit IRC04:06
openstackgerritGhanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup  https://review.openstack.org/60396904:16
openstackgerritGhanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup  https://review.openstack.org/60396904:28
*** med_ has joined #openstack-nova04:29
*** eandersson has joined #openstack-nova04:34
*** cfriesen has joined #openstack-nova04:41
*** Dinesh_Bhor has joined #openstack-nova04:46
gmannlyarwood: i replied on this - https://review.openstack.org/#/c/602018/04:47
gmannlyarwood: stable branch patches needs to get in before openstack-infra/openstack-zuul-jobs one04:47
*** med_ has quit IRC04:51
*** med_ has joined #openstack-nova04:52
*** ShilpaSD has joined #openstack-nova04:52
*** janki has joined #openstack-nova05:02
*** jaosorior has quit IRC05:03
*** ratailor has joined #openstack-nova05:18
*** brinzhang has joined #openstack-nova05:36
*** med_ has quit IRC05:38
*** alexchadin has joined #openstack-nova05:39
*** Luzi has joined #openstack-nova05:44
*** Dinesh_Bhor has quit IRC06:08
*** alexchadin has quit IRC06:08
*** holser_ has joined #openstack-nova06:09
*** Dinesh_Bhor has joined #openstack-nova06:15
*** tetsuro has joined #openstack-nova06:19
*** jaosorior has joined #openstack-nova06:25
openstackgerrithuanhongda proposed openstack/nova stable/ocata: Cleanup RP and HM records while deleting a compute service.  https://review.openstack.org/60374906:28
openstackgerritfupingxie proposed openstack/nova master: Avoid Forcing the Translation of Translatable Variables  https://review.openstack.org/60399306:29
*** dpawlik_ has joined #openstack-nova06:38
*** Dinesh_Bhor has quit IRC06:38
*** belmoreira has joined #openstack-nova06:39
*** dpawlik has quit IRC06:39
*** Dinesh_Bhor has joined #openstack-nova06:42
*** dpawlik_ has quit IRC06:45
*** dpawlik has joined #openstack-nova06:45
*** slaweq has joined #openstack-nova06:47
openstackgerritZhenyu Zheng proposed openstack/nova master: Only update cells' transport_url and database_connection when needed.  https://review.openstack.org/60399806:47
*** ralonsoh has joined #openstack-nova06:50
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands  https://review.openstack.org/48740506:53
*** skatsaounis has joined #openstack-nova07:02
*** rcernin has quit IRC07:02
*** sahid has joined #openstack-nova07:08
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Add support changes-before for microversion 2.66  https://review.openstack.org/60354907:38
*** Dinesh_Bhor has quit IRC07:39
bauzasgood morning07:44
sean-k-mooneygood morning :)07:45
gibigood morning folks07:46
*** jpena|off is now known as jpena07:47
*** Dinesh_Bhor has joined #openstack-nova07:49
*** cfriesen has quit IRC07:49
*** helenafm has joined #openstack-nova07:51
*** Dinesh_Bhor has quit IRC07:54
*** Dinesh_Bhor has joined #openstack-nova08:01
*** hoangcx has quit IRC08:04
*** hoangcx has joined #openstack-nova08:04
*** ebbex has joined #openstack-nova08:06
*** jaosorior has quit IRC08:12
*** janki has quit IRC08:13
*** yankcrime has joined #openstack-nova08:17
*** janki has joined #openstack-nova08:20
openstackgerritMerged openstack/nova master: libvirt: Drop MIN_LIBVIRT_VHOSTUSER_MQ  https://review.openstack.org/56547208:26
*** bhagyashris has joined #openstack-nova08:27
*** jchhatbar has joined #openstack-nova08:27
*** janki has quit IRC08:28
*** jchhatba_ has joined #openstack-nova08:29
*** jchhatbar has quit IRC08:32
*** jiteka_ has joined #openstack-nova08:46
kashyapHey folks, I wonder if anyone here knows Linux systems where only /dev/random exists08:49
kashyapAnd not /dev/urandom.08:49
kashyapBecause I'm considering to add a default 'virtio-rng' device for Nova guests, whic uses /dev/urandom.08:50
kashyaphttps://bugs.launchpad.net/nova/+bug/178986808:50
openstackLaunchpad bug 1789868 in OpenStack Compute (nova) "RFE: Add a virtio-rng device to Nova instances by default" [Medium,Triaged] - Assigned to Kashyap Chamarthy (kashyapc)08:50
*** jiteka_ has quit IRC08:50
kashyap(If anyone is wondering why '/dev/urandom'?  It is non-blocking, and doesn't have the same limitations of `/dev/random`, which is a legacy interface.08:52
*** wznoinsk_ is now known as wznoinsk08:52
*** jaosorior has joined #openstack-nova08:58
*** Bhujay has joined #openstack-nova09:00
*** frankwang has joined #openstack-nova09:01
*** Dinesh_Bhor has quit IRC09:01
openstackgerrithuanhongda proposed openstack/nova stable/ocata: Cleanup the caches when deleting a resource provider  https://review.openstack.org/60402109:02
kashyapstephenfin: The last clean up (IIRC) in that series: https://review.openstack.org/#/c/562313/ (libvirt: Drop MIN_LIBVIRT_PARALLELS_SET_ADMIN_PASSWD)09:13
*** Tahvok has left #openstack-nova09:19
*** Dinesh_Bhor has joined #openstack-nova09:19
*** tetsuro has quit IRC09:28
*** helenafm has quit IRC09:30
stephenfinkashyap: cool, I'll take a look now09:30
*** jchhatba_ has quit IRC09:31
*** janki has joined #openstack-nova09:31
kashyapstephenfin: Thanks; it's not urgent.  Just a boring thing to tick off, when you have time09:34
*** tobias-urdin has joined #openstack-nova09:35
*** derekh has joined #openstack-nova09:37
*** belmoreira has quit IRC09:38
*** moshele has joined #openstack-nova09:38
*** bhagyashris has quit IRC09:40
*** dtantsur|afk is now known as dtantsur09:43
*** janki has quit IRC09:45
*** janki has joined #openstack-nova09:51
openstackgerritYikun Jiang proposed openstack/nova master: WIP: Add nova database migration script(psql version)  https://review.openstack.org/60402609:51
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Drop MIN_LIBVIRT_PF_WITH_NO_VFS_CAP_VERSION  https://review.openstack.org/56551709:51
*** kevko_home has joined #openstack-nova09:52
kevko_homeHello guys , can i have simple question on you :) ?09:52
*** jaosorior has quit IRC09:53
*** jlvillal has quit IRC09:54
*** jlvillal has joined #openstack-nova09:54
openstackgerritYikun Jiang proposed openstack/nova master: WIP: Add nova database migration script(psql version)  https://review.openstack.org/60402609:57
*** jchhatbar has joined #openstack-nova10:00
*** janki has quit IRC10:03
*** helenafm has joined #openstack-nova10:04
*** pcaruana has joined #openstack-nova10:04
kashyapkevko_home: Just ask, someone might respond.10:06
*** Dinesh_Bhor has quit IRC10:13
*** takashin has quit IRC10:13
*** Dinesh_Bhor has joined #openstack-nova10:15
*** Dinesh_Bhor has quit IRC10:16
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Add support changes-before for microversion 2.66  https://review.openstack.org/60354910:24
*** alexchadin has joined #openstack-nova10:27
*** alexchadin has quit IRC10:28
*** alexchadin has joined #openstack-nova10:28
*** alexchadin has quit IRC10:33
*** tbachman has quit IRC10:42
*** takashin has joined #openstack-nova10:43
openstackgerritJohn Garbutt proposed openstack/nova-specs master: WIP: Spec for API policy updates  https://review.openstack.org/54785010:47
*** jlvillal has quit IRC10:50
gibibauzas, tetsuro: I managed to re-use the existing ServerMovingTests functional test set to verify the nested allocations during move operations. I found that force livemigrate and every evacuate case are faulty.10:51
gibibauzas, tetsuro: I will push the patch soon10:51
gibibauzas, tetsuro: I mean the fault reproduction patch, then I will look at how to solve the problem10:52
*** jlvillal has joined #openstack-nova10:53
*** jchhatbar is now known as janki10:56
*** belmoreira has joined #openstack-nova10:57
*** jpena is now known as jpena|lunch10:57
*** jaosorior has joined #openstack-nova10:58
openstackgerrithuanhongda proposed openstack/nova stable/ocata: Cleanup RP and HM records while deleting a compute service.  https://review.openstack.org/60374910:58
openstackgerritGhanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup  https://review.openstack.org/60396910:58
*** udesale has quit IRC10:58
*** tetsuro has joined #openstack-nova10:59
*** s10 has joined #openstack-nova11:06
*** erlon has joined #openstack-nova11:07
openstackgerritVlad Gusev proposed openstack/nova stable/pike: libvirt: Reduce calls to qemu-img during update_available_resource  https://review.openstack.org/60403911:07
*** pcaruana has quit IRC11:15
*** ratailor has quit IRC11:16
*** pcaruana has joined #openstack-nova11:20
openstackgerritTakashi NATSUME proposed openstack/nova master: Add API ref guideline for examples  https://review.openstack.org/60406011:22
*** alexchadin has joined #openstack-nova11:28
*** pcaruana has quit IRC11:32
*** alexchadin has quit IRC11:33
*** pcaruana has joined #openstack-nova11:39
*** tssurya has joined #openstack-nova11:39
kevko_homeGuys, i am packaging nova for debian. Current situation is that i have several packages , nova-common , nova-api, nova-placement-api, nova-conductor ...etc11:48
kevko_homeEach of package is doing his work, for example nova-common creating database users, etc, and also populating nova db. I have also nova-placement-api and nova-api which are doing same stuff with populating db, nova-placement-api creating database placement , users, grants ..etc ..fill connection in config and run nova-manage api_db sync , same in nova-api create db nova , users , grants, run nova-manage api_db sync.11:48
kevko_homeProblem is that i have error when api_database connection is missing in nova-placement-api package, does it mean that nova-placement-api needs both nova_api and placement connection settings filled ? Shouldn't be command separate for nova_api and placement ... something like nova-manage api_db sync , nova-mange api_placement sync ?11:48
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix missing specifying doctrees directory  https://review.openstack.org/60406811:49
*** pcaruana has quit IRC11:50
bauzasgibi: hola, what's the fault ?11:55
tssuryakevko_home: which release are you using ?11:58
kevko_hometssurya: rocky11:58
tssuryaI think in Rocky for a new set-up its something like nova_api DB is the default placement-DB11:59
kevko_hometssurya: does it mean that placement database not needed ?12:00
tssuryahttps://docs.openstack.org/nova/rocky/configuration/config.html#placement_database.connection12:00
tssuryarefer to ^ ,12:01
kevko_hometssurya: i don't think you understand me :)12:01
*** priteau has joined #openstack-nova12:04
tssuryathere is no seperate DB sync commands as of yet, but probably cdent can help you more12:04
kevko_hometssurya: i have several deb packages , nova-common - create nova db, db user, db grants, set api_database.connection in nova.conf ( questions are answered in debconf ), run nova-manage db sync , nova-api do the same thing with one difference , run nova-manage api_db sync with fill api_database.connection to right value , nova-placement-api same thing with difference that set placement_database.connection value .... everything is12:05
kevko_homework as expected ....but in nova-placement api postinst i have this : http://paste.openstack.org/show/730413/12:05
kevko_hometssurya: so basically , i think nova-manage api_db sync should be splitted to two separate commands for fill api_db and placement_api12:06
kevko_hometssurya: because nova-placement-api and nova-api can run standalone ...why there is sync command which is trying fill both databases if i let's say configuring nova-placement-api only on some server ?12:07
*** alexchadin has joined #openstack-nova12:08
kevko_hometssurya: or add if clauses on  CONF.placement_database.connection is not None:   else: LOG.warning(''Nova-manage will not run , you have to configure api_database.connection')12:08
kevko_hometssurya: i can send a code to review ..but wanted to discuss this with you guys in nova channel ...12:09
kevko_hometssurya: because if i know , placement will be totally moved into separate project ...but don't know when ..12:10
tssuryaits in the transition phase12:10
kevko_hometssurya: and what do you think about my above thinkings ? :/12:11
tssuryalooking more into the code..12:12
tssuryakevko_home: okay so you basically want the user to be warned if placement_database.connection is not set ?12:14
tssuryaand nova_api.databaseconnection is also not set ?12:14
kevko_hometssurya: yes,  something like that ..let me send you diff ..w8 a minute12:15
tssuryawell I guess the Rocky documentation deployment (https://docs.openstack.org/nova/rocky/user/placement.html#deployment) states api_db sync command is used for both syncing and if you set placement_db conn it will be used and if you don't set that, it is expected that you set the api_db conn.12:16
tssuryaI understand your concern though, and the need for a check seems ok to me,12:17
kevko_hometssurya: something like this http://paste.openstack.org/show/730414/12:19
kevko_hometssurya: ok, i will send a review then12:19
gibibauzas: sorry I was out grabbing food. The fault is that nova does not consider allocations agains the child RPs during the move12:22
tssuryakevko_home: ack12:22
*** tbachman has joined #openstack-nova12:24
*** tbachman has quit IRC12:30
Kevin_Zhengtssurya Hi12:33
Kevin_Zhengdoes this bothers CERN?12:33
Kevin_Zhenghttps://launchpad.net/bugs/179342312:33
openstackLaunchpad bug 1793423 in OpenStack Compute (nova) "Should not read config options while update cells" [Undecided,In progress] - Assigned to Zhenyu Zheng (zhengzhenyu)12:33
Kevin_Zhengor it is made this way12:33
*** aloga has quit IRC12:35
*** aloga has joined #openstack-nova12:36
tssuryaKevin_Zheng: we don't use the update_cell command command very often, but what you have reported has always bugged me :)12:36
Kevin_ZhengHa12:36
tssuryameaning the update_cell command is used for a lot of other stuff than just updating the DB connection and transport_url12:36
tssuryaso it is not fair that these two always have to be passed to ensure they don't get over written by the config options12:37
*** tbachman has joined #openstack-nova12:38
tssuryaKevin_Zheng: although I don't understand your point 2: where you say you can't use nova_12:39
tssuryanova_cell1.conf12:39
tssuryabecause you need api_database connection,12:40
tssuryafor update_cell ?12:40
Kevin_Zhengsorry disconnected12:40
tssuryanp, did you get the messages ^ ?12:41
Kevin_Zhengyeah, I saw them12:41
Kevin_Zhengreading12:41
Kevin_Zhengyeas12:41
Kevin_Zhengyeah12:41
Kevin_Zhengwe have to update the records in api_db12:42
tssuryaah okay12:42
tssuryayea sorry, got confused12:42
tssuryabut now that you mention "up_calls" we have the same problem for nova-manage db archive_deleted_rows12:43
Kevin_Zhenghmm12:43
*** Bhujay has quit IRC12:43
*** Bhujay has joined #openstack-nova12:44
*** Bhujay has quit IRC12:45
*** Bhujay has joined #openstack-nova12:45
*** alexchadin has quit IRC12:48
*** alexchadin has joined #openstack-nova12:48
*** janki has quit IRC12:50
*** med_ has joined #openstack-nova12:51
openstackgerritZhenyu Zheng proposed openstack/nova master: Only update cells' transport_url and database_connection when needed.  https://review.openstack.org/60399812:52
openstackgerrithuanhongda proposed openstack/nova master: Fix instance delete stuck in deleting task_state  https://review.openstack.org/59808412:52
*** alexchadin has quit IRC13:01
openstackgerritVlad Gusev proposed openstack/nova stable/pike: libvirt: Reduce calls to qemu-img during update_available_resource  https://review.openstack.org/60403913:04
*** mriedem has joined #openstack-nova13:06
*** cdent has joined #openstack-nova13:15
mnaserthere isn't a way to delete a compute node from the db, is there?13:16
bauzasmnaser: by SQL goos ?13:16
mnaserwell, without sql13:16
bauzasah13:17
mnasernova service-delete deletes the service but the compute node record is still there13:17
mnaserand scheduler complains constantly about 'No compute service record found for host <foo>'13:17
bauzasthat's a good point13:17
bauzascompute_node records are automatically populated by the resource tracker13:17
openstackgerritBalazs Gibizer proposed openstack/nova master: Use provider tree in virt FakeDriver  https://review.openstack.org/60408313:17
openstackgerritBalazs Gibizer proposed openstack/nova master: Run ServerMovingTests with nested resources  https://review.openstack.org/60408413:17
gibibauzas, tetsuro ^^13:18
mnasermaybe that error should check if there is an existing service, or something13:18
bauzasmnaser: I thought we were checking this in the RT code13:18
mnaserbut this is on the nova-scheduler code, i think RT code sits in nova-compute ?13:18
bauzasgibi: all cool, been frankly diverted by working on the reshape patch13:18
bauzas(and by meetings)13:18
bauzasmnaser: yup, run by nova-compute service13:19
bauzasI'm just saying we populate the entries there13:19
mnaseryeah but in this case it's taking a hypervisor out of service forever13:19
mnaserso turn it off, nova service-delete <foo> and that error doesnt go ahway13:19
mnasers/ahway/away/13:19
lbragstadjohnthetubaguy gmann nice work on https://review.openstack.org/#/c/547850/13:20
bauzasyup, I see the problem13:20
mnaserhttps://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L716-L72013:20
mnasermaybe we should clean up there (or delete compute record when a nova-compute binary is deleted)13:20
bauzasmnaser: here is where we create the entry in the DB https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L58713:21
bauzasmnaser: we had a FK before13:21
bauzasbetween service and CN13:21
mnaserbut i guess with the os-services api addition and making it managable by api13:21
mnaserthat might have disappeared13:21
mnaseror some other historic reason you might know more than me :)13:21
mnaseroh you know what13:22
mnaserFK might not do anything anyways, because we just change deleted field13:22
mnaserso for all that sql cares, FK is still satisified13:22
bauzaswell, actually that's a good point13:23
bauzaswe shadow the services table13:23
bauzasso a CASCADE DELETE isn't like super important13:23
bauzasBBIAB13:24
mnaserfiled a bug: https://bugs.launchpad.net/nova/+bug/1793533 -- i can take care of pushing the code to fix it if i can get some guidance on the best approach13:26
openstackLaunchpad bug 1793533 in OpenStack Compute (nova) "Deleting a service with nova-compute binary doesn't remove compute node" [Undecided,New]13:26
*** udesale has joined #openstack-nova13:27
*** jpena|lunch is now known as jpena13:29
mriedemmnaser: deleting the compute service should also delete the compute node record in the db13:31
mnasero13:31
mriedemmnaser: the problem is you need to also have nova-compute for that host stopped13:31
mriedemotherwise the RT will re-create the compute node record13:31
mriedemhttps://developer.openstack.org/api-ref/compute/#delete-compute-service13:31
*** jistr is now known as jistr|call13:32
mnaseri'm pretty sure it was stopped when i did this (actually, the hypervisor was rebooted with a new hostname so i just deleted the old one)13:32
mnaserlet me see the created_at time for the compute node record if there is one13:32
mriedemhttps://github.com/openstack/nova/blob/d87852ae6a1987b6faa3cb5851f9758b47ef4636/nova/db/sqlalchemy/api.py#L40413:34
mriedem^ is the DB API deleting the service and compute node record when you delete the service via DELETE /os-services/{service_id}13:34
*** frankwang has quit IRC13:34
mnasermriedem: created_at for compute node record is '2018-04-13 00:21:53', created_at for service (that was deleted) is '2018-04-13 00:21:53'13:34
mnaseroo13:35
mriedemdo the host values align?13:35
mnaserdeleted=16 on compute node13:35
mnaserso it was soft deleted13:36
mnaseryes, they do, it was actually soft deleted13:36
mnasercould it be that loop doesn't grab non-soft deleted compute nodes?13:37
mnaserthat would be the only logical thing happening13:37
mnaserOR13:37
mriedemby default that query is only going to look up non-soft-deleted cmpute node records that match the query13:37
mnaserit looks like it uses _get_computes_for_cells ?13:37
mnaserso maybe it is looking in nova_api compute node lists?13:38
mriedemwhich loop are you talking about?13:38
mnasermriedem: https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L71313:38
mnaserwhatever comes in here is including a deleted item13:38
mnaseri just confirmed it by adding LOG.debug(computes)13:38
mnaserand i see the deleted one that it complains about13:39
mriedemis there a resource provider in placement for the deleted compute node still?13:39
mriedemopenstack resource provider show <compute node uuid>13:39
mnaseryes13:40
mriedemhmm, you're on rocky right? is nova-api configured to talk to placement?13:40
mnaserthis is a queens deployment13:40
mnasernova-api talking to placement13:40
mriedemok, well we backported a fix for that to queens also,13:40
mnaserand also, shouldn't we need to delete it from nova_api mappings? maybe thats where its getting it from?13:40
mriedembut only if nova-api is configured to talk to placement,13:41
mriedemthen the api will also delete the RP record in placement when the compute node is deleted13:41
mriedemhost mappings?13:41
mriedemthat's also part of that fix13:41
tssuryaHMs are also deleted13:41
mriedemlemme dig it up13:41
mnasernova_api host_mappings still contains that compute node13:41
mnasernow this is early queens so that could very well be the cause, be good to see if i have that fix or not13:42
tssuryahttps://review.openstack.org/#/c/563698/13:42
mnaseraaaa13:42
mriedemyup that's the one13:42
*** liuyulong has joined #openstack-nova13:42
mnaserlet me double check that doesnt exist13:42
mnasernope13:43
mnaserthat's probably it13:43
mnaserill mark my bug as duplicate of that one13:43
mriedemyeah so the RP is still in placement, and it gave it back to the scheduler, and the scheduler somehow looked it up13:44
mriedemi'm curious as to why the scheduler is looking up deleted compute nodes though13:44
mnaseryeah, that doesn't seem right i guess13:44
dansmithum, guys, obvi13:44
dansmithit's scheduling a deleted instances13:45
mnaserobjects.ComputeNodeList.get_all(cctxt)13:45
mriedemi see the bug13:45
mriedem175617913:45
mriedemoops13:45
mriedemdef _db_compute_node_get_all_by_uuids(context, compute_uuids):13:45
mriedem        db_computes = context.session.query(models.ComputeNode).filter(13:45
mriedem            models.ComputeNode.uuid.in_(compute_uuids)).all()13:45
mriedem        return db_computes13:45
*** alexchadin has joined #openstack-nova13:46
*** brinzhang has quit IRC13:46
mriedemisn't using model_query so it's not filtering out soft deleted records13:46
tssuryayikes13:46
mnaserdo i want to mark my bug as duplicate and create another one for that ^ or use the same one to cover that13:47
dansmithhmm, I wonder why we did that13:47
dansmithinstead of writing it in sqla/api.py13:47
mriedembecause the new jazz is to write db stuff in the objects13:47
mriedemmnaser: we'll use yours for the query thing13:48
mriedemi'll un-invalidate it13:48
dansmithmriedem: only for api objects13:48
mriedemoh, then idk13:48
dansmithor at least, I've been still putting main stuff in there13:48
dansmithIIRC we agreed to not put api stuff int here, but keep doing it for the main stuff, but13:49
mriedemyou'd have to ask papa bear https://review.openstack.org/#/c/418134/13:49
* dansmith scrolls up lookin for what the bug is13:49
mriedemdansmith: https://bugs.launchpad.net/nova/+bug/179353313:50
openstackLaunchpad bug 1793533 in OpenStack Compute (nova) "Scheduler doesn't filter out deleted compute node records based on placement RP UUIDs" [Medium,Triaged]13:50
bauzasI'm back13:50
bauzasPapaOurs is here13:50
mriedemdansmith: so you got this one?13:50
bauzasany regression I made, mmm ?13:50
*** mdbooth_ has joined #openstack-nova13:50
*** mdbooth_ is now known as mdbooth13:50
tssuryaQ: placement should not even return deleted RPs right ? the list of compute_uuids coming from placement should be legit ? or its okay because the post-scheduler compute filter is supposed to check for these conditions like it doesn for enabled/disabled ?13:50
*** mschuppert has joined #openstack-nova13:51
dansmithmriedem: but the real problem is not in placement but that we keep finding the compute node in our search yeah?13:51
bauzastssurya: we have a filter for this13:51
mriedemtssurya: mnaser didn't have https://review.openstack.org/#/c/563698/13:51
mriedemtssurya: so yes this is a side effect that shouldn't otherwise happen13:51
bauzaswe have the ComputeFilter13:51
tssurya(I understand that beore this fix, the RPs were not deleted so it they are returned, but in current situation it should be okay right ?)13:51
dansmithmriedem: I got this one what? you want me to fix it up?13:51
tssuryabauzas: yea that filter13:51
mriedemdansmith: i assumed you were asking for the bug in order to push a change13:52
mnaserif we get a fix it'd be nice to get a dot release for nova, last queens release was end of may13:52
dansmithno, I was just curious what the symptom was.. but I can fix it up, sure13:52
jrollTIL papa bear is not a name for comstud13:52
dansmithmnaser: ++13:52
bauzasso I think we agreed maybe in Portland that the Placement API wouldn't check whether the node is active or not13:52
mriedemmnaser: we know - i've been watching rocky/queens/pike/ocata approved changes sit in the gate for 3 days13:52
mnaser:(13:52
cdentbauzas: correct13:53
mriedemhttp://lists.openstack.org/pipermail/openstack-dev/2018-September/134867.html13:53
mnaserrough times out here13:53
tssuryaack13:53
bauzasjroll: https://scontent-cdt1-1.xx.fbcdn.net/v/t1.15752-9/41984667_323237498424760_7346301711654322176_n.jpg?_nc_cat=0&oh=a19da45f6d7b7b799d8f831e7f3c4a05&oe=5C1954CF13:53
mriedembauzas: tssurya: cdent: dansmith: mnaser: in true form, we're all talking past each other13:53
mriedemdoes someone want me to summarize the issue here?13:53
jrollbauzas: add a guitar and you can come work on ironic :)13:53
dansmithseems clear,13:54
cdentmriedem: I think i was following along okay, was just trying to pause bauzas13:54
tssuryaI have understood this to be something needed as a regression fix for the code before this patch13:54
gibinova meeting stars in 6 minutes on #openstack-meeting13:54
tssuryaso its clear to me too13:54
bauzaswait wait13:54
mriedemso bauzas is the odd man out13:54
dansmithwe are not filtering the list of placement results against compute nodes that exist13:54
mnaseryes, we're getting *all* including deleted ones13:54
bauzascan someone explains me what's the problem ?13:54
tssuryayep yep13:54
dansmithbauzas: wait for my bug fix13:54
mriedemdansmith: yes, but we were only given those uuids for deleted records because mnaser doesn't have https://review.openstack.org/#/c/563698/13:54
dansmithit'll be clear then13:54
bauzassee my BBIAB 30 mins before :)13:54
bauzasdansmith: ok cool13:54
dansmithmriedem: right13:54
mriedemwhich would have deleted the RP in placement when the compute service was deleted13:55
* bauzas goes to use a coffee machine13:55
mriedemit's just a simple side effect13:55
mnaserbauzas: if a compute service is deleted (but still somehow in placement and has host_mappings, something which a bug has fixed not long ago), then nova ComputeNodeList.get_all_by_uuids returns that, it shouldn't13:55
dansmithmriedem: yeah, but we could need to delete a compute node when placement is down or something, so definitely should fix this issue13:55
bauzasjroll: meh, I do have a guitar as well at home...13:55
jroll++13:56
mnaserbauzas: and the reason was because get_all_by_uuids() doesn't use model_query so it doesn't filter against soft deleted stuff13:56
mnaserthat's what i got out of it and it makes sense enough for me :p13:56
*** awaugama has joined #openstack-nova13:56
mriedemdansmith: sure i agree13:56
bauzasmnaser: we don't have services in placement, just compute nodes, but okay I understand you :)13:56
mnaseri'm trying here13:56
mnaserhaha13:56
* mriedem moves to the meeting channel13:56
bauzas3 mins dude13:57
bauzastoo early13:57
mnaserone last thing: is someone pushing up a patch for this or is it on me?13:57
mriedemdan is13:57
mnaser(i dont mind)13:57
mnaserok cool13:57
bauzasi think dansmith said13:57
mnaserthanks dansmith13:57
bauzasyeah that13:57
mriedem*head explodes*13:57
bauzasjust throw me tomatoes now if I regressed :)13:57
dansmithbauzas: you did regress13:57
dansmithbut I will fix13:58
efriedstephenfin: Can you please see if I used the correct arguments here? https://review.openstack.org/#/c/603993/13:58
bauzasdansmith: you're the hero and I'm the villain then ;)13:58
dansmithper usual13:58
bauzasI can snip fingers, don't tempt me13:58
bauzassnap*13:59
*** litao has quit IRC14:00
*** jaypipes is now known as jaypipes-ooo14:03
*** mdbooth has quit IRC14:06
*** mdbooth has joined #openstack-nova14:07
*** dpawlik has quit IRC14:11
*** mlavalle has joined #openstack-nova14:11
*** moshele has quit IRC14:11
*** claudiub has joined #openstack-nova14:21
*** alexchadin has quit IRC14:21
*** alexchadin has joined #openstack-nova14:25
*** jistr|call is now known as jistr14:34
openstackgerritDan Smith proposed openstack/nova master: Filter deleted computes from get_all_by_uuids()  https://review.openstack.org/60410814:37
*** Luzi has quit IRC14:37
*** dpawlik has joined #openstack-nova14:41
mriedemmdbooth: did you see the evacuate integration tests are passing?14:45
*** dpawlik has quit IRC14:45
mdboothmriedem: I didn't, but I will as soon as poss :)14:45
mriedemnot much to see - we evacuate with the down compute so it fails, and then bring libvirtd back up and evacuate and it passes14:46
mriedemonly question is if it should be horked into the live migration job which is convenient but sorta confusing14:46
mdboothmriedem: Ideally we'd have it in a few places: would be good to cover both shared and non-shared.14:47
mdboothPerfectly we'd cover 'all 4' cases, but I don't think we have all 4 in CI.14:47
mriedemall 4 is what again? volume-backed, local disk not shared, local disk shared14:48
mriedemwhat's the other?14:48
mdbooth2 axes are: shared instance, shared disk.14:48
mriedemright now the patch is running on ceph local shared14:48
mriedemthe script could be updated to create a volume-backed server and evacuate again14:49
mnaseris there a reason why running debug=True doesn't show the http requests done by placement client?14:49
*** ratailor has joined #openstack-nova14:49
openstackgerritEric Fried proposed openstack/nova master: WIP: libvirt: Turn off max_unit  https://review.openstack.org/60411014:49
mnaserrather than reconstructing the http request, it'd be nice to know what nova-scheduler is asking placement14:50
mriedemwe call placement over ksa,14:50
mriedemso our debug=True logging is likely not carrying over to ksa14:50
mnaserbecause before debug=True would show you the filters running through things14:51
mnaserand you'd be able to debug scheduler issues14:51
mriedemyou just want to see like the GET /allocation_candidates request right?14:51
mnasernow it just starts filtering a subset and you don't know where that came from so yeah14:51
*** Bhujay has quit IRC14:51
mnaserstuff like that, yes, so that i know why this live migration is not getting scheduled on one of the hosts14:51
mnaserthere's empty capacity but it's not adding it14:52
mnaserprobably something along the lines of placement being inconsistent14:52
* mnaser should really write a tool that audits placement / nova14:52
mriedemare you passing the specific target host for the live migration to the compute API?14:52
mriedembecause i know of another bug related to that...14:53
mnasernope im not passing one14:53
mriedemok, you just expect a certain host to be picked b/c of weights and capacity etc?14:53
mnaseryeah, it's not even hitting weight/capacity, placement is not returning a host that has capacity14:53
mriedemi think we'd have to add something like this https://github.com/openstack/nova/blob/master/nova/config.py#L3914:54
efriedDoes the placement log not show the full command line?14:54
*** cfriesen has joined #openstack-nova14:54
mnaserwhich tells me there's probably incorrect allocations in placement that make that host look 'overloaded'14:54
mnaserah that's a good alternative, checking uwsgi logs on placement side14:54
mriedemthere should be the same request id on both sides14:54
mriedemthat's your workaround for now14:54
efriedThe placement logs by default won't show the payloads (request or response) but the queryparams are there I thought.14:54
mriedemyes they should be14:55
mnaseri should be able to rerun that http request14:55
mriedemhttp://logs.openstack.org/75/470775/38/check/tempest-full/a97793a/controller/logs/screen-placement-api.txt.gz#_Sep_06_13_02_32_18123414:55
efriedsorry, "command line" was a bogus phrase14:55
mriedemSep 06 13:02:32.181234 ubuntu-xenial-ovh-bhs1-0001824138 devstack@placement-api.service[6991]: DEBUG nova.api.openstack.placement.requestlog [req-68f9280e-61b2-446e-8622-a64e27e7c617 req-df696f1f-3435-4b6c-8a3b-c6dc1c58c1ba service placement] Starting request: 158.69.79.172 "GET /placement/allocation_candidates?limit=1000&resources=MEMORY_MB%3A64%2CVCPU%3A1" {{(pid=6993) __call__ /opt/stack/nova/nova/api/openstack/placement/r14:55
mriedemstlog.py:38}}14:55
mriedemmust be a bfv instance ^ because there is no DISK_GB requested14:55
mnaseryup /allocation_candidates?limit=1000&resources=DISK_GB%3A10%2CMEMORY_MB%3A2048%2CVCPU%3A414:56
mnaserlets see14:56
*** Swami has joined #openstack-nova14:57
mnaseropenstack allocation candidate list --resource DISK_GB=10 --resource MEMORY_MB=2048 --resource VCPU=4 => Operation or argument is not supported with version 1.014:58
mnasermriedem: do i need some special env variable?14:58
mnasersigh14:58
mnaser--os-placement-api-version 1.1014:58
mnaserill read docs from now on14:58
gibiFYI, I've added the bp use-nested-allocation-candidates to the 3rd runway slot14:59
gibiFirst part of https://blueprints.launchpad.net/nova/+spec/use-nested-allocation-candidates (gibi) [END: 2018-10-04]14:59
cdenti guess I need to learn osc-placement so I can parse this stuff. I'm still back on raw curl which is nice and comfy and explicit15:00
mnaseryeah it's returning one host (the host itself) which gets filtered out in a live migration, i think i'll have to write up the clean up / audit stuff15:00
*** mdbooth has quit IRC15:00
mnasercdent: it's nice to not have to write it all out esp to grab a token and then build out a curl request15:00
*** mdbooth has joined #openstack-nova15:00
mriedemmnaser: yeah osc is opt-in per request for microversions, unlike nova cli15:01
mriedemyou could just set an env var if you want the latest,15:01
mriedemexport OS_PLACEMENT_API_VERSION=<whatever you have that is the latest>15:01
*** takashin has left #openstack-nova15:02
cdentmnaser: yeah, totally agree that if you haven't built the curl-based habits the osc way is good. It's just that since I've been curl-ing against placement for such a long time I've got habits (including the token getting and using parts) that are rather built in. I'm complaining about myself here, not other people.15:03
mnasercdent: yeah i have a lot of terrible old habits15:03
mnasercdent: like using LOG.debug() instead of an actual debugger15:03
cdentdood! LOG.debug() is too fancy. sys.stderr.write() 4evah15:03
mnaserSystem.out.println()15:04
mnaserat least we're not in that darkest timeline15:04
*** alexchadin has quit IRC15:04
*** dklyle has joined #openstack-nova15:04
*** etp has joined #openstack-nova15:06
tobias-urdinwhen live migrating is the vcpu_pin_set option a 1:1 mapping for source and dest host? I start at the same lowest possible core but some machines have different amount of vcpus available, if I migrate an instances that has vcpu 79 but source host only has 60 vcpu will it reallocate where to place that or error out?15:06
mnaseri think that's a libvirt decision15:07
tobias-urdinyou are probably correct, will trace some more15:08
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Add support changes-before for microversion 2.66  https://review.openstack.org/60354915:08
mriedemi didn't think live migration + cpu pinning was supported yet?15:09
mriedemcfriesen: ^?15:09
*** helenafm has quit IRC15:10
cfriesenmriedem: tobias-urdin: live migration doesn't currently recalculate CPUs on the dest node.  This is one of the things covered under the "numa-aware live migration" blueprint.15:12
tobias-urdincfriesen: roger that, thanks :)15:12
cfriesentobias-urdin: the live migration *might* succeed, but it might end up putting multiple guest CPUs on the same host CPU, or it might fail due to different host topology.15:13
tobias-urdinok, that explains why it worked atleast thanks15:14
zzzeekjaypipes-ooo: think fast!  what's your favorite innodb_flush_method setting !  don't think!15:14
*** jiaopengju has quit IRC15:15
*** jiaopengju has joined #openstack-nova15:15
jaypipes-ooozzzeek: direct?15:16
zzzeekjaypipes-ooo: OK15:16
zzzeekjaypipes-ooo: we're adding the option to tripleo15:17
jaypipes-ooozzzeek: but only if there is a battery-backed write cache on the disks.15:17
jaypipes-ooozzzeek: otherwise, keep it normal.15:17
openstackgerritMerged openstack/nova stable/rocky: Fix nova-status "_check_resource_providers" check  https://review.openstack.org/60009815:18
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Add support changes-before for microversion 2.66  https://review.openstack.org/60354915:19
zzzeekjaypipes-ooo: OK is that impacting the durability of the logs only?   usually  b.c. we use galera, we assume write sets have also gone to other nodes15:20
zzzeekjaypipes-ooo: so w/ these kinds of options, we have to worry about all galera nodes power off simultaneously, but if only one machine, then not15:20
openstackgerritBalazs Gibizer proposed openstack/nova master: Run negative server moving tests with nested RPs  https://review.openstack.org/60412515:20
zzzeekjaypipes-ooo: we certainly arent changing this setting by default15:20
zzzeekjaypipes-ooo: Im just trying to create my own importance by curating what option we expose :)15:21
jaypipes-ooozzzeek: :) just leave it defaulted to normal then. It's mostly micro-tuning for write-heavy environments anyway.15:21
jaypipes-ooozzzeek: which openstack's DBs definitely are *not*.15:21
zzzeekjaypipes-ooo: yes.  I just need to have an intelligent answer for why someone would want to set this15:22
zzzeekjaypipes-ooo: it's usually folks with old OSP and struggling w/ huge keystone token table15:22
jaypipes-ooozzzeek: ack. there's a solution to that, though... TRUNCATE TABLE tokens; :P15:22
zzzeekjaypipes-ooo: agree15:22
*** s10 has quit IRC15:23
jaypipes-ooozzzeek: yeah, overall I'd advise not mucking with many of the innodb config settings other than innodb_buffer_pool_size.15:23
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Add support changes-before for microversion 2.66  https://review.openstack.org/60354915:23
zzzeekjaypipes-ooo: it's an argument im slwoly losing due to the occasional angry customer15:24
zzzeekwith a mysql DBA15:24
zzzeekjaypipes-ooo: which of course only matters to me if I have to be on the phone w/ them on friday night b.c. they lost their DB15:24
jaypipes-ooozzzeek: really no need considering nova, ironic, etc's database schemas are so poor anyway (lots of "blobject" storage and bloated not-really-relational-relations schema that those settings won't IMHO make much of a diff.15:24
zzzeekjaypipes-ooo: agree15:24
*** dave-mccowan has quit IRC15:25
*** dave-mccowan has joined #openstack-nova15:31
openstackgerritMerged openstack/nova master: libvirt: Use 'virt' as the default machine type for ARMv7  https://review.openstack.org/60259215:39
openstackgerritMerged openstack/nova master: Fix evacuate logging  https://review.openstack.org/59305515:40
openstackgerritMerged openstack/nova stable/queens: Fix soft deleting vm fails after "nova resize" vm  https://review.openstack.org/60334015:40
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Add tempest-slow job to run the tempest slow tests  https://review.openstack.org/60413415:50
openstackgerritSurya Seetharaman proposed openstack/nova master: Return a minimal construct for nova show when a cell is down  https://review.openstack.org/59165815:51
openstackgerritSurya Seetharaman proposed openstack/nova master: Return a minimal construct for nova service-list when a cell is down  https://review.openstack.org/58482915:51
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Add tempest-slow job to run the tempest slow tests  https://review.openstack.org/60413815:56
mnaserwoo15:58
mnaseri got a script going and it helped figure out the issue too15:58
*** gyee has joined #openstack-nova15:58
mnaserit's really not cleaned up but does the job, here's a placement 'audit' script: http://paste.openstack.org/show/730450/15:59
mriedemcool, throw that into "nova-manage placement audit" or something16:01
mriedemshould be able to use nova.scheduler.client.report.SchedulerReportClient for the HTTP calls16:02
mnaseryeah, and probably can use nova objects to avoid http calls?16:02
mriedemyeah maybe16:02
mnaseroh boi16:03
mnaseri think i'd say its a bug if a field is missing in nova api if it's empty/blank?16:03
mriedemdepends16:04
mriedemwhich field16:04
mnaserwith_servers=True16:04
mnaserthe servers: [] field is omitted if no servers are there16:04
mnaserso rather than servers: []. its just not there16:04
mriedemwelcome to the compute api16:04
mnaseri.e.: {u'status': u'disabled', u'state': u'down', u'id': u'13b1a4b6-d242-44c5-828e-e6f0a94284da', u'hypervisor_hostname': u'foobar'}16:04
mriedemi believe that's how https://developer.openstack.org/api-ref/compute/#list-hypervisor-servers worked16:05
mnaserhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/hypervisors.py#L90-L9216:05
mnaserif servers with servers = [] evaluates to false?16:06
mriedemyes16:06
mnaseri mean that could have been omitted but i dunno if thats an api bug or something we're expecting16:06
mriedemthat's just how that's always worked,16:07
mriedemand this is probably not the only instance of it16:07
mriedemwhere a field is omitted in the response if it doesn't have any value16:07
* mnaser adds .get('servers', []) and move son16:07
mriedemin this case it was just an oversight when i rewrote os-hypervisors in 2.5316:07
mriedemb/c it's using the same view builder code16:07
mnaserits nice that it gave compute node uuids16:08
mnaserit made this a lot easier16:08
mriedemyup, that's part of why we had to do 2.5316:08
mriedemhttps://docs.openstack.org/nova/latest/reference/api-microversion-history.html#maximum-in-pike16:08
mriedemit wasn't a fun microversion to write let me tell you16:08
mriedemgmann does have a spec started for fixing random warts like this https://review.openstack.org/#/c/603969/16:09
mriedemi'll throw this into the etherpad16:10
openstackgerritcaoyuan proposed openstack/nova master: Option "scheduler_default_filters" is deprecated.  https://review.openstack.org/60414816:11
mnaserholy crap16:12
mnaseri just ran this on a much bigger deployment and its a terrifying amount of stuff that is misreported16:12
mnaserdeleted vms, rps missing, and incorrect assignments16:13
*** liuyulong has quit IRC16:13
mriedemso you have orphaned allocations and rps for deleted things in nova yes?16:13
mriedemlikely because of that fix referenced earlier16:14
mriedemincorrect assignments is more troubling16:14
tobias-urdini've had the same after bombing clouds with testing16:14
mnasermriedem: im assuming its live migrations not cleaning up16:14
mriedemfailed live migrations?16:15
mnaseri dont really know, this cloud is been around for a while so i wouldnt know16:15
mnaserpike though16:15
mnasererr no16:15
mnaserqueens16:15
mriedemwe definitely have functional tests for successful and failed live migrations where we assert the allocations are in the right place once we're done16:15
mnaser108 deleted vms that are in placement16:16
mriedemat pike GA i think there were quite a few holes like that though for move operations16:16
mnaser8 missing RPs (but that is probably related to the bug we just spoke about and doesnt hurt that much)16:16
mnaser6 'incorrect' assignments16:16
mriedemof those 108 deleted vms still in placement,16:16
mriedemi'd be willing to bet a lot of those were local deletes in the API?16:17
mriedemwhich was also fixed later16:17
* mriedem gets the fix16:17
*** sahid has quit IRC16:17
mnaseryeah, i mean i can do some checking if you want me to do that before deeleting16:17
*** ratailor has quit IRC16:17
mriedemhttps://review.openstack.org/#/q/If507e23f0b7e5fa417041c3870d77786498f741d16:18
mriedemhttps://review.openstack.org/#/c/580498/ isn't even released yet on pike16:18
dansmithsheesh16:18
*** derekh has quit IRC16:18
mriedemmerged july 9...16:19
mriedemmnaser: so that 108 and 8 orphaned things are pretty safe to cleanup i think16:19
mriedemthe 6 incorrect will likely require a bit of investigation, but could just see where is the instance now and compare to what it's allocations are16:20
jrolljaypipes-ooo: way late, but I just found out we also have a john snow in our org (cc stephenfin)16:24
*** holser_ has quit IRC16:33
*** Swami has quit IRC16:36
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Fix upper-constraints link in tox file  https://review.openstack.org/60415816:37
* mnaser looks at larsks 16:38
* mnaser looks at https://github.com/larsks/os-placement-tools16:38
larsksmnaser: that has been useful twice so far :)16:39
mnaserlarsks: meanwhile i just spent most of the past few hours doing the same thing16:39
mnaserbut in a different approach that does list all servers + all tenants because that would burn down some oof our deployments16:39
*** Bhujay has joined #openstack-nova16:40
*** Bhujay has quit IRC16:41
*** Bhujay has joined #openstack-nova16:42
*** mdbooth has quit IRC16:43
mriedemdansmith: you know how we added a microversion to make live migration an async rpc cast from api to conductor?16:47
mriedemi'm kind of wondering if we should do something similar for resize16:48
mnasermriedem: hacked some more, http://paste.openstack.org/show/730450/ generates http://paste.openstack.org/show/730460/16:48
mnaserill test it out a bit more and try to see if i can add it to nova-manage16:48
mriedemwith resize we only finally return the api response once conductor casts to prep_resize on compute16:48
dansmithmriedem: is resize not async already?16:48
mriedemnope16:48
openstackgerritMerged openstack/nova master: Merge extended_volumes extension response into server view builder  https://review.openstack.org/59628516:48
dansmithbecause it could take a long ass time16:48
mriedemwell,16:48
openstackgerritMerged openstack/nova stable/rocky: Update RequestSpec.flavor on resize_revert  https://review.openstack.org/60240316:48
mriedemit's async once we pick a compute and cast to it16:48
dansmithah, okay16:48
mriedemthe live migration task before that async microversion would do the reschedules and such within conductor16:49
mriedemwhich could timeout the api response16:49
mriedemfor cross-cell resize, i'm considering doing similar to the pre-migration checks *from* conductor and going back to the scheduler well for more hosts if the one selected doesn't pass the pre-check16:49
mriedem*pre-live migration checks16:50
mriedemlikely a todo to throw on the pile for my patch at this point16:50
dansmithack16:50
mriedemi have officially started losing sleep over this16:50
mriedemneed to contract out some hot alaski action16:51
*** udesale has quit IRC16:52
dansmithheh16:54
mnaseri dont have time right now to get this audit code into nova-manage so i'll leave it for anyone to hack on later (till iget the time)16:56
mriedemmnaser: can you report a bug and throw it in there so we don't lose track of it?16:57
mnasermriedem: fair enough16:57
mnaserhttps://bugs.launchpad.net/nova/+bug/179356916:59
openstackLaunchpad bug 1793569 in OpenStack Compute (nova) "Add placement audit commands" [Undecided,New]16:59
*** Swami has joined #openstack-nova17:05
mriedemthanks17:05
*** jpena is now known as jpena|off17:09
openstackgerritSurya Seetharaman proposed openstack/nova master: API microversion bump for handling-down-cell  https://review.openstack.org/59165717:13
*** gouthamr has left #openstack-nova17:17
*** ralonsoh has quit IRC17:19
lucidguyif I curl the placment API for an allocation (instance) its17:19
lucidguy                  responding it exists on the wrong hypervisor ID.  Openstack17:19
lucidguy                  calls show it in the right place.  How can I edit this, can't17:19
lucidguy                  figure out the PUT equivalent syntax.  Tempted to delete but17:19
lucidguy                  that sounds very wrong17:19
lucidguyOuch, sorry about that17:19
*** tssurya has quit IRC17:20
lucidguyif I curl the placment API for an allocation (instance) its responding it exists on the wrong hypervisor ID.  Openstack calls show it in the right place.  How can I edit this, can't figure out the PUT equivalent syntax.  Tempted to delete but that sounds very wrong.17:20
lucidguyThat's better17:21
dansmithlucidguy: you should use osc-placement to fix it17:25
lucidguyosc-placement.. hmm, never heard of it.17:25
lucidguyHow does it work.17:27
dansmithhttps://docs.openstack.org/osc-placement/latest/index.html17:27
dansmithlucidguy: also check out https://github.com/larsks/os-placement-tools17:27
larsksdansmith: hah, I just pasted that to him in #openstack :)17:28
lucidguySounds like something new and time consuming to learn.17:28
lucidguyI would pay for a quick solution.. :)17:29
larskslucidguy: I haven't been following the conversation, but that script on github may be a quick solution.17:30
dansmithlarsks: good, because that's the right place to discuss :)17:30
larsksYeah17:30
lucidguyI don't think the orginization would like a random script hitting the production enviroment.17:32
lucidguyI'm sure it's fine, but if things were to go wrong, I would be screwed17:32
dansmithso wat17:32
dansmith*wait17:32
dansmithyou wanted a quick solution instead of learning a tool,17:33
dansmithand were just going to curl delete an instance's resource allocation,17:33
dansmithbut a "random script" that was written by people that know openstack and have tested it in production is not okay?17:33
*** Bhujay has quit IRC17:34
*** eandersson has quit IRC17:34
lucidguyAgain, I'm sure it's safe.  But my knowledge of the placment service is little to none.  Ideally there was a tool provided that can assist me.17:35
cdentlucidguy: what release are you running?17:35
lucidguyQueens17:36
cdentlucidguy: yeah, in that case osc-placement _is_ the tool provided to assist you17:36
*** jiteka has joined #openstack-nova17:37
dansmithand check_placement is the automated use of that tool to fix your exact problem without you having to learn everything about the tool17:37
cdentlucidguy: also see https://bugs.launchpad.net/nova/+bug/179356917:38
openstackLaunchpad bug 1793569 in OpenStack Compute (nova) "Add placement audit commands" [Wishlist,Confirmed]17:38
lucidguyI can see https://paste.ubuntu.com/p/8F3JwHqSjz/ with the appropriate curl GET command, is it as simple as performing a PUT to change that hypervisor ID?17:39
bauzasdansmith: mriedem: others: gentle notice that I'll be on PTO tomorrow17:39
bauzasI'm actively working on libvirt reshape, still work to do on inventories17:39
*** eandersson has joined #openstack-nova17:39
bauzasthen I'll push a WIP for review17:40
dansmithbauzas: ack17:40
cdentlucidguy: which curl GET produced that?17:40
dansmithFWIW, I'm out next week from tuesday->friday17:40
bauzasok17:40
dansmithbauzas: so just have it all ready on monday, k? :)17:40
cdentme M->W17:40
cdentgoing to dan's house17:40
*** dtantsur is now known as dtantsur|afk17:40
bauzasdansmith: I'm really rushing to provide it ASAP :)17:40
bauzasbut there are a couple of things I need to consider17:41
jitekamriedem: thanks for the answer for my question from yesterday about cold-migration support in Mitaka17:41
mriedemjiteka: yw17:41
bauzassince I was a bit off when implementing reshape, I just wonder if the only trigger for reshape is the ReshapeNeeded exception that then sends allocations ?17:41
bauzasdansmith: ^17:41
jitekamriedem: Today I did some testing and face the same exception that was I was getting from live-migration17:41
lucidguycdent: https://paste.ubuntu.com/p/n3GCFR8MSt/17:41
bauzasdansmith: IIUC, the update_provider_tree() method is just running periodically, but we only pass allocations as a non-null param when we trigger a reshape, right?17:42
* bauzas thinking of the fact that I'm writing the first bits of multiple vgpu types support17:42
jitekamriedem: http://paste.openstack.org/show/730464/17:42
dansmithbauzas: I haven't followed the whole thing, but IIRC you only get to raise that on the first call of update so that it's done before compute starts up17:42
bauzasdansmith: yup, that I understood17:43
cdentlucidguy: so the is issue is that you've got the allocations showing up on two different resource providers and it should just be one. If that's the case, edit the json to remove the block identified by the wrong one, and PUT it back to the same URL17:43
bauzasdansmith: and then we call again this method by passing an allocations param17:43
bauzasso we only reshape when allocations is non-None17:43
bauzasthe other cases are then periodic17:43
dansmithbauzas: not sure the details17:43
lucidguycdent:  Sadly I don't know how to do that.17:43
dansmithlucidguy: luckily there is a script that fixes this for you so you don't haveto17:44
*** dave-mccowan has quit IRC17:44
cdentyeah, lucidguy, if you're not comfortable running curl, use the scripts17:44
bauzasdansmith: no worries, I'll test it on my devbox then17:44
bauzasI should dump the DB to fake a reshape then17:45
*** gouthamr has joined #openstack-nova17:46
*** dave-mccowan has joined #openstack-nova17:46
*** jungleboyj has joined #openstack-nova17:47
*** lucidguy has quit IRC17:50
*** slaweq has quit IRC18:03
*** alaski has joined #openstack-nova18:09
*** munimeha1 has joined #openstack-nova18:16
*** tbachman has quit IRC18:20
openstackgerritEric Fried proposed openstack/nova master: Nix update_instance_allocation, _allocate_for_instance  https://review.openstack.org/60418618:29
*** tbachman has joined #openstack-nova18:40
*** cdent has quit IRC18:44
*** tbachman has quit IRC18:45
efriedjaypipes-ooo, gibi, mriedem: --^18:45
*** tbachman has joined #openstack-nova18:46
mriedemfake news18:46
mriedemlemme -1 quick18:49
mriedemjust need to update some docstrings18:50
mriedemotherwise i'm in love with your patch18:50
efriedmm, good eye18:51
mriedemi only have one18:51
efriedI used ^g, not grep18:51
openstackgerritEric Fried proposed openstack/nova master: Nix update_instance_allocation, _allocate_for_instance  https://review.openstack.org/60418618:53
efriedmriedem: Not sure if I did that right18:53
efriedI didn't go and look at the resource tracker18:53
mriedemi did, with jay's change underneath it's good18:54
efriedcoo18:54
openstackgerritElancheran S proposed openstack/nova master: Add exact match aggregate image properties matcher/filter  https://review.openstack.org/59316718:54
mriedembaby talk will get you everywhere18:56
*** afazekas has joined #openstack-nova18:59
*** dtantsur|afk has quit IRC19:01
*** dtantsur has joined #openstack-nova19:01
openstackgerritMerged openstack/nova master: doc trivial: additional info to admin-password-injection  https://review.openstack.org/60341419:01
*** med_ has quit IRC19:02
*** dpawlik has joined #openstack-nova19:12
*** dtantsur has quit IRC19:13
openstackgerritMerged openstack/nova stable/pike: Fix DB archiver AttributeError due to wrong table name attribute used  https://review.openstack.org/59988319:14
*** dpawlik has quit IRC19:16
*** tbachman has quit IRC19:16
*** dtantsur has joined #openstack-nova19:17
*** tbachman has joined #openstack-nova19:18
openstackgerritJim Rollenhagen proposed openstack/nova master: ironic: stop hammering ironic API in power sync loop  https://review.openstack.org/60212719:23
jrollmriedem: that has a bug report and such now per your request, should also be passing tests now ^19:23
mriedemok19:24
openstackgerritMerged openstack/nova master: XenAPI/Stops the migration of volume backed VHDS  https://review.openstack.org/53316819:25
*** med_ has joined #openstack-nova19:33
*** panda is now known as panda|dinner19:34
*** belmoreira has quit IRC19:35
*** tssurya has joined #openstack-nova19:35
openstackgerritMerged openstack/nova master: Refactor NeutronFixture  https://review.openstack.org/58833819:41
*** awaugama has quit IRC19:41
*** slaweq has joined #openstack-nova19:53
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: XenAPI/Stops the migration of volume backed VHDS  https://review.openstack.org/60420319:57
openstackgerritSurya Seetharaman proposed openstack/nova master: Making instance/migration listing skipping down cells configurable  https://review.openstack.org/59242820:05
openstackgerritSurya Seetharaman proposed openstack/nova master: Add get_by_cell_and_project() method to InstanceMappingList  https://review.openstack.org/59165620:05
openstackgerritSurya Seetharaman proposed openstack/nova master: Return a minimal construct for nova list when a cell is down  https://review.openstack.org/56778520:05
openstackgerritSurya Seetharaman proposed openstack/nova master: Add scatter-gather-single-cell utility  https://review.openstack.org/59494720:05
openstackgerritSurya Seetharaman proposed openstack/nova master: Return a minimal construct for nova show when a cell is down  https://review.openstack.org/59165820:05
openstackgerritSurya Seetharaman proposed openstack/nova master: Return a minimal construct for nova service-list when a cell is down  https://review.openstack.org/58482920:05
openstackgerritSurya Seetharaman proposed openstack/nova master: API microversion bump for handling-down-cell  https://review.openstack.org/59165720:05
openstackgerritMatthew Edmonds proposed openstack/nova master: [WIP] PowerVM: implement instance_on_disk  https://review.openstack.org/60420420:06
*** erlon has quit IRC20:07
*** slaweq has quit IRC20:08
*** priteau has quit IRC20:13
*** panda|dinner is now known as panda20:24
*** owalsh has joined #openstack-nova20:27
mriedemjroll: i'll wait until the ironic ci vote shows up, probably in a couple of days20:28
mriedemi've got a change that's been in the gate for over 20 hours20:29
*** tssurya has quit IRC20:35
*** holser_ has joined #openstack-nova20:49
mriedemdansmith: so random question, if i want to poll an instance for it's vm_state to change, i'm guessing Instance.get_by_uuid() is going to be faster since i can control the joins i don't care about in the db, rather than just calling instance.refresh()20:59
mriedemnvm, just talking out loud20:59
dansmithmriedem: yeah I guess probably21:04
mriedemi already know a faster thing21:05
mriedemmuwahahaha21:05
*** mrjk has quit IRC21:05
*** mrjk has joined #openstack-nova21:06
openstackgerritElancheran S proposed openstack/nova stable/pike: Add exact match aggregate image properties matcher/filter  https://review.openstack.org/59987021:10
*** claudiub has quit IRC21:15
openstackgerritMerged openstack/nova stable/queens: Fix the request context in ServiceFixture  https://review.openstack.org/59976221:27
*** munimeha1 has quit IRC21:29
openstackgerritMerged openstack/nova stable/queens: Add functional test for affinity with multiple cells  https://review.openstack.org/59976521:33
openstackgerritMerged openstack/nova stable/queens: Make scheduler.utils.setup_instance_group query all cells  https://review.openstack.org/59976621:33
*** tetsuro has quit IRC21:35
*** tetsuro has joined #openstack-nova21:37
*** takashin has joined #openstack-nova21:50
openstackgerritMerged openstack/nova master: Add contributor guide for upgrade status checks  https://review.openstack.org/59690221:51
openstackgerritMerged openstack/nova master: libvirt: mdevs returning parent and vendor PCI info  https://review.openstack.org/56230421:58
*** holser_ has quit IRC22:00
*** DinaBelova has quit IRC22:04
*** DinaBelova has joined #openstack-nova22:06
*** burt has quit IRC22:07
mriedemdansmith: do instances get saved as we pass them over rpc? kind of confusing how the instance.az updates in conductor are getting persisted in a few cases b/c we're not calling instance.save() right after we update the az22:12
mriedeme.g. https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L81522:13
dansmithmriedem: the act of sending an instance over rpc does not save it, no22:13
dansmithis that what you're asking?22:13
mriedemhmm,22:13
mriedemyeah,22:13
mriedemso it must be getting passed dirty over the wire,22:13
mriedemand then saved on the compute side22:13
dansmithyep22:13
mriedemeither when we're done (vm_state update) or fail (record a fault and revert task _state)22:13
mriedemok22:14
dansmithyar22:14
*** tbachman has joined #openstack-nova22:27
mriedemwelp,22:32
mriedemi think i've got a thing here22:32
mriedemTODOs aplenty22:32
*** tbachman_ has joined #openstack-nova22:32
mriedemcan we pretend this is grizzly and i just don't need tests or to worry about rolling back and cleaning up on failure?22:32
*** tbachman has quit IRC22:33
*** tbachman_ is now known as tbachman22:33
mriedemefried: i think i might actually consider thinking about maybe using taskflow22:34
efriedmriedem: Or you could use go22:35
mriedemshould i just shell out to some go script?22:35
efriedwhat could possibly go wrong?22:35
mriedemi've never written any go22:35
efriedI started learning yesterday22:35
efried'defer' ftw22:35
mriedemfor fun?22:35
efriedahem, got "volunteered" for a side project.22:36
mriedemor for PowerK*S?22:36
mriedem*PowerK8S22:36
efriedsomething like that.22:36
mriedemhaha22:36
mriedemi'm sorry22:36
mriedemso just uh, you know, get all the powervm stuff done, some placement stuff, some cyborg stuff, etc etc22:36
mriedemkthx22:36
*** spsurya has quit IRC22:48
*** xyang has quit IRC22:48
*** david-lyle has joined #openstack-nova22:49
*** spsurya has joined #openstack-nova22:50
*** dklyle has quit IRC22:51
*** manjeets has quit IRC22:51
*** rcernin has joined #openstack-nova22:53
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Cross-cell resize  https://review.openstack.org/60393022:58
mriedemdansmith: pretty sure this is ready for production ^22:58
*** mriedem is now known as mriedem_away23:10
*** slaweq has joined #openstack-nova23:11
*** dpawlik has joined #openstack-nova23:12
*** slaweq has quit IRC23:16
*** erlon has joined #openstack-nova23:16
*** dpawlik has quit IRC23:16
*** tbachman has quit IRC23:24
*** brinzhang has joined #openstack-nova23:26
*** mlavalle has quit IRC23:32
*** andreykurilin has quit IRC23:34
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Add support changes-before for microversion 2.66  https://review.openstack.org/60354923:35
*** andreykurilin has joined #openstack-nova23:35
*** rcernin has quit IRC23:36
*** rcernin has joined #openstack-nova23:36
*** panda is now known as panda|off23:39
*** gyee has quit IRC23:41
*** Swami has quit IRC23:45
*** dpawlik has joined #openstack-nova23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!