Wednesday, 2018-09-26

*** jamesdenton has quit IRC00:36
*** takashin has joined #openstack-nova00:41
*** tetsuro has joined #openstack-nova00:47
*** macza has joined #openstack-nova00:47
*** yikun has joined #openstack-nova00:52
*** macza has quit IRC00:52
openstackgerritTao Li proposed openstack/nova master: Rollback instance vm_state to original where instance claims failed  https://review.openstack.org/59225201:04
*** wxy-xiyuan has joined #openstack-nova01:05
*** litao has joined #openstack-nova01:09
*** Kevin_Zheng has joined #openstack-nova01:13
openstackgerritTao Li proposed openstack/nova master: Don't persist retry information into database  https://review.openstack.org/60501101:14
*** mrsoul has joined #openstack-nova01:19
*** Dinesh_Bhor has joined #openstack-nova01:23
openstackgerritMerged openstack/nova stable/queens: Fix nova-status "_check_resource_providers" check  https://review.openstack.org/60010101:23
*** hshiina has joined #openstack-nova01:26
*** owalsh_ has joined #openstack-nova01:29
*** owalsh has quit IRC01:33
*** hongbin has joined #openstack-nova01:39
*** jamesdenton has joined #openstack-nova01:46
*** tbachman has quit IRC01:49
*** erlon has quit IRC02:01
*** Dinesh_Bhor has quit IRC02:02
openstackgerritBrin Zhang proposed openstack/nova master: Specifies the storage backend to boot instance  https://review.openstack.org/57936002:03
openstackgerritBrin Zhang proposed openstack/nova master: Add volume_type field to BlockDeviceMapping object  https://review.openstack.org/60468702:07
*** Dinesh_Bhor has joined #openstack-nova02:11
*** macza has joined #openstack-nova02:18
*** macza has quit IRC02:22
*** psachin has joined #openstack-nova02:39
openstackgerrittianhui proposed openstack/nova master: doc: update availability zone doc  https://review.openstack.org/60530602:42
openstackgerritBrin Zhang proposed openstack/nova master: Specifies the storage backend to boot instance  https://review.openstack.org/57936002:46
*** Bhujay has joined #openstack-nova02:49
*** imacdonn has quit IRC02:50
*** imacdonn has joined #openstack-nova02:50
*** takashin has left #openstack-nova03:02
*** Bhujay has quit IRC03:07
*** naichuans has joined #openstack-nova03:16
naichuansHi, melwitt: has stein runways in use? https://etherpad.openstack.org/p/nova-runways-stein03:17
*** cfriesen has quit IRC03:19
openstackgerritMerged openstack/nova master: Option "scheduler_default_filters" is deprecated.  https://review.openstack.org/60414803:30
openstackgerritMerged openstack/nova master: doc:update virtual gpu doc  https://review.openstack.org/60501203:30
*** dave-mccowan has quit IRC03:44
*** dave-mccowan has joined #openstack-nova03:46
*** udesale has joined #openstack-nova03:53
*** itlinux has joined #openstack-nova03:56
*** hongbin has quit IRC03:59
*** tetsuro has quit IRC04:00
*** macza has joined #openstack-nova04:09
*** pcaruana has joined #openstack-nova04:14
openstackgerritiain MacDonnell proposed openstack/nova master: nova-manage - fix online_data_migrations counts  https://review.openstack.org/60532904:33
*** pcaruana has quit IRC04:38
*** Dinesh_Bhor has quit IRC04:47
*** Dinesh_Bhor has joined #openstack-nova04:54
*** hshiina has quit IRC05:10
*** hshiina has joined #openstack-nova05:13
*** tbachman has joined #openstack-nova05:14
*** tbachman_ has joined #openstack-nova05:16
*** tbachman has quit IRC05:19
*** tbachman_ is now known as tbachman05:19
openstackgerritMerged openstack/nova master: Consumer gen support for put allocations  https://review.openstack.org/59164705:25
*** Bhujay has joined #openstack-nova05:26
*** macza_ has joined #openstack-nova05:28
*** macza has quit IRC05:32
*** Bhujay has quit IRC05:32
*** macza_ has quit IRC05:33
*** dave-mccowan has quit IRC05:39
*** pcaruana has joined #openstack-nova05:43
*** Bhujay has joined #openstack-nova05:49
*** jistr has quit IRC05:55
*** jistr has joined #openstack-nova05:56
gmannapi office hour time06:03
gmann#startmeeting nova api06:04
openstackMeeting started Wed Sep 26 06:04:33 2018 UTC and is due to finish in 60 minutes.  The chair is gmann. Information about MeetBot at http://wiki.debian.org/MeetBot.06:04
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.06:04
*** openstack changes topic to " (Meeting topic: nova api)"06:04
openstackThe meeting name has been set to 'nova_api'06:04
gmannPING List: gmann, alex_xu06:04
*** adrianc has joined #openstack-nova06:12
*** ratailor has joined #openstack-nova06:12
gmanni will be around here for some time.06:12
gmannalso updating the bug report and subteam tracking etherpad06:13
*** dpawlik has joined #openstack-nova06:23
*** cfriesen has joined #openstack-nova06:23
*** qinglin has joined #openstack-nova06:41
*** qinglin has left #openstack-nova06:42
*** skatsaounis has joined #openstack-nova06:42
openstackgerritSam Morrison proposed openstack/python-novaclient master: Fix user-data argument to rebuild.  https://review.openstack.org/60534106:49
gmann#endmeeting06:51
*** openstack changes topic to "RC todo: https://etherpad.openstack.org/p/nova-rocky-release-candidate-todo -- This channel is for Nova development. For support of Nova deployments, please use #openstack."06:51
openstackMeeting ended Wed Sep 26 06:51:50 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)06:51
openstackMinutes:        http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-09-26-06.04.html06:51
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-09-26-06.04.txt06:51
openstackLog:            http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-09-26-06.04.log.html06:51
*** ralonsoh has joined #openstack-nova07:02
*** rcernin has quit IRC07:02
*** alexchadin has joined #openstack-nova07:03
*** tetsuro has joined #openstack-nova07:06
*** cfriesen has quit IRC07:13
*** Dinesh_Bhor has quit IRC07:15
*** psachin has quit IRC07:21
*** helenafm has joined #openstack-nova07:25
openstackgerritNaichuan Sun proposed openstack/nova master: os-xenapi(n-rp): add traits for vgpu n-rp  https://review.openstack.org/60426907:25
*** alexchadin has quit IRC07:25
*** psachin has joined #openstack-nova07:27
openstackgerritPrzemyslaw Lal proposed openstack/os-vif master: add nested DPDK VIF classes for kuryr-kubernetes  https://review.openstack.org/60499207:32
gibimdbooth: takashi already commented on your missing local delete notification bug that the solution is in the gate queue https://review.openstack.org/#/c/410297/07:35
openstackgerritZhenyu Zheng proposed openstack/nova-specs master: Detach and attach boot volumes - Stein  https://review.openstack.org/60062807:42
gibimdbooth: so you will need a rebase https://review.openstack.org/#/c/604859 on top of https://review.openstack.org/#/c/41029707:42
*** pvc has joined #openstack-nova07:42
*** alexchadin has joined #openstack-nova07:51
*** jpena|off is now known as jpena07:51
*** rcernin has joined #openstack-nova07:56
*** alexchadin has quit IRC07:57
*** Dinesh_Bhor has joined #openstack-nova07:58
*** alexchadin has joined #openstack-nova07:59
bauzasgood morning nova08:02
*** moshele has joined #openstack-nova08:12
openstackgerritsean mooney proposed openstack/nova master: Add Result wrapper class to nova common  https://review.openstack.org/60525108:15
*** jistr has quit IRC08:30
*** jistr has joined #openstack-nova08:31
*** adrianc has quit IRC08:33
*** adrianc has joined #openstack-nova08:33
*** derekh has joined #openstack-nova08:33
*** derekh has quit IRC08:33
*** derekh has joined #openstack-nova08:34
naichuansGood morning, bauzas: have a question to consult, has stein runways in use? https://etherpad.openstack.org/p/nova-runways-stein08:39
openstackgerritMatthew Booth proposed openstack/nova master: Add volume-backed evacuate test  https://review.openstack.org/60439708:42
*** owalsh_ is now known as owalsh08:45
*** tssurya has joined #openstack-nova08:54
openstackgerritBalazs Gibizer proposed openstack/nova master: consumer gen: more tests for delete allocation cases  https://review.openstack.org/59181109:01
*** Dinesh_Bhor has quit IRC09:03
*** alexchadin has quit IRC09:06
*** tetsuro has quit IRC09:07
*** moshele has quit IRC09:10
*** dtantsur|afk is now known as dtantsur09:10
*** rcernin has quit IRC09:16
bauzasnaichuans: it has, yes09:16
naichuansbauzas: thanks09:17
*** alexchadin has joined #openstack-nova09:20
*** k_mouza has joined #openstack-nova09:23
*** alexchadin has quit IRC09:25
k_mouzahello all! I'm working on a server with a couple of NVMe drives in it and I want to configure nova to create the instances' ephemeral disks on the NVMes. Is there a way I can set that? Thanks!09:26
*** Dinesh_Bhor has joined #openstack-nova09:28
lyarwoodk_mouza: there's an NVMe cinder volume driver iirc09:28
*** a-pugachev has joined #openstack-nova09:30
a-pugachevnova09:30
kashyapjohnthetubaguy: Heya, when you get a moment, the Oracle Linux and SLES folks confirmed: https://review.openstack.org/#/c/605060/09:31
lyarwoodk_mouza: https://www.openstack.org/assets/presentation-media/nvmeof-tsg.pptx09:31
*** adrianc has quit IRC09:33
*** priteau has joined #openstack-nova09:41
*** alexchadin has joined #openstack-nova09:42
k_mouzathanks lyarwood! That's nvme-over-fabrics though. I'd want to locally use the NVMEs on the host when an instance is spawned up on that host. Any option for this? I found the "instances_path" option in nova.conf where I can add one mount point (haven't tested this yet), but is there a way to add more than one?09:43
*** gameon has quit IRC09:46
*** adrianc has joined #openstack-nova09:47
lyarwoodk_mouza: aside from using the LVM imagebackend (image_type=lvm in nova.conf) no, there's no direct option.09:53
tobias-urdinquick question if somebody feels they have some input, we've been talking for a long time about the images_type cinder backend driver that is not yet written, if one were to prepare for this one would it make sense to place images_type backend instances on the same ceph pool as cinder so that there would be no need to data migration and one could only use the "manage" feature in cinder to impo09:54
tobias-urdinrt that data as a volume?09:54
tobias-urdinthere is a lot of stuff in between there though, having the data left but removing the instance for example09:54
lyarwoodtobias-urdin: as a migration path between the two?10:00
tobias-urdinyeah10:01
lyarwoodtobias-urdin: I'm not sure it would tbh, you would need cinder to know about the volumes in the original images pool, their metadata etc10:01
lyarwoodtobias-urdin: I guess we could get that from nova but it's kinda awkward10:01
tobias-urdiniirc cinder can import a ceph rbd volume i would just need to boot the instance from that, is what i was thinking atleast10:02
*** ttsiouts has joined #openstack-nova10:02
tobias-urdinbut i'm unsure how i would get nova to detach (read: remove instance) without deleting that rbd volume10:02
lyarwoodtobias-urdin: yeah, you can boot from a volume that imports the original image10:02
lyarwoodtobias-urdin: there's a boot root disk spec up for review at the moment that would help there10:02
lyarwoodtobias-urdin: snapshot the instance into an image, detach the root disk, create a volume from the snapshot image, attach it as the new root disk.10:03
lyarwoodtobias-urdin: that's without images_type=cinder btw10:03
tobias-urdinyeah, so if i place images_type=rbd instances on the same pool as cinder creates it's volumes i would (hopefully) be able to snapshot like that and spawn a new instance from that10:04
tobias-urdinand dont have to migrate a whole ceph pool10:04
*** ralonsoh has quit IRC10:04
tobias-urdinthat is, when images_type=cinder is available so I somehow could move over images_type=rbd instances10:05
tobias-urdinuntil then I'll simply hide the option to not spawn from a volume in horizon and instruct API users to spawn from volume-backed but I will assume there will be some stuff spawned with images_type=rbd10:05
tobias-urdinlyarwood: which is what I wanted to plan for, having images_type=cinder would have been awesome right about now :D10:06
*** Dinesh_Bhor has quit IRC10:10
lyarwoodtobias-urdin: going to summit? https://www.openstack.org/summit/berlin-2018/vote-for-speakers#/22786 we should add that to the list10:11
*** ralonsoh has joined #openstack-nova10:11
*** rmulugu__ has joined #openstack-nova10:13
tobias-urdinlyarwood: unfortunately not, i'm pushing for backing to go to next summit and ptg, but right now no :(10:14
tobias-urdinour use case(s) is pretty much bfv only10:15
k_mouzathanks for the help lyarwood!10:15
tobias-urdinsecond that, thanks lyarwood! :)10:16
lyarwoodnp10:16
*** Dinesh_Bhor has joined #openstack-nova10:16
*** Dinesh_Bhor has quit IRC10:18
*** rmulugu__ has quit IRC10:21
*** rmulugu has joined #openstack-nova10:21
*** rmulugu has quit IRC10:21
*** rmulugu has joined #openstack-nova10:24
*** ttsiouts has quit IRC10:24
*** ttsiouts has joined #openstack-nova10:25
*** ttsiouts has quit IRC10:29
*** ttsiouts has joined #openstack-nova10:30
*** Luzi has joined #openstack-nova10:42
*** alexchadin has quit IRC10:49
mdboothefried: Are you involved at all with https://bugs.launchpad.net/nova/+bug/1763181 btw? (test_parallel_evacuate_with_server_group)10:50
openstackLaunchpad bug 1763181 in OpenStack Compute (nova) "test_parallel_evacuate_with_server_group intermittently fails" [Medium,Confirmed]10:50
mdboothI only ask because you mentioned it the other day, and a patch I was looking at just hit it10:51
*** alexchadin has joined #openstack-nova10:58
*** rmulugu has quit IRC10:59
*** ttsiouts has quit IRC11:02
*** alexchadin has quit IRC11:03
*** erlon has joined #openstack-nova11:07
openstackgerritRadoslav Gerganov proposed openstack/nova master: VMware: Live migration of instances  https://review.openstack.org/27011611:08
*** k_mouza has quit IRC11:10
openstackgerritRadoslav Gerganov proposed openstack/nova master: VMware: Live migration of instances  https://review.openstack.org/27011611:11
*** udesale has quit IRC11:12
openstackgerritKashyap Chamarthy proposed openstack/nova master: Pick next minimum libvirt / QEMU versions for "T" release  https://review.openstack.org/60506011:12
*** psachin has quit IRC11:13
*** pcaruana has quit IRC11:15
*** jaypipes has joined #openstack-nova11:17
*** k_mouza has joined #openstack-nova11:18
*** jpena is now known as jpena|lunch11:21
*** psachin has joined #openstack-nova11:27
pooja-jadhavhi team, I am facing issue for AMQP driver issue, can anyone help me to sort it out11:30
*** k_mouza has quit IRC11:32
*** pvc has quit IRC11:32
*** pooja-jadhav is now known as pooja_jadhav11:33
*** oanson has quit IRC11:35
*** k_mouza has joined #openstack-nova11:40
*** brinzhang has joined #openstack-nova11:42
*** ttsiouts has joined #openstack-nova11:49
*** alexchadin has joined #openstack-nova11:57
*** dpawlik has quit IRC11:58
*** alexchadin has quit IRC12:17
*** dtantsur is now known as dtantsur|brb12:18
*** ratailor has quit IRC12:20
*** panda|off is now known as panda12:21
*** tbachman has quit IRC12:22
mdboothEurgh12:22
* mdbooth curses python yet again for the python3 debacle12:23
* mdbooth can't use contextlib.nullcontext(), because it's py3 only12:23
*** alexchadin has joined #openstack-nova12:25
sean-k-mooneymdbooth: is there a six compatiblity shim you can use?12:27
mdboothsean-k-mooney: Looked, didn't see one12:27
*** jpena|lunch is now known as jpena12:28
*** hshiina has quit IRC12:29
*** udesale has joined #openstack-nova12:30
openstackgerritBalazs Gibizer proposed openstack/nova master: consumer gen: more tests for delete allocation cases  https://review.openstack.org/59181112:31
openstackgerritBalazs Gibizer proposed openstack/nova master: consumer gen: support claim_resources  https://review.openstack.org/58366712:31
sean-k-mooneymdbooth: well looking at the pull request that intoduced it its a its a trival thing to implement yourself https://github.com/python/cpython/pull/4464/files#diff-edbcdd20abc32f8b018deb2353ae925aR47412:32
mdboothsean-k-mooney: Right. It's just messy.12:33
sean-k-mooneymdbooth: infact it look like itss python2 compatiable so just copy past it somewhere under a utils moduel or in common and a test for the python versions and eiterh user our veriosn or the upstream12:34
mdboothThe only reason I even went looking for one is because it's such an obvious thing to want which is likely duplicated all over the place.12:34
mdboothIf you don't need everything, presumably you don't need more than:12:34
mdbooth@contextlib.contextmanager:12:34
mdboothdef null()12:34
mdbooth  yield12:34
mdboothBut still... python3--12:35
mdboothFor pointlessly dividing effort12:35
sean-k-mooneymdbooth: ya we already have this https://github.com/openstack/nova/blob/957f4818b0d89cd71552effb8b5a5b231a68de7b/nova/test.py#L79-L85 so i think its fine to add the same for null12:35
jrollyou could also blame it on py2 not being dead yet :P12:35
mdboothjroll: py2 was a vibrant language with bazillions of lines written. Why kill it and create a new language at all?12:36
* mdbooth imagines somebody trying to deprecate C because C++ was invented.12:36
mdboothFortunately that community has more sense12:37
mdboothArgh, contextlib.nested() went away in py312:40
mdboothAnd the new with syntax doesn't support composition12:40
*** psachin has quit IRC12:41
sean-k-mooneymdbooth: i mean if i had the choice then i would depercate C in favor of c++ but that ship has sailed12:41
* mdbooth considers writing if PY2: else:12:41
*** ralonsoh has quit IRC12:41
mdboothsean-k-mooney: Indeed. The python answer to that was to fire a missile at the departed ship over the horizon anyway.12:41
*** ralonsoh has joined #openstack-nova12:42
*** Tomatosoup- has quit IRC12:42
openstackgerritBalazs Gibizer proposed openstack/nova master: Enable nested allocation candidates in scheduler  https://review.openstack.org/58567212:45
openstackgerritChen proposed openstack/nova master: doc: update availability zone doc  https://review.openstack.org/60530612:46
mdboothOh, ffs. contextlib.ExitStack looks like what I want, but it's py3 only12:48
*** liuyulong has joined #openstack-nova12:50
openstackgerritBalazs Gibizer proposed openstack/nova master: Use provider tree in virt FakeDriver  https://review.openstack.org/60408312:54
*** janki has joined #openstack-nova12:55
*** ttsiouts has quit IRC12:55
efriedmdbooth: No. I've just hit it a bazillion times.12:58
mdboothefried: I can see a relatively simple solution, but I'm currently trying to formulate a syntax which would work in both py2 and py312:59
mdboothefried: Not related to the other thing I'm working on, btw13:00
mdboothAmusingly, the bug is called out explicitly in a comment to the other caller of _validate_instance_group_policy:13:00
efriedmdbooth: what are you trying to do?13:01
mdbooth                # NOTE(russellb) It's important that this validation be done13:01
mdbooth                # *after* the resource tracker instance claim, as that is where13:01
mdbooth                # the host is set on the instance.13:01
mdboothefried: Have an optional context manager13:01
efriedoptional based on what?13:01
mdboothWhether or not a lock is required13:01
efriedcan't you have the context manager itself contain the condition?13:02
*** alexchadin has quit IRC13:02
efried@contextmanager13:02
efrieddef cm(...):13:02
efried   if lock_required:13:02
efried      do things13:02
efried   yield13:02
efried   if lock_required:13:02
efried      do things13:02
efried?13:02
mdboothThen I'd have to refactor that whole method to be a context manager13:03
*** ttsiouts has joined #openstack-nova13:03
efriedor the callers?13:03
efriedif lock_required:13:03
efried    with cm:13:03
efried        do things13:03
efriedelse:13:03
efried    do things13:03
efried?13:03
*** mriedem has joined #openstack-nova13:03
mdboothefried: Anyway, there are a bunch of obvious ways to do this. It's frustrating that they're all ugly though as they're deprecated/removed in py2 and not available in py3, or available only in py213:04
mdboothpy3 even13:04
efriedokay13:05
efriedI'm sure I'll understand better when I see it13:05
mdboothSome language/library designers failed to consider their users13:05
openstackgerritSurya Seetharaman proposed openstack/nova master: Block automatic transport_url update for cell0  https://review.openstack.org/60541413:05
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Skip more rebuild tests for cells v1 job  https://review.openstack.org/60541613:08
openstackgerritSurya Seetharaman proposed openstack/nova master: Block automatic transport_url update for cell0  https://review.openstack.org/60541413:08
edleafemdbooth: more likely is that someone proposed the ExitStack addition after py2 was put into maintenance mode. The mistake was OpenStack starting with py2 just because some vendors didn't distribute py3 yet13:08
sean-k-mooneymdbooth: well to be fair they have said they will continue to support it byond 2020 if enough people have not migrated to py3 earlier this year and python3 is 10 years old in december so we have had time to stop using it13:08
mdboothedleafe: py3 wasn't a safe choice in 2010 :/13:09
edleafeSure it was13:09
sean-k-mooneymdbooth: it was not in 2010 but it was in 2014 when 3.4 shipped13:10
mdboothOk13:10
edleafeIt's just that Ubuntu didn't include it by default, and Xen required py2.413:10
mdboothedleafe: That's 2 reasons right there13:10
mdboothThere were many, many more13:10
edleafeRight, so it isn't python that's the issue; it's the vendors dragging their butts13:10
mdboothAnd libraries13:11
sean-k-mooneymdbooth: yes but at this point its well past the time that libary mantains can claim they did not have time to migrate.13:11
edleafeIt's chicken-and-egg: if big projects like OpenStack adopt py3, vendors would have motivation to update. If they stay with py2, well, why bother13:11
stephenfinsean-k-mooney: http://py3readiness.org/13:11
mdboothedleafe: It was a brand new language which had been around a little over a year whose future was not assured, not least because it marked an epoch in the language.13:12
mdboothI'd go so far as to say it would have been an insane choice in 201013:12
sean-k-mooneyalmost there what are teh last 1113:12
sean-k-mooneystephenfin: nothing too critical bar may uwsgi13:13
stephenfinsean-k-mooney: Aye, and I'd imagine that's wrong13:13
stephenfinassuming uWSGI isn't dead13:13
stephenfinhttps://uwsgi-docs.readthedocs.io/en/latest/Python.html#python-313:13
sean-k-mooneystephenfin: was just going to say i assume its outdated13:13
stephenfinYup https://github.com/unbit/uwsgi/blob/master/setup.py13:14
sean-k-mooneystephenfin: im surprised entrypoints is not updated.13:14
sean-k-mooneystephenfin: has that been pulled into setuptools13:15
stephenfinI don't know that is. We use pkg_resources (or whatever it's called) from setuptools13:15
stephenfinsean-k-mooney: Yeah, I think so. Not sure what that is, tbh13:15
*** tbachman has joined #openstack-nova13:16
stephenfinLooks like pykube also supports it so that's also wrong https://github.com/kelproject/pykube/blob/master/setup.py#L16-L1913:16
sean-k-mooneyaprarently 200 ish lines of code that has not been update in a while https://github.com/takluyver/entrypoints/blob/master/entrypoints.py#L113:16
*** alexchadin has joined #openstack-nova13:17
stephenfinWhich also supports Python 3 https://github.com/takluyver/entrypoints/blob/master/flit.ini13:18
stephenfin(they use https://github.com/takluyver/flit)13:18
*** ttsiouts has quit IRC13:19
openstackgerritBalazs Gibizer proposed openstack/nova master: Run ServerMovingTests with nested resources  https://review.openstack.org/60408413:21
*** mrsoul has quit IRC13:26
*** panda has quit IRC13:32
*** dtantsur|brb is now known as dtantsur13:33
*** _hemna has joined #openstack-nova13:35
openstackgerritBalazs Gibizer proposed openstack/nova master: Run negative server moving tests with nested RPs  https://review.openstack.org/60412513:36
openstackgerritBrin Zhang proposed openstack/nova master: Specifies the storage backend to boot instance  https://review.openstack.org/57936013:42
*** alexchadin has quit IRC13:44
*** lbragstad has quit IRC13:45
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands  https://review.openstack.org/48740513:45
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Remove IPTools deprecated implementation  https://review.openstack.org/60542213:45
*** slaweq has quit IRC13:45
openstackgerritSurya Seetharaman proposed openstack/nova master: Block automatic transport_url update for cell0  https://review.openstack.org/60541413:46
*** alexchadin has joined #openstack-nova13:46
*** brinzhang has quit IRC13:49
*** lbragstad has joined #openstack-nova13:50
*** alexchadin has quit IRC13:50
openstackgerritBalazs Gibizer proposed openstack/nova master: Add request_spec.RequestGroup versioned object  https://review.openstack.org/56884013:51
*** awaugama has joined #openstack-nova13:55
*** k_mouza has quit IRC14:01
openstackgerritBalazs Gibizer proposed openstack/nova master: Add requested_resources field to RequestSpec  https://review.openstack.org/56726714:02
*** ttsiouts has joined #openstack-nova14:03
*** k_mouza has joined #openstack-nova14:06
openstackgerritBalazs Gibizer proposed openstack/nova master: Add bandwidth related standard resource classes  https://review.openstack.org/57084714:10
*** janki has quit IRC14:12
*** ttsiouts has quit IRC14:14
*** udesale has quit IRC14:15
*** mlavalle has joined #openstack-nova14:20
*** ttsiouts has joined #openstack-nova14:21
*** panda has joined #openstack-nova14:21
openstackgerritGhanshyam Mann proposed openstack/nova master: Add hide server address tests in test_serversV21.py  https://review.openstack.org/60543514:22
openstackgerritMatthew Booth proposed openstack/nova master: Fix a race evacuating instances in an anti-affinity group  https://review.openstack.org/60543614:24
openstackgerritMerged openstack/nova master: Consumer gen: remove_provider_from_instance_allocation  https://review.openstack.org/59178414:24
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Remove IPTools deprecated implementation  https://review.openstack.org/60542214:25
mdboothefried: Lets see if ^^^ passes tests.14:25
stephenfinbauzas, mriedem, tonyb: Could one of you do me a solid and abandon these unnecessary stable requirements patches? They're around since forever https://review.openstack.org/#/c/493146/ https://review.openstack.org/#/c/490256/14:25
mdboothefried: NB: it's not central to what I'm working on, and I don't really care what colour the bike shed is. If it doesn't merge, I'll still sleep like a baby.14:25
bauzasstephenfin: sure, lemme look14:25
bauzasstephenfin: thanks for helping me to do something else but writing UTs :p14:26
stephenfinYou're...welcome? :)14:26
* bauzas curses at TDD14:26
stephenfinbauzas: Oh, and this one https://review.openstack.org/#/c/543705/14:26
bauzasstephenfin: wait14:26
bauzasstephenfin: if I'm abandoning a bot change, will the bot be able to give us another change?14:27
stephenfinbauzas: I think that bot is dead now?14:27
*** Luzi has quit IRC14:27
bauzasoh right, now that we have the minimums14:27
bauzasmriedem: this ^ ?14:28
stephenfinIf not, I'll personally go harass -infra to resolve the issue14:28
mdboothmriedem: https://review.openstack.org/#/c/604397/ \o/14:29
mdboothmriedem: I'll rebase the other patches on it14:29
* mdbooth checks the actual output14:30
efriedmdbooth: I'll add it to my watchlist, but not sure I can give it a real review.14:30
mdboothefried: Yeah, np. Just saying I'm kinda throwing it over the fence. If it inspires somebody else to write a better patch then I'm cool with that, but kinks aside I suspect it'll fix the issue at hand today.14:32
mdboothIf somebody wants a massive rewrite they're welcome to massively rewrite it :)14:32
*** artom has quit IRC14:34
openstackgerritMatthew Booth proposed openstack/nova master: Run evacuate tests with local/lvm and shared/rbd storage  https://review.openstack.org/60440014:37
efriedbauzas: please have a quick look at new comments on https://review.openstack.org/#/c/599208/ before you put up a new patch set.14:38
bauzasefried: ack, thanks for the notice, I was writing the UTs :)14:39
efriedI figgered14:39
*** Bhujay has quit IRC14:44
openstackgerritBalazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler  https://review.openstack.org/56726814:44
bauzasefried: about your two points, fair enough for the type, but maybe it's YAGNI14:46
*** helenafm has quit IRC14:47
efriedbauzas: surely doesn't do any harm14:47
openstackgerritMerged openstack/nova stable/queens: Skip ServerActionsTestJSON.test_rebuild_server for cells v1 job  https://review.openstack.org/60511514:49
mriedemstephenfin: done14:50
stephenfinmriedem: Ta14:50
*** adrianc_ has joined #openstack-nova14:50
sean-k-mooneymriedem: i tried to review https://review.openstack.org/#/c/605199/ this morning.14:53
sean-k-mooneymriedem: your logic makes sense to me but i dont know why its failing14:53
*** adrianc has quit IRC14:54
melwittnaichuans: yes, stein runways are open. feel free to add approved ready-for-review blueprints to the queue14:55
*** adrianc_ has quit IRC14:55
*** cfriesen has joined #openstack-nova14:57
*** k_mouza has quit IRC14:58
mriedemsean-k-mooney: yeah idk either, it's not very important right now, i have a workaround in nova, and it can wait for dan to come back14:59
bauzasnaichuans: keep in mind we need first to have both the consumer-gen series and the scheduler using nested allocations series to be merged before your one15:00
bauzasnaichuans: and we also need a reshaping change for the xen driver15:00
*** pcaruana has joined #openstack-nova15:01
bauzasefried: I left a reply on my change15:06
efriedack15:06
bauzasefried: tl;dr if someday nvidia wants to name a type "nvidia-mysuperawesometypeforaimlcoinminingandotherbuzzword', they just need to release a new driver version15:07
bauzasand I just don't want to have a vendors war on the placement API :)15:08
sean-k-mooneybauzas: mdev types? ya they can be anything but i think there is a lenght limit in the kernel15:09
bauzassean-k-mooney: sure, TEXT ?15:09
bauzasor whatever crazy15:09
efriedthese type strings correspond to what you need to put in the config, right?15:09
openstackgerritBalazs Gibizer proposed openstack/nova master: Send resource allocations in the port binding  https://review.openstack.org/56945915:09
bauzasefried: yup, and I hate that15:10
sean-k-mooneydansmith: looking at the kernel docs its not clare i would have to check the cheder for the mdev device15:11
sean-k-mooneydansmith: sorry that was for bauzas ^15:11
bauzasefried: but there is a big difference in having a vendor-specific information in a config file, and something set in the DB and shown on the API side :)15:11
bauzass/, and/vs.15:11
bauzasgod dammit, my fucking English15:11
sean-k-mooneybauzas: is that different then your normal english :)15:12
bauzasaber ich lerne Deutch15:12
bauzassean-k-mooney: https://www.kernel.org/doc/Documentation/vfio-mediated-device.txt15:14
sean-k-mooneybauzas: i read that it does not have the max size of a mdev type specified15:16
bauzasyeah it's a struct15:16
bauzassean-k-mooney: open bar then, right?15:16
sean-k-mooneybauzas: more or less15:17
bauzasoh and look the header15:17
bauzaswho wrote this15:17
*** janki has joined #openstack-nova15:17
bauzasnow, you'll understand15:17
bauzasit's totally free15:17
bauzasthe less I expose, the safer I am :)15:18
mnaserdid nova-scheduler go multiprocess in rocky?15:18
bauzasmulti-workers yes15:20
openstackgerritBalazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request  https://review.openstack.org/57331715:21
bauzasmnaser: https://review.openstack.org/#/c/159382/15:21
mnaserproposed in 2015, merged in 2018: nice15:22
mriedemit was abandoned for a few years15:22
bauzasmnaser: we had concerns in the past that were resolved15:22
mnaseroh yeah of course15:22
mnaserit makes sense now with placement being there15:22
mnaserrunning 3 schedulers across 3 nodes was one big game of luck too15:23
*** artom has joined #openstack-nova15:23
sean-k-mooneymnaser: when we stated clamin in placement you could jsut run multiple schuler process to scale without multiprocess support15:23
jaypipesit was only the caching scheduler that was unsafe for multi-workers.15:25
sean-k-mooneyjaypipes: post placement15:26
mriedemoh i'm not sure that's true15:26
mriedemyou could still race with filter scheduler15:26
*** ShilpaSD has joined #openstack-nova15:26
mriedemsince there was no claim in the scheduler15:26
sean-k-mooneymriedem: for numa/sriov resouces?15:27
mriedemfor anything15:27
sean-k-mooneyfor a normal vm request i did not tihnk we coudl15:27
mriedembefore pike15:27
sean-k-mooneymriedem: was pike when we started claiming cpus ram and disk in placmenent?15:27
jaypipesright. before pike.15:27
mriedemsean-k-mooney: yes15:28
sean-k-mooneymriedem: ok so ya pre pike you could race post pike bar late claimes on the compute node for pinning/sriov/hugepages no race15:28
mriedemor if you're using server groups...15:30
openstackgerritArtom Lifshitz proposed openstack/nova-specs master: Re-propose numa-aware-live-migration spec  https://review.openstack.org/59958715:31
mriedemso all of the NFV things = still race-tastic15:31
mriedemand ironically the scheduler is the one thing that NFV things hate most because they already know exactly where they want to put the goodies15:31
sean-k-mooneymriedem: thats true for multi process works and multi schduler too right they are both as rachy for nfv stuff15:32
*** dpawlik has joined #openstack-nova15:32
mriedemeven single scheduler15:32
mriedemsingle worker15:32
mriedemthis is why a late affinity check exists in the compute15:32
*** dpawlik has quit IRC15:36
*** janki has quit IRC15:36
mdboothefried: Just wondering about external, non-libvirt CI in the context of https://review.openstack.org/#/c/602174/15:39
mdboothefried: Do you have one of those? If so, do you write your own jobs 'from scratch', or would the changes to the playbooks/.zuul.yaml in there cause it to fail?15:40
efriedmdbooth: We have an external, non-libvirt CI, yes. It runs tempest stuffs. I'm not an expert on it.15:41
mdboothefried: Ok. Just wondering if you'd end up running gate/test_evacuate.sh by default.15:42
mdboothIf you did, it would fail.15:42
mdboothmriedem: Do you know how external CI is typically configured ^^^ ?15:42
efried"typically"?15:42
efriednot really, no.15:42
efriedI couldn't really even tell you how ours is configured :)15:42
efriededmondsw: Any ideas ^ ?15:43
edmondswnot sure what gate/test_evacuate.sh is15:43
openstackgerritMatt Riedemann proposed openstack/nova master: Add attach kwarg to base/nova-net allocate_for_instance methods  https://review.openstack.org/60546415:43
jaypipesgibi: question for you on https://review.openstack.org/#/c/591811/. I'm sure I'm just missing something silly...15:43
mriedemmdbooth: they wouldn't15:43
efriedmdbooth: It looks to me like this is only going to change the legacy nova-live-migration job. Does that even get triggered anymore?15:43
mdboothedmondsw: It's new in https://review.openstack.org/#/c/602174/15:44
mriedemefried: yes15:44
gibijaypipes: looking15:44
mriedemdevstack-gate can run post-test hook scripts15:44
mdboothBasically if it's 'opt-in' then failing if libvirt isn't configured is the correct behaviour15:44
mriedemsome 3rd party CI still uses devstack-gate, some are moving to zuul v3 which doesn't use devstack-gate (unless you define a legacy-style job, like nova-live-migration)15:44
mriedemit's definitely opt-in15:44
mdboothIf we always run it we'd probably want it to just skip15:44
mdboothmriedem: Thanks15:44
*** dklyle has joined #openstack-nova15:45
edmondswmdbooth our CI is currently using devstack all-in-ones for each run, so it can't do things like evacuate that require multiple nodes yet... working on that15:45
*** munimeha1 has joined #openstack-nova15:45
mriedemtempest doesn't test evacuate anyway15:46
*** macza has joined #openstack-nova15:46
efriedand we're using zuulv3, right?15:46
mriedemthat's why this in a separate script, when tempest isn't running15:46
*** Bhujay has joined #openstack-nova15:46
openstackgerritMerged openstack/nova stable/queens: Follow devstack-plugin-ceph job rename  https://review.openstack.org/60201915:46
openstackgerritMerged openstack/nova stable/queens: nova-status - don't count deleted compute_nodes  https://review.openstack.org/60478615:46
gibijaypipes: you are right we are not catching AllocationDeleteFailed explicitly above in the call stack. Fortunately there are generic exception handling in place alreasy that puts the instance in ERROR state.15:47
gibijaypipes: the move operations are async on the API so when the fault happens there is no way to return that back to the API user anyhow15:47
*** xyang has joined #openstack-nova15:47
edmondswefried we are not using zuulv3 in PowerVM CI yet, if that's what you were asking15:49
efrieddah, okay, thought we were15:49
edmondswlast I heard, zuulv3 wasn't really ready for 3rd party CI usage yet15:50
melwittmriedem: I was looking at whether I should add the vmware live migration patch (in the queue) to a runway but saw it's failing vmware CI, and I see you've been discussing it with rado https://review.openstack.org/#/c/27011615:51
*** macza has quit IRC15:51
*** panda is now known as panda|bbl15:52
*** macza has joined #openstack-nova15:52
mriedemi haven't looked at it since my last comments15:53
mriedemit's also failing unit test15:53
melwittok. I'll make a note next to it in the queue15:54
*** dave-mccowan has joined #openstack-nova15:54
*** tssurya has quit IRC15:55
*** dave-mccowan has quit IRC15:57
mriedema shiny donkey to whoever can bring me the head of https://bugs.launchpad.net/nova/+bug/178999815:57
openstackLaunchpad bug 1789998 in OpenStack Compute (nova) "ResourceProviderAllocationRetrievalFailed ERROR log message on fresh n-cpu startup" [Low,Triaged]15:57
efriedF, I forgot *again* to collect my shiny nickel in Denver.15:58
mriedemit's still in my backpack15:58
efriedThat should probably be my bug. But I'm not likely to have time to look at it today.15:58
efriedalso, /me wonders what "shiny donkey" means. Sounds like a euphemism for something.15:59
efriedWill it also fit in your backpack?16:00
*** dave-mccowan has joined #openstack-nova16:00
mdboothmriedem: Speaking of common gate bugs: https://review.openstack.org/#/c/605436/16:01
mriedemefried: https://www.youtube.com/watch?v=UNV44oqUF6k16:01
mdboothAlthough I didn't to a full test run on it locally first, so I won't be surprised if there's a kink to work out.16:01
mriedemevacuate + affinity + locks = my head will explode16:02
mdboothmriedem: Add in a context manager which is a closure and some tail recursion ;)16:03
melwittI added cfriesen to the review16:05
mdboothcfriesen: https://review.openstack.org/#/c/605436/16:05
mdboothmelwitt: Yeah, I was going to ping him earlier but he wasn't around16:05
mdboothI saw on the bug he looked at it before, and I assume there's some alternative solution in StarlingX16:05
melwittyeah16:06
cfriesenfor the "validate flavor extra-specs and image properties" work item, do we need a spec since it'll presumably result in an error message to the user?  or are we allowed to return new error messages?16:07
mdboothLike I said it's not central to anything on my plate right now, though, so if somebody else wants to do a better job I'm cool with that. I probably won't spend a huge amount of time on it myself, though.16:07
mdboothI just fixed it because I saw it.16:08
cfriesenmdbooth: taking a look16:08
*** dtantsur is now known as dtantsur|afk16:08
openstackgerritMatthew Booth proposed openstack/nova master: Add volume-backed evacuate test  https://review.openstack.org/60439716:11
openstackgerritMatthew Booth proposed openstack/nova master: Run evacuate tests with local/lvm and shared/rbd storage  https://review.openstack.org/60440016:11
cfriesensecond question, for the "vcpu model extension" change where we'd allow specifying a list of CPU models in nova.conf instead of a single model, would we need a spec even though we're not changing the API?16:11
mgariepyhello, I am upgrading from Pike to Queens but when running nova-manage db online_data_migrations, i get  Some instances are still missing keypair information. Unable to run keypair migration at this time16:11
*** gibi has quit IRC16:14
mgariepyi found a few bug in lp concerning a workaround for kilo > liberty upgrade but the fix doesn't work for me as i don't have missing instance in my db.16:14
mgariepyhttps://bugs.launchpad.net/nova/+bug/168486116:14
openstackLaunchpad bug 1684861 in OpenStack Compute (nova) newton "Mitaka -> Newton: Database online_data_migrations in newton fail due to missing keypairs" [Medium,In progress] - Assigned to Lee Yarwood (lyarwood)16:14
mgariepyI have 845 entry for select count(instance_uuid) from instance_extra where keypairs is NULL;16:15
mdboothmgariepy: See #topic. You should probably try #openstack instead16:15
mgariepywell it's a nova issue.16:15
mgariepyi've been upgrading to N o p q. and it fails a Q.16:16
openstackgerritMatthew Booth proposed openstack/nova master: Raise error on timeout in wait_for_versioned_notifications  https://review.openstack.org/60485916:16
openstackgerritMatthew Booth proposed openstack/nova master: Add regression test for bug 1550919  https://review.openstack.org/59173316:16
openstackbug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9)16:16
openstackgerritMatthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate  https://review.openstack.org/57884616:16
melwittcfriesen: for extra spec and image properties validation, I think we would do a spec for it because it's an API change. for the cpu model list, from the ptg notes it looks like we thought we'd need a spec, maybe just to capture all of the related information. any opinion on either of these, mriedem?16:17
mdboothmgariepy: Indeed, but kilo and liberty are long out of support. Perhaps try your vendor?16:17
mdboothmriedem: We don't have any NFS CI jobs, do we?16:18
mgariepyi'm upgrading from pike to queens.16:18
mdboothmriedem: I probably asked this before: my memory is terrible.16:19
*** a-pugachev has quit IRC16:23
imacdonnmgariepy: you should at least try in #openstack ... "how do I...?" questions should start there. This channel is about development, not deployment .. if it's determined that there's a current bug, it could be brought here16:23
mriedemmdbooth: we do,16:24
mriedemit's in the experimental queue16:24
mriedemmelwitt: yes for api spec for extra spec validation in the api16:24
mriedemas for cpu models stuff in nova.conf, idk, wasn't paying attention to that at the ptg16:24
mriedemmdbooth: pro tip: look in nova's .zuul.yaml file16:25
mriedemye shall behold legacy-tempest-dsvm-full-devstack-plugin-nfs16:25
cfriesenmdbooth: the starlingx server group validation stuff is here: https://github.com/starlingx-staging/stx-nova/blob/master/nova/compute/manager.py#L1408-L1436 and the check against "older" instances is here: https://github.com/starlingx-staging/stx-nova/blob/master/nova/objects/instance_group.py#L550-L57216:26
cfriesenmelwitt: okay, specs it is.16:26
mriedemcfriesen: i think i might have mentioned this to you before, but you know how starlingx has a patched/upgraded flag it sets on the HostState object in the scheduler and then has a weigher for those?16:26
melwittthanks. cfriesen ^ you could try the cpu models as a specless bp and when we ask for approval during the nova meeting, someone might point out why it should be a spec, so you might have to write one at that point16:26
mriedemi think the idea being, send new requests to patched/upgraded hosts?16:26
mriedemcfriesen: any reason to not just check the compute's service version to see if it's the latest?16:27
mriedemthat would tell you if it's upgraded16:27
melwittmgariepy: you said earlier that you have not manually deleted any instances from the database?16:28
cfriesenmriedem: one issue was that patching for a bugfix might not affect the service version16:28
cfriesenmriedem: but that would work for the upgrade case16:28
mgariepymelwitt, nop i didn't16:29
mriedemweighing based on bug fix patches seems excessive16:29
mgariepyi think the upgrade db didn't updated the deleted instances attrbutes.16:29
*** Bhujay has quit IRC16:29
mriedembut i guess i get it16:29
cfriesenmriedem: so in the original model due to limitations we had to reboot the compute node when patching, so when rolling out a patch we really didn't want to have to migrate instances multiple times if we could avoid it.   Probably less of an issue now.16:30
mgariepymelwitt, updated the keypairs fields in the db..16:31
imacdonnefried: ping me if you want to discuss https://review.openstack.org/#/c/605329/ - there's probably a sexier way to do it16:34
*** panda|bbl is now known as panda16:35
*** ttsiouts has quit IRC16:35
mriedemimacdonn: gonna need tests16:35
mriedemb/c clearly we weren't testing this before which is why it's a bug16:35
imacdonnmriedem: yeah, I figured that'd come up ... but there aren't any tests at all for this stuff currently, or I failed to find them16:35
imacdonnTrying to verify the contents of a PrettyTable didn't seem appealing :/16:36
mriedemhttps://github.com/openstack/nova/blob/41ac87f812f239e38ad3b72c2f2108523ad3444d/nova/tests/unit/test_nova_manage.py#L74916:36
mriedemthere are tests for each individual migration method but you're right that they aren't tested together in aggregate16:37
imacdonnoh. Why isn't that under "cmd" ?16:37
mriedemb/c history16:37
imacdonnmmkay16:37
mriedemno reason we couldn't move it16:37
mriedemexcept it makes backports a pain in the ass16:37
melwittmgariepy: oh, hm. ok, we have had online data migrations before that skip deleted records, so that sounds legit but I need to look and double check. it's surprising though that we haven't had this reported before, I'd think it would be common16:37
imacdonnk, I'll look into why the test didn't catch the bug16:38
imacdonnoh, I guess because it didn't have more than 50 of any migration type16:38
melwitttssurya, mriedem: I've got a call at the top of the hour, so I won't be able to participate much in a cells meeting if we have one16:40
mgariepymelwitt, the cloud i'm upgarding lives from some times. first install was kilo and upgraded16:43
mgariepybut depending on the when it's upgraded, it can cause inconsistency some times..16:43
melwittmgariepy: yeah, so I'm looking at this and the migration is that it's moving keypairs from the "main" database to the api database. and it's counting only the non-deleted InstanceExtra. InstanceExtra are marked as deleted when instances are deleted through the nova API https://github.com/openstack/nova/blob/stable/queens/nova/objects/keypair.py#L24516:46
*** dave-mccowan has quit IRC16:49
melwittI don't yet understand how this works, I see the migration creates a keypair in the api db, deletes the keypair from the cell db, but I'm not yet seeing the connection with instance_extra16:50
melwittit looks like the instance_extra part is a separate migration that should have happened before this cell db => api db one that I'm looking at16:51
melwittok yeah, instance_obj.migrate_instance_keypairs16:52
melwittfrom newton16:52
mgariepyi'm currently using : nova_git_install_branch: d7864fbb9c2c558c409559e1d5989f84c7403832 # HEAD of "stable/queens" as of 23.07.201816:53
mgariepymelwitt, can you point me to the commit ?16:53
melwittmgariepy: here's the code https://github.com/openstack/nova/blob/stable/ocata/nova/objects/instance.py#L1398 that should have run when you upgraded to newton, when you ran the nova-manage db online_data_migrations. did you do that for newton?16:54
melwittthe code no longer exists in queens, so if you missed running that online data migration in newton, you can't run it with the queens code16:55
mgariepyi ran it for sure.16:56
*** artom has quit IRC16:58
melwittand there were no errors? because while this is only migrating non-deleted records, the check that is blocking you in queens is also only considering non-deleted records, so I don't see how this could be happening unless the online migration from newton was missed or had errors16:58
openstackgerritMerged openstack/nova master: placement: Always reset conf.CONF when starting the wsgi app  https://review.openstack.org/60469316:58
melwittas for getting out of it, if the unmigrated instance_extra records are associated with non-deleted instances, I think you're going to have to do something like use the old newton code to migrate the records. if they unmigrated instance_extra records are associated with deleted instances, you're going to have to delete them manually17:00
*** derekh has quit IRC17:01
mgariepythe Ocata code i was runnig wasn't the latest17:02
mgariepyanyway seems to be fixed now.17:03
*** artom has joined #openstack-nova17:04
mgariepyis there a script to validate the database ?17:04
mgariepyi run this cloud since kilo17:07
mgariepymaybe some stuff didn't migrate well, it's just not fun to find out the day you upgrade it17:08
*** jpena is now known as jpena|off17:09
melwittyeah, so there's this tool called the upgrade status check17:11
*** slaweq has joined #openstack-nova17:11
* melwitt looks for docs17:11
melwitthttps://docs.openstack.org/nova/pike/cli/nova-status.html17:12
cfriesenmriedem: re: weighing based on patching, the main usecase currently is for things that fundamentally require taking the node out of service (kernel and kernel modules, for example).  But it's coupled with our proprietary patching orchestrator, so it's not really upstreamable.17:12
*** slaweq has quit IRC17:15
*** dpawlik has joined #openstack-nova17:16
*** dpawlik has quit IRC17:16
*** dpawlik has joined #openstack-nova17:17
mgariepyanyway, thanks for you help melwitt,17:30
melwittmgariepy: yeah, take a look at the nova-status command, that should help you out during each upgrade to make sure you've done all the steps needed for the upgrade to succeed17:33
*** ralonsoh has quit IRC17:41
mriedemmelwitt: i assumed the cells meeting was not happening since tssurya isn't around and dan is out17:44
cfriesenmelwitt: for the "image properties and flavor extra-spec validation", can we use the fact that rebuild/resize/create can all already return a 400 error to avoid the need for a new microversion?17:45
cfriesenmriedem: maybe you could answer this too. ^17:46
melwittyeah, I was thinking mriedem would be better for answering that17:46
*** dpawlik has quit IRC17:47
mriedemcfriesen: uh, no17:48
mriedembecause on cloud A i can do something which i can't on cloud B17:48
cfriesenmriedem: what about the argument that it silently failed before (you have to check the instance state to see it go to ERROR) but now we'll return an error?17:49
mriedemi could maybe buy that, but this is a big enough change that i think it's hard to justify17:50
mriedemtbc, i don't think a spec is warranted just b/c of a microversion, but also about how this is going to work and which specs will be validated and how17:50
cfriesenmriedem: okay, new microversion it is.  I'm not going to be the one writing this spec, I'm just establishing the parameters for someone else to write it up.17:51
cfriesen(someone else on our side, I mean)17:52
mriedemi'm also only one person17:52
mriedemothers might have other opinions17:52
mriedemlike alex_xu and gmann17:53
cfriesenwe can write it up assuming a new microversion and call it out in the review.  easy enough to remove if not needed17:54
mriedemyeah just use the alternatives sectoin17:55
mriedem*section17:55
openstackgerritiain MacDonnell proposed openstack/nova master: nova-manage - fix online_data_migrations counts  https://review.openstack.org/60532918:07
*** slaweq has joined #openstack-nova18:12
*** gibi has joined #openstack-nova18:18
*** dpawlik has joined #openstack-nova18:21
*** slaweq has quit IRC18:22
*** pcaruana has quit IRC18:24
*** lbragstad has quit IRC18:24
*** dpawlik has quit IRC18:25
*** lbragstad has joined #openstack-nova18:25
*** maciejjozefczyk has joined #openstack-nova18:33
openstackgerritJonte Watford proposed openstack/nova master: Add __str__  method to NUMACell related objects  https://review.openstack.org/60026918:46
openstackgerritJonte Watford proposed openstack/nova master: Add __str__  method to NUMACell related objects  https://review.openstack.org/60026918:49
*** jdillaman has quit IRC18:58
*** jdillaman has joined #openstack-nova18:59
*** dave-mccowan has joined #openstack-nova19:05
*** rtjure has quit IRC19:05
*** rtjure has joined #openstack-nova19:08
openstackgerritJonte Watford proposed openstack/nova master: Add __str__  method to NUMACell related objects  https://review.openstack.org/60026919:18
*** slaweq has joined #openstack-nova19:24
*** Sundar has joined #openstack-nova19:32
efriedimacdonn: The test will hopefully help me understand it - or at least prove to myself that you've fixed something.19:37
imacdonnefried: I pasted example output of the failure case in the bug report19:38
mriedemi could use a hashable ovo right about now19:39
efriedimacdonn: Yeah, I saw that and it helped me understand the problem, but looking at the code I couldn't see a) how the problem was happening, or b) how you fixed it. It's been a few hours now, maybe a second look will do the trick.19:40
mriedemi've got a sorted list of things, but some of those things could be duplicates, and i need to filter out the duplicates, but ovos are'nt hashable as far as i can tell19:40
efriedmriedem: set()?19:40
efriedoh, you have a sorted list of OVOs.19:41
mriedemright19:41
efriedgot it19:41
efriedare the __eq__ able?19:41
imacdonnefried: heh. the problem was that each invocation of the inner method was returning a dict with counts from that run, and it was being used to update() a dict in the outer functions .. that replaced the values in the outer one, instead of adding to them19:41
mriedemspecifically, 2 of the Migration objects in the same list have the same uuid19:41
mriedembut their updated_at values are different and i just need to remove the older one19:41
efriedmriedem: So you sorted by UUID?19:41
mriedemnot necessarily19:41
mriedemdefault sort keys are: sort_keys=['created_at', 'id']19:42
mriedemhttp://paste.openstack.org/show/730960/19:43
efriedmriedem: You could use filter() to bastardize set() logic19:43
*** k_mouza has joined #openstack-nova19:43
efriedbut, yeah, one way or another you're not getting out of this without a loop.19:45
mriedemright i've got a loop19:45
mriedembut it's fugly19:45
efriedYou could monkey-patch a __hash__ function onto the objects...19:45
mriedemplus, i have to maintain the sort order of the list19:45
efriedthis is nova.objects.Migration?19:46
mriedemyeah19:46
mriedemovo actually has a ComparableVersionedObject mixin19:46
mriedemwe only use it in one place in nova's objects, the Selection object19:47
efriedbut you only want to use the UUID to compare the lists?19:47
*** k_mouza has quit IRC19:47
mriedemi think i might have it19:54
*** maciejjozefczyk has quit IRC19:54
mriedemyup got it19:55
mriedemffs, you know how sometimes you come across a programming problem which seems like something you dealt with on a daily basis when you were a junior in college?19:55
mriedemand now, getting paid high professional tech person salary, you feel dumb as a brick19:56
efriedcollege is way harder than real life19:56
efriedimacdonn: Okay, I'm there. The bug is the .update, which is patently wrong.19:57
efriedimacdonn: I convinced myself by solving it a different way: http://paste.openstack.org/show/730962/19:57
efriedwhich isn't better than what you've done, just different.19:58
imacdonnefried: I tried to do it your way, but I got a complaint about tuples ... oh, you changed it to a list19:59
efriedyeah19:59
efriedno reason for it to be a tuple afaics19:59
efriedanyway, I'm approving your patch. Good catch, good fix.19:59
imacdonncool, thanks!19:59
*** bnemec has quit IRC20:10
*** evrardjp has joined #openstack-nova20:11
*** gibi has quit IRC20:12
*** bnemec has joined #openstack-nova20:15
*** priteau has quit IRC20:33
*** munimeha1 has quit IRC20:40
*** gibi has joined #openstack-nova20:45
openstackgerritMerged openstack/nova master: Transform missing delete notifications  https://review.openstack.org/41029720:51
openstackgerritMerged openstack/nova master: cells: Be explicit in docs about service restarts  https://review.openstack.org/60358820:51
openstackgerritMerged openstack/nova master: api-ref: add 'migrations' param to GET /os-migrations  https://review.openstack.org/60523220:51
openstackgerritMerged openstack/nova master: Ignore VirtDriverNotReady in _sync_power_states periodic task  https://review.openstack.org/60437620:51
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Ignore VirtDriverNotReady in _sync_power_states periodic task  https://review.openstack.org/60553320:58
*** erlon has quit IRC21:04
*** slaweq has quit IRC21:06
*** panda is now known as panda|off21:13
imacdonnmriedem: something's troubling me about this online migrations stuff21:27
imacdonnhttps://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L374-L38621:27
imacdonnif there are more than max-count non-migratable rows, wouldn't the method return 50 found and 0 done... even though there could be some that are migratable ?21:28
imacdonnis the migration method supposed to be smart enough to attempt the migratable ones first ?21:29
mriedemi'm not sure what a non-migrateable record is21:44
mriedemdansmith would be the best person to ask about that comment but he's out the rest of this week21:44
imacdonnmy interpretation was that there are some migrations that cannot always be applied to all rows .... tho it's not clear what the implications would be21:45
*** mgariepy has quit IRC21:59
*** awaugama has quit IRC22:00
*** dklyle has quit IRC22:02
openstackgerritChris Friesen proposed openstack/nova-specs master: Add support for emulated virtual TPM  https://review.openstack.org/57111122:05
openstackgerritChris Friesen proposed openstack/nova-specs master: Add support for emulated virtual TPM  https://review.openstack.org/57111122:08
*** mgariepy has joined #openstack-nova22:13
*** mlavalle has quit IRC22:21
*** rcernin has joined #openstack-nova22:35
*** dpawlik has joined #openstack-nova22:48
*** dpawlik has quit IRC22:52
*** rcernin has quit IRC22:53
*** rcernin has joined #openstack-nova22:55
*** Sundar has quit IRC23:05
mriedemholy god 609 things in the check queue23:08
*** macza has quit IRC23:09
*** macza has joined #openstack-nova23:10
*** macza has quit IRC23:14
openstackgerritmelanie witt proposed openstack/nova master: Revert "Deprecate the nova-consoleauth service"  https://review.openstack.org/60525023:23
openstackgerritmelanie witt proposed openstack/nova master: Un-deprecate the nova-consoleauth service  https://review.openstack.org/60525523:23
*** jlvillal has joined #openstack-nova23:24
openstackgerritmelanie witt proposed openstack/nova master: Revert "Deprecate the nova-consoleauth service"  https://review.openstack.org/60525023:25
openstackgerritmelanie witt proposed openstack/nova master: Un-deprecate the nova-consoleauth service  https://review.openstack.org/60525523:25
*** dklyle has joined #openstack-nova23:26
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Cross-cell resize  https://review.openstack.org/60393023:29
*** mriedem is now known as mriedem_away23:30
*** macza has joined #openstack-nova23:34
*** macza has quit IRC23:39
*** rcernin_ has joined #openstack-nova23:41
*** rcernin has quit IRC23:43
*** liuyulong has quit IRC23:47
*** openstackgerrit has quit IRC23:49
*** hshiina has joined #openstack-nova23:51

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!