Wednesday, 2018-10-10

*** itlinux has joined #openstack-nova00:03
*** hamzy_ has joined #openstack-nova00:05
openstackgerritMerged openstack/nova master: api-ref: Replace non UUID string with UUID  https://review.openstack.org/60885400:09
*** moshele has quit IRC00:11
*** lbragstad has joined #openstack-nova00:16
*** gyee has quit IRC00:20
openstackgerritBrin Zhang proposed openstack/nova master: Add compute version 36 to support ``volume_type``  https://review.openstack.org/57936000:22
*** k_mouza has quit IRC00:24
*** tetsuro has joined #openstack-nova00:24
*** cfriesen has quit IRC00:27
openstackgerritiain MacDonnell proposed openstack/nova master: Handle online_data_migrations exceptions  https://review.openstack.org/60809100:34
*** Dinesh_Bhor has joined #openstack-nova00:38
*** ircuser-1 has joined #openstack-nova00:45
*** Dinesh_Bhor has quit IRC00:49
*** Dinesh_Bhor has joined #openstack-nova00:52
*** tetsuro has quit IRC01:00
*** slaweq has joined #openstack-nova01:11
*** hongbin has joined #openstack-nova01:14
*** slaweq has quit IRC01:15
openstackgerritSam Morrison proposed openstack/nova master: Allow ability for non admin users to list all flavors.  https://review.openstack.org/60847401:17
*** erlon_ has quit IRC01:20
*** mrsoul has joined #openstack-nova01:32
*** swamireddy has quit IRC01:37
*** openstackgerrit has quit IRC01:37
*** mgoddard has quit IRC01:37
*** Dinesh_Bhor has quit IRC01:37
*** mhen has quit IRC01:37
*** tristanC has quit IRC01:37
*** mikeoschen has quit IRC01:37
*** mugsie has quit IRC01:37
*** jackding has quit IRC01:37
*** jroll has quit IRC01:37
*** logan- has quit IRC01:37
*** ajo has quit IRC01:37
*** odyssey4me has quit IRC01:37
*** jcosmao has quit IRC01:37
*** vdrok has quit IRC01:37
*** mvkr has quit IRC01:37
*** markvoelker has quit IRC01:37
*** jaypipes has quit IRC01:37
*** sean-k-mooney has quit IRC01:37
*** icey has quit IRC01:37
*** jmlowe has quit IRC01:37
*** edleafe has quit IRC01:37
*** burt has quit IRC01:37
*** gibi has quit IRC01:37
*** wznoinsk has quit IRC01:37
*** jhesketh has quit IRC01:37
*** nehaalhat_ has quit IRC01:37
*** Sigyn has quit IRC01:37
*** yonglihe has quit IRC01:37
*** dtroyer has quit IRC01:37
*** McNinja has quit IRC01:37
*** dave-mccowan has quit IRC01:37
*** rpittau has quit IRC01:37
*** jiapei has quit IRC01:37
*** devananda has quit IRC01:37
*** Cardoe has quit IRC01:37
*** spsurya has quit IRC01:37
*** etp has quit IRC01:37
*** sdake has quit IRC01:37
*** xyang has quit IRC01:37
*** masayukig[m] has quit IRC01:37
*** pas-ha has quit IRC01:37
*** johnsom has quit IRC01:37
*** mgagne has quit IRC01:37
*** knikolla has quit IRC01:37
*** dklyle has quit IRC01:37
*** kukacz has quit IRC01:37
*** Kevin_Zheng has quit IRC01:37
*** BlackDex has quit IRC01:37
*** szaher has quit IRC01:37
*** gmann has quit IRC01:37
*** StevenK has quit IRC01:37
*** kashyap has quit IRC01:37
*** hamzy_ has quit IRC01:37
*** efried has quit IRC01:37
*** gouthamr has quit IRC01:37
*** belmoreira has quit IRC01:37
*** wxy-xiyuan has quit IRC01:37
*** MasterofJOKers has quit IRC01:37
*** dosaboy has quit IRC01:37
*** tinwood has quit IRC01:37
*** zzzeek_ has quit IRC01:37
*** manjeets has quit IRC01:37
*** hfjvjffju has quit IRC01:37
*** bandini has quit IRC01:37
*** dr_gogeta86 has quit IRC01:37
*** ebbex has quit IRC01:37
*** nicolasbock has quit IRC01:37
*** beagles has quit IRC01:37
*** sayalilunkad has quit IRC01:37
*** ShilpaSD has quit IRC01:37
*** pooja_jadhav has quit IRC01:37
*** yikun has quit IRC01:37
*** jistr has quit IRC01:37
*** amotoki has quit IRC01:37
*** jpena|off has quit IRC01:37
*** dtantsur|afk has quit IRC01:37
*** stephenfin has quit IRC01:37
*** sorrison has quit IRC01:37
*** whoami-rajat has quit IRC01:37
*** hogepodge has quit IRC01:37
*** jbryce has quit IRC01:37
*** kmalloc has quit IRC01:37
*** lamt has quit IRC01:37
*** coreycb has quit IRC01:37
*** jungleboyj has quit IRC01:37
*** Hazelesque has quit IRC01:37
*** geekinutah has quit IRC01:37
*** hongbin has quit IRC01:37
*** lbragstad has quit IRC01:37
*** panda has quit IRC01:37
*** imacdonn has quit IRC01:37
*** artom has quit IRC01:37
*** penick has quit IRC01:37
*** jiaopengju has quit IRC01:37
*** SpamapS has quit IRC01:37
*** mgariepy has quit IRC01:37
*** d34dh0r53 has quit IRC01:37
*** yankcrime has quit IRC01:37
*** NostawRm has quit IRC01:37
*** tonyb has quit IRC01:37
*** lennyb has quit IRC01:37
*** jbernard has quit IRC01:37
*** bnemec has quit IRC01:37
*** andreykurilin has quit IRC01:37
*** egonzalez has quit IRC01:37
*** fnordahl has quit IRC01:37
*** rm_work has quit IRC01:37
*** fungi has quit IRC01:37
*** ttx has quit IRC01:37
*** samueldmq has quit IRC01:37
*** melwitt has quit IRC01:37
*** s1061123 has quit IRC01:37
*** andymccr has quit IRC01:37
*** rabel has quit IRC01:37
*** jamesdenton has quit IRC01:37
*** nicholas has quit IRC01:37
*** chason has quit IRC01:37
*** bauzas has quit IRC01:37
*** mnaser has quit IRC01:37
*** TheJulia has quit IRC01:37
*** mordred has quit IRC01:37
*** hughsaunders has quit IRC01:37
*** itlinux has quit IRC01:37
*** jaosorior has quit IRC01:37
*** _pewp_ has quit IRC01:37
*** _hemna has quit IRC01:37
*** dims has quit IRC01:37
*** kencjohnston has quit IRC01:37
*** DinaBelova has quit IRC01:37
*** larsks has quit IRC01:37
*** gnuoy has quit IRC01:37
*** mrsoul has quit IRC01:37
*** sambetts_ has quit IRC01:37
*** vabada has quit IRC01:37
*** alex_xu has quit IRC01:37
*** jdillaman has quit IRC01:37
*** purplerbot has quit IRC01:37
*** naichuans has quit IRC01:37
*** jamiec_ has quit IRC01:37
*** mmedvede has quit IRC01:37
*** elod has quit IRC01:37
*** rnoriega has quit IRC01:37
*** obre has quit IRC01:37
*** johnthetubaguy has quit IRC01:37
*** spotz has quit IRC01:37
*** Jeffrey4l has quit IRC01:37
*** raginbajin has quit IRC01:37
*** dansmith has quit IRC01:37
*** antonym has quit IRC01:37
*** liuyulong has quit IRC01:37
*** jangutter has quit IRC01:37
*** owalsh_away has quit IRC01:37
*** zigo has quit IRC01:37
*** eandersson has quit IRC01:37
*** tobias-urdin has quit IRC01:37
*** smcginnis has quit IRC01:37
*** gryf has quit IRC01:37
*** niceplace has quit IRC01:37
*** breton has quit IRC01:37
*** ircuser-1 has quit IRC01:37
*** rcernin has quit IRC01:37
*** kaisers has quit IRC01:37
*** kevinbenton has quit IRC01:37
*** ianw has quit IRC01:37
*** jlvillal has quit IRC01:37
*** edmondsw has quit IRC01:37
*** aloga has quit IRC01:37
*** dulek has quit IRC01:37
*** aarents has quit IRC01:37
*** andreaf has quit IRC01:37
*** alanmeadows has quit IRC01:37
*** zioproto has quit IRC01:37
*** rha has quit IRC01:37
*** frickler has quit IRC01:37
*** hemna has quit IRC01:37
*** markmcclain has quit IRC01:37
*** ericyoung has quit IRC01:37
*** rmk has quit IRC01:37
*** ChanServ has quit IRC01:37
*** andreaf has joined #openstack-nova01:43
*** dulek has joined #openstack-nova01:43
*** aloga has joined #openstack-nova01:43
*** aarents has joined #openstack-nova01:43
*** edmondsw has joined #openstack-nova01:43
*** jlvillal has joined #openstack-nova01:43
*** ianw has joined #openstack-nova01:43
*** kevinbenton has joined #openstack-nova01:43
*** kaisers has joined #openstack-nova01:43
*** rcernin has joined #openstack-nova01:43
*** ircuser-1 has joined #openstack-nova01:43
*** odyssey4me has joined #openstack-nova01:43
*** jcosmao has joined #openstack-nova01:43
*** vdrok has joined #openstack-nova01:43
*** ajo has joined #openstack-nova01:43
*** logan- has joined #openstack-nova01:43
*** jroll has joined #openstack-nova01:43
*** jackding has joined #openstack-nova01:43
*** mikeoschen has joined #openstack-nova01:43
*** mhen has joined #openstack-nova01:43
*** mugsie has joined #openstack-nova01:43
*** Dinesh_Bhor has joined #openstack-nova01:43
*** niceplace has joined #openstack-nova01:43
*** breton has joined #openstack-nova01:43
*** gryf has joined #openstack-nova01:43
*** smcginnis has joined #openstack-nova01:43
*** tobias-urdin has joined #openstack-nova01:43
*** eandersson has joined #openstack-nova01:43
*** zigo has joined #openstack-nova01:43
*** owalsh_away has joined #openstack-nova01:43
*** jangutter has joined #openstack-nova01:43
*** liuyulong has joined #openstack-nova01:43
*** antonym has joined #openstack-nova01:43
*** dansmith has joined #openstack-nova01:43
*** raginbajin has joined #openstack-nova01:43
*** Jeffrey4l has joined #openstack-nova01:43
*** spotz has joined #openstack-nova01:43
*** johnthetubaguy has joined #openstack-nova01:43
*** obre has joined #openstack-nova01:43
*** rnoriega has joined #openstack-nova01:43
*** elod has joined #openstack-nova01:43
*** jamiec_ has joined #openstack-nova01:43
*** mmedvede has joined #openstack-nova01:43
*** naichuans has joined #openstack-nova01:43
*** purplerbot has joined #openstack-nova01:43
*** jdillaman has joined #openstack-nova01:43
*** alex_xu has joined #openstack-nova01:43
*** vabada has joined #openstack-nova01:43
*** sambetts_ has joined #openstack-nova01:43
*** mrsoul has joined #openstack-nova01:43
*** dklyle has joined #openstack-nova01:44
*** kukacz has joined #openstack-nova01:44
*** Kevin_Zheng has joined #openstack-nova01:44
*** BlackDex has joined #openstack-nova01:44
*** szaher has joined #openstack-nova01:44
*** gmann has joined #openstack-nova01:44
*** kashyap has joined #openstack-nova01:44
*** StevenK has joined #openstack-nova01:44
*** Sigyn has joined #openstack-nova01:44
*** nehaalhat_ has joined #openstack-nova01:44
*** bnemec has joined #openstack-nova01:44
*** andreykurilin has joined #openstack-nova01:44
*** egonzalez has joined #openstack-nova01:44
*** fnordahl has joined #openstack-nova01:44
*** rm_work has joined #openstack-nova01:44
*** fungi has joined #openstack-nova01:44
*** ttx has joined #openstack-nova01:44
*** samueldmq has joined #openstack-nova01:44
*** melwitt has joined #openstack-nova01:44
*** hamzy_ has joined #openstack-nova01:44
*** efried has joined #openstack-nova01:44
*** gouthamr has joined #openstack-nova01:44
*** belmoreira has joined #openstack-nova01:44
*** wxy-xiyuan has joined #openstack-nova01:44
*** MasterofJOKers has joined #openstack-nova01:44
*** dosaboy has joined #openstack-nova01:44
*** tinwood has joined #openstack-nova01:44
*** zzzeek_ has joined #openstack-nova01:44
*** manjeets has joined #openstack-nova01:44
*** bandini has joined #openstack-nova01:44
*** dr_gogeta86 has joined #openstack-nova01:44
*** ebbex has joined #openstack-nova01:44
*** nicolasbock has joined #openstack-nova01:44
*** beagles has joined #openstack-nova01:44
*** sayalilunkad has joined #openstack-nova01:44
*** openstackgerrit has joined #openstack-nova01:44
*** mgoddard has joined #openstack-nova01:44
*** zioproto has joined #openstack-nova01:45
*** alanmeadows has joined #openstack-nova01:45
*** rha has joined #openstack-nova01:45
*** frickler has joined #openstack-nova01:45
*** hemna has joined #openstack-nova01:45
*** markmcclain has joined #openstack-nova01:45
*** ericyoung has joined #openstack-nova01:45
*** rmk has joined #openstack-nova01:45
*** ShilpaSD has joined #openstack-nova01:45
*** pooja_jadhav has joined #openstack-nova01:45
*** yikun has joined #openstack-nova01:45
*** jistr has joined #openstack-nova01:45
*** amotoki has joined #openstack-nova01:45
*** jpena|off has joined #openstack-nova01:45
*** dtantsur|afk has joined #openstack-nova01:45
*** lamt has joined #openstack-nova01:45
*** sorrison has joined #openstack-nova01:45
*** stephenfin has joined #openstack-nova01:45
*** coreycb has joined #openstack-nova01:45
*** whoami-rajat has joined #openstack-nova01:45
*** jungleboyj has joined #openstack-nova01:45
*** hogepodge has joined #openstack-nova01:45
*** geekinutah has joined #openstack-nova01:45
*** jbryce has joined #openstack-nova01:45
*** kmalloc has joined #openstack-nova01:45
*** Hazelesque has joined #openstack-nova01:45
*** yonglihe has joined #openstack-nova01:45
*** dtroyer has joined #openstack-nova01:45
*** McNinja has joined #openstack-nova01:45
*** mvkr has joined #openstack-nova01:46
*** markvoelker has joined #openstack-nova01:46
*** edleafe has joined #openstack-nova01:46
*** sean-k-mooney has joined #openstack-nova01:46
*** icey has joined #openstack-nova01:46
*** jmlowe has joined #openstack-nova01:46
*** wznoinsk has joined #openstack-nova01:46
*** burt has joined #openstack-nova01:46
*** gibi has joined #openstack-nova01:46
*** jhesketh has joined #openstack-nova01:46
*** jamesdenton has joined #openstack-nova01:46
*** nicholas has joined #openstack-nova01:46
*** chason has joined #openstack-nova01:46
*** bauzas has joined #openstack-nova01:46
*** mnaser has joined #openstack-nova01:46
*** TheJulia has joined #openstack-nova01:46
*** mordred has joined #openstack-nova01:46
*** s1061123 has joined #openstack-nova01:46
*** rabel has joined #openstack-nova01:46
*** andymccr has joined #openstack-nova01:46
*** hongbin has joined #openstack-nova01:46
*** panda has joined #openstack-nova01:46
*** imacdonn has joined #openstack-nova01:46
*** artom has joined #openstack-nova01:46
*** jiaopengju has joined #openstack-nova01:46
*** penick has joined #openstack-nova01:46
*** SpamapS has joined #openstack-nova01:46
*** mgariepy has joined #openstack-nova01:46
*** d34dh0r53 has joined #openstack-nova01:46
*** yankcrime has joined #openstack-nova01:46
*** NostawRm has joined #openstack-nova01:46
*** tonyb has joined #openstack-nova01:46
*** lennyb has joined #openstack-nova01:46
*** jbernard has joined #openstack-nova01:46
*** jaosorior has joined #openstack-nova01:46
*** _pewp_ has joined #openstack-nova01:46
*** kencjohnston has joined #openstack-nova01:46
*** DinaBelova has joined #openstack-nova01:46
*** larsks has joined #openstack-nova01:46
*** gnuoy has joined #openstack-nova01:46
*** ChanServ has joined #openstack-nova01:47
*** card.freenode.net sets mode: +o ChanServ01:47
*** lbragstad has joined #openstack-nova01:48
*** tristanC has joined #openstack-nova01:48
*** mgagne has joined #openstack-nova01:49
*** Cardoe has joined #openstack-nova01:49
*** Guest10461 has joined #openstack-nova01:49
*** dave-mccowan has joined #openstack-nova01:50
*** hughsaunders has joined #openstack-nova01:52
*** swamireddy has joined #openstack-nova01:52
*** itlinux has joined #openstack-nova01:55
*** mhen has quit IRC01:56
*** mhen has joined #openstack-nova01:59
*** hshiina has joined #openstack-nova02:02
*** tetsuro has joined #openstack-nova02:03
*** sapd1 has joined #openstack-nova02:11
*** takashin has joined #openstack-nova02:11
*** lbragstad has quit IRC02:14
*** trungnv has joined #openstack-nova02:16
*** hoangcx has joined #openstack-nova02:16
openstackgerritJack Ding proposed openstack/nova master: Add I/O Semaphore to limit concurrent disk ops  https://review.openstack.org/60918002:30
openstackgerrithuanhongda proposed openstack/nova master: api-ref: add two tables in the note of DELETE /os-services  https://review.openstack.org/60918602:33
*** psachin has joined #openstack-nova02:57
openstackgerritSam Morrison proposed openstack/nova master: Allow ability for non admin users to list all flavors.  https://review.openstack.org/60847403:03
*** dave-mccowan has quit IRC03:08
*** slaweq has joined #openstack-nova03:11
*** slaweq has quit IRC03:16
openstackgerritBrin Zhang proposed openstack/nova master: Add compute API version for when a ``volume_type`` is requested  https://review.openstack.org/60557303:26
*** hongbin has quit IRC03:30
*** whoami-rajat has quit IRC03:48
*** udesale has joined #openstack-nova03:52
*** Dinesh_Bhor has quit IRC03:58
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (7)  https://review.openstack.org/57199204:04
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (8)  https://review.openstack.org/57199304:05
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py  https://review.openstack.org/56615304:05
openstackgerritSundar Nadathur proposed openstack/nova-specs master: Nova Cyborg interaction specification.  https://review.openstack.org/60395504:27
*** janki has joined #openstack-nova04:29
*** ircuser-1 has quit IRC04:38
*** cfriesen has joined #openstack-nova04:38
*** spsurya has joined #openstack-nova04:44
*** Dinesh_Bhor has joined #openstack-nova04:54
*** ratailor has joined #openstack-nova05:11
*** slaweq has joined #openstack-nova05:11
*** whoami-rajat has joined #openstack-nova05:23
*** ircuser-1 has joined #openstack-nova05:28
*** janki has quit IRC05:53
*** janki has joined #openstack-nova05:54
gmannalex_xu hi, will you be there for  API office hour ?05:55
alex_xugmann: yea05:56
gmanncool,05:56
gmannlet's start06:01
gmann#startmeeting nova api06:02
openstackMeeting started Wed Oct 10 06:02:03 2018 UTC and is due to finish in 60 minutes.  The chair is gmann. Information about MeetBot at http://wiki.debian.org/MeetBot.06:02
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.06:02
*** openstack changes topic to " (Meeting topic: nova api)"06:02
openstackThe meeting name has been set to 'nova_api'06:02
gmann#link https://wiki.openstack.org/wiki/Meetings/NovaAPI#Agenda_for_next_Office_hours06:02
gmannagenda ^^06:02
gmanni have not got the much time to review for couple of weeks.06:03
gmann#topic API Subteam Tracking06:03
*** openstack changes topic to "API Subteam Tracking (Meeting topic: nova api)"06:03
gmann#linkhttps://etherpad.openstack.org/p/stein-nova-subteam-tracking06:03
gmanni added the approved/under review BP related to API on this extherpad06:03
gmannl6306:04
alex_xucurrently we have an api bp in the runway06:04
gmannyeah06:04
gmann#link https://etherpad.openstack.org/p/nova-runways-stein06:05
alex_xuyea, the volume type in boot06:06
alex_xuhow much we left for extension merge?06:07
gmannalex_xu: link https://review.openstack.org/#/q/project:openstack/nova+branch:master+topic:bp/api-extensions-merge-stein+status:open06:07
gmann3-4 patch i will say.06:07
gmanni need to rebase them though06:07
alex_xucool06:07
gmannthis is last patch where i am removing the extensions register logic from wsgi.py - https://review.openstack.org/#/c/607092/06:08
gmannthis is WIP, still mode code to remove06:08
alex_xucool, simpler code06:09
gmannyeah, i will work on those and finish soon06:10
alex_xuthanks06:10
gmannalex_xu: i think we can remove this too - wsgi_action_extensions06:12
*** Dinesh_Bhor has quit IRC06:12
gmanndo you remember  any of action extensions ?06:12
gmannthis one  - https://github.com/openstack/nova/blob/master/nova/api/openstack/wsgi.py#L46806:13
alex_xuhttps://review.openstack.org/#/c/607092/1/nova/api/openstack/compute/routes.py@25206:13
alex_xuwhat benefit we remove it?06:13
gmannhumm, i was thinking for same resource side but these are all separate entry point for resource action06:14
gmannagree to keep them separate.06:15
alex_xustill feel a lot of complex thing in https://review.openstack.org/#/c/607092/1/nova/api/openstack/wsgi.py06:16
gmanntrue, it could be more simpler06:16
alex_xuwithout extension, does this still useful https://review.openstack.org/#/c/607092/1/nova/api/openstack/wsgi.py@8806:17
alex_xugmann: ^ maybe worth to check this in your last patch06:17
alex_xuI remember that is used for cache the response obj for the extension, not sure whether it is used by other place06:17
alex_xugmann: sorry, I mean those cache interface https://review.openstack.org/#/c/607092/1/nova/api/openstack/wsgi.py@9706:18
gmannyeah those were mainly used in extensions code but i can check if anywhere we use them06:19
gmannbut Request object we need06:19
alex_xuyes, we need Req obj06:20
*** adrianc has joined #openstack-nova06:20
gmannalex_xu: quickly grep them and it is only extensions code. i will remove them thanks.06:21
alex_xucool \o/06:22
gmannalex_xu: i will make this patch up by tonight and make it ready for you by tomorrow so that u can check if any more bits we can remove06:22
alex_xugmann: yea, will do06:22
gmannthanks06:23
gmannmoving next06:23
gmannapi cleanup things06:24
gmann#link https://etherpad.openstack.org/p/nova-api-cleanup06:24
gmannand spec which need to include the hypervisor API cleanup - https://review.openstack.org/#/c/603969/06:24
gmannwe need to weight on those with what worth to do and what not06:25
gmannand next question on this is - should we do this in stein ? or wait for T to collect more worthy cleanup ?06:25
gmanni can keep it updated for stein and wait till T if any more related API cleanup. And then we do those in single version bump based on agreement06:27
gmannalex_xu: what u say ?06:27
alex_xupretty sure we won't get rid of all the cleanup in one microversion06:27
alex_xusee the past, how much microversion we spend on deprecate proxy API :)06:27
*** skatsaounis has joined #openstack-nova06:27
gmann:) yeah06:27
alex_xuI will review the spec06:28
gmannall you mean "all listed in etherpad" or all in API (because we do not know them now)06:28
*** Dinesh_Bhor has joined #openstack-nova06:28
alex_xuall in API06:28
gmanntrue, so that's is reason i want to wait till T so that we can cover max.06:28
alex_xumaybe based on the requirement, if there is nothing urgent to change, then we needn't do it very soon06:29
gmannand conclude that "this is we are not going to do" "this is ok to do".  so that these does not comes again in future06:29
gmannyeah06:29
gmanni do not think anything urgent on those but i will also get opinion from mriedem and melwitt06:30
gmannalso06:31
alex_xuI'm afriad another option is microversion shouldn't be huge06:31
gmannhumm06:31
gmanni feel it should not be huge in term of complexity but should be ok in term of numbers.06:32
gmannanyways that we can discuss on spec with exact list of changes06:33
alex_xuyea06:34
gmannanything else on this or we move next ?06:34
alex_xuno more from me06:35
gmannok06:35
gmanni do not have anything else to discuss form API subteam tracking section.06:35
gmannalex_xu: do you have ?06:36
alex_xuno06:36
gmannok06:36
gmann#topic Bug Triage/Discussion06:36
*** openstack changes topic to "Bug Triage/Discussion (Meeting topic: nova api)"06:36
gmann#link https://etherpad.openstack.org/p/nova-api-weekly-bug-report06:36
openstackgerritTetsuro Nakamura proposed openstack/nova-specs master: Spec: Support filtering by forbidden aggregate  https://review.openstack.org/60335206:37
*** janki has quit IRC06:38
gmannthere are 4 new bugs06:38
*** janki has joined #openstack-nova06:38
gmann#link https://bugs.launchpad.net/nova/+bug/178938206:38
openstackLaunchpad bug 1789382 in OpenStack Compute (nova) "openstack server list error" [Undecided,New]06:38
gmannseems timeout from cell ?06:39
alex_xualso see 'TypeError: 'object' object is not iterable' after cell timeout06:40
alex_xucell timeout is just a warning06:41
*** moshele has joined #openstack-nova06:41
*** fanzhang has joined #openstack-nova06:42
alex_xusounds like we handle something wrong06:42
*** Swami has joined #openstack-nova06:42
gmannhumm object is none or something may be06:43
gmannlet me ask more log of api and compute06:44
gmanni did not find any other pointer to debug without those06:45
alex_xuyes06:45
*** helenafm has joined #openstack-nova06:46
*** tssurya has joined #openstack-nova06:47
gmanndone06:49
gmannit seems hitting here - https://github.com/openstack/nova/blob/c6218428e9b29a2c52808ec7d27b4b21aadc0299/nova/compute/multi_cell_list.py#L26506:49
*** pcaruana has joined #openstack-nova06:50
gmann#link https://bugs.launchpad.net/nova/+bug/179613206:50
openstackLaunchpad bug 1796132 in OpenStack Compute (nova) "SSL Verification Error on Launch Instance (queens)" [Undecided,New]06:50
gmann"Seems forcing everythign to https isn't the wisest choice and requires more nova specific ssl config, I'll be going back to using http, so this bug may no longer be valid to work on."06:50
gmanncomments from author ^^06:50
gmannshould we mark it invalid then ?06:52
gmannseems like glance was not on https06:52
gmannSSLError: SSL exception connecting to https://10.5.25.19:9292/v2/images/fd9637fb-57e8-4c43-906:53
alex_xuI don't know, is it configure mistake?06:53
gmannseems so06:54
alex_xui don't familar this part06:54
gmanni will ask on bug is that is solved with all having on https or not06:54
*** Luzi has joined #openstack-nova06:55
*** mdbooth has joined #openstack-nova06:56
gmanndone06:56
gmannit is almost time and other bugs we can do next week or in between of next office hour06:57
alex_xuyes06:57
gmann#topic Open Discussion06:57
*** openstack changes topic to "Open Discussion (Meeting topic: nova api)"06:57
gmannanything else alex_xu you want to discuss otherwise we close for today ?06:57
*** rcernin has quit IRC06:58
alex_xunothing from me06:58
*** zhanglong has joined #openstack-nova06:58
gmannalex_xu: thanks for joining. this really help.06:58
alex_xunp06:58
gmann#endmeeting06:58
*** openstack changes topic to "Current runways: use-nested-allocation-candidates -- This channel is for Nova development. For support of Nova deployments, please use #openstack."06:58
openstackMeeting ended Wed Oct 10 06:58:37 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)06:58
openstackMinutes:        http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-10-10-06.02.html06:58
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-10-10-06.02.txt06:58
openstackLog:            http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-10-10-06.02.log.html06:58
*** tssurya has quit IRC07:01
*** cfriesen has quit IRC07:06
*** mikeoschen has quit IRC07:07
*** vdrok has quit IRC07:07
*** odyssey4me has quit IRC07:07
*** vdrok has joined #openstack-nova07:08
*** ajo has quit IRC07:08
*** odyssey4me has joined #openstack-nova07:08
*** ajo has joined #openstack-nova07:08
openstackgerritMartin Midolesov proposed openstack/nova master: vmware:PropertyCollector for caching instance properties  https://review.openstack.org/60827807:08
*** mugsie has quit IRC07:08
*** mgagne has quit IRC07:09
*** logan- has quit IRC07:09
*** mgagne has joined #openstack-nova07:10
*** jroll has quit IRC07:10
*** janki has quit IRC07:11
*** jiapei has joined #openstack-nova07:11
*** logan- has joined #openstack-nova07:11
*** janki has joined #openstack-nova07:11
*** jroll has joined #openstack-nova07:12
*** ttsiouts has joined #openstack-nova07:12
openstackgerritLucian Petrut proposed openstack/nova master: Fix os-simple-tenant-usage result order  https://review.openstack.org/60868507:14
*** Swami has quit IRC07:22
*** panda has quit IRC07:30
*** helenafm has quit IRC07:32
*** panda has joined #openstack-nova07:32
*** mgagne has quit IRC07:34
*** ttsiouts has quit IRC07:35
*** mgagne has joined #openstack-nova07:36
*** ralonsoh has joined #openstack-nova07:36
*** zhanglong has quit IRC07:39
*** zhanglong has joined #openstack-nova07:40
*** hoonetorg has joined #openstack-nova07:42
*** alexchadin has joined #openstack-nova07:50
*** jchhatbar has joined #openstack-nova07:51
*** janki has quit IRC07:52
*** jchhatbar has quit IRC07:53
*** janki has joined #openstack-nova07:53
*** maciejjozefczyk has joined #openstack-nova07:55
*** ttsiouts has joined #openstack-nova07:59
*** k_mouza has joined #openstack-nova07:59
*** Dinesh_Bhor has quit IRC08:01
*** janki has quit IRC08:01
*** bhagyashris__ has joined #openstack-nova08:01
*** janki has joined #openstack-nova08:01
*** ttsiouts has quit IRC08:05
*** ttsiouts has joined #openstack-nova08:08
*** janki has quit IRC08:10
*** zhanglong has quit IRC08:13
*** ociuhandu has joined #openstack-nova08:13
*** zhanglong has joined #openstack-nova08:14
*** ttsiouts has quit IRC08:14
*** rpittau has joined #openstack-nova08:18
*** ttsiouts has joined #openstack-nova08:21
*** logan- has quit IRC08:23
*** alexchadin has quit IRC08:25
*** logan- has joined #openstack-nova08:27
*** jangutter has quit IRC08:32
*** jangutter has joined #openstack-nova08:33
*** derekh has joined #openstack-nova08:33
*** jangutter has quit IRC08:37
*** ygk12345 has joined #openstack-nova08:37
*** jangutter has joined #openstack-nova08:37
ygk12345hi all08:38
ygk12345I am unable to unshelve an instance whihc is in shelve offload state08:38
bauzasygk12345: stack trace ?08:39
openstackgerritBrin Zhang proposed openstack/nova master: Add microversion 2.67 to support volume_type  https://review.openstack.org/60639808:39
ygk12345the instance is still in shelved state and in shutdown state08:40
ygk12345bauzas: it is mitaka08:40
ygk12345bauzas: I dont see any hypervisor allocated to it08:41
ygk12345bauzas: DEBUG (session:277) RESP: [404] Date: Wed, 10 Oct 2018 08:41:47 GMT Content-Length: 52 Content-Type: text/plain; charset=UTF-8 X-Compute-Request-Id: req-f192f22e-9cd9-4b41-9863-c9752acbf95f RESP BODY: 404 Not Found  The resource could not be found.08:42
ygk12345bauzas: is it deleted ?08:42
bauzasygk12345: do you have an ERROR log when unshelving?08:46
*** tetsuro has quit IRC08:46
ygk12345no08:46
ygk12345it is saying  "resource could not be found" in the debug output08:47
*** hshiina has quit IRC08:49
bauzasygk12345: what tells you the os-instance-actions API ?08:49
openstackgerritBrin Zhang proposed openstack/nova master: Add restrictions on ``updated_at`` when getting migrations  https://review.openstack.org/60779808:51
*** paiboinaritesh has joined #openstack-nova08:53
openstackgerritBrin Zhang proposed openstack/nova master: Add restrictions on ``updated_at`` when getting instance action records  https://review.openstack.org/60780108:55
openstackgerritBrin Zhang proposed openstack/nova master: Add restrictions on ``updated_at`` when getting migrations  https://review.openstack.org/60779808:56
*** belmorei_ has joined #openstack-nova08:57
openstackgerritBalazs Gibizer proposed openstack/nova-specs master: Remove force flag from live-migrate and evacuate  https://review.openstack.org/60933008:58
*** belmoreira has quit IRC09:00
*** k_mouza has quit IRC09:01
*** brinzhang has joined #openstack-nova09:03
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge used_limits extension response into limit view builder  https://review.openstack.org/60603109:07
*** alexchadin has joined #openstack-nova09:07
openstackgerritGhanshyam Mann proposed openstack/nova master: Merge image_size extension response into image view builder  https://review.openstack.org/60684509:07
openstackgerritGhanshyam Mann proposed openstack/nova master: Remove more code related to extensions and testing  https://review.openstack.org/60708809:08
*** sambetts_ is now known as sambetts|afk09:10
*** Dinesh_Bhor has joined #openstack-nova09:12
*** k_mouza has joined #openstack-nova09:14
*** k_mouza has quit IRC09:17
*** k_mouza has joined #openstack-nova09:17
*** k_mouza has quit IRC09:20
*** bhagyashris__ has quit IRC09:21
openstackgerritGhanshyam Mann proposed openstack/nova master: [WIP]Remove extensions loading framework from wsgi.py  https://review.openstack.org/60709209:21
openstackgerritYikun Jiang proposed openstack/nova-specs master: Support initial allocation ratios  https://review.openstack.org/55210509:35
*** jarodwl has joined #openstack-nova09:39
*** ygk12345 has quit IRC09:41
*** mikeoschen has joined #openstack-nova09:43
*** adrianc has quit IRC09:47
*** imacdonn has quit IRC09:52
*** adrianc has joined #openstack-nova09:52
*** imacdonn has joined #openstack-nova09:52
*** lpetrut has joined #openstack-nova09:53
*** mvkr has quit IRC10:01
openstackgerritStephen Finucane proposed openstack/nova master: docs: Don't configure '[scheduler] discover_hosts_in_cells_interval'  https://review.openstack.org/60934510:10
openstackgerritStephen Finucane proposed openstack/nova master: conf: Deprecate the 'discover_hosts_in_cells_interval' option  https://review.openstack.org/60934610:10
gmannalex_xu: do you remember any case where we extended the response of action class with @wsgi.extends(action ?10:16
gmannalex_xu: this case - https://github.com/openstack/nova/blob/6bf11e1dc14afad78b11d980c2544a3dc41579ff/nova/api/openstack/wsgi.py#L77210:17
gmannalex_xu: because that is what populate self.wsgi_action_extensions  - https://github.com/openstack/nova/blob/6bf11e1dc14afad78b11d980c2544a3dc41579ff/nova/api/openstack/wsgi.py#L48910:17
gmannalex_xu: this list goes as action (self.wsgi_action) - https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/routes.py#L26610:18
gmannalex_xu: so we are good to remove the self.wsgi_action_extensions too along with self.wsgi_xtensions.10:19
*** ttsiouts has quit IRC10:20
*** zhanglong has quit IRC10:23
*** Dinesh_Bhor has quit IRC10:25
*** ttsiouts has joined #openstack-nova10:32
*** dave-mccowan has joined #openstack-nova10:32
*** mvkr has joined #openstack-nova10:38
*** Dinesh_Bhor has joined #openstack-nova10:42
*** priteau has joined #openstack-nova10:45
*** belmorei_ has quit IRC10:46
*** belmoreira has joined #openstack-nova10:47
*** paiboinaritesh has quit IRC10:50
alex_xugmann: I thought wsgi_action_extensions is for the whole action?10:51
alex_xunot just the response of the action10:51
*** ttsiouts has quit IRC10:53
*** ttsiouts has joined #openstack-nova10:53
alex_xugmann: I think you are right10:55
alex_xugmann: we don't need 'register_extensions' method at all10:55
gmannalex_xu: yea.10:57
*** ttsiouts has quit IRC10:58
*** jpena|off has quit IRC10:58
*** takashin has left #openstack-nova11:01
openstackgerritTakashi NATSUME proposed openstack/nova master: Use oslo_db.sqlalchemy.test_fixtures  https://review.openstack.org/60935211:02
*** alex_xu has quit IRC11:09
*** udesale has quit IRC11:11
*** alex_xu has joined #openstack-nova11:13
*** Dinesh_Bhor has quit IRC11:14
*** dtantsur|afk is now known as dtantsur11:16
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: [DNM] test linux pytoute impl  https://review.openstack.org/60935411:17
*** ttsiouts has joined #openstack-nova11:17
*** aspiers has joined #openstack-nova11:18
*** k_mouza has joined #openstack-nova11:20
*** k_mouza has quit IRC11:25
*** ratailor has quit IRC11:33
*** spatel has joined #openstack-nova11:55
aspiersmelwitt: following on from my colleague JP's discussion with nova folks at the PTG regarding adding AMD SEV support to nova, I've done a bunch of research regarding possible implementations and am writing a spec and bp which I hope to submit very shortly. Thought I'd give you a heads-up just in case there's anything you'd like to discuss.11:59
*** spatel has quit IRC11:59
*** alexchadin has quit IRC12:00
*** alexchadin has joined #openstack-nova12:01
*** brinzhang has quit IRC12:02
*** belmoreira has quit IRC12:05
*** belmoreira has joined #openstack-nova12:08
*** k_mouza has joined #openstack-nova12:09
*** k_mouza has quit IRC12:13
*** adrianc has quit IRC12:13
*** tbachman has joined #openstack-nova12:38
*** cfriesen has joined #openstack-nova12:39
*** udesale has joined #openstack-nova12:45
*** jaypipes has joined #openstack-nova12:47
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Time how long select_destinations() takes in conductor  https://review.openstack.org/60857512:53
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Replace usage of get_legacy_facade() with get_engine()  https://review.openstack.org/60857412:54
mikeoschenjoin #openstack-sdks12:54
openstackgerritGhanshyam Mann proposed openstack/nova master: Remove the extensions framework from wsgi.py  https://review.openstack.org/60709212:57
*** mriedem has joined #openstack-nova12:58
pooja_jadhavhi team, how I can create a BFV instance in the api-sample-tests for testing. please guide me for the same.13:04
*** mvkr has quit IRC13:05
pooja_jadhavI am referring https://github.com/openstack/nova/blob/85b36cd2f82ccd740057c1bee08fc722209604ab/nova/tests/functional/api_sample_tests/api_samples/servers/v2.42/server-create-req.json.tpl13:05
pooja_jadhavfor creating an instance. but compute_utils. is_volume_backed giving False for the instance.13:07
*** mdbooth has quit IRC13:08
pooja_jadhavgmann: ^^13:11
gmannpooja_jadhav: oh, that did not work ?13:13
pooja_jadhav gmann: unfortunately, no :(13:14
*** mdbooth has joined #openstack-nova13:14
mriedemyou'd have to use the cinder fixture for one thing13:14
pooja_jadhavgmann: can u plz tell me.. which existing json.tpl should I use to create a BFV instance??13:15
mriedemhttps://github.com/openstack/nova/blob/85b36cd2f82ccd740057c1bee08fc722209604ab/nova/tests/functional/api_sample_tests/api_samples/servers/v2.42/server-create-req.json.tpl isn't going to work since the cinder fixture doesn't create volumes13:15
*** k_mouza has joined #openstack-nova13:15
*** jdillaman has quit IRC13:15
gmanni suggest to write funtional test for that instead of sample tests13:15
mriedemsee how https://github.com/openstack/nova/blob/85b36cd2f82ccd740057c1bee08fc722209604ab/nova/tests/fixtures.py#L1583 is used in functional tests13:16
mriedeme.g. https://review.openstack.org/#/c/608771/13:16
*** eharney has joined #openstack-nova13:20
Luzihey Nova, we've written the Spec for Image Encryption for Nova and would appreciate reviews :) https://review.openstack.org/#/c/608696/13:21
pooja_jadhavmriedem, gmann: thanks will look into this13:21
gmannmriedem: yeah, pooja_jadhav tried to add the create volumes stub there13:22
janguttersean-k-mooney, jaypipes: I'm looking at https://github.com/openstack/os-vif/blob/master/os_vif/objects/host_info.py and I've got some questions. (will post them to the room in general)13:22
sean-k-mooneyjangutter: sure go for it13:22
jaypipesI blame sean-k-mooney.13:22
stephenfinsean-k-mooney: I wonder if we should be setting 'model' here for SR-IOV VIFs? https://github.com/openstack/nova/blob/6bf11e1dc14afad78b11d980c2544a3dc41579ff/nova/virt/libvirt/vif.py#L130-L13313:22
gmannpooja_jadhav: mriedem i feel normal functional tests make more sense to verify the compute_utils. is_volume_backed instead of api sample tests13:23
gmannlike example mriedem mentioned13:23
jangutterfor the host_info objects, there's a mechanism to filter vif types by name and version, but not a corresponding mechanism for port_profiles.13:23
openstackgerritGhanshyam Mann proposed openstack/nova master: Remove the caching the resource on Request object  https://review.openstack.org/60940313:23
openstackgerritGhanshyam Mann proposed openstack/nova master: Remove more code related to extensions and testing  https://review.openstack.org/60708813:23
sean-k-mooneystephenfin sorry taught that message was from jangutter am in what context13:23
openstackgerritGhanshyam Mann proposed openstack/nova master: Remove the extensions framework from wsgi.py  https://review.openstack.org/60709213:24
stephenfinsean-k-mooney: If we do and that hw_vif_model==virtio, we'll undo the hard work of https://github.com/openstack/nova/commit/622ebf2fab0a9bf75ee12437bef28f60e083f849 right?13:24
openstackgerritYikun Jiang proposed openstack/nova-specs master: Support initial allocation ratios  https://review.openstack.org/55210513:24
sean-k-mooneyjangutter: yes currently nothing uses the filter. it was there for future use but its still in the future13:24
sean-k-mooneyjangutter: so we can extend it13:24
stephenfinsean-k-mooney: Heh, yeah, two people talking about related stuff is confusing :) I'll test this myself in a bit. Just sanity checking13:24
gmannalex_xu: mriedem melwitt this complete the API extensions merge work - https://review.openstack.org/#/q/topic:bp/api-extensions-merge-stein+status:open13:25
mriedempooja_jadhav: gmann: i'm not sure why we need a new functional test for bfv?13:25
sean-k-mooneywell if you set hw_vif_model=Anything we shoudl respect that13:25
mriedemwe have existing functional tests that cover that flow13:25
mriedemincluding the patch i just linked to you13:25
gmanni will check the gate if any tests i need to fix otherwise it is good to go13:26
sean-k-mooneystephenfin: but i need to check both patches to see how they interact13:26
mriedemgmann: ack on the api extension merge series - if you haven't, you should queue that up in a runway13:26
janguttersean-k-mooney, jaypipes: (host_info context) right, so there's two ways of doing a check like this. the 'naive bayes' way, or the really explode the dependencies way.13:26
*** jdillaman has joined #openstack-nova13:26
gmannmriedem: right, those should work untill pooja_jadhav trying anything special or new feature (that is not up for review so not sure)13:26
pooja_jadhavmriedem:  I am writting in api-sample-test for (if instance is BFV, then local_gb_used should be 0 in in the simple tenant usage api)13:26
sean-k-mooneystephenfin: if your asking should we remove https://github.com/openstack/nova/blob/6bf11e1dc14afad78b11d980c2544a3dc41579ff/nova/virt/libvirt/vif.py#L130-L133 the answer is no but we may need to adapt the queue size patch13:27
pooja_jadhavmriedem, gmann : https://bugs.launchpad.net/nova/+bug/171557013:27
openstackLaunchpad bug 1715570 in OpenStack Compute (nova) "simple tenant usage api calculating disk usages incorrectly" [Medium,In progress] - Assigned to Bhagyashri Shewale (bhagyashri-shewale)13:27
janguttersean-k-mooney, jaypipes: (host_info context) the difference comes in, are you going to ever worry about a case where VIFobject 1.0 supports PortProfile 1.0 and not 2.0?13:27
jaypipesjangutter: the host_info should be able to communicate to Neutron's agents exactly the kinds of VIFs that it can plug. If that means we need to pass some additional information about port profiles supported by the host, so be it.13:27
sean-k-mooneyjaypipes: we should but we dont currently13:28
gmannmriedem: added13:28
jaypipesjangutter: if that makes a difference to what Neutron negotiates with the host, then yes...13:28
*** k_mouza has quit IRC13:28
jangutterjaypipes: (host_info context) it's similar to the question: does the base object need to bump its version if any of the members bump up a version?13:29
mriedempooja_jadhav: we don't need to use an api sample test for that bug13:29
sean-k-mooneyjangutter: unfortunetly no. i think it should be we do not bump for compostion13:29
jaypipesjangutter: no13:29
mriedempooja_jadhav: a simple functional test which creates a volume-backed server and then queries the simple tenant usage API to assert it's showing disk usage when it shouldn't should suffice13:30
jaypipesjangutter: but see my comment on the datapath offload port profile patch that you shouldn't be modifying the VIFPortProfileBase object like that.13:30
pooja_jadhavmriedem: but existing tests for simple tenant usage api are in api sample tests.13:30
mriedempooja_jadhav: that doesn't really matter13:30
sean-k-mooneyjangutter: if you add a filed to base then you bump the version of all the derived types too13:30
pooja_jadhavmriedem: okies13:30
jangutterjaypipes: yep, that's revving because of inheritance, another story.13:30
sean-k-mooneyjangutter: so bump for inheritance changes but not for composition13:30
jaypipessean-k-mooney: that's not true any more AFAIK.13:30
mriedempooja_jadhav: something like the setup in https://review.openstack.org/#/c/608771/ should be most of the work,13:31
mriedemthen it's just querying the simple tenant usage API and asserting the results13:31
sean-k-mooneyjaypipes: it better be or we are screwed13:31
*** awaugama has joined #openstack-nova13:31
pooja_jadhavmriedem: yeah.. thanks13:31
mriedempooja_jadhav: we could just put the test patch on top of ^ to re-use the same setup13:31
mriedemi can try that quick13:31
jaypipessean-k-mooney: the version manifest tracks versions for sub-classes separately from the base classes, meaning you don't need to bump the sub-class versions when a base version increases.13:32
sean-k-mooneyjaypipes: correct but if we dont then adding a filed to the base mean the derived has a new filed also and no version bump13:32
sean-k-mooneysimilary if we remove a filed form the base that filed goes away in the derived without a version bump and we are similarly screwed13:33
jaypipessean-k-mooney: the derived version is only indicating the version of the derived-specific fields.13:33
jaypipesdansmith: you up yet? :)13:33
sean-k-mooneyjaypipes: no its indicating the version fo the whole object if not then its not safe to inherit OVOs13:34
dansmithjaypipes: yes13:34
*** mchlumsky has joined #openstack-nova13:34
jaypipesdansmith: we are discussing whether it is required to bump derived class object versions if a base versions is incremented.13:34
jangutterjaypipes, sean-k-mooney: If you don't bump because of composition, then you can flatten out the list of objects, regardless of how which members they belong to.13:34
dansmithjaypipes: if you change something in the base, you've changed it in the sub and the hash should change (thus need a version bump) IIRC13:35
sean-k-mooneydansmith: that is my understanding too.13:35
dansmithjaypipes: _simply_ changing the master version shouldn't require a child bump, but there would be no reason13:35
jaypipesdansmith: oh, am I confusing the composition rules with inheritance rules?13:35
stephenfinsean-k-mooney: Nope. Rather, we just should make that if conditional on whether we're requesting SR-IOV VIFs or not13:35
jangutterjaypipes, sean-k-mooney: I mean then you don't need to specifically associate _which_ VIF and which port-profile object/version combination go together, you just need to check if you understand each object/version combination separately.13:35
dansmithjaypipes: I think you're confusing how including an object in another object used to require lockstep versioning, but that isn't the case any more13:35
sean-k-mooneystephenfin: nope for macvtap i think you can set the model13:36
jaypipesdansmith: right. I was confusing composition rules with inheritance rules. sorry (again) :(13:36
stephenfin*SR-IOV direct13:36
sean-k-mooneystephenfin: im also not sure if that assumtion is safe to make but it might be13:36
pooja_jadhavmriedem: Let me try if u dont mind?13:37
stephenfinmoshele: Any thoughts on the above?13:37
stephenfinmoshele: tl;dr: I wonder if we should be setting 'model' here for SR-IOV VIFs? https://github.com/openstack/nova/blob/6bf11e1dc14afad78b11d980c2544a3dc41579ff/nova/virt/libvirt/vif.py#L130-L13313:37
sean-k-mooneydansmith: right but if the composed object version change how we make object compatible today is actully inccorect13:37
stephenfinmoshele: If we do and that hw_vif_model==virtio, we'll undo the hard work of https://github.com/openstack/nova/commit/622ebf2fab0a9bf75ee12437bef28f60e083f849 I think13:37
stephenfinmoshele: SR-IOV direct VIFs, that is13:38
jangutterdansmith: if you use composition, would it make sense to check a list of classes and versions for compatibility, or would you need to check the combinations?13:38
*** lbragstad has joined #openstack-nova13:38
sean-k-mooneystephenfin: you can have VF that are virtio just an FYI13:38
dansmithsean-k-mooney: I don't understand what you're saying13:38
dansmithjangutter: heh, I'm also not sure what you mean13:39
dansmithpoint me at code?13:39
jangutterdansmith: let me set up a quick etherpad?13:39
moshelestephenfin: sorry I don't follow13:39
dansmithyah13:40
sean-k-mooneydansmith: if you look at https://github.com/openstack/nova/blob/6bf11e1dc14afad78b11d980c2544a3dc41579ff/nova/objects/migrate_data.py#L243-L270 we call support with the target version fo the derived but that may not corralate to a target version of the base13:40
jaypipesdansmith: they are wondering how the versioning system works when you have an ObjectField field...13:40
jaypipesdansmith: and if the version of the ObjectField changes, why the base doesn't need to change.13:40
stephenfinmoshele: In https://github.com/openstack/nova/commit/622ebf2fab0a9bf75ee12437bef28f60e083f849 a check was added to ensure we don't see RX/TX queue sizes for non-virtio interfaces13:40
jangutterjaypipes, sean-k-mooney, dansmith: https://etherpad.openstack.org/p/ovo-versioning13:41
dansmithjaypipes: oh, because we send a manifest.. a list of object names and versions.. for rpc13:41
sean-k-mooneyjaypipes: yes. and in the past we used to have a verion map thing that track the version fo the object fileds and  what version the correspondeed to13:41
dansmithwell, when we backport, we do that13:41
stephenfinI'm thinking it's possible we could break the check if a user sets 'hw_vif_type=virtio' in image metadata. If they do that, then this line will be true13:41
stephenfinhttps://github.com/openstack/nova/blob/6bf11e1dc14afad78b11d980c2544a3dc41579ff/nova/virt/libvirt/vif.py#L15613:42
sean-k-mooneydansmith: that is part of my argument as to why we should version for compoltion and inheritenc but since the has does not change for compostion versiosn its not enforece by our tests13:43
dansmithsean-k-mooney: yeah that was a total disaster13:43
stephenfinwhich wouldn't be the case normally because this line would be false for direct https://github.com/openstack/nova/blob/6bf11e1dc14afad78b11d980c2544a3dc41579ff/nova/virt/libvirt/vif.py#L13713:43
dansmithsean-k-mooney: it doesn't need to change13:43
sean-k-mooneydansmith: the lockstep stuff. it was a pain but it worked13:43
dansmithsean-k-mooney: it was unnecessary for us13:43
stephenfinmoshele: If that makes sense? I'm just thinking it's a latent bug. I'll test myself but doing so requires me setting up an environment :)13:43
dansmithmaybe for you because you don't have the same communication we have between nodes13:43
sean-k-mooneydansmith: it maye if version 1 of my containing clase used version 1 of a composed calss and version 2 of the conatine uses version 5 then downgrading the containing class to 1 results in it having an object filed of 513:44
moshelestephenfin: not sure, but you maybe right here13:44
dansmithsean-k-mooney: yep, which is fine, because the objects are forward compatible13:45
mriedemgibi: i'm late to this party but a few comments inline https://review.openstack.org/#/c/609330/13:45
dansmithsean-k-mooney: and if there's some reason, the containing class can downlevel the version it has13:45
mriedemi haven't read the ML thread yet13:45
mriedempooja_jadhav: go ahead13:46
sean-k-mooneydansmith: today we dont track that it should down level the object filed to 2 when it downlevels to 1 which is the gap13:46
moshelestephenfin: please update me with your result13:46
stephenfinmoshele: Yup, will open a bug if it's an issue13:47
dansmithsean-k-mooney: we don't backlevel it if and only if the requesting party says that they support version 5 of the sub object13:47
sean-k-mooneydansmith: its totally solveable in the make_compatible function just we dont enforce it today and we should when we start passing os-vif objects over the api13:47
dansmithsean-k-mooney: which wouldn't happen, and thus we'd backport both13:47
gibimriedem: you are not late at all13:47
dansmithsean-k-mooney: sure we don't enforce it13:48
moshelestephenfin: is  'hw_vif_type=virtio' in image metadata per network interface?13:48
dansmithsean-k-mooney: that's why I'm saying if you are making objects where that matters, then you can backlevel it13:48
stephenfinmoshele: I don't think so. I don't see how it could be13:48
sean-k-mooneydansmith: this isnt in relation to RPC by they way. this is relation to passing os-vif object betwen nova an neutron via the rest api13:48
stephenfinmoshele: Assuming you mean can it be configured per interface. I assume it affects all network interfaces13:48
moshelestephenfin: I see, so we need to ignore it or reject it13:49
dansmithsean-k-mooney: I know that, which is why I said you may have less flexibility because you don't control the communication in the same way13:49
stephenfinFor direct SR-IOV, I would imagine13:49
sean-k-mooneydansmith: sure. we have added code in the past to do this and taken it out as part of code review because it did not go over rpc13:49
dansmithsean-k-mooney: fwiw, the relation mapping stuff is all still in o.vo because it's a library, so you can use it if you really think it's necessary13:49
moshelestephenfin: for VNIC_TYPES_DIRECT_PASSTHROUGH13:49
stephenfinmoshele: yeah13:49
sean-k-mooneydansmith: ya we can but its also easy to do this in the make compatible fuction without that13:50
sean-k-mooneyjangutter: does any of this help?13:50
openstackgerritsean mooney proposed openstack/os-vif master: add support for generic tap device plug  https://review.openstack.org/60238413:51
openstackgerritsean mooney proposed openstack/os-vif master: clean up ip_command interface  https://review.openstack.org/60941413:51
janguttersean-k-mooney: I'm still downleveling the conversation to the simple version I can understand :-p13:51
gibimriedem: good point about the pre 2.29 and pre 2.30 microversion. I have to think that through.13:52
mriedemgibi: i don't see operators on this thread either in the ML...has anyone reached out to the ops community to see if they are cool with dropping support for the force parameter? and if not, why not.13:52
gibimriedem: bauzas forwarded it to the ops I think13:53
mriedemalthough as noted you can still use the force flag with the older microversion, or use 2.113:53
dansmithjangutter: so you might be assuming there's more magic going on here than there is13:53
mriedemthis spec is really just about signaling13:53
mriedemlike when we deprecated personality files13:53
dansmithjangutter: you can't define that a field is an object at (or below or above) a particular version13:53
bauzasgibi: mriedem: yup but no answers yet13:53
bauzasgibi: and I asked you about two separate microversions in the change13:53
jangutterdansmith: right, this comes into play when serializing13:53
dansmithjangutter: within a scope, it's assumed that you support a set of object schemas (by name) at a particular version, with compatibility for older versions13:53
mriedembauzas: no one but you wants 2 microversions for this13:53
gibibauzas: it seems to me that others more like having a single microversion instead13:54
mriedem2 microversions for the same thing is excessive13:54
mriedemas efried noted in the spec review, we don't do multiple microversions for something just because it touches multiple APIs13:54
dansmithjaypipes: so when we serialize today, we have the object and a list of versions that the other side supports, and we backlevel everything in the tree to the versions they support, as needed13:54
dansmither jangutter ^13:54
mriedemotherwise i would have had multiple microversions for volume multiattach and removing personality files13:54
dansmithjangutter: if you don't have that manifest of supported versions, then you'd have to make inferences based on the version of the parent you're pinned to, which is what we used to do13:55
dansmithjangutter: like this: https://github.com/openstack/nova/blob/kilo-eol/nova/objects/instance.py#L25713:55
dansmithjangutter: if you set those up on your object then o.vo will still respect them13:55
jangutterdansmith: yep. the trick comes when downlevelling an object that has members containing other objects which are versioned.13:55
dansmithjangutter: right, but that's what this obj_relationships is for13:56
sean-k-mooneydansmith: that is assume that the latest version of each object both side knows about is the desired version correct13:56
dansmithjangutter: note that it specifies which versions the contains-another-object fields refer to13:56
bauzasmriedem: gibi: okay, just the fact that we had 2 different versions previously (2.29 and 2.30)13:56
jangutterdansmith: I've seen that mapping, the question is, do we need/want it in os-vif?13:56
dansmithsean-k-mooney: it means within a scope you don't randomly upgrade one object and not another yeah13:57
dansmithsean-k-mooney: which is what this was designed to do, not for "I loaded a new plugin which loaded one new object into a sea of older ones"13:57
sean-k-mooneydansmith: right...  so we might have to deal with the lather in os-vif but perhaps we dont13:58
dansmithyeah I dunno13:58
mriedembauzas: we had 2 different versions previously because of all the related plumbing those required13:58
mriedemthis is a simple schema change13:59
sean-k-mooneydansmith: did any of this impact out of tree virt drivers on the nova side? or are all the OVOs managed above the virt dirver level13:59
bauzasmriedem: okay, fair then13:59
dansmithsean-k-mooney: we don't support out of tree virt drivers13:59
*** tbachman has quit IRC13:59
sean-k-mooneydansmith: :) well thats one answer. but i think we are still fine. plugins are not allowed to provide vif types or profiles they can only consume them so i think we wont have the mixed case14:00
dansmithoh okay I thought that was the point of os-vif14:00
dansmithbut cool if not14:00
sean-k-mooneyplugins can consume the datamodels but not extend them14:01
sean-k-mooneydansmith: that said kuryr-kubernetes are violating that contract https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/objects/vif.py14:02
mriedembauzas: i think you wanted to copy the ops list but didn't14:03
mriedem"adding openstack-operators@ accordingly."14:03
mriedemthe ops list isn't on copy14:03
sean-k-mooneydansmith: i told them that this was not be supported a few cycles ago and we will be moving those vif types before nova and neutron start useing os-vif objects to negociate bindings14:03
mriedemoh i see, "Shit, I forgot to add openstack-operators@..."14:03
bauzasmriedem: I had a problem with my other gmail address14:03
bauzashence the three emails14:03
*** tbachman has joined #openstack-nova14:03
* bauzas hides14:04
bauzashopefully the single ML address will simplify it14:04
dansmithsean-k-mooney: ack14:04
jangutterdansmith, sean-k-mooney, jaypipes: thanks very much for this discussion, I think it might be a good time to explicitly fix os-vif into the simpler model rather than allowing a possible version explosion.14:06
sean-k-mooneyjangutter: im not sure how you would do that14:07
jaypipesjangutter: well, since nothing yet uses the object-over-http I wouldn't mind keeping all the versions at 1.0 at this point.14:08
sean-k-mooneyi dont think its partacally complex14:08
jaypipesbut I need to run away now for a half hour. back soon.14:08
*** munimeha1 has joined #openstack-nova14:08
sean-k-mooneyjaypipes: we proably can make the all 1 but i would be fine to bump them all to 2.0 or something wehn we use them over http14:09
jaypipessean-k-mooney: ++14:09
jaypipessean-k-mooney: and after the version manifest stuff is added in...14:09
sean-k-mooneyjaypipes: yes assuming that is needed14:11
sean-k-mooneywe will need to document all this in a spec in any case14:11
*** dtantsur is now known as dtantsur|brb14:13
mriedemgibi: jaypipes: bauzas: efried: i'm all caught up on that ML thread,14:14
mriedemreplies inline,14:14
mriedemtl;dr i agree with jay on failing hard if the source has nested allocatoins and we're being forced14:14
efried++14:15
bauzasyup, +114:15
mriedemforce predates these exotic topologies14:15
bauzasif they really want to migrate, just don't force14:15
mriedemand we shouldn't attempt to support it14:15
bauzasso, first they force, and if they get a non-accepted migration, they could just not force14:15
bauzaswhich looks good to me14:15
mriedemright14:16
sean-k-mooneymriedem: taking that one step futher thw will mean eventually force will never work as at some point all compute nodes will be nested14:16
gibimriedem: so do we all agree that moving from nested to flat is OK to fail even if it would succeed in placement?14:16
mriedemthe one case i can see for using force is what bauzas mentioned in the thread, which is you disable a compute so new instances can't go there, meanwhile rebalancing by forcing things there via live migrate14:16
*** alexchadin has quit IRC14:16
mriedemgibi: that would only succeed in the case that the dest host is not upgraded and reshaped yet14:17
mriedemright?14:17
gibimriedem: right14:17
mriedemso it's a narrow window where we might get lucky and it works14:17
janguttersean-k-mooney: one way of doing this is to explicitly ignore relationships established by composition - in other words, you assume that a particular plugin will not require distinct port_profile versions for different vifs that it supports.14:17
mriedemso i don't care about supporting that14:17
gibimriedem: yes14:17
gibimriedem: OK14:17
* gibi changing in flight implementation :)14:17
mriedemsean-k-mooney: yes i'm ok with that14:17
bauzasmriedem: for the disabled host, they can still call the scheduler14:17
bauzasmriedem: but yeah the computefilter will then return no14:18
mriedembauzas: the ComputeFilter will reject it14:18
mriedemright14:18
sean-k-mooneymriedem: i know :) so am i force is a pain in the ass. but where i was going with this is shoudl we consider deprecating force14:18
mriedemsean-k-mooney: that's gibi's spec14:18
mriedemhttps://review.openstack.org/#/c/609330/114:18
bauzasmriedem: actually I guess that's probably why force_hosts on boot doesn't run on filters14:18
bauzasmriedem: but we shouldn't really skip all filters, just the compute one14:18
sean-k-mooneymriedem: oh :)14:19
sean-k-mooneyjangutter: ya i can see jsut removing the version info in general that said it may be useful to keep jsut so we can say this is the newest version i supprot to nova/neutron14:19
bauzasmriedem: jaypipes: gibi: actually, hold on14:19
bauzasI think the usecase I said for force is still needed for operators :(14:20
* gibi is holding on14:20
bauzasbecause they probably want to migrate instances to some disabled compute14:20
janguttersean-k-mooney: you can still keep port_profiles versioned, but you don't require the combination mapping.14:20
sean-k-mooneyjangutter: so in teh host info obejct jsut filter by name not by version, but keep version in the object to say i know about at most version x of this object14:20
*** k_mouza has joined #openstack-nova14:20
sean-k-mooneyjangutter: yep14:20
sean-k-mooneybauzas: but why do we want to supprot that14:21
sean-k-mooney they may but it instead of using disabled to reserve a host for mainainace would it not be better to have a maintanace availablity zone they could move the host into14:22
bauzassean-k-mooney: I guess operators want to migrate some instances from some host because for example the RAID situation is bad14:22
sean-k-mooneybauzas: well migrating from a disable host is fine14:22
bauzassean-k-mooney: but then they want to migrate to a single host which is exactly like the source one for all the instances14:23
sean-k-mooneybauzas: migrating too a disable host i think is strange14:23
bauzassean-k-mooney: because of capacity I guess14:23
bauzasgibi: either way, I think we need to be super clear in the spec that this usecase won't be possible once we remove the force field in a microversion14:24
mriedembauzas: force_hosts on boot still goes through the filters14:24
bauzasmriedem: not thru the filters14:24
bauzasmriedem: thru the filter scheduler yep14:24
bauzasbut then it says "all good"14:24
bauzasand then returens14:24
bauzasreturns14:24
mriedemshow me the code14:24
*** mlavalle has joined #openstack-nova14:24
*** k_mouza has quit IRC14:25
sean-k-mooneybauzas: your refing to when you use --availability-zone ZONE:HOST right14:25
gibibauzas: I can make it clear in the spec that force migration or force evacuating to the disable destination will not work as scheduler's ComputeFilter will reject that host14:25
sean-k-mooneywhich adds the force flag an just check the availablity zone and host exits then skips all the filters14:25
bauzasmriedem: https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L58914:25
mriedemyup just found that14:26
mriedemhuh i didn't realize14:26
openstackgerritStephen Finucane proposed openstack/nova master: conf: Deprecate the 'discover_hosts_in_cells_interval' option  https://review.openstack.org/60934614:26
*** spatel has joined #openstack-nova14:26
mriedembauzas: "I think we need to be super clear in the spec that this usecase won't be possible once we remove the force field in a microversion" isn't accurate14:27
mriedemyou can still hit the force code with the older microversions14:27
mriedemand osc's default behavior14:27
bauzasmriedem: okay, I wasn't clear14:27
bauzasI meant "microversions >2.XX won't support this usecase now"14:27
gibimriedem, bauzas: but that old code won't work for nested allocatons14:27
mriedemgibi: yeah i left a comment on that in the spec just now, and added mnaser and tobias from city network (public cloud SIG chair)14:27
mriedemgibi: agree14:28
mriedemi know mnaser does the rebalance dance,14:28
bauzasmriedem: both are in OSDN AFAIK14:28
mriedemi just don't know if he disables computes before doing so14:28
bauzasat least that's what twitter claims :)14:28
gibisooo, the operators will use the force case totally as soon as the allocations are nested14:28
gibiregardless of microversion14:28
sean-k-mooneymriedem: have we increased the minium microverion by the way since we started using them.14:28
mriedemno we don't do that14:28
gibis/use/lose/14:28
sean-k-mooneymriedem: so we will always effectly have to support force then as you can always use an old microverion ?14:29
mriedemuntil everything is nested14:29
gibisean-k-mooney: we could not suppor force for nested allocations14:29
mriedemwhich is whenever jaypipes' cpu resource tracking stuff happens14:30
sean-k-mooneymriedem: or numa in placement14:30
mriedemunless we start supporting VMs without compute resources...14:30
mriedemyou can't live migrate with numa today anyway so meh14:30
sean-k-mooneymriedem: oh you mean "serverless" workloads14:30
mriedemsean-k-mooney: it was a joke14:30
*** lyarwood has joined #openstack-nova14:31
*** johnsom has joined #openstack-nova14:31
sean-k-mooneymriedem: yes but i just wanted to bitch about "serverless" marketing14:31
bauzasMEEEEH14:31
mriedemqinling already handles that14:31
mriedemsee https://qinling.readthedocs.io/14:32
mriedemheh14:32
mriedemhttps://docs.openstack.org/qinling/latest/14:32
sean-k-mooneymriedem: either jays cpu think of bauzas's numa stuff "should" land in stein14:32
bauzasthere are a couple of proposals about serverless w/ OpenStack  that don't necessarly imply a high-level OpenStack service for this, but meh :)14:32
sean-k-mooneymriedem: so does storelets14:32
bauzasanyway, we're running VMs14:33
sean-k-mooneyhttps://github.com/openstack/storlets14:33
bauzaslooks like we're diverting14:33
pooja_jadhavmriedem: able to write FT :).. thanks alot14:33
sean-k-mooneybauzas: sorry your right. so are you ok with documenting that force is availabel for old microverions and will not be supported for nested hosts?14:34
mriedempooja_jadhav: np.14:34
mriedempooja_jadhav: i'd recommend starting with a patch that adds the functional test to show the bug, as my patch does14:35
mriedemthen you can work the fix on top of that separately14:35
*** moshele has quit IRC14:35
pooja_jadhavmriedem: sure14:35
*** mvkr has joined #openstack-nova14:36
*** ttsiouts has quit IRC14:40
*** ttsiouts has joined #openstack-nova14:46
*** tbachman has quit IRC14:47
*** tbachman has joined #openstack-nova14:48
*** Luzi has quit IRC14:55
*** maciejjozefczyk has quit IRC14:55
stephenfinmoshele, sean-k-mooney: Yeah, it's a bug https://bugs.launchpad.net/nova/+bug/179714614:56
openstackLaunchpad bug 1797146 in OpenStack Compute (nova) "failed to boot guest with vnic_type direct when rx_queue_size, tx_queue_size and hw_vif_type are set" [Undecided,New]14:56
sean-k-mooneystephenfin: yes but only for vnic_types direct or direct_physical corect14:58
stephenfinyup14:58
sean-k-mooneystephenfin: if the guest also has ovs ports they should still use the specifid model14:58
stephenfinYup https://bugs.launchpad.net/nova/+bug/1797146/comments/114:58
openstackLaunchpad bug 1797146 in OpenStack Compute (nova) "failed to boot guest with vnic_type direct when rx_queue_size, tx_queue_size and hw_vif_type are set" [Undecided,New]14:58
sean-k-mooneywe should test macvtap ports too14:58
stephenfinsean-k-mooney: Is there any configuration where we'd have a direct or direct_physical vnic_type and still use virtio?14:59
stephenfinI'm assuming not because those are two opposing things15:00
sean-k-mooneystephenfin: yes but we should ignore the model in that case15:00
sean-k-mooneystephenfin: e.g. if the VF itself is a virtio-net-pci device that is fine15:01
sean-k-mooneybut we should not set the model to virtio expcitly in that case as qemu is not emulating virtio15:01
sean-k-mooneyvirtio is being implemneted in hardware15:01
stephenfinSweet15:02
stephenfinThat makes this nice and easy so15:02
sean-k-mooneystephenfin: just add vnic_type not in VNIC_TYPES_DIRECT_PASSTHROUGH15:02
stephenfinsean-k-mooney: Yup, exactly what I'm doing15:02
sean-k-mooneyVNIC_TYPES_DIRECT_PASSTHROUGH is form https://github.com/openstack/nova/blob/6bf11e1dc14afad78b11d980c2544a3dc41579ff/nova/network/model.py#L11615:02
sean-k-mooney:)15:02
melwitt.15:03
sean-k-mooneymelwitt: i read "." as basically you saying "um" and pausing15:03
melwittI don't know what that means, but ok :)15:04
sean-k-mooneymelwitt: you typed "." on irc so i just assumed you were about to say something and paused to think for a sec15:05
*** ociuhandu has quit IRC15:05
*** ociuhandu has joined #openstack-nova15:08
*** lpetrut has quit IRC15:11
sean-k-mooneystephenfin: your activly fixing https://bugs.launchpad.net/nova/+bug/1797146 right so im jsut going to assign it to you on launchpad15:11
openstackLaunchpad bug 1797146 in OpenStack Compute (nova) "failed to boot guest with vnic_type direct when rx_queue_size, tx_queue_size and hw_vif_type are set" [Medium,Confirmed]15:11
stephenfinGo for it15:11
*** panda has quit IRC15:13
jaypipesmriedem: have you ever used the "query" scheduler hint? https://github.com/openstack/nova/blob/0163b9bfb54aaa89b0574c86e7fd36321eebccfe/nova/api/openstack/compute/schemas/servers.py#L12215:14
*** gyee has joined #openstack-nova15:14
*** panda has joined #openstack-nova15:14
sean-k-mooneyjaypipes: as in the json filter "query" schduer hint15:14
*** spatel has quit IRC15:15
mriedemjaypipes: hell no15:16
cfriesenefried: jaypipes: new version of the emulated TPM spec is up.  you folks okay with HW_SYSTEM_TPM for the trait, or do you want something like COMPUTE_SECURITY_TPM ?15:18
*** spatel has joined #openstack-nova15:19
sean-k-mooneycfriesen: when i was proposing tpm traits before i was going with something slightly different https://review.openstack.org/#/c/514712/3/os_traits/hw/platform/security.py15:19
*** k_mouza has joined #openstack-nova15:19
sean-k-mooneycfriesen: so it would be HW_PLATFORM_SECURITY_TPM15:20
sean-k-mooneyor HW_PLATFORM_SECURITY_TPM_2_015:21
*** ttsiouts has quit IRC15:21
*** lpetrut has joined #openstack-nova15:21
sean-k-mooneyCOMPUTE_SECURITY_TPM would indicate taht the hypervior can emulate a TPM and HW_PLATFORM_SECURITY_TPM would be the host has a tpm15:21
*** ttsiouts has joined #openstack-nova15:21
cfriesenyeah, in the review I did call out whether we want to embed the TPM version in the trait15:22
cfriesensean-k-mooney: I thought from the hangout that physical TPM would be handled via a resource with inventory?15:23
*** spatel has quit IRC15:23
*** k_mouza has quit IRC15:23
sean-k-mooneyin the tpm i guess it could be as it is passthough to the vm and not subdevied15:23
sean-k-mooneyin which case COMPUTE_SECURITY_TPM should be the only trait that is needed15:24
jaypipessean-k-mooney: is TPM2.0 an Intel-specific thing?15:24
sean-k-mooneymoduleo adding a version15:24
sean-k-mooneyjaypipes: no its an open standard15:24
jaypipesk.15:24
jaypipessean-k-mooney: I was going to suggest prefixing with X86 if it was Intel-specific.15:24
sean-k-mooneyjaypipes: https://www.iso.org/standard/66510.html15:25
cfriesenokay, I can switch to COMPUTE_SECURITY_TPM_1_2 and COMPUTE_SECURITY_TPM_2_0 if jaypipes is cool with that15:25
jaypipessean-k-mooney: we have used COMPUTE_ to refer to virt-driver specific capabilities. I don't believe this is that?15:26
jaypipessean-k-mooney: isn't TPM a hardware thing?15:26
cfriesenjaypipes: with the trait we're talking about an emulated TPM15:26
cfriesenthe hardware TPM would be a resource since there would be a finite number of them15:26
jaypipesah, right..15:26
*** ttsiouts has quit IRC15:26
jaypipesOK, good with me then.15:26
sean-k-mooneyyep what cfriesen said :)15:27
jaypipesthis is what I was confusing HPET with :)15:27
sean-k-mooneyyep15:27
cfriesenokay, I'll respin the TPM spec with that minor change15:27
jaypipescfriesen: you proposing the os-trait patch?15:27
cfriesensure15:27
* jaypipes still parsing sean-k-mooney's words... "subdevied" is a new one to me.15:28
sean-k-mooney*subdivided15:28
jaypipescfriesen: ok, when you do, please be sure to be crystal clear that the trait refers to the virt-driver emulated capability, not a physical resource.15:29
jaypipessean-k-mooney: I'm kidding with you :)15:29
cfriesenjaypipes: right, makes sense15:29
jaypipesty sir15:29
sean-k-mooneywhat i have realised while typeing used to massively reduce the amount of missspelling i made due to reversing or omitting letter now that i touch type entirly without thinking they are reappearing15:30
*** macza has joined #openstack-nova15:31
sean-k-mooneyit used to be a huge problem in school when i would hand write things and just stop writing a word half way through and start in the middle fo the next one bacially because my hand could not keep up with my brian when writing15:31
jangutterIn the past few years I've noticed that I've started to mistype things really really badly, reading back the sentence once is no longer enough for me to figure out what I messed up.15:32
jangutterWorse, it's happening to my speech too. Pretty hilarious when you realise that your words leaving your mouth and in your brain don't match up.15:33
*** mdbooth has quit IRC15:34
jangutterbut really, I try to spread that rumour so I can claim I actually meant "offloads" when I said "screwdriver".15:34
*** lpetrut has quit IRC15:37
*** mvkr has quit IRC15:40
*** helenafm has joined #openstack-nova15:41
*** ociuhandu has quit IRC15:41
*** Guest10461 is now known as dims15:44
openstackgerritStephen Finucane proposed openstack/nova master: Ignore hw_vif_type for direct, direct-physical vNIC types  https://review.openstack.org/60946015:48
stephenfinsean-k-mooney: ^15:49
openstackgerritChris Friesen proposed openstack/nova-specs master: Add support for emulated virtual TPM  https://review.openstack.org/57111115:57
*** udesale has quit IRC15:57
openstackgerritAndreas Jaeger proposed openstack/nova master: Replace openSUSE experimental check with newer version  https://review.openstack.org/60946716:00
*** mvkr has joined #openstack-nova16:02
openstackgerritBalazs Gibizer proposed openstack/nova master: Consider nested allocations during allocation cleanup  https://review.openstack.org/60605016:03
openstackgerritBalazs Gibizer proposed openstack/nova master: Reject forced move with nested source allocation  https://review.openstack.org/60578516:03
gibijaypipes, mriedem, bauzas, efried: here is the rework of the force migration with nested allocation https://review.openstack.org/#/c/60578516:04
gibiand I'm leaving for today16:05
bauzasI'm done for the day, but I'll look tomorrow16:05
bauzashah16:05
sean-k-mooneystephenfin: can you take a look at https://review.openstack.org/#/c/609414/ before you leave16:09
stephenfinsean-k-mooney: Can do16:09
sean-k-mooneymaster is currently broken for hardware offloaded ovs and some other cases this will fix it and harden up the interface a little16:09
*** dtantsur|brb is now known as dtantsur16:15
*** k_mouza has joined #openstack-nova16:26
stephenfinsean-k-mooney: Yeah, good spot16:26
sean-k-mooneystephenfin: lennyb spotted it and pingged rodlfo and i on the neutron irc this morning16:27
*** k_mouza has quit IRC16:28
sean-k-mooneyi was thinking about fixing the name spaceing of those module too but i think there is already enough in one patch16:28
sean-k-mooneyi might submit a followup later16:28
stephenfinsean-k-mooney: I'm going to see if we can do the same thing claudiub did here to avoid that happening again https://review.openstack.org/#/c/470775/16:28
*** k_mouza has joined #openstack-nova16:28
sean-k-mooneystephenfin: im not sure that would have help in this case but i might not under stand awhat that dose enough either16:29
stephenfinsean-k-mooney: Yeah, it wouldn't actually. I thought https://review.openstack.org/#/c/609414/1/os_vif/tests/unit/internal/command/ip/windows/test_impl_netifaces.py was mocking the wrong stuff but it's not16:30
*** moshele has joined #openstack-nova16:30
sean-k-mooneythis is the improtant test https://review.openstack.org/#/c/609414/1/os_vif/tests/unit/internal/command/ip/test_api.py16:31
sean-k-mooneybefore we were returing an instance of the ip lib for windows and the module for linux16:31
stephenfinsean-k-mooney: Just left a nit comment on that, actually16:31
*** mrjk has joined #openstack-nova16:32
mriedemdansmith: on that initial allocation ratios spec, there is one place we still use the compute node fields, and that's in the scheduler https://github.com/openstack/nova/blob/6bf11e1dc14afad78b11d980c2544a3dc41579ff/nova/scheduler/host_manager.py#L25616:32
sean-k-mooneyya i realsied i coudl have used that too. im going to be adding more unit tests wehn ir change the module layout so ill change that then if your ok with that16:32
mriedemso we set the values on the compute (in the RT) and then read in the scheduler16:32
dansmithmriedem: but aren't those just for the filters?16:33
dansmithwhat else cares about those?16:33
*** k_mouza has quit IRC16:33
mriedemweighers use it too i guess16:33
*** tssurya has joined #openstack-nova16:33
dansmithto pick things that aren't set for oversubscription?16:33
dansmiththat seems weird16:33
mriedemthe numa topology filter is also using it16:34
dansmithoh, numa filter uses it16:34
dansmithhah16:34
dansmithchrist16:34
dansmithso16:34
dansmith(a) we should try to get someone to fix that16:34
stephenfinsean-k-mooney: Yup, it's just a nit16:35
dansmith(b) we can just update the compute node record with the same policy as we update placement16:35
mriedemwhich is use config if set16:35
mriedemthat's what the spec proposed yeah16:35
dansmithyep16:35
dansmithokay I see the use in the weigher16:35
mriedemthe question was about upgrading from compute nodes that have 0.0 values in the db16:35
mriedemand i said we could online data migrate those by reading config if the values are 0.016:36
dansmiththe 0.0 means that scheduler uses its own config, right?16:36
sean-k-mooneyregarding the numa topology filter im not sure it actully need the allocation ratiors16:36
mriedemno16:36
dansmithallocation_ratio of zero makes no sense otherwise right?16:36
mriedemnothing in the scheduler reads config for allocation ratios16:36
dansmithmriedem: it used to though yeah?16:36
mriedemin the long long ago i guess,16:37
mriedemoh well,16:37
mriedemthe facade would i guess yeah...16:37
dansmithpoint being, 0.0 is nonsense16:37
mriedemthe ComputeNode._from_db_object would read from config if 0.0 in the db16:37
jaypipesdansmith: ++16:37
dansmithso we could leave that, and only set it if they override per compute.. same logic as placement16:37
dansmithand anything existing with 0.0 gets the same treatment as usual I guess16:38
mriedemleave the facade in ComputeNode._from_db_object?16:38
dansmithi imagine it won't affect compute's use if it is ignoring what is set on the object, so .. sure?16:38
sean-k-mooneystephenfin: for https://github.com/openstack/nova/blob/0163b9bfb54aaa89b0574c86e7fd36321eebccfe/nova/scheduler/filters/numa_topology_filter.py#L91-L102 can you think of a use case wehre we actully need the allcoation ratiios here16:38
sean-k-mooneystephenfin: we are not allowed to over subsibe against our selves wehn fitting to a host so setting them to 1.0 i think would be valid16:39
sean-k-mooneystephenfin: i would have to go through the code to check but i think we could make the numa topolgy filter work without them.16:42
sean-k-mooneydansmith: although it sound like we dont need to remove them if we go wtih the facade right16:42
dansmithsean-k-mooney: it won't be right if you do16:43
dansmithsean-k-mooney: because if people set the ratio in placement per-compute, which is what we're trying to enable with all of this work,16:43
dansmiththe filter will consider a value other than what is in placement16:43
dansmithI'm guessing we don't get back ratios in /a_c, but if we did, we could update our host states before we call the filters16:44
sean-k-mooneydansmith: yes but this is not using the placement value anyway16:44
jaypipesmriedem: why would we keep the facade stuff in ComputeNode._from_db_object()?16:44
dansmithsean-k-mooney: right but right now they have to be the same16:44
dansmithsean-k-mooney: in the future they will not be16:44
dansmithjaypipes: see the discussion just now on the filters that use it, and existing computes in the db with 0.0 set16:44
mriedemjaypipes: we either need to leave that or online data migrate the 0.0 entries from existing records in the db on read16:45
sean-k-mooneydansmith: placement woudl have already filtered out any host that did not pass its allocation right. so we should not have to check twice and sicne we can oversubsibe againat ourselve an allocation ration of 1 i think would still be correct16:45
sean-k-mooneydansmith: anywway its not important right now i guess16:45
mriedemjaypipes: because the compute won't deal with those fields on the object, and if not set, the scheduler reads them from config via the facade16:45
dansmithsean-k-mooney: I didn't look to see what that code in the filter was doing, so maybe?16:45
dansmithsean-k-mooney: if so, we just remove it right?16:46
* jaypipes remembers why he stepped away from these specs.16:46
sean-k-mooneydansmith: ya i think soo but i would have to double check the hardware.numa_fit_instance_to_host fucntion first16:46
dansmithwe get back the resource summaries from the providers in /a_c, so including the allocation_ratios in there might be useful for things like this and for the weigher case16:47
sean-k-mooneydansmith: ya. the filters dont currently have access to the allocation candiates today is that correct16:48
sean-k-mooneyunless there in the spec_objec?16:48
dansmithsean-k-mooney: that isn't what I'm saying16:48
dansmithI'm saying the scheduler, when it gets back candidates, gets a summary of all covered providers, with inventory information16:49
dansmithif that included the ratios, it could update host_states before calling the filter loop16:49
jaypipessean-k-mooney: pls see my comment on https://review.openstack.org/#/c/609414/16:49
sean-k-mooneyoh ok that would work too ya i was assuming you were suggsting passing in the candiates but your way we do that update once and dont have to update any code in the filters16:49
sean-k-mooneyjaypipes: there isnt a bug number because i just got pingged on irc this morning but i can open one16:50
dansmithmriedem: melwitt tssurya: cells meeting today?16:51
mriedemnack16:51
mriedemwe might want to just cancel that meeting16:51
dansmithI'd also be fine with that16:51
*** k_mouza has joined #openstack-nova16:51
dansmithI think I suggested that last year even16:51
*** helenafm has quit IRC16:52
jaypipessean-k-mooney: yes pls. if this is truly a "currently broken for hardware offloaded ovs" scenario, it definitely should be a bug.16:53
*** k_mouza has quit IRC16:54
tssuryadansmith: no problems in cancelling16:54
sean-k-mooneyits broke for all ovs backends that use ip command because api _get_impl on linux retrun a module instead of the insatnce of the pyroute2 class16:55
mriedemdansmith: you want to propose the change to cancel the meeting or want me to?16:56
sean-k-mooneyjaypipes: os that is ovs + iptables or ovs + hardware offloads. i have added some extra test to catch this  case16:56
dansmithmelwitt: what do you think about canceling the cells meeting altogether and making it ad-hoc as needed?16:56
dansmithmriedem: I figure we don't need to make a federal case out of it16:56
dansmithif everyone agrees, we just take it off the schedule16:56
mriedemdansmith: it's literally in a schedule though16:56
dansmithI know16:56
mriedemhttp://git.openstack.org/cgit/openstack-infra/irc-meetings/tree/meetings/nova-cells-v2-meeting.yaml16:56
dansmithoh,16:57
dansmiththat schedule16:57
mriedemyeah, free up the time slot in that channel if we're not going to use it16:57
dansmithI thought it was just on the old wiki list16:57
mriedemno this is very official and federale16:57
dansmithI'll propose.. I need to do something useful today16:57
*** k_mouza has joined #openstack-nova16:58
*** macza has quit IRC16:59
*** macza has joined #openstack-nova16:59
melwittdansmith: yup sounds ok to me17:01
dansmithhttps://review.openstack.org/#/c/609496/17:01
*** k_mouza has quit IRC17:02
*** derekh has quit IRC17:03
*** k_mouza has joined #openstack-nova17:05
*** k_mouza has quit IRC17:08
mriedemhmm live migration failure in the gate, not something i've seen before i don't think, looks like it was aborted but i'm not sure why17:09
mriedemhttp://logs.openstack.org/31/606031/4/check/nova-live-migration/9d106bb/logs/subnode-2/libvirt/libvirtd.txt.gz#_2018-10-10_15_27_01_31317:09
mriedem2018-10-10 15:27:01.313+0000: 18210: error : qemuMigrationFinish:5533 : migration successfully aborted17:09
*** erlon has joined #openstack-nova17:14
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: API _get_impl() for Linux should return PyRoute2() object  https://review.openstack.org/60935417:14
*** k_mouza has joined #openstack-nova17:18
*** k_mouza has quit IRC17:23
*** orange_julius has joined #openstack-nova17:24
orange_juliusI've been looking into ways to use ARM images inside of an Openstack installation and was wondering if anybody had any experience with this. From what I've seen we basically have two options: Purchase an ARM server and set up as a compute node. Configure a server to use qemu instead of KVM and virtualize. Is it possible to tell a compute node to us17:26
orange_juliuse both kvm and qemu depending on the image? Is there a better way to accomplish this?17:26
openstackgerritsean mooney proposed openstack/os-vif master: clean up ip_command interface  https://review.openstack.org/60941417:26
openstackgerritsean mooney proposed openstack/os-vif master: add support for generic tap device plug  https://review.openstack.org/60238417:26
*** k_mouza has joined #openstack-nova17:27
sean-k-mooneyjaypipes: done ^ let me know if there is anything else you would like me to change17:27
*** psachin has quit IRC17:28
*** moshele has quit IRC17:29
*** k_mouza has quit IRC17:31
jaypipessean-k-mooney: +Wd17:32
*** mvkr has quit IRC17:33
sean-k-mooneyjaypipes: thanks i should have created the bug when it was reported to me on irc instead of starting on the patch but i need to base my other patch on top of it anyway17:34
*** dtantsur is now known as dtantsur|afk17:34
jaypipessean-k-mooney: no worries man17:34
sean-k-mooneyok so time for dinner ill be back online later17:36
*** moshele has joined #openstack-nova17:39
*** adrianc has joined #openstack-nova17:39
*** ociuhandu has joined #openstack-nova17:39
*** k_mouza has joined #openstack-nova17:40
*** macza has quit IRC17:40
*** macza has joined #openstack-nova17:41
*** ociuhandu has quit IRC17:41
cfriesenorange_julius: currently I think you'd need to make it a nova-compute config option.  theoretically you could make it depend on the image properties, but I think that'd be a feature to be added.17:42
orange_juliuscfriesen: Just so  I understand, you are saying that we'd have to change the nova config on a hypervisor to use qemu instead of KVM. Basically dedicating that entire machine to QEMU workloads instead of KVM17:43
mriedemorange_julius: mnaser can probably help here17:44
mriedemi think he's running arm nodes somewhere17:45
*** k_mouza has quit IRC17:45
*** tssurya has quit IRC17:46
*** adrianc has quit IRC17:47
*** adrianc has joined #openstack-nova17:47
cfriesenorange_julius: the libvirt driver in nova looks at caps.host.cpu.arch which comes from libvirt.  so you'd need to make that return an arm architecture I think.17:52
*** pcaruana has quit IRC17:55
*** k_mouza has joined #openstack-nova18:06
*** k_mouza has quit IRC18:10
*** pcaruana has joined #openstack-nova18:12
*** itlinux has quit IRC18:13
*** k_mouza has joined #openstack-nova18:18
*** panda has quit IRC18:20
*** k_mouza has quit IRC18:20
*** priteau has quit IRC18:20
*** panda has joined #openstack-nova18:23
*** k_mouza has joined #openstack-nova18:24
*** moshele has quit IRC18:25
*** k_mouza has quit IRC18:27
*** mvkr has joined #openstack-nova18:28
larsksHey folks.  There are comments in the nova history that suggest the quota_usage_refresh manage command was replaced by API functionality. What is that API?18:30
*** k_mouza has joined #openstack-nova18:34
larsksstephenfin: ...if you're around, they were your comments :) ^^^^18:36
*** k_mouza_ has joined #openstack-nova18:38
*** k_mouza has quit IRC18:39
melwittlarsks: as of Pike, we don't track quota usages separately from resource counts, so there's no notion of refreshing quota. we only use resource counting18:39
melwittso quota can't get out-of-sync18:40
melwittare you asking about a version earlier than Pike?18:40
*** k_mouza_ has quit IRC18:40
*** corvus has joined #openstack-nova18:45
larsksmelwitt: pike, actually, so that's good to know.  I'm an indirect conduit for the issue right now, so I will need to wait until I get my hands on the environment in question I guess before I can better assess what's going on.  Thanks!18:46
melwittlarsks: ok, feel free to ping me if you have more questions18:47
*** moshele has joined #openstack-nova18:48
mriedemdansmith: https://github.com/kk7ds/openstack-gerrit-dashboard/pull/2918:51
dansmithmriedem: yep will look in a sec18:51
dansmithmriedem: was going to ask you this morning if you had fixed that yet :D18:51
dansmithomg it works!18:54
*** macza has quit IRC18:55
*** macza has joined #openstack-nova18:55
openstackgerritArtom Lifshitz proposed openstack/nova master: WIP: Handle volume API failure in post_live_migration  https://review.openstack.org/60951719:03
*** pcaruana has quit IRC19:03
openstackgerritMatt Riedemann proposed openstack/nova master: Fix NoneType error in _notify_volume_usage_detach  https://review.openstack.org/60951819:08
*** adrianc has quit IRC19:08
mriedemdansmith: i needed something to do besides review code and/or specs19:13
* dansmith nods19:13
*** spatel has joined #openstack-nova19:17
*** k_mouza has joined #openstack-nova19:23
openstackgerritMerged openstack/nova-specs master: Update blueprint name so spec matches launchpad  https://review.openstack.org/60734719:25
*** k_mouza has quit IRC19:27
imacdonndansmith: I implemented what I understood from our discussion yesterday at https://review.openstack.org/608091 . It needs a little polish, but sean-k-mooney wants to use new the exit status if there are any exceptions, whether or not any migrations may still be pending. I don't think we can do that, because it can't be automated19:27
*** k_mouza has joined #openstack-nova19:28
*** k_mouza has quit IRC19:32
*** dave-mccowan has quit IRC19:34
*** k_mouza has joined #openstack-nova19:40
mriedemhey gang, two easy +Ws https://review.openstack.org/#/c/608802/ https://review.openstack.org/#/c/609467/19:41
*** k_mouza has quit IRC19:43
*** k_mouza_ has joined #openstack-nova19:44
*** moshele has quit IRC19:45
*** k_mouza has joined #openstack-nova19:47
melwittdansmith, mriedem: I linked my nova-consoleauth patch on L52 here that is ready for subteam review https://etherpad.openstack.org/p/stein-nova-subteam-tracking19:48
*** macza has quit IRC19:48
*** macza has joined #openstack-nova19:48
*** k_mouza_ has quit IRC19:49
*** macza has quit IRC19:49
*** k_mouza has quit IRC19:50
artomI thought we had functional live migration tests?19:50
*** macza has joined #openstack-nova19:50
artomAh, nova/tests/functional/test_servers.py19:50
artomIgnore me19:50
dansmithimacdonn: I don't understand sean's concern or desire19:51
imacdonndansmith: thanks for commenting. One thing is still a bit fuzzy .. what does "work was done" mean? The way "ran" is currently implemented, it only counts how many rows were migrated *in the last batch*, so of you use the default of 50 at a time, ran will always end up as 019:53
imacdonn... because that's the only way it can break out of the loop19:55
dansmithimacdonn: ran is the sum of all the "done" values from any migration it4eration right?19:55
*** pcaruana has joined #openstack-nova19:55
dansmithran becoming nonzero is how you break out19:55
imacdonndansmith: no, only the last iteration19:55
imacdonndansmith: it gets reset to 0 at https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L71819:56
dansmithimacdonn: oh I see, but that's a bug I guess19:56
dansmithfrom when this went from a fixed number to having an --until-done19:56
dansmithor whatever19:56
dansmithor the opposite, but you know what I mean19:57
sean-k-mooneydansmith: we break out 1 of 2 way. ran becomes 0 or we pass --max-count in which case we do not loop as unlimited is false19:57
dansmithso yeah you have to fix that for this to work19:57
imacdonndansmith: that's what I need to get nailed down ... I tried to fix that, in PS2, but made grenade blow up, becaused grenade needs the command to exit with status 019:57
dansmithimacdonn: well, if this is wrong it's possible grenade is wrong19:58
jaypipesmriedem: yesterday, which scheduler filter did you say already looked at instance metadata by querying the BuildRequest?19:58
mriedemjaypipes: the one you're writing19:58
dansmithoh wait,19:58
dansmithmaybe I'm remembering this now19:58
imacdonndansmith: it's possible, yes ... although it seems like if you run the command without --max-count, an outcome of exit status 0 (generally interpreted as success), is what would be expected19:58
dansmithin the unlimited case, you really need the exit code to be zero19:59
dansmithright19:59
dansmithoof, this should be commented in here for sure19:59
dansmithimacdonn: so maybe just keep the full count separate from ran and use that for the gate on exit 219:59
imacdonnso that's how I came up with the term "migrations may still be pending" .... when ran is not zero, which can only happen if you use --max-count19:59
sean-k-mooneydansmith: yes if you dont pass --max-count the exit 0 should mean all migration ran sucessfuly20:00
dansmithimacdonn: like I say, you don't know what is pending or not really20:00
imacdonndansmith: that's why I used "may" :)20:00
dansmithimacdonn: don't.20:00
sean-k-mooneyactully if you do pass --max-could exit 0 should still mean the same thing20:00
dansmithimacdonn: so if you keep total_ran and use that then you're good right?20:00
dansmithsean-k-mooney: no it shouldn't20:01
dansmithsean-k-mooney: because you ran --max-count=50 and you get zero, you expect you're done20:01
dansmithsean-k-mooney: if you don't pass --max-count, zero means all of them were completed, no errors so you're done20:01
sean-k-mooneyif there are 50 migrations and i pass --max-count=100 it should return 0 if all 50 ran successfully20:01
dansmithsean-k-mooney: no it shouldn't20:01
dansmithsean-k-mooney: read the man page20:01
imacdonndansmith: are you saying exit 2 if exceptions and total_ran>0, and exit 1 if ran (not total_ran) > 0 ?20:01
sean-k-mooneyso if max is greater then total you dont want the same behavior as if there was no max20:02
dansmithimacdonn: I'm saying leave the 0 and 1 the way they are, and exit 2 if total_ran=0 and exceptions20:02
dansmithsean-k-mooney: it's about definition of done-ness20:02
imacdonndansmith: that's what I had in PS2, and it broke grenade, because it exits with 1 if any migrations were done20:02
imacdonndansmith: or maybe I didn't interpret your last statement right20:03
sean-k-mooneyyes which is why im saying if i set a max larger then the amount to do and they all ran sucsessfully im done hence 020:03
dansmithimacdonn: I'm not talking about changing the definition of 120:03
dansmithimacdonn: right20:03
dansmithimacdonn: if you don't change the logic for 1 then grenade can't break, unless we're actually hiding exceptions20:03
*** k_mouza has joined #openstack-nova20:03
*** spatel has quit IRC20:04
imacdonndansmith: OK, I think that might work ... I'll have to try it ... sean-k-mooney, do you still have concerns ?20:05
sean-k-mooneydansmith: we used to hide exceptions but my understand of 1 is there are still more migration to run i would prefer it to be "there are more migration to run and all the ones i just ran did not have error"20:05
dansmithsean-k-mooney: that's not what 1 means20:05
dansmithwe can't really know if there are more unless we try and hit zero20:05
dansmithwithout doing more database stuff to count separately from doing20:05
dansmithwhich is not worth it, IMHO20:05
dansmithso, while (rc==1) { doit }20:06
imacdonnpersonally, I kinda wish there was a way to find out how many migrations are needed, before attempting any20:06
imacdonnI might want to do this when planning an upgrade20:06
*** pcaruana has quit IRC20:06
sean-k-mooneyok so 1 just used to mean there was a partial update so we need to loop that i think makes sense20:06
sean-k-mooneyand 0 means we are done20:07
dansmithsean-k-mooney: no, 1 means we did things, that's ALL it means :)20:07
sean-k-mooneydansmith: what is the smantics of 2 in your case20:07
dansmithmight be partial, might be full20:07
mriedemsorrison: if you wanted to policy something, i'd think having policy on the ability to create multiple servers in a single request would be a good one so you can avoid tenants killing your scheduler with large burst multi-create requests20:07
mriedemespecially if those users have higher than normal quota20:07
dansmithsean-k-mooney: hopefully this can be the last time I say this, but 2 means we couldn't make any more progress, and exceptions were raised20:07
mriedemwe probably had a policy on the multi-create API extension at some point20:07
mriedemmake it 2.5....20:08
mriedemand i'm sold20:08
dansmithsean-k-mooney: so you can distinguish between "can't make any more progress" and "can't make any more progress, but things seem unhappy"20:08
sean-k-mooneydansmith: ok but we dont stop trying migration on the first exception20:08
*** k_mouza has quit IRC20:08
dansmithsean-k-mooney: exactly20:08
*** moshele has joined #openstack-nova20:09
sean-k-mooneymy piont it 2 would only ever be retruned if all the migrations in the first iteration failed20:09
dansmithno20:09
mriedemsorrison: maybe that's just never been a problem b/c of quota restrictions, the multi-create thing i mean20:09
dansmithsean-k-mooney: did you mean the last iteration? my answer is still no, but...20:10
imacdonnno, 2 gets returned if the only remaining possible migrations barfed for some reason20:10
dansmithsean-k-mooney: with the suggestion I just made to imacdonn, we keep a total_run count and use that for 2 instead of ran, which is just "the last iteration"20:10
mriedemmelwitt: isn't this more than just the db backend for console auth? https://bugs.launchpad.net/nova/+bug/1795982 - it's been regressed since multi-cell support in pike20:10
openstackLaunchpad bug 1795982 in OpenStack Compute (nova) "/os-console-auth-tokens/{console_token} API doesn't handle the database backend" [High,In progress] - Assigned to melanie witt (melwitt)20:10
dansmithimacdonn: right20:10
dansmithimacdonn: maybe just tweak and push that up and we can argue about it after there's something to see?20:10
dansmithI'm getting kinda frustrated with this overly minute detail and really want to get on to other stuff before I end my day20:11
imacdonndansmith: roger. will do after lunch20:11
dansmithimacdonn: thanks20:11
melwittmriedem: I don't think so because nova-consoleauth is global, you don't need to know anything about cells to query it20:11
sean-k-mooneydansmith: yes i was referring to "total_run==0 and exceptions" for retrun 220:11
melwittmriedem: that is, it's storage of console token auths is global across all cells20:12
efrieddansmith, imacdonn: I don't intend to get super involved in this, but have we considered allowing behavior change(s) (e.g. where exceptions cause failure) based on an env var or CLI switch? (Sorry, this thought has been bouncing around in my head for a week, had to get it out.)20:12
dansmithefried: I don't think we need a behavior change here20:12
mriedemhmm, ok https://docs.openstack.org/nova/queens/user/cellsv2-layout.html#consoleauth-service-and-console-proxies20:12
efried...so that existing automations aren't affected, but new users can have the benefit of potentially improved UX20:12
mriedemgot confused about what's global or not20:12
dansmithefried: if we did, then sure20:12
openstackgerritArtom Lifshitz proposed openstack/nova master: Handle volume API failure in post_live_migration  https://review.openstack.org/60951720:13
*** moshele has quit IRC20:13
sean-k-mooneydansmith: imacdonn you know what im fine with what ever you implement and ill read teh code after to understand what the exit code actully mean.20:13
efriedOkay. When I stopped looking, the patch was suggesting a behavior change that seemed fair and just to me, but was nacked for that reason.20:13
imacdonnefried: we've introduced a new exit status, so the logic for the existing ones doesn't have to change .. I think it'll only "break" when there are exceptions and no more possible migrations, and we *want* it to break in that case20:14
dansmithefried: the only thing that could make this more dreadful would be two behaviors in the same set of code :)20:15
dansmithimacdonn: ++20:15
efrieddansmith: Hm, we should introduce a microversioning system for that.20:15
dansmithefried: we should microversion your butt.20:15
* efried almost choked on his steak20:16
dansmithif we ever have nova-manage cellv2 thingy --cli-version=2.12320:16
dansmiththen just shoot me20:16
melwittmriedem: yeah, so the /os-console-auth-tokens/{console_token} API calls nova-consoleauth over RPC, and nova-consoleauth was made cell-aware sometime in the past, so all was working fine with multi-cell (unless there's a bug we don't know about). but when we moved to the database backend, that's what made it so that the /os-console-auth-tokens API would need to be able to talk to cell databases directly instead of going through the20:16
melwitt nova-consoleauth service20:16
*** erlon has quit IRC20:17
efriedwhat we really need is nested microversions20:17
sean-k-mooneyimacdonn: retruaning any new code will still requrie autoation scirpt to handel the new error case or manual intervention so the fact there is a behavior change or not is slight less important that said in the sucess case the codes should not change20:17
mriedemgod i bet my cross-cell resize stuff needs to recreate console auth tokens for the moved instance in the target cell db too...20:18
mriedemlike bdms and tags20:18
* dansmith gets out his irc ops to kickban people discussing nested microversions20:18
*** ralonsoh has quit IRC20:18
mriedemand virtual_interfaces...20:18
melwittyou could probably just punt that though, let them have to get a fresh console token after a cross-cell move20:19
imacdonnsean-k-mooney: that's true, and that's why there's a release note for this, and it may not be backportable ... but the most common case will be running the command without --max-count and expecting a 0, or rerunning it until you don't get 120:19
melwittdefault TTL for console token auth is 10 minutes so they aren't designed to live long. operators can configure longer TTL but I'm not sure they'd expect you to solve for that20:19
imacdonnsean-k-mooney: I guess the possible case where it could break automation is if the command is being rerun infinitely until it gets a zero, which would never happen if it's returning 2 every time20:20
*** tbachman has quit IRC20:20
sean-k-mooneyimacdonn: if i was writingin this in ansiable and i called it without --max-count i would have interpereted a non 0 result as an error just fyi20:20
imacdonnsean-k-mooney: right, and we're not going to change that20:21
imacdonnsean-k-mooney: without --max-count, you'll either get 0 (it worked), or 2 (something unexpectedly broke, and you need to figure out why)20:21
sean-k-mooneyimacdonn: if you gurarentee that in the code that is fine20:22
imacdonnsean-k-mooney: I believe I can .. I'll post it this afternoon, and we can nit-pick :)20:23
*** spatel has joined #openstack-nova20:23
*** k_mouza has joined #openstack-nova20:24
sean-k-mooneyill be offline by then but enjoy your lunch and ill take a look at it tomorow20:24
imacdonnk, thanks!20:24
*** k_mouza has quit IRC20:28
*** erlon has joined #openstack-nova20:31
*** devananda has joined #openstack-nova20:33
sean-k-mooneyhave people see a 404 failing to retriva allocationf form resource provierded before20:34
sean-k-mooneyhttp://logs.openstack.org/84/602384/4/check/kuryr-kubernetes-tempest-daemon-octavia/33adb32/controller/logs/screen-n-cpu.txt.gz?#_Oct_10_19_02_09_95377120:34
openstackgerritJack Ding proposed openstack/nova-specs master: High Precision Event Timer (HPET) on x86 guests  https://review.openstack.org/60798920:36
openstackgerritJack Ding proposed openstack/nova-specs master: High Precision Event Timer (HPET) on x86 guests  https://review.openstack.org/60798920:36
*** erlon has quit IRC20:37
*** k_mouza has joined #openstack-nova20:40
*** awaugama has quit IRC20:43
*** k_mouza has quit IRC20:43
*** tbachman has joined #openstack-nova20:44
*** itlinux has joined #openstack-nova20:46
*** erlon has joined #openstack-nova20:48
*** tbachman has quit IRC20:48
*** spatel has quit IRC20:48
*** spatel has joined #openstack-nova20:49
*** erlon has quit IRC20:53
*** liuyulong has quit IRC20:55
*** k_mouza has joined #openstack-nova20:55
mriedemmelwitt: ok +220:56
melwittthanks20:57
*** k_mouza_ has joined #openstack-nova20:58
*** k_mouza has quit IRC21:00
*** k_mouza_ has quit IRC21:03
*** spatel has quit IRC21:04
*** slaweq has quit IRC21:04
*** spatel has joined #openstack-nova21:06
*** k_mouza has joined #openstack-nova21:06
mriedemsean-k-mooney: yes it's a known bug21:10
mriedemhttps://bugs.launchpad.net/nova/+bug/178999821:10
openstackLaunchpad bug 1789998 in OpenStack Compute (nova) "ResourceProviderAllocationRetrievalFailed ERROR log message on fresh n-cpu startup" [Low,Triaged]21:10
mriedemhappens on every start of a new compute21:10
*** slaweq has joined #openstack-nova21:11
openstackgerritMatt Riedemann proposed openstack/nova master: Don't log an error if attachment_create fails  https://review.openstack.org/60954721:14
*** slaweq has quit IRC21:16
sorrisonmriedem: Missing some context RE: "maybe that's just never been a problem b/c of quota restrictions, the multi-create thing i mean"21:23
mriedemmeaning maybe no one has ever felt the need to restrict certain groups of users from being able to make multi-create requests21:23
mriedembecause multi-create can be abused, e.g. https://review.openstack.org/#/c/607735/21:24
*** priteau has joined #openstack-nova21:24
mriedemsorrison: maybe a better question is, what is the highest any of your tenants have for instance quota?21:24
*** priteau has quit IRC21:26
sorrisonmriedem: 2048 is the highest just looking in our DB21:26
*** macza has quit IRC21:26
mriedemjesus21:26
mriedemhave you ever tried to create 2048 servers in a single create request?21:27
*** macza has joined #openstack-nova21:27
sorrisonhaha don't be silly :-)21:27
mriedembecause the API will let you do that21:27
mriedemthere is no rate limiting on multi-create requests21:27
mriedemand that size of request will melt your scheduler21:27
mriedemrelated: https://review.openstack.org/#/c/510235/21:28
sorrisonis the multi create number set in the request spec? I can have a look in the db to see what our stats are like21:28
mriedemyes, it's the request spec "num_instances" field21:28
*** eharney has quit IRC21:31
openstackgerritMerged openstack/os-vif master: clean up ip_command interface  https://review.openstack.org/60941421:35
sorrisonmriedem: very tricky to get that info out of mysql due to json blob. We're not running a version of mysql that has json support sadly21:36
mriedemdamn21:36
melwittI never knew request spec was a json blob until now O.o21:40
openstackgerritMatt Riedemann proposed openstack/nova master: Don't log error in _remove_deleted_instances_allocations if compute is new  https://review.openstack.org/60955221:40
sorrisoneither way, we're aware of the issue but haven't had any major issues21:41
mriedemmaybe i can get some data from some public cloud ops21:41
sorrisonJust trying to get my sql foo on to see if I can extract the num_instances21:41
*** munimeha1 has quit IRC21:44
sorrisonok so max num_instances we've had is 4921:51
sorrisonmriedem: stats here http://paste.openstack.org/show/731867/21:52
melwittneat21:53
mriedemsorrison: nice, thanks21:56
*** tbachman has joined #openstack-nova22:00
sorrisonmriedem: I sorted out https://review.openstack.org/#/c/608474/ still not sure about correct name for policy as it does affect list and show for a flavor22:01
mriedemthat's not checked on show is it?22:01
mriedemor you mean, allow non-admins to show private flavors that they don't have access to?22:02
mriedemi.e. support person trying to triage a bug for a server created with a private flavor?22:02
sorrisonYes22:07
sorrisonThe change to allow policy for a flavor show is https://review.openstack.org/#/c/608474/3/nova/objects/flavor.py22:07
sorrisonit's for reporting scripts22:08
mriedemyup took me a second to sort that out22:09
sorrisonyeah it goes down a few layers from the api22:09
*** burt has quit IRC22:11
*** slaweq has joined #openstack-nova22:11
mriedemsorrison: ok comments inline;22:12
mriedemi left some suggestions about the rule name, but they aren't awesome22:12
mriedemmaybe alex_xu or gmann or dansmith have ideas22:12
sorrisonyeah I can't think of something good there22:15
*** slaweq has quit IRC22:15
sorrisonwith disabled flavors I think they are useful. We are planning on retiring some flavors soon and were planning on disabling them by updating the DB22:16
sorrisonunless there is a better way to retire flavors?22:16
*** mlavalle has quit IRC22:20
mriedemthere is no way to disable flavors via the API, which is why i'm sort of hesitant to mention them22:27
mriedembut it's not a big deal to leave that in if you're hacking flavors.disabled via the db directly22:27
mriedemit just sucks you have to do that...22:27
mriedemwe have a PUT /flavors/{flavor_id} now...seems that would be a place to disable/enable flavors22:28
melwittAFAIK, people retired flavors by deleting them. and I remember we had a bug back from eons ago where 'nova show' would fail on existing instances with the retired flavor because it was trying to pull a flavor that was deleted from the db22:28
melwittthat got fixed by flavors embedded on instances22:28
mriedemand we expose the flavor details embedded in the instance in the API now22:28
sorrisonhmm yeah that makes sense and can prob just retire by deleting now22:34
*** spatel has quit IRC22:36
*** erlon has joined #openstack-nova22:40
*** rcernin has joined #openstack-nova22:41
*** spatel has joined #openstack-nova22:42
*** spatel has quit IRC22:47
*** moshele has joined #openstack-nova22:56
mriedemefried: see the thread on the ML about moving taskflow out of openstack governance?22:57
mriedempowervm might care about that22:57
mriedemoh heh i see you did :)22:58
openstackgerritMatt Riedemann proposed openstack/nova master: Skip _remove_deleted_instances_allocations if compute is new  https://review.openstack.org/60955222:59
openstackgerritMatt Riedemann proposed openstack/nova master: Skip _remove_deleted_instances_allocations if compute is new  https://review.openstack.org/60955223:00
*** moshele has quit IRC23:00
*** macza has quit IRC23:03
*** slaweq has joined #openstack-nova23:11
*** aloga has quit IRC23:15
*** slaweq has quit IRC23:16
*** k_mouza has quit IRC23:17
*** mriedem has quit IRC23:18
*** aloga has joined #openstack-nova23:27
*** icey has quit IRC23:39
*** icey has joined #openstack-nova23:40
openstackgerritiain MacDonnell proposed openstack/nova master: Handle online_data_migrations exceptions  https://review.openstack.org/60809123:44
*** mchlumsky has quit IRC23:46
*** takashin has joined #openstack-nova23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!