*** betherly has joined #openstack-nova | 00:11 | |
*** betherly has quit IRC | 00:15 | |
*** erlon has joined #openstack-nova | 00:24 | |
openstackgerrit | Merged openstack/osc-placement stable/queens: Do not depend on jenkins user in devstack gate https://review.openstack.org/556666 | 00:30 |
---|---|---|
*** betherly has joined #openstack-nova | 00:31 | |
*** betherly has quit IRC | 00:36 | |
*** tetsuro has joined #openstack-nova | 00:40 | |
*** hshiina has joined #openstack-nova | 00:40 | |
*** itlinux has joined #openstack-nova | 00:49 | |
*** yingjun has joined #openstack-nova | 00:50 | |
*** betherly has joined #openstack-nova | 00:52 | |
*** yingjun has quit IRC | 00:56 | |
*** betherly has quit IRC | 00:56 | |
openstackgerrit | Merged openstack/nova master: Add functional recreate test for bug 1799727 https://review.openstack.org/613115 | 01:02 |
openstack | bug 1799727 in OpenStack Compute (nova) "CPU_Allocation_Ratio from nova.conf doesn't update exisiting providers" [High,In progress] https://launchpad.net/bugs/1799727 - Assigned to Matt Riedemann (mriedem) | 01:02 |
sean-k-mooney | melwitt: sorry i needed to go lie down for a bit as i was feeling off (just a headache) | 01:05 |
sean-k-mooney | melwitt: i commented on the os-vif release patch | 01:05 |
sean-k-mooney | i think its fine but there are two patches i would like to incude in the release if we have time or do a 1.12.1 release before the end of the year if they need future work before november 1st | 01:06 |
sean-k-mooney | efried: ill review your provider config yaml spec https://review.openstack.org/#/c/612497 tomorow if i can. i have abandon mine in favor of your for this release | 01:08 |
sean-k-mooney | but with that siad im going to go back to sleep talk to everyone in the morning o/ | 01:08 |
*** betherly has joined #openstack-nova | 01:12 | |
*** betherly has quit IRC | 01:17 | |
*** mrsoul has joined #openstack-nova | 01:17 | |
*** bhagyashris has joined #openstack-nova | 01:20 | |
*** betherly has joined #openstack-nova | 01:33 | |
*** betherly has quit IRC | 01:37 | |
*** cervigni has joined #openstack-nova | 01:38 | |
cervigni | hello everyone, we have a very odd problem in our environment. lauching an instance stucks on scheduling / building. But if I launch more than one from web interface, the first instance always fails, while the other instances (other than the first one) always succeed | 01:38 |
openstackgerrit | Yongli He proposed openstack/nova-specs master: add 'show-server-group' spec https://review.openstack.org/612255 | 01:38 |
cervigni | any idea where I should start looking? I though it was a placement problem but no errors whatsoever | 01:38 |
openstackgerrit | Yongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology" https://review.openstack.org/612256 | 01:38 |
*** mhen has quit IRC | 01:40 | |
*** mhen has joined #openstack-nova | 01:42 | |
*** lbragstad has quit IRC | 01:49 | |
*** lbragstad has joined #openstack-nova | 01:49 | |
openstackgerrit | Yongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology" https://review.openstack.org/612256 | 01:51 |
*** betherly has joined #openstack-nova | 01:53 | |
*** rcernin has joined #openstack-nova | 01:55 | |
*** Dinesh_Bhor has joined #openstack-nova | 01:55 | |
*** betherly has quit IRC | 01:58 | |
*** moshele has joined #openstack-nova | 02:03 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Fixes Python3 issue in decoding password https://review.openstack.org/604870 | 02:06 |
*** lei-zh has joined #openstack-nova | 02:09 | |
openstackgerrit | Yongli He proposed openstack/nova-specs master: add 'show-server-group' spec https://review.openstack.org/612255 | 02:13 |
openstackgerrit | Yongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology" https://review.openstack.org/612256 | 02:13 |
*** betherly has joined #openstack-nova | 02:14 | |
*** trungnv has joined #openstack-nova | 02:18 | |
*** betherly has quit IRC | 02:19 | |
*** moshele has quit IRC | 02:31 | |
openstackgerrit | Yikun Jiang proposed openstack/nova master: Add compute_node ratio online data migration https://review.openstack.org/609995 | 02:34 |
*** betherly has joined #openstack-nova | 02:34 | |
*** betherly has quit IRC | 02:39 | |
*** betherly has joined #openstack-nova | 02:54 | |
*** Dinesh_Bhor has quit IRC | 02:58 | |
*** betherly has quit IRC | 03:00 | |
*** Dinesh_Bhor has joined #openstack-nova | 03:06 | |
*** cervigni has quit IRC | 03:17 | |
*** dpawlik has quit IRC | 03:27 | |
*** cfriesen has quit IRC | 03:29 | |
*** dpawlik has joined #openstack-nova | 03:29 | |
*** betherly has joined #openstack-nova | 03:35 | |
*** betherly has quit IRC | 03:40 | |
*** brinzhang has quit IRC | 03:47 | |
*** brinzhang has joined #openstack-nova | 03:47 | |
*** udesale has joined #openstack-nova | 03:51 | |
openstackgerrit | Yikun Jiang proposed openstack/nova master: Add ratio online data migration when load compute node https://review.openstack.org/613499 | 03:52 |
*** betherly has joined #openstack-nova | 03:56 | |
*** lpetrut has joined #openstack-nova | 03:58 | |
*** betherly has quit IRC | 04:00 | |
*** jding1_ has joined #openstack-nova | 04:01 | |
*** tetsuro has quit IRC | 04:04 | |
*** jackding has quit IRC | 04:04 | |
*** Dinesh_Bhor has quit IRC | 04:11 | |
*** dave-mccowan has quit IRC | 04:14 | |
*** janki has joined #openstack-nova | 04:22 | |
*** brinzhang has quit IRC | 04:31 | |
*** brinzhang has joined #openstack-nova | 04:31 | |
*** lpetrut has quit IRC | 04:34 | |
openstackgerrit | melanie witt proposed openstack/nova master: Add nova-status upgrade check for consoles https://review.openstack.org/611214 | 04:34 |
*** dpawlik has quit IRC | 04:36 | |
*** dpawlik has joined #openstack-nova | 04:39 | |
*** lei-zh has quit IRC | 04:49 | |
*** lei-zh has joined #openstack-nova | 05:09 | |
*** takashin has left #openstack-nova | 05:31 | |
*** ratailor has joined #openstack-nova | 05:35 | |
*** Dinesh_Bhor has joined #openstack-nova | 05:35 | |
*** betherly has joined #openstack-nova | 05:36 | |
*** betherly has quit IRC | 05:40 | |
*** Luzi has joined #openstack-nova | 05:45 | |
*** mdbooth_ has joined #openstack-nova | 05:46 | |
*** mchlumsky_ has joined #openstack-nova | 05:46 | |
*** elod_ has joined #openstack-nova | 05:50 | |
*** jpenag has joined #openstack-nova | 05:53 | |
*** hemna_ has joined #openstack-nova | 05:54 | |
*** ianw_ has joined #openstack-nova | 05:54 | |
*** dims_ has joined #openstack-nova | 05:54 | |
*** erlon has quit IRC | 05:55 | |
*** irclogbot_2 has quit IRC | 05:55 | |
*** mchlumsky has quit IRC | 05:55 | |
*** liuyulong|away has quit IRC | 05:55 | |
*** mdbooth has quit IRC | 05:55 | |
*** dims has quit IRC | 05:55 | |
*** dulek has quit IRC | 05:55 | |
*** jpena|off has quit IRC | 05:55 | |
*** skatsaounis has quit IRC | 05:55 | |
*** elod has quit IRC | 05:55 | |
*** gnuoy has quit IRC | 05:55 | |
*** hemna has quit IRC | 05:55 | |
*** burt has quit IRC | 05:55 | |
*** ianw has quit IRC | 05:55 | |
*** jlvillal has quit IRC | 05:55 | |
*** mdrabe has quit IRC | 05:55 | |
*** ianw_ is now known as ianw | 05:55 | |
*** mhen has quit IRC | 05:59 | |
*** mdrabe has joined #openstack-nova | 05:59 | |
*** tetsuro has joined #openstack-nova | 06:01 | |
*** erlon has joined #openstack-nova | 06:03 | |
*** burt has joined #openstack-nova | 06:03 | |
*** mhen has joined #openstack-nova | 06:07 | |
*** trungnv has quit IRC | 06:16 | |
*** ccamacho has quit IRC | 06:20 | |
*** ccamacho has joined #openstack-nova | 06:41 | |
*** ccamacho has quit IRC | 06:49 | |
*** ccamacho has joined #openstack-nova | 06:51 | |
openstackgerrit | Yikun Jiang proposed openstack/nova master: Use new ``initial_xxx_allocation_ratio`` CONF https://review.openstack.org/602804 | 07:00 |
openstackgerrit | Yikun Jiang proposed openstack/nova master: Add ratio online data migration when load compute node https://review.openstack.org/613499 | 07:00 |
openstackgerrit | Yikun Jiang proposed openstack/nova master: Add compute_node ratio online data migration https://review.openstack.org/609995 | 07:06 |
*** sahid has joined #openstack-nova | 07:11 | |
*** erlon has quit IRC | 07:12 | |
*** helenafm has joined #openstack-nova | 07:15 | |
*** rcernin has quit IRC | 07:22 | |
*** bauzas is now known as bauwser | 07:35 | |
*** Dinesh_Bhor has quit IRC | 07:39 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add recreate test for bug 1799892 https://review.openstack.org/613304 | 07:42 |
openstack | bug 1799892 in OpenStack Compute (nova) "Placement API crashes with 500s in Rocky upgrade with downed compute nodes" [Undecided,New] https://launchpad.net/bugs/1799892 | 07:42 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Consider root id is None in the database case https://review.openstack.org/613305 | 07:42 |
*** hshiina has quit IRC | 07:44 | |
openstackgerrit | mashuting proposed openstack/nova master: VMware: Support volumes backed by VStorageObject https://review.openstack.org/521690 | 07:46 |
*** helenafm is now known as mcgiggler | 07:58 | |
*** binhnd108 has quit IRC | 08:01 | |
*** binhnd108 has joined #openstack-nova | 08:01 | |
*** elod_ is now known as elod | 08:07 | |
*** Dinesh_Bhor has joined #openstack-nova | 08:18 | |
*** derekh has joined #openstack-nova | 08:23 | |
*** ccamacho has quit IRC | 08:32 | |
*** panda|off is now known as panda | 08:32 | |
*** ttsiouts has joined #openstack-nova | 08:33 | |
*** ccamacho has joined #openstack-nova | 08:33 | |
*** ttsiouts has quit IRC | 08:38 | |
*** tetsuro has quit IRC | 08:38 | |
openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Integration tests using gabbi-tempest https://review.openstack.org/613386 | 08:52 |
*** spatel has joined #openstack-nova | 08:52 | |
*** cdent has joined #openstack-nova | 08:52 | |
*** ttsiouts has joined #openstack-nova | 08:53 | |
*** spatel has quit IRC | 08:56 | |
*** lei-zh has quit IRC | 09:05 | |
*** moshele has joined #openstack-nova | 09:10 | |
*** ttsiouts has quit IRC | 09:14 | |
*** ttsiouts has joined #openstack-nova | 09:15 | |
openstackgerrit | Yikun Jiang proposed openstack/nova master: Add ratio online data migration when load compute node https://review.openstack.org/613499 | 09:19 |
*** moshele has quit IRC | 09:20 | |
*** sapd1 has quit IRC | 09:25 | |
*** alexchadin has joined #openstack-nova | 09:36 | |
*** shuquan has joined #openstack-nova | 09:57 | |
*** brinzhang has quit IRC | 10:01 | |
*** dpawlik has quit IRC | 10:03 | |
*** dpawlik_ has joined #openstack-nova | 10:03 | |
*** erlon has joined #openstack-nova | 10:07 | |
*** shuquan has quit IRC | 10:10 | |
*** lpetrut has joined #openstack-nova | 10:11 | |
*** ttsiouts has quit IRC | 10:15 | |
*** bhagyashris has quit IRC | 10:20 | |
*** jpenag is now known as jpena | 10:36 | |
*** betherly has joined #openstack-nova | 10:41 | |
*** tbachman has quit IRC | 10:48 | |
*** dtantsur|afk is now known as dtantsur | 10:48 | |
openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Integration tests using gabbi-tempest https://review.openstack.org/613386 | 10:49 |
openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Integration tests using gabbi-tempest https://review.openstack.org/613386 | 10:52 |
*** alexchadin has quit IRC | 10:52 | |
openstackgerrit | Yikun Jiang proposed openstack/nova master: Add ratio online data migration when load compute node https://review.openstack.org/613499 | 10:53 |
openstackgerrit | Yikun Jiang proposed openstack/nova master: Add compute_node ratio online data migration script https://review.openstack.org/609995 | 10:53 |
*** jpena is now known as jpena|lunch | 11:01 | |
*** tridde is now known as trident | 11:17 | |
*** Dinesh_Bhor has quit IRC | 11:22 | |
*** udesale has quit IRC | 11:28 | |
*** panda is now known as panda|lunch | 11:29 | |
*** janki has quit IRC | 11:36 | |
*** ttsiouts has joined #openstack-nova | 11:48 | |
*** sahid has quit IRC | 11:48 | |
*** jpena|lunch is now known as jpena | 11:57 | |
*** ratailor has quit IRC | 12:04 | |
*** liuyulong has joined #openstack-nova | 12:09 | |
*** tbachman has joined #openstack-nova | 12:20 | |
*** panda|lunch is now known as panda | 12:24 | |
*** eharney has joined #openstack-nova | 12:25 | |
*** tbachman has quit IRC | 12:27 | |
*** sahid has joined #openstack-nova | 12:27 | |
*** cdent has quit IRC | 12:30 | |
*** tbachman has joined #openstack-nova | 12:35 | |
jaypipes | aspiers: +2 from me. | 12:39 |
*** ttsiouts has quit IRC | 12:51 | |
*** cdent has joined #openstack-nova | 12:58 | |
*** derekh has quit IRC | 13:01 | |
jaypipes | efried: done | 13:02 |
*** derekh has joined #openstack-nova | 13:04 | |
*** derekh has quit IRC | 13:04 | |
*** derekh has joined #openstack-nova | 13:05 | |
*** pooja_jadhav has quit IRC | 13:14 | |
*** mpasserini has joined #openstack-nova | 13:17 | |
mpasserini | Hi, what is the service which has the task of creating the ephemeral volumes on the compute nodes? Nova-compute? | 13:18 |
*** dpawlik_ has quit IRC | 13:18 | |
*** spatel has joined #openstack-nova | 13:19 | |
*** mriedem has joined #openstack-nova | 13:19 | |
*** dpawlik has joined #openstack-nova | 13:20 | |
*** efried is now known as fried_rice | 13:23 | |
*** ratailor has joined #openstack-nova | 13:24 | |
mriedem | dansmith: i'd ping tssurya, but she's not around and it seems you're updating the down cell series. i've gone up through https://review.openstack.org/#/c/584829/ | 13:34 |
dansmith | mriedem: just going through my gerrit mail right now | 13:35 |
*** ratailor has quit IRC | 13:35 | |
mriedem | i've got comments/questions in the changes with +1s too, so you could look at those as well. like wondering about applying limits when listing from down cells. | 13:35 |
mriedem | seems we could do that, but we don't. | 13:35 |
dansmith | roger | 13:36 |
mriedem | cdent: requests.GET question for you, if i have a call like GET /servers?all_tenants=1&project_id=1&project_id=2, does that result in {'project_id': [1,2]} ? | 13:48 |
mriedem | with the all_tenants key in the dict as well, but i care about the double project_id | 13:49 |
cdent | mriedem: I think it depends on how you are making the call. let me refresh my memory | 13:49 |
cdent | mriedem: looks like you need getall to get what you want: https://docs.pylonsproject.org/projects/webob/en/stable/reference.html#query-post-variables | 13:50 |
cdent | GET() will get you both, in tuples | 13:51 |
*** spatel has quit IRC | 13:51 | |
cdent | GET[key] gets the second, getall(key) gets both | 13:51 |
*** med_ has joined #openstack-nova | 13:51 | |
mriedem | ok i forgot about getall(), i think i found the list of tuples while digging through requests code yesterday | 13:51 |
* cdent stares blankly at the slow gate | 13:52 | |
*** med_ has quit IRC | 13:52 | |
mriedem | ok and looking at the list servers code, the only param we do getall on is 'status' so you can filter the list of servers on multiple status values, anything else would just be whatever the last entry is in the query string | 13:53 |
*** awaugama has joined #openstack-nova | 13:53 | |
mriedem | we don't document that of course, but that's what i'm seeing | 13:53 |
mriedem | i just wasn't sure how search_opts.update(req.GET) would work | 13:53 |
*** bnemec has joined #openstack-nova | 13:54 | |
cdent | there are lots of things about the nova-api that are "unique" | 13:55 |
*** munimeha1 has joined #openstack-nova | 13:57 | |
*** mlavalle has joined #openstack-nova | 14:01 | |
*** Luzi has quit IRC | 14:03 | |
*** cdent has quit IRC | 14:05 | |
openstackgerrit | Jay Pipes proposed openstack/nova-specs master: Standardize CPU resource tracking https://review.openstack.org/555081 | 14:09 |
jaypipes | fried_rice, stephenfin, artom, alex_xu: thx for the reviews. I think I got all of your comments. please check it again. thanks in advance! mriedem, I added a bunch more to the upgrade impact section. ^^ | 14:10 |
*** jaypipes is now known as leakypipes | 14:10 | |
fried_rice | ack | 14:10 |
*** artom is now known as temka | 14:10 | |
*** dave-mccowan has joined #openstack-nova | 14:11 | |
*** spatel has joined #openstack-nova | 14:14 | |
*** luksky has joined #openstack-nova | 14:14 | |
*** dave-mccowan has quit IRC | 14:15 | |
*** spatel has quit IRC | 14:18 | |
*** dpawlik has quit IRC | 14:19 | |
*** ttsiouts has joined #openstack-nova | 14:20 | |
*** stephenfin is now known as finucannot | 14:22 | |
*** dpawlik has joined #openstack-nova | 14:24 | |
finucannot | mriedem: This is another one of those changes that I thought would require a microversion but apparently does not. The output is wrong but it doesn't raise a HTTP 5xx https://review.openstack.org/#/c/608685/ | 14:25 |
finucannot | What distinguishes a fix from this from, say, modifying the output of os-hypervisor to respect (cpu|ram)_allocation_ratio. Both are currently giving "wrong" output | 14:26 |
mriedem | i don't have a good answer for that except the os-hypervisors stuff has been around forever and i don't know if including allocation ratios in that calculation would be considered by all to be "right" | 14:29 |
*** dpawlik has quit IRC | 14:29 | |
*** cdent has joined #openstack-nova | 14:29 | |
finucannot | Yeah, probably not the best example | 14:30 |
finucannot | mriedem: Would it be fair to ask for 'bug'-type reno for these kind of changes, in that case? | 14:30 |
finucannot | I'm thinking of the case where different clouds would give different results for what's supposed to be the same version | 14:30 |
mriedem | i wouldn't say it's unfair, although this simple tenant usage thing lpetrut is fixing is admin-only by default | 14:31 |
mriedem | non-admins can't list usage across all tenants | 14:31 |
*** mpasserini has left #openstack-nova | 14:31 | |
mriedem | so that's not really an interop concern | 14:31 |
finucannot | Ohh, I didn't know that. In that case, not an issue here | 14:32 |
mriedem | well, | 14:32 |
mriedem | his change isn't specific to list (admin), it's also show (non-admin) | 14:33 |
mriedem | so idk, if you want a "fixes" release note then ask for one | 14:33 |
mriedem | "paging was broken, now it's fixed" | 14:33 |
finucannot | Yeah, I think I will. Probably makes sense assuming we want to backport this too (and to alert folks who'd want this downstream) | 14:34 |
mriedem | in general, we don't have a great formula for when a microversion is required. obviously major behavior changes that people need to opt into. and request/response schema changes. but there are so many other behavior-ish and bug fix type things that could be argued require a microversion we'd never do anything | 14:35 |
mriedem | or we'd have a thousand microversions by now | 14:35 |
mriedem | e.g. the trusted VFs thing from sahid technically could have required a microversion | 14:35 |
*** jackding has joined #openstack-nova | 14:35 | |
mriedem | and your requested networks physnet stuff | 14:36 |
finucannot | All good points | 14:37 |
finucannot | Clearly my "must raise HTTP 5xx" rule is too rigid | 14:37 |
openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Integration tests using gabbi-tempest https://review.openstack.org/613386 | 14:37 |
openstackgerrit | Lucian Petrut proposed openstack/nova master: Fix os-simple-tenant-usage result order https://review.openstack.org/608685 | 14:45 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix os-simple-tenant-usage result order https://review.openstack.org/608685 | 14:47 |
mriedem | i can't figure out for the life of me why i can't send a RequestSpec object to prep_resize over rpc https://gist.github.com/mriedem/9fce3c68336f8abb5d4753c156d8f96f but we pass RequestSpec objects over rpc in several other places, like build_and_run_instance and select_destinations | 14:50 |
mriedem | there is an old oslo.messaging bug for the fake impl rpc driver https://bugs.launchpad.net/oslo.messaging/+bug/1529084 but how does that not break on those other calls? | 14:51 |
openstack | Launchpad bug 1529084 in oslo.messaging "RPC fake driver should accept datetime items for data" [Undecided,Invalid] | 14:51 |
*** tbachman has quit IRC | 14:55 | |
*** cfriesen has joined #openstack-nova | 14:56 | |
*** dansmith is now known as SteelyDan | 15:01 | |
*** dave-mccowan has joined #openstack-nova | 15:04 | |
*** dave-mccowan has quit IRC | 15:10 | |
*** itlinux has quit IRC | 15:13 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Kill @safe_connect in _get_provider_traits https://review.openstack.org/613613 | 15:22 |
fried_rice | edmondsw: ^ (and leakypipes and other haters of @safe_connect) | 15:22 |
*** gyee has joined #openstack-nova | 15:23 | |
edmondsw | fried_rice thanks | 15:24 |
*** tbachman has joined #openstack-nova | 15:24 | |
cdent | fried_rice: where does the exception go, now? | 15:24 |
* cdent is a broken record | 15:25 | |
fried_rice | cdent: up | 15:25 |
fried_rice | as it should | 15:25 |
cdent | indeed | 15:25 |
cdent | but then what? | 15:25 |
fried_rice | well, it will go the same place as the AttributeError did. | 15:25 |
fried_rice | http://184.172.12.213/04/602804/8/check/nova-in-tree-pvm/9a0e925/logs/n-cpu.txt.gz#_Oct_26_02_24_17_490196 | 15:25 |
cdent | okay, but surely that's not enough | 15:26 |
*** moshele has joined #openstack-nova | 15:26 | |
cdent | either the attributeerror of the keystone error needs to be handled in some approrpriate fashion | 15:26 |
cdent | s/of/or/ | 15:26 |
fried_rice | It's really just so we can know what actually happened rather than having to rely on the tribal knowledge that when a placement helper method returns None, it's probably because comm failed. | 15:27 |
cdent | (re that link: my eyes!!!!) | 15:27 |
fried_rice | Getting rid of @safe_connect is mostly about ^ that, not about doing something more appropriate with the now-not-as-mysterious exception. That would be a separate thing. | 15:27 |
fried_rice | cdent: hold on, we've got some of my log coloring experimental code on that server, I think there's a secret option to change themes... | 15:28 |
*** moshele has quit IRC | 15:29 | |
cdent | sure, but the reason safe_connect existed in the first place was to do some kind of "right thing" when comm's failed. what's wrong here is that safe_connect is broken, not that it exists | 15:29 |
cdent | safe_connect was supposed provided away for interactions with the placement api to be correctly retried (or logged) when things went awry | 15:30 |
cdent | somewhere along the way it lost that and became simply a bad thing that returned None when it shouldn't | 15:30 |
cdent | There's no doubt (at all) that it is a bad thing, now. But the lost of the intention is also a bad thing. | 15:30 |
cdent | If we're cool with the idea of removing it (because its masks real things that need to be fixed) will to stuff actually being fixed, cool | 15:31 |
fried_rice | in this case, the next spin through the periodic will hopefully work. | 15:31 |
cdent | that seems an odd approach to take, to me | 15:31 |
fried_rice | That's "retry" | 15:31 |
fried_rice | or if this call happened as the result of an actual operation, we've got retries built in, IIRC. Sec... | 15:32 |
cdent | because the next periodic could be many minutes away if the deployer has chosen to do so | 15:32 |
fried_rice | Yeah, and if an operation isn't happening, who cares | 15:32 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Pass request_spec from compute to cell conductor on reschedule https://review.openstack.org/582417 | 15:32 |
cdent | if the failed request was e.g., updating inventory, scheduling will go wrong during that window | 15:33 |
cdent | What I'm trying to get at here is that I suspect (actually, am confident that) the system is more complex than "just let the expceptions rise" can bear | 15:33 |
fried_rice | So this is all happening under the umbrella of _update, which has a retry around it for conflicts | 15:33 |
cdent | but what about for a network partition? | 15:34 |
cdent | (or things that look like a network partition (such as the load balance being reconfigured)) | 15:35 |
fried_rice | Look, I'm not disputing that we could do a better job of handling placement comm errors in this whole flow (i.e. the resource tracker). But first we have to know we're having a placement comm error. | 15:36 |
fried_rice | If we want to put in retries at some level based on ClientException, I'm all behind that. | 15:36 |
fried_rice | But that's not what this patch is for. | 15:36 |
cdent | Okay, but "handling placement comm errors" is why safe_connect was created, so simply killing it is probably not the right approach. Fixing it probably is. | 15:38 |
cdent | I'm harping on it because it is clear that the reasson for its existence has now been lost to the sands of time (because somewhere along the way it borked) | 15:39 |
cdent | But we seem to want to say "it sucks, let's just kill it" (at least jokingly) and that's not really sufficient in a distributed system. | 15:39 |
cdent | These issues will come back around again, after safe_connect has gone, and we'll realize "you know, we need to create this thing that allows us to safely connect" | 15:41 |
fried_rice | We have made several assays toward fixing it. It can't be done. Because it's at too low a level in the call stack. | 15:41 |
SteelyDan | cdent: actually safe_connect was really to handle the "have they set up placement or not" situation | 15:41 |
SteelyDan | which is why we've been talking about removing it entirely since placement became required | 15:41 |
cdent | SteelyDan: that was _one_ of the reasons, and yes, the very first reason, but very quickly it took on "deal with errors from keystoneclient" | 15:41 |
SteelyDan | yes, it has evolved | 15:42 |
openstackgerrit | Eric Fried proposed openstack/nova master: Kill @safe_connect in _get_provider_traits https://review.openstack.org/613613 | 15:42 |
cdent | we had: is it in the service catalog, then can I reach it | 15:42 |
fried_rice | cdent: added words clarifying intent --^ | 15:42 |
*** ttsiouts has quit IRC | 15:43 | |
cdent | thanks | 15:43 |
openstackgerrit | sean mooney proposed openstack/nova master: harden placement init under wsgi https://review.openstack.org/610034 | 15:44 |
cdent | I'm trying really hard to not to think to much about the resource tracker lately but sometimes I get sucked in. | 15:44 |
sean-k-mooney | cdent: ^ uses the run_once decorator | 15:45 |
fried_rice | cdent: Anything we would do to @safe_connect, beyond making it essentially a no-op shell (which isn't better than removing it IMO), would also entail a thorough audit of everywhere it is used, which is a nearly impossible task due to how many different ways and in how many layers things get called. | 15:45 |
fried_rice | For example, if we decided to make it retry, we would have to restrict the decorator to *only* single primitive API calls. We would have to remove it from all the methods that do more complex things e.g. involving multiple API calls. | 15:45 |
cdent | sean-k-mooney: yeah, thanks, reading | 15:46 |
sean-k-mooney | cdent: ill propose the placement version shortly if people are fine with it | 15:46 |
cdent | fried_rice: yes, I know, thus why I'm trying really hard not to think about the resource tracker lately. It was already really complicated before placement, and we somehow managed to make it worse, not better. | 15:47 |
fried_rice | I have made a couple of attempts, and I think SteelyDan has as well, to do something to @safe_connect itself to improve it. At some point in a review leakypipes said we should just target one usage at a time and get rid of it. Which so far has been the only approach that has gotten us to actually merge code around this. | 15:47 |
SteelyDan | yup | 15:47 |
fried_rice | cdent: I still hope that it will be better in the long run, once we've purged all the legacy stuff from this painful transitional period. | 15:47 |
fried_rice | like @safe_connect :P | 15:48 |
fried_rice | and stuff gibi has been doing lately has cleaned up some of that legacy gorp too. | 15:48 |
fried_rice | So we're getting there. | 15:48 |
* fried_rice soothes cdent | 15:48 | |
cdent | well, just to cover my ass here: If I had my druthers we never would have had safe_connect | 15:48 |
cdent | but we gots we gots | 15:49 |
cdent | i'll cope | 15:49 |
fried_rice | My dad used to say, "If frogs had wings, they wouldn't bump their asses so much." | 15:49 |
fried_rice | (I made that sound like he's dead or something. He would still say it, given the slightest opportunity.) | 15:49 |
cdent | heh | 15:49 |
*** sahid has quit IRC | 15:55 | |
*** spatel has joined #openstack-nova | 15:55 | |
cdent | sean-k-mooney: have you run the functional tests on that change? I think you're going to run into trouble with the databse fixture | 15:55 |
*** mcgiggler has quit IRC | 15:55 | |
spatel | sean-k-mooney: is there a way to find real instance hostname using virsh list command? | 15:55 |
*** itlinux has joined #openstack-nova | 15:56 | |
spatel | currently i am doing "virsh dumpxml instance-00000387 | grep nova:name" | 15:57 |
spatel | i wish it has build it function | 15:57 |
sean-k-mooney | cdent: am no but i will and see what it does not like | 15:58 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix min config value for shutdown_timeout option https://review.openstack.org/613028 | 15:58 |
cdent | sean-k-mooney: i'm doing it now, will leave a comment with the reasults | 15:58 |
sean-k-mooney | spatel: no grep is your friend in this case | 15:59 |
spatel | :) thanks | 15:59 |
*** lpetrut has quit IRC | 16:00 | |
fried_rice | cdent: btw, that log server has the ANSI color coding patch (which isn't working 100% properly - some codes don't like to turn off), not the choose-your-theme patch, so you're SOL, sorry. | 16:01 |
cdent | fair enough, as before, I'll cope | 16:01 |
fried_rice | if we ever reach a point where you're having to look at PowerVM CI logs more than once a year, I'll take that patch offa there :) | 16:02 |
cdent | ✔ | 16:03 |
openstackgerrit | Martin Midolesov proposed openstack/nova master: vmware:PropertyCollector for caching instance properties https://review.openstack.org/608278 | 16:06 |
openstackgerrit | Martin Midolesov proposed openstack/nova master: VMware: Expose esx hosts to Openstack https://review.openstack.org/613626 | 16:06 |
*** dtantsur is now known as dtantsur|afk | 16:07 | |
*** tbachman has quit IRC | 16:12 | |
*** bnemec is now known as beekneemech | 16:13 | |
*** tbachman has joined #openstack-nova | 16:14 | |
openstackgerrit | Martin Midolesov proposed openstack/nova master: VMware: Expose esx hosts to Openstack https://review.openstack.org/613626 | 16:14 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Migrate "reboot an instance" user guide docs https://review.openstack.org/612730 | 16:15 |
mriedem | fried_rice: gibi: do you see something here that i don't? https://review.openstack.org/#/c/605785/16/nova/tests/functional/test_servers.py@5275 | 16:17 |
mriedem | if i'm wrong, i'll +W | 16:17 |
openstackgerrit | Merged openstack/python-novaclient master: Fixes Python3 issue in decoding password https://review.openstack.org/604870 | 16:18 |
*** tbachman has quit IRC | 16:18 | |
fried_rice | mriedem: I didn't scrutinize tbh. If it is a redundant test, I figgered it could be removed in a fup. | 16:19 |
*** fried_rice is now known as fried_rolls | 16:20 | |
mriedem | btw, on that safe_connect thing, couldn't all of the same arguments be made for all other services nova talks to if we're worried about network drops? so that would be at least: keystone, glance, cinder, neutron, *barbican | 16:21 |
mriedem | i think the ironic driver already has it's own retry wrapper | 16:22 |
cdent | yes? | 16:22 |
cdent | we assume a lot that's can to be less easy to assume in this like edge and other blech like that | 16:23 |
cdent | s/can/going/ | 16:23 |
mriedem | oh i'm sure | 16:23 |
mriedem | ksa already has retry stuff in it too right? | 16:23 |
mordred | yup | 16:23 |
melwitt | 16:24 | |
mordred | and in sdk we have a structure for expressing per-service error codes that are safe to do automatic retries on | 16:24 |
cdent | this whole day has been a slow setup to allow mordred to do an sdk advertisement | 16:24 |
mordred | cdent: isn't htat what most days are? | 16:24 |
mriedem | we just need to rip and replace all nova's internal client things with the sdk, done! | 16:24 |
* cdent takes his cut and goes to buy beer | 16:24 | |
mordred | coming soon to a gerrit near you! | 16:25 |
*** tbachman has joined #openstack-nova | 16:25 | |
mordred | (honestly, I've got one more patch i need to write sdk-side, then I want to make y'all a couple of sake-of-argument patches so we can look at what it might be like and whether it's worth working on in earnest) | 16:26 |
mriedem | working on what? sdk in nova? | 16:27 |
mriedem | back in the first YVR summit i think dean said the service projects shouldn't use the sdk, but that was a long time ago | 16:27 |
mriedem | i think for perf reasons | 16:27 |
mriedem | but it seems kinda dumb not to | 16:27 |
*** mdbooth_ has quit IRC | 16:28 | |
leakypipes | gibi, mriedem: anyone got the link to gibi's patch series that removes the doubled-up allocation cruft for legacy evacuate code paths? | 16:29 |
leakypipes | can't find it atm | 16:29 |
mriedem | https://review.openstack.org/#/c/512623/ ? | 16:30 |
mriedem | otherwise idk what that is | 16:30 |
openstackgerrit | Merged openstack/nova master: Bump os-brick version to 2.6.1 https://review.openstack.org/611109 | 16:30 |
openstackgerrit | Merged openstack/nova master: Add API ref guideline for examples https://review.openstack.org/604060 | 16:31 |
melwitt | mriedem: s-1 release review is here. sorry I forgot to do it yesterday https://review.openstack.org/613636 | 16:31 |
*** dave-mccowan has joined #openstack-nova | 16:33 | |
mriedem | done | 16:34 |
*** mriedem is now known as mriedem_away | 16:34 | |
melwitt | thx | 16:34 |
melwitt | mnaser: do you ever use beta releases of nova? as of http://lists.openstack.org/pipermail/openstack-dev/2018-September/135088.html beta releases are optional and I wasn't sure if operators use them or not | 16:41 |
melwitt | I proposed a s-1 release out of habit and release folk asked if anyone needed it and to consider not doing a beta release. so just trying to find out if operators we know use them | 16:42 |
*** ShilpaSD has quit IRC | 16:43 | |
*** luksky has quit IRC | 16:48 | |
mnaser | I haven’t ever really played with them. Only RCs | 16:49 |
melwitt | ok, thanks | 16:49 |
*** jangutter has quit IRC | 16:50 | |
*** dave-mccowan has quit IRC | 16:58 | |
*** derekh has quit IRC | 16:58 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Stop build *all* docs in 'docs' https://review.openstack.org/613645 | 17:01 |
*** bauwser is now known as bauzas | 17:01 | |
finucannot | fried_rolls: You'd probably appreciate that ^ | 17:01 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Fail to live migration if instance has a NUMA topology https://review.openstack.org/611088 | 17:02 |
*** betherly has quit IRC | 17:03 | |
*** zul has joined #openstack-nova | 17:04 | |
*** jpena is now known as jpena|off | 17:06 | |
*** lpetrut has joined #openstack-nova | 17:08 | |
*** ralonsoh has quit IRC | 17:23 | |
*** mlavalle has quit IRC | 17:23 | |
*** bexigastack has joined #openstack-nova | 17:28 | |
bexigastack | hello all | 17:28 |
bexigastack | i have a quick question that someone here could possibly answer quickly | 17:28 |
bexigastack | i've got cinder handling nfs mounts served from a netapp in c-mode | 17:29 |
bexigastack | everything is working as expected | 17:29 |
bexigastack | i am having an issue when launching an instance on a compute node where that nfs share is already mounted | 17:30 |
bexigastack | nova attempts to mount it before launching a second instance but is hit with: | 17:30 |
bexigastack | Command: mount -t nfs nfsserver.dns.name:/OPENSTACK_MOUNT/OPENSTACK_CLOUD_1 /var/lib/nova/mnt/787b0fb4b865db5b3b3c9d305128af32 | 17:31 |
bexigastack | Exit code: 32 | 17:31 |
bexigastack | Stdout: u'' | 17:31 |
bexigastack | Stderr: u'mount.nfs: /var/lib/nova/mnt/787b0fb4b865db5b3b3c9d305128af32 is busy or already mounted\n' | 17:31 |
*** mlavalle has joined #openstack-nova | 17:31 | |
bexigastack | oh woops - i think i am in the wrong channel - this is used for development | 17:32 |
bexigastack | appologies - i will use #openstack | 17:32 |
*** lbragstad is now known as elbragstad | 17:37 | |
*** Swami has joined #openstack-nova | 17:38 | |
*** jding1_ has quit IRC | 17:39 | |
*** cdent has quit IRC | 18:03 | |
*** munimeha1 has quit IRC | 18:11 | |
*** tbachman has quit IRC | 18:22 | |
*** mriedem_away is now known as mriedem | 18:28 | |
openstackgerrit | Merged openstack/nova master: Reject forced move with nested source allocation https://review.openstack.org/605785 | 18:31 |
openstackgerrit | Merged openstack/nova master: api-ref: Remove unnecessary minimum microversion https://review.openstack.org/613226 | 18:31 |
openstackgerrit | Merged openstack/nova master: Add a hacking rule for deprecated assertion methods https://review.openstack.org/613184 | 18:31 |
*** medberry is now known as med_ | 18:31 | |
*** munimeha1 has joined #openstack-nova | 18:33 | |
melwitt | SteelyDan, leakypipes: are either of you willing to please review this nova-status upgrade check that warns if the deployment is using consoles to set the [workarounds]enable_consoleauth = True config option if performing a live/rolling upgrade? https://review.openstack.org/611214 we need to backport it to stable/rocky and were hoping to include it in stable/rocky release as soon as we can | 18:52 |
melwitt | mnaser: would you like to have a look at the reno update for the nova-consoleauth thing? https://review.openstack.org/613174 | 18:54 |
melwitt | and let me know if you think it's good | 18:55 |
leakypipes | melwitt: you see the py3k test failures on that? | 18:57 |
openstackgerrit | Dan Smith proposed openstack/nova master: Modify get_by_cell_and_project() to get_not_deleted_by_cell_and_projects() https://review.openstack.org/607663 | 19:01 |
openstackgerrit | Dan Smith proposed openstack/nova master: Minimal construct plumbing for nova list when a cell is down https://review.openstack.org/567785 | 19:01 |
openstackgerrit | Dan Smith proposed openstack/nova master: Refactor scatter-gather utility to return exception objects https://review.openstack.org/607934 | 19:01 |
openstackgerrit | Dan Smith proposed openstack/nova master: Minimal construct plumbing for nova show when a cell is down https://review.openstack.org/591658 | 19:01 |
openstackgerrit | Dan Smith proposed openstack/nova master: Minimal construct plumbing for nova service-list when a cell is down https://review.openstack.org/584829 | 19:01 |
melwitt | leakypipes: yes, they are unrelated, ssh timeout | 19:01 |
leakypipes | melwitt: sure? | 19:01 |
melwitt | leakypipes: yes, why? | 19:01 |
leakypipes | melwitt: ok, lemme take another look | 19:02 |
melwitt | the code change is in the 'nova-status upgrade check' CLI command which isn't running in either of those tempest tests | 19:02 |
*** fried_rolls is now known as efried | 19:07 | |
*** tbachman has joined #openstack-nova | 19:08 | |
*** erlon has quit IRC | 19:09 | |
*** efried is now known as fried_rice | 19:11 | |
openstackgerrit | Jack Ding proposed openstack/nova master: Add I/O Semaphore to limit concurrent disk ops https://review.openstack.org/609180 | 19:18 |
*** dave-mccowan has joined #openstack-nova | 19:18 | |
*** toabctl has quit IRC | 19:19 | |
*** toabctl has joined #openstack-nova | 19:21 | |
openstackgerrit | Merged openstack/nova master: Add more documentation for online_data_migrations CLI https://review.openstack.org/605836 | 19:32 |
cfriesen | mriedem: sean-k-mooney: gibi: question about the HPET spec. given that the HPET removal was not for any security reasons, and that HPET is supported by the minimum versions of qemu/libvirt, can we simplify the feature and just specify something like "hw:hpet" in the flavor/image with no way to disable it (since there's no useful reason to prevent it) | 19:35 |
cfriesen | no way for the operator to disable/block it, I mean | 19:35 |
*** lpetrut has quit IRC | 19:37 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Modify get_by_cell_and_project() to get_not_deleted_by_cell_and_projects() https://review.openstack.org/607663 | 19:54 |
openstackgerrit | Dan Smith proposed openstack/nova master: Minimal construct plumbing for nova list when a cell is down https://review.openstack.org/567785 | 19:54 |
openstackgerrit | Dan Smith proposed openstack/nova master: Refactor scatter-gather utility to return exception objects https://review.openstack.org/607934 | 19:54 |
openstackgerrit | Dan Smith proposed openstack/nova master: Minimal construct plumbing for nova show when a cell is down https://review.openstack.org/591658 | 19:54 |
openstackgerrit | Dan Smith proposed openstack/nova master: Minimal construct plumbing for nova service-list when a cell is down https://review.openstack.org/584829 | 19:54 |
*** spatel has quit IRC | 20:19 | |
*** spatel has joined #openstack-nova | 20:24 | |
*** zul has quit IRC | 20:25 | |
*** imacdonn has quit IRC | 20:32 | |
*** imacdonn has joined #openstack-nova | 20:32 | |
*** spatel has quit IRC | 20:39 | |
*** openstackstatus has quit IRC | 20:42 | |
*** openstack has joined #openstack-nova | 20:44 | |
*** ChanServ sets mode: +o openstack | 20:44 | |
*** ttsiouts has joined #openstack-nova | 20:46 | |
*** awaugama has quit IRC | 20:47 | |
*** munimeha1 has quit IRC | 20:53 | |
*** spatel has joined #openstack-nova | 20:58 | |
*** ttsiouts has quit IRC | 20:58 | |
*** spatel has quit IRC | 21:02 | |
*** jamesdenton has quit IRC | 21:11 | |
*** eharney has quit IRC | 21:12 | |
openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Expose virtual device tags in REST API https://review.openstack.org/393930 | 21:21 |
mriedem | cfriesen: idk, i'd have to context switch the hpet stuff all back into my brain | 21:29 |
openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Expose virtual device tags in REST API https://review.openstack.org/393930 | 21:29 |
mriedem | cfriesen: if it's as simple as just adding a new image property b/c it's not some kind of security related issue people would want to disable, and maybe (or maybe not) tied to arch of the guest image, then it seems just having an image property would be OK, expecially since it sounds like it's really just a use case for legacy OSes | 21:31 |
mriedem | i'm not sure why it would even need to be a flavor extra spec really | 21:31 |
mriedem | that would probably be better than doing a bunch of discovery to determine if hpet is possible on a host and exposing that as yet another trait | 21:34 |
cfriesen | at least for qemu it doesn't seem to have any security implications as there are other more accurate time sources anyway. I think an image property makes the most sense, and I don't think any discovery is needed | 21:37 |
mriedem | os_wind_river_special_knob_hpet=true seems ok to me | 21:37 |
cfriesen | lol | 21:37 |
cfriesen | okay. I'll talk to Jack, we'll respin with it as simple as possible and the justification for the simplicity | 21:38 |
cfriesen | one thing...can we specify the hypervisor type somehow? because we do need to land on a qemu node | 21:40 |
mriedem | isn't that an existing image property? | 21:40 |
mriedem | https://docs.openstack.org/glance/latest/admin/useful-image-properties.html | 21:40 |
mriedem | hypervisor_type | 21:41 |
mriedem | "Note that qemu is used for both QEMU and KVM hypervisor types." | 21:41 |
mriedem | hmm | 21:41 |
mriedem | is that a problem? | 21:41 |
mriedem | i.e. is a kvm node a problem? | 21:41 |
cfriesen | no, qemu/kvm is fine | 21:42 |
mriedem | then i think you're covered | 21:42 |
cfriesen | yeah, between hypervisor_type and architecture, I think we're good. | 21:42 |
cfriesen | thanks | 21:42 |
mriedem | np | 21:43 |
*** mriedem has quit IRC | 21:52 | |
*** tbachman_ has joined #openstack-nova | 22:02 | |
*** tbachman has quit IRC | 22:04 | |
*** tbachman_ is now known as tbachman | 22:04 | |
*** burt has quit IRC | 22:04 | |
*** itlinux has quit IRC | 22:05 | |
*** tbachman_ has joined #openstack-nova | 22:17 | |
*** tbachman has quit IRC | 22:17 | |
*** tbachman_ is now known as tbachman | 22:17 | |
*** pcaruana has quit IRC | 23:10 | |
*** Swami has quit IRC | 23:43 | |
*** rcernin has joined #openstack-nova | 23:43 | |
*** rcernin has quit IRC | 23:51 | |
*** itlinux has joined #openstack-nova | 23:51 | |
*** gyee has quit IRC | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!