| *** takashin has joined #openstack-nova | 00:10 | |
| *** slaweq has joined #openstack-nova | 00:11 | |
| *** slaweq has quit IRC | 00:24 | |
| *** brinzhang has joined #openstack-nova | 01:00 | |
| *** slaweq has joined #openstack-nova | 01:16 | |
| *** artom has quit IRC | 01:23 | |
| *** slaweq has quit IRC | 01:24 | |
| *** artom has joined #openstack-nova | 01:28 | |
| *** spatel has joined #openstack-nova | 01:48 | |
| *** slaweq has joined #openstack-nova | 02:16 | |
| openstackgerrit | zhufl proposed openstack/nova master: Add missing ws seperator between words https://review.openstack.org/618491 | 02:20 |
|---|---|---|
| *** slaweq has quit IRC | 02:24 | |
| *** tbachman has quit IRC | 02:27 | |
| *** sridharg has joined #openstack-nova | 02:29 | |
| *** sambetts_ has quit IRC | 02:35 | |
| *** mrsoul has quit IRC | 02:35 | |
| *** sambetts_ has joined #openstack-nova | 02:39 | |
| *** owalsh_ has joined #openstack-nova | 02:44 | |
| *** psachin has joined #openstack-nova | 02:46 | |
| *** owalsh has quit IRC | 02:48 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Consider root id is None in the database case https://review.openstack.org/613305 | 02:52 |
| *** slaweq has joined #openstack-nova | 03:11 | |
| *** tbachman has joined #openstack-nova | 03:19 | |
| *** slaweq has quit IRC | 03:25 | |
| *** udesale has joined #openstack-nova | 03:51 | |
| *** slaweq has joined #openstack-nova | 04:14 | |
| *** janki has joined #openstack-nova | 04:24 | |
| *** slaweq has quit IRC | 04:25 | |
| *** spatel has quit IRC | 04:26 | |
| openstackgerrit | Merged openstack/nova master: Fix regression in glance client call https://review.openstack.org/618534 | 04:33 |
| openstackgerrit | Merged openstack/nova master: doc: Rewrite the console doc https://review.openstack.org/606148 | 04:34 |
| openstackgerrit | Merged openstack/nova master: doc: Add minimal documentation for RDP consoles https://review.openstack.org/606992 | 04:34 |
| openstackgerrit | Merged openstack/nova master: doc: Add minimal documentation for MKS consoles https://review.openstack.org/606993 | 04:34 |
| *** ivve has joined #openstack-nova | 04:37 | |
| *** bhagyashris has joined #openstack-nova | 04:46 | |
| *** diga has joined #openstack-nova | 04:50 | |
| *** ircuser-1 has joined #openstack-nova | 04:51 | |
| *** cfriesen has joined #openstack-nova | 04:55 | |
| *** bhagyashris has quit IRC | 04:59 | |
| *** slaweq has joined #openstack-nova | 05:16 | |
| openstackgerrit | zhufl proposed openstack/nova master: Add missing ws seperator between words https://review.openstack.org/618491 | 05:17 |
| *** pooja_jadhav has joined #openstack-nova | 05:22 | |
| *** slaweq has quit IRC | 05:24 | |
| *** bhagyashris has joined #openstack-nova | 05:32 | |
| *** ratailor has joined #openstack-nova | 05:56 | |
| *** moshele has joined #openstack-nova | 06:10 | |
| *** slaweq has joined #openstack-nova | 06:11 | |
| *** moshele has quit IRC | 06:13 | |
| *** slaweq has quit IRC | 06:24 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:25 | |
| *** fanzhang has joined #openstack-nova | 06:44 | |
| *** belmoreira has joined #openstack-nova | 06:46 | |
| *** Luzi has joined #openstack-nova | 07:03 | |
| *** ratailor has quit IRC | 07:03 | |
| *** ratailor has joined #openstack-nova | 07:05 | |
| *** mrsoul has joined #openstack-nova | 07:18 | |
| *** ccamacho has joined #openstack-nova | 07:20 | |
| *** pcaruana has joined #openstack-nova | 07:24 | |
| *** trident has quit IRC | 07:29 | |
| *** belmoreira has quit IRC | 07:30 | |
| *** belmoreira has joined #openstack-nova | 07:31 | |
| *** trident has joined #openstack-nova | 07:31 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:41 | |
| bhagyashris | artom: Hi, | 07:42 |
| *** hoonetorg has quit IRC | 07:55 | |
| *** alexchadin has joined #openstack-nova | 07:57 | |
| *** sahid has joined #openstack-nova | 07:58 | |
| *** Dinesh_Bhor has quit IRC | 08:00 | |
| *** jangutter has joined #openstack-nova | 08:06 | |
| *** slaweq has joined #openstack-nova | 08:11 | |
| *** hoonetorg has joined #openstack-nova | 08:13 | |
| *** slaweq has quit IRC | 08:16 | |
| *** pooja_jadhav has quit IRC | 08:38 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:40 | |
| *** mhen has joined #openstack-nova | 08:45 | |
| *** jpena|off is now known as jpena | 08:48 | |
| *** bhdn has quit IRC | 08:51 | |
| *** cfriesen has quit IRC | 08:56 | |
| *** pooja_jadhav has joined #openstack-nova | 08:58 | |
| *** diga has quit IRC | 09:03 | |
| *** s10 has joined #openstack-nova | 09:10 | |
| *** kukacz has quit IRC | 09:10 | |
| *** slaweq has joined #openstack-nova | 09:11 | |
| *** sahid has quit IRC | 09:13 | |
| *** sahid has joined #openstack-nova | 09:13 | |
| *** kukacz has joined #openstack-nova | 09:13 | |
| *** owalsh_ is now known as owalsh | 09:15 | |
| *** alexchadin has quit IRC | 09:17 | |
| melwitt | frickler: thanks for jumping on that. agreed we should consider making the ceph job voting | 09:20 |
| * melwitt returns to PTO | 09:20 | |
| *** takashin has left #openstack-nova | 09:30 | |
| *** jsheeren has joined #openstack-nova | 09:34 | |
| jsheeren | hi all I was curious about an issue we ran into | 09:34 |
| *** derekh has joined #openstack-nova | 09:34 | |
| jsheeren | we have an Opensack Pike env and we're using NFS as shared storage for /var/lib/nova/instances | 09:35 |
| jsheeren | our env consists of 29 compute nodes, each has a mount to the volume for shared storage | 09:36 |
| kashyap | melwitt: Have fun; and try to disconnect :-) | 09:36 |
| jsheeren | we noticed the latency on that volume becoming very high and we were getting api timeouts. (with rabbitmq time-outs) | 09:37 |
| jsheeren | our suspicion is the image cache manager as a cause of the latencies. when we did a rolling restart of nova-compute services (with a 5 min delay between them); the latency was gone | 09:39 |
| jsheeren | and we are not seeing the api time-outs any more. | 09:39 |
| *** bhagyashris has quit IRC | 09:40 | |
| jsheeren | has anyone had a similar experience? we increased the image cache manager interval as well, from the default 2400 sec to 4800 sec | 09:40 |
| *** jaosorior has joined #openstack-nova | 09:41 | |
| *** tssurya has joined #openstack-nova | 09:42 | |
| jsheeren | it seems the crawling of the /var/lib/nova tree takes longer than the message time-out. so we also increased the rcp_response time-out | 09:43 |
| jsheeren | there are approx 700 instances on the env btw | 09:43 |
| *** maciejjozefczyk has quit IRC | 09:50 | |
| *** cdent has joined #openstack-nova | 09:51 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Call migrate_volume_completion after cinder migrate https://review.openstack.org/618717 | 09:55 |
| *** brinzhang has quit IRC | 09:58 | |
| *** brinzhang has joined #openstack-nova | 09:59 | |
| *** brinzhang has quit IRC | 10:00 | |
| *** brinzhang has joined #openstack-nova | 10:01 | |
| *** sridharg has quit IRC | 10:05 | |
| *** k_mouza has joined #openstack-nova | 10:06 | |
| *** brinzhang has quit IRC | 10:08 | |
| *** brinzhang has joined #openstack-nova | 10:09 | |
| *** sean-k-mooney has quit IRC | 10:15 | |
| *** Dinesh_Bhor has quit IRC | 10:17 | |
| *** sean-k-mooney has joined #openstack-nova | 10:23 | |
| *** betherly has joined #openstack-nova | 10:27 | |
| *** toabctl has quit IRC | 10:33 | |
| *** maciejjozefczyk has joined #openstack-nova | 10:35 | |
| *** moshele has joined #openstack-nova | 10:36 | |
| tobias-urdin | melwitt: we did hit this bug in rocky today https://review.openstack.org/#/c/591080/ | 10:39 |
| tobias-urdin | would that be acceptable for backport? | 10:39 |
| *** panda|rover|off is now known as panda|rover | 10:49 | |
| *** cdent has quit IRC | 10:57 | |
| *** udesale has quit IRC | 11:06 | |
| openstackgerrit | Vlad Gusev proposed openstack/nova stable/rocky: Handle unicode characters in migration params https://review.openstack.org/618734 | 11:11 |
| *** janki has quit IRC | 11:18 | |
| openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: implement trigger crash dump https://review.openstack.org/618736 | 11:20 |
| *** pooja_jadhav has quit IRC | 11:20 | |
| openstackgerrit | Jason SUN proposed openstack/nova master: For instances end up in cell0, set its availability_zone to None. https://review.openstack.org/618737 | 11:25 |
| *** rodolof has joined #openstack-nova | 11:29 | |
| *** moshele has quit IRC | 11:34 | |
| *** k_mouza has quit IRC | 11:38 | |
| *** k_mouza has joined #openstack-nova | 11:39 | |
| *** moshele has joined #openstack-nova | 11:40 | |
| *** moshele has quit IRC | 11:44 | |
| *** sridharg has joined #openstack-nova | 11:44 | |
| *** janki has joined #openstack-nova | 11:49 | |
| *** pooja_jadhav has joined #openstack-nova | 12:03 | |
| tobias-urdin | is it possible to flush the entries in instance_system_metadata for an instance manually without breaking something? there is cached content on user and project which is incorrect | 12:09 |
| tobias-urdin | i assume the only other wait to force a rewrite of those values in the xml would be a hard reboot, but not sure that would do the trick either | 12:09 |
| *** moshele has joined #openstack-nova | 12:17 | |
| *** cdent has joined #openstack-nova | 12:19 | |
| *** moshele has quit IRC | 12:23 | |
| *** brinzhang has quit IRC | 12:24 | |
| *** ratailor has quit IRC | 12:24 | |
| *** sahid has quit IRC | 12:25 | |
| *** ondrejme has joined #openstack-nova | 12:25 | |
| *** jaypipes has joined #openstack-nova | 12:26 | |
| *** rodolof has quit IRC | 12:29 | |
| *** rodolof has joined #openstack-nova | 12:30 | |
| *** jpena is now known as jpena|lunch | 12:31 | |
| *** ccamacho has quit IRC | 12:31 | |
| *** sahid has joined #openstack-nova | 12:31 | |
| *** ccamacho has joined #openstack-nova | 12:33 | |
| *** mriedem has joined #openstack-nova | 12:55 | |
| *** dave-mccowan has joined #openstack-nova | 12:56 | |
| *** moshele has joined #openstack-nova | 12:56 | |
| *** udesale has joined #openstack-nova | 13:08 | |
| *** moshele has quit IRC | 13:09 | |
| *** udesale has quit IRC | 13:11 | |
| *** udesale has joined #openstack-nova | 13:11 | |
| *** jsheeren has quit IRC | 13:12 | |
| *** cdent has quit IRC | 13:13 | |
| *** sapd1 has joined #openstack-nova | 13:13 | |
| *** k_mouza has quit IRC | 13:14 | |
| *** tetsuro has joined #openstack-nova | 13:20 | |
| *** tbachman has quit IRC | 13:20 | |
| *** takashin has joined #openstack-nova | 13:21 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add os_compute_api:servers:create:cell_down policy https://review.openstack.org/614783 | 13:25 |
| *** jpena|lunch is now known as jpena | 13:29 | |
| *** k_mouza has joined #openstack-nova | 13:31 | |
| *** k_mouza_ has joined #openstack-nova | 13:33 | |
| *** k_mouza has quit IRC | 13:36 | |
| *** dave-mccowan has quit IRC | 13:36 | |
| *** psachin has quit IRC | 13:37 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add os_compute_api:servers:create:cell_down policy https://review.openstack.org/614783 | 13:41 |
| *** tbachman has joined #openstack-nova | 13:45 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add DownCellFixture https://review.openstack.org/614810 | 13:46 |
| *** mvkr has quit IRC | 13:47 | |
| *** tbachman_ has joined #openstack-nova | 13:48 | |
| *** moshele has joined #openstack-nova | 13:50 | |
| *** cdent has joined #openstack-nova | 13:50 | |
| *** tbachman has quit IRC | 13:51 | |
| *** tbachman_ is now known as tbachman | 13:51 | |
| *** moshele has quit IRC | 13:54 | |
| *** cdent has quit IRC | 13:55 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add API ref guideline for body text https://review.openstack.org/605628 | 14:03 |
| *** moshele has joined #openstack-nova | 14:03 | |
| *** ccamacho has quit IRC | 14:04 | |
| *** cdent has joined #openstack-nova | 14:05 | |
| *** moshele has quit IRC | 14:06 | |
| *** ccamacho has joined #openstack-nova | 14:08 | |
| *** lbragstad has joined #openstack-nova | 14:09 | |
| *** awaugama has joined #openstack-nova | 14:11 | |
| openstackgerrit | Josephine Seifert proposed openstack/nova-specs master: Spec for the Nova part of Image Encryption https://review.openstack.org/608696 | 14:12 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix server query examples https://review.openstack.org/616834 | 14:32 |
| *** k_mouza has joined #openstack-nova | 14:34 | |
| *** mvkr has joined #openstack-nova | 14:35 | |
| *** k_mouza_ has quit IRC | 14:37 | |
| *** mchlumsky has joined #openstack-nova | 14:43 | |
| *** burt has joined #openstack-nova | 14:44 | |
| *** tetsuro has quit IRC | 14:55 | |
| openstackgerrit | Elod Illes proposed openstack/nova master: Transform scheduler.select_destinations notification https://review.openstack.org/508506 | 14:56 |
| mriedem | jackding: some small changes for https://review.openstack.org/#/c/605902/ and then i'm +2 | 14:56 |
| mriedem | plus the glance image docs | 14:56 |
| *** cfriesen has joined #openstack-nova | 14:58 | |
| *** mlavalle has joined #openstack-nova | 15:00 | |
| *** mdbooth has quit IRC | 15:01 | |
| *** k_mouza_ has joined #openstack-nova | 15:01 | |
| *** sapd1 has quit IRC | 15:02 | |
| *** k_mouza__ has joined #openstack-nova | 15:02 | |
| *** Luzi has quit IRC | 15:03 | |
| jackding | mriedem: ok thanks | 15:04 |
| *** spatel has joined #openstack-nova | 15:04 | |
| spatel | sean-k-mooney: morning!!! | 15:04 |
| *** k_mouza has quit IRC | 15:04 | |
| *** takashin has left #openstack-nova | 15:05 | |
| *** k_mouza_ has quit IRC | 15:06 | |
| *** sapd1 has joined #openstack-nova | 15:09 | |
| *** slaweq_ has joined #openstack-nova | 15:10 | |
| *** slaweq has quit IRC | 15:12 | |
| *** spatel has left #openstack-nova | 15:13 | |
| *** k_mouza__ has quit IRC | 15:17 | |
| *** spatel_ has joined #openstack-nova | 15:17 | |
| sean-k-mooney | hello | 15:19 |
| spatel_ | how are you ? | 15:19 |
| spatel_ | i had question related multi-queue for virt-io | 15:20 |
| sean-k-mooney | not too bad. just rootcaused an issue in some logs so feeling quite good | 15:20 |
| *** sapd1 has quit IRC | 15:20 | |
| spatel_ | if i have 8 vCPU on instance in that queue what value should be good to set in ethtool -L eth0 combined <N> ? | 15:21 |
| sean-k-mooney | 8 | 15:22 |
| sean-k-mooney | when you enable multiqueue openstack will allocate a tx and rx pair per core | 15:22 |
| spatel_ | i thought i should keep some CPU core for other work | 15:24 |
| spatel_ | This is what i am doing so far may be i am wrong here.. if i create 16 vCPU machine then i assign only 8 queue | 15:24 |
| spatel_ | if i create 8 vCPU machine then i create 4 queue | 15:25 |
| spatel_ | am i doing something wrong doing that or best practice is to give vCPU = Queue size | 15:25 |
| sean-k-mooney | assinging a queue does nto mean you are assinging a cpu to manage it | 15:26 |
| sean-k-mooney | the vswitch cannot know which queue the os is using so it will assume it can enqueue packets to all of them | 15:26 |
| sean-k-mooney | if you dont config the kernel to pool on all queue you will miss packets | 15:27 |
| *** jaypipes has quit IRC | 15:27 | |
| sean-k-mooney | you can have one guess cpu pool all queue if you want | 15:27 |
| spatel_ | so best option is to give all queue right? | 15:28 |
| spatel_ | 8 vCPU = 8 queue ? | 15:28 |
| sean-k-mooney | by assingin 1 queue per cpus its allows apps to transmit without haveing to take locks as you can use the cpu id as a queue index | 15:28 |
| sean-k-mooney | yes | 15:28 |
| sean-k-mooney | but your application that is processign the traffic in the vm can be confied to only 4 cpus if you like | 15:29 |
| sean-k-mooney | you just need to configre the app to use 2 queues per core in that case | 15:29 |
| sean-k-mooney | if you are using the kernel driver this is all handeled internally i belive | 15:29 |
| spatel_ | I thought queue bind with vCPU so if you specify 4 queue size then only 4 vCPU parellel work on packet processing.. | 15:30 |
| spatel_ | that is why i was reserving 4 vCPU for OS and 4vCPU for queue (for networking work) | 15:31 |
| sean-k-mooney | there are 2 level here. the host level were we will allocate 1 queu per vcpu and the guest level | 15:31 |
| spatel_ | https://specs.openstack.org/openstack/nova-specs/specs/liberty/implemented/libvirt-virtiomq.html | 15:32 |
| spatel_ | Host level ?? never heard that | 15:32 |
| sean-k-mooney | what im trying to say is that nova will configure qemu with 1 queu per vcpu form the host/hyperviour perspective | 15:33 |
| sean-k-mooney | provided you enable multique that is | 15:33 |
| spatel_ | hmm! | 15:34 |
| sean-k-mooney | as such if you do not set ethtool -L <NIC> combined $(nproc) | 15:34 |
| sean-k-mooney | you will get incorrect behavior | 15:35 |
| tobias-urdin | mriedem: could i steal some of your time, perhaps you know if it flushed the system metadata cache | 15:35 |
| tobias-urdin | 12:58 < tobias-urdin> is it possible to flush the entries in instance_system_metadata for an instance manually without breaking something? there is cached content on user and project which is incorrect | 15:35 |
| tobias-urdin | 12:58 < tobias-urdin> i assume the only other wait to force a rewrite of those values in the xml would be a hard reboot, but not sure that would do the trick either | 15:35 |
| spatel_ | i think slowly i am following you... what you trying to say.. sean-k-mooney | 15:35 |
| openstackgerrit | Tobias Urdin proposed openstack/nova stable/rocky: Handle unicode characters in migration params https://review.openstack.org/618734 | 15:35 |
| sean-k-mooney | but within the guest the application that process packts form that interface can pin to 1-n core independly form the number of quese that there are | 15:35 |
| spatel_ | oh!! got it.. what you saying.. | 15:36 |
| spatel_ | i was wrong about queuing logic... | 15:36 |
| mriedem | tobias-urdin: there is no external REST API for changing things within the instance system_metadata, | 15:37 |
| spatel_ | let me change my all instance to use all nproc | 15:37 |
| mriedem | and what goes in there depends on the instance and operation, and manually messing with it is probably a bad idea given it's system data | 15:37 |
| mriedem | tobias-urdin: so you'd have to be more specific about the incorrect sysmeta data that needs to be fixed | 15:38 |
| spatel_ | sean-k-mooney: thanks again for saving me!!! | 15:38 |
| tobias-urdin | mriedem: we are affected by https://review.openstack.org/#/c/618734/ but we have renamed the project until then but live migrations fails since it's wrong in the XML | 15:38 |
| sean-k-mooney | spatel_: no worries this is rather difficult to figure out all at once | 15:38 |
| tobias-urdin | so i was not sure if doing a hard reboot would use the cached instance_system_metadata or not, it does rebuild the XML but perhaps with the wrong data | 15:38 |
| tobias-urdin | perhaps better to just test it out in a test environment | 15:38 |
| spatel_ | in document is not very clear! anyway i am totally on it now | 15:39 |
| tobias-urdin | it's probably not a good idea to DELETE those rows in instance_system_metadata | 15:39 |
| mriedem | tobias-urdin: no that's probably not a great idea | 15:39 |
| mriedem | tobias-urdin: what are the bad fields? user name and project name? | 15:40 |
| *** k_mouza has joined #openstack-nova | 15:40 | |
| mriedem | i.e. owner_user_name and owner_project_name in the xml? | 15:40 |
| sean-k-mooney | spatel_: ya this was a topic at the summit. we need an nfv tuning guide with examples as the docs for these advanced feature are... lacking clarity to put it nicely | 15:41 |
| tobias-urdin | mriedem: yeah the owner project name in the xml | 15:41 |
| mriedem | i'm guessing _get_guest_config_meta in the libvirt driver is the thing putting the bad data in the xml | 15:42 |
| mriedem | if you deleted owner_user_name and owner_project_name from the instance_system_metadata, we would put "N/A" in the xml | 15:42 |
| sean-k-mooney | spatel_: i as a developer often use the specs to understand what we intended to enable but end users should not needed to read them to consume the features and use them properly. | 15:42 |
| spatel_ | ++ | 15:43 |
| *** moshele has joined #openstack-nova | 15:43 | |
| mriedem | tobias-urdin: and those fields are put into the system_metadata only at server create time, not reboot | 15:44 |
| mriedem | so even if you changed the user name / project name in keystone, that wouldn't be reflected in the instance sysmeta | 15:44 |
| tobias-urdin | mriedem: thanks! then i'll apply the patch manually on the affected nodes until it lands in stable/rocky | 15:46 |
| *** priteau has joined #openstack-nova | 15:51 | |
| dansmith | mriedem: tobias-urdin +W | 15:52 |
| *** moshele has quit IRC | 15:52 | |
| *** jaypipes has joined #openstack-nova | 15:53 | |
| *** slaweq_ has quit IRC | 15:54 | |
| *** slaweq_ has joined #openstack-nova | 15:54 | |
| dansmith | mriedem: jaypipes sean-k-mooney: I think we need to give some clarity to sundar here: https://review.openstack.org/#/c/603955/10/specs/stein/approved/nova-cyborg-interaction.rst | 15:55 |
| dansmith | I am majorly opposed to documenting all the cyborg and os-acc APIs and functions in that spec | 15:55 |
| *** dklyle has quit IRC | 15:55 | |
| sean-k-mooney | dansmith: just hopping on a call in 5 mins but sure what had you in mind | 15:56 |
| sean-k-mooney | dansmith: yes i suggested splitting it into 3 specs a while ago | 15:56 |
| dansmith | L324 specifically | 15:56 |
| dansmith | sean-k-mooney: even if it gets split, those definitions don't belong in one of our specs, IMHO | 15:56 |
| sean-k-mooney | am i highlevel discription of the os-acc that nova will consume would be nice but the cyborg apis dont need to be in the spec for sure | 15:57 |
| sean-k-mooney | i would like to know the data structure that are passed the the fuction that should be called at diffrent point by nova but the internal can live in cyborg specs | 15:58 |
| dansmith | sean-k-mooney: the data structures are fine, but you asked him to add more api signatures where I asked him to completely remove them | 15:59 |
| sean-k-mooney | dansmith: i think the os-vif spec got it about right https://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved/os-vif-library.html | 15:59 |
| dansmith | which is why we need to converge so he knows what to do | 15:59 |
| jaypipes | sean-k-mooney: I think I was pretty clear in Denver and elsewhere that I think the Cyborg team first needs to have some workable low-level device plumbing library (what I *thought* os-acc was supposed to be) before Nova even becomes part of the conversation. I view os-acc as very similar to os-vif, and I'm disappointed that there is even discussion about REST APIs or anything like that instead of designing an easy to use, hard-to-abuse low-level | 15:59 |
| jaypipes | device plugging lib. | 15:59 |
| sean-k-mooney | dansmith: well that was because he was documenting the api and did not discribe the device profile enpoint | 16:00 |
| sean-k-mooney | so either remove the api enpoitn entirely which im fine with or include that one | 16:00 |
| sean-k-mooney | jaypipes: yes i agree with that | 16:00 |
| jaypipes | sean-k-mooney: totally unnecessary at this point, IMHO. | 16:00 |
| jaypipes | sean-k-mooney: (the REST API or anything like that) | 16:01 |
| sean-k-mooney | jaypipes: ya so let ask for all the cyborg rest apis to be removed and state it will be handeled by os-acc | 16:01 |
| dansmith | jaypipes: can you comment on the spec (L324ish)? I've already voiced there and so another "remove all this" would be good.. | 16:01 |
| jaypipes | sean-k-mooney: the path to success with Cyborg is to mimick os-vif, not Mogan. | 16:01 |
| sean-k-mooney | jaypipes: yes i agree | 16:01 |
| sean-k-mooney | jaypipes: anyway i need to jump on a call | 16:02 |
| jaypipes | dansmith: ok. I've already made a number of those comments but will do so again | 16:02 |
| dansmith | jaypipes: I know, and I appreciate it.. L324 is where there was a conflicting "Do X" and "Don't do X" | 16:02 |
| sean-k-mooney | dansmith: jaypipes feel free to link to this irc convo or just state im +1 on removing the api enpoint too | 16:02 |
| jaypipes | dansmith: ack | 16:02 |
| dansmith | jaypipes: and sundar expressed confusion there, so.. | 16:02 |
| cdent | I spoke with sundar briefly in berlin and he felt like he was getting different messages from jaypipes and dansmith. Both efried and I suggested he show up here to be a part of these discussions if/when he had a chance. | 16:03 |
| *** dklyle has joined #openstack-nova | 16:03 | |
| *** tbachman has quit IRC | 16:04 | |
| *** pcaruana has quit IRC | 16:07 | |
| dansmith | cdent: I imagine you mean between me and sean-k-mooney or jaypipes and sean-k-mooney | 16:08 |
| dansmith | he didn't even acknowledge my comments on the spec, | 16:08 |
| cdent | dansmith: I don't. | 16:08 |
| dansmith | and jaypipes and I didn't comment on most of the same lines | 16:08 |
| *** moshele has joined #openstack-nova | 16:08 | |
| cdent | I'm reporting merely on what sundar said to me, not what's happening on the spec | 16:09 |
| cdent | The only attention I've given to the spec is to point out where the proposed API is not right | 16:09 |
| *** s10 has quit IRC | 16:11 | |
| *** moshele has quit IRC | 16:14 | |
| *** udesale has quit IRC | 16:16 | |
| *** Sundar has joined #openstack-nova | 16:17 | |
| *** jamesdenton has joined #openstack-nova | 16:18 | |
| mriedem | and i haven't looked at it at all | 16:20 |
| mriedem | i'm kind of waiting for ^ to settle before digging into it | 16:21 |
| *** janki has quit IRC | 16:26 | |
| *** mchlumsky has quit IRC | 16:31 | |
| *** mchlumsky has joined #openstack-nova | 16:34 | |
| *** tbachman has joined #openstack-nova | 16:36 | |
| jaypipes | mriedem: the nova-cyborg thing? | 16:39 |
| mriedem | ye | 16:40 |
| mriedem | *yes | 16:40 |
| *** sapd1 has joined #openstack-nova | 16:45 | |
| *** ccamacho has quit IRC | 16:46 | |
| *** ccamacho has joined #openstack-nova | 16:46 | |
| *** rodolof has quit IRC | 16:51 | |
| sean-k-mooney | cdent: there were some mixed messages from me vs dan and jay. i wanted them to either document everything or drop the api stuff. dan wanted the api stuff remvoed and i think jay agreed | 16:51 |
| *** moshele has joined #openstack-nova | 16:52 | |
| sean-k-mooney | cdent: i was fine with removing the cyborg api stuff which sundar may not have picked up on but i dislike have only some of the enpoints int he spec | 16:52 |
| *** moshele has quit IRC | 16:53 | |
| sean-k-mooney | i think dansmith jaypipes and i all agree we would like to see the integration follow the os-vif and os-bricks model where os-acc become the nova integration point | 16:53 |
| cdent | sean-k-mooney: I said to him that it would be easier to evaluate the API if it were all in one place | 16:53 |
| cdent | And if the API isn't needed at this stage, then cool | 16:53 |
| cdent | I was simply trying to help him navigate what has proven to be a strenuous process | 16:54 |
| sean-k-mooney | cdent: that is true but the one place could be a cyborg spec that we provide input into yes? | 16:54 |
| cdent | yes, if the one place were to happen, then in cyborg would be the place | 16:55 |
| *** k_mouza_ has joined #openstack-nova | 16:57 | |
| efried | problem there being that they've had very little input on the cyborg specs from outside the cyborg team. | 16:58 |
| efried | I think it may have been on my recommendation (which was for that reason ^) that Sundar put this one into nova-specs. | 16:58 |
| *** k_mouza__ has joined #openstack-nova | 16:58 | |
| *** Sundar has quit IRC | 16:58 | |
| dansmith | there really shouldn't need to be a lot of input from us on cyborg APIs I don't think | 16:59 |
| dansmith | if we keep the discussion on the nova side to the workflow and interaction with the library, | 16:59 |
| sean-k-mooney | efried: well you and i have both left quite a lot of feedback at different times but i dont think alot of it has been incorperated. some definetly has but we have had the same converstaton several times | 16:59 |
| dansmith | the server-side stuff should be discernible from that I think | 16:59 |
| dansmith | sean-k-mooney: yeah, definitely feel like we've gone in circles a lot on this, approaching exhaustion | 16:59 |
| *** k_mouza has quit IRC | 17:00 | |
| *** priteau has quit IRC | 17:00 | |
| openstackgerrit | Elod Illes proposed openstack/nova master: Transform scheduler.select_destinations notification https://review.openstack.org/508506 | 17:01 |
| *** k_mouza_ has quit IRC | 17:02 | |
| *** k_mouza__ has quit IRC | 17:04 | |
| *** tssurya has quit IRC | 17:07 | |
| *** sapd1 has quit IRC | 17:07 | |
| jaypipes | jangutter: I really like the "before and after" sections in https://review.openstack.org/#/c/607610/3/specs/stein/approved/generic-os-vif-offloads.rst (e.g. lines 133-177). makes it much easier to see how the changes affect things. ++ | 17:10 |
| *** itlinux has joined #openstack-nova | 17:12 | |
| *** imacdonn has quit IRC | 17:17 | |
| *** imacdonn has joined #openstack-nova | 17:17 | |
| *** mmethot has joined #openstack-nova | 17:21 | |
| *** k_mouza has joined #openstack-nova | 17:24 | |
| sean-k-mooney | jaypipes: dansmith i responded on the cyborg spec to say please remove the cyborg api section. | 17:25 |
| *** sahid has quit IRC | 17:25 | |
| sean-k-mooney | jaypipes: dansmith also do we all agree the indirect usecase where the acclerator is not attach to the vm should not be in the spec? | 17:25 |
| jaypipes | sean-k-mooney: I just finished up with jangutter's spec on os-vif object model changes. adding some comments to the cyborg spec now... | 17:26 |
| sean-k-mooney | my understanding is that the instance will not be the consumer of the devices in placement and since they are not attach to the nova instance nova should not care | 17:26 |
| cdent | efried: we (you?) need to come up with a plan for replacing the tests that use rp_object as added in https://review.openstack.org/#/c/560444/ | 17:27 |
| sean-k-mooney | jaypipes: oh ya i need to go back to that one | 17:27 |
| sean-k-mooney | jaypipes: am one point i made on the code which is not in the spec is we should not use the term datapath offlod since the representor netdev is actull part of the control plane. | 17:28 |
| jaypipes | sean-k-mooney: I said on the spec that I think "OffloadBase" is fine and removing "Datapath" would be good. | 17:30 |
| sean-k-mooney | i realise when i clicked the link i have only looked at the code for this so im currently readign the spec for the first tiem | 17:31 |
| sean-k-mooney | jaypipes: if you have not seen it can you reivew this comment on the code to see if you agree https://review.openstack.org/#/c/572081/9/os_vif/objects/vif.py@376 i will see how that relates to the spec | 17:35 |
| *** pooja_jadhav has quit IRC | 17:36 | |
| *** rodolof has joined #openstack-nova | 17:36 | |
| *** rodolof has quit IRC | 17:40 | |
| *** rodolof has joined #openstack-nova | 17:40 | |
| efried | cdent: That should be easy peasy. Did you want me to do that in nova, placement, or both? | 17:41 |
| *** rodolof has quit IRC | 17:41 | |
| cdent | efried: it only exists in nova | 17:41 |
| efried | stand by. | 17:41 |
| *** rodolof has joined #openstack-nova | 17:41 | |
| * cdent stands on one leg | 17:42 | |
| *** pcaruana has joined #openstack-nova | 17:44 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Handle unicode characters in migration params https://review.openstack.org/618734 | 17:44 |
| *** k_mouza has quit IRC | 17:46 | |
| *** sridharg has quit IRC | 17:49 | |
| *** rodolof has quit IRC | 17:51 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Nix refs to ResourceProvider obj from libvirt UT https://review.openstack.org/618786 | 17:51 |
| efried | cdent: There ya go ^ | 17:51 |
| cdent | rad | 17:51 |
| *** rodolof has joined #openstack-nova | 17:51 | |
| cdent | thanks | 17:52 |
| efried | There's more refactoring that could be done there, but this is roughly the easiest. | 17:52 |
| efried | without being too hacky | 17:52 |
| efried | cdent: BTW, pretty sure the origin of the test code was bhagyashris. This doesn't look like my style at all. | 17:54 |
| cdent | efried: noted. I just went by git blame when raising the "alarm`' | 17:54 |
| efried | yup, and she's not around atm anyway. Easy enough fix. | 17:54 |
| *** rodolof has quit IRC | 17:56 | |
| *** rodolof has joined #openstack-nova | 17:56 | |
| *** derekh has quit IRC | 18:00 | |
| efried | jaypipes, mriedem, bauzas: ----^ easy one | 18:01 |
| *** jpena is now known as jpena|off | 18:03 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Use external placement in functional tests https://review.openstack.org/617941 | 18:07 |
| openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Delete the placement code https://review.openstack.org/618215 | 18:07 |
| *** tbachman has quit IRC | 18:07 | |
| cdent | feh, that's not going to work after a merge | 18:08 |
| *** dtantsur is now known as dtantsur|afk | 18:09 | |
| *** rodolof has quit IRC | 18:28 | |
| *** tbachman has joined #openstack-nova | 18:29 | |
| *** READ10 has joined #openstack-nova | 18:40 | |
| larsks | Hey folks. Should disk-related instance resource quotas (such as quota:disk_write_bytes_sec) be applied when booting from a volume? | 18:48 |
| *** k_mouza has joined #openstack-nova | 18:49 | |
| *** k_mouza has quit IRC | 18:54 | |
| *** Swami has joined #openstack-nova | 19:13 | |
| *** mvkr has quit IRC | 19:20 | |
| cfriesen | larsks: I think it's supposed to be applied, at least for libvirt/qemu. | 19:21 |
| sean-k-mooney | cfriesen: yes it is but i just tested with devstack and it does not work on master | 19:26 |
| sean-k-mooney | cfriesen: larsks moved to public pastbin http://paste.openstack.org/show/735692/ | 19:27 |
| sean-k-mooney | im link 95% sure this used to work | 19:28 |
| cfriesen | sean-k-mooney: I think it's "quota:write_bytes_sec" | 19:28 |
| cfriesen | no, that webpage was wrong | 19:29 |
| sean-k-mooney | quota:disk_write_bytes_sec is what horizon set | 19:29 |
| *** moshele has joined #openstack-nova | 19:29 | |
| sean-k-mooney | ill set all the limits and see what hapes perhaps its just that one. i think this works with the ceph backend but maybe for boot form volume you have to use cinder qos | 19:30 |
| sean-k-mooney | cfriesen: larsks nope still ignored http://paste.openstack.org/show/735693/ | 19:34 |
| openstackgerrit | Jack Ding proposed openstack/nova master: Add HPET timer support for x86 guests https://review.openstack.org/605902 | 19:40 |
| *** moshele has quit IRC | 19:43 | |
| larsks | cfriesen: thanks, and sean-k-mooney thanks for checking. What I'm curious about is whether or not that is expected behavior... | 19:46 |
| larsks | I.e., should I open a bug for this? | 19:46 |
| sean-k-mooney | larsks: it is expect to work and yes | 19:46 |
| larsks | Ack, I'll do that right now, then. | 19:46 |
| sean-k-mooney | but we also advise peole not to use falvor qouta any more even though we have not deprecated them offically | 19:47 |
| larsks | Oh, that's news. Why is that? | 19:47 |
| sean-k-mooney | because cinder and neutron both have there own qos apis which are richer and better tested | 19:47 |
| larsks | Okay. Being able to associate a collection disk/network/etc quotas with a flavor is very convenient. | 19:48 |
| larsks | But I can see that having these resource quotas managed in different places could lead to confusion and duplication of effort. | 19:49 |
| sean-k-mooney | it is but its legacy functionality that was supperseed by qos apis in the services | 19:49 |
| sean-k-mooney | that daid if you are not using cinder or neutron an want that fuctionality the falvor were the only way to do it | 19:49 |
| larsks | Fair enough. Do you know if there is documentation that would suggest avoiding flavor quotas? I may need to convince someone to do so. | 19:49 |
| sean-k-mooney | larsks: not that im aware of but most people dont know they exist and we just dont activly publicise that fact to new users | 19:50 |
| larsks | Got it. Okay, thanks! | 19:50 |
| cdent | Is anyone else seeing HackingTestCase.test_check_doubled_words fail on py36 on ubuntu 18.04? It's not failing on macos | 19:56 |
| efried | cdent: I just ran it locally on trusty and it ran okay. | 19:58 |
| efried | I noticed it breaking here: https://review.openstack.org/#/c/618786/ <== is that where you were seeing it, or somewhere else? | 19:59 |
| *** jobewan has joined #openstack-nova | 19:59 | |
| cdent | first on my placement removal patches, and then on master | 19:59 |
| *** rodolof has joined #openstack-nova | 20:00 | |
| *** mvkr has joined #openstack-nova | 20:09 | |
| *** mchlumsky has quit IRC | 20:10 | |
| *** mchlumsky has joined #openstack-nova | 20:11 | |
| *** rodolof has quit IRC | 20:11 | |
| cdent | weird, it's a problem in 3.6 but not 3.7 | 20:12 |
| *** rodolof has joined #openstack-nova | 20:12 | |
| *** rodolof has quit IRC | 20:16 | |
| *** rodolof has joined #openstack-nova | 20:17 | |
| cdent | oh rich, it passes in stestr in 3.7, but not with testtools.run or unittest | 20:18 |
| * cdent flips a table | 20:22 | |
| *** burt has quit IRC | 20:26 | |
| *** rodolof has quit IRC | 20:26 | |
| *** rodolof has joined #openstack-nova | 20:27 | |
| *** rodolof has quit IRC | 20:31 | |
| *** rodolof has joined #openstack-nova | 20:32 | |
| larsks | sean-k-mooney: Looks like there is already a bug, from 2016 :). https://bugs.launchpad.net/nova/+bug/1445637 | 20:33 |
| openstack | Launchpad bug 1445637 in OpenStack Compute (nova) "Instance resource quota not observed for non-ephemeral storage" [Wishlist,Opinion] | 20:33 |
| sean-k-mooney | larsks: ah ok let me repriorise it for you | 20:35 |
| *** READ10 has quit IRC | 20:35 | |
| larsks | I don't know, maybe at this point it's just a doc bug and the docs should say "use cinder and neutron resource controls". | 20:36 |
| sean-k-mooney | i have set it to confirmed and low. we can propse a docs update as a resolution to the but if we like | 20:37 |
| *** rodolof has quit IRC | 20:38 | |
| *** rodolof has joined #openstack-nova | 20:39 | |
| *** rodolof has quit IRC | 20:41 | |
| *** rodolof has joined #openstack-nova | 20:42 | |
| *** rodolof has quit IRC | 20:56 | |
| larsks | sean-k-mooney: ...but flavor quotas *are* still the correct mechanism for controlling cpu and memory limits? | 21:01 |
| sean-k-mooney | larsks: cpu and memory limits? | 21:03 |
| cdent | efried: it's because of this https://bugs.python.org/issue33899 which gets python 3.6.7 and newer versions of python 3.7. I'll make a bug and a patch | 21:03 |
| larsks | sean-k-mooney: right, like quota:cpu_quota. | 21:04 |
| larsks | sean-k-mooney: so really just cpu. | 21:04 |
| sean-k-mooney | larsks: that is also something that in general is not used | 21:04 |
| larsks | Okay. Is there an alternative for that, or is that just something that was considered less useful? | 21:05 |
| sean-k-mooney | larsks: most of those values are from lxc | 21:05 |
| sean-k-mooney | or vm ware | 21:05 |
| sean-k-mooney | many of them never work with libvirt/kvm cpu_shares did but not the rest | 21:06 |
| sean-k-mooney | the same is true fo the memory limits | 21:06 |
| sean-k-mooney | https://docs.openstack.org/nova/latest/user/flavors.html | 21:06 |
| sean-k-mooney | all of the flavor quota atibute came form the vmware driver originally | 21:07 |
| larsks | Okay. So effectively the best practice is not to use instance resource limits for anything, and rely on the per-service limits (e.g., cinder, neutron) where available. Is that accurate? | 21:09 |
| sean-k-mooney | if you want to have interop between different public cloud then you could not rely on that feature existing | 21:10 |
| sean-k-mooney | as an operator you can set them but it may cause issues for your users if you also expose the service qos apis | 21:10 |
| cdent | efried: https://bugs.launchpad.net/nova/+bug/1804062 the thing that I thought would fix it does not | 21:10 |
| openstack | Launchpad bug 1804062 in OpenStack Compute (nova) "test_hacking fails for python 3.6.7 and newer" [Undecided,New] | 21:10 |
| cdent | so still thinking | 21:10 |
| larsks | sean-k-mooney: fair enough. Are there any plans to deprecate the feature in the near future? | 21:10 |
| cdent | mriedem: to distract you, that bug ^ is real fun | 21:11 |
| sean-k-mooney | larsks: again it kind of a if its not broken dont fix it or delete it situation | 21:11 |
| sean-k-mooney | larsks: i dont think so but it has been mentioned in the past | 21:11 |
| sean-k-mooney | larsks: a better way to look at it is it unlikely that we would add more quota: extraspec in the future | 21:12 |
| larsks | Okay, that makes sense. Thanks for spending some time on this! | 21:13 |
| cfriesen | is it just me or is it not intuitive that the way to get a vnc session to a server using the "openstack" command is "openstack console url show" rather than an "openstack server console show" or similar? | 21:14 |
| sean-k-mooney | cfriesen: i did fine it weird too | 21:15 |
| sean-k-mooney | its there to differenceate between the url or the log | 21:15 |
| sean-k-mooney | but i would have gon with opesntack server console show and openstack server log show | 21:15 |
| sean-k-mooney | cfriesen: sorry tehy are console log show and console url show | 21:16 |
| sean-k-mooney | but yes openstack server console show and openstack server log show would have made more sense to me | 21:17 |
| *** rmart04 has joined #openstack-nova | 21:18 | |
| *** rmart04 has quit IRC | 21:19 | |
| mriedem | cfriesen: likely a question for dtroyer in #openstack-sdks | 21:19 |
| mriedem | cdent: so we're intermittently hitting that in py36 jobs? | 21:20 |
| cdent | yes | 21:20 |
| cdent | seems to depend on whether the node has a recently updated python. 3.6.7 was released to ubuntu not long ago | 21:21 |
| sean-k-mooney | cdent: is that happening in nova or in the hacking repo? | 21:21 |
| cdent | nova | 21:21 |
| cdent | it's just the one test | 21:21 |
| cdent | the root is that having a newline token being added on the end is causing pep8 to think it needs to do a "logical check" | 21:22 |
| sean-k-mooney | can you past the test name again ill try and run it on python 3.6 on centos | 21:22 |
| cdent | which means it bypasses the physical checks that happen otherwise | 21:22 |
| cdent | sean-k-mooney: nova.tests.unit.test_hacking.HackingTestCase.test_check_doubled_words | 21:22 |
| cdent | it ought to pass fine in <3.6.7 | 21:22 |
| mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22testtools.matchers._impl.MismatchError%3A%20%5B(1%2C%200%2C%20'N343')%5D%20!%3D%20%5B%5D%5C%22%20AND%20tags%3A%5C%22console%5C%22%20AND%20build_name%3A%5C%22openstack-tox-py36%5C%22&from=7d | 21:22 |
| cdent | yeah, so always bionic | 21:23 |
| mriedem | yup | 21:23 |
| mriedem | do we want to skip the test for now? | 21:23 |
| cdent | if you're happy with that, that's probably the easiest way to go | 21:23 |
| mriedem | or at least skip on py36 | 21:24 |
| sean-k-mooney | python 3.6 will be the defult on rhel8 also as per doug hellmann's mail earilier today | 21:25 |
| cdent | yeah, I'll do a skipIf | 21:26 |
| cdent | one moment please | 21:26 |
| sean-k-mooney | im testing with Python 3.6.5 on centos 7 and it passed | 21:26 |
| cdent | yeah, that's expected | 21:27 |
| sean-k-mooney | oh it needs to be 3.6.7+ to fail | 21:28 |
| *** awaugama has quit IRC | 21:34 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Skip double word hacking test https://review.openstack.org/618843 | 21:43 |
| cdent | mriedem, efried, sean-k-mooney ^ | 21:43 |
| * sean-k-mooney clicks | 21:43 | |
| sean-k-mooney | is that really a nova bug or a hacking bug? | 21:44 |
| cdent | the failing test is because of changes to the tokenize stdlib. The hacking check is in nova itself, not in hacking | 21:45 |
| sean-k-mooney | i guess we shoudl make the test support both the old and new api | 21:45 |
| cdent | at least the way nova is experiencing the problem | 21:45 |
| cdent | sean-k-mooney: I tried and failed to do that because it is in the guts of pep8 where the problem happens | 21:45 |
| cdent | all hacking has is a regex | 21:45 |
| cdent | the presence of the added NEWLINE token causes pep8 to believe it needs to make a logical instead of physical check | 21:46 |
| sean-k-mooney | not sure i follow but then again i have not looked at the python bug yet | 21:47 |
| cdent | there's little we can do from our side of the world to make it not add the NEWLINE | 21:47 |
| cdent | looking at the python bug (and the related tracker for api breakages it causes) will make things much more clear | 21:47 |
| *** jobewan has quit IRC | 21:47 | |
| sean-k-mooney | so just to be clear on what line in test_chesck_double_words is it addint the new line | 21:49 |
| sean-k-mooney | the + operator | 21:49 |
| cdent | at the end of the entire string | 21:49 |
| cdent | and it isn't adding a new line | 21:49 |
| cdent | it is adding a NEWLINE token when tokenizing | 21:49 |
| sean-k-mooney | oh | 21:49 |
| sean-k-mooney | that seams like a think it should not be doing... but ok | 21:50 |
| sean-k-mooney | anyway you temp fix makes sense | 21:50 |
| cdent | yeah, you'd think so, but someone decided that the method should behave more like C | 21:50 |
| cdent | the comments on the python bug are amusing | 21:50 |
| sean-k-mooney | c ends with \0 | 21:50 |
| sean-k-mooney | e.g. a 0 byte | 21:50 |
| sean-k-mooney | not a new line | 21:50 |
| *** pcaruana has quit IRC | 21:51 | |
| cdent | right, but it tokenizes a NEWLINE | 21:51 |
| cdent | apparently | 21:51 |
| sean-k-mooney | so it does not match c either in terms of string termination of const char* s | 21:51 |
| cdent | it's not about string termination | 21:51 |
| cdent | it is about code tokenizing | 21:51 |
| cdent | please, read the bug | 21:51 |
| cdent | it will all become clear | 21:52 |
| sean-k-mooney | yes i was as we were chatting "As was pointed out in https://bugs.python.org/issue33766 there is an edge case in the tokenizer whereby it will implicitly treat the end of input as a newline." | 21:52 |
| efried | cdent: What is [1] in the commit message? | 21:53 |
| cdent | that link that sean-k-mooney just pointed at, did I forget to add it? le sigh | 21:54 |
| efried | not https://bugs.python.org/issue33899 ? | 21:54 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Skip double word hacking test https://review.openstack.org/618843 | 21:54 |
| cdent | argh too many bugs | 21:54 |
| sean-k-mooney | efried: the openstack bug points to the python bug | 21:55 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Skip double word hacking test https://review.openstack.org/618843 | 21:55 |
| sean-k-mooney | but yes the commit does not have a bug link | 21:55 |
| sean-k-mooney | hehe ok now it does | 21:56 |
| efried | so none of those is https://bugs.python.org/issue33766 | 21:56 |
| cdent | there we go, now it links to the two python bugs I wanted to link to, neither of which are the one that sean pointed to (which was an originating bug) | 21:56 |
| cdent | indeed | 21:56 |
| *** ivve has quit IRC | 21:56 | |
| * cdent can't seem to stay out of 13 hour days | 21:56 | |
| efried | Not having dug any deeper, I'll point out that ``echo 'print("a");print("b")' > test.py`` does indeed end with a newline. | 21:57 |
| sean-k-mooney | yes https://bugs.python.org/issue35107 is tracking the fallout of fixing https://bugs.python.org/issue33899 which ended up breaking backward compatiblity | 21:57 |
| efried | efried@efried-ThinkPad-W520:~$ echo 'print("a");print("b")' > /tmp/test.py | 21:57 |
| efried | efried@efried-ThinkPad-W520:~$ od -c /tmp/test.py | 21:57 |
| efried | 0000000 p r i n t ( " a " ) ; p r i n t | 21:57 |
| efried | 0000020 ( " b " ) \n | 21:57 |
| efried | 0000026 | 21:57 |
| cdent | i don't think that's the point efried | 21:57 |
| efried | I'm sure it's not. | 21:57 |
| efried | hence the 'not having dug any deeper' | 21:57 |
| cdent | it's the same deal: discussion on that bug revealed the different between a newline character and a NEWLINE token and ways in which tokenizer failed to produce NEWLINE in some cirtical areas | 21:59 |
| cdent | the fix, however, was too hasty | 21:59 |
| sean-k-mooney | ya and they should not have backporte it to python 2.7 luckally they reverted it on the 2.7 branch | 22:00 |
| efried | cdent: Did this start appearing because we *just* started testing with py3.6.7? | 22:01 |
| cdent | yes | 22:01 |
| cdent | ubuntu bionic got it within the past few days | 22:01 |
| sean-k-mooney | looking at https://bugs.python.org/issue35107 they are still discusiing what the behavior should be but i agreee with them that you should be able to round trip | 22:01 |
| cdent | and our images updated recently | 22:01 |
| sean-k-mooney | am i missrembereing or did ubunut ship with a beta python version at lauchch or was that just for 3.7 | 22:02 |
| sean-k-mooney | i remembere there was somting about an unreleased python version at one point on ubuntu but dont know if that was 3.6 or 3.7 | 22:03 |
| efried | right, cuz we've been testing with 3.7 for a while now, so if it was >=3.6.7 we should have hit it. | 22:03 |
| sean-k-mooney | efried: well no the original bugfix was merged 2018-07-06 10:23 | 22:04 |
| mriedem | efried: i think the 3.6 jobs switched to bionic in the last 24 hours | 22:05 |
| mriedem | according to logstash | 22:05 |
| sean-k-mooney | so it proably took a while to get in the ubuntu package repos and then for use to update the image with it | 22:05 |
| sean-k-mooney | or what mriedem said | 22:05 |
| mriedem | anyway, it doesn't really matter | 22:06 |
| mriedem | sh*t is f'ed, skip until it's not | 22:06 |
| mriedem | making sure we don't have double words in comments is probably not super high on the cloud infrastructure priority list | 22:07 |
| cdent | my testing box has been bionic for months, but i did an update update and upgrade today (after being gone for the week of berlin) and that's when it started showing up. I reguarly to upgrades on that machine, so I think it is a minor upgrade in bionic | 22:07 |
| cdent | mriedem: no way man, it's the tippy top top | 22:07 |
| mriedem | how are we going to do flake8 checks AT THE EDGE?! | 22:08 |
| sean-k-mooney | you know i have been starting to look into jamspell after the sumit demo | 22:08 |
| sean-k-mooney | im hopign to see if i can figure out how to make it work with a git commit hook to try and fix may patches | 22:09 |
| sean-k-mooney | maybe | 22:09 |
| efried | heh | 22:09 |
| sean-k-mooney | ok i should call it a night o/ | 22:10 |
| cdent | i probably need something like that too | 22:11 |
| cdent | I gave up on grammarly, seemed to be making browser too slow, and only works there | 22:11 |
| sean-k-mooney | i still use it somethime but i have to fix the formating after so it breaks my workflow to copy and past the suff into a broswer | 22:12 |
| sean-k-mooney | anyway email sent really going this time | 22:13 |
| cdent | I think I should go too. night all | 22:19 |
| *** cdent has quit IRC | 22:19 | |
| *** aloga_ has joined #openstack-nova | 22:36 | |
| *** dklyle has quit IRC | 22:37 | |
| *** slaweq__ has joined #openstack-nova | 22:37 | |
| *** dklyle has joined #openstack-nova | 22:38 | |
| *** wznoinsk has joined #openstack-nova | 22:38 | |
| *** tbachman has quit IRC | 22:39 | |
| *** jiaopengju has quit IRC | 22:39 | |
| *** mgoddard has quit IRC | 22:39 | |
| *** aloga has quit IRC | 22:39 | |
| *** slaweq_ has quit IRC | 22:39 | |
| *** marvin_mhg has quit IRC | 22:39 | |
| *** bandini has quit IRC | 22:39 | |
| *** imacdonn has quit IRC | 22:39 | |
| *** spatel_ has quit IRC | 22:39 | |
| *** cfriesen has quit IRC | 22:39 | |
| *** mriedem has quit IRC | 22:39 | |
| *** sambetts_ has quit IRC | 22:39 | |
| *** jmlowe has quit IRC | 22:39 | |
| *** manjeets has quit IRC | 22:39 | |
| *** jmlowe has joined #openstack-nova | 22:41 | |
| *** tbachman has joined #openstack-nova | 22:41 | |
| *** jiaopengju has joined #openstack-nova | 22:41 | |
| *** imacdonn has joined #openstack-nova | 22:41 | |
| *** sambetts_ has joined #openstack-nova | 22:43 | |
| *** mgoddard has joined #openstack-nova | 22:45 | |
| *** cfriesen has joined #openstack-nova | 23:01 | |
| efried | jroll: Can I get your nod on https://review.openstack.org/#/c/616721/ please before I merge it? | 23:05 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Nix refs to ResourceProvider obj from libvirt UT https://review.openstack.org/618786 | 23:08 |
| *** spatel has joined #openstack-nova | 23:16 | |
| *** mlavalle has quit IRC | 23:16 | |
| *** spatel has quit IRC | 23:20 | |
| *** spatel has joined #openstack-nova | 23:22 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix server query examples https://review.openstack.org/616834 | 23:23 |
| *** spatel has quit IRC | 23:26 | |
| *** aloga_ has quit IRC | 23:33 | |
| *** gibi has quit IRC | 23:34 | |
| *** aloga has joined #openstack-nova | 23:35 | |
| *** gibi has joined #openstack-nova | 23:35 | |
| *** manjeets has joined #openstack-nova | 23:36 | |
| *** lbragstad has quit IRC | 23:40 | |
| *** takashin has joined #openstack-nova | 23:45 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!