Wednesday, 2018-11-21

*** spatel has quit IRC00:03
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional regression recreate test for bug 1790204  https://review.openstack.org/61912300:06
openstackbug 1790204 in OpenStack Compute (nova) "Allocations are "doubled up" on same host resize even though there is only 1 server on the host" [Medium,Triaged] https://launchpad.net/bugs/179020400:06
*** tetsuro has quit IRC00:07
*** tetsuro has joined #openstack-nova00:10
*** mriedem has quit IRC00:17
openstackgerritTakashi NATSUME proposed openstack/nova stable/queens: Add description of custom resource classes  https://review.openstack.org/61912500:41
*** hamzy has joined #openstack-nova00:44
*** brinzhang has joined #openstack-nova01:22
*** brinzhang has quit IRC01:33
*** brinzhang has joined #openstack-nova01:33
*** tbachman has quit IRC01:55
openstackgerritMerged openstack/nova master: Consider root id is None in the database case  https://review.openstack.org/61330502:00
*** Dinesh_Bhor has joined #openstack-nova02:02
*** sambetts_ has quit IRC02:02
*** sambetts_ has joined #openstack-nova02:06
*** tbachman has joined #openstack-nova02:10
*** mtreinish has quit IRC02:13
*** mtreinish has joined #openstack-nova02:13
*** cfriesen has quit IRC02:18
*** mrsoul has joined #openstack-nova02:30
*** jascott1 has joined #openstack-nova02:38
jascott1hi, im trying to understand how and under what conditions openstack attaches config-drive to a VM. I have one distro that has the config drive and one that doesnt. Any help appreciated02:39
*** Dinesh_Bhor has quit IRC02:44
*** jascott1 has quit IRC02:44
*** mhen has quit IRC02:50
*** yedongcan has joined #openstack-nova02:50
*** Dinesh_Bhor has joined #openstack-nova02:52
*** mhen has joined #openstack-nova02:52
*** jascott1 has joined #openstack-nova02:56
*** jmlowe has quit IRC02:59
*** jmlowe has joined #openstack-nova03:00
*** jascott1 has quit IRC03:03
*** tbachman has quit IRC03:36
*** tbachman has joined #openstack-nova03:50
openstackgerritYikun Jiang proposed openstack/nova master: WIP: Remove live_migration_progress_timeout config  https://review.openstack.org/61914203:54
openstackgerritYikun Jiang proposed openstack/nova master: WIP: Add live migration timeout action  https://review.openstack.org/61914303:54
openstackgerritTakashi NATSUME proposed openstack/nova master: Add descriptions about microversions  https://review.openstack.org/61914404:02
*** psachin has joined #openstack-nova04:14
*** udesale has joined #openstack-nova04:17
*** bhagyashris has joined #openstack-nova04:18
bhagyashrisAtom: Hi,04:18
bhagyashrisartom: Hi, Sorry for spelling ^ because of auto correction04:20
*** itlinux has joined #openstack-nova04:33
*** janki has joined #openstack-nova04:42
*** jascott1 has joined #openstack-nova04:44
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Fix a type of block_device_mapping_v2 in a comment  https://review.openstack.org/61914504:44
*** pooja_jadhav has joined #openstack-nova04:49
*** sridharg has joined #openstack-nova04:54
*** ratailor has joined #openstack-nova05:00
*** bhagyashris has quit IRC05:01
openstackgerritMerged openstack/nova master: Remove v1 check in Cinder client version lookup  https://review.openstack.org/61792705:35
*** ileixe has joined #openstack-nova05:43
*** sambetts_ has quit IRC05:44
*** sambetts_ has joined #openstack-nova05:44
*** ileixe has quit IRC05:55
*** diga has quit IRC06:00
*** bhagyashris has joined #openstack-nova06:08
*** annp has joined #openstack-nova06:17
*** pooja_jadhav has quit IRC06:31
*** bhagyashris has quit IRC06:48
*** threestrands has joined #openstack-nova06:58
*** ileixe has joined #openstack-nova07:04
openstackgerritYikun Jiang proposed openstack/nova master: Remove live_migration_progress_timeout config  https://review.openstack.org/61914207:05
*** bhagyashris has joined #openstack-nova07:09
*** naichuans has joined #openstack-nova07:20
openstackgerritTakashi NATSUME proposed openstack/nova master: Transform compute_task notifications  https://review.openstack.org/48262907:26
*** rcernin has quit IRC07:26
openstackgerritYikun Jiang proposed openstack/nova master: Remove live_migration_progress_timeout config  https://review.openstack.org/61914207:32
*** adrianc has joined #openstack-nova07:34
openstackgerritZhenyu Zheng proposed openstack/nova-specs master: Amend the detach-boot-volume design  https://review.openstack.org/61916107:37
*** sahid has joined #openstack-nova07:38
openstackgerritZhenyu Zheng proposed openstack/nova-specs master: Make scheduling weight more granular  https://review.openstack.org/59930807:38
*** maciejjozefczyk has joined #openstack-nova07:44
openstackgerritYikun Jiang proposed openstack/nova master: Remove live_migration_progress_timeout config  https://review.openstack.org/61914207:53
openstackgerritYikun Jiang proposed openstack/nova master: Add live migration timeout action  https://review.openstack.org/61914307:53
*** ccamacho has joined #openstack-nova07:59
*** sean-k-mooney has quit IRC08:06
*** artom has quit IRC08:08
*** artom has joined #openstack-nova08:12
*** artom has joined #openstack-nova08:13
*** maciejjozefczyk has quit IRC08:15
*** sahid has quit IRC08:20
*** helenafm has joined #openstack-nova08:21
openstackgerritSilvan Kaiser proposed openstack/nova master: Added mount fstype based validation of Quobyte mounts  https://review.openstack.org/52224508:22
*** takashin has left #openstack-nova08:30
openstackgerritZhenyu Zheng proposed openstack/nova master: Add method to allow fetch root_volume BDM by instance_uuid  https://review.openstack.org/61467208:34
*** dtantsur|afk is now known as dtantsur08:42
*** ralonsoh has joined #openstack-nova08:50
*** sapd1__ has quit IRC08:54
*** sapd1 has joined #openstack-nova08:55
*** ccamacho has quit IRC09:02
openstackgerritYikun Jiang proposed openstack/nova master: Add live migration timeout action  https://review.openstack.org/61914309:04
*** ccamacho has joined #openstack-nova09:04
*** whoami-rajat has joined #openstack-nova09:09
fricklermelwitt: how long do we need to wait for further reviews on https://review.openstack.org/616580 ? this is a severe issue for us, currently running with a local patch. should I propose stable backports already or wait for the patch being merged in master?09:12
*** ratailor has quit IRC09:12
*** tetsuro has quit IRC09:12
*** ratailor has joined #openstack-nova09:13
*** erlon has quit IRC09:24
*** jaosorior has quit IRC09:26
*** ondrejme has quit IRC09:28
*** k_mouza has joined #openstack-nova09:28
*** k_mouza has quit IRC09:28
*** k_mouza has joined #openstack-nova09:29
*** derekh has joined #openstack-nova09:30
*** tssurya has joined #openstack-nova09:32
*** cdent has joined #openstack-nova09:37
kashyapfrickler: Hi, Mel is away on PTO, so a core reviewer can just do +W there, since it already has two +2s09:46
*** pcaruana has joined #openstack-nova09:48
cdentah yes, Thanskgiving, a time of review drought and dry turkeys.09:49
melwittfrickler: I'm not sure. I would ask mriedem since he left a comment about waiting a bit before approval09:50
* cdent checks the time09:51
*** bhagyashris has quit IRC09:51
*** gibi has quit IRC10:01
*** jaosorior has joined #openstack-nova10:03
*** k_mouza has quit IRC10:04
*** gibi has joined #openstack-nova10:08
*** k_mouza has joined #openstack-nova10:23
openstackgerritChris Dent proposed openstack/nova master: Use external placement in functional tests  https://review.openstack.org/61794110:29
openstackgerritChris Dent proposed openstack/nova master: WIP: Delete the placement code  https://review.openstack.org/61821510:29
*** k_mouza has quit IRC10:32
*** jascott1 has quit IRC10:33
*** priteau has joined #openstack-nova10:37
*** erlon has joined #openstack-nova10:40
*** threestrands has quit IRC10:43
*** nehaalhat_ has quit IRC10:51
*** k_mouza has joined #openstack-nova10:53
*** k_mouza has quit IRC10:57
*** k_mouza has joined #openstack-nova10:59
*** yedongcan has left #openstack-nova11:03
*** mvkr has quit IRC11:03
*** sambetts_ is now known as sambetts|afk11:21
*** udesale has quit IRC11:28
*** Dinesh_Bhor has quit IRC11:37
*** xek has quit IRC11:39
*** mvkr has joined #openstack-nova11:43
*** sean-k-mooney has joined #openstack-nova11:46
*** mugsie has joined #openstack-nova11:49
*** janki has quit IRC11:50
*** tssurya has quit IRC11:55
*** janki has joined #openstack-nova11:56
*** psachin has quit IRC12:01
openstackgerritJens Harbott (frickler) proposed openstack/nova stable/queens: Make supports_direct_io work on 4096b sector size  https://review.openstack.org/61922012:01
*** xek has joined #openstack-nova12:04
openstackgerritElod Illes proposed openstack/nova master: Transform scheduler.select_destinations notification  https://review.openstack.org/50850612:06
openstackgerritJan Gutter proposed openstack/nova-specs master: Spec to implement os-vif generic datapath offloads  https://review.openstack.org/60761012:10
*** janki has quit IRC12:12
*** brinzhang has quit IRC12:15
*** brinzhang has joined #openstack-nova12:15
*** brinzhang has quit IRC12:16
*** brinzhang has joined #openstack-nova12:17
*** phillu has joined #openstack-nova12:19
mnaserhttps://review.openstack.org/#/c/615134/12:26
mnaserthis has been sitting for a little while and it's very trivial12:26
*** pvradu has joined #openstack-nova12:31
*** pvradu has quit IRC12:32
*** pvradu has joined #openstack-nova12:33
jangutter^^ impressive amount of CI checks against that one.12:34
sean-k-mooneymnaser: so the logic is really old flavor could only be plublic so default to public? if that is the case then yes this makes sense12:36
mnaserjangutter: i pride myself in checking my stuff, hah12:37
mnasersean-k-mooney: well we either have to assume its public or its not.  given that we default to public=True, and that field is missing, it probably is true12:38
*** brinzhang has quit IRC12:38
sean-k-mooneyok i can see the logic in that argument.12:38
*** dtantsur is now known as dtantsur|brb12:47
sean-k-mooneyjaypipes: https://review.openstack.org/#/c/602384/ responces in line. ill respin once you decide if you would like to see addtional changes but i think the typo was the only thing you wanted adressed in the patch correct12:57
jaypipessean-k-mooney: yup. was just curious about the other questions...13:01
*** tssurya has joined #openstack-nova13:02
*** zul has joined #openstack-nova13:13
sean-k-mooneycool in that case ill fix the typo. can you cast your eye over the follow up patch when you have a chance13:14
*** k_mouza has quit IRC13:17
*** k_mouza has joined #openstack-nova13:30
*** maciejjozefczyk has joined #openstack-nova13:46
*** ratailor has quit IRC13:49
*** mriedem has joined #openstack-nova13:49
mriedemdansmith: lyarwood: https://review.openstack.org/#/q/topic:bug/1799892+(status:open+OR+status:merged) on stable should be good to go now13:49
mriedemother cores, the hpet change just needs a final +2 https://review.openstack.org/#/c/605902/13:50
openstackgerritHervĂ© Beraud proposed openstack/nova stable/rocky: Stop to mocking oslo.service.loopingcall._ThreadingEvent since this class was removed  https://review.openstack.org/61924613:53
*** whoami-rajat has quit IRC13:54
*** maciejjozefczyk has quit IRC13:56
fricklermriedem: do you want to continue waiting on https://review.openstack.org/616580 ? it would be great if we could get that fix into the next round of stable releases, not sure whether there is something scheduled for that yet13:58
*** janki has joined #openstack-nova13:59
mriedemfrickler: i was waiting for more core reviews, but they didn't come, so approved14:00
mriedemyou'll need to backport to stable/rocky14:00
mriedemwe likely won't be doing a series of stable releases until after the US thanksgiving holiday (which is tomorrow)14:00
*** BlackDex has quit IRC14:02
openstackgerritJens Harbott (frickler) proposed openstack/nova stable/rocky: Make supports_direct_io work on 4096b sector size  https://review.openstack.org/61925114:02
*** peeejayz has joined #openstack-nova14:03
*** pvradu_ has joined #openstack-nova14:03
*** munimeha1 has joined #openstack-nova14:03
fricklermriedem: stable/rocky is a simple cherry-pick from master, which I did now. stable/queens required editing because the function moved its location, which is why I prepared that patch earlier14:04
*** BlackDex has joined #openstack-nova14:04
*** pvradu has quit IRC14:07
*** pvradu_ has quit IRC14:07
*** dtantsur|brb is now known as dtantsur14:07
*** pvradu has joined #openstack-nova14:08
fricklermriedem: do you think that it should also go into pike and ocata? seems those would require more editing, but the bug is present in those branches, too.14:08
openstackgerritHervĂ© Beraud proposed openstack/nova stable/rocky: Stop to mocking oslo.service.loopingcall._ThreadingEvent since this class was removed  https://review.openstack.org/61924614:08
mriedemfrickler: can you re-cherry-pick to rocky using the command line?14:09
mriedemwith the -x option14:09
mriedemthe gerrit UI won't do that until the change you're cherry picking *from* has merged14:09
mriedemfrickler: ocata is in extended maintenance mode and i'm not really sure this needs to go that far back upstream14:10
*** Sundar has joined #openstack-nova14:10
mriedemEM means it *could* go that far back, but i'm not sure it's high enough priority14:10
mriedems/priority/severity/14:10
fricklermriedem: oh, I was hoping gerrit would be the better option than command-line. but does it do anything other than add the "cherry picked from" line to the commit message? in that case I'd just add that line manually14:12
fricklermriedem: o.k., so I'll do pike but not ocata. pike is the release most of our deployments are currently running on.14:13
openstackgerritJens Harbott (frickler) proposed openstack/nova stable/rocky: Make supports_direct_io work on 4096b sector size  https://review.openstack.org/61925114:14
mriedemstable cores: we have quite a few rocky backports that need a final +2 https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/rocky+label:Code-Review=214:17
openstackgerritJens Harbott (frickler) proposed openstack/nova stable/pike: Make supports_direct_io work on 4096b sector size  https://review.openstack.org/61925414:18
*** jaosorior has quit IRC14:25
*** gary_perkins has joined #openstack-nova14:30
gary_perkinsHi! I'm not sure if this would be the best channel to ask, but I ask anyway :) I have a kolla-ansible deployment of Queens. I have set a nova policy rule  "os_compute_api:servers:create:zero_disk_flavor": "rule:admin_api"  to stop any image-backed instances with a zero root-disk from being created. I want to only allow cinder-volume backed instances. But, for some reason, this policy change has had no noticable effect. I'm expecting my "14:31
gary_perkinsopenstack server create" to return an error, but instead it creates an instance consuming local storage. Is there something I'm missing?14:31
gary_perkinsTIA14:31
*** k_mouza has quit IRC14:39
*** udesale has joined #openstack-nova14:39
*** k_mouza has joined #openstack-nova14:42
*** whoami-rajat has joined #openstack-nova14:43
*** davidsha has joined #openstack-nova14:53
*** cfriesen has joined #openstack-nova15:10
sean-k-mooneyso rather then ask this in the olso changel again.. the stien schdule does not list the nova specs freeze. is it m215:12
cdentsean-k-mooney: last I heard, yes, but I don't have a good memory for arbitrary deadlines15:15
sean-k-mooneycdent: ya that i why i check the scduel. m2 is still the first week of january so that means really the dealin is decemebr ish before people evaporate15:17
SundarCan somebody tell me how to derive a SQLalchemy model (table) from an OVO, or vice versa?15:17
dansmithSundar: they're not related15:18
jangutterrule of thumb, the spec freeze is about two weeks before the first possible free time of the reviewers who can approve them.15:18
dansmithSundar: some of our SQLA models match our OVO objects pretty close, but many do not.. but either way, they're not 1:115:18
Sundardansmith: So, we may have to represent the same object in 2 different ways and translate back and forth?15:19
dansmithSundar: I'm not sure I understand what you mean, but.. yes? In nova at least, the model is how we store it, and the OVO object is how we speak it over RPC.. sometimes they're very similar, but not always15:20
SundarOK. Thank you.15:20
*** jaosorior has joined #openstack-nova15:24
mriedemsean-k-mooney: https://wiki.openstack.org/wiki/Nova/Stein_Release_Schedule15:28
mriedemgary_perkins: you're sure disk=0 on the flavor?15:28
sean-k-mooneymriedem: ah thank you15:28
sean-k-mooneyah and the os-vif frees is listed too perfect15:29
mriedemgary_perkins: and that a bdm isn't being passed on the server create request?15:31
gary_perkinsmriedem: yes, disk=0 on the flavor15:31
gary_perkinsmriedem: bdm?15:32
mriedemblock_device_mapping_v215:33
gary_perkinsmy command line to spin up an instance is: os server create --image bionic-server-cloudimg-arm64 --flavor c2.large --key-name gary-key --nic net-id=2e8281a6-30f4-4cdc-b433-c87137413af7 test-115:33
mriedemthe dict-o-doom for boot from volume15:33
mriedemok and that image doesn't have a block_device_mapping_v2 property in it?15:33
mriedemwhich is the trojan horse way of boot from volume15:34
gary_perkinshmmm.. good point, will check15:34
mriedemfwiw, this is a functional test for exactly what you're trying to see https://github.com/openstack/nova/blob/d74f9d62c5c320539ff5a46f28b0104c3b236633/nova/tests/functional/wsgi/test_servers.py#L38515:34
mriedemmnaser was trying to switch the default on that rule in stein but it turns out the flavors used in devstack, which tempest uses in our CI, have disk=0 so they explode :) https://review.openstack.org/#/c/603910/15:36
gary_perkinsmriedem: thanks! and no block_device_mapping_v2 property15:36
gary_perkinsha!15:37
mnasermriedem: ah sorry i never actually got around cleaning that one up15:37
mriedemmnaser: it's going to be non-trivial15:37
mriedemgary_perkins: which policy file did you modify?15:37
mriedem/etc/nova/policy.json?15:38
janguttersomething that still shows how much of a noob I am: regarding blueprint and specs. Is there a specific order in which things get approved normally? spec -> blueprint? Or is it not ordered?15:38
mriedemmake sure whatever policy file you modified is the one this option points at https://docs.openstack.org/nova/queens/configuration/config.html#oslo_policy.policy_file15:38
mnasermriedem: because now in tempest we need to use a flavor that is non root_gb=0 first before that can ever work, right?15:38
mriedemjangutter: spec and then blueprint15:38
mriedemmnaser: yeah, and tempest is configured with flavors that devstack sets up in our CI15:38
mriedemhttps://github.com/openstack-dev/devstack/blob/master/lib/tempest#L19115:39
janguttermriedem: thanks!15:39
mriedemtempest is also configured with the cirros images https://github.com/openstack-dev/devstack/blob/master/lib/tempest#L32615:40
mriedemso maybe we just need to get the image size from glance and use that for the flavor disk size15:40
mnasermriedem: will we still be able to get coverage for bfv with root_gb=0 then?15:40
*** Sundar has quit IRC15:41
mnaseror that might involve probably adding tempest tests15:41
mriedemnot unless you add a specific test to tempest for that15:41
mriedemwe have functional tests in nova for it15:41
mriedembut those don't use a real virt driver15:41
mriedemyay min_disk=0 on the image http://logs.openstack.org/34/615134/2/check/tempest-full/f6d351a/controller/logs/devstacklog.txt.gz#_2018-11-02_13_20_26_69815:42
mriedemthat's helpful15:42
gary_perkinsmriedem: yes, /etc/nova/policy.json originally copied from https://docs.openstack.org/nova/queens/_downloads/nova.policy.yaml.sample15:43
mriedemgary_perkins: but what is [oslo_policy]/policy_file in nova.conf in the nova-api service pointing at?15:43
mriedemb/c you said policy.json but you linked to a policy.yaml sample15:43
gary_perkinsmriedem: oh, sorry. Just trying to find my original sample. That's obviously the wrong one15:45
gary_perkinsmriedem: nova.conf: policy_file = policy.json15:46
mriedemhmm, and you shouldn't have to restart nova-api after modifying the policy file, it should be read fresh each time15:47
*** ratailor has joined #openstack-nova15:48
gary_perkinsand ofc, policy.json has: "os_compute_api:servers:create:zero_disk_flavor": "rule:admin_api"15:49
gary_perkinsamongst may other policies!15:49
*** tssurya has quit IRC15:50
*** udesale has quit IRC15:58
*** Sundar has joined #openstack-nova16:01
*** adrianc has quit IRC16:09
*** phillu has quit IRC16:15
mriedemgary_perkins: i'm not sure. have you tried tweaking any other policy rules to make sure it's not something with the configuration of the policy file?16:17
*** ratailor has quit IRC16:24
*** k_mouza has quit IRC16:28
*** ileixe has quit IRC16:33
*** janki has quit IRC16:36
xekgibi, there are no versioned network.floating_ip.associate network.floating_ip.disassociate notifications?16:45
artommriedem, hey, so, I'm being told from people who were at summit that you were in the room at the NFV pain points session (https://etherpad.openstack.org/p/BER-nfv-hpc-pain-points). Now, to me, that sounds like nothing could make you happier than reviewing https://review.openstack.org/#/c/599587/, right ;)16:46
gibixek: is there an unversioned one from nova about those?16:46
*** Sundar has quit IRC16:47
gibixek: OK I see there is unversioned ones for those16:47
xekgibi, I see they are emitted in nova.network.floating_ips, but I'm not sure if there is an alternative somewhere else? maybe in neutron?16:47
mriedemartom: lots of things could make me happier16:48
*** k_mouza has joined #openstack-nova16:48
artommriedem, what if I promised ice cream?16:48
mriedemxek: gibi: i don't think we'd port that to versioned notifications since they are nova-network specific and that's deprecated16:48
mriedemartom: i have ice cream like 30 feet away16:49
artomFoiled again!16:49
artommriedem, in seriousness, I know y'all are overloaded, I'm just trying to get it over the line, so if you have energy/bandwidth, it'd be appreciated16:49
*** pcaruana has quit IRC16:50
gibixek, mriedem: yeah, I just found that it is only emitted from the nova network code patch, this is why they are not on the todo list for versioned transformation16:50
*** efried_back_mon has quit IRC16:51
gibixek: I don't know if neturon has a similar notification mechanism16:51
xekgibi, mriedem, it makes sense, thanks for clarifying that.16:52
gibimlavalle: ^^ do you happen to know if neutron emits notification about floating ips?16:52
*** xek_ has joined #openstack-nova16:54
*** xek has quit IRC16:57
*** helenafm has quit IRC17:02
mlavallegibi: what kind of notification are we talking about? the code sends notifications like this: https://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L140817:05
mlavalleThese are internal notifications. modules subscribe to these notifications to listen to events and process them17:06
mriedemmlavalle: yes same thing17:08
mriedemover rpc17:08
*** pvradu has quit IRC17:08
*** sambetts|afk has quit IRC17:14
mriedemmnaser: let's see what explodes https://review.openstack.org/61931917:14
*** betherly has joined #openstack-nova17:15
mnasermriedem: seems reasonable. i'll have to fix the functional tests soon17:15
mnaserugh the logs have been rotated out already17:15
mriedemyeah one thing at a time17:16
mriedemnot urgent17:16
*** sambetts_ has joined #openstack-nova17:16
*** k_mouza has quit IRC17:17
*** alex_xu has quit IRC17:17
*** xek_ is now known as xek17:18
*** alex_xu has joined #openstack-nova17:19
*** sridharg has quit IRC17:20
*** k_mouza has joined #openstack-nova17:21
*** betherly has quit IRC17:21
*** davidsha has quit IRC17:35
*** jaosorior has quit IRC17:41
openstackgerritMatt Riedemann proposed openstack/nova master: Remove NovaException logging from scatter_gather_cells  https://review.openstack.org/61911017:44
*** dtantsur is now known as dtantsur|afk17:49
*** derekh has quit IRC17:50
*** k_mouza has quit IRC18:12
dansmithI think Greg's windows box has a virus18:17
*** mriedem has quit IRC18:26
openstackgerritElod Illes proposed openstack/nova master: Transform scheduler.select_destinations notification  https://review.openstack.org/50850618:31
*** mriedem has joined #openstack-nova18:37
jangutterdansmith: please take this as a late night bad joke: isn't that a redundant statement?18:39
dansmithjangutter: yeah, maybe I should say "Greg's windows box has a virus and is proud enough to show off in public"18:40
*** ralonsoh has quit IRC18:40
openstackgerritMerged openstack/nova stable/queens: De-dupe subnet IDs when calling neutron /subnets API  https://review.openstack.org/61655118:45
*** xek has quit IRC19:00
*** xek has joined #openstack-nova19:08
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: implement reshaper for vgpu  https://review.openstack.org/59920819:10
openstackgerritElod Illes proposed openstack/nova master: Transform scheduler.select_destinations notification  https://review.openstack.org/50850619:14
openstackgerritMerged openstack/nova stable/rocky: Add recreate test for bug 1799892  https://review.openstack.org/61907519:15
openstackbug 1799892 in OpenStack Compute (nova) rocky "Placement API crashes with 500s in Rocky upgrade with downed compute nodes" [Medium,In progress] https://launchpad.net/bugs/1799892 - Assigned to Matt Riedemann (mriedem)19:15
mriedemeasy bug fix https://review.openstack.org/#/c/615134/19:24
*** prometheanfire has left #openstack-nova19:33
*** dklyle has quit IRC19:38
*** mvkr has quit IRC19:40
*** whoami-rajat has quit IRC19:41
mriedemanyone have any bright ideas on how to assert a semaphore context manager is called in unit tests? https://review.openstack.org/#/c/609180/7/nova/tests/unit/virt/libvirt/test_driver.py19:46
*** dklyle has joined #openstack-nova19:46
*** erlon has quit IRC19:49
sean-k-mooneymriedem: as in assert the semaphore was aquired on a partaclar code path?19:51
sean-k-mooneyjust looking19:52
mriedemhttp://paste.openstack.org/show/735916/19:57
sean-k-mooneymriedem: do you want sema.__enter__.assert_called_once() or just assert it is called19:58
mriedemdoes'nt matter19:59
mriedempoint is, i don't really want to add a bunch of mocks all over test code and never assert it's used20:00
sean-k-mooneyah ok20:00
sean-k-mooneyim not sure that does what you want20:02
sean-k-mooneyyou are asserting that the __enter__ metod of the sema context manager is called but will that not always be called by the with statement20:03
mriedemif i remove the code change for that method, the test fails20:03
mriedemwhich is what i'd expect20:03
sean-k-mooneyhum ok this is one of those things in python that i always have to trow in an interpreter to prove to myself it scorrect20:04
mriedemi also don't know why we have nova.privsep.qemu.convert_image but not everything uses it, there are a few places in here that are calling qemu-img convert outside of privsep20:06
mriedemdansmith: do you know anything about that? ^20:06
mriedemb/c i thought we declared mission accomplished on privsep stuff20:06
sean-k-mooneymriedem: are the fucntion that call it out side of privsep called from function with the prive sep decorator applied20:07
mriedemumm, no20:08
mriedemgrep _disk_raw_to_qcow2 in the libvirt driver20:08
mriedemit's using processutils from oslo20:08
mriedemand we're passing through a rootwrap helper20:09
dansmithmriedem: not everything like that needs to run privileged20:10
sean-k-mooneyttp://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/driver.py#n8361 is using oslo but i dont see a rootwarap helper20:10
dansmithmriedem: might be that we need image convert sometimes when reading from an lvm or something like that, I dunno20:10
mriedemok i'll pretend this never happene20:11
dansmithgood plan20:11
sean-k-mooneyassuimg the nova user has the correct permisiosn to read and write the vm images it shoudl be able to execute that command with out elevating20:11
mriedemjackding: so on that io concurrency change,20:11
mriedemi would just like to see that for the functional code paths that add the context manager,20:11
mriedemthat at least one corresponding unit test asserts the context manager is called20:11
mriedemlike i noted for _disk_raw_to_qcow220:12
mriedemthen i'm +20 on that change20:12
mriedemthe privsep one might not be possible20:12
sean-k-mooneybased on code search its only ever called once20:12
sean-k-mooneyhttp://codesearch.openstack.org/?q=_disk_raw_to_qcow2&i=nope&files=&repos=nova20:12
jackdingmriedem: I have added asserts for all places where sema is used. running tox now, will push after it's done.20:12
sean-k-mooneyhere in finish migration http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/driver.py#n843720:12
mriedemjackding: sweet20:13
openstackgerritJack Ding proposed openstack/nova master: Add I/O Semaphore to limit concurrent disk ops  https://review.openstack.org/60918020:15
*** cdent has quit IRC20:18
openstackgerritsean mooney proposed openstack/os-vif master: always create ovs port during plug  https://review.openstack.org/60238420:18
openstackgerritsean mooney proposed openstack/os-vif master: add isolate_vif config option  https://review.openstack.org/61253420:18
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Default embedded instance.flavor.is_public attribute  https://review.openstack.org/61934920:18
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Default embedded instance.flavor.is_public attribute  https://review.openstack.org/61935120:28
*** mvkr has joined #openstack-nova20:35
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Default embedded instance.flavor.is_public attribute  https://review.openstack.org/61935220:36
openstackgerritMerged openstack/nova stable/rocky: Consider root id is None in the database case  https://review.openstack.org/61907620:46
openstackgerritJack Ding proposed openstack/nova master: Add I/O Semaphore to limit concurrent disk ops  https://review.openstack.org/60918020:57
mriedemthere are some assertions made in this change which i'm not sure i agree with https://review.openstack.org/#/c/617927/20:58
mriedemhopefully that doesn't set some kind of precedent20:58
mriedemsaying nova supports cinder v1 is a stretch, but i wouldn't want someone to think, nova stein can't work with cinder from queens20:59
mriedembecause it totally should20:59
*** manjeets has quit IRC21:12
*** betherly has joined #openstack-nova21:13
openstackgerritMerged openstack/nova master: Default embedded instance.flavor.is_public attribute  https://review.openstack.org/61513421:20
*** betherly has quit IRC21:23
*** xek has quit IRC21:40
mriedemstephenfin: artom: i've granted your wish and reviewed the numa aware live migration spec and dumped some questions21:41
mriedemartom: can you tl;dr the diff from the approved spec in rocky to stein?21:42
mriedembecause this essentially sounds like, do the RT/claim stuff like cold migration already does (and what nikola's old patch did)21:42
mriedemwas the rocky version of the spec much more dependent on actually modeling numa in placement?21:42
openstackgerritZane Bitter proposed openstack/nova stable/rocky: Don't use private interface in oslo.service  https://review.openstack.org/61936021:44
sean-k-mooneythe stine one has been refined somewhat to not depend on plamcennt at all21:44
openstackgerritmelanie witt proposed openstack/nova-specs master: Propose counting quota usage from placement and API database  https://review.openstack.org/50904221:44
sean-k-mooneymriedem: it will prefrom claims in the RT on the destination node and pass back the topology info as ovo form the dest to the source the same way we did for the multi port bindings spec21:45
mriedemsean-k-mooney: i just read the stein one21:47
mriedemi was looking for the summary on the diff from the rocky spec21:47
sean-k-mooneyah ok stephen just proposed tthe rocky one as is so the delta should just be comparing to v1 of the stein one21:48
sean-k-mooneythere was no content change when stepen reproposed it so https://review.openstack.org/#/c/599587/1..6/specs/stein/approved/numa-aware-live-migration.rst will show you the delta21:50
sean-k-mooneybasicaly we added detail for the resouce claimes section and how the nume info on the destinaiton woudl be generated21:51
artommriedem, whoa, thanks dude21:53
artomWhat sean-k-mooney said. And also how the destination will communicate said NUMA stuff to the source21:53
mriedemright, ok so no placement21:54
mriedemgot it21:54
artomAnd more explicitly spelled out why we can't use just placement (even if it was ready, which it isn't) and still need the resource tracker21:54
mriedemgiven that, i'm going to f off for thanksgiving now21:54
artomFair enough, r right off then :)21:55
artom*f21:55
sean-k-mooneymriedem: enjoy the break o/21:55
*** betherly has joined #openstack-nova21:55
artomI haven't fully parsed your feedback then, but I'll have a new version for you when you're back21:55
artoms/then/yet21:55
artomwtf brain21:55
*** mriedem has quit IRC21:59
openstackgerritMatt Riedemann proposed openstack/nova stable/ocata: Default embedded instance.flavor.is_public attribute  https://review.openstack.org/61936622:00
*** betherly has quit IRC22:00
*** betherly has joined #openstack-nova22:02
*** betherly has quit IRC22:06
*** rcernin has joined #openstack-nova22:09
*** priteau has quit IRC22:16
*** erlon has joined #openstack-nova22:26
*** Dinesh_Bhor has joined #openstack-nova22:30
sean-k-mooneycfriesen: by the way were you aware we approved a spec for vTPM on hyperv back in liberty https://specs.openstack.org/openstack/nova-specs/specs/liberty/approved/hyper-v-vtpm-devices.html22:38
openstackgerritMerged openstack/nova master: Make supports_direct_io work on 4096b sector size  https://review.openstack.org/61658022:39
sean-k-mooneycfriesen: it also got appoved in mitaka but i dont think they ever implmented it22:42
*** imacdonn has quit IRC22:42
*** imacdonn has joined #openstack-nova22:42
sean-k-mooneyactully they do http://git.openstack.org/cgit/openstack/compute-hyperv/tree/compute_hyperv/nova/vmops.py#n133422:44
cfriesensean-k-mooney: hadn't seen it.  now I'm obligated to go check it out. :)22:45
cfriesenwhat git tree is that?  I don't see any use of "vtpm" in nova, so it seems like it was never implemented on the nova side.22:48
sean-k-mooneyits in  openstack/compute-hyperv22:48
sean-k-mooneyhttps://github.com/openstack/compute-hyperv its still active aparently22:49
cfriesenlooks like it was superceded by https://blueprints.launchpad.net/nova/+spec/hyper-v-shielded-vms22:50
*** betherly has joined #openstack-nova22:51
sean-k-mooneyim going to add thi to the reply i was sending to fungi on the ml22:52
cfriesenwas proposed late for ocata, but doesn't seem to have been re-proposed for pike22:53
sean-k-mooneywell hyperv had an out of tree driver just like power so i guess they did not need to reporpose to support it22:54
*** betherly has quit IRC22:57
*** betherly has joined #openstack-nova23:08
*** munimeha1 has quit IRC23:09
fungithanks for the details, sean-k-mooney!23:14
fungiand yeah, in the future where hosts which have legit tpms can pass them through the hypervisor to guests, as long as it's apparent to the guest whether it's getting an actual tpm or an emulated one i think that's probably fine23:18
*** betherly has quit IRC23:18
*** mlavalle has quit IRC23:18
fungiat least running the emulated tpm on the hypervisor is still a step up from running an emulated tpm inside the guest itself23:19
*** Dinesh_Bhor has quit IRC23:20
fungicertainly an attacker with access to the host can clone and impersonate the tpm (unlike with a proper hardware one) but that's a higher barrier than compromising the guest23:22
*** rm_work has quit IRC23:33
*** rm_work has joined #openstack-nova23:33
*** slaweq has quit IRC23:45
*** lbragstad is now known as lbragstad_turkey23:46
*** betherly has joined #openstack-nova23:48
openstackgerritMerged openstack/nova master: Use long_rpc_timeout in select_destinations RPC call  https://review.openstack.org/60773523:51
*** zul has quit IRC23:51
*** betherly has quit IRC23:53
openstackgerritMerged openstack/nova stable/pike: Handle HostMappingNotFound when deleting a compute service  https://review.openstack.org/58356723:55
*** lbragstad_turkey has quit IRC23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!