| *** wolverineav has quit IRC | 00:01 | |
| *** wolverineav has joined #openstack-nova | 00:04 | |
| *** wolverineav has quit IRC | 00:07 | |
| *** wolverineav has joined #openstack-nova | 00:07 | |
| *** hongbin has quit IRC | 00:07 | |
| *** _alastor_ has quit IRC | 00:11 | |
| *** tosky has quit IRC | 00:14 | |
| *** sdake has quit IRC | 00:25 | |
| *** sdake has joined #openstack-nova | 00:29 | |
| *** sdake has quit IRC | 00:30 | |
| *** N3l1x has joined #openstack-nova | 00:32 | |
| *** Nel1x has quit IRC | 00:32 | |
| jackding | cfriesen: need your opinion on https://review.openstack.org/#/c/603844/ | 00:35 |
|---|---|---|
| *** TxGirlGeek has quit IRC | 00:44 | |
| *** wolverineav has quit IRC | 00:45 | |
| *** wolverineav has joined #openstack-nova | 00:45 | |
| *** wolverineav has quit IRC | 00:46 | |
| *** wolverineav has joined #openstack-nova | 00:46 | |
| *** Swami has quit IRC | 00:47 | |
| *** wolverineav has quit IRC | 00:50 | |
| *** wolverineav has joined #openstack-nova | 00:54 | |
| *** sdake has joined #openstack-nova | 00:56 | |
| *** wolverineav has quit IRC | 00:59 | |
| *** sdake has quit IRC | 01:03 | |
| *** wolverineav has joined #openstack-nova | 01:10 | |
| *** whoami-rajat has joined #openstack-nova | 01:18 | |
| *** sdake has joined #openstack-nova | 01:19 | |
| *** ircuser-1 has joined #openstack-nova | 01:21 | |
| *** sdake has quit IRC | 01:27 | |
| *** sdake has joined #openstack-nova | 01:35 | |
| *** gbarros has quit IRC | 01:37 | |
| openstackgerrit | Merged openstack/nova master: Reject evacuate with port having resource request https://review.openstack.org/630724 | 01:37 |
| *** macza has quit IRC | 01:49 | |
| *** sdake has quit IRC | 01:52 | |
| *** wolverineav has quit IRC | 02:00 | |
| *** wolverineav has joined #openstack-nova | 02:02 | |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for cyborg access https://review.openstack.org/631242 | 02:05 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to spec obj. https://review.openstack.org/631243 | 02:05 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.openstack.org/631244 | 02:05 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.openstack.org/631245 | 02:05 |
| *** macza has joined #openstack-nova | 02:09 | |
| openstackgerrit | Merged openstack/nova master: Add support for vrouter HW datapath offloads https://review.openstack.org/572082 | 02:17 |
| *** owalsh_ has joined #openstack-nova | 02:18 | |
| *** gbarros has joined #openstack-nova | 02:18 | |
| *** owalsh has quit IRC | 02:21 | |
| *** sdake has joined #openstack-nova | 02:22 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:32 | |
| *** gyee has quit IRC | 02:35 | |
| *** rchurch_ has joined #openstack-nova | 02:35 | |
| *** rchurch has quit IRC | 02:36 | |
| *** awalende has joined #openstack-nova | 02:44 | |
| *** awalende has quit IRC | 02:49 | |
| *** wolverineav has quit IRC | 02:51 | |
| *** Dinesh_Bhor has quit IRC | 02:58 | |
| *** hongbin has joined #openstack-nova | 03:00 | |
| *** efried has quit IRC | 03:03 | |
| *** efried has joined #openstack-nova | 03:03 | |
| *** psachin has joined #openstack-nova | 03:04 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:04 | |
| *** sdake has quit IRC | 03:17 | |
| *** sdake has joined #openstack-nova | 03:18 | |
| *** cfriesen has quit IRC | 03:20 | |
| *** BjoernT has joined #openstack-nova | 03:26 | |
| *** hongbin has quit IRC | 03:34 | |
| *** sdake has quit IRC | 03:35 | |
| *** dave-mccowan has quit IRC | 03:44 | |
| *** Dinesh_Bhor has quit IRC | 03:54 | |
| *** sdake has joined #openstack-nova | 03:57 | |
| *** lbragstad has quit IRC | 03:59 | |
| *** takashin has joined #openstack-nova | 04:01 | |
| *** tbachman has quit IRC | 04:01 | |
| *** tbachman has joined #openstack-nova | 04:03 | |
| *** igordc has quit IRC | 04:08 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Move setting mac addresses for network devices to privsep. https://review.openstack.org/621529 | 04:16 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move interface disabling to privsep. https://review.openstack.org/622150 | 04:16 |
| *** sdake has quit IRC | 04:16 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Move binding ips to privsep. https://review.openstack.org/622151 | 04:16 |
| openstackgerrit | Michael Still proposed openstack/nova master: create_veth_pair is unused, remove it. https://review.openstack.org/624226 | 04:16 |
| openstackgerrit | Michael Still proposed openstack/nova master: Create specialist set_macaddr_and_vlan helper. https://review.openstack.org/624227 | 04:16 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move create_tap_dev into privsep. https://review.openstack.org/624228 | 04:16 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move set_vf_interface_vlan to be with its only caller. https://review.openstack.org/624229 | 04:16 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move DHCP releasing to privsep. https://review.openstack.org/624230 | 04:16 |
| openstackgerrit | Michael Still proposed openstack/nova master: Convert additional IP management calls to privsep. https://review.openstack.org/624231 | 04:16 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move route management to privsep. https://review.openstack.org/624232 | 04:16 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move additional IP address management to privsep. https://review.openstack.org/624591 | 04:16 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move slight bonkers IP management to privsep. https://review.openstack.org/624592 | 04:16 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move arping to privsep. https://review.openstack.org/624593 | 04:16 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move cleaning conntrack to privsep. https://review.openstack.org/624594 | 04:16 |
| *** udesale has joined #openstack-nova | 04:17 | |
| *** BjoernT has quit IRC | 04:22 | |
| *** gbarros has quit IRC | 04:33 | |
| *** bhagyashris_ has joined #openstack-nova | 04:38 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:42 | |
| *** sdake has joined #openstack-nova | 04:45 | |
| *** macza has quit IRC | 04:45 | |
| *** lpetrut has joined #openstack-nova | 04:46 | |
| *** wolverineav has joined #openstack-nova | 04:46 | |
| *** slaweq has joined #openstack-nova | 04:55 | |
| *** dims has quit IRC | 04:58 | |
| *** macza has joined #openstack-nova | 05:08 | |
| *** ratailor has joined #openstack-nova | 05:13 | |
| *** N3l1x has quit IRC | 05:19 | |
| *** lpetrut has quit IRC | 05:23 | |
| *** wolverineav has quit IRC | 05:26 | |
| *** sridharg has joined #openstack-nova | 05:28 | |
| *** janki has joined #openstack-nova | 05:42 | |
| *** mdbooth_ has joined #openstack-nova | 05:49 | |
| *** slaweq has quit IRC | 05:49 | |
| *** macza has quit IRC | 05:50 | |
| *** BjoernT has joined #openstack-nova | 05:51 | |
| *** mdbooth has quit IRC | 05:52 | |
| *** efried1 has joined #openstack-nova | 06:01 | |
| *** efried has quit IRC | 06:02 | |
| *** efried1 is now known as efried | 06:02 | |
| *** sdake has quit IRC | 06:03 | |
| *** BjoernT has quit IRC | 06:16 | |
| *** wolverineav has joined #openstack-nova | 06:38 | |
| *** wolverineav has quit IRC | 06:42 | |
| *** markvoelker has joined #openstack-nova | 06:45 | |
| *** Luzi has joined #openstack-nova | 06:48 | |
| *** dims has joined #openstack-nova | 06:48 | |
| *** dims has quit IRC | 06:52 | |
| *** dims has joined #openstack-nova | 06:54 | |
| *** ralonsoh has joined #openstack-nova | 06:58 | |
| *** dims has quit IRC | 06:59 | |
| *** slaweq has joined #openstack-nova | 07:00 | |
| *** dims has joined #openstack-nova | 07:02 | |
| *** abhishekk has joined #openstack-nova | 07:04 | |
| *** jaypipes has quit IRC | 07:05 | |
| *** jaypipes has joined #openstack-nova | 07:06 | |
| *** moshele has joined #openstack-nova | 07:16 | |
| *** moshele has quit IRC | 07:18 | |
| *** markvoelker has quit IRC | 07:18 | |
| openstackgerrit | Yury Kulazhenkov proposed openstack/nova master: rename ScaleIO driver to VxFlex Os https://review.openstack.org/634866 | 07:20 |
| *** ratailor has quit IRC | 07:21 | |
| *** pcaruana has joined #openstack-nova | 07:45 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:50 | |
| *** ccamacho has joined #openstack-nova | 07:58 | |
| *** takashin has left #openstack-nova | 07:59 | |
| *** tesseract has joined #openstack-nova | 08:02 | |
| *** rpittau has joined #openstack-nova | 08:04 | |
| *** panda is now known as panda|ko | 08:05 | |
| *** tkajinam has quit IRC | 08:06 | |
| *** awalende has joined #openstack-nova | 08:08 | |
| *** belmoreira has joined #openstack-nova | 08:09 | |
| *** markvoelker has joined #openstack-nova | 08:15 | |
| *** lpetrut has joined #openstack-nova | 08:21 | |
| *** lpetrut has quit IRC | 08:21 | |
| *** lpetrut has joined #openstack-nova | 08:22 | |
| *** Luzi_ has joined #openstack-nova | 08:25 | |
| *** helenafm has joined #openstack-nova | 08:26 | |
| *** Luzi has quit IRC | 08:27 | |
| *** lpetrut has quit IRC | 08:28 | |
| *** tssurya has joined #openstack-nova | 08:40 | |
| *** ttsiouts has joined #openstack-nova | 08:45 | |
| *** tetsuro has joined #openstack-nova | 08:47 | |
| *** markvoelker has quit IRC | 08:49 | |
| *** tosky has joined #openstack-nova | 08:50 | |
| *** tetsuro_ has joined #openstack-nova | 08:51 | |
| *** priteau has joined #openstack-nova | 08:51 | |
| *** priteau has joined #openstack-nova | 08:52 | |
| *** tetsuro has quit IRC | 08:54 | |
| *** ttsiouts has quit IRC | 08:55 | |
| *** lennyb has quit IRC | 08:55 | |
| *** lennyb has joined #openstack-nova | 08:58 | |
| *** xek__ has joined #openstack-nova | 09:01 | |
| *** ociuhandu has quit IRC | 09:03 | |
| *** Luzi_ has quit IRC | 09:07 | |
| *** Luzi has joined #openstack-nova | 09:07 | |
| *** ttsiouts has joined #openstack-nova | 09:08 | |
| *** adrianc has quit IRC | 09:21 | |
| *** ociuhandu has joined #openstack-nova | 09:24 | |
| *** Dinesh_Bhor has quit IRC | 09:35 | |
| *** Dinesh_Bhor has joined #openstack-nova | 09:36 | |
| *** adrianc has joined #openstack-nova | 09:44 | |
| *** markvoelker has joined #openstack-nova | 09:46 | |
| *** bhagyashris_ has quit IRC | 09:53 | |
| *** bauzas has quit IRC | 09:54 | |
| *** tetsuro has joined #openstack-nova | 09:57 | |
| *** tetsuro_ has quit IRC | 09:57 | |
| tinwood | Morning. I'm still waiting, please, for somebody to nay/yay on my very small nova review: https://review.openstack.org/#/c/633279/ Many thanks. | 09:59 |
| *** tetsuro_ has joined #openstack-nova | 10:12 | |
| *** tetsuro has quit IRC | 10:15 | |
| *** markvoelker has quit IRC | 10:19 | |
| *** wolverineav has joined #openstack-nova | 10:19 | |
| *** wolverineav has quit IRC | 10:24 | |
| *** ociuhandu_ has joined #openstack-nova | 10:28 | |
| *** bauzas has joined #openstack-nova | 10:29 | |
| *** ociuhandu has quit IRC | 10:31 | |
| *** tetsuro_ has quit IRC | 10:33 | |
| *** slaweq has quit IRC | 10:33 | |
| *** erlon has joined #openstack-nova | 10:45 | |
| *** owalsh_ is now known as owalsh | 10:48 | |
| *** slaweq has joined #openstack-nova | 10:50 | |
| *** slaweq has quit IRC | 10:54 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239 | 10:54 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528 | 10:54 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pass resource provider mapping to neutronv2 api https://review.openstack.org/616240 | 10:54 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule https://review.openstack.org/619529 | 10:54 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding https://review.openstack.org/569459 | 10:54 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317 | 10:54 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 10:54 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 10:54 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 10:54 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 10:54 |
| *** moshele has joined #openstack-nova | 10:58 | |
| *** derekh has joined #openstack-nova | 11:03 | |
| *** s1061123 has quit IRC | 11:04 | |
| *** s1061123 has joined #openstack-nova | 11:04 | |
| *** aloga has quit IRC | 11:05 | |
| *** ccamacho has quit IRC | 11:05 | |
| *** tbachman has quit IRC | 11:07 | |
| *** tbachman has joined #openstack-nova | 11:08 | |
| *** Dinesh_Bhor has quit IRC | 11:11 | |
| *** ttsiouts has quit IRC | 11:12 | |
| *** cdent has joined #openstack-nova | 11:12 | |
| *** ccamacho has joined #openstack-nova | 11:12 | |
| *** ttsiouts has joined #openstack-nova | 11:12 | |
| *** Dinesh_Bhor has joined #openstack-nova | 11:13 | |
| *** markvoelker has joined #openstack-nova | 11:15 | |
| *** ttsiouts has quit IRC | 11:16 | |
| *** udesale has quit IRC | 11:28 | |
| *** moshele has quit IRC | 11:32 | |
| *** slaweq has joined #openstack-nova | 11:46 | |
| *** markvoelker has quit IRC | 11:48 | |
| *** tbachman has quit IRC | 11:49 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells https://review.openstack.org/591657 | 11:51 |
| *** _hemna has quit IRC | 11:51 | |
| *** aloga has joined #openstack-nova | 11:52 | |
| *** owalsh_ has joined #openstack-nova | 11:57 | |
| *** owalsh has quit IRC | 11:59 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: API: Remove evacuate/live-migrate 'force' parameter https://review.openstack.org/634600 | 11:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't force evacuate/live migrate in notification sample tests https://review.openstack.org/634920 | 11:59 |
| *** abhishekk has quit IRC | 12:00 | |
| *** owalsh_ has quit IRC | 12:03 | |
| *** owalsh has joined #openstack-nova | 12:04 | |
| *** slaweq has quit IRC | 12:09 | |
| *** owalsh- has joined #openstack-nova | 12:10 | |
| *** owalsh has quit IRC | 12:12 | |
| *** owalsh- is now known as owalsh | 12:21 | |
| *** slaweq has joined #openstack-nova | 12:26 | |
| *** slaweq has quit IRC | 12:30 | |
| *** ttsiouts has joined #openstack-nova | 12:31 | |
| *** samc-bbc has quit IRC | 12:32 | |
| *** slaweq has joined #openstack-nova | 12:36 | |
| *** dpawlik has quit IRC | 12:47 | |
| *** moshele has joined #openstack-nova | 12:51 | |
| *** janki has quit IRC | 12:59 | |
| *** slaweq has quit IRC | 12:59 | |
| openstackgerrit | Merged openstack/nova master: Follow up for per-instance serial number change https://review.openstack.org/634743 | 13:01 |
| openstackgerrit | Jan Gutter proposed openstack/nova master: Ignore some PendingDeprecationWarnings for os-vif https://review.openstack.org/634928 | 13:01 |
| *** tbachman has joined #openstack-nova | 13:04 | |
| *** lbragstad has joined #openstack-nova | 13:05 | |
| *** sdake has joined #openstack-nova | 13:05 | |
| *** tbachman_ has joined #openstack-nova | 13:06 | |
| *** tbachman has quit IRC | 13:09 | |
| *** tbachman_ is now known as tbachman | 13:09 | |
| jangutter | mriedem: ^ apologies for contributing to g8h8 2019 | 13:10 |
| *** mriedem has joined #openstack-nova | 13:11 | |
| *** jmlowe has quit IRC | 13:17 | |
| mriedem | https://blueprints.launchpad.net/nova/+spec/libvirt-neutron-sriov-livemigration and https://blueprints.launchpad.net/nova/+spec/handling-down-cell are now in runway slots | 13:18 |
| openstackgerrit | Merged openstack/nova master: Move setting mac addresses for network devices to privsep. https://review.openstack.org/621529 | 13:23 |
| openstackgerrit | Merged openstack/nova master: Move interface disabling to privsep. https://review.openstack.org/622150 | 13:23 |
| *** Dinesh_Bhor has quit IRC | 13:30 | |
| *** jmlowe has joined #openstack-nova | 13:34 | |
| *** erlon has quit IRC | 13:41 | |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to spec obj. https://review.openstack.org/631243 | 13:45 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.openstack.org/631244 | 13:45 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.openstack.org/631245 | 13:45 |
| openstackgerrit | Merged openstack/nova master: Reject unshelve with port having resource request https://review.openstack.org/630725 | 13:48 |
| *** mvkr has quit IRC | 13:52 | |
| *** sdake has quit IRC | 13:54 | |
| *** wolverineav has joined #openstack-nova | 13:56 | |
| *** wolverineav has quit IRC | 14:00 | |
| *** sdake has joined #openstack-nova | 14:04 | |
| *** moshele has quit IRC | 14:06 | |
| *** eharney has joined #openstack-nova | 14:07 | |
| *** dave-mccowan has joined #openstack-nova | 14:09 | |
| *** psachin has quit IRC | 14:09 | |
| *** dave-mccowan has quit IRC | 14:13 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Drop nova-multiattach job https://review.openstack.org/606981 | 14:14 |
| mriedem | jaypipes: next 2 in the bw provider series are awaiting your loving embrace https://review.openstack.org/#/c/567268/ | 14:15 |
| gibi_off | mriedem, jaypipes: thank your for the reviews! | 14:16 |
| *** markvoelker has joined #openstack-nova | 14:16 | |
| cdent | gibi_off: I hope you're feeling well, or at least headed that way | 14:17 |
| *** sdake has quit IRC | 14:17 | |
| *** cfriesen has joined #openstack-nova | 14:18 | |
| gibi_off | cdent: thanks, I'm pretty OK | 14:19 |
| *** mvkr has joined #openstack-nova | 14:20 | |
| gibi_off | cdent: I still have some extra medical steps ahead but so far so good | 14:21 |
| cdent | glad to hear it, good luck with it all | 14:21 |
| gibi_off | cdent: thanks | 14:21 |
| gibi_off | I think I will remove the _off postfix from next week | 14:22 |
| cdent | whatever you do, don't let openstack rush things | 14:22 |
| * edleafe laughs at seeing "OpenStack" and "rush" in the same sentence | 14:23 | |
| gibi_off | I use openstack (and software dev in general) as something agains boredom | 14:23 |
| *** erlon has joined #openstack-nova | 14:24 | |
| *** ttsiouts has quit IRC | 14:30 | |
| *** ttsiouts has joined #openstack-nova | 14:31 | |
| efried | tinwood: I left a +2. I'm hoping the second comes from someone like dansmith who knows how to spell OVO | 14:32 |
| *** udesale has joined #openstack-nova | 14:32 | |
| tinwood | efried, thanks very much. | 14:33 |
| *** sdake has joined #openstack-nova | 14:33 | |
| efried | You're welcome, fwiw :) | 14:34 |
| *** ttsiouts has quit IRC | 14:36 | |
| dansmith | I commented | 14:38 |
| dansmith | I'm not really in favor of tracking every possible out of tree driver in our objects | 14:38 |
| dansmith | so I'll let someone else +2 that | 14:38 |
| efried | dansmith: An alternative would be to make that a string field so drivers can put their name in there without having to exist in an enum. Is that enum used for anything else anywhere ever? | 14:41 |
| dansmith | yeah I dunno why it's an enum, and don't know where it's used | 14:41 |
| efried | I looked yesterday and couldn't find anywhere other than in the diagnostics object. | 14:42 |
| efried | I think | 14:42 |
| efried | yeah | 14:42 |
| *** sdake has quit IRC | 14:45 | |
| bauzas | afternoon, folks | 14:47 |
| *** ttsiouts has joined #openstack-nova | 14:47 | |
| bauzas | here and now, I begin my upstream day | 14:47 |
| efried | \o/ | 14:47 |
| bauzas | any fancy reviews to make ? | 14:48 |
| *** markvoelker has quit IRC | 14:49 | |
| *** sdake has joined #openstack-nova | 14:49 | |
| efried | dansmith, tinwood: I looked at the in-tree usages of get_instance_diagnostics, and they're all using a string to set that field; none of them are using the actual enum class. So changing that to a string field would require no changes *in tree*. Out of tree, I suppose it would be harmless if we kept the enum around (deprecated) and let folks know to transition to using a plain string. | 14:49 |
| tinwood | efried, I tried that, but it errored out as the field checks the enum for the string. | 14:50 |
| *** BjoernT has joined #openstack-nova | 14:50 | |
| tinwood | That's how I found I needed to update the enum. | 14:50 |
| *** awaugama has joined #openstack-nova | 14:50 | |
| efried | tinwood: You tried just using a string in your oot get_instance_diagnostics impl? | 14:50 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Drop the integrated-gate (py27) template https://review.openstack.org/634949 | 14:52 |
| tinwood | efried, yes, I wouldn't have changed nova except it wouldn't accept 'lxd'. The equivalent change in nova-lxd needing it is a string: https://review.openstack.org/#/c/633270/3/nova/virt/lxd/driver.py | 14:53 |
| *** BjoernT_ has joined #openstack-nova | 14:53 | |
| tinwood | efried, line 1175 | 14:53 |
| efried | Yeah, so that's what I'm saying. Instead of augmenting the enum every time some OOT (or in-tree for that matter) driver needs to implement get_instance_diagnostics, let's just change the field in the Diagnostics object to a StringField. We can deprecate the HypervisorDriver enum (or not, I guess it doesn't really matter if drivers want to use it to get their string). That way, any impl - in tree or out - can use any string they l | 14:53 |
| efried | without having to dork with this enum. | 14:53 |
| *** awalende has quit IRC | 14:54 | |
| tinwood | efried, ah, I see - well, it would help me ... :) | 14:54 |
| efried | I mean, I get the value in having a discrete set of values allowed in that field, but I don't think it's probably worth the hassle in this case. | 14:54 |
| *** BjoernT has quit IRC | 14:54 | |
| *** awalende has joined #openstack-nova | 14:55 | |
| efried | dansmith: would you be supportive of such a change? | 14:55 |
| dansmith | efried: we should ask whoever added that | 14:55 |
| dansmith | but this falls into the realm of my previous meh on the topic | 14:55 |
| efried | sergei nitikin | 14:56 |
| efried | nikitin | 14:56 |
| efried | blueprint restore-vm-diagnostics | 14:56 |
| *** sdake has quit IRC | 14:56 | |
| cdent | mriedem: to avoid a pointless "woot, yeah" response to your recent email, I say "woot, yeah" here. | 14:57 |
| cdent | woot, yeah | 14:57 |
| *** priteau has quit IRC | 14:58 | |
| *** ociuhandu_ has quit IRC | 14:58 | |
| *** ociuhandu has joined #openstack-nova | 14:58 | |
| * efried reads spec: http://specs.openstack.org/openstack/nova-specs/specs/ocata/approved/restore-vm-diagnostics.html | 14:58 | |
| efried | tinwood: ^ | 14:58 |
| tinwood | efried, taking a look | 14:59 |
| mriedem | cdent: woot acknowledged | 14:59 |
| *** Nel1x has joined #openstack-nova | 14:59 | |
| *** _hemna has joined #openstack-nova | 14:59 | |
| *** awalende has quit IRC | 14:59 | |
| efried | The spec doesn't say it's an enum. It says it's a string. The enum-ness must have been decided during impl time. | 14:59 |
| tinwood | efried, indeed. But I can't merge my nova-lxd change as nova either needs a change to the enum-ness or adding the lxd bit. I could take a look at removing the enumness if that would help? | 15:00 |
| *** betherly has joined #openstack-nova | 15:00 | |
| tinwood | efried, which would you prefer? | 15:00 |
| efried | tinwood: Yes, clearly you need a change to nova, I get that. I also get dansmith's position of not wanting to enumerate OOT drivers in an in-tree object. I think changing to a string field is a good compromise. Can you dig it? | 15:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove PLACEMENT_DB_ENABLED from nova-next job config https://review.openstack.org/634953 | 15:02 |
| tinwood | efried, sure, happy to take a crack at that. | 15:02 |
| efried | your code will work the same either way | 15:02 |
| efried | okay. I'll leave a comment on your review. | 15:02 |
| efried | tinwood: you can use the same change set, so we can keep track of this thread of discussion. | 15:02 |
| tinwood | efried, okay, will do. | 15:03 |
| *** sdake has joined #openstack-nova | 15:04 | |
| *** betherly has quit IRC | 15:05 | |
| *** udesale has quit IRC | 15:06 | |
| *** slaweq has joined #openstack-nova | 15:08 | |
| efried | tinwood: wrt getting rid of HypervisorDriver[Field], my opinion is that we should just kill it, with a warning sent out to the ML in case downstream/oot code happens to be using it (which seems like a really low probability). Would you like to craft that patch and/or ML post as well? | 15:09 |
| tinwood | Sure, I can do the patch. The ML patch; yes, I can probably draft something. | 15:10 |
| *** Luzi has quit IRC | 15:12 | |
| efried | tinwood: Thanks! | 15:12 |
| tinwood | np :) | 15:13 |
| *** gbarros has joined #openstack-nova | 15:13 | |
| *** mlavalle has joined #openstack-nova | 15:15 | |
| *** gbarros has quit IRC | 15:16 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: API: Remove evacuate/live-migrate 'force' parameter https://review.openstack.org/634600 | 15:26 |
| *** betherly has joined #openstack-nova | 15:29 | |
| *** betherly has quit IRC | 15:30 | |
| *** maciejjozefczyk has quit IRC | 15:30 | |
| sean-k-mooney | efried: which hypervior driver filed | 15:31 |
| efried | sean-k-mooney: See https://review.openstack.org/#/c/633279/ | 15:31 |
| sean-k-mooney | efried: rather then kill it why not make it an string field | 15:33 |
| *** gbarros has joined #openstack-nova | 15:33 | |
| efried | sean-k-mooney: That's the plan: make the .driver field a StringField. But that's the only place HypervisorDriver[Field] is used, so we can get rid of that object. | 15:34 |
| sean-k-mooney | oh ok | 15:35 |
| *** lbragstad has quit IRC | 15:35 | |
| sean-k-mooney | efried: for compatiablity i think we woudl need to rename it too | 15:35 |
| *** lbragstad has joined #openstack-nova | 15:35 | |
| efried | sean-k-mooney: I don't think so. The data type per se isn't changing. | 15:36 |
| sean-k-mooney | efried: as in i dont think we are allowed to chagne types of fields in OVO | 15:36 |
| efried | sean-k-mooney: All existing in-tree consumers use a string to assign the field | 15:36 |
| sean-k-mooney | that is not my concern im wonderign how this will work during an upgrade | 15:37 |
| sean-k-mooney | e.g. if you had an old api node and a new compute | 15:38 |
| sean-k-mooney | i guess that shoudl not be and issue as you should upgrade your api and condocutor before the computes | 15:38 |
| sean-k-mooney | at least for majour upgrades | 15:38 |
| efried | adding an enum value doesn't make that better though, right? | 15:39 |
| efried | still have the same problem | 15:39 |
| efried | if you receive an object and it has a value you don't recognize in that field, you're borked either way. | 15:39 |
| efried | but at least making it a string field will avoid that problem in the future. | 15:40 |
| sean-k-mooney | well you would need to handel it in the object make compatioble function | 15:40 |
| sean-k-mooney | when you are downleveling it | 15:40 |
| sean-k-mooney | ya im just wondering if we shoudl rename it to driver_name when we make it a sting | 15:40 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Fix legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/634962 | 15:42 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 15:42 |
| efried | I'm not an ovo expert by any means. If that's necessary, so be it. | 15:42 |
| sean-k-mooney | efried: well i usuall check with dansmith for these kindo fo things. but in the past he has alswas asked if i am changing form a dict to an ovo for example that the filed be renamed. | 15:43 |
| sean-k-mooney | enum to string is slightly differnet | 15:44 |
| sean-k-mooney | but technically its the same | 15:44 |
| sean-k-mooney | you are still changeing datatypes | 15:44 |
| *** pchavva has joined #openstack-nova | 15:44 | |
| efried | Guess it depends how ovo is treating the enum. In python the enum value is just a string. | 15:45 |
| sean-k-mooney | yes the underlying python type is a sting in either case | 15:46 |
| *** markvoelker has joined #openstack-nova | 15:46 | |
| efried | other than checking against the set of valid values, there *shouldn't* be any extra significance tied to the fact that it's an enum. | 15:46 |
| sean-k-mooney | an enum field is the same a string field with the choices attibute set | 15:46 |
| gibi_off | melwitt: hi! I'm still not 100% back but I can chair the nova meeting on Thursday as normal. | 15:47 |
| *** gbarros has quit IRC | 15:48 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: API: Remove evacuate/live-migrate 'force' parameter https://review.openstack.org/634600 | 15:48 |
| sean-k-mooney | efried: it just field like casting to void*. the data in memory is still the same but how you use it just chaged. its not somting i would block it on but i would still check with jaypipes or dansmith personally | 15:48 |
| sean-k-mooney | *feels like | 15:49 |
| dansmith | sean-k-mooney: yep, agree, and since this is for something out of tree, it's not really worth doing something like that to make it work, imho | 15:49 |
| *** hongbin has joined #openstack-nova | 15:51 | |
| sean-k-mooney | dansmith: so to be clear are you +/- on changing to string and if we do change to string would you also want the field name change form driver to driver_name? | 15:51 |
| dansmith | sean-k-mooney: char *response = "meh"; int vote = -1 *(int*)(void*)response; | 15:53 |
| dansmith | hrm, my C is rusty | 15:55 |
| sean-k-mooney | i belive that woudl set vote to -1 * the address of responce. | 15:57 |
| dansmith | I meant to have another * in there, so it tried to set vote to -1 * the intlike value of meh, which would be negative something large :) | 15:58 |
| sean-k-mooney | yes i assumed that was what you were going for. poters are always fun... | 15:59 |
| sean-k-mooney | *pointers | 16:00 |
| *** gyee has joined #openstack-nova | 16:02 | |
| *** tssurya has quit IRC | 16:06 | |
| mriedem | need another stable core for this https://review.openstack.org/#/c/627011/ | 16:07 |
| mriedem | you guys are still talking about this out of tree enum thing? :) | 16:07 |
| *** TxGirlGeek has joined #openstack-nova | 16:10 | |
| *** wolverineav has joined #openstack-nova | 16:10 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Retrieve the table schema using ovsdb-client command https://review.openstack.org/634967 | 16:11 |
| sean-k-mooney | mriedem: i think we had finished but yes | 16:12 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: Check hosts have no instances for AZ rename https://review.openstack.org/509206 | 16:13 |
| sean-k-mooney | mriedem: by the way i agree with your ml post regardign changing the jobs. when i get my third party ci triggering of upstream it would be good to get your input on what you would like it to test | 16:14 |
| mriedem | ok | 16:15 |
| openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: do not set mac when unplugging macvtap vf https://review.openstack.org/624842 | 16:17 |
| openstackgerrit | sean mooney proposed openstack/nova master: Add free for claimed, allocated devices https://review.openstack.org/616120 | 16:17 |
| openstackgerrit | sean mooney proposed openstack/nova master: Allow per-port modification of vnic_type and profile https://review.openstack.org/607365 | 16:17 |
| openstackgerrit | sean mooney proposed openstack/nova master: Add get_instance_pci_request_from_vif https://review.openstack.org/619929 | 16:17 |
| openstackgerrit | sean mooney proposed openstack/nova master: SR-IOV Live migration indirect port support https://review.openstack.org/620115 | 16:17 |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589 | 16:17 |
| sean-k-mooney | i fixed the merge conflict ^ otherwise its the same | 16:18 |
| *** markvoelker has quit IRC | 16:19 | |
| *** belmoreira has quit IRC | 16:19 | |
| *** ccamacho has quit IRC | 16:19 | |
| *** ccamacho has joined #openstack-nova | 16:20 | |
| *** igordc has joined #openstack-nova | 16:22 | |
| *** panda|ko is now known as panda|off | 16:22 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Retrieve the table schema using ovsdb-client command https://review.openstack.org/634967 | 16:23 |
| *** gbarros has joined #openstack-nova | 16:25 | |
| *** wwriverrat has quit IRC | 16:27 | |
| *** pchavva has left #openstack-nova | 16:31 | |
| *** wolverineav has quit IRC | 16:33 | |
| *** ttsiouts has quit IRC | 16:33 | |
| *** ttsiouts has joined #openstack-nova | 16:33 | |
| *** openstackgerrit has quit IRC | 16:35 | |
| artom | sean-k-mooney, so, explain again why the nodeset in memoryBacking isn't necessary? If the dest compute has differently-numbered NUMA nodes, doesn't that need updating? | 16:36 |
| sean-k-mooney | it is but its is carried in the numa_mappings info already | 16:37 |
| sean-k-mooney | https://etherpad.openstack.org/p/numa_migration | 16:37 |
| *** ttsiouts has quit IRC | 16:37 | |
| *** wolverineav has joined #openstack-nova | 16:38 | |
| sean-k-mooney | i think the object i have listed in https://etherpad.openstack.org/p/numa_migration should have all the info you need? | 16:40 |
| *** ccamacho has quit IRC | 16:41 | |
| artom | sean-k-mooney, sorry, still don't get how if the source has <page size="1" unit="G" nodeset="4"/> and on the dest there is no nodeset 5 because there's only 4 NUMA nodes, how the source is supposed to update that bit of the XML | 16:42 |
| *** openstackgerrit has joined #openstack-nova | 16:43 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Retrieve the table schema using ovsdb-client command https://review.openstack.org/634967 | 16:43 |
| sean-k-mooney | simple if it recives numa_maping:{0:2, 1:3} from the dest it sets nodeset=2,3 | 16:43 |
| *** jmlowe has quit IRC | 16:44 | |
| *** ttsiouts has joined #openstack-nova | 16:44 | |
| sean-k-mooney | nodeset will be the union of of all the host numa nodes listed in numa_maping | 16:44 |
| artom | Ah, yep, that's annoyingly obvious | 16:44 |
| artom | The kernel will spread the pages across all nodes as equally as it can | 16:45 |
| sean-k-mooney | libvirt allows mixed page size for the xml but nova does not | 16:45 |
| sean-k-mooney | yes | 16:45 |
| artom | Right, I knew the size won't change | 16:45 |
| sean-k-mooney | by default | 16:45 |
| sean-k-mooney | you can allocate pages differently if you choose too | 16:45 |
| sean-k-mooney | artom: the mempage size could cange form 2M to 1G on migration if the flavor had hw:mem_page_size=large | 16:46 |
| sean-k-mooney | or at leaste we woudl be allowed to do that | 16:46 |
| artom | I feel like that should not be allowed? | 16:46 |
| sean-k-mooney | if we choose to support that is another matter | 16:46 |
| sean-k-mooney | well large state you will recive any pagezie other then the smallest available | 16:47 |
| artom | I don't think the guest would like that... | 16:47 |
| *** igordc has quit IRC | 16:47 | |
| sean-k-mooney | the guest wont be able to tell | 16:47 |
| artom | So wait, the guest will continue to see 1G pages, but they'll be backed by 2M? | 16:47 |
| sean-k-mooney | the guest does nto see 1G hugepages | 16:47 |
| sean-k-mooney | this all happens in qemu | 16:48 |
| sean-k-mooney | the guest sees virtual ram dims | 16:48 |
| dims | o/ :) | 16:48 |
| sean-k-mooney | hehe o/ | 16:48 |
| *** ttsiouts has quit IRC | 16:48 | |
| * artom puts virtual horns on dims | 16:49 | |
| dims | LOL | 16:49 |
| sean-k-mooney | artom: if the guest expcitly requested 1G pages in the flavor and the destiation cant provide that the resouce tracker will fail to claim it | 16:49 |
| sean-k-mooney | artom: but this is why i added numa_pagesize | 16:50 |
| *** igordc has joined #openstack-nova | 16:50 | |
| artom | sean-k-mooney, I'm confused because when I first set up my env for this, I gave the devstack machines 2M hugepages, but didn't configure anything on the host. With that I could boot only like, 1 VM out of 10 | 16:50 |
| sean-k-mooney | the guess will have only 1 page size for all its memory | 16:50 |
| artom | The rest hung in 'spawning' | 16:50 |
| artom | So I assumed guest and host pagesize need to match up, otherwise dragons! | 16:50 |
| sean-k-mooney | no hugepages in the guest is totally independat | 16:51 |
| artom | Which is why the idea of live-migrating a guest with 1G pages to a host that only has 2M pages (and this would get accepted because hw:numa_pagesize=large) confuses me | 16:51 |
| sean-k-mooney | you can create 1G pages in the gues and have 4k pages on the host | 16:51 |
| *** hamzy has quit IRC | 16:51 | |
| *** _alastor_ has joined #openstack-nova | 16:52 | |
| artom | And there's no performance impact? That's not been my experience... Or maybe I was doing something else wrong | 16:52 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | 16:52 |
| artom | I kinda feel we need danpb | 16:52 |
| sean-k-mooney | of corse there is a performacne impact but if you did not ask for hugepages for the vm you cannot expect to have the performace benifit | 16:52 |
| artom | In my case it appeared to be a debilitating performance impact | 16:53 |
| sean-k-mooney | the point is the guest internal memory allocation stragy is not something nova shoudl care about | 16:53 |
| *** mvkr has quit IRC | 16:53 | |
| sean-k-mooney | artom: it will perfom better then 4k pages in the geuset but it wont significatly improve performance | 16:54 |
| *** helenafm has quit IRC | 16:56 | |
| *** erlon has quit IRC | 16:57 | |
| *** agopi is now known as agopi|brb | 17:03 | |
| *** wolverineav has quit IRC | 17:05 | |
| *** wolverineav has joined #openstack-nova | 17:06 | |
| *** krasmussen has quit IRC | 17:06 | |
| *** agopi|brb has quit IRC | 17:07 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Fix legacy-grenade-dsvm-neutron-multinode-live-migration https://review.openstack.org/634962 | 17:13 |
| sean-k-mooney | artom: i updated https://etherpad.openstack.org/p/numa_migration | 17:15 |
| artom | sean-k-mooney, yep, cheers for that | 17:15 |
| artom | I've kinda deviated on trying to better understand hugepages | 17:16 |
| *** markvoelker has joined #openstack-nova | 17:16 | |
| *** ralonsoh has quit IRC | 17:17 | |
| *** maciejjozefczyk has joined #openstack-nova | 17:22 | |
| *** _hemna has quit IRC | 17:23 | |
| *** jmlowe has joined #openstack-nova | 17:26 | |
| openstackgerrit | Jack Ding proposed openstack/nova master: Correct instance port binding for rebuilds https://review.openstack.org/603844 | 17:27 |
| artom | sean-k-mooney, so next problem is, with hw:mem_page_size=large, will the scheduler and/or resource tracker claim allow migrating from a 1G host to a 2M host? | 17:28 |
| *** slaweq has quit IRC | 17:28 | |
| sean-k-mooney | it would if we used the value form the flavor directly | 17:28 |
| artom | So we need a way to prevent that... | 17:29 |
| *** wwriverrat has joined #openstack-nova | 17:30 | |
| sean-k-mooney | artom: when you do the claim here https://review.openstack.org/#/c/634606/6/nova/compute/resource_tracker.py@255 | 17:30 |
| openstackgerrit | Jack Ding proposed openstack/nova master: Flavor extra spec and image properties validation https://review.openstack.org/620706 | 17:30 |
| sean-k-mooney | we will need to pas the pageszie used on the source node | 17:30 |
| artom | sean-k-mooney, yesh, the claims aren't really set up to receive a pagesize separately | 17:31 |
| openstackgerrit | Jack Ding proposed openstack/nova master: Preserve UEFI NVRAM variable store https://review.openstack.org/621646 | 17:31 |
| *** rpittau has quit IRC | 17:31 | |
| artom | What if we just hax the flavor we pass it? ;) | 17:31 |
| sean-k-mooney | artom: well you are passing the migration so why not prepoulate the instance_host_mapping with the pagesize info in the migration | 17:31 |
| openstackgerrit | Jack Ding proposed openstack/nova master: Improve libvirt image and snapshot handling https://review.openstack.org/616692 | 17:32 |
| *** sridharg has quit IRC | 17:32 | |
| artom | sean-k-mooney, instance_host_mapping? | 17:33 |
| sean-k-mooney | the new object im suggesting here https://etherpad.openstack.org/p/numa_migration | 17:33 |
| artom | Oh, your thing from the etherpad | 17:33 |
| sean-k-mooney | ya | 17:33 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Isolate cell-targeting code in MigrationTask https://review.openstack.org/621310 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Move resize.prep.start/end notifications to helper method https://review.openstack.org/633298 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Move resize.(start|end) notification sending to helper method https://review.openstack.org/634831 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Extract compute API _create_image to compute.utils https://review.openstack.org/621311 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.openstack.org/614035 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.openstack.org/614037 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.openstack.org/627890 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832 | 17:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtSourceTask https://review.openstack.org/627891 | 17:34 |
| sean-k-mooney | so the idea is that object is going to be passed back form the dest to source | 17:34 |
| artom | sean-k-mooney, yeah, no I'm before that | 17:34 |
| artom | When picking a host | 17:34 |
| artom | We need to pick a host with the same pagesize as the source | 17:34 |
| sean-k-mooney | but there is no reason it cant be passed form the source to dest | 17:34 |
| sean-k-mooney | artom: the numa toplogy filter could also maybe look at the instance_numa_toplogy bolb and see if we recored the pagesize | 17:35 |
| sean-k-mooney | if we do then it can pretent that page size was requested explcitly if hw:mem_page_size=large | 17:35 |
| artom | The flavor is embedded in the instance now, right? | 17:36 |
| *** tbachman has quit IRC | 17:36 | |
| artom | I kinda feel like we should straight up overwrite hw:mem_page_size after the instance boots | 17:36 |
| *** maciejjozefczyk has quit IRC | 17:36 | |
| artom | Just as a separate thing | 17:36 |
| sean-k-mooney | yes | 17:36 |
| *** jmlowe has quit IRC | 17:36 | |
| artom | I'll propose that and it'll solve all evarything | 17:37 |
| artom | Maybe lunch first tho | 17:37 |
| *** igordc has quit IRC | 17:38 | |
| sean-k-mooney | updating the embed flavor could work but today we dont know the pagesize untill we hit the compute node | 17:38 |
| sean-k-mooney | so it would have to be updated there | 17:39 |
| artom | Don't see why it can't be done, objects are remotable for precisely this kind of thing | 17:39 |
| *** igordc has joined #openstack-nova | 17:40 | |
| stephenfin | why is 1GB -> 2MB a bad thing? | 17:40 |
| sean-k-mooney | artom: well im more thingink we shoudl not update it unless the instance actully boots so that retry dont break | 17:40 |
| stephenfin | If they want 1GB, they can specifically request it, no? | 17:40 |
| sean-k-mooney | stephenfin: they can | 17:40 |
| artom | sean-k-mooney, yeah, it'd be way at the end of the boot code path | 17:41 |
| stephenfin | So they don't care and want just "huge pages", so give em whatever is available? | 17:41 |
| artom | I'll take a closer look to find the best place/way | 17:41 |
| sean-k-mooney | stephenfin: apparently while on x86 cahnging pagesize even form 4k is fine | 17:41 |
| sean-k-mooney | stephenfin: on arm or other achiteture its not supported | 17:41 |
| stephenfin | You mean via QEMU? | 17:41 |
| sean-k-mooney | yes | 17:41 |
| artom | stephenfin, and it'll prevent post-copy live migration | 17:41 |
| stephenfin | artom: how so? | 17:41 |
| sean-k-mooney | that too on x86 | 17:41 |
| artom | See our downstream IRC chat with danpb | 17:41 |
| * stephenfin looks | 17:42 | |
| *** tbachman has joined #openstack-nova | 17:42 | |
| artom | stephenfin, excellent question ask Dan! ;) | 17:42 |
| sean-k-mooney | stephenfin: we could chagne it in the futre we are just suggeting skipping it for now to keep tings simple | 17:42 |
| artom | Yep, I'd rather keep things simple for now | 17:42 |
| stephenfin | change what now? | 17:42 |
| stephenfin | oh, allow changing from 2M to 1G and vice versa | 17:43 |
| stephenfin | Yeah, I wasn't suggesting we'd want to allow that for any reason other than to make it easier | 17:43 |
| stephenfin | So if it turns out to be harder, nvm. YAGNI | 17:43 |
| sean-k-mooney | stephenfin: well i would personally have defaulted to allowing it but if it has edgaces the lets not and maybe reasses if it chagnes | 17:44 |
| artom | Oh, you aren't going to need it | 17:44 |
| sean-k-mooney | stephenfin: i have personally seen a vm migrated for kernel vhost with 4k pages to ovs-dpdk with 2mb hugepages to hardware offlaoded ovs with 1G pages all via qemu | 17:45 |
| * artom was trying very hard with "Yet Another... Gruesomely Necessary Intervention" | 17:45 | |
| *** derekh has quit IRC | 17:45 | |
| sean-k-mooney | so qemu can do it but its to complex for what we need for numa migrations at least in v1 | 17:46 |
| openstackgerrit | Merged openstack/nova master: Duplicate os-vif datapath offload metadata https://review.openstack.org/634218 | 17:47 |
| *** markvoelker has quit IRC | 17:48 | |
| dansmith | mriedem: I'm trying to power through this cells-down api patch | 17:51 |
| dansmith | mriedem: I assume you realize this could be broken down into smaller patches but just figure it's not worth it? | 17:51 |
| dansmith | the pop-all-tenants-unless-cell-down-support-then-pop-it-elsewhere thing has me thinking there's probably a lot that is easy to miss in here | 17:51 |
| *** jmlowe has joined #openstack-nova | 17:57 | |
| sean-k-mooney | quick dumb question. there are several image metadata keys listed in https://github.com/openstack/nova/blob/f7252b586b4b9f5a098fedfa27715b8f7e662af6/nova/notifications/objects/image.py#L187-L254 that are not document in teh glance metadefs. i should file the bug for fixing that agaisn glance right. do i need to also add nova to the bug or is glance enought | 17:58 |
| artom | sean-k-mooney, isn't glance metadata freeform? | 17:59 |
| artom | Ie, set any key:value you want? | 17:59 |
| sean-k-mooney | there is a registry where all valide key:values are ment to be listed | 17:59 |
| sean-k-mooney | https://github.com/openstack/glance/tree/master/etc/metadefs | 17:59 |
| sean-k-mooney | it also define the flavor and volume metadata keys and how the relate | 18:00 |
| sean-k-mooney | e.g. hw:mem_page_size in flavor is the same as hw_mem_page_size in image | 18:00 |
| sean-k-mooney | horizon uses that to generate its ui for setting the metadata | 18:00 |
| artom | sean-k-mooney, huh, OK, cuz I was looking at the image api-ref not long ago and got the impression you can set pretty much anything you want | 18:01 |
| artom | Yeah: https://developer.openstack.org/api-ref/image/v2/index.html?expanded=create-image-detail#images | 18:01 |
| artom | "Additionally, you may include additional properties specified as key:value pairs, where the value must be a string data type. Keys are limited to 255 chars in length. Available key names may be limited by the cloud’s property protection configuration." | 18:01 |
| artom | Obviously not everything has a meaning | 18:02 |
| artom | But you could create/update an image with kitty:yesplease if you wanted | 18:02 |
| sean-k-mooney | artom: you can but it like os traits | 18:02 |
| sean-k-mooney | for "standard" keys with defiend values you are not ment to extend them | 18:03 |
| artom | Aha | 18:03 |
| *** dims has quit IRC | 18:06 | |
| openstackgerrit | Merged openstack/nova stable/pike: Ensure rbd auth fallback uses matching credentials https://review.openstack.org/627011 | 18:09 |
| *** ociuhandu has quit IRC | 18:11 | |
| *** sdake has quit IRC | 18:11 | |
| *** hamzy has joined #openstack-nova | 18:12 | |
| *** ociuhandu has joined #openstack-nova | 18:13 | |
| *** agopi has joined #openstack-nova | 18:13 | |
| *** ociuhandu has quit IRC | 18:17 | |
| *** gbarros has quit IRC | 18:18 | |
| *** dpawlik has joined #openstack-nova | 18:23 | |
| *** dims has joined #openstack-nova | 18:26 | |
| *** gbarros has joined #openstack-nova | 18:29 | |
| *** Nel1x has quit IRC | 18:29 | |
| *** _hemna has joined #openstack-nova | 18:33 | |
| artom | sean-k-mooney, I just realized overwriting the page size in the embedded flavor has consequences on cold migration | 18:41 |
| artom | (Among other things, I image) | 18:41 |
| artom | So previously you'd be able to cold migrate to a different host with a different page size (as long it was still `large`) | 18:42 |
| artom | If we overwrite, a rebuild will be required | 18:42 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: ironic: partition compute services by conductor group https://review.openstack.org/635006 | 18:43 |
| *** ccamacho has joined #openstack-nova | 18:44 | |
| *** markvoelker has joined #openstack-nova | 18:46 | |
| *** moshele has joined #openstack-nova | 18:49 | |
| *** itlinux has joined #openstack-nova | 18:49 | |
| *** sdake has joined #openstack-nova | 18:53 | |
| sean-k-mooney | artom: right which is why it should proably be passed in the migration object | 18:54 |
| mriedem | dansmith: yeah i noticed a few things that could be split out | 18:55 |
| mriedem | and yeah the all_tenants stuff worries me a bit | 18:55 |
| mriedem | since all_tenants is just a confusing mess generally to begin with | 18:55 |
| *** macza has joined #openstack-nova | 18:55 | |
| *** Swami has joined #openstack-nova | 18:55 | |
| dansmith | yeah | 18:56 |
| mriedem | i haven't been back to it since my last deluge | 18:56 |
| dansmith | okay she changed a bunch of stuff and uploaded this morning, modulo one noted issue | 18:56 |
| sean-k-mooney | as i said in the ether pad/before there is no reason the new object that carries the numa mapping form the dst to the source cant be used to carry info form teh souce to dest. we are modifying the migration object to hold the new object anyway so might as well use it of the page size too | 18:57 |
| sean-k-mooney | artom: ^ assumeing we cant just get teh value for the instance_numa_toplogy object and use that in the numa topology filter already | 18:57 |
| sean-k-mooney | anyway im going to cook dinner ill be back in an hour or two | 18:58 |
| artom | sean-k-mooney, bon appetit | 18:58 |
| mriedem | dansmith: i also didn't check to see if there was a functional test that stresses the all_tenants stuff with a down cell | 18:58 |
| *** moshele has quit IRC | 18:58 | |
| mriedem | but that'd be good | 18:59 |
| mriedem | create a server in cell A with project A, create a server in cell B with project B, take down cell B and then list servers for all tenants | 18:59 |
| artom | And actually it may be what's happening already in NUMATopologyFilter | 18:59 |
| *** wolverineav has quit IRC | 19:00 | |
| *** wolverineav has joined #openstack-nova | 19:02 | |
| *** moshele has joined #openstack-nova | 19:03 | |
| *** artom has quit IRC | 19:04 | |
| *** wolverineav has quit IRC | 19:07 | |
| *** dims has quit IRC | 19:16 | |
| *** markvoelker has quit IRC | 19:19 | |
| *** wolverineav has joined #openstack-nova | 19:20 | |
| *** artom has joined #openstack-nova | 19:20 | |
| *** dims has joined #openstack-nova | 19:25 | |
| *** pcaruana has quit IRC | 19:27 | |
| *** erlon has joined #openstack-nova | 19:29 | |
| *** ociuhandu has joined #openstack-nova | 19:30 | |
| *** ociuhandu has quit IRC | 19:35 | |
| *** tbachman has quit IRC | 19:38 | |
| *** erlon has quit IRC | 19:54 | |
| *** wolverineav has quit IRC | 19:55 | |
| *** ociuhandu has joined #openstack-nova | 19:59 | |
| *** tbachman has joined #openstack-nova | 19:59 | |
| *** gbarros has quit IRC | 20:06 | |
| *** mvkr has joined #openstack-nova | 20:09 | |
| *** efried1 has joined #openstack-nova | 20:09 | |
| *** efried has quit IRC | 20:10 | |
| *** gbarros has joined #openstack-nova | 20:11 | |
| *** efried1 is now known as efried | 20:11 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: ironic: partition compute services by conductor group https://review.openstack.org/635006 | 20:15 |
| *** markvoelker has joined #openstack-nova | 20:16 | |
| *** gbarros has quit IRC | 20:17 | |
| *** moshele has quit IRC | 20:23 | |
| sean-k-mooney | stephenfin: mriedem care to +w https://review.openstack.org/#/c/626381/ ? | 20:26 |
| *** wolverineav has joined #openstack-nova | 20:26 | |
| *** jmlowe has quit IRC | 20:29 | |
| *** wolverineav has quit IRC | 20:32 | |
| mriedem | done | 20:34 |
| mriedem | sean-k-mooney: are you going to work on backports? | 20:34 |
| sean-k-mooney | for which patch | 20:34 |
| mriedem | https://review.openstack.org/#/c/626381/ | 20:34 |
| sean-k-mooney | sure i can back port that | 20:35 |
| sean-k-mooney | am are there upstream backports for https://review.openstack.org/#/c/614167/20 | 20:35 |
| sean-k-mooney | i will start backporting that and https://review.openstack.org/#/c/591607/25 too if not | 20:36 |
| *** tbachman has quit IRC | 20:36 | |
| sean-k-mooney | haveing said that you mentioned that backporting https://review.openstack.org/#/q/topic:bug/1751923+(status:open+OR+status:merged) was contovertioal? | 20:37 |
| *** igordc has quit IRC | 20:41 | |
| mriedem | i would personally prefer to let ^ simmer a bit before we go backport crazy on it | 20:45 |
| mriedem | because it's very non-trivial | 20:45 |
| mriedem | is a data migration and a change in behavior in how that periodic works in the compute service | 20:45 |
| sean-k-mooney | ok ill leave it a couple of weeks and see if anything happens | 20:45 |
| sean-k-mooney | actully ya downstream we tend not to backport data migrations | 20:46 |
| sean-k-mooney | ill have to think how feasible it is. ill backport my own patch then in the interim | 20:47 |
| *** markvoelker has quit IRC | 20:48 | |
| *** wolverineav has joined #openstack-nova | 20:54 | |
| *** priteau has joined #openstack-nova | 20:55 | |
| *** priteau has quit IRC | 21:12 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293 | 21:13 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.openstack.org/627890 | 21:13 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832 | 21:13 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.openstack.org/627891 | 21:13 |
| *** priteau has joined #openstack-nova | 21:14 | |
| *** xek__ has quit IRC | 21:20 | |
| *** tbachman has joined #openstack-nova | 21:24 | |
| *** itlinux has quit IRC | 21:29 | |
| *** awaugama has quit IRC | 21:30 | |
| *** wolverineav has quit IRC | 21:31 | |
| *** wolverineav has joined #openstack-nova | 21:33 | |
| *** igordc has joined #openstack-nova | 21:33 | |
| mriedem | dansmith: i left some ideas on how to split up the down cell patch | 21:34 |
| mriedem | https://www.youtube.com/watch?v=urhJ81E-Bog | 21:35 |
| dansmith | mriedem: okay, honestly I dunno how much I should harp on it, it's just.. really big | 21:35 |
| *** moshele has joined #openstack-nova | 21:35 | |
| mriedem | https://review.openstack.org/#/q/topic:bp/cross-cell-resize+(status:open+OR+status:merged) i'm obviously cool with splitting things up... | 21:36 |
| dansmith | mriedem: you should bug me to look at some of those tomorrow | 21:37 |
| mriedem | the first three are easy | 21:37 |
| mriedem | i've got a -2 toward the bottom | 21:37 |
| dansmith | mriedem: you should bug me to look at three of those tomorrow | 21:37 |
| mriedem | ok | 21:38 |
| *** wolverineav has quit IRC | 21:38 | |
| *** _hemna has quit IRC | 21:39 | |
| *** cdent has quit IRC | 21:39 | |
| *** sdake has quit IRC | 21:39 | |
| *** moshele has quit IRC | 21:43 | |
| *** wolverineav has joined #openstack-nova | 21:46 | |
| *** markvoelker has joined #openstack-nova | 21:46 | |
| *** hamzy has quit IRC | 21:46 | |
| *** mchlumsky has quit IRC | 21:52 | |
| *** _fragatina has joined #openstack-nova | 22:06 | |
| *** _fragatina_ has joined #openstack-nova | 22:07 | |
| *** _fragatina has quit IRC | 22:10 | |
| *** gbarros has joined #openstack-nova | 22:17 | |
| *** dpawlik has quit IRC | 22:19 | |
| *** markvoelker has quit IRC | 22:20 | |
| *** sdake has joined #openstack-nova | 22:28 | |
| *** gbarros has quit IRC | 22:33 | |
| *** sdake has quit IRC | 22:34 | |
| *** sdake has joined #openstack-nova | 22:36 | |
| *** _fragatina_ has quit IRC | 22:43 | |
| *** tesseract has quit IRC | 22:52 | |
| *** priteau has quit IRC | 22:52 | |
| *** tkajinam has joined #openstack-nova | 22:55 | |
| *** gbarros has joined #openstack-nova | 23:03 | |
| *** erlon has joined #openstack-nova | 23:03 | |
| *** wolverineav has quit IRC | 23:09 | |
| *** wolverineav has joined #openstack-nova | 23:09 | |
| *** erlon has quit IRC | 23:10 | |
| *** agopi is now known as agopi|off | 23:13 | |
| *** wolverineav has quit IRC | 23:13 | |
| *** markvoelker has joined #openstack-nova | 23:16 | |
| *** agopi|off has quit IRC | 23:17 | |
| openstackgerrit | Merged openstack/nova master: PCI: do not force remove allocated devices https://review.openstack.org/626381 | 23:17 |
| *** hongbin has quit IRC | 23:18 | |
| *** BjoernT_ has quit IRC | 23:21 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: do not set mac when unplugging macvtap vf https://review.openstack.org/624842 | 23:27 |
| openstackgerrit | sean mooney proposed openstack/nova master: Add free for claimed, allocated devices https://review.openstack.org/616120 | 23:27 |
| openstackgerrit | sean mooney proposed openstack/nova master: Allow per-port modification of vnic_type and profile https://review.openstack.org/607365 | 23:27 |
| openstackgerrit | sean mooney proposed openstack/nova master: Add get_instance_pci_request_from_vif https://review.openstack.org/619929 | 23:27 |
| openstackgerrit | sean mooney proposed openstack/nova master: SR-IOV Live migration indirect port support https://review.openstack.org/620115 | 23:27 |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589 | 23:27 |
| openstackgerrit | sean mooney proposed openstack/nova stable/rocky: PCI: do not force remove allocated devices https://review.openstack.org/635071 | 23:29 |
| openstackgerrit | sean mooney proposed openstack/nova stable/queens: PCI: do not force remove allocated devices https://review.openstack.org/635072 | 23:29 |
| *** wolverineav has joined #openstack-nova | 23:33 | |
| openstackgerrit | sean mooney proposed openstack/nova stable/pike: PCI: do not force remove allocated devices https://review.openstack.org/635074 | 23:38 |
| openstackgerrit | sean mooney proposed openstack/nova stable/ocata: PCI: do not force remove allocated devices https://review.openstack.org/635075 | 23:38 |
| *** eharney has quit IRC | 23:43 | |
| *** imacdonn has quit IRC | 23:48 | |
| *** imacdonn has joined #openstack-nova | 23:49 | |
| *** markvoelker has quit IRC | 23:50 | |
| *** agopi|off has joined #openstack-nova | 23:55 | |
| *** gbarros has quit IRC | 23:58 | |
| *** gbarros has joined #openstack-nova | 23:58 | |
| *** gbarros has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!