| *** sdake has quit IRC | 00:01 | |
| *** wolverineav has joined #openstack-nova | 00:02 | |
| *** elod has quit IRC | 00:05 | |
| *** wolverineav has quit IRC | 00:06 | |
| *** takashin has joined #openstack-nova | 00:07 | |
| *** tbachman has joined #openstack-nova | 00:10 | |
| *** markvoelker has quit IRC | 00:11 | |
| *** wolverineav has joined #openstack-nova | 00:19 | |
| *** tetsuro has joined #openstack-nova | 00:20 | |
| *** elod has joined #openstack-nova | 00:32 | |
| *** wolverineav has quit IRC | 00:33 | |
| *** wolverineav has joined #openstack-nova | 00:34 | |
| *** wolverineav has quit IRC | 00:39 | |
| *** sapd1 has joined #openstack-nova | 00:43 | |
| *** wolverineav has joined #openstack-nova | 00:44 | |
| *** sdake has joined #openstack-nova | 00:45 | |
| *** ade_lee_ has joined #openstack-nova | 00:46 | |
| *** ileixe has joined #openstack-nova | 00:48 | |
| openstackgerrit | Adam Spiers proposed openstack/os-traits master: Add HW_CPU_AMD_SEV trait https://review.openstack.org/635608 | 00:49 |
|---|---|---|
| *** mriedem_afk has quit IRC | 00:49 | |
| *** ade_lee_ has quit IRC | 00:53 | |
| *** ade_lee_ has joined #openstack-nova | 00:53 | |
| *** agopi|pto has joined #openstack-nova | 01:01 | |
| *** sdake has quit IRC | 01:06 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Transfer port.resource_request to the scheduler https://review.openstack.org/567268 | 01:07 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Extend RequestGroup object for mapping https://review.openstack.org/619527 | 01:07 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239 | 01:07 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528 | 01:07 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass resource provider mapping to neutronv2 api https://review.openstack.org/616240 | 01:07 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule https://review.openstack.org/619529 | 01:07 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Send RP uuid in the port binding https://review.openstack.org/569459 | 01:07 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317 | 01:07 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 01:07 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 01:07 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 01:07 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 01:07 |
| *** markvoelker has joined #openstack-nova | 01:09 | |
| *** wolverineav has quit IRC | 01:13 | |
| *** wolverineav has joined #openstack-nova | 01:14 | |
| *** agopi|pto has quit IRC | 01:14 | |
| *** agopi|pto has joined #openstack-nova | 01:14 | |
| *** agopi|pto has quit IRC | 01:16 | |
| *** agopi|pto has joined #openstack-nova | 01:16 | |
| *** bhagyashris has joined #openstack-nova | 01:16 | |
| *** agopi|pto has quit IRC | 01:17 | |
| *** agopi|pto has joined #openstack-nova | 01:17 | |
| *** wolverineav has quit IRC | 01:19 | |
| *** tbachman has quit IRC | 01:25 | |
| *** BjoernT has joined #openstack-nova | 01:30 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Execute CrossCellMigrationTask from MigrationTask https://review.openstack.org/635668 | 01:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Plumb allow_cross_cell_resize into compute API resize() https://review.openstack.org/635684 | 01:39 |
| *** BjoernT_ has joined #openstack-nova | 01:40 | |
| *** markvoelker has quit IRC | 01:41 | |
| *** BjoernT has quit IRC | 01:43 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:43 | |
| *** wolverineav has joined #openstack-nova | 01:44 | |
| *** mlavalle has quit IRC | 01:46 | |
| *** mriedem has joined #openstack-nova | 01:46 | |
| mriedem | takashin: stephenfin: oops https://bugs.launchpad.net/nova/+bug/1815153 | 01:47 |
| openstack | Launchpad bug 1815153 in OpenStack Compute (nova) "Requested host during cold migrate is ignored if server created before Rocky" [High,Triaged] | 01:47 |
| *** agopi|pto has quit IRC | 01:49 | |
| *** agopi|pto has joined #openstack-nova | 01:49 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Add migration param to check_can_live_migrate_destination https://review.openstack.org/634605 | 01:49 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Introduce live_migration_claim() https://review.openstack.org/635669 | 01:49 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Use live_migration_claim() to check dest resources https://review.openstack.org/634606 | 01:49 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | 01:49 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] LM: generate new NUMA XML on the dest and send it to the source https://review.openstack.org/634828 | 01:49 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] LM: update NUMA-related XML on the source https://review.openstack.org/635229 | 01:49 |
| *** agopi|pto has quit IRC | 01:56 | |
| *** agopi|pto has joined #openstack-nova | 01:56 | |
| *** wolverineav has quit IRC | 01:57 | |
| *** wolverineav has joined #openstack-nova | 01:57 | |
| *** agopi|pto has quit IRC | 01:58 | |
| *** agopi|pto has joined #openstack-nova | 01:58 | |
| *** wolverineav has quit IRC | 02:02 | |
| *** sdake has joined #openstack-nova | 02:06 | |
| *** cfriesen has quit IRC | 02:07 | |
| *** sdake has quit IRC | 02:13 | |
| *** mriedem has quit IRC | 02:14 | |
| *** markvoelker has joined #openstack-nova | 02:38 | |
| *** psachin has joined #openstack-nova | 02:51 | |
| *** udesale has joined #openstack-nova | 03:11 | |
| *** markvoelker has quit IRC | 03:12 | |
| *** dave-mccowan has joined #openstack-nova | 03:13 | |
| *** chhagarw has joined #openstack-nova | 03:19 | |
| *** takashin has left #openstack-nova | 03:25 | |
| *** sapd1 has quit IRC | 03:32 | |
| openstackgerrit | Merged openstack/python-novaclient master: Remove deprecated novaclient.v2.contrib modules https://review.openstack.org/635430 | 03:37 |
| *** sapd1 has joined #openstack-nova | 03:45 | |
| openstackgerrit | Jack Ding proposed openstack/nova master: Correct instance port binding for rebuilds https://review.openstack.org/603844 | 04:00 |
| *** tetsuro has quit IRC | 04:07 | |
| *** markvoelker has joined #openstack-nova | 04:09 | |
| *** tbachman has joined #openstack-nova | 04:11 | |
| *** tetsuro has joined #openstack-nova | 04:12 | |
| *** BjoernT has joined #openstack-nova | 04:13 | |
| *** BjoernT_ has quit IRC | 04:16 | |
| *** whoami-rajat has joined #openstack-nova | 04:24 | |
| *** lbragstad has quit IRC | 04:35 | |
| *** markvoelker has quit IRC | 04:41 | |
| *** tbachman has quit IRC | 04:42 | |
| *** sapd1 has quit IRC | 05:05 | |
| *** dave-mccowan has quit IRC | 05:08 | |
| openstackgerrit | Merged openstack/nova stable/ocata: Default embedded instance.flavor.is_public attribute https://review.openstack.org/619366 | 05:09 |
| *** BjoernT has quit IRC | 05:10 | |
| *** ratailor has joined #openstack-nova | 05:18 | |
| *** gyee has quit IRC | 05:36 | |
| *** markvoelker has joined #openstack-nova | 05:38 | |
| openstackgerrit | Merged openstack/nova master: Fix deprecation warning for threadgroup.add_timer https://review.openstack.org/635516 | 05:41 |
| *** raghav has joined #openstack-nova | 06:01 | |
| *** janki has joined #openstack-nova | 06:05 | |
| *** tetsuro has quit IRC | 06:07 | |
| *** markvoelker has quit IRC | 06:12 | |
| *** mdbooth_ has joined #openstack-nova | 06:18 | |
| *** mdbooth has quit IRC | 06:20 | |
| *** moshele has joined #openstack-nova | 06:34 | |
| *** moshele has quit IRC | 06:46 | |
| *** tetsuro has joined #openstack-nova | 06:50 | |
| *** Dinesh_Bhor has quit IRC | 06:57 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:03 | |
| *** Luzi has joined #openstack-nova | 07:08 | |
| *** markvoelker has joined #openstack-nova | 07:09 | |
| *** sridharg has joined #openstack-nova | 07:12 | |
| *** remi_ness has joined #openstack-nova | 07:15 | |
| *** wolverineav has joined #openstack-nova | 07:22 | |
| *** pcaruana has joined #openstack-nova | 07:23 | |
| *** wolverineav has quit IRC | 07:28 | |
| *** wolverineav has joined #openstack-nova | 07:29 | |
| *** markvoelker has quit IRC | 07:41 | |
| *** ccamacho has joined #openstack-nova | 08:00 | |
| *** takamatsu has joined #openstack-nova | 08:00 | |
| *** alex_xu has joined #openstack-nova | 08:05 | |
| *** awalende has joined #openstack-nova | 08:09 | |
| *** yan0s has joined #openstack-nova | 08:13 | |
| *** tkajinam has quit IRC | 08:14 | |
| *** tesseract has joined #openstack-nova | 08:18 | |
| *** markvoelker has joined #openstack-nova | 08:38 | |
| *** _fragatina has joined #openstack-nova | 08:40 | |
| *** xek has joined #openstack-nova | 08:45 | |
| *** yan0s has quit IRC | 08:51 | |
| *** rpittau has joined #openstack-nova | 08:56 | |
| *** ociuhandu has joined #openstack-nova | 09:07 | |
| *** panda|off is now known as panda | 09:08 | |
| *** markvoelker has quit IRC | 09:12 | |
| *** whoami-rajat has quit IRC | 09:14 | |
| *** yan0s has joined #openstack-nova | 09:17 | |
| *** mcgiggler has joined #openstack-nova | 09:18 | |
| *** tssurya has joined #openstack-nova | 09:25 | |
| *** tetsuro has quit IRC | 09:27 | |
| *** whoami-rajat has joined #openstack-nova | 09:28 | |
| *** derekh has joined #openstack-nova | 09:36 | |
| bauzas | good Friday nova | 09:39 |
| *** bauzas is now known as bauwser | 09:39 | |
| bauwser | (heh, that's maybe 3 months I didn't used my Friday suit :) ) | 09:40 |
| *** dtantsur|afk is now known as dtantsur | 09:40 | |
| *** slaweq has joined #openstack-nova | 09:42 | |
| *** bhagyashris has quit IRC | 09:47 | |
| *** david-lyle has joined #openstack-nova | 09:54 | |
| *** manjeets_ has joined #openstack-nova | 09:55 | |
| *** dklyle has quit IRC | 09:57 | |
| *** manjeets has quit IRC | 09:57 | |
| *** remi_ness has quit IRC | 10:07 | |
| *** markvoelker has joined #openstack-nova | 10:10 | |
| *** ociuhandu has quit IRC | 10:10 | |
| *** tssurya has quit IRC | 10:15 | |
| *** Dinesh_Bhor has quit IRC | 10:21 | |
| *** ociuhandu has joined #openstack-nova | 10:30 | |
| *** ociuhandu has quit IRC | 10:31 | |
| *** ociuhandu has joined #openstack-nova | 10:31 | |
| *** markvoelker has quit IRC | 10:42 | |
| *** ratailor has quit IRC | 10:58 | |
| *** tbachman has joined #openstack-nova | 11:04 | |
| *** udesale has quit IRC | 11:10 | |
| *** udesale has joined #openstack-nova | 11:10 | |
| *** erlon has joined #openstack-nova | 11:11 | |
| *** moshele has joined #openstack-nova | 11:15 | |
| *** takamatsu_ has joined #openstack-nova | 11:20 | |
| *** ileixe has quit IRC | 11:20 | |
| *** takamatsu has quit IRC | 11:20 | |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: Check hosts have no instances for AZ rename https://review.openstack.org/509206 | 11:21 |
| stephenfin | bauwser: Whoops | 11:27 |
| *** stephenfin is now known as finucannot | 11:27 | |
| *** tssurya has joined #openstack-nova | 11:29 | |
| *** moshele has quit IRC | 11:31 | |
| *** moshele has joined #openstack-nova | 11:34 | |
| *** sdake has joined #openstack-nova | 11:34 | |
| *** markvoelker has joined #openstack-nova | 11:39 | |
| *** dikonoor__ has joined #openstack-nova | 11:40 | |
| *** dikonoor__ has quit IRC | 11:40 | |
| *** sdake has quit IRC | 11:41 | |
| *** tbachman has quit IRC | 11:45 | |
| *** sdake has joined #openstack-nova | 11:45 | |
| *** dikonoor has joined #openstack-nova | 11:50 | |
| *** moshele has quit IRC | 11:54 | |
| *** dikonoor has quit IRC | 11:56 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: API: Remove evacuate/live-migrate 'force' parameter https://review.openstack.org/634600 | 11:58 |
| *** dikonoor has joined #openstack-nova | 12:04 | |
| *** mcgiggler has quit IRC | 12:11 | |
| *** sdake has quit IRC | 12:11 | |
| *** wolverineav has quit IRC | 12:11 | |
| *** cdent has joined #openstack-nova | 12:11 | |
| *** markvoelker has quit IRC | 12:12 | |
| *** sdake has joined #openstack-nova | 12:12 | |
| *** slaweq has quit IRC | 12:15 | |
| *** slaweq has joined #openstack-nova | 12:18 | |
| openstackgerrit | Merged openstack/nova master: Transfer port.resource_request to the scheduler https://review.openstack.org/567268 | 12:22 |
| *** whoami-rajat has quit IRC | 12:24 | |
| *** ratailor has joined #openstack-nova | 12:25 | |
| openstackgerrit | Merged openstack/nova-specs master: AMD SEV: address final feedback received prior to merge https://review.openstack.org/628252 | 12:25 |
| *** raghav has quit IRC | 12:27 | |
| *** _fragatina has quit IRC | 12:31 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Avoid redundant initialize_connection on source post live migration https://review.openstack.org/551302 | 12:42 |
| *** whoami-rajat has joined #openstack-nova | 12:44 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Plumbing required in servers ViewBuilder to construct partial results https://review.openstack.org/635146 | 12:46 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells https://review.openstack.org/591657 | 12:46 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells Documentation https://review.openstack.org/635147 | 12:46 |
| *** sdake has quit IRC | 12:48 | |
| *** _fragatina has joined #openstack-nova | 12:55 | |
| *** sridharg has quit IRC | 12:55 | |
| openstackgerrit | Merged openstack/os-traits master: Add HW_CPU_AMD_SEV trait https://review.openstack.org/635608 | 12:56 |
| *** Shilpa has quit IRC | 12:57 | |
| *** mcgiggler has joined #openstack-nova | 12:58 | |
| *** agopi|pto has quit IRC | 13:00 | |
| *** ratailor has quit IRC | 13:01 | |
| *** psachin has quit IRC | 13:03 | |
| *** mrjk has quit IRC | 13:08 | |
| *** tbachman has joined #openstack-nova | 13:08 | |
| *** pelement has left #openstack-nova | 13:08 | |
| *** markvoelker has joined #openstack-nova | 13:09 | |
| *** mrjk has joined #openstack-nova | 13:10 | |
| *** sridharg has joined #openstack-nova | 13:12 | |
| *** eharney has joined #openstack-nova | 13:15 | |
| *** tesseract has quit IRC | 13:15 | |
| *** tesseract has joined #openstack-nova | 13:16 | |
| *** gary_perkins has quit IRC | 13:18 | |
| *** obre has quit IRC | 13:18 | |
| *** obre has joined #openstack-nova | 13:18 | |
| *** gary_perkins has joined #openstack-nova | 13:19 | |
| *** cdent has quit IRC | 13:23 | |
| *** lpetrut has joined #openstack-nova | 13:29 | |
| *** moshele has joined #openstack-nova | 13:31 | |
| *** mriedem has joined #openstack-nova | 13:31 | |
| *** _fragatina has quit IRC | 13:35 | |
| *** eharney has quit IRC | 13:38 | |
| *** rpittau has quit IRC | 13:40 | |
| *** rpittau has joined #openstack-nova | 13:40 | |
| *** markvoelker has quit IRC | 13:42 | |
| *** eharney has joined #openstack-nova | 13:43 | |
| *** moshele has quit IRC | 13:43 | |
| *** cdent has joined #openstack-nova | 13:46 | |
| mriedem | tssurya: i think we're just missing a unit test on https://review.openstack.org/#/c/635121/ and then i'd be +2 | 14:00 |
| *** sridharg has quit IRC | 14:03 | |
| tssurya | mriedem: on it thanks | 14:04 |
| *** mrch_ has quit IRC | 14:04 | |
| mriedem | dansmith: another good example of how brittle everything is https://bugs.launchpad.net/nova/+bug/1815153 | 14:08 |
| openstack | Launchpad bug 1815153 in OpenStack Compute (nova) "Requested host during cold migrate is ignored if server created before Rocky" [High,In progress] - Assigned to Takashi NATSUME (natsume-takashi) | 14:08 |
| mriedem | tssurya: if you're respinning i had some nits in https://review.openstack.org/#/c/635145/ as well | 14:09 |
| tssurya | mriedem: yea saw them, I'll fix them too | 14:09 |
| *** _fragatina has joined #openstack-nova | 14:10 | |
| *** BjoernT has joined #openstack-nova | 14:12 | |
| bauwser | mriedem: thanks for the detailed bug report on https://bugs.launchpad.net/nova/+bug/1815153 | 14:16 |
| openstack | Launchpad bug 1815153 in OpenStack Compute (nova) "Requested host during cold migrate is ignored if server created before Rocky" [High,In progress] - Assigned to Takashi NATSUME (natsume-takashi) | 14:16 |
| bauwser | mriedem: tbc, requested_destination wasn't intended to be persisted | 14:17 |
| *** sridharg has joined #openstack-nova | 14:21 | |
| *** BjoernT has quit IRC | 14:22 | |
| *** erlon has quit IRC | 14:23 | |
| *** awalende has quit IRC | 14:24 | |
| *** TheJulia is now known as needssleep | 14:25 | |
| *** awalende has joined #openstack-nova | 14:25 | |
| dansmith | mriedem: just in general? | 14:26 |
| mriedem | just another example of how i feel that everything i touch breaks something else somewhere | 14:26 |
| dansmith | ah yep | 14:26 |
| mriedem | bauwser: sure, we fixed that, | 14:26 |
| mriedem | and in doing so broke something else inadvertently later | 14:26 |
| *** cfriesen has joined #openstack-nova | 14:28 | |
| *** dave-mccowan has joined #openstack-nova | 14:29 | |
| *** awalende has quit IRC | 14:29 | |
| *** lbragstad has joined #openstack-nova | 14:31 | |
| bauwser | mriedem: ergh ok | 14:32 |
| *** efried is now known as fried_rice | 14:35 | |
| mriedem | i'm also not sure why, | 14:37 |
| mriedem | because of https://github.com/openstack/nova/blob/a6963fa6858289d048e4d27ce8e61637cd023f4c/nova/compute/api.py#L3329 | 14:37 |
| *** dtantsur is now known as creepy_owlet | 14:37 | |
| mriedem | we should blow up here https://github.com/openstack/nova/blob/a6963fa6858289d048e4d27ce8e61637cd023f4c/nova/conductor/manager.py#L1009 with an old request spec | 14:38 |
| mriedem | but i modified a functional test that hits that code and it doesn't blow pu | 14:38 |
| mriedem | *up | 14:38 |
| *** sdake has joined #openstack-nova | 14:38 | |
| mriedem | oh i see why | 14:38 |
| mriedem | https://github.com/openstack/nova/blob/a6963fa6858289d048e4d27ce8e61637cd023f4c/nova/compute/api.py#L3329 has no effect on save | 14:39 |
| *** markvoelker has joined #openstack-nova | 14:39 | |
| mriedem | https://github.com/openstack/nova/blob/a6963fa6858289d048e4d27ce8e61637cd023f4c/nova/objects/request_spec.py#L619. | 14:40 |
| *** sdake has quit IRC | 14:42 | |
| *** sdake has joined #openstack-nova | 14:43 | |
| *** mchlumsky has joined #openstack-nova | 14:44 | |
| *** sridharg has quit IRC | 14:44 | |
| bauwser | mriedem: yeah, most of the problems with the persisted fields in the ReqSpec is because we late call .save() sometimes or not | 14:46 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Plumbing for ignoring list_records_by_skipping_down_cells https://review.openstack.org/635121 | 14:46 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Plumbing for allowing the all-tenants filter with down cells https://review.openstack.org/635145 | 14:46 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Plumbing required in servers ViewBuilder to construct partial results https://review.openstack.org/635146 | 14:46 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells https://review.openstack.org/591657 | 14:46 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.68: Handles Down Cells Documentation https://review.openstack.org/635147 | 14:46 |
| bauwser | mriedem: so the only way to make sure to not persist them is to verify if save() does it or not | 14:47 |
| openstackgerrit | Mohammed Naser proposed openstack/nova master: zuul: add cross-repo jobs for openstack-ansible https://review.openstack.org/635852 | 14:47 |
| mriedem | i would argue the root of our problems with the request spec is its dual nature - it's both a record of the original server create request (and modified on rebuild + new image and resize + new flavor), but also used as a parameter data bag to pass stuff to the scheduler for per-request operatoins like migrations | 14:47 |
| mriedem | and we don't deal with ^ very well | 14:47 |
| bauwser | yeah I agree with you | 14:48 |
| mriedem | if we would have just passed things like requested_destination through to the scheduler as a specific parameter we could have saved some trouble | 14:48 |
| bauwser | well | 14:48 |
| bauwser | sure | 14:48 |
| *** sdake has quit IRC | 14:48 | |
| cdent | change it? | 14:48 |
| bauwser | but we had a consensus about not doing this 2 years ago ;) | 14:48 |
| bauwser | we preferred to pass o.vo objects rathre :) | 14:49 |
| mriedem | sure, because 2 years ago no one anticipated the shit loads of bugs | 14:49 |
| mriedem | i'm not advocating a big overhaul since that will yield yet more bugs | 14:49 |
| mriedem | i just bemoan blowing off a two every time i try to stitch a finger back on | 14:49 |
| mriedem | *toe | 14:49 |
| bauwser | well, maybe the analysis could be to say which fields should be persisted once and which ones not | 14:49 |
| mriedem | bauwser: we already have that in the request spec | 14:50 |
| mriedem | and have been adding to it over time | 14:50 |
| bauwser | right | 14:50 |
| mriedem | https://github.com/openstack/nova/blob/a6963fa6858289d048e4d27ce8e61637cd023f4c/nova/objects/request_spec.py#L587 | 14:50 |
| mriedem | https://github.com/openstack/nova/blob/a6963fa6858289d048e4d27ce8e61637cd023f4c/nova/objects/request_spec.py#L593 | 14:50 |
| *** janki has quit IRC | 14:50 | |
| mriedem | gibi is already handling requested_resources so they aren't overwritten on save https://github.com/openstack/nova/blob/a6963fa6858289d048e4d27ce8e61637cd023f4c/nova/objects/request_spec.py#L517 | 14:50 |
| mriedem | we need to do the same for those other fields probably | 14:51 |
| bauwser | ok | 14:51 |
| bauwser | yeah I guess | 14:51 |
| bauwser | like the flavor | 14:51 |
| bauwser | when should we persist it? | 14:51 |
| bauwser | for example, for resize | 14:51 |
| mriedem | flavor isn't in that list | 14:51 |
| bauwser | should we persist the new flavor in the original ReqSpec ? | 14:51 |
| bauwser | I know | 14:51 |
| *** sdake has joined #openstack-nova | 14:52 | |
| mriedem | we already do that here yeah https://github.com/openstack/nova/blob/a6963fa6858289d048e4d27ce8e61637cd023f4c/nova/conductor/manager.py#L361 | 14:52 |
| bauwser | I guess so | 14:52 |
| bauwser | so | 14:52 |
| bauwser | what I'm trying to explain is that we basically fixed problems by each bug | 14:52 |
| bauwser | and then we modified the object | 14:52 |
| bauwser | maybe we should just take some time to discuss about *all* the fields | 14:53 |
| mriedem | oh yeah and that flavor thing introduced a bug that was latent for a long time https://github.com/openstack/nova/blob/a6963fa6858289d048e4d27ce8e61637cd023f4c/nova/compute/api.py#L3403 | 14:53 |
| bauwser | right | 14:53 |
| bauwser | I'm just giving examples | 14:53 |
| mriedem | and i'm just venting | 14:53 |
| bauwser | so, honestly, the more I'm thinking | 14:53 |
| bauwser | the more I wonder if we should have more than one RequestSpec for an instance :) | 14:53 |
| bauwser | ie. the original record for create | 14:54 |
| bauwser | and then a new record for a move | 14:54 |
| mriedem | the more i think about request spec, the less i want to think about request spec | 14:54 |
| mriedem | i want to get this bug fixed and move on | 14:54 |
| bauwser | hah | 14:54 |
| bauwser | anyway, I need to go to a meeting | 14:55 |
| bauwser | :/ | 14:55 |
| *** gary_perkins has quit IRC | 14:55 | |
| *** gary_perkins has joined #openstack-nova | 14:56 | |
| *** gary_perkins has quit IRC | 14:56 | |
| *** gary_perkins has joined #openstack-nova | 14:56 | |
| *** tbachman has quit IRC | 15:04 | |
| *** whoami-rajat has quit IRC | 15:04 | |
| *** markvoelker has quit IRC | 15:12 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Trim fake_deserialize_context in test_conductor https://review.openstack.org/635859 | 15:21 |
| mriedem | another subunit parser thing ^ based on http://logs.openstack.org/27/619527/16/gate/openstack-tox-lower-constraints/cd2889d/job-output.txt.gz#_2019-02-08_12_32_26_104934 | 15:21 |
| mriedem | dansmith: so wrt upgrades we just assert that conductor always goes before everything else yeah? and api is last. which is why if we're making changes to both api and conductor at the same time w/o changing rpc method interfaces, but like through fields on the RequestSpec (behavior changes), we aren't doing any strict version checking in the API to make sure conductor is new enough to handle that behavior change | 15:26 |
| mriedem | we just assume that conductor will be upgraded before api | 15:26 |
| dansmith | mriedem: api isn't last, compute is last | 15:27 |
| mriedem | unlike how the api will check min versions on computes for behavior | 15:27 |
| dansmith | mriedem: we pretty much have to assume that conductor, scheduler, and api all go at the same time | 15:27 |
| mriedem | ok but conductor is first | 15:27 |
| *** remi_ness has joined #openstack-nova | 15:27 | |
| mriedem | yeah | 15:27 |
| mriedem | was just thinking about https://review.openstack.org/#/c/635668/2/nova/conductor/tasks/migrate.py@200 | 15:27 |
| mriedem | which is changes to conductor based on changes the api will make to the request spec, which is all assumed to be upgraded at the same time | 15:28 |
| dansmith | yeah | 15:28 |
| mriedem | i must be having some sort of existential crisis this morning | 15:28 |
| dansmith | mriedem: go to your happy place | 15:29 |
| *** Luzi has quit IRC | 15:29 | |
| *** spatel has joined #openstack-nova | 15:29 | |
| spatel | sean-k-mooney: morning | 15:29 |
| *** lpetrut has quit IRC | 15:29 | |
| *** lpetrut has joined #openstack-nova | 15:30 | |
| sean-k-mooney | spatel: o/ | 15:30 |
| spatel | openstack hypervisor stats show command " count | 179" is this number of hypervisor right? | 15:30 |
| melwitt | mriedem: looking at https://review.openstack.org/635859, is it that the assertions are constantly failing and being swallowed? is it bad that the assertions were failing? | 15:31 |
| *** cdent has quit IRC | 15:31 | |
| *** whoami-rajat has joined #openstack-nova | 15:31 | |
| *** pcaruana has quit IRC | 15:31 | |
| spatel | why hypervisor stats showing count 179 & "openstack hypervisor list" showing 193 | 15:32 |
| spatel | which one i should consider right? | 15:32 |
| spatel | sean-k-mooney: ^ | 15:32 |
| spatel | http://paste.openstack.org/show/744746/ | 15:33 |
| *** tbachman has joined #openstack-nova | 15:33 | |
| *** mlavalle has joined #openstack-nova | 15:36 | |
| mriedem | melwitt: yes and idk | 15:36 |
| mriedem | i do'nt know where the 'fake_user' is coming from b/c it's not coming from anything in test_conductor.py that i can tell | 15:37 |
| mriedem | i assume that any test which really cares about the context being serialized/deserialized is checking that explicitly, otherwise we use fake user/project ids all the time | 15:40 |
| sean-k-mooney | spatel: i know you had that issue in the past but i can rememebr what it was again | 15:41 |
| melwitt | mriedem: yeah, fair enough | 15:42 |
| *** priteau has joined #openstack-nova | 15:51 | |
| *** lpetrut has quit IRC | 15:51 | |
| *** sdake has quit IRC | 15:52 | |
| *** tssurya has quit IRC | 15:52 | |
| *** sdake has joined #openstack-nova | 15:53 | |
| *** jangutter has quit IRC | 15:54 | |
| *** sdake has quit IRC | 15:56 | |
| *** sdake has joined #openstack-nova | 15:58 | |
| *** eharney has quit IRC | 15:58 | |
| spatel | i think stats output doing something which list not doing.. that is why its difference | 15:59 |
| *** priteau has quit IRC | 16:00 | |
| *** cdent has joined #openstack-nova | 16:04 | |
| *** tbachman has quit IRC | 16:07 | |
| sean-k-mooney | spatel: the hypervior stats i think only show running vms | 16:08 |
| *** jangutter has joined #openstack-nova | 16:08 | |
| *** _fragatina has quit IRC | 16:08 | |
| sean-k-mooney | nova list will also show shelved instnaces and ones in error or power off state | 16:08 |
| spatel | if that is true then it make sense | 16:08 |
| *** eharney has joined #openstack-nova | 16:09 | |
| spatel | let me drill and see | 16:09 |
| *** markvoelker has joined #openstack-nova | 16:09 | |
| sean-k-mooney | oh wait you are not asking about nova list | 16:11 |
| sean-k-mooney | you are asing about count in openstack hypervisor stats show vs the outpu of openstack hypervior list | 16:11 |
| spatel | yes count | 16:11 |
| spatel | now you are on same page :) | 16:11 |
| spatel | sean-k-mooney: ^^ | 16:12 |
| *** TxGirlGeek has joined #openstack-nova | 16:12 | |
| sean-k-mooney | spatel: try openstack hypervisor list -c "Host IP" -c "Hypervisor Type" -f value | grep QEMU | sort | uniq | wc -l | 16:16 |
| spatel | 193 | 16:17 |
| sean-k-mooney | ok i was wondering if you had duplicate entries | 16:17 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set the conductor indirection API when running nova-metadata under uwsgi https://review.openstack.org/635577 | 16:17 |
| spatel | i verified already basic stuff | 16:18 |
| *** tbachman has joined #openstack-nova | 16:18 | |
| spatel | i think openstack hypervisor stats show ( only showing hypervisor in use ) | 16:18 |
| spatel | let me do experiment and see... let me empty or spin up vm and see count change or not | 16:19 |
| *** erlon has joined #openstack-nova | 16:21 | |
| sean-k-mooney | spatel: well teh api doces say it should the number of hyperviors | 16:22 |
| sean-k-mooney | https://developer.openstack.org/api-ref/compute/?expanded=show-hypervisor-statistics-detail#show-hypervisor-statistics | 16:22 |
| sean-k-mooney | so if it the number of active or in use hyperviors there is at least a docs bug | 16:22 |
| spatel | let me prove it and open bug | 16:23 |
| spatel | did you try to test these command in your cloud? | 16:23 |
| mriedem | dansmith: melwitt: i'm +2 on the bottom 3 down cell changes in that series now https://review.openstack.org/#/c/635120/ | 16:24 |
| sean-k-mooney | yes and they are the same | 16:24 |
| mriedem | splitting those out from the big patch was definitely the way to go | 16:24 |
| sean-k-mooney | ill disabel a compute service and see if it changes | 16:24 |
| sean-k-mooney | spatel: ok i can repoduce | 16:25 |
| sean-k-mooney | if the comptue node is disabled hypervior stats does not report it | 16:25 |
| sean-k-mooney | so that is a bug either in the code or in the docs | 16:26 |
| spatel | oh!!! | 16:26 |
| melwitt | mriedem: ack | 16:27 |
| *** owalsh_ has joined #openstack-nova | 16:27 | |
| spatel | sean-k-mooney: you are right!! i have around 10 or 12 disabled compute node | 16:28 |
| sean-k-mooney | spatel: what release are you running again? | 16:28 |
| spatel | pike | 16:28 |
| spatel | sorry queens | 16:28 |
| sean-k-mooney | i am not sure if we changed it in rocky or queens but we used to auto disable compute nodes after 3-5 failed builts without a successful build | 16:29 |
| sean-k-mooney | if you manually did not disable them that coudl be the cause | 16:29 |
| spatel | i didn't remember when and who did disable it.. but at least clear that stats not showing disable | 16:30 |
| *** owalsh has quit IRC | 16:30 | |
| spatel | Do you know how to list disable hypervisor from command line? | 16:31 |
| *** owalsh_ is now known as owalsh | 16:32 | |
| dansmith | mriedem: okay cool, glad to see that, I'll look a bit later | 16:32 |
| *** tbachman has quit IRC | 16:35 | |
| *** tbachman has joined #openstack-nova | 16:37 | |
| *** gyee has joined #openstack-nova | 16:38 | |
| *** markvoelker has quit IRC | 16:43 | |
| sean-k-mooney | spatel: openstack compute service list | 16:47 |
| *** hamzy has quit IRC | 16:47 | |
| spatel | thanks | 16:48 |
| *** eharney has quit IRC | 16:48 | |
| spatel | sean-k-mooney: 179 + 14 (disable) = 193 | 16:51 |
| spatel | I got my answer :) thanks | 16:52 |
| *** ileixe has joined #openstack-nova | 16:53 | |
| sean-k-mooney | spatel: can you file a bug just so we dont forget | 16:55 |
| sean-k-mooney | as i said we either should update the docs or the code | 16:56 |
| *** manjeets_ is now known as manjeets | 17:00 | |
| spatel | i think we should update code and add one more row ( disabled compute node ) ;) | 17:02 |
| *** wolverineav has joined #openstack-nova | 17:02 | |
| *** mcgiggler has quit IRC | 17:06 | |
| *** wolverineav has quit IRC | 17:07 | |
| *** dikonoor has quit IRC | 17:17 | |
| *** rpittau has quit IRC | 17:17 | |
| *** jangutter has quit IRC | 17:17 | |
| mriedem | ew another subunit parser giant log capture http://logs.openstack.org/27/619527/16/check/openstack-tox-py35/ab8a233/job-output.txt.gz#_2019-02-08_14_57_03_415588 | 17:21 |
| mriedem | gross that's from o.vo | 17:21 |
| mriedem | so i suppose we need to set log levels to debug for oslo.versionedobjects and oslo.messaging in our test runs | 17:22 |
| mriedem | s/debug/warning/ | 17:22 |
| mriedem | although for oslo.messaging we're tracing exceptions in those conductor unit tests... | 17:22 |
| sean-k-mooney | mriedem: one question do we know what the cause is? i was wondering if it could be a locale issue or something like that | 17:22 |
| melwitt | sean-k-mooney: I don't think so. see the comments in this earlier bug for more info https://bugs.launchpad.net/cinder/+bug/1728640 | 17:24 |
| openstack | Launchpad bug 1728640 in Cinder "py35 unit test subunit.parser failures" [Critical,Fix released] - Assigned to Sean McGinnis (sean-mcginnis) | 17:24 |
| mriedem | i think the summary is we're sending a shit load of content to the subunit output stream capture which blows it up | 17:25 |
| sean-k-mooney | ya that was the other ting i was wondering but i guess that means we are not mocking out the loggers enough in the unit tests | 17:25 |
| melwitt | yeah. from mtreinish: "we may be exceeding the max attachment size in subunit" | 17:26 |
| melwitt | (from a comment in that bug) | 17:26 |
| sean-k-mooney | on the plus side if we do reduce the log output it will both help with space on logs.openstack.org and maybe speed up the tests | 17:27 |
| sean-k-mooney | all that io is proably slowing them down | 17:27 |
| mriedem | well normally i don't think you get a lot of this output unless a test fails | 17:34 |
| mriedem | or the subunit parser blows up | 17:34 |
| openstackgerrit | Elod Illes proposed openstack/nova stable/queens: Handle IndexError in _populate_neutron_binding_profile https://review.openstack.org/635897 | 17:35 |
| *** yan0s has quit IRC | 17:37 | |
| *** tbachman has quit IRC | 17:37 | |
| *** markvoelker has joined #openstack-nova | 17:40 | |
| *** jaypipes is now known as leakypipes | 17:43 | |
| *** creepy_owlet is now known as dtantsur|afk | 17:43 | |
| *** udesale has quit IRC | 17:44 | |
| *** sdake has quit IRC | 17:47 | |
| *** remi_ness has quit IRC | 17:50 | |
| *** ccamacho has quit IRC | 17:50 | |
| *** derekh has quit IRC | 17:53 | |
| *** tbachman has joined #openstack-nova | 17:56 | |
| mnaser | mriedem, cdent, dansmith: https://review.openstack.org/#/c/635852/ has an openstack ansible cross repo job (which you can see installs from the zuul cloned nova -- http://logs.openstack.org/52/635852/1/check/nova-openstack-ansible-cross-repo/9738be9/logs/ara-report/result/113b6602-4a28-4512-964b-4174593eb507/ "Processing /home/zuul/src/git.openstack.org/openstack/nova") | 17:59 |
| mnaser | i will add another tox env which will run it making sure that we *skip* placement deploy to merge that eventually | 17:59 |
| mnaser | and then the normal functional test will run *with* out-of-repo placement | 18:00 |
| cdent | awesome, thanks | 18:00 |
| cdent | I'll look more closely soon, probably monday | 18:02 |
| dansmith | mriedem: should I not nit out over the presumptive microversion comment? https://review.openstack.org/#/c/635121/4 | 18:06 |
| *** ociuhandu_ has joined #openstack-nova | 18:08 | |
| *** jmlowe has quit IRC | 18:11 | |
| *** ociuhandu has quit IRC | 18:11 | |
| *** markvoelker has quit IRC | 18:13 | |
| *** ociuhandu_ has quit IRC | 18:13 | |
| *** hamzy has joined #openstack-nova | 18:14 | |
| *** remi_ness has joined #openstack-nova | 18:20 | |
| *** hamzy has quit IRC | 18:22 | |
| *** wolverineav has joined #openstack-nova | 18:22 | |
| *** ociuhandu has joined #openstack-nova | 18:23 | |
| *** wolverineav has quit IRC | 18:23 | |
| *** wolverineav has joined #openstack-nova | 18:24 | |
| *** hamzy has joined #openstack-nova | 18:25 | |
| *** chhagarw has quit IRC | 18:25 | |
| *** ociuhandu has quit IRC | 18:27 | |
| *** wolverineav has quit IRC | 18:31 | |
| *** wolverineav has joined #openstack-nova | 18:32 | |
| *** mdbooth_ has quit IRC | 18:33 | |
| *** wolverineav has quit IRC | 18:34 | |
| *** wolverineav has joined #openstack-nova | 18:34 | |
| *** whoami-rajat has quit IRC | 18:34 | |
| *** eharney has joined #openstack-nova | 18:38 | |
| *** ociuhandu has joined #openstack-nova | 18:49 | |
| *** hamzy has quit IRC | 18:50 | |
| *** wolverineav has quit IRC | 18:50 | |
| *** ociuhandu has quit IRC | 18:55 | |
| *** hamzy has joined #openstack-nova | 18:58 | |
| *** tesseract has quit IRC | 19:09 | |
| *** markvoelker has joined #openstack-nova | 19:10 | |
| *** hamzy has quit IRC | 19:10 | |
| aspiers | is there a reason that the trait string values in this dict are not referenced using os_traits constants? http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/utils.py#n49 | 19:10 |
| *** hamzy has joined #openstack-nova | 19:11 | |
| aspiers | wouldn't it be helpful to have the compile-time checks resulting from using os_traits? or am I misunderstanding something? | 19:11 |
| *** erlon has quit IRC | 19:12 | |
| cdent | aspiers: I think it's a matter of "didn't happen yet" | 19:13 |
| aspiers | cdent: so a patch would be gratefully received? :) | 19:13 |
| cdent | ask fried_rice or leakypipes to confirm, but I suspect so | 19:14 |
| aspiers | OK thanks | 19:14 |
| cdent | I'm not savvy to that section of the coe | 19:14 |
| cdent | and it is dinner time | 19:14 |
| * cdent waves | 19:14 | |
| *** cdent has quit IRC | 19:14 | |
| *** wolverineav has joined #openstack-nova | 19:16 | |
| openstackgerrit | Corey Bryant proposed openstack/nova master: xenapi/agent: Change openssl error handling https://review.openstack.org/635533 | 19:16 |
| *** ociuhandu has joined #openstack-nova | 19:18 | |
| cfriesen | If I were to request a release of os-traits (in order to make use of the new vTPM traits) would I ask for release 0.10.1 or 0.11.0? | 19:22 |
| melwitt | new traits = "new features" so a minor version bump | 19:23 |
| aspiers | melwitt: speaking of traits, do you have any thoughts on the above? I can submit a review easily | 19:23 |
| leakypipes | aspiers: no reason other than legacy I think... I'd welcome a cleanup patch. | 19:25 |
| melwitt | ok, good. I was about to say, I don't know and I'd ask jay | 19:25 |
| aspiers | :) | 19:25 |
| aspiers | leakypipes, melwitt: coming in about 15 seconds ... | 19:25 |
| cfriesen | aspiers: I see you just added some stuff to os-traits...were you planning on requesting a new release? | 19:25 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Convert CPU_TRAITS_MAPPING to use os_traits https://review.openstack.org/635919 | 19:26 |
| aspiers | cfriesen: don't need one urgently yet - still working on the code to consume the new trait :) | 19:26 |
| cfriesen | aspiers: I'm in the same boat, just don't want to get caught waiting too long | 19:26 |
| aspiers | cfriesen: fair enough | 19:26 |
| *** mriedem has quit IRC | 19:27 | |
| aspiers | leakypipes, melwitt: added you as reviewers | 19:27 |
| *** mriedem has joined #openstack-nova | 19:27 | |
| mriedem | dansmith: yeah good point, that should move | 19:28 |
| *** sdake has joined #openstack-nova | 19:28 | |
| *** wolverineav has quit IRC | 19:28 | |
| dansmith | I shall convert | 19:28 |
| dansmith | I shall wait until you drop your +2 | 19:28 |
| melwitt | aspiers: ack | 19:28 |
| mriedem | dansmith: already done | 19:28 |
| dansmith | mriedem: I shall be already done as well | 19:28 |
| mriedem | dansmith: are you just going to move it to https://review.openstack.org/#/c/591657/ ? | 19:28 |
| openstackgerrit | Elod Illes proposed openstack/nova stable/pike: Handle IndexError in _populate_neutron_binding_profile https://review.openstack.org/635921 | 19:29 |
| *** wolverineav has joined #openstack-nova | 19:29 | |
| dansmith | mriedem: am I? | 19:30 |
| aspiers | leakypipes: just checking IIUC: is update_provider_tree() the right place to add a call to new code which tests for SEV support and then calls provider_tree.add_traits() if support is found? | 19:31 |
| aspiers | leakypipes: I guess _get_cpu_traits() might be the other candidate, but that seems dependent on the guest CPU mode, which I don't think we want for SEV | 19:31 |
| mriedem | dansmith: i'm not sure what 'convert' meant | 19:32 |
| mriedem | oh -1? | 19:32 |
| dansmith | mriedem: heh yeah, convert my vote | 19:32 |
| * aspiers reads update-provider-tree.rst in an attempt to understand this properly | 19:32 | |
| mriedem | ah i see | 19:32 |
| mriedem | saved my sweet sweet stats sheet | 19:32 |
| mriedem | a true gentleman | 19:33 |
| * dansmith bows | 19:33 | |
| mriedem | aspiers: yes upt | 19:33 |
| mriedem | to set inventory/aggregates/traits/etc | 19:33 |
| aspiers | mriedem: thanks! | 19:33 |
| mriedem | aspiers: fried_rice is your captain for upt | 19:33 |
| aspiers | got it :) | 19:33 |
| aspiers | hmm, that nick is making me hungry | 19:33 |
| *** wolverineav has quit IRC | 19:34 | |
| *** BjoernT has joined #openstack-nova | 19:35 | |
| *** wolverineav has joined #openstack-nova | 19:35 | |
| *** wolverineav has quit IRC | 19:36 | |
| *** wolverineav has joined #openstack-nova | 19:36 | |
| *** hamzy has quit IRC | 19:37 | |
| *** hamzy has joined #openstack-nova | 19:38 | |
| *** BjoernT_ has joined #openstack-nova | 19:38 | |
| *** BjoernT has quit IRC | 19:40 | |
| *** erlon has joined #openstack-nova | 19:40 | |
| *** markvoelker has quit IRC | 19:44 | |
| *** zul has quit IRC | 19:45 | |
| *** BjoernT has joined #openstack-nova | 19:45 | |
| *** BjoernT_ has quit IRC | 19:47 | |
| *** mgoddard has quit IRC | 19:50 | |
| *** mgoddard has joined #openstack-nova | 19:51 | |
| aspiers | leakypipes, fried_rice, mriedem: I'm wondering if it makes sense to detect SEV support in get_available_resource(), possibly under data["cpu_info"] | 19:53 |
| mriedem | for what reason? | 19:53 |
| aspiers | for one, so it's visible via the API | 19:54 |
| mriedem | it is visible the API, | 19:54 |
| mriedem | the placement API | 19:54 |
| mriedem | as a trait on the compute node resource provider | 19:54 |
| aspiers | right, but not via "openstack hypervisor show" IIUC? | 19:55 |
| mriedem | we're not trying to game all new traits into the old hypervisor stats API | 19:55 |
| mriedem | correct | 19:55 |
| mriedem | and that's ok | 19:55 |
| mriedem | in the long long future the hypervisor stats/show stuff could be proxied to placement | 19:55 |
| aspiers | ah OK, so the idea is to move away from the old API? | 19:55 |
| aspiers | got it | 19:55 |
| aspiers | that thought arose because the get_domain_capabilities() I've added sits next to get_capabilities() https://review.openstack.org/#/c/633855/1/nova/virt/libvirt/host.py | 19:56 |
| aspiers | which is currently called from _get_cpu_info() | 19:56 |
| mriedem | but you can also get that via update_provider_tree yes? | 19:57 |
| mriedem | self.host.get_domain_capabilities() | 19:57 |
| aspiers | yup | 19:57 |
| mriedem | if 'sev' in caps: add_my_trait() | 19:57 |
| aspiers | makes sense, thanks! | 19:57 |
| mriedem | the cpu feature flag stuff sort of works like that | 19:57 |
| *** wolverineav has quit IRC | 19:58 | |
| fried_rice | aspiers: Give me a bit, I'm on a call, but - yes, at a glance, it makes sense to me that SEV support would be discovered and the trait injected in update_provider_tree. | 19:58 |
| *** sdake has quit IRC | 19:59 | |
| aspiers | fried_rice: cool, thanks! | 19:59 |
| aspiers | I need to grab some dinner | 19:59 |
| aspiers | back in a bit | 19:59 |
| *** wolverineav has joined #openstack-nova | 19:59 | |
| fried_rice | aspiers: Or, during init_host, add it to the virt driver's capabilities dict. | 19:59 |
| *** sdake has joined #openstack-nova | 19:59 | |
| fried_rice | but that relies on a) an in-flight patch from mriedem that converts those to traits on the compute RP, and b) making the capabilities dict an instance var on the relevant virt drivers, like PowerVM has. | 20:00 |
| aspiers | interesting, I'll check that out | 20:02 |
| fried_rice | aspiers: a) is https://review.openstack.org/#/c/538498/ | 20:02 |
| mriedem | "in-flight" | 20:03 |
| mriedem | more like crash landed | 20:03 |
| aspiers | LOL :) | 20:03 |
| *** eharney has quit IRC | 20:03 | |
| cfriesen | melwitt: fried_rice: if we're using the "cycle-with-intermediary" library pattern for os-traits, shouldn't there have been a release already after stein-2? | 20:03 |
| *** wolverineav has quit IRC | 20:04 | |
| fried_rice | aspiers: b) is visible in the out-of-tree PowerVM driver where we set a capability depending on which disk driver we're using: https://github.com/openstack/nova-powervm/blob/master/nova_powervm/virt/powervm/driver.py#L175-L181 | 20:04 |
| melwitt | cfriesen: yes. I had thought the release team was going to propose them but it looked like they didn't | 20:05 |
| fried_rice | cfriesen: I wouldn't expect os-traits releases to be a big deal wrt milestones, but whatevs. | 20:05 |
| cfriesen | fried_rice: not that it's a big deal, but according to http://lists.openstack.org/pipermail/openstack-dev/2018-October/135689.html it was going to be automatic | 20:05 |
| fried_rice | gotcha | 20:05 |
| melwitt | they did a release of os-traits at s-1 but not for s-2 | 20:05 |
| aspiers | fried_rice: in case you're interested, this is the first step towards detection of SEV support which will be consumed by the code which provides the new trait | 20:06 |
| aspiers | https://review.openstack.org/#/c/633855/ | 20:06 |
| fried_rice | were there changes between m-1 and m-2? | 20:06 |
| melwitt | yeah, I wondered if maybe there weren't | 20:06 |
| fried_rice | aspiers: ack, I've had that spec on my list for yonks. hope to get around to reading it eventually ... | 20:06 |
| aspiers | fried_rice: thanks a lot for all the info, I'll take a look | 20:06 |
| aspiers | hehe | 20:07 |
| aspiers | OK, I really REALLY need dinner now. bbl ;-) | 20:07 |
| cfriesen | melwitt: what was the exact cutoff? the vTPM stuff went in on Jan 8, and there was a minor change on Jan 5 | 20:07 |
| cfriesen | anyways, I'll propose a release | 20:08 |
| melwitt | not sure. smcginnis, do you know how the auto release works? we noticed there wasn't an automatic release proposed for os-traits at s-2 | 20:08 |
| *** sdake has quit IRC | 20:09 | |
| *** sdake has joined #openstack-nova | 20:11 | |
| *** sdake has quit IRC | 20:13 | |
| *** sdake has joined #openstack-nova | 20:14 | |
| *** BjoernT_ has joined #openstack-nova | 20:14 | |
| *** BjoernT has quit IRC | 20:16 | |
| melwitt | yeah, I don't find any auto-proposed releases for s-2 like this one from s-1 https://review.openstack.org/612843 | 20:16 |
| *** hongbin has joined #openstack-nova | 20:19 | |
| *** ociuhandu has quit IRC | 20:20 | |
| *** hamzy has quit IRC | 20:21 | |
| *** trident has quit IRC | 20:21 | |
| *** trident has joined #openstack-nova | 20:22 | |
| *** trident has quit IRC | 20:34 | |
| *** trident has joined #openstack-nova | 20:35 | |
| *** _hemna has quit IRC | 20:36 | |
| *** markvoelker has joined #openstack-nova | 20:40 | |
| *** sdake has quit IRC | 20:44 | |
| *** sdake has joined #openstack-nova | 20:47 | |
| *** whoami-rajat has joined #openstack-nova | 20:48 | |
| *** dave-mccowan has quit IRC | 20:50 | |
| *** dave-mccowan has joined #openstack-nova | 20:53 | |
| smcginnis | melwitt, cfriesen: Were there more than 1 or 2 non-zuul, functional changes? It's possible it was accidentally skipped if it didn't look like there were really changes to get out. | 20:58 |
| *** hamzy has joined #openstack-nova | 20:59 | |
| cfriesen | smcginnis: one actual change went in on jan 8, so maybe that was it. | 20:59 |
| smcginnis | Actually, looks like that didn't merge until the 11th, so it was most likely after we checked. | 21:00 |
| smcginnis | https://review.openstack.org/#/c/629299/ | 21:00 |
| melwitt | smcginnis: there was one functional change, I think. I tried a gerrit search for project:openstack/releases message:"stein milestone-2" and didn't find any other auto-generated releases | 21:01 |
| melwitt | (unless the commit message format changed) | 21:01 |
| smcginnis | I can't remember if we used "stein milestone-2" in the commit messages for those. | 21:02 |
| melwitt | ok, I was curious if any other project got an auto-proposed release for s-2 but didn't know how to find | 21:05 |
| melwitt | it was nice having it for s-1 anyway :) | 21:06 |
| melwitt | mriedem: can you sanity check me, is this backward incompatible, the 'only_contrib' removal? it looks to me like it's removed but not backward incompat https://github.com/openstack/python-novaclient/compare/11.1.0...master | 21:10 |
| *** markvoelker has quit IRC | 21:12 | |
| mriedem | no it's not, so a minor version bump at least | 21:13 |
| mriedem | that warning has been there since pike i think | 21:14 |
| mriedem | i also don't know if that discover_extensions() thing is an external interface on the client at all | 21:14 |
| mriedem | so not backward compatible but also meh | 21:14 |
| melwitt | yeah, you know, that is ringing a bell that some project was calling discover_extensions() externally | 21:16 |
| melwitt | looks like lots of stuff actually. heat, cinder, neutron | 21:18 |
| *** dave-mccowan has quit IRC | 21:18 | |
| melwitt | karbor, masakari, osc | 21:18 |
| *** ociuhandu has joined #openstack-nova | 21:19 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.openstack.org/635646 | 21:19 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Execute CrossCellMigrationTask from MigrationTask https://review.openstack.org/635668 | 21:19 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Plumb allow_cross_cell_resize into compute API resize() https://review.openstack.org/635684 | 21:19 |
| mriedem | yeah i guess http://codesearch.openstack.org/?q=%5C.discover_extensions&i=nope&files=&repos= | 21:20 |
| mriedem | not sure why, it doesn't do anything anymore as far as i know | 21:20 |
| mriedem | as in novaclient doesn't have 'extensions' anymore | 21:20 |
| melwitt | yeah. probably been there forever | 21:22 |
| mriedem | dansmith: if i fix that issue in tssurya's patch quick are you ok with approving any of those bottom changes yet today or just wait for monday? | 21:22 |
| openstackgerrit | Corey Bryant proposed openstack/nova master: xenapi/agent: Change openssl error handling https://review.openstack.org/635533 | 21:22 |
| dansmith | mriedem: I stopped when I got to that and asked you about it, then got distracted | 21:23 |
| dansmith | mriedem: but yeah, if you fix that quick I'll hit that one at least and see what the next one looks like | 21:23 |
| mriedem | ok | 21:23 |
| *** ociuhandu has quit IRC | 21:24 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumbing for ignoring list_records_by_skipping_down_cells https://review.openstack.org/635121 | 21:27 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumbing for allowing the all-tenants filter with down cells https://review.openstack.org/635145 | 21:27 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumbing required in servers ViewBuilder to construct partial results https://review.openstack.org/635146 | 21:27 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: API microversion 2.68: Handles Down Cells https://review.openstack.org/591657 | 21:27 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: API microversion 2.68: Handles Down Cells Documentation https://review.openstack.org/635147 | 21:27 |
| dansmith | damit mriedem | 21:27 |
| mriedem | sheesh | 21:28 |
| mriedem | full rebasearro | 21:28 |
| mriedem | *rebasearoo | 21:28 |
| melwitt | actually I think this should be a major bump because of the removal of those contrib modules. in case anyone was using them? | 21:29 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Modify InstanceMappingList.get_not_deleted_by_cell_and_project() https://review.openstack.org/635120 | 21:29 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumbing for ignoring list_records_by_skipping_down_cells https://review.openstack.org/635121 | 21:29 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumbing for allowing the all-tenants filter with down cells https://review.openstack.org/635145 | 21:29 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumbing required in servers ViewBuilder to construct partial results https://review.openstack.org/635146 | 21:29 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: API microversion 2.68: Handles Down Cells https://review.openstack.org/591657 | 21:29 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: API microversion 2.68: Handles Down Cells Documentation https://review.openstack.org/635147 | 21:29 |
| mriedem | melwitt: whatever you want | 21:29 |
| melwitt | going to play it safe | 21:29 |
| dansmith | mriedem: okay hit the bottom two, have the third up for when I finish something | 21:30 |
| mriedem | cool | 21:30 |
| mriedem | time for me to start my think friday | 21:31 |
| *** BjoernT_ has quit IRC | 21:31 | |
| dansmith | oh man, forgot about think friday | 21:32 |
| melwitt | os-vif has been released a billion times so I don't need to do that | 21:34 |
| *** sdake has quit IRC | 21:58 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: API: Remove evacuate/live-migrate 'force' parameter https://review.openstack.org/634600 | 22:09 |
| *** remi_ness has quit IRC | 22:09 | |
| *** markvoelker has joined #openstack-nova | 22:10 | |
| *** TxGirlGeek has quit IRC | 22:11 | |
| dansmith | mriedem: okay got N-3 | 22:17 |
| dansmith | the actual microversion patch is like half the size now, which is oh so much better | 22:18 |
| mriedem | yeah | 22:19 |
| mriedem | and most of it is samples | 22:19 |
| *** wolverineav has joined #openstack-nova | 22:19 | |
| dansmith | yeah | 22:20 |
| mriedem | welp it's 4:20, too late to start think friday now | 22:20 |
| *** wolverineav has quit IRC | 22:23 | |
| *** wolverineav has joined #openstack-nova | 22:23 | |
| *** remi_ness has joined #openstack-nova | 22:26 | |
| *** wolverineav has quit IRC | 22:28 | |
| *** wolverineav has joined #openstack-nova | 22:32 | |
| *** remi_ness has quit IRC | 22:35 | |
| fried_rice | o ovo wizards, remind me what the idiom is for getting extra specs out of a flavor obj | 22:37 |
| fried_rice | if 'extra_specs' in flavor: | 22:38 |
| fried_rice | extra_specs = flavor.extra_specs | 22:38 |
| fried_rice | ? | 22:38 |
| *** hongbin has quit IRC | 22:38 | |
| mriedem | anyone want to drop the nova-multiattach job from nova changes? https://review.openstack.org/#/c/606981/ | 22:38 |
| mriedem | fried_rice: yes, but i think it's always there | 22:38 |
| mriedem | return cls._from_db_object(context, cls(context), db_flavor, | 22:39 |
| mriedem | expected_attrs=['extra_specs']) | 22:39 |
| fried_rice | apparently not, at least in test: http://logs.openstack.org/43/631243/8/check/openstack-tox-py27/e61ba3b/testr_results.html.gz | 22:39 |
| mriedem | unit tests not withstanding | 22:39 |
| fried_rice | maybe the test is just borked. | 22:39 |
| mriedem | yeah in real runtime code the flavor would have the extra specs loaded on get from the db | 22:39 |
| fried_rice | can it be None? | 22:40 |
| mriedem | is the field marked as nullable=True? | 22:40 |
| fried_rice | ... | 22:40 |
| mriedem | 631243 | 22:40 |
| mriedem | oops | 22:40 |
| mriedem | 'extra_specs': fields.DictOfStringsField(), | 22:40 |
| mriedem | no | 22:40 |
| mriedem | so it's not nullable | 22:40 |
| mriedem | if it's set, it's not None | 22:40 |
| mriedem | and cannot be set to None | 22:40 |
| fried_rice | (Whether it is or not, I've learned not to trust my intuition when it comes to db objs and ovos) | 22:41 |
| mriedem | you're usually pretty safe unless it's RequestSpec | 22:41 |
| mriedem | then you're in for a world of pain | 22:41 |
| fried_rice | okay, so it's always legal to say flavor.extra_specs.get('some_key') and not have to dork with checking whether extra_specs is a) present, b) a dict? | 22:41 |
| mriedem | it's alwasy a dict | 22:41 |
| fried_rice | ight. | 22:41 |
| mriedem | in runtime code it should be present | 22:41 |
| *** markvoelker has quit IRC | 22:42 | |
| mriedem | yeah this is wonky https://review.openstack.org/#/c/631243/8/nova/objects/flavor.py@231 | 22:43 |
| mriedem | that could just be self.extra_specs.get('accel:device_profile') | 22:43 |
| fried_rice | yeah, that's what I'm ripping on. | 22:43 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.openstack.org/633855 | 22:43 |
| aspiers | fried_rice: thanks for the recheck - is the dsvm-nova gate broken, or is my code? ... or both? X-D | 22:44 |
| aspiers | I can't get through to the NSX CI logs | 22:44 |
| fried_rice | aspiers: hanging on by one rusty hinge | 22:44 |
| aspiers | hehe | 22:45 |
| fried_rice | it's not your code | 22:45 |
| fried_rice | if your code were a problem, the whole CI would be red | 22:45 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: neutron: make migrate_instance_finish call setup_instance_network_on_host https://review.openstack.org/635343 | 22:45 |
| fried_rice | (for that patch) | 22:45 |
| aspiers | yeah I guess | 22:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: neutron: make migrate_instance_finish call setup_instance_network_on_host https://review.openstack.org/635343 | 22:46 |
| *** panda has quit IRC | 22:46 | |
| fried_rice | mriedem: Um, you said something about RequestSpec being problematic? | 22:47 |
| fried_rice | You mean if I'm trying to do this on RequestSpec fields themselves, or if I'm trying to pull RequestSpec.flavor.extra_specs.get('something') ? | 22:48 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Follow up (#2) for the bw resource provider series https://review.openstack.org/634767 | 22:48 |
| mriedem | fried_rice: i'm just be facetious | 22:48 |
| mriedem | see my request spec rant this morning | 22:48 |
| fried_rice | emphasis on feces. | 22:49 |
| mriedem | HI-O! | 22:49 |
| fried_rice | so this is just using fake_spec_obj, which exists previously https://review.openstack.org/#/c/631243/8/nova/tests/unit/scheduler/test_device_profile.py | 22:49 |
| *** panda has joined #openstack-nova | 22:49 | |
| fried_rice | but apparently trying to pull extra specs out of that with spec_obj.flavor.get('extra_specs') is blowing up. | 22:50 |
| fried_rice | (in test.) | 22:50 |
| mriedem | req_obj.flavor = fake_flavor.fake_flavor_obj(ctxt) | 22:51 |
| mriedem | my guess is there is a problem in how that sets the extra_specs on that fake Flavor object | 22:52 |
| mriedem | yup | 22:52 |
| mriedem | 'extra_specs' needs to be in expected_attrs | 22:52 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/objects/flavor.py#L258 | 22:53 |
| mriedem | extra_specs is a joined column so that fake_flavor_obj code is a bit misleading | 22:53 |
| fried_rice | and that always happens in real life, so that test code ought to be updated accordingly? | 22:54 |
| mriedem | yes | 22:54 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/tests/unit/fake_request_spec.py#L78 | 22:54 |
| mriedem | should pass expected_attrs=['extra_specs'] | 22:54 |
| mriedem | or fake_flavor_obj should just default to extra_specs if expected_attrs is empty | 22:54 |
| mriedem | b/c that's what the get from db methods in the object do https://github.com/openstack/nova/blob/master/nova/objects/flavor.py#L378 | 22:55 |
| fried_rice | yeah, this fixes: | 22:55 |
| fried_rice | --- a/nova/tests/unit/fake_flavor.py | 22:55 |
| fried_rice | +++ b/nova/tests/unit/fake_flavor.py | 22:55 |
| fried_rice | @@ -50,7 +50,7 @@ def fake_db_flavor(**updates): | 22:55 |
| fried_rice | 22:55 | |
| fried_rice | 22:55 | |
| fried_rice | def fake_flavor_obj(context, **updates): | 22:55 |
| fried_rice | - expected_attrs = updates.pop('expected_attrs', None) | 22:55 |
| fried_rice | + expected_attrs = updates.pop('expected_attrs', ['extra_specs']) | 22:55 |
| fried_rice | return objects.Flavor._from_db_object(context, | 22:55 |
| fried_rice | objects.Flavor(), fake_db_flavor(**updates), | 22:55 |
| fried_rice | expected_attrs=expected_attrs) | 22:55 |
| mriedem | ++ | 22:55 |
| *** wolverineav has quit IRC | 23:02 | |
| *** wolverineav has joined #openstack-nova | 23:02 | |
| *** spatel has quit IRC | 23:03 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Share snapshot image membership with instance owner https://review.openstack.org/630769 | 23:06 |
| *** whoami-rajat has quit IRC | 23:08 | |
| *** wolverineav has quit IRC | 23:09 | |
| *** wolverineav has joined #openstack-nova | 23:11 | |
| *** wolverineav has quit IRC | 23:16 | |
| *** wolverineav has joined #openstack-nova | 23:16 | |
| *** wolverineav has quit IRC | 23:17 | |
| mriedem | jroll: just a reminder that when https://review.openstack.org/#/c/635006/ is ready to go for wider review to throw it in the runways queue https://etherpad.openstack.org/p/nova-runways-stein | 23:18 |
| *** wolverineav has joined #openstack-nova | 23:18 | |
| aspiers | fried_rice, mriedem: was trying to understand the discussion around https://review.openstack.org/#/c/538498/ and it seems one point of debate was the corner case where a trait might need to be removed from a node, right? | 23:20 |
| aspiers | fried_rice, mriedem: FWIW, that is not too unlikely with SEV | 23:20 |
| fried_rice | aspiers: The basic idea is that there are some traits that are "owned" by compute, and any others are not. | 23:21 |
| aspiers | It could be triggered by a downgrade of the kernel or QEMU or libvirt, or by disabling the sev option in the kvm_amd kernel module | 23:21 |
| aspiers | fried_rice: yeah I got that, and I presume that the SEV trait would be owned by compute | 23:21 |
| fried_rice | If a trait is owned by compute, you can't (un)set it as an operator or whatever. Next periodic will restore it to its "proper" (according to compute) value. | 23:22 |
| aspiers | sure | 23:22 |
| fried_rice | so if your trait is owned by compute, all you have to worry about is whether it needs to be set or not, and do that. | 23:22 |
| fried_rice | If you need to be able to do that *without* compute service restarts, then I recommend doing it in update_provider_tree, not via a driver capability. | 23:22 |
| aspiers | My point is that SEV requires support all the way up the stack, and if one link in the chain vanishes, then the trait would have to be removed. So that code under review does have to correctly handle that case, as you were saying in the discussion | 23:23 |
| aspiers | I don't think it needs to happen without nova-compute restart | 23:23 |
| aspiers | It's not gonna be a regular occurrence at all | 23:23 |
| fried_rice | oh, you're worried about whether I'm right to -1 mriedem's patch?? Of *course* I am! | 23:23 |
| fried_rice | I've *never* -1'd a mriedem patch and been *wrong* about it! | 23:24 |
| *** slaweq has quit IRC | 23:24 | |
| fried_rice | aspiers: Are you looking to take over that patch and make it go? That would be appreciated, I think, by me & mriedem and others. | 23:24 |
| aspiers | haha | 23:24 |
| fried_rice | you're referring to https://review.openstack.org/#/c/538498/7/nova/compute/resource_tracker.py@962 ? | 23:25 |
| aspiers | fried_rice: I like the idea in principal, but the reality is that I'm *hopelessly* new to all of this code so I worry it would take me far too long to figure out | 23:25 |
| *** wolverineav has quit IRC | 23:25 | |
| aspiers | yeah that was part of the discussion I was referring to | 23:26 |
| fried_rice | aspiers: you're demonstrating an understanding that's certainly adequate to where you'd be capable of making this patch go. Matt and I would be available to advise if you got stuck. | 23:26 |
| aspiers | fried_rice: maybe I'm just a good bluffer ;-) | 23:26 |
| fried_rice | So yeah, I'm +2 on this patch if that condition is removed. (And also rebase, and also test fixups, I think) | 23:27 |
| mriedem | the trick on that thing is really just functional testing the scenarios | 23:27 |
| mriedem | 1. compute reports traits via driver capabilities, user removes them externally, run periodic and they come back | 23:27 |
| mriedem | 2. user externally sets traits and compute periodic doesn't remove them | 23:28 |
| mriedem | 3. driver reports traits in t0, then at t1 doesn't report the trait, so it's removedd | 23:28 |
| mriedem | something like that | 23:28 |
| fried_rice | ++ | 23:28 |
| fried_rice | the patch already has a start on that stuff. | 23:28 |
| mriedem | once the functional test scenarios are in place then the code should be pretty straight-forward | 23:28 |
| aspiers | I see | 23:28 |
| fried_rice | https://review.openstack.org/#/c/538498/7/nova/tests/functional/test_servers.py | 23:28 |
| aspiers | yeah, looking at that | 23:29 |
| mriedem | with that it's 5:30 and i need to shove off | 23:29 |
| fried_rice | o/ | 23:29 |
| mriedem | i hope y'all will do the same | 23:29 |
| *** mriedem has quit IRC | 23:29 | |
| aspiers | it's 11:30pm here :-/ | 23:29 |
| fried_rice | I'm going to rip apart Sundar's PoC a little more. | 23:29 |
| fried_rice | Where in the build flow do neutron ports get bound? | 23:30 |
| aspiers | it looks like it doesn't yet test the behaviour of a driver-reported trait being removed, right? | 23:30 |
| fried_rice | aspiers: I think it only really tests that capabilities are converted to traits, stuffed onto the compute rp, and new custom ones are vivified in placement. | 23:32 |
| fried_rice | that would be scenario 0 in mriedem's list above. | 23:32 |
| aspiers | ok | 23:32 |
| fried_rice | So 1, 2, and 3 all still need to be implemented. | 23:32 |
| aspiers | got it | 23:33 |
| fried_rice | I guess the existing code is mriedem's scenario 1 before the first comma. | 23:33 |
| *** sdake has joined #openstack-nova | 23:33 | |
| aspiers | I see | 23:36 |
| *** wolverineav has joined #openstack-nova | 23:44 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!