*** agopi has joined #openstack-nova | 00:00 | |
openstackgerrit | Merged openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Stein" https://review.openstack.org/632507 | 00:02 |
---|---|---|
*** itlinux has joined #openstack-nova | 00:05 | |
*** wolverineav has quit IRC | 00:05 | |
*** itlinux has quit IRC | 00:06 | |
*** macza has quit IRC | 00:06 | |
*** wolverineav has joined #openstack-nova | 00:06 | |
*** tetsuro has joined #openstack-nova | 00:11 | |
*** wolverineav has quit IRC | 00:11 | |
*** agopi has quit IRC | 00:12 | |
*** ircuser-1 has quit IRC | 00:17 | |
*** markvoelker has joined #openstack-nova | 00:19 | |
*** tosky has quit IRC | 00:19 | |
*** ircuser-1 has joined #openstack-nova | 00:20 | |
aspiers | mriedem: just to be clear, my only currently submitted SEV patch https://review.openstack.org/#/c/633855/ shouldn't need rebasing since it's just extending the domain XML model | 00:25 |
aspiers | mriedem: but the next one I submit will auto-detect the SEV feature and most likely take advantage of the driver's capabilities to provide that trait | 00:26 |
openstackgerrit | Merged openstack/nova master: Fix typo in initial_disk_allocation_ratio release note https://review.openstack.org/638245 | 00:28 |
openstackgerrit | Merged openstack/nova master: API microversion 2.69: Handles Down Cells Documentation https://review.openstack.org/635147 | 00:29 |
openstackgerrit | Merged openstack/nova master: doc: fix and clarify --block-device usage in user docs https://review.openstack.org/607589 | 00:29 |
*** tetsuro has quit IRC | 00:36 | |
*** tetsuro has joined #openstack-nova | 00:37 | |
*** wolverineav has joined #openstack-nova | 00:37 | |
*** mvkr has quit IRC | 00:40 | |
*** wolverineav has quit IRC | 00:42 | |
*** mvkr has joined #openstack-nova | 00:42 | |
*** marst has joined #openstack-nova | 00:50 | |
*** slaweq has quit IRC | 00:52 | |
*** whoami-rajat has joined #openstack-nova | 01:12 | |
*** logan- has quit IRC | 01:22 | |
*** logan- has joined #openstack-nova | 01:23 | |
*** wolverineav has joined #openstack-nova | 01:24 | |
*** agopi has joined #openstack-nova | 01:26 | |
*** wolverineav has quit IRC | 01:28 | |
*** logan- has quit IRC | 01:31 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Fix the leak in the cross-cell revert resize code https://review.openstack.org/638314 | 01:31 |
*** logan- has joined #openstack-nova | 01:31 | |
*** mriedem has quit IRC | 01:35 | |
*** Kunpeng has quit IRC | 01:38 | |
*** sdake has quit IRC | 01:44 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add method to allow reset fields for root bdm in BDM obj https://review.openstack.org/614672 | 01:45 |
*** sdake has joined #openstack-nova | 01:47 | |
*** wolverineav has joined #openstack-nova | 01:50 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | 01:58 |
*** nicholas has quit IRC | 02:03 | |
*** keekz has joined #openstack-nova | 02:05 | |
*** gyee has quit IRC | 02:06 | |
*** _fragatina has quit IRC | 02:12 | |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for cyborg access https://review.openstack.org/631242 | 02:14 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to spec obj. https://review.openstack.org/631243 | 02:14 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.openstack.org/631244 | 02:14 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.openstack.org/631245 | 02:14 |
openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 02:16 |
*** _fragatina has joined #openstack-nova | 02:16 | |
*** _fragatina has quit IRC | 02:17 | |
*** _fragatina has joined #openstack-nova | 02:17 | |
*** wolverineav has quit IRC | 02:20 | |
*** wolverineav has joined #openstack-nova | 02:21 | |
*** _fragatina has quit IRC | 02:21 | |
*** wolverineav has quit IRC | 02:22 | |
*** erlon__ has joined #openstack-nova | 02:24 | |
*** wolverineav has joined #openstack-nova | 02:26 | |
*** erlon__ has quit IRC | 02:31 | |
*** wolverineav has quit IRC | 02:31 | |
*** sapd1_x has quit IRC | 02:38 | |
*** Dinesh_Bhor has joined #openstack-nova | 02:41 | |
*** efried_pto is now known as efried | 02:43 | |
*** purplerbot has quit IRC | 02:43 | |
*** purplerbot has joined #openstack-nova | 02:44 | |
*** marst has quit IRC | 02:46 | |
*** hongbin has joined #openstack-nova | 02:48 | |
*** sdake has quit IRC | 02:48 | |
*** sdake has joined #openstack-nova | 02:49 | |
*** psachin has joined #openstack-nova | 02:52 | |
*** sdake has quit IRC | 02:57 | |
*** sdake has joined #openstack-nova | 02:58 | |
openstackgerrit | Yongli He proposed openstack/nova master: Add server subresouce topology API https://review.openstack.org/621476 | 02:59 |
*** dklyle has quit IRC | 03:03 | |
*** wwriverrat has joined #openstack-nova | 03:04 | |
*** wwriverrat has quit IRC | 03:05 | |
*** wolverineav has joined #openstack-nova | 03:06 | |
*** wolverineav has quit IRC | 03:10 | |
*** dklyle has joined #openstack-nova | 03:17 | |
*** markvoelker has quit IRC | 03:20 | |
openstackgerrit | melanie witt proposed openstack/nova master: WIP Add online data migration for populating user_id https://review.openstack.org/633351 | 03:27 |
openstackgerrit | melanie witt proposed openstack/nova master: WIP Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | 03:27 |
openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 03:27 |
openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 03:27 |
*** zhubx has joined #openstack-nova | 03:28 | |
*** spsurya has joined #openstack-nova | 03:34 | |
*** wolverineav has joined #openstack-nova | 03:48 | |
*** udesale has joined #openstack-nova | 03:51 | |
*** takashin has joined #openstack-nova | 03:51 | |
*** tbachman has quit IRC | 03:59 | |
*** tbachman has joined #openstack-nova | 04:00 | |
*** tetsuro has quit IRC | 04:06 | |
*** markvoelker has joined #openstack-nova | 04:21 | |
*** wolverineav has quit IRC | 04:29 | |
*** _fragatina has joined #openstack-nova | 04:33 | |
*** _fragatina has quit IRC | 04:37 | |
*** _fragatina has joined #openstack-nova | 04:37 | |
*** moshele has joined #openstack-nova | 04:39 | |
*** moshele has quit IRC | 04:45 | |
*** sdake has quit IRC | 04:50 | |
*** sdake has joined #openstack-nova | 04:54 | |
*** markvoelker has quit IRC | 04:55 | |
*** hongbin has quit IRC | 05:04 | |
*** sdake has quit IRC | 05:14 | |
*** sdake has joined #openstack-nova | 05:16 | |
*** abhishekk has joined #openstack-nova | 05:16 | |
openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 05:18 |
openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 05:21 |
*** moshele has joined #openstack-nova | 05:23 | |
openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 05:25 |
*** wwriverrat has joined #openstack-nova | 05:34 | |
*** tetsuro has joined #openstack-nova | 05:38 | |
*** _fragatina has quit IRC | 05:38 | |
*** ratailor has joined #openstack-nova | 05:40 | |
*** tetsuro has quit IRC | 05:41 | |
*** tetsuro has joined #openstack-nova | 05:45 | |
*** sdake has quit IRC | 05:48 | |
*** agopi has quit IRC | 05:49 | |
*** sdake has joined #openstack-nova | 05:49 | |
*** markvoelker has joined #openstack-nova | 05:52 | |
*** tetsuro has quit IRC | 05:53 | |
*** lbragstad_ has joined #openstack-nova | 05:53 | |
*** gokhani has joined #openstack-nova | 05:53 | |
*** wolverineav has joined #openstack-nova | 05:55 | |
*** tetsuro has joined #openstack-nova | 05:55 | |
*** lbragstad has quit IRC | 05:55 | |
*** wolverineav has quit IRC | 05:59 | |
*** sdake has quit IRC | 06:03 | |
*** tetsuro has quit IRC | 06:04 | |
*** lbragstad has joined #openstack-nova | 06:04 | |
*** lbragstad_ has quit IRC | 06:04 | |
*** sdake has joined #openstack-nova | 06:05 | |
*** lbragstad_ has joined #openstack-nova | 06:09 | |
*** lbragstad has quit IRC | 06:10 | |
*** lbragstad has joined #openstack-nova | 06:16 | |
*** lbragstad_ has quit IRC | 06:18 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: WIP detach root volume API changes https://review.openstack.org/623981 | 06:19 |
*** sridharg has joined #openstack-nova | 06:20 | |
*** markvoelker has quit IRC | 06:25 | |
*** spsurya has quit IRC | 06:25 | |
*** pbing19 has joined #openstack-nova | 06:26 | |
*** sdake has quit IRC | 06:37 | |
*** Luzi has joined #openstack-nova | 06:40 | |
*** bhagyashris has joined #openstack-nova | 06:41 | |
*** jaypipes has quit IRC | 06:42 | |
*** stakeda has joined #openstack-nova | 06:46 | |
*** jaypipes has joined #openstack-nova | 06:46 | |
*** igordc has quit IRC | 06:52 | |
*** slaweq has joined #openstack-nova | 07:08 | |
*** psachin has quit IRC | 07:10 | |
*** egonzalez has quit IRC | 07:10 | |
*** egonzalez has joined #openstack-nova | 07:11 | |
*** rcernin has quit IRC | 07:13 | |
*** spsurya has joined #openstack-nova | 07:17 | |
*** wolverineav has joined #openstack-nova | 07:18 | |
*** pcaruana has joined #openstack-nova | 07:19 | |
*** markvoelker has joined #openstack-nova | 07:22 | |
*** sambetts_ has quit IRC | 07:29 | |
*** sambetts_ has joined #openstack-nova | 07:30 | |
*** psachin has joined #openstack-nova | 07:32 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove wrong description for auto resize confirm https://review.openstack.org/638357 | 07:42 |
*** Dinesh_Bhor has quit IRC | 07:49 | |
*** wolverineav has quit IRC | 07:52 | |
*** sapd1_x has joined #openstack-nova | 07:54 | |
*** markvoelker has quit IRC | 07:55 | |
*** _pewp_ has quit IRC | 07:58 | |
*** _pewp_ has joined #openstack-nova | 07:59 | |
*** tssurya has joined #openstack-nova | 07:59 | |
*** sunnaichuan has joined #openstack-nova | 08:01 | |
*** pbing19 has quit IRC | 08:03 | |
*** sapd1_x has quit IRC | 08:06 | |
*** jaosorior has quit IRC | 08:08 | |
*** awalende has joined #openstack-nova | 08:15 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: rbd: flatten images when creating/unshelving an instance https://review.openstack.org/457886 | 08:17 |
*** ccamacho has quit IRC | 08:18 | |
*** tesseract has joined #openstack-nova | 08:18 | |
*** tkajinam has quit IRC | 08:23 | |
*** lbragstad has quit IRC | 08:25 | |
*** tosky has joined #openstack-nova | 08:26 | |
*** ivve has joined #openstack-nova | 08:27 | |
*** wolverineav has joined #openstack-nova | 08:28 | |
*** ttsiouts has joined #openstack-nova | 08:36 | |
*** helenafm has joined #openstack-nova | 08:36 | |
openstackgerrit | Silvan Kaiser proposed openstack/nova master: Added mount fstype based validation of Quobyte mounts https://review.openstack.org/522245 | 08:42 |
*** aloga has quit IRC | 08:48 | |
openstackgerrit | zhaixiaojun proposed openstack/nova master: When the flavor id is invalid, the message does not match the regular expression, missing the numbers from 0-9. https://review.openstack.org/638150 | 08:48 |
*** aloga has joined #openstack-nova | 08:48 | |
openstackgerrit | zhaixiaojun proposed openstack/nova master: When the flavor id is invalid, the message does not match the regular expression, missing the numbers from 0-9. https://review.openstack.org/638150 | 08:49 |
*** pbing19 has joined #openstack-nova | 08:50 | |
*** ralonsoh has joined #openstack-nova | 08:51 | |
*** markvoelker has joined #openstack-nova | 08:52 | |
*** dtantsur|afk is now known as dtantsur\ | 08:53 | |
*** dtantsur\ is now known as dtantsur | 08:53 | |
*** wolverineav has quit IRC | 09:00 | |
*** ociuhandu has quit IRC | 09:04 | |
*** ccamacho has joined #openstack-nova | 09:09 | |
*** ccamacho has quit IRC | 09:10 | |
*** ccamacho has joined #openstack-nova | 09:11 | |
*** janki has joined #openstack-nova | 09:12 | |
*** yaawang has joined #openstack-nova | 09:15 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: FUP for Id7827fe8dc27112e342dc25c902c8dbc25f63b94 https://review.openstack.org/638370 | 09:22 |
*** ociuhandu has joined #openstack-nova | 09:24 | |
*** markvoelker has quit IRC | 09:25 | |
*** ociuhandu has quit IRC | 09:25 | |
*** ygk_12345 has joined #openstack-nova | 09:25 | |
*** ociuhandu has joined #openstack-nova | 09:26 | |
*** derekh has joined #openstack-nova | 09:31 | |
*** sapd1_x has joined #openstack-nova | 09:37 | |
gibi | efried, jaypipes: I've added a fup ^^ for https://review.openstack.org/#/c/616239 I think https://review.openstack.org/#/c/616239 only needs a +A now :) | 09:38 |
ygk_12345 | hi all | 09:39 |
ygk_12345 | i have a songle node packstack. but the hypervisor list is empty eventhough the nova-compute is up and running | 09:39 |
ygk_12345 | *single | 09:40 |
ygk_12345 | can someone help me please | 09:40 |
*** tssurya has quit IRC | 09:43 | |
*** bhagyashris has quit IRC | 09:46 | |
ygk_12345 | can someone help me please with my issue | 09:51 |
ygk_12345 | the hypervisor list is empty and also no entries in the compute_nodes tables in nova database | 09:51 |
*** awalende has quit IRC | 09:52 | |
bauzas | which release ? | 09:52 |
ygk_12345 | bauzas: latest one | 09:52 |
*** awalende has joined #openstack-nova | 09:52 | |
bauzas | Rocky ? | 09:52 |
bauzas | I thought packstack was no longer supported | 09:53 |
ygk_12345 | bauzas: how to check that info ? | 09:53 |
bauzas | it's more a classic #openstack usage question, tbh | 09:53 |
bauzas | but just look at the RDO packages | 09:53 |
bauzas | they have versions | 09:54 |
bauzas | and then look at the n-cpu logs | 09:54 |
*** panda|off is now known as panda | 09:54 | |
ygk_12345 | bauzas: where exactly n-cpu logs r located ? | 09:55 |
tosky | (packstack should still work, at least for rocky) | 09:56 |
ygk_12345 | bauzas: tosky yes it is rocky | 09:57 |
*** awalende has quit IRC | 09:57 | |
ygk_12345 | bauzas: tosky but the hypervisor list is empty. i cant understand why | 09:57 |
*** tssurya has joined #openstack-nova | 09:57 | |
*** wolverineav has joined #openstack-nova | 09:57 | |
*** jaosorior has joined #openstack-nova | 09:57 | |
bauzas | ygk_12345: I'm not a packstack expert, so I don't know where those are located | 09:58 |
bauzas | /var/log/nova ? | 09:58 |
tosky | my nova knowledge does not go too depth in that, but I would start with the usual debug operations: enable debug=True, check all the logs | 09:58 |
ygk_12345 | bauzas: i see this in nova-compute log | 09:58 |
*** awalende has joined #openstack-nova | 09:59 | |
ygk_12345 | bauzas: tosky ""Can\'t connect to MySQL server on \'10.129.146.156\' " | 09:59 |
ygk_12345 | bauzas: but the mysql is running fine on that node | 10:00 |
ygk_12345 | bauzas: i see this in the mariadb "ERROR] WSREP: rsync SST method requires wsrep_...tartup" | 10:01 |
bauzas | ygk_12345: I'm really sorry but this discussion is way not for this channel | 10:02 |
bauzas | see the channel topic | 10:02 |
ygk_12345 | bauzas: any appropriate IRC channel for thi ? | 10:02 |
bauzas | like said in the topic, general installation/configuration issues can be discussed in #openstack | 10:02 |
ygk_12345 | bauzas: ok thanks | 10:02 |
*** jangutter_ has joined #openstack-nova | 10:05 | |
*** jangutter has quit IRC | 10:06 | |
*** jangutter_ has quit IRC | 10:14 | |
*** zhubx has quit IRC | 10:14 | |
*** jangutter has joined #openstack-nova | 10:15 | |
*** zhubx has joined #openstack-nova | 10:15 | |
*** markvoelker has joined #openstack-nova | 10:17 | |
*** yaawang has quit IRC | 10:18 | |
*** zhubx007 has joined #openstack-nova | 10:20 | |
*** spsurya has quit IRC | 10:22 | |
*** jangutter has quit IRC | 10:22 | |
*** zhubx has quit IRC | 10:23 | |
*** cfriesen has quit IRC | 10:23 | |
*** jangutter has joined #openstack-nova | 10:25 | |
*** moshele has quit IRC | 10:27 | |
*** abhishekk has quit IRC | 10:28 | |
*** wolverineav has quit IRC | 10:30 | |
*** psachin has quit IRC | 10:38 | |
*** psachin has joined #openstack-nova | 10:42 | |
openstackgerrit | Merged openstack/os-traits master: Change python3.5 job to python3.7 job on Stein+ https://review.openstack.org/610065 | 10:43 |
*** stakeda has quit IRC | 10:49 | |
*** sapd1_x has quit IRC | 10:50 | |
*** jangutter has quit IRC | 10:51 | |
*** jaosorior has quit IRC | 10:55 | |
*** ygk_12345 has left #openstack-nova | 10:57 | |
*** yan0s has joined #openstack-nova | 11:02 | |
*** jangutter has joined #openstack-nova | 11:03 | |
*** lpetrut has joined #openstack-nova | 11:03 | |
*** moshele has joined #openstack-nova | 11:04 | |
*** tssurya has quit IRC | 11:05 | |
openstackgerrit | Stephen Finucane proposed openstack/os-vif master: Clean up versioned object backlevelling code https://review.openstack.org/630976 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/os-vif master: Add API docs for various VIF types https://review.openstack.org/637009 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/os-vif master: Add API docs for various profile, datapath offload types https://review.openstack.org/638395 | 11:07 |
*** erlon__ has joined #openstack-nova | 11:10 | |
*** ttsiouts has quit IRC | 11:13 | |
*** ttsiouts has joined #openstack-nova | 11:14 | |
*** cdent has joined #openstack-nova | 11:15 | |
*** mdbooth_ is now known as mdbooth | 11:15 | |
*** jaosorior has joined #openstack-nova | 11:15 | |
*** ttsiouts has quit IRC | 11:18 | |
*** jangutter_ has joined #openstack-nova | 11:21 | |
*** psachin has quit IRC | 11:22 | |
*** cdent has quit IRC | 11:23 | |
*** jangutter has quit IRC | 11:24 | |
*** udesale has quit IRC | 11:26 | |
*** wolverineav has joined #openstack-nova | 11:27 | |
*** awalende has quit IRC | 11:28 | |
*** awalende has joined #openstack-nova | 11:30 | |
*** moshele has quit IRC | 11:37 | |
*** moshele has joined #openstack-nova | 11:38 | |
mrch_ | is anybody using cloudbaseinit? | 11:39 |
*** ratailor has quit IRC | 11:42 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | 11:44 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239 | 11:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fill the RequestGroup mapping during schedule https://review.openstack.org/619528 | 11:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pass resource provider mapping to neutronv2 api https://review.openstack.org/616240 | 11:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule https://review.openstack.org/619529 | 11:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding https://review.openstack.org/569459 | 11:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317 | 11:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 11:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 11:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 11:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 11:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 11:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance to make place for port healing https://review.openstack.org/637953 | 11:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance (2) https://review.openstack.org/637954 | 11:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | 11:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: cache neutron ports in heal allocation https://review.openstack.org/638207 | 11:45 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: FUP for Id7827fe8dc27112e342dc25c902c8dbc25f63b94 https://review.openstack.org/638370 | 11:46 |
*** FlorianFa has joined #openstack-nova | 11:49 | |
*** s10 has joined #openstack-nova | 11:49 | |
*** FlorianFa has quit IRC | 11:51 | |
*** awalende has quit IRC | 11:52 | |
*** awalende has joined #openstack-nova | 11:52 | |
*** FlorianFa has joined #openstack-nova | 11:54 | |
*** FlorianFa has quit IRC | 11:56 | |
*** ttsiouts has joined #openstack-nova | 11:56 | |
*** FlorianFa has joined #openstack-nova | 11:56 | |
*** erlon__ has quit IRC | 11:57 | |
*** awalende has quit IRC | 11:57 | |
*** erlon__ has joined #openstack-nova | 11:59 | |
*** wolverineav has quit IRC | 12:00 | |
*** sdake has joined #openstack-nova | 12:02 | |
openstackgerrit | Stephen Finucane proposed openstack/os-vif master: docs: Add API docs for VIF types https://review.openstack.org/637009 | 12:04 |
openstackgerrit | Stephen Finucane proposed openstack/os-vif master: docs: Add API docs for profile, datapath offload types https://review.openstack.org/638395 | 12:05 |
openstackgerrit | Stephen Finucane proposed openstack/os-vif master: docs: Start using sphinx.ext.autodoc for VIF types https://review.openstack.org/638404 | 12:05 |
openstackgerrit | Stephen Finucane proposed openstack/os-vif master: doc: Use sphinx.ext.todo for profile, datapath offload types https://review.openstack.org/638405 | 12:05 |
openstackgerrit | Lajos Katona proposed openstack/python-novaclient master: Add support for microversion v2.70 https://review.openstack.org/637234 | 12:08 |
*** pbing19 has quit IRC | 12:10 | |
*** erlon_ has joined #openstack-nova | 12:13 | |
*** snevi has joined #openstack-nova | 12:14 | |
*** erlon__ has quit IRC | 12:17 | |
*** tssurya has joined #openstack-nova | 12:18 | |
*** edleafe has joined #openstack-nova | 12:30 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add function "has_table_columns" to OVSDB implementation API https://review.openstack.org/634967 | 12:44 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | 12:46 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add function "has_table_columns" to OVSDB implementation API https://review.openstack.org/634967 | 12:47 |
*** awalende has joined #openstack-nova | 12:50 | |
*** moshele has quit IRC | 12:52 | |
*** ygk_12345 has joined #openstack-nova | 12:52 | |
ygk_12345 | hi all | 12:53 |
ygk_12345 | can anyone help me with noav-compute in rocky packstack | 12:53 |
ygk_12345 | i tried there | 12:53 |
ygk_12345 | but no one coule help mw | 12:53 |
ygk_12345 | though this would be the right channel | 12:53 |
ygk_12345 | since u guys r familiar with nova | 12:53 |
ygk_12345 | the hypervisor list is empty eventhough the nova-compute is running | 12:53 |
ygk_12345 | cant understand why | 12:54 |
*** wolverineav has joined #openstack-nova | 12:58 | |
ygk_12345 | is anyone here can help me with nova-compute in rocky packstack ? | 13:01 |
sean-k-mooney | im not sure if this is related to missing cell mapping or not but | 13:02 |
sean-k-mooney | you could try nova-manage cell_v2 discover_hosts | 13:02 |
ygk_12345 | sean-k-mooney: i can see the cells though | 13:02 |
ygk_12345 | i did that | 13:02 |
ygk_12345 | but did not help | 13:02 |
ygk_12345 | sean-k-mooney: i see the host not found error in nova-compute logs | 13:02 |
ygk_12345 | but the host is resolvable though | 13:02 |
ygk_12345 | the host is centos 7 | 13:03 |
sean-k-mooney | is the nova compute serviec regestered in the nova_cell1 compute_nodes table | 13:03 |
sean-k-mooney | *compute agent | 13:03 |
ygk_12345 | sean-k-mooney: how to check that ? | 13:03 |
ygk_12345 | the compute_nodes table is empty in the nova database | 13:04 |
sean-k-mooney | mysql -e "select * from nova_cell1.compute_ndoes" | 13:04 |
sean-k-mooney | ok so the nova compute agent has not connected to the db | 13:05 |
sean-k-mooney | i assume it is also not listed in teh service table | 13:05 |
sean-k-mooney | mysql -e "select * from nova_cell1.services" | 13:05 |
jaypipes | gibi: off to the test pits it goes then. | 13:05 |
gibi | jaypipes: thanks a lot | 13:05 |
sean-k-mooney | ygk_12345: i would check the compute agent log and config but it likely is not connected to the cell db | 13:06 |
sean-k-mooney | actully wait | 13:06 |
jaypipes | gibi: nem probléma! | 13:06 |
gibi | jaypipes: :) | 13:06 |
sean-k-mooney | jaypipes: dose the compute agent connect to the cell db by defualt or acess it via the conductor? | 13:07 |
jaypipes | sean-k-mooney: the nova-compute does not connect to *any* DB directly. | 13:07 |
jaypipes | sean-k-mooney: placement via the REST API and Nova DB via the cell conductor. | 13:07 |
sean-k-mooney | right it connect via the conductor over the rpc bus right | 13:07 |
jaypipes | sean-k-mooney: well, OVO, but yes, same thing. :) | 13:07 |
ygk_12345 | sean-k-mooney: how to proceed now ? | 13:08 |
sean-k-mooney | ygk_12345: check the compute agent log and see if it is conected to the rabbitmq rpc bus | 13:08 |
ygk_12345 | sean-k-mooney: i think it is | 13:09 |
ygk_12345 | sean-k-mooney: i see this error in the log | 13:09 |
ygk_12345 | sean-k-mooney: "ERROR nova.compute.manager [req-427da537-366f-4442-b3be-6a8c71730c11 - - - - -] No compute node record for host TPC-G6-10" | 13:09 |
sean-k-mooney | ygk_12345: that is expected when the compute-agent start for the first time. it should then proceed to create it | 13:10 |
ygk_12345 | sean-k-mooney: but it is not creating and listing the hypervisor capabilities like ram, vcpus, disk etc | 13:10 |
ygk_12345 | sean-k-mooney: strange | 13:11 |
ygk_12345 | sean-k-mooney: i am scratching my head for hours now :) | 13:11 |
ygk_12345 | sean-k-mooney: i have a similar setup and it is aslo having the same issue | 13:11 |
sean-k-mooney | ygk_12345: i take it its a new deployment its posible the cell conductor is haveing issues. | 13:11 |
ygk_12345 | sean-k-mooney: its packstack rocky on centos 7 | 13:11 |
ygk_12345 | but jpena said it was working for him in the lab | 13:12 |
sean-k-mooney | well packstack isnt used that widely and i dont know how well it is tested upsteam that said im sure it likely something small | 13:12 |
ygk_12345 | sean-k-mooney: need help to find it out | 13:13 |
sean-k-mooney | well im not that familar with packstack. i have avoided for years after tyring it several times with little sucess. without nova compute agent and cell conductor logs to look at there is not much i can do to help | 13:15 |
*** cdent has joined #openstack-nova | 13:16 | |
*** keekz is now known as nicholas | 13:17 | |
*** markvoelker has quit IRC | 13:17 | |
jaypipes | FYI, all interested parties... I am not accepting any *new* reviews into my personal queue today. The only ones in my queue (in order) are cdent/efried's OVO List object patch, then jackding's patch series for bug 1659062, and then the remaining patches in gibi's bandwidth series. | 13:17 |
openstack | bug 1659062 in OpenStack Compute (nova) "Failed evacuations leave neutron ports on destination host" [Wishlist,In progress] https://launchpad.net/bugs/1659062 - Assigned to Jack Ding (jackding) | 13:18 |
ygk_12345 | sean-k-mooney: i cant see any errors in the conductor logs | 13:18 |
cdent | noted | 13:18 |
*** markvoelker has joined #openstack-nova | 13:18 | |
gibi | jaypipes: ack | 13:18 |
sean-k-mooney | jaypipes: ack | 13:18 |
s10 | Please review https://review.openstack.org/#/c/636678/ . We've faced this bug in Queens week ago, had to apply the patch. | 13:20 |
*** markvoelker has quit IRC | 13:22 | |
sean-k-mooney | lyarwood: do you have time to look at ^ . it looks like a strait forward backport | 13:22 |
lyarwood | sean-k-mooney: looking | 13:23 |
openstackgerrit | Merged openstack/nova master: Update nova docs front page for placement removal https://review.openstack.org/628183 | 13:23 |
*** sdake has quit IRC | 13:23 | |
openstackgerrit | Merged openstack/nova master: Remove placement from nova install docs https://review.openstack.org/628184 | 13:23 |
openstackgerrit | Merged openstack/nova master: Remove link to placement configuration from nova config docs https://review.openstack.org/628185 | 13:23 |
openstackgerrit | Merged openstack/nova master: Remove placement from contributor doc https://review.openstack.org/628186 | 13:24 |
*** sdake has joined #openstack-nova | 13:25 | |
*** jangutter_ is now known as jangutter | 13:26 | |
lyarwood | stephenfin: ^ isn't that slightly premature in S? | 13:27 |
lyarwood | if we aren't dropping the actual placement code from nova until T that is | 13:28 |
sean-k-mooney | well we cant add new patchs to that code so not really | 13:29 |
lyarwood | but users can still deploy it in S | 13:29 |
lyarwood | but now we've removed the docs | 13:29 |
sean-k-mooney | yes i broght that up a few weeks ago | 13:29 |
sean-k-mooney | but the feeling was we should not advocate deploying with in tree with stien | 13:30 |
*** wolverineav has quit IRC | 13:30 | |
*** tbachman has quit IRC | 13:30 | |
lyarwood | sean-k-mooney: kk | 13:30 |
sean-k-mooney | lyarwood: i had the same question when i first saw it proposed | 13:31 |
*** moshele has joined #openstack-nova | 13:34 | |
*** mriedem has joined #openstack-nova | 13:34 | |
*** avolkov has joined #openstack-nova | 13:36 | |
cdent | yeah, the idea was that new installs should use the new code | 13:36 |
cdent | upgrades, different story | 13:36 |
*** sdake has quit IRC | 13:36 | |
*** moshele has quit IRC | 13:37 | |
*** sdake has joined #openstack-nova | 13:37 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add microversion to expose virtual device tags https://review.openstack.org/631948 | 13:38 |
mriedem | takashin: i've reported bug 1817064 for novaclient - looks like novaclient.tests.functional.v2.test_instance_action.TestInstanceActionCLIV266.test_list_instance_action_with_changes_before still has race issues | 13:42 |
openstack | bug 1817064 in python-novaclient "test_list_instance_action_with_changes_before intermittently fails with "MismatchError: ['create'] != ['create', 'stop']"" [Undecided,New] https://launchpad.net/bugs/1817064 | 13:42 |
takashin | mriedem: Thank you. | 13:43 |
*** abhishekk has joined #openstack-nova | 13:48 | |
*** artom has quit IRC | 13:50 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add function "has_table_columns" to OVSDB implementation API https://review.openstack.org/634967 | 13:50 |
gibi | nova meeting starts in 5 minutes in #openstack-meeting | 13:56 |
*** lbragstad has joined #openstack-nova | 13:57 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | 14:06 |
kashyap | Huzzah, this merged: https://review.openstack.org/#/c/632507/ | 14:06 |
kashyap | Thanks for the reviews / time, folks. Now to clean up the rest of the cruft... | 14:07 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | 14:08 |
*** jaosorior has quit IRC | 14:08 | |
*** Kunpeng has joined #openstack-nova | 14:09 | |
sean-k-mooney | TIL print("...", file=some_file) is only suport in python3 ... | 14:10 |
sean-k-mooney | back to some_file.write() it is | 14:10 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add function "has_table_columns" to OVSDB implementation API https://review.openstack.org/634967 | 14:11 |
*** s10 has quit IRC | 14:12 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API https://review.openstack.org/482226 | 14:12 |
*** sdake has quit IRC | 14:14 | |
*** panda is now known as panda|ruck | 14:16 | |
*** markvoelker has joined #openstack-nova | 14:18 | |
*** udesale has joined #openstack-nova | 14:22 | |
jackding | takashin: mdbooth: Could you please revisit https://review.openstack.org/#/c/616692/? Thanks | 14:24 |
*** cfriesen has joined #openstack-nova | 14:24 | |
takashin | jackdin: Okay. I will check it later. | 14:25 |
*** eharney has joined #openstack-nova | 14:25 | |
takashin | jackding: Okay. I will check it later. | 14:25 |
*** wolverineav has joined #openstack-nova | 14:28 | |
jackding | mriedem: Could you please revisit https://review.openstack.org/#/c/620706/ and https://review.openstack.org/#/c/616692/? Thanks | 14:29 |
jackding | takashin: thanks | 14:30 |
*** jaosorior has joined #openstack-nova | 14:30 | |
*** imacdonn has quit IRC | 14:31 | |
*** sdake has joined #openstack-nova | 14:31 | |
*** ygk_12345 has quit IRC | 14:31 | |
*** Kunpeng has quit IRC | 14:32 | |
*** hongbin has joined #openstack-nova | 14:42 | |
*** hongbin has quit IRC | 14:42 | |
openstackgerrit | Merged openstack/os-vif master: Clean up versioned object backlevelling code https://review.openstack.org/630976 | 14:48 |
*** dave-mccowan has joined #openstack-nova | 14:48 | |
*** sdake has quit IRC | 14:51 | |
*** ttsiouts has quit IRC | 14:51 | |
*** ttsiouts has joined #openstack-nova | 14:52 | |
*** markvoelker has quit IRC | 14:53 | |
*** ttsiouts has quit IRC | 14:54 | |
*** ttsiouts has joined #openstack-nova | 14:54 | |
*** takashin has quit IRC | 15:00 | |
*** mvkr has quit IRC | 15:00 | |
*** hongbin has joined #openstack-nova | 15:00 | |
*** wolverineav has quit IRC | 15:01 | |
mdbooth | jackding: Done. Change looks good. I think there's some missing unit test coverage, though. | 15:02 |
*** sdake has joined #openstack-nova | 15:02 | |
*** takashin has joined #openstack-nova | 15:02 | |
mdbooth | jackding: Hopefully trivial to add. | 15:02 |
openstackgerrit | Surya Seetharaman proposed openstack/nova master: [Doc] Best practices for effectively tolerating down cells https://review.openstack.org/638173 | 15:03 |
*** tbachman has joined #openstack-nova | 15:03 | |
*** mlavalle has joined #openstack-nova | 15:06 | |
*** abhishekk has quit IRC | 15:07 | |
*** artom has joined #openstack-nova | 15:07 | |
*** takashin has left #openstack-nova | 15:07 | |
mriedem | dansmith: you want to get this rocky backport for that live migration volumes thing https://review.openstack.org/#/c/636895/ | 15:07 |
*** jaosorior has quit IRC | 15:08 | |
openstackgerrit | ya.wang proposed openstack/nova master: Select cpu model from a list of cpu models https://review.openstack.org/637834 | 15:08 |
*** awaugama has joined #openstack-nova | 15:12 | |
*** Luzi has quit IRC | 15:12 | |
*** awalende has quit IRC | 15:12 | |
*** awalende has joined #openstack-nova | 15:13 | |
openstackgerrit | sean mooney proposed openstack/os-vif master: remove brctl from vif_plug_ovs https://review.openstack.org/636821 | 15:16 |
openstackgerrit | sean mooney proposed openstack/os-vif master: remove use of brctl from vif_plug_linux_bridge https://review.openstack.org/636822 | 15:16 |
*** awalende_ has joined #openstack-nova | 15:17 | |
*** awalende_ has quit IRC | 15:17 | |
*** awalende has quit IRC | 15:17 | |
*** dave-mccowan has quit IRC | 15:21 | |
*** jistr is now known as jistr|afk | 15:22 | |
*** mvkr has joined #openstack-nova | 15:24 | |
*** artom has quit IRC | 15:31 | |
*** jistr|afk is now known as jistr | 15:32 | |
*** artom has joined #openstack-nova | 15:38 | |
*** dave-mccowan has joined #openstack-nova | 15:41 | |
mriedem | lyarwood: mgoddard: i know this backport has been hanging out awhile but i'm pretty uncomfortable with it https://review.openstack.org/#/c/608573/ | 15:42 |
mriedem | given the bug report and commit message says "since change in rocky" which was actually a change in stein | 15:42 |
*** liuyulong has quit IRC | 15:43 | |
*** liuyulong has joined #openstack-nova | 15:43 | |
mriedem | i guess this is an example of the warning http://logs.openstack.org/95/636895/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/c4e5305/controller/logs/screen-n-cpu.txt.gz#_Feb_15_14_25_05_143091 | 15:43 |
mgoddard | mriedem: the "since change in rocky" == https://review.openstack.org/#/c/565841/? It merged in August '18 | 15:44 |
*** dave-mccowan has quit IRC | 15:45 | |
mriedem | included in on that change says master | 15:45 |
mriedem | https://github.com/openstack/nova/commits/stable/rocky/nova/virt/ironic/driver.py | 15:46 |
mriedem | not in there | 15:46 |
*** jaosorior has joined #openstack-nova | 15:46 | |
mriedem | i remember us talking about merging that late in rocky but decided to defer to early stein | 15:47 |
mriedem | and it was merged right after the ptg as i recall | 15:47 |
mriedem | and proceeded to break tripleo | 15:47 |
*** jobewan has joined #openstack-nova | 15:47 | |
mriedem | because they were still using the scheduler filters that needed those inventory values | 15:47 |
*** sdake has quit IRC | 15:48 | |
mgoddard | ok, I agree it's not in stable/rocky | 15:48 |
mriedem | https://wiki.openstack.org/wiki/Nova/Rocky_Release_Schedule so that was merged probably right after rc1 | 15:48 |
mriedem | when we cut stable/rocky | 15:48 |
*** markvoelker has joined #openstack-nova | 15:50 | |
*** sdake has joined #openstack-nova | 15:50 | |
openstackgerrit | Pierre Riteau proposed openstack/nova master: Fix a typo in configuration description https://review.openstack.org/638445 | 15:51 |
mgoddard | ok, let's abandon it then. the backport was based on the assumption that that change was in rocky | 15:51 |
mriedem | god this whole transition has been a mess | 15:51 |
mgoddard | yup | 15:51 |
mriedem | mgoddard: i left a comment, but if we do have the warnings, | 15:51 |
mriedem | i think they have to be conditional based on the https://docs.openstack.org/nova/rocky/configuration/config.html#workarounds.report_ironic_standard_resource_class_inventory option in rocky | 15:51 |
mriedem | because if that's true, the warnings are legit | 15:51 |
mgoddard | that's another option | 15:51 |
mriedem | if false, then we can avoid the warnings | 15:51 |
*** mrch_ has quit IRC | 15:51 | |
mriedem | if that option is false we're not reporting standard resoruce class inventory anyway so we don't need to warn about 0 values | 15:52 |
mgoddard | that seems reasonable. I'll update it to check that flag | 15:52 |
*** janki has quit IRC | 15:53 | |
mriedem | the commit message is going to need some updating | 15:53 |
mriedem | to sort out the confusion | 15:53 |
*** tosky has quit IRC | 15:53 | |
mgoddard | sure | 15:53 |
mgoddard | thanks for following up | 15:54 |
*** tosky has joined #openstack-nova | 15:54 | |
mgoddard | actually, hold up | 15:55 |
mgoddard | "They were not required to be set since the Pike release, but still this | 15:55 |
mgoddard | warning is emitted. | 15:55 |
mgoddard | that's why I marked it as backport potential for pike - rocky | 15:56 |
mgoddard | so since pike, it's valid not to set them, but if you don't then you get a warning | 15:56 |
mgoddard | it doesn't matter what is reported to placement, this is about the ironic node config | 15:58 |
mriedem | ok i see https://review.openstack.org/#/c/608573/3/nova/virt/ironic/driver.py@815 | 15:58 |
mriedem | so if the values are 0 we won't report those resource classes for inventory | 15:58 |
*** wolverineav has joined #openstack-nova | 15:58 | |
mriedem | i guess https://docs.openstack.org/ironic/rocky/install/configure-nova-flavors.html doesn't mention anything about 0ing out the node property values, | 16:00 |
mriedem | is that in the ironic docs somewhere? | 16:00 |
bauzas | gibi: I'm just starting to sharpen my pen for reviewing network-bw-providers | 16:01 |
bauzas | gibi: did the implementation diverged from the spec https://specs.openstack.org/openstack/nova-specs/specs/stein/approved/bandwidth-resource-provider.html ? | 16:01 |
*** ttsiouts has quit IRC | 16:01 | |
bauzas | gibi: that helps me catching up quickier | 16:01 |
gibi | bauzas: the name of the resource classes got shorter, and there are extra object model addition that was not covered by the spec | 16:02 |
*** ttsiouts has joined #openstack-nova | 16:02 | |
mriedem | and the microversion... | 16:02 |
gibi | bauzas: but I think the basic logic and goal did not changef | 16:02 |
gibi | mriedem: ++ | 16:02 |
bauzas | gibi: okay, gtk | 16:02 |
bauzas | mriedem: a new API microversion ? | 16:03 |
bauzas | if so, I'll be able to get it | 16:03 |
gibi | bauzas: yes a new microversion to enable the feature for server create/delete | 16:03 |
bauzas | gotcha | 16:04 |
*** moshele has joined #openstack-nova | 16:04 | |
mgoddard | mriedem: let me check the docs | 16:04 |
*** jobewan has quit IRC | 16:05 | |
mriedem | i guess i just don't know how those values are zeroed out - the node API? something in ironic-inspector? | 16:05 |
*** ttsiouts has quit IRC | 16:06 | |
*** alex_xu has quit IRC | 16:07 | |
mgoddard | mriedem: the node 'properties' field is just a dict, it defaults to being empty | 16:08 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Don't emit warning when ironic properties are zero https://review.openstack.org/608573 | 16:09 |
mriedem | mgoddard: https://review.openstack.org/#/c/608573/3..4//COMMIT_MSG | 16:09 |
mgoddard | mriedem: I can't find anything that explicitly says not to set those properties, but that is what we test in devstack: https://github.com/openstack/ironic/blob/master/devstack/lib/ironic | 16:09 |
mgoddard | mriedem: search --property | 16:09 |
mgoddard | mriedem: nice, thanks for updating | 16:10 |
mriedem | i only see https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L2082 but that's something else | 16:10 |
mriedem | that's the flavor not the node | 16:10 |
mgoddard | L1996 is node creation | 16:11 |
openstackgerrit | Merged openstack/python-novaclient master: Make Server.networks use a predictable sort order https://review.openstack.org/638214 | 16:11 |
openstackgerrit | Merged openstack/python-novaclient master: API microversion 2.69: Handles Down Cells https://review.openstack.org/579563 | 16:11 |
mgoddard | only property is cpu_arch, and possibly root_device | 16:11 |
*** udesale has quit IRC | 16:11 | |
mriedem | ok and we don't get a KeyError because of https://review.openstack.org/#/c/608573/4/nova/virt/ironic/driver.py@245 | 16:12 |
*** moshele has quit IRC | 16:12 | |
mgoddard | right | 16:12 |
mriedem | so we'll warn there too :) | 16:13 |
*** alex_xu has joined #openstack-nova | 16:13 | |
mriedem | oh wait | 16:13 |
mriedem | nevermind we default to - | 16:13 |
mriedem | *0 | 16:13 |
mgoddard | yeah | 16:13 |
mriedem | ok approved | 16:14 |
*** artom has quit IRC | 16:14 | |
mriedem | please re-do the queens backport using the updated stable/rocky change | 16:14 |
mgoddard | great, thanks. will do | 16:15 |
mriedem | sorry for the trouble. i had put off sorting this one out for weeks. | 16:15 |
*** hamzy has quit IRC | 16:15 | |
mgoddard | no problem, I know the kind of task :) | 16:16 |
tbachman | z;. ¸d fgi`q1e | 16:16 |
tbachman | 16:16 | |
*** markvoelker has quit IRC | 16:23 | |
*** macza has joined #openstack-nova | 16:24 | |
*** tbachman has quit IRC | 16:25 | |
melwitt | o/ | 16:27 |
mriedem | cdent: efried: i'm kind of at a loss as to what to do about this stable/rocky nova backport which is a fix from extracted placement in stein https://review.openstack.org/#/c/608903/ | 16:28 |
*** pbing19 has joined #openstack-nova | 16:28 | |
mriedem | as far as i know, nothing is "using" nested providers in rocky - i know nova isn't, but i'm not aware of anything else either | 16:28 |
mriedem | so i'm leaning to not backport this if we don't need it | 16:28 |
cdent | mriedem: my inclication would be to wait until somebody asks | 16:28 |
mriedem | same | 16:28 |
mriedem | i think in that case i'm going to abandon | 16:29 |
mriedem | with all due respect to mr nakamura | 16:29 |
cdent | all respect is due mr nakamura | 16:30 |
*** wolverineav has quit IRC | 16:31 | |
*** imacdonn has joined #openstack-nova | 16:38 | |
*** jobewan has joined #openstack-nova | 16:39 | |
*** hamzy has joined #openstack-nova | 16:40 | |
*** zhubx007 has quit IRC | 16:40 | |
*** zhubx007 has joined #openstack-nova | 16:41 | |
*** lpetrut has quit IRC | 16:46 | |
openstackgerrit | Mark Goddard proposed openstack/nova stable/queens: Don't emit warning when ironic properties are zero https://review.openstack.org/608611 | 16:47 |
*** gyee has joined #openstack-nova | 16:48 | |
*** lpetrut has joined #openstack-nova | 16:49 | |
mriedem | dansmith: can you send this queens backport to its maker https://review.openstack.org/#/c/623547/ | 16:59 |
*** tbachman has joined #openstack-nova | 16:59 | |
dansmith | aye | 16:59 |
*** wwriverrat has quit IRC | 17:03 | |
*** _fragatina has joined #openstack-nova | 17:03 | |
*** pcaruana has quit IRC | 17:07 | |
*** tssurya has quit IRC | 17:08 | |
*** _fragatina has quit IRC | 17:09 | |
*** _fragatina has joined #openstack-nova | 17:09 | |
*** helenafm has quit IRC | 17:10 | |
*** erlon_ has quit IRC | 17:14 | |
ralonsoh | jaypipes, sean-k-mooney : so what's the plan here https://review.openstack.org/#/c/482226/48/vif_plug_ovs/tests/functional/base.py? To import from os-vif.tests.[functional|unit].base in the other projects. Am I right? | 17:16 |
*** sridharg has quit IRC | 17:17 | |
sean-k-mooney | i think for this patch yes. i want do refactor some of the code in general in train | 17:17 |
sean-k-mooney | deduping that file would be on that list | 17:17 |
sean-k-mooney | ill try and do a review of all the open os-vif patches again today/tommorow | 17:18 |
sean-k-mooney | ideally we can then to a relase on monday | 17:18 |
ralonsoh | sean-k-mooney, ok, I'll submit a patch to move functional.base to os-vif, and import from there | 17:19 |
sean-k-mooney | jaypipes: does that sound ok to you? | 17:19 |
sean-k-mooney | ralonsoh: i dont think we need to do that in stien | 17:19 |
sean-k-mooney | it can wait till after we do the release. | 17:19 |
ralonsoh | sean-k-mooney, perfect | 17:20 |
*** markvoelker has joined #openstack-nova | 17:20 | |
sean-k-mooney | ill send a ml post tomorrow with the patches i would like to see in the final release for stien so i would more or less like to avoid more churn | 17:21 |
*** yan0s has quit IRC | 17:23 | |
mriedem | dansmith: let me know when you're tired of stable pings but https://review.openstack.org/#/c/635072/ also | 17:26 |
mriedem | i'll shift to bugging others | 17:26 |
*** wolverineav has joined #openstack-nova | 17:26 | |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for cyborg access https://review.openstack.org/631242 | 17:28 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to spec obj. https://review.openstack.org/631243 | 17:28 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.openstack.org/631244 | 17:28 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.openstack.org/631245 | 17:28 |
dansmith | makes me feel useful and like a slacker all at once | 17:28 |
*** dtantsur is now known as dtantsur|afk | 17:29 | |
sean-k-mooney | stephenfin: i like the direction of your sphinx docs changes in os-vif | 17:30 |
sean-k-mooney | stephenfin: ill try and review them tomorrow | 17:30 |
stephenfin | sean-k-mooney: Ta. Just need to fix the pep8 issue | 17:30 |
sean-k-mooney | quick question https://review.openstack.org/#/c/638053/2/tox.ini | 17:31 |
sean-k-mooney | do we still need to specify the interperter version or will python3 work instead of python3.6 | 17:31 |
sean-k-mooney | i think python3 should work but i know not show why we set 2.7 explctily before | 17:33 |
sean-k-mooney | stephenfin: oh ^ was for you | 17:34 |
*** erlon_ has joined #openstack-nova | 17:35 | |
sean-k-mooney | i might jsut drop the change in version and add a sperate python3 functional env instead | 17:35 |
stephenfin | sean-k-mooney: The precedence for Python version is (a) specific environment 'basepython' version, (b) global 'basepython' value, (c) implicit value from a testenv factor (i.e. 'py27'), (d) system Python | 17:36 |
*** ccamacho has quit IRC | 17:36 | |
sean-k-mooney | stephenfin: right but the function job failed because 3.6 was not on the host it ran on so im wondering can i just set python3 and use whatever version of python 3 is available | 17:37 |
stephenfin | sean-k-mooney: Actually, that was the way that it was before tox 3.1. Since then, (b) and (c) are switched and you'll get a warning if they conflict | 17:37 |
stephenfin | sean-k-mooney: Ahh | 17:37 |
stephenfin | sean-k-mooney: Yeah, then yeah, 'python3' is good | 17:38 |
stephenfin | *Yeah, then 'python3' is good | 17:38 |
sean-k-mooney | ok thanks ill repspin with that :) | 17:39 |
stephenfin | (It'll run whatever python3 is symlinked to on the distro) | 17:39 |
sean-k-mooney | would you prefer if i had two envs or one | 17:39 |
*** artom has joined #openstack-nova | 17:39 | |
sean-k-mooney | e.g. should i keep a functionl 2.7 env and add a functional-py3 env | 17:39 |
jaypipes | ralonsoh: ++ what sean-k-mooney said. | 17:40 |
stephenfin | sean-k-mooney: I'm happy to drop py2.7 functional tests if we still have unit tests. mriedem might have something to say as well, since he's done some work here lately, I think | 17:40 |
sean-k-mooney | actully i should check the pti docs and see what it say we should do for stien | 17:40 |
stephenfin | s/drop py2.7/switch from py2.7 to py3/ | 17:40 |
*** moshele has joined #openstack-nova | 17:41 | |
bauzas | melwitt: hum, I guess we probably have to work on https://etherpad.openstack.org/p/nova-tc-vision-self-eval | 17:42 |
* bauzas tries to do his homework | 17:42 | |
melwitt | yes. I've done nothing yet :( not a great timing for this one, near the end of the cycle | 17:42 |
sean-k-mooney | stephenfin: hehe i mean i would like to drop py2.7 but we cant do that until U | 17:43 |
bauzas | I can try to think a bit about it | 17:43 |
*** zzzeek has quit IRC | 17:44 | |
melwitt | mriedem: thanks for making the forum brainstorm etherpad | 17:44 |
sean-k-mooney | ralonsoh: by the way i have to check your patch but if its ok with you i would prefer to default to useing the ovs-vsctl client instead of the native client for stien since we wont really have time to let it bake in the ci and see if it has issue before monday | 17:44 |
melwitt | bauzas: thanks | 17:44 |
bauzas | I guess I'll be challenged on that anyway... | 17:44 |
sean-k-mooney | ralonsoh: we can swap the default in train and or remvoe the cli client after the m1 release | 17:45 |
ralonsoh | sean-k-mooney, yes, let's see first if the native implementation works, then we can remove the CLI one | 17:46 |
*** moshele has quit IRC | 17:47 | |
mriedem | stephenfin: on which repo? os-vif? | 17:47 |
stephenfin | mriedem: yup | 17:48 |
*** ociuhandu has quit IRC | 17:48 | |
mriedem | i assume that job is pretty fast isn't ? | 17:48 |
*** panda|ruck is now known as panda|ruck|off | 17:48 | |
sean-k-mooney | yes it is | 17:48 |
*** wolverineav has quit IRC | 17:48 | |
mriedem | then might as well leave it another cycle | 17:48 |
mriedem | drop in U | 17:48 |
*** zzzeek has joined #openstack-nova | 17:49 | |
*** ociuhandu has joined #openstack-nova | 17:50 | |
sean-k-mooney | ok ill just add a new fucntional-py3 env then. im trying to move my dev envs over to python3 by default but there is no harm keeping the py27 one as well | 17:50 |
mriedem | fwiw functional-py27 caught an issue in one of my cross-cell changes that passed on the py35 job | 17:52 |
mriedem | something deep down in the db api layer | 17:52 |
*** markvoelker has quit IRC | 17:53 | |
*** ociuhandu has quit IRC | 17:54 | |
*** lpetrut has quit IRC | 17:54 | |
sean-k-mooney | mriedem: i generally run both locally but there is no py3 fucntionl env currently so to run them on python3 i was locally hacking the file. | 17:54 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for cyborg access https://review.openstack.org/631242 | 18:02 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to request spec. https://review.openstack.org/631243 | 18:02 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.openstack.org/631244 | 18:02 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.openstack.org/631245 | 18:02 |
openstackgerrit | Adam Spiers proposed openstack/nova master: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | 18:03 |
*** sdake has quit IRC | 18:05 | |
*** sdake has joined #openstack-nova | 18:06 | |
mriedem | alright stable cores, several +2ed changes on stable/queens ready for review https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/queens+label:Code-Review=2 | 18:06 |
*** wolverineav has joined #openstack-nova | 18:06 | |
*** igordc has joined #openstack-nova | 18:09 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Correct examples in "Manage Compute services" documentation https://review.openstack.org/638475 | 18:10 |
*** mvkr has quit IRC | 18:12 | |
*** wwriverrat has joined #openstack-nova | 18:26 | |
*** mdbooth_ has joined #openstack-nova | 18:30 | |
*** mdbooth has quit IRC | 18:34 | |
*** moshele has joined #openstack-nova | 18:36 | |
*** moshele has quit IRC | 18:39 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: [pike-only] Fix resize_instance rpcapi call https://review.openstack.org/603439 | 18:42 |
*** markvoelker has joined #openstack-nova | 18:50 | |
*** snevi has quit IRC | 18:51 | |
melwitt | mriedem: fyi, initial implementation for counting quota usage is done. working on organizing the patches better and adding test coverage now | 18:52 |
*** wolverineav has quit IRC | 18:54 | |
*** mrch_ has joined #openstack-nova | 18:55 | |
*** ralonsoh has quit IRC | 18:56 | |
*** gbarros has quit IRC | 18:57 | |
*** mvkr has joined #openstack-nova | 18:59 | |
*** mrjk_ has quit IRC | 19:00 | |
*** moshele has joined #openstack-nova | 19:02 | |
*** mrjk has joined #openstack-nova | 19:02 | |
*** liuyulong has quit IRC | 19:13 | |
*** manjeets has quit IRC | 19:14 | |
*** manjeets has joined #openstack-nova | 19:14 | |
*** erlon_ has quit IRC | 19:15 | |
*** erlon_ has joined #openstack-nova | 19:17 | |
*** wolverineav has joined #openstack-nova | 19:18 | |
openstackgerrit | Merged openstack/nova master: Calculate RequestGroup resource provider mapping https://review.openstack.org/616239 | 19:18 |
openstackgerrit | Merged openstack/nova stable/rocky: Fix a missing policy in test policy data https://review.openstack.org/637085 | 19:18 |
*** wolverineav has quit IRC | 19:19 | |
*** markvoelker has quit IRC | 19:23 | |
*** wolverineav has joined #openstack-nova | 19:28 | |
*** yankcrime has joined #openstack-nova | 19:30 | |
*** moshele has quit IRC | 19:31 | |
openstackgerrit | Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.openstack.org/633855 | 19:31 |
*** ccamacho has joined #openstack-nova | 19:31 | |
*** s10 has joined #openstack-nova | 19:36 | |
mriedem | melwitt: ok | 19:39 |
artom | Wait, does the API handle the possibility of NoValidHost when live migrating? | 19:50 |
mriedem | artom: depends on microversion | 19:51 |
mriedem | v2.1 is an rpc call from the api to conductor to scheduler which can be a NoValidHost | 19:52 |
mriedem | i think it was 2.32 i want to say that changed that to a cast | 19:52 |
mriedem | from api to conductor | 19:52 |
mriedem | 2.34 https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id31 | 19:53 |
artom | mriedem, hrmm, but pre-2.34 it should still return a 400, not 500 | 19:53 |
artom | Which is what I'm seeing in my func tests | 19:54 |
artom | So I'm doing something wrong then, it seems | 19:54 |
artom | Which is weird, because I'm definitely catching the "new" ComputeResourcesUnavailable from the claims, and re-raising it as a MigrationPreCheckError | 19:56 |
artom | Which the conductor *catches* | 19:56 |
artom | Or should, according to the code | 19:56 |
mriedem | is your test using the CastAsCall fixture? | 19:56 |
artom | Huh, do func tests use it by default? | 19:57 |
mriedem | no, but you might be extending a class that uses it | 19:58 |
artom | Ah, yeah, _IntegratedTestBase | 19:58 |
artom | Oh, that would be why the NoValidHost ends up in the API | 19:58 |
artom | Heh, can I "unuse" a single fixture? | 19:59 |
*** wolverineav has quit IRC | 20:01 | |
*** whoami-rajat has quit IRC | 20:02 | |
artom | No, there's something else. | 20:14 |
artom | It dies on the select_destinations call (which is always a call) in _find_destinations in the live migrate task | 20:15 |
artom | I... I think this exists in master as well. | 20:16 |
*** _fragatina has quit IRC | 20:20 | |
*** markvoelker has joined #openstack-nova | 20:21 | |
*** erlon__ has joined #openstack-nova | 20:26 | |
*** erlon_ has quit IRC | 20:29 | |
mriedem | jaypipes: so i'm not sure if my comments in here warrant a -1 or if it's just follow up fodder https://review.openstack.org/#/c/619528/ | 20:30 |
*** awaugama has quit IRC | 20:30 | |
mriedem | but there are some serious performance impacts there if you're doing multi-create and not actually doing fancy port bw scheduling | 20:30 |
*** awalende has joined #openstack-nova | 20:31 | |
artom | Hrmm, or not. | 20:32 |
jaypipes | mriedem: multi-create meaning multiple instances in the same request, yeah? | 20:32 |
mriedem | yeah | 20:33 |
jaypipes | mriedem: mayhaps. | 20:33 |
mriedem | but this is even heavy for a single instance | 20:33 |
mriedem | post-scheduler, call placement to get allocations and traits for each provider in those allocations | 20:33 |
mriedem | for an instance that might not even have one of these fancy ports | 20:33 |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: De-shim PlacementFixture https://review.openstack.org/637959 | 20:33 |
*** wolverineav has joined #openstack-nova | 20:33 | |
*** awalende has quit IRC | 20:36 | |
*** spatel has joined #openstack-nova | 20:37 | |
*** cdent has quit IRC | 20:38 | |
*** wolverineav has quit IRC | 20:38 | |
jaypipes | mriedem: which is kinda what I said in the original review.. | 20:39 |
jaypipes | mriedem: but the alternative is to unpack the JSON in the Selection.allocation_request field blobified goop. | 20:39 |
mriedem | that won't work, | 20:40 |
mriedem | oh wait | 20:40 |
mriedem | maybe it will because that has the resource provider uuid in it right? | 20:40 |
mriedem | it's just a json version of https://developer.openstack.org/api-ref/placement/#update-allocations | 20:41 |
mriedem | yeah dude that's way faster than hitting placement for each instance | 20:41 |
mriedem | well, *should be* faster | 20:41 |
mriedem | that's also potentially the same Selection object (allocation_request) for multiple servers in the same build operation | 20:44 |
mriedem | so deserialize once rather than GET /allocations/{consumer_id} x number of instances | 20:45 |
*** macza has quit IRC | 20:45 | |
*** macza has joined #openstack-nova | 20:45 | |
jaypipes | mriedem: ack. | 20:47 |
mriedem | we can follow up also and avoid that GET /resource_provider/{rp_id}/traits call yeah? by stashing the GET /a_c provider_summaries traits per provider on the Selection object we return from the scheduler | 20:48 |
jaypipes | mriedem: which violates our original intention that the allocation_request would be a BLOBby thing that could be sent as-is as the request payload to placement on the event of a reschedule/retry operation] | 20:48 |
*** _pewp_ has quit IRC | 20:48 | |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: De-shim PlacementFixture https://review.openstack.org/637959 | 20:48 |
jaypipes | mriedem: but as you say, it's considerably faster than re-querying placement for each instance | 20:48 |
*** _pewp_ has joined #openstack-nova | 20:48 | |
mriedem | i'm not sure how it violates that | 20:48 |
mriedem | for the first selection in the list, it's allocatoin request has already been 'consumed' | 20:49 |
jaypipes | mriedem: well, it violates the principle that the allocation_request's structure could change and nothing in nova would need to be changed. | 20:49 |
jaypipes | mriedem: yes, understood. | 20:49 |
jaypipes | again, this was the original thought... things have changed/softened in our thinking since then | 20:49 |
jaypipes | :) | 20:49 |
mriedem | i'm not sure what you're saying :) | 20:49 |
mriedem | it's still a string on the selection object, in this code we just deserialize that field to get the rp uuids | 20:50 |
mriedem | well, the actual allocations i guess | 20:50 |
jaypipes | it's not just the rp uuids. | 20:50 |
jaypipes | yeah, it's all the allocation info | 20:50 |
mriedem | i guess what you're saying is we'd be treating the allocatoin request like a response | 20:50 |
mriedem | when it's not | 20:50 |
jaypipes | and of course, if we change the structure of the allocation_request response, boom, that "deserialize this blob and inspect it" code would of course need to change | 20:51 |
jaypipes | mriedem: yes. | 20:51 |
jaypipes | mriedem: I'm just trying to give you some background on why that's a JSON string and not an object :) | 20:51 |
mriedem | yeah i remember | 20:51 |
mriedem | and why we also provider the version | 20:52 |
jaypipes | ok, I will go away now | 20:52 |
mriedem | *provide | 20:52 |
mriedem | don't go away jay | 20:52 |
mriedem | please stay | 20:52 |
jaypipes | :P | 20:52 |
openstackgerrit | Merged openstack/nova stable/queens: Fix a missing policy in test policy data https://review.openstack.org/637112 | 20:52 |
openstackgerrit | Merged openstack/nova stable/rocky: tox: Don't write byte code (maybe) https://review.openstack.org/636917 | 20:52 |
mriedem | so maybe what i'll do is pull this down, put in the very easy "if the request spec doesn't have requested_resources, don't do anything with this new code" thing, leave a bunch of todos for gibi to follow up | 20:55 |
mriedem | that solves 99% of my performance worry | 20:55 |
*** markvoelker has quit IRC | 20:55 | |
mriedem | jaypipes: ^ how do you like that? | 20:55 |
efried | mriedem: That sounds like a pretty reasonable solution to me. And you would be doing it rather than letting gibi do it because... you want to get it merged today? | 20:57 |
mriedem | yes | 20:57 |
mriedem | time is as they say of the essence | 20:57 |
jaypipes | mriedem: ✔ | 20:57 |
* mriedem puts on his coding pants | 20:57 | |
efried | makes me a little nervous for the author of the patch not to have a nod on a change of that magnitude, logic-wise. | 20:58 |
efried | I guess worst case it can be reverted | 20:58 |
efried | but then again why couldn't it be done in a fup anyway? | 20:58 |
mriedem | i can be, but i just really don't want to get close to freeze with this like it is | 21:00 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Remove _legacy_dict methods https://review.openstack.org/636210 | 21:00 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add migration param to check_can_live_migrate_destination https://review.openstack.org/634605 | 21:00 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | 21:00 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Use live_migration_claim() to check dest resources https://review.openstack.org/634606 | 21:00 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects to transmit NUMA config from dest to source https://review.openstack.org/634827 | 21:00 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: Make dest send NUMAMigrateData to the source https://review.openstack.org/634828 | 21:00 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: update NUMA-related XML on the source https://review.openstack.org/635229 | 21:00 |
mriedem | btw the change i'm talking about is 1 line | 21:00 |
mriedem | do this https://review.openstack.org/#/c/616239/33/nova/objects/request_spec.py@781 | 21:01 |
mriedem | at the beginning of https://review.openstack.org/#/c/619528/27/nova/conductor/manager.py@1248 | 21:01 |
artom | efried, mriedem, hey, so I know it's late in the cycle, and I'd be trampling all over the runways process, but what are the chances of pushing for reviews/merge of ^^ before FF? | 21:02 |
jaypipes | mriedem: that is 2 lines Matt. Un. Friggin. Acceptable. | 21:02 |
mriedem | artom: there are more cores here than me | 21:02 |
mriedem | artom: at this point i'm pushing to get the bw provider stuff in before FF | 21:03 |
artom | mriedem, I know. You reviewed the spec is why. But I get that you're oversubscribed as is. | 21:03 |
sean-k-mooney | jaypipes: he did say about 1 line :P | 21:03 |
*** erlon__ has quit IRC | 21:04 | |
artom | Which is why I mentioned efried :) Intel are apparently keep on it. | 21:04 |
mriedem | artom: what's the test story on that series? is https://review.openstack.org/#/c/634606/24/nova/tests/functional/compute/test_live_migration.py the most functional we have? | 21:04 |
artom | mriedem, in-tree, yeah | 21:05 |
artom | I wrote https://review.rdoproject.org/r/#/c/18832/ that I've been using in my devstack | 21:05 |
efried | artom: I have been requested both internally and externally to have a look at that. Unfortunately, it's behind a number of other things, as well as requiring quite a bit of homework on my part just to grok the background. I think alex_xu is involved though, right? | 21:05 |
jaypipes | sean-k-mooney: :P | 21:05 |
artom | efried, not really, you're our only hope (Obi Wan) | 21:05 |
* mriedem looks at https://review.openstack.org/#/admin/groups/25,members | 21:06 | |
* efried filters by cores who can spell NUMA | 21:06 | |
*** wolverineav has joined #openstack-nova | 21:06 | |
artom | So, it's easy for me to get stephenfin to look at it, being the same company and all | 21:06 |
sean-k-mooney | artom: the code freeze is still a few weeks away. we shoudl be able to get to it once bw feature is in | 21:06 |
artom | It's the other non-RH core that's the problem | 21:07 |
mriedem | i also have like a 50 change series of my own | 21:07 |
artom | ... and who groks NUMA? jaypipes I guess? But you're as oversubscribed as mriedem. | 21:07 |
mriedem | i definitely know how the live migration flow in compute manager and claims shit works, so i should look at it | 21:08 |
mriedem | but god | 21:08 |
artom | To be fair, there's very little actual NUMA, bizarely | 21:08 |
artom | In the sense that it uses a lot of existing code | 21:08 |
artom | So if you assume those bits works, it's just about the glue | 21:08 |
sean-k-mooney | artom: that because your useing the existing code to calulate the topology on the destination then just sending it back to the source and updating the xml | 21:09 |
artom | Yep, what sean-k-mooney said | 21:09 |
mriedem | if it's ready for review just put it in runways | 21:09 |
sean-k-mooney | so most of that code is common | 21:09 |
mriedem | you can have other RH cores review it and do the honorable and not +W | 21:09 |
mriedem | like dansmith and melwitt | 21:09 |
*** wolverineav has quit IRC | 21:09 | |
*** wolverineav has joined #openstack-nova | 21:10 | |
artom | mriedem, yep :) | 21:10 |
artom | Was trying to gauge interest/chances. So not a slam dunk, to put it mildly ;) | 21:10 |
* artom shall continue doing the Needful, as per the Process. | 21:10 | |
artom | ;) | 21:10 |
mriedem | sorry | 21:11 |
*** rcernin has joined #openstack-nova | 21:11 | |
mriedem | i'll get to what i can when i can | 21:11 |
melwitt | yes, I should help review that. currently toiling on my own patch series for counting quota usage from placement | 21:11 |
artom | mriedem, heh, no need to apologise :) | 21:11 |
sean-k-mooney | artom: has cfriesen reviewed the code by the way. he will be interested in it. im setting up at test env currently and will fully re review it proably early next week | 21:12 |
artom | sean-k-mooney, I poked him a while ago, when it was still all WIP | 21:13 |
cfriesen | I'm totally swamped with a downstream cust issue | 21:13 |
artom | Let's consider him poked a second time | 21:13 |
mriedem | efried: ok you and my anxiety over ^ has made me approve https://review.openstack.org/#/c/619528/ | 21:13 |
mriedem | i trust gibi to do me right | 21:14 |
sean-k-mooney | cfriesen: no worries | 21:14 |
efried | mriedem: ack. I think it's the right thing. If you propose the fup and have gibi +2 it, that would be swimming. | 21:15 |
artom | (We're doing a retro at PTG, right? We could talk about better planning - it feels like we all have our pet series, plus the cores have an "obligation" to review other stuff) | 21:16 |
mriedem | artom: remember how many times throughout the release i asked you and stephenfin how that series was coming since no patches were posted, even WIP? | 21:16 |
efried | artom: add retrospective section with that line to https://etherpad.openstack.org/p/nova-ptg-train | 21:16 |
artom | mriedem, oh, I'm fully acknowledging my responsibility in this being massively late | 21:17 |
melwitt | yes, we do a retro each ptg and yep, just add info there. we usually have a separate etherpad we link to from the ptg pad, since the ptg pad ends up being ginormous | 21:17 |
mriedem | ok :) | 21:17 |
artom | I understand that I can't rock up and be like "y'all got 2 weeks to merge my shit" | 21:17 |
artom | But... it doesn't mean I'll stay silent and not push for it :) | 21:19 |
artom | That being said, if it doesn't merge I'll only have myself to blame | 21:19 |
*** macza has quit IRC | 21:19 | |
*** spatel has quit IRC | 21:20 | |
sean-k-mooney | artom: by the way ill need to test this on my hadware setup. ubuntu crashes the l2 guest with nested virt. on centos booting the l2 guest crashes the l1 guest kernel... so i think i need to do a bios/micorcode upgrade before i can do nested ver on my new server :( | 21:20 |
artom | sean-k-mooney, devstack on fedora 29 works great for me | 21:20 |
sean-k-mooney | i might test it on my laptop actully nested virt works fine there | 21:21 |
melwitt | artom: yeah, I think we (or at least I) am just wondering what you mean by "better planning" in this case. not that you're trying to get review lately | 21:21 |
sean-k-mooney | that said i spent 1300 euro on the workstation to do nested virt ci so i need to fix it anyway | 21:21 |
melwitt | (and that's mostly rhetorical, we will discuss that on the retro) | 21:22 |
artom | melwitt, in the sense of committing to less, given our collectives bandwithes | 21:22 |
artom | (Band... wii?) | 21:22 |
melwitt | ah. yeah, the eternal issue | 21:22 |
sean-k-mooney | artom: if noting else there will be a number of low hanging fruit feautre that can land in early trian | 21:24 |
melwitt | I think if things were staggered more, it would mostly work. but life happens and many things end up coming in at the same time at the end of the cycle, at least that's what it seems to me | 21:24 |
artom | Heh, naturally, if there's only 1 deadline, everyone will procrastinate until that deadline | 21:24 |
melwitt | :) | 21:25 |
mriedem | we've had multiple feature freeze deadlines in the past mind you | 21:26 |
mriedem | priority and non-priority ff | 21:26 |
mriedem | and people don't like that either for similar reasons | 21:27 |
mriedem | can't really process your way out of these problems | 21:27 |
artom | A thing we do downstream is just punt waaaay early | 21:27 |
artom | So like, by upstream spec freeze if there's no code up it's punted | 21:28 |
sean-k-mooney | well that is what the the non priorot feature freeze used to do | 21:28 |
artom | The live migration stuff is sorta an exception because everyone wants it, so we both punted to Train *and* kept it around in Stein just in case | 21:28 |
sean-k-mooney | if it was not a priority feature and it was not done by m2 it got punted | 21:28 |
*** brault has joined #openstack-nova | 21:28 | |
artom | Maybe not split into priority/non-priority? Just "no patches ready for review by spec freeze? Punt." | 21:29 |
artom | And then there's more collective bandwidth for the remaining stuff | 21:30 |
artom | I dunno, we can bikeshed more at the retro I guess | 21:30 |
melwitt | yeah. open to ideas there, we'll talk about it then in more detail | 21:30 |
sean-k-mooney | honestly any feature that misses FF i would hope we coudl just target at m1 and actully aim to get more stuff done at teh earliar milestones | 21:31 |
mriedem | ^ is why we have runways | 21:31 |
sean-k-mooney | that is true. | 21:32 |
artom | So, honest question, do they work? For instance, sean-k-mooney's SRIOV live migration stuff got a runway, and then no-one (and I'm just as guilty here) reviewed it | 21:32 |
mriedem | sure they do | 21:33 |
mriedem | plenty of stuff has been merged from runways b/c of runways | 21:33 |
mriedem | trusted certs for example | 21:33 |
sean-k-mooney | with the bandwith stuff in another runway and with the priority fo that im honestly not that surprised. i think they do help | 21:33 |
mriedem | there are some things that people just don't have as a priority to review, or comfort in reviewing | 21:34 |
sean-k-mooney | ya i think it more the latter with the numa stuff | 21:34 |
*** wolverineav has quit IRC | 21:34 | |
sean-k-mooney | few people feel comfortable to review it | 21:34 |
mriedem | ok i need to do this fup and move on | 21:34 |
melwitt | and I have to run to an appointment. bbl | 21:35 |
*** eharney has quit IRC | 21:35 | |
*** slaweq has quit IRC | 21:35 | |
* artom is happy to stand corrected on runways then :) | 21:36 | |
* artom is off too | 21:37 | |
*** tesseract has quit IRC | 21:39 | |
*** wolverineav has joined #openstack-nova | 21:39 | |
*** wolverineav has quit IRC | 21:40 | |
*** wolverineav has joined #openstack-nova | 21:40 | |
*** wolverineav has quit IRC | 21:41 | |
*** wolverineav has joined #openstack-nova | 21:41 | |
*** artom has quit IRC | 21:42 | |
*** slaweq has joined #openstack-nova | 21:48 | |
*** takashin has joined #openstack-nova | 21:51 | |
*** markvoelker has joined #openstack-nova | 21:53 | |
*** macza has joined #openstack-nova | 21:53 | |
*** ociuhandu has joined #openstack-nova | 21:54 | |
*** macza has quit IRC | 21:55 | |
*** macza has joined #openstack-nova | 21:55 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Follow up for I0c764e441993e32aafef0b18049a425c3c832a50 https://review.openstack.org/638517 | 22:04 |
mriedem | jaypipes: efried: ^ | 22:04 |
efried | way to go on that "about one line" thing. | 22:05 |
mriedem | i wasn't going to make all of the changes in his original patch | 22:06 |
mriedem | so i went with the full fup and todo's the provider trait cache thing for him :) | 22:06 |
*** pbing19 has quit IRC | 22:06 | |
*** ociuhandu has quit IRC | 22:10 | |
sean-k-mooney | mriedem: by the way i started review your cross cell migration stuff but before i dig into that series to much is it complete. | 22:16 |
mriedem | there are still kinks i have to work out and more testing to be added | 22:17 |
sean-k-mooney | im planning on my sriov migration series and artoms numa migration series again next week. i could try and add your cell migration series to that list if i can make time | 22:17 |
sean-k-mooney | *planning on testing | 22:18 |
mriedem | i have no illusions that cross-cell resize is going to land in stein | 22:18 |
mriedem | but review would be useful nonetheless to get more than just my eyes on it, | 22:18 |
mriedem | Kevin_Zheng has been reviewing some of it along the way as well | 22:18 |
mriedem | functional tests start at the change that gets the server to VERIFY_RESIZE status | 22:19 |
*** tbachman has quit IRC | 22:19 | |
mriedem | i have a known issue with volume attachment tracking as well | 22:19 |
mriedem | it's all from the bottom up though, so technically we can start merging things and none of it will be used until the very end of the series | 22:20 |
mriedem | if people need a review guide (like gibi did for the bw provider series) i can post something in the ML | 22:20 |
sean-k-mooney | ok well while i have at least some of the context of that code loaded i thikn it makes sense to spend my review time on it abit next sprint | 22:20 |
*** tbachman has joined #openstack-nova | 22:21 | |
*** hamzy has quit IRC | 22:21 | |
sean-k-mooney | mriedem: well i havent gotten to any of the involed code yet but sofar all your patches are fairly clear and too the point. you also tend to front load the context with a decent commit message so a review guide might be useful but so far the 2 or 3 patches i have looked at are pretty self evendely correct | 22:23 |
*** markvoelker has quit IRC | 22:25 | |
mriedem | honestly there is a shit load of documentation because i have to keep it straight myself | 22:25 |
*** artom has joined #openstack-nova | 22:26 | |
*** _fragatina has joined #openstack-nova | 22:26 | |
*** sdake has quit IRC | 22:27 | |
sean-k-mooney | maybe my tastes are changing but while i like self documenting code as i have been looking at longer patchset lately i have found my self like self documetning code with comments and documentation more | 22:30 |
*** wolverineav has quit IRC | 22:30 | |
mriedem | i think you just said the same thing | 22:31 |
mriedem | "like i like A, i like A" | 22:31 |
mriedem | *while i like A, i like A | 22:31 |
*** wolverineav has joined #openstack-nova | 22:31 | |
mriedem | maybe i don't know what self-documenting code is | 22:32 |
mriedem | it's what research type people say when you ask what their code does :) | 22:32 |
mriedem | in my experience | 22:32 |
sean-k-mooney | for me it its code that is written in such a as the variable names and function make it clear what it should do without requiring a comment | 22:32 |
sean-k-mooney | but lately even when that is the case i have found that a comment explaining why it does X not how it does x which is obvios for the code is someting i have been thinking about more | 22:34 |
sean-k-mooney | its somethin i personally want to improve in my own code. | 22:35 |
*** wolverineav has quit IRC | 22:36 | |
sean-k-mooney | i know i can write good documetation and comment to explain why i did somethign but often dont until im asked but when i review your code i often find i dont need to ask | 22:36 |
*** _fragatina_ has joined #openstack-nova | 22:37 | |
*** _fragatina has quit IRC | 22:40 | |
*** _fragatina has joined #openstack-nova | 22:42 | |
*** slaweq has quit IRC | 22:43 | |
*** _fragatina_ has quit IRC | 22:45 | |
*** wolverineav has joined #openstack-nova | 22:49 | |
aspiers | sean-k-mooney: +1, good variable and function naming is so important (and rare in a lot of projects ...) | 22:54 |
*** slaweq has joined #openstack-nova | 22:56 | |
*** ShilpaSD has quit IRC | 23:00 | |
*** slaweq has quit IRC | 23:00 | |
*** tkajinam has joined #openstack-nova | 23:01 | |
*** ShilpaSD has joined #openstack-nova | 23:02 | |
*** jobewan has quit IRC | 23:07 | |
*** slaweq has joined #openstack-nova | 23:11 | |
sean-k-mooney | with some code i have reviewed i woudl have been happier if there were functions. even if they were named badly. giving a name to the thing you are doing and the inputs it operates on helps so much. | 23:11 |
*** tosky has quit IRC | 23:11 | |
sean-k-mooney | aspiers: i find that happens more in c then python where peopel will put a comment before and after a pice of code say it does x with y | 23:12 |
*** sdake has joined #openstack-nova | 23:13 | |
sean-k-mooney | aspiers: instad of creating a function that does x with y and encurring the horror that is the cost of a function call. | 23:14 |
sean-k-mooney | at least in python that is not an excuse | 23:14 |
*** mriedem has quit IRC | 23:14 | |
*** _fragatina has quit IRC | 23:15 | |
*** _fragatina has joined #openstack-nova | 23:15 | |
*** slaweq has quit IRC | 23:16 | |
*** _fragatina has quit IRC | 23:20 | |
*** markvoelker has joined #openstack-nova | 23:22 | |
*** _fragatina has joined #openstack-nova | 23:23 | |
*** ivve has quit IRC | 23:25 | |
*** igordc has quit IRC | 23:30 | |
*** sdake has quit IRC | 23:33 | |
*** sdake has joined #openstack-nova | 23:38 | |
*** gyee has quit IRC | 23:38 | |
*** tbachman has quit IRC | 23:44 | |
*** sdake has quit IRC | 23:46 | |
*** sdake has joined #openstack-nova | 23:48 | |
*** sdake has quit IRC | 23:51 | |
*** sdake_ has joined #openstack-nova | 23:51 | |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.openstack.org/631244 | 23:52 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.openstack.org/631245 | 23:52 |
*** gyee has joined #openstack-nova | 23:52 | |
*** erlon__ has joined #openstack-nova | 23:54 | |
*** markvoelker has quit IRC | 23:55 | |
*** wolverineav has quit IRC | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!