| *** sdake has quit IRC | 00:00 | |
| *** liuyulong has quit IRC | 00:02 | |
| *** sdake has joined #openstack-nova | 00:02 | |
| *** tosky has quit IRC | 00:02 | |
| *** sdake has quit IRC | 00:05 | |
| *** markvoelker has joined #openstack-nova | 00:06 | |
| *** sdake has joined #openstack-nova | 00:06 | |
| *** alex_xu has joined #openstack-nova | 00:08 | |
| *** igordc has quit IRC | 00:09 | |
| *** sdake has quit IRC | 00:10 | |
| melwitt | sigh... BuildRequest doesn't have a user_id field. only a project_id field. so, neeeeevermind | 00:12 |
|---|---|---|
| openstackgerrit | Brin Zhang proposed openstack/nova master: Remove the string check of the flavor attribute 'swap' https://review.openstack.org/639012 | 00:12 |
| *** mriedem has quit IRC | 00:15 | |
| *** mriedem has joined #openstack-nova | 00:17 | |
| sean-k-mooney | melwitt: if you wanted to optimise the data migration slightly you coudl do it in 2 phases | 00:17 |
| *** brinzhang has joined #openstack-nova | 00:17 | |
| *** edmondsw has quit IRC | 00:17 | |
| sean-k-mooney | melwitt: first add the user ids form all instace that have a user id in there request spec | 00:18 |
| sean-k-mooney | then call done to the cell and grab it out of the instance table for the remainder | 00:18 |
| melwitt | yeah. that might be a good idea | 00:19 |
| sean-k-mooney | you may not be able to rely on it being present in the request spec but you can conditionally use it to minimise the down calls | 00:19 |
| melwitt | for this, it was about whether we can make the InstanceMapping.user_id field non-nullable. and I think because of the aforementioned things, we can't | 00:19 |
| melwitt | no user_id on BuildRequest, and user_id not guaranteed to be set on RequestSpec | 00:19 |
| mriedem | yonglihe: i replied in https://review.openstack.org/#/c/621474/ and i'm ok with the server_groups as a list since that seems to be the consensus | 00:19 |
| sean-k-mooney | melwitt: if this change lands in stien you could make it non nullable in train | 00:20 |
| sean-k-mooney | the only donwside to that would be for FFU you would have to run the online migration. although i assume this could be done as an offline migration too | 00:21 |
| melwitt | sean-k-mooney: yeah. I don't understand whether it needs to be a major object version bump or not, but I can ask about that next cycle. because it would be good to make it non-nullable whenever we can | 00:21 |
| melwitt | yes, offline (nova-manage) migration is the one that does the cell database reads | 00:22 |
| melwitt | we're going to have a blocker migration in T also, to ensure all migrated, and then be able to remove transitionary online/active migration code | 00:23 |
| sean-k-mooney | ok if its an offline data migration that is executed centrally on the controller that is not too much of a headache for ffu | 00:23 |
| melwitt | right | 00:23 |
| sean-k-mooney | thanks for +1'ing the os-vif releae patch by the way. | 00:24 |
| sean-k-mooney | hopefully it will get merged soon but ill follow up tomorrow if not | 00:25 |
| *** agopi has joined #openstack-nova | 00:25 | |
| sean-k-mooney | night o/ | 00:25 |
| melwitt | np, gnight | 00:29 |
| *** mlavalle has quit IRC | 00:29 | |
| *** sdake has joined #openstack-nova | 00:32 | |
| *** erlon has joined #openstack-nova | 00:34 | |
| *** markvoelker has quit IRC | 00:40 | |
| *** wolverineav has quit IRC | 00:42 | |
| *** macza has quit IRC | 00:43 | |
| *** _hemna has joined #openstack-nova | 00:44 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Fix changes-before values in an instance action test https://review.openstack.org/638849 | 00:44 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | 00:46 |
| *** mriedem has quit IRC | 00:47 | |
| *** awalende has joined #openstack-nova | 00:47 | |
| *** tetsuro has joined #openstack-nova | 00:51 | |
| *** awalende has quit IRC | 00:52 | |
| *** Sundar has joined #openstack-nova | 00:52 | |
| *** tetsuro has quit IRC | 00:53 | |
| *** tetsuro has joined #openstack-nova | 00:56 | |
| *** sdake has quit IRC | 00:59 | |
| *** lbragstad has quit IRC | 00:59 | |
| *** takashin has joined #openstack-nova | 01:01 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.openstack.org/634605 | 01:01 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Make the use of the CastAsCall fixture configurable https://review.openstack.org/639428 | 01:01 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP needs more tests] Full NUMA live migration support https://review.openstack.org/634606 | 01:01 |
| *** Swami has quit IRC | 01:08 | |
| jaypipes | melwitt: hmm, how user_id isn't guaranteed on request spec or build request is very odd to me... | 01:08 |
| jaypipes | one would think both of those would by their very nature have a user associated with them. :) | 01:08 |
| melwitt | jaypipes: build request doesn't even have a user_id field (wah wah). but request spec waits until conductor to set project_id and user_id | 01:09 |
| melwitt | and yeah, I agree. I think it's because user_id wasn't "required" when they were first added as tables | 01:10 |
| melwitt | there's definitely a user associated with them. just not recorded so well | 01:10 |
| *** _fragatina has quit IRC | 01:14 | |
| *** itlinux has joined #openstack-nova | 01:16 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/queens: DNM: For testing multinode and tempest-slow job https://review.openstack.org/623992 | 01:21 |
| *** igordc has joined #openstack-nova | 01:26 | |
| *** slaweq has joined #openstack-nova | 01:26 | |
| *** slaweq has quit IRC | 01:31 | |
| *** sdake has joined #openstack-nova | 01:35 | |
| *** _fragatina has joined #openstack-nova | 01:35 | |
| *** itlinux has quit IRC | 01:36 | |
| *** markvoelker has joined #openstack-nova | 01:37 | |
| *** takamatsu_ has quit IRC | 01:39 | |
| *** edmondsw has joined #openstack-nova | 01:42 | |
| *** erlon has quit IRC | 01:45 | |
| *** takamatsu_ has joined #openstack-nova | 01:45 | |
| openstackgerrit | Merged openstack/nova master: Mention SR-IOV cold migration limitation in admin docs https://review.openstack.org/603909 | 01:47 |
| yonglihe | mriedem, got that, working on it now, thanks. | 01:51 |
| *** lbragstad has joined #openstack-nova | 01:58 | |
| *** whoami-rajat has joined #openstack-nova | 02:01 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351 | 02:03 |
| openstackgerrit | melanie witt proposed openstack/nova master: Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | 02:03 |
| openstackgerrit | melanie witt proposed openstack/nova master: WIP Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 02:03 |
| openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 02:03 |
| *** tetsuro has quit IRC | 02:05 | |
| *** sdake has quit IRC | 02:09 | |
| *** markvoelker has quit IRC | 02:10 | |
| *** sdake has joined #openstack-nova | 02:10 | |
| *** sdake has quit IRC | 02:13 | |
| *** gyee has quit IRC | 02:15 | |
| *** sdake has joined #openstack-nova | 02:15 | |
| *** sdake has quit IRC | 02:16 | |
| *** tetsuro has joined #openstack-nova | 02:18 | |
| *** _hemna has quit IRC | 02:18 | |
| *** tetsuro has quit IRC | 02:24 | |
| *** _hemna has joined #openstack-nova | 02:30 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:30 | |
| *** rcernin has quit IRC | 02:32 | |
| *** _hemna has quit IRC | 02:34 | |
| *** tetsuro has joined #openstack-nova | 02:35 | |
| *** hongbin has joined #openstack-nova | 02:38 | |
| *** igordc has quit IRC | 02:40 | |
| *** igordc has joined #openstack-nova | 02:40 | |
| *** tetsuro has quit IRC | 02:40 | |
| *** sdake has joined #openstack-nova | 02:41 | |
| *** hongbin has quit IRC | 02:43 | |
| *** sdake has quit IRC | 02:45 | |
| *** _fragatina has quit IRC | 02:45 | |
| *** sdake has joined #openstack-nova | 02:47 | |
| *** tetsuro has joined #openstack-nova | 02:47 | |
| *** takamatsu_ has quit IRC | 02:53 | |
| *** sdake has quit IRC | 02:55 | |
| *** sdake has joined #openstack-nova | 02:56 | |
| *** sdake has quit IRC | 03:01 | |
| *** psachin has joined #openstack-nova | 03:01 | |
| *** sdake_ has joined #openstack-nova | 03:01 | |
| *** tetsuro has quit IRC | 03:02 | |
| *** markvoelker has joined #openstack-nova | 03:04 | |
| *** tetsuro has joined #openstack-nova | 03:08 | |
| *** _hemna has joined #openstack-nova | 03:09 | |
| *** sdake_ has quit IRC | 03:10 | |
| *** sdake has joined #openstack-nova | 03:12 | |
| *** sdake has quit IRC | 03:15 | |
| *** tetsuro has quit IRC | 03:15 | |
| *** sdake has joined #openstack-nova | 03:16 | |
| *** wolverineav has joined #openstack-nova | 03:18 | |
| *** sdake has quit IRC | 03:23 | |
| *** sdake_ has joined #openstack-nova | 03:23 | |
| *** sdake_ has quit IRC | 03:25 | |
| *** sdake has joined #openstack-nova | 03:26 | |
| *** tetsuro has joined #openstack-nova | 03:30 | |
| *** sdake has quit IRC | 03:30 | |
| *** sdake has joined #openstack-nova | 03:31 | |
| *** itlinux has joined #openstack-nova | 03:31 | |
| *** sdake has quit IRC | 03:35 | |
| *** sdake has joined #openstack-nova | 03:36 | |
| *** _hemna has quit IRC | 03:40 | |
| *** sdake_ has joined #openstack-nova | 03:44 | |
| *** sdake has quit IRC | 03:44 | |
| *** diga has joined #openstack-nova | 03:47 | |
| *** sdake_ has quit IRC | 03:51 | |
| *** sdake has joined #openstack-nova | 03:52 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add compute service support for attach/detach root volume https://review.openstack.org/614750 | 03:53 |
| *** wolverineav has quit IRC | 03:55 | |
| *** sdake has quit IRC | 03:55 | |
| *** sdake has joined #openstack-nova | 03:56 | |
| *** sdake has quit IRC | 03:57 | |
| *** sdake has joined #openstack-nova | 03:58 | |
| *** Sundar has quit IRC | 03:58 | |
| *** sdake has quit IRC | 04:00 | |
| *** tetsuro has quit IRC | 04:02 | |
| *** tetsuro has joined #openstack-nova | 04:03 | |
| *** tetsuro has quit IRC | 04:04 | |
| *** sdake has joined #openstack-nova | 04:06 | |
| *** masber has joined #openstack-nova | 04:08 | |
| *** sdake has quit IRC | 04:11 | |
| *** sdake_ has joined #openstack-nova | 04:12 | |
| *** spsurya has joined #openstack-nova | 04:15 | |
| *** sdake_ has quit IRC | 04:17 | |
| openstackgerrit | Merged openstack/python-novaclient master: Fix changes-before values in an instance action test https://review.openstack.org/638849 | 04:21 |
| *** janki has joined #openstack-nova | 04:33 | |
| *** _fragatina has joined #openstack-nova | 04:52 | |
| *** wolverineav has joined #openstack-nova | 05:01 | |
| *** itlinux has quit IRC | 05:01 | |
| *** wolverineav has quit IRC | 05:02 | |
| *** dave-mccowan has quit IRC | 05:05 | |
| *** macza has joined #openstack-nova | 05:13 | |
| openstackgerrit | Merged openstack/nova master: Avoid BadRequest error log on volume attachment https://review.openstack.org/581453 | 05:13 |
| *** macza has quit IRC | 05:17 | |
| *** _hemna has joined #openstack-nova | 05:37 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove duplicate cleanup in functional tests https://review.openstack.org/636996 | 05:37 |
| *** sridharg has joined #openstack-nova | 05:38 | |
| *** tetsuro has joined #openstack-nova | 05:38 | |
| *** ileixe has joined #openstack-nova | 05:42 | |
| *** udesale has joined #openstack-nova | 05:42 | |
| *** ileixe has quit IRC | 05:42 | |
| *** ileixe has joined #openstack-nova | 05:43 | |
| *** masber has quit IRC | 06:04 | |
| *** tetsuro has quit IRC | 06:05 | |
| *** dcdawg has joined #openstack-nova | 06:07 | |
| *** tetsuro has joined #openstack-nova | 06:08 | |
| *** ivve has joined #openstack-nova | 06:08 | |
| *** ratailor has joined #openstack-nova | 06:10 | |
| *** _hemna has quit IRC | 06:11 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 06:11 |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 06:16 |
| *** wolverineav has joined #openstack-nova | 06:21 | |
| *** tetsuro has quit IRC | 06:31 | |
| *** sridharg has quit IRC | 06:32 | |
| *** dcdawg has quit IRC | 06:36 | |
| *** wolverineav has quit IRC | 06:38 | |
| *** wolverineav has joined #openstack-nova | 06:39 | |
| *** dcdawg has joined #openstack-nova | 06:39 | |
| *** _hemna has joined #openstack-nova | 06:42 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume https://review.openstack.org/638080 | 06:45 |
| *** _hemna has quit IRC | 06:47 | |
| *** Luzi has joined #openstack-nova | 06:47 | |
| *** markvoelker has quit IRC | 06:51 | |
| *** ttsiouts has joined #openstack-nova | 06:53 | |
| *** wolverineav has quit IRC | 06:54 | |
| *** slaweq has joined #openstack-nova | 06:57 | |
| *** Dinesh_Bhor has quit IRC | 06:58 | |
| openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | 06:59 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move final bridge commands to privsep. https://review.openstack.org/639580 | 06:59 |
| openstackgerrit | Michael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.openstack.org/639581 | 06:59 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | 06:59 |
| *** Dinesh_Bhor has joined #openstack-nova | 07:01 | |
| *** tetsuro has joined #openstack-nova | 07:07 | |
| *** phasespace has quit IRC | 07:08 | |
| *** Dinesh_Bhor has quit IRC | 07:12 | |
| *** ivve has quit IRC | 07:17 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 07:19 |
| *** takamatsu_ has joined #openstack-nova | 07:21 | |
| *** belmoreira has joined #openstack-nova | 07:25 | |
| *** dpawlik has joined #openstack-nova | 07:25 | |
| *** dcdawg has quit IRC | 07:28 | |
| *** ccamacho has joined #openstack-nova | 07:29 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | 07:30 |
| *** ttsiouts has quit IRC | 07:33 | |
| *** ttsiouts has joined #openstack-nova | 07:34 | |
| *** ivve has joined #openstack-nova | 07:34 | |
| *** ttsiouts has quit IRC | 07:38 | |
| *** wolverineav has joined #openstack-nova | 07:44 | |
| *** dcdawg has joined #openstack-nova | 07:48 | |
| *** liuyulong has joined #openstack-nova | 07:50 | |
| *** sridharg has joined #openstack-nova | 07:52 | |
| *** markvoelker has joined #openstack-nova | 07:52 | |
| *** tetsuro has quit IRC | 07:55 | |
| *** ccamacho has quit IRC | 07:56 | |
| *** takashin has left #openstack-nova | 08:01 | |
| *** lbragstad has quit IRC | 08:01 | |
| *** moshele has joined #openstack-nova | 08:05 | |
| *** ccamacho has joined #openstack-nova | 08:07 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:10 | |
| *** tssurya has joined #openstack-nova | 08:12 | |
| *** pcaruana has joined #openstack-nova | 08:13 | |
| *** Dinesh_Bhor has quit IRC | 08:14 | |
| *** phasespace has joined #openstack-nova | 08:16 | |
| *** imacdonn has quit IRC | 08:18 | |
| *** imacdonn_ has joined #openstack-nova | 08:18 | |
| *** wolverineav has quit IRC | 08:18 | |
| *** tesseract has joined #openstack-nova | 08:20 | |
| *** ttsiouts has joined #openstack-nova | 08:25 | |
| *** markvoelker has quit IRC | 08:25 | |
| openstackgerrit | Sagar Waghmare proposed openstack/nova master: db sync prints stack-trace on invalid version https://review.openstack.org/639591 | 08:25 |
| *** pcaruana has quit IRC | 08:28 | |
| *** dcdawg has quit IRC | 08:29 | |
| *** ttsiouts has quit IRC | 08:30 | |
| *** takamatsu_ has quit IRC | 08:31 | |
| *** tkajinam has quit IRC | 08:33 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume https://review.openstack.org/638080 | 08:35 |
| *** helenafm has joined #openstack-nova | 08:38 | |
| *** tosky has joined #openstack-nova | 08:41 | |
| *** pcaruana has joined #openstack-nova | 08:42 | |
| *** _hemna has joined #openstack-nova | 08:45 | |
| openstackgerrit | garyk proposed openstack/nova master: Better handle live migration abort https://review.openstack.org/635440 | 08:46 |
| *** wolverineav has joined #openstack-nova | 08:51 | |
| *** pcaruana has quit IRC | 08:51 | |
| *** ttsiouts has joined #openstack-nova | 08:55 | |
| *** diga has quit IRC | 08:56 | |
| *** liuyulong_ has joined #openstack-nova | 08:56 | |
| *** pcaruana has joined #openstack-nova | 08:58 | |
| *** liuyulong has quit IRC | 08:59 | |
| *** pcaruana|afk| has joined #openstack-nova | 09:01 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Convert to raw format into rbd volume https://review.openstack.org/638080 | 09:02 |
| *** dcdawg has joined #openstack-nova | 09:02 | |
| *** pcaruana has quit IRC | 09:03 | |
| *** snevi has joined #openstack-nova | 09:08 | |
| *** ttsiouts has quit IRC | 09:08 | |
| *** ttsiouts has joined #openstack-nova | 09:09 | |
| *** ivve has quit IRC | 09:11 | |
| *** ttsiouts_ has joined #openstack-nova | 09:11 | |
| *** ttsiouts has quit IRC | 09:12 | |
| *** takamatsu has joined #openstack-nova | 09:15 | |
| *** _hemna has quit IRC | 09:16 | |
| *** snevi has quit IRC | 09:19 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP status: Ensure templated connection URLs are rendered before use https://review.openstack.org/639607 | 09:20 |
| *** ralonsoh has joined #openstack-nova | 09:22 | |
| *** markvoelker has joined #openstack-nova | 09:23 | |
| *** wolverineav has quit IRC | 09:23 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fup for the bandwidth series https://review.openstack.org/639159 | 09:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Handle placement error during re-schedule https://review.openstack.org/639608 | 09:24 |
| *** igordc has quit IRC | 09:25 | |
| *** cdent has joined #openstack-nova | 09:25 | |
| *** ivve has joined #openstack-nova | 09:26 | |
| *** janki has quit IRC | 09:30 | |
| *** janki has joined #openstack-nova | 09:30 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | 09:32 |
| *** sapd1 has quit IRC | 09:33 | |
| *** Luzi has quit IRC | 09:36 | |
| aspiers | can anyone help me understand why this failed? http://logs.openstack.org/77/638677/2/gate/grenade-py3/e4fb83b/ | 09:40 |
| *** derekh has joined #openstack-nova | 09:41 | |
| *** takamatsu has quit IRC | 09:44 | |
| *** mvkr has quit IRC | 09:46 | |
| *** macza has joined #openstack-nova | 09:46 | |
| *** macza has quit IRC | 09:50 | |
| *** Luzi has joined #openstack-nova | 09:51 | |
| *** efoley has joined #openstack-nova | 09:56 | |
| *** markvoelker has quit IRC | 09:57 | |
| *** owalsh_ has joined #openstack-nova | 09:57 | |
| *** owalsh has quit IRC | 09:58 | |
| *** mvkr has joined #openstack-nova | 10:01 | |
| *** sdake has joined #openstack-nova | 10:03 | |
| *** sdake has quit IRC | 10:05 | |
| *** priteau has joined #openstack-nova | 10:06 | |
| *** sdake has joined #openstack-nova | 10:08 | |
| *** owalsh has joined #openstack-nova | 10:09 | |
| *** owalsh_ has quit IRC | 10:10 | |
| *** sdake has quit IRC | 10:10 | |
| *** sdake has joined #openstack-nova | 10:12 | |
| *** sdake has quit IRC | 10:13 | |
| *** moshele has quit IRC | 10:13 | |
| *** sdake has joined #openstack-nova | 10:16 | |
| *** sdake has quit IRC | 10:17 | |
| *** dpawlik has quit IRC | 10:20 | |
| *** wolverineav has joined #openstack-nova | 10:20 | |
| *** sdake has joined #openstack-nova | 10:22 | |
| *** panda|ruck|off is now known as panda | 10:23 | |
| *** panda is now known as panda|ruck | 10:23 | |
| *** sdake has quit IRC | 10:25 | |
| *** sdake has joined #openstack-nova | 10:25 | |
| *** sdake has quit IRC | 10:30 | |
| *** sdake has joined #openstack-nova | 10:31 | |
| *** dpawlik has joined #openstack-nova | 10:35 | |
| *** sdake has quit IRC | 10:35 | |
| *** sdake has joined #openstack-nova | 10:35 | |
| *** priteau has quit IRC | 10:40 | |
| *** tssurya has quit IRC | 10:40 | |
| *** sdake has quit IRC | 10:41 | |
| *** sdake_ has joined #openstack-nova | 10:41 | |
| *** tssurya has joined #openstack-nova | 10:42 | |
| *** priteau has joined #openstack-nova | 10:45 | |
| *** sdake_ has quit IRC | 10:45 | |
| *** sdake has joined #openstack-nova | 10:46 | |
| *** brinzhang has quit IRC | 10:46 | |
| *** dcdawg has quit IRC | 10:47 | |
| *** sdake has quit IRC | 10:50 | |
| *** sdake has joined #openstack-nova | 10:51 | |
| *** markvoelker has joined #openstack-nova | 10:53 | |
| *** udesale has quit IRC | 10:53 | |
| *** wolverineav has quit IRC | 10:54 | |
| *** sdake has quit IRC | 10:55 | |
| *** sdake has joined #openstack-nova | 10:57 | |
| *** Dinesh_Bhor has joined #openstack-nova | 10:57 | |
| *** sdake has quit IRC | 11:00 | |
| *** Dinesh_Bhor has quit IRC | 11:00 | |
| *** sdake has joined #openstack-nova | 11:01 | |
| *** dpawlik has quit IRC | 11:04 | |
| *** Shilpa has joined #openstack-nova | 11:05 | |
| *** ShilpaSD has quit IRC | 11:06 | |
| *** dcdawg has joined #openstack-nova | 11:09 | |
| *** ttsiouts_ has quit IRC | 11:09 | |
| *** ttsiouts has joined #openstack-nova | 11:10 | |
| *** sapd1 has joined #openstack-nova | 11:11 | |
| *** erlon has joined #openstack-nova | 11:12 | |
| *** dcdawg has quit IRC | 11:13 | |
| *** _hemna has joined #openstack-nova | 11:14 | |
| *** ratailor has quit IRC | 11:20 | |
| *** ileixe has quit IRC | 11:20 | |
| *** ttsiouts has quit IRC | 11:23 | |
| *** takamatsu has joined #openstack-nova | 11:24 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | 11:25 |
| *** Shilpa has quit IRC | 11:25 | |
| *** markvoelker has quit IRC | 11:26 | |
| *** dcdawg has joined #openstack-nova | 11:27 | |
| *** dcdawg has quit IRC | 11:31 | |
| *** dcdawg has joined #openstack-nova | 11:34 | |
| *** dpawlik has joined #openstack-nova | 11:35 | |
| *** dcdawg has quit IRC | 11:38 | |
| *** dpawlik has quit IRC | 11:39 | |
| *** dpawlik has joined #openstack-nova | 11:41 | |
| *** macza has joined #openstack-nova | 11:44 | |
| *** _hemna has quit IRC | 11:47 | |
| bauzas | gibi: hola | 11:47 |
| bauzas | gibi: do you know where we set VCPU inventories for https://review.openstack.org/#/c/631559/ ? | 11:48 |
| * bauzas tries to find it but I haven't seen it yet | 11:48 | |
| *** macza has quit IRC | 11:48 | |
| bauzas | FWIW, we have a VCPU inventory that only accepts two VCPUs :) | 11:49 |
| bauzas | (Pdb) compute_inventory | 11:49 |
| bauzas | {u'VCPU': {u'allocation_ratio': 16.0, u'total': 2, u'reserved': 0, u'step_size': 1, u'min_unit': 1, u'max_unit': 2}, u'MEMORY_MB': {u'allocation_ratio': 1.5, u'total': 4096, u'reserved': 512, u'step_size': 1, u'min_unit': 1, u'max_unit': 4096}, u'DISK_GB': {u'allocation_ratio': 1.0, u'total': 128, u'reserved': 0, u'step_size': 1, u'min_unit': 1, u'max_unit': 128}} | 11:49 |
| *** ttsiouts has joined #openstack-nova | 11:49 | |
| bauzas | oh my bad | 11:50 |
| *** wolverineav has joined #openstack-nova | 11:51 | |
| sean-k-mooney | bauzas: technically the vcpu inventory will accept 32 cpu allocation but each allcoation can only contin 2 | 11:52 |
| bauzas | yup, so that's not the problem I have then | 11:52 |
| bauzas | super weird | 11:52 |
| sean-k-mooney | what is the problem you are having? | 11:52 |
| bauzas | placement returns me no alloc candidates but inventories are okay | 11:53 |
| *** efoley has quit IRC | 11:53 | |
| sean-k-mooney | is it a timeing issue? | 11:53 |
| sean-k-mooney | and have we talked about this like 3 times in the past and we keep forgetting | 11:53 |
| bauzas | sean-k-mooney: nope, I don't think it's a race | 11:54 |
| bauzas | sean-k-mooney: http://paste.openstack.org/show/746416/ | 11:54 |
| sean-k-mooney | bauzas: ok i was wondering if it was the downstream issue you had been looking at on and off for the last few months | 11:55 |
| *** moshele has joined #openstack-nova | 11:55 | |
| bauzas | nope, working on the reshape series | 11:55 |
| bauzas | http://paste.openstack.org/show/746418/ | 11:56 |
| *** moshele has quit IRC | 11:57 | |
| sean-k-mooney | im not sure what im looking at. | 11:57 |
| *** tetsuro has joined #openstack-nova | 11:57 | |
| bauzas | sean-k-mooney: I modified the functest and now i have a NoValidHost http://paste.openstack.org/show/746419/ | 11:58 |
| bauzas | that's probably a PEBKAC | 11:59 |
| bauzas | oh wait, it's the memory... | 11:59 |
| bauzas | we ask for 2048GB of RAM in the flavor | 11:59 |
| *** tetsuro has quit IRC | 11:59 | |
| *** moshele has joined #openstack-nova | 12:00 | |
| bauzas | we have 4096 * 1.5 - 512 | 12:00 |
| *** ivve has quit IRC | 12:00 | |
| sean-k-mooney | GB i think you mean MB | 12:00 |
| sean-k-mooney | * i hope you mean MB | 12:00 |
| bauzas | whoops indeed | 12:00 |
| bauzas | anyway, that's why I get a placement thingy | 12:00 |
| *** Luzi has quit IRC | 12:00 | |
| bauzas | I need to create more room or ask for less | 12:01 |
| bauzas | but then the question remains, where do we set inventories from the functional tests ? | 12:01 |
| sean-k-mooney | ubutnu/fedroa and centos will work with 256mb and cirros will work with 64mb | 12:01 |
| *** Luzi has joined #openstack-nova | 12:02 | |
| sean-k-mooney | its using the libvirt fake driver | 12:02 |
| sean-k-mooney | so its in the driver code | 12:02 |
| bauzas | bingo, found it | 12:03 |
| bauzas | HostInfo() | 12:04 |
| sean-k-mooney | ya that sound about right | 12:04 |
| bauzas | yay, it works when changing kB_mem attribute \o/ | 12:05 |
| *** awalende has joined #openstack-nova | 12:16 | |
| *** s10 has joined #openstack-nova | 12:16 | |
| *** markvoelker has joined #openstack-nova | 12:22 | |
| *** wolverineav has quit IRC | 12:24 | |
| *** udesale has joined #openstack-nova | 12:26 | |
| aspiers | can anyone give me some hints on how to debug failing grenade jobs? | 12:27 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Use the correct mdev allocated from the pGPU https://review.openstack.org/636591 | 12:31 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: libvirt: implement reshaper for vgpu https://review.openstack.org/599208 | 12:31 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add functional test for libvirt vgpu reshape https://review.openstack.org/631559 | 12:31 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: FUP: docs nit https://review.openstack.org/639647 | 12:31 |
| bauzas | efried: ^ | 12:32 |
| gibi | bauzas: this is where the 2 VCPU is coming from fakelibvirt.HostInfo | 12:34 |
| aspiers | ah, logs/grenade.sh.txt.gz is the logfile I was looking for | 12:35 |
| gibi | bauzas: ohh I see your figured it out | 12:35 |
| *** dcdawg has joined #openstack-nova | 12:37 | |
| *** gbarros has joined #openstack-nova | 12:41 | |
| *** moshele has quit IRC | 12:46 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 12:47 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add remove_resources_from_instance_allocation to report client https://review.openstack.org/639653 | 12:48 |
| *** rpsene has joined #openstack-nova | 12:48 | |
| jaypipes | aspiers: have a friend jump on them. | 12:50 |
| aspiers | :) | 12:50 |
| *** markvoelker has quit IRC | 12:56 | |
| *** ivve has joined #openstack-nova | 12:57 | |
| *** mdbooth_ has quit IRC | 12:57 | |
| sean-k-mooney | how do people feel about backporting https://review.openstack.org/#/q/topic:bug/1751923+(status:open+OR+status:merged) | 12:58 |
| *** agopi has quit IRC | 12:59 | |
| sean-k-mooney | mriedemn asked me to hold off for a while a when it merged but i have a downstream customer asking for this so im wondering if i should backport upstream or not? | 12:59 |
| sean-k-mooney | i wont get around to starting the backport untill next week but input would be welcome. | 13:01 |
| *** dave-mccowan has joined #openstack-nova | 13:02 | |
| *** mdbooth has joined #openstack-nova | 13:02 | |
| tssurya | stephenfin: I had a small doubt here: https://review.openstack.org/#/c/634600/9 regarding the doc samples; could you confirm ? | 13:03 |
| *** pcaruana|afk| has quit IRC | 13:09 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 13:09 |
| sean-k-mooney | tssurya: assuming you are correct that means we are missing a gate job to build the api samples | 13:13 |
| tssurya | sean-k-mooney: yea that's what I think so too | 13:13 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance to make place for port healing https://review.openstack.org/637953 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance (2) https://review.openstack.org/637954 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | 13:14 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: cache neutron ports in heal allocation https://review.openstack.org/638207 | 13:14 |
| sean-k-mooney | i have never actully built the api-sampels personally so i dont know the answer to your question but ya my takeaway from that question is we shoudl fix them if need and add a gate job in the same patch to prevent future regressions | 13:15 |
| *** mchlumsky has joined #openstack-nova | 13:15 | |
| tssurya | sean-k-mooney: yea thanks | 13:16 |
| *** sdake has quit IRC | 13:16 | |
| *** priteau has quit IRC | 13:19 | |
| *** wolverineav has joined #openstack-nova | 13:21 | |
| artom | tssurya, I think the stuff under doc/ is generated automatically, don't remember how though, it's been forever since I played with that.. | 13:21 |
| artom | Hrmm, although Matt had to add them manually in his path here https://review.openstack.org/#/c/631948/ | 13:22 |
| artom | OK, I have no idea, ignore me | 13:22 |
| *** derekh has quit IRC | 13:22 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add remove_resources_from_instance_allocation to report client https://review.openstack.org/639653 | 13:25 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 13:25 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 13:25 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 13:25 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 13:25 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 13:25 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance to make place for port healing https://review.openstack.org/637953 | 13:25 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance (2) https://review.openstack.org/637954 | 13:25 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | 13:25 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: cache neutron ports in heal allocation https://review.openstack.org/638207 | 13:25 |
| *** jmlowe has quit IRC | 13:29 | |
| *** agopi has joined #openstack-nova | 13:35 | |
| *** tbachman has quit IRC | 13:38 | |
| *** agopi has quit IRC | 13:40 | |
| tssurya | artom: oh he added them manually ? | 13:40 |
| tssurya | I was actually trying to review this: https://review.openstack.org/#/c/621474/26 and some things seemed off when added manually like the test samples and doc samples didn't match | 13:41 |
| tssurya | anyways thanks artom I am confused too at this point | 13:41 |
| *** _hemna has joined #openstack-nova | 13:43 | |
| *** mriedem has joined #openstack-nova | 13:44 | |
| mriedem | tssurya: from your question in https://review.openstack.org/#/c/634600/ it sounds like a bug if you want to report one and push a fix | 13:46 |
| *** phasespace has quit IRC | 13:52 | |
| *** markvoelker has joined #openstack-nova | 13:53 | |
| *** rambo_li has joined #openstack-nova | 13:53 | |
| *** janki has quit IRC | 13:53 | |
| tssurya | mriedem: ack will do | 13:54 |
| mriedem | also, nice review on https://review.openstack.org/#/c/621474/ | 13:54 |
| *** wolverineav has quit IRC | 13:55 | |
| tssurya | :) | 13:55 |
| *** igordc has joined #openstack-nova | 13:56 | |
| *** rambo_li has quit IRC | 13:56 | |
| *** derekh has joined #openstack-nova | 13:57 | |
| gibi | mriedem: fixed your comments in https://review.openstack.org/#/c/622421 and split out the report client change to a separate patch | 13:58 |
| gibi | mriedem: the fup is also up to date https://review.openstack.org/#/c/639159 | 14:00 |
| mriedem | ok | 14:00 |
| *** mlavalle has joined #openstack-nova | 14:00 | |
| *** liuyulong has joined #openstack-nova | 14:00 | |
| gibi | I have to spend the rest of the afternoon in downstream land so let's communicate via the code reviews :/ | 14:01 |
| mriedem | fare thee well | 14:01 |
| *** rambo_li has joined #openstack-nova | 14:01 | |
| gibi | mriedem: thanks I will try :) | 14:01 |
| *** eharney has joined #openstack-nova | 14:04 | |
| *** awaugama has joined #openstack-nova | 14:06 | |
| *** agopi has joined #openstack-nova | 14:08 | |
| *** rambo_li has quit IRC | 14:10 | |
| *** sdake has joined #openstack-nova | 14:12 | |
| *** sdake has quit IRC | 14:12 | |
| *** jmlowe has joined #openstack-nova | 14:13 | |
| sean-k-mooney | mriedem: o/ | 14:13 |
| mriedem | ~o~ | 14:14 |
| sean-k-mooney | mriedem: i asked this before you joined today but do you still want me to hold off on backporting https://review.openstack.org/#/q/topic:bug/1751923+(status:open+OR+status:merged) upstream? i will need to start backporting them downstream next week but i would prefer to do it upstream | 14:14 |
| mriedem | sean-k-mooney: if you're going to do the backport work anyway, can you start it upstream and then cherry pick the upstream backports for your downstream work? knowing that the upstream backports might sit awhile to bake | 14:15 |
| mriedem | i'm not comfortable landing that on stable before it's been released on master and someone like cern or vexxhost has run them yet | 14:16 |
| sean-k-mooney | yep i can do that. i was jsut not sure if you wanted me to avoid backporting them upstream in general | 14:16 |
| *** priteau has joined #openstack-nova | 14:16 | |
| sean-k-mooney | is it the data migrtation script that you are most concerned about or the force refesh patch in general | 14:17 |
| *** Luzi has quit IRC | 14:17 | |
| mriedem | the data migration script | 14:17 |
| *** _hemna has quit IRC | 14:18 | |
| sean-k-mooney | ya technically that is optional and only required for old instnaces that do not alreay have a vlue poplulated in the virtual interfaces table | 14:18 |
| mriedem | i probably won't be comfortable with that on backports upstream until cern has run it | 14:18 |
| sean-k-mooney | i rased that as a conern downstream too | 14:18 |
| mriedem | since it hits all of the cells | 14:18 |
| aspiers | kashyap: you around? I have an idea of how to move forward with getDomainCapabilities() | 14:19 |
| *** eharney_ has joined #openstack-nova | 14:19 | |
| kashyap | aspiers: Yes | 14:19 |
| kashyap | aspiers: Shoot | 14:19 |
| sean-k-mooney | ya from a down stream perspecitve we are going ot have to test this carfully for FFU also | 14:20 |
| aspiers | I think it would be good enough for now if we call it once per arch, using the default machine type for that arch specified by hw_machine_type | 14:20 |
| *** lbragstad has joined #openstack-nova | 14:20 | |
| kashyap | aspiers: Yeah. How many arches is SEV supported, BTW? | 14:21 |
| sean-k-mooney | mriedem: what im hoping to do is get the patches inplace next week so we can do some addtional testing before wew fully decided if we will apply the patch. thanks for clarifing :) | 14:21 |
| aspiers | later we could consider calling it for other machine types | 14:21 |
| aspiers | kashyap: only x86_64 I think | 14:21 |
| kashyap | aspiers: Thought as much. Yeah, for now, let's go the x86_64 route, document it in the conf file / wherver appropriate | 14:22 |
| aspiers | kashyap: so the memoized _domaincaps would be a nested dict of dicts like I mentioned the other day | 14:22 |
| *** eharney has quit IRC | 14:22 | |
| sean-k-mooney | aspiers: you can set the machive type in the image_metadata too | 14:22 |
| kashyap | sean-k-mooney: Yes, that's what I'm getting at | 14:22 |
| aspiers | sean-k-mooney: sure, but right now there is nothing in domain capabilities which would need to influence that | 14:23 |
| kashyap | $ openstack image set \ | 14:23 |
| kashyap | --property hw_machine_type=x86_64=q35 Fedora-29-Template | 14:23 |
| kashyap | aspiers: Aside, ^ have you tested the above with Git master? | 14:23 |
| aspiers | kashyap: have I tested setting image props? | 14:23 |
| kashyap | Yes | 14:23 |
| aspiers | no | 14:23 |
| kashyap | (Asking because, I got a bug report, albiet for an older release, that the above isn't working. I'm still suspicious of the bug report.) | 14:23 |
| aspiers | ah OK | 14:24 |
| kashyap | I asked the reporter to get me the logs, and libvirt debug log (with filters), etc. So I can see what's going on. | 14:24 |
| aspiers | kashyap: so I'm suggesting something like (effectively) self._domaincaps['x86_64']['q35'] = <XML tree object> | 14:24 |
| kashyap | "Seeing is believing." Because too many times I got burnt by taking the word of the bug reporter | 14:24 |
| aspiers | haha yeah :) | 14:25 |
| kashyap | ... only to see in the logs that they misconfigured or did a blatant no-op | 14:25 |
| *** markvoelker has quit IRC | 14:25 | |
| openstackgerrit | Lajos Katona proposed openstack/python-novaclient master: Add support for microversion v2.70 https://review.openstack.org/637234 | 14:26 |
| kashyap | aspiers: BTW, just saw the comment in the review (and the bug: https://bugzilla.redhat.com/show_bug.cgi?id=1683471) | 14:26 |
| openstack | bugzilla.redhat.com bug 1683471 in libvirt "getDomainCapabilities claims SEV is supported for pc-i440fx-1.4 machine type" [Unspecified,New] - Assigned to libvirt-maint | 14:26 |
| sean-k-mooney | kashyap: i got libvirtError: XML error: No PCI buses available | 14:26 |
| kashyap | (I see you filed it yourself, though) | 14:26 |
| sean-k-mooney | when i tried that a few seconds ago | 14:26 |
| openstackgerrit | Lajos Katona proposed openstack/python-novaclient master: Add support for microversion v2.71 https://review.openstack.org/637234 | 14:26 |
| kashyap | sean-k-mooney: Ah, on Git master? | 14:27 |
| kashyap | sean-k-mooney: So something is broken :-( | 14:27 |
| aspiers | kashyap: yes :) | 14:27 |
| kashyap | sean-k-mooney: Can you add the log filters I noted in the second bullet here: | 14:27 |
| kashyap | https://kashyapc.fedorapeople.org/virt/openstack/request-nova-libvirt-qemu-debug-logs.txt | 14:27 |
| kashyap | sean-k-mooney: And then re-post the complete libvirt debug log somewhere, if you can... | 14:27 |
| *** psachin has quit IRC | 14:27 | |
| sean-k-mooney | on f77791954d8a39652ea30ccf51968886471de612 form master | 14:27 |
| aspiers | kashyap: does that dict of dicts make sense to you? it allows for calling getDomCaps on more machine types in the future | 14:27 |
| aspiers | and at least one per arch for now | 14:28 |
| kashyap | aspiers: Yeah, it does make sense to me. (As we future-proofed it.) | 14:29 |
| aspiers | kashyap: OK great, I'll update the patch to do that and test it on a real SEV machine | 14:29 |
| *** Sundar has joined #openstack-nova | 14:29 | |
| sean-k-mooney | kashyap: the only difference form the default filter on ubunut is the also have 1:cpu | 14:29 |
| kashyap | sean-k-mooney: Did you get your default filter from DevStack? (I made sure to add '1:cpu' there too) | 14:30 |
| sean-k-mooney | yes | 14:30 |
| kashyap | aspiers: Thanks! I've got the SEV series in my browser open. | 14:31 |
| kashyap | ("Open in the browser" doesn't mean much, though :D) | 14:31 |
| sean-k-mooney | at least i assume so since this was just a ubunut cloud image so anything not stadard was devstack | 14:31 |
| kashyap | sean-k-mooney: If you got it from DevStack, you should have '1:cpu'. | 14:32 |
| kashyap | Because I added: | 14:32 |
| kashyap | lib/nova_plugins/functions-libvirt: local log_filters="1:libvirt.c 1:qemu 1:conf 1:security 3:object 3:event 3:json 3:file 1:util 1:cpu" | 14:32 |
| kashyap | (In DevStack) | 14:32 |
| aspiers | kashyap: LOL :) maybe you need this https://chrome.google.com/webstore/detail/xtab/amddgdnlkmohapieeekfknakgdnpbleb | 14:32 |
| sean-k-mooney | kashyap: yep i have but the string in https://kashyapc.fedorapeople.org/virt/openstack/request-nova-libvirt-qemu-debug-logs.txt does not have 1:cpu | 14:32 |
| gibi | jaypipes, efried: the fup for the bandwidth series is up-to-date and mriedem already +2 it | 14:32 |
| gibi | https://review.openstack.org/#/c/639159/ | 14:33 |
| jaypipes | ack, on it. | 14:33 |
| gibi | jaypipes: thanks a lot | 14:33 |
| kashyap | sean-k-mooney: Heh, then I should update my doc :-) | 14:33 |
| kashyap | sean-k-mooney: Okay, we're good. | 14:33 |
| kashyap | aspiers: Haha, seems dangerous. As it destroys the illusion of productivity! | 14:34 |
| aspiers | X-D | 14:34 |
| aspiers | on a tangent, I wonder if I broke a world record by having 89 Chrome extensions installed | 14:35 |
| sean-k-mooney | kashyap: looking at the libvirtd log there isnt really any useful infor there. just the same message. this is more then likely a nova issue not a libvirt one | 14:37 |
| jaypipes | gibi: all done. | 14:39 |
| kashyap | sean-k-mooney: Yeah, could be the way Nova is generating guest XML too | 14:39 |
| sean-k-mooney | kashyap: this is the section fo the log around the issu http://paste.openstack.org/show/746435/ | 14:39 |
| kashyap | sean-k-mooney: Anything fun in the n-cpu.log? | 14:39 |
| gibi | jaypipes: thanks. The rest of the series also up-to-date if you have time https://review.openstack.org/#/c/639653 | 14:39 |
| sean-k-mooney | well there was a traceback but ill check the xml that was generated on second while i grab it | 14:39 |
| kashyap | sean-k-mooney: Thanks! | 14:40 |
| kashyap | sean-k-mooney: Care to post the full libvirtd.log just somewhere? I'd like to see some messages above that too | 14:41 |
| sean-k-mooney | http://paste.openstack.org/show/746436/ | 14:42 |
| sean-k-mooney | am sure i can but its got a lot of crap in it since just checked it in one of my long running dev vms | 14:42 |
| sean-k-mooney | kashyap: looking at the xml we are not generating a pcie bus or adding a pci bridge device | 14:43 |
| kashyap | sean-k-mooney: Ah, right; I normally just clean it up `> foo.log` and start over | 14:43 |
| sean-k-mooney | i can truncate it can spin up another vm it will only take a second but this looks like a nova issue | 14:44 |
| mriedem | gibi: i know you told me to leave you alone, but i'm a soft -1 on the bottom 2 changes in the series now, should be easy things to address and then i can +2 those today | 14:44 |
| sean-k-mooney | for q35 we expect nova to generate a pcie toplogy in the xml | 14:45 |
| *** ttsiouts has quit IRC | 14:45 | |
| kashyap | sean-k-mooney: Hang on ... | 14:45 |
| kashyap | sean-k-mooney: This is not even valid guest XML: | 14:46 |
| kashyap | <type machine="x86_64=q35">hvm</type> | 14:46 |
| sean-k-mooney | hehe ya i just noticed that too | 14:46 |
| kashyap | sean-k-mooney: Also, it's a bug in libvirt itself! | 14:47 |
| kashyap | sean-k-mooney: It should reject that as an invalid XML | 14:47 |
| sean-k-mooney | it did | 14:47 |
| kashyap | I'll file an upstream bug report, and take it w/ the libvirt folks | 14:47 |
| openstackgerrit | Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474 | 14:47 |
| sean-k-mooney | the error startswith "Error defining a guest with XML: ..." | 14:48 |
| sean-k-mooney | maybe that came form nova | 14:48 |
| kashyap | I guess so; libvirt uses the terms "domains" | 14:48 |
| kashyap | sean-k-mooney: Regardless, libvirt's parser should reject invalid XML | 14:48 |
| sean-k-mooney | ah right | 14:48 |
| kashyap | It is a valid bug in libvirt itself; I just double-confirmed w/ a libvirt upstream dev. | 14:48 |
| sean-k-mooney | yep let me quickly set the image prop to q35 | 14:48 |
| *** _hemna has joined #openstack-nova | 14:49 | |
| *** sdake has joined #openstack-nova | 14:49 | |
| kashyap | sean-k-mooney: So, this is valid guest XML: <type arch='x86_64' machine='pc-i440fx-rhel7.2.0'>hvm</type> | 14:50 |
| sean-k-mooney | kashyap: openstack image set --property hw_machine_type=q35 cirros-0.3.6-x86_64-disk works | 14:50 |
| kashyap | sean-k-mooney: Excellent. So the problem is the bug reporter directly copied my bad syntax! | 14:51 |
| kashyap | Talk about copy/paste on the internet. | 14:51 |
| sean-k-mooney | http://paste.openstack.org/show/746437/ | 14:51 |
| sean-k-mooney | kashyap: well the syntax you used was correct for the nova.conf | 14:51 |
| *** wolverineav has joined #openstack-nova | 14:52 | |
| sean-k-mooney | but an image presuably only has on architeure so i guess droping the arch= part makes sense | 14:52 |
| *** tbachman has joined #openstack-nova | 14:52 | |
| kashyap | Yeah | 14:52 |
| kashyap | sean-k-mooney: Thanks for the debugging; two birds, one stone. ;-) | 14:53 |
| yonglihe | Surya's comments addressed. thanks. https://review.openstack.org/#/c/621474/27 | 14:53 |
| sean-k-mooney | you could argue there is also a nova bug here in that nova did not validate the image metadata property before passing it to libvirt | 14:53 |
| kashyap | sean-k-mooney: That, too. | 14:54 |
| yonglihe | jaypipes: topology patch rebase to microversion 2.72 https://review.openstack.org/#/c/621476/ | 14:54 |
| *** moshele has joined #openstack-nova | 14:54 | |
| *** sdake has quit IRC | 14:55 | |
| *** mrch_ has quit IRC | 14:56 | |
| *** hongbin has joined #openstack-nova | 14:56 | |
| *** pcaruana has joined #openstack-nova | 14:57 | |
| mriedem | gibi: -1 on https://review.openstack.org/#/c/625310/ as well | 14:59 |
| *** itlinux has joined #openstack-nova | 14:59 | |
| kashyap | sean-k-mooney: Can you tell the libvirt/QEMU version you tested with, please? | 15:00 |
| mriedem | stephenfin: you should probably take a look at this before me https://review.openstack.org/#/c/625311/ | 15:01 |
| * stephenfin looks | 15:01 | |
| *** sdake has joined #openstack-nova | 15:02 | |
| sean-k-mooney | ubuntu@os-vif-1:/opt/stack/nova$ qemu-system-x86_64 --version | 15:03 |
| sean-k-mooney | QEMU emulator version 2.11.1(Debian 1:2.11+dfsg-1ubuntu7.9) | 15:03 |
| sean-k-mooney | Copyright (c) 2003-2017 Fabrice Bellard and the QEMU Project developers | 15:03 |
| cfriesen | mriedem: not sure what you mean by this comment: https://review.openstack.org/#/c/620706/25/nova/compute/api.py@612 | 15:03 |
| sean-k-mooney | ubuntu@os-vif-1:/opt/stack/nova$ libvirtd --version | 15:03 |
| sean-k-mooney | libvirtd (libvirt) 4.0.0 | 15:03 |
| *** dpawlik has quit IRC | 15:03 | |
| *** s10 has quit IRC | 15:04 | |
| mriedem | cfriesen: reference to https://review.openstack.org/#/c/620706/25/nova/compute/api.py@3569 | 15:04 |
| *** s10 has joined #openstack-nova | 15:05 | |
| *** ttsiouts has joined #openstack-nova | 15:06 | |
| mriedem | cfriesen: left another comment | 15:06 |
| mriedem | i'd care less about that if it wasn't copy/paste | 15:06 |
| mriedem | DRY that up | 15:06 |
| mriedem | please | 15:06 |
| *** ShilpaSD has joined #openstack-nova | 15:08 | |
| *** igordc has quit IRC | 15:11 | |
| *** s10 has quit IRC | 15:13 | |
| *** s10 has joined #openstack-nova | 15:14 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add "master" parameter to ip.set() API function https://review.openstack.org/639702 | 15:14 |
| sean-k-mooney | jaypipes: stephenfin by the way i missed ^ in the brctl removal so we need to respin os-vif... | 15:15 |
| jaypipes | yonglihe: yes, I have that in my queue. I have major concerns about the response format in that patch. It is mixing the concept of a guest's virtual CPU topology with that of the NUMA information, and the two things don't really have anything to do with each other -- and unfortunately the way that InstanceNUMATopology and InstanceNUMACell objects were designed, that bad coupling is now going to leak out through the public REST API, which is a | 15:15 |
| jaypipes | problem I raised during the spec review I believe. | 15:15 |
| *** eharney_ is now known as eharney | 15:16 | |
| *** moshele has quit IRC | 15:18 | |
| *** hongbin has quit IRC | 15:18 | |
| *** moshele has joined #openstack-nova | 15:20 | |
| *** hongbin has joined #openstack-nova | 15:20 | |
| *** liuyulong has quit IRC | 15:21 | |
| *** liuyulong has joined #openstack-nova | 15:22 | |
| *** _hemna has quit IRC | 15:22 | |
| *** markvoelker has joined #openstack-nova | 15:22 | |
| cfriesen | mriedem: regarding https://review.openstack.org/#/c/620706/25/nova/compute/api.py@3569 if I do that then wouldn't I need to change the existing code in _validate_flavor_image() where it's doing stuff like image.get('properties', {})? | 15:24 |
| *** wolverineav has quit IRC | 15:24 | |
| stephenfin | mriedem, gibi: Reviewed https://review.openstack.org/#/c/625311/ Two main issues plus a lot of doc nits (which can be ignored for now) | 15:29 |
| mriedem | cfriesen: yeah i guess you're right | 15:31 |
| *** itlinux_ has joined #openstack-nova | 15:31 | |
| cfriesen | making the other changes now | 15:31 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Fix the api sample docs for microversion 2.68 https://review.openstack.org/639707 | 15:32 |
| dcdawg | I'm trying to run a test "tox -e py27" but get an error File "nova/__init__.py", line 33, in <module> | 15:32 |
| dcdawg | import oslo_service # noqa | 15:33 |
| dcdawg | ImportError: No module named oslo_service | 15:33 |
| dcdawg | Even though I installed the "test-requirements.txt" stuff | 15:33 |
| stephenfin | dcdawg: 'tox -e py27 --recreate' | 15:33 |
| *** sdake has quit IRC | 15:33 | |
| stephenfin | dcdawg: If that doesn't work, it usually means you've introduced a syntax error in your code. 'git stash' your changes and try again to confirm (without '--recreate' this time) | 15:34 |
| *** itlinux has quit IRC | 15:34 | |
| *** ccamacho has quit IRC | 15:35 | |
| *** priteau has quit IRC | 15:35 | |
| *** ccamacho has joined #openstack-nova | 15:35 | |
| *** sdake has joined #openstack-nova | 15:35 | |
| mriedem | gdi this root volume detach/attach just gets more complicated | 15:36 |
| mriedem | artom: so i realize there is a bug in the device tag stuff | 15:36 |
| artom | mriedem, your new API stuff? | 15:37 |
| mriedem | no. you know how you can try to create a server with device tags and we'll fail late and abort the build in the compute service if the compute driver doesn't support device tags? | 15:37 |
| *** moshele has quit IRC | 15:37 | |
| artom | mriedem, yeah | 15:37 |
| mriedem | if you shelve that server and then unshelve it, you could wind up on a host that doesn't support tags either and it won't fail | 15:37 |
| artom | mriedem, that's fun | 15:38 |
| mriedem | which was the argument i think you made when adding tags to the attach volume api - you didn't allow it for shelved offloaded servers because we wouldn't know if the compute we land on supports them, | 15:38 |
| mriedem | but that's already broken | 15:38 |
| artom | mriedem, it's been a while for me with that code, where exactly do we fail? And is that code path not used when we unshelve? Because that's basically a new instance build, no? | 15:39 |
| mriedem | https://github.com/openstack/nova/blob/6efa3861a5a829ba5883ff191e2552b063028bb0/nova/compute/manager.py#L2114 | 15:39 |
| mriedem | ^ is only called during server create | 15:39 |
| mriedem | not unshelve | 15:39 |
| artom | mriedem, yeah, I remember saying "can't do tagged attached with shelved because we have no idea if the eventual compute will support it" | 15:39 |
| mriedem | unshelve is a new spawn of the guest | 15:39 |
| mriedem | sure but we don't know if the eventual compute for server create will support it either | 15:39 |
| mriedem | anyway, see my reply to Kevin_Zheng's email in the ML | 15:40 |
| jangutter | stephenfin: re: https://review.openstack.org/#/c/625311/ I spoke in PM to gibi about this, I think the next review in the series shows why it's needed: the tag is propagated to the scheduler. | 15:40 |
| artom | mriedem, dammit, yeah, _unshelve_instance() straight up driver.spawn()s | 15:40 |
| mriedem | for that matter, | 15:41 |
| mriedem | we could be migrating an instance with device tags to another host that doesn't support it | 15:41 |
| *** ccamacho has quit IRC | 15:41 | |
| mriedem | the breakdown is that we just have no filtering for device tags in the scheduler | 15:41 |
| *** awalende has quit IRC | 15:41 | |
| artom | mriedem, true. We couldn't, back then | 15:41 |
| artom | Now in New Placement Future, we could add it | 15:41 |
| mriedem | we could, we just didn't | 15:41 |
| *** ccamacho has joined #openstack-nova | 15:41 | |
| *** awalende has joined #openstack-nova | 15:42 | |
| mriedem | i think at the time we just said "aggregates?" | 15:42 |
| mriedem | and conveniently forgot about it | 15:42 |
| artom | mriedem, no, we just didn't consider it, I think | 15:42 |
| artom | Well, except for the boot case | 15:42 |
| mriedem | i remember asking about a scheduler filter | 15:42 |
| *** helenafm has quit IRC | 15:42 | |
| artom | Well, we already have ComputeCapabilitiesFilter... | 15:42 |
| mriedem | because the server create aborts | 15:42 |
| mriedem | which is pretty severe | 15:42 |
| artom | Should get shoved in there, somewhere, no? | 15:43 |
| mriedem | that would have been the option | 15:43 |
| mriedem | anyway the better answer now is likely based on https://review.openstack.org/#/c/538498/ | 15:43 |
| mriedem | with a placement request filter | 15:44 |
| artom | mriedem, I see - New Placement Future indeed ;) | 15:44 |
| mriedem | having said all this, anyone running mixed hypervisors in the same region is probably asking for trouble | 15:45 |
| mriedem | and anyone running only a hypervisor driver that doesn't support tags should be disabling it in the api via policy | 15:45 |
| mriedem | like if you're just a vio shop | 15:45 |
| artom | ... I don't think we have an API policy for it, do we? | 15:45 |
| mriedem | i thought we did but i guess not | 15:46 |
| mriedem | super | 15:46 |
| *** awalende has quit IRC | 15:46 | |
| *** itlinux_ has quit IRC | 15:46 | |
| *** sapd1 has quit IRC | 15:46 | |
| artom | I'll add a patch(es) on top of aspiers's to fix this. | 15:47 |
| mriedem | anything in the api that isn't supported by all backend compute drivers should probably be controlled via policy... | 15:47 |
| artom | Would this be considered a bug? Ie, is it fair game after FF? | 15:47 |
| aspiers | kashyap: did you see https://bugzilla.redhat.com/show_bug.cgi?id=1683471#c7 | 15:47 |
| openstack | bugzilla.redhat.com bug 1683471 in libvirt "getDomainCapabilities claims SEV is supported for pc-i440fx-1.4 machine type" [Unspecified,New] - Assigned to libvirt-maint | 15:47 |
| mriedem | artom: i'm not even sure what we're trying to fix at this point honestly - scheduling? | 15:47 |
| jroll | jaypipes: have a quick question on one of your comments on 635006 while I'm writing tests, if you have a minute | 15:47 |
| mriedem | artom: adding a placement request filter based on compute capabilities traits is likely a blueprint | 15:48 |
| artom | mriedem, yeah - don't schedule an instance with tags on a host that can't tag | 15:48 |
| mriedem | i.e. https://blueprints.launchpad.net/nova/+spec/expose-host-capabilities | 15:48 |
| *** ccamacho has quit IRC | 15:48 | |
| kashyap | aspiers: Yes, I saw. | 15:48 |
| *** ccamacho has joined #openstack-nova | 15:48 | |
| mriedem | idk, definitely something i wouldn't rush in the 2 weeks of FF | 15:48 |
| kashyap | aspiers: I was incidentally talking to the same libvirt dev on machine types (he too was looking for docs) | 15:48 |
| mriedem | at this point the design impacts of root volume attach are also making this very risky | 15:49 |
| artom | mriedem, hah, indeed - and anyways I'm already rushing NUMA LM | 15:49 |
| kashyap | aspiers: I'll write some common documentation on machine types that serves us (and any other tools that use libvirt/QEMU). Basing off of this: https://kashyapc.fedorapeople.org/v2-gracefully-handle-qemu-machine-types.rst.txt | 15:49 |
| * mriedem feels like getting in the fetal position | 15:49 | |
| *** moshele has joined #openstack-nova | 15:49 | |
| artom | mriedem, have you tried alcoholism? | 15:50 |
| aspiers | haha | 15:50 |
| artom | mriedem, I'll be at PTG, we can hash this out - is root volume attach/detach going to be in Stein? | 15:50 |
| *** rpsene has quit IRC | 15:51 | |
| artom | (We need a rule in the Nova rule at PTG: the moment some spends more than 30 seconds talking about how to model someting in placement, they get pied in the face) | 15:51 |
| artom | (... We'll also need a massive pie budget) | 15:51 |
| *** ccamacho has quit IRC | 15:51 | |
| artom | *Nova room | 15:51 |
| *** ccamacho has joined #openstack-nova | 15:51 | |
| *** ccamacho has quit IRC | 15:51 | |
| *** ccamacho has joined #openstack-nova | 15:52 | |
| *** ccamacho has quit IRC | 15:54 | |
| *** ccamacho has joined #openstack-nova | 15:54 | |
| *** markvoelker has quit IRC | 15:56 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: ironic: partition compute services by conductor group https://review.openstack.org/635006 | 15:58 |
| mriedem | artom: the root volume attach/detach stuff is trying to get into stein | 15:58 |
| mriedem | which is how i came across this issue while reviewing the change | 15:58 |
| mriedem | anyway i'll start by reporting a bug | 15:58 |
| *** ivve has quit IRC | 16:01 | |
| melwitt | o/ | 16:05 |
| mriedem | artom: https://bugs.launchpad.net/nova/+bug/1817927 | 16:05 |
| openstack | Launchpad bug 1817927 in OpenStack Compute (nova) "device tagging support is not checked during move operations" [Undecided,New] | 16:05 |
| artom | mriedem, ack | 16:05 |
| artom | mriedem, I put a drive-by comment in the ML about root detach, btw | 16:06 |
| *** takamatsu has quit IRC | 16:09 | |
| *** udesale has quit IRC | 16:10 | |
| artom | "volume workflow since in these cases, we want to keep the BDM record but reset some fields." Can that part change? Is a BDM without a volume ID really still a BDM? | 16:10 |
| artom | (from https://review.openstack.org/#/c/614750/) | 16:10 |
| mriedem | not all bdms are volumes | 16:10 |
| artom | Anyways, I know I'm jumping in here super late and talking out of my butt | 16:11 |
| mriedem | even if you don't boot from volume, there is an image bdm for the local disk | 16:11 |
| mriedem | BDM.is_volume is what tells you if it represents a volume | 16:11 |
| artom | But there's still "something" there, right? image ID, volume ID? | 16:11 |
| mriedem | yes there would be in those other non-volume cases | 16:12 |
| mriedem | not for a detached root volume | 16:12 |
| artom | OK, so my question still makes sense - if a BDM has nothing to "back" it, is it still a BDM? | 16:13 |
| mriedem | it's a placeholder | 16:13 |
| mriedem | there are probably other ways to model this, and i seem to remember some of that discussion during the spec review, but none of it is great | 16:13 |
| artom | It's almost as though it'd need to be split in half: the instance side, and the "backing" side | 16:14 |
| artom | Anyways, yeah, way too late to talk about design at this stage | 16:14 |
| mriedem | there has to be *something* that nova can use to indicate that the root volume is detached | 16:15 |
| artom | (And the tags would move to the "backing" side - because they're a nova concept, but they apply to the volume, not the attachment, strictly speaking) | 16:15 |
| mriedem | in case the user tries to attach a new root volume or do something like shelve offload, detach root, unshelve (without re-attaching a root volume) | 16:16 |
| *** s10 has quit IRC | 16:16 | |
| artom | mriedem, yeah, there needs to be a placeholder, as you said | 16:16 |
| artom | OK, brainstorming here, how about this: split image_id, volume_id, snapshot_id and tag (and whatever else is needed) into a new "BlockDeviceBacking" object or whatever | 16:17 |
| artom | And null *that* on a detached root volume | 16:17 |
| artom | But persist that BlockDeviceBacking | 16:18 |
| artom | And if the same root volume is re-attached, re-join those two objects? | 16:18 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: add addtion check and gate jobs for os-vif https://review.openstack.org/639732 | 16:21 |
| mriedem | no thanks | 16:21 |
| mriedem | i need to move on from this before i become too depressed to get much done today | 16:21 |
| *** tssurya has quit IRC | 16:21 | |
| *** wolverineav has joined #openstack-nova | 16:22 | |
| *** _hemna has joined #openstack-nova | 16:24 | |
| openstackgerrit | sean mooney proposed openstack/os-vif master: add addtion check and gate jobs for os-vif https://review.openstack.org/639732 | 16:26 |
| aspiers | kashyap: I think I'll make a preliminary patch which extends LibvirtConfigCapsGuest to capture the <emulator> value | 16:27 |
| dcdawg | Beginner question: Can I simply commit spell corrections in the comments of the code or do I have to make a bug report for that? | 16:27 |
| *** abhishekk has joined #openstack-nova | 16:28 | |
| kashyap | aspiers: Alright, I'll keep an eye on that series. (I'm just about to head out for my Dutch class; next 3 1/2 hours) | 16:28 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: add addtion check and gate jobs for os-vif https://review.openstack.org/639732 | 16:28 |
| openstackgerrit | Jim Rollenhagen proposed openstack/nova master: ironic: check fresh data when sync_power_state doesn't line up https://review.openstack.org/636699 | 16:28 |
| *** _hemna has quit IRC | 16:29 | |
| *** tbachman has quit IRC | 16:29 | |
| mriedem | dcdawg: definitely don't need a bug | 16:31 |
| mriedem | depending on the comment you're fixing, if the comment is otherwise not something that can be understood or make sense and needs to be re-written for clarity, sure that's fine | 16:32 |
| mriedem | it's just a simple typo but you still understand what the comment is saying, then patches to fix those are mostly just noise, unless you fix a bunch of stuff in a single change | 16:32 |
| *** hongbin has quit IRC | 16:33 | |
| efried | Hi nova. Do the current args passed into a filter (which appear to be a HostState and a RequestSpec) somewhere contain information from GET /a_c? Namely | 16:34 |
| efried | a) the allocation candidate (allocation_requests[N]) under consideration; and | 16:34 |
| efried | b) (the relevant subset of) the provider_summaries? | 16:34 |
| mriedem | pretty sure no | 16:35 |
| *** abhishekk has quit IRC | 16:35 | |
| *** macza has joined #openstack-nova | 16:35 | |
| efried | HostState.host is a Selection object? | 16:36 |
| mriedem | no, | 16:36 |
| mriedem | it's a ComputeNode.host | 16:36 |
| *** _fragatina has quit IRC | 16:36 | |
| mriedem | HostState is a wrapper of a ComputeNode | 16:36 |
| gibi | mriedem, stephenfin: thanks for the reviews | 16:36 |
| efried | okay; seems like a and b should be something we should start passing into filters, nah? | 16:37 |
| mriedem | we haven't had a need yet | 16:37 |
| efried | as soon as nested starts being real in allocation candidates... | 16:37 |
| *** dcdawg has quit IRC | 16:37 | |
| mriedem | when you have a filter that needs that information then we'll talk about it | 16:37 |
| efried | and until we have every possible filtering and weighing feature natively in placement... | 16:37 |
| mriedem | which we won't | 16:38 |
| efried | right | 16:38 |
| efried | okay, that's fair. But it seems like it would be pretty easy to do. | 16:39 |
| mriedem | nothing is ever easy anymore | 16:39 |
| cdent | was it ever? | 16:39 |
| mriedem | sure | 16:39 |
| mriedem | back in grizzly you could do whatever :) | 16:40 |
| mriedem | it didn't need to actually work | 16:40 |
| * cdent wasn't born then | 16:40 | |
| mriedem | https://media2.giphy.com/media/11fpbdcbnBd5tu/source.gif | 16:40 |
| *** tetsuro has joined #openstack-nova | 16:40 | |
| cdent | efried: you have a concrete use case yet, or preparing for the future? | 16:41 |
| *** hongbin has joined #openstack-nova | 16:41 | |
| efried | cdent: more the latter. | 16:42 |
| cdent | the situation seems to be "lots of things in nova are going to want that info, eventually" | 16:42 |
| efried | I agree with that. | 16:42 |
| efried | But I also sympathize with the notion of: let's not do this just because we think it's a good idea; let's wait until someone actually needs it. | 16:43 |
| cdent | It's the eventually that seems to be causing strain | 16:43 |
| efried | YAGNI? | 16:43 |
| cdent | there's a growing movement to make sure we have contributors who will own that stuff | 16:43 |
| cdent | I guess yagni's a factor, sure, but more: let's not add extra work without adding extra people. If people don't show up, they must not want it. | 16:44 |
| cdent | making that void more visible is a thing I care about quite a bit | 16:44 |
| mriedem | artom: ^ sound familiar? | 16:44 |
| artom | mriedem, heh, I was gonna say | 16:45 |
| jaypipes | jroll: sorry, yes, please go ahead | 16:45 |
| cdent | mriedem: ? | 16:45 |
| mriedem | cdent: artom and i were just talking about that, in a closet | 16:45 |
| artom | Yeah, we've come out of the closet just now | 16:45 |
| cdent | congrats | 16:46 |
| * mriedem covers the hickies | 16:46 | |
| *** gouthamr_ has joined #openstack-nova | 16:46 | |
| *** IvensZambrano has joined #openstack-nova | 16:46 | |
| cdent | so how to visibilate things/ | 16:47 |
| cdent | (not including hickies) | 16:47 |
| edleafe | This should be added somewhere in the OpenStack charter: "let's not | 16:47 |
| edleafe | add extra work without adding extra people. If people don't show up, | 16:47 |
| edleafe | they must not want it." | 16:47 |
| artom | edleafe, people *do* show up. Once. | 16:48 |
| *** gouthamr has quit IRC | 16:48 | |
| artom | And as mriedem was saying, in 2 years of deployers upgrade to the new thing, those people are gone. | 16:48 |
| artom | *when | 16:48 |
| mriedem | i'm not in my 20s anymore, i'm looking for a long-term commitment with contributors | 16:48 |
| artom | o/` If you want it better put a ring on it o/` | 16:50 |
| *** gouthamr has joined #openstack-nova | 16:50 | |
| *** gouthamr_ has quit IRC | 16:50 | |
| *** tetsuro has quit IRC | 16:51 | |
| *** sdake has quit IRC | 16:52 | |
| *** markvoelker has joined #openstack-nova | 16:53 | |
| *** sdake has joined #openstack-nova | 16:54 | |
| *** wolverineav has quit IRC | 16:55 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP status: Ensure templated connection URLs are rendered before use https://review.openstack.org/639607 | 16:56 |
| *** pcaruana has quit IRC | 16:57 | |
| *** _fragatina has joined #openstack-nova | 16:58 | |
| *** gyee has joined #openstack-nova | 16:59 | |
| *** _fragatina_ has joined #openstack-nova | 16:59 | |
| *** rtjure has quit IRC | 17:00 | |
| *** mriedem is now known as mriedem_away | 17:01 | |
| *** sdake has quit IRC | 17:02 | |
| *** _alastor_ has quit IRC | 17:02 | |
| *** _fragatina has quit IRC | 17:02 | |
| efried | mriedem_away, jaypipes, bauzas, gibi: I think https://review.openstack.org/#/c/538498/ is ready to go now, if you want to give it another look-see. | 17:03 |
| efried | (convert compute caps to traits) | 17:04 |
| *** mvkr has quit IRC | 17:04 | |
| *** macza_ has joined #openstack-nova | 17:07 | |
| *** _fragatina_ has quit IRC | 17:07 | |
| *** tbachman has joined #openstack-nova | 17:08 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add remove_resources_from_instance_allocation to report client https://review.openstack.org/639653 | 17:08 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | 17:08 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | 17:08 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | 17:08 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | 17:08 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | 17:08 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance to make place for port healing https://review.openstack.org/637953 | 17:08 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance (2) https://review.openstack.org/637954 | 17:08 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | 17:08 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: cache neutron ports in heal allocation https://review.openstack.org/638207 | 17:08 |
| gibi | mriedem_away: I fixed up https://review.openstack.org/#/c/639653 but I run out of time on https://review.openstack.org/#/c/622421 so I have to do that tomorrow | 17:09 |
| *** macza has quit IRC | 17:10 | |
| *** gbarros has quit IRC | 17:11 | |
| openstackgerrit | Merged openstack/nova master: Fup for the bandwidth series https://review.openstack.org/639159 | 17:13 |
| jaypipes | efried: still says cannot merge on that patch... | 17:15 |
| jroll | jaypipes: oops, I meant I left a question in gerrit, sorry | 17:15 |
| efried | oh? | 17:15 |
| efried | oh. | 17:15 |
| efried | aspiers: ^ looks like needs rebase. Which ugh probably means need to wait until predecessor finishes merging. | 17:16 |
| *** wolverineav has joined #openstack-nova | 17:16 | |
| *** dpawlik has joined #openstack-nova | 17:17 | |
| melwitt | does anyone know what's the correct way to unit test code that calls placement? I found the PlacementFixture nova/tests/functional/fixtures.py but was thinking that's not appropriate for unit tests | 17:18 |
| *** tesseract has quit IRC | 17:22 | |
| efried | melwitt: "unit" and "calls placement" don't really gel. If it's a true unit test, the placement calls ought to be mocked. | 17:22 |
| melwitt | efried: right.. I wondered if there was a specific way to mock them (like a fixture I don't know about) or if it's just ad-hoc | 17:23 |
| efried | melwitt: Do you have a specific example? | 17:23 |
| melwitt | I didn't find any example yet. still looking | 17:23 |
| efried | okay. | 17:23 |
| *** dpawlik has quit IRC | 17:24 | |
| melwitt | I'm working on quota check code that calls placement, so once I added the placement call, lots of unit tests fail | 17:24 |
| melwitt | and if someone happened to know the recommended way to mock placement, that would help me | 17:24 |
| *** tesseract has joined #openstack-nova | 17:24 | |
| efried | melwitt: See nova.tests.unit.scheduler.client.test_report | 17:24 |
| efried | melwitt: Those tests mock SchedulerReportClient.<http primitive like get/put/post/delete> | 17:25 |
| melwitt | thank you | 17:25 |
| *** markvoelker has quit IRC | 17:25 | |
| efried | melwitt: Whereas nova.tests.functional.test_report_client uses the placement fixture to create an interceptor context manager with which to wrap "real" calls to placement. | 17:26 |
| *** moshele has quit IRC | 17:26 | |
| efried | the latter, for functional tests, gets you real placement behavior. The former just lets you pretend you got a certain Response object. | 17:27 |
| melwitt | efried: got it. thanks for the help | 17:27 |
| efried | np, enjoy. | 17:27 |
| *** ttsiouts has quit IRC | 17:31 | |
| *** mrch_ has joined #openstack-nova | 17:31 | |
| efried | melwitt: correction: test_report_client uses PlacementDirect. The difference in usage between that and PlacementFixture is the context manager-ness. | 17:31 |
| *** ttsiouts has joined #openstack-nova | 17:31 | |
| efried | but it sounds like you want the unit level stuff in any case. | 17:31 |
| melwitt | right. but that's good info to know anyway. I'll need to use that too for the functional tests I think | 17:33 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: add addtion check and gate jobs for os-vif https://review.openstack.org/639732 | 17:34 |
| *** jmlowe has quit IRC | 17:34 | |
| efried | melwitt: In case I don't otherwise notice, lmk when you've got code up, would like to review. | 17:34 |
| *** dims has quit IRC | 17:35 | |
| melwitt | efried: the patch that adds placement calls is here https://review.openstack.org/638073 implementation done, test coverage is what I'm working on now | 17:35 |
| *** ttsiouts has quit IRC | 17:36 | |
| efried | ack | 17:36 |
| *** tesseract has quit IRC | 17:36 | |
| *** ivve has joined #openstack-nova | 17:36 | |
| *** tesseract has joined #openstack-nova | 17:38 | |
| *** gbarros has joined #openstack-nova | 17:38 | |
| *** takamatsu has joined #openstack-nova | 17:41 | |
| efried | melwitt: left a comment. So yeah, if you take that advice, you'll probably want a functional test in test_report_client; and you may decide a unit test isn't necessary. | 17:45 |
| *** wolverineav has quit IRC | 17:46 | |
| melwitt | efried: sweet, thanks | 17:46 |
| efried | yw | 17:46 |
| *** efried is now known as efried_afk | 17:47 | |
| *** dims has joined #openstack-nova | 17:48 | |
| *** Sundar is now known as DarthNau | 17:50 | |
| *** tbachman has quit IRC | 17:57 | |
| *** _fragatina has joined #openstack-nova | 17:58 | |
| *** gbarros has quit IRC | 17:58 | |
| *** takamatsu has quit IRC | 18:01 | |
| *** tesseract has quit IRC | 18:02 | |
| *** IvensZambrano has quit IRC | 18:02 | |
| *** moshele has joined #openstack-nova | 18:05 | |
| *** IvensZambrano has joined #openstack-nova | 18:08 | |
| *** panda|ruck is now known as panda|ruck|off | 18:09 | |
| *** moshele has quit IRC | 18:12 | |
| *** tbachman has joined #openstack-nova | 18:12 | |
| *** gbarros has joined #openstack-nova | 18:16 | |
| *** sridharg has quit IRC | 18:22 | |
| *** markvoelker has joined #openstack-nova | 18:22 | |
| *** gbarros has quit IRC | 18:22 | |
| *** _hemna has joined #openstack-nova | 18:25 | |
| *** sdake has joined #openstack-nova | 18:26 | |
| *** wolverineav has joined #openstack-nova | 18:26 | |
| *** erlon has quit IRC | 18:30 | |
| *** _fragatina has quit IRC | 18:31 | |
| *** efried_afk is now known as efried | 18:32 | |
| *** sdake has quit IRC | 18:33 | |
| openstackgerrit | Merged openstack/nova master: Change LibvirtDriver.capabilities to an instance variable https://review.openstack.org/638677 | 18:33 |
| openstackgerrit | Ghanshyam Mann proposed openstack/python-novaclient master: DNM: Testing legacy jobs on bionic https://review.openstack.org/639768 | 18:34 |
| *** _fragatina has joined #openstack-nova | 18:35 | |
| efried | aspiers: predecessor merged ^ -- The rebase is trivial, I would be happy to do that and address artom's nits at the same time, unless you're already working on it | 18:37 |
| aspiers | efried: already working on it | 18:38 |
| efried | okay | 18:38 |
| aspiers | efried: I've already fixed his nits | 18:38 |
| *** sdake has joined #openstack-nova | 18:38 | |
| aspiers | however I think I may have noticed a missing test case | 18:38 |
| *** dcdawg has joined #openstack-nova | 18:38 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/os-vif master: DNM: Testing legacy jobs on bionic https://review.openstack.org/639769 | 18:38 |
| aspiers | efried: if someone uses the placement API to put a capability trait on a compute host, and then at the next periodic the driver declares that cap is unsupported, it needs to be removed, right? | 18:39 |
| efried | yes | 18:39 |
| efried | that's, like, the primary use case here | 18:39 |
| efried | That's not already covered by the tests? | 18:39 |
| aspiers | I think I only tested removal of traits which were put there by the driver | 18:39 |
| aspiers | I'm just checking now | 18:40 |
| efried | okay. It would be one of the test cases with a compute manager reset() in it, if that helps you narrow it down. | 18:40 |
| *** ralonsoh has quit IRC | 18:40 | |
| aspiers | Yeah, it's not there | 18:42 |
| openstackgerrit | Merged openstack/nova master: remove deprecated os_brick import from ScaleIO driver https://review.openstack.org/638592 | 18:42 |
| *** dcdawg has quit IRC | 18:43 | |
| efried | aspiers: be easy to fold it into test_report_cpu_traits | 18:43 |
| *** ivve has quit IRC | 18:43 | |
| aspiers | efried: I think it needs to go in test_servers.TraitsTrackingTests | 18:44 |
| aspiers | that's where all the others are | 18:44 |
| efried | either way. | 18:44 |
| *** sdake has quit IRC | 18:44 | |
| aspiers | unfortunately I've gotta go but I'll push the rebase as soon as I've covered this test case | 18:44 |
| efried | okay. | 18:45 |
| *** jmlowe has joined #openstack-nova | 18:47 | |
| *** jmlowe has quit IRC | 18:47 | |
| *** sdake has joined #openstack-nova | 18:47 | |
| *** jmlowe has joined #openstack-nova | 18:48 | |
| *** mriedem_away is now known as mriedem | 18:50 | |
| *** sdake has quit IRC | 18:51 | |
| *** IvensZambrano has quit IRC | 18:51 | |
| *** takamatsu has joined #openstack-nova | 18:52 | |
| mriedem | efried: jaypipes: +2 on https://review.openstack.org/#/c/639653/ - bottom of the bw series now, adds report client functionality for removing part of allocations from the whole | 18:54 |
| *** markvoelker has quit IRC | 18:56 | |
| *** sdake has joined #openstack-nova | 18:56 | |
| *** _hemna has quit IRC | 18:58 | |
| *** wolverineav has quit IRC | 18:59 | |
| openstackgerrit | sean mooney proposed openstack/os-vif master: Add "master" parameter to ip.set() API function https://review.openstack.org/639702 | 19:06 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: add addtional check and gate jobs for os-vif https://review.openstack.org/639732 | 19:06 |
| sean-k-mooney | jaypipes: melwitt ^ should fix the os-vif bug and add new gate jobs that will catch them in the future. | 19:10 |
| openstackgerrit | Chris Friesen proposed openstack/nova master: Flavor extra spec and image properties validation https://review.openstack.org/620706 | 19:10 |
| sean-k-mooney | we will need to a do a 1.15.1 release to pick up that change. ill do that after teh ci reports back but i have tested it locally with iptables | 19:10 |
| efried | mriedem: I can't remember why we decided to use retrying instead of the home-grown @retries in https://review.openstack.org/#/c/556669/, can you? | 19:11 |
| efried | because I'm inclined to push for same in gibi's | 19:11 |
| mriedem | https://review.openstack.org/#/c/556669/17/nova/utils.py@1301 | 19:12 |
| mriedem | i guess that's not what you're looking for | 19:12 |
| sean-k-mooney | im going to grab dinner and kick off a devstack build of a linux bridge env and validated locally too. | 19:13 |
| mriedem | efried: do you mean, why does SchedulerReportClient use our own retries decorator rather than use retrying the library? | 19:14 |
| mriedem | or the RetryDecorator from oslo? | 19:14 |
| jaypipes | mriedem: ack | 19:14 |
| mriedem | b/c that was added in https://review.openstack.org/#/c/516708/ | 19:14 |
| cfriesen | mdbooth: any chance you could take a look at https://review.openstack.org/#/c/616692/ ? | 19:15 |
| efried | mriedem: Well, report client uses home-grown @retries for a few things and @retrying.retry for others. The latter appear to be my handiwork, as linked above; but I also remember having a conversation with you about the relative merits of using retrying lib vs oslo vs this home-grown thing (which is gross btw). | 19:15 |
| mriedem | i asked https://review.openstack.org/#/c/516708/1/nova/scheduler/client/report.py@97 | 19:15 |
| efried | jaypipes: Don't send that one to the gate too quick. I have a gripe about the retries. | 19:15 |
| mriedem | but no reply | 19:15 |
| *** wolverineav has joined #openstack-nova | 19:16 | |
| *** wolverineav has quit IRC | 19:16 | |
| *** wolverineav has joined #openstack-nova | 19:16 | |
| efried | mriedem: Mm, yeah. IMO we should get rid of that. | 19:16 |
| efried | and at least for now stop adding more usages of it. | 19:16 |
| mriedem | let me phone a friend: dansmith | 19:17 |
| mriedem | i'm assuming he just added his own for simplicity | 19:17 |
| mriedem | and i'm assuming gibi is re-using it because the new code borrows heavily from the claim_resources stuff | 19:17 |
| dansmith | what now? | 19:18 |
| mriedem | why did you write your own https://review.openstack.org/#/c/516708/1/nova/scheduler/client/report.py@97 | 19:18 |
| mriedem | because now gibi is copying it and efried doesn't like it | 19:18 |
| dansmith | oh gah, I dunno.. because I'm not good at remembering all the crap in libraries | 19:19 |
| artom | efried, aspiers, actually, on that capabilities patch, why are we not also adding the driver-owned CUSTOM_ stuff to os_traits? | 19:19 |
| artom | Seems like it would clear stuff up, at the expense of an extra patch that I image won't be difficult to hack up and merge | 19:20 |
| jaypipes | sean-k-mooney: +2 from me on both. | 19:20 |
| artom | *I imagine | 19:20 |
| jaypipes | efried: k | 19:20 |
| jaypipes | mriedem: https://review.openstack.org/#/c/538498/ is showing it needs a rebase anyway. | 19:21 |
| efried | artom: Anything that's a capability-based trait should indeed go into os-traits. Is that what you're saying? | 19:21 |
| artom | efried, yeah | 19:21 |
| efried | random driver-owned CUSTOM_ stuff notsomuch. | 19:21 |
| mriedem | jaypipes: i didn't ask you about that | 19:21 |
| artom | efried, exactl | 19:22 |
| artom | y | 19:22 |
| artom | It's a weird message we're sending to admins | 19:22 |
| efried | jaypipes: that was me. aspiers is working on the rebase (and adding a test case). | 19:22 |
| artom | "The driver owns this stuff, but also this other differently-named stuff that shares a namespace with the stuff you can set" | 19:22 |
| efried | artom: Well, the namespace is COMPUTE_, not CUSTOM_ | 19:23 |
| jaypipes | mriedem: sorry, meant efried :) | 19:23 |
| efried | CUSTOM_ just means it's not in os-traits (yet) | 19:23 |
| efried | artom: Where are you seeing a driver capability-based trait that's not in os-traits? | 19:24 |
| efried | Or are you just concerned about the fact that we're testing that scenario? | 19:24 |
| artom | efried, IMAGECACHE? | 19:24 |
| *** wolverineav has quit IRC | 19:24 | |
| *** DarthNau has quit IRC | 19:25 | |
| efried | mm. mriedem said "optionally" at https://review.openstack.org/#/c/538498/19/nova/virt/driver.py@143 -- whyzat? | 19:25 |
| *** jdillaman has joined #openstack-nova | 19:26 | |
| efried | Trying to think of a scenario (heterogeneous levels of nova-compute / os-traits in a cloud, upgrade, something) where we would *need* to support a custom version of a driver capability trait. | 19:26 |
| mriedem | let me remember something from over a year ago... | 19:26 |
| efried | iow could we just make L1033-5 an exception? | 19:27 |
| mriedem | not all capabilities would have traits, | 19:27 |
| mriedem | like has_imagecache | 19:27 |
| efried | okay, but why does has_imagecache not have a trait? | 19:27 |
| mriedem | but your question is if it's in CAPABILITY_TRAITS_MAP should it also be a standard trait | 19:27 |
| efried | right | 19:28 |
| efried | always | 19:28 |
| mriedem | we don't schedule based on has_imagecache | 19:28 |
| efried | then why are we bothering to add it as a trait? | 19:28 |
| efried | and, who says we wouldn't schedule based on has_imagecache? | 19:28 |
| mriedem | i am | 19:28 |
| mriedem | i am saying that right now | 19:29 |
| efried | Maybe I have a flavor that favors nodes with imagecache | 19:29 |
| *** wolverineav has joined #openstack-nova | 19:29 | |
| mriedem | the day we schedule based on has_imagecache is the day i go work at walgreens | 19:29 |
| efried | then wy are we bothering to add it as a trait? | 19:29 |
| efried | on the compute provider | 19:29 |
| mriedem | you're talking about L1034 right? | 19:30 |
| *** betherly has joined #openstack-nova | 19:30 | |
| efried | yes | 19:30 |
| mriedem | gdi, did i write that code? | 19:30 |
| artom | That should be, like, our motto. | 19:31 |
| efried | yes, it is present in PS7 (though with normalize_name done manually, tsk) | 19:31 |
| *** igordc has joined #openstack-nova | 19:31 | |
| efried | as well as the corresponding comment on L1023 | 19:32 |
| mriedem | looking at https://review.openstack.org/#/c/538498/7/nova/virt/driver.py | 19:32 |
| mriedem | i was probably doing it because supports_trusted_certs wasn't in os-traits at the time | 19:32 |
| mriedem | and didn't think about how that would generate CUSTOM_HAS_IMAGECACHE | 19:32 |
| mriedem | and i think https://review.openstack.org/#/c/538498/7/nova/virt/driver.py@145 | 19:32 |
| mriedem | relates to something i asked jaypipes when he started adding these to os-traits | 19:32 |
| mriedem | so let me dig that up and i can redirect you to jaypipes | 19:33 |
| efried | buck about to be passed | 19:33 |
| mriedem | https://review.openstack.org/#/c/546713/ | 19:33 |
| jaypipes | damn | 19:33 |
| efried | I'm not really concerned about whodunit; what's the right thing here? Should we make it a rule that compute driver capability traits must be standard, and anything that's not will be ignored? | 19:33 |
| mriedem | "I don't seehas_imagecachesupports_recreatesupports_migrate_to_same_host" | 19:33 |
| mriedem | "None of those things are capabilities that a flavor or image would require." | 19:34 |
| efried | that conversation sounds familiar | 19:34 |
| efried | I was apparently convinced enough to +2 the thing. | 19:34 |
| mriedem | "Eric Fried Mar 29, 2018 Patch Set 1: Code-Review+1Okay, I'm convinced we don't need the missing capabilities as traits. Thanks for your patience, all." | 19:34 |
| *** betherly has quit IRC | 19:34 | |
| efried | artom signed off on it too. | 19:35 |
| efried | so, fine, we decided we didn't need them to be standard, and the reason was because we didn't think they would need to be scheduled to. So the question remains: do we need to put them onto the compute node as traits? (Given ^ they would be CUSTOM_ fo sho) | 19:35 |
| mriedem | i think i would agree that if a compute driver capability is going to be reported as a trait, it should probably be a standard trait | 19:35 |
| artom | efried, yeah, but that's like saying a kid ate some candy ;) | 19:35 |
| artom | And in my defense, 'twas me who started this whole kerfuffle we're in now | 19:36 |
| *** ttsiouts has joined #openstack-nova | 19:36 | |
| efried | yup, so it's only fair that the blame ended up back atcha. | 19:36 |
| artom | But... was it a *useful* kerfuffle? | 19:36 |
| mriedem | especially because if we added a new driver capability, like supports_trusted_certs, and before it's standard we report CUSTOM_SUPPORTS_TRUSTED_CERTS and then we have a standard trait and it becomes COMPUTE_TRUSTED_CERTS, that's going to be a weird situation for anyone building flavors requiring the former | 19:36 |
| artom | Or did we just re-hash a past discussion to arrive at the same conclusion? | 19:37 |
| efried | artom: No, this is a slightly new discussion and a decision that needs to be made. | 19:37 |
| efried | but we did have to rehash the old discussion as a prerequisite :) | 19:37 |
| artom | \o/ I'm useful! | 19:37 |
| mriedem | i kind of also wish we weren't discussing the design of this ~1 week from feature freeze | 19:37 |
| artom | Sorta | 19:37 |
| efried | mriedem: Yes, there should be no reason we need to introduce a standard trait but wait to use it in nova. | 19:37 |
| mriedem | because i'm going to say "sure whatever you want idk anymore" | 19:37 |
| mriedem | and in a year we'll be saying "wtf did we do this?" | 19:38 |
| efried | jaypipes: Do you agree with mriedem? To paraphrase: If we're going to tag the compute RP with a driver capability trait, it should be a standard trait; and conversely we should not tag the compute RP with a driver capability trait that is not standard; and therefore we should never tag the compute RP with a CUSTOM_* capability trait. | 19:39 |
| *** lbragstad has quit IRC | 19:39 | |
| jaypipes | reading... | 19:39 |
| efried | (note use of 'capability' throughout - obviously the compute RP can get CUSTOM_* traits from elsewhere - admin, update_provider_tree, etc.) | 19:40 |
| *** lbragstad has joined #openstack-nova | 19:41 | |
| jaypipes | efried, mriedem: I feel the same as I did back then. If the thing is a capability of the compute node that an end user could feasibly want to influence scheduling, it should be a standardized os-trait. if it's just an internal implementation of the virt driver that isn't something an end-user would ever care about but is important for the virt driver infrastructure, just make it a simple attribute of the virt driver class. | 19:42 |
| efried | okay, I'll mark up the review for aspiers | 19:43 |
| mriedem | jaypipes: yeah i agree | 19:43 |
| mriedem | as for why the patch was written how it was when i did a year ago, i can only guess (and already did) | 19:43 |
| jaypipes | in the case of trusted certs, if this is something an end user will say "get me on a host that supports trusted certs", then it should be in os-traits as COMPUTE_TRUSTED_CERTS or whatever. | 19:43 |
| mriedem | i believe it is | 19:44 |
| jaypipes | and it sounds like end users do want that (via a flavor of course) so yeah. | 19:44 |
| mriedem | https://github.com/openstack/os-traits/commit/3e0a6ea4f5045e0bdfe5a2e8097a184ba2c93c5a#diff-98123dc3728cad793e21fa497cf05723 | 19:44 |
| mriedem | it's not really the end user | 19:44 |
| mriedem | it's not something on a flavor or image | 19:44 |
| mriedem | it's that the user says 'i want you to honor my request' and we send you to some compute that has no f'ing clue what that thing is | 19:44 |
| mriedem | i.e. placement request filters | 19:45 |
| mriedem | same for multiattach volumes and device tags | 19:45 |
| jaypipes | that's scheduling though. :) | 19:45 |
| jaypipes | but yes. | 19:45 |
| mriedem | my point was just trusted certs are not a flavor/image thing | 19:46 |
| mriedem | you can't build aggregates around them | 19:46 |
| jaypipes | ack | 19:47 |
| mriedem | efried: aspiers: ok documented https://review.openstack.org/#/c/538498/19/nova/virt/driver.py@1034 | 19:48 |
| efried | mriedem: nice, race condition, correctly assumed "furiously" | 19:49 |
| *** spsurya has quit IRC | 19:52 | |
| melwitt | mriedem, dansmith: thanks for the comments on the InstanceMapping.user_id patch. I just replied to mriedem. dansmith, build request doesn't have a user_id field, and request spec has had the user_id field only since rocky. do you think that's ok to rely on? I had been thinking we have to account for request specs older than rocky, but maybe that doesn't make sense because we're trying to account for old instance mappings that are in | 19:52 |
| melwitt | the middle of being scheduled (and something older than rocky should be still in the middle of being scheduled) | 19:52 |
| melwitt | *shouldn't | 19:52 |
| *** markvoelker has joined #openstack-nova | 19:53 | |
| dansmith | melwitt: right, it seems only worse to rely on something that has only existed since stein, but I thought it was on reqspec from well before that | 19:53 |
| dansmith | either way, | 19:53 |
| melwitt | it was added to reqspec in rocky | 19:53 |
| dansmith | *all* IMs are missing it now, only some reqspecs are | 19:53 |
| dansmith | okay | 19:53 |
| melwitt | https://github.com/openstack/nova/commit/6e49019fae80586c4bbb8a7281600cf6140c176a | 19:53 |
| dansmith | just seems like a joined query would be plenty fast, and then we're not just duplicating this again and again | 19:54 |
| dansmith | once per instance per db should be enough :D | 19:54 |
| dansmith | that's two years ago.. is that rocky? | 19:54 |
| melwitt | yeah, I thought that would be older but I notice the included in version shows 18.0.0 | 19:54 |
| dansmith | should be queens right? | 19:55 |
| dansmith | er, actually | 19:55 |
| dansmith | maybe before that? | 19:55 |
| melwitt | must have taken a long time to merge. queens is 17.0.0 | 19:55 |
| dansmith | queens was early '18 | 19:55 |
| melwitt | it merged may 2018 | 19:55 |
| melwitt | https://review.openstack.org/565340 | 19:55 |
| dansmith | ohh, I see, the 2017 date is the first git date I guess | 19:56 |
| melwitt | yeah | 19:56 |
| dansmith | well, anyway, same argument I think | 19:56 |
| melwitt | I'm totally cool with not caring about request specs older than rocky if I got that reassurance | 19:56 |
| dansmith | regardless, you could drop the first two patches and just change how you query for it whenever you do that | 19:57 |
| dansmith | we could fix up old reqspecs on server GET for that matter | 19:58 |
| dansmith | change our IM query to be IM joined with reqspec.user_id, and if null, set it to the instance.user_id we get from the cell before returning to the user | 19:58 |
| dansmith | that would be pretty low overhead I think, | 19:58 |
| *** _pewp_ has quit IRC | 19:58 | |
| dansmith | or just tell people if you want this to be accurate, make sure your migrations are done, just like would have to be the case if we added a new column to IM | 19:59 |
| *** _pewp_ has joined #openstack-nova | 19:59 | |
| *** ccamacho has quit IRC | 20:00 | |
| melwitt | migration for what, request spec? the addition of user_id didn't come with a migration | 20:00 |
| *** wolverineav has quit IRC | 20:00 | |
| *** wolverineav has joined #openstack-nova | 20:01 | |
| melwitt | dansmith ^ | 20:02 |
| dansmith | melwitt: but you'd need one for your column, right? and I'm not sure why we don't have one for the reqspec one | 20:02 |
| melwitt | oh, you mean me add one | 20:03 |
| melwitt | yeah, ok | 20:03 |
| melwitt | man, all that work I did to do all the various user_id populations | 20:03 |
| * melwitt sheds a single tear | 20:03 | |
| dansmith | I'm saying just add one migration, for the field we have, which would be enough for all cases, instead of adding it to another place that has to also get patched up | 20:03 |
| melwitt | I think I'm following now. thanks | 20:04 |
| melwitt | back to the salt mines | 20:04 |
| *** wwriverrat has joined #openstack-nova | 20:06 | |
| *** wwriverrat has left #openstack-nova | 20:06 | |
| dansmith | melwitt: why do we not already have a migration for user_id on reqspec? | 20:06 |
| dansmith | did that just get missed maybe? | 20:06 |
| *** wolverineav has quit IRC | 20:06 | |
| melwitt | dansmith: I dunno. probably wasn't considered important for already existing records | 20:06 |
| dansmith | any idea why? | 20:06 |
| melwitt | no, that's my guess | 20:07 |
| melwitt | mriedem: do you happen to know why we didn't do nova-manage data migration for RequestSpec.user_id? https://review.openstack.org/565340 | 20:08 |
| dansmith | seems really weird to me | 20:08 |
| melwitt | aye | 20:08 |
| dansmith | I think because it's for "out of tree filters" and thus wasn't really done completely | 20:09 |
| dansmith | just another reason not to further proliferate "I need this duplicate info over here so I'll add it again" kinda stuff | 20:09 |
| melwitt | yeah. I was thinking in the box | 20:10 |
| mriedem | melwitt: was never added - as dansmith said, it was added for an out of tree filter (mgagne) that relied on the user_id and therefore a full-fledged data migration wasn't added for existing request specs because we hack them prior to scheduling during moves | 20:11 |
| mriedem | but any persistence of that request_spec.user_id update is purely accidental | 20:11 |
| * mriedem reads scrollback | 20:12 | |
| dansmith | yeah, that's unfortunate | 20:12 |
| melwitt | request spec, what's persisted? what isn't? it's a surprise! | 20:12 |
| mriedem | https://github.com/openstack/nova/commit/6e49019fae80586c4bbb8a7281600cf6140c176a is queens btw | 20:12 |
| dansmith | melwitt: right, let's migrate to make it consistent and remove this point of ambiguity for the future :) | 20:13 |
| mriedem | oh shit i guess that was rocky | 20:13 |
| mriedem | i thought it was older | 20:13 |
| melwitt | YEAH told ya | 20:13 |
| melwitt | it was started way before rocky though | 20:14 |
| melwitt | maybe not way before, but in queens | 20:14 |
| *** gbarros has joined #openstack-nova | 20:14 | |
| *** Sundar has joined #openstack-nova | 20:15 | |
| mriedem | we don't have a db migration for requestspec.user_id b/c it's a json blob | 20:17 |
| mriedem | oh having said that... | 20:17 |
| melwitt | wait what? json blob | 20:17 |
| mriedem | you can't join on a blob | 20:17 |
| dansmith | wait it's not a column? | 20:17 |
| mriedem | nope | 20:18 |
| mriedem | ha | 20:18 |
| mriedem | man, all that work I did to do all the various user_id populations | 20:18 |
| mriedem | oops | 20:18 |
| mriedem | spec = Column(MediumText(), nullable=False) | 20:18 |
| mriedem | everything in request spec is json blob | 20:18 |
| mriedem | so you can't filter on a join | 20:18 |
| mriedem | wahwah | 20:18 |
| dansmith | isn't project_id a column on reqspec? | 20:18 |
| mriedem | hell no | 20:18 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api_models.py#L164 | 20:19 |
| dansmith | ugh, okay, nevermind then | 20:20 |
| mriedem | salt mines averted | 20:20 |
| dansmith | so, if we keep that, | 20:20 |
| dansmith | I'm not sure why we're patching it up in all these places, vs. just on create and doing a migration like normal | 20:20 |
| melwitt | I was thinking to be opportunistic but maybe I went overboard | 20:20 |
| dansmith | it's just a lot harder to reason about correctness | 20:21 |
| melwitt | we do need one for a soft-deleted instance restore at least. but maybe none of the others | 20:21 |
| melwitt | oh wait, no | 20:21 |
| mriedem | i don't think we need the conductor ones | 20:21 |
| mriedem | in https://review.openstack.org/#/c/638574/3 | 20:21 |
| melwitt | since I added soft-deleted instances to the migration | 20:21 |
| mriedem | we want the one on GET /servers/{server_id} | 20:21 |
| dansmith | if we do it opportunitstically, just do it on load, not in 100 places, IMHO | 20:22 |
| dansmith | mriedem: right | 20:22 |
| mriedem | i can't speak for the soft deleted restore thing | 20:22 |
| melwitt | ok, thanks. I pre-emptive optimizationed myself :( | 20:22 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Better handle live migration abort https://review.openstack.org/635440 | 20:23 |
| mriedem | if someone is building servers between the time the scheduler/conductor is new and the api is old, and they miss that race, the data migration can handle it | 20:23 |
| melwitt | no, I think we don't need the soft deleted restore anymore because I included soft deleted in the nova-manage migration. since they could be restored theoretically any time in the future | 20:23 |
| *** cdent has quit IRC | 20:24 | |
| *** gbarros has quit IRC | 20:24 | |
| mriedem | so handle create and GET and that's good enough | 20:24 |
| mriedem | data migration takes care of the rest | 20:24 |
| melwitt | ok, I'll clean that up. thanks | 20:24 |
| *** markvoelker has quit IRC | 20:26 | |
| *** hemna has quit IRC | 20:28 | |
| *** hemna has joined #openstack-nova | 20:29 | |
| *** jmlowe has quit IRC | 20:29 | |
| melwitt | that was an emotional roller coaster | 20:30 |
| openstackgerrit | Merged openstack/nova master: Fix the api sample docs for microversion 2.68 https://review.openstack.org/639707 | 20:31 |
| *** wolverineav has joined #openstack-nova | 20:35 | |
| *** eharney has quit IRC | 20:36 | |
| *** tosky has quit IRC | 20:36 | |
| *** dcdawg has joined #openstack-nova | 20:38 | |
| *** dave-mccowan has quit IRC | 20:38 | |
| *** wolverineav has quit IRC | 20:40 | |
| *** wolverineav has joined #openstack-nova | 20:41 | |
| *** wolverineav has quit IRC | 20:41 | |
| *** wolverineav has joined #openstack-nova | 20:41 | |
| *** dcdawg has quit IRC | 20:42 | |
| *** betherly has joined #openstack-nova | 20:43 | |
| *** dave-mccowan has joined #openstack-nova | 20:44 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Privatize SchedulerReportClient HTTP wrappers https://review.openstack.org/639818 | 20:45 |
| efried | melwitt: FYI as discussed earlier ^ | 20:45 |
| *** wolverineav has quit IRC | 20:45 | |
| *** betherly has quit IRC | 20:48 | |
| *** mikal has joined #openstack-nova | 20:49 | |
| melwitt | efried: ack | 21:00 |
| *** redcavalier has joined #openstack-nova | 21:03 | |
| *** ivve has joined #openstack-nova | 21:03 | |
| *** redcavalier has left #openstack-nova | 21:03 | |
| mriedem | melwitt: ok i've gone a few more patches up in your series | 21:03 |
| mriedem | to the point of the wip and stopped there | 21:03 |
| melwitt | mriedem: been reading through the comments. thanks. indeed I was trying to account for a scenario like, "what if they run nova-manage in the middle of the upgrade but not at the end, how to catch the stragglers". but I realize I might be suffering from not knowing something like, nova-manage is always run once at the end of the upgrade too | 21:05 |
| mriedem | you run it until there are no more to process | 21:05 |
| mriedem | and then when we drop the compat code, | 21:05 |
| mriedem | we put in a blocker migration | 21:06 |
| mriedem | there is no defined time that operators have to run online_data_migrations, they can run it whenever | 21:06 |
| *** mmethot has quit IRC | 21:06 | |
| melwitt | well, if it's run in the middle of the upgrade and run at the exact wrong time, it would come back as "all done" because of the not-yet-scheduled old instance mappings, if there are any | 21:06 |
| mriedem | it should be idempotent, save for the ones that create a marker | 21:06 |
| melwitt | yeah, that's what I had thought, no defined time or way to run online_data_migrations | 21:07 |
| mriedem | but then your counting quota code is going to catch that and do the legacy counting method right? | 21:07 |
| openstackgerrit | Michael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.openstack.org/639826 | 21:07 |
| mriedem | and presumably log something if they haven't opted out of counting from placement b/c of edge or something? | 21:08 |
| melwitt | yes | 21:08 |
| mriedem | so i don't think we need to be super paranoid about it | 21:08 |
| mriedem | and we'll add a blocker schema migration before dropping the compat code | 21:08 |
| melwitt | ok, I see. that's helpful | 21:08 |
| mriedem | i.e. you can't upgrade to U if you haven't done your homework | 21:08 |
| melwitt | right | 21:08 |
| mriedem | of course i'd like dansmith to check my work her | 21:08 |
| mriedem | *her | 21:08 |
| mriedem | di | 21:08 |
| *** jaosorior has quit IRC | 21:08 | |
| mriedem | here | 21:08 |
| mriedem | also, | 21:09 |
| dansmith | I refuse to touch your her | 21:09 |
| mriedem | the GET /servers/{server_id} should catch any that miss that very tight winow | 21:09 |
| mriedem | *window | 21:09 |
| mriedem | b/c the client is going to be polling the API for the server to be ACTIVE | 21:09 |
| mriedem | yeah? | 21:09 |
| melwitt | yeah, I guess, another thought is if I re-worked the online_data_migrations to go the other direction, from instance mappings => cells (which was the original proposal) | 21:10 |
| dansmith | I definitely think the less-complicated and more usual migration and update-on-read approach is good | 21:10 |
| melwitt | but looking at the queued_for_delete migration made me think maybe it would be too inefficient to go the other direction | 21:10 |
| melwitt | the reason it can come back as "all done" is about I made it iterate cells and migrate that way | 21:11 |
| mriedem | hmm | 21:11 |
| melwitt | *when there are instance in-flight being scheduled | 21:11 |
| mriedem | so if i'm cern and i've got 72 cells and running this in batches, | 21:11 |
| mriedem | it's going to query instance mappings from the same cells every time until it find something new to process right? | 21:11 |
| mriedem | e.g. we've migrated everything for cells 1-50 | 21:12 |
| dansmith | are you talking about how to migrate the mappings in a migration? | 21:12 |
| mriedem | to start processing cells after 50, we have to check 1-50 all over again | 21:12 |
| mriedem | https://review.openstack.org/#/c/633351/14/nova/objects/instance_mapping.py@243 | 21:12 |
| dansmith | you process the records by which mappings have a null user_id | 21:13 |
| dansmith | you collate those by cell, and do them in batches against the cell | 21:13 |
| dansmith | you don't re-process anything because you've set the value to non-null once it's done | 21:13 |
| melwitt | yeah, I did it similar to queued_for_delete, it gets instance mappings that have instances in cells | 21:13 |
| mriedem | i don't tihnk that's what this is doing | 21:13 |
| dansmith | I'm describing what it *should* do | 21:14 |
| *** ivve has quit IRC | 21:14 | |
| melwitt | but it will miss instance mappings that don't yet have an instance in a cell (I think) | 21:14 |
| dansmith | the current implementation will you mean | 21:14 |
| melwitt | yeah | 21:14 |
| dansmith | sure, but iterating by cell makes no sense anyway, IMHO | 21:15 |
| mriedem | well it's based on populate_queued_for_delete which dansmith wrote so i hope it's correct :) | 21:15 |
| melwitt | ok :( I will redo it | 21:15 |
| mriedem | well i guess have dansmith look at https://review.openstack.org/#/c/633351/14/nova/objects/instance_mapping.py and make sure we're on the same page | 21:16 |
| *** jmlowe has joined #openstack-nova | 21:17 | |
| dansmith | I probably did the qfd one by cell because you had to get a list of instances not deleted per cell | 21:17 |
| dansmith | or rather, if you don't find an instance deleted per cell, then you mark all of those mappings as not deleted | 21:18 |
| dansmith | but you don't need to do that in this case.. you want to batch/collate by cell, but you can do that with a single query I think in the other case | 21:18 |
| dansmith | neither the user_id or qfd ones probably need to care about things in-flight that don't have that set, | 21:20 |
| dansmith | since you have to run this after you've upgraded your controller code, so things in flight there would already be setting the new value | 21:21 |
| dansmith | meaing, things that don't have a cell yet | 21:21 |
| *** markvoelker has joined #openstack-nova | 21:23 | |
| melwitt | right | 21:25 |
| *** betherly has joined #openstack-nova | 21:25 | |
| melwitt | oh, hm ok. I misread at first | 21:26 |
| melwitt | have to run this after upgraded controller code, so things in flight there would already be setting user_id | 21:26 |
| *** wolverineav has joined #openstack-nova | 21:27 | |
| *** awaugama has quit IRC | 21:27 | |
| dansmith | right you have to have upgraded the code that can handle the new format for a thing before you start running migrations to move them into the new format of course | 21:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Optimize populate_queued_for_delete online data migration https://review.openstack.org/639840 | 21:28 |
| melwitt | what about old controller, in-flight, upgrade controller, run online_data_migrations, doesn't that fall through the cracks? | 21:28 |
| mriedem | while we're talking about this ^ | 21:28 |
| mriedem | melwitt: if we hit that, the GET /servers/{server_id} would migrate the mapping | 21:29 |
| melwitt | ok | 21:29 |
| *** wolverineav has quit IRC | 21:30 | |
| *** wolverineav has joined #openstack-nova | 21:30 | |
| *** betherly has quit IRC | 21:30 | |
| melwitt | ok, will take another stab at this | 21:30 |
| mriedem | this, or something | 21:31 |
| mriedem | something is getting stabbed | 21:31 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: add additional check and gate jobs for os-vif https://review.openstack.org/639732 | 21:31 |
| dansmith | melwitt: for the qfd you mean? I guess maybe, but it would still be cleared once you delete that | 21:31 |
| dansmith | melwitt: for user_id if you process by mapping and not by cell, then it doesn't matter | 21:31 |
| melwitt | no, for user_id | 21:32 |
| melwitt | when you said "user_id doesn't need to care about things in-flight that don't have it set" | 21:32 |
| *** Sundar has quit IRC | 21:33 | |
| dansmith | melwitt: I'm confused if or what you're asking | 21:34 |
| melwitt | dansmith: but I think I get it now that if we process by mapping, it will catch them | 21:34 |
| dansmith | right | 21:34 |
| dansmith | I said | 21:35 |
| melwitt | I was just thinking if we go by cell then we would miss something in a super specific timed case | 21:35 |
| dansmith | "probably don't need to care" meaning that leaking things in flight probably isn't as big of a deal.. but not saying we should ignore them or not try to get them | 21:35 |
| dansmith | sure | 21:35 |
| melwitt | oh, I see. got it | 21:35 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Add support for microversion 2.70 - expose device tags https://review.openstack.org/636779 | 21:37 |
| sean-k-mooney | jaypipes: o/ i fixed yup the typos in https://review.openstack.org/#/c/639732/6 care to +2 +w again? | 21:38 |
| *** mmethot has joined #openstack-nova | 21:42 | |
| *** wolverineav has quit IRC | 21:45 | |
| *** wolverineav has joined #openstack-nova | 21:45 | |
| mriedem | mordred: i think you'll enjoy this https://bugs.launchpad.net/nova/+bug/1817963 | 21:45 |
| openstack | Launchpad bug 1817963 in OpenStack Compute (nova) "API reference tells users to not create servers with availability_zone "nova" but the server create samples use "nova" for the AZ :(" [Medium,Triaged] - Assigned to Matt Riedemann (mriedem) | 21:45 |
| *** eharney has joined #openstack-nova | 21:47 | |
| melwitt | extra points for the sad face | 21:48 |
| mriedem | "don't do this" | 21:48 |
| mriedem | "here is an example of how to create a server, with exactly what not to do" | 21:48 |
| mriedem | "you're welcome" | 21:48 |
| melwitt | go us | 21:49 |
| * artom is amused by his own migate typo | 21:51 | |
| artom | Like something out of Zoolander | 21:51 |
| artom | Bruce Migate | 21:52 |
| melwitt | migrations that run good and do other stuff good too | 21:53 |
| *** markvoelker has quit IRC | 21:56 | |
| artom | What is this, a server for ants? | 21:57 |
| *** mchlumsky has quit IRC | 21:59 | |
| jaypipes | sean-k-mooney: done | 22:00 |
| efried | Howdy folks. How, in the ServersTestBase harness, does one go from a server dict to an Instance object? | 22:06 |
| cfriesen | is anyone aware of weirdness with accessing image_meta in the resize code path in devstack? | 22:06 |
| artom | cfriesen, weirdness? It's a method disguised as a property, but other than that... | 22:07 |
| artom | So, you can't actually set it, IIRC | 22:07 |
| *** betherly has joined #openstack-nova | 22:08 | |
| cfriesen | artom: I'm not seeing entries that I think should be in there. | 22:08 |
| cfriesen | artom: they're in the instance_system_metadata table in the DB | 22:08 |
| *** derekh has quit IRC | 22:09 | |
| artom | cfriesen, lazy-loading? | 22:09 |
| artom | Guessing, mostly | 22:09 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test proper allocation of devices during reshape https://review.openstack.org/639854 | 22:09 |
| *** betherly has quit IRC | 22:12 | |
| efried | mriedem, jaypipes: I think vgpu reshape is ready to go https://review.openstack.org/#/c/636591/ | 22:13 |
| melwitt | efried: AFAIK, I don't think doing that is a thing. why do you want to do it? | 22:14 |
| efried | melwitt: just because there's a libvirt method I want to call that expects Instance. See https://review.openstack.org/639854 | 22:14 |
| melwitt | oh, I see. I haven't seen a test like that before | 22:15 |
| melwitt | mriedem is probably your best bet for an idea | 22:16 |
| *** agopi has quit IRC | 22:16 | |
| mriedem | cfriesen: that's because image meta is stored in instance_system_metadata | 22:17 |
| mriedem | cfriesen: hence https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L126 | 22:17 |
| mordred | mriedem: wow, yea. that's awesome | 22:19 |
| mriedem | efried: commented | 22:19 |
| cfriesen | mriedem: _get_guest_config() is called with "image_meta" as an arg, but image_meta.properties.get('traits_required') returns nothing | 22:19 |
| mriedem | on your test that is | 22:19 |
| mordred | mriedem: have we ever fixed documentation suggesting people not use "RegionOne" as the region names for their clouds? | 22:20 |
| melwitt | heh, well that was easy | 22:20 |
| mriedem | mordred: not familiar | 22:20 |
| efried | thanks mriedem | 22:20 |
| cfriesen | mriedem: I see "image_trait:COMPUTE_SECURITY_TPM_1_2" in table instance_system_metadata though | 22:20 |
| mordred | mriedem: and here I thought you knew everything | 22:20 |
| *** agopi has joined #openstack-nova | 22:20 | |
| mriedem | mordred: i'm selfish and only care about compute api docs | 22:21 |
| mriedem | heh lots o todos here https://developer.openstack.org/api-guide/compute/users.html | 22:21 |
| mriedem | cfriesen: _get_guest_config() called with image_meta from where? the API? | 22:22 |
| artom | Do you think egotistical lobsters are shellfish? | 22:22 |
| mriedem | if only the guy that added all the required image traits stuff was still around... | 22:23 |
| cfriesen | mriedem: this is in the context of LibvirtDriver.finish_migration(). I'm wondering if we're not properly passing in image_meta at all. | 22:23 |
| mriedem | cfriesen: "image_trait" isn't the right prefix silly pants | 22:24 |
| mriedem | https://docs.openstack.org/glance/latest/admin/useful-image-properties.html | 22:24 |
| mriedem | trait:HW_CPU_X86_AVX2=required | 22:24 |
| mriedem | if only the code were freely available... :) | 22:25 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.openstack.org/634605 | 22:25 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Make the use of the CastAsCall fixture configurable https://review.openstack.org/639428 | 22:25 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Full NUMA live migration support https://review.openstack.org/634606 | 22:25 |
| mordred | artom: wow | 22:25 |
| cfriesen | mriedem: the image itself has "trait:...." | 22:25 |
| mriedem | oh b/c we slap on the image_ prefix before storing in system_metadata | 22:25 |
| mriedem | now it comes back to me | 22:25 |
| cfriesen | mriedem: but it in instance_system_metadata it prepends "image_" to it | 22:25 |
| mriedem | is the value "required" | 22:25 |
| mriedem | ? | 22:25 |
| cfriesen | mriedem: yes | 22:25 |
| cfriesen | I'm working my way up the stack trying to figure out where it got lost | 22:26 |
| mriedem | well instance.image_meta -> ImageMeta.from_instance -> instance.system_metadata for all image_ keys | 22:26 |
| mriedem | and it strips the image_ prefix | 22:26 |
| artom | mordred? | 22:26 |
| cfriesen | there's an "image_meta" argument that's passed down the call chain | 22:26 |
| sean-k-mooney | there is also image meta in the instance and the request spec | 22:27 |
| sean-k-mooney | we have several copies of it depended on where you are | 22:27 |
| cfriesen | hmm...ComputeManager._finish_resize_helper() does this: image_meta = objects.ImageMeta.from_dict(image) | 22:29 |
| mordred | artom: "Do you think egotistical lobsters are shellfish?" :) | 22:30 |
| *** agopi has quit IRC | 22:31 | |
| *** sdake has quit IRC | 22:36 | |
| *** dcdawg has joined #openstack-nova | 22:38 | |
| *** dcdawg has quit IRC | 22:43 | |
| cfriesen | mriedem: it looks like the culprit is that call in _finish_resize_helper(). image.properties has "traits_required", but image_meta.properties doesn't. | 22:46 |
| mriedem | cfriesen: i think i know why | 22:48 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/tasks/migrate.py#L296 | 22:48 |
| mriedem | resize gets the RequestSpec.image rather than Instance.image_meta | 22:49 |
| mriedem | which might not have the fancy translation of ImageMeta.properties.traits_required | 22:49 |
| cfriesen | okay, but in _finish_resize_helper() the "image" argument seems to have a valid image.properties | 22:50 |
| cfriesen | the call to objects.ImageMeta.from_dict(image) seems to be corrupting the image properties | 22:50 |
| cfriesen | dropping the "traits_required" | 22:51 |
| cfriesen | looks like "traits_required" has some special-casing in objects/image_meta.py | 22:52 |
| cfriesen | wonder if something is messed up | 22:52 |
| *** sdake has joined #openstack-nova | 22:53 | |
| *** mmethot has quit IRC | 22:57 | |
| openstackgerrit | Merged openstack/os-vif master: Add "master" parameter to ip.set() API function https://review.openstack.org/639702 | 22:58 |
| *** tkajinam has joined #openstack-nova | 23:00 | |
| melwitt | zzzeek: I recently learned func.sum will return a Decimal object (https://review.openstack.org/639216) but I can't find where in the documentation I can learn what type will be returned from various func. can you point me to a doc I missed? | 23:04 |
| *** rcernin has joined #openstack-nova | 23:06 | |
| *** sapd1 has joined #openstack-nova | 23:06 | |
| cfriesen | mriedem: I think I see what's wrong. In _finish_resize_helper() the "image" argument looks like this, with "traits_required" already broken out: http://paste.openstack.org/show/746468/ | 23:08 |
| cfriesen | mriedem: but in ImageMetaProps.from_dict() it ignores "traits_required" and tries to build it up from the original "trait:xxxxxx" image property, which isn't there. | 23:09 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test proper allocation of devices during reshape https://review.openstack.org/639854 | 23:09 |
| sean-k-mooney | cfriesen: the image metadata key never contains a ":" | 23:11 |
| cfriesen | sean-k-mooney: yes it does, for traits | 23:11 |
| mriedem | because it was already transformed and stored in system_metadata | 23:11 |
| sean-k-mooney | cfriesen: nova uses namesapce:key=value | 23:12 |
| sean-k-mooney | cfriesen: are you sure | 23:12 |
| mriedem | ImageMetaProps.from_dict() is expecting the trait:COMPUTE_SECURITY_TPM_1_2=required format | 23:12 |
| sean-k-mooney | i dont think its ment to be supproted | 23:12 |
| mriedem | which in the api it parses to ImageMetaProps.traits_required right? | 23:12 |
| sean-k-mooney | oh ok ignore me then | 23:12 |
| mriedem | and then that is stored in system_metadata | 23:12 |
| cfriesen | sean-k-mooney: https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/glance-image-traits.html | 23:12 |
| cfriesen | mriedem: yep | 23:12 |
| mriedem | and then ImageMetaProps.from_dict from system_metadata image properties only has the "traits_required" entry | 23:12 |
| mriedem | but not the original trait:COMPUTE_SECURITY_TPM_1_2=required | 23:12 |
| mriedem | cfriesen: should be pretty easy to write a test to show the loss during conversion | 23:13 |
| *** moshele has joined #openstack-nova | 23:13 | |
| sean-k-mooney | cfriesen that was proably an oversigt in the spec... | 23:13 |
| mriedem | hasn't been an issue yet because no one has used image traits beyond scheduling yet | 23:13 |
| cfriesen | mriedem: seems likely | 23:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test proper allocation of devices during reshape https://review.openstack.org/639854 | 23:14 |
| *** dave-mccowan has quit IRC | 23:14 | |
| sean-k-mooney | cfriesen: looking at https://github.com/openstack/nova/blob/f7252b586b4b9f5a098fedfa27715b8f7e662af6/nova/notifications/objects/image.py#L184 | 23:15 |
| sean-k-mooney | it looks like its expecting traits_required | 23:15 |
| *** mlavalle has quit IRC | 23:15 | |
| sean-k-mooney | both the schema and field follow the normal convetion and use _ | 23:16 |
| sean-k-mooney | https://github.com/openstack/nova/blob/f7252b586b4b9f5a098fedfa27715b8f7e662af6/nova/notifications/objects/image.py#L253 | 23:16 |
| mriedem | those are the notification objects... | 23:17 |
| cfriesen | sean-k-mooney: https://github.com/openstack/nova/blob/f7252b586b4b9f5a098fedfa27715b8f7e662af6/nova/objects/image_meta.py#L566 seems to explicitly ignore "traits_required" | 23:17 |
| *** dave-mccowan has joined #openstack-nova | 23:20 | |
| sean-k-mooney | hum ok that is stil rather confusing but ok | 23:21 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669 | 23:21 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.openstack.org/634827 | 23:21 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.openstack.org/634828 | 23:21 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.openstack.org/635229 | 23:21 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.openstack.org/634605 | 23:21 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.openstack.org/634606 | 23:21 |
| mriedem | cfriesen: i think that's in the case when the ImageMetaProps is built from the base image meta in the API | 23:22 |
| mriedem | not the already-transferred form from system_metadata | 23:22 |
| mriedem | i think it's meant to avoid setting ImageMetaProps.traits_required if the external image literally has a "traits_required" field | 23:22 |
| cfriesen | I'm checking whether I can use instance.image_meta for nwo | 23:23 |
| mriedem | removing that line probably fixes your problem | 23:23 |
| cfriesen | looks like down in the guts of resize I can use instance.image_meta.properties.get('traits_required') and it works as expected | 23:25 |
| mriedem | ew | 23:25 |
| cfriesen | I think sorting out ImageMetaProps can be a separate issue | 23:25 |
| mriedem | smells down there in the guts | 23:25 |
| *** itlinux has joined #openstack-nova | 23:26 | |
| cfriesen | "instance" is already one of the args | 23:26 |
| sean-k-mooney | cfriesen: i would hope it would be for a resize | 23:26 |
| *** betherly has joined #openstack-nova | 23:32 | |
| *** ttsiouts has quit IRC | 23:32 | |
| sean-k-mooney | cfriesen: one question in https://review.openstack.org/#/c/633256/4 | 23:35 |
| sean-k-mooney | ill try to get to https://review.openstack.org/#/c/631363/9 tommorrow | 23:35 |
| *** harlowja has joined #openstack-nova | 23:36 | |
| cfriesen | sean-k-mooney: cool. I've almost got single-node resize working. would appreciate a test of multinode resize/migrate if you've got time. | 23:36 |
| *** betherly has quit IRC | 23:37 | |
| *** sdake has quit IRC | 23:38 | |
| sean-k-mooney | do i need to install anyting non standard beyond having new enough qemu/libvirt | 23:38 |
| cfriesen | sean-k-mooney: "swtpm" and "swtpm-tools" packages on fedora | 23:38 |
| sean-k-mooney | ok cool ill proably use my centos test vms but i can spin up a fedora one if it does not have the package | 23:39 |
| cfriesen | sean-k-mooney: you're thinking about allowing the flavor to explicitly forbid enabling vTPM? not sure why anyone would want to do that since it's purely a virtual thing. | 23:40 |
| sean-k-mooney | if i have issue with nested virt i also have pysical servers i can test with too | 23:40 |
| sean-k-mooney | cfriesen: it is but an operator may want to forbid it for live migration reasons | 23:40 |
| cfriesen | sean-k-mooney: but we're going to make it support live migration, no? | 23:41 |
| sean-k-mooney | yes but they may have old hyperviors | 23:41 |
| *** sdake has joined #openstack-nova | 23:41 | |
| sean-k-mooney | i guess they would have upgraded to stien anyway so its proably not important | 23:41 |
| cfriesen | sean-k-mooney: then the dest won't advertise the trait | 23:42 |
| *** sdake has quit IRC | 23:42 | |
| sean-k-mooney | ya ok it shoudl be good | 23:42 |
| sean-k-mooney | there some traits that operator may want ot forbid in the falvor expclitly but this likel is not one of them | 23:42 |
| *** moshele has quit IRC | 23:43 | |
| *** awalende has joined #openstack-nova | 23:43 | |
| *** awalende has quit IRC | 23:47 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
