Wednesday, 2019-03-06

eanderssoninteresting00:00
mriedemoh wait...00:00
eanderssonterraform had the same issue00:00
eanderssonand we double checked that we had a version that supports it00:00
eanderssonbrb00:00
mriedemcan you run the osc command with --debug?00:00
mriedemafter you're rb00:00
*** tosky has quit IRC00:00
*** tetsuro has joined #openstack-nova00:02
*** wolverineav has quit IRC00:04
openstackgerritMerged openstack/nova master: Ensure that bandwidth and VF are from the same PF  https://review.openstack.org/62354300:08
openstackgerritMerged openstack/nova master: api-ref: typo service.disable_reason  https://review.openstack.org/64095600:08
openstackgerritMerged openstack/nova master: Handle missing exception in instance creation code  https://review.openstack.org/64108200:08
*** ttsiouts has quit IRC00:11
mriedemeandersson: i'm not seeing it by eyeball but maybe something subtle regressed here https://review.openstack.org/#/c/567534/00:13
*** hongbin has quit IRC00:13
*** sapd1 has quit IRC00:16
openstackgerritEric Fried proposed openstack/nova master: WIP: use ironicclient AdapterClient  https://review.openstack.org/64117000:17
*** wolverineav has joined #openstack-nova00:22
*** hoonetorg has quit IRC00:24
*** hoonetorg has joined #openstack-nova00:26
openstackgerritTakashi NATSUME proposed openstack/nova stable/rocky: Fix an error when generating a host ID  https://review.openstack.org/64117300:29
*** macza_ has quit IRC00:30
*** brinzhang has joined #openstack-nova00:31
*** mlavalle has quit IRC00:33
*** luksky has quit IRC00:35
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Fix RT usage issues in cross-cell resize functional tests  https://review.openstack.org/64117600:36
mriedemKevin_Zheng: figured out another problem ^00:36
openstackgerritBrin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot  https://review.openstack.org/58033600:39
openstackgerritBrin Zhang proposed openstack/nova-specs master: Support delete_on_termination in volume attach api  https://review.openstack.org/61294900:40
*** artom has joined #openstack-nova00:42
*** wolverineav has quit IRC00:48
*** markvoelker has joined #openstack-nova00:49
mriedemcfriesen: does starlingx by chance already have a fix for this? https://review.openstack.org/#/c/641176/1/nova/compute/resource_tracker.py@50400:49
mriedembecause that todo left from https://review.openstack.org/#/c/370374/ is the exact issue i'm hitting,00:50
mriedemresource usage on the source node is not correct until update_available_resource runs00:50
*** wolverineav has joined #openstack-nova00:51
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Fix RT usage issues in cross-cell resize functional tests  https://review.openstack.org/64117600:53
openstackgerritMatt Riedemann proposed openstack/nova master: Fix ProviderUsageBaseTestCase._run_periodics for multi-cell  https://review.openstack.org/64117900:53
*** ileixe has joined #openstack-nova00:56
mriedemcfriesen: sob it does00:57
mriedemhttps://github.com/starlingx-staging/stx-nova/blob/master/nova/compute/resource_tracker.py#L72800:57
*** itlinux has joined #openstack-nova00:58
yongliheabout this topology api, does it had block issue or we just run out of bandwidth? https://review.openstack.org/#/c/621476/01:00
*** mriedem has quit IRC01:00
*** wolverineav has quit IRC01:03
*** wolverineav has joined #openstack-nova01:04
*** whoami-rajat has joined #openstack-nova01:09
Kevin_Zhengmriedem: for cross cell resize? ACK01:09
*** wolverineav has quit IRC01:09
yongliheSean's several suggest directly confilict with current spec, what can i do for that?  help me.01:13
*** oanson has quit IRC01:13
Kevin_Zhengyonglihe I will try to check01:14
yongliheKevin_Zheng, thanks01:15
*** mmethot has joined #openstack-nova01:15
*** gyee has quit IRC01:21
*** mrch has joined #openstack-nova01:21
*** markvoelker has quit IRC01:22
openstackgerritguang-yee proposed openstack/nova master: pass endpoint interface to Ironic client  https://review.openstack.org/64087901:23
*** mrch_ has quit IRC01:24
*** sdake has quit IRC01:29
*** tetsuro has quit IRC01:32
*** wolverineav has joined #openstack-nova01:36
*** itlinux_ has joined #openstack-nova01:39
*** itlinux_ has quit IRC01:40
*** itlinux has quit IRC01:41
openstackgerritMerged openstack/nova master: Improve libvirt image and snapshot handling  https://review.openstack.org/61669201:44
eanderssonI tried the latest openstack client in a lab version of Rocky01:45
eanderssonand soft-anti-affinity does not work there either01:45
*** sdake has joined #openstack-nova01:45
*** mikal has joined #openstack-nova01:47
*** jhesketh has quit IRC01:57
*** lbragstad has quit IRC01:58
*** jhesketh has joined #openstack-nova01:58
*** wolverineav has quit IRC02:00
*** wolverineav has joined #openstack-nova02:00
*** sdake has quit IRC02:05
*** ileixe has quit IRC02:05
*** ileixe has joined #openstack-nova02:08
*** mdbooth_ has quit IRC02:15
*** markvoelker has joined #openstack-nova02:19
*** wolverineav has quit IRC02:22
*** hongbin has joined #openstack-nova02:26
*** wolverineav has joined #openstack-nova02:27
*** sdake has joined #openstack-nova02:29
*** tbachman has quit IRC02:33
*** wolverineav has quit IRC02:40
*** sdake has quit IRC02:42
*** psachin has joined #openstack-nova02:43
*** lbragstad has joined #openstack-nova02:51
*** markvoelker has quit IRC02:52
*** mdbooth has joined #openstack-nova03:09
*** sdake has joined #openstack-nova03:20
*** sdake has quit IRC03:23
*** sdake_ has joined #openstack-nova03:24
*** wolverineav has joined #openstack-nova03:43
*** wolverineav has quit IRC03:44
*** zhubx has quit IRC03:46
*** zhubx has joined #openstack-nova03:47
*** janki has joined #openstack-nova03:49
*** markvoelker has joined #openstack-nova03:49
*** janki has quit IRC03:50
*** janki has joined #openstack-nova03:50
openstackgerritBoxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible  https://review.openstack.org/64027103:56
*** zhubx has quit IRC03:57
*** sdake_ has quit IRC03:58
*** zhubx has joined #openstack-nova03:58
*** wolverineav has joined #openstack-nova03:58
*** markvoelker has quit IRC04:22
openstackgerritMerged openstack/nova master: Check hosts have no instances for AZ rename  https://review.openstack.org/50920604:25
*** ratailor has joined #openstack-nova04:27
*** hongbin has quit IRC04:42
openstackgerritMerged openstack/nova master: Move set_vf_interface_vlan to be with its only caller.  https://review.openstack.org/62422904:59
openstackgerritMerged openstack/nova master: Move DHCP releasing to privsep.  https://review.openstack.org/62423005:00
openstackgerritMerged openstack/nova master: Convert additional IP management calls to privsep.  https://review.openstack.org/62423105:00
openstackgerritMerged openstack/nova master: Move route management to privsep.  https://review.openstack.org/62423205:00
*** sdake has joined #openstack-nova05:03
*** sdake has quit IRC05:03
*** dave-mccowan has quit IRC05:03
*** tetsuro has joined #openstack-nova05:04
*** sdake has joined #openstack-nova05:07
*** marst has joined #openstack-nova05:08
*** bhagyashris_ has joined #openstack-nova05:11
*** sridharg has joined #openstack-nova05:13
*** igordc has joined #openstack-nova05:14
*** marst has quit IRC05:18
*** igordc has quit IRC05:27
*** hoonetorg has quit IRC05:33
*** sdake has joined #openstack-nova05:39
*** wolverineav has quit IRC05:40
*** bhagyashris_ has quit IRC05:43
openstackgerritTakashi NATSUME proposed openstack/nova master: Add a live migration regression test  https://review.openstack.org/64120005:43
openstackgerritTakashi NATSUME proposed openstack/nova master: Add a live migration regression test  https://review.openstack.org/64120005:45
*** johnthetubaguy has quit IRC05:49
*** hoonetorg has joined #openstack-nova05:50
*** johnthetubaguy has joined #openstack-nova05:56
openstackgerritLuyao Zhong proposed openstack/nova master: object: Add pmem_namespaces field to the NUMACell obj  https://review.openstack.org/63454705:58
openstackgerritLuyao Zhong proposed openstack/nova master: object: Add virtual_pmems fields to the InstanceNUMACell obj  https://review.openstack.org/63454805:58
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: Enable driver configures PMEM namespace when initiating libvirt driver  https://review.openstack.org/63454905:58
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: Update PMEM namespaces info and usage  https://review.openstack.org/63455005:58
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: report pmem namespaces resources by provider tree  https://review.openstack.org/63455105:58
openstackgerritLuyao Zhong proposed openstack/nova master: API: parse pmem related flavor extra spec  https://review.openstack.org/63455205:58
openstackgerritLuyao Zhong proposed openstack/nova master: scheduler: translate virtual pmems request to placement request group  https://review.openstack.org/63455305:58
openstackgerritLuyao Zhong proposed openstack/nova master: update _numa_fit_instance_cell for the support of virtual_pmems  https://review.openstack.org/63455405:58
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: boot VM with vpmems and cleanup vpmems when destroying  https://review.openstack.org/63455505:58
openstackgerritLuyao Zhong proposed openstack/nova master: support VM resizing with vpmem data migration  https://review.openstack.org/63455605:58
*** igordc has joined #openstack-nova06:07
*** udesale has joined #openstack-nova06:07
*** igordc has quit IRC06:07
*** wolverineav has joined #openstack-nova06:14
*** wolverineav has quit IRC06:18
*** wolverineav has joined #openstack-nova06:18
openstackgerritMerged openstack/nova master: Flavor extra spec and image properties validation from API  https://review.openstack.org/62070606:23
*** wolverineav has quit IRC06:32
openstackgerritSurya Seetharaman proposed openstack/nova master: Update --max-rows parameter description for archive_deleted_rows  https://review.openstack.org/60699506:35
*** markvoelker has joined #openstack-nova06:49
openstackgerritAbhishek Kekane proposed openstack/nova-specs master: Support multiple backend of Glance  https://review.openstack.org/64121006:52
*** Luzi has joined #openstack-nova06:53
*** ivve has joined #openstack-nova07:00
openstackgerritBoxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible  https://review.openstack.org/64027107:04
openstackgerritmelanie witt proposed openstack/nova master: Count instances from mappings and cores/ram from placement  https://review.openstack.org/63807307:04
openstackgerritmelanie witt proposed openstack/nova master: Use instance mappings to count server group members  https://review.openstack.org/63832407:04
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Add description for BDM volume_size  https://review.openstack.org/64125507:06
openstackgerritmelanie witt proposed openstack/nova master: Add user_id column to the instance_mappings table  https://review.openstack.org/63334907:10
openstackgerritmelanie witt proposed openstack/nova master: Add user_id field to InstanceMapping  https://review.openstack.org/63335007:10
openstackgerritmelanie witt proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules  https://review.openstack.org/63857407:10
openstackgerritmelanie witt proposed openstack/nova master: Add online data migration for populating user_id  https://review.openstack.org/63335107:10
openstackgerritmelanie witt proposed openstack/nova master: Add get_counts() to InstanceMappingList  https://review.openstack.org/63807207:10
openstackgerritmelanie witt proposed openstack/nova master: Count instances from mappings and cores/ram from placement  https://review.openstack.org/63807307:10
openstackgerritmelanie witt proposed openstack/nova master: Use instance mappings to count server group members  https://review.openstack.org/63832407:10
*** cfriesen has quit IRC07:14
openstackgerritAbhishek Kekane proposed openstack/nova-specs master: Support multiple backend of Glance  https://review.openstack.org/64121007:16
*** lbragstad has quit IRC07:17
*** markvoelker has quit IRC07:21
*** luksky has joined #openstack-nova07:35
*** bhagyashris has joined #openstack-nova07:38
*** luksky has quit IRC07:39
*** ccamacho has joined #openstack-nova07:41
yonglihesean-k-mooney: ping07:47
yonglihehttps://docs.google.com/document/d/1kRRZFq_ha0T9mFDOEzv0PMvXgtnjGm5ii9mSzdqt1VM/edit#heading=h.kn16u3i4dj8507:56
yongliheI collected your commets in google docs and anyone could edit or comment it, i given my opion about them,  some of them needs discuss.07:57
*** rpittau|afk is now known as rpittau08:02
*** dtantsur|afk is now known as dtantsur08:03
*** dtantsur is now known as dtantsur|mtg08:03
*** wolverineav has joined #openstack-nova08:03
*** tesseract has joined #openstack-nova08:07
*** wolverineav has quit IRC08:08
*** tkajinam has quit IRC08:09
*** wolverineav has joined #openstack-nova08:10
*** awalende has joined #openstack-nova08:15
*** wolverineav has quit IRC08:17
*** wolverineav has joined #openstack-nova08:18
*** phasespace has joined #openstack-nova08:19
*** markvoelker has joined #openstack-nova08:19
*** helenafm has joined #openstack-nova08:23
*** tosky has joined #openstack-nova08:29
*** pcaruana has joined #openstack-nova08:29
*** takashin has left #openstack-nova08:31
*** tssurya has joined #openstack-nova08:33
*** ralonsoh has joined #openstack-nova08:38
openstackgerritMerged openstack/nova master: Validate PCI aliases early in resize  https://review.openstack.org/64113108:42
*** xek has joined #openstack-nova08:49
openstackgerritZhenyu Zheng proposed openstack/nova master: Should not skip volume_size check for bdm.image_id == image_ref case  https://review.openstack.org/64128208:50
*** markvoelker has quit IRC08:52
*** dpawlik has joined #openstack-nova08:57
openstackgerritBalazs Gibizer proposed openstack/nova master: Use Selection object to fill request group mapping  https://review.openstack.org/63871109:05
*** ttsiouts has joined #openstack-nova09:08
*** ttsiouts has quit IRC09:13
*** dpawlik has quit IRC09:17
*** wolverineav has quit IRC09:19
*** tetsuro has quit IRC09:35
*** derekh has joined #openstack-nova09:37
*** markvoelker has joined #openstack-nova09:49
*** moshele has joined #openstack-nova09:50
*** bhagyashris has quit IRC09:54
openstackgerritBalazs Gibizer proposed openstack/nova master: Warn if group_policy is missing from flavor  https://review.openstack.org/64128910:05
gibisimple patch ^^10:06
bauzasgibi: +2d10:19
openstackgerritMerged openstack/nova master: Move additional IP address management to privsep.  https://review.openstack.org/62459110:21
*** markvoelker has quit IRC10:22
gibibauzas: thanks10:23
gibibauzas: this the that API patch for bandwidht, turning the functionalty on https://review.openstack.org/#/c/636360/10:24
gibibauzas: mriedem already +2-d it10:24
bauzasI know, I was planning to vote on it soon10:24
gibibauzas: cool. thanks10:24
openstackgerritBalazs Gibizer proposed openstack/nova master: Test macvtap port with resource request  https://review.openstack.org/64130910:33
gibiit is a functional test only patch ^^10:33
gibisean-k-mooney: ^^10:34
*** moshele has quit IRC10:40
*** cdent has joined #openstack-nova10:49
openstackgerritNeil Jerram proposed openstack/nova master: Allow utime call to fail on Flat image base file  https://review.openstack.org/64131510:52
*** wolverineav has joined #openstack-nova10:53
*** udesale has quit IRC10:57
*** wolverineav has quit IRC10:57
*** xek has quit IRC10:58
*** xek_ has joined #openstack-nova10:58
*** zhubx has quit IRC10:59
*** zhubx has joined #openstack-nova10:59
*** thgcorrea has joined #openstack-nova11:00
*** FlorianFa has quit IRC11:01
*** FlorianFa has joined #openstack-nova11:02
*** helenafm_ has joined #openstack-nova11:04
*** pcaruana has quit IRC11:04
*** mikal has quit IRC11:04
openstackgerritStephen Finucane proposed openstack/nova master: objects: Store InstancePCIRequest.numa_policy in DB  https://review.openstack.org/62444411:06
openstackgerritStephen Finucane proposed openstack/nova master: fakelibvirt: Add ability to generate fake PCI devices  https://review.openstack.org/64040911:06
openstackgerritStephen Finucane proposed openstack/nova master: tests: Create PCI tests for NUMA'y tests  https://review.openstack.org/64082611:06
*** helenafm has quit IRC11:06
stephenfingibi, bauzas: Any chance you could take a look at those today (or at least the bottom one)?11:06
bauzasstephenfin: sure, I dedicated my time today for reviews11:07
*** moshele has joined #openstack-nova11:07
bauzasspread the word11:07
gibistephenfin: looking11:08
*** erlon has joined #openstack-nova11:09
*** panda|ruck|off is now known as panda|ruck|flu11:10
gibistephenfin: I'm +2 on the whole series. It really made those sriov tests more readable at the end11:14
stephenfingibi: Sweet. Thanks.11:14
stephenfingibi: I'd been thinking about maybe using Jinja2 templates for that entire file, but I'll tackle that later/separately :)11:15
stephenfingibi: If it's not too much, this might also be of interest to you https://review.openstack.org/#/c/636383/ (another clean up'y one)11:16
*** erlon has quit IRC11:16
*** erlon has joined #openstack-nova11:17
gibistephenfin: I will check that after launch11:18
gibilunch11:18
stephenfinta :)11:18
*** markvoelker has joined #openstack-nova11:19
*** pcaruana has joined #openstack-nova11:32
*** dave-mccowan has joined #openstack-nova11:45
openstackgerritNeil Jerram proposed openstack/nova master: Allow utime call to fail on qcow2 image base file  https://review.openstack.org/64131511:46
*** markvoelker has quit IRC11:52
*** xek_ has quit IRC11:54
*** ratailor has quit IRC11:54
*** erlon has quit IRC12:03
*** erlon has joined #openstack-nova12:04
*** mvkr has joined #openstack-nova12:13
*** ttsiouts has joined #openstack-nova12:16
*** mdbooth has quit IRC12:21
openstackgerritMerged openstack/nova master: Fix WeighedHost logging regression  https://review.openstack.org/64114312:25
*** tetsuro has joined #openstack-nova12:31
*** brinzhang has quit IRC12:31
*** udesale has joined #openstack-nova12:38
*** markvoelker has joined #openstack-nova12:49
*** mchlumsky has joined #openstack-nova13:02
*** mdbooth has joined #openstack-nova13:05
*** TheJulia_sick is now known as TheJulia13:05
openstackgerritEric Fried proposed openstack/nova master: Warn if group_policy is missing from flavor  https://review.openstack.org/64128913:15
*** ttsiouts has quit IRC13:17
*** ttsiouts has joined #openstack-nova13:18
*** liuyulong_zzz is now known as liuyulong13:19
*** markvoelker has quit IRC13:22
*** ttsiouts has quit IRC13:23
fricklereandersson: check whether your compute endpoint is v2 or v2.1. the former doesn't support microversions.13:23
fricklerprobably osc should do some better guarding against that13:24
sean-k-mooneyfrickler: osc does not support auto microversions either but yes if you pass one explcitly i coudl check that you are not using the v2 endpoint13:25
fricklersean-k-mooney: see the backlog from yesterday. "openstack --os-compute-api-version 2.15 server group create anti-affinity-test --policy soft-anti-affinity" fails when I change my compute endpoint url from /v2.1 to /v213:26
sean-k-mooneyfrickler: sure you are using an explcitly microverions it could guard against that but osc doese not really have any special logic to handel microversions13:27
*** ttsiouts has joined #openstack-nova13:28
fricklersean-k-mooney: hmm, o.k., maybe then nova should throw an error when the client requests 2.15 instead of silently falling back to 2.0 behaviour13:29
sean-k-mooneythat woudl be a backwards incompatiable chagne13:30
sean-k-mooneyand would break those that expect it13:30
sean-k-mooneythe v2 endpoint is unversioned so by deffinion it shoudl not be doing version checks13:30
yonglihesean-k-mooney: hi, good morning13:30
openstackgerritAndrey Volkov proposed openstack/nova stable/rocky: Check hosts have no instances for AZ rename  https://review.openstack.org/64135113:31
fricklersean-k-mooney: hmm, o.k., let's wait for eandersson to confirm whether I located his issue before continuing that discussion ;)13:32
*** tacco is now known as oekotaco13:33
*** mriedem has joined #openstack-nova13:34
mriedemsean-k-mooney: https://blueprints.launchpad.net/nova/+spec/libvirt-neutron-sriov-livemigration is next in the runways slot but is that going to make stein in the next 24 hours?13:38
mriedemmy guess is no looking at the state of the series13:38
yonglihemriedem, sean-k-mooney: any suggest on https://review.openstack.org/#/c/621476/?  sean-k-mooney had quiet a lot concern about the sockets/threads/cores that reported to user.13:40
mriedemyonglihe: the contents of that regarding numa are not my strong area so i will have to defer to sean-k-mooney and stephenfin and others13:41
yongliheok, i collected them into https://docs.google.com/document/d/1kRRZFq_ha0T9mFDOEzv0PMvXgtnjGm5ii9mSzdqt1VM/edit# , might be easier to work on.   sean-k-mooney , stephenfin.13:43
mriedemtssurya: i copied you on an email to jose about https://review.openstack.org/#/c/613039/ since he's at cern as well - just fyi13:43
yonglihebut seems time for stein is quite tight.13:43
mriedemtssurya: since we've got <24 hours to land that13:43
mriedemyonglihe: yes it is13:43
tssuryamriedem: ack, thanks13:43
mriedemtssurya: i'm of course assuming cern is very small and everyone knows everyone else and what they are working on...13:44
sean-k-mooneyyonglihe: o/13:44
tssuryamriedem: yep I am going to pass by his office now :)13:44
mriedemtssurya: oh heh i was just joking13:44
mriedembut cool13:44
openstackgerritMerged openstack/nova master: Validate bandwidth configuration for other VIF types  https://review.openstack.org/63638313:45
openstackgerritMerged openstack/nova master: Further de-dupe os-vif VIF tests  https://review.openstack.org/63638413:45
sean-k-mooneyyonglihe: so overall i dont think the datamodel is quite right. given the time constraitns i personally would be more comfortable waiting for train to finalise it but i can take a look at the google doc. etherpad thens to be a good choice for this kind of thing also13:46
*** josecastroleon has joined #openstack-nova13:47
sean-k-mooneyyonglihe: one of the main issues is the current proposed api is coupeling cpu topology and numa topology but they are independnt fo each other which is why im concerned the current data model is missleading13:47
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Fix WeighedHost logging regression  https://review.openstack.org/64135513:48
yonglihesean-k-mooney, yeah, i get that. it's mass. how about delete the cpu topology  toltally.13:49
*** tetsuro has quit IRC13:50
bauzasgibi: +Wd with a comment on https://review.openstack.org/#/c/636360/2313:51
yongliheconsiderating the time factor, it's up to you choosing what we can do on the stein, or postpone to next release. both ok for me.13:51
sean-k-mooneyyou could or you could group it seperatly. e.g. in the toployg endpoint you get back a dict with two fields {cpu_toplolgoy:{}, numa_toplogy[{},{}]}13:51
*** pcaruana has quit IRC13:51
*** tetsuro has joined #openstack-nova13:51
*** eharney has joined #openstack-nova13:51
gibibauzas: thanks, replied13:51
tssuryamriedem: josecastroleon is working on it13:52
bauzasgibi: great, that works with me13:52
gibicool13:52
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Fix WeighedHost logging regression  https://review.openstack.org/64135913:52
bauzasfor docs, I dunno where to land docs13:52
bauzasgiven that's both neutron/nova13:52
bauzasstephenfin: thoughts for doc'ing bandwith RPs feature ?13:53
bauzasin nova, neutron or both ?13:53
gibibauzas: from nova perspective only the API limitations and the vrit driver dependency are externally visible, the rest is neutron configuration and neutron API13:53
bauzasstephenfin: how can we write some admin notes given docs are now per project ?13:53
* gibi needs to step away for a bit13:53
stephenfinbauzas: Depends on where most of the work has to be done. It _feels_ like more of a neutron thing, IMO13:53
bauzasoki doki, I'm good with this13:54
stephenfinbauzas: SR-IOV networking is probably the closest thing we have and that is in the neutron guide, though we do have references to it in our docs13:54
*** sdake has quit IRC13:54
mriedemtssurya: thanks13:54
bauzasthat's my point, we probably still need references to it13:54
stephenfinsean-k-mooney: what was the reply to mriedem's question about the libvirt-neutron-sriov-livemigration spec? You think it's reasonable to land13:55
stephenfin(FWIW, I have reviewed it myself multiple times and I don't _think_ any of jaypipes' comments were too serious)13:56
yonglihesean-k-mooney: good idea, then seems I could not do much on that tonight, and I would like to hear more from you. so after I had a good sleep,  than I can catch all comment from you, and trying to change the patch and to see what happens then.  anyway, thanks a lot.  have a good one.13:56
sean-k-mooneystephenfin: i did not see that question13:56
sean-k-mooneymriedem: ah you were asking if it would make stien in the next 24 hours13:57
sean-k-mooneythe main issue i think has been the lack of review so i dont know if people will raise issue13:58
sean-k-mooneymriedem: i think it could land but if you would prefer to defer to train to give it more scurtiny then i can live with that too13:58
sean-k-mooneythe neuton depency has merged so its all on the nova side at this point13:59
mriedemi personally think it's probably high risk at this point but i also haven't reviewed it13:59
*** sdake has joined #openstack-nova14:00
sean-k-mooneyya thats fair. its less high risk then the numa stuff since sriov live migration never work before in any scenairo so we cant break it more then it was but obviosly we want it to be right14:01
*** pcaruana has joined #openstack-nova14:01
*** mlavalle has joined #openstack-nova14:02
sean-k-mooneymriedem: artom has modifed the openlab request to see if we could get sriov capably servers so we can test it as part of that effort too14:02
stephenfinmriedem: I would suggest taking a glance. There's one patch that is rather bulky but the rest seem compact/grokable. Definitely would benefit from someone with a deep knowledge of the live migration flow too14:03
stephenfinThe NUMA stuff is far more involved, yeah14:03
*** marst has joined #openstack-nova14:06
sean-k-mooney... i need to resovle a merge conflict with gibi's stuff ill work on that now14:07
sean-k-mooneyit should be small but we merged a few thing in the last 36 hours that conflicted with this code14:08
*** wolverineav has joined #openstack-nova14:08
* alex_xu can't find one which can chime in easily and have chance in last 24 hours14:08
*** FlorianFa has quit IRC14:09
mriedemyeah honestly i'm going to be focusing in 2 blueprints today most likely, the rbd extend volume one and maybe we can get the data migration part of melwitt's counting quotas from placement in stein, but i don't know about the rest of it14:09
mriedem*on14:10
mriedemi've taken about a week off from the cross-cell resize stuff and despite it not getting in stein our product team needs it by end of the month so i have to start working on that more14:10
sean-k-mooneymriedem: sure no worries. ill resolve the merge confilcit anyway and redeploy locally to test.14:10
mriedemalex_xu: if i find something that does not require a lot of prior context i will ping you14:11
mriedemalthough it's late now14:11
mriedemgibi: i left some comments on that neutron docs patch,14:11
mriedemgibi: it reminded me - we don't have any sort of minimum compute service version check from the api for min bw provider support right?14:12
alex_xumriedem: cool, I empty tomorrow for help something14:12
*** wolverineav has quit IRC14:12
mriedemgibi: and maybe we don't because of what we talked about the other day with bauzas - if the compute/neutron agent are upgraded to stein then they report inventory, otherwise they don't and the scheduler shouldn't pick them for these types of workloads14:13
gibimriedem: we dont have compute version checks for the reason you described14:14
mriedemyeah ok14:14
*** jaypipes has quit IRC14:14
*** jaypipes has joined #openstack-nova14:15
*** sdake has quit IRC14:17
*** markvoelker has joined #openstack-nova14:19
*** lbragstad has joined #openstack-nova14:20
*** sdake has joined #openstack-nova14:22
sean-k-mooneyjaypipes: thanks for taking the time to review the sriov stuff yesterday just seeing it now ill sync with adrianc to adress all the feedback and we will respin.14:24
*** sdake has quit IRC14:24
adriancalready addressed the comments will upload a PS soon14:25
sean-k-mooneyadrianc: ah cool. i was distracted in neutron land the last 2 days14:25
adriancsean-k-mooney, shall i rebase the direct and indirect patches on top ?14:25
sean-k-mooneyam sure14:25
adriancpromise not to loose a PS :)14:25
sean-k-mooneyhehe i trust you not to :) i generally work my way from the bottom up and cherrypick the later patches when working on a chain like this14:27
sean-k-mooneythat or use interactive rebases if its just my own patches14:27
jaypipesok, thanks adrianc and sean-k-mooney. will review it as soon as I see the new patches.14:28
sean-k-mooney:)14:28
adriancsean-k-mooney: gotcha thanks !14:30
adriancjaypipes: thanks for the inputs14:30
*** tetsuro has quit IRC14:34
openstackgerritAdrian Chiris proposed openstack/nova master: Sep methods to free claimed and allocated devs  https://review.openstack.org/61612014:36
openstackgerritAdrian Chiris proposed openstack/nova master: Allow per-port modification of vnic_type and profile  https://review.openstack.org/60736514:36
openstackgerritAdrian Chiris proposed openstack/nova master: Add get_instance_pci_request_from_vif  https://review.openstack.org/61992914:36
*** moshele has quit IRC14:37
*** sdake has joined #openstack-nova14:38
*** awaugama has joined #openstack-nova14:38
mriedemhttps://www.youtube.com/watch?v=jk8SToEQPGw14:39
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Fix WeighedHost logging regression  https://review.openstack.org/64139814:40
mtreinishmriedem: I like that the top comments on that are trying to explain the joke...14:42
mriedemmtreinish: i like that you are gone for weeks at a time and only show up, in this channel of all places, when i drop a simpsons video14:43
mtreinishI think that I have my priorities straight14:45
mriedemi don't disagree14:45
sean-k-mooneyadrianc: by the way i am assuming you are crurrently rebasing https://review.openstack.org/#/c/620115 on the ohter changes. the final change in the seriese does not use any of the funcitions you modified so that should be a straight cherrypick at the end14:46
*** tbachman has joined #openstack-nova14:46
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Handle missing exception in instance creation code  https://review.openstack.org/64140114:46
openstackgerritAdrian Chiris proposed openstack/nova master: SR-IOV Live migration indirect port support  https://review.openstack.org/62011514:46
adriancsean-k-mooney: yes14:47
sean-k-mooney:)14:47
mriedemtakashin: when you get a chance can you backport https://review.openstack.org/#/c/636271/ please?14:48
mriedemmtreinish: while you're here, see how this job runs tempest with --concurrency=4 http://logs.openstack.org/72/638072/14/check/nova-next/c8ecf61/job-output.txt.gz#_2019-03-06_08_18_20_02117414:52
mriedembut yet it looks like a lot of the tests are running serially14:52
*** markvoelker has quit IRC14:52
mriedemthe first 7 are on the same worker14:52
mriedemunless that just means the other workers were running slower tests at the same time?14:53
mriedemyeah i suppose that's all it is14:53
mtreinishmriedem: yeah I think that's what's going on14:54
mriedemman there are tests in tempest that really just don't belong there14:54
mriedemtempest.api.compute.servers.test_list_server_filters.ListServerFiltersTestJSON.test_list_servers_filter_by_shutoff_status [72.172009s] ... ok14:54
mtreinishthe stackviz view is good for visualizing that: http://logs.openstack.org/72/638072/14/check/nova-next/c8ecf61/logs/stackviz/#/stdin/timeline14:54
mriedemcreate a server, stop it, wait for it to be stopped14:54
HD|Laptophey all14:55
openstackgerritJose Castro Leon proposed openstack/nova master: Extend volume for libvirt network volumes (RBD)  https://review.openstack.org/61303914:55
mriedemwe could test shutoff server filtering in functional tests14:55
mtreinishI'd support moving that test out of tempest14:56
HD|Laptophow do I convince nova-compute to not include the NFS storage under "local disk store" in Horizon?14:56
mriedemcripes these dualnet scenario tests are also long as hell14:56
mriedem3+ minutes14:56
*** ivve has quit IRC14:57
openstackgerritAdrian Chiris proposed openstack/nova master: Sep methods to free claimed and allocated devs  https://review.openstack.org/61612014:57
mriedemHD|Laptop: you mean a single compute is showing local storage for the entire nfs share rather?14:58
mriedemthat's not really a horizon thing14:58
mriedeme.g. compute1 is showing like 2TB of "local" disk14:58
HD|Laptopmriedem: under horizon/admin/hypervisors/, each hypervisor shows with 68TB local storage14:58
HD|Laptopprobably this is because its instance_path is set to a shared folder on said NFS server14:59
mriedemyes14:59
HD|Laptopand horizon seems to sum up all the disks... to "Lokale Festplattenbelegung14:59
mtreinishmriedem: iirc those tests make multiple servers and networks, login to them with an ipv4 network and test connectivity between servers over different ipv6 configurations. It takes forvever just waiting for things to come up14:59
HD|Laptop120GB von 582,8TB benutzt14:59
mriedemHD|Laptop: that comes from the libvirt driver in here https://github.com/openstack/nova/blob/dfaa513fe1329aabe6e5d83b6ac42e0e25ad9eb6/nova/virt/libvirt/driver.py#L574715:00
mriedemhttps://github.com/openstack/nova/blob/dfaa513fe1329aabe6e5d83b6ac42e0e25ad9eb6/nova/virt/libvirt/driver.py#L576215:00
mriedemsince instances_path is on shared storage, it's going to show the entire storage pool for that path15:00
mriedemi'm not aware of a way around that15:00
*** sdake has quit IRC15:00
HD|Laptopah okay. damn :'D15:00
mriedemmtreinish: time for an "extra-slow" tag soon15:01
mriedemmtreinish: will openstack health show me how long on average the entire TestGettingAddress class takes?15:01
openstackgerritsean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration  https://review.openstack.org/62958915:01
mtreinishit doesn't let you filter the averages by class iirc15:02
mtreinishbut if you give me a sec I can hack together a graph for you manually15:02
mriedemtook ~35 minutes in logs.openstack.org/72/638072/14/check/nova-next/c8ecf61/job-output.txt.gz15:05
mriedem8 tests15:06
*** sdake has joined #openstack-nova15:06
*** cfriesen has joined #openstack-nova15:07
*** moshele has joined #openstack-nova15:07
*** Luzi has quit IRC15:09
*** agopi has joined #openstack-nova15:14
efriedmriedem: where/how can I run a CI that exercises ironic-in-nova?15:14
mriedemefried: we have a non-voting job on all nova changes15:14
openstackgerritMatt Riedemann proposed openstack/nova master: Do not run tempest.scenario.test_network* tests in nova-next  https://review.openstack.org/64141615:14
mriedemironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa15:14
mriedemand i think there are a couple in the experimental queue as well for multinode and neutron stuff15:14
efriedaha, okay.15:14
efriedmriedem: background: I finally bit the bullet and started hacking up a way for ironicclient to use the ksa adapter we go through all the trouble of building up on the nova side, only to throw it away.15:15
sean-k-mooneyefried: the other way to do it is a DNM change to ironic that depends on the nova change15:15
*** awalende has quit IRC15:15
sean-k-mooneythat will runn the ironcis jobset and pull in the relevent nova patch15:15
efriedsean-k-mooney: and that exercises the nova side?15:16
*** awalende has joined #openstack-nova15:16
sean-k-mooneyassuming they have jobs that boot ironic instances via nova15:16
sean-k-mooneyit just depends on what you want to test15:16
efriedironicclient: https://review.openstack.org/64116915:16
efriednova: https://review.openstack.org/#/c/641170/15:16
efriedin case you care.15:16
mriedemmelwitt: looks like functional test failures at the end of your counting quotas series are real https://review.openstack.org/#/c/638324/15:16
mriedemefried: the one thing i'm not sure about is if that nova change will pull in the ironicclient code dependency or if it will pull in ironicclient from upper-constraints15:17
mriedemmight depend on if the job is zuul v3-ified15:17
efriedo15:18
mriedemhttp://logs.openstack.org/70/641170/1/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/0e5cd32/controller/logs/pip2-freeze.txt.gz indicates it doesn't15:18
*** agopi has quit IRC15:18
mriedempython-ironicclient==2.6.015:18
sean-k-mooneyefried: mriedem looks like the ironic base job is a zullv3 native job but it does not list openstack/nova as a required project15:18
mriedemdoesn't pull in the source dep15:18
openstackgerritSurya Seetharaman proposed openstack/nova master: Block automatic transport_url update for cell0  https://review.openstack.org/60541415:18
efriedwell crap15:19
mriedemso,15:19
mriedemthe "legacy" way to do this is a devstack change which depends on the nova/ironicclient changes and you configure devstack to pull in the client from source15:19
mriedemassuming devstack has an ironic job...15:19
efriedand if it doesn't, make the devstack change and then make a nova change that depends on it.15:20
mriedemor, your nova change depends on a devstack change that pulls in ironicclient from source which depends on the ironicclient patch15:20
mriedemyeah15:20
efriedyeah15:20
efriedwhee15:20
*** awalende has quit IRC15:20
mriedemhttps://github.com/openstack-dev/devstack/blob/master/stackrc#L34515:20
sean-k-mooneyefried:  i can mock up a quick test patch that ill pull in one of the ironic jobs and force it to use nova and ironcic client form source if iyou like15:21
*** sridharg has quit IRC15:21
efriedsean-k-mooney: If you have that at your fingertips, that would be great. It would take me a while to figure out.15:21
sean-k-mooneyefried: if you list a project in required-project and it auto adds it to LIBS_FROM_GIT and zuul follow the depends-on stuff to pull in the requried patches15:22
sean-k-mooneyefried: it should only take me a minute to create one15:23
*** tbachman has quit IRC15:28
*** moshele has quit IRC15:29
*** xek_ has joined #openstack-nova15:30
*** moshele has joined #openstack-nova15:30
*** xek__ has joined #openstack-nova15:32
*** xek_ has quit IRC15:35
*** Sundar has joined #openstack-nova15:37
*** udesale has quit IRC15:37
openstackgerritJose Castro Leon proposed openstack/nova master: Extend volume for libvirt network volumes (RBD)  https://review.openstack.org/61303915:38
openstackgerritsean mooney proposed openstack/nova master: [DNM] tempest client testing jobs  https://review.openstack.org/64142115:39
sean-k-mooneyefried: i think ^ will do what you want15:39
*** moshele has quit IRC15:39
efried...15:40
sean-k-mooneyi proably should have also dropt the tox jobs but they are quick15:41
efriedsean-k-mooney: Cool. How is that pulling in the ironicclient patch?15:41
sean-k-mooneyit is based on your nova patch an your nova patch has a depends on15:42
efriedright, but I thought we established that the depends-on wasn't working?15:42
sean-k-mooneyso because i added the ironic client to the require projects it will pull it in when zuul prepares the git repos and add it ot devstack LIBS_FROM_GIT list15:42
efriedor is that magic instated by virtue of this having been done in .zuul.yaml?15:42
efriedokay, nice.15:43
sean-k-mooneywe should still check when it actully runs just to be sure but it should work15:43
sean-k-mooneyi might quickly resping to drop the tempest full and greade job too since i has not started in zuul yet15:44
sean-k-mooneywell its ther ebut no vms yet15:45
efriedsean-k-mooney: Thanks for doing that. I have plenty of work left to do on the code side, but if I can at least get it running, then I have a way to debug.15:45
openstackgerritsean mooney proposed openstack/nova master: [DNM] tempest client testing jobs  https://review.openstack.org/64142115:46
sean-k-mooneythere we go i missed doce but that will be much more efficent15:48
efriedthanks sean-k-mooney15:48
sean-k-mooneyand no worries hopefully that works the way we want it too15:48
sean-k-mooneyif it does i can move those jobs into the experimental pipline or replace the current non voting jobs we have15:49
mtreinishmriedem: hmm, well getting the time series graph took longer than I thought (I must be rusty): https://blog.kortar.org/wp-content/uploads/2019/03/v6_network_total-1.png15:49
*** lpetrut has joined #openstack-nova15:50
*** markvoelker has joined #openstack-nova15:50
mtreinishwe also must have dropped a test (or skip it in some configurations) which made the aggregation difficult after Sept 201815:50
*** dtantsur|mtg is now known as dtantsur|afk15:50
mtreinishI also box and whiskered each individual test: https://blog.kortar.org/wp-content/uploads/2019/03/v6_network_scenario_run_times.png15:50
mtreinishit's definitely way too slow15:51
*** pcaruana has quit IRC15:53
mriedemgeez yeah15:53
mriedemthat aligns with the 2100 seconds i saw in that timed out job15:53
mriedemso i posted https://review.openstack.org/#/c/641416/ as a short-term workaround for nova-next15:53
mriedemi can't really decide if we should whitelist the scenario modules we care about in the nova-next job, because then new ones could be added and we'd miss them, but at the same time there is probably more we should blacklist15:54
*** janki has quit IRC15:55
mriedemi remember the good old days when tempest took 45 minutes15:55
mriedemthe whole job15:55
mtreinishman, that was a long time ago15:55
dansmithstephenfin: can you answer my questions about the test assertions in this? https://review.openstack.org/#/c/62459215:55
stephenfindansmith: sure15:55
mriedemgranted, the gate was fubar'd on a weekly basis, but still15:55
mriedemit was fubar'ed FAST15:56
dansmithstephenfin: I was thinking it would be nice to merge another good chunk of those this cycle, but...15:56
sean-k-mooney  mriedem for what its work im hoping to get the os-vif gates down to that by droping the keystone and cinder apis test.15:56
mtreinishkeystone tests take like zero time15:57
mtreinishdropping cinder will save a lot of time15:57
mtreinishsean-k-mooney: if there is no integration between os-vif and cinder I was just disable cinder all together in those jobs15:57
sean-k-mooneymtreinish: ya but os-vif is a lib that never talk to any other openstack service15:57
mtreinishs/was/would/g15:57
mriedemthat's why i dropped the non-compute api tests from the nova-next job15:57
sean-k-mooneymtreinish: yes im going ot15:58
sean-k-mooneyi think in the os-vif jobs i might keep the compute and networking api tests + the senario test for now and see what the job times look like15:59
sean-k-mooneyif they are under an hour ill be happy if i can get down to 45 mins or so even more so16:00
*** erlon has quit IRC16:00
*** thgcorrea has quit IRC16:01
mtreinishwell if you disable cinder (not just blacklist the cinder api tests) it won't run a good chunk of the scenarios16:02
mtreinishand those scenarios are individually among the slowest tests in a job16:02
*** erlon has joined #openstack-nova16:03
*** pcaruana has joined #openstack-nova16:06
*** hongbin has joined #openstack-nova16:07
*** ttsiouts has quit IRC16:08
*** ttsiouts has joined #openstack-nova16:09
*** sdake has quit IRC16:09
*** ttsiouts has quit IRC16:11
stephenfindansmith: Done-zo https://review.openstack.org/#/c/624592/816:11
*** ttsiouts has joined #openstack-nova16:11
*** sdake has joined #openstack-nova16:13
*** IvensZambrano has joined #openstack-nova16:14
melwittmriedem: ack, will fix. I think it's bc that patch changed things from counting instances => instance mappings, that test is probably only creating instance records and not mapping records16:17
*** _alastor_ has joined #openstack-nova16:17
*** tssurya has quit IRC16:18
*** mrch has quit IRC16:21
*** markvoelker has quit IRC16:22
dansmithmriedem: probably need someone to make a call on breaking potentially n-net-only tests with this: https://review.openstack.org/#/c/62459216:23
mriedemi know some of the converted privsep stuff is going untested because testing the privsep stuff is hard...16:24
mriedemi remember wresting with trying to mock around that stuff at one point16:24
mriedemi don't remember the details16:24
mriedem*wrestling even16:24
mriedemi'd rather not make that call today...16:25
dansmithjust seemed like some feature-y patches we could make independent progress on, and they were just refreshed, but.. I got stopped at the first one16:26
sean-k-mooneydansmith: even in the nova-net case some of that code is likely dead code as os-vif will be used in most cases16:27
*** ccamacho has quit IRC16:27
dansmithsean-k-mooney: understand, but it's just hard to get on board with orphaning code with tests.. if it's dead code, then maybe we should remove it16:28
mriedemin other fun news, when post live migration fails we don't set the instance to error status or reset the task_state to None apparently http://logs.openstack.org/43/635343/4/check/tempest-slow-py3/a2497ae/job-output.txt.gz#_2019-03-06_05_29_44_91080116:28
sean-k-mooneythe gateway code is likely still used16:28
sean-k-mooneymriedem: ya i have seen that happen a few times16:30
sean-k-mooneydansmith: by the way we were waiting mainly for cern to move to cellsv2 only before droping nova-networks16:31
*** yonglihe has quit IRC16:31
sean-k-mooneyso can we drop it entirly in train?16:31
dansmithsean-k-mooney: they're not fully off it, AFAIK16:31
sean-k-mooneywe are not going to froward port it to python3 im assuming16:32
sean-k-mooneydansmith: ok we should check with them and see.16:32
*** ileixe has quit IRC16:33
stephenfinThere was a mail about this on openstack-discuss a few weeks back16:33
stephenfinI recall they said they were planning to migrate *everything* to neutron, but I can't recall the timeline16:33
dansmithyeah, that's been the plan for a while, I just haven't heard that they have16:34
dansmitheither way, removal is non-trivial so cern being off it isn't the only barrier :)16:34
stephenfinSounds like a challenge16:34
stephenfinDoes anyone know if config drives rely on the metadata service being up? I'm assuming 'nova-compute' handles stuff by itself but haven't dived too deep yet16:35
melwittmriedem: I have a osc-placement change up for a batch command for setting allocation ratios per aggregate in placement, if you're interested in reviewing https://review.openstack.org/64089816:35
sean-k-mooneywell i think we might be able to delegate some of the logic to os-vif in the interim16:35
* stephenfin would ask mikal if he were around16:35
sean-k-mooneyfor example i want to pull the trusted vf stuff into a sriov plugin in os-vif16:36
dansmithsean-k-mooney: if you think those gateway things are still used can you comment?16:36
*** imacdonn has quit IRC16:36
*** imacdonn has joined #openstack-nova16:36
dansmithsean-k-mooney: I think there's also some default firewalling of nova services that still use a lot of the linux_net ip.* commands, right? like punching holes for nova-api, metadata, etc16:36
*** macza has joined #openstack-nova16:39
sean-k-mooneydansmith: ya there is a bunch of firwalling stuff. i would prefer not to migrate that code to os-vif but we migth be able to clean it up abit16:42
dansmithsean-k-mooney: yeah, not saying we should, I'm saying we shouldn't just be randomly dropping tests for stuff we convert to privsep because "it's hard" and "it might be only for n-net"16:43
openstackgerritmelanie witt proposed openstack/nova master: Use instance mappings to count server group members  https://review.openstack.org/63832416:44
sean-k-mooneyill take a look and see if its used and ya.16:44
sean-k-mooneyi can take a look at some to the privisep changes and see if i can convert them or help if needed too16:44
sean-k-mooneybut that will be after ff16:45
sean-k-mooneyi am happy to work with stephen on paying donw that technical debt16:45
dansmithI was just thinking that these feature-y patches might be a few easy wins to get in before FF, several were +2 already and just refreshed16:46
dansmithbut clearly I was wrong :)16:46
sean-k-mooneyactully they are more or less indepenate so maybe we can change the odering of some of the patches that dont drop tests/nova-net stuff16:47
*** sdake has quit IRC16:48
sean-k-mooneye.g. merge the stuff that is a driect port/obviously correct and deffer the rest16:48
*** sdake has joined #openstack-nova16:48
dansmithyep, I +W'd one above that first one16:49
artomstephenfin, the config drive is independant of the metadata API16:50
stephenfinartom: So put configuration in nova-compute?16:50
stephenfinI'm thinking on the vendordata stuff, specifically16:50
dansmithstephenfin: what does that mean?16:51
artomYeah, what do you want to put in nova-compute?16:51
dansmithstephenfin: config for how to reach the vendordata server/16:51
stephenfindansmith: If I was using DynamicJSON, yeah16:51
dansmithstephenfin: config_drive literally just imports the python module that generates the metadata response and uses it to dump things into a disk image16:52
dansmithstephenfin: then yeah, nova-compute would need that config16:52
sean-k-mooneyartom: you can add force_config drive or something but you can also just enable config drive in the flavor/image16:52
stephenfindansmith++ ta16:52
stephenfinI ended up down a rabbithole yesterday and ended up doing this https://review.openstack.org/#/c/640730/ and now I'm more confused than ever. Back to reviews16:52
*** pcaruana has quit IRC16:55
mriedemhttps://bugs.launchpad.net/nova/+bug/181887316:56
openstackLaunchpad bug 1818873 in OpenStack Compute (nova) "When post_live_migration_at_destination fails the instance is not put into ERROR/None vm_state/task_state" [Medium,Triaged]16:56
*** sdake has quit IRC16:56
mriedemso if post_live_migration_at_destination fails early, the guest is on the dest but the instance db state is all f'ed up16:56
mriedemmdbooth: don't you have a similar bug to this ^?16:56
sean-k-mooneymriedem: yes16:57
*** panda|ruck|flu is now known as panda|ruck|off16:57
mdboothThe one I recall was the other way round. The issue is when post_live_migration fails on the *source*16:58
artommriedem, maybe https://bugs.launchpad.net/nova/+bug/1628606?16:58
openstackLaunchpad bug 1628606 in OpenStack Compute (nova) "live migration does not clean up at target node if a failure occurs during post migration" [Low,In progress] - Assigned to Artom Lifshitz (notartom)16:58
sean-k-mooneyi brought that up in https://review.openstack.org/#/c/603844/16:58
artommriedem, I've been meaning to refactor the flow to make sure we save the instance state correctly in all cases16:59
artomI addressed the Cinder API fail case, there are more (like Neutron)16:59
sean-k-mooneyartom: didnt you partial fix this already. we just 1 addional try finally block effectily to make sure we always set the instance host16:59
openstackgerritMerged openstack/nova master: Support server create with ports having resource request  https://review.openstack.org/63636016:59
sean-k-mooneyartom: you didnt address all the cinder issues16:59
openstackgerritMerged openstack/nova master: objects: Store InstancePCIRequest.numa_policy in DB  https://review.openstack.org/62444416:59
artomsean-k-mooney, yeah https://review.openstack.org/#/c/611093/16:59
*** ivve has joined #openstack-nova17:00
sean-k-mooneyyou missed on place where we call cinder that can raise an exception17:00
artomsean-k-mooney, yeah, it's entirely possible17:00
artomsean-k-mooney, it was meant as a bandaid until a more correct fix is done17:01
*** ccamacho has joined #openstack-nova17:02
mriedemthis is clearly not...enterprise ready17:02
mriedemone could spend days cleaning up this mess17:02
sean-k-mooneyartom: ya i know17:03
sean-k-mooneyhttps://github.com/openstack/nova/blob/38c96993fd7163afe1a7c5f380af0d57a1bd2903/nova/compute/manager.py#L673617:03
mdboothIt seems more intuitive to me to update instance.host to the destination *immediately* we're actually running there, i.e. from the source at the top of _post_live_migration, but IIRC there are weird gotchas with that.17:03
sean-k-mooneythat is that call im thinking of17:03
mriedemanother clunker is we pass the Migration object around via the MigrateData which is pretty brittle,17:03
artommriedem, what mdbooth said17:03
mriedemi'd like to just partial that like what mdbooth did with source_bdms17:03
sean-k-mooneyit will hit the cinder attachments api and can raise an exception which means the vm is running on the dest but we never update the db17:04
artomI think just making sure we always update instance state the moment it's irreversibly on the destination is a good first step17:04
sean-k-mooneyya i wrote it down on my whiteboard after reviewing the other chage earlier in the week17:04
*** eharney has quit IRC17:06
*** gyee has joined #openstack-nova17:06
mdboothYou know how sometimes you don't understand a thing, but you remember understanding a thing while somebody was explaining it? I vaguely recall dansmith explaining why instance.host needs to be updated later.17:06
dansmithmdbooth: during migration?17:07
mdboothdansmith: Yeah.17:07
sean-k-mooneydansmith: later in post_live_migration_at_destination to be percise17:07
dansmithyou know how sometimes you don't understand a thing, but you remember that every time someone asks about it, you go re-re-re-research it and re-remind yourself why that thing is true?17:07
mdboothdansmith: haha17:07
artomPresumably things count on instance.host still being the source17:08
mdboothartom: Right. dansmith can be very convincing at times.17:08
sean-k-mooneyit was releated to cleaning up the cinder and neutron port properly on the souces17:08
sean-k-mooneyin anycase we can likely resolve that and make sure the db is consitent if we spend a little itme on it17:09
artomsean-k-mooney, heh, that's true for literally *all* of the bugs :D17:09
sean-k-mooneya good first step is proably jsut to break the fucntion into smaller functions so its eaier to grock17:10
artomsean-k-mooney, that too17:10
artomIt's actually on our downstream squad backlog17:10
sean-k-mooneyya i know its on my personal white board backlog too for after i get done with sriov.17:10
sean-k-mooneyi didnt wnat to go messing with the post live migrtation stuff in parallel17:11
*** eharney has joined #openstack-nova17:13
*** lpetrut has quit IRC17:14
*** mrch has joined #openstack-nova17:15
*** ccamacho has quit IRC17:15
*** awalende has joined #openstack-nova17:17
*** lpetrut has joined #openstack-nova17:17
openstackgerritTheodoros Tsioutsias proposed openstack/nova master: Add requested_networks to RequestSpec  https://review.openstack.org/57020117:19
openstackgerritTheodoros Tsioutsias proposed openstack/nova master: Enable rebuild for instances in cell0  https://review.openstack.org/57020317:19
*** ccamacho has joined #openstack-nova17:19
*** markvoelker has joined #openstack-nova17:19
*** awalende has quit IRC17:22
*** ttsiouts has quit IRC17:24
*** ttsiouts has joined #openstack-nova17:25
*** ttsiouts has quit IRC17:29
sean-k-mooneyadrianc: mind if i fix https://review.openstack.org/#/c/620115/27/nova/compute/manager.py@89 and rebase everyting17:31
*** lpetrut has quit IRC17:32
openstackgerritMatt Riedemann proposed openstack/nova master: De-cruft compute manager live migration  https://review.openstack.org/64144917:33
*** helenafm_ has quit IRC17:34
sean-k-mooneyis it my imaginaiton or does devstack no longer delete exsiting libvirt instances when it stacks?17:42
sean-k-mooneyi keep hitting domain already exists errors lately if i dont delete instance before i unstack and stack17:42
*** mmethot has quit IRC17:44
*** wolverineav has joined #openstack-nova17:44
*** mmethot has joined #openstack-nova17:45
cdentsean-k-mooney: I haven't experienced that, I rarely created actual vms from devstack, but I'm not surprised if it is happening: maintenance of devstack as a _dev_ tool, rather than the thing that happens in the gate is getting nowhere near the attention it used to17:48
sean-k-mooneyi think someone removed it17:49
*** wolverineav has quit IRC17:49
sean-k-mooneyill check the logs but after 5+ years of knowing that stack will clean up any vms you forgot about its hard to unlearn17:50
dansmithsean-k-mooney: I experienced that a while ago.. probably more than a year17:50
dansmithtbh, I'm not sure why it would do that for you, and it'd need to be real careful about any non-nova vms that were there17:50
sean-k-mooneywell i always found it strange it did it on stack not unstack but i have only noticed it lately17:50
dansmithunstack is really not maintained, AFAIK17:50
melwittmeanwhile, I never knew it cleaned up anything because I always deleted mine or destroyed the entire env and start over. not much unstack/stack17:50
dansmithit's missing a ton of crap17:51
sean-k-mooneydansmith: it used to use the instance name prefix that you have cofigred to delete any vm that matched17:51
dansmithsean-k-mooney: okay, that's surprising to me, but ...17:51
sean-k-mooneydansmith: ya i have a todo to fix wsgi config cleanup17:51
sean-k-mooneythere are a few other unstack/clean things i need to do.17:52
sean-k-mooneydansmith: it woudl be nice to keep it but make it conditional17:52
bauzassean-k-mooney: yup, I saw the same behaviour, even with a ./clean.sh17:52
*** markvoelker has quit IRC17:52
sean-k-mooneyone of the hack we did in the intel nfv ci to make it more reliable back when i was invoved in runing it is we never called unstack17:53
sean-k-mooneynodepool was going to delete the vm so it saved time and sometime the cinder loop device clean woudl randomly fail17:54
*** wolverineav has joined #openstack-nova17:54
sean-k-mooneyif i find a commit that removed it for a reason i might revert and make it condional but off by default.17:55
openstackgerritguang-yee proposed openstack/nova master: pass endpoint interface to Ironic client  https://review.openstack.org/64087917:55
openstackgerritMatt Riedemann proposed openstack/nova master: Refactor pre-live-migration work out of _do_live_migration  https://review.openstack.org/64145317:57
openstackgerritKen'ichi Ohmichi proposed openstack/nova master: doc: cleanup pci.alias references  https://review.openstack.org/64088217:57
*** lchabert has quit IRC17:58
openstackgerritMatt Riedemann proposed openstack/nova master: doc: cleanup pci.alias references  https://review.openstack.org/64088217:59
*** lchabert has joined #openstack-nova17:59
mriedemefried: you want to just fast approve ^ since ken'ichi updated it and +2ed but his updated need tweaking17:59
*** ccamacho has quit IRC18:00
*** lchabert has quit IRC18:01
*** wolverineav has quit IRC18:01
*** lchabert has joined #openstack-nova18:01
*** derekh has quit IRC18:03
sean-k-mooneyhuh its still there https://github.com/openstack-dev/devstack/blob/master/lib/nova#L230-L23918:04
sean-k-mooneyi must be broken18:04
*** psachin has quit IRC18:05
dansmithheh that's a pretty brute-force thing.. would be wrong if you ever redefined the pattern to not be a prefix18:05
dansmithnot that anyone would, but..18:05
sean-k-mooneywell people sometimes change the pattern to just use the uuid but ya its pretty dumb code18:06
*** wolverineav has joined #openstack-nova18:06
*** wolverineav has quit IRC18:06
sean-k-mooneythat sad its 2-7 years old and mostly just worked so its not terible18:06
*** wolverineav has joined #openstack-nova18:06
melwittmriedem: I'm going to review the rbd volume extend patch. anything else you'd recommend for review today?18:06
sean-k-mooneyill debug this later.18:07
dansmithI mean unlikely to change it on devstack18:07
sean-k-mooneyright operators change it for reasons but devs dont really have a need too18:07
eanderssonfrickler, thanks will double check18:08
sean-k-mooneyi was getting migration failure because i had stoped domains and got an error saying the domain already existed18:08
sean-k-mooneynova rolled back the live-migration and everything was fine18:09
sean-k-mooneyok finished testing the sriov migration stuff again. im going rebase it all to the head of master but it seams to work locally18:21
*** ralonsoh has quit IRC18:28
*** Sundar has quit IRC18:31
mriedemmelwitt: not really, i'm just waiting for another run of the ceph change on that one18:40
eanderssonfrickler, that was indeed it18:41
*** IvensZambrano has quit IRC18:42
melwittmriedem: ok, thanks. I just went through it, also lgtm18:43
*** jaypipes has quit IRC18:44
mriedemmelwitt: the rebuild from cell0 stuff could probably use more eyes but i've already been over it in parts and continued to find issues, so i'm just not really comfortable with pushing for that on the last day18:45
openstackgerritMerged openstack/nova master: Warn if group_policy is missing from flavor  https://review.openstack.org/64128918:46
melwittmriedem: got it18:46
openstackgerritsean mooney proposed openstack/nova master: Sep methods to free claimed and allocated devs  https://review.openstack.org/61612018:46
openstackgerritsean mooney proposed openstack/nova master: Allow per-port modification of vnic_type and profile  https://review.openstack.org/60736518:46
openstackgerritsean mooney proposed openstack/nova master: Add get_instance_pci_request_from_vif  https://review.openstack.org/61992918:46
openstackgerritsean mooney proposed openstack/nova master: SR-IOV Live migration indirect port support  https://review.openstack.org/62011518:46
openstackgerritsean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration  https://review.openstack.org/62958918:46
dansmithmelwitt: what's the party line on the privsep stuff?18:46
sean-k-mooneystephenfin: ^ they are all rebased and typos adressed.18:47
sean-k-mooneystephenfin: i tested it before the rebase so it should all be working but ill restack and test again18:47
melwittdansmith: I don't know the details but from earlier chat it looked like there's a lot of questions/issues. I'll re-read18:49
dansmithmelwitt: well, there are questions on a class of them, but that's a small subset18:49
dansmithmelwitt: re-ordering the patches would free up a bunch that are already +W18:49
dansmithI'm mostly interested in whether or not we care about the current half-baked situation we're in (I do)18:50
*** markvoelker has joined #openstack-nova18:50
dansmiththey're not fixes, so kinda seem like they should go in front of FF to me, and they're not no-risk18:50
dansmithit'd be nice to make some more progress, especially since mikal just updated them (IMHO)18:50
sean-k-mooneythere is what 7-10 left18:51
melwittdansmith: ah, I see. I agree they should go in front of FF and I think it would be good to merge the straightforward ones by ore-ordering18:51
*** spatel has joined #openstack-nova18:51
dansmithmelwitt: okay I hadn't seen you in that stack much so wasn't sure if you were ignoring them for specific reasons or just because they're not interesting.. maybe a ptl statement on the bottom one about "let's try to get a chunk of these merged before FF tomorrow" then ?18:52
sean-k-mooneyoh 18 but 3 are +w and could merge if we reorder18:52
dansmithI guess I could also reorder a few for mikal and we could do some before he wakes up even18:52
melwittdansmith: no, I recently went in there and approved one, which unblocked a small stack of them. haven't been ignoring them purposely18:52
dansmithsean-k-mooney: yeah and more proabably I just stopped walking up the stack18:52
dansmithokay18:52
dansmithlemme reorder them and see what I can free up easily18:53
eanderssonmriedem, the soft-anti-affinity issue was because the keystone endpoint was still v2/ and not v2.1/18:53
eanderssonjust fyi18:53
mriedemmelwitt: why create a new test class for this? https://review.openstack.org/#/c/633350/12/nova/tests/functional/db/test_instance_mapping.py18:54
melwittdansmith: I think they're valuable and want to get what progress we can there. I'll add a comment18:54
mriedemeandersson: ah..yeah we even have a troubleshooting entry for that in our docs from when oath upgraded to ocata18:54
mriedemeandersson: https://docs.openstack.org/nova/latest/admin/support-compute.html#requested-microversions-are-ignored18:54
mriedemeandersson: heh for that exactly same problem :)18:54
mriedem*exact18:55
eanderssonIt was just an odd one, as it worked before. =]18:55
eanderssonPlus does not help that we haven't had a weekend yet :p18:55
eanderssonUpgrading from Mitaka to Rocky... not easy lol18:55
melwittmriedem: don't have a great reason. at first, I had modeled it after the bdm uuid addition/migration, which used a separate class for the test cases. and I wasn't sure if it was sufficiently different from the rest of the tests and should be separated or not. I can lump it with the rest, no problem18:56
eanderssonMoving to Cells V2 has been super smooth so far thou18:56
mriedemeandersson: that's good to hear18:56
mriedemthe cells thing that is18:56
eandersson:p18:56
eanderssonWe still have a lot of unaccounted performance issues that we are troubleshooting.18:56
mriedemtoo bad you're late to submit a "upgrading from mitaka to rocky at blizzzzard" talk at the summit18:56
eanderssonhaha18:56
mriedemits not just cells v2 you're biting off, it's also placement18:57
mriedemso you might be hitting some perf issues due to not scaling that out enough,18:57
*** ivve has quit IRC18:57
mriedemor nova-compute being way too chatty18:57
eanderssonIt actually looks pretty good so far on the nova side, but something is talking to Neutron a lot more.18:58
dansmithyeah that shouldn't be cells-related I don't think18:58
eanderssonYea - don't think so either18:58
mriedemare you doing a lot of live migrations from rocky?18:58
dansmitheandersson: glad to hear things aren't terrible :)18:58
*** marst has quit IRC18:58
eanderssonWe haven't dared to test live migration yet :p18:58
mriedemok because the only big new neutron-related thing in rocky i can think of is https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/neutron-new-port-binding-api.html18:59
dansmitheandersson: are you trying to move to multiple cells or just upgrading to the point where it's required for a single one?18:59
eanderssonsingle one for now18:59
dansmithgotcha18:59
eanderssonwe want to move to multiple cells18:59
eanderssonbut wasn't a priority18:59
dansmithone thing at a time, for sure19:00
melwittmriedem: replied on the review. I think maybe I was thinking since it's special and temporary handling, maybe keep it separate for more obvious removal later. but none of that is strong reasoning. just wasn't sure what to do19:00
*** hongbin has quit IRC19:00
melwitteandersson: ++ also glad to hear things aren't terrible with cells :P19:01
*** hongbin has joined #openstack-nova19:02
mriedemmelwitt: there is something that needs fixing here https://review.openstack.org/#/c/638574/19:08
melwittmriedem: ok, on it19:08
openstackgerritDan Smith proposed openstack/nova master: Move arping to privsep.  https://review.openstack.org/62459319:09
openstackgerritDan Smith proposed openstack/nova master: Move cleaning conntrack to privsep.  https://review.openstack.org/62459419:09
openstackgerritDan Smith proposed openstack/nova master: Move killing processes to privsep.  https://review.openstack.org/63543219:09
openstackgerritDan Smith proposed openstack/nova master: Cleanup the exec_ebtables code a little.  https://review.openstack.org/63543419:09
openstackgerritDan Smith proposed openstack/nova master: Move slight bonkers IP management to privsep.  https://review.openstack.org/62459219:09
openstackgerritDan Smith proposed openstack/nova master: Privsepify ipv4 forwarding enablement.  https://review.openstack.org/63543119:09
openstackgerritDan Smith proposed openstack/nova master: Move FP device creation and deletion to privsep.  https://review.openstack.org/63543319:09
openstackgerritDan Smith proposed openstack/nova master: Privsep the ebtables modification code.  https://review.openstack.org/63543519:09
openstackgerritDan Smith proposed openstack/nova master: Move adding vlans to interfaces to privsep.  https://review.openstack.org/63543619:09
openstackgerritDan Smith proposed openstack/nova master: Move iptables rule fetching and setting to privsep.  https://review.openstack.org/63650819:09
openstackgerritDan Smith proposed openstack/nova master: Move dnsmasq restarts to privsep.  https://review.openstack.org/63928019:09
openstackgerritDan Smith proposed openstack/nova master: Move router advertisement daemon restarts to privsep.  https://review.openstack.org/63928119:09
openstackgerritDan Smith proposed openstack/nova master: Move calls to ovs-vsctl to privsep.  https://review.openstack.org/63928219:09
openstackgerritDan Smith proposed openstack/nova master: Move setting of device trust to privsep.  https://review.openstack.org/63928319:09
openstackgerritDan Smith proposed openstack/nova master: Move final bridge commands to privsep.  https://review.openstack.org/63958019:09
openstackgerritDan Smith proposed openstack/nova master: Cleanup the _execute shim in nova/network.  https://review.openstack.org/63958119:09
openstackgerritDan Smith proposed openstack/nova master: We no longer need rootwrap.  https://review.openstack.org/55443819:09
openstackgerritDan Smith proposed openstack/nova master: Cleanup no longer required filters and add a release note.  https://review.openstack.org/63982619:09
mriedemmakes you feel like a BIG MAN19:10
* dansmith puffs out his chest19:10
sean-k-mooney:)19:10
*** marst has joined #openstack-nova19:10
melwittlol.19:11
sean-k-mooneyefried: do you want the good news or the bad news19:12
dansmithI have some draft comments on one of melwitt's in that stack too, I need to go find and finish that19:12
mriedemi got you a puppy on the way home from work,19:12
mriedembut then i got hungry and ate it19:12
dansmithmelwitt: okay bottom four of that privsep set are +W19:13
dansmithassuming I didn't break anything.. the rebases were not bad, but not trivial19:13
melwittdansmith: cool, thanks for doing that19:13
dansmithaye19:13
melwittI made a comment on the old bottom patch to explain19:13
dansmithoh okay19:13
sean-k-mooneyefried: the good news is your change passed the fucntional job that runs the ironic api test and and python-ironclinet was installed from git19:14
sean-k-mooneyefried: the bad news is the tempest job that ran teh senario tests failed with this error http://logs.openstack.org/21/641421/2/check/nova-ironic-client-tempest/8faf490/controller/logs/screen-n-cpu.txt.gz?level=TRACE#_Mar_06_18_04_20_98530719:14
*** wolverineav has quit IRC19:14
sean-k-mooneyefried: anyway you should be able to use that to test your chagnes looks like your just need to set the ironic api version19:17
*** markvoelker has quit IRC19:22
openstackgerritChris Friesen proposed openstack/nova master: Split up _is_storage_shared_with() in libvirt driver  https://review.openstack.org/63993319:24
openstackgerritChris Friesen proposed openstack/nova master: Add emulated TPM support to Nova  https://review.openstack.org/63136319:24
*** Sundar has joined #openstack-nova19:24
cfriesenignore these, debugging something that fails in zuul but works locally. ^19:24
*** wolverineav has joined #openstack-nova19:25
mriedemmelwitt: ok i think dansmith and i are both up through the instance mapping user_id data migration patch, so you can probably start addressing stuff and pushing19:26
*** wolverineav has quit IRC19:26
*** wolverineav has joined #openstack-nova19:26
melwittmriedem: ack, reading through19:27
cfriesenmriedem: just wanted to say thanks for all the reviews in the past week.  you're a machine.19:29
*** wolverineav has quit IRC19:29
*** wolverineav has joined #openstack-nova19:30
mriedemcfriesen: yw19:31
mriedemi'm also having a hard time not making an inappropriate machine-related comment here19:32
mriedemfeels like a trap19:32
dansmithhaha19:32
dansmithI've been thinking19:32
dansmithall I came up with that was appropriate was "that's why his hugs are so cold"19:32
mriedembut i'd have to hug for anyone to know that19:32
dansmithI can tell from a distance19:32
melwittpff lol19:34
mriedemwe'll also need to think about what we do about counting for instance mappings that have queued_for_delete=None (not yet migrated)19:35
mriedemi think i would tend to count those since we do'nt know if the instance is deleted, so it's safer to be conservative19:35
*** wolverineav has quit IRC19:35
melwittyeah, was just reading through that19:36
dansmithI haven't gotten to any of the actual counting stuff19:36
dansmithI figure best case,19:36
dansmithwe merge the data model and migration stuff19:36
dansmithso we can get the things migrated in stein and then we're looking at train for the actual counting stuff19:36
dansmithas I haven't looked over any of that other than to go answer one question for myself19:36
melwitt+1 my initial thought is to be conservative and count the queued_for_delete=None ones19:37
mriedemyeah i haven't gotten into the api changes that actually use the new counting stuff, and at this rate it's too late for me to be comfortable with that,19:37
mriedemso i'd be happy to get the data model change and migration in stein19:38
mriedemso there is less to migrate in train19:38
dansmithyeah, having it migrated in stein before makes that stuff a lot better19:38
melwittI can't argue with that. it's a bummer, but I take responsibility for not having this all ready for review earlier in the cycle19:38
melwittI appreciate the review you're doing now and glad to be able to land some of it because of it19:39
melwitts/some of it/the migration stuff/19:40
*** wolverineav has joined #openstack-nova19:41
*** xek has joined #openstack-nova19:42
melwittI don't know why, but the whole unset non-nullable ovo field thing really confuses me :x19:44
*** xek has quit IRC19:44
*** xek_ has joined #openstack-nova19:44
dansmithI don't know why either :)19:45
*** xek__ has quit IRC19:45
melwitt:P19:45
*** wolverineav has quit IRC19:47
mriedemmelwitt: i'm +2 on the rbd extend volume change now https://review.openstack.org/#/c/613039/19:50
melwitt+W19:51
dansmithmelwitt: comment for you on the base patch.. I dare not -1 against that raft of positive votes, but.. genuine question19:56
*** wolverineav has joined #openstack-nova19:56
* melwitt looks19:56
melwittdansmith: good question -- I think probably so. we added indexes for the quotas re-work in pike19:58
dansmithYES19:58
dansmithoh sweet sweet -1 vote19:58
melwitthah19:58
melwittI'd ask jaypipes to confirm but he's not around atm19:58
*** zhubx has quit IRC19:59
*** zhubx007 has joined #openstack-nova19:59
*** jding1__ has joined #openstack-nova19:59
*** cdent_ has joined #openstack-nova19:59
dansmithit should be free to add since it's defaulted to null at add time, so .. I can't really imagine we don't want one19:59
*** lbragstad has quit IRC20:00
*** tosky has quit IRC20:00
*** lbragstad has joined #openstack-nova20:00
*** tosky has joined #openstack-nova20:01
melwittyeah...I'll see what the indexes look like for the current counting stuff we have and model after that. I don't know that much about database stuff20:01
*** jding1_ has quit IRC20:02
*** cdent has quit IRC20:02
*** cdent_ is now known as cdent20:02
dansmithshould be fairly straightforward..nothing really to configure afaik20:04
openstackgerritMerged openstack/nova master: Test live migration with config drive  https://review.openstack.org/56786020:06
melwittdansmith: IIUC, we would need two right? one on project_id and one that is on project_id and user_id?20:06
dansmithI'm not sure you need both, but maybe.. I guess I would think one on each is as good as one on (a) and one on (a,b) but not positive20:07
dansmithI was focused on the userid bit, but since I haven't really looked at how this is used, I wasn't thinking about it being queried as (a,b)20:08
dansmithso yeah maybe.. Guess we do need some expertise20:08
melwittI think I'm thinking that because of what jaypipes recommended to be done on the consumers table: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api_models.py#L646-L64820:08
melwittif the queries are going to be project_id and project_id + user_id20:09
dansmithright, but there isn't a bare one on project there, just composite ones20:09
dansmithbut yeah I dunno20:09
melwittyeah, true20:09
*** igordc has joined #openstack-nova20:10
melwittI'm not sure there's another example. but yeah the pattern is going to be (a) and (a,b)20:10
efriedmriedem: done20:16
efriedsean-k-mooney: not at all surprised it failed, good deal that it's hitting the changes. Thanks again.20:16
* melwitt casts summon jaypipes20:18
sean-k-mooneyefried: it looks like the functional job that runs the ironic api tempest test dose not help so you could drop that job20:18
efriedsean-k-mooney: I guess it "proves" (or at least suggests) that I didn't f up backward compatibility20:19
efriedassuming of course that the func tests actually exercise the paths I dorked with.20:19
*** Sundar has quit IRC20:19
*** markvoelker has joined #openstack-nova20:19
sean-k-mooneyya i guess.20:19
sean-k-mooneyim just going to go grab some gorceries. ill be back online a bit later20:21
*** wolverineav has quit IRC20:21
efriedwow, grocery stores are open after 6pm? Things have changed since I lived over there:)20:22
cdentefried: the best part is that the sign says "open 24 hours"20:22
cdentbut it means except saturday evening or sunday20:22
efriedheh20:23
cdentI have anger about that because there was this one, not at band camp, when I needed to pee20:23
cdentand because I saw the "24 hours" I had let myself relax that little bit you do when you know that safety approaches20:23
cdentbut no20:23
efriedmriedem: Popping https://review.openstack.org/#/c/639854/ off the stack - did you say you were going to address both issues in a fup (and therefore consider this one done)?20:25
efriedif you're loaded I can do it, no biggie20:26
efried(and by loaded I mean...)20:26
mriedemi can't hardly stand20:27
mriedemso i was going to start working on a fup patch for some of my comments in the earlier reshaper patches and then stack yours on top of that, but then ran out of steam to start doing that yesterday,20:27
mriedemand really kind of need to be working more on the cross-cell stuff20:27
mriedemso if you're looking for fun things to fup on, go nuts20:28
efriedfup my nuts20:29
*** betherly has joined #openstack-nova20:31
openstackgerritChris Friesen proposed openstack/nova master: Add missing libvirt exception during device detach  https://review.openstack.org/64148020:33
cfriesenmelwitt: this is for the bug you took a look at a few weeks ago. ^20:34
mriedemwhoa20:34
melwittcfriesen: ack20:35
melwitton my list20:35
*** igordc has quit IRC20:35
*** wolverineav has joined #openstack-nova20:37
*** betherly has quit IRC20:41
openstackgerritEric Fried proposed openstack/nova master: Test proper allocation of devices during reshape  https://review.openstack.org/63985420:42
*** cdent has quit IRC20:42
efriedmriedem: There's that one with the implicit comma thingy removed.20:42
efriednow fupping helper method for mdev name20:42
mriedemefried: did you see my comment about that earlier in the series?20:44
mriedemhttps://review.openstack.org/#/c/599208/18/nova/virt/libvirt/driver.py@683520:45
efriedyes20:45
mriedemi think we should just make _get_mediated_device_information handle the dash to underscore conversion20:45
mriedemso the caller (like your test) doesn't need to care20:45
efriedack20:45
mriedemdo you want to just also fix those temporarily/PR typos in the test code in the same change as your test wrinkle or a new generic follow up?20:46
efriedmriedem: one caller only has the name. Want the method to be smart and figure out which one it got, or take one of two kwargs, or...20:46
mriedemi don't follow20:47
efried_get_mediated_device_information is called in two places. In one of them, the one you pointed out, I have the UUID and convert to the name, which is the part that sucks. In the other, I only have the name and would have to do the reverse if I wanted the arg to be uuid.20:48
mriedemi guess you could add a helper method if that's more clear20:48
*** mikal has joined #openstack-nova20:48
mriedemi figured at the start of _get_mediated_device_information it would just dev_name = dev_name.replace('-', '_')20:49
mriedemand then it doesn't matter20:49
efriedthe method uses both the name and the uuid. I think a pair of helpers might be clearest.20:50
mriedemoh you're talking about this right? https://review.openstack.org/#/c/599208/18/nova/virt/libvirt/driver.py@616120:50
mriedemwhatever, a simple _get_mdev_name(uuid) is also easy20:51
*** betherly has joined #openstack-nova20:51
*** markvoelker has quit IRC20:53
*** tesseract has quit IRC20:54
*** betherly has quit IRC20:55
openstackgerritEric Fried proposed openstack/nova master: FUP for test_reshape  https://review.openstack.org/64148221:01
efriedmriedem: gathered them together ^21:01
efried'cept I seem to have f'ed that up somehow.21:02
mriedemdos2unix nice21:03
efriedwhaaa21:04
efriedoh21:04
efriedthought you were saying my line feeds were wrong21:04
*** erlon has quit IRC21:05
mriedemso is this ok or are tests failing?21:06
efriedfailing. We must be monkey patching libvirt/utils somewhere21:07
efriedf it, I'll move the utils into the driver.21:07
mriedemfakelibvirt...21:07
mriedemhttps://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/fake_libvirt_utils.py21:07
efriedthat's... crazy21:09
mikalThere's heaps of that stuff from back before we understood how unit testing worked.21:10
mikalMost of its removable with conversion to mock patches now.21:10
mikal(i.e. that's now been done for most of nova-net because I like doomed projects)21:10
*** betherly has joined #openstack-nova21:11
efriedclearly21:11
mikal*shrug* That code is 8 years old and no one has ever been offended enough to clean it up, so we're all complicit in it being like that.21:12
openstackgerritEric Fried proposed openstack/nova master: FUP for test_reshape  https://review.openstack.org/64148221:12
efriedoh ffs21:12
mikalIt made sense at the time with the tools available then.21:12
openstackgerritEric Fried proposed openstack/nova master: FUP for test_reshape  https://review.openstack.org/64148221:12
efriedokay mriedem, hopefully that one is okay.21:13
efriedI'm pretty offended mikal. But yeah, I don't know if I'm offended enough to clean it up.21:13
mriedemwe're talking about fake_libvirt_utils being offensive right?21:15
efriedyes21:15
mriedemnot just mikal showing up and randomly offending people21:15
efriedhahaha21:15
dansmithalso,21:15
dansmithmikal is in his PJs currently, which may offend you21:15
*** betherly has quit IRC21:15
efriedfor some values of "PJs".21:16
dansmithand for all we know, australian PJs might be like american birthday suits21:16
efriedswhat I'm sayin21:16
efried...with a pouch21:16
mikalLook. I've only told one of you to fuck off so far today. I'm really not being _unusually_ offensive.21:17
mriedemi was going to say "as is his wont" but figured that might offend him, but i see it wouldn't21:18
*** whoami-rajat has quit IRC21:18
efriedWe can hug it out, mikal, but let's get one thing perfectly clear:21:19
efriedNo pants, no hug.21:19
mriedemi'll hug a nude man21:19
mriedemi don't care21:19
mriedemi'm told it will be cold on the receiving end though21:20
dansmithlast week mriedem told me he prefers sweaty guys21:20
dansmithI don't really like where this is going21:20
mriedemi'll go back to the fire i just started in the tc channel21:20
dansmithto warm your icy embrace?21:21
melwittdansmith: going through the change to add a test case for an instance mapping that has no instance (manual cleanup or purge) and was thinking, what should we do in that case? if we don't migrate the user_id, the record would keep getting found. should we migrate it to some sentinel value? or bother trying to get it from request spec? or other?21:28
* mikal wanders off to get into his coding pants.21:29
*** eharney has quit IRC21:29
*** betherly has joined #openstack-nova21:31
cfriesenare there docs on how to add new privsep commands in nova?21:31
efriedcfriesen: You are right on time, mikal just put on pants21:32
efriedif anyone has that answer, it's him.21:32
mikalWell, I actually _left_ to put on pants, but you get the idea.21:32
mikalcfriesen: do you want a pre-pants possibly grumpy answer, or a post pants probably still grumpy answer?21:32
cfriesen:)21:33
cfriesenI'm easy21:34
mikalcfriesen: https://www.madebymikal.com/adding-oslo-privsep-to-a-new-project-a-worked-example/ is an overly complete answer with way more detail than you care about.21:34
mikalcfriesen: but the short answer is its pretty trivial. Decide where in nova/privsep to put the method. Add the method with the decorator. Call the method from other places. Profit.21:34
mikalcfriesen: the only real warts are around style (don't pass in command lines, pass in args that are used to generate a command line); and unit testing hoops if efried notices that test coverage has dropped.21:35
cfriesensweet, thanks.21:35
mikalcfriesen: I'd be happy to do a worked example in a blog post, but you're the first person to ever ask because no one loves me and my life is meaningless.21:35
*** betherly has quit IRC21:35
cfriesen(I'm trying to resolve a problem with emulated TPM and cold migration...the software TPM daemon runs as root but nova doesn't, and I need to copy the root-owned file to the dest node.)21:36
mikalcfriesen: although when I think of it, https://review.openstack.org/#/c/624593/ is probably close enough to documentation for now. Copy that.21:36
mikalOh, so you just want to read a file with escalated permissions?21:36
mikalThat's already implemented IIRC.21:36
mikalcfriesen: http://git.openstack.org/cgit/openstack/nova/tree/nova/privsep/path.py#n27 is what you want to read a file as root.21:37
cfriesenI suspect I need to modify SshDriver.copy_file() and RsyncDriver.copy_file() to optionally run with root privileges.21:37
mikalcfriesen: with maybe a http://git.openstack.org/cgit/openstack/nova/tree/nova/privsep/path.py#n73 thrown in for the destination file.21:38
mikalUmmmm. Why not just change the permissions on the file, sync, then change the permissions at the destination?21:39
mikalInstead of running the sync as root?21:39
cfriesenmight work. It's tricky because root might not even be set up for passwordless ssh, and the resize code path doesn't do RPCs to set things up the way live migration does.21:40
cfriesenstill studying the flow to figure out how to make it work21:40
mikalOk, well I'm going to put on pants and stuff, but ping me if you need more random pointers.21:41
*** betherly has joined #openstack-nova21:46
openstackgerritEric Fried proposed openstack/nova master: WIP: Make fake_libvirt_utils DIAF  https://review.openstack.org/64148921:50
*** markvoelker has joined #openstack-nova21:50
efriedmikal, mriedem: let's see how that goes ^21:50
efriedit's stage 1 of ? btw21:50
*** takashin has joined #openstack-nova21:50
efriedProbably better to explicitly mock only what's necessary to mock in only the places it's necessary.21:51
efriedBut I probably *am* too lazy for that.21:51
*** betherly has quit IRC21:51
dansmithmelwitt: I think we should include it in found, not in done, so it's clear that it's not migrated.. a sentinel doesn't make sense, IMHO, and it really should be cleaned up via archive/purge I think21:53
dansmithmelwitt: this is exactly why I wanted a test for it, so we make some decision and commit to it :)21:53
*** igordc has joined #openstack-nova21:53
*** mchlumsky has quit IRC21:53
sean-k-mooneyso instead of mocking nova.virt.libvirt.driver.libvirt_utils you are now mocking a buch of functions in that module21:53
sean-k-mooneyefried:  ^21:53
efriedsean-k-mooney: right, instead of mocking a whole module with a whole module, I'm mocking the individual methods that are actually mocked.21:54
sean-k-mooneymost of which were just pass....21:54
efriedwhich is fine21:54
sean-k-mooneyya21:54
efriedsean-k-mooney: what pissed me off enough to do this was having to add new passthrough utils in fake_libvirt_utils at the same time as adding them to utils - see the predecessor patch.21:55
efriedthis makes it so you don't have to do that.21:55
efriedwhich is a win.21:55
sean-k-mooneywhy not mock them in the testfucntion where they are actuly needed21:55
efriedi.e. by default anything you write in utils is not mocked - but also won't break the world if you try to use it.21:55
sean-k-mooneye.g. instaad of a blanket mock21:55
efriedYeah, sean-k-mooney agree with that. Not having looked, that sounds like a huge effort.21:56
efriedI assume the test surface of libvirt is enormous21:56
efriedthough from the little I've seen, we're nowhere near majority coverage.21:56
efriedI guess we have a 'cover' job to tell us that, huh21:56
sean-k-mooneyefried: you should assume that but it is not nessicaialy true.21:56
efriedin any case, yes, stage 2-N might be to remove the mocks one at a time, see which tests break, and explicitly mock the removed thingy in those tests.21:57
sean-k-mooneywell i guess we  could do that first then localise the mocs21:57
efriedjust so.21:57
mriedemcfriesen: wrote this up based on what i pinged you about last night https://bugs.launchpad.net/nova/+bug/181891421:58
openstackLaunchpad bug 1818914 in OpenStack Compute (nova) "Hypervisor resource usage on source still shows old flavor usage after resize confirm until update_available_resource periodic runs" [Low,Triaged]21:58
melwittdansmith: oh, gotcha. consider it part of a "not completed" migration and operator must clean up to finish migration. yep, thank you21:58
*** spatel has quit IRC21:59
sean-k-mooneyefried: also fun fact https://github.com/openstack/nova/search?q=assert_called_once&unscoped_q=assert_called_once21:59
melwittdansmith, mriedem: something that sucks that I realize now is that if we don't land the counting part of the series, we need to restore the policy change behavior thing to account for what to do with server creates in the face of down cells...21:59
dansmithmelwitt: yeah, you could also make a nova-status check for those I guess, and/or just do a warn-once on the migrate to say "yo dawg, this might never end if you don't do something"21:59
sean-k-mooneyi leaned yesterday that assert_called_once was added in py3621:59
cfriesenmriedem: oh yeah, meant to bring that up.21:59
mriedemmelwitt: i don't know that we *need* to22:00
*** phasespace has quit IRC22:00
mriedemit's a latent issue since multi-cell support in pike right?22:00
dansmithmelwitt: we already changed that? but it's no different than if we land none of this right?22:00
mriedemand counting quotas since pike22:00
efriedsean-k-mooney: Yes, in base python, BUT we use mock-the-lib, which had it added/backported to much earlier.22:00
melwittdansmith: ++ appreciate the ideas, as my brain is about fried22:00
dansmithright, nothing has changed since _that_ point right?22:00
melwittmriedem: ok. I wasn't sure if it's need or not. ok22:00
efriedsean-k-mooney: I remember learning that a couple years ago when I freaked out about same.22:00
sean-k-mooneyefried:  oh ok22:00
sean-k-mooneyefried: ya so i freaked out a bit yesterday when i found that neutron have a hacking check that prevent you from using ig22:01
sean-k-mooney*it22:01
melwittdansmith: yeah... yeah, that's true, current behavior is to ignore cell timeouts and such22:01
melwittso it's no worse than today22:01
dansmithyeah, I thought you were saying we had landed something very out of order22:01
dansmithfrom where we are today,22:02
dansmithlanding the data bit won't change anything I don't think22:02
melwittno, just... I don't know, I was thinking did down cell support change something about that. but I don't think it did22:02
dansmithI surely hope not22:02
melwitthaha. just paranoid about things changing things22:03
sean-k-mooneychange is scary22:03
melwittit is :) especially in nova where you can change something and some weird side effect pops up somewhere else because of it22:04
cfriesenmriedem: might want to check whether the last paragraph in https://bugs.launchpad.net/nova/+bug/1498126 is still applicable22:05
openstackLaunchpad bug 1498126 in OpenStack Compute (nova) "Inconsistencies with resource tracking in the case of resize operation." [Medium,Confirmed]22:05
cfriesenmriedem: that bug is old enough that the code may be fixed by now22:06
dansmithmelwitt: sean-k-mooney: that's whyfor we have careful review and don't just slam everything in, IMHO22:06
sean-k-mooneychange is scary? or so that we can all check our understading of the change and its wider effect so that changin a thing does not change other tings unless we ment too22:07
dansmithsean-k-mooney: no, the fear of weird side effects part.. that's why review from a heterogenous pool of experienced reviewers is important22:10
mriedemcfriesen: you mean this? "drop_move_claim looks up the new_flavor to compare it with the flavor  that was used to track the migration, but on the source node it's  certain to be the old_flavor. Thus as it stands now drop_move_claim   (only ran on source nodes) doesn't do anything. Not a big deal, but we  should probably fix it."22:10
cfriesenmriedem: yeah22:10
cfriesenI haven't checked whether it still applies22:10
mriedemi don't think that applies anymore, i'm not really sure what it's talking about22:10
mriedemwhen confirm_resize calls drop_move_claim, it's from the source and dropping usage for the old_flavor22:11
sean-k-mooneydansmith: yes because we all have different experice and approce solutions in different ways so we tend to see different things.22:11
mriedemwhen revert_resize (on the dest) calls rt.drop_move_claim, it's dropping the new_flavor usage from the dest host22:11
mriedemanyway, the bug i reported is something i hit in my cross-cell resize functional tests for confirm resize and should be really easy to recreate in general22:13
mriedemauto-confirm the resize and set the update_available_resource interval to a high number, like 10 minutes22:13
cfriesenmriedem: I think you're right and it doesn't apply anymore.22:16
sean-k-mooneydansmith: by the way the horrible code in https://review.openstack.org/#/c/624592/9/nova/network/linux_net.py22:17
sean-k-mooneywe have the same code more or less in os-vif https://github.com/openstack/os-vif/blob/master/vif_plug_linux_bridge/linux_net.py#L115-L15322:17
*** betherly has joined #openstack-nova22:17
*** hongbin has quit IRC22:18
sean-k-mooneywe also have iptables code we inheritied form nova networks in the linux bridge plugin.22:20
*** phasespace has joined #openstack-nova22:21
*** betherly has quit IRC22:22
*** markvoelker has quit IRC22:22
sean-k-mooneyi wouldnt be too surpisidn if we could replace alot of this code wide a call to plug on the linux bridge driver22:23
sean-k-mooney*surprised22:23
mikalefried: I effectively did this sort of thing with the nova-net privsep thing. I'd much rather end up with mock decorators on the methods which actually need them. Otherwise its super hard to untangle what calls what when something fails. I can take a look at this later, but only if people say one nice thing about me each day. Today's topic can be how pleasing my hairstyling is. Go.22:27
efriedI saw a shampoo commercial the other day and thought of you.22:28
efriedmikal: Did you see conversation above where I said: this is stage 1, so we don't have to have "passthrough mocks" in the fake module. Stage 2-N might be to remove the remaining mocks one at a time, see which tests break, and explicitly mock the removed thingy in those tests.22:29
mikalNo not really. I was trying to remember how jeans work.22:29
mikalI didn't read all the scrollback, it looked long and boring.22:30
efriedit was22:31
sean-k-mooneymikal: fyi dansmith reorderd some of you privsep removal code so the 4 patchs with +w can merge without being blocked by https://review.openstack.org/#/c/62459222:31
efriedmikal: that's why I extracted the salient bit of it for you. So you wouldn't have to mess up your hair.22:32
efriedor... something.22:32
mikalsean-k-mooney: careful. Some of us said regrettable things when we noticed that but hadn't yet had our valium for the day.22:32
*** hongbin has joined #openstack-nova22:33
*** macza has quit IRC22:36
sean-k-mooneymikal: i assumed you would be happy that 4 more of them are currently makeing there way through the gate22:38
sean-k-mooneymikal: but on a releated note we have similar code in os-vif which i kindof want to kill at some point once i figure out why we do it22:38
sean-k-mooneyhttps://github.com/openstack/os-vif/blob/master/vif_plug_linux_bridge/linux_net.py#L115-L15322:38
*** awaugama has quit IRC22:39
efriedmriedem: Are we waiting for train for https://review.openstack.org/#/c/633855/ series? (SEV stuff)22:49
mriedemefried: yes22:51
*** rcernin has joined #openstack-nova22:52
efriedmriedem: procedural hold so I don't keep looking at it and trying to decide whether to approve it?22:52
*** wolverineav has quit IRC22:52
mikalOh wow, this is terrible. Did you know we sometimes mock away the fake for that fake_libvirt_utils thing? Why? Who did this?!?22:53
mriedemefried: i put a -W on the 2nd patch in the series which adds the capability which will now auto-generate the trait on the compute node resource provider,22:54
mriedemi avoided the -2 to not blow up jay's beautiful stats22:54
efriedmriedem: ack22:54
sean-k-mooneymikal: do you know that we somtimes import the fake_libvirt direver for the unit tests in too fucntional tests22:54
mriedemefried: as for the one below that, i don't have an opinion22:54
efriedmikal: You mean mock.patch(restore original method)?22:55
efriedthat's pretty fantastic22:55
mikalefried: no, its even more useless. We do a mock.patch to a noop for a function THAT IS ALREADY A NOOP.22:55
efriedwow22:55
sean-k-mooneymikal: well actully that is proably new test that were written without knowing that ere was a global mock22:56
sean-k-mooneyso those test are actully proably mocking just the things they need to mock22:56
sean-k-mooneywhich is good22:56
sean-k-mooneythe fact it was already mocked is wasteful but it does not hurt anything22:57
sean-k-mooneyby the way is there a reason the fake libvirt dirver is not with the other virt dirvers like the the Fake virt diriver is?22:58
*** wolverineav has joined #openstack-nova22:58
mikalsean-k-mooney: please don't ask logical questions, it just makes use feel even more inadequate22:59
*** tkajinam has joined #openstack-nova23:01
*** dave-mccowan has quit IRC23:06
mikalHerm. Turns out we apply the fake_libvirt_utils fixture in many places it isn't even used.23:08
mikalThis rathole is nice. I like it. It feels like home.23:08
*** wolverineav has quit IRC23:13
*** mlavalle has quit IRC23:15
*** wolverineav has joined #openstack-nova23:17
*** markvoelker has joined #openstack-nova23:19
mikalWait what? nova.virt.libvirt.utils.file_open is definitely my favourite part of all this.23:23
cfriesenmikal: did you intentionally omit "mv" or "cp" from privsep?23:25
mikalcfriesen: privsep only has things which had callers. So an absence either means that the user hasn't merged yet, or there is no user in nova until you came along.23:27
openstackgerritmelanie witt proposed openstack/nova master: Add user_id field to InstanceMapping  https://review.openstack.org/63335023:28
openstackgerritmelanie witt proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules  https://review.openstack.org/63857423:28
openstackgerritmelanie witt proposed openstack/nova master: Add online data migration for populating user_id  https://review.openstack.org/63335123:28
openstackgerritmelanie witt proposed openstack/nova master: Add get_counts() to InstanceMappingList  https://review.openstack.org/63807223:28
openstackgerritmelanie witt proposed openstack/nova master: Count instances from mappings and cores/ram from placement  https://review.openstack.org/63807323:28
openstackgerritmelanie witt proposed openstack/nova master: Use instance mappings to count server group members  https://review.openstack.org/63832423:28
cfriesenmikal: I need to copy a subtree under /var/lib/libvirt/swtpm/<uuid> and recursively chmod or chown it.  On the dest I need to do the opposite.23:29
cfriesenI'm wondering whether from a security standpoint it'd make more sense to create these under libvirt, or as generic operations in path.py23:29
mikalcfriesen: I think I'd put it under path, it seems generically useful.23:30
mikalcfriesen: there's no security difference between either location, its more about who uses it.23:31
*** hongbin has quit IRC23:32
*** hongbin has joined #openstack-nova23:34
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py  https://review.openstack.org/56615323:37
openstackgerritTakashi NATSUME proposed openstack/nova stable/queens: Add description of custom resource classes  https://review.openstack.org/61912523:37
openstackgerritmelanie witt proposed openstack/nova master: Add online data migration for populating user_id  https://review.openstack.org/63335123:45
openstackgerritmelanie witt proposed openstack/nova master: Add get_counts() to InstanceMappingList  https://review.openstack.org/63807223:45
openstackgerritmelanie witt proposed openstack/nova master: Count instances from mappings and cores/ram from placement  https://review.openstack.org/63807323:45
openstackgerritmelanie witt proposed openstack/nova master: Use instance mappings to count server group members  https://review.openstack.org/63832423:45
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1818914  https://review.openstack.org/64152123:52
openstackbug 1818914 in OpenStack Compute (nova) "Hypervisor resource usage on source still shows old flavor usage after resize confirm until update_available_resource periodic runs" [Low,Triaged] https://launchpad.net/bugs/181891423:52
mriedemcfriesen: ^ recreate test at least23:52
*** markvoelker has quit IRC23:53
melwittmriedem: I think I'm not going to be able to be around tomorrow... :( on that note, I'm not sure how helpful it'd be to land the migration without the user-impacting changes,23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!