openstackgerrit | Merged openstack/nova master: Remove fake_libvirt_utils from the cache concurrency tests. https://review.openstack.org/642556 | 00:12 |
---|---|---|
*** gyee has quit IRC | 00:16 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: qemu: Make disk image conversion dramatically faster https://review.openstack.org/640781 | 00:28 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode for Nova instances https://review.openstack.org/641981 | 00:28 |
*** erlon has joined #openstack-nova | 00:41 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: WIP: Gracefully handle QEMU machine types for guests https://review.openstack.org/631154 | 00:44 |
*** marst has joined #openstack-nova | 00:49 | |
*** lbragstad has quit IRC | 00:49 | |
*** dave-mccowan has joined #openstack-nova | 00:54 | |
*** marst has quit IRC | 00:54 | |
*** erlon has quit IRC | 00:57 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Handle templated cell mappings in nova-status https://review.openstack.org/642611 | 01:03 |
*** agopi has quit IRC | 01:04 | |
*** whoami-rajat has joined #openstack-nova | 01:12 | |
*** wolverineav has quit IRC | 01:18 | |
*** wolverineav has joined #openstack-nova | 01:18 | |
*** wolverineav has quit IRC | 01:23 | |
*** itlinux has joined #openstack-nova | 01:25 | |
*** wolverineav has joined #openstack-nova | 01:33 | |
*** wolverineav has quit IRC | 01:33 | |
*** mvkr has quit IRC | 01:36 | |
*** mvkr has joined #openstack-nova | 01:38 | |
*** erlon has joined #openstack-nova | 01:48 | |
*** mvkr has quit IRC | 01:49 | |
*** itlinux has quit IRC | 01:51 | |
*** mvkr has joined #openstack-nova | 01:52 | |
*** hongbin has joined #openstack-nova | 01:53 | |
*** tetsuro has joined #openstack-nova | 02:10 | |
*** openstackstatus has quit IRC | 02:22 | |
*** openstack has joined #openstack-nova | 02:24 | |
*** ChanServ sets mode: +o openstack | 02:24 | |
*** BjoernT has joined #openstack-nova | 02:41 | |
*** Dinesh_Bhor has quit IRC | 02:49 | |
*** BjoernT has quit IRC | 02:50 | |
*** lbragstad has joined #openstack-nova | 02:58 | |
*** wolverineav has joined #openstack-nova | 02:59 | |
*** agopi has joined #openstack-nova | 03:06 | |
*** lbragstad has quit IRC | 03:07 | |
*** BjoernT has joined #openstack-nova | 03:12 | |
*** hongbin has quit IRC | 03:33 | |
*** erlon has quit IRC | 03:35 | |
*** dave-mccowan has quit IRC | 03:40 | |
*** munimeha1 has quit IRC | 03:43 | |
*** liuyulong has quit IRC | 03:47 | |
*** udesale has joined #openstack-nova | 03:49 | |
*** Ahzzmandius has quit IRC | 03:52 | |
*** mchlumsky has quit IRC | 03:58 | |
*** BjoernT has quit IRC | 04:03 | |
*** mordred has quit IRC | 04:14 | |
*** mordred has joined #openstack-nova | 04:21 | |
*** mordred has quit IRC | 04:37 | |
*** janki has joined #openstack-nova | 04:38 | |
*** udesale has quit IRC | 04:45 | |
*** mordred has joined #openstack-nova | 04:45 | |
*** udesale has joined #openstack-nova | 04:46 | |
*** abhishekk has joined #openstack-nova | 04:57 | |
*** wolverineav has quit IRC | 05:00 | |
*** wolverineav has joined #openstack-nova | 05:01 | |
*** markvoelker has joined #openstack-nova | 05:06 | |
*** wolverineav has quit IRC | 05:17 | |
*** wolverineav has joined #openstack-nova | 05:18 | |
*** sridharg has joined #openstack-nova | 05:22 | |
*** wolverineav has quit IRC | 05:22 | |
*** sapd1 has joined #openstack-nova | 05:24 | |
*** wolverineav has joined #openstack-nova | 05:25 | |
*** wolverineav has quit IRC | 05:30 | |
*** wolverineav has joined #openstack-nova | 05:32 | |
*** wolverineav has quit IRC | 05:40 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add description for BDM volume_size https://review.openstack.org/641255 | 05:57 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add description for BDM volume_size https://review.openstack.org/641255 | 05:57 |
*** slaweq_ has joined #openstack-nova | 06:00 | |
*** tristanC has quit IRC | 06:02 | |
*** wolverineav has joined #openstack-nova | 06:04 | |
*** tristanC2 has joined #openstack-nova | 06:04 | |
*** wolverineav has quit IRC | 06:04 | |
*** slaweq has quit IRC | 06:07 | |
*** kevinbenton has quit IRC | 06:07 | |
*** yankcrime has quit IRC | 06:07 | |
*** mgoddard has quit IRC | 06:07 | |
*** HD|Laptop has quit IRC | 06:07 | |
*** kevinbenton has joined #openstack-nova | 06:08 | |
*** gary_perkins has quit IRC | 06:08 | |
*** andreaf has quit IRC | 06:09 | |
*** gary_perkins has joined #openstack-nova | 06:10 | |
*** mgoddard has joined #openstack-nova | 06:10 | |
*** panda|rover|off has quit IRC | 06:10 | |
*** andreaf has joined #openstack-nova | 06:12 | |
*** panda has joined #openstack-nova | 06:12 | |
*** wolverineav has joined #openstack-nova | 06:14 | |
*** dr_gogeta86 has quit IRC | 06:16 | |
*** masayukig[m] has joined #openstack-nova | 06:19 | |
*** wolverineav has quit IRC | 06:32 | |
*** masayukig[m] is now known as masayukig[m]1 | 06:35 | |
*** masayukig[m]1 is now known as masayukig[m]2 | 06:35 | |
*** Luzi has joined #openstack-nova | 06:53 | |
*** jlejeune has quit IRC | 07:00 | |
openstackgerrit | Ying Wang proposed openstack/nova stable/rocky: Modified the filter regulation of 'Instance Name' for filter instance https://review.openstack.org/642659 | 07:01 |
*** ivve has joined #openstack-nova | 07:23 | |
*** dpawlik has joined #openstack-nova | 07:30 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: Remove the unsafe convert of lvm imagebackend https://review.openstack.org/642667 | 07:37 |
*** pcaruana has joined #openstack-nova | 07:39 | |
*** owalsh has quit IRC | 07:39 | |
*** pcaruana has quit IRC | 07:43 | |
*** pcaruana has joined #openstack-nova | 07:43 | |
openstackgerrit | Ying Wang proposed openstack/nova master: It was modified to the exact filter regulation of 'Instance Name' for filter instance https://review.openstack.org/642675 | 07:54 |
*** wolverineav has joined #openstack-nova | 07:55 | |
*** wolverineav has quit IRC | 07:59 | |
*** rpittau|afk is now known as rpittau | 07:59 | |
*** takashin has left #openstack-nova | 08:00 | |
*** tkajinam has quit IRC | 08:07 | |
*** tssurya has joined #openstack-nova | 08:08 | |
*** awalende has joined #openstack-nova | 08:15 | |
*** tesseract has joined #openstack-nova | 08:16 | |
*** luksky has joined #openstack-nova | 08:20 | |
*** ccamacho has joined #openstack-nova | 08:21 | |
*** xek has joined #openstack-nova | 08:34 | |
*** ralonsoh has joined #openstack-nova | 08:36 | |
*** sapd1 has quit IRC | 08:47 | |
*** ttsiouts has joined #openstack-nova | 08:49 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: Remove the unsafe convert of lvm imagebackend https://review.openstack.org/642667 | 08:51 |
*** dtantsur|afk is now known as dtantsur | 08:52 | |
*** luksky has quit IRC | 08:52 | |
*** yankcrime has joined #openstack-nova | 08:55 | |
*** luksky has joined #openstack-nova | 08:57 | |
*** tetsuro has quit IRC | 08:59 | |
*** priteau has joined #openstack-nova | 09:02 | |
*** ttsiouts has quit IRC | 09:04 | |
*** ttsiouts has joined #openstack-nova | 09:05 | |
*** tetsuro has joined #openstack-nova | 09:08 | |
*** tetsuro has quit IRC | 09:10 | |
*** snevi has joined #openstack-nova | 09:11 | |
*** derekh has joined #openstack-nova | 09:34 | |
*** mikal has quit IRC | 09:37 | |
*** mikal has joined #openstack-nova | 09:37 | |
*** mikal has quit IRC | 09:42 | |
*** tosky has joined #openstack-nova | 09:44 | |
*** helenafm has joined #openstack-nova | 09:52 | |
openstackgerrit | ya.wang proposed openstack/nova master: Update docs: User token times out during long-running operations https://review.openstack.org/642410 | 09:59 |
*** owalsh has joined #openstack-nova | 10:14 | |
*** cdent has joined #openstack-nova | 10:22 | |
*** panda is now known as panda|rover | 10:22 | |
*** lpetrut has joined #openstack-nova | 10:33 | |
*** tbachman has quit IRC | 10:40 | |
*** liuyulong has joined #openstack-nova | 11:17 | |
*** dave-mccowan has joined #openstack-nova | 11:23 | |
*** ttsiouts has quit IRC | 11:45 | |
*** ttsiouts has joined #openstack-nova | 11:45 | |
*** owalsh has quit IRC | 11:50 | |
*** ttsiouts has quit IRC | 11:50 | |
*** owalsh has joined #openstack-nova | 11:52 | |
*** awalende has quit IRC | 11:53 | |
*** awalende has joined #openstack-nova | 11:56 | |
*** owalsh has quit IRC | 11:56 | |
*** mikal has joined #openstack-nova | 11:56 | |
*** owalsh has joined #openstack-nova | 11:57 | |
*** tbachman has joined #openstack-nova | 11:59 | |
*** awalende has quit IRC | 12:00 | |
*** mikal has quit IRC | 12:01 | |
*** awalende has joined #openstack-nova | 12:03 | |
*** owalsh has quit IRC | 12:06 | |
*** owalsh has joined #openstack-nova | 12:07 | |
*** ttsiouts has joined #openstack-nova | 12:09 | |
*** markvoelker has quit IRC | 12:18 | |
*** owalsh has quit IRC | 12:18 | |
*** luksky has quit IRC | 12:19 | |
*** owalsh has joined #openstack-nova | 12:21 | |
*** panda|rover is now known as panda|rover|lunc | 12:21 | |
*** liuyulong_ has joined #openstack-nova | 12:31 | |
*** jaosorior has quit IRC | 12:43 | |
*** udesale has quit IRC | 12:50 | |
*** udesale has joined #openstack-nova | 12:51 | |
*** mriedem has joined #openstack-nova | 12:53 | |
*** janki has quit IRC | 12:59 | |
*** mlavalle has joined #openstack-nova | 12:59 | |
*** awalende has quit IRC | 12:59 | |
*** janki has joined #openstack-nova | 12:59 | |
*** owalsh has quit IRC | 13:01 | |
*** owalsh has joined #openstack-nova | 13:02 | |
*** awalende has joined #openstack-nova | 13:03 | |
*** FlorianFa has quit IRC | 13:03 | |
*** sapd1 has joined #openstack-nova | 13:03 | |
*** luksky has joined #openstack-nova | 13:08 | |
*** slaweq_ is now known as slaweq | 13:08 | |
*** owalsh has quit IRC | 13:10 | |
*** panda|rover|lunc is now known as panda|rover | 13:12 | |
mriedem | lyarwood: a few small things in https://review.openstack.org/#/c/551349/ | 13:13 |
*** yan0s has joined #openstack-nova | 13:13 | |
*** jaosorior has joined #openstack-nova | 13:15 | |
*** owalsh has joined #openstack-nova | 13:15 | |
*** lbragstad has joined #openstack-nova | 13:17 | |
*** owalsh has quit IRC | 13:19 | |
*** owalsh has joined #openstack-nova | 13:20 | |
*** dave-mccowan has quit IRC | 13:22 | |
*** marst has joined #openstack-nova | 13:26 | |
mriedem | gibi: heh found a use case for something we talked about recently https://review.openstack.org/#/c/387687/ | 13:26 |
*** irclogbot_2 has quit IRC | 13:26 | |
mriedem | compute node went down, admin unbinds a port to re-use it elsewhere, compute node comes back up and delete the old server and nova deletes the port | 13:27 |
mriedem | or unbinds it from the server it was currently bound to | 13:27 |
*** irclogbot_2 has joined #openstack-nova | 13:28 | |
gibi | mriedem: hm, that sounds like a bug | 13:31 |
gibi | mriedem: nova should check if the port is bound to the same server as nova things to bound to before unbind | 13:32 |
mriedem | yeah there is an old bug for it | 13:34 |
mriedem | https://bugs.launchpad.net/nova/+bug/1634269 | 13:34 |
openstack | Launchpad bug 1634269 in OpenStack Compute (nova) "Incorrect port unbind request on instance delete" [Low,In progress] - Assigned to AJAY KALAMBUR (akalambu) | 13:34 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix incorrect port unbind request in nova on instance delete https://review.openstack.org/387687 | 13:34 |
*** dave-mccowan has joined #openstack-nova | 13:35 | |
gibi | OK, so in the fix we simply refresh nova's view based on neutron's view and only unbind if the vif is still belongs to the instance | 13:37 |
gibi | that could work | 13:37 |
*** marst has quit IRC | 13:38 | |
gibi | in a similar scenario with bandwidth when neutron admin forcefully unbind the port then the resource allocation view will become inaccurate | 13:38 |
gibi | then when the old nova instance is deleted the whole resource allocation is deleted in placement so the inventory become correct eventually | 13:39 |
gibi | hm, in the bug, the instance is deleted while the compute was still down. I'm not sure when the allocation for such instance is deleted from placement | 13:41 |
gibi | OK. compute.api._local_delete calls delete_allocation_for_instance() so if the admin unbinds the port _after_ the instance is local deleted then the resource view is in a correct state | 13:43 |
gibi | mriedem: So I don't see that this sceanrio leads to any issue with bandwidth resource | 13:46 |
mriedem | this bug predates placement by a long shot | 13:46 |
mriedem | i'm not saying it does, | 13:46 |
mriedem | we have just talked about the weird corner case of unbinding ports out of band | 13:47 |
*** owalsh has quit IRC | 13:50 | |
gibi | mriedem: yeah, the use case seems valid | 13:51 |
*** lennyb has quit IRC | 13:51 | |
*** mlavalle has quit IRC | 13:52 | |
openstackgerrit | Jack Ding proposed openstack/nova master: Preserve UEFI NVRAM variable store https://review.openstack.org/621646 | 13:53 |
*** mlavalle has joined #openstack-nova | 13:54 | |
mriedem | melwitt: is this really stein rc potential? https://bugs.launchpad.net/nova/+bug/1816399 - isn't that a latent issue since rocky? | 13:56 |
openstack | Launchpad bug 1816399 in OpenStack Compute (nova) "The periodic task to clean up expired console_auth tokens is invalid" [Undecided,In progress] - Assigned to Takashi NATSUME (natsume-takashi) | 13:56 |
*** owalsh has joined #openstack-nova | 13:56 | |
*** awaugama has joined #openstack-nova | 13:56 | |
*** openstack has joined #openstack-nova | 15:39 | |
*** ChanServ sets mode: +o openstack | 15:39 | |
*** jchhatbar has quit IRC | 15:47 | |
*** ttsiouts has joined #openstack-nova | 15:48 | |
*** sapd1 has quit IRC | 15:53 | |
*** Vek has joined #openstack-nova | 15:58 | |
*** sapd1 has joined #openstack-nova | 16:01 | |
*** cfriesen has joined #openstack-nova | 16:04 | |
*** ivve has quit IRC | 16:07 | |
*** sapd1 has quit IRC | 16:08 | |
openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Re-propose cross-cell-resize spec for Train https://review.openstack.org/642807 | 16:10 |
dansmith | mriedem: regarding this: https://review.openstack.org/#/c/567701, where is the az set on the reqspec during live migration? | 16:12 |
*** ttsiouts has quit IRC | 16:14 | |
*** ttsiouts has joined #openstack-nova | 16:14 | |
mriedem | the request spec az is set on server create and never changes | 16:14 |
dansmith | okay I'm missing something about your assertion in the commit message then | 16:15 |
dansmith | you say the reqspec.az is what the az filter looks at, and that means the instance can be moved across azs, which I assumed meant we update it so after you move it it's correct, | 16:16 |
dansmith | but if not, then if you force a move across azs, and then do something like a resize, | 16:16 |
dansmith | the instance will pop back over to the old az during scheduling, yeah? Is that what you meant? | 16:16 |
*** weshay is now known as Dwight | 16:18 | |
*** Dwight is now known as DwightH | 16:18 | |
*** DwightH is now known as weshay | 16:19 | |
mriedem | replied inline | 16:19 |
dansmith | mriedem: okay I'm more talking about the case where az *is* set | 16:20 |
dansmith | agree that if it's not set, it shouldn't matter, that's the easy case | 16:20 |
mriedem | i wasn't considering the force case here, | 16:21 |
mriedem | that's a separate f'ed up issue that evacuate will also suffer from | 16:21 |
mriedem | but yeah, if you request server create in AZ1, admin forces live migrate or evacuate to AZ2, and then the user resizes, they'll wind up back in AZ1 | 16:21 |
mriedem | b/c of the request spec | 16:21 |
mriedem | another example of why we removed the force parameter | 16:22 |
mriedem | but it's a separate bug imo | 16:22 |
*** agopi has joined #openstack-nova | 16:22 | |
dansmith | mriedem: I'm more interested in the v2.1 case, since that's all that osc seems to support right now, which by my reading is kinda equivalent to force=True with a destination right? | 16:24 |
dansmith | mriedem: I'm actually asking about this for another reason, not for confirmation of your patch itself | 16:24 |
mriedem | "which by my reading is kinda equivalent to force=True with a destination right" yup | 16:26 |
mriedem | also, | 16:27 |
mriedem | https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server.html#server-migrate is totally borked in this regard, | 16:27 |
dansmith | yes | 16:27 |
mriedem | if you're using osc to do live migrations, you're *always* forcing by default | 16:27 |
mriedem | it's mega fucked | 16:27 |
*** gyee has joined #openstack-nova | 16:27 | |
mriedem | i've talked with dean about this and unfucking it means essentially a major version bump | 16:28 |
mriedem | b/c it has to be an interface change | 16:28 |
mriedem | what you're talking about with force not updating the request spec az is a latent bug yeah | 16:28 |
*** ccamacho has quit IRC | 16:29 | |
mriedem | https://review.openstack.org/#/c/627801/ | 16:29 |
mriedem | maybe should queue that up for the ptg | 16:30 |
mriedem | mordred: i added an item to the nova train ptg etherpad about finally unbreaking the osc server migrate interface, since we should shit or get off that pot | 16:33 |
mriedem | ~L104 https://etherpad.openstack.org/p/nova-ptg-train | 16:34 |
dansmith | mriedem: on the --force removal, we just removed that flag and use the presence of the host parameter to indicate that we're serious? | 16:34 |
dansmith | because I thought the point was to be able to provide a host and let the scheduler sanity check it, and force was "this is an emergency just do it" | 16:34 |
mriedem | yeah - the provided host is a requested destination and the only one the scheduler will look at | 16:35 |
dansmith | so we've lost the emergency button? | 16:35 |
mriedem | if you're using the latest microversion yes, | 16:35 |
mriedem | but you can still 2.1 yourself into oblivion if you want | 16:36 |
dansmith | I vaguely recall these discussions of course, I'm just trying to fit my head around the current state | 16:36 |
mriedem | we also intentionally broke force for any servers that have nested allocations | 16:36 |
mriedem | regardless of microversion | 16:36 |
dansmith | if we start saying 2.1 is how you override things in an emergency then we really need to put the cap on "we're never bumping the minimum" :) | 16:37 |
*** udesale has quit IRC | 16:37 | |
dansmith | in the 2.1 case where you provide a host, we're still updating allocations though as far as I can see | 16:37 |
dansmith | you just mean nested allocs specifically? | 16:37 |
mriedem | we'll just do something dumb like adding the force parameter back | 16:37 |
mriedem | forcev2! | 16:37 |
mriedem | dansmith: yes if you force (2.1 where host is not None), we copy the allocations over to the forced dest compute node provider | 16:38 |
mriedem | but only if they are flat allocations | 16:38 |
mordred | mriedem: ok. happy to help fixing that | 16:38 |
mriedem | dansmith: that's this part https://github.com/openstack/nova/blob/e608568518ed91a0cbf08f779c5adb851762d80a/nova/conductor/tasks/live_migrate.py#L111 | 16:39 |
*** tssurya has quit IRC | 16:40 | |
*** snevi is now known as IvensZambrano | 16:40 | |
dansmith | mriedem: ack eyah | 16:40 |
*** yan0s has quit IRC | 16:41 | |
mriedem | so it sounds like you want me to change https://review.openstack.org/#/c/567701/ to at the very least save off the current instance.availabilty_zone before setting it based on the new dest host selection and then if we hit rollback to set it back to the saved off value? | 16:42 |
mriedem | which would only happen if i guess the rpc cast blew up? | 16:42 |
mriedem | dansmith: doing it on the compute when we change instance.host is a non-starter if you care about up-calls | 16:43 |
dansmith | mriedem: you can do it in the cell on the instance :) | 16:44 |
dansmith | as long as we pass the az into compute so it doesn't have to look it up, which is what I was saying was likely an rpc change | 16:44 |
dansmith | mriedem: I don't know what I want really.. what you're doing seems wrong, but what I did was equally wrong although slightly less concerning because of how those actions work | 16:45 |
*** wolverineav has joined #openstack-nova | 16:45 | |
dansmith | so I dunno, do we justify it with prior sins? | 16:45 |
*** wolverineav has quit IRC | 16:45 | |
mriedem | i can't backport an rpc change | 16:45 |
*** wolverineav has joined #openstack-nova | 16:45 | |
mriedem | we already have several places where we know we need to pass the az down to compute to avoid up-calls https://bugs.launchpad.net/nova/+bug/1781286 | 16:46 |
openstack | Launchpad bug 1781286 in OpenStack Compute (nova) "CantStartEngineError in cell conductor during reschedule - get_host_availability_zone up-call" [Medium,Triaged] | 16:46 |
mriedem | which reminds me https://review.openstack.org/#/c/581912/ | 16:47 |
*** wolverineav has quit IRC | 16:47 | |
dansmith | how about we just toss a grenade in this mofo and run? | 16:48 |
*** wolverineav has joined #openstack-nova | 16:48 | |
mriedem | wfm | 16:48 |
*** igordc has quit IRC | 16:48 | |
cfriesen | what's the current behaviour for resizing from a flavor with swap to one without swap? Do we allow it? | 16:50 |
mriedem | cfriesen: i'm fairly certain you ask this once per quarter | 16:51 |
mriedem | it's time for a tattoo | 16:51 |
cfriesen | as of last year it was supposed to work, but one of our testers just said it was busted | 16:51 |
*** igordc has joined #openstack-nova | 16:52 | |
cfriesen | I'm looking for automated tests of it | 16:52 |
mriedem | https://bugs.launchpad.net/nova/+bug/1762423 | 16:52 |
openstack | Launchpad bug 1762423 in OpenStack Compute (nova) "Resize to swapless flavor still looking for swap" [Low,In progress] - Assigned to jichenjc (jichenjc) | 16:52 |
*** igordc has quit IRC | 16:53 | |
cfriesen | according to my comment at the bottom of https://bugs.launchpad.net/nova/+bug/1552777 it was working in Pike | 16:53 |
openstack | Launchpad bug 1552777 in OpenStack Compute (nova) "resizing from flavor with swap to one without swap puts instance into Error status" [Medium,Fix released] - Assigned to Kam Nasim (knasim-wrs) | 16:53 |
mriedem | cfriesen: were you testing nova or starlingx? | 16:55 |
cfriesen | mriedem: pretty sure it was devstack, but can't say for sure now | 16:55 |
*** igordc has joined #openstack-nova | 16:56 | |
*** helenafm has quit IRC | 16:56 | |
mriedem | dansmith: unrelated softball https://review.openstack.org/#/c/642611/ | 16:56 |
dansmith | *crack* | 16:57 |
* mriedem goes to eat his feelings | 16:57 | |
*** rpittau is now known as rpittau|afk | 16:59 | |
*** ttsiouts has quit IRC | 17:01 | |
*** ttsiouts has joined #openstack-nova | 17:01 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Documentation for bandwidth support https://review.openstack.org/642064 | 17:05 |
*** tesseract has quit IRC | 17:05 | |
*** ttsiouts has quit IRC | 17:06 | |
*** eandersson_ has joined #openstack-nova | 17:07 | |
*** priteau has quit IRC | 17:08 | |
*** igordc has quit IRC | 17:10 | |
*** igordc has joined #openstack-nova | 17:21 | |
*** panda|rover is now known as panda|rover|off | 17:24 | |
*** READ10 has joined #openstack-nova | 17:33 | |
*** dtantsur is now known as dtantsur|afk | 17:39 | |
mriedem | efried: i'm mostly ok with https://review.openstack.org/#/c/640879/ but comments inline - the ironicclient valid_interfaces patch | 17:43 |
*** igordc has quit IRC | 17:43 | |
mriedem | i don't know if you can wordsmith something in as a code comment and commit message details, or if it's not worth it... | 17:45 |
*** igordc has joined #openstack-nova | 17:48 | |
*** luksky has quit IRC | 17:50 | |
*** READ10 has quit IRC | 17:50 | |
*** ivve has joined #openstack-nova | 17:52 | |
*** zhubx has quit IRC | 17:55 | |
*** zhubx has joined #openstack-nova | 17:55 | |
*** derekh has quit IRC | 17:55 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: RT: replace _instance_in_resize_state with _is_trackable_migration https://review.openstack.org/560467 | 18:04 |
openstackgerrit | Jeremy Stanley proposed openstack/nova stable/rocky: [DNM] Exercising base-test for a rocky change https://review.openstack.org/642582 | 18:09 |
mriedem | stephenfin: regarding https://review.openstack.org/#/c/641653/ - if that feature *never worked* since queens, doesn't backporting this stuff now essentially mean we're backporting a feature? | 18:10 |
openstackgerrit | Jeremy Stanley proposed openstack/nova master: [DNM] Exercising base-test for a master change https://review.openstack.org/642580 | 18:10 |
*** erlon has quit IRC | 18:15 | |
openstackgerrit | Jeremy Stanley proposed openstack/nova stable/rocky: [DNM] Exercising base-test for a master change https://review.openstack.org/642582 | 18:16 |
dansmith | mriedem: hmm.. "claiming will always fail" | 18:17 |
dansmith | mriedem: I'm trying to figure out what the upgrade impact of this is | 18:18 |
*** sridharg has quit IRC | 18:18 | |
dansmith | ah, so I guess it's not that terrible upgrade-wise, since we had blob pci requests before without this field | 18:21 |
dansmith | so this makes us save it, and load it from the request if it's there | 18:21 |
dansmith | which it might not be because the request was old, or because we were running the code for this and not saving it | 18:21 |
dansmith | definitely sounds fishy though, I'm not sure how this could have passed tests | 18:22 |
mriedem | "tests" | 18:22 |
mriedem | it's enabling a feature as far as i can tell | 18:22 |
dansmith | I mean according to the bug it doesn't work _at_all_ | 18:23 |
mriedem | looking back on the blueprint code that merged in queens, the only tests are unit tests | 18:24 |
dansmith | but I mean, I expected this was being tested on real hardware with an "it's too hard to automate that" sort of justification | 18:24 |
mriedem | one would hope | 18:25 |
mriedem | something something this is why we push for at least functional tests with stubs | 18:25 |
*** gmann is now known as gmann_afk | 18:26 | |
mriedem | dansmith: want to just fast approve this backport https://review.openstack.org/#/c/641401/ | 18:27 |
mriedem | i'm trying to flush stable queues | 18:27 |
mriedem | and https://review.openstack.org/#/c/641355/ | 18:27 |
dansmith | kewwwwwisssshh | 18:28 |
mriedem | i'm not sure what that sound is, you flushing a toilet? | 18:29 |
mriedem | oh right, flush | 18:29 |
mriedem | heh | 18:29 |
dansmith | um, duh | 18:29 |
mriedem | at first i was thinking about basketball and sinking a shot... | 18:29 |
mriedem | i.e. swisssshhh | 18:29 |
mriedem | but then i thought, "dan making basketball references?" | 18:29 |
dansmith | hahaah, right | 18:29 |
mriedem | ok rocky is ready for a few more if some stable cores want to look https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/rocky+label:Code-Review=2 | 18:36 |
*** pcaruana has quit IRC | 18:39 | |
openstackgerrit | Merged openstack/nova master: Share snapshot image membership with instance owner https://review.openstack.org/630769 | 18:43 |
*** IvensZambrano has quit IRC | 18:47 | |
openstackgerrit | Eric Fried proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879 | 18:57 |
efried | mriedem: howzat ^ | 18:57 |
efried | ah crap, I didn't use enough digits in my change IDs. | 18:58 |
openstackgerrit | Eric Fried proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879 | 19:00 |
efried | mriedem: fixed ^ | 19:00 |
mriedem | +W thanks | 19:00 |
efried | thanks | 19:01 |
mriedem | efried: actually one question about the release note https://review.openstack.org/#/c/640879/11/releasenotes/notes/set-endpoint-interface-for-ironicclient-a0b6b8f8dedc7341.yaml | 19:02 |
efried | ahcrap, I didn't even look at the reno. | 19:03 |
dansmith | busted | 19:03 |
mriedem | time for your spanking | 19:03 |
efried | considering this isn't my patch, I'd like to bring in my whipping boy. | 19:03 |
mriedem | the gimp? | 19:03 |
efried | Is that what he is? I've been thinking of him as "leather ninja" | 19:04 |
mriedem | hey it's taco tuesday right? https://media.giphy.com/media/ToMjGpHaUPwqzAVaxoI/giphy.gif | 19:04 |
efried | That's obscene in a way I can't begin to define | 19:05 |
dansmith | oh...mahgod. | 19:05 |
*** mikal has joined #openstack-nova | 19:05 | |
dansmith | man mikal just barely missed that one | 19:05 |
openstackgerrit | Eric Fried proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879 | 19:06 |
efried | mriedem: ^ | 19:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: pass endpoint interface to Ironic client https://review.openstack.org/640879 | 19:08 |
mriedem | let's all touch that patch | 19:08 |
*** wolverineav has quit IRC | 19:09 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Require python-ironicclient>=2.7.0 https://review.openstack.org/642863 | 19:11 |
mriedem | efried: right? ^ | 19:11 |
efried | mriedem: in master only, yeah. | 19:12 |
efried | +2 | 19:13 |
efried | o right, we load ironicclient dynamically, swhy it's not in requirements.txt | 19:14 |
*** mikal has quit IRC | 19:19 | |
*** wolverineav has joined #openstack-nova | 19:29 | |
*** ttsiouts has joined #openstack-nova | 19:29 | |
*** betherly has joined #openstack-nova | 19:32 | |
*** igordc has quit IRC | 19:32 | |
*** igordc has joined #openstack-nova | 19:33 | |
*** wolverineav has quit IRC | 19:34 | |
cfriesen | I assume this is a test-tool problem, not a problem with my change? http://logs.openstack.org/63/631363/22/check/nova-grenade-live-migration/1a03cbc/job-output.txt.gz#_2019-03-11_07_51_09_359608 | 19:36 |
mriedem | it means live migration failed | 19:36 |
mriedem | u'status': u'error' | 19:36 |
*** betherly has quit IRC | 19:37 | |
mriedem | http://logs.openstack.org/63/631363/22/check/nova-grenade-live-migration/1a03cbc/logs/screen-n-cpu.txt.gz?level=TRACE#_Mar_11_07_50_39_506220 | 19:37 |
mriedem | cfriesen: so yeah i assume that's not your fault | 19:40 |
mriedem | libvirt randomly puked | 19:41 |
melwitt | mriedem: yeah, I guess you're right it's latent since rocky | 19:44 |
*** luksky has joined #openstack-nova | 19:48 | |
*** ralonsoh has quit IRC | 19:48 | |
*** wolverineav has joined #openstack-nova | 20:02 | |
*** wolverineav has quit IRC | 20:06 | |
*** wolverineav has joined #openstack-nova | 20:06 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Don't warn on network-vif-unplugged event during live migration https://review.openstack.org/642877 | 20:12 |
*** gibi has quit IRC | 20:12 | |
*** cdent has quit IRC | 20:13 | |
*** igordc has quit IRC | 20:13 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Don't warn on network-vif-unplugged event during live migration https://review.openstack.org/642877 | 20:15 |
*** waverider has joined #openstack-nova | 20:15 | |
mriedem | bunch of stable/queens changes with a +2 that need approval https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/queens+label:Code-Review=2 | 20:16 |
*** dave-mccowan has quit IRC | 20:24 | |
*** agopi has quit IRC | 20:42 | |
*** waverider has quit IRC | 20:44 | |
*** IvensZambrano has joined #openstack-nova | 20:44 | |
*** hongbin has joined #openstack-nova | 20:52 | |
*** gmann_afk is now known as gmann | 20:54 | |
openstackgerrit | melanie witt proposed openstack/nova master: Add get_counts() to InstanceMappingList https://review.openstack.org/638072 | 20:57 |
openstackgerrit | melanie witt proposed openstack/nova master: Count instances from mappings and cores/ram from placement https://review.openstack.org/638073 | 20:57 |
openstackgerrit | melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.openstack.org/638324 | 20:57 |
*** zhubx has quit IRC | 20:59 | |
*** zhubx has joined #openstack-nova | 20:59 | |
*** eharney has quit IRC | 21:03 | |
*** mriedem has quit IRC | 21:05 | |
*** IvensZambrano has quit IRC | 21:06 | |
*** mriedem has joined #openstack-nova | 21:08 | |
mriedem | we should probably change the channel topic from the runways etherpad link to the rc potential etherpad link | 21:14 |
*** xek has quit IRC | 21:16 | |
melwitt | yeah, we should. dansmith ^ | 21:16 |
*** ChanServ sets mode: +o dansmith | 21:16 | |
melwitt | https://etherpad.openstack.org/p/nova-stein-rc-potential | 21:16 |
dansmith | link me? it's | 21:16 |
dansmith | thanks | 21:16 |
* dansmith is one lazy mofo | 21:16 | |
*** dansmith changes topic to "Current runways: https://etherpad.openstack.org/p/nova-stein-rc-potential -- This channel is for Nova development. For support of Nova deployments, please use #openstack." | 21:17 | |
*** ChanServ sets mode: -o dansmith | 21:17 | |
melwitt | thanks | 21:17 |
*** gibi has joined #openstack-nova | 21:18 | |
*** wolverineav has quit IRC | 21:20 | |
*** betherly has joined #openstack-nova | 21:21 | |
*** marst has quit IRC | 21:25 | |
*** betherly has quit IRC | 21:26 | |
*** wolverineav has joined #openstack-nova | 21:26 | |
*** igordc has joined #openstack-nova | 21:26 | |
*** igordc has quit IRC | 21:26 | |
*** agopi has joined #openstack-nova | 21:27 | |
*** igordc has joined #openstack-nova | 21:27 | |
*** wolverineav has quit IRC | 21:31 | |
*** marst has joined #openstack-nova | 21:33 | |
mriedem | got a bunch of pike backports that need a +W https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/pike+label:Code-Review=2 | 21:33 |
mriedem | there are also several pike backports from me which haven't had core review, and i probably shouldn't approve my own backports | 21:33 |
mriedem | melwitt: ^ | 21:33 |
melwitt | k, I'll go through them | 21:34 |
openstackgerrit | Merged openstack/nova master: Revert "Fixes race condition with privsep utime" https://review.openstack.org/641038 | 21:35 |
mriedem | feel free to proxy my backports as an implicit +2 | 21:35 |
melwitt | copy that | 21:35 |
*** ab-a has quit IRC | 21:37 | |
*** ab-a has joined #openstack-nova | 21:38 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional test to delete a server while in VERIFY_RESIZE https://review.openstack.org/615644 | 21:42 |
mriedem | melwitt: this is another old change that you've reviewed at one point https://review.openstack.org/#/c/541420/ but without it is going to make our eventual data migration for old volume attachments take that much longer | 21:43 |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP/PoC: Bypass ironicclient for node.get https://review.openstack.org/642899 | 21:44 |
efried | TheJulia, jroll, dtantsur|afk: This should interest you ^ | 21:45 |
*** wolverineav has joined #openstack-nova | 21:45 | |
melwitt | mriedem: oh yeah, I remember that one. it fell off my radar a long time ago. I'll re-queue it | 21:45 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add retry_on_deadlock to migration_update DB API https://review.openstack.org/633075 | 21:45 |
efried | TheJulia, jroll, dtantsur|afk: I decided that other thing - getting ironicclient to accept a pre-made Adapter - was going to be pretty heinous and an unnecessary step on the road to getting ironicclient out of the picture. This is a different approach. | 21:45 |
TheJulia | efried: ++++++++++++++++++= | 21:46 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Create volume attachment during boot from volume in compute https://review.openstack.org/541420 | 21:47 |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP/PoC: Bypass ironicclient for node.get https://review.openstack.org/642899 | 21:48 |
mriedem | efried: now that you're an oslo.policy master https://review.openstack.org/#/c/624185/ | 21:49 |
efried | ayfkm? | 21:49 |
melwitt | mriedem: speaking of old patches, I have an old patch bug fix that I've been wanting review on, if you could add it to your list. the patch has been verified by an operator https://review.openstack.org/611974 | 21:51 |
efried | mriedem: I'm not touching it until I see lbragstad's +1 | 21:51 |
*** awaugama has quit IRC | 21:51 | |
mriedem | melwitt: that looks like something for lyarwood and/or mdbooth to look at first | 21:52 |
mriedem | hell or even cfriesen since he reported the bug | 21:53 |
*** marst has quit IRC | 21:54 | |
melwitt | ok. I guess I forgot to ask them | 21:54 |
melwitt | looks like I added them to the review but didn't bug them. I'll do that | 21:56 |
cfriesen | I can probably confirm that it works, but I don't know the code | 21:56 |
melwitt | oh, no I didn't. you did. guh | 21:56 |
*** rcernin has joined #openstack-nova | 22:01 | |
lbragstad | mriedem oh - i forgot about that guy | 22:01 |
lbragstad | looked again, left comments | 22:01 |
*** betherly has joined #openstack-nova | 22:08 | |
mriedem | oh boy ok that's enough policy for me for one day | 22:08 |
*** hoonetorg has quit IRC | 22:09 | |
*** cdent has joined #openstack-nova | 22:10 | |
*** hoonetorg has joined #openstack-nova | 22:10 | |
*** whoami-rajat has quit IRC | 22:12 | |
*** betherly has quit IRC | 22:12 | |
*** agopi has quit IRC | 22:23 | |
openstackgerrit | Sam Morrison proposed openstack/nova-specs master: add spec "flavor-classes" https://review.openstack.org/635408 | 22:23 |
*** igordc has quit IRC | 22:25 | |
*** hongbin has quit IRC | 22:32 | |
*** igordc has joined #openstack-nova | 22:43 | |
*** tosky has quit IRC | 22:43 | |
*** ivve has quit IRC | 22:44 | |
*** ttsiouts has quit IRC | 22:45 | |
*** ttsiouts has joined #openstack-nova | 22:46 | |
*** ttsiouts has quit IRC | 22:50 | |
*** mriedem has quit IRC | 22:51 | |
*** tkajinam has joined #openstack-nova | 22:53 | |
*** tbachman has joined #openstack-nova | 23:05 | |
*** betherly has joined #openstack-nova | 23:10 | |
*** cdent has quit IRC | 23:13 | |
*** betherly has quit IRC | 23:15 | |
*** slaweq has quit IRC | 23:24 | |
*** tristanC2 is now known as tristanC | 23:36 | |
*** itlinux has joined #openstack-nova | 23:37 | |
*** betherly has joined #openstack-nova | 23:42 | |
*** betherly has quit IRC | 23:46 | |
*** BjoernT has quit IRC | 23:47 | |
*** IvensZambrano has joined #openstack-nova | 23:53 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!