Friday, 2019-03-15

*** wolverineav has joined #openstack-nova00:07
*** dpawlik has joined #openstack-nova00:10
*** wolverineav has quit IRC00:12
*** sapd1 has joined #openstack-nova00:14
*** liuyulong_ has quit IRC00:14
*** dpawlik has quit IRC00:15
*** tetsuro has joined #openstack-nova00:17
*** sapd1 has quit IRC00:18
*** dpawlik has joined #openstack-nova00:22
*** hamzy has joined #openstack-nova00:22
*** wolverineav has joined #openstack-nova00:22
*** dpawlik has quit IRC00:26
*** igordc has quit IRC00:27
*** wolverineav has quit IRC00:28
*** markvoelker has joined #openstack-nova00:34
gmanntakashin:  ^^ let's just say "- more information about sorting order of response results". mentioned particular field even as example can create confusion.00:36
*** markvoelker has quit IRC00:39
*** dpawlik has joined #openstack-nova00:52
*** wolverineav has joined #openstack-nova00:53
*** dpawlik has quit IRC00:57
takashingmann: Thanks. I will fix it.01:01
openstackgerritTakashi NATSUME proposed openstack/nova master: Add description about sort order in API ref guideline  https://review.openstack.org/62728201:02
*** markvoelker has joined #openstack-nova01:05
*** whoami-rajat has joined #openstack-nova01:17
openstackgerritFan Zhang proposed openstack/nova master: Retry after hitting libvirt error VIR_ERR_OPERATION_INVALID in live migration.  https://review.openstack.org/61227201:31
*** markvoelker has quit IRC01:32
*** zhubx has quit IRC01:33
*** zhubx has joined #openstack-nova01:33
openstackgerritJulia Kreger proposed openstack/nova master: [ironic] ignore conflict upon cleaning up node  https://review.openstack.org/64348401:35
openstackgerritzhaixiaojun proposed openstack/nova master: Fix bug: non-admin user can not filter instance by instance-uuid  https://review.openstack.org/64240301:40
*** wolverineav has quit IRC01:42
openstackgerritzhaixiaojun proposed openstack/nova master: Fix bug: non-admin user can not filter instance by instance-uuid  https://review.openstack.org/64240301:51
*** hongbin has joined #openstack-nova01:54
*** marst has joined #openstack-nova01:54
*** cfriesen has quit IRC02:04
*** dpawlik has joined #openstack-nova02:07
*** wolverineav has joined #openstack-nova02:08
*** penick has quit IRC02:09
*** lbragstad has quit IRC02:09
*** dpawlik has quit IRC02:12
*** dpawlik has joined #openstack-nova02:18
*** dpawlik has quit IRC02:22
*** lbragstad has joined #openstack-nova02:25
*** wolverineav has quit IRC02:39
*** wolverineav has joined #openstack-nova02:39
*** BjoernT has joined #openstack-nova02:40
openstackgerritzhufl proposed openstack/nova master: Pass kwargs to exception to get better format of error message  https://review.openstack.org/64350102:45
*** wolverineav has quit IRC02:48
*** ccamacho has quit IRC02:50
*** dpawlik has joined #openstack-nova02:52
openstackgerritMerged openstack/nova stable/queens: Fix WeighedHost logging regression  https://review.openstack.org/64135902:52
*** dpawlik has quit IRC02:56
*** takashin has left #openstack-nova03:01
*** psachin has joined #openstack-nova03:03
*** wolverineav has joined #openstack-nova03:11
*** zhubx has quit IRC03:12
*** zhubx has joined #openstack-nova03:13
*** BjoernT has quit IRC03:29
*** wolverineav has quit IRC03:37
*** udesale has joined #openstack-nova03:50
openstackgerritMerged openstack/nova master: Add functional test to delete a server while in VERIFY_RESIZE  https://review.openstack.org/61564404:13
*** wolverineav has joined #openstack-nova04:14
*** hongbin has quit IRC04:16
*** psachin has quit IRC04:30
*** dave-mccowan has quit IRC04:30
*** lbragstad has quit IRC04:31
*** marst has quit IRC04:39
*** marst has joined #openstack-nova04:43
*** lpetrut has joined #openstack-nova04:47
*** janki has joined #openstack-nova04:50
*** dpawlik has joined #openstack-nova04:52
*** dpawlik has quit IRC04:57
*** tssurya has joined #openstack-nova04:59
*** marst has quit IRC05:03
*** dpawlik has joined #openstack-nova05:04
*** dpawlik has quit IRC05:08
*** wolverineav has quit IRC05:08
openstackgerritMerged openstack/nova stable/pike: Migrate nova v2.0 legacy job to zuulv3  https://review.openstack.org/62057905:09
*** slaweq has joined #openstack-nova05:10
*** wolverineav has joined #openstack-nova05:11
*** wolverineav has quit IRC05:17
*** lpetrut has quit IRC05:19
*** lpetrut has joined #openstack-nova05:29
*** zhubx007 has joined #openstack-nova05:34
*** zhubx has quit IRC05:34
*** dpawlik has joined #openstack-nova05:42
*** lpetrut has quit IRC05:43
*** dpawlik has quit IRC05:47
*** slaweq has quit IRC05:56
*** mtreinish has quit IRC05:57
*** rcernin has quit IRC05:58
*** tetsuro has quit IRC06:08
*** sridharg has joined #openstack-nova06:10
*** rcernin has joined #openstack-nova06:13
*** ivve has joined #openstack-nova06:27
*** mtreinish has joined #openstack-nova06:31
*** Luzi has joined #openstack-nova07:00
*** stakeda has joined #openstack-nova07:14
*** dpawlik has joined #openstack-nova07:15
*** tssurya has quit IRC07:17
openstackgerritzhaixiaojun proposed openstack/nova master: Fix bug: non-admin user can not filter instance by instance-uuid  https://review.openstack.org/64240307:17
*** tssurya has joined #openstack-nova07:35
*** pcaruana has joined #openstack-nova07:36
*** tssurya has quit IRC07:40
*** priteau has joined #openstack-nova07:40
*** slaweq has joined #openstack-nova07:54
*** rcernin has quit IRC07:59
kashyapefried: dansmith: Caught up with the scrollback on #openstack-meeting.  And this is the Intel's equivalent for AMD's SEV: "MKTME": https://www.redhat.com/archives/libvir-list/2019-February/msg01730.html08:01
kashyapdansmith: efried: The enablement of "MKTME" (Multikey Total Memory Encryption) is not merged in kernel itself yet.08:01
kashyapThen comes the design and implementation part in QEMU and libvirt (which is what the above libvirt mailing list URL points to).08:02
*** tesseract has joined #openstack-nova08:04
*** luksky has joined #openstack-nova08:09
*** dpawlik has quit IRC08:10
*** xek has quit IRC08:13
*** xek has joined #openstack-nova08:13
*** tssurya has joined #openstack-nova08:15
openstackgerritYongli He proposed openstack/nova master: Clean up orphan instances  https://review.openstack.org/62776508:17
*** rpittau|afk is now known as rpittau08:17
*** tkajinam has quit IRC08:18
*** mcgiggler has joined #openstack-nova08:20
*** pcaruana has quit IRC08:24
*** pcaruana|afk| has joined #openstack-nova08:24
*** markvoelker has joined #openstack-nova08:27
*** awalende has joined #openstack-nova08:33
*** wolverineav has joined #openstack-nova08:43
bauzasgood morning Nova08:45
hrwmorning08:47
*** derekh has joined #openstack-nova08:47
*** ccamacho has joined #openstack-nova08:48
*** wolverineav has quit IRC08:48
*** ccamacho has quit IRC08:52
*** dpawlik has joined #openstack-nova09:13
*** lpetrut has joined #openstack-nova09:20
*** logan- has quit IRC09:23
*** logan- has joined #openstack-nova09:27
*** Dinesh_Bhor has joined #openstack-nova09:30
*** Dinesh__Bhor has joined #openstack-nova09:30
*** Dinesh__Bhor has quit IRC09:30
*** Dinesh_Bhor has quit IRC09:30
*** Dinesh_Bhor has joined #openstack-nova09:31
*** dpawlik has quit IRC09:45
*** dtantsur|afk is now known as dtantsur09:47
*** dpawlik has joined #openstack-nova09:48
* stephenfin should have checked IRC during the week. That's a loooot of mentions10:01
*** lpetrut has quit IRC10:02
*** martinkennelly has joined #openstack-nova10:05
*** stakeda has quit IRC10:06
*** dpawlik has quit IRC10:07
*** ttsiouts has joined #openstack-nova10:07
kashyapProbably it's OK to not check too.  "Distraction is the bane" ;-)10:07
*** IvensZambrano has joined #openstack-nova10:08
*** luksky has quit IRC10:09
*** dtantsur is now known as dtantsur|brb10:15
hrw;D10:18
hrwzuul -> irc gate would be lovely10:18
*** kaiokmo has quit IRC10:19
*** ttsiouts has quit IRC10:22
*** ttsiouts has joined #openstack-nova10:23
*** ttsiouts_ has joined #openstack-nova10:23
*** lpetrut has joined #openstack-nova10:27
*** ttsiouts has quit IRC10:27
*** cdent has joined #openstack-nova10:38
*** wolverineav has joined #openstack-nova10:45
*** dpawlik has joined #openstack-nova10:45
*** wolverineav has quit IRC10:49
*** luksky has joined #openstack-nova10:53
*** mriedem has joined #openstack-nova10:53
*** udesale has quit IRC10:56
*** udesale has joined #openstack-nova10:57
openstackgerritMatt Riedemann proposed openstack/nova master: Fix ProviderUsageBaseTestCase._run_periodics for multi-cell  https://review.openstack.org/64117911:11
openstackgerritMatt Riedemann proposed openstack/nova master: Improve CinderFixtureNewAttachFlow  https://review.openstack.org/63938211:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1818914  https://review.openstack.org/64152111:11
openstackbug 1818914 in OpenStack Compute (nova) "Hypervisor resource usage on source still shows old flavor usage after resize confirm until update_available_resource periodic runs" [Low,In progress] https://launchpad.net/bugs/1818914 - Assigned to Matt Riedemann (mriedem)11:11
openstackgerritMatt Riedemann proposed openstack/nova master: Remove unused context parameter from RT._get_instance_type  https://review.openstack.org/64179211:11
openstackgerritMatt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize  https://review.openstack.org/64180611:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid  https://review.openstack.org/61401211:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method  https://review.openstack.org/61403611:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add Instance.hidden field  https://review.openstack.org/63112311:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add TargetDBSetupTask  https://review.openstack.org/62789211:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask  https://review.openstack.org/63158111:11
openstackgerritMatt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask  https://review.openstack.org/63385311:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method  https://review.openstack.org/62131311:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method  https://review.openstack.org/63329311:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask  https://review.openstack.org/62789011:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method  https://review.openstack.org/63483211:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image  https://review.openstack.org/63760511:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask  https://review.openstack.org/62789111:11
openstackgerritMatt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection  https://review.openstack.org/64218311:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method  https://review.openstack.org/63804711:11
openstackgerritMatt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API  https://review.openstack.org/63804811:11
openstackgerritMatt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server  https://review.openstack.org/63826811:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add CrossCellWeigher  https://review.openstack.org/61435311:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API  https://review.openstack.org/63826911:11
mriedemgibi: bauzas: alex_xu: the bottom 4 changes in the cross-cell-resize series are test-only changes and are generally useful (not directly related to cross-cell but i do need them in that series later) ^11:12
mriedemit would help to land some of what we can while we can since that series is currently at 44 changes11:12
mriedemdansmith: from when you awaken from your cryochamber ^11:13
mriedem*for when11:13
kashyapThe re-proposed SEV spec needs some further re-design (to take into account a blocker raised by DanPB): https://review.openstack.org/#/c/64199411:20
*** kaiokmo has joined #openstack-nova11:24
*** BlackDex has quit IRC11:28
*** weshay is now known as weshay|rover11:31
*** cdent has quit IRC11:31
*** dpawlik has quit IRC11:33
stephenfinmriedem: RE: https://bugs.launchpad.net/nova/+bug/1819794, I assume there's still an open to figure out why https://bugs.launchpad.net/nova/+bug/1819794/comments/2 is happening?11:35
openstackLaunchpad bug 1819794 in OpenStack Compute (nova) "nova-next job fail on Ubuntu Bionic" [Medium,Confirmed]11:35
mriedemstephenfin: correct, it's not fixed11:36
stephenfinmriedem: Okidok. Won't get to that today but I'll try take a look next week11:36
*** cdent has joined #openstack-nova11:41
*** tosky has joined #openstack-nova11:43
efriedkashyap: ack, thanks for the info. dansmith, does the dev stage of that project affect your opinion on landing the SEV work?11:44
efriedare you thinking we should perhaps call it something more generic, so that when Intel's answer arrives on the scene, we can implement it under the covers without changing the UI at all?11:45
kashyapstephenfin: I'll look at that Bionic thingie; there are two things there (VMX thing and the misconfig of TLS certs)11:45
stephenfinkashyap: It's all yours11:46
kashyapstephenfin: Nod, first clearing out existing queue of stuff11:46
kashyapefried: On the "calling it more generic", that's what I wanted to plant a flag about -- for us (Nova) to consider _if_ we can work out a generic mechanism11:47
kashyapefried: From a quick chat with DanPB yesterday, he said Intel "MKTME" takes quite a different approach to AMD's SEV -- and what we're going to get in common in the end is up in the air.11:48
efriedkashyap: Well, yeah, I would think the outward-facing bits, like the compute capability trait?, would be called <generic>, and then under the covers we11:49
efriedif <generic>:11:49
efried  if AMD:11:49
efried    turn on SEV11:49
efried  elif Intel:11:49
efried    turn on MKTME11:49
efriedoh11:49
efriedwell then11:49
kashyapefried: On the outward-facing bits like the capability trait (although I don't know an awful lot about it) -- yes, it is worth at least calling out in the spec11:52
kashyap... that shows we've considered Intel's equivalent, with whatever limited info we have now.11:53
kashyapefried: Might want to add your above pseudo-code comment in the spec11:53
efriedkashyap: I suppose I'll have to finally *read* the spec :P11:54
kashyapefried: Haha.  I'll admit, I was not paying attention to it at all (as my plate is already overflowing with stuff).11:54
kashyapefried: I slowly got into it, as I was pinged about handling machine types, and then I noticed a few things11:55
cdentwonders how kashyap is managing to have just one plate11:56
cdentI will study11:56
efriedkashyap: I'm very new to "caring about libvirt at all", and it seemed to be a fairly simple followon to... some other spec I can't remember where we did a capability trait thing.11:56
kashyapAnd then I saw things (like adding the wrapper around libvirt's getDomainCapabilities() API) could be split out -- as it can be used for other libvirt driver work11:56
kashyapcdent: Hehe, I split my time b/n Nova (Gerrit-based patch workflow) and low-level virt (mailing-list based patch workflow)11:56
cdentsounds very much like two plates11:57
*** BlackDex has joined #openstack-nova11:57
kashyapYeah, a bit brain-warping.  The joy of applying 40 patches from an e-mail thread :-)11:57
efriedbut yeah, with the plate full thing, stuff involving the bowels of libvirt tends to be the first to slide off the edge.11:57
kashyapBut ... if you're using tools like `mutt`, et al.  That makes it blazing fast, though11:57
*** dpawlik has joined #openstack-nova11:58
kashyapefried: Can understand on the "caring about libvirt" thing.  The "being simple to follow" depends on what one is looking at, though ;-)11:58
efriedkashyap: Well, yes, simple from a "how we used the placement-isms" perspective, mainly because I've been right in the middle of that business for a whiile.11:59
*** janki has quit IRC12:00
*** dtantsur|brb is now known as dtantsur12:01
kashyapAh, gotcha; in that sense.12:01
openstackgerritMatt Riedemann proposed openstack/nova master: docs: cleanup driver parity scope section  https://review.openstack.org/64356612:02
kashyapefried: And thanks for reviewing the cache mode change series.12:02
efriedkashyap: Sure thing (speaking of bowels of libvirt)12:03
kashyap:-)12:03
kashyapefried: Warning: That SEV spec has _tons_ of hypervisor-related concepts.  So expect to sink some 2 hours or more, if you're reading with full concentration12:04
efriedthis is probably why I never finished it the first time around.12:04
efriedI was like, "whoah, this stuff is over my head; I hope kashyap reviews it."12:04
kashyap(And as we speak, there is potentially one more thing to be fixed in libvirt/QEMU; libvirt folks are testing)12:04
openstackgerritMatt Riedemann proposed openstack/nova master: Remove resize caveat from conductor docs  https://review.openstack.org/64356712:05
kashyapefried: I've commented on parts of it; for now you can ignore and tackle other high-prio stuff.12:05
efriedthanks12:06
kashyapI still need to review all the firmware / OVMF and other memory requirements stuff.12:06
kashyapWill get to it next week12:06
*** artom has joined #openstack-nova12:06
stephenfinmriedem: wrt all things docs, there's a nice albeit lengthy of all things metadata here that could benefit from your attention https://review.openstack.org/#/c/640730/12:09
mriedemchrist almighty12:09
stephenfinblame efried for setting me down that path12:10
stephenfin(PS1 comments)12:10
mriedemi don't see efried commenting in PS112:11
mriedemi also see dansmith did some review on this...12:11
stephenfinI must have changed the Change-ID at some point (initial version simply added use of :oslo.config:option: to one of the docs)12:12
*** abhishekk has joined #openstack-nova12:13
efriedYeah, I remember you saying this was interesting to me, and glancing at it, and not fully understanding why, and balking at the size of it, and not getting further into it where I might have been able to answer that question.12:13
*** derekh has quit IRC12:14
*** FlorianFa has quit IRC12:14
*** panda is now known as panda|lunch12:15
*** sapd1_x has joined #openstack-nova12:17
mriedemwe could benefit from some docs on the object version registry, nova object serializer, how objects are registered into that, how backporting of versioned objects works, conductors role in all that stuff, etc12:18
*** mlavalle has joined #openstack-nova12:19
kashyapstephenfin: Heh, on your docs patch, very dansmith-esque rationale: "Dropped a bunch of random comments in here, surely some of them addd up to a -1" :D12:25
*** markvoelker has quit IRC12:25
*** pcaruana has joined #openstack-nova12:26
*** pcaruana|afk| has quit IRC12:28
*** dpawlik has quit IRC12:33
*** mlavalle has quit IRC12:33
openstackgerritMatt Riedemann proposed openstack/nova master: Trivial typo fix for REST API in policy enforcement docs  https://review.openstack.org/64356912:34
*** EmilienM is now known as EvilienM12:37
mdboothdansmith: You in, yet?12:38
*** priteau has quit IRC12:38
kashyapHe should be, it is already 05:40 AM.  Too late12:38
mdboothdansmith: I have confirmed btw that my monkey_patch patch fixes non-wsgi, but not wsgi, and crucially I now understand why12:38
mdboothIt's a good patch, but incomplete. I'm just working on a follow up which I hope should fix everything and bring all our monkey patching hacks into 1 place. I'm happy to keep them separate or merge. Discuss when you get in?12:40
*** tobias-urdin has joined #openstack-nova12:40
mdboothkashyap: Heh, for anybody else I wouldn't have bothered to ping at this time ;)12:40
kashyapmdbooth: I know :-)  Sorry for trolling12:40
mriedemgood god this doc needs updating https://docs.openstack.org/nova/latest/reference/scheduler-evolution.html12:41
*** ttsiouts_ has quit IRC12:41
kashyapDoes anyone here know if Ubuntu maintains Git repo for their Bionic QEMU packages?12:41
*** ttsiouts has joined #openstack-nova12:42
* kashyap goes to look up12:42
kashyapI ask because of this: it seems like a very Ubuntu might've messed something: https://bugs.launchpad.net/nova/+bug/181979412:42
openstackLaunchpad bug 1819794 in OpenStack Compute (nova) "nova-next job fail on Ubuntu Bionic" [Medium,Confirmed]12:42
edleafemriedem: updating or deleting?12:42
mriedemedleafe: some of the stuff in there still applies12:43
mriedembut just stuff like "The recent NUMA features" that was written 3 years ago isn't so recent anymore12:43
edleafemriedem: it just seems that the bits that are still relevant don't merit a whole page in the docs. It's also a page that needs to be updated frequently12:44
*** ttsiouts has quit IRC12:46
*** abhishekk has quit IRC12:53
*** dave-mccowan has joined #openstack-nova13:02
*** ttsiouts has joined #openstack-nova13:04
openstackgerritMerged openstack/nova master: Avoid crashing while getting libvirt capabilities with unknown arch names  https://review.openstack.org/64345813:13
*** eharney has quit IRC13:15
*** ivve has quit IRC13:18
*** dpawlik has joined #openstack-nova13:20
*** marst has joined #openstack-nova13:21
openstackgerritMatthew Booth proposed openstack/nova master: Fix SSL infinite recursion  https://review.openstack.org/62695213:24
openstackgerritMatthew Booth proposed openstack/nova master: WIP: Assert that we're monkey patching before importing  https://review.openstack.org/64357913:25
efriedmordred: dtantsur asked the question about openstacksdk-in-nova via https://review.openstack.org/#/c/642899/ -- which had to come up again sooner or later. When you have a minute, would you mind summarizing what would be involved in plumbing nova to use it?13:25
mordredyes. happy to13:26
mordredwant me to do it on the review?13:26
openstackgerritMatthew Booth proposed openstack/nova master: DNM: What if we just monkey patched at the top level?  https://review.openstack.org/64358113:26
*** sean-k-mooney has joined #openstack-nova13:30
*** BjoernT has joined #openstack-nova13:33
mordredefried, dtantsur: Also - is this a thing you're wanting to squeeze in to stein? or for train?13:33
* dtantsur looks at efried13:34
dtantsurI'd expect Train to avoid surprises13:34
mriedemedleafe: i just reported a bug so i don't lose track of the issues since i don't have time to work on it - those could all be worked as separate changes by interested contributors https://bugs.launchpad.net/nova/+bug/182028313:34
openstackLaunchpad bug 1820283 in OpenStack Compute (nova) "Scheduler Evolution in nova - the doc needs updating" [Medium,Confirmed]13:34
efriedmordred, dtantsur: Oh, yeah, Train fo sho. This first patch only swaps out one API; the work to hit all of them will be fairly extensive. And possibly warrants a blueprint as well.13:35
dtantsurWhich reminds me, I need to implement Baremetal Volume API in openstacksdk..13:35
efriedmordred: Here probably better so I can ask questions (like, "whoah, you're assuming I know way more than I actually do")13:35
edleafemriedem: thanks for recording that. That page needs either a wholesale rewrite or a proper burial13:35
*** pcaruana has quit IRC13:36
mordredefried: well crap - I just responded to the patch :)13:40
mordredefried: so maybe read that real quick and we can pick it up here13:40
*** marst has quit IRC13:42
*** arne_wiebalck has joined #openstack-nova13:47
*** dpawlik has quit IRC13:52
efriedmordred: reading now, thanks.13:52
*** dpawlik has joined #openstack-nova13:54
efriedmordred: "translating from service name to service type", like https://github.com/openstack/nova/blob/master/nova/utils.py#L1197-L1202 ?13:55
*** cfriesen has joined #openstack-nova13:56
mordredefried: yes.13:57
efriedso - already done \o/13:57
efriedmore or less13:57
mordredefried: so - basically what we need is a loop that does what that's doing for all of the service types13:57
mordredefried: and then we need to extract the parameters because the ks_loading.load_auth_from_ ... methods don't make sense in this context13:58
mordredbut it would be pretty quick/easy to do13:58
mordredif we're talking train, it should be pretty easy to write the loader method in sdk13:58
*** eharney has joined #openstack-nova13:59
*** TheJulia is now known as needssleep13:59
efriedmordred: And as I understand it, the sdk contains "primitives" that will make e.g. https://review.openstack.org/#/c/642899/9/nova/virt/ironic/client_wrapper.py@101 (the node_get method) redundant and unnecessary.13:59
mordredyes, that's right13:59
*** rpittau is now known as elfosardo13:59
efriedcool.13:59
*** dtantsur is now known as creepy_owlet13:59
*** efried is now known as fried_rice14:00
*** awaugama has joined #openstack-nova14:00
fried_riceoh yeah ^14:00
fried_ricemordred: a little more on ks_loading_load_*_from conversion, if you please?14:00
mordredefried: as a concrete example --  once you have a conn - you can either do conn.baremetal.get() for direct rest, or you can do conn.baremetal.chassis() to get a list of chassis14:00
fried_ricemordred: ack, that makes sense (abstractly).14:00
mordredfried_rice: yeah. sdk *needs* to be the one constructing the adapter, so it needs to consume those parameters as config input14:01
fried_ricemordred: so right now we are, for all services (except maybe cinder?), doing this: https://github.com/openstack/nova/blob/master/nova/conf/ironic.py#L114-L11514:01
mordredit would be easier for it to also create the session and auth rather than having the ks_loading code do it14:01
mordredyeah - totally - register_ksa_opts should stay14:02
fried_riceso the ksa opts themselves don't change in the conf? That would be convenient.14:02
mordredwe just want to make the sdk be able to get its config from the same opts that ksa is defining14:02
mordredyeah14:02
fried_riceAh nice. This sounds like a pretty low-surface-area change then, from a plumbing perspective.14:02
mordredI *Think* there is a method call we can use to ask ksa what the opts are - so we should be able to be clever and the method should be pretty small14:03
mordredyeah14:03
fried_ricemordred: Yes, see https://github.com/openstack/nova/blob/master/nova/conf/utils.py#L5814:03
mordredit should be fairly easy - no noticable impact to deployers - and we should be able to delete a bunch of things from nova eventually14:03
fried_ricei.e. we're already doing that.14:03
fried_riceor rather https://github.com/openstack/nova/blob/master/nova/conf/utils.py#L3614:04
mordredyeah - awesome14:04
mordredI can start a patch to sdk to add the conf loader function14:04
fried_ricenice.14:04
mordredI'm excited about this actually - I think it'll wind up being really helpful in both directions14:06
fried_ricemordred: btw, in case you think this is all just serendipity, you helped me write all of that stuff.14:06
fried_ricethis is where you get to say things like, "I love it when a plan comes together".14:06
* bauzas waves after one week away from laptop14:07
bauzasinternal meeting, in case people were looking at me14:07
fried_ricemordred: agreed, there seems to be a lot of support for "get python-*client out of the way", to the point where I almost wonder whether it should be a Train community goal.14:07
fried_ricemordred: I mean, it can be a U community goal, and that shouldn't stop us doing pieces of it in Train14:08
fried_ricebut that would get it more attention14:08
mordredfried_rice: yeah - I thnik if we can get the sdk plumbed in and used in the places you're using adapters now (just the adapters on the sdk connection)14:09
mordredthen it'll be pretty easy then to pick off transitions one at a time - since the conn will be available and stuff14:09
*** awalende has quit IRC14:11
*** awalende has joined #openstack-nova14:12
*** marst has joined #openstack-nova14:13
*** sridharg has quit IRC14:15
openstackgerritMerged openstack/nova master: add python 3.7 unit test job  https://review.openstack.org/61069414:15
*** tbachman has quit IRC14:15
*** awalende_ has joined #openstack-nova14:15
*** awalende has quit IRC14:16
*** awalende_ has quit IRC14:17
*** pcaruana has joined #openstack-nova14:17
*** pcaruana|afk| has joined #openstack-nova14:17
*** pcaruana|afk| has quit IRC14:17
*** tbachman has joined #openstack-nova14:18
*** stephenfin is now known as finucannot14:19
fried_ricemordred: Well, tbh, the only place we're *actually* using the adapter that I know of is for talking to placement.14:20
*** jhesketh_ has quit IRC14:20
*** sean-k-mooney has quit IRC14:20
fried_ricemordred: All the other places we retrofitted to get and adapter so we could use its endpoint to pass to the client constructor and then throw the rest away.14:20
fried_rices/and adapter/an adapter/14:20
*** ttsiouts has quit IRC14:21
fried_ricemordred: that being the case, perhaps we could use the placement client (known as SchedulerReportClient) to lead the charge of testing the sdk plumbing.  <== cdent14:21
*** ttsiouts has joined #openstack-nova14:22
cdenti'd be pro that14:22
mordred++14:22
fried_ricemriedem, dansmith: Any foundational/historical/other reasons we shouldn't start doing this? (TLDR Incorporating openstacksdk into nova with the eventual goal of ripping out deps on python-*client and (directly) ksa.)14:24
*** ttsiouts has quit IRC14:25
*** ttsiouts has joined #openstack-nova14:25
bauzasfried_rice: CLI is a thing, python bindings is another thing14:34
openstackgerritEric Fried proposed openstack/nova master: WIP/PoC: Bypass ironicclient for node.get  https://review.openstack.org/64289914:34
bauzashaving a client that's managed by the project teams sounds more maintainable14:34
bauzaswith regards to microversions in particular14:35
bauzasI honestly thought about the OSC gap we have atm14:35
bauzaswith sean mooney as well14:35
fried_ricebauzas: Sorry, I don't follow. Are you suggesting we keep python-*client in the mix??14:36
bauzasand we wonder whether we could just use the plugin interface of OSC for having our microversions support *in-tree*14:36
fried_riceforget CLI for the moment; I'm talking about e.g. nova talking to ironic via openstacksdk rather than through python-ironicclient14:37
bauzasfried_rice: IIRC we said in the past that we could probably one day have an OSC CLI which'd be using novaclient python PAI14:37
bauzasAPI*14:37
bauzasfried_rice: yup, got it14:37
bauzasthe problem is that we don't have support for OSC microversions. In what openstacksdk would change this ?14:38
bauzaspardon my french14:38
bauzasI mean 'we don't have OSC supporting nova API microversions'14:38
*** dpawlik has quit IRC14:39
fried_ricebauzas: forget OSC for the moment.14:40
fried_riceIs there a reason we shouldn't rip out nova's dep on the pythot-ironicclient lib (see nova/virt/ironic/client_wrapper.py)14:41
fried_rices/pythot/python/ wow14:41
*** priteau has joined #openstack-nova14:42
bauzasfried_rice: is there a feature parity between ironicclient and openstacksdk ?14:44
*** tbachman_ has joined #openstack-nova14:45
bauzasat least for compute, I can't see it https://docs.openstack.org/openstacksdk/latest/user/guides/compute.html14:46
fried_ricebauzas: For many if not all of the APIs - creepy_owlet could answer that - but even if there's a specific API missing, we can use the adapter.get/put/post/delete primitives14:46
*** jhesketh_ has joined #openstack-nova14:46
*** tbachman has quit IRC14:46
*** tbachman_ is now known as tbachman14:46
fried_rice...which is what I was starting to do (via ksa directly as opposed to sdk) via https://review.openstack.org/642899 which started this discussion.14:46
bauzasI'm confused, I thought we were talking about the potential TC goal for Train14:48
bauzasmy sole take on using other clients but the project ones is that we need to make sure those projects take ownerships of their respective parts14:49
*** sean-k-mooney has joined #openstack-nova14:49
*** jhesketh has quit IRC14:49
*** jhesketh has joined #openstack-nova14:49
fried_ricebauzas: Right, we're specifically *not* talking about the current community goal. We're talking about a potential future community goal that's similar, but different. Namely: stop using python-*client from *services* (as opposed to CLIs).14:49
mordredfried_rice: https://review.openstack.org/643601 WIP Make factory for a CloudRegion from CONF objects14:50
*** jhesketh_ has quit IRC14:51
fried_ricemordred: ack14:51
mordredfried_rice: that's probably 95% there - obviously needs tests and whatnot - but that's the overall idea14:51
*** dpawlik has joined #openstack-nova14:51
mordredfried_rice: I think - because nova supports people having different accounts for different services, for now we should keep the existing model and have your nova code load session and auth plugin and pass them in - and we'll do one-connection-per-service - even though that's ultimately a little strange14:52
fried_ricemordred: okay, I was wondering about that.14:52
mordredfried_rice: but fits with the consumption model better so we can keep things as it is14:52
mordredthen, later, we can talk about whether it makes sense to think about it differently14:53
*** jhesketh has quit IRC14:54
mordredfried_rice: anyway - I've got a call now, so I'll have to come back to it -but I don't think it'll be super hard to get a working poc based on that14:54
fried_riceack14:55
creepy_owletbauzas: there is no feature parity overall, but most of things needed for Nova are there.14:56
*** jaosorior has quit IRC14:56
creepy_owletOne missing is Volume API, but it should be easy to introduce now that we have all basic bits in place.14:57
mordredand it woudl be good all around to get that added to sdk anyway, so the work would be generally useful14:57
creepy_owletexactly14:58
*** cdent has quit IRC14:58
creepy_owletFYI I'd like to start Train with replacing ironicclient with openstacksdk in ironic-inspector14:58
creepy_owletmetalsmith is already 100% openstacksdk14:58
openstackgerritEric Fried proposed openstack/nova master: Remove [ironic]api_endpoint option  https://review.openstack.org/64348314:59
*** jhesketh has joined #openstack-nova15:03
*** Luzi has quit IRC15:14
*** ttsiouts has quit IRC15:14
melwittaspiers: heya, was wondering if you're up for writing up a doc for https://review.openstack.org/538498 for rc1? L38 https://etherpad.openstack.org/p/nova-stein-rc-potential15:16
mriedemfried_rice: i was out, but i have an answer, sec15:19
mriedemfried_rice: i mentioned historical context in the community wide goal about sdk usage in server projects and dtroyer replied https://review.openstack.org/#/c/639376/4/goals/train/osc.rst@3315:20
mriedemtl;dr is it used to be heavyweight to use the sdk15:20
mriedemnow it's not so much so we should be ok to use if we want15:20
*** dpawlik has quit IRC15:22
mriedembut i see dmitry and monty already told you all this15:26
* mriedem was doing exterior drainage mandy work15:26
*** zhubx007 has quit IRC15:33
*** zhubx007 has joined #openstack-nova15:35
*** zhubx007 has quit IRC15:36
*** zhubx007 has joined #openstack-nova15:37
openstackgerritMatt Riedemann proposed openstack/nova master: Remove stale aggregates notes from scheduler evolution doc  https://review.openstack.org/64361315:40
mriedembauzas: edleafe: ^15:40
edleafemriedem: so is the plan for the evolution doc to remove piece-by-piece instead of all at once?15:44
openstackgerritMatt Riedemann proposed openstack/nova master: Remove "Fixing the Scheduler DB model" from schedule evolution doc  https://review.openstack.org/64361515:44
mriedemedleafe: some of it needs re-wording,15:45
mriedemit's not all removal15:45
edleafemriedem: ah, ^^ answers that15:45
mriedemand i'd rather not try to bite off re-writing that entire thing in a single change because (1) i don't have the time and (2) people probably don't want to review it15:45
mriedemso i'm just killing some time before lunch by hitting the low hanging fruit15:45
*** awaugama has quit IRC15:48
openstackgerritMerged openstack/nova stable/queens: Provide a useful error message when trying to update non-compute services  https://review.openstack.org/63880315:49
mriedemmelwitt: want to hit this for rocky https://review.openstack.org/#/c/643173/15:51
openstackgerritMerged openstack/nova stable/queens: Fix incompatible version handling in BuildRequest  https://review.openstack.org/63443915:51
melwittmriedem: sure15:51
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Fix resetting non-persistent fields when saving obj  https://review.openstack.org/64321515:52
mriedemoh right dan is out today and monday, forgot about that15:53
*** cdent has joined #openstack-nova15:54
mriedemhttps://review.openstack.org/#/c/643215/ is also needed for rocky15:55
*** ttsiouts has joined #openstack-nova15:55
*** lpetrut has quit IRC15:56
*** dustinc has joined #openstack-nova15:56
*** lpetrut has joined #openstack-nova15:56
*** jangutter has quit IRC15:58
*** udesale has quit IRC15:59
*** lpetrut has quit IRC16:13
*** wolverineav has joined #openstack-nova16:21
*** gyee has joined #openstack-nova16:23
*** cdent has quit IRC16:24
*** kmalloc is now known as needscoffee16:25
*** wolverineav has quit IRC16:29
*** wolverineav has joined #openstack-nova16:30
*** luksky has quit IRC16:35
*** sapd1_x has quit IRC16:35
*** belmoreira has quit IRC16:45
*** igordc has joined #openstack-nova17:01
*** mcgiggler has quit IRC17:01
*** elfosardo is now known as rpittau|afk17:08
*** wolverineav has quit IRC17:18
*** itlinux has quit IRC17:18
*** ravirjn has joined #openstack-nova17:19
*** creepy_owlet is now known as dtantsur|afk17:22
*** ttsiouts has quit IRC17:23
*** ttsiouts has joined #openstack-nova17:24
*** tssurya has quit IRC17:24
*** luksky has joined #openstack-nova17:26
*** ttsiouts has quit IRC17:28
*** priteau has quit IRC17:30
*** wolverineav has joined #openstack-nova17:30
*** zhubx007 has quit IRC17:31
*** zhubx007 has joined #openstack-nova17:32
*** wolverineav has quit IRC17:32
*** wolverineav has joined #openstack-nova17:33
ravirjnHi everyone! We have one running newton trippleo cluster. Just now we added HP MSA storage. Now, we want to migrate all nova instances from compute host to cinder volume. But, we are not sure how to migrate instances to cinder volume. For testing, we created a snapshot of a running instance, and created new instance using this instance-snapshot, but, the problem is, the IP addresses are getting changed. Please help.17:33
*** wolverineav has quit IRC17:41
*** wolverineav has joined #openstack-nova17:44
*** jdillaman has quit IRC17:47
openstackgerritMerged openstack/nova stable/rocky: Check hosts have no instances for AZ rename  https://review.openstack.org/64135117:47
openstackgerritMerged openstack/nova master: docs: cleanup driver parity scope section  https://review.openstack.org/64356617:47
openstackgerritMerged openstack/nova master: Remove resize caveat from conductor docs  https://review.openstack.org/64356717:47
openstackgerritMerged openstack/nova master: Add descriptions of numbered resource classes and traits  https://review.openstack.org/62149417:47
openstackgerritMerged openstack/nova master: Trivial typo fix for REST API in policy enforcement docs  https://review.openstack.org/64356917:48
*** wolverineav has quit IRC17:48
*** wolverineav has joined #openstack-nova17:49
*** diablo_rojo has joined #openstack-nova17:50
mdboothmelwitt: http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003870.html17:51
mdboothThe monkey patching thing17:52
*** awaugama has joined #openstack-nova17:52
mdboothIncidentally, I clearly don't understand how we bump requirements.17:53
mdboothI wanted to bump the eventlet version requirement to >=0.21.0. That seems to have failed because we're using 0.18.2, but that seems super old.17:53
mdboothHmm, that's the lower constraint17:54
sean-k-mooney mdbooth would bumping the min version be blocked as we are after the non client lib freeze17:55
mdboothAh, presumably we only install the old stuff for the lower constraints test17:55
sean-k-mooneymdbooth: in the gate yes. that basically just runs the unit tests17:56
mdboothsean-k-mooney: No idea. It's not critical, tbh, as I can easily take that out. I was more interested in why we haven't hit this in the gate yet.17:56
mdboothWe have a workaround in the monkey patching which is no longer required after eventlet 0.21.017:56
sean-k-mooneymdbooth: ya as i said downstream from looking at what we run in the gate we should17:56
mdboothSo while I was in there with a test patch I bumped the eventlet min version and removed it.17:57
mdboothI assumed it would go through as we'd be using a newer version already anyway.17:57
sean-k-mooneywe should not be useing the lower constraint by the way in the tempest job17:58
sean-k-mooneymdbooth: perhaps this is showing up in osp15 because we are packagin an old eventlet17:58
mdboothsean-k-mooney: Nope. Latest and greatest.17:58
sean-k-mooneythe tempest-full-py3 job will use whatever the uppper-constraits.txt allows17:59
melwitt0.24.1 is the upper constraint for eventlet, so I'm not sure why 0.18.2 is being installed https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L14317:59
sean-k-mooneywe should be running 0.20.017:59
sean-k-mooneyhttps://github.com/openstack/requirements/blob/stable/pike/upper-constraints.txt#L14117:59
sean-k-mooneyoh that was pike18:00
mdbooth0.24.118:00
mdboothSame as OSP18:00
mdboothMight be urllib3, then18:00
sean-k-mooneyeventlet===0.24.1 on master18:00
sean-k-mooneyurllib3===1.24.118:00
sean-k-mooneyon master18:00
mdboothOSP: python3-urllib3-1.23-518:01
mdboothSlightly older urllib318:01
mdboothAnyway, as I said in the ML post it's not that important. By not monkey patching first, if it's not this today it will be something else tomorrow.18:01
*** priteau has joined #openstack-nova18:02
sean-k-mooneyya18:03
sean-k-mooneyat somepoint maybe we can finally move away form eventlets entriely but it will atleast be U before that becomes possible18:03
sean-k-mooneyi.e. we need to drop python2 support first18:04
melwittsean-k-mooney: you might be able to help triage this bug, looks in your wheelhouse https://bugs.launchpad.net/nova/+bug/180130318:20
openstackLaunchpad bug 1801303 in OpenStack Compute (nova) "VM send DHCP request before openflow is created in br-int" [Undecided,New]18:20
openstackgerritMerged openstack/nova stable/rocky: Update instance.availability_zone during live migration  https://review.openstack.org/64317318:26
sean-k-mooneymelwitt: sure ill take a look now18:32
melwittsean-k-mooney: thanks18:33
sean-k-mooneymy inital reaction is this shound never happen in any release after we added the vif plugged events as we wait for those on boot18:34
*** tbachman has quit IRC18:34
*** tbachman has joined #openstack-nova18:34
melwittoh, I see. I think it's been awhile since those were added18:34
melwitti.e. before queens18:35
sean-k-mooneyyes back in like mitaka or so queens should have it18:35
sean-k-mooneyim going to ask from mor info on what network backend they are using18:35
melwittok, cool18:35
sean-k-mooneyif they are using odl then that would explain the behavior18:35
melwittoh, right. I vaguely remember that from last time I tried to think about vif plug events xD18:36
sean-k-mooneyodl sends the event on port bind not when odl wires it up18:36
*** eharney has quit IRC18:38
*** wolverineav has quit IRC18:42
*** tesseract has quit IRC18:45
*** wolverineav has joined #openstack-nova18:47
fried_ricemordred: !18:50
fried_ricemordred: I pulled down your openstacksdk patch, diddled with it a little bit, added a kwarg to Connection, instantiated it with a CONF and a session/auth established from ks_loading, and succeeded in talking to placement through it.18:52
*** wolverineav has quit IRC18:52
mordredfried_rice: SWEET!18:52
fried_ricemordred: Permission to upload my changes to your patch so I can create one in nova that depends-on it and proceed?18:52
mordredplease do18:52
mordredfried_rice: that's super exciting that it worked and stuff18:53
mordredor, you know "worked" well enough for you to make it actually work18:53
fried_ricemordred: FYI, my ipython session looked roughly like this:18:53
fried_riceimport openstack18:53
fried_ricefrom nova import conf18:53
fried_riceconf.CONF(args=['--config-file', '/etc/nova/nova-cpu.conf'])18:53
fried_ricefrom keystoneauth1 import loading18:53
fried_riceauth = loading.load_auth_from_conf_options(conf.CONF, 'placement')18:53
fried_ricesess = loading.load_session_from_conf_options(conf.CONF, 'placement', auth=auth)18:53
fried_ricefrom openstack import connection18:53
fried_riceconn = connection.Connection(session=sess, oslo_conf=conf.CONF)18:53
fried_riceconn.placement.get('/resource_providers').json()18:53
*** tosky has quit IRC18:53
fried_riceand obviously the money shot was that last thing producing the expected json payload.18:54
mordredfried_rice: ++18:54
mordredfried_rice: fwiw, when you stitch it in to nova - pass app_name and app_version to the parameters (app_name of "nova" I think :) ) - it updates the user agent strings18:55
fried_ricemordred: okay, will do.18:55
mordredbut does it via appending - so it'll be like nova/blah openstacksdk/blah keystoneauth/blah18:55
fried_ricemordred: um, maybe will add a TODO18:55
mordred++18:55
mordredadd a todo - I can followup18:56
fried_riceright now I just want to PoC this sucker.18:56
mordredyup18:56
fried_ricemordred: btw, is the above connection-y stuff how you envisioned this tying together from the pov of the openstacksdk consumer (i.e. nova)?18:56
fried_riceawkward that there's already a kwarg called `config`; I figured `oslo_conf` was adequately explicit.18:57
mordredfried_rice: yeah - I think that totally works. I was originally thinking the user might just use the openstack.config.from_conf or whatever I called it to make a CloudRegion that could be passed to Connection's config parameter ...18:58
mordredfried_rice: but your way makes total sense and I think should make it nicer for other openstack projects to follow suit18:58
fried_riceight18:58
mordredso "yes"18:58
fried_riceight18:58
sean-k-mooneymelwitt: i have marked https://bugs.launchpad.net/nova/+bug/1801303 as incomplet and subsribed my self to the bug. if i get a responce i will retriage but this likely will end up getting moved to invlaide since its been a few months since it was first reported.19:02
openstackLaunchpad bug 1801303 in OpenStack Compute (nova) "VM send DHCP request before openflow is created in br-int" [Low,Incomplete]19:02
melwittsean-k-mooney: thanks for helping with that. yeah, hopefully we'll get a response19:03
mordredfried_rice: it seems like a slight logic error in Connection ...19:04
mordredbut you said it worked for you19:05
fried_ricemordred: what seems like a logic error?19:05
mordredif session: is the first thing, then elif oslo_conf:19:05
*** martinkennelly has quit IRC19:05
mordredfried_rice: but you're passing in an oslo_conf and a session19:05
fried_ricehum, maybe that means it's only using the session and I don't need the conf :)19:05
fried_riceiow I'm not hitting your code at all19:05
fried_ricetrying...19:06
mordredyeah. it'll totally work just with teh session19:06
mordredbut - if there are any adapter level conf settings - like ... interface, region_name or endpoint_override they'll be ignored19:06
mordred(those being teh ones I could imagine are most likely for someone to set in their nova.conf file19:07
fried_riceack (and confirmed btw). Will twiddle and retry to make sure it still works :)19:07
mordredcool! I left a comment on the review for posterity19:08
fried_rice...also works fwiw19:09
mordred\o/19:09
fried_riceI guess I would need to do something nonstandard with adapter-only settings to make sure it's actually excercising the code, but for now...19:09
mordredor just put ina  print statement :)19:09
mordredbut yeah - I thnk for now that's fine19:10
fried_riceNo, I mean *exercising*19:10
fried_ricelike, I should remove the public interface from my service catalog and set my conf to private19:10
fried_riceor something.19:10
mordredyeah. totally19:10
mordredfried_rice: if it's ok with you - I'll start updating that with docs19:13
fried_ricemordred: It's all yours. I'll buzz you if I need to diddle with it any further for local testing purposes, but I think I'm done for now.19:13
*** priteau has quit IRC19:13
fried_ricemordred: What happens if I pass kwargs like microversion and headers into primitives like .get?19:17
*** gouthamr has quit IRC19:17
fried_riceI think what I'm asking is, do I have to go around and remove all that shit from my placement client to make it go, or can I do that cleanup later?19:18
*** dave-mccowan has quit IRC19:18
mordredit works exactly like keystoneauth adaptr (it is a subclass of a ksa adapter)19:18
fried_riceokay, so probably redundant, but harmless19:18
mordrednah - I think you should totally pass those thigns in19:18
*** IvensZambrano has quit IRC19:19
mordredconn.placement.get() is pure passthrough ksa.Adapter. it doesn't do anything special with microverions for you - other than doing major version discovery19:19
mordredthe higher order methods for other services, like ironic, are where the sdk will be handling microversions and headesr for you19:19
mordredbut for placement - just a one-to-one swap should be totally fine19:19
openstackgerritEric Fried proposed openstack/nova master: WIP/PoC: Use openstacksdk for placement  https://review.openstack.org/64366419:21
fried_ricemordred: ^19:22
fried_riceexpect that to fail unit/functional but pass tempest etc.19:22
*** wolverineav has joined #openstack-nova19:22
fried_riceassuming Depends-On chain works here...19:22
mordredprobably because unit tests mock ksa somehow?19:22
fried_riceyes19:22
fried_riceum19:22
mordredI mean - to be fair - mocking ksa should still work19:22
fried_ricemaybe19:22
mordredsince it's still basically ksa19:22
fried_riceyeah, I suppose it's possible most of the unit/functional will still pass.19:22
fried_riceJust the ones that actually mock the get_ksa_adapter utils19:23
fried_ricewill fail19:23
mordredyeah19:23
fried_ricewe'll see19:23
fried_ricemaybe the whole thing will blow up because I effed something.19:23
fried_riceBut I'm generally super pleased with how simple this is turning out to be to get off the ground.19:23
* fried_rice just cursed self19:23
mordredfried_rice: yeah - being pleased is almost always the wrong choice :)19:24
mordredfried_rice: but yeah -s ince you already jinxed it - I'm also super pleased :)19:25
fried_ricehah!19:25
fried_riceDrinks tonight. Mourning next week.19:25
*** wolverineav has quit IRC19:27
*** dave-mccowan has joined #openstack-nova19:32
*** eharney has joined #openstack-nova19:33
*** mchlumsky_ has quit IRC19:34
*** openstack has joined #openstack-nova19:42
*** ChanServ sets mode: +o openstack19:42
*** dave-mccowan has quit IRC19:43
*** tssurya has joined #openstack-nova19:46
*** ivve has joined #openstack-nova19:48
openstackgerritEric Fried proposed openstack/nova master: WIP/PoC: Use openstacksdk for placement  https://review.openstack.org/64366419:48
fried_riced'oh ^19:48
*** tbachman has quit IRC19:49
*** wolverineav has joined #openstack-nova19:50
*** gouthamr has joined #openstack-nova19:53
*** wolverineav has quit IRC19:57
*** pcaruana has quit IRC19:59
sean-k-mooneyfried_rice: are you going to pivot your ironic clinet patch to similarly use the openstack sdk?20:05
fried_ricesean-k-mooney: yes, was just about to make a start on that, if I can figure out how the baremetal sdk thingies work.20:06
*** wolverineav has joined #openstack-nova20:06
sean-k-mooneycool20:06
sean-k-mooneythe openstacksdk has some gaps compared to the python-*client module but converting what can be converted makes sense20:07
*** wolverineav has quit IRC20:20
*** wolverineav has joined #openstack-nova20:21
*** wolverineav has quit IRC20:25
*** gouthamr_ has joined #openstack-nova20:29
*** ivve has quit IRC20:34
*** whoami-rajat has quit IRC20:46
cfriesensean-k-mooney: https://review.openstack.org/#/c/631363/ and https://review.openstack.org/#/c/639934 seem to be working for me, I would appreciate some eyes on them.20:47
*** hongbin has joined #openstack-nova20:49
*** martinkennelly has joined #openstack-nova20:50
openstackgerritEric Fried proposed openstack/nova master: WIP/PoC: Use SDK instead of ironicclient for node.get  https://review.openstack.org/64289920:52
fried_ricesean-k-mooney, dtantsur|afk, needssleep, mordred: ^20:53
fried_riceIt seems like the Node object from the SDK has different fields than that of the ironicclient. Like, there's no uuid field!20:53
fried_ricewhich made that delta rather more of a pain than I wanted it to be. And will need it vetted by someone like dtantsur|afk20:54
mordredfried_rice: woot! and yeah ... there are a few areas where the sdk strives for internal consistency over consistency with actual external resource. id is one of them20:55
mordredso sorry about the patch size there20:55
mordredfried_rice: but it looks completely reasonable that converting that whole file won't be super terrible20:58
needssleepwell, it was the lift that would have been the tests with how they are written that pretty much stopped me20:59
mordredneedssleep: :)21:02
mordredI know that feeling21:02
*** awaugama has quit IRC21:03
*** marst has quit IRC21:05
*** lbragstad has joined #openstack-nova21:08
fried_riceneedssleep: You mean you don't trust the CI to have complete coverage? :P21:14
mordredBLASPHEMY21:20
*** gouthamr has quit IRC21:22
openstackgerritEric Fried proposed openstack/nova master: Remove [ironic]api_endpoint option  https://review.openstack.org/64348321:22
fried_ricesrsly ^21:22
*** BjoernT has quit IRC21:23
*** BjoernT has joined #openstack-nova21:27
mordredfried_rice: \o/21:29
mnaseryes please kill more endpoint config options :--)21:59
*** tssurya has quit IRC22:10
*** awalende has joined #openstack-nova22:13
mordredmnaser: did you see the other fun from fried_rice above?22:13
*** awalende has quit IRC22:17
*** BjoernT has quit IRC22:18
*** mlavalle has joined #openstack-nova22:19
openstackgerritMerged openstack/nova stable/rocky: Fix resetting non-persistent fields when saving obj  https://review.openstack.org/64321522:32
*** tbachman has joined #openstack-nova22:37
*** tbachman_ has joined #openstack-nova22:39
*** tbachman has quit IRC22:42
*** tbachman_ is now known as tbachman22:42
*** markvoelker has joined #openstack-nova22:51
*** hongbin has quit IRC22:57
*** _alastor_ has quit IRC23:09
*** mriedem has quit IRC23:13
*** _alastor_ has joined #openstack-nova23:21
*** martinkennelly has quit IRC23:27
*** tbachman has quit IRC23:27
openstackgerritMerged openstack/nova stable/queens: Avoid redundant initialize_connection on source post live migration  https://review.openstack.org/63782723:52
openstackgerritMerged openstack/nova stable/pike: Handle missing marker during online data migration  https://review.openstack.org/61134323:52

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!