Monday, 2019-03-18

*** wolverineav has quit IRC00:04
*** wolverineav has joined #openstack-nova00:05
openstackgerritJake Yip proposed openstack/nova master: Add --before to nova-manage db archive_deleted_rows  https://review.openstack.org/55675100:06
openstackgerritJake Yip proposed openstack/nova master: refactor nova-manage archive_deleted_rows  https://review.openstack.org/64377900:06
*** slaweq_ has joined #openstack-nova00:11
*** wolverineav has quit IRC00:14
*** wolverineav has joined #openstack-nova00:22
*** slaweq_ has quit IRC00:24
*** dave-mccowan has joined #openstack-nova00:28
*** dave-mccowan has quit IRC00:31
*** wolverineav has quit IRC00:40
*** wolverineav has joined #openstack-nova00:40
*** _mlavalle_1 has quit IRC00:50
*** wolverineav has quit IRC00:52
*** itlinux has joined #openstack-nova00:59
*** slaweq_ has joined #openstack-nova01:11
*** wolverineav has joined #openstack-nova01:13
*** wolverineav has quit IRC01:20
*** wolverineav has joined #openstack-nova01:21
*** slaweq_ has quit IRC01:24
*** wolverineav has quit IRC01:26
*** marst has joined #openstack-nova01:31
*** lbragstad has joined #openstack-nova01:40
openstackgerrityuanliu proposed openstack/nova master: Fix query method for nova compute services by compute_driver types  https://review.openstack.org/63708301:52
*** wolverineav has joined #openstack-nova02:04
*** slaweq_ has joined #openstack-nova02:11
*** wolverineav has quit IRC02:15
*** sapd1_x has joined #openstack-nova02:16
*** lbragstad has quit IRC02:17
*** BjoernT has joined #openstack-nova02:19
*** irclogbot_2 has quit IRC02:23
*** slaweq_ has quit IRC02:24
*** edmondsw has quit IRC02:26
*** edleafe has quit IRC02:27
openstackgerrityuanliu proposed openstack/nova master: Fix query method for nova compute services by compute_driver types  https://review.openstack.org/63708302:38
*** alex_xu has joined #openstack-nova02:38
*** marst has quit IRC02:40
*** BjoernT has quit IRC02:48
*** BjoernT has joined #openstack-nova02:49
*** nicolasbock has quit IRC02:58
*** BjoernT has quit IRC03:06
*** slaweq_ has joined #openstack-nova03:11
*** hongbin has joined #openstack-nova03:12
*** BjoernT has joined #openstack-nova03:16
*** hongbin has quit IRC03:21
*** slaweq_ has quit IRC03:25
*** sapd1_x has quit IRC03:26
*** wolverineav has joined #openstack-nova03:29
*** wolverineav has quit IRC03:33
*** whoami-rajat has joined #openstack-nova03:46
*** ttsiouts has quit IRC03:52
*** janki has joined #openstack-nova04:05
*** udesale has joined #openstack-nova04:08
*** slaweq_ has joined #openstack-nova04:14
*** itlinux has quit IRC04:15
*** BjoernT has quit IRC04:20
*** slaweq_ has quit IRC04:24
ravirjnCan anyone please help me regarding, how to migrate instances from compute host (ephemeral disk) to cinder volume without any changes in IP addresses? I have one running Newton trippleo cluster.05:15
*** slaweq_ has joined #openstack-nova05:16
*** ivve has quit IRC05:22
*** slaweq_ has quit IRC05:24
openstackgerritSeyeong Kim proposed openstack/nova stable/rocky: Extract compute API _create_image to compute.utils  https://review.openstack.org/64385205:32
openstackgerritSeyeong Kim proposed openstack/nova stable/rocky: Share snapshot image membership with instance owner  https://review.openstack.org/64385305:32
*** rcernin has quit IRC05:43
openstackgerritMichael Still proposed openstack/nova master: Move slight bonkers IP management to privsep.  https://review.openstack.org/62459205:44
openstackgerritMichael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement.  https://review.openstack.org/63543105:44
openstackgerritMichael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods.  https://review.openstack.org/63543305:44
openstackgerritMichael Still proposed openstack/nova master: Privsep the ebtables modification code.  https://review.openstack.org/63543505:44
openstackgerritMichael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep.  https://review.openstack.org/63543605:44
openstackgerritMichael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep.  https://review.openstack.org/63650805:44
openstackgerritMichael Still proposed openstack/nova master: Move dnsmasq restarts to privsep.  https://review.openstack.org/63928005:44
openstackgerritMichael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep.  https://review.openstack.org/63928105:44
openstackgerritMichael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep.  https://review.openstack.org/63928205:44
openstackgerritMichael Still proposed openstack/nova master: Move setting of device trust to privsep.  https://review.openstack.org/63928305:44
openstackgerritMichael Still proposed openstack/nova master: Move final bridge commands to privsep.  https://review.openstack.org/63958005:44
openstackgerritMichael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network.  https://review.openstack.org/63958105:44
openstackgerritMichael Still proposed openstack/nova master: We no longer need rootwrap.  https://review.openstack.org/55443805:44
openstackgerritMichael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note.  https://review.openstack.org/63982605:44
*** jaosorior has joined #openstack-nova05:45
*** rcernin has joined #openstack-nova05:59
*** ratailor has joined #openstack-nova06:10
*** slaweq_ has joined #openstack-nova06:11
openstackgerritBrin Zhang proposed openstack/nova master: Remove the string check of the flavor attribute 'swap'  https://review.openstack.org/63901206:11
*** sapd1_x has joined #openstack-nova06:18
*** slaweq_ has quit IRC06:24
*** ivve has joined #openstack-nova06:30
*** wolverineav has joined #openstack-nova06:45
*** wolverineav has quit IRC06:50
*** Luzi has joined #openstack-nova06:53
*** phasespace has quit IRC06:54
*** jaosorior has quit IRC06:58
*** ivve has quit IRC07:07
*** luksky has joined #openstack-nova07:08
*** tkajinam_ has joined #openstack-nova07:11
*** jaosorior has joined #openstack-nova07:11
*** tkajinam has quit IRC07:13
*** slaweq_ has joined #openstack-nova07:13
*** luksky has quit IRC07:18
*** pcaruana has joined #openstack-nova07:19
*** dpawlik has joined #openstack-nova07:23
*** belmoreira has joined #openstack-nova07:24
openstackgerritzhangyangyang proposed openstack/nova master: Drop py35 tests  https://review.openstack.org/64386807:25
openstackgerritzhangyangyang proposed openstack/nova master: Drop py35 jobs and add py36 jobs  https://review.openstack.org/64387107:34
*** jaosorior has quit IRC07:35
*** ivve has joined #openstack-nova07:38
*** jaosorior has joined #openstack-nova07:44
*** jaosorior has quit IRC07:44
*** xek has joined #openstack-nova07:45
openstackgerritYongli He proposed openstack/nova master: Clean up orphan instances  https://review.openstack.org/62776507:50
*** luksky has joined #openstack-nova08:01
*** awalende has joined #openstack-nova08:02
openstackgerritzhangyangyang proposed openstack/python-novaclient master: Drop py35 tests  https://review.openstack.org/64387308:02
*** tosky has joined #openstack-nova08:05
*** ttsiouts has joined #openstack-nova08:06
*** tosky has quit IRC08:07
*** tesseract has joined #openstack-nova08:07
*** phasespace has joined #openstack-nova08:11
*** mikal has joined #openstack-nova08:12
*** ccamacho has joined #openstack-nova08:19
*** rpittau|afk is now known as rpittau08:19
*** sridharg has joined #openstack-nova08:20
*** tkajinam_ has quit IRC08:24
*** zhubx has quit IRC08:25
*** tosky has joined #openstack-nova08:26
*** priteau has joined #openstack-nova08:26
*** zhubx has joined #openstack-nova08:27
*** lennyb has joined #openstack-nova08:31
*** jangutter has joined #openstack-nova08:34
*** tssurya has joined #openstack-nova08:36
bauzasgood morning folks08:55
*** luksky has quit IRC08:55
*** luksky has joined #openstack-nova08:57
*** sapd1_x has quit IRC08:57
gibibauzas: good morning bauzas08:58
* bauzas was off mostly all the last week08:59
bauzasI'll try to look at the bugs08:59
*** brault has joined #openstack-nova09:03
tssuryagood morning nova!09:04
tssuryaalex_xu, gmann and other API experts : would you have a look at https://review.openstack.org/#/c/638629/ when you have the time ? we would like to have the nova lock description info downstream09:06
alex_xutssurya: yea, copy that, will try it soon09:06
tssuryathanks alex_xu :)09:07
alex_xunp09:07
*** brault has quit IRC09:09
*** dtantsur|afk is now known as dtantsur09:11
*** belmoreira has quit IRC09:15
openstackgerritMichael Still proposed openstack/nova master: Remove fake_libvirt_utils from connection tests.  https://review.openstack.org/64255709:22
openstackgerritMichael Still proposed openstack/nova master: Remove fake_libvirt_utils from snapshot tests.  https://review.openstack.org/64255809:22
openstackgerritMichael Still proposed openstack/nova master: Make privsep.chown mocking for libvirt snapshot tests less magic.  https://review.openstack.org/64213409:22
openstackgerritMichael Still proposed openstack/nova master: Remove fake_libvirt_utils from virt driver tests.  https://review.openstack.org/64389409:22
openstackgerritMichael Still proposed openstack/nova master: Remove fake_libvirt_utils from libvirt imagebackend tests.  https://review.openstack.org/64389509:22
openstackgerritMichael Still proposed openstack/nova master: Remove remaining vestiges of fake_libvirt_utils from unit tests.  https://review.openstack.org/64389609:22
openstackgerritMichael Still proposed openstack/nova master: Complete remove fake_libvirt_utils.  https://review.openstack.org/64389709:22
*** mikal has quit IRC09:27
*** mikal has joined #openstack-nova09:28
*** luksky has quit IRC09:31
*** mikal has quit IRC09:32
*** wolverineav has joined #openstack-nova09:54
*** cdent has joined #openstack-nova09:55
*** wolverineav has quit IRC09:58
lyarwoodbauzas: https://review.openstack.org/#/c/628726/ - morning, mind taking another look at this now I've had to revert to the original change, with conflicts etc?10:03
bauzassure10:03
bauzaslyarwood: haha, zuul gave you again my -1 because you rebased to PS3  :)10:04
lyarwoodbauzas: yeeeeeeeeeah, fun times :)10:05
kashyapbauzas: alex_xu: Morning, can either of you put this simple 4-patch series through? -- https://review.openstack.org/#/q/topic:bug/1818847+(status:open+OR+status:merged)10:06
bauzasqueuing10:07
kashyapThanks!10:09
bauzaslyarwood: I'm confused with the gerrit ordering10:13
openstackgerritKashyap Chamarthy proposed openstack/nova master: qemu: Make disk image conversion dramatically faster  https://review.openstack.org/64078110:15
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode for Nova instances  https://review.openstack.org/64198110:15
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: vzstorage: Use 'writeback' QEMU cache mode  https://review.openstack.org/64337610:15
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: smbfs: Use 'writeback' QEMU cache mode  https://review.openstack.org/64337710:15
*** luksky has joined #openstack-nova10:21
bauzasis it me or gerrit is in the weeds ?10:27
openstackgerritBalazs Gibizer proposed openstack/nova master: Documentation for bandwidth support  https://review.openstack.org/64206410:28
*** udesale has quit IRC10:28
kashyapbauzas: Loads fine for me10:28
*** mikal has joined #openstack-nova10:28
bauzasgraaaah10:28
gibibauzas: gerrit was down for me too for a while10:28
bauzasI also have a super bad DSL connection10:28
kashyapgibi: If you have time, would appreciate your quick eyes on this: https://review.openstack.org/#/q/topic:bug/1818847+(status:open+OR+status:merged)10:29
kashyapAlready has +2s from efried10:29
gibikashyap: ack10:29
bauzaskashyap: you were next in the queue10:29
kashyapThank you, both.10:30
kashyapbauzas: The first patch in the series, I only fixed my own OCD nit-pick (remove a needless comma); so it might fall into the "fast-approve" zone.10:31
bauzasgtk10:31
*** mikal has quit IRC10:32
*** nicolasbock has joined #openstack-nova10:35
openstackgerritMerged openstack/nova master: Pass kwargs to exception to get better format of error message  https://review.openstack.org/64350110:57
*** ratailor has quit IRC11:04
bauzaskashyap: just provide a note and fix the commit msg and I'm +2/+W11:07
bauzaskashyap: for https://review.openstack.org/#/c/640781/811:07
*** slaweq_ is now known as slaweq11:14
* kashyap looks11:16
kashyapbauzas: On the full SHA-1, note how I also put in the commit _summary_ -- so there is no confusion at all :-)11:17
kashyapIf one is not putting the one-line commit summary next to the short SHA-1, then I agree that adding a full SHA-1 would be useful11:18
*** ttsiouts has quit IRC11:21
kashyapCan do the rel note, if you think it's useful11:21
*** sapd1_x has joined #openstack-nova11:23
*** sajauddin has joined #openstack-nova11:36
*** kaiokmo has quit IRC11:37
openstackgerritKashyap Chamarthy proposed openstack/nova master: qemu: Make disk image conversion dramatically faster  https://review.openstack.org/64078111:42
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode for Nova instances  https://review.openstack.org/64198111:43
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: vzstorage: Use 'writeback' QEMU cache mode  https://review.openstack.org/64337611:43
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: smbfs: Use 'writeback' QEMU cache mode  https://review.openstack.org/64337711:43
kashyapbauzas: ^ Added the rel note, and the full SHA111:43
* kashyap --> lunch11:43
*** udesale has joined #openstack-nova11:45
*** rcernin has quit IRC11:46
*** ttsiouts has joined #openstack-nova11:47
*** belmoreira has joined #openstack-nova11:47
kashyapThanks for the review!11:49
*** edmondsw has joined #openstack-nova11:50
*** jaosorior has joined #openstack-nova11:51
*** tbachman has joined #openstack-nova11:53
*** udesale has quit IRC12:01
*** udesale has joined #openstack-nova12:02
*** sajauddin has quit IRC12:13
*** edleafe has joined #openstack-nova12:21
*** markvoelker has quit IRC12:22
*** udesale has quit IRC12:27
*** udesale has joined #openstack-nova12:28
*** whoami-rajat has quit IRC12:35
*** eharney has joined #openstack-nova12:39
*** yan0s has joined #openstack-nova12:43
yaawangkashyap: hi, have you seen the review of https://review.openstack.org/#/c/642030/ :)12:45
kashyapyaawang: Will look at it shortly.12:46
*** ralonsoh has joined #openstack-nova12:48
yaawangThanks12:50
*** pcaruana|afk| has joined #openstack-nova12:54
*** dpawlik has quit IRC12:55
*** eharney has quit IRC12:56
*** pcaruana has quit IRC12:56
*** mriedem has joined #openstack-nova12:58
*** whoami-rajat has joined #openstack-nova13:08
*** dave-mccowan has joined #openstack-nova13:09
*** BjoernT has joined #openstack-nova13:13
*** mchlumsky has joined #openstack-nova13:14
*** dave-mccowan has quit IRC13:15
*** lbragstad has joined #openstack-nova13:18
*** needssleep is now known as TheJulia13:18
*** dpawlik has joined #openstack-nova13:24
*** marst has joined #openstack-nova13:26
bauzasefried: when you're back, please look at https://review.openstack.org/#/c/640781/13:30
*** awaugama has joined #openstack-nova13:34
*** mikal has joined #openstack-nova13:34
*** ttsiouts has quit IRC13:36
efriedbauzas: looking...13:36
*** mchlumsky has quit IRC13:37
efriedbauzas, kashyap: +A13:37
bauzasta13:37
*** sapd1_x has quit IRC13:38
*** mikal has quit IRC13:39
*** mchlumsky has joined #openstack-nova13:40
mriedemefried: bauzas: kashyap: https://review.openstack.org/#/c/641981/13:40
mriedemthe default changed right?13:40
*** ttsiouts has joined #openstack-nova13:41
*** marst has quit IRC13:41
bauzasmriedem: lemme look13:41
kashyapmriedem: Yes, mea culpa13:41
kashyapThat's why I was badgering other reviewers if I missed anything else13:41
*** ttsiouts_ has joined #openstack-nova13:42
kashyapefried: Let me quickly update the help file13:42
bauzasmriedem: ah, good point about the conf opt13:42
kashyapmriedem: There's already a rel note in the other patch; but I'll expand for this, too13:42
bauzasmriedem: I already asked for a relnote in the below change13:42
bauzasyeah this13:42
mriedemthey are different changes though13:42
kashyapTrue13:42
kashyapOne is for image conversion, the other is for Nova instances.13:42
bauzasokay, passing a new PS13:43
kashyapAlso that help text needs an update (as a separate change, later).  I had a lengthy e-mail chain with the QEMU Block Layer folks.  Based on that our docs can do an update13:43
bauzasfor stopping the CI13:43
efriedI didn't realize there was a conf option. It wasn't apparent in the code.13:43
openstackgerritSylvain Bauza proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode for Nova instances  https://review.openstack.org/64198113:44
bauzaskashyap: ^13:44
bauzasit blocks the CI13:44
efriedwow, I'm still not seeing how that attribute gets set from that conf option.13:44
kashyapAlso the whole cache modes help text needs an update (as a separate change), based on a lengthy e-mail chain with the QEMU Block Layer folks.13:45
kashyapErr, disregard that duplicate13:46
*** ttsiouts has quit IRC13:46
*** pcaruana|afk| has quit IRC13:48
*** sapd1_x has joined #openstack-nova13:50
kashyapefried: See this:13:51
kashyap       for mode_str in CONF.libvirt.disk_cachemodes:13:51
kashyap            disk_type, sep, cache_mode = mode_str.partition('=')13:51
kashyap            if cache_mode not in self.valid_cachemodes:13:51
kashyap                LOG.warning('Invalid cachemode %(cache_mode)s specified '13:51
kashyap                            'for disk type %(disk_type)s.',13:52
kashyap                            {'cache_mode': cache_mode, 'disk_type': disk_type})13:52
kashyap                continue13:52
kashyap            self.disk_cachemodes[disk_type] = cache_mode13:52
efriedn-sch meeting in 8 minutes in #openstack-meeting-alt13:52
efriedkashyap: Yeah, but I still don't see how that's feeding into the self._disk_cachemode attr13:52
*** cfriesen has joined #openstack-nova13:54
* kashyap digs13:56
mriedemis it just me or does this seem somewhat risky to be rushing in right before rc1?13:57
mriedemgiven the complication13:57
openstackgerritLance Bragstad proposed openstack/nova master: Remove obsolete policy configuration details from docs  https://review.openstack.org/64394913:57
*** tetsuro has joined #openstack-nova13:57
*** jding1_ has quit IRC13:58
*** maciejjozefczyk has joined #openstack-nova13:58
*** takashin has joined #openstack-nova13:58
mriedemin other news, i'm +2 on gibi's bw provider nova docs https://review.openstack.org/#/c/642064/13:59
bauzasmriedem: what do you make you feel rushing ?13:59
bauzaskashyap's change ? If so, I just stopped the gate run given your good comments13:59
bauzasand I'm fine with discussing it13:59
mriedemwe're a few days from RC1, this is a latent bug, and does not seem trivial14:00
mriedemhence it seems risky to me,14:00
kashyapmriedem: I'm fine delaying it14:00
bauzasfair enough, we can take time14:00
bauzasI didn't wanted to rush14:00
mriedemi.e. i don't know if this is totally fine with NFS deployments (not that i particularly care about NFS)14:00
mriedemi know writeback is recommended for rbd users, so is there a bias here?14:00
kashyapmriedem: On that topic, it is.  I ran this past the QEMU Block Layer folks over a lengthy thread14:01
mriedemkashyap: yeah i trust you've done your homework14:01
kashyapSee the commit message for on the question of NFS14:01
mriedemgiven the commit message14:01
mriedemwell, which commit message?14:01
kashyap1 sec14:01
mriedemi guess you mean https://review.openstack.org/#/c/640781/9//COMMIT_MSG14:01
mriedemwhich i also commented on14:01
mriedembut again, those are different patches14:02
mriedemone is image conversion and one is the disk config for local disks yeah?14:02
kashyapmriedem: Ah, just saw your comment.  So, that applies to both the patches14:02
kashyapSo I should add remark in the patch that changes it for the Nova instances?14:02
kashyaps/?//14:03
mriedemprobably, but it's saying that if the host crashes during writes to NFS, it doesn't matter - but with writethrough each write gets an fsync yeah?14:03
kashyapI checked with Kevin Wolf, he said in _both_ cases: (a) for image conversion; and (b) for Nova instances14:03
mriedemand with writeback they wouldn't14:03
mriedemso you'd lose those writes on NFS right?14:03
kashyap... 'writeback' is fine even in NFS.14:04
mriedemdoes this all assume some minimum version of qemu for that safety behavior?14:04
kashyapmriedem: Yes, with 'writethrough', each write gets an fsync().14:04
mriedemb/c as noted, danpb wrote this code14:04
*** eharney has joined #openstack-nova14:04
kashyapmriedem: Yes, danpb also incidentally saw and said: "Nova is using the wrong cache mode in both cases, conversion & for guests"14:05
kashyapOn minimum version --14:05
bauzasmriedem: apologies if you felt I trampled your -1 by a new PS, it was just for stopping the gate run, i should have added my own -1 with it14:05
kashyapmriedem: We have it since QEMU 1.1 (released in 2012).  I noted it in the commit message with references: see lines 67-7114:06
mriedemkashyap: ack yeah ok i glossed over that14:07
*** marst has joined #openstack-nova14:07
mriedembut that is also true in the non-image conversion case?14:08
kashyapmriedem: Yest that's what the QEMU Block Layer folks said.  Let me confirm once more.14:09
kashyapmriedem: Okay, yes.  even for non-image conversion case, 'writeback' is correct.14:10
mriedemso let me ask another way, in what case would anyone use writethrough?14:10
kashyapGood question14:10
kashyapmriedem: You'd use it if your guest OS really really sucks and doesn't issue fluses where data must be safe on disk.14:11
kashyapBut note:14:11
kashyapSuch "suck OSes" are things RHEL-4 or even older versions of Windows14:12
kashyapFWIW, the commit message and the text I've written is also reviewed by QEMU folks; I wasn't riffing on it :-)14:13
*** amodi has joined #openstack-nova14:13
mriedemi'm not sure there is a way to make this configuration per-guest in nova,14:15
mriedembut ok14:15
mriedemi.e. i'm not aware of an image property to override the configuration14:16
kashyapMe neither14:16
*** mgariepy has quit IRC14:18
kashyapmriedem: Replied on the commit on your note about DanPB's 2012 commit.14:24
openstackgerritLance Bragstad proposed openstack/nova master: Clarify policy short-comings in policy enforcement doc  https://review.openstack.org/64396014:27
*** hongbin has joined #openstack-nova14:28
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add functional test to check the addition of an interface to a linux bridge  https://review.openstack.org/64396414:30
*** pcaruana has joined #openstack-nova14:33
*** BjoernT has quit IRC14:35
*** amodi has quit IRC14:35
mriedemlbragstad: replied in https://review.openstack.org/#/c/643949/1/doc/source/reference/policy-enforcement.rst@117 - that's a good question for which i'm not sure i have a good answer,14:37
mriedemi'm inclined to say we could just remove that section14:37
mriedembut maybe run it by the patrole/ops people first14:37
*** jdillaman has joined #openstack-nova14:38
*** BjoernT has joined #openstack-nova14:40
gmanntssurya: sure, i will check today.14:41
lbragstadmriedem sweet14:41
openstackgerritOpenStack Release Bot proposed openstack/os-resource-classes stable/stein: Update .gitreview for stable/stein  https://review.openstack.org/64402814:42
openstackgerritOpenStack Release Bot proposed openstack/os-resource-classes stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein  https://review.openstack.org/64402914:42
openstackgerritOpenStack Release Bot proposed openstack/os-resource-classes master: Update master for stable/stein  https://review.openstack.org/64403014:42
openstackgerritOpenStack Release Bot proposed openstack/os-traits stable/stein: Update .gitreview for stable/stein  https://review.openstack.org/64403114:42
openstackgerritOpenStack Release Bot proposed openstack/os-traits stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein  https://review.openstack.org/64403214:42
*** sapd1_x has quit IRC14:42
openstackgerritOpenStack Release Bot proposed openstack/os-traits master: Update master for stable/stein  https://review.openstack.org/64403314:42
openstackgerritOpenStack Release Bot proposed openstack/os-vif stable/stein: Update .gitreview for stable/stein  https://review.openstack.org/64403414:42
openstackgerritOpenStack Release Bot proposed openstack/os-vif stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein  https://review.openstack.org/64403514:42
*** sridharg has quit IRC14:42
openstackgerritOpenStack Release Bot proposed openstack/os-vif master: Update master for stable/stein  https://review.openstack.org/64403614:42
*** pawel-baclawski has joined #openstack-nova14:42
lbragstadmriedem i'm not sure how much review spam you want - but i was planning on following up each section in 643960 with it's own patch14:43
mriedemyeah i assumed that was coming since it says "Each issue14:44
mriedemhas a section dedicated to describing the underlying cause and historical14:44
mriedemcontext in greater detail."14:44
lbragstadif that's too verbose - i can propose it in one patch, too14:47
mriedemlbragstad: a question and some nits in https://review.openstack.org/#/c/643960/14:49
lbragstadawesome - i'll take a look14:50
*** takashin has left #openstack-nova14:53
kashyapmriedem: So, on cache mode change for Nova guests: (a) The existing Nova help text is broken: it claims "writethrough" as the default, it is not the case; (b) My patch doesn't change the _default_ -- see my last comment here: https://review.openstack.org/#/c/641981/714:53
*** tetsuro has quit IRC14:54
*** malekmar has joined #openstack-nova14:56
*** amodi has joined #openstack-nova14:56
*** zkzmmrc has joined #openstack-nova14:56
*** liuyulong has joined #openstack-nova14:57
*** malekmar has quit IRC14:59
*** malekmar has joined #openstack-nova14:59
*** awalende has quit IRC14:59
*** pawel-baclawski has quit IRC14:59
kashyapIt seems you've added that help text from an IBM help doc (commit: 3d9a76bd71159a3e8ce0acdb27ec76381b1024fc)15:00
*** awalende has joined #openstack-nova15:00
mriedemkashyap: yes, i fleshed out the help from libvirt and ibm help docs because before that it was a one-line unhelpful help string15:00
kashyapmriedem: Yeah, I see your intention was good.  I'm trying to find the new URL of that IBM doc15:01
*** tuchopaw has joined #openstack-nova15:01
kashyapBecause QEMU's default has been 'writeback' (for guests) for ages; not sure why the IBM doc claimed it to be 'writethrough'15:01
mdboothCan anybody tell me which package provides the 'openssl' binary on Ubuntu?15:02
* mdbooth is adding a missing bindep15:02
*** BjoernT_ has joined #openstack-nova15:02
*** tuchopaw has quit IRC15:02
mriedemumm, openssl?15:02
*** phasespace has quit IRC15:03
mdboothmriedem: That's what it's called on Fedora. Just wanted to ensure it's not called something else in foreign parts.15:03
mriedemhttp://lmgtfy.com/?q=ubuntu+openssl+package15:03
* mdbooth would not normally google something like that15:04
kashyapmriedem: Hehe, I seem to have already debunked the IBM doc 2014!  -- https://www.redhat.com/archives/libvirt-users/2014-August/msg00060.html (Behavior of disk caching with qcow2 disks15:04
* mdbooth prefers the trusty output of: rpm -qf /usr/bin/openssl15:04
mdboothOr however that translates when you make it brown15:04
*** awalende has quit IRC15:04
*** BjoernT has quit IRC15:05
*** zkzmmrc has quit IRC15:06
*** malekmar has quit IRC15:06
*** tuchopaw has joined #openstack-nova15:07
*** BjoernT has joined #openstack-nova15:07
openstackgerritMatthew Booth proposed openstack/nova master: Remove eventlet hub workaround for monotonic clock  https://review.openstack.org/64423715:07
openstackgerritMatthew Booth proposed openstack/nova master: Add missing test bindep on openssl  https://review.openstack.org/64423815:07
*** malekmar has joined #openstack-nova15:07
*** pawel-baclawski has joined #openstack-nova15:08
*** BjoernT_ has quit IRC15:10
*** tuchopaw has quit IRC15:11
*** pawel-baclawski has quit IRC15:12
*** mlavalle has joined #openstack-nova15:13
*** Luzi has quit IRC15:13
*** malekmar has quit IRC15:16
*** hrw has left #openstack-nova15:16
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: vzstorage: Use 'writeback' QEMU cache mode  https://review.openstack.org/64337615:16
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: smbfs: Use 'writeback' QEMU cache mode  https://review.openstack.org/64337715:16
*** kuzmlmar has joined #openstack-nova15:16
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode for Nova instances  https://review.openstack.org/64198115:16
openstackgerritGorka Eguileor proposed openstack/nova master: Fix unnecessary locking when connecting volumes  https://review.openstack.org/61419015:19
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode when 'none' is not viable  https://review.openstack.org/64198115:20
kashyapbauzas: mriedem: efried: The above patch doesn't need a rel eng; we aren't changing the default - I updated the commit message to reflect that.15:20
kashyap(And fixed the wrong info in the Nova conf doc, which came in via another misinfo from IBMs's doc, which disappeared)15:21
kashyapHuh, let me reorder them patches correctly.  Sorry for the noise.15:23
*** mikal has joined #openstack-nova15:23
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode when 'none' is not viable  https://review.openstack.org/64198115:25
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: vzstorage: Use 'writeback' QEMU cache mode  https://review.openstack.org/64337615:25
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: smbfs: Use 'writeback' QEMU cache mode  https://review.openstack.org/64337715:25
*** janki has quit IRC15:26
gibimelwitt, mriedem: the bandwidth documentation patch for neutron is ready to review https://review.openstack.org/#/c/64039015:27
*** mikal has quit IRC15:27
mriedemgibi: ok, should probably get mlavalle to review that since he worked on it15:30
gibimriedem: sure15:32
gibiI just wanted to note that it is not wip any more15:32
*** dpawlik has quit IRC15:35
*** BjoernT has quit IRC15:37
*** BjoernT_ has joined #openstack-nova15:37
*** mgariepy has joined #openstack-nova15:38
tssuryathanks gmann15:54
*** kuzmlmar has quit IRC15:56
*** maciejjozefczyk has quit IRC16:01
*** weshay|rover is now known as weshay16:02
*** dpawlik has joined #openstack-nova16:04
*** ttsiouts_ has quit IRC16:05
*** dpawlik has quit IRC16:08
*** ttsiouts has joined #openstack-nova16:13
*** tbachman has quit IRC16:15
kashyapefried: Just to tie-up the loose end: your observation was correct earlier -- self._disk_cachemode does _not_ get fed in by the CONF.libvirt.disk_cachemodes16:16
* kashyap --> needs to be AFK; back later16:19
kashyapmdbooth: Thanks for the review, again.  It's like a whack-a-mole.  Just when I think I fixed all occurrences...16:20
mriedemaspiers: efried: i'm doing some testing in devstack with the compute capabilites as traits stuff and i'm not seeing where / when a sighup is needed https://review.openstack.org/#/c/538498/22/releasenotes/notes/driver-capabilities-to-traits-152eb851cd016f4d.yaml16:21
mdboothkashyap: Hehe.16:21
*** yan0s has quit IRC16:21
*** udesale has quit IRC16:21
*** BjoernT_ has quit IRC16:21
mdboothkashyap: Incidentally, if at all possible can you avoid rebasing?16:22
kashyapmdbooth: Sure.  I was fixing commit messages by re-ordering patches, and forgot to put them back in the same order one of the times16:23
mdboothAck16:23
kashyap(Once I needed a genuine rebase due to that "compress" flag landing)16:23
tssuryamriedem: whenever you have time and if you remember, do you know why we didn't go ahead with https://review.openstack.org/#/c/218975 ? I can't find it in the history in case there was any opposition16:24
mdboothkashyap: Did you see your release note build failure, btw?16:24
kashyapmdbooth: I didn't, will look in the AM.  Have to bike to my Dutch class shortly, and stay alert for 3 1/2 hours...16:25
mdboothkashyap: That's on the bottom patch, so you're going to have to beg for your +2s back.16:25
mriedemtssurya: go ahead with that patch or the alternative discussed between myself and alaski?16:25
tssuryago ahead with that patch I mean16:25
openstackgerritBalazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance to make place for port healing  https://review.openstack.org/63795316:26
tssuryato add the config16:26
openstackgerritBalazs Gibizer proposed openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations  https://review.openstack.org/63795416:26
openstackgerritBalazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations  https://review.openstack.org/63795516:26
openstackgerritBalazs Gibizer proposed openstack/nova master: cache neutron ports in heal allocation  https://review.openstack.org/63820716:26
mriedemsee the comments between myself and laski :)16:26
kashyapThanks for the heads-up.  mdbooth: And yes, I'll add a rel note.16:26
tssuryamriedem: shoot my bad sorry :)16:28
mriedemtssurya: are you hitting an issue with baremetal nodes?16:29
tssuryamriedem: the power sync stuff https://review.openstack.org/#/c/636132/16:29
tssuryaworking on it since we need it downstream16:30
tssuryaso was going through the history16:30
mriedemok you're aware of https://github.com/openstack/nova/commit/19cb8280232fd3b0ba0000a475d061ea9fb10e1a right?16:30
tssuryayea16:30
*** BjoernT has joined #openstack-nova16:31
*** diablo_rojo has joined #openstack-nova16:33
*** wolverineav has joined #openstack-nova16:35
*** dpawlik has joined #openstack-nova16:36
*** dpawlik has quit IRC16:42
cfriesenprocess question...when does the stein branch get created?16:44
*** tssurya has quit IRC16:44
edleafe cfriesen: usually when RC1 is cut16:46
*** wolverineav has quit IRC16:52
mriedemcfriesen: iow thursday16:53
cfriesenthx, was just looking at the release timeline.16:54
efriedmriedem: Set your association refresh interval to 0 and you'll need that SIGHUP16:54
efriedmriedem: I reckon we're deprecating that option soon16:55
openstackgerritBalazs Gibizer proposed openstack/nova master: Remove put_allocations() from report client  https://review.openstack.org/64429216:55
efriedI think we maybe wanted to give CERN a little while to play first16:55
mdboothEurgh: http://logs.openstack.org/52/626952/5/check/openstack-tox-py37/47f5826/job-output.txt.gz16:56
mdbootheventlet monkey patching for command line tools which import nova?16:56
openstackgerritMatt Riedemann proposed openstack/nova master: Add docs for compute capabilities as traits  https://review.openstack.org/64429316:57
mriedemefried: oh.....well i guess i need to update this then ^ but that wasn't mentioned in the reno16:57
mdboothIt really would be better to monkey patch at specific entry points :/16:57
*** ttsiouts has quit IRC16:57
*** itlinux has joined #openstack-nova16:58
efriedmriedem: hm, the default there is five minutes, was there any science behind "60 seconds" or was that anecdotal?16:59
*** wolverineav has joined #openstack-nova16:59
mriedemanecdotal17:01
mriedemi'm trying again now17:01
mriedemwith resource_provider_association_refresh=017:01
*** mgoddard has quit IRC17:02
mdboothWhat's api-paste.ini used for, and what are the implications of making changes there?17:03
cdentmdbooth: it configures middleware used by the api17:04
cdentthe difficulty with make changes there is that it is in that hybrid realm of config file and also stuff that's required17:05
mdboothcdent: So changes to the one we have in tree would have deployment implications?17:05
cdentyes17:05
mdboothEurgh17:05
cdentHowever, we have changed it in the past17:05
cdentso it's not impossible17:05
mdboothI basically wanted to airlift it into a module which isn't called __init__.py17:06
cdentthere's been talk of trying to get rid of it for a long time (similar to policy-defaults-in-code)17:06
mriedemrpms should mark that file as config so updates shouldn't overwrite it17:06
mdboothHowever, that would change a bunch of object paths, and therefore require changes in api-paste.ini17:06
mriedemapi-paste.ini at this point is mostly just a relic17:07
cdentmdbooth: yeah, this is one of the places I fell down when doing my own roam through __init__ files17:07
mdboothOr... I could just move monkey patching to the top of it and leave it there...17:07
mriedemwhen nova and openstack in general were more open to extension points17:07
*** mgoddard has joined #openstack-nova17:08
mdboothMy latest version of the monkey patching change moves monkey patching into nova/__init__.py, and also adds a couple of assertions which will explode if you've imported libraries with known problems before monkey patching17:09
mdboothWhich sounded great, until I realised that command line tools also import nova17:09
mdboothtesting, ftw17:09
mdboothSo now I'm looking again at monkey patching only for certain entry points17:10
mdboothBut we can't monkey patch lower than nova/api/openstack/... because __init__.py imports the world17:10
cdentayup17:10
*** mikal has joined #openstack-nova17:11
mdboothI was hoping to move that out of the way, but that looks depressingly involved17:11
*** dpawlik has joined #openstack-nova17:11
*** ivve has quit IRC17:13
*** dpawlik has quit IRC17:16
*** mikal has quit IRC17:16
*** BjoernT has quit IRC17:19
mriedemefried: hmm, what am i missing with trying to hup n-cpu in devstack: sudo systemctl kill -s HUP devstack@n-cpu.service17:21
mriedemdoesn't seem to be doing anything17:21
efriedmriedem: have you tried just finding the pid?17:22
mriedemhmm, i must have killed it somehow17:26
mriedemActive: inactive (dead) since Mon 2019-03-18 17:09:49 UTC; 16min ago17:26
mriedemgot it17:31
mriedemINFO nova.compute.manager [None req-65477139-47bd-4419-b5b3-d729fdadb369 None None] Reloading compute RPC API17:31
efriedmriedem: how did you do it?17:32
mriedemkill -HUP <pid>17:32
efriedmriedem: based on the systemctl man page, it's possible you would have needed to say -s SIGHUP (not just HUP) and specify a --kill-who=main (or something?) to target the actual n-cpu process rather than its control process.17:34
efriedso yeah, kill -HUP <pid> sounds easier to me :P17:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add docs for compute capabilities as traits  https://review.openstack.org/64429317:35
openstackgerritMatthew Booth proposed openstack/nova master: Fix SSL infinite recursion  https://review.openstack.org/62695217:40
*** mvkr has quit IRC17:43
*** rpittau is now known as rpittau|afk17:43
*** itlinux has quit IRC17:50
*** itlinux has joined #openstack-nova17:54
*** gyee has joined #openstack-nova17:58
*** jmlowe has joined #openstack-nova18:02
*** luksky has quit IRC18:10
*** itlinux has quit IRC18:10
*** dustinc is now known as dustinc|lunch18:13
*** itlinux has joined #openstack-nova18:15
*** dtantsur is now known as dtantsur|afk18:23
*** eharney_ has joined #openstack-nova18:23
*** eharney has quit IRC18:25
*** breton has joined #openstack-nova18:26
*** breton has left #openstack-nova18:28
*** wolverineav has quit IRC18:31
*** BjoernT has joined #openstack-nova18:32
*** gmann is now known as gmann_afk18:34
*** tesseract has quit IRC18:34
*** itlinux has quit IRC18:34
*** bbobrov has joined #openstack-nova18:35
*** bbobrov has quit IRC18:35
*** bbobrov has joined #openstack-nova18:36
*** BjoernT_ has joined #openstack-nova18:36
*** BjoernT has quit IRC18:37
*** itlinux has joined #openstack-nova18:38
*** tbachman has joined #openstack-nova18:41
*** ivve has joined #openstack-nova18:45
*** tbachman has quit IRC18:45
*** mriedem has quit IRC18:45
*** mriedem has joined #openstack-nova18:48
*** wolverineav has joined #openstack-nova18:49
*** gmann_afk is now known as gmann18:56
*** BjoernT_ has quit IRC19:00
*** dpawlik has joined #openstack-nova19:05
melwittmriedem: new bug I tagged for stein-rc-potential https://bugs.launchpad.net/nova/+bug/182058819:06
openstackLaunchpad bug 1820588 in OpenStack Compute (nova) "Bandwidth resource is leaked if a bound port is deleted in neutron" [Low,Confirmed]19:06
*** BjoernT has joined #openstack-nova19:10
*** dpawlik has quit IRC19:10
*** BjoernT has quit IRC19:11
*** jmlowe has quit IRC19:13
*** BjoernT has joined #openstack-nova19:14
*** itlinux has quit IRC19:15
*** eharney_ has quit IRC19:20
aspiersmriedem, kashyap: Sorry, had to take a few days break due to RSI issues. (Cautiously) back now and trying to catch up19:22
*** igordc has joined #openstack-nova19:22
*** dustinc|lunch is now known as dustinc19:23
*** itlinux has joined #openstack-nova19:24
*** wolverineav has quit IRC19:25
openstackgerritEric Fried proposed openstack/nova master: WIP/PoC: Use openstacksdk for placement  https://review.openstack.org/64366419:36
openstackgerritEric Fried proposed openstack/nova master: WIP/PoC: Use SDK instead of ironicclient for node.get  https://review.openstack.org/64289919:36
*** imacdonn_ has joined #openstack-nova19:39
*** imacdonn_ is now known as imacdonn19:40
*** dpawlik has joined #openstack-nova19:40
*** wolverineav has joined #openstack-nova19:44
*** dpawlik has quit IRC19:45
*** wolverineav has quit IRC19:48
*** wolverineav has joined #openstack-nova19:48
*** itlinux has quit IRC19:53
openstackgerritEric Fried proposed openstack/nova master: qemu: Make disk image conversion dramatically faster  https://review.openstack.org/64078119:53
efriedkashyap: I added a colon to make that go ^19:54
efriedyou may (or may not) wish to rebase its successors.19:54
*** whoami-rajat has quit IRC19:55
*** itlinux has joined #openstack-nova19:57
*** cdent_ has joined #openstack-nova19:59
*** luksky has joined #openstack-nova20:01
*** cdent has quit IRC20:02
*** cdent_ is now known as cdent20:02
*** ralonsoh has quit IRC20:05
*** wolverineav has quit IRC20:09
*** wolverineav has joined #openstack-nova20:10
*** irclogbot_2 has joined #openstack-nova20:11
efriedmdbooth: I've only superficially been following along, but when you rip out eventlet monkey-patching, some deepcopyZ will start to fail on lock artifacts.20:12
efriedmdbooth: Not sure the best solution for this; the naïf one is to implement __deepcopy__ on the thing holding the lock to create a new one (which is what the monkey-patched version did).20:13
*** dpawlik has joined #openstack-nova20:14
*** dklyle has quit IRC20:14
*** wolverineav has quit IRC20:16
*** BjoernT has quit IRC20:16
*** wolverineav has joined #openstack-nova20:16
*** wolverineav has quit IRC20:16
*** wolverineav has joined #openstack-nova20:16
*** dklyle has joined #openstack-nova20:18
*** dpawlik has quit IRC20:18
*** jmlowe has joined #openstack-nova20:20
*** eharney_ has joined #openstack-nova20:21
*** irclogbot_2 has quit IRC20:25
*** irclogbot_2 has joined #openstack-nova20:26
openstackgerritmelanie witt proposed openstack/nova master: WIP Add a prelude release note for the 19.0.0 Stein GA  https://review.openstack.org/64441220:28
*** mikal has joined #openstack-nova20:36
openstackgerritMerged openstack/nova master: Remove obsolete policy configuration details from docs  https://review.openstack.org/64394920:38
*** BjoernT has joined #openstack-nova20:40
mnaserhi everyone -- is there anyone doing any work on policy/scopes at the moment?20:41
*** dave-mccowan has joined #openstack-nova20:43
melwittmnaser: not that I know of, but I was thinking of trying to get some stuff going next cycle for scope types. I proposed a forum session which might get combined with a keystone proposed session of similar topic20:44
mnasermelwitt: cool, ill tag along for that perhaps20:44
*** igordc has quit IRC20:49
*** awaugama has quit IRC20:50
*** dpawlik has joined #openstack-nova20:51
*** pcaruana has quit IRC20:54
*** igordc has joined #openstack-nova20:54
*** mchlumsky has quit IRC20:55
*** dpawlik has quit IRC20:55
*** wwriverrat has joined #openstack-nova20:56
openstackgerritMerged openstack/python-novaclient master: Update master for stable/stein  https://review.openstack.org/64418320:58
*** itlinux has quit IRC21:01
*** irclogbot_2 has quit IRC21:05
*** irclogbot_2 has joined #openstack-nova21:06
openstackgerritLance Bragstad proposed openstack/nova master: Clarify policy shortcomings in policy enforcement doc  https://review.openstack.org/64396021:12
openstackgerritLance Bragstad proposed openstack/nova master: Remove additional policy configuration details from policy doc  https://review.openstack.org/64442321:12
*** priteau has quit IRC21:12
*** itlinux has joined #openstack-nova21:13
*** itlinux has quit IRC21:17
*** xek has quit IRC21:17
*** mgoddard has quit IRC21:20
*** itlinux has joined #openstack-nova21:25
*** mgoddard has joined #openstack-nova21:26
*** irclogbot_2 has quit IRC21:26
*** irclogbot_2 has joined #openstack-nova21:27
*** cdent has quit IRC21:28
*** BjoernT has quit IRC21:30
*** wwriverrat has left #openstack-nova21:32
*** itlinux has quit IRC21:43
*** itlinux has joined #openstack-nova21:44
*** mvkr has joined #openstack-nova21:47
*** itlinux has quit IRC21:51
*** dpawlik has joined #openstack-nova22:05
*** itlinux has joined #openstack-nova22:09
*** dpawlik has quit IRC22:10
*** mlavalle has quit IRC22:13
*** mlavalle has joined #openstack-nova22:16
*** marst has quit IRC22:17
*** itlinux has quit IRC22:20
*** mlavalle has quit IRC22:30
*** igordc has quit IRC22:36
*** igordc has joined #openstack-nova22:40
*** tkajinam has joined #openstack-nova22:54
*** wolverineav has quit IRC22:57
*** wolverineav has joined #openstack-nova22:57
*** elod has quit IRC23:01
*** wolverineav has quit IRC23:03
*** rcernin has joined #openstack-nova23:04
*** ivve has quit IRC23:09
mriedemlbragstad: typo here? https://review.openstack.org/#/c/644423/23:13
*** hongbin has quit IRC23:19
*** mriedem has quit IRC23:20
*** NostawRm has quit IRC23:36
*** tosky has quit IRC23:48
openstackgerritLance Bragstad proposed openstack/nova master: Remove additional policy configuration details from policy doc  https://review.openstack.org/64442323:49
openstackgerritLance Bragstad proposed openstack/nova master: Clarify policy shortcomings in policy enforcement doc  https://review.openstack.org/64396023:50
*** wolverineav has joined #openstack-nova23:54
*** wolverineav has quit IRC23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!