*** BjoernT has quit IRC | 00:01 | |
*** wolverineav has quit IRC | 00:08 | |
*** wolverineav has joined #openstack-nova | 00:08 | |
*** wolverineav has quit IRC | 00:13 | |
*** BjoernT has joined #openstack-nova | 00:16 | |
*** markvoelker has joined #openstack-nova | 00:17 | |
*** hamzy has joined #openstack-nova | 00:19 | |
*** markvoelker has quit IRC | 00:21 | |
*** BjoernT_ has joined #openstack-nova | 00:21 | |
*** BjoernT has quit IRC | 00:21 | |
*** BjoernT_ has quit IRC | 00:38 | |
*** igordc has quit IRC | 00:42 | |
*** diablo_rojo has quit IRC | 00:48 | |
*** markvoelker has joined #openstack-nova | 00:48 | |
*** BjoernT has joined #openstack-nova | 00:48 | |
*** marst has joined #openstack-nova | 00:49 | |
*** lbragstad has quit IRC | 00:49 | |
*** slaweq has joined #openstack-nova | 00:56 | |
*** ileixe has joined #openstack-nova | 00:56 | |
*** gyee has quit IRC | 00:57 | |
*** slaweq has quit IRC | 01:00 | |
*** tetsuro has joined #openstack-nova | 01:01 | |
*** cdent has quit IRC | 01:01 | |
*** awalende has joined #openstack-nova | 01:12 | |
*** mriedem_away has quit IRC | 01:15 | |
*** awalende has quit IRC | 01:17 | |
*** tetsuro has quit IRC | 01:20 | |
*** marst has quit IRC | 01:28 | |
*** whoami-rajat has joined #openstack-nova | 01:29 | |
*** markvoelker has quit IRC | 01:49 | |
*** zhubx has quit IRC | 01:53 | |
*** zhubx has joined #openstack-nova | 01:55 | |
eandersson | What is the difference between disk_available_least and disk_free_gb ? | 01:55 |
---|---|---|
*** cfriesen has quit IRC | 02:11 | |
openstackgerrit | Yongli He proposed openstack/nova master: Clean up orphan instances https://review.openstack.org/627765 | 02:23 |
eandersson | It looks like maybe disk_available_least takes into account the qcow images on the host? | 02:26 |
eandersson | because the host has 79GB available, the flavor uses 74GB, but the scheduler thinks its out of disk space so refuses to schedule there | 02:28 |
eandersson | but if we schedule there manually using --availability-zone nova:<compute-name> | 02:28 |
eandersson | it works | 02:28 |
eandersson | and it now has ~4GB disk free according to the nova.compute logs | 02:29 |
eandersson | > does not have 76800 MB usable disk, it only has 44031.0 MB | 02:30 |
eandersson | So confusing that the disk space used to schedule isn't reported anywhere, or at the very least not the number the scheduler uses to make decisions upon isn't reported. | 02:31 |
*** tiendc has joined #openstack-nova | 02:34 | |
*** tiendc has quit IRC | 02:35 | |
*** tiendc has joined #openstack-nova | 02:35 | |
eandersson | After scheduling manually I can see that disk_available_least is -33 | 02:40 |
eandersson | but free_disk_gb is at 4 | 02:41 |
*** psachin has joined #openstack-nova | 02:57 | |
*** itlinux has joined #openstack-nova | 03:04 | |
*** ileixe has quit IRC | 03:20 | |
*** ileixe has joined #openstack-nova | 03:23 | |
*** alex_xu has joined #openstack-nova | 03:30 | |
*** sridharg has joined #openstack-nova | 03:32 | |
*** dave-mccowan has quit IRC | 03:39 | |
*** nicolasbock has quit IRC | 03:45 | |
*** wolverineav has joined #openstack-nova | 03:47 | |
*** tkajinam has quit IRC | 03:54 | |
openstackgerrit | Merged openstack/nova master: Remove "Fixing the Scheduler DB model" from schedule evolution doc https://review.openstack.org/643615 | 03:56 |
*** zhubx has quit IRC | 03:56 | |
*** zhubx has joined #openstack-nova | 03:56 | |
*** tkajinam has joined #openstack-nova | 03:57 | |
*** ratailor has joined #openstack-nova | 03:59 | |
*** udesale has joined #openstack-nova | 04:00 | |
*** wolverineav has quit IRC | 04:11 | |
*** ileixe has quit IRC | 04:32 | |
*** psachin has quit IRC | 04:34 | |
*** psachin has joined #openstack-nova | 04:42 | |
*** itlinux has quit IRC | 04:45 | |
*** janki has joined #openstack-nova | 04:47 | |
eandersson | maybe jaypipes ? ^ | 04:55 |
*** BjoernT has quit IRC | 05:00 | |
*** BjoernT_ has joined #openstack-nova | 05:00 | |
*** ileixe has joined #openstack-nova | 05:04 | |
openstackgerrit | Merged openstack/nova master: Add docs for compute capabilities as traits https://review.openstack.org/644293 | 05:09 |
*** wolverineav has joined #openstack-nova | 05:15 | |
openstackgerrit | Yongli He proposed openstack/nova master: Clean up orphan instances https://review.openstack.org/627765 | 05:17 |
*** wolverineav has quit IRC | 05:18 | |
*** sapd1_x has joined #openstack-nova | 05:21 | |
*** BjoernT_ has quit IRC | 05:21 | |
*** markvoelker has joined #openstack-nova | 05:22 | |
*** tiendc has quit IRC | 05:26 | |
*** markvoelker has quit IRC | 05:26 | |
*** ivve has quit IRC | 05:28 | |
*** BjoernT has joined #openstack-nova | 05:49 | |
*** janki has quit IRC | 05:50 | |
*** markvoelker has joined #openstack-nova | 05:53 | |
*** sapd1_x has quit IRC | 05:56 | |
*** janki has joined #openstack-nova | 05:57 | |
*** wolverineav has joined #openstack-nova | 06:09 | |
*** wolverineav has quit IRC | 06:13 | |
*** BjoernT has quit IRC | 06:17 | |
*** sajauddin has joined #openstack-nova | 06:23 | |
*** ivve has joined #openstack-nova | 06:30 | |
*** jaosorior has joined #openstack-nova | 06:33 | |
*** Luzi has joined #openstack-nova | 06:45 | |
*** phasespace has quit IRC | 06:55 | |
*** ivve has quit IRC | 07:07 | |
openstackgerrit | Seyeong Kim proposed openstack/nova stable/rocky: Share snapshot image membership with instance owner https://review.openstack.org/643853 | 07:15 |
*** pcaruana has joined #openstack-nova | 07:20 | |
*** ivve has joined #openstack-nova | 07:22 | |
*** tosky has joined #openstack-nova | 07:29 | |
*** rchurch has joined #openstack-nova | 07:40 | |
*** phasespace has joined #openstack-nova | 07:45 | |
*** xek_ has joined #openstack-nova | 07:49 | |
*** dpawlik_ is now known as dpawlik | 07:51 | |
*** slaweq has joined #openstack-nova | 07:55 | |
*** alex_xu has quit IRC | 08:04 | |
*** ttsiouts has joined #openstack-nova | 08:05 | |
*** tesseract has joined #openstack-nova | 08:07 | |
*** awalende has joined #openstack-nova | 08:11 | |
*** ccamacho has joined #openstack-nova | 08:11 | |
*** luksky has joined #openstack-nova | 08:13 | |
*** helenafm has joined #openstack-nova | 08:18 | |
*** ttsiouts has quit IRC | 08:26 | |
*** rpittau|afk is now known as rpittau | 08:27 | |
*** ttsiouts has joined #openstack-nova | 08:34 | |
*** tkajinam has quit IRC | 08:35 | |
*** rcernin has quit IRC | 08:38 | |
*** ttsiouts has quit IRC | 08:52 | |
*** ttsiouts has joined #openstack-nova | 08:54 | |
*** ralonsoh has joined #openstack-nova | 08:58 | |
*** Luzi has quit IRC | 08:59 | |
*** sridharg has quit IRC | 09:01 | |
openstackgerrit | Michael Still proposed openstack/nova master: Complete remove fake_libvirt_utils. https://review.openstack.org/643897 | 09:02 |
openstackgerrit | Michael Still proposed openstack/nova master: Remove fake_libvirt_utils users in functional testing. https://review.openstack.org/644793 | 09:02 |
*** sridharg has joined #openstack-nova | 09:09 | |
*** tstrul has joined #openstack-nova | 09:11 | |
*** dtantsur|afk is now known as dtantsur | 09:21 | |
*** SASAA has joined #openstack-nova | 09:23 | |
*** derekh has joined #openstack-nova | 09:25 | |
*** IvensZambrano has joined #openstack-nova | 09:25 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add known issue for minimum bandwidth resource leak https://review.openstack.org/644694 | 09:28 |
*** jaosorior has quit IRC | 09:36 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Misc cleanups https://review.openstack.org/644616 | 09:42 |
*** psachin has quit IRC | 09:48 | |
mdbooth | stephenfin: Hey, so it turns out sphinx also imports nova/api/openstack/__init__.py | 10:08 |
mdbooth | stephenfin: My patch is adding monkey patching there, so sphinx is still borked | 10:09 |
mdbooth | stephenfin: I moved monkey patching there for the wsgi entry point because I don't think it can be anywhere else, so I'm a bit stumped. | 10:10 |
stephenfin | mdbooth: Tried using the mock setting I was on about? | 10:10 |
mdbooth | stephenfin: In sphinx? | 10:10 |
stephenfin | aye | 10:11 |
mdbooth | Is that a valid thing to do? | 10:11 |
mdbooth | I didn't understand what it did, tbh. | 10:11 |
stephenfin | http://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#confval-autodoc_mock_imports | 10:11 |
mdbooth | Oh, so autodoc_mock_imports = ["nova.monkey_patch"] ? | 10:12 |
stephenfin | tbh, I'm not sure how it works under the hood either. You could try mocking the 'eventlet' module though and see what happens | 10:12 |
stephenfin | Or that, yeah | 10:12 |
mdbooth | Where does the sphinx config live again? | 10:12 |
stephenfin | If that doesn't help, we're going to have to rip out the stuff that imports code and figure out which one is causing the issue | 10:13 |
stephenfin | Those modules being 'oslo_config.sphinxext', 'oslo_policy.sphinxext' and 'sphinx.ext.apidoc' | 10:13 |
sean-k-mooney | mdbooth: i think in docs/sources/conf.py | 10:13 |
stephenfin | mdbooth: doc/source/conf.py | 10:13 |
sean-k-mooney | i was so close :) | 10:13 |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Update Network Bandwidth resource provider spec https://review.openstack.org/644810 | 10:14 |
*** luksky has quit IRC | 10:17 | |
mdbooth | stephenfin: autodoc_mock_imports = ["nova.monkey_patch"] does not appear to mock nova.monkey_patch | 10:19 |
sean-k-mooney | mdbooth: whatabout autodoc_mock_imports = ["eventlet"] ? | 10:20 |
mdbooth | Just trying, but I am disappoint | 10:20 |
stephenfin | mdbooth: Hmm, out of curiosity, doesn't this mean that simply importing 'nova' will trigger the monkey patching so, regardless of whether it's Sphinx importing it or something else? | 10:21 |
mdbooth | That also appears not to be mocked. | 10:22 |
mdbooth | stephenfin: Well *anything* importing one of these classes will apply monkey patching | 10:22 |
mdbooth | But this has always been true | 10:22 |
mdbooth | In this specific instance, I've moved the wsgi entry point, though | 10:22 |
stephenfin | and what's changed? | 10:23 |
sean-k-mooney | stephenfin: the classes that triggered the auto monkey patching in the past did not contain any reuable busines loginc | 10:23 |
mdbooth | It used to be in nova/api/openstack/wsgi_app.py, it's now in nova/api/openstack/__init__.py | 10:23 |
mdbooth | However, it has *always* been in nova/cmd/__init__.py | 10:23 |
sean-k-mooney | ya | 10:23 |
sean-k-mooney | nova/cmd/__init__.py was done so that when we use setup tools to generate the console scipts | 10:24 |
mdbooth | sean-k-mooney: The reusable aspect of my patch is a side effect | 10:24 |
sean-k-mooney | the import of the commands monkey patched it automatically | 10:24 |
mdbooth | Primarily it *fixes* the non-wsgi and wsgi imports to do monkey patching before importing anything else | 10:24 |
mdbooth | It's a bugfix, not a cleanup | 10:24 |
sean-k-mooney | mdbooth: yes | 10:24 |
sean-k-mooney | but the point i was try to make was | 10:25 |
*** psachin has joined #openstack-nova | 10:25 | |
* mdbooth isn't on a holy mission of tidiness here | 10:25 | |
sean-k-mooney | if you wrote a tool that just imported our config definiton | 10:25 |
sean-k-mooney | say to do a config migration or to generate the files | 10:25 |
sean-k-mooney | then before it would not monkey patch your tool | 10:25 |
sean-k-mooney | depending on where you put the call that may or may not change | 10:26 |
*** baclawski has joined #openstack-nova | 10:26 | |
mdbooth | stephenfin: How would you feel if I set an environment variable in sphinx tox.ini which nova.monkey_patch used to skip monkey patching? | 10:26 |
mdbooth | Or conf.py | 10:26 |
*** cdent has joined #openstack-nova | 10:27 | |
stephenfin | mdbooth: I'm all for it | 10:27 |
stephenfin | With a giant NOTE explaining why we do this craziness | 10:29 |
mdbooth | stephenfin: Heh, of course | 10:29 |
mdbooth | stephenfin: nova.monkey_patch is itself now a giant NOTE | 10:29 |
sean-k-mooney | stephenfin: im hoping in train we can remove the need to monkey patch the wsgi api code. | 10:30 |
stephenfin | U, you mean? | 10:30 |
sean-k-mooney | no in trian | 10:30 |
stephenfin | Oh, sorry, just the WSGI piece | 10:30 |
sean-k-mooney | it was a regression in the multi cell list feither | 10:30 |
mdbooth | Indeed | 10:30 |
sean-k-mooney | *feature | 10:30 |
sean-k-mooney | ya just the wsgi piece | 10:31 |
mdbooth | Although, tbh it's flaky as hell and we need to remove the whole thing. | 10:31 |
sean-k-mooney | doing it in general is proably not worth it but eventlets and wsgi are not partcally happy bedfellows | 10:31 |
mdbooth | Our entry points are not sufficiently well defined to do this. Specifically, monkey patching on import is a bad idea, but our entry points leave us with no other choice. | 10:32 |
sean-k-mooney | mdbooth: ya that proably a U thing but futuriest actully has eveything i waned by asyncio form python3 | 10:32 |
sean-k-mooney | mdbooth: ya | 10:32 |
sean-k-mooney | fortunetly or not depending on your perspective we dont alter those entry points frequently so the sting and ductape we have been using in the past has been enough | 10:33 |
*** tstrul has quit IRC | 10:34 | |
*** jaosorior has joined #openstack-nova | 10:35 | |
*** wolverineav has joined #openstack-nova | 10:41 | |
*** wolverineav has quit IRC | 10:46 | |
*** nicolasbock has joined #openstack-nova | 10:46 | |
*** dave-mccowan has joined #openstack-nova | 10:56 | |
aspiers | is it just me or is tempest-full-py broken? "The error was: 'gabbi_tempest_path' is undefined\n\nThe error appears to have been in '/var/lib/zuul/builds/42292da2453549e68ae6c1e63bfca00b/untrusted/project_5/git.openstack.org/openstack/tempest/roles/setup-tempest-run-dir/tasks/main.yaml'" | 10:59 |
cdent | blargh, that sounds like it is at least partially my fault | 11:00 |
cdent | (because of gabbi in the name) but I haven't changed anything recently | 11:00 |
aspiers | cdent: failure is in https://review.openstack.org/#/c/644554/ | 11:00 |
cdent | thanks | 11:00 |
* cdent goes to read the tempest git logs | 11:01 | |
cdent | aspiers: looks like it has already been fixed | 11:03 |
aspiers | oh nice | 11:03 |
* aspiers rechecks | 11:03 | |
cdent | https://review.openstack.org/#/c/644699/ | 11:03 |
cdent | hmm, actually I think that may have broken it | 11:04 |
* cdent digs more | 11:04 | |
aspiers | haha | 11:04 |
* aspiers waits | 11:04 | |
*** luksky has joined #openstack-nova | 11:06 | |
cdent | aspiers: it is a fix, the reason it wasn't happening before is because it didn't tickle a problem until ansible 2.7 was the default | 11:06 |
aspiers | ah ok | 11:06 |
aspiers | thanks! | 11:06 |
aspiers | is it just me or does the browser not cache these horrendously long job-output.txt.gz files? | 11:06 |
cdent | I think it does not | 11:07 |
aspiers | I see my Chrome sending Cache-Control: no-cache with the request - wtf? | 11:07 |
*** sapd1_x has joined #openstack-nova | 11:07 | |
aspiers | Why would it do that? | 11:07 |
cdent | I think it is because the server is not sending good headers | 11:08 |
cdent | there's no last-modified or other cache-related header in the headers of the response | 11:08 |
aspiers | I see Cache-Control in the response | 11:08 |
aspiers | but surely it's the Apache index page which should control how the client sends a request for the actual file | 11:09 |
aspiers | http://logs.openstack.org/54/644554/2/check/tempest-full-py3/42292da/ <- this one | 11:09 |
sean-k-mooney | aspiers: do you have the developer console open | 11:09 |
aspiers | sean-k-mooney: ohhhh, good point | 11:09 |
cdent | if I do a raw curl of the log file you linked to above and the headers are very limited | 11:09 |
sean-k-mooney | aspiers: there is a tick box to disable cache | 11:09 |
aspiers | sean-k-mooney: thanks for the reminder! | 11:09 |
aspiers | ok so unticking "Disable cache" gets rid of no-cache headers, but it's still re-downloading the full file each time | 11:12 |
cdent | because of what I said: the server isn't providing enough info to allow useful caching | 11:12 |
*** sajauddin has quit IRC | 11:13 | |
aspiers | so it's missing an Expires: header? | 11:13 |
aspiers | or Last-Modified | 11:13 |
aspiers | or Date | 11:13 |
cdent | or a last-modified, or a cache-control, or an etag or lots of thing | 11:13 |
cdent | Date is the server date, not the date of the content | 11:13 |
mdbooth | cdent stephenfin: Docs loads oslo policies from nova.api.openstack.placement.policies because it's defined in setup.cfg and I guess it's not unreasonable to document those things. Problem is I moved the monkey patching point to nova/api/openstack/__init__.py, so now that pulls in monkey patching. | 11:13 |
* mdbooth blames placement ;) | 11:13 | |
cdent | yeah, fine, I tried to delete that code ! :) | 11:14 |
sean-k-mooney | aspiers: that just an issue with the apache config for the instance thats is fronting logs.openstack.org | 11:14 |
mdbooth | cdent: Yeah, if you could move that out of the way... | 11:14 |
aspiers | sean-k-mooney: yeah, I'm gonna ask infra about that | 11:14 |
aspiers | https://httpd.apache.org/docs/2.4/caching.html | 11:14 |
sean-k-mooney | well in generaly what is the point of allowing cdns to cache logs.openstack.org | 11:14 |
sean-k-mooney | the browser sure but i dont hink we can do one without the other | 11:15 |
sean-k-mooney | maybe we can | 11:15 |
cdent | mdbooth: i'll do it on saturday, with a tps repoert | 11:15 |
sean-k-mooney | aspiers: actully its proably fine to cache it so if they want to update it it proably wont have any negitive impact | 11:16 |
*** janki has quit IRC | 11:16 | |
aspiers | right, because the paths are unique | 11:16 |
sean-k-mooney | most logs on logs.openstack.org never get read anyway | 11:16 |
cdent | they could relatively easily have a last-modified header | 11:16 |
*** janki has joined #openstack-nova | 11:16 | |
cdent | which would at least allow a conditional get | 11:16 |
* mdbooth shakes his fist at python, and eventlet, and then python again | 11:16 | |
* aspiers takes this discussion to -infra | 11:17 | |
sean-k-mooney | yep each run is a new file even for the same patch so you will never get cached old data where the content on the server has changed | 11:17 |
*** ileixe has quit IRC | 11:20 | |
kashyap | mdbooth: Want to give your final ACK/NACK on this: https://review.openstack.org/#/c/641981/ | 11:20 |
*** ttsiouts has quit IRC | 11:21 | |
mdbooth | kashyap: "This improves performance without compromising data integrity". You could stick that in a politician's stump speech alongside mom and apple pie. | 11:22 |
*** Zara has joined #openstack-nova | 11:22 | |
kashyap | LOL | 11:22 |
kashyap | mdbooth: If you prefer a different phrasing, I'm open to critique | 11:23 |
mdbooth | kashyap: Absolutely not. It's straight to the point. | 11:23 |
kashyap | aspiers: (Thanks for your remark on that trade-off of: readability vs. indirection. I've bookmarked the talk :-)) | 11:23 |
kashyap | mdbooth: Okay, I get lunch then. Thanks for looking! Appreciate your time. | 11:23 |
kashyap | aspiers: (I'm largely with you on it, as I was also feeling uneasy that method becoming longer and longer.) | 11:24 |
aspiers | kashyap: :) | 11:24 |
*** ccamacho has quit IRC | 11:24 | |
*** ccamacho has joined #openstack-nova | 11:26 | |
*** rcernin has joined #openstack-nova | 11:27 | |
*** udesale has quit IRC | 11:28 | |
*** udesale has joined #openstack-nova | 11:29 | |
*** lpetrut has joined #openstack-nova | 11:29 | |
*** ttsiouts has joined #openstack-nova | 11:37 | |
*** pcaruana has quit IRC | 11:38 | |
*** ttsiouts has quit IRC | 11:42 | |
*** ratailor has quit IRC | 11:44 | |
*** tssurya has joined #openstack-nova | 11:47 | |
*** dave-mccowan has quit IRC | 11:51 | |
openstackgerrit | Merged openstack/os-resource-classes master: Update master for stable/stein https://review.openstack.org/644030 | 12:02 |
*** ttsiouts has joined #openstack-nova | 12:04 | |
openstackgerrit | Merged openstack/os-traits master: Update master for stable/stein https://review.openstack.org/644033 | 12:05 |
*** psachin has quit IRC | 12:11 | |
*** markvoelker has quit IRC | 12:13 | |
*** sapd1_x has quit IRC | 12:15 | |
*** pcaruana has joined #openstack-nova | 12:16 | |
*** psachin has joined #openstack-nova | 12:19 | |
openstackgerrit | Merged openstack/os-resource-classes stable/stein: Update .gitreview for stable/stein https://review.openstack.org/644028 | 12:29 |
openstackgerrit | Merged openstack/os-traits stable/stein: Update .gitreview for stable/stein https://review.openstack.org/644031 | 12:30 |
openstackgerrit | Merged openstack/os-resource-classes stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/644029 | 12:30 |
openstackgerrit | Merged openstack/os-traits stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/644032 | 12:36 |
*** tbachman has quit IRC | 12:40 | |
*** eharney has joined #openstack-nova | 12:42 | |
kashyap | mdbooth: You are right. That whole documentation mess needs fixing. I'll hold my nose and get that going. | 12:46 |
kashyap | mdbooth: And on that fated IBM article from the past ... look, I apparently "debunked" it as far as 2014: https://www.redhat.com/archives/libvirt-users/2014-August/msg00060.html ("Behavior of disk caching with qcow2 disks") | 12:46 |
*** tesseract has quit IRC | 12:47 | |
*** tesseract-rh has joined #openstack-nova | 12:47 | |
*** sapd1_x has joined #openstack-nova | 12:55 | |
*** jaosorior has quit IRC | 12:56 | |
*** jmlowe has quit IRC | 12:58 | |
*** artom has joined #openstack-nova | 12:58 | |
*** artom has quit IRC | 13:01 | |
*** artom has joined #openstack-nova | 13:01 | |
*** yaawang has quit IRC | 13:02 | |
*** yaawang has joined #openstack-nova | 13:07 | |
*** lbragstad has joined #openstack-nova | 13:07 | |
*** marst has joined #openstack-nova | 13:09 | |
*** mchlumsky has joined #openstack-nova | 13:13 | |
*** rcernin has quit IRC | 13:16 | |
*** mriedem has joined #openstack-nova | 13:17 | |
*** jaosorior has joined #openstack-nova | 13:21 | |
openstackgerrit | Merged openstack/nova master: Move slight bonkers IP management to privsep. https://review.openstack.org/624592 | 13:21 |
*** ccamacho has quit IRC | 13:23 | |
*** ccamacho has joined #openstack-nova | 13:23 | |
bauzas | efried: FWIW, I'd have loved to have time for reviewing https://review.openstack.org/#/c/644412/ but fortunately, it's not merged yet | 13:25 |
*** ccamacho has quit IRC | 13:28 | |
*** ccamacho has joined #openstack-nova | 13:28 | |
efried | bauzas: I knew it was going to hang on in the queue for a while, but we're also a bit tight for time so I didn't want it not to merge because we forgot to +W it. | 13:29 |
efried | I didn't mean to cut anyone out, sorry. | 13:29 |
bauzas | no worries | 13:29 |
bauzas | just for the next release, we open the prelude change 2 days before and we leave it there at least some time | 13:30 |
*** psachin has quit IRC | 13:30 | |
efried | noted, thank you. | 13:30 |
*** alex_xu has joined #openstack-nova | 13:32 | |
*** sapd1_x has quit IRC | 13:35 | |
aspiers | kashyap: https://review.openstack.org/#/c/644554/ is ready for review | 13:39 |
aspiers | efried: anyone else I should add to review for that? ^^ | 13:39 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Eventlet monkey patching should be as early as possible https://review.openstack.org/626952 | 13:39 |
* kashyap clicks | 13:39 | |
*** shilpasd has joined #openstack-nova | 13:40 | |
mdbooth | It's going to be revised in a second ;) | 13:43 |
*** marst has quit IRC | 13:43 | |
mdbooth | Line length violations after I indented everything and forgot to rerun pep8 | 13:43 |
efried | aspiers: Dunno. Maybe bauzas would like to look :) | 13:45 |
bauzas | I can | 13:45 |
efried | thanks bauzas. Should be an easy one, just a refactor (and an extra log) | 13:45 |
aspiers | and extra tests!! \o/ | 13:46 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Eventlet monkey patching should be as early as possible https://review.openstack.org/626952 | 13:46 |
mdbooth | Ok, ^^^ is the one. Really. | 13:46 |
mdbooth | stephenfin: How do you feel about the sphinx bodge in ^^^ ? | 13:46 |
*** BjoernT has joined #openstack-nova | 13:47 | |
stephenfin | mdbooth: It's necessarily awful | 13:47 |
mdbooth | stephenfin: Why thank you | 13:47 |
stephenfin | :) | 13:47 |
kashyap | aspiers: Looks good to me. | 13:47 |
*** BjoernT has quit IRC | 13:48 | |
aspiers | kashyap: thanks | 13:48 |
*** tbachman has joined #openstack-nova | 13:48 | |
*** tbachman has quit IRC | 13:48 | |
*** helenafm has quit IRC | 13:48 | |
mdbooth | If there's any other way which doesn't involve moving entry points, and therefore impacting deployment tooling, I'd do that instead. | 13:48 |
mdbooth | It's kinda icky, but it's the best I can think of. | 13:49 |
stephenfin | mdbooth: It'll do for 6 months, I imagine | 13:50 |
stephenfin | at which point we should be aiming to rip that all out | 13:50 |
* efried googles "bodge" | 13:51 | |
mdbooth | stephenfin: Yarp. | 13:51 |
efried | that's a new one on me, thanks mdbooth | 13:51 |
mdbooth | efried: dirty hack that works | 13:51 |
mdbooth | efried: Code I'm not proud of | 13:51 |
sean-k-mooney | mdbooth: is the bodge hardcoding OS_NOVA_DISABLE_EVENTLET_PATCHING in the conf.py | 13:51 |
mdbooth | sean-k-mooney: Both that, and requiring it at all | 13:52 |
*** sapd1_x has joined #openstack-nova | 13:52 | |
*** jonher has quit IRC | 13:54 | |
mdbooth | Wait, I think I just did think of a better way | 13:55 |
sean-k-mooney | i was going to leave a review comment but honestly my tastae for anyting in this patch can be adressed in train. assuming this works and the gate is happy i think this is good enough for stien | 13:55 |
*** BjoernT has joined #openstack-nova | 13:55 | |
efried | mriedem: Care to re-wordsmith https://review.openstack.org/#/c/644412/4/releasenotes/notes/stein-prelude-b5fe92310e1e725e.yaml@57 ? Or I can take a stab at it, but you know the reward for good work... | 13:55 |
mdbooth | Ok, there's another version coming which eliminates that. | 13:55 |
sean-k-mooney | condtionally setining it if not set instead of hardcoding | 13:55 |
sean-k-mooney | e.g. by usign the defualt valude on the get call | 13:56 |
mdbooth | We originally did: from nova import utils; utils.monkey_patch() | 13:56 |
mdbooth | Oh, wait. I got excited too early. | 13:56 |
mdbooth | It doesn't work. | 13:56 |
sean-k-mooney | well provied v11 which is currently up works that is proably good enough for now | 13:57 |
*** awaugama has joined #openstack-nova | 13:57 | |
mdbooth | I was thinking that explicitly executing monkey_patch() from the importing module bought us something, but of course it doesn't because it's still executed at import time. | 13:57 |
mdbooth | ...which is why I removed that in the first place. | 13:57 |
*** IvensZambrano has quit IRC | 13:57 | |
sean-k-mooney | ah ya | 13:58 |
*** marst has joined #openstack-nova | 13:58 | |
*** mlavalle has joined #openstack-nova | 14:01 | |
mriedem | efried: replied | 14:02 |
mriedem | tl;dr i don't think it's worth re-writing | 14:02 |
*** jonher has joined #openstack-nova | 14:02 | |
*** eharney has quit IRC | 14:03 | |
*** Luzi has joined #openstack-nova | 14:03 | |
efried | mriedem: I seem to be having a hard time conveying what I think the reader is going to care about here. And maybe it's because they really won't care about it. | 14:07 |
efried | mriedem: The release notes are about more than the upgrade process itself, aren't they? | 14:08 |
mriedem | yeah, major new features and such | 14:08 |
mriedem | and highlighting major upgrade impacts, | 14:08 |
efried | I mean, | 14:08 |
efried | I guess if you're going to go switch on the QoS feature, you'll read the docs for that and... not be surprised when multiple providers appear. | 14:09 |
mriedem | sure, but those already using vgpu + libvirt might never enable qos | 14:09 |
mriedem | so i'd rather not conflate the features | 14:09 |
*** ttsiouts has quit IRC | 14:10 | |
*** ttsiouts has joined #openstack-nova | 14:10 | |
cdent | efried: do people poke placement? is that a thing? | 14:10 |
efried | right, so I was focusing not on the specific features and more on the structural change they have in common. A structural change that operators may notice | 14:11 |
efried | cdent: Based on conversations overheard with vexxhost and cern folks, it seems like they do. | 14:11 |
cdent | dunno about vexxhost but my experience with cern it is with regard to what the service is doing, not the count of resource providers | 14:12 |
efried | ...and precisely because the features otherwise seem unrelated, this prelude would be a good place to write about the thing that ties them together. | 14:12 |
mriedem | cdent: they do when shit goes wrong and they are trying to debug | 14:12 |
mriedem | so how about, | 14:12 |
efried | yeah, so when they do that and oh crap there's suddenly two or more providers for my host, that must be wrong, freak out | 14:12 |
cdent | yes, and all of that has little to with reading a release notes prelude, I would have thought. that's what I'm trying to understand | 14:12 |
efried | if they read the prelude, ever, they might remember in the back of their head that this might possibly be a normal thing, and dig further before pushing the red button. | 14:13 |
cdent | if you can grep for 'resource provider' anywhere in the release notes then that's enough | 14:13 |
cdent | yeah, the "ever" is key, and why I think it is to "go back to release notes after something weird happened" | 14:13 |
cdent | "and grep" | 14:13 |
efried | mm | 14:14 |
mriedem | "Nova now supports nested resource providers in two cases: 1. QoS-enabled ports will have resource allocates created on a nested resource provider from the start. 2. Libvirt compute nodes reporting VGPU inventory will have that VGPU inventory and corresponding allocations moved to a child resource provider on restart of the nova-compute service after upgrading to Stein. - In both cases this means when looking at resource prov | 14:14 |
mriedem | s, depending on scenario, you can see more than one provider where there was initially just a root compute node provider per compute service." | 14:14 |
mriedem | efried: how is that ^? | 14:14 |
efried | mriedem: love it | 14:14 |
efried | s/allocates/allocated/ | 14:14 |
efried | allocations | 14:14 |
efried | sed fail | 14:15 |
*** ttsiouts has quit IRC | 14:15 | |
mriedem | like cdent said, if the release notes for the changes themselves were clear in the reno we likely wouldn't need the big prelude, but o-) | 14:15 |
mriedem | ideally, the vgpu reno would have a before and after osc output | 14:16 |
mriedem | showing the VCPU/MEMORY_MB/DISK_GB inventory on the root provider and the VGPU inventory on the child provider after the reshape | 14:16 |
mriedem | or, | 14:16 |
mriedem | we can still build that into the docs | 14:16 |
mriedem | i.e. "if things are working properly, you can expect to see something like this" | 14:16 |
mriedem | somewhere in here https://docs.openstack.org/nova/latest/admin/virtual-gpu.html | 14:17 |
*** cfriesen has joined #openstack-nova | 14:17 | |
mriedem | personally i don't love putting a ton of detail in release notes anyway - details should be in docs since those are indexed and don't get lost in the sands of time, and then renos can just link to said docs | 14:17 |
mriedem | people FFU past the release notes anyway | 14:18 |
mriedem | hell https://docs.openstack.org/nova/latest/admin/virtual-gpu.html should probably already say something about nested provider trees starting in stein | 14:18 |
efried | mriedem: Right, like I said before, the notes for the changes themselves could (and the docs for said changes certainly should) mention the nrp-ness; but they're tied together by this substantial architectural shift (and basically nothing else), and IMO that's worth mentioning, and this is the place to do it. | 14:18 |
mriedem | sure, if you want, just take what i proposed above and pretty it up | 14:19 |
*** ttsiouts has joined #openstack-nova | 14:19 | |
*** Kevin_Zheng has quit IRC | 14:22 | |
efried | mriedem: done, should I edit and repropose or let melwitt do it? | 14:22 |
mriedem | https://bugs.launchpad.net/nova/+bug/1821015 | 14:23 |
openstack | Launchpad bug 1821015 in OpenStack Compute (nova) "Attaching virtual GPU devices to guests in nova - libvirt reshaping" [Medium,Triaged] | 14:23 |
mriedem | efried: i'd say go ahead and modify yourself | 14:23 |
lbragstad | at some point this week - i'm wondering if we can sit down and hash out http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003894.html | 14:26 |
mriedem | lbragstad: you and who's army? | 14:26 |
lbragstad | just me, myself, and i | 14:27 |
mriedem | i didn't read the whole thread but i thought you and melwitt were hashing it out | 14:27 |
mriedem | dansmith: efried: jaypipes: fyi https://techblog.web.cern.ch/techblog/post/placement-requests/ | 14:27 |
mriedem | nice write up from belmoreira on the refresh associations stuff in their rocky upgrade | 14:27 |
mriedem | nice to see that feedback loop working ^ | 14:28 |
lbragstad | well - i think we're going to need to involve the foundation at some point to correct the sessions | 14:28 |
lbragstad | otherwise we risk splitting the audience with two similar sessions | 14:28 |
mriedem | are you going to make me read this thread? | 14:30 |
*** derekh has quit IRC | 14:31 | |
mriedem | can you do the general keystone sessions at the forum with an emphasis on what nova is planning to do, and then the nova specific details get hashed out at the ptg? | 14:31 |
mriedem | i don't even know if johnthetubaguy is going to be attending for https://www.openstack.org/summit/denver-2019/summit-schedule/events/23715/feedback-gathering-for-unified-limits-proposal | 14:32 |
mriedem | lbragstad: is what i just suggested what you already came to in the ML thread? | 14:33 |
mriedem | i was really hoping to not have to put my leadership underwear on today | 14:34 |
lbragstad | well there are duplicate forum sessions for rbac and unified limits | 14:34 |
lbragstad | i think melwitt wanted to have the nova session be specific to the unified limit and policy migrations for now - but i expect a lot of other services are going to be in that same boat | 14:35 |
lbragstad | originally, i think we were planning on using the forum sessions to communicate relevant information about what has been done for each initiative to operators, and leave the developer-specific topics for the PTG | 14:36 |
mriedem | here you go http://lists.openstack.org/pipermail/openstack-discuss/2019-March/004026.html | 14:38 |
*** awaugama has quit IRC | 14:38 | |
mriedem | if a split nova-specific session is just going to be crickets, then i don't think it's worth doing a forum session, just leave it for the ptg if devs want to talk about it | 14:39 |
*** itlinux has joined #openstack-nova | 14:39 | |
mriedem | this is why i didn't actually propose a nova session for unified limits myself | 14:39 |
lbragstad | ack - thanks for responding | 14:40 |
mriedem | probably not the response you're looking for, but it's a reason to justify combining sessions | 14:41 |
mriedem | if jaypipes cares about this (by proxy for verizon) i'm not sure if he's going to be at the forum either | 14:41 |
lbragstad | i'm fine keeping them separate if there is a reason to | 14:41 |
lbragstad | but i'm also fine consolidating them | 14:42 |
mriedem | lbragstad: is there anything you're not fine with? :) | 14:42 |
lbragstad | lol - if we keep them separate sessions, i wouldn't be fine with people getting confused over which one to attend ;) | 14:42 |
mriedem | you could do like a carnival barker standing outside your session | 14:43 |
mriedem | "one day only folks, gather round gather round" | 14:43 |
lbragstad | i'll see if i can recruit someone to do that | 14:44 |
lbragstad | s/recruit/bribe/ | 14:44 |
mriedem | ayoung with a sax? | 14:44 |
lbragstad | only if smooth jazz gets you in the mood to discuss policy and unified limits | 14:44 |
mriedem | smooth jazz gets me in the mood for everything | 14:45 |
* artom will start attaching sound files to his patches. | 14:46 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert "Wait for network-vif-plugged on resize revert" https://review.openstack.org/639396 | 14:46 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Revert resize: wait for external events in compute manager https://review.openstack.org/644881 | 14:46 |
* artom shall wait for CI to tell him what he broke with the second one. | 14:47 | |
*** sridharg has quit IRC | 14:47 | |
*** dtantsur is now known as dtantsur|bbl | 14:51 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Add a prelude release note for the 19.0.0 Stein GA https://review.openstack.org/644412 | 14:51 |
efried | mriedem et al ^ | 14:51 |
mriedem | bauzas: fyi if you can take a stab at this https://bugs.launchpad.net/nova/+bug/1821015 | 14:51 |
openstack | Launchpad bug 1821015 in OpenStack Compute (nova) "Attaching virtual GPU devices to guests in nova - libvirt reshaping" [Medium,Triaged] | 14:51 |
* bauzas looks | 14:52 | |
bauzas | mriedem: no worries, I'll write docs | 14:52 |
bauzas | I was also planning to talk about reboot issues | 14:52 |
mriedem | efried: +2 | 14:53 |
jaypipes | mriedem: thx for the link, ++. I should have time to get back to the perf improvement patches for CERN in nova-scheduler soon. sorry, between an offsite last week and some other things, been slammed of late. | 14:59 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add known issue for minimum bandwidth resource leak https://review.openstack.org/644694 | 14:59 |
gibi | mriedem: thanks for that ^^ | 15:00 |
mriedem | np | 15:00 |
kashyap | mriedem: When you get a min, got a question for you (and the other Matt) on PS-11 here: https://review.openstack.org/#/c/641981/11 | 15:00 |
kashyap | (It's a quick one, though.) | 15:00 |
*** jmlowe has joined #openstack-nova | 15:00 | |
*** phasespace has quit IRC | 15:01 | |
*** lpetrut has quit IRC | 15:01 | |
*** manjeets_ is now known as manjeets | 15:02 | |
mriedem | kashyap: sure, split the docs kerfuffle out | 15:04 |
kashyap | mriedem: Thank you, sir | 15:04 |
kashyap | mriedem: I noted as such in the commit message (but not many read it, besides you :D). It requires a separate treatment. And writing high-quality docs take time. So I didn't wanted to mix it all in one.) | 15:05 |
mriedem | need another core for https://review.openstack.org/#/c/642863/ | 15:05 |
mriedem | which should probably happen before rc1 | 15:05 |
*** dpawlik is now known as dpawlik_ | 15:06 | |
*** mrch_ has quit IRC | 15:06 | |
*** phasespace has joined #openstack-nova | 15:12 | |
*** awalende has quit IRC | 15:14 | |
*** awalende has joined #openstack-nova | 15:14 | |
*** Luzi has quit IRC | 15:17 | |
*** awalende has quit IRC | 15:19 | |
mriedem | lbragstad: mnaser: so based on mnaser's reply in the ML on the policy stuff with a read-only user, that would be something like just changing all GET policies in nova to require a reader role, yeah? rather than admin_or_owner type thing. | 15:29 |
mriedem | so non-admins could have the reader role, but not admin role, and admins would have both reader and admin role | 15:29 |
lbragstad | correct | 15:30 |
*** mvkr has quit IRC | 15:30 | |
lbragstad | fwiw - keystone builds a relationship between the defaults roles we populate | 15:30 |
mriedem | and that could also be scoped to project, right? so readers in project A can't GET resources from project B | 15:30 |
lbragstad | right | 15:30 |
lbragstad | if someone has `reader` on the system, then they can view hypervisor information or whatever | 15:31 |
lbragstad | (is an example of how that would work outside of project scope) | 15:31 |
mriedem | ok, which is a good use case for support teams | 15:31 |
lbragstad | exactly | 15:31 |
lbragstad | or auditors | 15:31 |
mriedem | they can't delete hypervisors, but they can GET them | 15:31 |
lbragstad | also - when nova writes policies for this | 15:31 |
lbragstad | you only need to write it for the lower common denominator | 15:32 |
lbragstad | lowest* | 15:32 |
lbragstad | for example, GET /v2/hypervisors would be "role:reader" for the policy check string | 15:32 |
*** hongbin has joined #openstack-nova | 15:32 | |
lbragstad | and if a system administrator calls that API, they will actually have `admin`, `member`, and `reader` in their token - since `admin` implies `member` and `member` implies `reader` | 15:33 |
mriedem | and scope_types has to be set to 'system' for that also? | 15:33 |
lbragstad | eventually, yet | 15:33 |
lbragstad | yes* | 15:33 |
mriedem | so what about the case where people aren't using scope types yet? | 15:33 |
mriedem | but want reader roles in their policy, but not expose hypervisor details to non-admins | 15:33 |
*** tbachman has joined #openstack-nova | 15:34 | |
mriedem | or is that not really an option? | 15:34 |
lbragstad | in that case, we have to add a little extra to the check string for each policy (only until we can assume the migration is over and we've communicated things to operators) | 15:34 |
lbragstad | "role:reader and system_scope:all" would solve that | 15:34 |
lbragstad | without having enforce_scope=True | 15:34 |
mriedem | do you envision we'd have two policy files for awhile, the existing one for backward compat, and a "this is the new fancy stuff which is here to use if you want, but it's experimental for now" kind of thing? | 15:35 |
lbragstad | i wouldn't recommend that approach - we tried that in keystone a long time ago and it didn't turn out too well imo | 15:35 |
lbragstad | instead, i would evolve the existing policies to account for those cases, like check_str="(role:reader and system_scope:all) or rule:admin_or_owner" | 15:36 |
mriedem | ok i don't have a good grasp on what the proposed migration looks like | 15:36 |
mriedem | i'm assuming the recommendation is to start migrating piece meal | 15:36 |
lbragstad | that's how we're doing it in keystone, yeah | 15:36 |
mriedem | i'm also assuming there is a summit video somewhere about the migration process? | 15:37 |
lbragstad | we're going to resource individually, adding a whole bunch of protection tests so we catch regressions, and then adjusting the policies accordingly | 15:37 |
lbragstad | going through* | 15:37 |
lbragstad | there have been forum sessions on the migration approach in the past, but nothing has been recorded afaik | 15:38 |
mriedem | ok, that could also be done with a recorded youtube session like these old ones that sdague used to organize https://wiki.openstack.org/wiki/BootstrappingHour | 15:40 |
mriedem | i wish we'd start doing more of those again | 15:40 |
lbragstad | i have done something similar for this work in the past, but not the migration | 15:40 |
*** eharney has joined #openstack-nova | 15:40 | |
openstackgerrit | Dan Smith proposed openstack/nova-specs master: Add request-filter-image-types spec https://review.openstack.org/644625 | 15:42 |
*** luksky has quit IRC | 15:45 | |
*** BjoernT has quit IRC | 15:50 | |
*** gyee has joined #openstack-nova | 15:51 | |
*** lpetrut has joined #openstack-nova | 15:54 | |
*** liuyulong is now known as liuyulong|away | 15:57 | |
*** itlinux has quit IRC | 16:00 | |
*** IvensZambrano has joined #openstack-nova | 16:03 | |
*** efried is now known as efried_rolling | 16:03 | |
*** BjoernT has joined #openstack-nova | 16:06 | |
*** mvkr has joined #openstack-nova | 16:07 | |
bauzas | mriedem: efried_rolling: FWIW, I left https://review.openstack.org/#/c/644412/5 waiting for other reviews, we could just +W it tonight EOB if you want | 16:08 |
bauzas | ie. US folks EOB I mean | 16:08 |
*** itlinux has joined #openstack-nova | 16:09 | |
bauzas | that leaves melwitt, dansmith or other West Coast folks to balance if needed | 16:09 |
mriedem | ack | 16:09 |
*** igordc has joined #openstack-nova | 16:10 | |
*** lpetrut has quit IRC | 16:12 | |
*** itlinux has quit IRC | 16:14 | |
*** sapd1_x has quit IRC | 16:14 | |
*** itlinux has joined #openstack-nova | 16:17 | |
*** jangutter has quit IRC | 16:20 | |
*** _pewp_ has quit IRC | 16:20 | |
*** _pewp_ has joined #openstack-nova | 16:21 | |
*** jmlowe has quit IRC | 16:21 | |
*** dtantsur|bbl is now known as dtantsur | 16:22 | |
openstackgerrit | Dan Smith proposed openstack/nova-specs master: Add request-filter-image-types spec https://review.openstack.org/644625 | 16:23 |
gmann | lbragstad: mriedem do we really need system_scope=all ? until enforce_scope=false scope_type will not be checked just log warning so operator will have time to consume the scope_type things | 16:24 |
gmann | I mean as we have configuration variable to enable/disable the scope_type then, we can directly do "role:reader", scope_type: 'system' | 16:25 |
*** tzumainn has joined #openstack-nova | 16:26 | |
*** _pewp_ has quit IRC | 16:26 | |
*** itlinux has quit IRC | 16:27 | |
*** itlinux has joined #openstack-nova | 16:29 | |
kashyap | What are the other volume drivers besides: Quobyte, Virtuozzo, SMBFS? | 16:29 |
lbragstad | gmann i think we do need "role:reader and system_scope:all", especially in the case where we are applying that to things like hypervisors | 16:30 |
lbragstad | otherwise we could accidentally open the hypervisor API up to anyone with the reader role on anything | 16:30 |
lbragstad | since the check string would be "role:reader or rule:admin_or_owner" instead of "(role:reader and system_scope:all) or rule:admin_or_owner" | 16:31 |
*** priteau has joined #openstack-nova | 16:33 | |
*** igordc has quit IRC | 16:37 | |
*** itlinux has quit IRC | 16:37 | |
*** altlogbot_1 has joined #openstack-nova | 16:40 | |
*** mrch_ has joined #openstack-nova | 16:40 | |
*** altlogbot_1 has quit IRC | 16:41 | |
*** igordc has joined #openstack-nova | 16:42 | |
*** itlinux has joined #openstack-nova | 16:43 | |
*** awaugama has joined #openstack-nova | 16:44 | |
*** BjoernT has quit IRC | 16:47 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode when 'none' is not viable https://review.openstack.org/641981 | 16:47 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: vzstorage: Use 'writeback' QEMU cache mode https://review.openstack.org/643376 | 16:47 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: smbfs: Use 'writeback' QEMU cache mode https://review.openstack.org/643377 | 16:47 |
*** jmlowe has joined #openstack-nova | 16:48 | |
kashyap | mdbooth: ^ Has the bare-minimum doc update. For the volume drivers text: the 'vzstorage' and 'smbfs' patch should also merge along with the main patch -- for the "doc to tell the truth" | 16:48 |
* kashyap --> needs to run; back later | 16:49 | |
mdbooth | kashyap: Thanks | 16:49 |
cfriesen | kashyap: everything under virt/libvirt/volume? | 16:49 |
*** itlinux has quit IRC | 16:50 | |
gmann | lbragstad: ok. make sense until enforce_scope is not removed or defaulted to True. | 16:50 |
mnaser | lbragstad, mriedem: late but better than ever, i tried hacking a little bit on what it would look like and i was also unsure of how an ideal transition path might look like | 16:51 |
gmann | lbragstad: so in that case requested cred will have to add system_scope=all for such request then only they are auth otherwise not | 16:51 |
mnaser | i think the concern is bob's openstack deployment who hasn't deleted their policy.json file or is currently overriding a few things that finds themselves exposing a lot of things after an upgrade | 16:52 |
lbragstad | mnaser how so? | 16:54 |
gmann | mnaser: any policy rule overridden in policy.json file will keep working as it is because we will add old policy rule as deprecated_rule in new rules. But yes if anyone reply on policy in code default thing then they will see this impact | 16:54 |
lbragstad | because their overrides are obsolete? | 16:54 |
mnaser | lbragstad: if someone had role:support to GET hypervisor list, and now we updated it that they need system scope now for that specific policy | 16:55 |
mnaser | they find themselves with a non functional policy at that point i guess | 16:55 |
mnaser | yeah i think the concern is that it would break existing policies | 16:55 |
lbragstad | if they have a special role for listing hypervisors and an override for that policy, then it should still work even if we change the default | 16:56 |
gmann | yeah | 16:56 |
gmann | if bob reply on GET hypervisor with default policy which is say "admin" currently, we will change this to say "role:reader and system_scope:all" or something which control it not to expose to non-admin | 16:59 |
*** N3l1x has joined #openstack-nova | 17:00 | |
mnaser | lbragstad: if we change the scope to system, wouldn't it stop working then.. because that role is probably project scoped? | 17:01 |
mnaser | project scoped to the 'admin' tenant | 17:01 |
lbragstad | roles aren't scoped to projects per se | 17:02 |
lbragstad | roles can be associated to actors on targets, actors can be groups or users, and targets can be projects, domains, or system | 17:02 |
mnaser | right, but bob's openstack cloud probably has it targeting projects right now, as 99% of our docs have always said | 17:03 |
mnaser | "if you want to give a role for X, create a project and add X role to Y user into it" | 17:03 |
gmann | also scope_type will not be enforced until it is explicitly set True by enforce_scope. enforce_scope default is false as of now. | 17:03 |
*** ivve has quit IRC | 17:06 | |
mnaser | but if its not enforced then could that not introduce other eissues? | 17:08 |
eandersson | Morning | 17:09 |
mnaser | role:reader and system_scope:system without it enforced means role:reader can get hypervisor list? | 17:09 |
eandersson | What is the difference from disk_gb and disk_available_least? | 17:10 |
lbragstad | mnaser that's why we write the policy like "(role:reader and system_scope:all) or role:admin_or_owner" | 17:11 |
gmann | no, as lbragstad mentioned we will add a special case of scope_type for that what keystone did - role:reader and system_scope:all | 17:11 |
mnaser | ok so we would have a policy enforcing both .. until we decide to cut it off | 17:11 |
gmann | true | 17:11 |
mnaser | so maybe a train could be a transitionary release i guess | 17:11 |
mnaser | and then we can flip the switch | 17:11 |
lbragstad | we need to write slightly more complicated policy check_strs to allow for the migration | 17:12 |
gmann | I suggest to flip in V to give 1 2 cycle of transition phase as this is huger change in policy | 17:12 |
mnaser | can you enable enforcement of system_scope? | 17:12 |
lbragstad | then we can offload more to oslo.policy using enforce_scope=True in the future and simplify the check strings | 17:12 |
mnaser | could a deployer enable it AND put rule:admin_or_owner set to nothing | 17:12 |
mnaser | and they'd be using 'the new system' | 17:13 |
lbragstad | yeah... if a deployer wants to opt into the new system, they just have to maintain a policy file with the *new* defaults, which omits the logical OR with oslo.policy migration | 17:13 |
lbragstad | it's clunky... but... | 17:14 |
openstackgerrit | Merged openstack/nova master: Add known issue for minimum bandwidth resource leak https://review.openstack.org/644694 | 17:16 |
*** udesale has quit IRC | 17:17 | |
*** IvensZambrano has quit IRC | 17:20 | |
*** altlogbot_0 has joined #openstack-nova | 17:26 | |
*** altlogbot_0 has quit IRC | 17:28 | |
*** altlogbot_2 has joined #openstack-nova | 17:30 | |
*** mvkr has quit IRC | 17:31 | |
*** ccamacho has quit IRC | 17:36 | |
*** NobodyCam has joined #openstack-nova | 17:40 | |
NobodyCam | Good Morning Nova folks | 17:40 |
*** tesseract-rh has quit IRC | 17:40 | |
*** ttsiouts has quit IRC | 17:40 | |
*** ttsiouts has joined #openstack-nova | 17:41 | |
*** sridharg has joined #openstack-nova | 17:42 | |
*** ttsiouts has quit IRC | 17:46 | |
*** dtantsur is now known as dtantsur|afk | 17:53 | |
jaypipes | NobodyCam: mornin :) | 17:54 |
jaypipes | or afternoon. | 17:54 |
NobodyCam | hey hey jaypipes long time! | 17:54 |
eandersson | jaypipes, do you happen to know the difference between free_disk_gb and disk_available_least? | 17:56 |
eandersson | I assume disk_available_least takes images etc into account? | 17:56 |
eandersson | Trying to figure out why a vm that was destroyed and re-created won't fit into the same compute again. | 17:57 |
eandersson | free_disk_gb is large enough to accommodate the vm | 17:57 |
eandersson | also, manually creating the vm on that compute worked (free_disk_gb is now 4, and disk_available_least is -33) | 17:58 |
sean-k-mooney | eandersson: disk_available_lest will sometime be the same but it can be wildly different depending on your storage backend | 17:59 |
eandersson | so this is probably due to the rocky upgrade | 18:00 |
eandersson | we don't use a specified storage backend | 18:00 |
eandersson | so what ever is default | 18:00 |
eandersson | brb | 18:01 |
sean-k-mooney | eandersson: google could me this https://gist.github.com/JCallicoat/43505cab0535057ca4fb | 18:01 |
sean-k-mooney | i wonder if we have that comment in our code | 18:02 |
NobodyCam | so dumb question, when creating new project / user it's just the _member_ role that is required to launch instances? | 18:02 |
sean-k-mooney | NobodyCam: by defualt yes | 18:02 |
NobodyCam | :) | 18:03 |
sean-k-mooney | although you have to also have a default quota of instnaces greater then 0 | 18:03 |
*** priteau has quit IRC | 18:04 | |
*** luksky has joined #openstack-nova | 18:05 | |
sean-k-mooney | eandersson: what i ment by storage spefic backedn is it gets a little broken when using shared storage e.g. nfs or rbd | 18:07 |
sean-k-mooney | eandersson: if free_gb is positive and disk_available_lest is negitive it means your worst case over commited for the instance that are shduled to the host exceed that allowed by your over commit raitio | 18:08 |
klindgren | Question re: live migration + configdrive + iso9960. Instead of scping the file between HV's. Can why can't we just recreate the config drive on the destination host? | 18:10 |
sean-k-mooney | klindgren: i belive there was a libvirt bug that prevented | 18:10 |
sean-k-mooney | klindgren: but we could | 18:10 |
klindgren | Are files that re passed in via the a boot command, not started as part of the vm data? So the config drive would be incomplete? | 18:10 |
sean-k-mooney | klindgren: i think that depends. i think we store user-data in the db in the instance extra table | 18:11 |
klindgren | Yea, we changed the code (we have a new enough libvirt) on the scp to look for iso9961 vs iso9960. And the migration works, it just creates a sparsely populated file with no data in it on the dst. | 18:12 |
sean-k-mooney | klindgren: what files are you spscically refering to | 18:12 |
klindgren | Nova boot --file /seomdest=blah --file /anotherdest=asdf | 18:13 |
klindgren | Which gets put in to config drive under content/000, content/0001 | 18:13 |
sean-k-mooney | klindgren: ya so openstack server create --user-data < my data> is stored in the db i dont think we store teh contets of files passed with --file | 18:14 |
NobodyCam | another dumb question: is there a trick to allowing the admin to launch service instances: I'm seeing Policy check for os_compute_api:os-hide-server-addresses failed with credentials <blah> when attempting to launch Octavia instances | 18:14 |
*** ralonsoh has quit IRC | 18:19 | |
sean-k-mooney | NobodyCam: am the amdin account i think need but admin and _member_ roles | 18:20 |
sean-k-mooney | but the admin account still had a quota | 18:20 |
sean-k-mooney | in the case of octavir the octavia service account allso has a quota typeiclay it will be set to -1 to have no limit however | 18:21 |
*** irclogbot_2 has quit IRC | 18:21 | |
*** owalsh has quit IRC | 18:23 | |
*** irclogbot_1 has joined #openstack-nova | 18:24 | |
*** irclogbot_1 has quit IRC | 18:27 | |
*** irclogbot_0 has joined #openstack-nova | 18:29 | |
openstackgerrit | Merged openstack/nova master: docs: Misc cleanups https://review.openstack.org/644616 | 18:30 |
*** icey has quit IRC | 18:31 | |
*** zhongjun2 has quit IRC | 18:31 | |
*** NobodyCam has quit IRC | 18:31 | |
*** pas-ha has quit IRC | 18:31 | |
*** geekinutah has quit IRC | 18:32 | |
mriedem | klindgren: correct personality files (file injection) are not stored in the db so if they are only in the config drive and you rebuild the config drive on the dest, those will be gone | 18:32 |
mriedem | same issue for shelve/unshelve with a config drive + personality files | 18:32 |
*** icey has joined #openstack-nova | 18:33 | |
*** zhongjun2 has joined #openstack-nova | 18:33 | |
sean-k-mooney | mriedem: personality files are also deprecated for removal for 2 release or more right? | 18:33 |
mriedem | correct https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/deprecate-file-injection.html | 18:33 |
mriedem | but it's an API so they aren't going to be removed | 18:33 |
mriedem | just strongly discouraged | 18:33 |
sean-k-mooney | mriedem: not even with a microverion? | 18:34 |
mriedem | although, a deployment can simply disable file injection (and that's the default for libvirt) today | 18:34 |
mriedem | sean-k-mooney: yes we deprecated them by removing them from the API | 18:34 |
mriedem | but if you use 2.1 then that doesn't matter | 18:34 |
*** _pewp_ has joined #openstack-nova | 18:34 | |
*** pas-ha has joined #openstack-nova | 18:34 | |
*** NobodyCam has joined #openstack-nova | 18:34 | |
*** geekinutah has joined #openstack-nova | 18:34 | |
sean-k-mooney | ah that makes sense. that is what i had assed we would do | 18:35 |
mriedem | when you assed you make an ass of u and me | 18:35 |
sean-k-mooney | typos all the typos :) | 18:35 |
mriedem | this is the libvirt thing https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.inject_partition | 18:35 |
_pewp_ | [ OpenStack Docs: Configuration Options ] - docs.openstack.org | 18:35 |
mriedem | disabled by default forever | 18:35 |
*** _pewp_ has quit IRC | 18:36 | |
sean-k-mooney | mriedem: i think we reinable it in some of the tempest jobs | 18:36 |
sean-k-mooney | but i dont rememebr which one | 18:36 |
sean-k-mooney | anyway its not important | 18:36 |
mriedem | yes it's the ENABLE_FILE_INJECTION var in devstack | 18:38 |
mriedem | it's in the base tempest job to test personality files | 18:38 |
gmann | it is enable in tempest-full | 18:38 |
*** sridharg has quit IRC | 18:38 | |
sean-k-mooney | mriedem: so related to klindgren's question if we have disabled file injection is there any reason we cant just recreate the config dirve in that case | 18:38 |
mriedem | idk, not my area of expertise | 18:39 |
mriedem | mikal could maybe help | 18:39 |
sean-k-mooney | mriedem: i mean they are not big so im not sure that is really a big issue anyway | 18:39 |
mriedem | klindgren: what is the problem with transferring the config drive during live migration? | 18:39 |
*** _pewp_ has joined #openstack-nova | 18:39 | |
mriedem | it becomes read-only or what? | 18:40 |
klindgren | Allowing ssh between all compute nodes with an ssh key | 18:40 |
klindgren | Gives an easy vector for an attacker to spread across compute nodes | 18:40 |
sean-k-mooney | klindgren: i dont think that is required in all cases | 18:40 |
klindgren | Its required in the configdrive + iso9960 use case | 18:41 |
sean-k-mooney | if you are using the ssh migration uri for libvrt then it would be | 18:41 |
sean-k-mooney | but im not sure if you can tunnel the file data over the libvirt connection when using qemus/libvirst native tls feature | 18:41 |
klindgren | we are using TLS for libvirt but this code does scp's of the config drive | 18:42 |
sean-k-mooney | kashyap: ^ any idea? | 18:42 |
klindgren | Because even libvirt 4.x can't migrate it/won't | 18:42 |
sean-k-mooney | klindgren: oh ok | 18:42 |
sean-k-mooney | klindgren: any you need config drive because ye cant use metadata service or just dont want too? | 18:42 |
klindgren | We only use configdrive vs's running metadata, and we have a bunch of stuff from other teams built onto of configdrive | 18:43 |
sean-k-mooney | oh wait ye are still support file injection too wich needs config drive | 18:44 |
klindgren | We don't specifically disable file injection, however in our case - no one uses it. | 18:44 |
klindgren | Basically In: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8196-L8215 | 18:48 |
_pewp_ | [ nova/driver.py at master · openstack/nova · GitHub ] - github.com | 18:48 |
sean-k-mooney | klindgren: ok. at first glance it sound like we may be able to just recreate the config drive in your sepcific case when file inject is diabled. | 18:48 |
*** BjoernT has joined #openstack-nova | 18:48 | |
klindgren | If we change iso9660 to iso9661, the live migration works. The confgdrive file is created on the destination hv. However, its created as a correctly size, spare file with no data in it | 18:49 |
klindgren | sean-k-mooney, We would be willing to do the code for this. Just wanted to make sure that their was some reason why we never did this before and wanted to make sure that we would have some level of support for this. | 18:50 |
klindgren | Assuming the file injection stuff was probably the blocker before hand. | 18:50 |
mriedem | klindgren: dansmith and/or jaypipes might remember other reasons | 18:51 |
* jaypipes reads back | 18:52 | |
dansmith | the configdrive being readonly makes it not migrated by libvirt, IIRC | 18:52 |
mriedem | figuring out if file injection is disabled on both the source and dest and telling hosts on both sides during live migration, hey, file injection is disabled so if there is a config drive on the instance, just rebuild it on the dest, would probably be pretty straight-forward | 18:52 |
sean-k-mooney | dansmith: i think tha thas been fixed | 18:52 |
openstackgerrit | Vladyslav Drok proposed openstack/nova master: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.openstack.org/571410 | 18:53 |
_pewp_ | [ Gerrit Code Review ] - review.openstack.org | 18:53 |
sean-k-mooney | mriedem: ya that is what i was thinking too but i dont know if im missing an edge case | 18:53 |
sean-k-mooney | aslo is _pewp_ a new bot? | 18:53 |
dansmith | sean-k-mooney: I thought it was actually categorically rejected, but I'm sure I'm wrong | 18:54 |
mriedem | idk wtf _pewp_ is but it looks like it's hemna_'s | 18:54 |
sean-k-mooney | dansmith: i was jsut taking this config comment on face value https://github.com/openstack/nova/blob/master/nova/conf/configdrive.py#L17-L33 | 18:55 |
_pewp_ | [ nova/configdrive.py at master · openstack/nova · GitHub ] - github.com | 18:55 |
sean-k-mooney | i dont know wat "resolved in libvirt v1.2.17" actully means | 18:56 |
sean-k-mooney | they coudl have document it as wont fix i guess | 18:56 |
dansmith | well, that was one reason to have it as vfat, IIRC, | 18:57 |
*** ivve has joined #openstack-nova | 18:58 | |
dansmith | but I thought we actually still need that for other reasons, like being able to host instances with no iso9660 support, and maybe one of the sub-drivers like virtuozzo that needs a regular filesystem or something | 18:58 |
sean-k-mooney | ya vfat was a woraround for that issue | 18:58 |
mriedem | sean-k-mooney: stephenfin deprecated the config_drive_format option so you could follow up with him | 18:58 |
sean-k-mooney | mriedem: ya i was going to check the release notes for libvirt 1.2.17 | 18:59 |
mriedem | the commit message referenced https://bugzilla.redhat.com/show_bug.cgi?id=1203032 | 18:59 |
openstack | bugzilla.redhat.com bug 1203032 in libvirt "Enhancing block/disk migration in libvirt" [Low,Closed: nextrelease] - Assigned to pboldin | 18:59 |
_pewp_ | [ 1203032 – Enhancing block/disk migration in libvirt ] - bugzilla.redhat.com | 18:59 |
eandersson | sean-k-mooney, I see | 19:00 |
*** altlogbot_2 has quit IRC | 19:00 | |
eandersson | I think this changed somehow during the upgrade which is why it's weird | 19:00 |
eandersson | I mean we went from.. Mitaka to Rocky :D | 19:00 |
eandersson | from my perspective it looks like base images are taken into account now, and weren't before. | 19:01 |
sean-k-mooney | eandersson: do you set allocation raitios in host aggreates? | 19:01 |
eandersson | nothing overcommited on these flavors | 19:01 |
eandersson | I tried adding disk_all = 1 but did nothing | 19:01 |
*** altlogbot_0 has joined #openstack-nova | 19:02 | |
sean-k-mooney | by disk_all do you mean https://docs.openstack.org/nova/rocky/configuration/config.html#DEFAULT.disk_allocation_ratio | 19:04 |
_pewp_ | [ OpenStack Docs: Configuration Options ] - docs.openstack.org | 19:04 |
eandersson | sorry yea disk_allocation_ratio | 19:04 |
eandersson | we don't have it set in the aggregate for non-overprovisioned aggergates | 19:04 |
sean-k-mooney | eandersson: in ocata? i think we broke setting allocation ratios via host aggregates when we started using placment for cpu ram and disk | 19:05 |
*** tesseract has joined #openstack-nova | 19:05 | |
sean-k-mooney | there is a mail from melwitt about butthis is proably not the issue. | 19:06 |
*** altlogbot_0 has quit IRC | 19:06 | |
*** _pewp_ has quit IRC | 19:06 | |
sean-k-mooney | http://lists.openstack.org/pipermail/openstack-dev/2018-January/126283.html | 19:06 |
*** _pewp_ has joined #openstack-nova | 19:06 | |
sean-k-mooney | eandersson: in upgading form mitaka to rocky you went form that working to not | 19:07 |
*** tssurya has quit IRC | 19:07 | |
eandersson | So I would expect that to break for instances that are over-commited | 19:07 |
eandersson | not for instances that are not overcommited right? | 19:07 |
*** altlogbot_3 has joined #openstack-nova | 19:07 | |
sean-k-mooney | but also you nolonger need the AggregateCoreFilter,AggregateRamFilter,AggregateDiskFilter or the core/ram/disk filters | 19:07 |
eandersson | I think that would fix it for us | 19:08 |
*** lpetrut has joined #openstack-nova | 19:08 | |
eandersson | because placement does that now? | 19:08 |
sean-k-mooney | eandersson: yes this is handeled by placement now | 19:09 |
sean-k-mooney | or rather form ocata on | 19:09 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Revert resize: wait for external events in compute manager https://review.openstack.org/644881 | 19:09 |
_pewp_ | [ Gerrit Code Review ] - review.openstack.org | 19:09 |
artom | _pewp_, what are you? | 19:09 |
sean-k-mooney | so you can safely disable the disk filter that is preventing the vm form working | 19:09 |
sean-k-mooney | artom: i think a bot of some kind | 19:10 |
artom | sean-k-mooney, heh, I got that part :) | 19:10 |
eandersson | Yea - I enabled debug | 19:10 |
eandersson | I gotta go, but will be back later. More meeting | 19:10 |
*** efried_rolling is now known as efried | 19:11 | |
*** lpetrut has quit IRC | 19:12 | |
sean-k-mooney | artom: i think its https://github.com/hemna/sopel-tableflip | 19:13 |
*** jmlowe has quit IRC | 19:15 | |
*** awalende has joined #openstack-nova | 19:15 | |
*** irclogbot_0 has quit IRC | 19:16 | |
*** tssurya has joined #openstack-nova | 19:16 | |
*** irclogbot_3 has joined #openstack-nova | 19:17 | |
*** awalende has quit IRC | 19:19 | |
melwitt | lbragstad, mriedem: well, the parts I thought were relevant to operators/users (and thus forum) are 1) are operators on board with the idea of fixing non-admin policy handling via scope types as a carrot to get operators to adopt different token scopes in their use of nova and 2) if the unified limit migration details in the spec sound OK to operators. 2) is maybe not something operators care too much about | 19:20 |
*** _pewp_ has quit IRC | 19:21 | |
*** _pewp_ has joined #openstack-nova | 19:21 | |
*** _pewp_ has quit IRC | 19:22 | |
*** _pewp_ has joined #openstack-nova | 19:22 | |
efried | dansmith: Sorry if I'm being a dolt here, but where does the request filter get required=COMPUTE_IMAGE_TYPE_FOO from originally? Is it image_meta? Is it translated from the image type somehow? This is the part I'm still missing in https://review.openstack.org/#/c/644625/ | 19:23 |
_pewp_ | [ Gerrit Code Review ] - review.openstack.org | 19:23 |
efried | You've mentioned how the compute driver adds COMPUTE_IMAGE_TYPE_FOO into its capabilities | 19:23 |
dansmith | efried: I haven't worked it all out all the plumbing yet, but we know what image they asked for and we can know what format it's in | 19:24 |
efried | Okay. So like if there's an image.type field and we can do "COMPUTE_IMAGE_TYPE_SUPPORT_%s" % image.type kind of thing? | 19:25 |
dansmith | right | 19:25 |
dansmith | it's called format I think, but yeah | 19:25 |
efried | image.type.upper().replace("things that aren't legal", "_") | 19:25 |
efried | os_traits.normalize something | 19:25 |
efried | okay, cool. Thanks. | 19:25 |
dansmith | efried: | disk_format | qcow2 | | 19:26 |
sean-k-mooney | am so dumb question before i read your sepc. could we just tag the compute nodes with traits for the image typs they support and then read the image type form glance and add the trait to the placment request | 19:26 |
dansmith | efried: https://docs.openstack.org/glance/rocky/user/formats.html | 19:26 |
_pewp_ | [ OpenStack Docs: Disk and Container Formats ] - docs.openstack.org | 19:26 |
dansmith | efried: pretty constrained list there | 19:27 |
sean-k-mooney | im thinking of suppoted image types like compute capablites | 19:27 |
efried | dansmith: cool. Standard traits to be proposed I assume. | 19:27 |
efried | sean-k-mooney: That's what he's doing, yes. | 19:27 |
dansmith | efried: yep | 19:27 |
sean-k-mooney | efried: ok makes sense | 19:27 |
dansmith | efried: first item in work item list is "add to os-traits" | 19:28 |
efried | os_traits.normalize_name is only for custom traits. prolly going to want a map. | 19:28 |
efried | ++ | 19:28 |
sean-k-mooney | efried: i was going to say we have some code in nova to normalise traits already but maybe we never merged that.. | 19:28 |
efried | sean-k-mooney: Yeah, we merged it and then moved it to os.traits, but it's only for custom | 19:29 |
sean-k-mooney | i was thinking of the traits nomalisation code for the feature based nic schduling that we never finished. | 19:29 |
efried | It's probably okay to hardcode a map for this. Adding a new supported image type, that doesn't happen frequently, does it? | 19:29 |
dansmith | efried: correct | 19:30 |
sean-k-mooney | efried: not really no | 19:30 |
*** irclogbot_3 has quit IRC | 19:30 | |
efried | if a new image type is added, does it require changes in nova anyway? | 19:30 |
sean-k-mooney | it happens about as often as adding a new hypervior | 19:30 |
sean-k-mooney | am not nessisarly | 19:31 |
efried | cause if not, we may want to consider making that translation generic rather than hardcoded | 19:31 |
mriedem | https://etherpad.openstack.org/p/nova-ptg-train | 19:31 |
*** jmlowe has joined #openstack-nova | 19:31 | |
_pewp_ | [ OpenStack Etherpad ] - etherpad.openstack.org | 19:31 |
mriedem | "New virt driver for rsd:" | 19:31 |
*** _pewp_ has quit IRC | 19:31 | |
sean-k-mooney | we just pull the image form glance and give it to the hyperviro to use | 19:31 |
dansmith | efried: likely would.. libvirt can read a lot of stuff, but most of what is covered there | 19:31 |
mriedem | come to butthead https://github.com/openstack/rsd-virt-for-nova | 19:31 |
dansmith | efried: and if it wasn't just a "use this and load it" then it'd break us without nova support | 19:31 |
*** _pewp_ has joined #openstack-nova | 19:31 | |
*** irclogbot_1 has joined #openstack-nova | 19:31 | |
efried | anyway, I didn't want to get into all the impl details; I just wanted to understand where that bit was coming from. | 19:31 |
dansmith | efried: like, if it wasn't just a raw file we're copying around, libvirt would need tooling to deal with those files, even if it can read them | 19:32 |
efried | okay. | 19:32 |
sean-k-mooney | dansmith: we have a few other cases that are very similar | 19:32 |
sean-k-mooney | for example im thinkg of suport vif_models or gpu_models(not gpu/vgpu passthough but gpu emulation) | 19:33 |
efried | mriedem: I saw that, noticed they didn't have a whole lot of code in their virt driver | 19:33 |
sean-k-mooney | i was going to write a spec to enable virt-gpu support by extendign the enum we alredy have but do you think its woth doing somethign similar and reporting supprot vif_models or gpu_models as traits? | 19:34 |
*** altlogbot_3 has quit IRC | 19:34 | |
*** artom has quit IRC | 19:35 | |
mriedem | efried: i'm assuming you'll get all sorts of awesome internal pressure for that rsd driver now | 19:35 |
*** altlogbot_1 has joined #openstack-nova | 19:36 | |
sean-k-mooney | mriedem: i have reviewd the code. its more limited then it used to be/could be | 19:36 |
sean-k-mooney | it currently relyi on create a 1:1 mapping between compute node and flavor | 19:36 |
sean-k-mooney | it previously used to to create 1 hypervior per compute node like the ironic on did so nova could act as a scudler. so while im happy to see the direver it has good way to go befoer it would be ready to move intree or be used in production | 19:38 |
*** _pewp_ has quit IRC | 19:39 | |
sean-k-mooney | efried: have you looked at the rsd virt dirver at all | 19:39 |
efried | I glanced at what was there in github and it appeared to be empty. Beyond that, no. | 19:39 |
*** imacdonn has quit IRC | 19:40 | |
efried | Oh, I've been confusing RSD and RDT in my head. (can't imagine why) | 19:40 |
efried | so yeah, I've never heard of RSD, internally or otherwise. | 19:40 |
*** imacdonn has joined #openstack-nova | 19:40 | |
sean-k-mooney | efried: its ok you will :P | 19:40 |
sean-k-mooney | efried: https://github.com/openstack/rsd-virt-for-nova | 19:41 |
efried | ohh, there it is. | 19:41 |
sean-k-mooney | efried: ya it used to be a lot more powerful but things changed. | 19:42 |
sean-k-mooney | that said it still allows you to boot node with out ironic useig rsd via nova so thats kind of cool | 19:43 |
*** _pewp_ has joined #openstack-nova | 19:45 | |
sean-k-mooney | but its currently missusing flavor in a way that will not scale. if you have 1000 RSD nodes it will create 1000 flavors... | 19:46 |
*** awaugama has quit IRC | 19:48 | |
cdent | sounds like something I could use at home | 19:49 |
*** eharney has quit IRC | 19:50 | |
sean-k-mooney | cdent: the original plan was to create one hypervior per rsd node and 1 flavor per uniqute type of rsd node discovers whcih requried on allcoate of CUSTOM_RSD_NODE_TYPE_WHATEVER | 19:53 |
sean-k-mooney | so if you only had two types of rsd system you would get only 2 flavor and to customer resouce classes | 19:53 |
sean-k-mooney | pretty much how ironic works | 19:53 |
*** tesseract has quit IRC | 19:54 | |
sean-k-mooney | cdent: i think helena had some issue wiht modelign things properly in plamcent so this was a temproy fix but i havent talkd to her about it since last ptg so who know why it chaged | 19:55 |
cdent | the world moves in mysterious ways | 19:56 |
*** igordc has quit IRC | 19:56 | |
*** eharney has joined #openstack-nova | 20:02 | |
*** owalsh has joined #openstack-nova | 20:13 | |
*** awalende has joined #openstack-nova | 20:20 | |
*** eharney has quit IRC | 20:22 | |
*** awalende_ has joined #openstack-nova | 20:23 | |
*** awalende has quit IRC | 20:26 | |
*** igordc has joined #openstack-nova | 20:31 | |
openstackgerrit | melanie witt proposed openstack/nova master: Move creation of rpcapi.ComputeAPI object from __init__ https://review.openstack.org/644998 | 20:39 |
_pewp_ | [ Gerrit Code Review ] - review.openstack.org | 20:39 |
*** IvensZambrano has joined #openstack-nova | 20:41 | |
*** irclogbot_1 has quit IRC | 20:45 | |
*** mdbooth_ has joined #openstack-nova | 20:46 | |
*** irclogbot_1 has joined #openstack-nova | 20:47 | |
*** mdbooth has quit IRC | 20:50 | |
melwitt | lbragstad: I re-read the channel log and I think we should just combine sessions | 20:51 |
*** igordc has quit IRC | 20:51 | |
*** igordc has joined #openstack-nova | 20:52 | |
lbragstad | melwitt both rbac and unified limits? | 20:52 |
melwitt | lbragstad: I think so. I'm going to wager we'll have enough time for both | 20:52 |
lbragstad | ok | 20:53 |
mriedem | dansmith: alright i've gone through your spec https://review.openstack.org/#/c/644625/ | 20:53 |
_pewp_ | [ Gerrit Code Review ] - review.openstack.org | 20:53 |
mriedem | mostly nits, but wondering what you had in mind for the capabilities-as-traits hook for this | 20:53 |
lbragstad | i suppose we'll need to get some etherpads rolling then - that way we get the things nova wants to go through written down and generalized if possible | 20:53 |
*** altlogbot_1 has quit IRC | 20:53 | |
melwitt | lbragstad: yeah, I can create etherpads with the things I was thinking, and then we can work on it. or, you can create them and I'll add. whatever you want | 20:54 |
lbragstad | melwitt would you want to follow up the ML thread? | 20:54 |
melwitt | lbragstad: sure, I'll reply | 20:54 |
lbragstad | thanks | 20:54 |
*** altlogbot_3 has joined #openstack-nova | 20:55 | |
*** eharney has joined #openstack-nova | 21:19 | |
*** xek_ has quit IRC | 21:21 | |
*** whoami-rajat has quit IRC | 21:29 | |
mriedem | welp, this doesn't look good http://logs.openstack.org/63/642863/1/gate/nova-tox-functional/6573680/job-output.txt.gz#_2019-03-20_15_58_21_993250 | 21:30 |
mriedem | cdent: efried: ^ | 21:30 |
* cdent reads | 21:30 | |
mriedem | this is the test that uses the PlacementFixture as a context manager | 21:30 |
cdent | ah, that might explain why we don't register log opts | 21:31 |
cdent | in register_opts | 21:31 |
* cdent throws together a quick revert of that to see | 21:31 | |
mriedem | what i can't explain is why this would just start failing all of a sudden | 21:31 |
dansmith | mriedem: okay, since the list of disk formats is such a restricted and static list, it doesn't seem unreasonable to just use capabilities for this, but I don't care that much | 21:31 |
cdent | that merged only in the last few ours | 21:31 |
efried | mriedem: It's because we landed https://review.openstack.org/#/c/644591/ in placement | 21:32 |
_pewp_ | [ Gerrit Code Review ] - review.openstack.org | 21:32 |
cdent | well, some times today (the register opts change) | 21:32 |
*** SASAA has quit IRC | 21:32 | |
efried | hemna_: Not loving _pewp_ - what value is it supposed to add? | 21:32 |
hemna_ | arg | 21:32 |
cdent | mriedem: there's the revert https://review.openstack.org/#/c/645014/ | 21:32 |
_pewp_ | [ Gerrit Code Review ] - review.openstack.org | 21:32 |
cdent | but I think there's likely a better fix | 21:32 |
hemna_ | I'll remove the github portion, I thought I already had | 21:32 |
cdent | (on the nova side) | 21:33 |
*** _pewp_ has quit IRC | 21:33 | |
* cdent will work on the nova side right now | 21:33 | |
mriedem | opening a bug | 21:33 |
mriedem | https://bugs.launchpad.net/nova/+bug/1821092 | 21:34 |
openstack | Launchpad bug 1821092 in OpenStack Compute (nova) "test_local_delete_removes_allocations_after_compute_restart failing since https://review.openstack.org/#/c/644591/" [Critical,Confirmed] | 21:34 |
mriedem | dansmith: so you were thinking like a capability boolean for each known disk_format? | 21:35 |
dansmith | mriedem: yeah, I mean, I know that there would be more of those than existing capabilities, but... I don't think the cost is any higher, and we just have to invent a new place to keep that list | 21:36 |
klindgren | sean-k-mooney, mriedem , dansmith, I assume based upon earlier discussions that you guys would be ok with a patch on live-migration to regenerate vs's copy an iso9660 config drive under the correct conditions? | 21:36 |
efried | cdent: You're just making a blank nova patch that depends-on the revert? | 21:36 |
dansmith | klindgren: meaning regenerate if we know there aren't files we'd be missing? not sure we can know that currently | 21:37 |
mriedem | i think we can assume there wouldn't be any personality files if inject_partition is -2 | 21:37 |
mriedem | i.e. disabled | 21:37 |
dansmith | mriedem: they could be in the config drive just not injected into the root image right? | 21:38 |
cdent | efried: no, I was hoping someone else would make the thing that matt has seen fail depend-on the revert patch. I'm looking into fixing the nova side so we don't have to have the revert on the placement side. It's happening because of a misuse of conf, which would be good to remove | 21:38 |
klindgren | I mean - I *know* that on my clouds it's not there, because of the layers that are built onto of it, don't use it. | 21:38 |
mriedem | dansmith: oh maybe, i'd have to dig into that code | 21:38 |
dansmith | mriedem: pretty sure they end up in config drive if provided, and then also in the root disk if you inject, but I could be wrong | 21:38 |
klindgren | So I was thinking maybe a config option for scp/rsync to add regenerate? | 21:38 |
efried | cdent: ack. | 21:38 |
dansmith | mriedem: but deciding whether or not to regen based on the config of the (current) source it's coming from seems too loose a restriction | 21:38 |
efried | mriedem: you want me to update https://review.openstack.org/#/c/642863/ ? | 21:39 |
mriedem | efried: to depend on the fix for this blocker bug? | 21:39 |
mriedem | dansmith: i don't disagree, it would require thought, | 21:39 |
*** itlinux has joined #openstack-nova | 21:39 | |
mriedem | so i think the answer to klindgren's question is it's going to require thought, not just a simple single change | 21:40 |
klindgren | I just want to avoid a patch that we can never get merged upstream | 21:40 |
efried | mriedem: yes. or create a new blank patch. | 21:40 |
mriedem | i suspect there would be MigrateData object RPC changes and such to communicate between the dest and source compute | 21:40 |
*** awalende has joined #openstack-nova | 21:40 | |
dansmith | mriedem: agree it's non trivial | 21:40 |
* cdent has found the problem | 21:41 | |
mriedem | klindgren: are you or your coworker buddies going to be at the ptg? | 21:41 |
efried | oo, cdent do tell | 21:41 |
klindgren | mriedem, yes we will have 2 people there | 21:41 |
mriedem | cdent: did someone put potato skins down the drain again? | 21:41 |
klindgren | I won't be there | 21:41 |
cdent | mriedem: twice | 21:42 |
klindgren | afaik | 21:42 |
mriedem | klindgren: at least throw something on here https://etherpad.openstack.org/p/nova-ptg-train | 21:42 |
cdent | efried: I'm relatively certain the same config is being used twice and it should be. need to confirm | 21:42 |
mriedem | and if you start coming up with design ideas and have thought through the corner cases and such, it'd be good to dump those thoughts in the ML | 21:42 |
dansmith | mriedem: injection_info = InjectionInfo(network_info=network_info, | 21:42 |
dansmith | files=injected_files, | 21:42 |
cdent | and I'm not clear why this only matters for logging opts | 21:42 |
cdent | but we'll see | 21:42 |
dansmith | mriedem: ^ is where we pass in the injected files to be written to the configdrive | 21:42 |
dansmith | mriedem: so I don't think host config disabling injection tells us anything about what is in the configdrive image | 21:43 |
mriedem | ok | 21:43 |
mriedem | RequestSpec to the rescue! | 21:43 |
*** awalende_ has quit IRC | 21:43 | |
dansmith | or system_metadata, a count of injected files we assert to be nonzero or something | 21:43 |
dansmith | but still, it's going to be confusing for admins, | 21:44 |
dansmith | wondering why some instances are migratable and/or don't depend on ssh keys and some do | 21:44 |
dansmith | but..yeah. | 21:44 |
dansmith | if we had the http service integrated into compute for the health check, we could do something better, like allowing one compute to fetch the image via one-time token from the source | 21:45 |
dansmith | i.e. fetch http://sourcehost/migration_assets/$uuid | 21:46 |
dansmith | they have to be able to talk to each other anyway | 21:46 |
dansmith | and just make that self-destruct as soon as the GET is performed | 21:46 |
mriedem | have you changed topics? or in the wrong channel perhaps? :) | 21:47 |
dansmith | no? | 21:47 |
mriedem | oh | 21:47 |
mriedem | heh | 21:47 |
mriedem | i'm not sure where "if we had the http service integrated into compute for the health check" came from | 21:48 |
dansmith | thinking of better ways to move bulk data between compute nodes than requiring ssh keys and allowing logins | 21:48 |
dansmith | because that _is_ totally nuts from a security perspective, | 21:48 |
dansmith | and fixing that with something more secure would be better than just adding a different path (regen) which only works in some cases anyway | 21:49 |
dansmith | such an approach would work for and fix the security holes in cold migration as well | 21:49 |
*** wwriverrat has joined #openstack-nova | 21:50 | |
mriedem | well, it's essentially what i'm doing for cross-cell resize with glance | 21:50 |
dansmith | using glance as the intermediary, but yeah | 21:50 |
mriedem | noting now that your config drive will have to get rebuilt on the other side... | 21:50 |
mriedem | does config driver already get rebuilt on resize? | 21:51 |
mriedem | *drive | 21:51 |
dansmith | I thought it gets copied | 21:51 |
dansmith | along with the root disk | 21:51 |
mriedem | i'm not sure https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8882 | 21:51 |
dansmith | if we had this http endpoint, your cross-cell resize stuff could be much more like regular resize and not have to go through glance | 21:52 |
dansmith | mriedem: that doesn't run if it already exists | 21:52 |
dansmith | so yeah, maybe that means it's regen'd but if it's copied then it won't | 21:52 |
dansmith | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3626 | 21:53 |
mriedem | hmm yeah so i suppose disk.config gets copied here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8811 | 21:54 |
mriedem | huh, i guess that's something that needs to be at least documented for the cross-cell stuff as a limitation right now because it's not doing anything with the config drive, so it's going to get regenerated on the dest and you'd lose any personality files | 21:55 |
dansmith | you're welcome. | 21:56 |
mriedem | duly noted in my re-proposed spec https://review.openstack.org/#/c/642807/1 | 21:58 |
mriedem | i don't know what the answer is, upload a snapshot of the disk.config to glance? | 21:58 |
dansmith | no the answer is implement an http server :D | 22:00 |
cdent | efried, mriedem : the gist of the problem is that you can register other opts multiple times, but not cli opts, and adding oslo_log.log.register_opts() to the common path brings CLI options into the scene of test_local_delete_removes_allocations_after_compute_restart, where config is registered multiple times (3 in fact) | 22:03 |
cdent | it only shows up in that test because we are doing some wildness with the PlacementFixture that doesn't happen anywhere else | 22:04 |
cdent | candidates for fixing it: | 22:04 |
cdent | 1. that revert, worry about it later | 22:04 |
cdent | 2. change that test to do things differently (hard because the reference to the in ram sqlite database needs to be maintained) | 22:05 |
cdent | 3. change the placement fixture (on the placement side) to take a flag to register or not register opts | 22:05 |
cdent | 3 is probably the best choice in the long run, and won't take me long to do | 22:06 |
efried | why does the placement fixture need to register opts ever? | 22:06 |
cdent | because it has to use opts in order to start placement | 22:06 |
efried | I guess when tests go after opts, the defaults need to be there. | 22:06 |
efried | and that | 22:06 |
cdent | unfortunately the way oslo_config works, it has to know about stuff | 22:07 |
cdent | (good and bads to that) | 22:07 |
efried | 3 today, or should we 1 to unblock and then 3? | 22:07 |
cdent | the mode the fixture has now is "don't make the caller think, if possible" | 22:07 |
cdent | I'm happy with just 3 if everyone else is | 22:08 |
cdent | but if you want to unblock quicker, then 1 and then 3 | 22:08 |
efried | yeah, let's merge 1 and you can put 3 on top and include unrevert in it? | 22:08 |
cdent | I wanted to be able to find a version of 2, but that test is already so hairy I don't think it is worth | 22:09 |
cdent | sure | 22:09 |
cdent | feel free to push the revert through | 22:09 |
efried | cdent, mriedem, melwitt: fast-approved https://review.openstack.org/#/c/645014/ | 22:10 |
efried | and then mriedem respun and did same, neat | 22:10 |
mriedem | i added the bug tag | 22:10 |
efried | yup, ++ | 22:11 |
*** pcaruana has quit IRC | 22:11 | |
*** marst has quit IRC | 22:12 | |
openstackgerrit | Eric Fried proposed openstack/nova master: DNM: Trying a different strategy for tests https://review.openstack.org/645026 | 22:12 |
*** mlavalle has quit IRC | 22:13 | |
*** mvkr has joined #openstack-nova | 22:16 | |
*** awalende has quit IRC | 22:18 | |
*** awalende has joined #openstack-nova | 22:18 | |
melwitt | efried: ack, thanks | 22:19 |
*** BjoernT has quit IRC | 22:22 | |
*** awalende has quit IRC | 22:23 | |
mriedem | well now i'm depressed and have a 2 hour call in 3 hours so it's time to leave | 22:25 |
*** mriedem is now known as mriedem_away | 22:25 | |
*** BjoernT has joined #openstack-nova | 22:27 | |
NobodyCam | anyone have any pointers to stacking down instances stuck in scheduling .. I set nova* to debug mode and don't see any errors jumping out | 22:35 |
NobodyCam | s/stracking/tracking | 22:36 |
openstackgerrit | Chris Dent proposed openstack/nova master: Don't register placement opts mutiple times in a test https://review.openstack.org/645033 | 22:36 |
cdent | mriedem_away, efried ^ that fixes the nova side and depends-on the placement side fix | 22:37 |
NobodyCam | I do see this in the compute log: | 22:39 |
NobodyCam | Instance 7d8f61e6-155c-47a9-9d35-95939b29d487 has been scheduled to this compute host, the scheduler has made an allocation against this compute node but the instance has yet to start. Skipping heal of allocation: {u'resources': {u'MEMORY_MB': 1024, u'VCPU': 1, u'DISK_GB': 20}}. _remove_deleted_instances_allocations /openstack/venvs/nova-18.1.5.dev5/lib/python2.7/site-packages/nova/compute/resource_tracker.py:1355 | 22:39 |
*** BjoernT has quit IRC | 22:50 | |
*** IvensZambrano has quit IRC | 22:52 | |
*** rcernin has joined #openstack-nova | 22:57 | |
*** rcernin has quit IRC | 22:58 | |
*** rcernin has joined #openstack-nova | 22:58 | |
*** itlinux has quit IRC | 22:59 | |
*** itlinux has joined #openstack-nova | 23:00 | |
*** itlinux has quit IRC | 23:08 | |
*** itlinux has joined #openstack-nova | 23:09 | |
*** tbachman has quit IRC | 23:15 | |
aspiers | cdent: OK, now you are not just ahead of me but downright telepathic. I was about to report that placement issue... | 23:16 |
cdent | aspiers: which one? | 23:17 |
aspiers | the option registering | 23:17 |
cdent | that's mriedem_away's psychic powers not mine | 23:17 |
aspiers | OK, so you just fixed it :) | 23:18 |
* cdent hopes | 23:19 | |
aspiers | Either way it's nice when things get fixed even before I get a chance to report them | 23:19 |
aspiers | haha | 23:19 |
cdent | it's all smoke and mirrors. There's an openstack cabal where people like efried, mriedem_away, me place latent bugs into the code that we can then fix quickly, making ourselves appear heroic and super insightful | 23:20 |
*** luksky has quit IRC | 23:20 | |
aspiers | That's dastardly cunning | 23:20 |
cdent | the chaos that you see isn't figuring out the solution for the bug, it's figuring out which bug, of the many that we have caused, is being revealed this time | 23:21 |
aspiers | I'd hope our govt was doing the same, but alas they're not | 23:21 |
cdent | heh | 23:21 |
*** awalende has joined #openstack-nova | 23:21 | |
cdent | it's...shocking | 23:22 |
aspiers | damn right | 23:22 |
*** hongbin has quit IRC | 23:23 | |
* cdent wanders off to not think about that or this for a while | 23:24 | |
*** mriedem_away has quit IRC | 23:28 | |
*** mriedem has joined #openstack-nova | 23:29 | |
*** tosky has quit IRC | 23:31 | |
mriedem | efried: cdent: thanks got both | 23:32 |
*** awalende has quit IRC | 23:41 | |
mriedem | sorrison: if you can't make the next nova meeting, you could add https://bugs.launchpad.net/nova/+bug/1819568 to the open discussion agenda as a potential specless blueprint | 23:55 |
openstack | Launchpad bug 1819568 in OpenStack Compute (nova) "RFE: network_data.json doesn't contain information about floating IPs" [Wishlist,Opinion] | 23:55 |
*** artom has joined #openstack-nova | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!