Thursday, 2019-04-04

*** awalende has joined #openstack-nova00:00
*** tbachman has joined #openstack-nova00:01
*** wolverineav has quit IRC00:01
*** wolverineav has joined #openstack-nova00:01
*** wolverineav has quit IRC00:04
*** awalende has quit IRC00:04
*** wolverineav has joined #openstack-nova00:05
*** tetsuro has joined #openstack-nova00:08
*** wolverineav has quit IRC00:10
*** tbachman has quit IRC00:15
*** alex_xu has quit IRC00:27
*** tbachman has joined #openstack-nova00:27
*** bbowen has joined #openstack-nova00:32
openstackgerritMerged openstack/nova master: Don't warn on network-vif-unplugged event during live migration  https://review.openstack.org/64287700:32
*** bbowen__ has quit IRC00:33
*** wolverineav has joined #openstack-nova00:35
*** igordc has quit IRC00:36
mriedemthis uh, seems not so necessary https://github.com/openstack/nova/commit/70c7ba7324cf47179d978b4073545e3837d4fd24#diff-12951ec32bc2b8cae6ea1933599a3dbcR33400:37
mriedemand potentially a security issue00:41
mriedemefried: melwitt: ^ is new in stein so if it's something we shouldn't be exposing in the notifications we should probably think about that for rc200:43
sean-k-mooneywait we send the db connection field in the cellmapping notifcation?00:47
mriedemapparently00:47
mriedemand transport_url00:47
sean-k-mooneyis that now the templated url?00:47
openstackgerritMerged openstack/nova master: Drop migrate_keypairs_to_api_db data migration  https://review.openstack.org/64964800:47
openstackgerritMerged openstack/nova master: Add functional test for the JsonFilter  https://review.openstack.org/64781100:47
openstackgerritMerged openstack/nova master: api-ref: document ordering for instance actions and events  https://review.openstack.org/64974800:47
openstackgerritMerged openstack/nova master: api-ref: fix description of os-server-external-events 'events' param  https://review.openstack.org/64975000:47
openstackgerritMerged openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6)  https://review.openstack.org/57411300:48
sean-k-mooneyhehe a lot of nova patches were in the last job run00:48
sean-k-mooneyanyway if its the tempalted url its may not be an issue but ya if its the actully connetion sting that is bad00:49
mriedemit does not need to be templated00:50
mriedemhttps://docs.openstack.org/nova/latest/user/cells.html#template-urls-in-cell-mappings00:50
mriedemeven if it was templated, it would be the full url when pulled out of the CellMapping object attribute00:51
sean-k-mooney:(00:52
sean-k-mooneythe patch mentioned it was transfroming the notificaiton to the versioned form00:52
*** luksky has quit IRC00:52
sean-k-mooneywas this previouly sent via the unversioned endpoint00:52
mriedemi doubt it00:53
sean-k-mooneyok so it is a regression in stien and i agree it a security concern too.00:53
sean-k-mooneyhow did you come across it00:53
mriedemthe unversioned notification sent RequestSpec.to_legacy_request_spec_dict()00:54
mriedemtssurya -1ed a change of mine saying i should add more stuff to that notification since i added a new field to the Destination object00:54
mriedemhttps://review.openstack.org/#/c/614035/00:55
sean-k-mooneymriedem: ah ok i similarly modifed a field in one of my patches and it ended up changin the image metadata notificaion00:55
sean-k-mooneywhich i undersand in a way but i also was confused by00:55
sean-k-mooneyit seams that we not have to version some object when field in an objec support new values00:55
*** wolverineav has quit IRC00:55
sean-k-mooneypreviousl we did not version bump object for compostion00:56
sean-k-mooneyonly when fields were added or removed00:56
*** wolverineav has joined #openstack-nova00:56
mriedemgibi_off: stephenfin: https://review.openstack.org/#/c/508506/28/nova/notifications/objects/request_spec.py@334 - if we don't need those i don't tihnk we should be sending them out of nova on the notification bus00:56
*** ileixe has joined #openstack-nova00:57
*** wolverineav has quit IRC01:00
*** tetsuro has quit IRC01:01
*** tetsuro_ has joined #openstack-nova01:01
sean-k-mooneymriedem: do we want to even include the cell here https://review.openstack.org/#/c/508506/28/nova/notifications/objects/request_spec.py@28401:02
mriedemidk, the legacy notification for select_destinations didn't send all of this stuff01:02
mriedemso i don't know why it was all added01:02
mriedemthe legacy notification sent a legacy more minimal view of the request spec01:03
mriedemthis version is everything01:03
mriedemsending the name/uuid of the cell is meh to me01:03
mriedemsending the URLs with credentials to connect to the cell...that's a bad idea01:04
sean-k-mooneyya i was just looking at what the to_legacy_request_spec_dict function did01:04
sean-k-mooneyi would proably change 'cell': fields.ObjectField('CellMappingPayload', nullable=True),01:04
mriedemwell i threw this on the RC2 etherpad so i guess can wait for others to look and provide an opinion01:05
sean-k-mooneyto 'cell': fields.UUIDFiled(nullable=True),01:05
sean-k-mooneyand then drop the CellMappingPayload object entirely01:05
sean-k-mooneyi think we require the host to be unique across all cells anyway though so the cell is uudi is not really needed01:06
mriedemi'm dropping off01:09
*** mriedem has quit IRC01:09
sean-k-mooneyo/01:09
*** tiendc has joined #openstack-nova01:19
openstackgerritTetsuro Nakamura proposed openstack/nova master: Pass node uuid to new Destination.node_uuid  https://review.openstack.org/64953301:45
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add in_tree field to RequestGroup object  https://review.openstack.org/64953401:45
openstackgerritTetsuro Nakamura proposed openstack/nova master: node_uuid from RequestSpec to ResourceRequest  https://review.openstack.org/64953501:45
*** wolverineav has joined #openstack-nova02:03
*** whoami-rajat has joined #openstack-nova02:03
*** wolverineav has quit IRC02:08
*** tinwood has quit IRC02:10
*** tinwood has joined #openstack-nova02:12
*** hongbin has joined #openstack-nova02:12
*** BjoernT has joined #openstack-nova02:15
ileixeHi forks.02:20
openstackgerritMatt Riedemann proposed openstack/nova master: Obfuscate CellMappingPayload database_connection and transport_url  https://review.openstack.org/64977502:20
ileixeIs this bp https://review.openstack.org/#/c/599598/ abonded at all?02:20
ileixeabandoned*02:20
ileixeWe need this functionality a lot, so I wonder about it.02:21
openstackgerritMatt Riedemann proposed openstack/nova master: Obfuscate CellMappingPayload database_connection and transport_url  https://review.openstack.org/64977502:22
*** mriedem has joined #openstack-nova02:23
mriedemmelwitt: added you and others https://review.openstack.org/#/c/649775/02:24
mriedemwip until people chew on the alternatives02:24
openstackgerritMatt Riedemann proposed openstack/nova master: Remove MIN_COMPUTE_MULTIATTACH conditions in API  https://review.openstack.org/64975702:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add nova-status upgrade check for minimum required cinder API version  https://review.openstack.org/64975902:27
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Drop pre-cinder 3.44 version compatibility  https://review.openstack.org/62106102:27
*** ileixe has quit IRC02:29
*** markvoelker has joined #openstack-nova02:29
*** mriedem has quit IRC02:29
openstackgerritzhufl proposed openstack/nova master: Remove reading xvpconf_template in xvp.py  https://review.openstack.org/64977702:31
openstackgerritBhagyashri Shewale proposed openstack/nova master: Ignore root_gb for BFV in simple tenant usage API  https://review.openstack.org/61262602:36
*** zhubx has quit IRC02:36
openstackgerritGhanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup  https://review.openstack.org/60396902:37
openstackgerritTakashi NATSUME proposed openstack/nova master: Change a log level for overwriting allocation  https://review.openstack.org/64978802:44
*** psachin has joined #openstack-nova02:44
*** markvoelker has quit IRC02:59
*** zhubx has joined #openstack-nova03:16
*** samueldmq has quit IRC03:16
*** wolverineav has joined #openstack-nova03:20
*** wolverineav has quit IRC03:25
openstackgerritAlex Xu proposed openstack/nova master: [DNM] debug the LM test  https://review.openstack.org/64980703:26
*** alex_xu has joined #openstack-nova03:28
*** BjoernT has quit IRC03:38
*** BjoernT has joined #openstack-nova03:44
*** BjoernT has quit IRC03:44
*** tetsuro_ has quit IRC03:50
*** tetsuro has joined #openstack-nova03:51
*** BjoernT has joined #openstack-nova03:52
*** hongbin has quit IRC03:52
*** markvoelker has joined #openstack-nova03:57
*** zhubx has quit IRC03:57
*** BjoernT has quit IRC04:00
*** zhubx has joined #openstack-nova04:03
*** udesale has joined #openstack-nova04:09
*** ceryx has quit IRC04:10
*** markvoelker has quit IRC04:29
openstackgerritJake Yip proposed openstack/nova master: Add --before to nova-manage db archive_deleted_rows  https://review.openstack.org/55675104:31
*** cfriesen has quit IRC04:33
*** erlon has joined #openstack-nova04:44
*** ileixe has joined #openstack-nova04:46
*** ricolin has joined #openstack-nova04:57
*** pcaruana has joined #openstack-nova04:58
*** lbragstad has quit IRC05:06
*** tetsuro has quit IRC05:09
*** ratailor has joined #openstack-nova05:12
*** tetsuro has joined #openstack-nova05:14
*** ccamacho has quit IRC05:22
*** bhagyashris_ has joined #openstack-nova05:23
*** krypto has joined #openstack-nova05:24
*** markvoelker has joined #openstack-nova05:27
*** shilpasd has quit IRC05:35
*** tetsuro_ has joined #openstack-nova05:38
*** tetsuro has quit IRC05:40
*** phasespace has quit IRC05:59
*** markvoelker has quit IRC06:00
*** tetsuro_ has quit IRC06:03
openstackgerritHuqiang Wang proposed openstack/nova-specs master: Separate the vCPUs into different pools based on priority  https://review.openstack.org/64988206:07
*** zhubx has quit IRC06:09
*** zhubx has joined #openstack-nova06:09
*** janki has joined #openstack-nova06:13
*** sridharg has joined #openstack-nova06:15
*** alex_xu has quit IRC06:15
*** Luzi has joined #openstack-nova06:18
*** slaweq has joined #openstack-nova06:21
*** dpawlik has joined #openstack-nova06:26
*** sidx64 has joined #openstack-nova06:30
*** erlon has quit IRC06:36
*** manjeets has quit IRC06:36
*** mdbooth_ has quit IRC06:45
*** rpittau|afk is now known as rpittau06:48
*** markvoelker has joined #openstack-nova06:57
*** tesseract has joined #openstack-nova07:09
*** ccamacho has joined #openstack-nova07:11
*** awalende has joined #openstack-nova07:13
*** awalende has quit IRC07:17
*** awalende has joined #openstack-nova07:18
*** wolverineav has joined #openstack-nova07:21
*** dims has quit IRC07:22
*** dims has joined #openstack-nova07:24
*** sidx64 has quit IRC07:25
*** wolverineav has quit IRC07:25
*** tosky has joined #openstack-nova07:26
*** helenafm has joined #openstack-nova07:27
*** markvoelker has quit IRC07:30
openstackgerritHuqiang Wang proposed openstack/nova-specs master: Separate the vCPUs into different pools based on priority  https://review.openstack.org/64988207:31
*** dims has quit IRC07:31
*** dims has joined #openstack-nova07:34
*** ralonsoh has joined #openstack-nova07:34
*** ralonsoh has quit IRC07:34
*** jistr is now known as jistr|afk07:35
*** ralonsoh has joined #openstack-nova07:37
*** krypto has quit IRC07:43
*** elod_off has quit IRC07:45
*** brinzhang has quit IRC07:50
*** brinzhang has joined #openstack-nova07:50
*** elod_off has joined #openstack-nova07:52
*** spsurya has joined #openstack-nova07:55
*** tssurya has joined #openstack-nova07:56
*** tkajinam has quit IRC08:22
*** dtantsur|afk is now known as dtantsur08:25
*** markvoelker has joined #openstack-nova08:28
openstackgerritzhaixiaojun proposed openstack/nova master: Update description of valid whitelist  https://review.openstack.org/64240308:30
openstackgerritzhaixiaojun proposed openstack/nova master: Update description of valid whitelist  https://review.openstack.org/64240308:33
kashyapIs there some 'tox' shortcut to build _just_ one releases's specs?08:34
kashyap`tox -e docs train` or something like that08:34
*** mdbooth has joined #openstack-nova08:42
openstackgerritMichael Still proposed openstack/nova master: Hacking N362: Don't abbrev/alias privsep import  https://review.openstack.org/64919008:44
openstackgerritMichael Still proposed openstack/nova master: Improve test coverage of nova.privsep.path.  https://review.openstack.org/64860108:44
openstackgerritMichael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs.  https://review.openstack.org/64860208:44
openstackgerritMichael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs, continued.  https://review.openstack.org/64860308:44
openstackgerritMichael Still proposed openstack/nova master: Add test coverage for nova.privsep.libvirt.  https://review.openstack.org/64861608:44
openstackgerritMichael Still proposed openstack/nova master: Add test coverage for nova.privsep.qemu.  https://review.openstack.org/64919108:44
openstackgerritMichael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement.  https://review.openstack.org/63543108:44
openstackgerritMichael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods.  https://review.openstack.org/63543308:44
openstackgerritMichael Still proposed openstack/nova master: Privsep the ebtables modification code.  https://review.openstack.org/63543508:44
openstackgerritMichael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep.  https://review.openstack.org/63543608:44
openstackgerritMichael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep.  https://review.openstack.org/63650808:44
openstackgerritMichael Still proposed openstack/nova master: Move dnsmasq restarts to privsep.  https://review.openstack.org/63928008:44
openstackgerritMichael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep.  https://review.openstack.org/63928108:44
openstackgerritMichael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep.  https://review.openstack.org/63928208:44
openstackgerritMichael Still proposed openstack/nova master: Move setting of device trust to privsep.  https://review.openstack.org/63928308:44
openstackgerritMichael Still proposed openstack/nova master: Move final bridge commands to privsep.  https://review.openstack.org/63958008:45
openstackgerritMichael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network.  https://review.openstack.org/63958108:45
openstackgerritMichael Still proposed openstack/nova master: We no longer need rootwrap.  https://review.openstack.org/55443808:45
openstackgerritzhaixiaojun proposed openstack/nova master: Update description of valid whitelist for non-admin user  https://review.openstack.org/64240308:49
*** krypto has joined #openstack-nova08:51
*** ricolin has quit IRC08:53
*** jaosorior has quit IRC08:54
*** markvoelker has quit IRC09:01
*** yan0s has joined #openstack-nova09:14
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Avoid building an encryptor when device_path isn't provided  https://review.openstack.org/64995109:17
*** mvkr has joined #openstack-nova09:24
stephenfinkashyap: Not that I'm aware of, no. It's all or nothing09:33
openstackgerritTakashi NATSUME proposed openstack/nova master: Change a log level for overwriting allocation  https://review.openstack.org/64978809:35
*** bhagyashris_ has quit IRC09:43
*** wolverineav has joined #openstack-nova09:45
openstackgerritBoxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule  https://review.openstack.org/64995309:47
*** wolverineav has quit IRC09:49
*** luksky has joined #openstack-nova09:51
*** markvoelker has joined #openstack-nova09:58
*** sidx64 has joined #openstack-nova10:00
*** brinzhang has quit IRC10:04
*** dtantsur is now known as dtantsur|brb10:07
*** awalende has quit IRC10:10
*** awalende has joined #openstack-nova10:11
*** sidx64 has quit IRC10:15
openstackgerritBoxiang Zhu proposed openstack/nova master: Use the functional test test_parallel_evacuate_with_server_group  https://review.openstack.org/64996310:21
*** bbowen has quit IRC10:21
*** sidx64 has joined #openstack-nova10:22
*** phasespace has joined #openstack-nova10:22
*** jistr|afk is now known as jistr10:23
*** awalende has quit IRC10:30
*** awalende has joined #openstack-nova10:30
*** awalende has quit IRC10:30
*** markvoelker has quit IRC10:31
*** awalende has joined #openstack-nova10:31
*** derekh has joined #openstack-nova10:35
*** sidx64 has quit IRC10:36
*** tbachman has quit IRC10:44
*** nicolasbock has joined #openstack-nova10:45
*** sapd1_x has joined #openstack-nova10:50
*** jaosorior has joined #openstack-nova10:52
*** ratailor has quit IRC10:54
*** udesale has quit IRC10:54
*** ratailor has joined #openstack-nova10:56
*** nicolasbock has quit IRC10:57
*** sidx64 has joined #openstack-nova10:59
*** jaosorior has quit IRC10:59
*** yan0s has quit IRC11:09
*** erlon has joined #openstack-nova11:14
*** zbr has quit IRC11:14
*** sidx64 has quit IRC11:14
*** sidx64 has joined #openstack-nova11:15
awalendefollowing problem: I had a semi-failed migration. The instance has been migrated to another host and is working so far. However, not everything has been adjusted in the db and I get the following log repeatedly in the source host:11:17
awalendeInstance a3fcb5a8-74e3-42f9-9659-428ffe710c19 has been moved to another host schwalm. There are allocations remaining against the source host that might need to be removed: {u'resources': {u'VCPU': 2, u'MEMOR11:17
awalendeY_MB': 2048, u'DISK_GB': 21}}11:17
*** cdent has joined #openstack-nova11:17
awalendeWhere can I find the responsible parts in the db to clean up this mess?11:18
*** sidx64 has quit IRC11:19
*** sidx64 has joined #openstack-nova11:20
*** nicolasbock has joined #openstack-nova11:20
*** helenafm has quit IRC11:22
tssuryaawalende: depending on the release you are running this would be the "allocations" table in the nova_api or placement database11:24
awalendeIt's queens :)11:24
tssuryayou could use the https://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-allocation-delete CLI to remove the allocation against the migration record on the source host11:24
tssuryaah if queens its nova_api database11:25
tssuryaallocations table11:25
tssuryaawalende: you should be able to find records for that migration_uuid as the consumer against the source resource_provider11:26
awalendeselect * from allocations where consumer_id='a3fcb5a8-74e3-42f9-9659-428ffe710c19';11:28
*** markvoelker has joined #openstack-nova11:28
awalendethis gave me 3 rows, so I simply have to overwrite the resource_provider_id with the id from the new host?11:28
tssuryaawalende: the consumer_id is name of your instance ? or the migration_uuid ?11:29
awalendeinstance id11:29
tssuryaah so these are the allocations against the new host for your instance11:29
awalendeah okay11:30
*** mvkr has quit IRC11:30
tssuryacould you verify by checking the resource_provider_id ? these three records should be the ones you should NOT delete11:30
tssuryawhat you should do is query with consumer_id=migration_uuid11:30
awalendeis there a smart way to find out the resource_provider_id of each computehost?11:30
*** bbowen has joined #openstack-nova11:31
*** zbr has joined #openstack-nova11:31
*** yan0s has joined #openstack-nova11:33
awalendeAh I believe I got it11:38
awalendeSo the 3 rows in my db still have the resource_provider_id from the "old" host11:39
tssuryaawalende: ah no allocations against new host ?11:39
awalendeFor now, I'm not finding anyone. As I mentioned before, I had to finish the failed migration manually by myself11:40
awalendesomething has been really messed up by this11:40
*** samueldmq has joined #openstack-nova11:40
tssuryaah ok that's bad then no allocations were formed against the target host and we don't know how far the migration went11:40
tssuryayea11:40
awalendefor example I had to manually transfer the swap partition disk11:41
openstackgerritLee Yarwood proposed openstack/nova master: Use migration_status during volume migrating and retyping  https://review.openstack.org/63722411:42
awalendeWould probably the best idea to scrap this instance completely, but my customer will try to assassinate me11:42
sean-k-mooneyjaypipes: thanks jay for your comments on https://review.openstack.org/#/c/620115/29 can you confim my understanding of what you want changed is correct11:42
*** sidx64 has quit IRC11:44
awalendebut anyway, thanks for the help tssurya. much appreciated11:44
tssuryaawalende: np :)11:45
*** tiendc has quit IRC11:45
*** erlon_ has joined #openstack-nova11:45
*** sidx64 has joined #openstack-nova11:46
*** sidx64 has quit IRC11:47
*** sidx64 has joined #openstack-nova11:48
*** ratailor has quit IRC11:49
*** dtantsur|brb is now known as dtantsur11:57
awalendeha, it worked11:58
tssuryaawalende: you just changed the allocations manually ? :)11:58
awalendeexactly, the warnings in the compute logs went away and the instance is still working :D11:59
tssurya:) let's hope for the best then12:00
*** mvkr has joined #openstack-nova12:00
awalendefingers crossed12:00
*** markvoelker has quit IRC12:02
jaypipessean-k-mooney: I really don't know why a new "utils.lock" variable was introduced.12:03
jaypipessean-k-mooney: instead of just using utils.synchronized12:03
*** phasespace has quit IRC12:03
sean-k-mooneyya neither do i which is why i was going to change it as you suggested12:04
openstackgerritLee Yarwood proposed openstack/nova master: compute: Reject resize requests when the source host is down  https://review.openstack.org/62348912:04
*** tbachman has joined #openstack-nova12:05
jaypipessean-k-mooney: answered on review12:06
sean-k-mooneyjaypipes: thanks12:06
jaypipessean-k-mooney: remove the utils.lock thing and I'm +212:06
sean-k-mooneyperfect ill start work on that now so. if you have time to review the follow up patch its pretty short but if not that ok too.12:07
jaypipessean-k-mooney: yep, already on it.12:07
jaypipessean-k-mooney: I had to spend time this morning correcting your comma misuse. :P12:08
jaypipessean-k-mooney: and don't get me started on your abuse of the apostrophe.12:08
sean-k-mooney:) i hear punction is a think people find useful.12:09
sean-k-mooneyisnt my use of it novel12:09
* jaypipes goes to buy sean-k-mooney a copy of "Elements of Style" as a gift for Denver PTG.12:09
jaypipes"punction", eh? :)12:09
sean-k-mooneypunctuation, i was 72% there.12:12
artom... that's how they take cerebro-spinal fluid samples, no?12:12
*** jamesdenton has quit IRC12:13
*** brinzhang has joined #openstack-nova12:21
*** yan0s has quit IRC12:22
sean-k-mooneyi may have lost a tab in firefox and realised its still open in one of the 14 firefox windows i currently have open.12:32
sean-k-mooneyproably12:32
openstackgerritStephen Finucane proposed openstack/nova master: Remove DiffieHellmann tests  https://review.openstack.org/64997412:34
*** yan0s has joined #openstack-nova12:37
*** sidx64 has quit IRC12:38
*** sidx64 has joined #openstack-nova12:39
*** krypto has quit IRC12:39
*** Luzi has quit IRC12:48
*** mriedem has joined #openstack-nova12:54
*** lbragstad has joined #openstack-nova12:59
*** alex_xu has joined #openstack-nova13:00
*** dklyle has quit IRC13:02
gansohi alex_xu, could you please take a look at https://review.openstack.org/#/c/647566 ? The other part of that bugfix has already merged, we are waiting on this fix to land so we can backport. Thanks in advance!13:02
alex_xuganso: let me check13:03
adriancsean-k-mooney: Hey, are you planning to work on : https://review.openstack.org/#/c/620115/29 ?13:03
openstackgerritAlex Xu proposed openstack/nova master: [DNM] debug the LM test  https://review.openstack.org/64980713:04
sean-k-mooneyim in a meeting for the next hour but after13:04
sean-k-mooneyif you want to do it fell free13:05
*** udesale has joined #openstack-nova13:05
efriedileixe: It appears to be abandoned. It looks like dansmith was going to make it work some other way, you may want to follow up with him.13:06
adriancsean-k-mooney, jaypipes : also replied on the utils.lock()13:06
efriedileixe: I also seem to recall there was going to be a forum session following on from one we had in Berlin on this topic...13:06
efriedileixe: https://www.openstack.org/summit/denver-2019/summit-schedule/events/23675/change-ownership-of-resources-followup13:07
*** Luzi has joined #openstack-nova13:07
adriancsean-k-mooney: have some meetings and prior engagements will probably get to it on Sunday.13:08
*** davidsha has joined #openstack-nova13:08
sean-k-mooneyadrianc: ill read your comments if you have no objections to useing syncronised instead of util.lock then i can make the changes today13:08
adriancsean-k-mooney: well i intentionally defined the utils.lock() so ill be able to use as a context manager and save the wrapping13:09
openstackgerritTakashi NATSUME proposed openstack/nova master: Change a log level for overwriting allocation  https://review.openstack.org/64978813:09
adriancsean-k-mooney: but if decorators are preferred then I have no objection.13:10
*** gaoyan has joined #openstack-nova13:12
*** itlinux has quit IRC13:12
mriedemanyone hit this grenade failure yet? http://logs.openstack.org/12/648912/4/check/grenade-py3/19a6549/logs/grenade.sh.txt.gz#_2019-04-03_03_50_29_32413:13
mriedemefried: cdent: ^?13:14
* cdent reads13:14
cdentmriedem: I remember hitting that some months ago and thinking I fixed it13:15
cdentIt happens when the openstack client is reinstalled, at a different python version, so the plugins are no longer visible13:15
mriedemhmm, only happening on stable/stein and master http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22cval%3D'openstack%3A%20'%5C%5C''resource%20provider%20inventory%20show%20openstack%3A%20VCPU%20-f%20value%20-c%20total'%5C%5C''%20is%20not%20an%20openstack%20command.%20See%20'%5C%5C''openstack%20--help'%5C%5C''.%5C%22%20AND%20tags%3A%5C%22console%5C%22&from=7d13:16
mriedemgrenade was maybe branched?13:16
cdentso, somewhere in that log will be something causing whichever openstack command is on the path to become a different one13:17
cdentthis was the original bug https://bugs.launchpad.net/grenade/+bug/180515613:18
openstackLaunchpad bug 1805156 in grenade "In a python3 grenade run, openstack client plugins are lost after swift install" [Undecided,Fix released] - Assigned to Chris Dent (cdent)13:18
openstackgerritHamdy Khader proposed openstack/nova master: Do not perform port update in case of baremetal instance.  https://review.openstack.org/64934513:18
mriedemcdent: looks like osc-placement is installed into py2.7 and python-openstackclient is installed into py3.613:18
efriedmriedem: Yes, I was looking at that last night.13:19
efriedokay, looks like you guys are further along than I got13:20
mriedemWARNING: Did not find python 3 classifier for remote package osc-placement13:20
mriedemthat's why osc-placement isn't installed on py313:20
cdentmriedem: swift is reinstalling python-openstackclient here: http://logs.openstack.org/12/648912/4/check/grenade-py3/19a6549/logs/grenade.sh.txt.gz#_2019-04-03_03_26_57_82013:20
mriedemhttps://github.com/openstack/osc-placement/blob/master/setup.cfg#L1813:21
mriedemassuming this is a rax-dfw node...13:21
cdentare you sure that's more than a warning?13:22
mriedemthat makes me think it's bug 182089213:23
openstackbug 1820892 in devstack "Intermittent "Error starting thread.: ModuleNotFoundError: No module named 'etcd3gw'" in grenade-py3 jobs since March 14" [High,In progress] https://launchpad.net/bugs/1820892 - Assigned to Dr. Jens Harbott (j-harbott)13:23
mriedemdevstack failing to parse the py3 classifier on pypi for rax-dfw nodes and thinks it's a py2.7 package and installs there13:23
mriedemhttps://review.openstack.org/#/c/649096/13:23
cdentI agree with that fix13:24
*** Sundar has joined #openstack-nova13:24
cdentI'll fix osc-placement in the meantime13:25
mriedemosc-placement looks OK, except it doesn't have a 3.6 classifier, but devstack isn't looking for that13:25
fricklercdent: mriedem: hmm, maybe there's more to it with the "swift reinstalling osc" thing. might be swift shouldn't be installed at all for a py3 job as long as they don't do py313:25
cdentfrickler: I've wondered that too13:26
mriedemfrickler: that would be a pretty big change to the integrated gate i think since by default swift backs glance13:26
mriedemin devstack i mean13:26
fricklerbecause some time soon we also might want to make sure that py3 jobs are able to run without py2 at all13:26
mriedemthis was a rax-dfw node as well btw13:27
mriedemit's something about the networks to pypi for those nodes13:27
cdentthat's...bizarre?13:28
fricklerhttps://review.openstack.org/#/c/649096/ should help with that. if we can get it to pass all those unstable tests, that is13:28
*** sridharg has quit IRC13:29
cdentmriedem: is there anything I need to do here, or is the situation in hand?13:30
*** sidx64 has quit IRC13:30
mriedemcdent: if the underlying issue is the same bug that ^ is fixing then i think we're ok13:32
efriedmriedem: if we're trying to cut RC2 today, we need to resolve https://review.openstack.org/#/c/649775/ ASAP, right?13:33
efriedWhat's the next step there?13:33
mriedemefried: i'd like input from you and dansmith on that one, seems gibi thinks bumping the major and dropping the fields is better (alternative 1) and i tend to agree13:34
mriedemi wrote that patch before bed in haste13:34
*** Luzi has quit IRC13:34
mriedemtaking my kid to the bus stop13:34
efriedmriedem: I've only skimmed, but was there a concern that the malicious user would be able to opt into the insecure version? and how was that allayed?13:34
*** sidx64 has joined #openstack-nova13:35
efriedI'll read it more deeply here...13:35
dansmiththose fields have no place in a notification, best I can tell13:35
*** Luzi has joined #openstack-nova13:37
efrieddansmith: I think that's agreed; the question is just whether we can get away with removing them from the existing version since nobody's using it yet, or if we need a new version13:38
efriedin which case can we still get hacked by people asking for the old one13:38
dansmiththe *only* reason to do the 1.1 version is if we really want to backport that or something13:39
dansmithbut since, as matt said on the review, the user doesn't get to choose what they get, I think it'd be better to signal "no, these really aren't going to be in your notification" with a major version bump13:40
dansmithwhat I meant by "want to backport" is "want to backport without the appearance of a major bump and breaking change"13:40
efriedthere's not like a way to spoof a client asking for the old version?13:41
dansmithbut I don't think we should do that13:41
dansmithyou don't ask not notification versions13:41
dansmithyou get what you get13:41
dansmiththe version is just a signal to tell you something has changed13:41
efriedokay, neat. Then I'm on board.13:41
dansmithit's not like objects where we try to backport a version to the one you want13:41
*** BjoernT has joined #openstack-nova13:42
efriedcool13:43
*** BjoernT has quit IRC13:43
*** sidx64 has quit IRC13:44
*** awalende has quit IRC13:44
mriedemok i'll bump the major and drop the fields13:45
mriedemdo we still by default emit both legacy and versioned....13:45
mriedemyup13:46
mriedemhttps://docs.openstack.org/nova/latest/configuration/config.html#notifications.notification_format13:46
*** wolverineav has joined #openstack-nova13:46
mriedemthe amount of object translation work to build these payloads is likely a detriment to scheduling performance as wel13:46
mriedem*well13:46
mriedemanywho, that's a different known issue13:46
dansmithmriedem: the base object has some version that increments with each subclass change?13:49
dansmithoh, nm13:49
dansmithevent_type13:49
dansmithwhich won't need to change with this13:49
*** wolverineav has quit IRC13:50
*** spsurya has quit IRC13:51
*** awalende has joined #openstack-nova13:52
*** altlogbot_3 has quit IRC13:55
efriedNova meeting in five minutes in #openstack-meeting13:55
*** awalende has quit IRC13:56
*** awaugama has joined #openstack-nova13:58
*** BjoernT has joined #openstack-nova14:01
*** ivve has joined #openstack-nova14:01
openstackgerritMatt Riedemann proposed openstack/nova master: Remove CellMappingPayload database_connection and transport_url fields  https://review.openstack.org/64977514:03
mriedemgibi_off: stephenfin: dansmith: melwitt: efried: ^14:03
*** imacdonn has quit IRC14:03
stephenfinack14:03
efriedthx mriedem14:03
*** amodi has joined #openstack-nova14:04
*** munimeha1 has joined #openstack-nova14:05
*** udesale has quit IRC14:06
*** udesale has joined #openstack-nova14:07
*** udesale has quit IRC14:11
*** udesale has joined #openstack-nova14:11
*** gaoyan has quit IRC14:14
openstackgerritStephen Finucane proposed openstack/nova master: devstack: Remove 'tempest-dsvm-tempest-xen-rc'  https://review.openstack.org/65001814:16
*** mlavalle has joined #openstack-nova14:16
*** janki has quit IRC14:17
*** awalende has joined #openstack-nova14:19
openstackgerritMatt Riedemann proposed openstack/nova master: Add docs on what not to include in notifications  https://review.openstack.org/65002014:22
*** dpawlik has quit IRC14:22
*** awalende has quit IRC14:23
sean-k-mooneyjaypipes: looking at adrianc responce https://review.openstack.org/#/c/620115/29/nova/compute/manager.py@7193 i think its a resonable argument but im also happy to create the new function and use the synchronized decorator.14:27
sean-k-mooneyill leave the decission up to you. the current decorator cant be used as a context manager but i think that could be added in the future to oslo concurancy14:29
sean-k-mooneyi think we would jsut have to change this return to a yeild https://github.com/openstack/oslo.concurrency/blob/master/oslo_concurrency/lockutils.py#L32814:30
sean-k-mooneyand add the contextlib.contextmanager decorator https://docs.python.org/3/library/contextlib.html#contextlib.contextmanager14:31
*** itlinux has joined #openstack-nova14:32
sean-k-mooneyits something i need to tink about but its a sepreate form this change14:32
*** itlinux has quit IRC14:32
*** Luzi has quit IRC14:34
mriedemefried: i shared a link to those charts i mentioned, you can peruse them at your leisure and if you think they are fine as further reading (albeit targeted topics) i can make them public and share on the ML or something14:42
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: Remove CellMappingPayload database_connection and transport_url fields  https://review.openstack.org/65004314:47
efriedmriedem: thank you.14:47
*** BjoernT has quit IRC14:47
*** itlinux has joined #openstack-nova14:48
*** mvkr has quit IRC14:48
*** itlinux has quit IRC14:49
*** itlinux has joined #openstack-nova14:51
*** Sundar has quit IRC14:53
*** BjoernT has joined #openstack-nova14:56
*** hongbin has joined #openstack-nova14:59
*** BjoernT has quit IRC15:01
*** takashin has left #openstack-nova15:01
*** BjoernT has joined #openstack-nova15:02
*** cfriesen has joined #openstack-nova15:03
*** jamesdenton has joined #openstack-nova15:10
mriedemhmm, because of that recent devstack change to add a 2nd shared public network we're always getting this in n-cpu logs during tempest runs now15:16
mriedemhttp://logs.openstack.org/58/637058/15/check/nova-next/f4e8140/logs/screen-n-cpu.txt.gz?level=TRACE#_Apr_04_00_07_20_96871915:16
mriedemseems that should not trace, nor be an error really - the user made a bad request essentially but we catch it in compute rather than the api15:16
*** yan0s has quit IRC15:17
mriedemyeah it's just a 400 INFO response in the api http://logs.openstack.org/58/637058/15/check/nova-next/f4e8140/logs/screen-n-api.txt#_Apr_04_00_07_20_97538015:18
*** awaugama has quit IRC15:19
mriedemhuh surprising we even get that far, the request is empty Body: {"interfaceAttachment": {}}15:20
*** awaugama has joined #openstack-nova15:23
mriedemhttps://bugs.launchpad.net/nova/+bug/1823198 is anyone has opinions15:25
openstackLaunchpad bug 1823198 in OpenStack Compute (nova) "NetworkAmbiguous traceback in nova-compute logs even though it's a user error" [Low,Triaged]15:25
mriedem*if15:25
*** awaugama has quit IRC15:26
*** awaugama has joined #openstack-nova15:26
*** dklyle has joined #openstack-nova15:27
*** erlon has quit IRC15:29
*** udesale has quit IRC15:32
*** gyee has joined #openstack-nova15:43
*** brinzhang has quit IRC15:45
*** tssurya has quit IRC15:52
openstackgerritMatt Riedemann proposed openstack/nova master: Drop pre-cinder 3.44 version compatibility  https://review.openstack.org/62106115:53
efrieddansmith: You around to hit https://review.openstack.org/#/c/649775/ ?15:53
dansmithI will, I'm just about to finish my two hours of morning calls15:54
efriedcool, thanks.15:54
*** efried is now known as efried_mtg15:54
*** Sundar has joined #openstack-nova15:54
*** hongbin has quit IRC15:57
*** hongbin has joined #openstack-nova15:58
*** hongbin has quit IRC16:00
gansoalex_xu: thanks for the +W! =)16:01
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: Don't warn on network-vif-unplugged event during live migration  https://review.openstack.org/65006016:03
*** hongbin has joined #openstack-nova16:12
*** BjoernT has quit IRC16:17
*** awaugama has quit IRC16:20
*** tbachman has quit IRC16:22
*** sapd1_x has quit IRC16:24
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: prevent common kwargs from glance client failure  https://review.openstack.org/65006416:25
*** dpawlik has joined #openstack-nova16:25
*** tbachman has joined #openstack-nova16:25
openstackgerritLee Yarwood proposed openstack/nova stable/queens: prevent common kwargs from glance client failure  https://review.openstack.org/65006516:25
*** awaugama has joined #openstack-nova16:32
*** awaugama is now known as awaugama_lunch16:32
*** igordc has joined #openstack-nova16:33
*** dpawlik has quit IRC16:38
*** tosky has quit IRC16:43
*** rpittau is now known as rpittau|afk16:44
*** itlinux has quit IRC16:45
*** itlinux has joined #openstack-nova16:47
*** tbachman has quit IRC16:51
*** itlinux has quit IRC16:54
*** itlinux has joined #openstack-nova16:55
*** awaugama_lunch is now known as awaugama16:56
*** ccamacho has quit IRC16:58
*** itlinux has quit IRC16:59
*** tbachman has joined #openstack-nova16:59
*** itlinux has joined #openstack-nova17:00
*** dtantsur is now known as dtantsur|afk17:00
*** davidsha has quit IRC17:03
openstackgerritMatt Riedemann proposed openstack/nova master: Handle Invalid exceptions as expected in attach_interface  https://review.openstack.org/65007717:12
*** derekh has quit IRC17:18
*** imacdonn has joined #openstack-nova17:27
*** spsurya has joined #openstack-nova17:37
*** gmann is now known as gmann_afk17:44
*** wolverineav has joined #openstack-nova17:45
*** wolverineav has quit IRC17:45
*** wolverineav has joined #openstack-nova17:45
*** ralonsoh has quit IRC17:49
*** munimeha1 has quit IRC17:50
*** BjoernT has joined #openstack-nova17:59
*** wolverineav has quit IRC18:01
*** wolverineav has joined #openstack-nova18:02
*** wolverineav has quit IRC18:04
*** wolverineav has joined #openstack-nova18:04
*** erlon_ has quit IRC18:07
*** derekh has joined #openstack-nova18:09
*** derekh has quit IRC18:10
*** BjoernT_ has joined #openstack-nova18:22
*** BjoernT has quit IRC18:24
*** psachin has quit IRC18:28
openstackgerritAdrian Chiris proposed openstack/nova master: Move get_pci_mapping_for_migration to MigrationContext  https://review.openstack.org/64302318:32
openstackgerritAdrian Chiris proposed openstack/nova master: Allow driver to properly unplug VIFs on destination on confirm resize  https://review.openstack.org/64302418:32
openstackgerritMatt Riedemann proposed openstack/nova master: Do not log a warning about not using compute monitors  https://review.openstack.org/65009218:33
mriedemjaypipes: i know you love compute monitors ^18:33
mriedemhttp://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Excluding%20nova.compute.monitors.cpu%20monitor%20virt_driver.%20Not%20in%20the%20list%20of%20enabled%20monitors%20(CONF.compute_monitors).%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22&from=7d18:33
*** owalsh has quit IRC18:34
*** owalsh_ has joined #openstack-nova18:34
*** itlinux has quit IRC18:35
* jaypipes gets out the red pen18:38
*** owalsh_ has quit IRC18:39
*** cdent has quit IRC18:40
*** owalsh has joined #openstack-nova18:41
*** tbachman has quit IRC18:44
*** mdbooth_ has joined #openstack-nova18:44
*** jmlowe has quit IRC18:44
*** mdbooth has quit IRC18:47
*** itlinux has joined #openstack-nova18:49
openstackgerritMatt Riedemann proposed openstack/nova master: Handle PortLimitExceeded in POST /servers/{server_id}/os-interface  https://review.openstack.org/65009718:49
*** BjoernT has joined #openstack-nova18:52
openstackgerritMatt Riedemann proposed openstack/nova master: Handle PortLimitExceeded in POST /servers/{server_id}/os-interface  https://review.openstack.org/65009718:52
*** BjoernT_ has quit IRC18:53
*** eharney has quit IRC18:55
*** eharney has joined #openstack-nova18:58
*** jmlowe has joined #openstack-nova18:59
*** wolverineav has quit IRC19:02
*** mmethot has joined #openstack-nova19:03
*** wolverineav has joined #openstack-nova19:03
*** wolverineav has quit IRC19:07
mriedemmelwitt: have you seen this? intermittent unit test failure http://logs.openstack.org/06/641806/7/check/openstack-tox-lower-constraints/1f1fce6/job-output.txt.gz#_2019-04-03_22_36_18_97509619:08
*** tbachman has joined #openstack-nova19:08
*** BjoernT has quit IRC19:11
mriedemlooks like this unit test starts up a conductor service using the ServiceFixture which calls self.addCleanup(self.service.kill)19:12
melwittno, haven't seen that before. I've seen the error before, I remember helping to fix a bug for that way back when19:13
melwittthis one https://review.openstack.org/55509319:14
melwittand in the fail you linked, we're getting it during service.destroy() this time19:15
melwittwhich must mean in that flow somewhere we have a reader transaction context nested outside a writer transaction context19:15
mriedemyeah not sure, also doesn't really show up much in logstash19:18
mriedemso i guess i'll recheck and assume it's a fluke19:18
melwittlooking at the code, so far I don't see how the nesting could be happening19:18
*** owalsh_ has joined #openstack-nova19:25
*** owalsh has quit IRC19:25
*** itlinux has quit IRC19:33
*** tosky has joined #openstack-nova19:33
mriedemefried_mtg: these failures http://logs.openstack.org/13/621313/21/check/openstack-tox-py36/ba2c848/testr_results.html.gz definitely started spiking after 4/1 with https://github.com/openstack/nova/commit/e5269f2fbb773953266fccbfd9df3f75e351eeb919:33
*** BjoernT has joined #openstack-nova19:34
mriedemi wonder if removing kipsdist = True in tox.ini is contributing19:34
mriedemhttp://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22sqlalchemy.exc.InterfaceError%3A%20(pymysql.err.InterfaceError)%20(0%2C%20'')%5C%22%20AND%20tags%3A%5C%22console%5C%22&from=7d19:34
mriedem*skipsdist = True19:34
mriedemand it's always on  node provider:        limestone-regionone19:34
*** awaugama has quit IRC19:37
*** wolverineav has joined #openstack-nova19:38
*** tbachman has quit IRC19:38
*** owalsh has joined #openstack-nova19:39
*** owalsh_ has quit IRC19:40
*** wolverineav has quit IRC19:42
mriedemtox on the limestone node is 3.8.4 and on an ovh node that passes tox is 3.8.119:45
mriedempymysql is the same between them19:45
*** artom has quit IRC19:46
*** efried_mtg is now known as efried19:46
efriedmriedem: What can I do to help?19:47
mriedemhold me19:47
mriedembut not in a tap out kind of way19:47
mriedemi'm reporting a new bug and will push an e-r query19:47
efriedshould I push a change adding skipdist back and see what happens?19:48
mriedemidk, i wasn't involved in that lower-constraints fix so i don't know if that will screw up the lower-constraints job, but i guess you'd find out19:49
*** gmann_afk is now known as gmann19:49
efriedaccording to the commit message, cdent thought skipdist was "otherwise superfluous"19:49
efriedso hopefully that means it at least won't hurt anything.19:49
* efried tries...19:49
mriedemif lower-constraints needs usedevelop=false and skipsdist=false, it could just specify that explicitly19:49
efriedyuh19:49
mriedemusedevelop defaults to false also, so i'm not sure why the lower-constraints job is calling it out19:50
mriedemi'm currently being defeated by launchpad timeouts19:50
*** BjoernT has quit IRC19:52
openstackgerritEric Fried proposed openstack/nova master: DNM: Re-add skipsdist=True  https://review.openstack.org/65012319:53
efriedmriedem: ^ any way to get that to run on the offending node?19:53
mriedemnot that i know of19:53
mriedemunless there is a way to specify that in the zuul job definition19:54
mriedemfungi: ^19:54
mriedemquestion is can we restrict a change to only run on limestone-regionone nodes19:54
*** BjoernT has joined #openstack-nova19:55
mriedembtw this would explain the unit test job timeouts creeping up again19:56
mriedemb/c when this fails, i think there is some thread switch or something and the fixture just goes away and we timeout19:56
logan-i can provide a project to run it on in limestone-regionone19:57
logan-aside from setting up custom nodepool labels I don't think there is a way to set affinity in the job19:58
*** wolverineav has joined #openstack-nova19:58
openstackgerritMerged openstack/nova master: Remove CellMappingPayload database_connection and transport_url fields  https://review.openstack.org/64977519:59
openstackgerritMerged openstack/nova master: Add docs on what not to include in notifications  https://review.openstack.org/65002019:59
*** ttsiouts has joined #openstack-nova20:01
*** wolverineav has quit IRC20:03
*** wolverineav has joined #openstack-nova20:04
*** bbowen has quit IRC20:04
fungimriedem: efried: logan- is correct. we'd need special node labels or nodesets20:04
*** ttsiouts has quit IRC20:04
mriedemhttps://bugs.launchpad.net/nova/+bug/182325120:05
openstackLaunchpad bug 1823251 in OpenStack Compute (nova) "Spike in TestNovaMigrationsMySQL.test_walk_versions/test_innodb_tables failures since April 1 2019" [Medium,Confirmed]20:05
mriedemfungi: logan-: ok i guess we'll just tinker with seeing if adding skipsdist=True back fixes the issue20:05
mriedemand i'll get an e-r query up20:05
efriedmriedem: So is https://review.openstack.org/#/c/650043/ not safe to recheck?20:06
efriedwe're holding RC2 for it, nah?20:06
mriedemefried: melwitt already approved it20:06
mriedembut i just looked at the grenade failure, it's a known gate failure20:06
efriedyes but it's sitting failed20:06
mriedemdon't need to recheck it if it's approved now20:06
efriedright, I'm asking if it's a 100% failure or if we can recheck?20:06
melwittit's in the zuul check queue20:06
efriedoh, okay.20:06
mriedemfor this pymysql InterfaceError, it's showing up in more than just nova,20:13
mriedemso did something change in upper-constraints or something more global on 4/1?20:13
mriedemhttps://github.com/openstack/requirements/commit/27d0b42e23f8d964464862cb5590dea870ae9fd7#diff-0bdd949ed8a7fdd4f95240bd951779c8 merged on 4/120:14
mriedemi don't see anything obvious though20:15
mriedemlogan-: are you able to tell if anything changed around 4/1 wrt limestone-regionone bionic node packages?20:19
mriedemspecifically related to mysql/sqlalchemy/pymysql20:20
mriedemalthough the latter 2 should be coming from pypi in our CI runs20:20
logan-the region came back online after a p->q->r upgrade on 3/27, nothing has changed since then though.20:20
*** BjoernT has quit IRC20:20
logan-since we have been chatting, I just found a config issue that is being resolved: https://review.openstack.org/#/c/650135/20:21
*** tesseract has quit IRC20:21
mriedemheh what a coincidence https://review.openstack.org/#/c/641981/20:22
*** tbachman has joined #openstack-nova20:22
*** artom has joined #openstack-nova20:23
logan-hah20:23
*** pcaruana has quit IRC20:29
*** pcaruana has joined #openstack-nova20:30
*** dpawlik has joined #openstack-nova20:31
*** hongbin has quit IRC20:34
*** dpawlik has quit IRC20:35
*** itlinux has joined #openstack-nova20:37
*** itlinux has quit IRC20:38
openstackgerritEric Fried proposed openstack/nova master: DNM: Re-add skipsdist=True, except for lower-constraints  https://review.openstack.org/65012320:39
*** itlinux has joined #openstack-nova20:39
efriedkashyap, aspiers: FYI, I did not seed the review-day etherpad with the specs you mentioned, because it sounded like they weren't quite ready for that yet.20:40
*** ttsiouts has joined #openstack-nova20:42
openstackgerritMichael Still proposed openstack/nova master: Hacking N362: Don't abbrev/alias privsep import  https://review.openstack.org/64919020:44
openstackgerritMichael Still proposed openstack/nova master: Improve test coverage of nova.privsep.path.  https://review.openstack.org/64860120:44
openstackgerritMichael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs.  https://review.openstack.org/64860220:44
openstackgerritMichael Still proposed openstack/nova master: Improve test coverage of nova.privsep.fs, continued.  https://review.openstack.org/64860320:45
openstackgerritMichael Still proposed openstack/nova master: Add test coverage for nova.privsep.libvirt.  https://review.openstack.org/64861620:45
openstackgerritMichael Still proposed openstack/nova master: Add test coverage for nova.privsep.qemu.  https://review.openstack.org/64919120:45
openstackgerritMichael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement.  https://review.openstack.org/63543120:45
openstackgerritMichael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods.  https://review.openstack.org/63543320:45
openstackgerritMichael Still proposed openstack/nova master: Privsep the ebtables modification code.  https://review.openstack.org/63543520:45
openstackgerritMichael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep.  https://review.openstack.org/63543620:45
openstackgerritMichael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep.  https://review.openstack.org/63650820:45
openstackgerritMichael Still proposed openstack/nova master: Move dnsmasq restarts to privsep.  https://review.openstack.org/63928020:45
openstackgerritMichael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep.  https://review.openstack.org/63928120:45
openstackgerritMichael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep.  https://review.openstack.org/63928220:45
openstackgerritMichael Still proposed openstack/nova master: Move setting of device trust to privsep.  https://review.openstack.org/63928320:45
openstackgerritMichael Still proposed openstack/nova master: Move final bridge commands to privsep.  https://review.openstack.org/63958020:45
openstackgerritMichael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network.  https://review.openstack.org/63958120:45
openstackgerritMichael Still proposed openstack/nova master: We no longer need rootwrap.  https://review.openstack.org/55443820:45
efriedmdbooth_: anything on this morning's weird db race topic?20:45
efriedo, it's like midnight for you.20:45
*** wolverineav has quit IRC20:46
*** wolverineav has joined #openstack-nova20:47
*** ttsiouts has quit IRC20:47
*** hongbin has joined #openstack-nova20:48
*** wolverineav has quit IRC20:51
*** wolverineav has joined #openstack-nova20:51
*** spsurya has quit IRC20:54
*** BjoernT has joined #openstack-nova20:55
*** slaweq has quit IRC20:58
*** cdent has joined #openstack-nova20:58
*** amodi has quit IRC20:59
*** wolverineav has quit IRC21:03
*** dpawlik has joined #openstack-nova21:04
*** wolverineav has joined #openstack-nova21:05
efriedmriedem: I'm dyin here. Can't figure out how to get logstash to return these. Here are representative examples:21:09
efriedhttp://logs.openstack.org/57/649757/1/check/openstack-tox-py37/a965c6b/testr_results.html.gz21:09
efriedhttp://logs.openstack.org/92/627892/21/check/openstack-tox-py37/66b8eab/testr_results.html.gz21:09
efriedhttp://logs.openstack.org/13/621313/21/check/openstack-tox-py36/ba2c848/testr_results.html.gz21:09
efriedhttp://logs.openstack.org/53/639453/9/check/openstack-tox-py36/2b6b01f/testr_results.html.gz21:09
efriedhttp://logs.openstack.org/66/649566/1/check/openstack-tox-py37/e989684/testr_results.html.gz21:09
efriedhttp://logs.openstack.org/01/648601/5/check/openstack-tox-py36/0e12826/testr_results.html.gz21:09
mriedemthink i already got it https://review.openstack.org/65013621:11
efriedsigh21:12
*** ttsiouts has joined #openstack-nova21:12
efriedI was trying to include other parts of the "message". How do you do that? Whenever I use AND it comes back with nothing.21:12
efriedfixtures._fixtures.timeout.TimeoutException seems relevant. Because I would have thought that InterfaceException could be caused by any number of things.21:13
efriedInterfaceError, rather21:13
mriedemconsole log entries are indexed as single lines21:15
mriedemso you unfortunately can't do an AND on messages from different lines21:15
mriedemthe only multi-line indexing we have is tracebacks in screen logs21:15
mriedeme.g. nova-compute21:15
mriedemwhich is frustrating with tests that fail like this https://bugs.launchpad.net/nova/+bug/182321521:16
openstackLaunchpad bug 1823215 in OpenStack Compute (nova) "TestInstanceNotificationSampleWithMultipleComputeOldAttachFlow._test_live_migration_force_complete intermittent fails with MismatchError: 6 != 7" [Medium,Confirmed]21:16
mriedemmeans we have to do a better job of logging at the point of failure21:16
mriedemmelwitt: dansmith: i was going to write up something in our contributor testing reference docs about testing with a down cell in devstack, my notes are here http://paste.openstack.org/show/748904/ - do you see anything in there that i could be missing which might be interesting/useful?21:19
mriedemsomewhere linked from here https://docs.openstack.org/nova/latest/contributor/#testing21:19
cdentdid any of mdbooth's eventlet clean ups merge?21:21
mriedemcdent: https://review.openstack.org/#/q/topic:bug/1808975+(status:open+OR+status:merged)21:22
cdentbecause it seems like what the pymysql interface errors are showing is that something has disrupted some delicate timing and a bit of unitidiness in the opportunistic tests is not getting the leeway desired21:22
cdenthmmm, that's further back than would make sense for this21:22
mriedemcdent: i definitely suspect eventlet weirdness with http://status.openstack.org/elastic-recheck/#179336421:22
mriedemcdent: but yeah that21:22
mriedemtiming doesn't line up with the failures21:22
mriedemi do think we hit some thread switch and then the test just times out21:23
mriedemolder notes are in https://bugs.launchpad.net/nova/+bug/179336421:23
openstackLaunchpad bug 1793364 in Manila "mysql db opportunistic unit tests timing out intermittently in the gate (bad thread switch?)" [Undecided,In progress] - Assigned to Goutham Pacha Ravi (gouthamr)21:23
efriedmriedem: https://review.openstack.org/#/c/650043/ is failing in grenade again. Ima rebase it so we don't have to wait for the rest to finish, if you can re+W it?21:25
mriedemsure21:25
*** slaweq has joined #openstack-nova21:25
openstackgerritEric Fried proposed openstack/nova stable/stein: Remove CellMappingPayload database_connection and transport_url fields  https://review.openstack.org/65004321:25
efriedmriedem: needed trivial edit ^ since no newer master commit to rebase onto21:26
melwittmriedem: looks comprehensive to me, I can't think of anything missing other than linking to the docs about what down cell means and such when you propose the patch21:26
mriedemmelwitt: yup lots of links to be made21:26
mriedemthanks for looking21:26
cdentif it turns out to be sdist we should decode why. in at least some of our tests runs when sdist is true we'll install requirements as discovered by python setup.py sdist and then install requirements _again_ so there's a possibility that pip is changing it's mind about some things when upper constraints is more involved. hard to say, especially at my late hour21:26
melwittmriedem: yeah, looks good. good stuff to have in the docs21:27
mriedemefried: you could have chosen something besides the cherry-picked line :)21:27
mriedemwell i guess not, whatever21:27
efriedmriedem: Yeah, then it would have differed from its cherry-pick-ees.21:28
mriedemefried: maybe should ask fungi to promote that?21:28
*** ttsiouts has quit IRC21:28
dansmithmriedem: why the upgrade levels thing?21:28
*** ttsiouts has joined #openstack-nova21:28
mriedemdansmith: because of https://bugs.launchpad.net/nova/+bug/181569721:28
openstackLaunchpad bug 1815697 in OpenStack Compute (nova) "[upgrade_levels]compute=auto grinds the API response times when a cell is down" [Medium,Confirmed]21:28
mriedem"Also note the default database max_attempts and retry_interval are 10  which means for each API object created that hits this, it's going to  take 100 seconds to timeout per route handler per API worker. I count 31  route handlers that create an API object, so that's by default 3100  seconds or about ~52 minutes per worker on startup."21:29
dansmithoh because auto doesn't support the timeouts?21:29
melwittmriedem, efried: reminder we're also waiting on https://review.openstack.org/649630 it's #1 in the gate but if it fails...21:29
dansmithI think I remember that now21:29
efriedfungi: TLDR https://review.openstack.org/#/c/650043/ represents a security regression we're holding nova-stein-rc2 for21:29
mriedemdansmith: not really about the timeouts, it's just we hit that query on each API controller startup x number of API workers21:29
efriedmelwitt: ack, succeeding so far.21:29
efriedthough it hasn't finished the freakin grenade-lm job yet21:30
mriedemheh we could have rebased https://review.openstack.org/#/c/650043/ on top of https://review.openstack.org/64963021:30
melwittyeah. wanted to point that out in case of gate promotions, we have two that are in flight21:30
*** slaweq has quit IRC21:30
mriedemdansmith: https://review.openstack.org/#/c/649197/ was an attempt at something semi-related21:32
dansmithmriedem: oh, is this because we actually start them in threads early enough (because wsgi) that we haven't populated the cache yet?21:33
*** ttsiouts has quit IRC21:33
mriedemwell, in my devstack recreate, cell1 is down and cell1 is the only thing that has compute services,21:33
mriedemso we get 0 back for the min compute service version which does not get cached21:33
mriedemhttps://review.openstack.org/#/c/649197/1/nova/compute/rpcapi.py@42421:34
dansmithoh okay I meant the perf thing, but that's probably legit too21:34
mriedemalso related https://bugs.launchpad.net/nova/+bug/181569221:34
openstackLaunchpad bug 1815692 in OpenStack Compute (nova) "minimum nova-compute service version is not cached in nova-api when running under wsgi" [Low,Triaged]21:34
dansmithah21:35
mriedemthat would not affect the other bug on startup though because we don't call that method which uses the cache https://github.com/openstack/nova/blob/0bed18ffbb46c4f2d0ec87e64a39188c165398eb/nova/objects/service.py#L50721:36
mriedembut as i recall objects.Service.enable_min_version_cache() is meant for perf gains in the api lookups21:36
mriedemafter startup21:36
dansmithI think your singleton patch looks okay21:36
dansmithso,21:37
mriedemi haven't looked into the functional test failures21:37
dansmithwith the sighup thing not working,21:37
dansmithyou might not want to fix the caching thing :P21:37
dansmiththat might be why it hasn't been as much of a thing.. potentially.. if people aren't sighupping but still getting the pin recalculated21:37
dansmithalthough the perf impact is probably worse than just having to bump all your services fully21:37
mriedemthe sighup for nova-compute is particularly busted b/c of the privsep usage and neutron event callback handler stuff,21:38
dansmithwhat a tangled mess of shit21:38
dansmithright, but it's also going to cause anything else to do a full restart21:38
mriedembut i wasn't sure if hup'ing the controller services was still ok because we have the cells cache for connections and disabled cells and all that21:38
dansmithnot as impactful for apis I guess21:38
dansmithbut for conductor it's probably not great either21:39
mriedemok so i think you're saying huping the controller services will do what you want - reload caches, but not in the graceful way we intended21:39
dansmithI dunno about conductor, probably not great there,21:39
mriedemb/c it's a restart21:39
mriedemscheduler has the hup for the disabled cells i think21:39
dansmithas I think anything currently waiting on an rpc call, or polling for state or whatever will die21:39
mriedemand cells cache in the request context21:39
mriedemtangled mess of shit yes21:40
dansmithfor serious21:40
mriedemwho's being depressing NOW!21:40
dansmitho/21:40
mriedemmaybe my depression rubs off on those that speak with me21:40
dansmithand it's thursday, closer to friday21:40
mriedemefried: melwitt: how are you feeling right now?21:40
dansmithyou're also the arsehole that is finding this stuff21:41
dansmithwe could just ignore it if it wasn't for you21:41
melwittyeah, seriously21:43
melwitt:)21:43
mriedemit is also cold and rainy here right now (well most of this week)21:44
mriedemso it's just a gloom21:44
*** BjoernT has quit IRC21:45
fungiefried: cool, yeah i was advancing/monitoring the master branch version of 650043 earlier so that one could be approved sooner, can also shuffle that one up now that it's been approved (sorry for the delay, was just out for an afternoon walk)21:46
*** awalende has joined #openstack-nova21:46
efriedthanks fungi21:46
*** slaweq has joined #openstack-nova21:47
*** awalende has quit IRC21:50
*** slaweq has quit IRC21:51
*** pcaruana has quit IRC21:51
*** slaweq has joined #openstack-nova21:52
*** dpawlik has quit IRC21:53
*** slaweq has quit IRC21:57
openstackgerritMatt Riedemann proposed openstack/nova master: Log notifications if assertion in _test_live_migration_force_complete fails  https://review.openstack.org/65015521:59
*** bnemec has quit IRC22:01
*** dpawlik has joined #openstack-nova22:05
*** dpawlik has quit IRC22:09
*** hongbin has quit IRC22:09
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Re-propose cross-cell-resize spec for Train  https://review.openstack.org/64280722:19
*** rcernin has joined #openstack-nova22:23
*** cdent has quit IRC22:26
melwittefried, fungi: 650043,2 just failed lower-constraints :( for what looks to be https://bugs.launchpad.net/nova/+bug/179336422:28
openstackLaunchpad bug 1793364 in Manila "mysql db opportunistic unit tests timing out intermittently in the gate (bad thread switch?)" [Undecided,In progress] - Assigned to Goutham Pacha Ravi (gouthamr)22:28
fungimelwitt: thanks for the heads up, i've manually reset the gate so it will restart jobs on that change now22:30
melwittthanks!22:31
*** whoami-rajat has quit IRC22:32
*** igordc has quit IRC22:34
*** wolverineav has quit IRC22:35
*** mrhillsman_bbiab is now known as mrhillsman22:40
*** ttsiouts has joined #openstack-nova22:50
*** slaweq has joined #openstack-nova22:54
*** wolverineav has joined #openstack-nova22:56
*** luksky has quit IRC22:57
efriedmelwitt, mriedem: fungi: I gotta run. You got this?22:58
*** slaweq has quit IRC22:58
*** tkajinam has joined #openstack-nova22:59
melwittefried: yeah, I'll watch the patches tonight22:59
efriedThanks melwitt22:59
fungii'll be around as well23:00
fungifeel free to ping me for anything23:00
fungieager to see this resolved so it doesn't become a bigger issue after release23:00
melwittok, thank you23:01
mriedemno VMT bias there :)23:01
fungi(since that usually means more work for all of us, and we already have more than enough of that to go around)23:01
fungi;)23:01
fungiyeah, juggling plenty of security issues which have cropped up in releases we can't go back in time to fix, so it's nice when we catch one *before* releasing23:02
*** keekz has joined #openstack-nova23:14
*** dklyle has quit IRC23:19
*** ttsiouts has quit IRC23:23
*** wolverineav has quit IRC23:27
*** itlinux has quit IRC23:31
*** wolverineav has joined #openstack-nova23:31
*** wolverineav has quit IRC23:31
*** wolverineav has joined #openstack-nova23:32
*** igordc has joined #openstack-nova23:39
*** Sundar has quit IRC23:39
*** eharney has quit IRC23:40
*** tosky has quit IRC23:43
*** slaweq has joined #openstack-nova23:54
*** tjgresha has joined #openstack-nova23:56
*** gyee has quit IRC23:58
*** slaweq has quit IRC23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!