*** tbachman has joined #openstack-nova | 00:09 | |
*** tetsuro has joined #openstack-nova | 00:10 | |
*** tetsuro has quit IRC | 00:14 | |
*** tetsuro has joined #openstack-nova | 00:17 | |
*** markvoelker has joined #openstack-nova | 00:42 | |
*** tetsuro has quit IRC | 00:43 | |
*** markvoelker has quit IRC | 00:44 | |
*** markvoelker has joined #openstack-nova | 00:45 | |
*** tetsuro has joined #openstack-nova | 00:50 | |
*** gbarros has quit IRC | 00:51 | |
*** stakeda has joined #openstack-nova | 00:53 | |
*** yaawang has quit IRC | 00:56 | |
*** yaawang has joined #openstack-nova | 00:58 | |
*** ricolin has joined #openstack-nova | 01:00 | |
openstackgerrit | Bhagyashri Shewale proposed openstack/nova master: WIP: Ignore root_gb for BFV in simple tenant usage API https://review.openstack.org/612626 | 01:05 |
---|---|---|
*** tetsuro has quit IRC | 01:17 | |
*** tetsuro_ has joined #openstack-nova | 01:17 | |
*** whoami-rajat has joined #openstack-nova | 01:19 | |
*** tetsuro_ has quit IRC | 01:20 | |
*** tetsuro has joined #openstack-nova | 01:20 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova stable/stein: doc: Capitalize keystone domain name https://review.openstack.org/650600 | 01:23 |
*** tetsuro has quit IRC | 01:23 | |
*** tetsuro has joined #openstack-nova | 01:24 | |
*** tetsuro has quit IRC | 01:29 | |
*** tiendc has joined #openstack-nova | 01:31 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova stable/rocky: doc: Capitalize keystone domain name https://review.openstack.org/650601 | 01:32 |
*** tetsuro has joined #openstack-nova | 01:34 | |
*** tetsuro has quit IRC | 01:42 | |
*** tetsuro has joined #openstack-nova | 01:43 | |
*** irclogbot_1 has quit IRC | 01:44 | |
*** edmondsw_ has quit IRC | 01:48 | |
*** edleafe has quit IRC | 01:48 | |
*** Dinesh_Bhor has joined #openstack-nova | 01:57 | |
*** brinzhang has joined #openstack-nova | 02:14 | |
*** yaawang has quit IRC | 02:28 | |
*** yaawang has joined #openstack-nova | 02:30 | |
openstackgerrit | Merged openstack/nova stable/queens: prevent common kwargs from glance client failure https://review.openstack.org/650065 | 02:49 |
*** ircuser-1 has quit IRC | 02:49 | |
*** ileixe has joined #openstack-nova | 02:53 | |
ileixe | Hi, guys. | 02:55 |
ileixe | I wonder what's best practice to integrate custom code with Nova. | 02:56 |
ileixe | Since there is deprecated sign for API like hook / extension which can be builiding block for custom code. | 02:56 |
ileixe | How can admin achieve their own busineess logic with VM lifecycle? For example, when VM created, add related metadata to CMDB. | 02:57 |
ileixe | We've been used notification events before, I realized it's quite unstable and unexpectable.. | 02:58 |
*** Nel1x has quit IRC | 03:02 | |
*** udesale has joined #openstack-nova | 03:04 | |
*** psachin has joined #openstack-nova | 03:20 | |
*** Nel1x has joined #openstack-nova | 03:21 | |
*** lpetrut has joined #openstack-nova | 03:49 | |
*** psachin has quit IRC | 03:51 | |
*** imacdonn_ has quit IRC | 04:02 | |
*** imacdonn_ has joined #openstack-nova | 04:02 | |
*** Nel1x has quit IRC | 04:10 | |
openstackgerrit | Sundar Nadathur proposed openstack/nova-specs master: Nova Cyborg interaction specification. https://review.openstack.org/603955 | 04:15 |
*** lpetrut has quit IRC | 04:21 | |
*** ratailor has joined #openstack-nova | 04:33 | |
*** _alastor_ has joined #openstack-nova | 04:36 | |
*** pcaruana has joined #openstack-nova | 04:49 | |
*** pcaruana has quit IRC | 04:55 | |
*** sidx64 has joined #openstack-nova | 04:56 | |
*** sidx64 has quit IRC | 05:00 | |
*** sidx64 has joined #openstack-nova | 05:02 | |
*** Luzi has joined #openstack-nova | 05:49 | |
*** bhagyashris_ has joined #openstack-nova | 05:49 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.openstack.org/649953 | 05:50 |
*** _alastor_ has quit IRC | 05:55 | |
*** phasespace has quit IRC | 06:01 | |
*** jaosorior has joined #openstack-nova | 06:05 | |
*** lpetrut has joined #openstack-nova | 06:08 | |
*** sridharg has joined #openstack-nova | 06:13 | |
*** sapd1_x has joined #openstack-nova | 06:15 | |
*** pcaruana has joined #openstack-nova | 06:30 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: Use the functional test test_parallel_evacuate_with_server_group https://review.openstack.org/649963 | 06:36 |
openstackgerrit | zhufl proposed openstack/nova master: Remove query_client from resource_tracker https://review.openstack.org/650616 | 06:38 |
*** zhubx has joined #openstack-nova | 06:38 | |
*** zhubx has quit IRC | 06:39 | |
*** zhubx has joined #openstack-nova | 06:40 | |
*** ivve has joined #openstack-nova | 06:42 | |
*** markvoelker has quit IRC | 06:43 | |
*** dpawlik has joined #openstack-nova | 06:45 | |
*** zhubx has quit IRC | 06:47 | |
*** zhubx has joined #openstack-nova | 06:48 | |
*** zhubx has quit IRC | 06:49 | |
*** boxiang has joined #openstack-nova | 06:49 | |
*** slaweq has joined #openstack-nova | 06:53 | |
*** slaweq has quit IRC | 06:56 | |
*** slaweq has joined #openstack-nova | 07:01 | |
openstackgerrit | Kunpeng Zhang proposed openstack/nova master: Enhance live-migration progress log for memory https://review.openstack.org/650621 | 07:03 |
openstackgerrit | Tushar Patil proposed openstack/nova-specs master: Allow compute nodes to use DISK_GB from shared storage RP https://review.openstack.org/650188 | 07:09 |
*** awalende has joined #openstack-nova | 07:10 | |
openstackgerrit | Kunpeng Zhang proposed openstack/nova master: Enhance live-migration progress log for memory https://review.openstack.org/650621 | 07:13 |
*** tesseract has joined #openstack-nova | 07:13 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova stable/rocky: doc: Fix openstack CLI command https://review.openstack.org/648425 | 07:14 |
openstackgerrit | Takashi NATSUME proposed openstack/nova stable/rocky: Replace glance command with openstack command https://review.openstack.org/637060 | 07:15 |
*** awalende has quit IRC | 07:19 | |
*** tosky has joined #openstack-nova | 07:19 | |
*** phasespace has joined #openstack-nova | 07:19 | |
*** awalende has joined #openstack-nova | 07:20 | |
*** awalende has quit IRC | 07:24 | |
*** awalende has joined #openstack-nova | 07:24 | |
gibi_off | ileixe: have you reported the problems regarding notifications as bugs? I encurage you to try versioned notifications and report any bugs. Also feel free to ping me if you have questions | 07:28 |
*** gibi_off is now known as gibi | 07:28 | |
openstackgerrit | Yongli He proposed openstack/nova master: Clean up orphan instances https://review.openstack.org/627765 | 07:31 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Change a log level for overwriting allocation https://review.openstack.org/649788 | 07:31 |
ileixe | gibi: I think I do not choose right word to express my situation. Notification itself is not a problem. What I felt hard is whenver I have small hooking logic, there were too many things to be considered. (e.g. We have to deploy ceilometer for consumer, gnocchi for publisher, aodh for alarm. And even there is no exact API to hook the event) | 07:34 |
*** ralonsoh has joined #openstack-nova | 07:35 | |
ileixe | I felt like I'm on the wrong track. T_T | 07:35 |
*** igordc has quit IRC | 07:36 | |
gibi | ileixe: have you considered simply listening on the notification (or versioned_notification) topic on the message bus? that needs credentials to the message bus but if you can have that then it is couple of lines of code to subscribe to the topic and get the events | 07:37 |
ileixe | Yes acutally we're done to make our 3rd party component to listen messaging | 07:37 |
gibi | in this case you dont need ceilometer and aodh to interface with your CMDB | 07:39 |
ileixe | but I thought it's also not a right solution since we have to track messaging format/every event type (I mean unexpectable in this siutation). | 07:39 |
*** awalende has quit IRC | 07:39 | |
ileixe | Yep.. | 07:39 |
ileixe | So my question is how others deal with this problem. | 07:40 |
gibi | ileixe: versioned notifications have a well defined format and proper versioning. Have you see the doc https://docs.openstack.org/nova/latest/reference/notifications.html#existing-versioned-notifications ? | 07:42 |
*** awalende has joined #openstack-nova | 07:42 | |
gibi | I cannot say how others deal with this, but I think versioned notificatons are capable of solving your problem and if you have feedback how to make them better then that feedback is very much appreciated | 07:43 |
*** luksky has joined #openstack-nova | 07:46 | |
*** helenafm has joined #openstack-nova | 07:47 | |
*** elod_off is now known as elod | 07:48 | |
*** rpittau|afk is now known as rpittau | 07:48 | |
ileixe | gibi: Thanks, gibi. It's worth to listen your view since I felt maybe I'm not going the wrong way. I will feedback you when I have an better idea to solve the problem. | 07:49 |
gibi | ileixe: feel free to ping me | 07:49 |
*** jangutter has joined #openstack-nova | 07:49 | |
ileixe | :) | 07:49 |
*** helenafm has quit IRC | 07:52 | |
*** tssurya has joined #openstack-nova | 07:59 | |
*** tkajinam has quit IRC | 08:11 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | 08:17 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | 08:17 |
*** rcernin has quit IRC | 08:19 | |
*** tetsuro has quit IRC | 08:20 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.openstack.org/649953 | 08:25 |
*** tetsuro has joined #openstack-nova | 08:25 | |
*** ccamacho has joined #openstack-nova | 08:28 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: Use the functional test test_parallel_evacuate_with_server_group https://review.openstack.org/649963 | 08:33 |
*** derekh has joined #openstack-nova | 08:33 | |
*** dtantsur|afk is now known as dtantsur | 08:35 | |
*** sapd1_x has quit IRC | 08:39 | |
*** markvoelker has joined #openstack-nova | 08:45 | |
*** zigo_ has joined #openstack-nova | 08:46 | |
*** zigo_ is now known as zigo | 08:50 | |
*** tetsuro has quit IRC | 08:54 | |
*** tetsuro has joined #openstack-nova | 08:58 | |
*** sidx64 has quit IRC | 09:10 | |
*** ttsiouts has joined #openstack-nova | 09:11 | |
openstackgerrit | Adrian Chiris proposed openstack/nova master: SR-IOV Live migration indirect port support https://review.openstack.org/620115 | 09:11 |
*** tobberydberg has quit IRC | 09:12 | |
*** sidx64 has joined #openstack-nova | 09:13 | |
*** tuchopaw has joined #openstack-nova | 09:18 | |
*** markvoelker has quit IRC | 09:18 | |
*** zkzmmrc has joined #openstack-nova | 09:18 | |
*** kuzmlmar has joined #openstack-nova | 09:19 | |
*** tuchopaw has quit IRC | 09:19 | |
*** tobberydberg has joined #openstack-nova | 09:24 | |
openstackgerrit | Merged openstack/nova master: Do not log a warning about not using compute monitors https://review.openstack.org/650092 | 09:36 |
*** cdent has joined #openstack-nova | 09:39 | |
*** finucannot is now known as stephenfin | 09:40 | |
kashyap | stephenfin: When you get a moment, an rST question: in this rendering: http://logs.openstack.org/14/645814/2/check/openstack-tox-docs/0e76299/html/specs/train/approved/cpu-selection-with-hypervisor-consideration.html | 09:42 |
kashyap | stephenfin: ... I don't like how the words "or" and "type" are highlighted in the two tables. (Probably because they're rendered as code blocks.) | 09:43 |
kashyap | Any ideas to address that? | 09:43 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Add "CPU selection with hypervisor consideration" spec https://review.openstack.org/645814 | 09:45 |
*** davidsha has joined #openstack-nova | 09:57 | |
*** stakeda has quit IRC | 10:00 | |
stephenfin | It's trying to guess the syntax. You can do '.. code-block:: none' before it (instead of '::') to override that, I would say | 10:00 |
kashyap | Oh right! | 10:02 |
kashyap | stephenfin: I recall the 'none' thingie. Good idea. | 10:02 |
kashyap | Thanks :-) | 10:02 |
stephenfin | kashyap: Actually, looks like Sphinx can render complex tables like those. Left comment inline | 10:03 |
* kashyap goes to read | 10:03 | |
kashyap | Oh, yeah. I recalled the "+" syntax. Wonderful rST + Sphinx. Endless joy :-) | 10:04 |
* kashyap goes to tinker | 10:04 | |
*** kuzmlmar has quit IRC | 10:04 | |
*** zkzmmrc has quit IRC | 10:04 | |
kashyap | stephenfin: Okay, even with '+', the words "or" and "type" are highlighted in the rendering. | 10:12 |
kashyap | (NB: Rendering was not the problem; with +, it rendering was equivalent to the one before.) | 10:12 |
* kashyap tries '.. code-block:: none' | 10:12 | |
stephenfin | kashyap: If you switch that to '+', you can dedent it and remove the '::' or '.. code-block' | 10:13 |
*** sean-k-mooney has joined #openstack-nova | 10:13 | |
stephenfin | so it'll render as a table instead of a code block | 10:13 |
kashyap | Ah-ha, so after switching it required 'dedenting'... | 10:14 |
stephenfin | Yeah, sorry, I wasn't clear | 10:14 |
stephenfin | The reason it's indented is so it'll render as code because I didn't think docutils would handle complex tables like that, but it turns out it can | 10:15 |
stephenfin | and with gusto, no less | 10:15 |
kashyap | (No problem.) | 10:15 |
kashyap | Hehe, noted. | 10:15 |
*** markvoelker has joined #openstack-nova | 10:16 | |
*** ttsiouts has quit IRC | 10:17 | |
openstackgerrit | Bhagyashri Shewale proposed openstack/nova master: Ignore root_gb for BFV in simple tenant usage API https://review.openstack.org/612626 | 10:17 |
*** ttsiouts has joined #openstack-nova | 10:17 | |
*** bhagyashris_ has quit IRC | 10:18 | |
*** ttsiouts_ has joined #openstack-nova | 10:20 | |
cdent | "with gusto" | 10:22 |
*** ttsiouts has quit IRC | 10:22 | |
kashyap | stephenfin: Hmm, so with "+" (de-dendeted, and no '::' or '.. code-block'), the table rendering is "naked": https://kashyapc.fedorapeople.org/Plain-rendering-of-table-Sphinx.png | 10:24 |
kashyap | (Assuming if you can even spot the table :D) | 10:24 |
* kashyap now tries the '.. code-block:: none' | 10:26 | |
sean-k-mooney | o/ | 10:26 |
*** ttsiouts_ has quit IRC | 10:31 | |
sean-k-mooney | stephenfin: efried: gibi: jaypipes: ill send a email about this later but https://review.openstack.org/#/c/650573/ as an fyi i finished setting up my thirdparty ci over the weekend so we have limited capastity to trigger some dpdk and pinning testing manually now. | 10:31 |
*** ttsiouts has joined #openstack-nova | 10:32 | |
*** priteau has joined #openstack-nova | 10:32 | |
sean-k-mooney | if people comment "seans-nfv-ci: recheck" or "check experimental" on any patch to nova,neutron,os-vif,networking-ovs-dpdk or devstack then it will run | 10:33 |
stephenfin | sounds good to me | 10:34 |
sean-k-mooney | i currently have two singel node jobs running for nova one that tests ovs-dpdk(with hugepages) and another that tests numa+cpu pinning+realtime | 10:34 |
sean-k-mooney | im going to convert them to multinode jobs so that migration/resize tests run and add a whitbox plugin job too i think. | 10:36 |
*** sidx64 has quit IRC | 10:36 | |
*** ttsiouts has quit IRC | 10:36 | |
sean-k-mooney | i also need to enable more tests. ill proably change the trigger to run atomatically once i come up with a sutible file ignore list but i am going to see if i can run some of these test upstream too in the future. | 10:38 |
*** sidx64 has joined #openstack-nova | 10:39 | |
*** tbachman has quit IRC | 10:49 | |
*** markvoelker has quit IRC | 10:49 | |
*** tiendc has quit IRC | 10:55 | |
efried | sean-k-mooney: nice! | 10:55 |
*** zkzmmrc has joined #openstack-nova | 10:57 | |
*** kuzmlmar has joined #openstack-nova | 10:57 | |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Re-propose detach root volume spec https://review.openstack.org/650580 | 11:03 |
*** sridharg has quit IRC | 11:04 | |
*** sridharg has joined #openstack-nova | 11:06 | |
*** udesale has quit IRC | 11:08 | |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Re-propose volume backed server rebuild https://review.openstack.org/650582 | 11:08 |
*** udesale has joined #openstack-nova | 11:09 | |
*** ttsiouts has joined #openstack-nova | 11:13 | |
*** markvoelker has joined #openstack-nova | 11:15 | |
*** Luzi has quit IRC | 11:15 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Hacking N363: Don't use spec[_set]='string' https://review.openstack.org/650370 | 11:19 |
*** sidx64 has quit IRC | 11:20 | |
*** dtantsur is now known as dtantsur|brb | 11:20 | |
openstackgerrit | Merged openstack/nova-specs master: Re-propose detach root volume spec https://review.openstack.org/650580 | 11:20 |
openstackgerrit | Merged openstack/nova-specs master: Re-propose volume backed server rebuild https://review.openstack.org/650582 | 11:24 |
*** mvkr has quit IRC | 11:34 | |
kashyap | sean-k-mooney: sfinucan: Remind me again: why are we messing with VNC whe configuring live migration here: http://git.openstack.org/cgit/openstack/nova/tree/doc/source/admin/configuring-migrations.rst | 11:38 |
*** bbowen has joined #openstack-nova | 11:38 | |
sean-k-mooney | kashyap by default our install guides did not used to tell people to make vnc listen to 0.0.0.0 i think | 11:40 |
sean-k-mooney | as a result if you live migrated without haveing mand that change the console would not work on the new host | 11:40 |
sean-k-mooney | as it defaulted to listening to on the ip of the source host and we dont update that in the libvirt xml on migration | 11:41 |
sean-k-mooney | so the vnc consle woudl try to bind to a tcp port on a ip that is not on the dstionation and fail | 11:41 |
kashyap | Ah, I see. I think we should spell that reasoning out in the doc. (I'll send a patch with "Thanks: Sean Mooney") | 11:43 |
*** sridharg has quit IRC | 11:43 | |
sean-k-mooney | well it says "You must not make the VNC server listen to the IP address of its compute | 11:43 |
sean-k-mooney | host, since that addresses changes when the instance is migrated. | 11:43 |
sean-k-mooney | " | 11:43 |
sean-k-mooney | but ya it could be clearer | 11:44 |
lyarwood | sean-k-mooney / kashyap ; isn't that out of date now given https://github.com/openstack/nova/blob/65874326404717b58ce4927c21d3502d7e53022b/nova/virt/libvirt/migration.py#L84 | 11:45 |
kashyap | sean-k-mooney: Yeah, the meaning is implicit. But it can definitely be clearer | 11:45 |
* kashyap clicks | 11:45 | |
lyarwood | I thought we did update the listen address now | 11:45 |
sean-k-mooney | we do according to that code | 11:46 |
sean-k-mooney | so its nolonger requried but it might be desirable anyway | 11:46 |
sean-k-mooney | it may not be | 11:46 |
sean-k-mooney | when was that added | 11:46 |
sean-k-mooney | 3 years ago | 11:47 |
sean-k-mooney | there is a slight change that the dock is out dated | 11:47 |
*** sridharg has joined #openstack-nova | 11:47 | |
*** pcaruana has quit IRC | 11:47 | |
kashyap | Yeah, definitely making sure that is set does not hurt. | 11:48 |
kashyap | lyarwood: Thanks for the pointer | 11:48 |
*** sidx64 has joined #openstack-nova | 11:55 | |
kashyap | sean-k-mooney: Do we always go through VNC proxy? | 11:56 |
sean-k-mooney | technically you can connect directly but typically an enduser will always connect via the vnc proxy | 11:57 |
sean-k-mooney | we do not want endusers connecting directly to the hyperviors | 11:57 |
sean-k-mooney | host | 11:57 |
*** derekh has quit IRC | 11:58 | |
*** nicolasbock has joined #openstack-nova | 12:00 | |
*** brinzhang has quit IRC | 12:01 | |
*** priteau has quit IRC | 12:01 | |
kashyap | Nod; also how about security? Isn't _always_ listening on 0.0.0.0 insecure? | 12:02 |
sean-k-mooney | yes which is why the note is present in the doc. | 12:03 |
kashyap | Which note? /me reads | 12:03 |
kashyap | Ah, this one: | 12:03 |
kashyap | Since this setting allows VNC clients from any IP address to connect to instance consoles, you must take additional measures like secure networks or firewalls to prevent potential attackers from gaining access to instances. | 12:03 |
*** kuzmlmar has quit IRC | 12:03 | |
*** zkzmmrc has quit IRC | 12:03 | |
sean-k-mooney | yes | 12:03 |
kashyap | Okay, thanks again :-) | 12:04 |
*** edmondsw has joined #openstack-nova | 12:04 | |
*** mgariepy has joined #openstack-nova | 12:11 | |
*** gbarros has joined #openstack-nova | 12:12 | |
jaypipes | sean-k-mooney: cool, thanks :) | 12:21 |
*** tetsuro has quit IRC | 12:24 | |
*** zkzmmrc has joined #openstack-nova | 12:29 | |
*** kuzmlmar has joined #openstack-nova | 12:29 | |
*** mvkr has joined #openstack-nova | 12:29 | |
*** tbachman has joined #openstack-nova | 12:34 | |
*** mchlumsky has joined #openstack-nova | 12:37 | |
*** mdbooth has quit IRC | 12:37 | |
*** pcaruana has joined #openstack-nova | 12:38 | |
*** mchlumsky has quit IRC | 12:41 | |
*** mrjk has quit IRC | 12:41 | |
*** mchlumsky has joined #openstack-nova | 12:42 | |
*** mdbooth has joined #openstack-nova | 12:44 | |
*** edleafe has joined #openstack-nova | 12:44 | |
*** ttsiouts has quit IRC | 12:44 | |
*** ttsiouts has joined #openstack-nova | 12:45 | |
*** mmethot has joined #openstack-nova | 12:45 | |
*** dtantsur|brb is now known as dtantsur | 12:47 | |
*** Luzi has joined #openstack-nova | 12:48 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add in_tree field to RequestGroup object https://review.openstack.org/649534 | 12:48 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Query `in_tree` to placement https://review.openstack.org/649535 | 12:48 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: WIP: Add get_compute_nodes_by_host_or_node() https://review.openstack.org/650877 | 12:48 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Pass target host to RequestGroup.in_tree https://review.openstack.org/650878 | 12:48 |
*** needssleep is now known as TheJulia | 12:49 | |
openstackgerrit | François Palin proposed openstack/nova master: WIP - nova diagnostics command is not working with all interfaces https://review.openstack.org/648123 | 12:49 |
*** derekh has joined #openstack-nova | 12:50 | |
*** jroll has quit IRC | 12:50 | |
*** ttsiouts has quit IRC | 12:50 | |
*** jroll has joined #openstack-nova | 12:50 | |
*** zkzmmrc has quit IRC | 12:51 | |
*** kuzmlmar has quit IRC | 12:51 | |
*** ratailor has quit IRC | 12:52 | |
*** awalende has quit IRC | 12:59 | |
*** awalende has joined #openstack-nova | 12:59 | |
*** ab-a has joined #openstack-nova | 13:03 | |
*** awalende has quit IRC | 13:04 | |
*** amodi has quit IRC | 13:06 | |
*** ttsiouts has joined #openstack-nova | 13:06 | |
*** lbragstad has joined #openstack-nova | 13:08 | |
mnaser | https://github.com/openstack/nova/blob/73edcfae7d5ea498fd17fa8e548ae1bd690f408a/nova/db/sqlalchemy/api.py#L5508-L5537 | 13:10 |
mnaser | so max rows isn't really max rows.. its scanning a full table | 13:10 |
*** sidx64 has quit IRC | 13:24 | |
*** owalsh has quit IRC | 13:26 | |
*** whoami-rajat has quit IRC | 13:28 | |
*** mrjk has joined #openstack-nova | 13:28 | |
*** owalsh has joined #openstack-nova | 13:29 | |
openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/stein: Revert "Fix crashing console-log" https://review.openstack.org/650363 | 13:29 |
openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/rocky: Revert "Fix crashing console-log" https://review.openstack.org/650364 | 13:29 |
*** pcaruana has quit IRC | 13:31 | |
*** pcaruana has joined #openstack-nova | 13:36 | |
*** whoami-rajat has joined #openstack-nova | 13:39 | |
*** liuyulong has joined #openstack-nova | 13:41 | |
sean-k-mooney | cdent: jaypipes dansmith thanks for your feedback on https://review.openstack.org/#/c/647578/2/specs/train/approved/image-metadata-prefiltering.rst by the way. im gong to rework the spec with your changes today | 13:41 |
openstackgerrit | Boris Bobrov proposed openstack/nova-specs master: Re-approve AMD SEV support for Train https://review.openstack.org/641994 | 13:46 |
openstackgerrit | Boris Bobrov proposed openstack/nova-specs master: Re-approve AMD SEV support for Train https://review.openstack.org/641994 | 13:50 |
*** mriedem has joined #openstack-nova | 13:50 | |
*** eharney has joined #openstack-nova | 13:52 | |
*** jmlowe has quit IRC | 13:52 | |
*** tetsuro has joined #openstack-nova | 13:58 | |
*** phasespace has quit IRC | 14:02 | |
*** awaugama has joined #openstack-nova | 14:03 | |
*** lpetrut has quit IRC | 14:09 | |
*** kaisers_ has joined #openstack-nova | 14:10 | |
*** tetsuro_ has joined #openstack-nova | 14:12 | |
*** dpawlik has quit IRC | 14:13 | |
*** tetsuro has quit IRC | 14:14 | |
*** tetsuro_ has quit IRC | 14:17 | |
*** mlavalle has joined #openstack-nova | 14:22 | |
*** amodi has joined #openstack-nova | 14:24 | |
*** spotz has joined #openstack-nova | 14:27 | |
*** jmlowe has joined #openstack-nova | 14:28 | |
*** ivve has quit IRC | 14:32 | |
*** Luzi has quit IRC | 14:32 | |
*** kaisers_ is now known as kaisers_away | 14:36 | |
*** belmoreira has joined #openstack-nova | 14:42 | |
*** mchlumsky has quit IRC | 14:43 | |
*** mchlumsky has joined #openstack-nova | 14:46 | |
*** lbragstad has quit IRC | 14:46 | |
*** lbragstad has joined #openstack-nova | 14:47 | |
*** belmorei_ has joined #openstack-nova | 14:48 | |
*** belmoreira has quit IRC | 14:52 | |
*** cfriesen has joined #openstack-nova | 14:54 | |
*** kaisers_away is now known as kaisers_ | 14:54 | |
*** boxiang has quit IRC | 14:55 | |
*** boxiang has joined #openstack-nova | 14:55 | |
*** tbachman has quit IRC | 14:56 | |
*** sidx64 has joined #openstack-nova | 14:59 | |
*** cfriesen has quit IRC | 14:59 | |
*** efried has quit IRC | 15:03 | |
*** tbachman has joined #openstack-nova | 15:07 | |
*** avolkov has quit IRC | 15:11 | |
*** efried has joined #openstack-nova | 15:12 | |
*** burt has quit IRC | 15:14 | |
*** sidx64 has quit IRC | 15:14 | |
*** gbarros has quit IRC | 15:14 | |
*** N3l1x has joined #openstack-nova | 15:15 | |
*** burt has joined #openstack-nova | 15:15 | |
*** gbarros has joined #openstack-nova | 15:15 | |
*** phasespace has joined #openstack-nova | 15:16 | |
*** gbarros has quit IRC | 15:17 | |
*** luksky has quit IRC | 15:18 | |
*** gyee has joined #openstack-nova | 15:20 | |
*** ttsiouts has quit IRC | 15:25 | |
*** ttsiouts has joined #openstack-nova | 15:26 | |
*** tbachman has quit IRC | 15:26 | |
*** ttsiouts has quit IRC | 15:30 | |
*** ttsiouts has joined #openstack-nova | 15:31 | |
*** takashin has quit IRC | 15:33 | |
*** itlinux_ has quit IRC | 15:33 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Do not log a warning about not using compute monitors https://review.openstack.org/650929 | 15:35 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: libvirt: disconnect volume when encryption fails https://review.openstack.org/650931 | 15:36 |
*** Sundar has joined #openstack-nova | 15:43 | |
*** sidx64 has joined #openstack-nova | 15:44 | |
*** gbarros has joined #openstack-nova | 15:48 | |
*** gbarros has quit IRC | 15:50 | |
*** dave-mccowan has joined #openstack-nova | 15:50 | |
*** sidx64_ has joined #openstack-nova | 15:51 | |
*** sidx64 has quit IRC | 15:51 | |
*** sidx64_ has quit IRC | 15:53 | |
*** tbachman has joined #openstack-nova | 15:54 | |
*** sidx64 has joined #openstack-nova | 15:55 | |
*** mlavalle has quit IRC | 15:56 | |
*** gbarros has joined #openstack-nova | 15:56 | |
*** kaisers_ is now known as kaisers_away | 15:57 | |
*** mlavalle has joined #openstack-nova | 15:57 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1823370 https://review.openstack.org/650424 | 15:58 |
openstack | bug 1823370 in OpenStack Compute (nova) "Evacuations are not restricted to the source cell during scheduling" [Medium,In progress] https://launchpad.net/bugs/1823370 - Assigned to Matt Riedemann (mriedem) | 15:58 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Restrict RequestSpec to cell when evacuating https://review.openstack.org/650429 | 15:58 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Use RequestSpec.requested_destination when rebuilding with new image https://review.openstack.org/650376 | 15:58 |
*** tssurya has quit IRC | 15:59 | |
*** kaisers_away is now known as kaisers_ | 16:00 | |
*** kaisers_ is now known as kaisers_away | 16:00 | |
*** belmorei_ has quit IRC | 16:01 | |
openstackgerrit | sean mooney proposed openstack/nova-specs master: add spec for image metadata prefiltering https://review.openstack.org/647578 | 16:05 |
*** liuyulong is now known as liuyulong|away | 16:07 | |
*** igordc has joined #openstack-nova | 16:07 | |
efried | gibi: Who creates the bw RPs? Nova or neutron? | 16:09 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models https://review.openstack.org/642030 | 16:09 |
*** Sundar has quit IRC | 16:09 | |
mriedem | efried: neutron | 16:10 |
efried | thanks | 16:10 |
mriedem | https://docs.openstack.org/neutron/latest/admin/config-qos-min-bw.html | 16:10 |
kashyap | sean-k-mooney: When you get a moment this week, can you please give the latest iteration a "once-over" -- https://review.openstack.org/#/c/642030/5/specs/train/approved/cpu-model-selection.rst | 16:10 |
*** belmoreira has joined #openstack-nova | 16:11 | |
*** ccamacho has quit IRC | 16:11 | |
kashyap | jackding: ^ You originally proposed it; I made some adjustments. Might want to take a look at it. | 16:11 |
*** igordc has quit IRC | 16:12 | |
kashyap | I noticed a few mistakes in the code, which led me to look at the spec, one thing leads to another ... and suddenly I "inherited" the above spec :D | 16:13 |
*** _alastor_ has joined #openstack-nova | 16:14 | |
*** IvensZambrano has joined #openstack-nova | 16:14 | |
*** tbachman has quit IRC | 16:14 | |
*** ttsiouts has quit IRC | 16:14 | |
*** belmoreira has quit IRC | 16:16 | |
*** igordc has joined #openstack-nova | 16:16 | |
*** erlon has joined #openstack-nova | 16:16 | |
*** manjeets has joined #openstack-nova | 16:22 | |
*** ircuser-1 has joined #openstack-nova | 16:26 | |
*** sidx64 has quit IRC | 16:27 | |
*** dtantsur is now known as dtantsur|afk | 16:27 | |
*** itlinux has joined #openstack-nova | 16:28 | |
*** davidsha has quit IRC | 16:29 | |
stephenfin | lyarwood: Mind taking a look at these if you're still about? https://review.openstack.org/650363 https://review.openstack.org/650364 | 16:29 |
lyarwood | stephenfin: yarp, I'll take a look before I leave | 16:31 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations https://review.openstack.org/637954 | 16:33 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | 16:33 |
stephenfin | dansmith, jaypipes: Briefly, do you recall any previous examples of us removing a model/table from 'nova/db/sqlalchemy/models.py'. I assume I need a migration? | 16:33 |
stephenfin | only example I can see 0951cf3d194edbee213673a525c1291245958264. I assume that's mostly all there is to it? | 16:33 |
stephenfin | (context is that I want to remove 'nova.db.sqlalchemy.models.Cell' without having the tests b**** at me) | 16:34 |
sean-k-mooney | stephenfin: quick question | 16:35 |
sean-k-mooney | http://logs.openstack.org/78/647578/3/check/openstack-tox-docs/38e7bf6/job-output.txt.gz#_2019-04-08_16_20_39_533258 this fails in the gate. | 16:35 |
sean-k-mooney | i know how to fix it | 16:35 |
sean-k-mooney | but i get the same error locally but the tox command succeeded | 16:35 |
stephenfin | sean-k-mooney: The gate doesn't run 'tox -e releasenotes', instead calling 'sphinx-build' directly | 16:36 |
sean-k-mooney | you mean it does not run tox -e docs | 16:36 |
stephenfin | Sorry, yeah | 16:36 |
*** kaisers_away is now known as kaisers_ | 16:36 | |
sean-k-mooney | ok why does the gate not do that | 16:37 |
*** kaisers_ is now known as kaisers_away | 16:37 | |
stephenfin | So I'd say the 'sphinx-build' call in 'tox.ini' is missing a '-W' flag | 16:37 |
sean-k-mooney | ah | 16:37 |
sean-k-mooney | ok | 16:37 |
sean-k-mooney | any reason i should not fix that in a seperate patch? | 16:38 |
stephenfin | sean-k-mooney: mordred et al. would have the full context, but I suspect it was to ensure documentation was reproducible. Some projects (including us) use the 'docs' target to do more than simply call 'sphinx-build' | 16:38 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Avoid using os-brick encryptors when device_path isn't provided https://review.openstack.org/649951 | 16:38 |
sean-k-mooney | its really unititive for the docs tox env to pass but the docs job to fail | 16:38 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance to make place for port healing https://review.openstack.org/637953 | 16:39 |
stephenfin | sean-k-mooney: I _think_ there was a patch from Takashi that fixed that but if not, you should add it, yes | 16:39 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations https://review.openstack.org/637954 | 16:39 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | 16:39 |
lyarwood | stephenfin: so regarding the novaclient backports, I'm not even sure that stable/stein is open at the moment | 16:39 |
* lyarwood checks ML | 16:39 | |
sean-k-mooney | stephenfin: ok ill look for Takashi's patch and if i dont find it ill add one | 16:40 |
*** rpittau is now known as rpittau|afk | 16:40 | |
mordred | stephenfin: I didnm't do it | 16:40 |
* mordred reading | 16:40 | |
mriedem | lyarwood: it's not, final release is wednesday | 16:40 |
sean-k-mooney | mordred: i was just confused by why the docs job on the nova-spec repo did not use the docs tox env | 16:41 |
sean-k-mooney | the docs tox env does not treat warnings as errors so i was confused by why it "passed" locally but failed in the gate | 16:41 |
stephenfin | mriedem, lyarwood: Ah, so any backports to stable/rocky must wait for stable/stein to open first, I guess? | 16:41 |
mordred | stephenfin: actualy - I believe the gate now runs tox -edocs ... it might be hysterical raisins that nova-specs is using an old job? | 16:41 |
lyarwood | Yeah I believe so | 16:41 |
mordred | sean-k-mooney: ^^ | 16:42 |
mordred | stephenfin, sean-k-mooney: the job you want is "openstack-tox-docs" | 16:42 |
sean-k-mooney | mordred: i can check the gate config and fix it too. | 16:42 |
stephenfin | mordred++ | 16:42 |
sean-k-mooney | mordred: i just wanted to make sure there wasnt a reason not to do it the normal way before i made any changes | 16:43 |
stephenfin | Hmm, weird, .zuul.yaml says we're using openstack-specs-jobs which uses openstack-tox-docs | 16:43 |
jaypipes | sean-k-mooney: you working on a rebase of https://review.openstack.org/#/c/629589/? | 16:43 |
stephenfin | and what was introduced by AJaeger over six months ago (openstack/openstack-zuul-jobs@76deef484) | 16:44 |
sean-k-mooney | jaypipes: not presently but i will later or tomorow | 16:44 |
jaypipes | k | 16:44 |
sean-k-mooney | jaypipes: oh i see adrianc updated https://review.openstack.org/#/c/620115/ | 16:45 |
jaypipes | sean-k-mooney: yeah, and I'm +2 on it. | 16:45 |
jaypipes | sean-k-mooney: thus my question to you :) | 16:45 |
sean-k-mooney | other then rebase ontop did you have anything you wanted me to change in https://review.openstack.org/#/c/629589/ | 16:45 |
jaypipes | sean-k-mooney: other than fixing some typos I noted in a review previously, I don't think so. | 16:46 |
sean-k-mooney | ok ill let you know when its done. thanks for review it. im currently working on my imagemetada prefilter spec | 16:47 |
jaypipes | sean-k-mooney: np. | 16:48 |
*** sundar has joined #openstack-nova | 16:50 | |
*** tesseract has quit IRC | 16:53 | |
mriedem | efried: i have done your bidding https://review.openstack.org/#/c/648800/ | 16:54 |
efried | Thanks mriedem | 16:54 |
*** ociuhandu has quit IRC | 16:54 | |
efried | all good points | 16:54 |
*** tbachman has joined #openstack-nova | 16:57 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: cache neutron ports in heal allocation https://review.openstack.org/638207 | 16:57 |
*** slaweq has quit IRC | 16:57 | |
*** derekh has quit IRC | 16:58 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA affinity for vGPUs https://review.openstack.org/650963 | 16:58 |
*** cdent has quit IRC | 16:59 | |
*** mlavalle has quit IRC | 16:59 | |
*** tbachman has quit IRC | 17:02 | |
dansmith | stephenfin: I dunno about removing a whole model or table, but should be the same as a column | 17:04 |
dansmith | stephenfin: i.e. remove the object and db model in this release, then in the next release add a schema migration to drop it | 17:05 |
stephenfin | dansmith: OK, I'll give it a go. Should we still have placeholder migrations or are they not done anymore? | 17:05 |
*** udesale has quit IRC | 17:05 | |
* stephenfin notes we didn't do it for Rocky | 17:05 | |
dansmith | stephenfin: unrelated to this you mean? | 17:05 |
dansmith | oh wow, okay | 17:05 |
stephenfin | yeah | 17:05 |
dansmith | I thought that was on the PTL release checklist | 17:05 |
dansmith | I mean, there's no new reason why we shouldn't, other than that we haven't really had to use them ever, but I'm not aware of any discussion or decision about it | 17:06 |
*** efried is now known as efried_lunch | 17:06 | |
*** udesale has joined #openstack-nova | 17:09 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add placeholder migrations for Stein backports https://review.openstack.org/650964 | 17:09 |
stephenfin | dansmith, melwitt, efried_lunch: They're there if we need them anyway ^ | 17:09 |
*** belmoreira has joined #openstack-nova | 17:10 | |
*** ralonsoh has quit IRC | 17:13 | |
*** erlon has quit IRC | 17:13 | |
*** slaweq has joined #openstack-nova | 17:14 | |
*** jcosmao has joined #openstack-nova | 17:15 | |
*** erlon has joined #openstack-nova | 17:15 | |
*** jcosmao has left #openstack-nova | 17:16 | |
*** slaweq has quit IRC | 17:19 | |
bauzas | stephenfin: others, FWIW, https://wiki.openstack.org/wiki/Nova/ReleaseChecklist | 17:23 |
bauzas | blame myself as I'm technically the release czar (heh) | 17:24 |
stephenfin | dansmith: Hmm, the tests are complaining that I'm not allowed to use 'drop' in migration. Is removing the 'cells' table (cells v1) a valid exception? | 17:24 |
*** slaweq has joined #openstack-nova | 17:24 | |
dansmith | stephenfin: yep, specifically to catch this case, so you have to add an exception | 17:24 |
stephenfin | dansmith: If I don't do that, I see 'AssertionError: Models and migration scripts aren't in sync:' | 17:24 |
dansmith | stephenfin: oh right, so I think you have to leave the model too if there's not an exception path for that | 17:25 |
dansmith | (we've only done this a couple times since some of those modernized tests) | 17:25 |
stephenfin | dansmith: there is not, no | 17:25 |
stephenfin | so just leave the model with a TODO to remove in a future release? | 17:26 |
dansmith | yeah, so leave that but you could neuter it in some way, but definitely remove all the *use* of it yeah | 17:26 |
stephenfin | (y) less work for me | 17:26 |
dansmith | stephenfin: you could probably rename the model, right? Call it "class CellsThingDONOTUSE(..)" | 17:26 |
*** _alastor_ has quit IRC | 17:27 | |
*** wolverineav has joined #openstack-nova | 17:27 | |
*** ivve has joined #openstack-nova | 17:27 | |
stephenfin | Um, I guess I could, yeah :D | 17:27 |
*** slaweq has quit IRC | 17:28 | |
*** erlon has quit IRC | 17:31 | |
*** wolverineav has quit IRC | 17:39 | |
*** tbachman has joined #openstack-nova | 17:40 | |
*** udesale has quit IRC | 17:41 | |
openstackgerrit | sean mooney proposed openstack/nova-specs master: add spec for image metadata prefiltering https://review.openstack.org/647578 | 17:42 |
sean-k-mooney | stephenfin: the nova-specs docs issue was because i had not rebased against mater where warnings are treated as errors | 17:44 |
*** wolverineav has joined #openstack-nova | 17:44 | |
sean-k-mooney | stephenfin: so the tox env and jobs is fine upstream | 17:44 |
*** IvensZambrano has quit IRC | 17:44 | |
*** tbachman_ has joined #openstack-nova | 17:44 | |
*** tbachman has quit IRC | 17:45 | |
*** tbachman_ is now known as tbachman | 17:45 | |
*** wolverineav has quit IRC | 17:51 | |
*** wolverineav has joined #openstack-nova | 17:56 | |
*** ricolin has quit IRC | 18:00 | |
*** kaisers_away is now known as kaisers_ | 18:06 | |
*** Swami has joined #openstack-nova | 18:10 | |
*** kaisers_ has quit IRC | 18:11 | |
openstackgerrit | Merged openstack/nova master: trivial: Remove dead code https://review.openstack.org/649562 | 18:13 |
openstackgerrit | Merged openstack/nova master: hacking: Fix dodgy check https://review.openstack.org/649563 | 18:13 |
openstackgerrit | Merged openstack/nova master: zvm: Remove dead code https://review.openstack.org/649564 | 18:13 |
openstackgerrit | Merged openstack/nova master: trivial: Remove dead 'ALIAS' constant https://review.openstack.org/649565 | 18:13 |
openstackgerrit | Merged openstack/nova master: trivial: Remove unused constants, functions https://review.openstack.org/649567 | 18:13 |
openstackgerrit | Merged openstack/nova master: trivial: Remove dead resource tracker code https://review.openstack.org/649569 | 18:13 |
*** itlinux has quit IRC | 18:19 | |
*** johnsom has quit IRC | 18:20 | |
*** fyx has quit IRC | 18:20 | |
*** adrianreza has quit IRC | 18:20 | |
*** fyx has joined #openstack-nova | 18:21 | |
*** adrianreza has joined #openstack-nova | 18:21 | |
*** johnsom has joined #openstack-nova | 18:21 | |
*** BlackDex has quit IRC | 18:22 | |
*** BlackDex has joined #openstack-nova | 18:22 | |
*** tjgresha has quit IRC | 18:24 | |
*** weshay|ruck is now known as weshay | 18:24 | |
*** tjgresha has joined #openstack-nova | 18:24 | |
*** slaweq has joined #openstack-nova | 18:25 | |
*** cdent has joined #openstack-nova | 18:27 | |
*** slaweq has quit IRC | 18:30 | |
*** tjgresha has quit IRC | 18:30 | |
*** tjgresha has joined #openstack-nova | 18:31 | |
*** igordc has quit IRC | 18:31 | |
*** erlon has joined #openstack-nova | 18:33 | |
*** burt has quit IRC | 18:35 | |
*** sridharg has quit IRC | 18:35 | |
mriedem | dansmith: a quick hot take if you will on the path to dropping this online data migration added in ocata: https://github.com/openstack/nova/blob/master/nova/objects/build_request.py#L484 - options: (1) drop it and just assume people are ok (2) add a nova-status upgrade check and drop it or (3) add an api migrations script which just does the query and delete (not a blocker migration, just query for those records and delete th | 18:36 |
*** burt has joined #openstack-nova | 18:36 | |
mriedem | i'm partial to #3 which if #1 is true, should be a no-op | 18:36 |
dansmith | surely we can delete with extreme prejudice | 18:39 |
dansmith | the case would be what? something created in mitaka that didn't boot that people still want to be able to see in nova-list? | 18:39 |
dansmith | mriedem: ^ | 18:43 |
mriedem | yeah i guess, but we're already deleting with prejudice in the online data migration | 18:43 |
mriedem | because you literally can't load the thing otherwise | 18:44 |
mriedem | so nova-list won't work anyway | 18:44 |
dansmith | mriedem: I mean delete all of the code | 18:44 |
*** belmoreira has quit IRC | 18:44 | |
mriedem | so #1 | 18:44 |
dansmith | if we really need a delete in a schema migration, then I guess, but I'd rather not create the confusion about why it was okay in this case, personally | 18:45 |
mriedem | i think the only thing that scares me is people doing skip upgrades from let's say mitaka in this case to train, but we've said time and again we don't support that and you have to roll through, | 18:46 |
mriedem | so if you do that and hit this, your action would be to just drop those records from your api db manually | 18:46 |
*** mlavalle has joined #openstack-nova | 18:46 | |
dansmith | yeah, that's a really long skip | 18:47 |
*** mvkr has quit IRC | 18:51 | |
*** cdent has quit IRC | 18:54 | |
*** jmlowe has quit IRC | 18:56 | |
*** eandersson_ is now known as eandersson | 18:57 | |
*** tbachman_ has joined #openstack-nova | 19:01 | |
*** tbachman has quit IRC | 19:02 | |
*** tbachman_ is now known as tbachman | 19:02 | |
*** igordc has joined #openstack-nova | 19:04 | |
*** tjgresha has quit IRC | 19:06 | |
*** slaweq has joined #openstack-nova | 19:08 | |
*** luksky has joined #openstack-nova | 19:13 | |
*** igordc has quit IRC | 19:15 | |
*** igordc has joined #openstack-nova | 19:15 | |
*** wolverineav has quit IRC | 19:22 | |
*** wolverineav has joined #openstack-nova | 19:23 | |
*** wolverineav has quit IRC | 19:30 | |
*** cfriesen has joined #openstack-nova | 19:33 | |
*** jbernard has quit IRC | 19:35 | |
*** jbernard has joined #openstack-nova | 19:37 | |
*** ceryx has joined #openstack-nova | 19:46 | |
cfriesen | portdirect: thought I'd give you a heads-up on something weird I saw. was booting up controller nodes and one of them didn't come up due to disk pressure. The other mariadb nodes were stuck in /tmp/start.py because check_if_cluster_data_is_fresh() kept evaluating to false (because the one node wasn't updating its timestamp) | 19:50 |
*** awaugama has quit IRC | 19:54 | |
*** sundar has quit IRC | 19:57 | |
*** wolverineav has joined #openstack-nova | 19:58 | |
*** jmlowe has joined #openstack-nova | 20:00 | |
cfriesen | whoops...^ was supposed to be in another channel. | 20:00 |
*** amodi has quit IRC | 20:03 | |
*** mriedem has quit IRC | 20:05 | |
*** dave-mccowan has quit IRC | 20:05 | |
*** dave-mccowan has joined #openstack-nova | 20:06 | |
*** mriedem has joined #openstack-nova | 20:06 | |
*** jaypipes has quit IRC | 20:07 | |
*** jaypipes has joined #openstack-nova | 20:07 | |
*** wolverineav has quit IRC | 20:08 | |
*** whoami-rajat has quit IRC | 20:08 | |
*** jaypipes_ has joined #openstack-nova | 20:08 | |
*** jaypipes has quit IRC | 20:12 | |
mnaser | I mentioned this earlier but.. this does a full table scan, even with max rows.. https://github.com/openstack/nova/blob/73edcfae7d5ea498fd17fa8e548ae1bd690f408a/nova/db/sqlalchemy/api.py#L5508-L5537 | 20:12 |
mnaser | I'm not sure what the best way to work around it is.. | 20:12 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.openstack.org/631123 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.openstack.org/627892 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.openstack.org/631581 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.openstack.org/633853 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.openstack.org/621313 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.openstack.org/633293 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.openstack.org/627890 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.openstack.org/634832 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.openstack.org/637605 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.openstack.org/627891 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.openstack.org/642183 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.openstack.org/642590 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.openstack.org/635080 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.openstack.org/635646 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.openstack.org/614035 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.openstack.org/635668 | 20:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.openstack.org/635684 | 20:18 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.openstack.org/636224 | 20:18 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.openstack.org/614037 | 20:18 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.openstack.org/636253 | 20:18 |
mriedem | mnaser: are we missing indexes? | 20:18 |
mriedem | i don't see any indexes on instance_actions_events | 20:20 |
mriedem | but that does: | 20:20 |
mriedem | update_statement = table.update().values(deleted=table.c.id).\ where(table.c.action_id.in_(deleted_actions)) | 20:20 |
mriedem | i don't know if adding an index on instance_actions_events.action_id would help though | 20:21 |
mriedem | probably need jaypipes_ to tell us what sucks about those queries | 20:22 |
*** pcaruana has quit IRC | 20:25 | |
*** efried_lunch is now known as efried | 20:25 | |
mriedem | that's also in the mainline code https://github.com/openstack/nova/blob/fb1fee6772bb101eac83845bac9022df77113aaa/nova/db/sqlalchemy/api.py#L5288 | 20:26 |
mnaser | Yeah I don’t know much. I had to kind orchestrate this outside nova and shortcircuit that code path | 20:28 |
*** eharney has quit IRC | 20:30 | |
mriedem | mnaser: do you archive/purge on a cron or just during each upgrade? | 20:31 |
mriedem | and tbc this just makes that archive/purge slower right? | 20:31 |
mnaser | mriedem: we’ve kinda not done this for a while so we ended up with huge databases. | 20:33 |
mnaser | so this may be a case of our fault not doing it as often | 20:33 |
mriedem | ok, was just trying to figure out if it's worth opening a bug report, i.e. if archive takes like 5 minutes or something, then maybe | 20:35 |
efried | stephenfin, bauzas, dansmith: Do we need to get those placeholder thingies in before the real release? I.e. modify the release patch? | 20:43 |
efried | mriedem, melwitt: ^ | 20:45 |
mriedem | no the placeholder migrations are post-release | 20:49 |
mriedem | so if we needed to add a schema migration in stable/stein, we have a placeholder for it in train | 20:49 |
efried | mriedem: Okay, so... is there some reason we couldn't backport placeholder migrations for rocky? | 20:50 |
mriedem | we don't backport placeholder migrations, | 20:51 |
mriedem | but apparently forgot to add them for rocky | 20:51 |
mriedem | *in* stein | 20:51 |
*** jaypipes_ is now known as jaypipes | 20:51 | |
efried | I'm confused | 20:51 |
efried | then why is https://review.openstack.org/#/c/650964/ in master and not in stable/stein? | 20:51 |
mriedem | for example, latest cell db migration in stein is 391 https://github.com/openstack/nova/tree/stable/stein/nova/db/sqlalchemy/migrate_repo/versions so if we needed something in stable/stein, we'd have to add 392 in stable/stein and then copy that to the 392_placeholder in train | 20:51 |
mriedem | it's essentially a buffer, | 20:52 |
mriedem | because otherwise the first schema migration in train is 392 | 20:52 |
mriedem | so if we need something in stein but already used 392 in train, we're stuck | 20:52 |
efried | oh, so if we hadn't done any migrations in stein, we could set up the buffer for rocky. | 20:53 |
jaypipes | mriedem: instance_action_events.action_id will automatically have an index on it since it's an FK to instance_actions | 20:53 |
mriedem | rocky ended at 390 and there was one cell db migration in stein, 391 | 20:53 |
mriedem | so if we need something on rocky we're f'ed | 20:53 |
jaypipes | at least for mysql and pgsql it will. | 20:53 |
mriedem | jaypipes: ah ok, thanks. i seem to remember asking about this same query a year or more ago and came to the same conclusion (or you told me the same at the time) | 20:54 |
jaypipes | I think :) | 20:54 |
jaypipes | might want to have mnaser do a quick SHOW TABLE instance_action_events to verify | 20:54 |
mriedem | else i'm thinking action_id/deleted or something | 20:54 |
jaypipes | hmm, maybe not since we don't use SQLalchemy create_tables() | 20:55 |
mnaser | be back in my machine in a sec | 20:55 |
jaypipes | but if the FOREIGN KEY .. REFERENCES statement/clause is executed at any time (either by SQLAlchemy's declarative_base or using sqlalchemy-migrate) then there is indeed an index created on action_id | 20:56 |
jaypipes | lemme log into an ocata prod DB and check... | 20:56 |
jaypipes | mriedem, mnaser: verified. there is indeed an index on (action_id) | 20:58 |
mriedem | jaypipes: ok cool | 20:59 |
mriedem | efried: https://review.openstack.org/#/q/project:openstack/nova+status:open+path:%255Enova/db/sqlalchemy/migrate_repo/versions/.* :) | 20:59 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: WIP/PoC: Use SDK instead of ironicclient for node.get https://review.openstack.org/642899 | 21:02 |
efried | dustinc: That looks like a sane delta ^ | 21:03 |
efried | were you planning to push other patches on top of that at the same time? | 21:03 |
dustinc | not yet, I have them local but was just pushing that one for now | 21:03 |
mnaser | jaypipes: so the thing is I think it might be the deleted field | 21:04 |
mnaser | the query looked a something like this: UPDATE instance_actions_events SET deleted=instance_action_events.id WHERE action_id IN (SELECT id FROM instance_actions WHERE instance_uuid IN (SELECT uuid FROM instances WHERE deleted!=0)) | 21:05 |
mnaser | so you grab a list of all non deleted instances, then you grab all their instance actions, then you grab all the action ids associated to them | 21:05 |
mriedem | weeee https://github.com/openstack/nova/blob/fb1fee6772bb101eac83845bac9022df77113aaa/nova/db/sqlalchemy/api.py#L174 | 21:05 |
mriedem | mnaser: other way around - it's soft-deleting actions and events for deleted instances | 21:06 |
mriedem | deleted!=0 == soft-deleted | 21:06 |
mriedem | archive is the only thing that actually deletes actions/events | 21:06 |
mnaser | right, yeah, so it soft deletes them because for some reason we don't soft delete them by default? yeah | 21:06 |
mnaser | so if you haven't done that in a while, that can be.. a big dataset | 21:06 |
mriedem | mnaser: corret https://github.com/openstack/nova/blob/fb1fee6772bb101eac83845bac9022df77113aaa/nova/db/sqlalchemy/api.py#L1832 | 21:06 |
mriedem | *correct | 21:06 |
mnaser | oh neat | 21:07 |
mriedem | could be real big if you have lots of pets | 21:07 |
mnaser | or a cloud with a lot of VMs going up and down | 21:08 |
mnaser | is there an index on deleted | 21:08 |
*** wolverineav has joined #openstack-nova | 21:09 | |
mnaser | instances_host_deleted_cleaned_idx yes there is | 21:10 |
* tbachman looks at the number of nova jobs in the gate :-o | 21:15 | |
*** ttsiouts has joined #openstack-nova | 21:18 | |
*** wolverineav has quit IRC | 21:22 | |
mriedem | that's my fault | 21:23 |
*** wolverineav has joined #openstack-nova | 21:23 | |
mriedem | https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/cross-cell-resize | 21:23 |
* tbachman wants mriedem’s code-generation/-fixing script | 21:25 | |
*** gbarros has quit IRC | 21:27 | |
*** wolverineav has quit IRC | 21:28 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete require_instance_exists_using_uuid https://review.openstack.org/650994 | 21:33 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Soft delete virtual_interfaces when instance is destroyed https://review.openstack.org/650995 | 21:33 |
mriedem | very easy couple of changes ^ | 21:36 |
*** wolverineav has joined #openstack-nova | 21:37 | |
*** Sundar has joined #openstack-nova | 21:39 | |
*** Sundar has quit IRC | 21:39 | |
*** Sundar has joined #openstack-nova | 21:40 | |
*** Sundar has quit IRC | 21:40 | |
*** Sundar has joined #openstack-nova | 21:42 | |
*** tbachman has quit IRC | 21:44 | |
*** whoami-rajat has joined #openstack-nova | 21:45 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Drop delete_build_requests_with_no_instance_uuid online migration https://review.openstack.org/651001 | 21:47 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup https://review.openstack.org/603969 | 21:48 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Drop delete_build_requests_with_no_instance_uuid online migration https://review.openstack.org/651001 | 21:48 |
*** mchlumsky has quit IRC | 21:52 | |
*** sambetts_ has quit IRC | 21:55 | |
*** sambetts_ has joined #openstack-nova | 21:58 | |
*** ivve has quit IRC | 21:59 | |
mriedem | mordred: i added you to this nova spec https://review.openstack.org/#/c/603969/ about cleaning up old nasty cruft out of the compute API if you want to weigh in on your most hated UX stuff in the compute API | 21:59 |
*** wolverineav has quit IRC | 21:59 | |
mriedem | my personal most hated is the OS-EXT-* prefixes | 21:59 |
mriedem | i just want do do: server = GET /servers/id; host = server['host'] without looking up the API reference every time | 22:00 |
*** wolverineav has joined #openstack-nova | 22:02 | |
*** erlon has quit IRC | 22:05 | |
*** wolverineav has quit IRC | 22:06 | |
*** slaweq has quit IRC | 22:07 | |
*** Sundar has quit IRC | 22:07 | |
openstackgerrit | melanie witt proposed openstack/nova master: Add post-release checklist items to the PTL guide https://review.openstack.org/651009 | 22:10 |
*** wolverineav has joined #openstack-nova | 22:11 | |
openstackgerrit | melanie witt proposed openstack/nova master: Add post-release checklist items to the PTL guide https://review.openstack.org/651009 | 22:12 |
*** tbachman has joined #openstack-nova | 22:12 | |
dansmith | efried: what mriedem said | 22:12 |
*** mriedem has quit IRC | 22:13 | |
*** rcernin has joined #openstack-nova | 22:14 | |
*** tbachman has quit IRC | 22:14 | |
*** lbragstad has quit IRC | 22:14 | |
*** igordc has quit IRC | 22:18 | |
*** igordc has joined #openstack-nova | 22:18 | |
*** mlavalle has quit IRC | 22:19 | |
*** slaweq has joined #openstack-nova | 22:23 | |
*** slaweq has quit IRC | 22:27 | |
*** wolverineav has quit IRC | 22:33 | |
*** luksky has quit IRC | 22:33 | |
*** ttsiouts has quit IRC | 22:35 | |
*** ttsiouts has joined #openstack-nova | 22:36 | |
*** ttsiouts has quit IRC | 22:40 | |
*** wolverineav has joined #openstack-nova | 22:43 | |
*** wolverineav has quit IRC | 22:43 | |
*** wolverineav has joined #openstack-nova | 22:44 | |
efried | lyarwood, jungleboyj, mdbooth: I moved "Swap volume API woes" to the (shiny new) cinder-nova xproj etherpad | 22:44 |
efried | https://etherpad.openstack.org/p/ptg-train-xproj-nova-cinder | 22:44 |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: DNM: split me https://review.openstack.org/651020 | 22:50 |
*** dave-mccowan has quit IRC | 22:58 | |
*** tkajinam has joined #openstack-nova | 23:00 | |
*** Sundar has joined #openstack-nova | 23:01 | |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Tools & docs for backlog & abandoned spec process https://review.openstack.org/648800 | 23:11 |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Abandon flavor-classes backlog spec https://review.openstack.org/649095 | 23:14 |
*** mgoddard has quit IRC | 23:14 | |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Abandon same-instances-scheduling backlog spec https://review.openstack.org/649102 | 23:14 |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Abandon parallel-scheduler backlog spec https://review.openstack.org/649101 | 23:14 |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Abandon instance-tasks backlog spec https://review.openstack.org/649100 | 23:14 |
*** mgoddard has joined #openstack-nova | 23:15 | |
*** tetsuro has joined #openstack-nova | 23:15 | |
openstackgerrit | Ivens Zambrano proposed openstack/nova-specs master: RMD Plugin: Energy Efficiency using CPU Core P-State control The power state of a core can be setup between a minimum and the maximum frequency on the cores as defined in the factory. Each core on a CPU can be defined individually to perform at specific f https://review.openstack.org/651024 | 23:17 |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Abandon instance-tasks backlog spec https://review.openstack.org/649100 | 23:18 |
*** wolverineav has quit IRC | 23:19 | |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Abandon flavor-classes backlog spec https://review.openstack.org/649095 | 23:19 |
*** wolverineav has joined #openstack-nova | 23:19 | |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Abandon same-instances-scheduling backlog spec https://review.openstack.org/649102 | 23:20 |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Abandon parallel-scheduler backlog spec https://review.openstack.org/649101 | 23:20 |
*** wolverineav has quit IRC | 23:24 | |
*** wolverineav has joined #openstack-nova | 23:24 | |
*** wolverineav has quit IRC | 23:26 | |
*** wolverineav has joined #openstack-nova | 23:27 | |
eandersson | Does anyone have a example of using the JsonFilter for the Scheduler? :D | 23:30 |
*** wolverineav has quit IRC | 23:33 | |
eandersson | nvm found an example | 23:40 |
openstackgerrit | Ivens Zambrano proposed openstack/nova-specs master: RMD Plugin: Energy Efficiency using CPU Core P-State control The power state of a core can be setup between a minimum and the maximum frequency on the cores as defined in the factory. Each core on a CPU can be defined individually to perform at specific f https://review.openstack.org/651024 | 23:40 |
openstackgerrit | Ivens Zambrano proposed openstack/nova-specs master: RMD Plugin: Energy Efficiency using CPU Core P-State control The power state of a core can be setup between a minimum and the maximum frequency on the cores as defined in the factory. Each core on a CPU can be defined individually to perform at specific f https://review.openstack.org/651024 | 23:47 |
*** bbowen has quit IRC | 23:49 | |
*** bbowen has joined #openstack-nova | 23:49 | |
*** wolverineav has joined #openstack-nova | 23:50 | |
openstackgerrit | Ivens Zambrano proposed openstack/nova-specs master: RMD Plugin: Energy Efficiency using CPU Core P-State control The power state of a core can be setup between a minimum and the maximum frequency on the cores as defined in the factory. Each core on a CPU can be defined individually to perform at specific f https://review.openstack.org/651024 | 23:51 |
*** whoami-rajat has quit IRC | 23:58 | |
*** tosky has quit IRC | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!