Monday, 2019-04-15

*** lbragstad has joined #openstack-nova00:29
*** brinzhang has joined #openstack-nova00:38
*** Dinesh__Bhor has quit IRC01:19
*** Dinesh_Bhor has joined #openstack-nova01:21
openstackgerritzhufl proposed openstack/nova master: Remove conductor_api and cells_rpcapi from manager.py  https://review.openstack.org/65105901:22
*** cfriesen has quit IRC01:24
*** lbragstad has quit IRC01:50
*** masayukig has joined #openstack-nova01:55
openstackgerritBoxiang Zhu proposed openstack/nova master: [WIP] Fix live migration break group policy simultaneously  https://review.openstack.org/65196901:56
*** dave-mccowan has quit IRC02:03
*** igordc has joined #openstack-nova02:04
*** masayukig has quit IRC02:10
*** masayukig has joined #openstack-nova02:10
*** lbragstad has joined #openstack-nova02:12
openstackgerritGhanshyam Mann proposed openstack/nova master: Dropping the py35 testing  https://review.openstack.org/64387103:01
openstackgerritGhanshyam Mann proposed openstack/nova master: Dropping the py35 testing  https://review.openstack.org/64387103:07
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py  https://review.openstack.org/56615303:19
openstackgerritTakashi NATSUME proposed openstack/nova stable/rocky: Replace glance command with openstack command  https://review.openstack.org/63706003:20
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix cleaning up console tokens  https://review.openstack.org/63771603:20
*** psachin has joined #openstack-nova03:29
*** tonyb[m] has joined #openstack-nova03:40
*** igordc has quit IRC03:50
*** amodi has quit IRC03:59
*** bhagyashris has joined #openstack-nova04:01
*** imacdonn has quit IRC04:05
*** imacdonn has joined #openstack-nova04:06
*** ivve has quit IRC04:18
*** udesale has joined #openstack-nova04:24
*** whoami-rajat has joined #openstack-nova04:37
*** janki has joined #openstack-nova04:44
*** jaosorior has joined #openstack-nova04:48
*** hongbin has quit IRC04:49
*** brinzh has joined #openstack-nova04:57
*** bhagyashris has quit IRC04:58
*** brinzhang has quit IRC05:01
*** rcernin has quit IRC05:08
*** rcernin has joined #openstack-nova05:10
*** ivve has joined #openstack-nova05:27
*** tkajinam has quit IRC05:28
*** ratailor has joined #openstack-nova05:29
*** sridharg has joined #openstack-nova05:39
*** tkajinam has joined #openstack-nova05:54
*** Luzi has joined #openstack-nova05:59
openstackgerritFan Zhang proposed openstack/nova master: Log disk transfer stats in live migration monitor.  https://review.openstack.org/61939506:05
*** yaawang has quit IRC06:13
*** sapd1_x has joined #openstack-nova06:17
*** pcaruana has joined #openstack-nova06:19
*** belmoreira has joined #openstack-nova06:20
*** dpawlik has joined #openstack-nova06:21
*** udesale has quit IRC06:26
*** dpawlik has quit IRC06:27
*** ircuser-1 has quit IRC06:29
*** yaawang has joined #openstack-nova06:30
*** dpawlik has joined #openstack-nova06:31
*** toabctl has joined #openstack-nova06:32
*** yaawang has quit IRC06:40
*** tkajinam_ has joined #openstack-nova06:48
*** tkajinam has quit IRC06:51
*** lbragstad has quit IRC06:52
*** slaweq__ has joined #openstack-nova06:57
*** yaawang has joined #openstack-nova06:58
*** rcernin has quit IRC07:05
*** tesseract has joined #openstack-nova07:10
*** udesale has joined #openstack-nova07:17
*** slaweq__ is now known as slaweq07:18
*** tosky has joined #openstack-nova07:20
*** udesale has quit IRC07:20
*** udesale has joined #openstack-nova07:21
*** spotz has joined #openstack-nova07:22
*** udesale has quit IRC07:22
*** belmoreira has quit IRC07:24
*** rpittau|afk is now known as rpittau07:34
*** udesale has joined #openstack-nova07:43
*** belmoreira has joined #openstack-nova07:47
*** luksky has joined #openstack-nova07:50
*** ttsiouts has joined #openstack-nova07:54
*** ralonsoh has joined #openstack-nova08:01
*** takashin has left #openstack-nova08:02
*** tssurya has joined #openstack-nova08:06
*** phasespace has quit IRC08:08
kashyapgibi: Morning.  On the Secure Boot spec, thanks for your comment :-) -- https://review.openstack.org/#/c/506720/08:13
kashyapgibi: So if I refresh it with the additional answers to the questions discussed - I guess you're onboard with it.08:13
*** helenafm has joined #openstack-nova08:14
kashyap(And then I can finally get down to the code :D  I already have a WIP patch for some scaffolding work that's anyway required.)08:14
openstackgerritTushar Patil proposed openstack/nova-specs master: Support filtering of allocation_candidates by forbidden aggregates  https://review.openstack.org/60996008:19
openstackgerritTushar Patil proposed openstack/nova-specs master: Allow compute nodes to use DISK_GB from shared storage RP  https://review.openstack.org/65018808:20
*** tkajinam_ has quit IRC08:20
*** awalende has joined #openstack-nova08:22
*** dtantsur|afk is now known as dtantsur08:30
*** boxiang has quit IRC08:32
*** boxiang has joined #openstack-nova08:32
*** belmoreira has quit IRC08:32
*** belmoreira has joined #openstack-nova08:36
gibikashyap: I'm OK with your spec based on your answers08:37
kashyapgibi: Thank you.  I'll refresh it with some tiny wording tweaks, then you can have a final look, and then can hopefully get your ACK (+2)08:38
kashyapalex_xu: Hi, on the `cpu_model_list` spec, talking to the QEMU folks ... I'm not sure we should even do that (allowing a list of CPU models) at all.08:39
*** jangutter has joined #openstack-nova08:39
kashyapgibi: Got an Ubuntu machine by any chance?  If so can you please post the output of equivalent on Ubuntu?08:40
*** udesale has quit IRC08:40
kashyap(Err, broken copy/paste)08:40
*** udesale has joined #openstack-nova08:40
kashyapOutput of: `dpkg --listfiles ovmf`08:40
kashyap(Or whatever the package is called on Ubuntu)08:40
kashyapgibi: Actually, disregard me, found this: https://packages.ubuntu.com/xenial/all/ovmf/filelist08:41
*** sapd1_x has quit IRC08:42
gibikashyap: this is from a bionic VM  http://paste.openstack.org/show/749298/08:44
* kashyap clicks08:45
kashyap(Yep, that's good.  Thank you.)08:45
gibinp08:45
kashyapSo Ubuntu just does what Debian does08:45
*** ttsiouts has quit IRC08:51
*** ttsiouts has joined #openstack-nova08:51
*** ttsiouts has quit IRC08:56
openstackgerritBoxiang Zhu proposed openstack/nova master: [WIP] Add host and hypervisor_hostname flag to create server  https://review.openstack.org/64552009:03
*** ttsiouts has joined #openstack-nova09:12
*** janki has quit IRC09:14
*** ttsiouts has quit IRC09:17
openstackgerritBrin Zhang proposed openstack/nova master: wip: Non-admin user can filter servers by user_id  https://review.openstack.org/65260209:26
*** avolkov has joined #openstack-nova09:35
*** cdent has joined #openstack-nova09:46
openstackgerritBalazs Gibizer proposed openstack/nova-specs master: Server move operations with ports having resource request  https://review.openstack.org/65260809:47
*** zbr has joined #openstack-nova09:48
*** zbr__ has quit IRC09:50
*** ttsiouts has joined #openstack-nova09:51
*** panda has joined #openstack-nova09:51
*** udesale has quit IRC09:54
*** udesale has joined #openstack-nova09:55
*** janki has joined #openstack-nova10:01
openstackgerritBoxiang Zhu proposed openstack/nova master: [WIP] Fix live migration break group policy simultaneously  https://review.openstack.org/65196910:09
*** belmoreira has quit IRC10:14
*** belmoreira has joined #openstack-nova10:18
aspierssean-k-mooney, efried: hoping to have a new version of the SEV spec submitted in the next few hours10:22
sean-k-mooneyaspiers: cool good to know10:24
sean-k-mooneyaspiers: have you added it to the review day etherpad10:24
sean-k-mooneyi think it was there last week10:24
*** udesale has quit IRC10:25
stephenfinCan someone sanity check this and tell me how I've changed the logic? https://review.openstack.org/#/c/651554/3/nova/compute/api.py10:25
stephenfin(tests are failing so I've obviously broken _something http://logs.openstack.org/54/651554/3/check/openstack-tox-py27/d5489c5/testr_results.html.gz)10:25
aspierssean-k-mooney: I am definitely intending to - I thought it wasn't really ready for more feedback yet until we address the existing concerns10:25
sean-k-mooneystephenfin: looking10:25
aspierssean-k-mooney: my new patchset will be mostly just including the new info and suggestions from you / Daniel / Brijesh10:25
*** ttsiouts has quit IRC10:26
*** udesale has joined #openstack-nova10:26
sean-k-mooneystephenfin: im gessing the addtion of  " and service_host is none"10:26
stephenfinThat reads to me like I'm moving the third case in the if-else to the first10:27
sean-k-mooneyactully no that is just the else block10:27
stephenfinyeah10:27
sean-k-mooneystephenfin: where do you call the new lookup_fn fucntion10:28
stephenfinsean-k-mooney: line 5002 on the right10:28
stephenfinmaybe the 'target_cell' context manager is doing something weird? :/10:28
sean-k-mooneyit shouldnt10:29
sean-k-mooneywhy are you doing this refactoring by the way. to get rid of the pep8 warning about lamdas should not be named?10:30
stephenfinsean-k-mooney: Yeah. I was going to noqa that particular one but for some reason I can't do that10:30
sean-k-mooneystephenfin: why are you not passing in service_id by the way10:32
stephenfinwhere now?10:32
sean-k-mooneyhttps://review.openstack.org/#/c/651554/3/nova/compute/api.py@498910:33
stephenfinsean-k-mooney: You don't need to for nested functions. They have access to everything in their parent's10:34
kashyapstephenfin: Hey there, an rST references question: just by looking at this rendering, can you tell why the '7' and '8' are funny like that? -- https://kashyapc.fedorapeople.org/Broken-rST-references.png10:34
sean-k-mooneythey do but it might mess with mocking10:34
stephenfinkashyap: Not a clue. That's rather odd looking. Indentation is usually the #1 cause of odd stuff like that though10:35
kashyapAh, I know!10:35
kashyapstephenfin: They're both referenced _twice_ in the document10:35
stephenfinOh, that's interesting10:36
kashyapAs in, two occurrences of each.  How can I accomplish that without this funnynnes (is it a word?)?10:36
stephenfin*funniness10:36
kashyapDamn, that's what I wrote at first10:36
kashyapThanks :-)10:36
stephenfintbh, I've no idea. I would _suspect_ it's a theming thing10:37
stephenfini.e. there's a reference number then cross references to where they're called, and we're sometimes using the latter where we should be using the former. That's a total guess though10:37
kashyapHmm, so I have to just reference it once.  Okheeee, not a big issue10:37
stephenfinOr just live with that weirdness10:38
stephenfinseeing as it's purely stylistic10:38
kashyapHehe.  I adjusted the text to make-do with just one reference.10:39
kashyapThanks for your response, though.10:39
openstackgerritKashyap Chamarthy proposed openstack/nova-specs master: Add "Secure Boot support for KVM & QEMU guests" spec  https://review.openstack.org/50672010:40
openstackgerritKashyap Chamarthy proposed openstack/nova-specs master: Add "Secure Boot support for KVM & QEMU guests" spec  https://review.openstack.org/50672010:40
sean-k-mooneystephenfin: kashyap by the way i dont know if ye saw my mailing list post but i got this working on saturday https://review.openstack.org/#/c/652197/10:41
*** belmoreira has quit IRC10:42
stephenfinsean-k-mooney: Aha, sussed it (I think)10:43
stephenfinhttps://review.openstack.org/#/c/651554/3/nova/compute/api.py@499110:43
*** tbachman has quit IRC10:43
stephenfinsean-k-mooney: https://review.openstack.org/#/c/651554/3/nova/compute/api.py@501110:43
stephenfinLooks like scoping rules mean variables set in a nested function have their own scope so I need to use something like global10:43
openstackgerritBalazs Gibizer proposed openstack/nova-specs master: Server move operations with ports having resource request  https://review.openstack.org/65260810:44
sean-k-mooneystephenfin: yes they do10:44
sean-k-mooneyand no just use mulitple return values10:44
sean-k-mooneyreturn is_uuid, ...10:45
kashyapsean-k-mooney: Yep, saw that fly-by on the list10:45
kashyapCool, you're using the MTTCG backend10:45
sean-k-mooneyya unfortunetly libvirt decided not to expose an xml element for it10:46
sean-k-mooneyso the best we can do is to use a cpu model that support mttcg10:46
kashyapFile an RFE for libvirt, if you see a valid use?10:46
sean-k-mooneyqemu64 should fit that requirement10:46
sean-k-mooneykashyap: they intentionally chose not to but i think it makes consumtion in openstack harder10:47
kashyap(But 'qemu64' is also an awful CPU to use in general (I know we're just testing) :-( -- because it can't get the Spectre/Meltdown fixes)10:47
*** alex_xu has quit IRC10:47
sean-k-mooneykashyap: it does not need them10:47
kashyapTODO: Move away from 'qemu64' even for testing10:47
sean-k-mooneykashyap: its an emulated cpu and therefor should not need to emulate the vulnerablity10:48
sean-k-mooneyyou can fix specter and meltdown entirely in qemu for qemu6410:48
sean-k-mooneyif they havent that is a qemu bug10:48
sean-k-mooneyso i dont see any reason to move away form qemu64 for testing10:49
kashyapsean-k-mooney: So back to that MTTCG thing, I saw the rationale on the libvirt list:10:49
kashyap[quote]10:49
kashyapWe don't have anything in the domain XML that indicates10:49
kashyapwhether a guest is using TCG or MTTCG. While QEMU does10:49
kashyaphave an option (-accel tcg,thread=single|multi), it is10:49
kashyapnot desirable to expose this in libvirt. QEMU will10:49
sean-k-mooneyyes i know i read it10:49
kashyapautomatically use MTTCG when the host/guest architecture10:49
kashyappairing is known to be safe. Only developers of QEMU TCG10:49
kashyapAh, okay10:49
kashyaphave a strong reason to override this logic.10:49
kashyap[/quote]10:49
kashyapIt is reasonable10:49
stephenfinsean-k-mooney: Came up with something even better (IMO)10:50
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve E731 (do not assign a lambda expression, use a def)  https://review.openstack.org/65155410:50
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve W503 (line break occurred before a binary operator)  https://review.openstack.org/65155510:50
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve E741 (ambiguous variable name)  https://review.openstack.org/65210310:50
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence)  https://review.openstack.org/65210410:50
sean-k-mooneykashyap: i dont think so10:50
stephenfinback to real work10:50
sean-k-mooneykashyap: we really want to know if its enabeld or not so we can fail to boot the vm if its not10:50
kashyapHmm.  Then file a libvirt RFE telling a management tool has a user for it :-)10:51
sean-k-mooneyi could i was going to ping dan donwstream and get his input first.10:52
sean-k-mooneykashyap:  i had stared working on enableing mttcg as a new virt_type when i came across the ml post where they said it was not exposed10:52
sean-k-mooneybut anyway that can wait.10:53
sean-k-mooneystephenfin: do you have a like to your fixed version?10:53
sean-k-mooneyactully never mind ill jsut refresh :)10:53
stephenfinyeah, it's the one I just pushed there :)10:53
sean-k-mooneyi mean it works. i still dislike you using variable form the enclosing scope but ya it should work10:55
sean-k-mooneyand you dont have to change the call site10:55
sean-k-mooneystephenfin: do we still have cases where the service id is not a uuid by the way?10:57
kashyapsean-k-mooney: On your comment that: upstream QEMU should fix 'qemu64' entirely for Spectre/Meltdown.  It's a non-goal:10:58
kashyap"TCG is not suitable for containing malicious code, so we don't need to worry about hardening against guests using spectre to exploit the JIT"10:58
sean-k-mooneykashyap: by the way one of the reasons i was interested in teh mttcg backend was the ability to emulate other achitecutres without the horible performacne cost10:58
kashyapsean-k-mooney: Yeah, can imagine (on MTTCG)10:58
sean-k-mooneykashyap: :(10:59
kashyapsean-k-mooney: I don't think it's (no security guarantees for TCG) an issue for us: as the upstream CI isn't running any real workloads in the L210:59
sean-k-mooneyyou can do it today by using a custom cpu_model + setting the machine type and qemu backend10:59
sean-k-mooneykashyap: ya11:00
kashyap(So we're good, there.)11:00
sean-k-mooneythe reason i went for qemu64 was to make sure it could run on all the ci cloud providers11:00
sean-k-mooneyevent the xen based ones11:00
sean-k-mooneyand it should be supported by mttcg as it uses the smallest feature set11:01
* kashyap --> lunch; bbiab11:01
sean-k-mooneystephenfin: by the way looking at https://review.openstack.org/#/c/652197/7/playbooks/nfv/nfv.yaml can you think of an epa/numa feature i have missed beyond 2 numa nodes?11:02
*** ttsiouts has joined #openstack-nova11:03
sean-k-mooneystephenfin: im going to test ovs-dpdk in a different job11:04
openstackgerritMerged openstack/nova stable/stein: Adding tests to demonstrate bug #1821824  https://review.openstack.org/64960011:06
openstackbug 1821824 in OpenStack Compute (nova) stein "Forbidden traits in flavor properties don't work" [High,In progress] https://launchpad.net/bugs/1821824 - Assigned to Eric Fried (efried)11:06
*** weshay_pto has quit IRC11:12
*** weshay_pto has joined #openstack-nova11:13
*** alex_xu has joined #openstack-nova11:19
*** panda is now known as panda|lunch11:23
openstackgerritMerged openstack/nova stable/stein: Fix bug preventing forbidden traits from working  https://review.openstack.org/64960111:29
*** belmoreira has joined #openstack-nova11:30
sean-k-mooney:) ^11:30
sean-k-mooneycool its already proposed to be backported to rocky as well :)11:31
*** erlon has joined #openstack-nova11:32
*** luksky has quit IRC11:41
*** mvkr has joined #openstack-nova11:48
openstackgerritMerged openstack/python-novaclient stable/stein: Add test for console-log and docs for bug 1746534  https://review.openstack.org/65192511:54
openstackbug 1746534 in python-novaclient "encoding error when doing console-log" [High,Fix released] https://launchpad.net/bugs/1746534 - Assigned to Thomas Goirand (thomas-goirand)11:54
*** tbachman has joined #openstack-nova12:07
*** panda|lunch is now known as panda12:08
*** ttsiouts has quit IRC12:11
*** ttsiouts has joined #openstack-nova12:11
*** brinzh has quit IRC12:13
openstackgerritBalazs Gibizer proposed openstack/nova-specs master: Server move operations with ports having resource request  https://review.openstack.org/65260812:14
*** luksky has joined #openstack-nova12:14
*** ttsiouts has quit IRC12:16
*** ttsiouts has joined #openstack-nova12:19
*** nicolasbock has joined #openstack-nova12:35
kashyapgibi: Does this require a Blueprint (much less a "spec"): https://bugs.launchpad.net/nova/+bug/178986812:35
openstackLaunchpad bug 1789868 in OpenStack Compute (nova) "RFE: Add a virtio-rng device to Nova instances by default" [Medium,In progress] - Assigned to s10 (vlad-esten)12:35
*** tosky has quit IRC12:36
kashyapI'd actually classify it as a "bug".  But, whatever :-)  (We already have a patch up for it, though: https://review.openstack.org/#/c/616603/)12:37
* kashyap just files one12:44
gibikashyap: I'm fine going with that bug report12:46
kashyapgibi: Ah, okay, then.12:46
*** davidsha has joined #openstack-nova12:46
gibikashyap: just a question. Could this change cause that on guest can deplete the enthropy pool of the host and therefore cause troubles on the host or in other guests?12:47
kashyapWasn't sure if the 'process hammer' would come to bite me in the behind ...12:47
gibikashyap: at least not my process hammer...12:47
kashyap(Heh)12:47
kashyapgibi: No, it won't.  But let me quadruple-check with the RNG experts12:47
kashyapgibi: Confirmed: One guest can't do that.12:52
kashyapWhere "that"  == deplete the entropy pool of the host12:52
*** ratailor has quit IRC12:55
gibikashyap: OK. thanks12:55
*** belmoreira has quit IRC12:57
*** boxiang has quit IRC12:57
*** boxiang has joined #openstack-nova12:58
*** udesale has quit IRC12:59
*** udesale has joined #openstack-nova13:02
*** udesale has quit IRC13:03
*** udesale has joined #openstack-nova13:03
*** belmoreira has joined #openstack-nova13:03
openstackgerritStephen Finucane proposed openstack/nova master: Add TODO to remove function attribute  https://review.openstack.org/65264913:04
stephenfingibi: If you have a chance, could you look at https://review.openstack.org/#/c/651302/1/nova/objects/instance.py and see if I'm doing anything particular wrong?13:05
kukaczhi, I wonder if nova handles situation of live-migrating an instance with config drive from rbd-backed compute host to file-backed compute host and vice versa? it seems I'm stuck in Ocata with instance resized from rbd-backed to raw-backed compute node, not willing to live-migrate in the other direction13:07
kukaczit's a volume-booted instance. the issue is about config drive13:09
*** lbragstad has joined #openstack-nova13:14
gibistephenfin: replied to the notification part. I wasn't to helpful, sorry.13:19
stephenfingibi: Neither was I so that makes two of us. Thanks :)13:19
gibistephenfin: I think you need dansmith for this13:21
*** mriedem has joined #openstack-nova13:24
*** takashin has joined #openstack-nova13:24
*** jroll has quit IRC13:25
*** jroll has joined #openstack-nova13:26
*** amodi_ has joined #openstack-nova13:27
*** amodi_ is now known as amodi13:27
*** burt has joined #openstack-nova13:33
openstackgerritStephen Finucane proposed openstack/nova master: conf: Undeprecate and move the 'dhcp_domain' option  https://review.openstack.org/48061613:37
openstackgerritStephen Finucane proposed openstack/nova master: Handle unsetting '[DEFAULT] dhcp_domain'  https://review.openstack.org/65266213:37
*** eharney has joined #openstack-nova13:37
*** awalende has quit IRC13:38
efriedboxiang: Do you mind if I do a quick edit of https://review.openstack.org/#/c/645458/ for grammar?13:43
*** bnemec has joined #openstack-nova13:46
mriedemlyarwood: questions in your swap volume migration_status patch https://review.openstack.org/#/c/637224/13:51
mriedemlyarwood: looks like there could be some weird edge cases13:51
*** priteau has joined #openstack-nova13:51
*** tetsuro has joined #openstack-nova13:54
*** tbachman has quit IRC13:54
*** tbachman has joined #openstack-nova13:57
mriedemefried: please don't since there are major issues now in that spec13:58
mriedemi.e. persisting RequestSpec.requested_destination now13:59
mriedemplease dear sweet baby jesus in heaven no13:59
efriedmriedem: Yup, Above comment was before those came in. So now I'll just mark up the issues so boxiang can fix them on the next spin.13:59
boxiangefried: ok13:59
efriedmriedem: Did you see the discussion between boxiang and alex_xu in PS13 on persisting?13:59
mriedemyes, and i disagree13:59
mriedemi'm commenting13:59
cdentplacement meeting in now ish in #openstack-meeting-alt14:00
mriedemi'm sure dansmith is also not going to be cool with starting to persist RequestSpec.requested_destination now14:00
alex_xumriedem: we persistent the requested_desitnation now14:01
*** cfriesen has joined #openstack-nova14:01
mriedemalex_xu: no we don't14:01
mriedemif you mean force_hosts/force_nodes, yes, and that's likely a mistake14:01
alex_xuso why we reset the requested_destination when migration?14:01
mriedemthat's not requested_destination14:01
mriedemthere is literally a field called requested_destination,14:01
mriedembut that's not what reset_forced_destinations resets14:02
mriedemreset_forced_destinations exists solely because we made the mistake of persisting force_hosts/force_nodes14:02
boxiangmriedem: the requestec_destination of request spec is always null in db now?14:02
alex_xuoh...14:02
mriedemi've commented if you want details and history/examples https://review.openstack.org/#/c/645458/14:03
mriedembut i've been working on fixing these bugs for a long time now14:03
mriedemso i don't really want to undo that work here14:03
alex_xuok, if so, I agree with that, that is what i'm thinking initial until I missed read reset_forced_destinations method14:04
mriedemthat method is a hack14:05
mriedemto workaround persistence we shouldn't be doing14:05
alex_xubut I'm pretty ensure we can migration the instance again without the initial forced host14:05
*** udesale has quit IRC14:05
mriedemyes we can because of reset_forced_destinations14:05
mriedemotherwise you couldn't ever evacuate or live migrate a forced host/node server14:06
alex_xuwithout the initial of requested_destination :)14:06
alex_xuyes14:06
*** Luzi has quit IRC14:07
mriedemthe main concern / justification i saw for persisting requested_destination in this spec was for the rebuild from cell0 case,14:08
mriedembut i think i've already pointed out things in that rebuild from cell0 spec that the user will lose from the initial server create if they rebuild from cell014:08
mriedembecause the rebuild API doesn't match the server create parameters 1:114:08
mriedemhttps://review.openstack.org/#/c/648686/1/specs/train/approved/enable-rebuild-for-instances-in-cell0.rst@7214:09
*** awalende has joined #openstack-nova14:10
alex_xumriedem: yes, agree with that. so that should be resolved by rebuild spec, right?14:10
alex_xuor you want to process in this spec14:11
alex_xuat least, there need a way to persistent requested_destination for the fail boot instance14:11
mriedemalex_xu: i really don't want to talk about rebuild from cell0 in *this* spec :)14:11
alex_xumriedem: cool :)14:11
mriedem"there need a way to persistent requested_destination for the fail boot instance" is debateable14:12
alex_xuha14:12
mriedemi agree with your assertion in boxiang's spec that we should just say you can move the server even if you requested that it was built on a specific host14:12
mriedemthe rest is implementation detail14:12
alex_xuok, thanks14:13
*** awalende has quit IRC14:14
mriedemalex_xu: i think we can cross the rebuild from cell0 bridge for this later if needed, i.e. we could either add the host/hypervisor_hostname parameters to the rebuild api to mirror the server create api (i don't love that idea) or we could do something like store the requested destination in the instance system_metadata when burying it in cell0, and then on rebuild from cell0, use those values and wipe the system metadata so i14:19
mriedemrestricted to rebuild from cell0 cases14:19
mriedemrebuild from cell0 is definitely going to have weird corner cases like this since the rebuild api doesn't mirror the server create api14:21
mriedemalex_xu: btw, are you feeling better?14:21
alex_xumriedem: yes, like the system_metadata better than the change rebuild API also14:21
alex_xumy initial thoughts is persistent the requested_destination, and reset it when we spawn successful, but I see now, you will hate that :)14:22
alex_xuit is urgly indeed14:22
mriedemmy sysmeta + rebuild from cell0 idea isn't much different14:22
*** awaugama has joined #openstack-nova14:23
mriedembut RequestSpec.requested_destination specifically is off limits for persisting i think - the code already explicitly does not persist it14:23
alex_xuyea14:25
alex_xuat least no better idea yet14:25
mriedemgibi: how would you like me to address this? https://review.openstack.org/#/c/651945/1/nova/cmd/manage.py@209414:26
mriedemcall out verify_instance and map_instances specifically14:27
mriedem?14:27
kashyaplyarwood: Heya, on your question on that Secure Boot spec about why not libguestfs API helpw ith "enrolling UEFI keys", I've answered it here: https://review.openstack.org/#/c/506720/8/specs/train/approved/allow-secure-boot-for-qemu-kvm-guests.rst@28714:27
kashyaplyarwood: In short, it doesn't make sense for libguestfs to do so -- as the key enrollment happens in the (virtual) BIOS14:27
kashyaplyarwood: I also ran it past the libguestfs folks, and FWIW, they too agree with what I suggested -- just use the external tool.14:28
alex_xumriedem: I get better soon in few days, but my daughter get sick also. get blame by whole family :)14:28
gibimriedem: give the deployer some hint about what to do. If there are nova-manage CLIs the call then mention those14:28
*** janki has quit IRC14:29
mriedemalex_xu: heh, i suppose from all the travel over the holiday14:29
mriedemgibi: ok done14:29
gibimriedem: thanks14:29
*** sridharg has quit IRC14:30
*** awaugama has quit IRC14:31
kashyaplyarwood: (And, thanks for the review!)14:31
kashyapgibi: If you want to re-ACK, in your "copious free time" :-) -- https://review.openstack.org/#/c/506720/14:32
*** mlavalle has joined #openstack-nova14:32
openstackgerritMerged openstack/nova stable/ocata: Fix disk size during live migration with disk over-commit  https://review.openstack.org/53074414:33
openstackgerritMerged openstack/nova stable/ocata: Refix disk size during live migration with disk over-commit  https://review.openstack.org/63137614:33
gibikashyap: ping me tomorrow please14:34
openstackgerritAdam Spiers proposed openstack/nova-specs master: Re-approve AMD SEV support for Train  https://review.openstack.org/64199414:34
kashyapgibi: Sure, thanks14:34
aspierssean-k-mooney, efried: new version of spec^^^14:34
openstackgerritMatt Riedemann proposed openstack/nova master: Add --instance option to heal_allocations  https://review.openstack.org/65194514:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add BFV wrinkle to TestNovaManagePlacementHealAllocations  https://review.openstack.org/65194814:35
efriedaspiers: ack, put r on the etherpad14:36
aspierswill do14:36
*** lpetrut has joined #openstack-nova14:36
efriedI'm going to take today off, folks. See you tomorrow. o/14:39
*** efried is now known as efried_pto14:39
openstackgerritAdam Spiers proposed openstack/nova-specs master: Re-approve AMD SEV support for Train  https://review.openstack.org/64199414:40
*** tetsuro has quit IRC14:41
dansmithmriedem: was on a call when you pinged earlier.. do I need to read back?14:42
*** awaugama has joined #openstack-nova14:45
stephenfindansmith: I don't know what you're referring to with mriedem, but if you've 2 minutes to sanity check this discussion between efried and I, I'd appreciate it https://review.openstack.org/#/c/651302/1/nova/objects/instance.py14:46
*** hongbin has joined #openstack-nova14:48
dansmithstephenfin: which, about the notifications?14:48
stephenfinyeah14:48
stephenfinassuming you know. If not, we'll have to go with our (hopefully not too creative) interpretation of what it's doing :)14:49
*** ttsiouts has quit IRC14:50
*** ttsiouts has joined #openstack-nova14:51
*** ttsiouts has quit IRC14:52
*** ttsiouts has joined #openstack-nova14:52
mriedemdansmith: i don't think so14:52
dansmithmriedem: okay14:52
dansmithstephenfin: I don't really, but I added words14:56
stephenfinWords are good. Thanks14:57
*** takashin has left #openstack-nova15:00
openstackgerritMerged openstack/nova stable/pike: Fix incompatible version handling in BuildRequest  https://review.openstack.org/64755715:04
*** tosky has joined #openstack-nova15:08
mriedemstephenfin: there is something wrong in the reno in https://review.openstack.org/#/c/651291/ plus some other FUP stuff - do you want me to just +W and then you can start a FUP change for that patch?15:14
stephenfinmriedem: Yes please. It's a huge series15:15
stephenfinI've got one follow-up at the end already15:15
sean-k-mooneymriedem: by the way similar to https://bugs.launchpad.net/nova/+bug/1790204 but on the nova side we cant support inplace resize for numa instances due to how the numa toplogy filter or more acurally the nova.virt.hardware module is implemented15:15
openstackLaunchpad bug 1790204 in OpenStack Compute (nova) "Allocations are "doubled up" on same host resize even though there is only 1 server on the host" [High,Triaged]15:15
mriedemstephenfin: ok there are probably enough in here to give it its own fup patch but i'll approve15:16
sean-k-mooneymriedem: so even if ^ is fix for numa instance it can still failt if the host is full15:16
openstackgerritFrançois Palin proposed openstack/nova master: Include all network devices in nova diagnostics  https://review.openstack.org/64812315:16
sean-k-mooneyi had breifly disccused supporing inplacee resize for numa instance downstream as we had a customer request realted to it but wanted to wait until the ptg to see how things panned out15:19
mriedemsean-k-mooney: ok i haven't put any thought into numa for that bug, just the simple resource class cases15:20
*** markvoelker has joined #openstack-nova15:20
sean-k-mooneywell its an issue with the resouce track side not placement.15:20
sean-k-mooneyif we do "fix" it want i wanted to ask is shoudl i be a bug or a blueprint15:21
sean-k-mooneye.g. is it feature or an oversitght/bug15:21
sean-k-mooneyin the context of fixing https://bugs.launchpad.net/nova/+bug/1790204 you can ignore numa. im just wonderinf what i should be filing for the numa same host resize/rebuild case bug/spec/blueprint15:23
openstackLaunchpad bug 1790204 in OpenStack Compute (nova) "Allocations are "doubled up" on same host resize even though there is only 1 server on the host" [High,Triaged]15:23
*** luksky has quit IRC15:27
*** ttsiouts has quit IRC15:30
*** ivve has quit IRC15:31
mriedemstephenfin: another reno fix needed for https://review.openstack.org/#/c/651294/ in a fup somewhere,15:34
adriancmriedem: Hi, was hoping to get your inputs on https://review.openstack.org/#/c/649345, it seems that _heal_instance_info_cache updates port binding:host_id to point to the compute host. while this is OK for most cases, its problematic for baremetal with Smart NIC https://storyboard.openstack.org/#!/story/200334615:34
stephenfinack15:34
mriedemand probably want melwitt to answer the question about what map_cell_and_hosts is used for15:34
sean-k-mooneyadrianc: that periodic task was not intended to run for ironic nodes. at least how its written it was apparently assuming it was running no a vm host15:36
mriedemadrianc: that's a regression due to https://review.openstack.org/#/c/603844/ right?15:36
*** slaweq has quit IRC15:36
mriedembefore ^ that periodic wouldn't mess with port bindings15:36
adriancsean-k-mooney: yea i know, hence i think it should not run on BM :)15:37
adriancmriedem: yes that is correct15:38
*** gyee has joined #openstack-nova15:38
openstackgerritBoxiang Zhu proposed openstack/nova-specs master: Add host and hypervisor_hostname flag to create server  https://review.openstack.org/64545815:38
sean-k-mooneywell for ironic nodes it could update teh port binding for the ironic node instead of skiping but ya we didnt think about that usesece with the previous patch15:39
adriancis the BM use-case relevant for this type of healing ?15:40
mriedemadrianc: comments inline15:41
sean-k-mooneyadrianc: im not sure15:41
mriedemadrianc: before that change the periodic task was essentially read-only as far as the ports are concerned, nova would just refresh it's internal cache15:41
adriancthanks mriedem, appreciated15:41
mriedemwhat you need to avoid in the BM case is the update to the port15:41
sean-k-mooneyi know we cna do boot form volume with ironic now15:41
sean-k-mooneydo we supprot resize/cold migrate15:42
sean-k-mooneyin principal if we did then yes we coudl have the same failure cases15:42
mriedemno we don't15:43
sean-k-mooneyok there is no reason that should not be supported for boot form volume ironic instance right?15:45
sean-k-mooneyi guess there is the quetion of ephemeral storage15:46
mriedemthere was a spec for supporting migration of ironic instances, you could read the details there15:46
mriedemhttps://review.openstack.org/#/c/449155/15:47
sean-k-mooneyif it was a pure bfv ironic node with no local disk it should work. no im jsut trying to reson about if we would need to validate neutron port for ironic instance in the future15:47
mriedemanyway, that doesn't really have anything to do with this change IMO15:47
mriedemjust avoid the port binding update if ironic to get back to the pre-regression behavior15:47
*** igordc has joined #openstack-nova15:47
sean-k-mooneyya i was leaving a comment to say somthign similar15:47
sean-k-mooneyjust wondering if we will need to do something more involed in the future15:48
sean-k-mooneybut to fix the regress we jus tneed to not to the port binding update here https://review.openstack.org/#/c/649345/4/nova/compute/manager.py@7331115:48
sean-k-mooneysorry here https://review.openstack.org/#/c/649345/4/nova/compute/manager.py@731115:49
sean-k-mooneyextra 315:49
adrianca noob's question here, but why would nova attempt to fix something that ironic did ? that is, ironic is the once who does the actual port binding today right ?15:50
mriedemmelwitt: you should review this part of the cells v2 removal series regarding console stuff https://review.openstack.org/#/c/651295/15:50
mriedemadrianc: the regression was just an oversight15:50
sean-k-mooneyadrianc: it depends on the workflow. for spawn yes the virt dirver does the binding15:50
sean-k-mooneyadrianc: this was trying to fix move opertion for virt dirver that supprot them15:51
*** igordc has quit IRC15:51
sean-k-mooneyfor live migration the conductor does the binidng15:51
adriancunderstood, sean-k-mooeny, was just addressing what you said about, "just wondering if we will need to do something more involed in the future"15:52
sean-k-mooneyadrianc: ah well if we support move operation maybe we shoudl be honestly this is only here because we dont cleanup thing correctly on revert or failed migration in all cases15:53
sean-k-mooneyadrianc: if we did we would not need to heal the info cache15:53
openstackgerritDan Smith proposed openstack/nova master: Add image type capability flags and trait conversions  https://review.openstack.org/65271015:55
openstackgerritBalazs Gibizer proposed openstack/nova-specs master: Server move operations with ports having resource request  https://review.openstack.org/65260815:55
*** belmoreira has quit IRC15:59
*** luksky has joined #openstack-nova16:05
openstackgerritStephen Finucane proposed openstack/nova-specs master: Standardize CPU resource tracking  https://review.openstack.org/55508116:07
mriedembauzas: could take a look at these backports? https://review.openstack.org/#/q/topic:bug/1821594+branch:stable/rocky16:07
*** lpetrut has quit IRC16:08
openstackgerritMerged openstack/nova stable/ocata: Update port device_owner when unshelving  https://review.openstack.org/62641316:11
*** boxiang has quit IRC16:16
*** boxiang has joined #openstack-nova16:17
*** tesseract has quit IRC16:21
sean-k-mooneythe periodic task is ment to heal all instance that need to be healed on each invocation right?16:23
sean-k-mooneybecause if it is, that is not what it actully does16:24
sean-k-mooneyoh actully reading the doc string that was intentional?16:25
*** slaweq has joined #openstack-nova16:25
*** rpittau is now known as rpittau|afk16:28
*** slaweq_ has joined #openstack-nova16:29
openstackgerritMatt Riedemann proposed openstack/nova master: Enable test_volume_backed_live_migration in tempest  https://review.openstack.org/52810416:31
*** slaweq has quit IRC16:31
*** ivve has joined #openstack-nova16:35
openstackgerritMerged openstack/nova stable/queens: Ignore VolumeAttachmentNotFound exception in compute.manager  https://review.openstack.org/63739116:37
*** jmlowe has joined #openstack-nova16:39
*** psachin has quit IRC16:42
*** dtantsur is now known as dtantsur|afk16:44
*** priteau has quit IRC16:47
*** priteau has joined #openstack-nova16:49
*** jmlowe has quit IRC16:50
tssuryadansmith: about the power update event spec (https://review.openstack.org/#/c/636132/4/specs/train/approved/nova-support-instance-power-update.rst) whenever you have the time could you confirm the things discussed at L77 and L74 ? main concern being the notifications/action record requirement16:53
tssuryathanks! :)16:53
*** davidsha has quit IRC16:54
*** tssurya has quit IRC16:58
*** pacharya has joined #openstack-nova17:09
*** boxiang has quit IRC17:10
*** zhubx has joined #openstack-nova17:10
*** ralonsoh has quit IRC17:14
*** cdent has quit IRC17:21
openstackgerritMatt Riedemann proposed openstack/nova master: Remove ComputeDriver.macs_for_instance method  https://review.openstack.org/65273717:22
*** ivve has quit IRC17:22
*** _erlon_ has joined #openstack-nova17:25
*** amodi has quit IRC17:26
*** jmlowe has joined #openstack-nova17:30
pacharyaa quick question, does creation of a batch instance delete API fall under https://docs.openstack.org/nova/latest/contributor/project-scope.html#no-more-orchestration ?17:30
_erlon_Folks, Im trying to debug a failure on the instance creation on Nova, on a Pike release, but all I get is " Got no allocation candidates from the Placement API" and no explanation on what resource is lacking:17:31
_erlon_http://paste.openstack.org/show/749318/17:31
_erlon_look at the placement API logs also does not help17:32
_erlon_I didn't had this problem before the placement API was introduced17:32
_erlon_what is the procudure now?17:32
*** slaweq_ has quit IRC17:37
*** pacharya has quit IRC17:44
*** Sundar has joined #openstack-nova17:53
mriedemthere was debug logging added to the placement GET /allocation_candidates code but i'm not sure it made it back to pike18:07
mriedemjaypipes: ^?18:07
mriedem_erlon_: https://review.openstack.org/#/q/If9ddb8a6d2f03392f3cc11136c4a0b026212b95b18:10
mriedemand https://review.openstack.org/#/q/status:merged+project:openstack/nova+branch:master+topic:one-resource-per-query18:10
mriedemthat would take some work to get back to pike18:10
mriedem_erlon_: how many computes do you have?18:11
mriedemfirst thing to do would be to make sure there is a resource provider for each compute node18:11
openstackgerritMerged openstack/python-novaclient stable/rocky: Revert "Fix crashing console-log"  https://review.openstack.org/65036418:22
openstackgerritMerged openstack/python-novaclient stable/rocky: Add test for console-log and docs for bug 1746534  https://review.openstack.org/65203318:22
openstackbug 1746534 in python-novaclient "encoding error when doing console-log" [High,Fix released] https://launchpad.net/bugs/1746534 - Assigned to Thomas Goirand (thomas-goirand)18:22
*** ircuser-1 has joined #openstack-nova18:24
*** markvoelker has quit IRC18:26
openstackgerritMatt Riedemann proposed openstack/nova master: Remove macs kwarg from allocate_for_instance  https://review.openstack.org/65274918:28
edleafevim18:33
edleafedoh!18:33
sean-k-mooneyedleafe: password:18:34
sean-k-mooney:)18:34
edleafetoo many windows open - now *that* would make an easy-to-remember password18:35
sean-k-mooneyim kind of sad the cirros passward is nolonger "cubswin:)"18:37
*** Sundar has quit IRC18:37
sean-k-mooneyanyway time for dinner18:37
sean-k-mooneyo/18:37
*** awaugama has quit IRC18:39
*** awaugama_ has joined #openstack-nova18:39
*** jding1_ has joined #openstack-nova18:49
*** jackding has quit IRC18:52
*** jmlowe has quit IRC18:55
_erlon_mriedem: only 118:58
_erlon_its a devstack node18:58
mriedem_erlon_: oh, well, make sure it's reporting into placement with the correct inventory19:00
mriedemhttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-list19:00
mriedemhttps://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-inventory-list19:00
_erlon_mriedem: its a devstack node and should be working fine19:00
_erlon_I can like create up to 3 instances19:00
_erlon_the 4th fails for some reason19:00
mriedemwell, you can use ^ to see the inventory of the provider,19:02
mriedemand https://docs.openstack.org/osc-placement/latest/cli/index.html#resource-usage-show to see the usage of the project which you used to create instances19:02
mriedemand then see if there is any remaining capacity for the 4th instance you're trying to create19:02
*** markvoelker has joined #openstack-nova19:04
*** eharney has quit IRC19:18
*** Sundar has joined #openstack-nova19:29
*** mdbooth_ has quit IRC19:34
*** tbachman has quit IRC19:34
openstackgerritMatt Riedemann proposed openstack/nova master: Handle unsetting '[DEFAULT] dhcp_domain'  https://review.openstack.org/65266219:34
openstackgerritMatt Riedemann proposed openstack/nova master: conf: Undeprecate and move the 'dhcp_domain' option  https://review.openstack.org/48061619:34
*** helenafm has quit IRC19:41
*** awaugama_ has quit IRC19:44
*** penick has quit IRC19:46
*** slaweq_ has joined #openstack-nova19:47
*** mlavalle has quit IRC19:47
*** dave-mccowan has joined #openstack-nova19:48
mriedemedleafe: error response status code question! https://review.openstack.org/#/c/645458/17/specs/train/approved/add-host-and-hypervisor-hostname-flag-to-create-server.rst@14119:49
*** mlavalle has joined #openstack-nova19:49
* edleafe jumps into a nearby phone booth19:49
mriedemdo those still exist?19:50
* edleafe realizes that there are no more phone booths19:50
edleafejink19:50
edleafejinx19:50
aspierswe still have some19:50
aspiersbut I don't think they tend to work19:50
aspiersunless you're a timelord19:50
jaypipes_erlon_: did you find the answer to your query?19:50
artomJust quick sanity check to be 100% sure, but the resource stats we provide in https://developer.openstack.org/api-ref/compute/?expanded=show-hypervisor-details-detail#show-hypervisor-details come from the resource tracker via the ComputeNode object, right? And specifically, not from placement?19:52
edleafemriedem: that's not really a response code question, is it? If the app logic is to let the scheduler pick, then 2xx. If you treat the value as missing, then 40019:52
mriedemedleafe: this one? "The new (``host`` and/or ``hypervisor_hostname``) and the old19:53
mriedem  (``az:host:node``) mechanisms are mutually exclusive. If both are specified19:53
mriedem  in the same request, the API will return a 409 HTTP Conflict error."19:53
mriedemthey are saying the api will return an error and we don't get to the scheduler19:53
mriedemi'm just saying that's not a 40919:53
edleafemriedem: huh, I clicked that link and L125 was front and center19:53
mriedemartom: everything in the hypervisors api comes from the compute node yeah19:54
artommriedem, cheerS!19:54
edleafeYeah, that's not a 409. There's nothing conflicting about the state of the system and the request. It's just a bad request19:54
mriedemartom: interestingly that API doesn't use the ComputeNode.stats object https://github.com/openstack/nova/blob/78e742662edd164c46382c31e106884762fed029/nova/db/sqlalchemy/api.py#L73019:55
mriedemhttps://github.com/openstack/nova/blob/78e742662edd164c46382c31e106884762fed029/nova/objects/compute_node.py#L8119:55
mriedemwhich is this happy thing https://github.com/openstack/nova/blob/78e742662edd164c46382c31e106884762fed029/nova/compute/stats.py19:56
artommriedem, should it? Looks like stats is an aggregate, while the hypervisors API is per node19:56
mriedemi'd say my default answer to "should the hypervisors api have more detail in it" is "probably not'19:57
mriedemhttps://developer.openstack.org/api-ref/compute/?expanded=#show-hypervisor-statistics is an aggregate yes19:58
artomI meant "should it" as more of a "why would you expect it to?"19:58
artomOooo I know, let's have NUMA nodes as REST resources and provide an API to access /sys/devices/system/node/node0/meminfo19:59
mriedemfrom the outside i'd expect an api that is called "statistics" to leverage a 'stats' field on that resource in the db20:00
mriedemartom: i'm pretty sure there is an intel spec for that20:00
*** Sundar has quit IRC20:00
artom*snerk*20:00
artom"efried pto" Aha, that explains it ;)20:03
mriedemmnaser: i saw you abandoned https://review.openstack.org/#/c/577933/ - is that because you don't need it anymore, or just don't have time to work on it? because i think a couple of people asked for the same thing and it's reasonable imo, probably just needs paperwork done and such (which someone could help with)20:04
mnasermriedem: I still think it's useful but I don't think I have the time to work on the paperwork and what not honestly20:04
mnasernot right now, anyways20:05
mnasermaybe I can restore and leave it with a "hey if you wanna pick this up, feel free to?"20:05
mriedemi think the only question is about a stale hostId value in the config drive on an instance that is live migrated around20:06
mriedembut for that matter the az value in the config drive could already be stale for the same reason20:07
artommriedem, didn't we specifically make a point of not updating device tag information on the config drive?20:07
artomhostId could fall under the same argument - "if you need up to date info, use the API"20:07
mriedemartom: i vaguely recall talking about punting on updating tags in the config drive because we just don't refresh the thing20:07
mriedemwe rebuild it in some cases (rebuild w/o shared storage, unshelve)20:08
artomI believe we settled on something like "we won't update it for you, it'll get rebuilt when it gets rebuilt"20:08
mriedemyou get what you get and you don't throw a fit?20:08
*** jmlowe has joined #openstack-nova20:10
mriedemmnaser: i'll reach out to our downstream product team and see if they have a similar need for this20:11
artommriedem, basically - https://github.com/openstack/nova/blob/master/releasenotes/notes/virt-device-tagged-attach-53e214d3b3fdd183.yaml20:11
mnasermriedem: cool, want me to restore it?20:11
mriedemmnaser: i can if i'm going to work on it20:11
mriedemso don't bother20:11
mnasermriedem: ok cool!20:12
mnaserI have been dealing with other fun weird things20:12
mnaserlike resource reporting messages taking way too long20:12
mnaserand timing out20:12
mnaserbut that only happening during live migrations20:12
mnaserI don't wanna point at nova yet.. but it's pretty weird.20:13
mriedem"resource reporting messages"?20:13
mnasereh the stuff that runs every little bit and reports the instance list to the scheduler20:13
mnaserand then at some point a post_live_migration failed too with a timeout20:13
mriedemoh, didn't know you relied on that20:13
mriedemsync_instance_info should be a broadcast - no timeout20:14
mnaserI mean I think if we want (anti-)affinity, we have to afaik?20:14
mriedemno, it's just a cache in the scheduler20:14
mriedemif the data isn't cached in the scheduler it pulls it from the db per request - which could be slow20:14
mnaseroh yeah I remember that20:14
mnaserlet me find the traceback20:14
dansmithmriedem: I have to submit something to lower-constraints itself before I can put it in nova yeah?20:15
mriedemdansmith: no, it's per-project20:15
mriedemnot like the old g-r way20:15
dansmithsigh20:15
mriedemhonestly i don't know why we have lower-constraints.txt and requirements.txt20:15
dansmithmight as well not ever try to remember because it'll be different20:15
openstackgerritDan Smith proposed openstack/nova master: Add image type capability flags and trait conversions  https://review.openstack.org/65271020:15
mriedemg-r was dropped so requirements.txt isn't automatically updated from g-r anymore20:15
mnaserhttps://www.irccloud.com/pastebin/drWAr4hV/20:16
mriedemand lower-constraints was added, but....20:16
dansmithright but I thought lower was, but whaterver20:16
openstackgerritMerged openstack/nova master: Remove cells v1 jobs  https://review.openstack.org/65128920:16
mnaseris resource_tracker not thee same thing? maybe I'm being misleading here20:16
mriedemmnaser: not that's something else, sec20:16
mriedemhttps://github.com/openstack/nova/blob/stable/stein/nova/compute/resource_tracker.py#L132320:17
mriedemit's timing out pulling instances from the db20:17
mriedemwell, "an instance"20:17
mriedemwhich....your db / mq must be getting hammered?20:17
mnasermriedem: nothing sticks out20:18
mriedemthat will kill the whole update_available_resource periodic though20:18
mriedemuntil the next time it runs i mean20:18
*** tbachman has joined #openstack-nova20:19
mriedemsync_instance_info is a different periodic that reports info to the scheduler20:19
mriedemper host20:19
mnaserI remember seeing a traceback involving it20:19
mnaserlet me check again20:19
*** dave-mccowan has quit IRC20:20
*** tbachman has quit IRC20:38
*** pcaruana has quit IRC20:38
*** priteau has quit IRC20:44
*** dave-mccowan has joined #openstack-nova20:54
*** dave-mccowan has quit IRC20:57
*** slaweq_ is now known as slaweq20:58
*** ceryx has left #openstack-nova21:01
*** ccstone has joined #openstack-nova21:02
*** erlon has quit IRC21:06
*** sambetts_ has quit IRC21:10
*** sambetts_ has joined #openstack-nova21:10
mriedemwhy doesn't tox yell at me anymore when i provide an env which doesn't exist?21:17
*** jackding has joined #openstack-nova21:18
mriedemdansmith: do you remember this from 3+ years ago? https://review.openstack.org/#/c/256073/21:30
mriedemif so, did https://review.openstack.org/#/c/325684/ regress it?21:31
*** mdbooth has joined #openstack-nova21:31
sean-k-mooneyso it was fixed for 6 months 2 and a half years ago21:32
sean-k-mooneyi must say i like the topic branch21:33
sean-k-mooney*topic name21:33
*** tbachman has joined #openstack-nova21:34
mriedemi just noticed that the base TestCase is still doing openstack_driver.DRIVER_CACHE = {} even though that's not used anymore21:34
*** eharney has joined #openstack-nova21:35
sean-k-mooneyi was going to say i assume you were doing git blame on something random and found that21:35
sean-k-mooneypresuably we should create an updated version of dans original caching patch again for this21:36
sean-k-mooneyi think we have several other dictionay caches at this point so we can proably reuse one for it21:37
dansmithmriedem: I don't remember it no21:37
mriedemi'll put up a logging patch that logs every time we create that object21:37
mriedemto see how bad it is21:37
mriedemdansmith: coincidentally that series is related to recent issues https://review.openstack.org/#/q/topic:okay-we-got-it+(status:open+OR+status:merged)21:38
*** mvkr has quit IRC21:38
*** awalende has joined #openstack-nova21:40
sean-k-mooneymriedem: by the way i added a memorize decorator in https://review.openstack.org/#/c/599071/3/nova/api/validation/parameter_types.py so we could just move the into the nova utils and reuse it if we want21:41
*** ivve has joined #openstack-nova21:41
*** jding1__ has joined #openstack-nova21:43
*** awalende has quit IRC21:45
*** jackding has quit IRC21:46
*** jding1_ has quit IRC21:46
*** ivve has quit IRC21:46
*** jackding has joined #openstack-nova21:46
*** mvkr has joined #openstack-nova21:51
*** whoami-rajat has quit IRC21:54
openstackgerritMatt Riedemann proposed openstack/nova master: Make nova.compute.rpcapi.ComputeAPI.router a singleton  https://review.openstack.org/64919721:59
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: log when loading security group driver  https://review.openstack.org/65278322:06
*** slaweq has quit IRC22:12
*** mriedem has quit IRC22:14
*** mlavalle has quit IRC22:15
*** luksky has quit IRC22:25
*** erlon has joined #openstack-nova22:49
*** tkajinam has joined #openstack-nova22:53
*** markvoelker has quit IRC22:57
*** markvoelker has joined #openstack-nova23:08
*** hongbin has quit IRC23:11
*** lbragstad has quit IRC23:13
*** avolkov has quit IRC23:15
*** rcernin has joined #openstack-nova23:24
openstackgerritLee Yarwood proposed openstack/nova master: Restore connection_info after live migration rollback  https://review.openstack.org/55134923:39
openstackgerritLee Yarwood proposed openstack/nova master: WIP compute: Use source_bdms to reset attachment_ids during LM rollback  https://review.openstack.org/65280023:39
*** erlon has quit IRC23:48
openstackgerritMerged openstack/nova stable/rocky: Adding tests to demonstrate bug #1821824  https://review.openstack.org/64960223:48
openstackbug 1821824 in OpenStack Compute (nova) rocky "Forbidden traits in flavor properties don't work" [High,In progress] https://launchpad.net/bugs/1821824 - Assigned to Eric Fried (efried)23:48
openstackgerritMerged openstack/nova stable/rocky: Fix bug preventing forbidden traits from working  https://review.openstack.org/64960323:48
openstackgerritMerged openstack/nova stable/rocky: Add missing libvirt exception during device detach  https://review.openstack.org/65163723:48
*** erlon has joined #openstack-nova23:50
*** erlon has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!