*** lbragstad has joined #openstack-nova | 00:29 | |
*** brinzhang has joined #openstack-nova | 00:38 | |
*** Dinesh__Bhor has quit IRC | 01:19 | |
*** Dinesh_Bhor has joined #openstack-nova | 01:21 | |
openstackgerrit | zhufl proposed openstack/nova master: Remove conductor_api and cells_rpcapi from manager.py https://review.openstack.org/651059 | 01:22 |
---|---|---|
*** cfriesen has quit IRC | 01:24 | |
*** lbragstad has quit IRC | 01:50 | |
*** masayukig has joined #openstack-nova | 01:55 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: [WIP] Fix live migration break group policy simultaneously https://review.openstack.org/651969 | 01:56 |
*** dave-mccowan has quit IRC | 02:03 | |
*** igordc has joined #openstack-nova | 02:04 | |
*** masayukig has quit IRC | 02:10 | |
*** masayukig has joined #openstack-nova | 02:10 | |
*** lbragstad has joined #openstack-nova | 02:12 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Dropping the py35 testing https://review.openstack.org/643871 | 03:01 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Dropping the py35 testing https://review.openstack.org/643871 | 03:07 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.openstack.org/566153 | 03:19 |
openstackgerrit | Takashi NATSUME proposed openstack/nova stable/rocky: Replace glance command with openstack command https://review.openstack.org/637060 | 03:20 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix cleaning up console tokens https://review.openstack.org/637716 | 03:20 |
*** psachin has joined #openstack-nova | 03:29 | |
*** tonyb[m] has joined #openstack-nova | 03:40 | |
*** igordc has quit IRC | 03:50 | |
*** amodi has quit IRC | 03:59 | |
*** bhagyashris has joined #openstack-nova | 04:01 | |
*** imacdonn has quit IRC | 04:05 | |
*** imacdonn has joined #openstack-nova | 04:06 | |
*** ivve has quit IRC | 04:18 | |
*** udesale has joined #openstack-nova | 04:24 | |
*** whoami-rajat has joined #openstack-nova | 04:37 | |
*** janki has joined #openstack-nova | 04:44 | |
*** jaosorior has joined #openstack-nova | 04:48 | |
*** hongbin has quit IRC | 04:49 | |
*** brinzh has joined #openstack-nova | 04:57 | |
*** bhagyashris has quit IRC | 04:58 | |
*** brinzhang has quit IRC | 05:01 | |
*** rcernin has quit IRC | 05:08 | |
*** rcernin has joined #openstack-nova | 05:10 | |
*** ivve has joined #openstack-nova | 05:27 | |
*** tkajinam has quit IRC | 05:28 | |
*** ratailor has joined #openstack-nova | 05:29 | |
*** sridharg has joined #openstack-nova | 05:39 | |
*** tkajinam has joined #openstack-nova | 05:54 | |
*** Luzi has joined #openstack-nova | 05:59 | |
openstackgerrit | Fan Zhang proposed openstack/nova master: Log disk transfer stats in live migration monitor. https://review.openstack.org/619395 | 06:05 |
*** yaawang has quit IRC | 06:13 | |
*** sapd1_x has joined #openstack-nova | 06:17 | |
*** pcaruana has joined #openstack-nova | 06:19 | |
*** belmoreira has joined #openstack-nova | 06:20 | |
*** dpawlik has joined #openstack-nova | 06:21 | |
*** udesale has quit IRC | 06:26 | |
*** dpawlik has quit IRC | 06:27 | |
*** ircuser-1 has quit IRC | 06:29 | |
*** yaawang has joined #openstack-nova | 06:30 | |
*** dpawlik has joined #openstack-nova | 06:31 | |
*** toabctl has joined #openstack-nova | 06:32 | |
*** yaawang has quit IRC | 06:40 | |
*** tkajinam_ has joined #openstack-nova | 06:48 | |
*** tkajinam has quit IRC | 06:51 | |
*** lbragstad has quit IRC | 06:52 | |
*** slaweq__ has joined #openstack-nova | 06:57 | |
*** yaawang has joined #openstack-nova | 06:58 | |
*** rcernin has quit IRC | 07:05 | |
*** tesseract has joined #openstack-nova | 07:10 | |
*** udesale has joined #openstack-nova | 07:17 | |
*** slaweq__ is now known as slaweq | 07:18 | |
*** tosky has joined #openstack-nova | 07:20 | |
*** udesale has quit IRC | 07:20 | |
*** udesale has joined #openstack-nova | 07:21 | |
*** spotz has joined #openstack-nova | 07:22 | |
*** udesale has quit IRC | 07:22 | |
*** belmoreira has quit IRC | 07:24 | |
*** rpittau|afk is now known as rpittau | 07:34 | |
*** udesale has joined #openstack-nova | 07:43 | |
*** belmoreira has joined #openstack-nova | 07:47 | |
*** luksky has joined #openstack-nova | 07:50 | |
*** ttsiouts has joined #openstack-nova | 07:54 | |
*** ralonsoh has joined #openstack-nova | 08:01 | |
*** takashin has left #openstack-nova | 08:02 | |
*** tssurya has joined #openstack-nova | 08:06 | |
*** phasespace has quit IRC | 08:08 | |
kashyap | gibi: Morning. On the Secure Boot spec, thanks for your comment :-) -- https://review.openstack.org/#/c/506720/ | 08:13 |
kashyap | gibi: So if I refresh it with the additional answers to the questions discussed - I guess you're onboard with it. | 08:13 |
*** helenafm has joined #openstack-nova | 08:14 | |
kashyap | (And then I can finally get down to the code :D I already have a WIP patch for some scaffolding work that's anyway required.) | 08:14 |
openstackgerrit | Tushar Patil proposed openstack/nova-specs master: Support filtering of allocation_candidates by forbidden aggregates https://review.openstack.org/609960 | 08:19 |
openstackgerrit | Tushar Patil proposed openstack/nova-specs master: Allow compute nodes to use DISK_GB from shared storage RP https://review.openstack.org/650188 | 08:20 |
*** tkajinam_ has quit IRC | 08:20 | |
*** awalende has joined #openstack-nova | 08:22 | |
*** dtantsur|afk is now known as dtantsur | 08:30 | |
*** boxiang has quit IRC | 08:32 | |
*** boxiang has joined #openstack-nova | 08:32 | |
*** belmoreira has quit IRC | 08:32 | |
*** belmoreira has joined #openstack-nova | 08:36 | |
gibi | kashyap: I'm OK with your spec based on your answers | 08:37 |
kashyap | gibi: Thank you. I'll refresh it with some tiny wording tweaks, then you can have a final look, and then can hopefully get your ACK (+2) | 08:38 |
kashyap | alex_xu: Hi, on the `cpu_model_list` spec, talking to the QEMU folks ... I'm not sure we should even do that (allowing a list of CPU models) at all. | 08:39 |
*** jangutter has joined #openstack-nova | 08:39 | |
kashyap | gibi: Got an Ubuntu machine by any chance? If so can you please post the output of equivalent on Ubuntu? | 08:40 |
*** udesale has quit IRC | 08:40 | |
kashyap | (Err, broken copy/paste) | 08:40 |
*** udesale has joined #openstack-nova | 08:40 | |
kashyap | Output of: `dpkg --listfiles ovmf` | 08:40 |
kashyap | (Or whatever the package is called on Ubuntu) | 08:40 |
kashyap | gibi: Actually, disregard me, found this: https://packages.ubuntu.com/xenial/all/ovmf/filelist | 08:41 |
*** sapd1_x has quit IRC | 08:42 | |
gibi | kashyap: this is from a bionic VM http://paste.openstack.org/show/749298/ | 08:44 |
* kashyap clicks | 08:45 | |
kashyap | (Yep, that's good. Thank you.) | 08:45 |
gibi | np | 08:45 |
kashyap | So Ubuntu just does what Debian does | 08:45 |
*** ttsiouts has quit IRC | 08:51 | |
*** ttsiouts has joined #openstack-nova | 08:51 | |
*** ttsiouts has quit IRC | 08:56 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: [WIP] Add host and hypervisor_hostname flag to create server https://review.openstack.org/645520 | 09:03 |
*** ttsiouts has joined #openstack-nova | 09:12 | |
*** janki has quit IRC | 09:14 | |
*** ttsiouts has quit IRC | 09:17 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: wip: Non-admin user can filter servers by user_id https://review.openstack.org/652602 | 09:26 |
*** avolkov has joined #openstack-nova | 09:35 | |
*** cdent has joined #openstack-nova | 09:46 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Server move operations with ports having resource request https://review.openstack.org/652608 | 09:47 |
*** zbr has joined #openstack-nova | 09:48 | |
*** zbr__ has quit IRC | 09:50 | |
*** ttsiouts has joined #openstack-nova | 09:51 | |
*** panda has joined #openstack-nova | 09:51 | |
*** udesale has quit IRC | 09:54 | |
*** udesale has joined #openstack-nova | 09:55 | |
*** janki has joined #openstack-nova | 10:01 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: [WIP] Fix live migration break group policy simultaneously https://review.openstack.org/651969 | 10:09 |
*** belmoreira has quit IRC | 10:14 | |
*** belmoreira has joined #openstack-nova | 10:18 | |
aspiers | sean-k-mooney, efried: hoping to have a new version of the SEV spec submitted in the next few hours | 10:22 |
sean-k-mooney | aspiers: cool good to know | 10:24 |
sean-k-mooney | aspiers: have you added it to the review day etherpad | 10:24 |
sean-k-mooney | i think it was there last week | 10:24 |
*** udesale has quit IRC | 10:25 | |
stephenfin | Can someone sanity check this and tell me how I've changed the logic? https://review.openstack.org/#/c/651554/3/nova/compute/api.py | 10:25 |
stephenfin | (tests are failing so I've obviously broken _something http://logs.openstack.org/54/651554/3/check/openstack-tox-py27/d5489c5/testr_results.html.gz) | 10:25 |
aspiers | sean-k-mooney: I am definitely intending to - I thought it wasn't really ready for more feedback yet until we address the existing concerns | 10:25 |
sean-k-mooney | stephenfin: looking | 10:25 |
aspiers | sean-k-mooney: my new patchset will be mostly just including the new info and suggestions from you / Daniel / Brijesh | 10:25 |
*** ttsiouts has quit IRC | 10:26 | |
*** udesale has joined #openstack-nova | 10:26 | |
sean-k-mooney | stephenfin: im gessing the addtion of " and service_host is none" | 10:26 |
stephenfin | That reads to me like I'm moving the third case in the if-else to the first | 10:27 |
sean-k-mooney | actully no that is just the else block | 10:27 |
stephenfin | yeah | 10:27 |
sean-k-mooney | stephenfin: where do you call the new lookup_fn fucntion | 10:28 |
stephenfin | sean-k-mooney: line 5002 on the right | 10:28 |
stephenfin | maybe the 'target_cell' context manager is doing something weird? :/ | 10:28 |
sean-k-mooney | it shouldnt | 10:29 |
sean-k-mooney | why are you doing this refactoring by the way. to get rid of the pep8 warning about lamdas should not be named? | 10:30 |
stephenfin | sean-k-mooney: Yeah. I was going to noqa that particular one but for some reason I can't do that | 10:30 |
sean-k-mooney | stephenfin: why are you not passing in service_id by the way | 10:32 |
stephenfin | where now? | 10:32 |
sean-k-mooney | https://review.openstack.org/#/c/651554/3/nova/compute/api.py@4989 | 10:33 |
stephenfin | sean-k-mooney: You don't need to for nested functions. They have access to everything in their parent's | 10:34 |
kashyap | stephenfin: Hey there, an rST references question: just by looking at this rendering, can you tell why the '7' and '8' are funny like that? -- https://kashyapc.fedorapeople.org/Broken-rST-references.png | 10:34 |
sean-k-mooney | they do but it might mess with mocking | 10:34 |
stephenfin | kashyap: Not a clue. That's rather odd looking. Indentation is usually the #1 cause of odd stuff like that though | 10:35 |
kashyap | Ah, I know! | 10:35 |
kashyap | stephenfin: They're both referenced _twice_ in the document | 10:35 |
stephenfin | Oh, that's interesting | 10:36 |
kashyap | As in, two occurrences of each. How can I accomplish that without this funnynnes (is it a word?)? | 10:36 |
stephenfin | *funniness | 10:36 |
kashyap | Damn, that's what I wrote at first | 10:36 |
kashyap | Thanks :-) | 10:36 |
stephenfin | tbh, I've no idea. I would _suspect_ it's a theming thing | 10:37 |
stephenfin | i.e. there's a reference number then cross references to where they're called, and we're sometimes using the latter where we should be using the former. That's a total guess though | 10:37 |
kashyap | Hmm, so I have to just reference it once. Okheeee, not a big issue | 10:37 |
stephenfin | Or just live with that weirdness | 10:38 |
stephenfin | seeing as it's purely stylistic | 10:38 |
kashyap | Hehe. I adjusted the text to make-do with just one reference. | 10:39 |
kashyap | Thanks for your response, though. | 10:39 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Add "Secure Boot support for KVM & QEMU guests" spec https://review.openstack.org/506720 | 10:40 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Add "Secure Boot support for KVM & QEMU guests" spec https://review.openstack.org/506720 | 10:40 |
sean-k-mooney | stephenfin: kashyap by the way i dont know if ye saw my mailing list post but i got this working on saturday https://review.openstack.org/#/c/652197/ | 10:41 |
*** belmoreira has quit IRC | 10:42 | |
stephenfin | sean-k-mooney: Aha, sussed it (I think) | 10:43 |
stephenfin | https://review.openstack.org/#/c/651554/3/nova/compute/api.py@4991 | 10:43 |
*** tbachman has quit IRC | 10:43 | |
stephenfin | sean-k-mooney: https://review.openstack.org/#/c/651554/3/nova/compute/api.py@5011 | 10:43 |
stephenfin | Looks like scoping rules mean variables set in a nested function have their own scope so I need to use something like global | 10:43 |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Server move operations with ports having resource request https://review.openstack.org/652608 | 10:44 |
sean-k-mooney | stephenfin: yes they do | 10:44 |
sean-k-mooney | and no just use mulitple return values | 10:44 |
sean-k-mooney | return is_uuid, ... | 10:45 |
kashyap | sean-k-mooney: Yep, saw that fly-by on the list | 10:45 |
kashyap | Cool, you're using the MTTCG backend | 10:45 |
sean-k-mooney | ya unfortunetly libvirt decided not to expose an xml element for it | 10:46 |
sean-k-mooney | so the best we can do is to use a cpu model that support mttcg | 10:46 |
kashyap | File an RFE for libvirt, if you see a valid use? | 10:46 |
sean-k-mooney | qemu64 should fit that requirement | 10:46 |
sean-k-mooney | kashyap: they intentionally chose not to but i think it makes consumtion in openstack harder | 10:47 |
kashyap | (But 'qemu64' is also an awful CPU to use in general (I know we're just testing) :-( -- because it can't get the Spectre/Meltdown fixes) | 10:47 |
*** alex_xu has quit IRC | 10:47 | |
sean-k-mooney | kashyap: it does not need them | 10:47 |
kashyap | TODO: Move away from 'qemu64' even for testing | 10:47 |
sean-k-mooney | kashyap: its an emulated cpu and therefor should not need to emulate the vulnerablity | 10:48 |
sean-k-mooney | you can fix specter and meltdown entirely in qemu for qemu64 | 10:48 |
sean-k-mooney | if they havent that is a qemu bug | 10:48 |
sean-k-mooney | so i dont see any reason to move away form qemu64 for testing | 10:49 |
kashyap | sean-k-mooney: So back to that MTTCG thing, I saw the rationale on the libvirt list: | 10:49 |
kashyap | [quote] | 10:49 |
kashyap | We don't have anything in the domain XML that indicates | 10:49 |
kashyap | whether a guest is using TCG or MTTCG. While QEMU does | 10:49 |
kashyap | have an option (-accel tcg,thread=single|multi), it is | 10:49 |
kashyap | not desirable to expose this in libvirt. QEMU will | 10:49 |
sean-k-mooney | yes i know i read it | 10:49 |
kashyap | automatically use MTTCG when the host/guest architecture | 10:49 |
kashyap | pairing is known to be safe. Only developers of QEMU TCG | 10:49 |
kashyap | Ah, okay | 10:49 |
kashyap | have a strong reason to override this logic. | 10:49 |
kashyap | [/quote] | 10:49 |
kashyap | It is reasonable | 10:49 |
stephenfin | sean-k-mooney: Came up with something even better (IMO) | 10:50 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve E731 (do not assign a lambda expression, use a def) https://review.openstack.org/651554 | 10:50 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve W503 (line break occurred before a binary operator) https://review.openstack.org/651555 | 10:50 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve E741 (ambiguous variable name) https://review.openstack.org/652103 | 10:50 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence) https://review.openstack.org/652104 | 10:50 |
sean-k-mooney | kashyap: i dont think so | 10:50 |
stephenfin | back to real work | 10:50 |
sean-k-mooney | kashyap: we really want to know if its enabeld or not so we can fail to boot the vm if its not | 10:50 |
kashyap | Hmm. Then file a libvirt RFE telling a management tool has a user for it :-) | 10:51 |
sean-k-mooney | i could i was going to ping dan donwstream and get his input first. | 10:52 |
sean-k-mooney | kashyap: i had stared working on enableing mttcg as a new virt_type when i came across the ml post where they said it was not exposed | 10:52 |
sean-k-mooney | but anyway that can wait. | 10:53 |
sean-k-mooney | stephenfin: do you have a like to your fixed version? | 10:53 |
sean-k-mooney | actully never mind ill jsut refresh :) | 10:53 |
stephenfin | yeah, it's the one I just pushed there :) | 10:53 |
sean-k-mooney | i mean it works. i still dislike you using variable form the enclosing scope but ya it should work | 10:55 |
sean-k-mooney | and you dont have to change the call site | 10:55 |
sean-k-mooney | stephenfin: do we still have cases where the service id is not a uuid by the way? | 10:57 |
kashyap | sean-k-mooney: On your comment that: upstream QEMU should fix 'qemu64' entirely for Spectre/Meltdown. It's a non-goal: | 10:58 |
kashyap | "TCG is not suitable for containing malicious code, so we don't need to worry about hardening against guests using spectre to exploit the JIT" | 10:58 |
sean-k-mooney | kashyap: by the way one of the reasons i was interested in teh mttcg backend was the ability to emulate other achitecutres without the horible performacne cost | 10:58 |
kashyap | sean-k-mooney: Yeah, can imagine (on MTTCG) | 10:58 |
sean-k-mooney | kashyap: :( | 10:59 |
kashyap | sean-k-mooney: I don't think it's (no security guarantees for TCG) an issue for us: as the upstream CI isn't running any real workloads in the L2 | 10:59 |
sean-k-mooney | you can do it today by using a custom cpu_model + setting the machine type and qemu backend | 10:59 |
sean-k-mooney | kashyap: ya | 11:00 |
kashyap | (So we're good, there.) | 11:00 |
sean-k-mooney | the reason i went for qemu64 was to make sure it could run on all the ci cloud providers | 11:00 |
sean-k-mooney | event the xen based ones | 11:00 |
sean-k-mooney | and it should be supported by mttcg as it uses the smallest feature set | 11:01 |
* kashyap --> lunch; bbiab | 11:01 | |
sean-k-mooney | stephenfin: by the way looking at https://review.openstack.org/#/c/652197/7/playbooks/nfv/nfv.yaml can you think of an epa/numa feature i have missed beyond 2 numa nodes? | 11:02 |
*** ttsiouts has joined #openstack-nova | 11:03 | |
sean-k-mooney | stephenfin: im going to test ovs-dpdk in a different job | 11:04 |
openstackgerrit | Merged openstack/nova stable/stein: Adding tests to demonstrate bug #1821824 https://review.openstack.org/649600 | 11:06 |
openstack | bug 1821824 in OpenStack Compute (nova) stein "Forbidden traits in flavor properties don't work" [High,In progress] https://launchpad.net/bugs/1821824 - Assigned to Eric Fried (efried) | 11:06 |
*** weshay_pto has quit IRC | 11:12 | |
*** weshay_pto has joined #openstack-nova | 11:13 | |
*** alex_xu has joined #openstack-nova | 11:19 | |
*** panda is now known as panda|lunch | 11:23 | |
openstackgerrit | Merged openstack/nova stable/stein: Fix bug preventing forbidden traits from working https://review.openstack.org/649601 | 11:29 |
*** belmoreira has joined #openstack-nova | 11:30 | |
sean-k-mooney | :) ^ | 11:30 |
sean-k-mooney | cool its already proposed to be backported to rocky as well :) | 11:31 |
*** erlon has joined #openstack-nova | 11:32 | |
*** luksky has quit IRC | 11:41 | |
*** mvkr has joined #openstack-nova | 11:48 | |
openstackgerrit | Merged openstack/python-novaclient stable/stein: Add test for console-log and docs for bug 1746534 https://review.openstack.org/651925 | 11:54 |
openstack | bug 1746534 in python-novaclient "encoding error when doing console-log" [High,Fix released] https://launchpad.net/bugs/1746534 - Assigned to Thomas Goirand (thomas-goirand) | 11:54 |
*** tbachman has joined #openstack-nova | 12:07 | |
*** panda|lunch is now known as panda | 12:08 | |
*** ttsiouts has quit IRC | 12:11 | |
*** ttsiouts has joined #openstack-nova | 12:11 | |
*** brinzh has quit IRC | 12:13 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Server move operations with ports having resource request https://review.openstack.org/652608 | 12:14 |
*** luksky has joined #openstack-nova | 12:14 | |
*** ttsiouts has quit IRC | 12:16 | |
*** ttsiouts has joined #openstack-nova | 12:19 | |
*** nicolasbock has joined #openstack-nova | 12:35 | |
kashyap | gibi: Does this require a Blueprint (much less a "spec"): https://bugs.launchpad.net/nova/+bug/1789868 | 12:35 |
openstack | Launchpad bug 1789868 in OpenStack Compute (nova) "RFE: Add a virtio-rng device to Nova instances by default" [Medium,In progress] - Assigned to s10 (vlad-esten) | 12:35 |
*** tosky has quit IRC | 12:36 | |
kashyap | I'd actually classify it as a "bug". But, whatever :-) (We already have a patch up for it, though: https://review.openstack.org/#/c/616603/) | 12:37 |
* kashyap just files one | 12:44 | |
gibi | kashyap: I'm fine going with that bug report | 12:46 |
kashyap | gibi: Ah, okay, then. | 12:46 |
*** davidsha has joined #openstack-nova | 12:46 | |
gibi | kashyap: just a question. Could this change cause that on guest can deplete the enthropy pool of the host and therefore cause troubles on the host or in other guests? | 12:47 |
kashyap | Wasn't sure if the 'process hammer' would come to bite me in the behind ... | 12:47 |
gibi | kashyap: at least not my process hammer... | 12:47 |
kashyap | (Heh) | 12:47 |
kashyap | gibi: No, it won't. But let me quadruple-check with the RNG experts | 12:47 |
kashyap | gibi: Confirmed: One guest can't do that. | 12:52 |
kashyap | Where "that" == deplete the entropy pool of the host | 12:52 |
*** ratailor has quit IRC | 12:55 | |
gibi | kashyap: OK. thanks | 12:55 |
*** belmoreira has quit IRC | 12:57 | |
*** boxiang has quit IRC | 12:57 | |
*** boxiang has joined #openstack-nova | 12:58 | |
*** udesale has quit IRC | 12:59 | |
*** udesale has joined #openstack-nova | 13:02 | |
*** udesale has quit IRC | 13:03 | |
*** udesale has joined #openstack-nova | 13:03 | |
*** belmoreira has joined #openstack-nova | 13:03 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add TODO to remove function attribute https://review.openstack.org/652649 | 13:04 |
stephenfin | gibi: If you have a chance, could you look at https://review.openstack.org/#/c/651302/1/nova/objects/instance.py and see if I'm doing anything particular wrong? | 13:05 |
kukacz | hi, I wonder if nova handles situation of live-migrating an instance with config drive from rbd-backed compute host to file-backed compute host and vice versa? it seems I'm stuck in Ocata with instance resized from rbd-backed to raw-backed compute node, not willing to live-migrate in the other direction | 13:07 |
kukacz | it's a volume-booted instance. the issue is about config drive | 13:09 |
*** lbragstad has joined #openstack-nova | 13:14 | |
gibi | stephenfin: replied to the notification part. I wasn't to helpful, sorry. | 13:19 |
stephenfin | gibi: Neither was I so that makes two of us. Thanks :) | 13:19 |
gibi | stephenfin: I think you need dansmith for this | 13:21 |
*** mriedem has joined #openstack-nova | 13:24 | |
*** takashin has joined #openstack-nova | 13:24 | |
*** jroll has quit IRC | 13:25 | |
*** jroll has joined #openstack-nova | 13:26 | |
*** amodi_ has joined #openstack-nova | 13:27 | |
*** amodi_ is now known as amodi | 13:27 | |
*** burt has joined #openstack-nova | 13:33 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Undeprecate and move the 'dhcp_domain' option https://review.openstack.org/480616 | 13:37 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Handle unsetting '[DEFAULT] dhcp_domain' https://review.openstack.org/652662 | 13:37 |
*** eharney has joined #openstack-nova | 13:37 | |
*** awalende has quit IRC | 13:38 | |
efried | boxiang: Do you mind if I do a quick edit of https://review.openstack.org/#/c/645458/ for grammar? | 13:43 |
*** bnemec has joined #openstack-nova | 13:46 | |
mriedem | lyarwood: questions in your swap volume migration_status patch https://review.openstack.org/#/c/637224/ | 13:51 |
mriedem | lyarwood: looks like there could be some weird edge cases | 13:51 |
*** priteau has joined #openstack-nova | 13:51 | |
*** tetsuro has joined #openstack-nova | 13:54 | |
*** tbachman has quit IRC | 13:54 | |
*** tbachman has joined #openstack-nova | 13:57 | |
mriedem | efried: please don't since there are major issues now in that spec | 13:58 |
mriedem | i.e. persisting RequestSpec.requested_destination now | 13:59 |
mriedem | please dear sweet baby jesus in heaven no | 13:59 |
efried | mriedem: Yup, Above comment was before those came in. So now I'll just mark up the issues so boxiang can fix them on the next spin. | 13:59 |
boxiang | efried: ok | 13:59 |
efried | mriedem: Did you see the discussion between boxiang and alex_xu in PS13 on persisting? | 13:59 |
mriedem | yes, and i disagree | 13:59 |
mriedem | i'm commenting | 13:59 |
cdent | placement meeting in now ish in #openstack-meeting-alt | 14:00 |
mriedem | i'm sure dansmith is also not going to be cool with starting to persist RequestSpec.requested_destination now | 14:00 |
alex_xu | mriedem: we persistent the requested_desitnation now | 14:01 |
*** cfriesen has joined #openstack-nova | 14:01 | |
mriedem | alex_xu: no we don't | 14:01 |
mriedem | if you mean force_hosts/force_nodes, yes, and that's likely a mistake | 14:01 |
alex_xu | so why we reset the requested_destination when migration? | 14:01 |
mriedem | that's not requested_destination | 14:01 |
mriedem | there is literally a field called requested_destination, | 14:01 |
mriedem | but that's not what reset_forced_destinations resets | 14:02 |
mriedem | reset_forced_destinations exists solely because we made the mistake of persisting force_hosts/force_nodes | 14:02 |
boxiang | mriedem: the requestec_destination of request spec is always null in db now? | 14:02 |
alex_xu | oh... | 14:02 |
mriedem | i've commented if you want details and history/examples https://review.openstack.org/#/c/645458/ | 14:03 |
mriedem | but i've been working on fixing these bugs for a long time now | 14:03 |
mriedem | so i don't really want to undo that work here | 14:03 |
alex_xu | ok, if so, I agree with that, that is what i'm thinking initial until I missed read reset_forced_destinations method | 14:04 |
mriedem | that method is a hack | 14:05 |
mriedem | to workaround persistence we shouldn't be doing | 14:05 |
alex_xu | but I'm pretty ensure we can migration the instance again without the initial forced host | 14:05 |
*** udesale has quit IRC | 14:05 | |
mriedem | yes we can because of reset_forced_destinations | 14:05 |
mriedem | otherwise you couldn't ever evacuate or live migrate a forced host/node server | 14:06 |
alex_xu | without the initial of requested_destination :) | 14:06 |
alex_xu | yes | 14:06 |
*** Luzi has quit IRC | 14:07 | |
mriedem | the main concern / justification i saw for persisting requested_destination in this spec was for the rebuild from cell0 case, | 14:08 |
mriedem | but i think i've already pointed out things in that rebuild from cell0 spec that the user will lose from the initial server create if they rebuild from cell0 | 14:08 |
mriedem | because the rebuild API doesn't match the server create parameters 1:1 | 14:08 |
mriedem | https://review.openstack.org/#/c/648686/1/specs/train/approved/enable-rebuild-for-instances-in-cell0.rst@72 | 14:09 |
*** awalende has joined #openstack-nova | 14:10 | |
alex_xu | mriedem: yes, agree with that. so that should be resolved by rebuild spec, right? | 14:10 |
alex_xu | or you want to process in this spec | 14:11 |
alex_xu | at least, there need a way to persistent requested_destination for the fail boot instance | 14:11 |
mriedem | alex_xu: i really don't want to talk about rebuild from cell0 in *this* spec :) | 14:11 |
alex_xu | mriedem: cool :) | 14:11 |
mriedem | "there need a way to persistent requested_destination for the fail boot instance" is debateable | 14:12 |
alex_xu | ha | 14:12 |
mriedem | i agree with your assertion in boxiang's spec that we should just say you can move the server even if you requested that it was built on a specific host | 14:12 |
mriedem | the rest is implementation detail | 14:12 |
alex_xu | ok, thanks | 14:13 |
*** awalende has quit IRC | 14:14 | |
mriedem | alex_xu: i think we can cross the rebuild from cell0 bridge for this later if needed, i.e. we could either add the host/hypervisor_hostname parameters to the rebuild api to mirror the server create api (i don't love that idea) or we could do something like store the requested destination in the instance system_metadata when burying it in cell0, and then on rebuild from cell0, use those values and wipe the system metadata so i | 14:19 |
mriedem | restricted to rebuild from cell0 cases | 14:19 |
mriedem | rebuild from cell0 is definitely going to have weird corner cases like this since the rebuild api doesn't mirror the server create api | 14:21 |
mriedem | alex_xu: btw, are you feeling better? | 14:21 |
alex_xu | mriedem: yes, like the system_metadata better than the change rebuild API also | 14:21 |
alex_xu | my initial thoughts is persistent the requested_destination, and reset it when we spawn successful, but I see now, you will hate that :) | 14:22 |
alex_xu | it is urgly indeed | 14:22 |
mriedem | my sysmeta + rebuild from cell0 idea isn't much different | 14:22 |
*** awaugama has joined #openstack-nova | 14:23 | |
mriedem | but RequestSpec.requested_destination specifically is off limits for persisting i think - the code already explicitly does not persist it | 14:23 |
alex_xu | yea | 14:25 |
alex_xu | at least no better idea yet | 14:25 |
mriedem | gibi: how would you like me to address this? https://review.openstack.org/#/c/651945/1/nova/cmd/manage.py@2094 | 14:26 |
mriedem | call out verify_instance and map_instances specifically | 14:27 |
mriedem | ? | 14:27 |
kashyap | lyarwood: Heya, on your question on that Secure Boot spec about why not libguestfs API helpw ith "enrolling UEFI keys", I've answered it here: https://review.openstack.org/#/c/506720/8/specs/train/approved/allow-secure-boot-for-qemu-kvm-guests.rst@287 | 14:27 |
kashyap | lyarwood: In short, it doesn't make sense for libguestfs to do so -- as the key enrollment happens in the (virtual) BIOS | 14:27 |
kashyap | lyarwood: I also ran it past the libguestfs folks, and FWIW, they too agree with what I suggested -- just use the external tool. | 14:28 |
alex_xu | mriedem: I get better soon in few days, but my daughter get sick also. get blame by whole family :) | 14:28 |
gibi | mriedem: give the deployer some hint about what to do. If there are nova-manage CLIs the call then mention those | 14:28 |
*** janki has quit IRC | 14:29 | |
mriedem | alex_xu: heh, i suppose from all the travel over the holiday | 14:29 |
mriedem | gibi: ok done | 14:29 |
gibi | mriedem: thanks | 14:29 |
*** sridharg has quit IRC | 14:30 | |
*** awaugama has quit IRC | 14:31 | |
kashyap | lyarwood: (And, thanks for the review!) | 14:31 |
kashyap | gibi: If you want to re-ACK, in your "copious free time" :-) -- https://review.openstack.org/#/c/506720/ | 14:32 |
*** mlavalle has joined #openstack-nova | 14:32 | |
openstackgerrit | Merged openstack/nova stable/ocata: Fix disk size during live migration with disk over-commit https://review.openstack.org/530744 | 14:33 |
openstackgerrit | Merged openstack/nova stable/ocata: Refix disk size during live migration with disk over-commit https://review.openstack.org/631376 | 14:33 |
gibi | kashyap: ping me tomorrow please | 14:34 |
openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Re-approve AMD SEV support for Train https://review.openstack.org/641994 | 14:34 |
kashyap | gibi: Sure, thanks | 14:34 |
aspiers | sean-k-mooney, efried: new version of spec^^^ | 14:34 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add --instance option to heal_allocations https://review.openstack.org/651945 | 14:35 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add BFV wrinkle to TestNovaManagePlacementHealAllocations https://review.openstack.org/651948 | 14:35 |
efried | aspiers: ack, put r on the etherpad | 14:36 |
aspiers | will do | 14:36 |
*** lpetrut has joined #openstack-nova | 14:36 | |
efried | I'm going to take today off, folks. See you tomorrow. o/ | 14:39 |
*** efried is now known as efried_pto | 14:39 | |
openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Re-approve AMD SEV support for Train https://review.openstack.org/641994 | 14:40 |
*** tetsuro has quit IRC | 14:41 | |
dansmith | mriedem: was on a call when you pinged earlier.. do I need to read back? | 14:42 |
*** awaugama has joined #openstack-nova | 14:45 | |
stephenfin | dansmith: I don't know what you're referring to with mriedem, but if you've 2 minutes to sanity check this discussion between efried and I, I'd appreciate it https://review.openstack.org/#/c/651302/1/nova/objects/instance.py | 14:46 |
*** hongbin has joined #openstack-nova | 14:48 | |
dansmith | stephenfin: which, about the notifications? | 14:48 |
stephenfin | yeah | 14:48 |
stephenfin | assuming you know. If not, we'll have to go with our (hopefully not too creative) interpretation of what it's doing :) | 14:49 |
*** ttsiouts has quit IRC | 14:50 | |
*** ttsiouts has joined #openstack-nova | 14:51 | |
*** ttsiouts has quit IRC | 14:52 | |
*** ttsiouts has joined #openstack-nova | 14:52 | |
mriedem | dansmith: i don't think so | 14:52 |
dansmith | mriedem: okay | 14:52 |
dansmith | stephenfin: I don't really, but I added words | 14:56 |
stephenfin | Words are good. Thanks | 14:57 |
*** takashin has left #openstack-nova | 15:00 | |
openstackgerrit | Merged openstack/nova stable/pike: Fix incompatible version handling in BuildRequest https://review.openstack.org/647557 | 15:04 |
*** tosky has joined #openstack-nova | 15:08 | |
mriedem | stephenfin: there is something wrong in the reno in https://review.openstack.org/#/c/651291/ plus some other FUP stuff - do you want me to just +W and then you can start a FUP change for that patch? | 15:14 |
stephenfin | mriedem: Yes please. It's a huge series | 15:15 |
stephenfin | I've got one follow-up at the end already | 15:15 |
sean-k-mooney | mriedem: by the way similar to https://bugs.launchpad.net/nova/+bug/1790204 but on the nova side we cant support inplace resize for numa instances due to how the numa toplogy filter or more acurally the nova.virt.hardware module is implemented | 15:15 |
openstack | Launchpad bug 1790204 in OpenStack Compute (nova) "Allocations are "doubled up" on same host resize even though there is only 1 server on the host" [High,Triaged] | 15:15 |
mriedem | stephenfin: ok there are probably enough in here to give it its own fup patch but i'll approve | 15:16 |
sean-k-mooney | mriedem: so even if ^ is fix for numa instance it can still failt if the host is full | 15:16 |
openstackgerrit | François Palin proposed openstack/nova master: Include all network devices in nova diagnostics https://review.openstack.org/648123 | 15:16 |
sean-k-mooney | i had breifly disccused supporing inplacee resize for numa instance downstream as we had a customer request realted to it but wanted to wait until the ptg to see how things panned out | 15:19 |
mriedem | sean-k-mooney: ok i haven't put any thought into numa for that bug, just the simple resource class cases | 15:20 |
*** markvoelker has joined #openstack-nova | 15:20 | |
sean-k-mooney | well its an issue with the resouce track side not placement. | 15:20 |
sean-k-mooney | if we do "fix" it want i wanted to ask is shoudl i be a bug or a blueprint | 15:21 |
sean-k-mooney | e.g. is it feature or an oversitght/bug | 15:21 |
sean-k-mooney | in the context of fixing https://bugs.launchpad.net/nova/+bug/1790204 you can ignore numa. im just wonderinf what i should be filing for the numa same host resize/rebuild case bug/spec/blueprint | 15:23 |
openstack | Launchpad bug 1790204 in OpenStack Compute (nova) "Allocations are "doubled up" on same host resize even though there is only 1 server on the host" [High,Triaged] | 15:23 |
*** luksky has quit IRC | 15:27 | |
*** ttsiouts has quit IRC | 15:30 | |
*** ivve has quit IRC | 15:31 | |
mriedem | stephenfin: another reno fix needed for https://review.openstack.org/#/c/651294/ in a fup somewhere, | 15:34 |
adrianc | mriedem: Hi, was hoping to get your inputs on https://review.openstack.org/#/c/649345, it seems that _heal_instance_info_cache updates port binding:host_id to point to the compute host. while this is OK for most cases, its problematic for baremetal with Smart NIC https://storyboard.openstack.org/#!/story/2003346 | 15:34 |
stephenfin | ack | 15:34 |
mriedem | and probably want melwitt to answer the question about what map_cell_and_hosts is used for | 15:34 |
sean-k-mooney | adrianc: that periodic task was not intended to run for ironic nodes. at least how its written it was apparently assuming it was running no a vm host | 15:36 |
mriedem | adrianc: that's a regression due to https://review.openstack.org/#/c/603844/ right? | 15:36 |
*** slaweq has quit IRC | 15:36 | |
mriedem | before ^ that periodic wouldn't mess with port bindings | 15:36 |
adrianc | sean-k-mooney: yea i know, hence i think it should not run on BM :) | 15:37 |
adrianc | mriedem: yes that is correct | 15:38 |
*** gyee has joined #openstack-nova | 15:38 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova-specs master: Add host and hypervisor_hostname flag to create server https://review.openstack.org/645458 | 15:38 |
sean-k-mooney | well for ironic nodes it could update teh port binding for the ironic node instead of skiping but ya we didnt think about that usesece with the previous patch | 15:39 |
adrianc | is the BM use-case relevant for this type of healing ? | 15:40 |
mriedem | adrianc: comments inline | 15:41 |
sean-k-mooney | adrianc: im not sure | 15:41 |
mriedem | adrianc: before that change the periodic task was essentially read-only as far as the ports are concerned, nova would just refresh it's internal cache | 15:41 |
adrianc | thanks mriedem, appreciated | 15:41 |
mriedem | what you need to avoid in the BM case is the update to the port | 15:41 |
sean-k-mooney | i know we cna do boot form volume with ironic now | 15:41 |
sean-k-mooney | do we supprot resize/cold migrate | 15:42 |
sean-k-mooney | in principal if we did then yes we coudl have the same failure cases | 15:42 |
mriedem | no we don't | 15:43 |
sean-k-mooney | ok there is no reason that should not be supported for boot form volume ironic instance right? | 15:45 |
sean-k-mooney | i guess there is the quetion of ephemeral storage | 15:46 |
mriedem | there was a spec for supporting migration of ironic instances, you could read the details there | 15:46 |
mriedem | https://review.openstack.org/#/c/449155/ | 15:47 |
sean-k-mooney | if it was a pure bfv ironic node with no local disk it should work. no im jsut trying to reson about if we would need to validate neutron port for ironic instance in the future | 15:47 |
mriedem | anyway, that doesn't really have anything to do with this change IMO | 15:47 |
mriedem | just avoid the port binding update if ironic to get back to the pre-regression behavior | 15:47 |
*** igordc has joined #openstack-nova | 15:47 | |
sean-k-mooney | ya i was leaving a comment to say somthign similar | 15:47 |
sean-k-mooney | just wondering if we will need to do something more involed in the future | 15:48 |
sean-k-mooney | but to fix the regress we jus tneed to not to the port binding update here https://review.openstack.org/#/c/649345/4/nova/compute/manager.py@73311 | 15:48 |
sean-k-mooney | sorry here https://review.openstack.org/#/c/649345/4/nova/compute/manager.py@7311 | 15:49 |
sean-k-mooney | extra 3 | 15:49 |
adrianc | a noob's question here, but why would nova attempt to fix something that ironic did ? that is, ironic is the once who does the actual port binding today right ? | 15:50 |
mriedem | melwitt: you should review this part of the cells v2 removal series regarding console stuff https://review.openstack.org/#/c/651295/ | 15:50 |
mriedem | adrianc: the regression was just an oversight | 15:50 |
sean-k-mooney | adrianc: it depends on the workflow. for spawn yes the virt dirver does the binding | 15:50 |
sean-k-mooney | adrianc: this was trying to fix move opertion for virt dirver that supprot them | 15:51 |
*** igordc has quit IRC | 15:51 | |
sean-k-mooney | for live migration the conductor does the binidng | 15:51 |
adrianc | understood, sean-k-mooeny, was just addressing what you said about, "just wondering if we will need to do something more involed in the future" | 15:52 |
sean-k-mooney | adrianc: ah well if we support move operation maybe we shoudl be honestly this is only here because we dont cleanup thing correctly on revert or failed migration in all cases | 15:53 |
sean-k-mooney | adrianc: if we did we would not need to heal the info cache | 15:53 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add image type capability flags and trait conversions https://review.openstack.org/652710 | 15:55 |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Server move operations with ports having resource request https://review.openstack.org/652608 | 15:55 |
*** belmoreira has quit IRC | 15:59 | |
*** luksky has joined #openstack-nova | 16:05 | |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Standardize CPU resource tracking https://review.openstack.org/555081 | 16:07 |
mriedem | bauzas: could take a look at these backports? https://review.openstack.org/#/q/topic:bug/1821594+branch:stable/rocky | 16:07 |
*** lpetrut has quit IRC | 16:08 | |
openstackgerrit | Merged openstack/nova stable/ocata: Update port device_owner when unshelving https://review.openstack.org/626413 | 16:11 |
*** boxiang has quit IRC | 16:16 | |
*** boxiang has joined #openstack-nova | 16:17 | |
*** tesseract has quit IRC | 16:21 | |
sean-k-mooney | the periodic task is ment to heal all instance that need to be healed on each invocation right? | 16:23 |
sean-k-mooney | because if it is, that is not what it actully does | 16:24 |
sean-k-mooney | oh actully reading the doc string that was intentional? | 16:25 |
*** slaweq has joined #openstack-nova | 16:25 | |
*** rpittau is now known as rpittau|afk | 16:28 | |
*** slaweq_ has joined #openstack-nova | 16:29 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Enable test_volume_backed_live_migration in tempest https://review.openstack.org/528104 | 16:31 |
*** slaweq has quit IRC | 16:31 | |
*** ivve has joined #openstack-nova | 16:35 | |
openstackgerrit | Merged openstack/nova stable/queens: Ignore VolumeAttachmentNotFound exception in compute.manager https://review.openstack.org/637391 | 16:37 |
*** jmlowe has joined #openstack-nova | 16:39 | |
*** psachin has quit IRC | 16:42 | |
*** dtantsur is now known as dtantsur|afk | 16:44 | |
*** priteau has quit IRC | 16:47 | |
*** priteau has joined #openstack-nova | 16:49 | |
*** jmlowe has quit IRC | 16:50 | |
tssurya | dansmith: about the power update event spec (https://review.openstack.org/#/c/636132/4/specs/train/approved/nova-support-instance-power-update.rst) whenever you have the time could you confirm the things discussed at L77 and L74 ? main concern being the notifications/action record requirement | 16:53 |
tssurya | thanks! :) | 16:53 |
*** davidsha has quit IRC | 16:54 | |
*** tssurya has quit IRC | 16:58 | |
*** pacharya has joined #openstack-nova | 17:09 | |
*** boxiang has quit IRC | 17:10 | |
*** zhubx has joined #openstack-nova | 17:10 | |
*** ralonsoh has quit IRC | 17:14 | |
*** cdent has quit IRC | 17:21 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove ComputeDriver.macs_for_instance method https://review.openstack.org/652737 | 17:22 |
*** ivve has quit IRC | 17:22 | |
*** _erlon_ has joined #openstack-nova | 17:25 | |
*** amodi has quit IRC | 17:26 | |
*** jmlowe has joined #openstack-nova | 17:30 | |
pacharya | a quick question, does creation of a batch instance delete API fall under https://docs.openstack.org/nova/latest/contributor/project-scope.html#no-more-orchestration ? | 17:30 |
_erlon_ | Folks, Im trying to debug a failure on the instance creation on Nova, on a Pike release, but all I get is " Got no allocation candidates from the Placement API" and no explanation on what resource is lacking: | 17:31 |
_erlon_ | http://paste.openstack.org/show/749318/ | 17:31 |
_erlon_ | look at the placement API logs also does not help | 17:32 |
_erlon_ | I didn't had this problem before the placement API was introduced | 17:32 |
_erlon_ | what is the procudure now? | 17:32 |
*** slaweq_ has quit IRC | 17:37 | |
*** pacharya has quit IRC | 17:44 | |
*** Sundar has joined #openstack-nova | 17:53 | |
mriedem | there was debug logging added to the placement GET /allocation_candidates code but i'm not sure it made it back to pike | 18:07 |
mriedem | jaypipes: ^? | 18:07 |
mriedem | _erlon_: https://review.openstack.org/#/q/If9ddb8a6d2f03392f3cc11136c4a0b026212b95b | 18:10 |
mriedem | and https://review.openstack.org/#/q/status:merged+project:openstack/nova+branch:master+topic:one-resource-per-query | 18:10 |
mriedem | that would take some work to get back to pike | 18:10 |
mriedem | _erlon_: how many computes do you have? | 18:11 |
mriedem | first thing to do would be to make sure there is a resource provider for each compute node | 18:11 |
openstackgerrit | Merged openstack/python-novaclient stable/rocky: Revert "Fix crashing console-log" https://review.openstack.org/650364 | 18:22 |
openstackgerrit | Merged openstack/python-novaclient stable/rocky: Add test for console-log and docs for bug 1746534 https://review.openstack.org/652033 | 18:22 |
openstack | bug 1746534 in python-novaclient "encoding error when doing console-log" [High,Fix released] https://launchpad.net/bugs/1746534 - Assigned to Thomas Goirand (thomas-goirand) | 18:22 |
*** ircuser-1 has joined #openstack-nova | 18:24 | |
*** markvoelker has quit IRC | 18:26 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove macs kwarg from allocate_for_instance https://review.openstack.org/652749 | 18:28 |
edleafe | vim | 18:33 |
edleafe | doh! | 18:33 |
sean-k-mooney | edleafe: password: | 18:34 |
sean-k-mooney | :) | 18:34 |
edleafe | too many windows open - now *that* would make an easy-to-remember password | 18:35 |
sean-k-mooney | im kind of sad the cirros passward is nolonger "cubswin:)" | 18:37 |
*** Sundar has quit IRC | 18:37 | |
sean-k-mooney | anyway time for dinner | 18:37 |
sean-k-mooney | o/ | 18:37 |
*** awaugama has quit IRC | 18:39 | |
*** awaugama_ has joined #openstack-nova | 18:39 | |
*** jding1_ has joined #openstack-nova | 18:49 | |
*** jackding has quit IRC | 18:52 | |
*** jmlowe has quit IRC | 18:55 | |
_erlon_ | mriedem: only 1 | 18:58 |
_erlon_ | its a devstack node | 18:58 |
mriedem | _erlon_: oh, well, make sure it's reporting into placement with the correct inventory | 19:00 |
mriedem | https://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-list | 19:00 |
mriedem | https://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-inventory-list | 19:00 |
_erlon_ | mriedem: its a devstack node and should be working fine | 19:00 |
_erlon_ | I can like create up to 3 instances | 19:00 |
_erlon_ | the 4th fails for some reason | 19:00 |
mriedem | well, you can use ^ to see the inventory of the provider, | 19:02 |
mriedem | and https://docs.openstack.org/osc-placement/latest/cli/index.html#resource-usage-show to see the usage of the project which you used to create instances | 19:02 |
mriedem | and then see if there is any remaining capacity for the 4th instance you're trying to create | 19:02 |
*** markvoelker has joined #openstack-nova | 19:04 | |
*** eharney has quit IRC | 19:18 | |
*** Sundar has joined #openstack-nova | 19:29 | |
*** mdbooth_ has quit IRC | 19:34 | |
*** tbachman has quit IRC | 19:34 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle unsetting '[DEFAULT] dhcp_domain' https://review.openstack.org/652662 | 19:34 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: conf: Undeprecate and move the 'dhcp_domain' option https://review.openstack.org/480616 | 19:34 |
*** helenafm has quit IRC | 19:41 | |
*** awaugama_ has quit IRC | 19:44 | |
*** penick has quit IRC | 19:46 | |
*** slaweq_ has joined #openstack-nova | 19:47 | |
*** mlavalle has quit IRC | 19:47 | |
*** dave-mccowan has joined #openstack-nova | 19:48 | |
mriedem | edleafe: error response status code question! https://review.openstack.org/#/c/645458/17/specs/train/approved/add-host-and-hypervisor-hostname-flag-to-create-server.rst@141 | 19:49 |
*** mlavalle has joined #openstack-nova | 19:49 | |
* edleafe jumps into a nearby phone booth | 19:49 | |
mriedem | do those still exist? | 19:50 |
* edleafe realizes that there are no more phone booths | 19:50 | |
edleafe | jink | 19:50 |
edleafe | jinx | 19:50 |
aspiers | we still have some | 19:50 |
aspiers | but I don't think they tend to work | 19:50 |
aspiers | unless you're a timelord | 19:50 |
jaypipes | _erlon_: did you find the answer to your query? | 19:50 |
artom | Just quick sanity check to be 100% sure, but the resource stats we provide in https://developer.openstack.org/api-ref/compute/?expanded=show-hypervisor-details-detail#show-hypervisor-details come from the resource tracker via the ComputeNode object, right? And specifically, not from placement? | 19:52 |
edleafe | mriedem: that's not really a response code question, is it? If the app logic is to let the scheduler pick, then 2xx. If you treat the value as missing, then 400 | 19:52 |
mriedem | edleafe: this one? "The new (``host`` and/or ``hypervisor_hostname``) and the old | 19:53 |
mriedem | (``az:host:node``) mechanisms are mutually exclusive. If both are specified | 19:53 |
mriedem | in the same request, the API will return a 409 HTTP Conflict error." | 19:53 |
mriedem | they are saying the api will return an error and we don't get to the scheduler | 19:53 |
mriedem | i'm just saying that's not a 409 | 19:53 |
edleafe | mriedem: huh, I clicked that link and L125 was front and center | 19:53 |
mriedem | artom: everything in the hypervisors api comes from the compute node yeah | 19:54 |
artom | mriedem, cheerS! | 19:54 |
edleafe | Yeah, that's not a 409. There's nothing conflicting about the state of the system and the request. It's just a bad request | 19:54 |
mriedem | artom: interestingly that API doesn't use the ComputeNode.stats object https://github.com/openstack/nova/blob/78e742662edd164c46382c31e106884762fed029/nova/db/sqlalchemy/api.py#L730 | 19:55 |
mriedem | https://github.com/openstack/nova/blob/78e742662edd164c46382c31e106884762fed029/nova/objects/compute_node.py#L81 | 19:55 |
mriedem | which is this happy thing https://github.com/openstack/nova/blob/78e742662edd164c46382c31e106884762fed029/nova/compute/stats.py | 19:56 |
artom | mriedem, should it? Looks like stats is an aggregate, while the hypervisors API is per node | 19:56 |
mriedem | i'd say my default answer to "should the hypervisors api have more detail in it" is "probably not' | 19:57 |
mriedem | https://developer.openstack.org/api-ref/compute/?expanded=#show-hypervisor-statistics is an aggregate yes | 19:58 |
artom | I meant "should it" as more of a "why would you expect it to?" | 19:58 |
artom | Oooo I know, let's have NUMA nodes as REST resources and provide an API to access /sys/devices/system/node/node0/meminfo | 19:59 |
mriedem | from the outside i'd expect an api that is called "statistics" to leverage a 'stats' field on that resource in the db | 20:00 |
mriedem | artom: i'm pretty sure there is an intel spec for that | 20:00 |
*** Sundar has quit IRC | 20:00 | |
artom | *snerk* | 20:00 |
artom | "efried pto" Aha, that explains it ;) | 20:03 |
mriedem | mnaser: i saw you abandoned https://review.openstack.org/#/c/577933/ - is that because you don't need it anymore, or just don't have time to work on it? because i think a couple of people asked for the same thing and it's reasonable imo, probably just needs paperwork done and such (which someone could help with) | 20:04 |
mnaser | mriedem: I still think it's useful but I don't think I have the time to work on the paperwork and what not honestly | 20:04 |
mnaser | not right now, anyways | 20:05 |
mnaser | maybe I can restore and leave it with a "hey if you wanna pick this up, feel free to?" | 20:05 |
mriedem | i think the only question is about a stale hostId value in the config drive on an instance that is live migrated around | 20:06 |
mriedem | but for that matter the az value in the config drive could already be stale for the same reason | 20:07 |
artom | mriedem, didn't we specifically make a point of not updating device tag information on the config drive? | 20:07 |
artom | hostId could fall under the same argument - "if you need up to date info, use the API" | 20:07 |
mriedem | artom: i vaguely recall talking about punting on updating tags in the config drive because we just don't refresh the thing | 20:07 |
mriedem | we rebuild it in some cases (rebuild w/o shared storage, unshelve) | 20:08 |
artom | I believe we settled on something like "we won't update it for you, it'll get rebuilt when it gets rebuilt" | 20:08 |
mriedem | you get what you get and you don't throw a fit? | 20:08 |
*** jmlowe has joined #openstack-nova | 20:10 | |
mriedem | mnaser: i'll reach out to our downstream product team and see if they have a similar need for this | 20:11 |
artom | mriedem, basically - https://github.com/openstack/nova/blob/master/releasenotes/notes/virt-device-tagged-attach-53e214d3b3fdd183.yaml | 20:11 |
mnaser | mriedem: cool, want me to restore it? | 20:11 |
mriedem | mnaser: i can if i'm going to work on it | 20:11 |
mriedem | so don't bother | 20:11 |
mnaser | mriedem: ok cool! | 20:12 |
mnaser | I have been dealing with other fun weird things | 20:12 |
mnaser | like resource reporting messages taking way too long | 20:12 |
mnaser | and timing out | 20:12 |
mnaser | but that only happening during live migrations | 20:12 |
mnaser | I don't wanna point at nova yet.. but it's pretty weird. | 20:13 |
mriedem | "resource reporting messages"? | 20:13 |
mnaser | eh the stuff that runs every little bit and reports the instance list to the scheduler | 20:13 |
mnaser | and then at some point a post_live_migration failed too with a timeout | 20:13 |
mriedem | oh, didn't know you relied on that | 20:13 |
mriedem | sync_instance_info should be a broadcast - no timeout | 20:14 |
mnaser | I mean I think if we want (anti-)affinity, we have to afaik? | 20:14 |
mriedem | no, it's just a cache in the scheduler | 20:14 |
mriedem | if the data isn't cached in the scheduler it pulls it from the db per request - which could be slow | 20:14 |
mnaser | oh yeah I remember that | 20:14 |
mnaser | let me find the traceback | 20:14 |
dansmith | mriedem: I have to submit something to lower-constraints itself before I can put it in nova yeah? | 20:15 |
mriedem | dansmith: no, it's per-project | 20:15 |
mriedem | not like the old g-r way | 20:15 |
dansmith | sigh | 20:15 |
mriedem | honestly i don't know why we have lower-constraints.txt and requirements.txt | 20:15 |
dansmith | might as well not ever try to remember because it'll be different | 20:15 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add image type capability flags and trait conversions https://review.openstack.org/652710 | 20:15 |
mriedem | g-r was dropped so requirements.txt isn't automatically updated from g-r anymore | 20:15 |
mnaser | https://www.irccloud.com/pastebin/drWAr4hV/ | 20:16 |
mriedem | and lower-constraints was added, but.... | 20:16 |
dansmith | right but I thought lower was, but whaterver | 20:16 |
openstackgerrit | Merged openstack/nova master: Remove cells v1 jobs https://review.openstack.org/651289 | 20:16 |
mnaser | is resource_tracker not thee same thing? maybe I'm being misleading here | 20:16 |
mriedem | mnaser: not that's something else, sec | 20:16 |
mriedem | https://github.com/openstack/nova/blob/stable/stein/nova/compute/resource_tracker.py#L1323 | 20:17 |
mriedem | it's timing out pulling instances from the db | 20:17 |
mriedem | well, "an instance" | 20:17 |
mriedem | which....your db / mq must be getting hammered? | 20:17 |
mnaser | mriedem: nothing sticks out | 20:18 |
mriedem | that will kill the whole update_available_resource periodic though | 20:18 |
mriedem | until the next time it runs i mean | 20:18 |
*** tbachman has joined #openstack-nova | 20:19 | |
mriedem | sync_instance_info is a different periodic that reports info to the scheduler | 20:19 |
mriedem | per host | 20:19 |
mnaser | I remember seeing a traceback involving it | 20:19 |
mnaser | let me check again | 20:19 |
*** dave-mccowan has quit IRC | 20:20 | |
*** tbachman has quit IRC | 20:38 | |
*** pcaruana has quit IRC | 20:38 | |
*** priteau has quit IRC | 20:44 | |
*** dave-mccowan has joined #openstack-nova | 20:54 | |
*** dave-mccowan has quit IRC | 20:57 | |
*** slaweq_ is now known as slaweq | 20:58 | |
*** ceryx has left #openstack-nova | 21:01 | |
*** ccstone has joined #openstack-nova | 21:02 | |
*** erlon has quit IRC | 21:06 | |
*** sambetts_ has quit IRC | 21:10 | |
*** sambetts_ has joined #openstack-nova | 21:10 | |
mriedem | why doesn't tox yell at me anymore when i provide an env which doesn't exist? | 21:17 |
*** jackding has joined #openstack-nova | 21:18 | |
mriedem | dansmith: do you remember this from 3+ years ago? https://review.openstack.org/#/c/256073/ | 21:30 |
mriedem | if so, did https://review.openstack.org/#/c/325684/ regress it? | 21:31 |
*** mdbooth has joined #openstack-nova | 21:31 | |
sean-k-mooney | so it was fixed for 6 months 2 and a half years ago | 21:32 |
sean-k-mooney | i must say i like the topic branch | 21:33 |
sean-k-mooney | *topic name | 21:33 |
*** tbachman has joined #openstack-nova | 21:34 | |
mriedem | i just noticed that the base TestCase is still doing openstack_driver.DRIVER_CACHE = {} even though that's not used anymore | 21:34 |
*** eharney has joined #openstack-nova | 21:35 | |
sean-k-mooney | i was going to say i assume you were doing git blame on something random and found that | 21:35 |
sean-k-mooney | presuably we should create an updated version of dans original caching patch again for this | 21:36 |
sean-k-mooney | i think we have several other dictionay caches at this point so we can proably reuse one for it | 21:37 |
dansmith | mriedem: I don't remember it no | 21:37 |
mriedem | i'll put up a logging patch that logs every time we create that object | 21:37 |
mriedem | to see how bad it is | 21:37 |
mriedem | dansmith: coincidentally that series is related to recent issues https://review.openstack.org/#/q/topic:okay-we-got-it+(status:open+OR+status:merged) | 21:38 |
*** mvkr has quit IRC | 21:38 | |
*** awalende has joined #openstack-nova | 21:40 | |
sean-k-mooney | mriedem: by the way i added a memorize decorator in https://review.openstack.org/#/c/599071/3/nova/api/validation/parameter_types.py so we could just move the into the nova utils and reuse it if we want | 21:41 |
*** ivve has joined #openstack-nova | 21:41 | |
*** jding1__ has joined #openstack-nova | 21:43 | |
*** awalende has quit IRC | 21:45 | |
*** jackding has quit IRC | 21:46 | |
*** jding1_ has quit IRC | 21:46 | |
*** ivve has quit IRC | 21:46 | |
*** jackding has joined #openstack-nova | 21:46 | |
*** mvkr has joined #openstack-nova | 21:51 | |
*** whoami-rajat has quit IRC | 21:54 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Make nova.compute.rpcapi.ComputeAPI.router a singleton https://review.openstack.org/649197 | 21:59 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: log when loading security group driver https://review.openstack.org/652783 | 22:06 |
*** slaweq has quit IRC | 22:12 | |
*** mriedem has quit IRC | 22:14 | |
*** mlavalle has quit IRC | 22:15 | |
*** luksky has quit IRC | 22:25 | |
*** erlon has joined #openstack-nova | 22:49 | |
*** tkajinam has joined #openstack-nova | 22:53 | |
*** markvoelker has quit IRC | 22:57 | |
*** markvoelker has joined #openstack-nova | 23:08 | |
*** hongbin has quit IRC | 23:11 | |
*** lbragstad has quit IRC | 23:13 | |
*** avolkov has quit IRC | 23:15 | |
*** rcernin has joined #openstack-nova | 23:24 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: Restore connection_info after live migration rollback https://review.openstack.org/551349 | 23:39 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP compute: Use source_bdms to reset attachment_ids during LM rollback https://review.openstack.org/652800 | 23:39 |
*** erlon has quit IRC | 23:48 | |
openstackgerrit | Merged openstack/nova stable/rocky: Adding tests to demonstrate bug #1821824 https://review.openstack.org/649602 | 23:48 |
openstack | bug 1821824 in OpenStack Compute (nova) rocky "Forbidden traits in flavor properties don't work" [High,In progress] https://launchpad.net/bugs/1821824 - Assigned to Eric Fried (efried) | 23:48 |
openstackgerrit | Merged openstack/nova stable/rocky: Fix bug preventing forbidden traits from working https://review.openstack.org/649603 | 23:48 |
openstackgerrit | Merged openstack/nova stable/rocky: Add missing libvirt exception during device detach https://review.openstack.org/651637 | 23:48 |
*** erlon has joined #openstack-nova | 23:50 | |
*** erlon has quit IRC | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!