Wednesday, 2019-04-24

*** dosaboy has quit IRC00:08
*** ganso has quit IRC00:08
*** ganso has joined #openstack-nova00:08
*** dosaboy has joined #openstack-nova00:09
*** mdbooth_ has joined #openstack-nova00:10
*** mdbooth has quit IRC00:13
*** jangutter has quit IRC00:22
*** nicolasbock has quit IRC00:27
*** jangutter has joined #openstack-nova00:30
openstackgerritmelanie witt proposed openstack/nova master: Fix SynchronousThreadPoolExecutorFixture mock spec  https://review.opendev.org/65017100:34
openstackgerritmelanie witt proposed openstack/nova master: Revert "Fix target_cell usage for scatter_gather_cells"  https://review.opendev.org/65389400:34
openstackgerritmelanie witt proposed openstack/nova master: Use futurist.GreenThreadPoolExecutor in scatter_gather_cells  https://review.opendev.org/65017200:34
*** jangutter has quit IRC00:40
*** jangutter has joined #openstack-nova00:46
*** slaweq has quit IRC00:58
*** takashin has joined #openstack-nova01:00
*** hoonetorg has quit IRC01:01
*** mriedem has quit IRC01:03
*** yedongcan has joined #openstack-nova01:11
*** markvoelker has joined #openstack-nova01:13
openstackgerritTetsuro Nakamura proposed openstack/nova master: Don't persist _nova_check_type flag in database  https://review.opendev.org/65527801:14
*** hoonetorg has joined #openstack-nova01:15
*** whoami-rajat has joined #openstack-nova01:16
*** mvkr has quit IRC01:32
openstackgerritMichael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement.  https://review.opendev.org/63543101:45
openstackgerritMichael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods.  https://review.opendev.org/63543301:45
openstackgerritMichael Still proposed openstack/nova master: Privsep the ebtables modification code.  https://review.opendev.org/63543501:45
openstackgerritMichael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep.  https://review.opendev.org/63543601:45
openstackgerritMichael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep.  https://review.opendev.org/63650801:45
openstackgerritMichael Still proposed openstack/nova master: Move dnsmasq restarts to privsep.  https://review.opendev.org/63928001:45
openstackgerritMichael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep.  https://review.opendev.org/63928101:45
openstackgerritMichael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep.  https://review.opendev.org/63928201:45
openstackgerritMichael Still proposed openstack/nova master: Move setting of device trust to privsep.  https://review.opendev.org/63928301:45
openstackgerritMichael Still proposed openstack/nova master: Move final bridge commands to privsep.  https://review.opendev.org/63958001:45
openstackgerritMichael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network.  https://review.opendev.org/63958101:45
openstackgerritMichael Still proposed openstack/nova master: We no longer need rootwrap.  https://review.opendev.org/55443801:45
openstackgerritMichael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note.  https://review.opendev.org/63982601:45
openstackgerritMichael Still proposed openstack/nova master: Improve test coverage of nova.privsep.utils.  https://review.opendev.org/65528101:45
openstackgerritMichael Still proposed openstack/nova master: Remove no longer required "inner" methods.  https://review.opendev.org/65528201:45
*** gerrykopec has quit IRC01:49
openstackgerritBoxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server  https://review.opendev.org/64552002:01
*** ricolin has joined #openstack-nova02:06
openstackgerritMerged openstack/nova master: Fix {min|max}_version in ironic Adapter setup  https://review.opendev.org/65445702:08
*** gmann_afk is now known as gmann02:16
*** mvkr has joined #openstack-nova02:21
*** igordc has joined #openstack-nova02:43
*** ileixe has quit IRC02:50
*** dikonoor has joined #openstack-nova02:51
*** ileixe has joined #openstack-nova02:53
*** ileixe has quit IRC02:53
*** jdillaman has quit IRC02:54
*** psachin has joined #openstack-nova03:02
*** lbragstad has quit IRC03:08
*** ileixe has joined #openstack-nova03:22
*** whoami-rajat has quit IRC03:35
*** udesale has joined #openstack-nova03:58
openstackgerritBoxiang Zhu proposed openstack/python-novaclient master: Add host and hypervisor_hostname to create servers  https://review.opendev.org/64767104:02
*** whoami-rajat has joined #openstack-nova04:06
*** arshad777 has quit IRC04:19
*** ivve has quit IRC04:25
*** ileixe has quit IRC04:28
*** ileixe has joined #openstack-nova04:31
openstackgerritMerged openstack/nova master: Fix ProviderUsageBaseTestCase._run_periodics for multi-cell  https://review.opendev.org/64117904:54
openstackgerritMerged openstack/nova master: Improve CinderFixtureNewAttachFlow  https://review.opendev.org/63938204:54
*** ivve has joined #openstack-nova05:02
*** ileixe has quit IRC05:06
*** ileixe has joined #openstack-nova05:09
*** markvoelker has quit IRC05:10
*** ratailor has joined #openstack-nova05:17
*** yedongcan has quit IRC05:39
*** mvkr has quit IRC05:40
*** igordc has quit IRC05:49
*** Luzi has joined #openstack-nova05:50
*** yedongcan has joined #openstack-nova05:52
*** mvkr has joined #openstack-nova05:53
openstackgerritzhongshengping proposed openstack/nova master: Replace git.openstack.org URLs with opendev.org URLs  https://review.opendev.org/65439806:00
*** ileixe has quit IRC06:01
*** dakshina-ilangov has joined #openstack-nova06:10
*** ileixe has joined #openstack-nova06:12
*** sridharg has joined #openstack-nova06:12
*** boxiang has quit IRC06:21
*** boxiang has joined #openstack-nova06:21
*** d34dh0r53 has quit IRC06:22
*** pcaruana has joined #openstack-nova06:24
*** arshad777 has joined #openstack-nova06:44
arshad777Hi everyone, I am trying to create an instance on the controller node on a multinode setup but getting no valid host found in nova log. Please refer nova log http://paste.openstack.org/show/749631/ for more detail. Please let me know if some thing is wrong on my setup06:46
*** yonglihe has joined #openstack-nova06:47
*** Luzi has quit IRC06:50
*** ralonsoh has joined #openstack-nova06:52
*** liuyulong_ has joined #openstack-nova06:55
*** rpittau|afk is now known as rpittau06:56
*** slaweq has joined #openstack-nova06:57
*** Luzi has joined #openstack-nova06:57
*** ileixe has quit IRC06:58
*** ileixe has joined #openstack-nova07:00
*** egonzalez has quit IRC07:03
*** egonzalez has joined #openstack-nova07:04
*** rcernin has quit IRC07:05
openstackgerritMerged openstack/nova stable/queens: libvirt: set device address tag only if setting disk unit  https://review.opendev.org/65351207:05
*** markvoelker has joined #openstack-nova07:12
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Prevent "qbr" Linux Bridge from replying to ARP messages  https://review.opendev.org/65533207:19
*** luksky has joined #openstack-nova07:26
*** tosky has joined #openstack-nova07:26
*** phasespace has joined #openstack-nova07:28
kashyapaspiers: Thank you :-)  Noticed it from an e-mail alert on the blueprint.  /me opens the change07:30
*** dtantsur|afk is now known as dtantsur07:40
*** luksky has quit IRC07:42
*** helenafm has joined #openstack-nova07:51
openstackgerritTetsuro Nakamura proposed openstack/nova master: Don't persist _nova_check_type flag in database  https://review.opendev.org/65527807:56
*** yan0s has joined #openstack-nova07:59
*** takashin has left #openstack-nova08:00
*** dikonoor has quit IRC08:01
kashyapaspiers: When you're awake, something unrelated: any reason why you added 'SEV' trait to a separate file, os_traits/hw/cpu/amd.py, instead of appending it to existing os_traits/hw/cpu/x86.py?08:03
aspierskashyap: based on feedback in the review08:03
aspiersI originally proposed the latter08:04
kashyapI see08:05
kashyapaspiers: So, I'm wondering if I should add the AMD CPU feature traits I added: https://review.opendev.org/#/c/655193/1/os_traits/hw/cpu/x86.py08:06
kashyap... to also amd.py08:06
aspiersdefinitely08:06
aspiersI would have thought, anyway08:06
kashyapThen, I also have to do a "clean up" of moving the existing "SVM" from x86.py to amd.py, too.  Will do that in a separate change.08:07
*** tssurya has joined #openstack-nova08:12
*** ttsiouts has joined #openstack-nova08:12
*** derekh has joined #openstack-nova08:13
aspierskashyap: https://review.opendev.org/#/c/609779/12/specs/stein/approved/amd-sev-libvirt-support.rst@9508:14
*** luksky has joined #openstack-nova08:16
* kashyap clicks08:17
gibiefried: I was about to start putting together the commits for the nova onboarding session. But then I found that you already created the DEMO commits (e.g. https://review.opendev.org/#/c/653504/) Is there something I can help with?08:18
kashyapaspiers: Hmm, one of the points was about whether it is an instruction set extension or not08:18
aspierskashyap: yup08:18
aspierss/definitely/I have no clue what I'm talking about/08:18
aspiersbut I can point to people who do ;-)08:18
kashyap:D08:18
kashyapI find that too granular.  We should stick to one clear approach: if they're AMD-specific, then use amd.py (regardless of whether it an "instruction set extension' or whatever it is)08:19
kashyapAnyway, not too important.08:19
aspiersyeah, needs to be clearly documented, e.g. in the README08:19
kashyapAlso, "x86" can mean both Intel and AMD.  (Although, the original term derived from Intel's 8086.)08:21
aspiersright08:21
kashyapaspiers: So, 'sev' shows up under /proc/cpuinfo on an AMD box yeah?08:22
aspiersthink so but checking08:22
aspiersyes08:22
aspiersin the flags08:23
aspiersas does svm08:23
kashyapThanks08:24
openstackgerritAdam Spiers proposed openstack/nova master: Add infrastructure for invoking libvirt's getDomainCapabilities API  https://review.opendev.org/65526808:52
aspierskashyap: ^^^ PEP8 TODO issue should be fixed08:52
*** mgoddard has joined #openstack-nova08:53
kashyapAck.08:55
aspierskashyap: any thoughts on whether the tests are sufficient as is?08:56
aspierskashyap: they're a bit lame but https://review.opendev.org/#/c/633855/ is the immediate follow-up which makes them sensible again08:57
kashyapaspiers: Yeah, that is fine and more than acceptable.08:57
aspiersspecifically testing that a feature can get added to the .features list08:57
kashyapThe infra patch is ... just that ... the infra :-)08:57
aspiersright08:57
kashyapAny sensible reviewer would (and should) understand that.08:58
aspiersand it does have tests anyway, which do test some aspects of it, just not the <features> bit08:58
aspierswell even that gets basic testing I guess08:58
kashyapRight, it's perfectly fine.09:00
*** tetsuro has joined #openstack-nova09:06
*** dtantsur is now known as dtantsur|brb09:19
*** tetsuro has quit IRC09:24
*** tetsuro has joined #openstack-nova09:31
*** tetsuro has quit IRC09:34
*** tetsuro has joined #openstack-nova09:41
*** d34dh0r53 has joined #openstack-nova09:45
*** tkajinam has quit IRC09:52
*** seyeongkim has quit IRC09:53
*** awestin1 has quit IRC09:54
*** awestin1_ has joined #openstack-nova09:54
*** pas-ha has quit IRC09:54
*** gmann has quit IRC09:54
*** pas-ha has joined #openstack-nova09:54
*** rpittau has quit IRC09:55
*** vdrok has quit IRC09:55
*** mrhillsman has quit IRC09:55
*** rm_work has quit IRC09:55
*** seyeongkim has joined #openstack-nova09:55
*** gmann has joined #openstack-nova09:56
*** tetsuro has quit IRC09:56
*** vdrok has joined #openstack-nova09:57
*** rpittau has joined #openstack-nova09:57
*** mrhillsman has joined #openstack-nova09:58
*** rm_work has joined #openstack-nova10:06
openstackgerritArtom Lifshitz proposed openstack/nova master: Run revert resize tests in nova-live-migration  https://review.opendev.org/65349810:07
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert "Wait for network-vif-plugged on resize revert"  https://review.opendev.org/63939610:07
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert resize: wait for external events in compute manager  https://review.opendev.org/64488110:07
*** liuyulong_ has quit IRC10:08
kashyapjaypipes: When you're about -- hope that answers your question: https://review.opendev.org/#/c/506720/8/specs/train/approved/allow-secure-boot-for-qemu-kvm-guests.rst@1910:12
*** dakshina-ilangov has quit IRC10:12
*** shilpasd has quit IRC10:12
kashyapartom: When you get time, can you confirm if I answered your questions on PS-11: https://review.opendev.org/#/c/506720/11/specs/train/approved/allow-secure-boot-for-qemu-kvm-guests.rst10:13
kashyap(On the review is fine.)10:13
openstackgerritArtom Lifshitz proposed openstack/nova master: Run revert resize tests in nova-live-migration  https://review.opendev.org/65349810:18
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert "Wait for network-vif-plugged on resize revert"  https://review.opendev.org/63939610:18
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert resize: wait for external events in compute manager  https://review.opendev.org/64488110:18
*** rtjure has joined #openstack-nova10:18
artomkashyap, ya10:20
artomkashyap, yep, your answers make sense10:23
artomI'll leave it to your judgment on whether you want to include any of them in the spec proper :)10:23
*** yedongcan has left #openstack-nova10:30
*** dtantsur|brb is now known as dtantsur10:35
*** nicolasbock has joined #openstack-nova10:36
*** gmann has quit IRC10:44
*** tbachman has quit IRC10:50
kashyapartom: Some of them I will.  Next iteration coming soon to a Firefox tab near you :D10:52
* kashyap --> makes food10:52
*** wwriverrat has quit IRC10:52
*** belmoreira has joined #openstack-nova11:06
jaypipeskashyap: hmm, didn't I +2 that yesterday? did you push new revs?11:09
jaypipesor am I confusing with the AMD SEV one...11:09
*** belmoreira has quit IRC11:09
sean-k-mooneyjaypipes: you did11:09
*** belmoreira has joined #openstack-nova11:09
sean-k-mooneythere was a few tiny nits that were fixed11:09
NewBrucesean-k-mooney that workaround patch is holding up splendidly; but man is the live migration process dicey - any failure can really leave you messed up at times….11:10
sean-k-mooney oh sorry no i confused myself11:10
sean-k-mooneyjaypipes: you  +2'd the sev one not the secure boot one11:11
NewBrucebut the workaround +1 so thanks for that11:11
sean-k-mooneyjaypipes: ignore me11:11
sean-k-mooneyNewBruce: way we know we can harden that code more, especially in the failure case11:12
sean-k-mooneyNewBruce: ill try and make the code a bit more presentable (pass tests) after the ptg11:12
NewBruceaye, admittedly the cleanup is a complex beast and really depends on where the failure happens; but if the second ports are set up, you can be in for a bad time in some cases11:12
NewBrucesean-k-mooney no worries mate; if i get some more time, ill try and dig into that flow a bit more11:13
*** udesale has quit IRC11:16
sean-k-mooneyjaypipes: fyi if you have time to look at the latest revision of the sev spec https://review.opendev.org/#/c/641994/12 we shoudl be able to remove it form the PTG agenda assumeing your good with it still.11:19
jaypipessean-k-mooney: k, will try this afternoon.11:20
jaypipes(need to get car repair done now)11:20
sean-k-mooneycar trouble is the worst, best of luck, hopfully its minor11:21
*** rtjure has quit IRC11:28
jaypipesefried, aspiers: AMD SEV re-proposal +W'd11:29
jaypipessean-k-mooney: ^11:29
sean-k-mooney:)11:29
jaypipessean-k-mooney: and yeah, it's just a servicing. nothing major (I hope!)11:30
*** ttsiouts has quit IRC11:31
*** ttsiouts has joined #openstack-nova11:32
*** ttsiouts has quit IRC11:34
*** ttsiouts has joined #openstack-nova11:34
jaypipesefried: what are the numbers that start off each bullet point/topic in the nova ptg train etherpad? for example:11:36
jaypipes"    66 :30 Disabled compute service request filter (mriedem)"11:36
jaypipeswhat does '66' mean there?11:37
sean-k-mooneyi had the same question11:37
sean-k-mooneybut didnt ask11:37
sean-k-mooneyhow many bottels of beer we need?11:37
jaypipesheh11:39
kashyapjaypipes: Yeah, you're mixing up two different specs :-)11:40
kashyapjaypipes: Mine is the Secure Boot spec (https://review.opendev.org/#/c/506720/)11:40
jaypipeskashyap: ETOOMANYSPECS ;)11:40
kashyap:-) Understandable.11:41
*** ccamacho has joined #openstack-nova11:44
openstackgerritMerged openstack/nova-specs master: Re-approve AMD SEV support for Train  https://review.opendev.org/64199411:44
openstackgerritKashyap Chamarthy proposed openstack/os-traits master: Add CPU traits for Meltdown/Spectre mitigation  https://review.opendev.org/65519311:44
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Add HW_CPU_X86_* traits for Meltdown/Spectre mitigation  https://review.opendev.org/65519111:45
*** helenafm has quit IRC11:45
*** belmoreira has quit IRC11:53
kashyapmdbooth_: When you're get a minute, a blast from the past: wanted to triple-check if I need to raise at all in the 'else' condition: https://review.opendev.org/#/c/639091/4/nova/virt/libvirt/driver.py11:56
kashyapmdbooth_: (You have context for it; it is the "Make EBUSY handling suck less" thing)11:57
*** belmoreira has joined #openstack-nova11:57
kashyaps/you're get/you get/11:57
kashyap(I think I should 'raise' _something_ there.../me refreshes context)11:59
*** markvoelker has quit IRC12:08
*** tbachman has joined #openstack-nova12:19
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Prevent "qbr" Linux Bridge from replying to ARP messages  https://review.opendev.org/65533212:20
*** udesale has joined #openstack-nova12:29
*** dikonoor has joined #openstack-nova12:37
*** lbragstad has joined #openstack-nova12:44
*** eharney has quit IRC12:50
*** jdillaman has joined #openstack-nova12:53
*** irclogbot_3 has quit IRC12:55
*** jistr is now known as jistr|afk12:56
*** irclogbot_3 has joined #openstack-nova12:56
hemnahey guys, I have libvirt section in nova.conf setup to use rbd as the libvirt_images_type, to use ceph for all image storage, and yet the placement API says I don't have a provider with enough space to create an 80G vm (flavor m1.large)12:56
*** francoisp has quit IRC12:56
*** altlogbot_1 has quit IRC12:57
*** altlogbot_0 has joined #openstack-nova12:58
*** helenafm has joined #openstack-nova13:02
* alex_xu hates google chrome+gerrit13:03
stephenfinalex_xu: Firefox is really quite nice nowadays :)13:04
stephenfinI'd argue better than Chrome in many cases (certainly resource utilization)13:04
lyarwoodhemna: https://review.opendev.org/#/c/650188/ is aiming to model that in Placement, I assume you don't have 80G of local disks?13:05
hemnayah I don't have 80G in local disk13:05
hemnahence the usage of ceph13:05
alex_xuok, I can a try, I'm enough with the screen always scrolling automatically...13:05
lyarwoodhemna: right, I was just trying to confirm that DISK_GB wouldn't be >= 80GB for the compute node13:07
hemnahttp://paste.openstack.org/show/749699/13:07
lyarwoodhemna: I guess that's a valid bug, you could use volumes to workaround it.13:08
hemnaI have a single compute node (devstack)13:09
lyarwoodso the pool doesn't even have 80GB in it?13:10
*** ratailor has quit IRC13:10
hemna6.5Tib available13:12
hemnalyarwood: http://paste.openstack.org/show/749700/13:15
hemnawalt-cloud-vms is my pool for nova13:16
hemnanothing in it so far13:16
efriedjaypipes, sean-k-mooney: Those are my personal scratch notes for priority (lower==earlier) and estimated time needed.13:18
efriedalex_xu, stephenfin: What issues are you seeing with chrome+gerrit? I've been using that combo for years without heartache, but maybe I'm missing out on something amazing on Firefox13:18
*** belmoreira has quit IRC13:19
hemnahrmm13:19
stephenfinefried: Oh, no issues on that particular use case for me: I use Firefox for other reasons (it performs better, supports pretty much everything Chrome doesn't, and is worth supporting to avoid a browser monoculture)13:20
alex_xuefried: the screan always auto scrolling, and jump to another random place...13:20
efriedalex_xu: Oh, screen flickers up and down when reviewing big files/deltas? You can fix that by toggling the gerrit option: <your name> => Settings => Diff Options => Render => Slow13:21
alex_xus/screan/screen13:21
alex_xuyes13:21
alex_xulet me try13:21
lyarwoodhemna: sorry on a call, reading over the update_provider_tree code for the libvirt driver this should actually be set to the overall rbd pool size13:22
stephenfinbut the only time I've seen an autoscrolling issue in Gerrit is when I'm creating/editing a comment and I try to scroll down. It jumps me back up13:22
efriedIt still jumps a little for me, but only occasionally, and it never does the thrashing thing it used to do.13:22
hemnait's ok.  I'm looking further13:22
lyarwoodhemna: can you confirm what placement actually has as DISK_GB for the compute node13:22
*** belmoreira has joined #openstack-nova13:22
hemnaI just bounced n-cpu and none of the settings in the [libvirt] section of nova.conf are being used.13:22
alex_xuefried: oh yeah, looks better, thanks13:22
efriedcool13:23
hemnalyarwood: http://paste.openstack.org/show/749701/13:23
alex_xuyea, i saw a little jump, but far better than previous13:23
lyarwoodhemna: ah, so the images_type isn't rbd for some reason13:24
hemnayah, it's all the defaults13:24
hemnainstead of what I have in nova.conf [libvirt]13:24
lyarwoodhemna: it's images_type13:24
lyarwoodhemna: not libvirt_images_type13:24
lyarwoodhemna: you've prefixed everything with libvirt_* in there it seems13:24
hemnaguess it was renamed ?13:24
hemnabah ok13:25
hemnaI'll update that and retry13:25
hemnanot sure how/why I did that13:25
lyarwoodhemna: it has always been images_type, libvirt is just the config section.13:25
hemnamust have been a copy/paste from somewhere13:26
*** francoisp has joined #openstack-nova13:28
efriedalex_xu: Would you be willing to be the first contact liaison for your time zone, per http://lists.openstack.org/pipermail/openstack-discuss/2019-April/005555.html ?13:28
hemnahrmm that didn't do it13:29
hemnalooks like the conf is read from nova-cpu.conf not nova.conf ?13:29
lyarwoodyeah with devstack it is13:29
hemnayup that's what it was13:31
hemnaphew13:31
hemnalets see if I can create a vm now.  thanks for the help13:31
openstackgerritEric Fried proposed openstack/nova stable/stein: Fix {min|max}_version in ironic Adapter setup  https://review.opendev.org/65542913:31
lyarwoodhemna: np, sorry for the earlier confusion :)13:31
hemnalocal_gb is now 670513:32
hemnaa bit better13:32
lyarwoodslightly13:32
*** sapd1_x has joined #openstack-nova13:34
*** seba has joined #openstack-nova13:38
alex_xuefried: I can be that, at least i'm the only nova core in my time zone13:40
efriedalex_xu: Thanks :)13:41
openstackgerritHamdy Khader proposed openstack/nova master: Do not perform port update in case of baremetal instance.  https://review.opendev.org/64934513:41
efriedalex_xu: What is your time zone? UTC+8?13:41
alex_xuefried: np13:41
alex_xuyes13:41
*** helenafm has quit IRC13:46
*** eharney has joined #openstack-nova13:48
kashyapefried: alex_xu: Heya, does this look any beter: https://review.opendev.org/641994 https://review.opendev.org/65519113:49
efriedkashyap: Being merged, that first one looks great!13:49
kashyapefried: Hehe, one more thing: because we're consolidating all the AMD stuff in amd.py, I am going to move 'SVM' trit from x86.py to amd.py (in a separate change).13:50
kashyap(Didn't wanted to sneak it in part of this.)13:50
*** gmann has joined #openstack-nova13:51
kashyapalex_xu: efried: Also, a trait-per-CPU-feature is _correct_, isn't it?13:52
*** mriedem has joined #openstack-nova13:53
efriedkashyap: Yes, one trait per feature is correct.13:53
efriedRe: moving traits... I'm not sure what harm that could do, if any. You may need to provide a shim. edleafe jaypipes?13:53
efriedkashyap: tbc, you're not changing what the string would end up being; just the module path we take to get there, right?13:54
kashyapefried: Yes, exactly.  Just moving the 'SVM' as-is from one file to another13:54
kashyapNot modifying the string itself13:54
efriedkashyap: I mean the string as it comes out the other end. Like if it's currently HW_CPU_FOO_SVM and you made it HW_CPU_FOO_AMD_SVM, that's bad.13:55
efriedi.e. that's a *new* trait (and you can't remove the old one, and it's now confusing which one consumers should use)13:55
kashyapefried: Ah-ha...Hmm.13:55
efriedBut if it's currently in hw/cpu/foo.py and called AMD_SVM, so it actually winds up being HW_CPU_FOO_AMD_SVM, and you move it to hw/cpu/foo/amd.py and name it SVM, the string itself wouldn't change. And that's the thing that *might* be okay.13:56
kashyapI'll post the quick change, and would prefer to be educated there13:56
kashyapefried: Ah-ha, I think you're right there13:57
kashyapSo, I see it being os_traits.HW_CPU_X86_SVM13:57
efriedkashyap: Sounds like you ought to propose it in its own patch :)13:57
kashyapIf I move SVM to amd.py, it can end up being: HW_CPU_AMD_SVM13:57
efriedkashyap: Okay, so by project charter, we can't make os_traits.HW_CPU_X86_SVM go away, ever.13:57
efriedHW_CPU_AMD_SVM will be a new trait.13:58
efriedIf there's no such thing as SVM on X86, that's just too bad.13:58
efriedyou can leave a comment on it that it's bogus13:58
efriedbut you can't remove it.13:58
kashyapefried: Yeah, indeed.  SVM is AMD's equivalent of Intel's VMX (Virtual Machine Extensions)13:59
efriedOkay. So if you're just adding AMD_SVM, you can do it as part of your change if that's appropriate. Is it? Sounds like it might be unrelated.13:59
kashyapefried: Okay, that makes sense -- add a comment that it's bogus; and add a new trait for SVM in amd.py13:59
efried++14:00
kashyapefried: It's slightly unrelated: but frankly, all these traits_ you are using hardware-based virt (Intel VMX; or AMD SVM)14:00
kashyapSeparate change coming soon14:00
efriedIf your patch is called "add CPU traits related to spectre/meltdown" and it's not, then separate14:01
efriedIf your patch is called "add a bunch of CPU traits that are missing" you'll have to justify why we need each one anyway. If it's a bunch of different reasons, all in one patch could be fine. But if it's 1) spectre/meltdown and 2) this other random thing that I saw while I was here -- separate patches :)14:02
kashyapYeah, noted. :-)14:02
*** helenafm has joined #openstack-nova14:04
edleafeefried: (reading back) It's the full name of the trait that can't change. How it is constructed in the file structure of os-traits is irrelevant14:06
efriededleafe: cool, gtk14:06
*** udesale has quit IRC14:06
*** udesale has joined #openstack-nova14:07
*** udesale has quit IRC14:08
*** udesale has joined #openstack-nova14:08
mriedemefried: want to hit the easy gerrit cherry pick button to put this in stable/stein? https://review.opendev.org/#/c/654457/14:13
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Prevent "qbr" Linux Bridge from replying to ARP messages  https://review.opendev.org/65533214:13
efriedmriedem: I'm 42 minutes ahead of you.14:13
mriedemah didn't notice b/c the tb changed14:13
efriedtb?14:13
mriedemtopic branch14:14
mriedemthe gerrit ui appends an annoying branch specifier in the backports14:14
efriedoh. That's weird14:14
efriedI'll pay attention to that from now on and fix it.14:14
openstackgerritEric Fried proposed openstack/nova master: Hacking N363: Don't use spec[_set]='string'  https://review.opendev.org/65037014:24
openstackgerritEric Fried proposed openstack/nova master: Fix mock specs set to strings  https://review.opendev.org/65545514:24
openstackgerritBalazs Gibizer proposed openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations  https://review.opendev.org/63795414:24
openstackgerritBalazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations  https://review.opendev.org/63795514:24
openstackgerritBalazs Gibizer proposed openstack/nova master: pull out functions from _heal_allocations_for_instance  https://review.opendev.org/65545714:24
openstackgerritBalazs Gibizer proposed openstack/nova master: reorder conditions in _heal_allocations_for_instance  https://review.opendev.org/65545814:24
openstackgerritBalazs Gibizer proposed openstack/nova master: pull out put_allocation call from _heal_*  https://review.opendev.org/65545914:24
efriedmelwitt: FYI since we talked about this a couple weeks ago: I fixed the Mock(spec='string') things ---^ and put the patch for the hacking rule on top of it14:24
*** phasespace has quit IRC14:26
efriedkashyap: You have a lot of support for https://review.opendev.org/#/c/645814/ -- if you add some words about when/how you're going to use the information (which I still don't know from outside conversations - fail spawn? fail to start n-cpu?) I'll fast approve if that's okay with sean-k-mooney14:30
efriedaspiers: I'm removing SEV from the PTG agenda, since it's approved \o/14:31
sean-k-mooneyya im fine with that.14:31
efriedthx14:31
kashyapefried: Yeah, it's the top-2 item on my TODO, will add it by tomm, that okay?14:31
kashyapIf not for this traits yak, I would have done it today14:31
efriedkashyap: wfm14:31
efriedkashyap: IMO more important than traits yak14:32
efriedbut of course I would say that because it eases my PTG schedule pain :P14:32
sean-k-mooneyideally it would be nice to log the cpu basleing that was calulated + the flags form the cpu model and config and indicate what flag was incompatable. then kill the agent but we can discus that in the implementation14:32
kashyapefried: Yesterday, I was about to add a quick note that: "Ack, will address this once I finish addressing the Secure Boot comments"14:32
kashyap(The SB spec took a lot more time, too)14:32
sean-k-mooneyeffectivly if nova can detect via libvirt that its incomatible we shoudl also tell the operator why so that they dont need to figure it out themselves14:33
kashyapsean-k-mooney: Yeah.  Let's hash it out when I actually get to implement it14:33
jaypipesefried: ack, got it. thx!14:33
efriedjaypipes: Since parlayed into a draft agenda, see ML.14:33
efried(which may be where you were coming from in the first place)14:34
*** KH-Jared has joined #openstack-nova14:34
*** itlinux has quit IRC14:35
kashyapefried: On your question on that spec about 'where to fail' -- I'm thinking currently 'spawn'.  Will add words to the spec14:37
efriedkashyap: Perfect, thanks.14:37
efriedI don't actually have a stake in what the answer is - I just want to see one :)14:37
efriedSo it be like, "Before this wonderful feature, the instance might fail to come alive, but nova wouldn't know anything was wrong. Now we can fail the spawn operation, putting the instance in ERROR state, with a helpful log message indicating which bits are a problem."14:39
*** igordc has joined #openstack-nova14:42
*** amodi has joined #openstack-nova14:43
openstackgerritStephen Finucane proposed openstack/nova-specs master: Standardize CPU resource tracking  https://review.opendev.org/55508114:44
*** mlavalle has joined #openstack-nova14:45
kashyapefried: Hehe, noted14:46
*** yan0s has quit IRC14:46
* kashyap is a bit unwell today; so a tad slow with things. Just one more meeting to go, which is the final straw to exhaust all the neurons for the day :D14:47
*** luksky has quit IRC14:49
*** Luzi has quit IRC14:50
*** ratailor has joined #openstack-nova14:57
*** tbachman has quit IRC14:59
*** tbachman has joined #openstack-nova14:59
*** dave-mccowan has joined #openstack-nova15:01
melwittefried: ack15:04
*** pcaruana has quit IRC15:06
*** dave-mccowan has quit IRC15:07
*** amotoki_ is now known as amotoki15:08
*** ccamacho has quit IRC15:15
*** ricolin has quit IRC15:17
*** tbachman has quit IRC15:19
mriedemlyarwood: re getting the ceph job voting, we might consider disabling the ssh validation (which is on by default in tempest) to avoid spurious failures http://logs.openstack.org/06/641806/12/check/devstack-plugin-ceph-tempest/7fc39ec/testr_results.html.gz - ssh failing is something with networking breaking down, not really anything that should be a result of a ceph backend for storage15:24
mriedemit'd also make the job fast15:24
mriedem*faster15:24
mriedemlyarwood: i also posted https://review.opendev.org/#/c/655452/ earlier today15:25
*** ricolin has joined #openstack-nova15:28
*** itlinux has joined #openstack-nova15:28
openstackgerritStephen Finucane proposed openstack/nova-specs master: Standardize CPU resource tracking  https://review.opendev.org/55508115:30
lyarwoodmriedem: ack sounds and looks good, where's the best place to track devstack-plugin-ceph-tempest result trends btw?15:31
mriedemhere is a patch to disable the ssh validation https://review.opendev.org/65547215:31
mriedemthere is a graph that is out of date, sec15:32
mriedemhttp://grafana.openstack.org/d/-iKINcImz/ceph-failure-rate?orgId=115:32
mriedemhttps://opendev.org/openstack/project-config/src/branch/master/grafana/ceph.yaml needs fixing to fix that graph15:32
mriedemotherwise i think melwitt might be tracking ceph job failure rates somewhere15:32
lyarwoodkk, I can take a look at fixing the graph if there's not another way15:33
melwittI've been tracking via eyeball because I keep forgetting how to get the graph that shows the comparison with the tempest-full job15:34
mriedemthat's what that graph above is for, but it's broken15:34
* lyarwood opens the file and immediately regrets offering to help15:34
melwitthaha. I can also try to fix it15:35
mriedemfirst it was broken by the ceph job renames, but now i think it's broken b/c of some zuulv3 thing, i had talked with corvus about it before but don't remember what needs fixing now15:35
*** ivve has quit IRC15:35
mriedemlooking for one more core for this functional recreate test patch https://review.opendev.org/#/c/641521/15:36
mriedemthen i can claim victory on merging 4/47 patches of my cross-cell series while it was in runways for 2 weeks15:37
*** itlinux has quit IRC15:41
stephenfinmriedem: I thought my cells-v1 series was big... I won't get to it tonight but I can look at that tomorrow morning15:42
stephenfin(assuming no one gets to it before me)15:43
mriedemthanks15:43
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree  https://review.opendev.org/64020715:44
efriedkashyap: I just did a thorough look at https://review.opendev.org/#/c/655193/15:44
efriedI would like to get some os-traits-y people (edleafe jaypipes) to scrutinize, esp. to make a ruling on whether/how we should do the split I suggested.15:44
edleafeefried: buried in meetings etc until the afternoon15:44
kashyapefried: /me looks; (while adding words to the other spec, so as to reduce your PTG scheduling workload :-))15:44
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree  https://review.opendev.org/64020715:45
kashyapefried: Eagle eyes there!  On "stibp"15:45
efriedkashyap: No hurry on my end15:46
kashyapI missed to add it, due to all these subtle acronyms15:46
*** pcaruana has joined #openstack-nova15:46
efriedkashyap: If it helps, I distilled that web page15:47
efried 136 @node important_cpu_features_intel_x8615:47
efried 148 @item @code{pcid}15:47
efried 159 @item @code{spec-ctrl}15:47
efried 171 @item @code{stibp}15:47
efried 182 @item @code{ssbd}15:47
efried 194 @item @code{pdpe1gb}15:47
efried 248 @node important_cpu_features_amd_x8615:47
efried 260 @item @code{ibpb}15:47
efried 272 @item @code{stibp}15:47
efried 283 @item @code{virt-ssbd}15:47
efried 299 @item @code{amd-ssbd}15:47
efried 313 @item @code{amd-no-ssb}15:47
efried 325 @item @code{pdpe1gb}15:47
kashyapefried: You actually read the source I lnked.  It makes me happy that someone actually read it :D15:47
kashyapThanks for the handy posting here.15:48
mgoddardmriedem: did you see my response re placement?15:49
kashyapefried: Ah-ha, I missed 'stibp' because it was very recently added (21 March), and it isn't present in the HTML rendering15:50
efriedoh, interesting15:50
kashyap[https://qemu.weilnetz.de/doc/qemu-doc.html#important_005fcpu_005ffeatures_005famd_005fx86]15:50
jaypipesefried: what does "AMD x86 hosts" mean w.r.t. Spectre/Meltdown? I thought it was an Intel-only architectural problem that was being exploited?15:50
mriedemmgoddard: i did now, thanks15:50
efriedjaypipes: I haven't a clue. kashyap --^15:50
mgoddardmriedem: np15:50
kashyapjaypipes: Not really; you fell for AMD's marketing :D15:50
kashyapjaypipes: Meltdown is an Intel-only thing15:51
kashyapjaypipes: Spectre affects both AMD _and_ Intel.15:51
*** belmoreira has quit IRC15:52
jaypipeskashyap: I didn't fall for anything... I was just asking a question :)15:52
kashyapjaypipes: Yeah, sorry for the flippant answer.  Hope I answered.  But look at the qemu.weilnetz.de link I posted.15:53
kashyapIt shows all the CVEs that affect AMD hosts, too15:53
jaypipeskashyap: so AMD's CPUs use the same speculative execution "algorithms"?15:53
jaypipesack, I'll read the paper.15:53
jaypipesif I can get through it :)15:53
kashyapjaypipes: Some yes, some not: https://www.amd.com/en/corporate/security-updates15:54
melwittjaypipes: sorry to interrupt... mnaser and I have a change to create request spec, build request, and instance mapping in a single database transaction https://review.opendev.org/586742 and could use your review eyeballs15:54
jaypipesmelwitt: pas de probleme. have a meeting for next 30 mins, will review after that15:56
*** itlinux has joined #openstack-nova15:56
jaypipesmelwitt: and no need to apologize! :)15:56
melwittmerci beaucoup :)15:57
jaypipesde rien15:58
*** tosky has quit IRC16:00
*** helenafm has quit IRC16:00
*** ratailor has quit IRC16:02
*** rpittau is now known as rpittau|afk16:03
*** _erlon_ has joined #openstack-nova16:03
*** efried is now known as efried_rollin16:04
*** wwriverrat has joined #openstack-nova16:06
*** tbachman has joined #openstack-nova16:07
*** altlogbot_0 has quit IRC16:09
mnaserlook at all this french16:09
mnaserD:16:09
mnaser(the nice type of French :p)16:10
sean-k-mooneystephenfin: ill try to review the latest versoin of the cpu spec again16:11
sean-k-mooneydo you have any pending changes or is it fine teo start on v2616:11
*** altlogbot_2 has joined #openstack-nova16:12
gibiefried: This morning I was about to start putting together the commits for the nova onboarding session. But then I found that you already created the DEMO commits (e.g. https://review.opendev.org/#/c/653504/) Is there something I can help with?16:15
*** ivve has joined #openstack-nova16:16
*** ricolin has quit IRC16:20
*** ttsiouts has quit IRC16:21
*** ttsiouts has joined #openstack-nova16:21
*** ccamacho has joined #openstack-nova16:25
*** ttsiouts has quit IRC16:26
*** dtantsur is now known as dtantsur|afk16:29
*** itlinux has quit IRC16:33
*** derekh has quit IRC16:35
*** itlinux has joined #openstack-nova16:37
*** ccamacho has quit IRC16:38
*** altlogbot_2 has quit IRC16:43
*** manjeets_ is now known as manjeets16:43
*** sapd1_x has quit IRC16:43
*** mdbooth_ has quit IRC16:44
*** gyee has joined #openstack-nova16:44
*** itlinux has quit IRC16:44
*** altlogbot_0 has joined #openstack-nova16:44
openstackgerritMerged openstack/nova stable/pike: libvirt: set device address tag only if setting disk unit  https://review.opendev.org/65351416:45
*** igordc has quit IRC16:45
*** itlinux has joined #openstack-nova16:50
mnaserreading scroll back, while it's nice to figure out those flags, I've noticed that different distros will tack in their own cpu flags.16:52
mnaserwhich absolutely drives me f'n insane because it breaks live migration across qemus/operating systems.16:53
*** altlogbot_0 has quit IRC16:53
*** psachin has quit IRC16:53
*** dikonoor has quit IRC16:54
*** altlogbot_1 has joined #openstack-nova16:54
*** itlinux has quit IRC16:56
*** luksky has joined #openstack-nova16:59
aspiersefried_rollin: can your procedural -2 be removed from https://review.opendev.org/#/c/633855/ now that the spec is approved?16:59
artomWho's good with Zuul? sean-k-mooney?17:07
*** KH-Jared has quit IRC17:07
artomI'm trying to figure out why my "new" job (actually just nova-live-migration renamed) has apparently not run at all: https://review.opendev.org/#/c/653498/17:08
artomThere aren't even logs that I can look at :(17:08
sean-k-mooneyill take a look17:10
*** itlinux has joined #openstack-nova17:10
artomAppreciated :)17:10
sean-k-mooneyah because you renamed it but did not add it to the check/gate queue17:10
artom*facepalm*17:11
artomThank you!17:11
sean-k-mooneycomments in https://review.opendev.org/#/c/653498/4/.zuul.yaml17:11
artomYep, found those with a grep nova-live-migration :P17:12
openstackgerritArtom Lifshitz proposed openstack/nova master: Run revert resize tests in nova-live-migration  https://review.opendev.org/65349817:13
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert "Wait for network-vif-plugged on resize revert"  https://review.opendev.org/63939617:13
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert resize: wait for external events in compute manager  https://review.opendev.org/64488117:13
artomAnd now to pick up car from garage (and maybe lunch)17:13
*** KH-Jared has joined #openstack-nova17:13
*** igordc has joined #openstack-nova17:16
sean-k-mooneyefried_rollin: regarding https://blueprints.launchpad.net/nova/+spec/libvirt-video-device-models it was marked as accpeted for train in last weeks meeting but the definiotn was not set to approved17:21
sean-k-mooneyefried_rollin: should it be updated or left at new? i was going to att the patch to the runway list so just checking before i do17:22
*** markvoelker has joined #openstack-nova17:22
*** markvoelker has quit IRC17:26
*** phasespace has joined #openstack-nova17:31
*** hongbin has joined #openstack-nova17:31
*** markvoelker has joined #openstack-nova17:37
*** eharney_ has joined #openstack-nova17:42
*** eharney has quit IRC17:44
*** eharney_ is now known as eharney17:45
mriedemhttps://review.opendev.org/#/c/649345/ should be good to go and fixes a stein regression17:49
*** udesale has quit IRC17:49
mriedemsean-k-mooney: done17:50
sean-k-mooneythanks :)17:50
mriedemoh http://eavesdrop.openstack.org/meetings/nova/2019/nova.2019-04-18-14.00.log.html#l-19717:50
mriedem14:41:14 <efried> If nobody has objections, I'll catch up with kashyap later and approve the bp if he's on board, cool?17:51
mriedemi don't know if that happened17:51
sean-k-mooneyah he had not syncted with kashap maybe17:51
sean-k-mooneywell there is no rush really17:51
sean-k-mooneyby the way for https://review.opendev.org/#/c/649345/17:52
sean-k-mooneyi was going to point out that manages_network_binding_host_id might be a littel confuing in some cases17:53
sean-k-mooneyaltully maybe not i was in the middel of finding out where we do the prot binding on swan for the livrt dirver17:54
sean-k-mooneyif we do it from the compute manager then thats all good17:55
*** ralonsoh has quit IRC18:00
*** sridharg has quit IRC18:09
jaypipesmelwitt, mnaser: still looking into that WSREP not prepared node thing...18:11
sean-k-mooneyWSREP  is a galera thing right18:18
jaypipessean-k-mooney: yeah. though the actual error in this case is a red herring. any old internal error from any old RDBMS could cause this issue.18:24
*** tbachman has quit IRC18:24
melwittnp :)18:25
sean-k-mooney the only time i had had to deal with WSREP errors was when i ran out of diskspeack on one of my contolers18:25
sean-k-mooneythat was... fun to fix18:25
jaypipesmelwitt, mnaser: "The api_context_manager.writer decorators are not nestable." <-- I am almost positive that statement is incorrect. AFAIK, any methods that are decorated by transaction context manager will *enlist* the decorated function's DB calls into an existing transaction (and if there is no existing transaction, one will automatically be created the first time a SQL statement is called (via ORM or core expression API in sqlalchemy)18:26
* jaypipes goes to find the code that show the above...18:26
melwittjaypipes: I thought the same thing so I tried that approach first, and in my func test I found that if the 2nd create() failed, the 1st create() remained in the sqlite database anyway18:27
jaypipesmelwitt: are they using the same RequestContext?18:28
melwittso I changed to the approach that's currently in the patch now18:28
melwittyes18:28
jaypipeshmmm.18:28
jaypipesmelwitt: and both in the same thread of execution, yeah?18:29
jaypipesmelwitt: both create() calls, that is...18:29
melwittit's possible I did something wrong but I'm not sure how. I had originally decorated a function in compute/api with a writer decorator and just put all 3 create() calls in it18:29
melwittyeah18:29
jaypipesmelwitt: interesting.18:30
melwittthe create() methods themselves are not decorated but they call decorated methods inside them. I dunno if that might be why18:30
jaypipesmelwitt: ftr, engineface's transaction context manager *should* only enlist into a single transaction (here is the relevant code, FWIW: https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/enginefacade.py#L1050-L1052)18:30
jaypipesmelwitt: ok, lemme look further into this and see what might be causing this issue.18:30
jaypipesmelwitt: just wanted to make sure that all the calls were actually expected to be in the same RequestContext18:31
jaypipess/to be in the/using the/18:31
melwittjaypipes: ok, thanks. I don't want to take up too much of your time on this18:32
openstackgerritSurya Seetharaman proposed openstack/nova master: Microversion 2.73: Support adding the reason behind a server lock  https://review.opendev.org/64866218:32
jaypipesmelwitt: not a worry, Melanie :)18:32
melwittjaypipes: it's a little complex in that the create() methods will use the object's internal self._context but all the objects self._context are set to the same RequestContext18:33
melwittbut maybe that aspect can cause a break in the decorator nesting-ness? I'm not sure18:33
jaypipesyeah, not entirely sure either :) will dig further.18:34
*** mdbooth has joined #openstack-nova18:41
*** itlinux has quit IRC18:50
*** itlinux has joined #openstack-nova18:52
*** itlinux has quit IRC18:54
openstackgerritSurya Seetharaman proposed openstack/nova master: Microversion 2.73: Support adding the reason behind a server lock  https://review.opendev.org/64866218:56
*** openstackgerrit has quit IRC18:57
*** itlinux has joined #openstack-nova18:58
melwittjaypipes: based on the code you linked, it really should work to nest it so I went back and tried it all again and it looks like it does indeed work properly. I must have messed something up last time, sorry for that :( being able to nest makes the code 1000x better so thank you for pointing it out. I'm going to respin19:07
*** itlinux has quit IRC19:11
melwittjaypipes++19:12
tssuryamriedem: following up on our discussion yesterday regarding filters/sorting I have a doubt here: https://review.opendev.org/#/c/648662/6/nova/api/openstack/compute/schemas/servers.py@544 could you leave a comment when you get time ?19:12
dansmithtssurya: see if I answered your question19:21
melwittturns out what I did wrong was not pass the RequestContext to the decorated outer method. it needs to be passed in for the decorator to start the transaction and then that will get used by the subsequent create() methods19:21
tssuryadansmith: thanks looking19:22
tssuryadansmith: ah you mean do something like 'sort_key': multi_params(VALID_SORT_KEYS_V273) ?,19:23
dansmithtssurya: yeah19:23
tssuryagot it, I'll try to update that patch :) thanks!19:23
*** _erlon_ has quit IRC19:23
*** eharney has quit IRC19:23
*** openstackgerrit has joined #openstack-nova19:25
openstackgerritmelanie witt proposed openstack/nova master: Create request spec, build request and mappings in one transaction  https://review.opendev.org/58674219:25
*** itlinux has joined #openstack-nova19:34
jaypipesmelwitt: no worries, Melanie! :)19:36
*** tssurya has quit IRC19:38
openstackgerritDan Smith proposed openstack/nova master: Add image type capability flags and trait conversions  https://review.opendev.org/65271019:40
openstackgerritDan Smith proposed openstack/nova master: Expose Hyper-V supported image types  https://review.opendev.org/65513719:40
openstackgerritDan Smith proposed openstack/nova master: Make libvirt expose supported image types  https://review.opendev.org/65345419:40
*** JamesBenson has joined #openstack-nova19:41
JamesBensonhey all19:42
JamesBensonI'm getting a nova_compute issue with this error: https://paste.fedoraproject.org/paste/EZYsQ8eDlp9gDjA8BB1YiA/19:42
JamesBensonThis is with a xen hypervisor19:42
*** openstackgerrit has quit IRC19:42
JamesBensonI'm installed os_xenapi with pip19:42
dansmithoh so you're the one!19:46
*** gerrykopec has joined #openstack-nova19:48
JamesBensondansmith???19:51
dansmithJamesBenson: ...guy still using xen :)19:52
JamesBensondansmith, trust me, this is the first time and only because we are getting software that is based off of the xen hypervisor.19:52
JamesBensonneedless to say, I'm finding bugs.19:52
dansmithI'm assuming this is the nova-compute log, but it looks really strange. definitely seems like you're failing to import os_xenapi for some reason that I can't help you with19:53
JamesBensonyes, nova-compute log19:53
dansmiththe db accesses are super strange, but I'd resolve the import issue first in case that is kicking it into some weird state where it's trying to survey the db when it shouldn't19:53
JamesBensonit's coming from kolla-ansible19:53
JamesBensonSo in the docker container, I can open python console and import sucessfully19:53
JamesBensonI did have to tar the dir in site-packages, cp it over and expand... but console did work.19:54
dansmithit's hard to tell from the traces, but I guess it's possible that os_xenapi is trying to access the db on init and that is preventing it from being imported, but that has been disallowed for many years19:55
dansmithso I wouldn't know what to say19:55
*** dave-mccowan has joined #openstack-nova19:56
JamesBensondansmith, are you familiar with kolla?20:01
dansmithnope20:02
JamesBensonIs it possible to check that nova is using openstack's os-xenapi instead of python-os-xenapi?20:09
JamesBensonI've never played with nova code explicitly.20:09
*** efried_rollin is now known as efried20:14
efriedJamesBenson: The nova requirements.txt file lists:20:15
efriedrequirements.txt:os-xenapi>=0.3.3 # Apache-2.020:15
efriedwhich means whatever happens when you say pip install 'os-xenapi>=0.3.3'20:16
efriedaspiers: done, thanks for the reminder.20:16
efriedsean-k-mooney: re libvirt-video-device-models, the action from last week was for kashyap to have a look at it and I would approve it if he was on board.20:18
efriedI know kashyap has been one-armed-wallpaperer busy for the past few days...20:19
*** igordc has quit IRC20:22
*** igordc has joined #openstack-nova20:23
*** igordc has quit IRC20:23
sean-k-mooneyefried: ya that fine20:36
sean-k-mooneyit cna wait until after the ptg20:36
sean-k-mooneyi was going to add it to the runway list but noticed it wasnt approved so held off20:36
sean-k-mooneyi have set a workflow -1 on the nova patch in the inerim20:36
*** pcaruana has quit IRC20:39
JamesBensonefried, so I wonder why it wasn't installed by default20:40
efriedsorry, I wasn't following the conversation, let me read scrollback...20:41
gmannefried:  regarding PT schedule, can we move 'API inconsistency cleanup' L276 on Thursday or friday ? I would not be available on Saturday due to my flight20:41
gmannPTG20:41
efriedgmann: Roger that, will shuffle, thanks for the heads up.20:42
gmannefried: thanks .20:42
JamesBensonefried, sean-k-mooney could you provide insight too, I've seen you in kolla :-)20:42
efriedyou haven't seen *me* in kolla :P20:42
JamesBensonsorry to pick on you explicitly, oh man, sorry efried!20:42
sean-k-mooneyJamesBenson: context?20:43
efried(I have nothing against kolla, just completely ignorant/inexperienced there)20:43
sean-k-mooneyreading back20:43
JamesBensonsean-k-mooney: I'm doing kolla with xen, the nova_compute container is having issues with os_xenapi and six, I had to manually install them, but still vomits on itself.20:43
JamesBensonsean-k-mooney, check out the paste for the error log...20:44
sean-k-mooneyJamesBenson: i honestly did not know kolla-ansible supproted xen i always used it with kvm20:45
JamesBensonlikewise, until we got software that needs a xenblanket...20:45
sean-k-mooneyi would gues in addtion to installing xen you might need to run some db migrations20:46
sean-k-mooneyoh xen server is supported now https://github.com/openstack/kolla-ansible/blob/23415bf8bb8179a966d1c10bd46e6cb9045f2b5d/doc/source/reference/compute/xenserver-guide.rst20:47
JamesBensondoing this little experiment, I'm finding bugs in several different openstack processes... :-(20:47
JamesBensonyeah20:47
sean-k-mooneywhat version of python are you using20:47
sean-k-mooneyi assume python 220:48
JamesBensonthis is version 2 still20:48
sean-k-mooneyya it 2.7 from the logs cool20:48
sean-k-mooneyso this is in the cells scater gather code20:49
sean-k-mooneywe indocuded explcitly use fo eventlets there20:49
JamesBenson?20:49
sean-k-mooneyin stien we intoduced a parallel cell list feature20:50
JamesBensonyes, I think it was failing at the cells spot in ansible20:50
JamesBensonI'm deploying using 7.0.120:50
sean-k-mooneyit was implemented using eventlets expclitly but that means in stien you need to monkey patch the nova api now20:50
sean-k-mooneybut some people have been having issue with monkey patched nova api under uwsigi also20:51
sean-k-mooneydo you know how this is run in in kolla20:51
JamesBensonhonestly, starting to get to the limits of my knowledge here now.20:52
*** eharney has joined #openstack-nova20:52
sean-k-mooneyim checking the kolla repos to see20:52
JamesBensonI do know this needs to get fixed in kolla-ansible: https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/nova/tasks/bootstrap_xenapi.yml#L3 and L4,20:54
efriedmriedem: pike-em good to go at this point?20:54
sean-k-mooneyJamesBenson: the command is nova-api so i think it running under pythons built in web server with haproxy in front20:55
sean-k-mooneyat least based on https://github.com/openstack/kolla-ansible/blob/7.0.1/ansible/roles/nova/templates/nova-api.json.j2#L220:56
sean-k-mooneyJamesBenson: what people were seeing was under uwsgi instead of mod_wsig the nova-api was not sending/reciving heartbeats to rabbitmq and teh connect to amqp was dropping20:58
sean-k-mooneyalthough im not sure that is related to your issue20:58
sean-k-mooneyJamesBenson: how did you install os_xenapi21:00
sean-k-mooneydid you rebuild the images using the template overide file21:00
JamesBensonit was a multistep process.... but tar'ed the package locally from python2.7/site-packages, docker cp, untar... I issued the commands using docker exec -u 021:01
sean-k-mooneyoh there is a standard way to extend kolla images21:02
JamesBensonI verified inside the container by logging into it, running python, and importing the packages without issue21:02
JamesBensonyeah, I didn't want to rebuild the images as I was sure there would be more issues.21:02
sean-k-mooneyhttps://github.com/openstack/kolla/blob/master/doc/source/admin/image-building.rst#generic-customisation21:02
sean-k-mooneydid you pull the image form the docker hub21:03
JamesBensonyes21:03
sean-k-mooneyok21:03
sean-k-mooneylet me check something21:03
JamesBensonso I'm good at debugging but don't do some processes often enough to remember how to do it, like submitted a bug, but now submitting the bug fix :-/. lol, downfall of academia and not industry, it's not a tool we use all too often.21:04
JamesBensonI know :how: to fix it, just submitting it...21:04
sean-k-mooneywell i was going to check if they had a configuration option in the kolla build config to enable building with xen then compare that to the build setting used in the gate to publish the image21:05
sean-k-mooneybut no no buil option that i can see in the config21:06
sean-k-mooneyand just checking you rna the xen_bootsrap command21:07
JamesBensonyes had issues, but seemed to build the facts.json: https://da.gd/E0FIl21:08
JamesBensonand I can literally submit about 3 patches to fix the issues I had with xen, if I can bug you about the process privately.21:09
*** ttsiouts has joined #openstack-nova21:09
*** arshad777 has quit IRC21:10
sean-k-mooneywell i havent working on kolla in about 18 months but if i can help sure21:10
sean-k-mooneywel proably should also bring this to the openstack-kolla channel21:10
JamesBensonbecause there are bugs in kolla-ansible, openstack os-xenapi, and what ever the issue is here or kolla with not installing the packages correctly in the docker container.21:11
sean-k-mooneyim just loggin off for the night but feel free to ping me tommorow21:11
sean-k-mooneyor ping me while im away and ill respond tomorow21:12
JamesBensonLets talk tomorrow, I'm logging off soon too21:12
sean-k-mooneycool my irc client is connected to #openstack-kolla also so feel free to ping me there so we dont distub the nova folks for the packaging side21:13
sean-k-mooneythe nova issue we can prably debug more here21:13
sean-k-mooneyis it repoducable?21:13
JamesBensonmost likely.21:13
sean-k-mooneyonly with xen or do you think i would hit it with libvir kvm too21:14
sean-k-mooneythis does not look realted to xen to be honest21:14
sean-k-mooneywell the db issues dont21:14
sean-k-mooneythere are some other issue with the xenapi too at the end21:15
mriedemefried: yeah i've had the patch up since earlier today21:15
JamesBensonI'm not sure where it exactly crosses over, but I know definitely those two packages have issues, kolla-ansible and os-xenapi.  Nova will need to dig deeper into to see where it breaks.21:16
JamesBensonBut I've never dug into nova this deep.21:16
*** itlinux has quit IRC21:16
sean-k-mooneywell there seams to be 2 basic erros in the nova log21:18
sean-k-mooneyDBNotAllowed: nova-compute21:18
sean-k-mooneyand then the xen api one21:18
JamesBensonagreed21:18
JamesBensonIs it possible that kolla mucked up the install of that package?21:19
*** ttsiouts has quit IRC21:19
JamesBensonBut I thought that was pulled from the nova repo.21:19
JamesBenson?21:19
sean-k-mooneywell its posibel that the xen dirver need other config option to be set that kolla is nto setting in the nova.conf21:20
sean-k-mooneythe default for the databse are set here https://github.com/openstack/kolla-ansible/blob/2dd69e9140b1ce1bd248c5c09217fb3a6502a9fc/ansible/roles/nova/defaults/main.yml#L161-L167 and used to generate teh config nova.conf here https://github.com/openstack/kolla-ansible/blob/2dd69e9140b1ce1bd248c5c09217fb3a6502a9fc/ansible/roles/nova/templates/nova.conf.j2#L156-L16421:22
sean-k-mooneythat code should be virt dirver independent21:23
*** itlinux has joined #openstack-nova21:23
mriedemmelwitt: heh yeah that PS4 on the transactional create patch is about a billion times cleaner21:23
*** itlinux has quit IRC21:24
*** whoami-rajat has quit IRC21:25
mriedemefried: https://review.opendev.org/#/c/652868/21:25
*** itlinux has joined #openstack-nova21:28
*** openstackgerrit has joined #openstack-nova21:30
openstackgerritDustin Cowles proposed openstack/nova master: WIP/PoC: Use SDK instead of ironicclient for node.get  https://review.opendev.org/64289921:30
efriedmriedem: Right, just wanted to make sure that was the final21:32
efriedmriedem: and presumably the one on top fails tests until the bottom one merges and the tag is created.21:32
jaypipesdansmith, mriedem: is it possible to update metadata on a server that failed to boot properly? (i.e. the instance went to cell0)21:36
dansmithjaypipes: metadata? like user metadata?21:36
mriedemefried: i'm trying to figure out why the one on top is failing21:37
jaypipesdansmith: no, sorry, metadata was a bad term. any attribute of the instance... say, it's name.21:37
efriedmriedem: It's because the tags aren't created yet21:37
efriedmriedem: I guess the job isn't smart enough to infer them from the releases in the predecessor patch.21:37
dansmithjaypipes: shouldn't really be anything cell0 specific I don't think.. if you can do it in error, then you can do it21:37
dansmithjaypipes: anything that requires talking to the host the instance is on won't work, of course21:38
mriedemjaypipes: like dansmith says it depends on the API and what it restricts,21:39
mriedembut i don't see any vm_state restrictions on the server update API21:39
dansmithand what I meant was, there could be vm_state restrictions, but none that are specific to cell0 that I know of,21:39
dansmithexcept something that ends up with an rpc call21:39
jaypipesdansmith, mriedem: this is some custom Yahoo! API plugin ... it grabs the Instance object, updates some custom attribute on it and then calls instance.save(). Unfortunately, that isn't working in a cellsv2 environment...21:39
mriedeminterestingly there are restrictions on updating things like metadata and tags21:39
mriedemjaypipes: likely b/c it's not targeted to the cell0 db21:40
dansmithjaypipes: should be fine, just .. yeah, make sure it's targeted,21:40
mriedemit's not cells-aware21:40
jaypipesyeahg21:40
jaypipesjuno code.21:40
jaypipesbeing converted to ocata. ugh.21:40
dansmithjuno we don't give a shit, right?21:40
mriedemif it were smart and used the common.get_instance method, the Instance._context would already be targeted21:40
jaypipesocata.21:41
jaypipesnone of this is "smart" :)21:41
dansmithJU .. NO21:41
*** itlinux has quit IRC21:41
mriedemcan i count verizon media group as a fallback employer to fix these old forks in case i get canned?21:41
dansmithcan anyone count on verizon media group as an employer?21:41
dansmithbah dum dum21:41
*** tbachman has joined #openstack-nova21:45
*** slaweq has quit IRC21:47
mriedemugh https://github.com/openstack/nova/blob/a991980863f056323c1ee9fd6a46dbc4cb899eca/nova/availability_zones.py#L12521:47
mriedemhttps://github.com/openstack/nova/blob/a991980863f056323c1ee9fd6a46dbc4cb899eca/nova/compute/api.py#L497221:48
mriedembadum https://review.opendev.org/#/c/649197/21:48
*** slaweq has joined #openstack-nova21:48
*** itlinux has joined #openstack-nova21:49
*** igordc has joined #openstack-nova21:53
*** nicolasbock has quit IRC21:55
*** JamesBenson has quit IRC21:59
*** imacdonn has quit IRC22:01
*** imacdonn has joined #openstack-nova22:02
efriedgmann: Thursday 1200-1230 okay for API inconsistency cleanup?22:03
*** itlinux has quit IRC22:03
gmannefried: yeah, prefect.22:03
efriedgmann: d'oh, I meant Friday 1200-123022:04
gmannefried: ok, friday also fine at 12.22:05
efriedgmann: thanks22:05
*** s1061123 has quit IRC22:05
*** s1061123 has joined #openstack-nova22:05
efrieddustinc: I've got the sdk topic scheduled for Thursday 1415-1430. mordred plans to be there for it too.22:09
*** itlinux has joined #openstack-nova22:09
jaypipesdansmith, mriedem: cells(v2) is a requirement in ocata, no? meaning, there's no "turning off" or not using cellsv2, yeah?22:09
jaypipesdansmith, mriedem: that's what the nova-manage map_instances call enables I thought?22:11
mriedemcells v2 is required since ocata yeah22:12
openstackgerritMatt Riedemann proposed openstack/nova master: AZ list performance optimization: avoid double service list DB fetch  https://review.opendev.org/63694722:12
mriedemefried: i think i got the test leak plugged ^ and actually found another slight perf improvement in the process22:13
efriednice22:13
mriedemturns out globally mocking the DB API is not a great idea!22:13
*** mlavalle has quit IRC22:13
efriedwho woulda thunk22:13
melwittmriedem: yeah, jaypipes saved the day :D22:14
*** itlinux has quit IRC22:15
mriedemso the spandex and cape aren't unusual22:15
*** gibi has quit IRC22:15
jaypipesnobody needs to see me in spandex. eww.22:15
melwittnot even the pugs22:15
jaypipeswell, sure, Winnie in a cape would be cool.22:17
melwittpugs in spandex, smooth out the rolls22:17
jaypipesshe's already got the Rosie the Pugeter iron-on decal on her Brownies jersey.22:18
melwitthells yeah22:18
melwitthm, somehow the unit tests get caught up in the database poison fixture when I back out the change22:21
jaypipesthat girl is poison.22:21
melwittthat's a blast from the past22:22
jaypipesthat's right... whipped out some Bell Biv there.22:22
jaypipesjeebus I'm old.22:22
* jaypipes goes back to applying arthritis medicine22:22
*** gibi has joined #openstack-nova22:23
melwittoh, it's just because of the database context manager decorator on the helper method, that triggers the POISON22:23
melwittarthritis--22:23
*** slaweq has quit IRC22:24
*** itlinux has joined #openstack-nova22:25
efriedaspiers: are you around through Saturday at the PTG?22:29
aspiersyup22:29
*** luksky has quit IRC22:31
efriedaspiers: Friday 1615-beer good for you?22:32
aspiers$day $time beer is good for me22:33
aspiersthat particular tuple is no exception :)22:33
efriedsorry, what I mean is, Friday 1615 until it's time to go get beer.22:33
efriedI'm not saying you get beer at 161522:34
aspiersawww22:34
efriedyou can bring your own, I won't stop you.22:34
aspiersraise up my hopes then cruelly dash them, why don't you22:34
aspiersbut sure :)22:34
efriedI'm cruelly dashing that way22:34
aspiersI guess 1615 is kinda early to start ;-)22:34
efriedit'll be 2315 in your time zone22:34
aspierstrue22:35
efriedpubs already closed22:35
efried(do they still close at 11? It was so when I was growing up)22:35
aspiersIt varies22:35
aspiersYou used to live here?22:35
aspiersor just remember the tourist pub run22:35
efriedI used to live in Buckinghamshire22:36
aspiersno way22:36
aspiersfor how long?22:36
efried1984-7 and 89-9422:36
aspiersthat's a decent length of time22:37
efriedMost of my formative years, I would say.22:37
aspierswhereabouts?22:37
efriedGerrard's Cross and Beaconsfield, respectively.22:37
aspiersfunny old world22:37
aspierswhere are you now?22:37
efriedyou know Bucks?22:37
efriedCentral Texas, Austin area22:37
aspiersnot really, but I know of both those places22:38
aspiersmost notably, Dominic Grieve represents the latter in Parliament IIRC22:38
aspiersthat's quite a change22:38
efriedheh, never paid any attention to the politics. Still don't.22:38
aspiersI like Austin, don't know the surrounding area22:38
efriedI used to like Austin22:38
aspiershaha22:39
efriedNow it's overrun with hipster douchebags22:39
efriedand getting too snobby for its britches22:39
aspiers:)22:39
aspiershappens to all the best places22:39
*** slaweq has joined #openstack-nova22:40
efriedif you like it they will come22:41
efriedcase in point, the Trocadero22:41
efriedCarnaby Street22:41
efriedCamden Town22:42
aspiers:)22:42
aspiersit's a bit like the Ballmer Peak22:43
aspiersplaces are shit for ages, then suddenly get cool, then everyone realises and floods the trendy cool place and ruins it again22:44
efriedaspiers, mriedem, gibi: I swapped both the traits filter topics with the bandwidth continuation. So now we have22:45
efriedThursday 1330-1415: Let's plan the next steps of the bandwidth support feature (gibi)22:45
efriedFriday22:45
efried1615-1630: Compute capabilities traits placement request filter (mriedem)22:45
efried1630-beer: Disabled compute service request filter (mriedem)22:45
efriedum, jaypipes, did you want to be around for the latter?22:45
aspiersawesome thanks22:45
mriedemefried: ok, although i didn't think the bw spec was that controversial22:49
mriedemjust needs to be updated22:49
efriedmriedem: Sorry, lack of context, I just realized that aspiers responded to me and not the list - he wanted to be around for the traits filter topics (which also increases our chances of convincing him to own them :) but is unavailable Thursday.22:50
efriedmriedem, gibi: And definitely if we don't need as much (or any) time to talk about the bandwidth stuff, let me know so I can shuffle some more stuff in.22:51
efriedmriedem: I got the impression that gibi wanted to have a kind of live design session for some of the issues.22:52
mriedemi'll let gibi answer that, i think the biggest hangups in the bw migration spec was (1) do we use a microversion (sounds like yeah probably) and (2) upgrade issues which i think he understands now22:52
*** slaweq has quit IRC22:53
*** tkajinam has joined #openstack-nova22:53
*** rcernin has joined #openstack-nova22:54
efriedneat, I'll fup with gibi22:55
mriedemdansmith: re https://review.opendev.org/#/c/649197/2/nova/compute/rpcapi.py@381 i think that's as easy as just resetting the compute.rpcapi._ROUTER global on ComputeManager.reset() or am i missing some nasty detail?22:56
dansmithmriedem: nope, I think that'll do it22:57
mriedemwhat do you think about just throwing reset_globals() from https://review.opendev.org/#/c/649197/2/nova/tests/unit/compute/test_rpcapi.py@37 into the rpcapi module itself? then i can hit it from multiple locations22:57
dansmithsec, phone23:01
openstackgerritMatt Riedemann proposed openstack/nova master: Always pass HostAPI to get_availability_zones  https://review.opendev.org/65558323:03
mriedemheh "Problme: Even though splited, still long and boring. Need fully review."23:04
mriedemL224 in the ptg etherpad23:04
mriedemefried: L223 is likely not something we really need for the ptg https://etherpad.openstack.org/p/nova-ptg-train it's just a request for review23:06
mriedemwhich i've done once before, just - it's a lot of code and i forgot about it23:06
eanderssonWhat is this fun error23:07
eandersson> ValueError: unmatched '{' in format23:07
eanderssonWhen running cell mapping23:07
efriedmriedem: ack23:07
mriedemare you using templates for the transport_url or db connection?23:07
eanderssonno template23:07
eanderssonmy best guess is a special char in the password is causing some fun bug23:08
mriedemdo you have a stacktrace you can paste?23:08
efriedmriedem: a little background, I've scheduled that there because of the stx association, and dtroyer will still be in the room. If we don't need to discuss it, we can take a coffee break at that time :)23:08
mriedemmaybe23:08
mriedemi suppose you don't want to paste the trace b/c of said password...23:08
mriedemefried: ok, whatever, i think it's just a request for review23:09
efriedack23:09
mriedemmelwitt and i have both reviewed it before23:09
efriedwell cool, if y'all merge it before the PTG I'll definitely strike it :)23:10
mriedemit's like 800 LOC though23:10
mriedemheh23:10
efriedand in merge conflict23:10
mriedemif it were a blueprint (which it arguably could be) then it could sit in a runway23:10
mriedemthe bottom patch isn't23:10
ccstone(I'm also working with eandersson) He already gave away the special character which is { :)23:10
mriedemthen the reviews would floweth like fine wine23:10
efriedsure they would23:11
*** slaweq has joined #openstack-nova23:11
efriedlemme see what a rebase would look like.23:11
mriedemccstone: which release of rocky?23:12
mriedemlatest patch?23:12
mriedem18.2.0?23:12
*** mvkr has quit IRC23:12
mriedemi was thinking maybe https://review.opendev.org/#/c/633086/ but that might not hit you if you're not using templated urls23:12
mriedemccstone: can you provide a bug or trace without the password in it? i don't know which command is being referenced23:14
ccstoneYeah, we're on 18.2.0, looks like we do have that patch.23:14
*** cooper6581 has joined #openstack-nova23:15
eanderssonhttp://paste.openstack.org/show/749729/23:15
openstackgerritEric Fried proposed openstack/nova master: Clean up orphan instances virt driver  https://review.opendev.org/64891223:16
openstackgerritEric Fried proposed openstack/nova master: Clean up orphan instances  https://review.opendev.org/62776523:16
efriedmriedem, melwitt: fyi, rebase was easy ^23:16
*** gibi has quit IRC23:18
mriedemeandersson: ccstone: please report a bug, i want to say we talked about special characters in passwords when adding that code and there were some assertions made, but i can't remember now, would definitely want dansmith to look23:18
mriedembut he's busy23:18
dansmithmriedem: sure, that seems okay I think (re reset_globals)23:20
mriedemeandersson: ccstone: looks like we'll catch and trace that ValueError but things don't fail right? we return the URL as-is23:21
dansmithmriedem: eandersson ccstone: passwords should be url-encoded23:21
ccstonemriedem: Will do, thanks! Our immediate fix was to change the rabbit password, but we're still getting the error, I assume because something has already put the transport_url in the database. Is there a nova-manage command to update that?23:21
mriedemccstone: nova-manage cell_v2 update_cell https://docs.openstack.org/nova/rocky/cli/nova-manage.html#nova-cells-v223:22
dansmithI do remember something about one place where we couldn't urlencode it ourselves for you but I forget why23:22
dansmithbut it was non-trivial silliness23:22
eanderssonYea - we didn't realize that it wasn't reading it from the config.23:22
eandersson(anymore at least)23:22
ccstoneI think the issue was that it wasn't URL encoded when we ran simple_cell_setup (also we did that step on Newton code)23:22
ccstoneOr part of that issue at least23:22
mriedemfwiw i remember f'ing around with this several times https://github.com/openstack/nova/blob/a991980863f056323c1ee9fd6a46dbc4cb899eca/nova/cmd/manage.py#L100623:23
mriedemfor formatting the db url23:23
mriedemusing sqlalchemy utilities23:23
*** mchlumsky has quit IRC23:23
*** slaweq has quit IRC23:25
*** JamesBenson has joined #openstack-nova23:27
*** gibi has joined #openstack-nova23:31
*** cooper6581 has quit IRC23:31
*** JamesBenson has quit IRC23:31
*** itlinux has quit IRC23:33
*** itlinux has joined #openstack-nova23:37
*** hongbin has quit IRC23:48
*** itlinux has quit IRC23:50

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!