*** mriedem has quit IRC | 00:04 | |
*** wwriverrat has quit IRC | 00:17 | |
*** wwriverrat has joined #openstack-nova | 00:17 | |
*** betherly has joined #openstack-nova | 00:41 | |
*** betherly has quit IRC | 00:46 | |
*** _alastor_ has quit IRC | 00:55 | |
*** betherly has joined #openstack-nova | 01:03 | |
*** wwriverrat has quit IRC | 01:04 | |
*** betherly has quit IRC | 01:08 | |
*** jiaopengju_1 has joined #openstack-nova | 01:10 | |
*** jiaopengju_2 has quit IRC | 01:13 | |
*** betherly has joined #openstack-nova | 01:24 | |
*** tssurya has quit IRC | 01:27 | |
*** gmann has quit IRC | 01:28 | |
*** betherly has quit IRC | 01:29 | |
*** lbragstad has quit IRC | 01:35 | |
*** bauzas has quit IRC | 01:36 | |
*** bauzas has joined #openstack-nova | 01:38 | |
*** jiaopengju_2 has joined #openstack-nova | 02:02 | |
*** jiaopengju_1 has quit IRC | 02:05 | |
*** sapd1_x has joined #openstack-nova | 02:06 | |
*** betherly has joined #openstack-nova | 02:07 | |
*** awalende has joined #openstack-nova | 02:09 | |
*** vdrok has quit IRC | 02:09 | |
*** vdrok has joined #openstack-nova | 02:11 | |
*** brinzhang has joined #openstack-nova | 02:11 | |
*** betherly has quit IRC | 02:11 | |
*** awalende has quit IRC | 02:13 | |
openstackgerrit | Merged openstack/nova master: libvirt: Always disconnect volumes after libvirtError exceptions https://review.opendev.org/655712 | 02:22 |
---|---|---|
*** whoami-rajat has quit IRC | 02:28 | |
*** betherly has joined #openstack-nova | 02:38 | |
*** betherly has quit IRC | 02:43 | |
openstackgerrit | Merged openstack/nova master: Add nova-status upgrade check for minimum required cinder API version https://review.opendev.org/649759 | 03:05 |
*** betherly has joined #openstack-nova | 03:10 | |
*** betherly has quit IRC | 03:14 | |
*** hongbin has quit IRC | 03:20 | |
*** jiaopengju_2 has quit IRC | 03:27 | |
*** JamesBenson has joined #openstack-nova | 03:48 | |
*** gmann has joined #openstack-nova | 04:13 | |
*** JamesBenson has quit IRC | 04:28 | |
*** pcaruana has joined #openstack-nova | 04:53 | |
*** dakshina-ilangov has joined #openstack-nova | 05:07 | |
*** hemna has joined #openstack-nova | 05:53 | |
*** hemna has quit IRC | 05:58 | |
*** _alastor_ has joined #openstack-nova | 06:09 | |
*** JamesBenson has joined #openstack-nova | 06:29 | |
*** JamesBenson has quit IRC | 06:33 | |
*** _alastor_ has quit IRC | 06:42 | |
*** hemna has joined #openstack-nova | 07:11 | |
*** hemna has quit IRC | 07:16 | |
*** dakshina-ilangov has quit IRC | 07:26 | |
*** gmann has quit IRC | 08:02 | |
*** awalende has joined #openstack-nova | 08:09 | |
*** awalende has quit IRC | 08:14 | |
*** igordc has quit IRC | 09:00 | |
openstackgerrit | Merged openstack/nova master: Delete the placement code https://review.opendev.org/618215 | 09:16 |
*** whoami-rajat has joined #openstack-nova | 09:58 | |
*** brinzhang has quit IRC | 10:49 | |
*** gmann has joined #openstack-nova | 12:05 | |
*** awalende has joined #openstack-nova | 12:09 | |
*** KH-Jared has quit IRC | 12:10 | |
*** awalende has quit IRC | 12:13 | |
lyarwood | \o/ | 12:14 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: libvirt: Always disconnect volumes after libvirtError exceptions https://review.opendev.org/657109 | 12:23 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Always disconnect volumes after libvirtError exceptions https://review.opendev.org/657110 | 12:23 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: Always disconnect volumes after libvirtError exceptions https://review.opendev.org/657111 | 12:24 |
*** ccamacho has quit IRC | 12:30 | |
*** sean-k-mooney has joined #openstack-nova | 12:41 | |
*** awalende has joined #openstack-nova | 12:44 | |
*** awalende has quit IRC | 12:48 | |
openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: add nfv job https://review.opendev.org/652197 | 12:58 |
openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: add nfv job https://review.opendev.org/652197 | 13:21 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656 | 13:39 |
*** slaweq has joined #openstack-nova | 13:44 | |
*** cfriesen has joined #openstack-nova | 14:05 | |
*** efried has joined #openstack-nova | 14:10 | |
*** altlogbot_2 has quit IRC | 14:10 | |
*** jaypipes has left #openstack-nova | 14:10 | |
*** jaypipes has quit IRC | 14:10 | |
*** altlogbot_1 has joined #openstack-nova | 14:11 | |
*** ricolin has joined #openstack-nova | 14:14 | |
*** slaweq has quit IRC | 14:21 | |
*** cfriesen has quit IRC | 14:26 | |
*** _alastor_ has joined #openstack-nova | 14:29 | |
*** sean-k-mooney has quit IRC | 14:29 | |
*** slaweq has joined #openstack-nova | 14:32 | |
*** mriedem has joined #openstack-nova | 14:32 | |
*** gmann has quit IRC | 14:34 | |
*** artom has joined #openstack-nova | 14:42 | |
*** artom has quit IRC | 14:50 | |
*** cdent has joined #openstack-nova | 14:54 | |
*** sean-k-mooney has joined #openstack-nova | 14:54 | |
*** artom has joined #openstack-nova | 14:55 | |
*** wwriverrat has joined #openstack-nova | 14:57 | |
mriedem | rm_work: do you happen to know if oath needed to disable versioned notifications because of load on the MQ? | 14:58 |
*** ricolin has quit IRC | 14:58 | |
*** ricolin has joined #openstack-nova | 14:59 | |
*** lbragstad has joined #openstack-nova | 14:59 | |
*** _alastor_ has quit IRC | 15:02 | |
rm_work | mriedem: Not positive but I can track down an answer for you easily enough ;) | 15:02 |
*** takashin has joined #openstack-nova | 15:02 | |
*** cfriesen has joined #openstack-nova | 15:03 | |
*** jangutter has joined #openstack-nova | 15:04 | |
efried | cfriesen: I put a comment on the TPM patch, if you could take a look please. Unless I'm way off, may require a slight design change... | 15:07 |
mriedem | thanks, wasn't sure who to ask | 15:07 |
*** lbragstad has quit IRC | 15:08 | |
cfriesen | efried: will take a look, thanks | 15:08 |
*** mlavalle has joined #openstack-nova | 15:10 | |
*** wwriverrat has quit IRC | 15:11 | |
*** ricolin has quit IRC | 15:13 | |
lyarwood | stephenfin: https://review.rdoproject.org/r/#/c/16234/ - now that placement has gone. | 15:16 |
*** abhishekk has joined #openstack-nova | 15:16 | |
*** bnemec has quit IRC | 15:17 | |
lyarwood | stephenfin: cheers | 15:18 |
stephenfin | lyarwood: Done | 15:18 |
efried | http://paste.openstack.org/raw/750586/ \o/ | 15:18 |
*** _alastor_ has joined #openstack-nova | 15:20 | |
openstackgerrit | Merged openstack/nova stable/stein: libvirt: Stop ignoring unknown libvirtError exceptions during volume attach https://review.opendev.org/657049 | 15:20 |
*** itlinux has quit IRC | 15:21 | |
*** ricolin has joined #openstack-nova | 15:23 | |
stephenfin | efried: Only three patches standing between us and https://review.opendev.org/#/c/651306/8 too :) | 15:24 |
stephenfin | Also, CI /o\ | 15:24 |
cdent | efried and or mriedem : if you could register an opinion on whether I should do the same changes to all the functional jobs as https://review.opendev.org/#/c/657074/ that would be keen. No rush, simply that it is in flight. | 15:24 |
efried | stephenfin: yeah, I need to get back to that series (and a zillion others) | 15:25 |
cdent | moar delegation | 15:25 |
stephenfin | ack. It'll be back in a runway in a few weeks too | 15:25 |
efried | stephenfin: We've also got mox, privsep, and fake-libvirt cleanups which ought to be pretty much ready to go. | 15:25 |
stephenfin | efried: Aye, though privsep is blocked by some comments from you that mikal hasn't address yet. I've been tackling the libvirt version enum cleanup ones from mriedem/kashyap already | 15:26 |
efried | oh, is that where I left privsep? cool | 15:27 |
efried | :) | 15:27 |
*** bnemec has joined #openstack-nova | 15:27 | |
*** ricolin has quit IRC | 15:27 | |
efried | looks like there are two I could push | 15:27 |
cfriesen | efried: is the TPM version actually an issue? given that it's emulated, all hosts can provide both TPM versions. if the guest doesn't care, they can just ask for version 1.2 | 15:30 |
*** ricolin has joined #openstack-nova | 15:32 | |
openstackgerrit | Merged openstack/nova stable/stein: libvirt: Avoid using os-brick encryptors when device_path isn't provided https://review.opendev.org/656462 | 15:35 |
*** ricolin has quit IRC | 15:36 | |
rm_work | mriedem: seems that we just never enabled notifications to begin with? ¯\_(ツ)_/¯ | 15:40 |
rm_work | where can I go look in our deployment tooling/config to see? :D | 15:40 |
rm_work | what config option is it? | 15:41 |
mriedem | rm_work: https://docs.openstack.org/nova/latest/configuration/config.html#notifications | 15:41 |
mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#notifications.notification_format specifically is what i'm looking for | 15:41 |
efried | cfriesen: Well, that's what I was asking you, I guess. | 15:42 |
mriedem | also this https://docs.openstack.org/nova/latest/configuration/config.html#oslo-messaging-notifications | 15:42 |
efried | cfriesen: Is it not the case that 2.0 is only available (emulatable) at certain versions of... things (qemu, libvirt, ...)? | 15:42 |
mriedem | rm_work: notifications are enabled by default so maybe you're just generating them but not consuming them. to disable them, [oslo_messaging_notifications]/driver=noop | 15:43 |
efried | cfriesen: Basically: is the model the thing the user primarily cares about, or is the version? | 15:43 |
rm_work | ok, yeah i think that's likely | 15:44 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Include all network devices in nova diagnostics https://review.opendev.org/657125 | 15:44 |
cfriesen | efried: the version of libvirt that introduced TPM support adds support for both, and the TPM emulator supports both, so they should always be available. I want to double-check with sean-k-mooney and kashyap but I think the initial concern would be the version as the two versions are quite different. | 15:46 |
efried | cfriesen: Oh, so the implementation (which I haven't gotten to yet, sorry) is using the version trait to effect the proper emulated version? | 15:48 |
efried | I guess if both versions are available, it would have to. | 15:48 |
cfriesen | efried: yeah, the virt driver uses the version trait when generating the libvirt XML | 15:50 |
*** IvensZambrano has joined #openstack-nova | 15:51 | |
efried | cfriesen: Okay. This was probably already discussed during design and I'm just late to the party. If hosts are advertising both versions, and users care about the version (are in fact locked to just one) then the current design is fine. | 15:51 |
mriedem | smcginnis: can you stop in the nova room to talk about openlab for 5 minutes? | 15:52 |
smcginnis | mriedem: Sure. Right now? | 15:52 |
mriedem | if possible yeah | 15:52 |
mriedem | 207 | 15:52 |
smcginnis | OMW | 15:52 |
rm_work | mriedem: seems we leave the default | 15:53 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove ComputeDriver.macs_for_instance method https://review.opendev.org/652737 | 15:53 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove macs kwarg from allocate_for_instance https://review.opendev.org/652749 | 15:53 |
mriedem | rm_work: ok thanks | 15:54 |
mriedem | sean-k-mooney: fyi several things are marked as experimental here https://docs.openstack.org/nova/latest/user/feature-classification.html#nfv-cloud-features | 15:55 |
mriedem | https://docs.openstack.org/nova/latest/user/feature-classification.html#matrix-hpc | 15:55 |
mriedem | https://docs.openstack.org/nova/latest/admin/huge-pages.html doesn't mention anything about being experimental or not tested | 15:55 |
*** sapd1_x has quit IRC | 15:57 | |
cfriesen | efried: A guest could have support for both versions, but unless they're specifically wanting 2.0 functionality then 1.2 should be fine. You raised another issue though, moving operators away from speaking placement-ese in flavors/images. Was that still an issue? This was loosely modelled after the CPU features traits which are explicitly placement-ese. | 15:59 |
*** jbernard has quit IRC | 16:00 | |
*** jbernard_ has joined #openstack-nova | 16:00 | |
*** shuquan has joined #openstack-nova | 16:01 | |
efried | cfriesen: It's not crucial to me that there be zero placement-ese in flavors. For simple things like this (requiring a single trait) it's fine, and is why we enabled support for it. It's complex placement-ese I want to avoid, instead having nova translate more operator-ese thingies to placement-ese. | 16:02 |
*** dtroyer has joined #openstack-nova | 16:02 | |
cfriesen | efried: makes sense. I'll reply to your review comment with a summary for others who look at it. | 16:03 |
efried | cfriesen: Thank you sir. | 16:04 |
efried | cfriesen: Wait, "A guest could have support for both versions, but unless they're specifically wanting 2.0 functionality then 1.2 should be fine." <== so it's possible I only care about "give me TIS"? | 16:05 |
efried | If that's the case, I'd still be in favor of making the trait optional (and set up by the request filter) | 16:06 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP/DNM objects: Remove get_by_volume_id from BlockDeviceMapping https://review.opendev.org/657127 | 16:06 |
cfriesen | efried: I think the guest support is different for TIS-on-1.2 vs TIS-on-2.0, but let me confirm with sean/kashyap | 16:07 |
*** ccamacho has joined #openstack-nova | 16:07 | |
efried | cfriesen: Okay. None of this should be a huge delta in the impl/spec IIUC. If it turns out to be, I can live with it as is. | 16:08 |
kashyap | cfriesen: Hi, what exactly you want to double-check? You said "support for both" up-thread -- what are you referring to? | 16:08 |
* kashyap just signed into IRC; so still catching up w/ the scroll | 16:08 | |
efried | kashyap: We're talking about the use cases for TPM. What is it that the operator cares about? | 16:08 |
efried | kashyap: Is "Give me TIS, I don't care if it's 1.2 or 2.0" a possibility? | 16:08 |
*** amodi has joined #openstack-nova | 16:08 | |
cfriesen | or do they care primarily about 1.2 vs 2.0, and then crb/tis if they're on 2.0 | 16:09 |
cfriesen | (the spec was written assuming the second) | 16:09 |
kashyap | efried: I don't know the answer to your second question -- need to go do some QEMU sluething for it | 16:09 |
*** lbragstad has joined #openstack-nova | 16:10 | |
kashyap | efried: The use cases for TPM, my limited understanding is that: they are a "big deal" recently: | 16:11 |
kashyap | efried: The idea is that you have a tiny co-processor that can do crypto, but with company-specified policies. | 16:11 |
cfriesen | kashyap: we can talk to sean-k-mooney, he doesn't seem to be paying attention to IRC. :) | 16:12 |
*** gmann has joined #openstack-nova | 16:12 | |
efried | he's paying attention to the room, like I should be :P | 16:13 |
*** ricolin has joined #openstack-nova | 16:13 | |
kashyap | efried: The use cases are disk encryption — e.g. MS's BitLocker, and "Clevis" (https://github.com/latchset/clevis), TLS key storage (openssl-engine-tpm), etc. | 16:13 |
kashyap | efried: But I agree: there should be some clear write-up about "use cases from an OpenStack operator PoV" | 16:14 |
efried | kashyap: That would be nice, but I don't want to go crazy here, or block the work pending said writeup. | 16:15 |
efried | kashyap: Really the only thing I care about is whether there exists a use case where the VM doesn't care which version it gets. | 16:15 |
rm_work | On behalf of Octavia, we're a little confused about the "deleting a bound port" problem. johnsom is responding to the email right now, but I wonder if higher bandwidth discussion while a lot of us are here would make sense? I guess the email thread is fine otherwise | 16:15 |
*** lbragstad has quit IRC | 16:16 | |
kashyap | efried: Yeah, noted. And yes, we should explicitly document the answer to your question. | 16:16 |
efried | rm_work: We have time on the agenda this afternoon if you'd like to get together | 16:17 |
*** eharney has joined #openstack-nova | 16:17 | |
melwitt | rm_work: it means if you delete a port via the neutron REST API without first detaching it from the server it's attached to. if you do this and the port had QoS settings on it, nova will leak resources in placement (because there's no way for us to delete them if you didn't go through the detach port API or the delete server API) | 16:17 |
rm_work | efried: Is this really a nova issue, or is it a neutron issue? Or is it totally cross-project? | 16:17 |
*** Luzi has joined #openstack-nova | 16:17 | |
*** ricolin has quit IRC | 16:17 | |
efried | rm_work: The leaked allocations are an issue in placement, which would affect subsequent nova boots with QoS-enabled neutron ports :) | 16:18 |
*** bnemec has quit IRC | 16:18 | |
melwitt | rm_work: one of the takeaways from the discussion is that neutron can deprecate the ability to delete ports that are still attached (and avoid the issue). as you similarly can't delete a volume that is still attached in cinder | 16:19 |
efried | rm_work: It's really "always" been bad that you could do this (delete a port without considering what it's attached to), but it never mattered enough to do anything about. Now that the port is tied to real allocations in placement, it constitutes a leak and that kinda pushes it over the edge to where we should really do something. | 16:19 |
rm_work | the reason we do this directly is that there are several cases where a port detach in nova will simply fail to complete | 16:19 |
rm_work | at which point, we can either orphan the entire port, or we can just delete it | 16:20 |
melwitt | I guess if a port detach in nova fails to complete, there's a bug that needs to be fixed | 16:20 |
rm_work | example A: nova compute node is down | 16:21 |
efried | When the detach fails to complete, is the instance still deleted? | 16:21 |
efried | If the failure path still removes the allocations from placement, then it would be fine for you to force-delete the port. | 16:21 |
melwitt | if compute is down it would get cleaned up at the next run of the 'reap' periodic task on compute | 16:21 |
rm_work | but we can't wait that long | 16:22 |
rm_work | this is usually during time-sensitive failover operations | 16:22 |
melwitt | but this is another case where it would help to add start_immediately=True to the reap periodic | 16:22 |
rm_work | i think in all cases that we do a port delete the VM that it was attached to WILL be deleted anyway | 16:22 |
efried | actually, gibi_cape: doesn't the allocation go away whenever the instance is deleted? So the actual problem scenario is when we're detaching a port without deleting the instance? | 16:22 |
melwitt | that way the first run would happen when compute first comes up | 16:22 |
rm_work | because we only delete these ports when we are also deleting a VM | 16:22 |
melwitt | gotcha | 16:23 |
gibi_cape | efried, rm_work: the leaked allocation is reclaimed when the instance is deleted | 16:23 |
rm_work | unless I am missing a flow <_< | 16:23 |
efried | rm_work: If you're deleting the VM, and that succeeds, then we're good. | 16:23 |
rm_work | ok then so long as that is our workflow, we should not be hard-prevented from doing the port deletion | 16:23 |
efried | rm_work: So the way the proposed change would affect you is you would have to change the way you do that port detach. | 16:23 |
rm_work | it comes down to a timing issue | 16:23 |
*** bnemec has joined #openstack-nova | 16:23 | |
*** baderbuddy has joined #openstack-nova | 16:23 | |
rm_work | on our side, we're not going to wait for the detach to succeed in nova before we delete the port | 16:24 |
rm_work | we're going to move on with our cleanup | 16:24 |
rm_work | waiting would be problematic when we're in the middle of a time sensitive flow | 16:24 |
efried | rm_work: "not be hard-prevented" - right; but in order to do it after this change, you would have to change either code or policy (depending on how it's decided to implement) | 16:24 |
rm_work | yeah, if it's policy, fine | 16:24 |
rm_work | that's doable (we're already a service admin account) | 16:24 |
rm_work | if it's a code change, what does that mean -- changing to doing a detach first? because that's unlikely to happen | 16:25 |
openstackgerrit | garyk proposed openstack/nova master: VMware: populate datastore refs at init https://review.opendev.org/574688 | 16:25 |
efried | Changing code to do two calls: 1) null the "owner" field, 2) delete op as you have it today | 16:25 |
rm_work | especially if you're telling us that it's really not a problem anyway given what we're doing in the big picture | 16:25 |
rm_work | ok, so just an owner null -- assuming there's no real delay in that, then that seems doable, one extra call isn't the end of the world | 16:26 |
efried | If code change is the direction we go, nova will have to do the same thing. mriedem expressed not feeling great about that. If it's possible to do this with policy, I'm guessing that will be preferred all around. | 16:26 |
gibi_cape | do we want to fix this-> < rm_work> the reason we do this directly is that there are several cases where a port detach in | 16:27 |
gibi_cape | nova will simply fail to complete | 16:27 |
gibi_cape | do we have some way to reproduce that? | 16:28 |
rm_work | see johnsom's just-sent email for a more complete example | 16:28 |
rm_work | i believe it's reproducable yes | 16:28 |
gibi_cape | rm_work: looking | 16:28 |
*** eharney has quit IRC | 16:29 | |
*** eharney has joined #openstack-nova | 16:29 | |
*** ccamacho has quit IRC | 16:30 | |
rm_work | the biggest one we can definitively reproduce would be a powered off compute host | 16:30 |
rm_work | this is a problem whether we are about to delete the port post-detach, or if we are going to re-use it | 16:31 |
rm_work | (it's ESPECIALLY a problem if we want to re-use it) | 16:31 |
rm_work | we've seen scenarios where a compute host was powered off for 12-24 hours | 16:31 |
rm_work | it's theoretically possible that it might NEVER come up -- and what would happen to our port in that case? | 16:31 |
efried | rm_work: Does the instance get deleted from the database? | 16:32 |
openstackgerrit | melanie witt proposed openstack/nova master: Use run_immediately=True for _cleanup_running_deleted_instances https://review.opendev.org/657132 | 16:32 |
rm_work | it sticks in "deleting" vm state | 16:32 |
efried | rm_work: But if the point is that this whole thing is centered around you wanting to delete the VM, and you're going to delete it as soon as that's possible, then you're fine. | 16:33 |
efried | The proc/mem/disk resources are just as leaked as the bandwidth resources in this case where the VM is undeletable. | 16:34 |
rm_work | though what happens if we *do* need to delete the port? | 16:34 |
rm_work | err sorry, if we do need to re-use the port? | 16:34 |
rm_work | it's the same bug, just unrelated to the placement-leakage issue | 16:34 |
gibi_cape | rm_work: how do you re-use the port when the compute is down? | 16:34 |
rm_work | (since you were asking about the specific nova bug) | 16:34 |
rm_work | move it to another compute | 16:35 |
rm_work | so the case would be if we are using one port as our main ingress (instead of AAP) | 16:35 |
rm_work | so if a compute host is powered off, we need to move that port over to another working VM | 16:35 |
efried | gibi_cape: Do we reclaim the allocations when a port is detached? | 16:35 |
gibi_cape | rm_work: if nova is not involved in this move then nova cannot make sure that the resource needs of the port also moved | 16:35 |
rm_work | but a detach will just fail to complete | 16:35 |
gibi_cape | efried: if the port is detached in nova then yes we delete the port allocation in placement | 16:36 |
rm_work | so we can't reattach the port to a different VM | 16:36 |
efried | rm_work: Right, it sounds like this scenario is not possible. | 16:36 |
efried | You can't detach it if you can't talk to the compute | 16:36 |
efried | did I understand correcctly? | 16:36 |
rm_work | ok, so that's not a solvable issue in nova? | 16:36 |
rm_work | what if that compute host never comes back up? in case of hardware failure, this is possible | 16:37 |
rm_work | is that port gone forever? | 16:37 |
*** baderbuddy has quit IRC | 16:37 | |
gibi_cape | rm_work: if the compute never comes up then the resoruce leak in placement is not relevant as nobody else could you the leaked resource | 16:38 |
mriedem | zzzeek: sort of a random mysql uniqueness / primary key question for you when you have a sec | 16:38 |
cfriesen | new etherpad: https://etherpad.openstack.org/p/nova-ptg-train-2 | 16:38 |
rm_work | right, not really talking about the placement-specific issue anymore | 16:38 |
rm_work | this is about the bug that was behind our reasoning | 16:38 |
rm_work | there's multiple impacts on our side from the same bug | 16:38 |
rm_work | one of them was that we just force-delete the port to handle cleanup on our side | 16:39 |
rm_work | but the other is that we necessarily lose the port | 16:39 |
*** panda has quit IRC | 16:41 | |
gibi_cape | rm_work: I'm not fully understand what you really want to achieve with moving the bound port from one VM / compute to another. For me a neutron port feels like just a logical entity that easy to create / re-create | 16:41 |
melwitt | gibi_cape: they can't ever change IPs :) | 16:41 |
gibi_cape | melwitt: thanks | 16:42 |
rm_work | correct | 16:42 |
rm_work | we NEED to maintain the IP or we're sunk | 16:42 |
kashyap | stephenfin: I saw your comment scroll-by, on removing the needless libvirt version constants: I have a half-baked branch with some WIP. Or have you already posted something? | 16:44 |
kashyap | stephenfin: Trying to ensure we're doing duplicating work :-) | 16:44 |
stephenfin | kashyap: Nah, I'm not writing anything. Just reviewing your and mriedem's patches | 16:45 |
kashyap | stephenfin: Ah, like that | 16:45 |
gibi_cape | rm_work: if the VM on the down compute recovers later how that VM will be recovered from networking perspective? On the compute side the vif is still attached, but the neutron port is moved and attached to another VM. | 16:45 |
kashyap | stephenfin: All clear. Thanks, more clean-ups coming to a Firefox tab near you | 16:45 |
rm_work | gibi_cape: we don't care, that VM is going to be deleted anyway | 16:45 |
rm_work | once we move the port, we consider the old VM "dead" to us | 16:46 |
rm_work | we'll always be issuing a VM delete on it | 16:46 |
rm_work | very much cattle | 16:46 |
gibi_cape | rm_work: OK. then the policy thing could work. Octavia can do the port delete in neutron with the extra policy as Octavia makes sure the VM is deleted so the leaked resource is recovered by the VM delete | 16:47 |
rm_work | I think that would be the best approach | 16:47 |
rm_work | though it WOULD be awesome if we could figure out a solution to the underlying nova "bug" | 16:47 |
rm_work | I know you folks may not consider it a bug, but from our perspective, it sure seems that way | 16:47 |
rm_work | if a detach would just ... "complete" even if the compute host is unreachable, it'd make us very happy :) | 16:48 |
gibi_cape | rm_work: would be nice to have a bug report on that or / and talk about this in the nova room | 16:48 |
rm_work | ok -- though i believe we've brought it up before and were told that was expected behaviour | 16:49 |
rm_work | but I suppose filing it officially would at least provide history for a decision even if it's still the same | 16:49 |
*** panda has joined #openstack-nova | 16:49 | |
gibi_cape | rm_work: I don't have the historical context | 16:50 |
gibi_cape | rm_work: so I agree that written bug report would be nice | 16:50 |
*** wwriverrat has joined #openstack-nova | 16:51 | |
*** wwriverrat has quit IRC | 16:51 | |
openstackgerrit | Chris Dent proposed openstack/nova master: Make nova-tox-functional-py36 reusable https://review.opendev.org/657074 | 16:51 |
rm_work | we'll make sure to write something up, hopefully today | 16:51 |
*** wwriverrat has joined #openstack-nova | 16:52 | |
gibi_cape | rm_work: thanks | 16:52 |
mriedem | sean-k-mooney: mnaser: i might have figured out a reason for the port binding update failure that rcolvin was hitting https://bugs.launchpad.net/nova/+bug/1822884/comments/21 | 16:55 |
openstack | Launchpad bug 1822884 in OpenStack Compute (nova) "live migration fails due to port binding duplicate key entry in post_live_migrate" [Undecided,In progress] - Assigned to sean mooney (sean-k-mooney) | 16:55 |
*** whoami-rajat has quit IRC | 16:55 | |
mriedem | i have a recreate for it in my nova-multi-cell resize change | 16:55 |
gibi_cape | rm_work: replied on ML too | 16:57 |
rm_work | yeah, that seems right to me | 17:03 |
shuquan | rbd disks: convert from source format to raw https://review.opendev.org/#/c/640271/ https://review.openstack.org/#/c/642667/ | 17:07 |
*** IvensZambrano has quit IRC | 17:08 | |
*** cgoncalves has joined #openstack-nova | 17:09 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Log when port resource is leaked during port delete https://review.opendev.org/657079 | 17:10 |
*** ralonsoh has joined #openstack-nova | 17:13 | |
*** ricolin has joined #openstack-nova | 17:13 | |
*** awalende has joined #openstack-nova | 17:17 | |
*** awalende_ has joined #openstack-nova | 17:18 | |
*** pcaruana has quit IRC | 17:18 | |
*** wwriverrat has quit IRC | 17:19 | |
*** awalende has quit IRC | 17:21 | |
openstackgerrit | Tushar Patil proposed openstack/nova-specs master: Support filtering of allocation_candidates by forbidden aggregates https://review.opendev.org/609960 | 17:25 |
kashyap | efried: cfriesen; johnthetubaguy: Thanks, folks! | 17:27 |
*** ricolin has quit IRC | 17:28 | |
cfriesen | can anyone point me at what's breaking the nova-live-migration test for https://review.opendev.org/#/c/621646/ ? I can't tell if it's an issue with my patch or a zuul issue. | 17:28 |
mriedem | cfriesen: http://logs.openstack.org/46/621646/21/check/nova-live-migration/8a081f1/logs/devstacklog.txt.gz#_2019-05-02_22_32_53_983 | 17:29 |
mriedem | http://status.openstack.org/elastic-recheck/#1827083 | 17:29 |
*** shuquan has quit IRC | 17:30 | |
cfriesen | mriedem: thanks | 17:30 |
*** ricolin has joined #openstack-nova | 17:34 | |
*** ralonsoh has quit IRC | 17:38 | |
*** eharney has quit IRC | 17:39 | |
openstackgerrit | Merged openstack/nova-specs master: Support filtering of allocation_candidates by forbidden aggregates https://review.opendev.org/609960 | 17:43 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: pull out functions from _heal_allocations_for_instance https://review.opendev.org/655457 | 17:47 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: reorder conditions in _heal_allocations_for_instance https://review.opendev.org/655458 | 17:47 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations https://review.opendev.org/637954 | 17:47 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: pull out put_allocation call from _heal_* https://review.opendev.org/655459 | 17:47 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.opendev.org/637955 | 17:47 |
*** ricolin has quit IRC | 17:48 | |
openstackgerrit | Merged openstack/nova master: Improve test coverage of nova.privsep.utils. https://review.opendev.org/655281 | 17:49 |
kashyap | cfriesen: Do you know what johnthetubaguy meant by the phrase "fragment hypervisor"? | 17:49 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add image type request filter https://review.opendev.org/656413 | 17:49 |
openstackgerrit | Dan Smith proposed openstack/nova master: Enable image type query support in nova-next https://review.opendev.org/656903 | 17:49 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add docs for image type support request filter https://review.opendev.org/657025 | 17:49 |
cfriesen | kashyap: nope. :) | 17:51 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rework the PCI passthrough guides https://review.opendev.org/635243 | 17:54 |
*** _alastor_ has quit IRC | 17:56 | |
*** artom has quit IRC | 18:06 | |
*** artom has joined #openstack-nova | 18:06 | |
*** artom has quit IRC | 18:06 | |
*** artom has joined #openstack-nova | 18:07 | |
*** bnemec has quit IRC | 18:09 | |
*** Luzi has quit IRC | 18:09 | |
*** pcaruana has joined #openstack-nova | 18:10 | |
*** cdent has quit IRC | 18:10 | |
*** pcaruana has quit IRC | 18:10 | |
*** abhishekk has quit IRC | 18:15 | |
*** mlavalle has quit IRC | 18:20 | |
*** slaweq has quit IRC | 18:21 | |
*** awalende has joined #openstack-nova | 18:29 | |
*** artom has quit IRC | 18:31 | |
*** awalende_ has quit IRC | 18:31 | |
*** mriedem has quit IRC | 18:31 | |
sean-k-mooney | dansmith: https://etherpad.openstack.org/p/nova-ptg-train-governance | 18:31 |
*** jangutter has quit IRC | 18:32 | |
*** awalende has quit IRC | 18:33 | |
*** takashin has quit IRC | 18:35 | |
*** amodi has quit IRC | 18:35 | |
*** jangutter has joined #openstack-nova | 18:36 | |
*** ricolin has joined #openstack-nova | 18:37 | |
*** cfriesen has quit IRC | 18:38 | |
*** imacdonn has quit IRC | 18:38 | |
*** imacdonn has joined #openstack-nova | 18:39 | |
*** jangutter has quit IRC | 18:41 | |
*** ricolin has quit IRC | 18:42 | |
*** lbragstad has joined #openstack-nova | 18:44 | |
*** bnemec has joined #openstack-nova | 18:51 | |
*** cdent has joined #openstack-nova | 18:52 | |
*** lbragstad has quit IRC | 19:11 | |
*** dklyle has joined #openstack-nova | 19:13 | |
*** takashin has joined #openstack-nova | 19:14 | |
*** dklyle has quit IRC | 19:18 | |
*** jangutter has joined #openstack-nova | 19:21 | |
*** cfriesen has joined #openstack-nova | 19:23 | |
*** gmann has quit IRC | 19:42 | |
*** jangutter has quit IRC | 19:57 | |
*** takashin has quit IRC | 20:00 | |
*** sean-k-mooney has quit IRC | 20:02 | |
*** takashin has joined #openstack-nova | 20:03 | |
*** cfriesen has quit IRC | 20:03 | |
openstackgerrit | Merged openstack/nova stable/stein: libvirt: Always disconnect volumes after libvirtError exceptions https://review.opendev.org/657109 | 20:08 |
*** jangutter has joined #openstack-nova | 20:13 | |
*** igordc has joined #openstack-nova | 20:17 | |
*** jangutter has quit IRC | 20:17 | |
*** slaweq has joined #openstack-nova | 20:26 | |
openstackgerrit | Merged openstack/nova master: Add image type capability flags and trait conversions https://review.opendev.org/652710 | 20:32 |
*** awalende has joined #openstack-nova | 20:34 | |
*** awalende has quit IRC | 20:38 | |
*** wwriverrat has joined #openstack-nova | 20:52 | |
*** wwriverrat has quit IRC | 20:52 | |
*** wwriverrat has joined #openstack-nova | 20:53 | |
*** altlogbot_1 has quit IRC | 20:56 | |
*** artom has joined #openstack-nova | 20:58 | |
*** altlogbot_1 has joined #openstack-nova | 20:59 | |
*** altlogbot_1 has quit IRC | 21:04 | |
*** altlogbot_1 has joined #openstack-nova | 21:05 | |
*** slaweq has quit IRC | 21:07 | |
*** igordc has quit IRC | 21:07 | |
*** igordc has joined #openstack-nova | 21:07 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.opendev.org/575311 | 21:08 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.opendev.org/575581 | 21:08 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.opendev.org/576017 | 21:09 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.opendev.org/576018 | 21:09 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.opendev.org/576019 | 21:09 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.opendev.org/576020 | 21:09 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027 | 21:10 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.opendev.org/576031 | 21:10 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299 | 21:10 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344 | 21:10 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673 | 21:11 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676 | 21:11 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.opendev.org/576689 | 21:11 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.opendev.org/576709 | 21:11 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712 | 21:12 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.opendev.org/566153 | 21:12 |
*** baderbuddy has joined #openstack-nova | 21:18 | |
*** bnemec has quit IRC | 21:18 | |
*** baderbuddy has quit IRC | 21:24 | |
*** wwriverrat has quit IRC | 21:30 | |
*** takashin has left #openstack-nova | 21:34 | |
*** cdent has quit IRC | 21:37 | |
*** bnemec has joined #openstack-nova | 21:38 | |
*** artom has quit IRC | 21:43 | |
*** sean-k-mooney has joined #openstack-nova | 22:07 | |
*** awalende has joined #openstack-nova | 22:11 | |
*** slaweq has joined #openstack-nova | 22:32 | |
openstackgerrit | Merged openstack/nova master: Improve metadata performance https://review.opendev.org/615435 | 22:38 |
*** sean-k-mooney has quit IRC | 22:44 | |
openstackgerrit | Merged openstack/nova stable/stein: Eventlet monkey patching should be as early as possible https://review.opendev.org/647310 | 22:49 |
*** awalende has quit IRC | 22:49 | |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Train Cycle Themes https://review.opendev.org/657171 | 23:30 |
*** efried has quit IRC | 23:40 | |
*** ircuser-1 has quit IRC | 23:41 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!