| *** dklyle has quit IRC | 00:11 | |
| *** zbr_ has joined #openstack-nova | 00:13 | |
| *** zbr has quit IRC | 00:14 | |
| *** itlinux has joined #openstack-nova | 00:15 | |
| *** itlinux has quit IRC | 00:22 | |
| *** itlinux has joined #openstack-nova | 00:23 | |
| *** itlinux has quit IRC | 00:25 | |
| *** itlinux has joined #openstack-nova | 00:26 | |
| *** bbowen has quit IRC | 00:39 | |
| *** itlinux has quit IRC | 00:41 | |
| *** itlinux has joined #openstack-nova | 00:44 | |
| *** itlinux has quit IRC | 00:47 | |
| *** psyton has joined #openstack-nova | 00:49 | |
| *** psyton has quit IRC | 00:50 | |
| *** macza has joined #openstack-nova | 01:00 | |
| *** psyton has joined #openstack-nova | 01:01 | |
| openstackgerrit | Merged openstack/nova master: Add functional confirm_migration_error test https://review.opendev.org/657870 | 01:02 |
|---|---|---|
| *** macza has quit IRC | 01:04 | |
| *** bbowen has joined #openstack-nova | 01:05 | |
| *** brinzhang has joined #openstack-nova | 01:09 | |
| *** ttsiouts has joined #openstack-nova | 01:22 | |
| *** guozijn has joined #openstack-nova | 01:24 | |
| *** bhagyashris has joined #openstack-nova | 01:25 | |
| *** ileixe has joined #openstack-nova | 01:30 | |
| *** dklyle has joined #openstack-nova | 01:37 | |
| *** guozijn has quit IRC | 01:39 | |
| *** guozijn has joined #openstack-nova | 01:40 | |
| *** hongbin has joined #openstack-nova | 01:49 | |
| *** ttsiouts has quit IRC | 01:54 | |
| *** dklyle has quit IRC | 01:54 | |
| *** nicolasbock has quit IRC | 01:55 | |
| *** bbowen has quit IRC | 02:14 | |
| *** BjoernT has joined #openstack-nova | 02:32 | |
| *** BjoernT has quit IRC | 02:33 | |
| *** BjoernT has joined #openstack-nova | 02:34 | |
| *** BjoernT has quit IRC | 02:37 | |
| *** mvkr has quit IRC | 02:41 | |
| *** macza has joined #openstack-nova | 02:48 | |
| *** BjoernT has joined #openstack-nova | 02:51 | |
| *** macza has quit IRC | 02:52 | |
| *** mvkr has joined #openstack-nova | 02:55 | |
| *** whoami-rajat has joined #openstack-nova | 02:59 | |
| *** ttsiouts has joined #openstack-nova | 03:03 | |
| *** sean-k-mooney has quit IRC | 03:09 | |
| *** sean-k-mooney has joined #openstack-nova | 03:11 | |
| *** imacdonn has quit IRC | 03:24 | |
| *** ttsiouts has quit IRC | 03:35 | |
| *** imacdonn has joined #openstack-nova | 03:39 | |
| *** igordc has quit IRC | 03:44 | |
| *** sapd1_x has joined #openstack-nova | 03:46 | |
| *** udesale has joined #openstack-nova | 03:52 | |
| *** ricolin has joined #openstack-nova | 03:58 | |
| *** mvkr has quit IRC | 04:03 | |
| *** ivve has quit IRC | 04:10 | |
| *** macza has joined #openstack-nova | 04:11 | |
| *** macza has quit IRC | 04:16 | |
| *** pcaruana|afk| has joined #openstack-nova | 04:25 | |
| *** hongbin has quit IRC | 04:29 | |
| *** pcaruana|afk| has quit IRC | 04:35 | |
| *** BjoernT has quit IRC | 04:48 | |
| *** BjoernT has joined #openstack-nova | 04:48 | |
| *** janki has joined #openstack-nova | 05:01 | |
| *** ratailor has joined #openstack-nova | 05:05 | |
| *** ivve has joined #openstack-nova | 05:13 | |
| *** dpawlik has joined #openstack-nova | 05:28 | |
| *** ttsiouts has joined #openstack-nova | 05:33 | |
| *** guozijn has quit IRC | 05:38 | |
| *** udesale has quit IRC | 05:43 | |
| *** udesale has joined #openstack-nova | 05:43 | |
| *** BjoernT has quit IRC | 05:47 | |
| *** Luzi has joined #openstack-nova | 06:02 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:02 | |
| *** ttsiouts has quit IRC | 06:06 | |
| *** amodi has quit IRC | 06:31 | |
| *** xek has joined #openstack-nova | 06:35 | |
| *** belmoreira has joined #openstack-nova | 06:41 | |
| *** slaweq has joined #openstack-nova | 06:52 | |
| *** udesale has quit IRC | 06:52 | |
| *** udesale has joined #openstack-nova | 06:52 | |
| *** dpawlik has quit IRC | 06:57 | |
| *** slaweq has quit IRC | 07:03 | |
| *** awalende has joined #openstack-nova | 07:03 | |
| *** tesseract has joined #openstack-nova | 07:05 | |
| *** rcernin has quit IRC | 07:06 | |
| *** pcaruana has joined #openstack-nova | 07:12 | |
| *** helenafm has joined #openstack-nova | 07:25 | |
| *** tssurya has joined #openstack-nova | 07:25 | |
| *** dpawlik has joined #openstack-nova | 07:28 | |
| *** ttsiouts has joined #openstack-nova | 07:31 | |
| *** rpittau|afk is now known as rpittau | 07:32 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Fix failure to boot instances with qcow2 format images https://review.opendev.org/640271 | 07:33 |
| *** jangutter has joined #openstack-nova | 07:50 | |
| *** dtantsur|afk is now known as dtantsur | 07:54 | |
| *** sridharg has joined #openstack-nova | 07:55 | |
| *** ralonsoh has joined #openstack-nova | 07:58 | |
| *** belmoreira has quit IRC | 07:59 | |
| *** tkajinam has quit IRC | 08:14 | |
| *** luksky has joined #openstack-nova | 08:24 | |
| *** jaosorior has quit IRC | 08:25 | |
| *** ttsiouts has quit IRC | 08:34 | |
| *** derekh has joined #openstack-nova | 08:37 | |
| awalende | Where in the db is stored the volumes that are attached to a specific instance? | 08:39 |
| *** belmoreira has joined #openstack-nova | 08:39 | |
| awalende | I have a failing instance which can't boot because it tries to attach a non existing volume. | 08:39 |
| *** priteau has joined #openstack-nova | 08:41 | |
| brinzhang | awalende: You can look down the 'block_device_mapping' table. | 08:46 |
| brinzhang | awalende: There may be information about the disk you need with the instance. | 08:48 |
| awalende | Thanks! I found the entry | 08:51 |
| awalende | now to find out which field to manipulate in order to detach it | 08:52 |
| awalende | or is it safe to delete the rows with the non existing volume? | 08:52 |
| *** davidsha has joined #openstack-nova | 09:02 | |
| *** ttsiouts has joined #openstack-nova | 09:10 | |
| *** ratailor_ has joined #openstack-nova | 09:14 | |
| *** ricolin has quit IRC | 09:14 | |
| *** ratailor has quit IRC | 09:16 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520 | 09:20 |
| *** bhagyashris has quit IRC | 09:35 | |
| openstackgerrit | Surya Seetharaman proposed openstack/python-novaclient master: [Docs] Update client docs to add reason and locked options https://review.opendev.org/659000 | 09:37 |
| *** tssurya has quit IRC | 09:41 | |
| *** jaosorior has joined #openstack-nova | 09:41 | |
| *** tssurya has joined #openstack-nova | 09:41 | |
| *** ttsiouts has quit IRC | 09:44 | |
| *** boxiang has quit IRC | 09:48 | |
| *** belmoreira has quit IRC | 09:50 | |
| *** gibi is now known as gibi_off | 10:02 | |
| *** baderbuddy has joined #openstack-nova | 10:05 | |
| *** ratailor__ has joined #openstack-nova | 10:06 | |
| *** ratailor_ has quit IRC | 10:09 | |
| *** baderbuddy has quit IRC | 10:13 | |
| *** jaosorior has quit IRC | 10:24 | |
| *** shilpasd has joined #openstack-nova | 10:31 | |
| *** tbachman has quit IRC | 10:43 | |
| openstackgerrit | Hamdy Khader proposed openstack/nova master: [WIP] OVS DPDK port representors support https://review.opendev.org/658785 | 10:50 |
| *** bbowen has joined #openstack-nova | 10:51 | |
| *** bbowen has quit IRC | 10:56 | |
| *** belmoreira has joined #openstack-nova | 10:56 | |
| *** jangutter has quit IRC | 10:56 | |
| *** jaosorior has joined #openstack-nova | 11:03 | |
| *** udesale has quit IRC | 11:12 | |
| *** jangutter has joined #openstack-nova | 11:31 | |
| *** ratailor_ has joined #openstack-nova | 11:46 | |
| *** ratailor__ has quit IRC | 11:48 | |
| *** nicolasbock has joined #openstack-nova | 11:48 | |
| *** slaweq has joined #openstack-nova | 11:54 | |
| *** tbachman has joined #openstack-nova | 11:54 | |
| *** vabada_ is now known as dabadaba | 11:58 | |
| *** dabadaba has quit IRC | 12:02 | |
| openstackgerrit | Hamdy Khader proposed openstack/os-vif master: [WIP] OVS DPDK port representors support https://review.opendev.org/658786 | 12:05 |
| *** tetsuro has joined #openstack-nova | 12:09 | |
| *** luksky has quit IRC | 12:10 | |
| *** tetsuro has quit IRC | 12:11 | |
| *** udesale has joined #openstack-nova | 12:14 | |
| *** aarents has joined #openstack-nova | 12:15 | |
| *** bbowen has joined #openstack-nova | 12:16 | |
| *** lpetrut has joined #openstack-nova | 12:19 | |
| *** slaweq has quit IRC | 12:21 | |
| *** priteau has quit IRC | 12:22 | |
| *** lpetrut has joined #openstack-nova | 12:23 | |
| *** sridharg has quit IRC | 12:23 | |
| *** derekh has quit IRC | 12:25 | |
| openstackgerrit | Alexandre arents proposed openstack/nova master: Fix live-migration when glance image deleted https://review.opendev.org/659054 | 12:29 |
| *** janki has quit IRC | 12:30 | |
| *** sridharg has joined #openstack-nova | 12:36 | |
| *** mchlumsky has joined #openstack-nova | 12:41 | |
| *** davidsha has quit IRC | 12:44 | |
| kashyap | alex_xu: Hi, I have abandoned this spec (the `cpu_model_list` thing) after further discussions w/ the QEMU & libvirt folks: https://review.opendev.org/#/c/642030/ | 12:45 |
| *** mchlumsky has quit IRC | 12:46 | |
| *** ratailor_ has quit IRC | 12:48 | |
| *** mriedem has joined #openstack-nova | 12:49 | |
| *** mchlumsky has joined #openstack-nova | 12:50 | |
| *** luksky has joined #openstack-nova | 12:52 | |
| alex_xu | kashyap: ok, got it | 12:57 |
| *** jistr is now known as jistr|call | 12:59 | |
| *** ttsiouts has joined #openstack-nova | 13:02 | |
| *** belmoreira has quit IRC | 13:02 | |
| *** brinzhang has quit IRC | 13:06 | |
| *** ttsiouts has quit IRC | 13:07 | |
| *** k4bi has joined #openstack-nova | 13:12 | |
| *** udesale has quit IRC | 13:14 | |
| *** udesale has joined #openstack-nova | 13:14 | |
| *** derekh has joined #openstack-nova | 13:15 | |
| *** lbragstad has joined #openstack-nova | 13:15 | |
| *** ttsiouts has joined #openstack-nova | 13:26 | |
| *** jistr|call is now known as jistr | 13:30 | |
| *** abhishekk has joined #openstack-nova | 13:30 | |
| *** ttsiouts has quit IRC | 13:30 | |
| *** BjoernT has joined #openstack-nova | 13:34 | |
| *** BjoernT has quit IRC | 13:36 | |
| *** BjoernT_ has joined #openstack-nova | 13:36 | |
| *** BjoernT has joined #openstack-nova | 13:37 | |
| *** BjoernT_ has quit IRC | 13:40 | |
| mdbooth | bauzas: I also thought we might have other bugs like https://review.opendev.org/#/c/658845/, so I posted to the ML earlier | 13:45 |
| bauzas | mdbooth: yup that's why I left a comment | 13:45 |
| mdbooth | bauzas: ack | 13:46 |
| bauzas | we have this bug, so we can fix it, but maybe we should also look at other methods | 13:46 |
| mdbooth | bauzas: Indeed | 13:46 |
| mdbooth | bauzas: And be generally stricter about not modifying argument data. It causes a bunch of issues, but I think this is the subtlist I've encountered. | 13:47 |
| mdbooth | Incidentally, this specific issue breaks the '1 task at a time' guard in n-api for all operations which use task state, which is nearly all of them. | 13:48 |
| mdbooth | s/all operations/all instance operations/ | 13:49 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: [Trivial doc change] Admin can overwrite the locked_reason of an owner https://review.opendev.org/659067 | 13:51 |
| *** jamesdenton has joined #openstack-nova | 13:52 | |
| *** awalende has quit IRC | 13:53 | |
| *** awalende has joined #openstack-nova | 13:53 | |
| kashyap | aspiers: You okay with the "plan" at the end here: https://review.opendev.org/#/c/655193/ | 13:56 |
| *** kaisers1 has quit IRC | 13:56 | |
| kashyap | alex_xu: If later we decide that we "really need it", we can always restore it. | 13:57 |
| *** awalende has quit IRC | 13:58 | |
| *** k4bi has quit IRC | 13:58 | |
| *** belmoreira has joined #openstack-nova | 13:58 | |
| *** awalende has joined #openstack-nova | 13:59 | |
| kashyap | efried: When you're about, bike-shedding, for the file name in 'os-traits': how about the x86.py --> x86-common.py? (Or is it "implied"?) | 14:01 |
| *** awalende has quit IRC | 14:03 | |
| efried | kashyap: We can't change x86.py at this point. And yes, I think common is implied. I would just make an x86 subdirectory with intel.py and amd.py | 14:03 |
| *** mlavalle has joined #openstack-nova | 14:03 | |
| kashyap | (Oh, right.) | 14:03 |
| kashyap | I keep forgetting that "can't ever change" aspect. | 14:03 |
| kashyap | Thx. | 14:03 |
| efried | kashyap: I'm actually not 100% sure of the mechanics. I think you may have to remove x86.py and move the contents to x86/__init__.py | 14:04 |
| efried | It's the strings that get produced that aren't allowed to change. | 14:04 |
| kashyap | Right, I'm not sure either. I'll duke around a bit. This is my first time tipping toes into this repo | 14:05 |
| kashyap | (Trying not to boil any lakes as "first steps" :D) | 14:05 |
| sean-k-mooney | why woudl you move them to __init__.py | 14:07 |
| sean-k-mooney | just to not have to type x86 | 14:07 |
| kashyap | sean-k-mooney: I don't know, having x86.py file and x86/ directory in the _same_ directory feels "clumsy". | 14:08 |
| sean-k-mooney | from a general style point of view is strongly dislike haveing __init__.py contain any content ever | 14:08 |
| kashyap | sean-k-mooney: I can live with it; but open to any approach that lets us avoid it | 14:08 |
| sean-k-mooney | we dont currently have an x86 direcotry correct | 14:09 |
| sean-k-mooney | https://github.com/openstack/os-traits/tree/master/os_traits/hw/cpu | 14:09 |
| sean-k-mooney | we just have the x86.py | 14:09 |
| sean-k-mooney | why are you creating a directory | 14:09 |
| kashyap | sean-k-mooney: See the discussion on the change here: https://review.opendev.org/#/c/655193/ | 14:10 |
| kashyap | sean-k-mooney: Specifically this remark from Eric on PS2: | 14:11 |
| kashyap | hw/cpu/x86.py (common to both Intel and AMD) | 14:11 |
| kashyap | hw/cpu/x86/amd.py (AMD-specific) <== new (but see below) | 14:11 |
| kashyap | hw/cpu/x86/intel.py (Intel-specific) <== new | 14:11 |
| efried | sean-k-mooney: os-traits has a precedent for having attributes in __init__.py | 14:11 |
| sean-k-mooney | im looking but or you do hw/cpu/intel.py hw/cpu/amd.py and hw/cpu/x86.py | 14:12 |
| sean-k-mooney | * or you could do hw/cpu/intel.py hw/cpu/amd.py and hw/cpu/x86.py | 14:12 |
| efried | sean-k-mooney: Point is, both intel and amd are x86 | 14:12 |
| sean-k-mooney | yes | 14:12 |
| efried | but have divergent attributes | 14:12 |
| efried | like for this spectre/meltdown stuff | 14:13 |
| *** abhishekk has quit IRC | 14:13 | |
| sean-k-mooney | well they really should not | 14:13 |
| *** dklyle has joined #openstack-nova | 14:13 | |
| efried | heh | 14:13 |
| *** tbachman has quit IRC | 14:13 | |
| sean-k-mooney | at the traits point of view | 14:13 |
| efried | sean-k-mooney: I mentioned that | 14:13 |
| efried | but kashyap shot me down | 14:13 |
| sean-k-mooney | we shoudl have a common trait where posible | 14:13 |
| efried | yup, read discussion in that patch. | 14:13 |
| *** lpetrut has quit IRC | 14:14 | |
| sean-k-mooney | kashyap: what was the outcome fo the discussion with openstack security on exposeing thes as traits | 14:14 |
| kashyap | sean-k-mooney: I didn't write to the 'openstack-security' folks. | 14:14 |
| sean-k-mooney | so before we decided on this chagne we shoudl have that disucssion | 14:14 |
| kashyap | sean-k-mooney: Note: at 'traits point of view", it is impossibel to have "divergent attributes". See my last comment | 14:15 |
| kashyap | I carefully discussed it with DanPB yesterday, and posted my discussion | 14:15 |
| *** rpittau is now known as rpittau|afk | 14:15 | |
| *** ratailor has joined #openstack-nova | 14:16 | |
| sean-k-mooney | sure but just because danpb sates an opion does not mean we will alway follow it but im reading the comments now :) | 14:16 |
| efried | point is, we need HW_CPU_X86_INTEL_FOO and HW_CPU_X86_AMD_BAR as well as HW_CPU_X86_BAZ. I'm just not sure whether that happens with | 14:17 |
| efried | hw/cpu/x86/intel.py: FOO | 14:17 |
| efried | hw/cpu/x86/amd.py: BAR | 14:17 |
| efried | hw/cpu/x86.py: BAZ | 14:17 |
| efried | or | 14:17 |
| efried | hw/cpu/x86/intel.py: FOO | 14:17 |
| efried | hw/cpu/x86/amd.py: BAR | 14:17 |
| efried | hw/cpu/x86/__init__.py: BAZ | 14:17 |
| efried | or we could even leave the existing structure and do | 14:17 |
| efried | hw/cpu/x86.py: INTEL_FOO | 14:17 |
| efried | hw/cpu/x86.py: AMD_BAR | 14:17 |
| efried | hw/cpu/x86.py: BAZ | 14:17 |
| *** dpawlik has quit IRC | 14:17 | |
| efried | edleafe: Do you have an opinion on this? | 14:17 |
| edleafe | They all come out to the same trait string, right? | 14:18 |
| sean-k-mooney | you can do it with all of the above | 14:18 |
| kashyap | sean-k-mooney: No, you misunderstood me. It's not "because" DanPB said. | 14:18 |
| kashyap | sean-k-mooney: See these two points: | 14:18 |
| aspiers | I'm with sean-k-mooney in that I don't like putting stuff in __init__.py | 14:18 |
| kashyap | * The benefit of HW_CPU_HAS_SPECTRE_CURE is that it glosses over the | 14:18 |
| kashyap | difference between the AMD and Intel flag names for the fix ('IBRS' vs | 14:18 |
| *** Luzi has quit IRC | 14:18 | |
| kashyap | 'IBPB'). However, we likely going to want feature- based traits for | 14:18 |
| kashyap | other things: AES, PCID, etc. | 14:18 |
| kashyap | * The HW_CPU_HAS_SPECTRE_CURE is ill-defined :-( since there are many | 14:18 |
| kashyap | Spectre-related bugs. | 14:18 |
| kashyap | sean-k-mooney: Frankly, we're over-thinking on the generic "traits" thing. | 14:19 |
| kashyap | I want to tackle that separately. And first get the granular traits in, without discussing this to the ends of the worlds. | 14:19 |
| sean-k-mooney | kashyap: so traits shoudl not may to qemu feature flags directly | 14:19 |
| mdbooth | stephenfin: I know you called it a nit, but given that I suspect it's a bug it wasn't caught by flake8 I'm going to respin anyway. Thanks for looking! | 14:19 |
| sean-k-mooney | there is no reas an IBRS trait cant map to the IBPB feature on amd and IBRS on intel | 14:20 |
| kashyap | sean-k-mooney: I disagree. | 14:20 |
| *** tbachman has joined #openstack-nova | 14:20 | |
| stephenfin | mdbooth: Go for it. fwiw, I do have a series to update the hacking version we use but I've WIP'd that til the removal of cells v1 is complete | 14:20 |
| sean-k-mooney | part of os-tratis is to provide a vendor independ set of common traits that can be normalised | 14:20 |
| edleafe | efried: if we're going to be having _INTEL_* and _AMD_* traits, it would make more sense to have them in their own modules | 14:20 |
| stephenfin | There's enough merge conflicts as it is | 14:20 |
| sean-k-mooney | and them mapped to plathform specific thing in the virt dirvers | 14:20 |
| kashyap | efried: Yeah, I'd like to know the answer to your earlier question | 14:21 |
| kashyap | (On the structure) | 14:21 |
| sean-k-mooney | edleafe: we dont really want to add tratis to the __init__.py file in general but we do allow it | 14:21 |
| kashyap | Why we "don't really want"? | 14:22 |
| kashyap | If efried says there's a precedence | 14:22 |
| edleafe | sean-k-mooney: yeah, that's messier, but it does work | 14:22 |
| edleafe | Separate modules is cleaner | 14:22 |
| efried | sean-k-mooney: That's happening all over os-traits. In typical projects I agree it may be best avoided, but when in rome... | 14:22 |
| sean-k-mooney | kashyap: because its condiered an anti pattern in python | 14:22 |
| kashyap | Hm | 14:22 |
| efried | of nine __init__.pyZ in os-traits, five have content. | 14:23 |
| sean-k-mooney | efried: yes i know | 14:23 |
| kashyap | sean-k-mooney: Also, look at: compute/__init__.py | 14:23 |
| sean-k-mooney | although when i suggested adding namespaces in os-traits intially i was hoping to not use __init__.py | 14:24 |
| edleafe | If you're creating a directory hierarchy, and need directory-level traits, the only way to do that is in __init__.py | 14:24 |
| sean-k-mooney | edleafe: yes which is why we use it | 14:24 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Fix retry of instance_update_and_get_original https://review.opendev.org/658845 | 14:25 |
| efried | edleafe: you can't have x86.py and x86/ ? | 14:25 |
| sean-k-mooney | but do we need hw/cpu/x86/intel.py or just hw/cpu/intel.py | 14:25 |
| sean-k-mooney | if its an intel specific trait why add x86 | 14:25 |
| efried | edleafe: that seems horrible to me because you wouldn't know where to look for your stuff, but is it even legal python? | 14:25 |
| mdbooth | bauzas stephenfin: ^^^ Only change is whitespace for stephenfin's nit. | 14:25 |
| kashyap | efried: edleafe: So, does this structure make sense: | 14:25 |
| kashyap | hw/cpu/x86/amd.py (AMD-specific) | 14:25 |
| kashyap | hw/cpu/x86/intel.py (Intel-specific) | 14:25 |
| kashyap | hw/cpu/x86/__init__.py (Common for both AMD and Intel) | 14:25 |
| kashyap | --- | 14:25 |
| kashyap | hw/cpu/amd.py (Deprecate it with a comment) | 14:25 |
| efried | kashyap: Yes, I think that's the right way to go. | 14:26 |
| sean-k-mooney | i think the opisite | 14:26 |
| edleafe | efried: that would create HW_CPU_X86_X86_FOO, no? | 14:26 |
| kashyap | sean-k-mooney: Also note that there are other vulns. _besides_ Spectre/Meltdown: E.g. "L1TF". | 14:26 |
| efried | kashyap: And remove x86.py. Current contents go to x86/__init__.py | 14:26 |
| sean-k-mooney | i would prefer to add an intel.py beside the amd.py | 14:26 |
| edleafe | efried: oh, you mean at the level above? | 14:26 |
| stephenfin | This feels like a lot of ado about nothing. What's wrong with keeping everything in x86.py again? | 14:26 |
| kashyap | efried: Right (on removing x86.py) | 14:26 |
| edleafe | efried: yeah, that could work | 14:26 |
| sean-k-mooney | i mean just add an intel.py here https://github.com/openstack/os-traits/tree/master/os_traits/hw/cpu | 14:26 |
| edleafe | But it's unnecesary | 14:27 |
| efried | edleafe: I meant, is it legal to have: hw/cpu/x86.py and hw/cpu/x86/__init__.py | 14:27 |
| aspiers | stephenfin: stop trying to spoil the bike-shedding fun ;-) | 14:27 |
| stephenfin | :) | 14:27 |
| kashyap | stephenfin: "Nothing"? It's because traits are "baked in forever", we're having this discussion. Otherwise, none would bother belaboring. | 14:27 |
| edleafe | efried: yep | 14:27 |
| kashyap | aspiers: Yeah, stephenfin is only aggravating :D | 14:27 |
| aspiers | kashyap is right about that, traits much need more care than most stuff | 14:27 |
| efried | stephenfin: because there are traits that exist only on amd and only on intel. | 14:27 |
| sean-k-mooney | stephenfin: well until openstack security ways in on the security question my current stance is we should add none of these tratis | 14:28 |
| efried | From now on we shall require everyone to read all comments on this patch and pass a quiz before being allowed to participate in the conversation. | 14:28 |
| kashyap | stephenfin: I know you have more than 10 minutes of attention span: have fun reading: https://review.opendev.org/#/c/655193/4 | 14:28 |
| aspiers | efried: I guess stephenfin's point was about which file they go in, not so much how they're namespaced | 14:28 |
| aspiers | efried: haha good idea! | 14:28 |
| stephenfin | kashyap: Not really. I mean, they're still for x86 architectures, only those from specific companies | 14:29 |
| stephenfin | Throwing everything in x86.py sounds a lot easier than trying to categorize each flag, IMO :) | 14:29 |
| sean-k-mooney | stephenfin: i agree | 14:29 |
| kashyap | sean-k-mooney: I think your stance there is invalid, recall what we discussed before: | 14:29 |
| kashyap | < efried> kashyap, sean-k-mooney: I'm going to say it's fine to add the traits to os-traits regardless; the vulnerability occurs when we expose them via compute | 14:29 |
| kashyap | stephenfin: Did you read the discussion here: https://review.opendev.org/#/c/655193/ ? | 14:30 |
| stephenfin | I mean, we're not going to have an amd_intel.py file if a flag is only supported by AMD and Intel and not whoever else has an x86 license | 14:30 |
| kashyap | (If not, there's more nuance than just following the IRC discussion here) | 14:30 |
| stephenfin | kashyap: I did and held my tongue because I wan't sure | 14:30 |
| kashyap | Heh | 14:30 |
| efried | we have to categorize the intel- and amd-specific ones anyway. The strings that come out in the end are already figured. It's a question of whether to have INTEL_FOO and AMD_BAR in x86.py or have separate namespace dirs. | 14:30 |
| sean-k-mooney | kashyap: my full stance on this is we should not do it peiord but if we must add these i would prefer them to be generic not vender specific and only as a last resouce expose vendor specific tratits | 14:30 |
| stephenfin | but now that I've seen this, I've decided my first impression made some sense at least | 14:31 |
| stephenfin | sean-k-mooney: Aye, agreed on the latter part of that at least. Not sure about the basis for the former so can't comment | 14:31 |
| stephenfin | efried: Do we? Why? | 14:32 |
| stephenfin | (just for context) | 14:32 |
| kashyap | sean-k-mooney: You seem to be too hung up on 'generic'. It _doesn't_ fully make sense in this case. | 14:32 |
| efried | I'll go out on a limb and say that anything x86 that's supported by both AMD and Intel should go into the x86 namespace, and random manufacturer that owns 0.0000001% of the x86 market who doesn't support that feature can just not turn it on. | 14:32 |
| sean-k-mooney | kashyap: i think this is a missue use of traits and im pushing back becasue i dont think you have mad the case of why we should be exposing this in a non generic way | 14:33 |
| efried | stephenfin: Because some of them are mutually exclusive. | 14:33 |
| kashyap | sean-k-mooney: The case is the vulnerabilities cannot be trivially mapped into 'generic' traits> | 14:33 |
| sean-k-mooney | traits are ment to be an abstration over hardware and are not intened to enable specifric feature flags in the emulated cpu | 14:33 |
| efried | well now I can get behind that ^ | 14:33 |
| kashyap | sean-k-mooney: And some people may want to run _without_ "L1TF" (which is Intel-only) | 14:33 |
| stephenfin | efried: OK. How would that manifest itself in a way we care about? | 14:34 |
| sean-k-mooney | kashyap: sure but why do this need to be in placement | 14:34 |
| sean-k-mooney | as a trait | 14:34 |
| stephenfin | (again, just so I know. Genuine question) | 14:34 |
| sean-k-mooney | kashyap: my concern is that you appear to be trying to use tratis to carry vm configuration in fomation by making the vendor specific when we should be able to provide an abstration here | 14:35 |
| efried | stephenfin: Apparently there's "has a flag you can turn on to mitigate X vulnerability" with variants of "do it on the CPU" and "do it in virt" and then there's "is manufactured without the vulnerability in the first place so no flags needed". And different variants of those exist depending on amd vs intel. | 14:35 |
| kashyap | sean-k-mooney: No, you're assuming far too much. This whole discussion "exploded" when I simply noticed a few weeks ago some missing CPU traits. | 14:36 |
| efried | stephenfin: I had already questioned whether we really cared about those distinctions, as opposed to "vulnerable or not". | 14:36 |
| efried | apparently we do. | 14:36 |
| sean-k-mooney | efried: right but the request to turn on the flag shoudl either be in the nova.conf or as a flavor extra spec or as an image proerty | 14:36 |
| kashyap | And digigng more, I then thought: "If you have generic CPU flags listed, what about those that provide mitigation for security flaws.) | 14:36 |
| sean-k-mooney | that flag should not be enabled by addign a required tratit to the flavor or image | 14:37 |
| efried | sean-k-mooney: Right, but how do you schedule (or avoid scheduling to) a system that is or is not able to enable those flags? | 14:37 |
| *** tbachman has quit IRC | 14:37 | |
| stephenfin | efried: OK, I wasn't aware of that. Thanks | 14:37 |
| sean-k-mooney | we normalise the vendor diference in the virt dirver to a standard trait that is vendor independed | 14:37 |
| kashyap | stephenfin: Your earlier question is answered in the commit message: "Notes on the "SSB"/"SSBD" confusion" | 14:38 |
| kashyap | (Here: https://review.opendev.org/#/c/655193/) | 14:38 |
| kashyap | (It notes how Intel and AMD addressed the same issue differently.) | 14:39 |
| dansmith | kashyap: are you suggesting traits for flaws, not just traits for cpu flags? | 14:39 |
| kashyap | dansmith: On "traits for flaws", I'm not sure if it makes sense. For now, all I care about is: all the required CPU flags are captured as traits | 14:40 |
| kashyap | Err, s/required/missing/ | 14:40 |
| sean-k-mooney | kashyap: efried suggested generic HW_CPU_HAS_MELTDOWN_CURE, HW_CPU_HAS_SPECTRE_CURE style traits in teh review | 14:41 |
| kashyap | sean-k-mooney: And did you see my response that I already pasted here? | 14:41 |
| dansmith | :( | 14:41 |
| sean-k-mooney | personally i think that is a better solution then what you are suggesting | 14:41 |
| artom | MELTDOWN_CURE sounds like a thing all parents of toddlers need | 14:41 |
| *** tbachman has joined #openstack-nova | 14:41 | |
| kashyap | sean-k-mooney: Huh, you haven't read the response, that I posted, have you: | 14:42 |
| kashyap | * The benefit of HW_CPU_HAS_SPECTRE_CURE is that it glosses over the | 14:42 |
| kashyap | difference between the AMD and Intel flag names for the fix ('IBRS' vs | 14:42 |
| sean-k-mooney | althoght i woudl personally go with hw_CPU_VULNERABLITY_SPECTER | 14:42 |
| kashyap | 'IBPB'). However, we likely going to want feature-based traits for | 14:42 |
| kashyap | other things: AES, PCID, etc. | 14:42 |
| kashyap | Given the above it doesn't make sense the "generic roll-up traits". | 14:42 |
| kashyap | * The HW_CPU_HAS_SPECTRE_CURE is ill-defined :-( since there are many | 14:42 |
| kashyap | Spectre-related bugs. | 14:42 |
| kashyap | s/"sense the"/"sense to have"/ | 14:43 |
| sean-k-mooney | yes i did see that comment | 14:43 |
| kashyap | sean-k-mooney: If you have a _clear_ proposal, please write it as a (not too long) comment in the change, I'd appreciate it. | 14:43 |
| kashyap | For now, I'll go with the structure I discussed with efried earlier. | 14:43 |
| sean-k-mooney | ok i will. but to be clear adding a required trait should have 0 impact on the xml generation and should not enable a cpu feature flag in the libvirt xml for that cpu feature | 14:44 |
| sean-k-mooney | if the host is configed in the nova.conf to enable that feature that is fine but reporting/requireing a trait should not change the behavior of the vm form another that was schduled to that host without requiring the traits | 14:45 |
| dansmith | fwiw, I *hate* the "has the cure" trait | 14:46 |
| kashyap | dansmith: Hehe, that's not going to happen :-) | 14:46 |
| sean-k-mooney | dansmith: well what about the other fomulation of hw_cpu_vulnerablity_XYZ | 14:46 |
| kashyap | dansmith: It was a thinking-out-loud point from Eric. | 14:47 |
| edleafe | dansmith: it's as bad as "doesn't have the vulnerability" trait | 14:47 |
| dansmith | sean-k-mooney: I don't like that either | 14:47 |
| sean-k-mooney | which the cpu feature flags are in another vail | 14:47 |
| dansmith | "is broken" or "was broken" or "has a software fix" are terrible traits to me | 14:47 |
| sean-k-mooney | dansmith: ya i dont like tracking vulnerablity in placement period | 14:48 |
| dansmith | sean-k-mooney: agreen | 14:48 |
| dansmith | *agreed | 14:48 |
| dansmith | I also don't think that tracking cpu flags in placement for non-feature flags makes sense | 14:48 |
| dansmith | AVX2, yes... flags that just imply that a microcode fix has been applied, not so much | 14:48 |
| sean-k-mooney | i stil am concerned that adding any of the security realted flag give me a vector to upload an image with a require/forbidn trait and target a vulnerable host | 14:49 |
| *** lpetrut has joined #openstack-nova | 14:49 | |
| dansmith | sean-k-mooney: for serious | 14:49 |
| kashyap | dansmith: How about this idea (that I discussed here on PS:4 as "Another Idea" - https://review.opendev.org/#/c/655193/): | 14:49 |
| kashyap | Make Nova check the 'sysfs' (/sys/devices/system/cpu/vulnerabilities) directory for vulnerabilities. And e.g. if it reports "Vulnerable" (instead of "Mitigation") for Meltdown (or other flaws), print a warning that the host is vulnerable, and on next release refuse to start the VMs | 14:49 |
| sean-k-mooney | dansmith: :) | 14:49 |
| dansmith | kashyap: I have a hard time understanding why this is a nova thing at all.. configs to turn on compatibility as needed makes sense, since we are controlling the definition of the VMs, | 14:50 |
| sean-k-mooney | kashyap: i dont think its novas place to do that | 14:50 |
| dansmith | but the management of the host-level patching is not our deal, IMHO | 14:50 |
| dansmith | what sean-k-mooney said | 14:50 |
| kashyap | dansmith: Nah, we don't _patch_ it. But isn't it fair game for Nova to tell that: "hey, your host is vulnerable to critical flaws, launching VMs there is dangerous?" | 14:51 |
| dansmith | same reason we don't refuse to boot instances because we're concerned that our cpu fans are spinning too slowly | 14:51 |
| dansmith | kashyap: not IMHO | 14:51 |
| kashyap | I see. | 14:51 |
| kashyap | Just wondering out loud. My umbilical cord isn't tied to that idea :-) | 14:51 |
| sean-k-mooney | kashyap: depending on your enviornment (a air gapped secure datacenter) you ligitamately may want to have a vulnerable system for the performace improvments. i agree with dansmith that it should not be novas role to dictate your securety and threat model | 14:52 |
| kashyap | One would think it's reasonable for Nova to prompt admins to secure their hypervisors. | 14:53 |
| dansmith | sean-k-mooney: yeah, definitely agree.. I have unpatched systems for reasons :) | 14:53 |
| kashyap | sean-k-mooney: Yeah, I've considered that point -- on someone _intentionally_ wanting to run unpatched | 14:53 |
| kashyap | ... precisely for the perf reasons. | 14:53 |
| sean-k-mooney | kashyap: you could make the same argument for libvirt if you go that route or qemu | 14:53 |
| dansmith | or fan speed, or cpu temperature, or firmware patch levels, or os patch levels, or .... | 14:54 |
| kashyap | Well, that doesn't make sense in the _common_ case for those components. Not everyone is sitting there with "air-gapped secure datacenters". | 14:54 |
| sean-k-mooney | the kernel warns the user and i think that is where the warning should be | 14:54 |
| kashyap | sean-k-mooney: Are you referring to the 'sysfs' directory as "kernel warns"? | 14:56 |
| sean-k-mooney | kashyap: well i ment the message in dmesg form the early boot but sysfs can be used later at runtime | 14:57 |
| sean-k-mooney | its also show in thing like lscpu | 14:57 |
| sean-k-mooney | actully its not in lscpu but is in /proc/cpuinfo in the bugs line "bugs : cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf" | 15:01 |
| kashyap | sean-k-mooney: Yeah, it's _not_ in `lscpu` | 15:01 |
| *** ratailor has quit IRC | 15:02 | |
| sean-k-mooney | ya it would be a nice enhancement to add it | 15:02 |
| kashyap | Right, it's in /proc/cpuinfo. And of course, 'sysfs' is a better place. | 15:02 |
| sean-k-mooney | yep and you allso get entires in dmesg as the are detected on kenel boot with the mitigations that are applied | 15:04 |
| sean-k-mooney | like this | 15:04 |
| sean-k-mooney | 0.033797] Spectre V2 : Mitigation: Full generic retpoline | 15:04 |
| sean-k-mooney | [ 0.033797] Spectre V2 : Spectre v2 / SpectreRSB mitigation: Filling RSB on context switch | 15:04 |
| sean-k-mooney | [ 0.033798] Spectre V2 : Spectre v2 mitigation: Enabling Indirect Branch Prediction Barrier | 15:04 |
| sean-k-mooney | [ 0.033798] Spectre V2 : Enabling Restricted Speculation for firmware calls | 15:04 |
| sean-k-mooney | [ 0.033799] Spectre V2 : Spectre v2 cross-process SMT mitigation: Enabling STIBP | 15:04 |
| sean-k-mooney | [ 0.033800] Speculative Store Bypass: Mitigation: Speculative Store Bypass disabled via prctl and seccomp | 15:04 |
| sean-k-mooney | which is the same info that gets stroed in cat /sys/devices/system/cpu/vulnerabilities/* | 15:05 |
| openstackgerrit | Gorka Eguileor proposed openstack/nova master: Use os-brick locking for volume attach and detach https://review.opendev.org/614190 | 15:05 |
| mriedem | bauzas: dansmith: can one of you hit this stable/stein test-only backport to keep things moving? https://review.opendev.org/#/c/658929/ | 15:13 |
| *** mchlumsky has quit IRC | 15:13 | |
| *** mchlumsky has joined #openstack-nova | 15:15 | |
| *** wwriverrat has quit IRC | 15:18 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'instance_update_from_api' https://review.opendev.org/651302 | 15:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop handling 'update_cells' on 'BandwidthUsage.create' https://review.opendev.org/651303 | 15:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop handling cells v1 for instance naming https://review.opendev.org/651304 | 15:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove cells code https://review.opendev.org/651306 | 15:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove conductor_api and _last_host_check from manager.py https://review.opendev.org/651059 | 15:20 |
| *** tbachman has quit IRC | 15:21 | |
| *** wwriverrat has joined #openstack-nova | 15:24 | |
| *** tbachman has joined #openstack-nova | 15:26 | |
| *** ttsiouts has joined #openstack-nova | 15:27 | |
| *** wwriverrat has quit IRC | 15:28 | |
| *** mchlumsky has quit IRC | 15:28 | |
| *** mchlumsky has joined #openstack-nova | 15:30 | |
| *** helenafm has quit IRC | 15:30 | |
| openstackgerrit | Adrian Chiris proposed openstack/nova master: [FUP] Follow-up patch for SR-IOV live migration https://review.opendev.org/659101 | 15:30 |
| *** sridharg has quit IRC | 15:35 | |
| *** hemna has joined #openstack-nova | 15:41 | |
| *** lpetrut has quit IRC | 15:45 | |
| *** belmoreira has quit IRC | 15:48 | |
| *** dklyle has quit IRC | 15:50 | |
| *** sridharg has joined #openstack-nova | 15:51 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Modify PciDevice.uuid generation code https://review.opendev.org/530487 | 15:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add an online migration for PciDevice.uuid https://review.opendev.org/530905 | 15:51 |
| *** dklyle has joined #openstack-nova | 15:52 | |
| *** hamzy has quit IRC | 15:52 | |
| stephenfin | dansmith: If you have any free time today, could you take a look at those two patches again? ^ They're the sixth and seventh oldest ones I have, respectively :) | 15:52 |
| *** awalende has joined #openstack-nova | 15:54 | |
| *** openstackgerrit has quit IRC | 15:54 | |
| dansmith | stephenfin: is there something that is going to need this? | 15:56 |
| dansmith | not that it's a bad thing to have proper uuids, but... just wondering | 15:56 |
| stephenfin | We have a chunk of legacy code that is present only because we can't be sure we don't have UUIDs. I'd like to remove that | 15:56 |
| stephenfin | So it's tech debt | 15:56 |
| dansmith | okay | 15:58 |
| *** igordc has joined #openstack-nova | 15:59 | |
| *** awalende has quit IRC | 15:59 | |
| mriedem | stephenfin: the bottom one is so obviously copied from the bdm code it still mentions bdms in it | 16:00 |
| *** cfriesen has joined #openstack-nova | 16:00 | |
| stephenfin | mriedem: Yuuup (though the reference is obv a mistake) | 16:00 |
| *** ttsiouts has quit IRC | 16:01 | |
| *** imacdonn has quit IRC | 16:01 | |
| *** macza has joined #openstack-nova | 16:01 | |
| stephenfin | mdbooth and I discussed dragging it out into something standardized a long time back, but we figured it would be better wait for at least one more user before proceeding down the generic util path | 16:01 |
| *** gyee has joined #openstack-nova | 16:01 | |
| *** igordc has quit IRC | 16:03 | |
| *** openstackgerrit has joined #openstack-nova | 16:04 | |
| openstackgerrit | Merged openstack/python-novaclient master: [Docs] Update client docs to add reason and locked options https://review.opendev.org/659000 | 16:04 |
| openstackgerrit | Matthew Booth proposed openstack/nova master: Add code comment to _instance_update https://review.opendev.org/659112 | 16:10 |
| *** dklyle has quit IRC | 16:11 | |
| *** imacdonn has joined #openstack-nova | 16:15 | |
| *** dklyle has joined #openstack-nova | 16:16 | |
| *** mgoddard has quit IRC | 16:20 | |
| *** dklyle has quit IRC | 16:21 | |
| *** tbachman has quit IRC | 16:21 | |
| *** mgoddard has joined #openstack-nova | 16:21 | |
| *** k4bi has joined #openstack-nova | 16:22 | |
| *** dklyle has joined #openstack-nova | 16:23 | |
| openstackgerrit | Adrian Chiris proposed openstack/nova master: [FUP] Follow-up patch for SR-IOV live migration https://review.opendev.org/659101 | 16:28 |
| *** mgoddard has quit IRC | 16:30 | |
| *** maciejjozefczyk has quit IRC | 16:31 | |
| *** mgoddard has joined #openstack-nova | 16:32 | |
| *** partlycloudy has left #openstack-nova | 16:33 | |
| logan- | hello, in OSA we've got a failure bumping our nova testing SHA (https://review.opendev.org/#/c/658208/) due to an api_db sync failure: | 16:36 |
| logan- | http://logs.openstack.org/08/658208/3/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/6c21b9f/logs/ara-report/result/2b065096-d2f5-497b-a29b-2833502c0459/ | 16:36 |
| logan- | "AttributeError: 'module' object has no attribute 'COMPUTE_IMAGE_TYPE_AKI'" | 16:36 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add 'flavor-extra-spec-image-property-validation-extended' spec https://review.opendev.org/638734 | 16:36 |
| mriedem | logan-: which version of os-traits? | 16:36 |
| mriedem | you need os-traits>=0.12.0 | 16:37 |
| logan- | checking | 16:37 |
| logan- | ok thanks | 16:37 |
| dtantsur | hey folks, we see this one rocky in ironic: http://logs.openstack.org/71/658771/4/check/ipa-tempest-dsvm-partition-bios-ipmi-iscsi-tinyipa-src/fb9d0bb/logs/screen-n-cpu.txt.gz?level=INFO | 16:38 |
| dtantsur | can it be https://github.com/openstack/nova/commit/35bda4ec385e4c2b3d4cee07467f5077b13b1dd9 ? | 16:38 |
| mriedem | dtantsur: which thing? the StrictVersion? yes. | 16:38 |
| mriedem | er wait | 16:38 |
| mriedem | the StrictVersion thing has been around awhile https://bugs.launchpad.net/nova/+bug/1793766 | 16:39 |
| openstack | Launchpad bug 1793766 in OpenStack Compute (nova) "An unknown error has occurred when trying to get the list of nodes from the Ironic inventory. Error: StrictVersion instance has no attribute 'version'" [Low,Confirmed] | 16:39 |
| mriedem | but maybe it's hitting more now because of ^ | 16:39 |
| dtantsur | I'm not sure if it's on nova or ironicclient side tbh | 16:39 |
| logan- | thanks for the tip mriedem, it looks like we're pulling in 0.11.0 somehow. http://logs.openstack.org/08/658208/3/check/openstack-ansible-deploy-aio_metal-ubuntu-bionic/6c21b9f/logs/ara-report/result/7f027c76-34d4-4dfa-a06a-d91722043b58/ | 16:40 |
| dtantsur | mriedem: then we end up with http://logs.openstack.org/71/658771/4/check/ipa-tempest-dsvm-partition-bios-ipmi-iscsi-tinyipa-src/fb9d0bb/logs/screen-n-cpu.txt.gz#_May_14_12_21_18_271733 | 16:40 |
| dtantsur | I'm not sure if the StrictVersion thingy is the cause, but looks so | 16:40 |
| logan- | oh we need to bump our requirements sha | 16:40 |
| logan- | heh | 16:40 |
| mriedem | logan-: stale upper-constraints? | 16:41 |
| mriedem | oh ok | 16:41 |
| logan- | yup, that should fix it up. thanks! | 16:41 |
| stephenfin | sean-k-mooney: If you're around for a while longer, you might fancy looking at https://review.opendev.org/638734 again. Think I've addressed most of your concerns (by focussing solely on flavor extra specs) | 16:41 |
| * stephenfin -> 🏡 | 16:42 | |
| *** tbachman has joined #openstack-nova | 16:43 | |
| *** udesale has quit IRC | 16:46 | |
| sean-k-mooney | oh the validation spec sure ill take a look | 16:46 |
| openstackgerrit | Merged openstack/nova stable/stein: Add functional confirm_migration_error test https://review.opendev.org/658929 | 16:47 |
| *** mgoddard has quit IRC | 16:48 | |
| *** mgoddard has joined #openstack-nova | 16:48 | |
| *** dtantsur is now known as dtantsur|afk | 16:51 | |
| tssurya | mriedem: could you have a look when you have time ? https://review.opendev.org/#/c/658110/ - thanks in advance | 16:53 |
| *** luksky has quit IRC | 16:54 | |
| *** dklyle has quit IRC | 16:59 | |
| *** derekh has quit IRC | 17:00 | |
| *** dklyle has joined #openstack-nova | 17:01 | |
| *** mgoddard has quit IRC | 17:02 | |
| *** mgoddard has joined #openstack-nova | 17:03 | |
| *** tssurya has quit IRC | 17:06 | |
| *** slaweq has joined #openstack-nova | 17:06 | |
| sean-k-mooney | stephenfin: adrianc i left some comments on https://review.opendev.org/#/c/659101/2 but this actully intduces more nits then it fixes at least from my view point | 17:11 |
| *** slaweq has quit IRC | 17:14 | |
| *** mgoddard has quit IRC | 17:20 | |
| *** mgoddard has joined #openstack-nova | 17:22 | |
| *** ralonsoh has quit IRC | 17:25 | |
| *** _erlon_ has joined #openstack-nova | 17:32 | |
| *** sridharg has quit IRC | 17:36 | |
| *** itlinux has joined #openstack-nova | 17:42 | |
| *** aarents has quit IRC | 17:45 | |
| *** hamzy has joined #openstack-nova | 17:48 | |
| *** itlinux has quit IRC | 17:48 | |
| *** dklyle has quit IRC | 17:52 | |
| sean-k-mooney | stephenfin: done. i think i have a better solution that i more generic then what you proposed but still support a yaml file for operators to customise | 17:54 |
| *** itlinux has joined #openstack-nova | 17:54 | |
| *** tjgresha has quit IRC | 17:54 | |
| sean-k-mooney | all standard extra specs however would be validated in python and we woudl have a stevedor entry point so that cyborg, rmd,os-traits extra specs could also be validated | 17:55 |
| *** tjgresha has joined #openstack-nova | 17:57 | |
| *** ttsiouts has joined #openstack-nova | 17:58 | |
| *** mvkr has joined #openstack-nova | 17:58 | |
| *** hongbin has joined #openstack-nova | 18:04 | |
| *** luksky has joined #openstack-nova | 18:15 | |
| *** betherly has joined #openstack-nova | 18:19 | |
| *** BjoernT has quit IRC | 18:22 | |
| *** betherly has quit IRC | 18:24 | |
| *** ivve has quit IRC | 18:29 | |
| *** ttsiouts has quit IRC | 18:31 | |
| *** lpetrut has joined #openstack-nova | 18:42 | |
| *** BjoernT has joined #openstack-nova | 18:44 | |
| *** lpetrut has quit IRC | 18:46 | |
| adrianc | sean-k-mooney: Thanks, ill take a look tommorow ? | 18:48 |
| adrianc | without the ? :) | 18:49 |
| sean-k-mooney | adrianc: they are reltivly minor | 18:49 |
| sean-k-mooney | and one comment is a presonl preference/nit | 18:49 |
| *** jdillaman has quit IRC | 18:49 | |
| adrianc | yah i gave it a quick look, thanks for providing inputs. BTW do we really need to bother ourselves with the cyborg integration on the is_sriov_port propery ? | 18:51 |
| adrianc | i mean its A. a future issue , B. ive just moved the "mess" to one place | 18:51 |
| sean-k-mooney | am proably not i just wanted to highlight it | 18:51 |
| adrianc | ack | 18:51 |
| sean-k-mooney | i mean we can always fix it when we integrate cyborg rather then now | 18:51 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/nova stable/rocky: Add functional confirm_migration_error test https://review.opendev.org/658834 | 18:59 |
| *** betherly has joined #openstack-nova | 19:00 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: [Trivial doc change] Admin can overwrite the locked_reason of an owner https://review.opendev.org/659067 | 19:04 |
| *** betherly has quit IRC | 19:04 | |
| *** itlinux has quit IRC | 19:16 | |
| *** dklyle has joined #openstack-nova | 19:16 | |
| *** dklyle has quit IRC | 19:19 | |
| *** david-lyle has joined #openstack-nova | 19:19 | |
| *** pcaruana has quit IRC | 19:19 | |
| *** slaweq has joined #openstack-nova | 19:21 | |
| *** awalende has joined #openstack-nova | 19:25 | |
| *** david-lyle has quit IRC | 19:42 | |
| mriedem | dansmith: so i just realized that our 2.33 change for listing hypervisors which added limit and marker support for paging changed the previous behavior where we'd just return everything - we now default to CONF.api.max_limit if you don't specify a limit, and i can't tell if that's good or not - i suppose in terms of api load it's good to limit server-side | 19:46 |
| mriedem | forces the client to page though | 19:46 |
| dansmith | mriedem: you mean before that we would return all of them regardless of the amount? | 19:46 |
| mriedem | right | 19:46 |
| dansmith | like, 50000000000 of them? | 19:46 |
| mriedem | 10K, 14K, whatever cern has yeah | 19:47 |
| dansmith | clamping to max_limit does not seem like a regression to me :) | 19:47 |
| mriedem | heh | 19:47 |
| mriedem | yeah i'm just learning some watcher code where they build their data model for hypervisors and it's super inefficient, and lossy because of this limit thing i realize | 19:47 |
| mriedem | tl;dr they (1) list all hypervisors with details (well, up to 1K), (2) for each hypervisor, get it's servers (3) for each hypervisor, get it's details (again) | 19:48 |
| mriedem | all of that can be done in a single GET with 2.53 | 19:48 |
| dansmith | yoza | 19:49 |
| dansmith | *yowza | 19:49 |
| mriedem | and i *think* this is on ever audit request | 19:49 |
| mriedem | rather than like build on startup, then modify as notifications come in | 19:49 |
| mriedem | *every | 19:49 |
| dansmith | sweet | 19:52 |
| mriedem | oy, and for every compute node, get all of its instances in separate GETs | 19:59 |
| NewBruce | hey sean-k-mooney / mriedem | 20:03 |
| NewBruce | saw the code updates and call for review - will get onto it asap - sorry bout that - got caught up in a couple other bug chasing efforts….. | 20:04 |
| NewBruce | thanks for the work on it though :) | 20:04 |
| *** jmlowe has joined #openstack-nova | 20:06 | |
| *** tesseract has quit IRC | 20:06 | |
| *** awalende has quit IRC | 20:19 | |
| *** awalende has joined #openstack-nova | 20:20 | |
| *** awalende has quit IRC | 20:24 | |
| *** bbowen_ has joined #openstack-nova | 20:26 | |
| *** itlinux has joined #openstack-nova | 20:27 | |
| *** jdillaman has joined #openstack-nova | 20:27 | |
| *** ttsiouts has joined #openstack-nova | 20:28 | |
| *** bbowen has quit IRC | 20:28 | |
| *** bbowen_ has quit IRC | 20:36 | |
| *** cdent has joined #openstack-nova | 20:36 | |
| *** ivve has joined #openstack-nova | 20:36 | |
| *** JamesBenson has joined #openstack-nova | 20:40 | |
| *** hamzy has quit IRC | 20:41 | |
| *** slaweq has quit IRC | 20:44 | |
| *** JamesBenson has quit IRC | 20:54 | |
| *** cdent has quit IRC | 20:58 | |
| *** JamesBenson has joined #openstack-nova | 20:59 | |
| *** JamesBenson has quit IRC | 20:59 | |
| mriedem | np | 20:59 |
| *** ttsiouts has quit IRC | 21:01 | |
| *** itlinux has quit IRC | 21:07 | |
| *** BjoernT has quit IRC | 21:14 | |
| mriedem | efried: comments on surya's fix here https://review.opendev.org/#/c/658110/ - if you're in agreement i'll just make the changes quick | 21:15 |
| efried | mriedem: wfm. You want to fix or would you feel better if I did? | 21:18 |
| mriedem | i'll do it, already got the test done | 21:18 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Disable limit if affinity(anti)/same(different)host is requested https://review.opendev.org/658110 | 21:21 |
| *** dklyle has joined #openstack-nova | 21:27 | |
| mriedem | efried: so i addressed my nits on ^ you and alex were +2, want to just fast approve? | 21:30 |
| efried | mriedem: gimme a sec. I'll mark up and then fast approve. | 21:32 |
| efried | mriedem: Comments added. If you are okay with those things, say so and I'll approve. | 21:36 |
| efried | or quick respin to address would be better :) | 21:36 |
| mriedem | oh hmm | 21:38 |
| mriedem | multiple hints aye | 21:38 |
| mriedem | couldn't i just throw a fake hint in there? | 21:38 |
| mriedem | i.e. are you ok with this? | 21:39 |
| mriedem | fake_spec = objects.RequestSpec( | 21:39 |
| mriedem | flavor=flavor, scheduler_hints={hint: [uuids.fake], | 21:39 |
| mriedem | 'some-fake-hint': ['fake-value']}) | 21:39 |
| efried | That would be good too, but I'd like to see >1 of the hints we're conditioning on. | 21:40 |
| efried | mriedem: If it were me, I would nix ddt, put the guts of the test in a _helper, and loop over it with various permutations of hints constructed in a loop from components. | 21:41 |
| efried | mriedem: if you tire of this, I can take a crack at it. | 21:42 |
| mriedem | ddt is nice in that the test names have the ddt values in the test name in case one of them blows up | 21:43 |
| mriedem | anyway i've got a thing | 21:43 |
| mriedem | this didn't come up in the review comments on the patch before this so i figured it was fine - unless that came up in irc | 21:44 |
| *** dklyle has quit IRC | 21:44 | |
| *** dklyle has joined #openstack-nova | 21:44 | |
| *** amodi has joined #openstack-nova | 21:44 | |
| mriedem | i'm not going to mention something about nested providers in the commit message b/c this is going back to queens | 21:46 |
| mriedem | where those weren't supported | 21:46 |
| mriedem | is that ok? | 21:46 |
| efried | Yeah, ignore that one, just thought to point it out. | 21:46 |
| *** mchlumsky has quit IRC | 21:47 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Disable limit if affinity(anti)/same(different)host is requested https://review.opendev.org/658110 | 21:47 |
| *** betherly has joined #openstack-nova | 21:48 | |
| *** bbowen has joined #openstack-nova | 21:48 | |
| efried | mriedem: +A | 21:49 |
| mriedem | whew | 21:49 |
| efried | I know, try to do a nice thing... | 21:50 |
| *** dklyle has quit IRC | 21:50 | |
| *** ivve has quit IRC | 21:50 | |
| *** betherly has quit IRC | 21:53 | |
| * mriedem makes a note to complain to my tc liaison about the nova core team | 21:59 | |
| *** rcernin has joined #openstack-nova | 22:00 | |
| *** luksky has quit IRC | 22:01 | |
| *** betherly has joined #openstack-nova | 22:08 | |
| *** betherly has quit IRC | 22:13 | |
| *** tbachman has quit IRC | 22:15 | |
| *** tbachman has joined #openstack-nova | 22:17 | |
| *** whoami-rajat has quit IRC | 22:18 | |
| *** BjoernT has joined #openstack-nova | 22:35 | |
| *** tbachman_ has joined #openstack-nova | 22:36 | |
| *** tbachman has quit IRC | 22:37 | |
| *** tbachman_ is now known as tbachman | 22:37 | |
| *** BjoernT has quit IRC | 22:39 | |
| *** BjoernT has joined #openstack-nova | 22:40 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: TC Vision Reflection https://review.opendev.org/658932 | 22:48 |
| efried | A little more every day | 22:48 |
| efried | maybe by meeting time I'll have enough for folks to start ripping apart | 22:49 |
| *** tkajinam has joined #openstack-nova | 22:52 | |
| *** _erlon_ has quit IRC | 22:52 | |
| *** ttsiouts has joined #openstack-nova | 22:58 | |
| *** hemna has quit IRC | 23:11 | |
| *** hongbin has quit IRC | 23:20 | |
| *** betherly has joined #openstack-nova | 23:31 | |
| *** ttsiouts has quit IRC | 23:32 | |
| *** macza has quit IRC | 23:33 | |
| *** mlavalle has quit IRC | 23:34 | |
| *** betherly has quit IRC | 23:36 | |
| *** BjoernT has quit IRC | 23:42 | |
| *** irclogbot_0 has quit IRC | 23:45 | |
| *** lbragstad has quit IRC | 23:47 | |
| *** irclogbot_0 has joined #openstack-nova | 23:48 | |
| *** itlinux has joined #openstack-nova | 23:49 | |
| *** betherly has joined #openstack-nova | 23:51 | |
| *** betherly has quit IRC | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!