Thursday, 2019-05-30

« Wednesday, 2019-05-29 Index Friday, 2019-05-31 »
*** wwriverrat has joined #openstack-nova00:04
*** slaweq has joined #openstack-nova00:11
*** gyee has quit IRC00:14
*** guozijn has joined #openstack-nova00:15
*** slaweq has quit IRC00:16
*** brinzhang has joined #openstack-nova00:16
*** guozijn has quit IRC00:24
*** hongbin has quit IRC00:28
*** markvoelker has quit IRC00:32
*** ccamacho has joined #openstack-nova00:39
*** imacdonn has quit IRC00:46
*** imacdonn has joined #openstack-nova00:46
*** yaawang has quit IRC00:46
*** yaawang has joined #openstack-nova00:47
*** wwriverrat has quit IRC01:12
openstackgerritGuo Jingyu proposed openstack/nova master: Define and catch QemuGuestAgentNotRunning for set-password failure  https://review.opendev.org/66146601:18
*** bbowen has joined #openstack-nova01:21
*** markvoelker has joined #openstack-nova01:21
*** whoami-rajat has joined #openstack-nova01:35
openstackgerritzhaixiaojun proposed openstack/nova master: Blacklist python-cinderclient 4.0.0  https://review.opendev.org/66157801:35
*** yedongcan has joined #openstack-nova01:35
*** yonglihe has joined #openstack-nova01:38
*** lbragstad has quit IRC01:40
*** awalende has joined #openstack-nova01:55
*** threestrands has joined #openstack-nova01:56
*** guozijn has joined #openstack-nova01:57
openstackgerritTakashi NATSUME proposed openstack/nova master: Add TODO note for mox removal  https://review.opendev.org/57675801:58
*** awalende has quit IRC02:00
*** ccamacho has quit IRC02:09
*** Spencer_Yu has joined #openstack-nova02:13
*** cfriesen has quit IRC02:19
openstackgerritmelanie witt proposed openstack/nova master: Follow up for counting quota usage from placement  https://review.opendev.org/66205602:23
*** ccamacho has joined #openstack-nova02:29
openstackgerritMerged openstack/nova stable/stein: docs: Don't version links to reno docs  https://review.opendev.org/66202502:38
openstackgerritMerged openstack/os-vif stable/rocky: Prevent "qbr" Linux Bridge from replying to ARP messages  https://review.opendev.org/65569202:58
*** sapd1_x has joined #openstack-nova03:11
*** BjoernT has joined #openstack-nova03:13
*** guozijn has quit IRC03:14
*** dave-mccowan has quit IRC03:15
*** guozijn has joined #openstack-nova03:24
*** guozijn has quit IRC03:27
*** JamesBenson has joined #openstack-nova03:29
openstackgerritmelanie witt proposed openstack/nova-specs master: Amend count-quota-usage-from-placement to reflect implementation  https://review.opendev.org/66213003:32
*** guozijn has joined #openstack-nova03:36
*** threestrands has quit IRC03:45
*** BjoernT has quit IRC03:46
*** threestrands has joined #openstack-nova04:05
*** threestrands has quit IRC04:06
*** slaweq has joined #openstack-nova04:11
*** slaweq has quit IRC04:16
*** sapd1_x has quit IRC04:26
*** shilpasd has joined #openstack-nova04:43
*** ricolin has joined #openstack-nova04:45
*** guozijn has quit IRC04:50
*** JamesBenson has quit IRC05:00
*** pcaruana has joined #openstack-nova05:00
*** igordc has joined #openstack-nova05:15
*** sridharg has joined #openstack-nova05:20
*** ricolin has quit IRC05:25
*** takashin has quit IRC05:27
*** ratailor has joined #openstack-nova05:28
*** ricolin has joined #openstack-nova05:28
openstackgerritMerged openstack/nova master: Add get_counts() to InstanceMappingList  https://review.opendev.org/63807205:33
*** guozijn has joined #openstack-nova05:50
openstackgerritMerged openstack/nova master: Fix hard-delete of instance with soft-deleted referential constraints  https://review.opendev.org/66139805:55
*** Dinesh_Bhor has joined #openstack-nova05:55
*** minmin has quit IRC05:57
*** stakeda has joined #openstack-nova05:57
openstackgerritguangchao.pan proposed openstack/nova master: Add a name for the automatically created volume  https://review.opendev.org/66009606:01
*** igordc has quit IRC06:01
*** lpetrut has joined #openstack-nova06:02
*** ccamacho has quit IRC06:05
*** slaweq has joined #openstack-nova06:06
*** factor has joined #openstack-nova06:12
*** efried1 has joined #openstack-nova06:21
*** efried has quit IRC06:23
*** efried1 is now known as efried06:23
*** ricolin has quit IRC06:26
openstackgerritTakashi NATSUME proposed openstack/nova master: Add TODO note for mox removal  https://review.opendev.org/57675806:38
*** takashin has joined #openstack-nova06:38
*** luksky has joined #openstack-nova06:42
*** ccamacho has joined #openstack-nova06:43
*** boxiang has joined #openstack-nova06:51
*** markvoelker has quit IRC07:01
*** markvoelker has joined #openstack-nova07:01
*** maciejjozefczyk has joined #openstack-nova07:01
*** markvoelker has quit IRC07:06
*** tobias-urdin has quit IRC07:09
*** helenafm has joined #openstack-nova07:10
*** rcernin has quit IRC07:10
openstackgerritBoxiang Zhu proposed openstack/nova master: Remove unsafe convert of lvm imagebackend  https://review.opendev.org/64266707:15
*** ccamacho has quit IRC07:16
*** ccamacho has joined #openstack-nova07:16
*** xek_ has joined #openstack-nova07:23
*** ricolin has joined #openstack-nova07:23
openstackgerritBalazs Gibizer proposed openstack/nova master: Enhance service restart in functional env  https://review.opendev.org/51255207:43
openstackgerritBalazs Gibizer proposed openstack/nova master: Add functional test coverage for bug 1724172  https://review.opendev.org/51255307:43
openstackbug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Medium,Fix released] https://launchpad.net/bugs/1724172 - Assigned to Balazs Gibizer (balazs-gibizer)07:43
openstackgerritLee Yarwood proposed openstack/nova stable/stein: Fix live-migration when glance image deleted  https://review.opendev.org/66215207:50
*** toabctl has quit IRC07:50
openstackgerritLee Yarwood proposed openstack/nova stable/rocky: Fix live-migration when glance image deleted  https://review.opendev.org/66215307:50
openstackgerritLee Yarwood proposed openstack/nova stable/queens: Fix live-migration when glance image deleted  https://review.opendev.org/66215407:50
*** priteau has joined #openstack-nova07:53
openstackgerritBalazs Gibizer proposed openstack/nova master: Defaults missing group_policy to 'none'  https://review.opendev.org/65779607:55
*** minmin has joined #openstack-nova07:56
*** ccamacho has quit IRC08:05
*** Spencer_Yu has quit IRC08:10
openstackgerritMerged openstack/nova master: Move selective patching of open() to nova.test for reuse  https://review.opendev.org/66126608:25
*** tstrul has joined #openstack-nova08:27
*** tkajinam has quit IRC08:33
lyarwoodhttps://review.opendev.org/#/c/572790/ - Looking for additional core review on this change from mriedem blocking swap_volume for multi-attached volumes that aren't RO08:38
*** derekh has joined #openstack-nova08:38
lyarwood^ I'd also like to pull that back into the stable branches FWIW08:38
*** derekh has quit IRC08:38
*** derekh has joined #openstack-nova08:39
*** cdent has joined #openstack-nova08:41
* johnthetubaguy has a peak08:41
cdent:mountain:08:42
* cdent hides08:43
johnthetubaguyheh08:43
* johnthetubaguy now wants a cappuccino 08:43
johnthetubaguylyarwood: I was dubious about that being back-portable but you are right, we should have done this in the first place08:45
lyarwoodjohnthetubaguy: yup it's just yet another swap_volume bugfix IMHO, pretty large for the stable branches but still useful.08:46
johnthetubaguyyeah, its borderline, but too useful not to08:47
*** markvoelker has joined #openstack-nova09:02
*** tstrul has quit IRC09:08
*** ricolin has quit IRC09:09
*** panda is now known as panda|ruck09:17
*** ociuhandu has joined #openstack-nova09:20
*** ratailor_ has joined #openstack-nova09:20
*** ratailor has quit IRC09:23
sean-k-mooneyjohnthetubaguy: o/09:33
johnthetubaguyhey09:33
sean-k-mooneyjohnthetubaguy: can you let me know if you want me to do the refactor you suggested here https://review.opendev.org/#/c/647733/5/nova/virt/libvirt/driver.py@4833 ill try to respin that later todoay if you do09:34
sean-k-mooneyill add the extra unit tests in either case09:34
johnthetubaguysean-k-mooney: its probably overkill, that was me thinking out loud really, just looking at your comments on there now09:35
*** markvoelker has quit IRC09:35
sean-k-mooneyjohnthetubaguy: ok, i dont like that the fucntion is modifying its inputs but i also dont really want to make the change larger then it needs to be09:37
johnthetubaguysean-k-mooney: yeah, also I think local consistency is a good argument to keep it as it is09:37
sean-k-mooneyif your happy with the other responces ill just add the extra unit test cases and leave it as is.09:38
johnthetubaguyyeah, I am happy with that09:38
sean-k-mooneycool thanks for taking a look :)09:38
johnthetubaguyno worries09:39
*** ratailor__ has joined #openstack-nova09:52
*** factor has quit IRC09:53
*** ratailor_ has quit IRC09:54
*** boxiang has quit IRC09:55
openstackgerritHamdy Khader proposed openstack/os-vif master: OVS DPDK port representors support  https://review.opendev.org/65878609:59
*** stakeda has quit IRC10:05
openstackgerritLee Yarwood proposed openstack/nova master: nova-lvm: Disable [validation]/run_validation in tempest.conf  https://review.opendev.org/66217610:08
openstackgerritMerged openstack/nova stable/queens: Delete allocations even if _confirm_resize raises  https://review.opendev.org/65215310:13
openstackgerritStephen Finucane proposed openstack/nova stable/rocky: docs: Don't version links to reno docs  https://review.opendev.org/66217810:18
*** sridharg has quit IRC10:32
*** bbowen has quit IRC10:37
*** factor has joined #openstack-nova10:37
*** nicolasbock has joined #openstack-nova10:39
openstackgerritAdam Spiers proposed openstack/nova master: WIP: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported  https://review.opendev.org/63868010:41
*** sridharg has joined #openstack-nova10:45
openstackgerritAdam Spiers proposed openstack/nova master: Track inventory for new MEM_ENCRYPTION_CONTEXT resource class  https://review.opendev.org/66210510:46
*** tbachman has quit IRC10:48
openstackgerritAdam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection  https://review.opendev.org/63633410:49
*** cdent has quit IRC10:55
*** yedongcan has left #openstack-nova10:55
*** guozijn has quit IRC11:00
alex_xusean-k-mooney: good morning, hope you can take a look at this https://review.opendev.org/#/c/601596/ if you are interesting. we update according the PTG discussion11:02
sean-k-mooneysure ill take a look11:08
johnthetubaguyalex_xu: I keep meaning to re-review that too11:09
sean-k-mooneyill be submiting a spec for stactic CAT today or tommorow if your interested too11:09
*** dave-mccowan has joined #openstack-nova11:10
sean-k-mooneyalex_xu: well assumeing we have capasity to work on it this cycle which is still TBD but im hoping to answer that question today11:10
*** rcernin has joined #openstack-nova11:10
alex_xujohnthetubaguy: sean-k-mooney thanks!11:11
gibiefried: could you check https://review.opendev.org/#/c/652608/ mriedem already happy with it11:20
openstackgerritBalazs Gibizer proposed openstack/nova stable/stein: cleanup evacuated instances not on hypervisor  https://review.opendev.org/66218911:23
*** guozijn has joined #openstack-nova11:23
*** ratailor_ has joined #openstack-nova11:33
alex_xusean-k-mooney: yea, i'm interesting in review the cat spec, I will ask someone from my team review it also11:34
*** ratailor__ has quit IRC11:35
sean-k-mooneyalex_xu: the draft is here https://etherpad.openstack.org/p/libvirt-static-cache-and-memory-allocation but its best to keep most of the review for gerrit11:37
*** ratailor_ has quit IRC11:37
sean-k-mooneyi still have some todos and self notes to clean up but its mostly complete11:38
alex_xusean-k-mooney: nice, yea, will waiting for the gerrit11:38
*** tstrul has joined #openstack-nova11:42
*** bbowen has joined #openstack-nova11:48
*** luksky has quit IRC11:48
*** _erlon_ has joined #openstack-nova11:51
openstackgerritHamdy Khader proposed openstack/os-vif master: OVS DPDK port representors support  https://review.opendev.org/65878611:58
*** kaiokmo has quit IRC12:00
*** priteau has quit IRC12:01
*** priteau has joined #openstack-nova12:05
*** rcernin has quit IRC12:10
openstackgerritLee Yarwood proposed openstack/nova master: block_device: Optionally recreate attachments when refreshing connection_info  https://review.opendev.org/57900412:17
*** niceplace has quit IRC12:26
*** niceplace has joined #openstack-nova12:29
*** guozijn has quit IRC12:34
*** guozijn has joined #openstack-nova12:35
*** priteau has quit IRC12:36
*** tbachman has joined #openstack-nova12:49
*** jaypipes has joined #openstack-nova12:54
efriedgibi: reading...12:55
efriedgibi: This second use case...12:58
efriedSo if I had a pre-Stein instance with bandwidth request, it didn't have any bandwidth allocated in placement. Once this is implemented, I can fix up that instance, giving it appropriate allocations, by migrating it.12:59
efrieddo I have that right?12:59
*** priteau has joined #openstack-nova13:00
*** lbragstad has joined #openstack-nova13:02
*** cdent has joined #openstack-nova13:02
*** mriedem has joined #openstack-nova13:02
*** eharney has joined #openstack-nova13:05
sean-k-mooneypresumable a rebuild could fix it too?13:06
sean-k-mooneybut a migration or resize would be the more general case13:06
efriedsean-k-mooney: This spec gel for you?13:07
efriedhttps://review.opendev.org/#/c/652608/13:07
efriedyou had some earlier reviews, but no votes13:07
sean-k-mooneyi kind of lost track of it. but ill review it now13:08
sean-k-mooneyat this point its proably fine13:08
efriedthanks13:09
gibiefried: yes, migration will heal the allocation on the target host13:09
efriedthanks13:09
gibiefried: sometimes there is no way to heal the allocation locally13:10
efriedThe spec looks fine to me, though I only superficially understand some of the mechanics involved, so I'll wait for sean-k-mooney's nod, then I'll approve.13:10
gibiefried: e.g. resource is overallocated as there was no nova support to keep it in sync13:10
*** brinzhang has quit IRC13:10
efriedright, that makes sense. So the CLI will fail?13:10
gibiefried: yes the heal_allocation CLI could fail due to overallocation13:11
gibias placement would reject the new allocation being created13:11
efriedyup, I get it.13:11
efriedAnd the overallocation was possible because nobody anywhere was tracking bw quantities13:12
shilpasdefried: Hi, need discussion regarding 'forbidden aggregate specs'13:12
openstackgerritMerged openstack/nova stable/rocky: Fix retry of instance_update_and_get_original  https://review.opendev.org/65931813:12
efriedshilpasd: Sure, what's up?13:12
shilpasdhere at https://review.opendev.org/#/c/609960/8/specs/train/approved/placement-req-filter-forbidden-aggregates.rst@20313:12
efriedshilpasd: Are you implementing it?13:12
shilpasdyes13:12
gibiefried: yes, there was no resource tracking13:12
shilpasdefried: We have added code to sync traits set on aggregates for command "nova-manage placement sync_aggregates".13:13
efriedokay13:14
shilpasdefried: further observed that 'syncing of traits set on aggregate is required for the other scenarios' like aggregate-create/delete/aggregate-remove-host/aggregate-set-metadata13:15
efriedyes, that makes sense to me.13:15
efriedthough I'm not sure what we should do on delete or remove-host ...13:15
efriedperhaps we need a --flush-traits option of some sort, so the admin can choose.13:16
shilpasdefried: for delete, will remove entry from placement.placement_aggregates and for remove-host will remove host association from aggragte13:17
efriedright, but the question is whether you should remove the aggregate's listed traits from the compute node resource providers in that aggregate13:17
efriedanswer is probably: "it depends" :\13:18
sean-k-mooneyefried: gibi three minor nits but yep that looks good to me13:18
efriedshilpasd: This would probably be a good topic for the ML.13:19
efriedgibi: I +2ed. The spelling nits probably aren't worth fixing, want me to merge?13:19
sean-k-mooneyi would eihter fix them and fast approve or just merge it as the content is correct modulo a few typos13:21
openstackgerritMatt Riedemann proposed openstack/nova master: Add heal_instance_mappings command  https://review.opendev.org/65590813:22
gibiefried: merge it please13:22
gibithanks13:22
efriedgibi: done13:23
*** priteau has quit IRC13:23
gibiawesome13:23
*** pcaruana has quit IRC13:23
efriedshilpasd: I suppose another option is to namespace the traits to be used for this feature.13:23
efriedshilpasd: e.g. if trait name contains '_AGGREGATE_ISOLATION_', automatically remove it when the agg is deleted or the host is removed. (Unless of course the host belongs to *another* aggregate which still has that trait...)13:24
efriedgibi: assume this is for train, yah?13:26
efried(gibi: I'm doing the bp paperwork)13:26
gibiefried: yes, it is for train13:26
efriedk13:26
gibiI have couple of patches up already but more work is needed there which i will do in the coming days weeks13:26
efriedgibi: are the patches tracked against this bp? The "Implementation" is not showing as started.13:29
gibiefried: I guess the bp rename did not helped13:29
shilpasdefried: aggregate can have any trait and that we need to be sync with placement, irrespective of namespace, right?13:29
*** mgariepy has quit IRC13:29
gibiefried: let me fix it13:29
efried(I could go look, but I'm being lazy, aka doing a bunch of other things at the same time)13:29
efriedshilpasd: When you create an aggregate or add a host, I would say yes, you should add all the traits.13:30
efriedshilpasd: I'm just trying to come up with a way to handle *deletion*.13:30
shilpasdefried: understood, okay13:30
efriedshilpasd: For example, if you're creating an aggregate to isolate your hosts that have HW_CPU_X86_AVX, it makes zero sense to remove that trait if you destroy that aggregate.13:30
gibiefried: I guess the implementation status will be updated if I push a new patch up targeting the renamed bp13:30
efriedgibi: yeah, it's totally no big deal, I really don't care, just happened to notice.13:31
gibiefried: but the patches are here https://review.opendev.org/#/q/topic:bp/support-move-ops-with-qos-ports+(status:open+OR+status:merged)13:31
gibiefried: ack13:31
*** BjoernT has joined #openstack-nova13:31
efriedshilpasd: And in fact that trait would be reasserted on the host the next time the periodics run13:31
efriedshilpasd: ...but that is definitely not a behavior we should rely on to "heal" such traits.13:32
openstackgerritMatt Riedemann proposed openstack/nova master: Change InstanceFaultRollback handling in _error_out_instance_on_exception  https://review.opendev.org/63321213:33
openstackgerritMatt Riedemann proposed openstack/nova master: Raise InstanceFaultRollback for UnableToMigrateToSelf from _prep_resize  https://review.opendev.org/63322713:33
shilpasdefried: ML is good suggestion to brain storm this, will generate the same, thanks13:35
openstackgerritMerged openstack/nova-specs master: Server move operations with ports having resource request  https://review.opendev.org/65260813:35
efriedshilpasd: Cool. To summarize the alternatives we've come up with so far, on delete/remove type operations, we could:13:36
efried- Leave all traits alone. If they need to be removed, it would have to be manually via a separate step.13:36
efried- Support a new option so the caller can dictate whether the operation should remove the traits. (This is all-or-none.)13:36
efried- Define a "namespace" - a trait substring - and remove only traits in that namespace.13:36
efriedshilpasd: ...but on create/add type operations, I think we should always add the traits to the hosts.13:36
*** spatel has joined #openstack-nova13:38
*** spatel has quit IRC13:42
*** BjoernT_ has joined #openstack-nova13:43
shilpasdefried: clear, thanks13:45
*** artom has quit IRC13:46
*** BjoernT has quit IRC13:46
*** pcaruana has joined #openstack-nova13:47
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: Fix the server group "policy" field type in api-ref  https://review.opendev.org/66222413:55
mriedemgibi: on https://review.opendev.org/#/c/512623/ i guess you re-ordered the series so the functional test, which depends on the fake driver global conf changes, could just be on master and the bug fix can be backported, is that right?13:58
gibimriedem: yes. lyarwood convinced me that it is better that way13:58
*** cmart has joined #openstack-nova13:59
gibimriedem: this means no functional re-create and functional coverage on stable branches13:59
mriedemi was hoping we could get the functional test backported as well so that's why i was pushing on slimming down the fake driver stuff, but alas i guess it wasn't possible13:59
mriedemif we're good on master i think that's sufficient13:59
gibimriedem: it was hairy due to the fake driver stuff13:59
mriedemthat's a lot better than a lot of bug fixes we've had in the past which are just unit test coverage13:59
efriednova meeting now14:00
mriedemspeaking of functional regression recreate tests https://review.opendev.org/#/c/661822/14:00
mriedemi could use some eyes on that since it's going all the way back to ocata14:00
gibimriedem: added it to my queue14:01
mriedemthanks14:01
gibimriedem: btw, I'm reading your cross-cell resize review guide and I have to tell it helps me a lot. thanks for writing that up14:02
mriedemgibi: thanks, i was about to ask if anyone had actually read it14:03
efriedmriedem: I fully intend to, if I ever get around to reviewing that series.14:03
efriedI've been kinda hoping others would have approved it by the time I got around to it.14:04
*** luksky has joined #openstack-nova14:09
openstackgerritAdrian Chiris proposed openstack/nova stable/queens: Move get_pci_mapping_for_migration to MigrationContext  https://review.opendev.org/66157114:11
openstackgerritAdrian Chiris proposed openstack/nova stable/queens: Allow driver to properly unplug VIFs on destination on confirm resize  https://review.opendev.org/66157214:11
sean-k-mooneyoh ^ are backports. i was confused as i had thought it had merged on master14:18
sean-k-mooneyalso nova team meeting is not right14:19
*** amodi has joined #openstack-nova14:23
*** sridharg has quit IRC14:25
*** JamesBenson has joined #openstack-nova14:26
*** sridharg has joined #openstack-nova14:26
*** mlavalle has joined #openstack-nova14:26
*** dpawlik has quit IRC14:29
*** helenafm has quit IRC14:34
gmannjohnthetubaguy: on policy spec- base defined role mapping to check_str is enough or you want complete list of policy and their propoed check_str ?14:39
mriedemadrianc_: do you care about this old bug fix? https://review.opendev.org/#/c/361438 if so please ack on it that you'll take it over otherwise i'm going to abandon it14:47
mriedemstarlingx probably cares as well but cfriesen isn't around to ask14:47
*** itlinux has quit IRC14:48
johnthetubaguygmann: I was thinking just the base, as examples, maybe add in keypairs too, but the rest we meet those problems as we hit them?14:50
johnthetubaguygmann: do you think my suggestion works, with changing the base rule based on that config?14:50
gmannjohnthetubaguy: +1 on base rule details i will add those.14:51
efriedmriedem: dtroyer might be able to answer starlingx care-about questions.14:51
gmannjohnthetubaguy: but till enforce_scope is false, scope_type will not have any effect so out old deprecated rule with old roles will work fine right ?14:52
gmanni forgot to reply config things on gerrit.14:52
cdentoh I had an open an missed it, but it's mostly directed at mriedem14:53
*** ricolin has joined #openstack-nova14:53
mriedemf i suppose they have an irc channel14:53
johnthetubaguygood question... its more than enforce_scope isn't enough, because its basically system or project for almost anything14:53
cdentyou remember a couple weeks ago when 10,000 allocation candidates was around 36 seconds? it's down to 6 now after "various changes"14:53
cdentso that's like a14:53
efried\o/14:53
johnthetubaguygmann: if we add the scope check in the rule by default all the time, boom, all current admins are busted14:53
cdent#success 10000 allocation candidates got faster14:54
openstackstatuscdent: Added success to Success page (https://wiki.openstack.org/wiki/Successes)14:54
johnthetubaguycdent: nice job14:54
gmannjohnthetubaguy: we will keep old check_str as deprecated rule , for example: https://review.opendev.org/#/c/645427/5/nova/policies/services.py14:54
sean-k-mooneycdent: just faster in aggreate or was there one change in partcalar that stood out14:54
gmann^^ above patch was for granular change but it can be same for  check_str change also14:54
*** cfriesen has joined #openstack-nova14:55
sean-k-mooneybut also cool14:55
mriedemcdent: cool14:55
cdentsean-k-mooney: i'll take the details to the placement channel14:55
* johnthetubaguy still likes the idea of multiple placements in a single region, using some sharding method14:56
*** lpetrut has quit IRC14:57
*** imacdonn has quit IRC14:58
gmannjohnthetubaguy: i mean old rule(check_str without scope string) will keep working because we will keep them as deprecated rule.  For example, current admin role (without scope thing) will be able to access the host APIs.14:59
*** artom has joined #openstack-nova15:01
johnthetubaguygmann: ah, so we are going to do the deprecated check_str idea... i forgot about that, carry on :)15:01
*** guozijn has quit IRC15:02
gmannjohnthetubaguy: yeah, i will add those detail in spec tomorrow if deprecated check_str solve all issue. as we are not going to do name change things it will be easy for us to do migration.15:03
johnthetubaguygmann: +115:03
artomefried, so I read the email, IIUC the current plan is to not have can_split, and just have some nodes expose NUMA and some nodes not expose NUMA15:03
artomNUMA instances can go on the former, non-NUMA on the latter15:03
artomIs that the tl'dr?15:03
*** takashin has left #openstack-nova15:04
mriedemlyarwood: i just abandoned this swap volume related bug fix but you might want to check it out https://review.opendev.org/#/c/300616/15:04
mriedemto see if it's still valid15:04
adrianc_mriedem: regarding https://review.opendev.org/#/c/361468, can be abandoned IMO.15:04
mriedemadrianc_: i'm assuming you mean the nova change right?15:05
mriedemhttps://review.opendev.org/#/c/36143815:05
lyarwoodmriedem: ack thanks for the pointer15:06
adrianc_yea15:06
mriedemadrianc_: ok any particular reason why? is it no longer valid?15:06
mriedemb/c the bug is still open15:06
*** tstrul has quit IRC15:06
*** zbr_ has joined #openstack-nova15:07
efriedartom: yup, that's it15:07
efriedartom: the only reason we would have needed can_split is so we could put non-NUMA VMs onto hosts whose RPs were modeled as NUMA-aware trees.15:08
adrianc_mriedem: well, i would expect SR-IOV to be used and not a direct physical port.15:08
mriedemartom: efried: the big problem with that is going to be really small deployments that can't split that way right?15:08
mriedemi.e. an edge site with 1 compute node15:08
mriedemessentially the virtual (shared) and dedicated physical cpu problem15:08
artomefried, mriedem, also the fact that hugepages and CPU pinning currently add an implicit NUMA topology15:09
mriedemon the same host i mean15:09
*** zbr has quit IRC15:09
adrianc_mriedem: i.e direct port and not direct-physical. while the bug is still valid, im not too sure its really stepping on too many toes. (at least not form mellanox side :) )15:09
artomSo all those instances suddenly won't be able to go on "flat" nodes15:09
efriedyup, what we need to hear is whether that's going to be a show-stopping issue for anyone.15:09
mriedemok, probably need to ask dansmith re edge15:09
* efried <== chauffeur duty, bbiab15:09
mriedemnot sure if he's back today or not15:10
mriedemadrianc_: ok i'll mark as low priority then, thanks15:10
mriedem*severity15:10
adrianc_mriedem: np15:10
mriedemok top 3 changes on http://status.openstack.org/reviews/#nova have been abandoned15:11
mriedemnow i'm done for 3 weeks15:11
openstackgerritMerged openstack/nova stable/queens: [stable-only] Delete allocations even if _confirm_resize raises (part 2)  https://review.opendev.org/66134915:14
adrianc_stephenfin: any chance to get some attention on the FUP : https://review.opendev.org/#/c/659101 :)15:14
openstackgerritLee Yarwood proposed openstack/nova master: WIP/DNM libvirt: flatten rbd volumes when unshelving an instance  https://review.opendev.org/45788615:20
openstackgerritMatt Riedemann proposed openstack/nova master: Add validation for cpu_realtime_mask  https://review.opendev.org/46820315:20
mriedemanother old ass change ^15:20
mriedemcfriesen: ^15:20
mriedemcfriesen: do you still want/need that change?15:21
lyarwoodmelwitt / mdbooth ; ^ kicked the rbd unshelve bugfix again, using vm_state this time as suggested. I'll sort tests out later.15:21
mriedemsean-k-mooney: did a neutron docs patch ever happen for the sriov live migration support?15:21
melwittlyarwood: ack15:21
sean-k-mooneymriedem: not yet but it is still planned. e.g. i just finsihed working on a spec and its next on my list15:22
cfriesenmriedem: I think the last comment there from stephenfin was that with the eventual changes for cpu resources in placement that change would be irrelevent.15:22
mriedemcfriesen: ok so in 3 years to never15:22
mriedemcfriesen: if we don't care about it let's just abandon it15:23
cfriesenpretty much.  I didn't care enough to keep pushing.15:23
cfriesenwas just a robustness thing15:23
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional test for two-cell scheduler behaviors  https://review.opendev.org/45200615:24
*** guozijn has joined #openstack-nova15:24
mriedemcfriesen: ok please abandon if you're not going to update it15:24
cfriesendone15:26
mriedemthanks15:26
*** gyee has joined #openstack-nova15:28
*** macza has joined #openstack-nova15:31
*** pcaruana has quit IRC15:33
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional test for two-cell scheduler behaviors  https://review.opendev.org/45200615:34
mriedemhella old review ^ now cleaned up and passing15:34
mriedemgets it off the nova reviews list15:35
*** luksky has quit IRC15:41
*** maciejjozefczyk has quit IRC15:45
*** itlinux has joined #openstack-nova15:45
melwittefried: re: zuul slow queue time, my guess for the behavior is because of the way zuul prioritizes patches http://lists.openstack.org/pipermail/openstack-discuss/2018-December/000482.html vs the number of nova patches that are in a pipeline. the reason I think this is because recently I pushed a devstack patch and it began running on a node within 15 minutes. whereas my nova patches wait a minimum of 2 hours15:53
efriedmelwitt: Interesting...15:56
sean-k-mooneymelwitt: ya that has chagned a few times we have gone back and forth16:00
openstackgerritMatt Riedemann proposed openstack/nova master: Remove zeromq from getting started with compute docs  https://review.opendev.org/58192616:00
mriedemsuper old trivial docs fix i cleaned up ^16:00
sean-k-mooneyi think the current apprch is intended to give smaller projectes equal change for running as nova but since we have a logner queue it takes longer for  our jobs to start16:01
sean-k-mooneyor put another way to prevent tripplo jobs consome all for the capsity16:02
*** JamesBenson has quit IRC16:11
*** mgariepy has joined #openstack-nova16:24
sean-k-mooneyefried: good spot on the pmu spec ill fix that shortly also i need to fix the typo stephen noted :)16:25
efriedsean-k-mooney: cool, I wasn't actually even sure if that one was a go at all, since it looked like stephenfin was pretty down on it :P16:26
mriedemgmann: if you clean this up i'll fast approve it https://review.opendev.org/#/c/603969/1616:26
sean-k-mooneywell he was basically saying can we just always to it for realtime guest uncondtionally16:26
gmannmriedem: thanks, doing it16:27
sean-k-mooneyi still think it good to allow a choice but if that is what peopel prefer that is fine with me16:27
sean-k-mooneyour realtime folks say they need this so if it only works for realtime it still works for them16:27
sean-k-mooneyalso i did  not know there was a path filtering option in gerrit16:29
*** luksky has joined #openstack-nova16:33
*** ccamacho has joined #openstack-nova16:36
efriedmriedem: Mind doing a quick +2W on this trivial spec update? https://review.opendev.org/#/c/652101/16:39
openstackgerritMatt Riedemann proposed openstack/nova master: Drop pre-cinder 3.44 version compatibility  https://review.opendev.org/62106116:39
mriedemi never reviewed the original16:39
mriedemmaybe i didn't need to16:40
openstackgerritGhanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup  https://review.opendev.org/60396916:40
gmannmriedem: ^^16:40
sean-k-mooneymriedem: the update is fixing typos/rendering issue in my original spec16:40
sean-k-mooneymriedem: the content is still the same.16:41
sean-k-mooney.. the more i use emacs the more reason i have not to use emacs16:42
*** ivve has quit IRC16:43
*** mgoddard has quit IRC16:44
*** cdent has quit IRC16:45
mriedemgmann: approved16:46
gmannmriedem: thanks16:46
*** mgoddard has joined #openstack-nova16:46
mriedemefried: approved16:47
efriedthanks mriedem16:48
*** lpetrut has joined #openstack-nova16:48
openstackgerritMatt Riedemann proposed openstack/os-vif stable/queens: Prevent "qbr" Linux Bridge from replying to ARP messages  https://review.opendev.org/65569416:50
openstackgerritsean mooney proposed openstack/nova-specs master: add libvirt pqos spec  https://review.opendev.org/66226416:50
sean-k-mooneyalex_xu: ^ is the static cache alocation spec16:51
sean-k-mooneyand now that thats done  ill do the neutron docs change for sriov then update pmu spec16:53
*** ivve has joined #openstack-nova16:58
*** mgoddard has quit IRC17:00
openstackgerritMerged openstack/nova-specs master: Updates to image-metadata-prefiltering spec  https://review.opendev.org/65210117:00
*** derekh has quit IRC17:01
*** mgoddard has joined #openstack-nova17:02
*** guozijn has quit IRC17:09
openstackgerritMerged openstack/nova-specs master: Spec for API inconsistency cleanup  https://review.opendev.org/60396917:20
*** ociuhandu has quit IRC17:37
*** ricolin has quit IRC17:42
openstackgerritMerged openstack/nova master: Blacklist python-cinderclient 4.0.0  https://review.opendev.org/66157817:47
openstackgerritMerged openstack/nova master: Block swap volume on volumes with >1 rw attachment  https://review.opendev.org/57279017:47
*** sridharg has quit IRC17:48
sean-k-mooneymriedem: this is the docs update for sriov migration in neutron https://review.opendev.org/#/c/662275/17:56
sean-k-mooneymriedem: i proably have typos but ill let you know when its merged so we can mark the blueprint as complete17:56
mriedemsean-k-mooney: i left a question in there17:58
sean-k-mooneyits more a best practice or for telcos where the user is the admin17:59
mriedemok that's what i figured18:00
sean-k-mooneythere is some work to in qemu and the kernel to create a live migrateable replacement for sriov but its not really ready yet18:01
sean-k-mooneyintel have demoed but notre release vhost-vfio that uses mdevs like the vgpu stuff and thre is also a virtio-net failover feature in qemu but i dont think that works yet either18:03
*** mlavalle has quit IRC18:07
mriedemmelwitt: comments inline on https://review.opendev.org/#/c/638324/18:16
*** jdillaman has quit IRC18:22
*** jdillaman has joined #openstack-nova18:23
*** pcaruana has joined #openstack-nova18:24
*** bbowen has quit IRC18:26
*** bbowen has joined #openstack-nova18:26
*** tstrul has joined #openstack-nova18:30
openstackgerritMerged openstack/nova master: Add BFV wrinkle to TestNovaManagePlacementHealAllocations  https://review.opendev.org/65194818:32
openstackgerritMerged openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8)  https://review.opendev.org/57531118:32
openstackgerritMerged openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9)  https://review.opendev.org/57558118:33
openstackgerritMerged openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10)  https://review.opendev.org/57601718:33
openstackgerritMerged openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11)  https://review.opendev.org/57601818:33
openstackgerritMerged openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12)  https://review.opendev.org/57601918:33
openstackgerritMerged openstack/nova stable/queens: Add functional confirm_migration_error test  https://review.opendev.org/65813618:33
mriedemganso: as noted in https://bugs.launchpad.net/nova/+bug/1821594 i'm not going to try working on fixing that in pike18:35
openstackLaunchpad bug 1821594 in OpenStack Compute (nova) pike "Error in confirm_migration leaves stale allocations and 'confirming' migration state" [Medium,Triaged]18:35
mriedemare you ok with that? if so i'll mark pike as won't fix in the bug18:35
gansomriedem: yea mriedem I am ok! thank you for everything Matt! =)18:36
openstackgerritMatt Riedemann proposed openstack/nova master: Handle missing RequestSpec.instance_group.uuid on load  https://review.opendev.org/66178618:38
mriedemganso: np, and thank you for helping with it (and noticing it wasn't fixed in queens/rocky)18:38
mriedemsean-k-mooney: any idea when sylvain is back?18:39
*** hongbin has joined #openstack-nova18:40
*** JamesBenson has joined #openstack-nova18:43
mriedemhmm i can't get to cloudbase hyperv ci logs on a recent run18:47
mriedemlpetrut: ^18:47
mriedemlpetrut: i can't access any of the hyperv ci logs on https://review.opendev.org/#/c/661786/ - getting 404s18:48
*** JamesBenson has quit IRC18:48
*** cmart has quit IRC18:50
openstackgerritMatt Riedemann proposed openstack/nova master: xenapi: log quality warning in init_host  https://review.opendev.org/66229518:57
mriedemefried: johnthetubaguy: here is the xenapi driver quality warning patch ^ i'll also post to the ML about it18:57
*** bbowen has quit IRC18:57
sean-k-mooneyshould we follow the same patteren for the other backends we indicated we shoudl deprecate18:59
sean-k-mooneymriedem: e.g. should i add a version of that warning for the libvirt/lxc backend18:59
mriedemsean-k-mooney: you mean libvirt/!(qemu)?19:01
mriedemi don't really want to open that can of worms right now, but the libvirt driver has a bunch of non-qemu shit that's not tested19:02
sean-k-mooneywell virtozo still have a ci19:02
sean-k-mooneyat the ptg we said we should deprecate them19:02
sean-k-mooneybut im fine with leaving it for now too19:03
sean-k-mooneynot remove im in train but if not ci by U then remove them19:03
mriedemthe vz ci is busted b/c https://review.opendev.org/#/c/506686/ won't merge19:04
mriedemhttp://openstack-3rd-party-virtuozzo-ci-logs.virtuozzo.com/24/638324/30/check/check-dsvm-tempest-vz7-exe-minimal/620b3db/console.html.gz19:04
mriedem2019-05-24 02:17:01.109 | + :pre_test_hook:L14:   git cherry-pick FETCH_HEAD 2019-05-24 02:17:01.311 | error: could not apply 789a1f2... don't add device address if there is no any units 2019-05-24 02:17:01.313 | hint: after resolving the conflicts, mark the corrected paths 2019-05-24 02:17:01.315 | hint: with 'git add <paths>' or 'git rm <paths>' 2019-05-24 02:17:01.318 | hint: and commit the result with 'git commit'19:04
sean-k-mooneymriedem: oh ok19:04
sean-k-mooneywell in anycase we could wait or we could add warning for all those that are not tested in train and see if anyone shouts19:05
sean-k-mooneyi still vaguly plan to fix the mount issue for libvirt lxc but its a supper low priority at the moment19:05
mriedemi don't really care if we remove libvirt+lxc, it hasn't worked in forever as far as i know19:06
mriedemi couldn't get ci working for it either19:07
mriedemhttps://docs.openstack.org/nova/latest/configuration/config.html#libvirt.virt_type19:07
sean-k-mooneyill try and find time between now and m2 to either fix the mount issue so it can actully be used or submit a patch to remove it since its been broken for 2 years19:08
mriedemlxc, uml and xen could probably all be deprecated from that list19:08
sean-k-mooneyyep19:08
mriedemwe can't remove those without deprecating them first19:08
sean-k-mooney your right19:08
sean-k-mooneyill either fix it or add a deprecation warning19:09
sean-k-mooneyi always liked lxc but if noone uses it and its broken then it would be nice to clean it up19:10
sean-k-mooneythat said with stephen deleteing nova network, nova-consoleauth and cells v1 this cycle this cycle that is likely enought for one release :)19:11
lpetrutmriedem: thanks for letting me know, I'll look into it19:15
mriedemlpetrut: thanks19:15
*** imacdonn has joined #openstack-nova19:17
*** jdillaman has quit IRC19:18
*** tstrul has quit IRC19:18
mriedemspeaking of deleting stuff, we should delete this old online data migration https://review.opendev.org/#/c/651001/19:19
mriedemand start working on dropping the pike-era data migrations19:20
efriedthanks mriedem (re xen)19:28
*** tstrul has joined #openstack-nova19:31
*** igordc has joined #openstack-nova19:49
*** igordc has quit IRC19:50
*** tstrul has quit IRC19:53
*** JamesBenson has joined #openstack-nova19:55
*** JamesBenson has quit IRC19:55
*** cmart has joined #openstack-nova19:56
*** JamesBenson has joined #openstack-nova19:56
*** lpetrut has quit IRC19:57
*** igordc has joined #openstack-nova20:00
*** bbowen has joined #openstack-nova20:01
*** factor has quit IRC20:14
lyarwoodmriedem: https://review.opendev.org/#/c/572790/ - Do you have bandwidth to backport this to stable/queens? Happy to do it if you don't, just wanted to asked first.20:29
lyarwoodand assuming you even think that's a good idea.20:31
*** xek_ has quit IRC20:34
mriedemi can...20:35
mriedemi think we can, i originally had the bug marked as backport to queens and then a year went by20:36
mriedemwill do that in a bit20:36
lyarwoodmriedem: cool thanks! I'll review stable/stein in the morning to get things moving.20:37
* lyarwood heads offline20:37
openstackgerritMerged openstack/nova master: Add get_usages_counts_for_quota to SchedulerReportClient  https://review.opendev.org/65314520:39
openstackgerritMerged openstack/nova master: Count instances from mappings and cores/ram from placement  https://review.opendev.org/63807320:39
openstackgerritMerged openstack/nova master: Set [quota]count_usage_from_placement = True in nova-next  https://review.opendev.org/65314620:39
*** _alastor_ has quit IRC20:41
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Optimize creating servers with tags  https://review.opendev.org/48417020:53
*** artom has quit IRC20:59
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: Block swap volume on volumes with >1 rw attachment  https://review.opendev.org/66233120:59
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Block swap volume on volumes with >1 rw attachment  https://review.opendev.org/66233321:14
*** pcaruana has quit IRC21:18
*** itlinux has quit IRC21:23
*** whoami-rajat has quit IRC21:24
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Block swap volume on volumes with >1 rw attachment  https://review.opendev.org/66233321:25
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Block swap volume on volumes with >1 rw attachment  https://review.opendev.org/66234021:30
*** tbachman has quit IRC21:41
*** takashin has joined #openstack-nova21:45
openstackgerritEric Fried proposed openstack/os-traits master: Create traits for NUMA & device subtree affinity  https://review.opendev.org/65789821:45
*** aram1s has joined #openstack-nova21:47
aram1shello! has anyone seen this error before: CantRemoveHost: Can’t remove host(s) [u'313c9b24-16f0-4b06-b862-62727288f358'] from Aggregate <Aggregate: 1>"21:48
aram1sthe hosts won't come out of our freepool21:48
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional test for two-cell scheduler behaviors  https://review.opendev.org/45200621:49
mriedemaram1s: that looks like a blazar specific error, not nova http://codesearch.openstack.org/?q=CantRemoveHost&i=nope&files=&repos=21:49
mriedemso you'd have to ask the blazar devs, or check the nova api logs to see if there is a related failure there21:50
*** tbachman has joined #openstack-nova21:50
aram1sthank you21:50
aram1s(i did not see anything else in nova-api)21:51
openstackgerritMerged openstack/nova master: [ironic] Don't remove instance info twice in destroy  https://review.opendev.org/65980921:59
*** _alastor_ has joined #openstack-nova21:59
openstackgerritEric Fried proposed openstack/os-traits master: Create traits for NUMA & device subtree affinity  https://review.opendev.org/65789822:00
*** JamesBenson has quit IRC22:02
*** mlavalle has joined #openstack-nova22:02
mriedemstephenfin: i'm not sure why you don't just remove the exception in https://review.opendev.org/#/c/651307/ since nothing else is using it, and i don't see any change later in the series that actually removes the exception, but hopefully you'll remember to do that22:10
*** aram1s has quit IRC22:11
*** luksky has quit IRC22:16
*** efried1 has joined #openstack-nova22:19
*** efried has quit IRC22:20
*** efried1 is now known as efried22:20
mriedemjaypipes: DROP COLUMN on a big ass instances table could take "awhile" yeah? https://review.opendev.org/#/c/651309/9/nova/db/sqlalchemy/models.py@34322:23
mriedemzzzeek: ^22:26
*** _alastor_ has quit IRC22:27
*** mriedem is now known as mriedem_away22:35
*** _alastor_ has joined #openstack-nova22:36
*** _alastor1 has joined #openstack-nova22:41
*** _alastor_ has quit IRC22:41
*** _alastor1 has quit IRC22:41
*** itlinux has joined #openstack-nova22:42
*** ccamacho has quit IRC22:47
*** ccamacho has joined #openstack-nova22:47
*** macza has quit IRC22:52
*** BjoernT_ has quit IRC22:56
*** JamesBenson has joined #openstack-nova23:03
*** tkajinam has joined #openstack-nova23:05
openstackgerritEric Fried proposed openstack/nova master: Bump openstackdocstheme to 1.30.0  https://review.opendev.org/66235323:06
*** JamesBenson has quit IRC23:07
openstackgerritEric Fried proposed openstack/nova-specs master: Bump openstackdocstheme to 1.30.0  https://review.opendev.org/66235423:07
*** mlavalle has quit IRC23:16
*** rcernin has joined #openstack-nova23:17
*** panda|ruck has quit IRC23:22
*** panda has joined #openstack-nova23:23
openstackgerritMerged openstack/nova master: Remove unused param from _fill_provider_mapping  https://review.opendev.org/65510723:25
*** cmart has quit IRC23:25
*** stakeda has joined #openstack-nova23:27
*** pmannidi has joined #openstack-nova23:27
openstackgerritMerged openstack/nova master: Remove zeromq from getting started with compute docs  https://review.opendev.org/58192623:42
*** hongbin has quit IRC23:46
*** artom has joined #openstack-nova23:48
*** tjgresha has joined #openstack-nova23:50
*** tjgresha has quit IRC23:55
*** tjgresha has joined #openstack-nova23:55
« Wednesday, 2019-05-29 Index Friday, 2019-05-31 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!