Wednesday, 2019-06-05

*** hamzy has joined #openstack-nova00:02
*** slaweq has quit IRC00:03
*** itlinux_ has quit IRC00:04
*** artom has joined #openstack-nova00:05
*** sapd1_x has joined #openstack-nova00:05
openstackgerritMerged openstack/python-novaclient master: Blacklist python-cinderclient 4.0.0  https://review.opendev.org/66291200:08
*** tbachman has joined #openstack-nova00:13
*** slaweq has joined #openstack-nova00:23
*** brinzhang has joined #openstack-nova00:26
openstackgerritTakashi NATSUME proposed openstack/nova master: Replace 'is comprised of' with 'comprises'  https://review.opendev.org/66317500:26
*** mriedem_away has quit IRC00:30
*** slaweq has quit IRC00:33
*** sapd1_x has quit IRC00:35
openstackgerritBrin Zhang proposed openstack/nova stable/rocky: Replace the invalid index of nova-rocky releasenote  https://review.opendev.org/66317800:37
*** cmart has quit IRC00:41
*** brault has joined #openstack-nova00:44
*** brault has quit IRC00:49
*** slaweq has joined #openstack-nova00:51
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove unnecessary setUp methods  https://review.opendev.org/66317900:59
alex_xuThe vPMEM spec is ready for review https://review.opendev.org/#/c/601596/, in case of anyone still at the day of spec review day~01:01
*** slaweq has quit IRC01:03
*** spsurya has joined #openstack-nova01:18
*** guozijn has joined #openstack-nova01:20
*** slaweq has joined #openstack-nova01:21
*** boxiang has quit IRC01:26
*** boxiang has joined #openstack-nova01:27
*** Sundar has quit IRC01:30
*** slaweq has quit IRC01:33
*** claudiub has quit IRC01:36
*** guozijn has quit IRC01:37
*** hongbin has joined #openstack-nova01:47
openstackgerritya.wang proposed openstack/nova-specs master: Add spec for expose-auto-converge-post-copy  https://review.opendev.org/65168101:52
*** slaweq has joined #openstack-nova01:54
*** Sundar has joined #openstack-nova01:56
*** Sundar has quit IRC02:03
*** slaweq has quit IRC02:03
*** lbragstad has quit IRC02:14
*** slaweq has joined #openstack-nova02:14
*** boxiang_ has joined #openstack-nova02:16
*** BjoernT has joined #openstack-nova02:17
*** boxiang has quit IRC02:18
*** tbachman has quit IRC02:18
*** tbachman has joined #openstack-nova02:19
*** slaweq has quit IRC02:25
*** itlinux has joined #openstack-nova02:27
*** Dinesh_Bhor has quit IRC02:37
*** slaweq has joined #openstack-nova02:41
*** minmin has joined #openstack-nova02:42
*** abhishekk has joined #openstack-nova02:43
*** slaweq has quit IRC02:54
*** markvoelker has joined #openstack-nova02:59
*** abhishekk has quit IRC03:13
*** slaweq has joined #openstack-nova03:15
*** Dinesh_Bhor has joined #openstack-nova03:19
*** slaweq has quit IRC03:26
*** markvoelker has quit IRC03:30
*** slaweq has joined #openstack-nova03:42
*** guozijn has joined #openstack-nova03:50
*** hongbin has quit IRC03:52
*** slaweq has quit IRC03:55
*** ricolin has joined #openstack-nova03:58
*** gyee has quit IRC04:02
*** slaweq has joined #openstack-nova04:12
*** threestrands has joined #openstack-nova04:15
*** bnemec has quit IRC04:23
*** gmann has quit IRC04:23
*** slaweq has quit IRC04:25
*** bnemec has joined #openstack-nova04:25
*** markvoelker has joined #openstack-nova04:27
*** gmann has joined #openstack-nova04:27
*** pcaruana has joined #openstack-nova04:30
*** guozijn has quit IRC04:36
*** brinzhang has quit IRC04:44
*** brinzhang has joined #openstack-nova04:44
*** markvoelker has quit IRC05:00
*** takashin has left #openstack-nova05:00
*** tkajinam has quit IRC05:01
*** slaweq has joined #openstack-nova05:02
*** tkajinam has joined #openstack-nova05:03
*** itlinux has quit IRC05:22
*** frankwang has joined #openstack-nova05:27
*** damien_r has joined #openstack-nova05:28
*** tkajinam has quit IRC05:33
*** guozijn has joined #openstack-nova05:36
*** ivve has quit IRC05:46
*** sapd1 has joined #openstack-nova05:48
*** markvoelker has joined #openstack-nova05:56
*** luksky has joined #openstack-nova06:00
*** phasespace has quit IRC06:02
*** tkajinam has joined #openstack-nova06:03
*** minmin has quit IRC06:03
*** dpawlik has joined #openstack-nova06:10
*** maciejjozefczyk has joined #openstack-nova06:12
*** dpawlik has quit IRC06:15
*** minmin has joined #openstack-nova06:16
*** dpawlik has joined #openstack-nova06:22
*** markvoelker has quit IRC06:28
*** dtantsur|afk is now known as dtantsur\06:29
*** dtantsur\ is now known as dtantsur06:29
*** damien_r has quit IRC06:30
*** takamatsu has joined #openstack-nova06:32
*** aarents has joined #openstack-nova06:48
*** lpetrut has joined #openstack-nova06:58
*** liuyulong_ has joined #openstack-nova06:58
*** rcernin has quit IRC06:59
*** brault has joined #openstack-nova07:02
*** factor has joined #openstack-nova07:03
*** ivve has joined #openstack-nova07:04
*** minmin has quit IRC07:07
*** tssurya has joined #openstack-nova07:13
*** rpittau|afk is now known as rpittau07:14
openstackgerritMerged openstack/nova master: Make all functional tests reusable by other projects  https://review.opendev.org/65765907:20
*** aloga has quit IRC07:23
*** aloga has joined #openstack-nova07:23
*** tesseract has joined #openstack-nova07:25
*** liuyulong_ has quit IRC07:26
*** minmin has joined #openstack-nova07:27
*** ttsiouts has joined #openstack-nova07:27
*** damien_r has joined #openstack-nova07:28
*** minmin has quit IRC07:35
*** ttsiouts has quit IRC07:37
*** helenafm has joined #openstack-nova07:41
*** whoami-rajat has joined #openstack-nova07:45
*** ralonsoh has joined #openstack-nova07:51
*** ttsiouts has joined #openstack-nova08:02
*** tetsuro has joined #openstack-nova08:05
openstackgerritBoxiang Zhu proposed openstack/nova master: Validate requested host/node during servers create  https://review.opendev.org/66123708:08
openstackgerritBoxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server  https://review.opendev.org/64552008:08
*** xek has joined #openstack-nova08:09
*** panda|ruck has quit IRC08:14
openstackgerritBrin Zhang proposed openstack/nova-specs master: Specifying az when restore shelved server  https://review.opendev.org/62468908:14
*** derekh has joined #openstack-nova08:18
*** phasespace has joined #openstack-nova08:22
*** markvoelker has joined #openstack-nova08:26
*** BjoernT has quit IRC08:26
*** panda has joined #openstack-nova08:28
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using q35 machine type  https://review.opendev.org/66301108:33
openstackgerritLee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type  https://review.opendev.org/66288708:33
*** tkajinam has quit IRC08:37
*** threestrands has quit IRC08:39
*** tetsuro has quit IRC08:46
*** openstackgerrit has quit IRC08:47
*** panda is now known as panda|ruck08:52
*** openstackgerrit has joined #openstack-nova08:54
openstackgerritStephen Finucane proposed openstack/nova master: Ensure controllers all call super  https://review.opendev.org/66095008:54
stephenfinbauzas: Is this clear(er) now? https://review.opendev.org/#/c/660774/3/nova/compute/manager.py08:55
*** rcernin has joined #openstack-nova08:57
*** markvoelker has quit IRC08:59
openstackgerritBoxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server  https://review.opendev.org/64552009:01
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using q35 machine type  https://review.opendev.org/66301109:20
openstackgerritLee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type  https://review.opendev.org/66288709:20
*** priteau has joined #openstack-nova09:22
kashyaplyarwood: When you respin, an Ultra-OCD nit (please don't hate me) : s/q35/'q35'/ (or Q35).09:25
mdboothkashyap: We should put quotes round q35?09:38
kashyapmdbooth: Not "should", but just a literal of some kind to show that it is a tiny code fragment, if you're using lowercase09:38
mdbooth-EPARSE09:38
mdboothIs this in the context of lyarwood 's specific patch, or in general?09:39
kashyapIn general.09:40
mdboothkashyap: I agree with you: that's an Ultra-OCD nit ;)09:40
kashyapmdbooth: I was saying it in the commit message, not in the code -- sorry, I didn't made that clear09:40
kashyapYes, because consistency is better than inconsistency, harmony is better than chaos, etc :D09:41
kashyapI mention these (but never -1!) because "you play like you practise".09:42
lyarwoodkashyap: if I respin I'll change it to Q3509:43
kashyaplyarwood: Merci09:43
*** markvoelker has joined #openstack-nova09:57
openstackgerritBoxiang Zhu proposed openstack/nova master: Validate requested host/node during servers create  https://review.opendev.org/66123710:09
openstackgerritBoxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server  https://review.opendev.org/64552010:09
*** lpetrut has quit IRC10:09
*** boxiang_ has quit IRC10:10
*** boxiang has joined #openstack-nova10:10
*** frankwang has quit IRC10:13
*** ttsiouts has quit IRC10:15
*** ttsiouts has joined #openstack-nova10:16
*** ttsiouts has quit IRC10:20
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type  https://review.opendev.org/66301110:21
openstackgerritLee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type  https://review.opendev.org/66288710:21
*** lpetrut has joined #openstack-nova10:22
*** dave-mccowan has joined #openstack-nova10:26
*** markvoelker has quit IRC10:29
*** maciejjozefczyk_ has joined #openstack-nova10:30
*** maciejjozefczyk has quit IRC10:31
*** ivve has quit IRC10:31
openstackgerritJohn Garbutt proposed openstack/nova-specs master: Add Unified Limits Spec  https://review.opendev.org/60220110:32
*** ivve has joined #openstack-nova10:33
mdboothlyarwood: FYI you can just recheck the DNM tempest change10:35
mdboothErr, no you can't. Thought you were using Depends-On.10:35
sean-k-mooneyhehe if its not using Depends-On currently adding it should rerun it right :)10:36
mdboothsean-k-mooney: Can you Depends-On another change in the same repo? It would be really convenient if you could.10:36
sean-k-mooneyoh the tempest change is no10:36
sean-k-mooneynova10:36
mdboothkashyap: https://review.opendev.org/#/c/663011/6..7/nova/virt/libvirt/blockinfo.py ;)10:37
sean-k-mooneyit can if there is no merge conflict but in repo you should jsut rebase on top of the other10:37
mdboothsean-k-mooney: More thinking about octopus merges.10:37
*** brinzhang has quit IRC10:38
kashyapmdbooth: One moment10:38
mdboothsean-k-mooney: i.e. You've got several otherwise independent patches, then a change which requires all of them.10:38
sean-k-mooneymdbooth: yep i have done that before and if there are no merge conflict it works10:38
*** frankwang has joined #openstack-nova10:38
lyarwooderm it's a DNM Nova change so nope10:38
lyarwoodah sean-k-mooney already said10:38
mdboothlyarwood: And I already noticed ;)10:39
sean-k-mooneyzuul create a new commit with all of the depencies as parents10:39
sean-k-mooneyso if the merge is possibel without conflict then zuul will do it if not it will mark the patch as in merge conflict10:39
mdboothIn that case, lyarwood should be able to use Depends-On for the tempest job change10:40
sean-k-mooneyyes he can10:40
sean-k-mooneyand then just recheck and it will pick up the latest version each time10:41
*** ivve has quit IRC10:41
kashyapmdbooth: Heh, thanks10:41
sean-k-mooneymdbooth: for that to work however the tempest change would have to not be based on the other change or zuul with skip the depends-on as its already satisfied10:42
mdboothsean-k-mooney: It would be academic in this case, tbh. I'm more just interested to know if it works :) I doubt lyarwood would bother on that basis.10:43
sean-k-mooneyi have used it in the past when i needed a bug fix someone else was writing form my own work but they did not want me to rebase my work ontop10:44
*** ricolin has quit IRC10:47
*** guozijn has quit IRC10:49
*** boxiang_ has joined #openstack-nova10:54
*** boxiang has quit IRC10:57
mdboothlyarwood: FYI, don't know if you've been doing this locally but your latest patch just completed a full set of py37 unit tests for me11:01
sean-k-mooneymdbooth: the nova compute agent does not work proably under py37 the last time i tried it11:01
sean-k-mooneyit hangs when you try to boot a vm11:01
sean-k-mooneyi think eventlets is not working properly11:02
mdboothWhich agent?11:02
sean-k-mooneynova-compute11:02
mdboothThe service?11:02
sean-k-mooneyyes11:02
mdboothAh, ok11:02
*** ttsiouts has joined #openstack-nova11:03
sean-k-mooneyit stop produceing all log output in the journal and the vm never boots11:03
mdboothsean-k-mooney: It's definitely running on RHEL 811:03
sean-k-mooneyat least that is what i was seeing on fedora 2911:03
sean-k-mooneyrhel8 is not useing py3711:03
sean-k-mooneyor atleast i thought it was using py3611:04
mdboothObviously11:04
sean-k-mooneythe unit test do actully run however on py37 as do the fucntional test i belive so it seams to only be an issue when we do actul socket io to connect to libvirt11:05
sean-k-mooneyto be honest i didnt debug it11:05
lyarwoodmdbooth: I've been watching it using http://zuul.openstack.org/status and https://github.com/kk7ds/openstack-gerrit-dashboard11:09
*** ociuhandu has joined #openstack-nova11:09
lyarwoodI was just bouncing between unit and functional tests failing for stupid reasons11:10
lyarwoodshould be resolved now11:10
mdboothlyarwood: Ack.11:10
*** claudiub has joined #openstack-nova11:12
*** panda|ruck is now known as panda|ruck|eat11:19
*** markvoelker has joined #openstack-nova11:26
*** abhishekk has joined #openstack-nova11:28
*** guozijn has joined #openstack-nova11:29
*** ttsiouts has quit IRC11:31
*** ttsiouts has joined #openstack-nova11:32
*** ttsiouts has quit IRC11:36
aspiersefried: https://review.opendev.org/#/c/638680/ looking a lot better now, thanks for the recheck11:38
aspiersalthough I do wonder what the hell you were doing awake at that time11:38
*** maciejjozefczyk_ has quit IRC11:39
*** maciejjozefczyk_ has joined #openstack-nova11:41
*** xek has quit IRC11:49
*** xek has joined #openstack-nova11:50
*** markvoelker has quit IRC12:00
*** gmann has quit IRC12:03
*** ricolin has joined #openstack-nova12:03
*** ociuhandu_ has joined #openstack-nova12:06
*** ociuhandu has quit IRC12:06
*** ttsiouts has joined #openstack-nova12:10
mdboothartom: Looking at https://review.opendev.org/#/c/644881/19/nova/compute/manager.py12:27
mdboothWhich neutron call generates the event when we're using OVS hybrid: setup_networks_on_host or migrate_instance_finish?12:27
* mdbooth suspects the latter12:27
*** jaypipes has joined #openstack-nova12:28
*** panda|ruck|eat is now known as panda|ruck12:30
sean-k-mooneymigrate_instance_finish calls _update_port_binding_for_instance12:30
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L272812:30
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L318612:31
sean-k-mooneyso _update_port_binding_for_instance triggers teh event when the portbinding is updated12:31
mdboothsean-k-mooney: Thanks.12:31
*** frankwang has quit IRC12:37
*** rcernin has quit IRC12:37
*** priteau has quit IRC12:41
sean-k-mooneymdbooth: i added some clarification to https://review.opendev.org/#/c/644881/19/nova/compute/manager.py12:45
openstackgerritAdam Spiers proposed openstack/nova master: Track inventory for new MEM_ENCRYPTION_CONTEXT resource class  https://review.opendev.org/66210512:45
mdboothsean-k-mooney: Thanks12:46
sean-k-mooneyalthough i think the comment artom left in the code is sufficent12:46
mdboothartom: I think you're missing a test.12:53
*** priteau has joined #openstack-nova12:54
kashyapGoddamned Gerrit utterly ****s up formatting when you try to quote-reply to a long message, that has some indentation.12:56
* kashyap manually cleans it up12:57
*** ttsiouts has quit IRC13:01
kashyap[No it's not possible; curses under my breath and moves on.]13:01
*** ttsiouts has joined #openstack-nova13:01
artommdbooth, sorry, caught me during daycare taxi13:03
artomLooks like sean-k-mooney answered your question13:04
artommdbooth, sean-k-mooney, thanks for the reviews, will address shortly13:04
sean-k-mooneyartom: i havent asked for any changes so mine is a noop :)13:04
*** BjoernT has joined #openstack-nova13:05
*** ttsiouts has quit IRC13:05
*** eharney has joined #openstack-nova13:06
openstackgerritMerged openstack/nova master: Change the default of notification_format to unversioned  https://review.opendev.org/60307913:10
*** mriedem has joined #openstack-nova13:10
openstackgerritLee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type  https://review.opendev.org/66288713:12
*** sapd1_x has joined #openstack-nova13:14
*** abhishekk has quit IRC13:15
artomlyarwood, well, depends what we want to show with it13:15
artomIf we just want it to pass with only the IDE/SATA CDROM changes, then yeah13:16
artomOnce we actually fix the PCIE ports in Nova, then that bit should be removed from the DNM patch13:16
artomErr, that was for a question asked in downstream IRC13:16
*** lbragstad has joined #openstack-nova13:17
*** brinzhang has joined #openstack-nova13:18
*** ttsiouts has joined #openstack-nova13:22
lyarwoodartom: okay so moving back here, testing q35 instead of the default machine type in upstream CI13:23
lyarwoodartom: I personally think that's fine in one job but we still need to cover the default somewhere13:23
artomlyarwood, yeah, that was my feeling as well - we can't add an entire new job given the gate resource constraints, and we should keep testing the default as well13:24
artomSo where do we stick q35? nova-next?13:24
kashyapartom: An email needs to be written to discuss on the list13:25
kashyap[nova] Test 'q35' machine type in the Gate13:25
kashyapOr something like that13:25
artomkashyap, sounds like a plan13:25
artomWho's doing the needful?13:25
kashyapI can do that.  But not now13:25
kashyapOne of the main reasons is that upstream and (nor a certain major Linux distro) QEMU doesn't "fix" bugs or add additional features to the 'pc' machine type13:26
kashyapNot least because it's considered legacy (20+ years old), and difficult to extend13:26
artomThat's an argument for outright switching the default, no?13:27
*** _erlon_ has joined #openstack-nova13:27
kashyapIt is.  We've had approximately 240 email-long threads about it.13:27
artomHah :(13:27
kashyapSorry, by "we" as in QEMU and libvirt.13:28
kashyapSome fear the backwards compat that it "might" break something13:28
artomWell, I meant in Nova, but in QEMU works too13:28
kashyapBut we can't ever be paralyzed13:28
kashyapartom: Yes: https://review.openstack.org/#/c/631154/13:28
kashyap"Gracefully handle QEMU machine types for guests"13:28
artomkashyap, oh, had no idea that existed, thanks13:29
kashyapartom: For now, installer tools are supposed to configure the default.13:29
artomWill add to the pile of specs to review13:29
artom... which I guess makes sense (installer configuring the machine type)13:30
kashyapThat's one reason I put on the back burner for this cycle13:30
yaawangjohnthetubaguy: mriedem Could you please take a look at auto-converge/post-copy spec? I've updated it. https://review.opendev.org/#/c/651681/13:33
*** BjoernT_ has joined #openstack-nova13:34
*** spatel has joined #openstack-nova13:35
*** egonzalez has left #openstack-nova13:35
*** BjoernT has quit IRC13:37
*** spatel has quit IRC13:39
*** rcernin has joined #openstack-nova13:41
*** eharney has quit IRC13:41
*** BjoernT_ is now known as BjoernT13:47
*** spsurya has quit IRC13:55
*** phasespace has quit IRC13:57
*** eharney has joined #openstack-nova13:57
*** mlavalle has joined #openstack-nova14:00
*** eharney has quit IRC14:02
*** boxiang has joined #openstack-nova14:02
*** BjoernT_ has joined #openstack-nova14:05
openstackgerritBalazs Gibizer proposed openstack/nova master: Remove global state from the FakeDriver  https://review.opendev.org/65670914:05
openstackgerritBalazs Gibizer proposed openstack/nova master: Enhance service restart in functional env  https://review.opendev.org/51255214:05
openstackgerritBalazs Gibizer proposed openstack/nova master: Add functional test coverage for bug 1724172  https://review.opendev.org/51255314:05
openstackbug 1724172 in OpenStack Compute (nova) rocky "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Medium,Confirmed] https://launchpad.net/bugs/172417214:05
efriedcfriesen: Thanks for the update.14:06
*** BjoernT has quit IRC14:08
aspiershttps://review.opendev.org/#/c/638680/ got a +1 from Zuul finally14:09
*** dpawlik has quit IRC14:10
efriedyup, \o/14:10
aspiersis it just me or are we getting some semi-spam +1 reviews?14:10
efriedhappens all the time14:11
aspiersah ok14:11
efriedstat padders14:11
aspiers:-(14:13
aspierskashyap: funny this should just emerge after we were talking about it the other day https://itnext.io/pyramid-of-doom-the-signs-and-symptoms-of-a-common-anti-pattern-c716838e181914:14
kashyapHiya14:14
* kashyap clicks14:15
*** jaosorior has joined #openstack-nova14:15
kashyapaspiers: Hehe, "pyrmaid of doom"14:15
*** artom has quit IRC14:15
*** eharney has joined #openstack-nova14:15
gibiaspiers: they are coming in batches14:16
gibiaspiers: https://www.stackalytics.com/?metric=marks&module=nova-group&company=awcloud14:17
kashyapaspiers: On "semi-spam +1s", I wonder if they would dare to do that had it were an e-mail14:17
kashyapImagine sending random +1s to e-mail based patch workflows.14:17
aspiersright14:17
*** brinzh has joined #openstack-nova14:17
aspiersperhaps someone in the foundation can have a word?14:17
kashyapEach Gerrit change is an island, nobody notices it (beside those who do).  So who cares who craps on it14:17
kashyapaspiers: This is something we have to live with, as a community-based open source project, afraid.14:18
aspierskashyap: not sure I agree14:18
aspiersthere's nothing to stop us raising complaints about this behaviour14:18
kashyapaspiers: Oh, certainly; there was a recent thread about it on the list, too14:18
kashyap(Not sure you noticed it)14:18
*** brinzhang has quit IRC14:19
aspiersI think I saw it14:19
lyarwoodmdbooth / kashyap / sean-k-mooney ; https://review.opendev.org/#/c/663011/ is ready for another round of reviews btw14:19
kashyapaspiers: I was just implying we can't eliminate this problem entirely.14:19
aspierskashyap: sure, but "This is something we have to live with" sounded more like a statement of resignation14:19
aspiersWe can probably eliminate 80% of spam reviews with small effort14:20
kashyapaspiers: Heh, let me "phrasing guard" down for a bit there.14:20
aspiersIt's an odd choice of changes to review they picked14:20
*** guozijn has quit IRC14:21
kashyaplyarwood: Will look in a bit.14:21
aspiershttps://www.stackalytics.com/?company=awcloud&metric=marks&release=train <- 25 contributors with 100% approval ratio14:21
*** bnemec has quit IRC14:23
*** bnemec has joined #openstack-nova14:25
openstackgerritMerged openstack/nova master: conf: Remove cells v1 options, group  https://review.opendev.org/65131014:27
*** lpetrut has quit IRC14:28
*** eharney has quit IRC14:35
boxianghttps://review.opendev.org/#/c/649963/ need someone to review it, give me some comments, thanks :)14:35
mriedemthe pci passthrough whitelist config is not mutable so changing it requires a restart, and that means it would be the same for all computes processed by the scheduler yeah? meaning when we create a HostState object per compute node per scheduling request, we're re-parsing that pci passthrouh whitelist spec per node per request, right? https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L22714:36
mriedemif you have several hundred nodes to process per request i'd imagine that eventually adds up14:37
efriedaspiers: I'm a bit fuzzy yet this morning, but I think there's a hole in https://review.opendev.org/#/c/662105/ - please see comments.14:39
aspiersefried: OK14:40
sean-k-mooneymriedem: that is done on the compute node but yes14:40
mriedemsean-k-mooney: this is done in the scheduler14:41
sean-k-mooneythe pci whitelist is on each the compute nodes and can be different14:41
sean-k-mooneythe alias is parsed on the schduler14:41
sean-k-mooneythere was a patch to cache this too at one point but i think it was blocked because peopel didnt feel it was enough of a perfomace imporvemnt14:42
openstackgerritDan Smith proposed openstack/nova master: Make nova-next archive using --before  https://review.opendev.org/66100214:42
sean-k-mooneymriedem: https://review.opendev.org/#/c/427145/14:43
sean-k-mooneymriedem: not sure if stephenfin still feels its not worth it14:44
sean-k-mooneymriedem: but i certenly tried to get it landed 2 years ago :)14:44
*** BjoernT_ is now known as BjoernT14:47
sean-k-mooneymriedem: by the way https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L227 is loading the pci info frmo the database not parsing the whitelist14:47
*** eharney has joined #openstack-nova14:48
sean-k-mooneywell that is not quite true its contcutiono the PciDeviceStats object form the compute.pci_device_pools14:48
mriedemhttps://bugs.launchpad.net/nova/+bug/183175814:49
openstackLaunchpad bug 1831758 in OpenStack Compute (nova) "passthrough_whitelist is parsed per compute node per scheduling request even though the whitelist doesn't change between requests" [Low,Confirmed]14:49
mriedemconstructing PciDeviceStats parses the whitelist14:50
sean-k-mooneythe whitelist does not have to be set on the the schduler node14:50
*** artom has joined #openstack-nova14:51
sean-k-mooneyand it is and i can be different per compute node but you are refering to https://github.com/openstack/nova/blob/master/nova/pci/stats.py#L66-L6714:51
openstackgerritAdrian Chiris proposed openstack/nova stable/rocky: Move get_pci_mapping_for_migration to MigrationContext  https://review.opendev.org/66149914:51
openstackgerritAdrian Chiris proposed openstack/nova stable/rocky: Allow driver to properly unplug VIFs on destination on confirm resize  https://review.opendev.org/66150014:51
*** lpetrut has joined #openstack-nova14:52
sean-k-mooneymriedem: i guess that makes sense on the compute node as this class is used in the pci manager but we should not need to do it in the schduler14:52
*** eharney has quit IRC14:54
*** lpetrut has quit IRC14:54
*** lpetrut has joined #openstack-nova14:55
sean-k-mooneymriedem: we proably should add a use_whitelist kwarg or something so we can disable this on the schduler14:55
*** factor has quit IRC14:55
openstackgerritLee Yarwood proposed openstack/nova master: DNM dump image_meta when attempting to validate image signatures  https://review.opendev.org/66334814:55
*** icarusfactor has joined #openstack-nova14:55
sean-k-mooneythe pci whitelist shoudl only be used in the compute node and the alias should only be used on teh api or schduler nodes.14:56
*** itlinux has joined #openstack-nova14:57
*** itlinux has quit IRC14:59
*** sapd1_x has quit IRC14:59
efriedcan we not save the date stamp of the file?15:00
efriedor use fsnotify (or whatever that thing is called)?15:00
*** boxiang has quit IRC15:03
*** JamesBenson has joined #openstack-nova15:04
*** brinzh has quit IRC15:06
*** lennyb has joined #openstack-nova15:07
mriedemwe're parsing from the config option value which is not mutable15:07
*** eharney has joined #openstack-nova15:07
sean-k-mooneymriedem: and as i mention on the bug the config value is only used on teh compute node and not in the schduler15:08
efriedoh, sorry, yeah, I was thinking of something quite different. Maybe I need more coffee15:08
mriedemsean-k-mooney: i would not doubt that config mgmt tooling - if it's setting it - is setting it everywhere because people wouldn't know which services care about it15:09
mriedemsean-k-mooney: nor do you know what out of tree filters could be doing with that thing in the HostState object15:09
sean-k-mooneymriedem: well the value can and typicaly iss different per compute node15:09
sean-k-mooneyso if they are doing anything with the config value its proably wronge15:10
openstackgerritBalazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations  https://review.opendev.org/63795515:10
mriedemyeah that's true15:10
mriedemtssurya: why do you have a -1 on https://review.opendev.org/#/c/623558/ ?15:12
mriedemit looks like from your numbers the patch makes a noticeable improvement in scheduling time,15:13
mriedemand the services query stuff could be optimized separately later15:13
tssuryamriedem: I don't remember exactly but I think I also didn't understand some parts of the _filter_enabled_cell_computes function15:15
tssuryaalso I am pretty sure we have a debug per cell for https://review.opendev.org/#/c/623558/2/nova/scheduler/host_manager.py@790 currently in our deployment which should be fixed.15:16
tssuryabut yeah could be done in a FUP15:16
mriedemdebug per cell?15:18
mriedemso you're running with this patch in production already?15:18
mriedembut changed that warning to a debug level message?15:18
tssuryayeah15:18
mriedem:/15:18
tssuryawait no15:18
*** brinzhang has joined #openstack-nova15:18
tssuryaI mean we are running it in production already15:19
tssuryawe are still running it as warning15:19
tssuryawhat I meant was it causes a lot of noise15:19
mriedemthat would be good feedback on the change (that you're running it in prod) and since when15:19
*** panda|ruck is now known as panda15:19
tssuryabecause it prints a message per cell15:19
tssuryaper scheduling15:19
tssuryasaying it didn't find anything15:19
tssuryaso removing that cell15:19
mriedemsure, so -1 for that i guess,15:19
mriedembut to say "not sure what this does but we've been running with it in prod successfully for months now" isn't really justification for a -1 :)15:20
tssuryamriedem: the -1 on the patch was for the extra improvement15:20
tssuryafo sure15:20
tssuryafor*15:20
mriedemwhich extra improvement? the services query?15:21
tssuryaand because I wasn't convinced what _filter_enabled_cell_computes was doing15:21
tssuryamriedem: yes15:21
tssuryabut I am okay if that needs to be done in a seperate patch15:21
mriedemok that's FUP worthy, since this change is already big15:21
tssuryaplus its ok for us if we don't backport this15:21
mriedemdid jay answer your questions about _filter_enabled_cell_computes ?15:21
mriedembecause if not, i wouldn't wait for him since he's gone15:22
tssuryamriedem: no15:22
tssuryaI can remove the -115:22
mriedema todo could be added for the services query15:22
tssuryaalso fyi this patch works with https://review.opendev.org/#/c/635532/ and both together give us good performance15:22
tssuryabelmiro should be putting a blog post soon15:23
tssuryaso we will link the post to this review15:23
*** derekh has quit IRC15:23
*** derekh has joined #openstack-nova15:23
openstackgerritKashyap Chamarthy proposed openstack/nova master: Document mitigation for Intel MDS security flaws  https://review.opendev.org/66157415:25
*** derekh has quit IRC15:25
*** rcernin has quit IRC15:26
*** liuyulong has quit IRC15:26
mriedemtssurya: what is your max_placement_results value now?15:26
*** derekh has joined #openstack-nova15:26
*** brinzhang has quit IRC15:26
*** gyee has joined #openstack-nova15:27
*** jaosorior has quit IRC15:27
tssuryamriedem: 10 still15:29
*** derekh has quit IRC15:29
*** derekh has joined #openstack-nova15:29
mriedemheh15:29
*** derekh has quit IRC15:31
*** derekh has joined #openstack-nova15:31
*** ttsiouts has quit IRC15:32
*** ttsiouts has joined #openstack-nova15:33
*** frankwang has joined #openstack-nova15:33
*** derekh has quit IRC15:34
*** derekh has joined #openstack-nova15:34
*** tssurya has quit IRC15:36
*** frankwang has quit IRC15:38
*** ttsiouts has quit IRC15:38
*** helenafm has quit IRC15:39
openstackgerritEric Fried proposed openstack/nova master: Raise if flavor and image disagree on hide_hypervisor_id  https://review.opendev.org/66336515:46
efriedmriedem: Can we +W https://review.opendev.org/#/c/579897/ now?15:47
mriedemjesus look at all of the new review comments i have to parse15:51
efriedonly since your last +215:53
efriedkashyap: you still around?15:53
mriedemok i have it in a tab but in the middle of something15:53
dansmithin case you're wondering,15:53
dansmithI hate it.15:53
efriedkashyap: I'd be happy to fix up those couple of typos in https://review.opendev.org/#/c/661574/ if you like.15:53
*** Sundar has joined #openstack-nova15:54
efrieddansmith: necessary evil15:54
dansmithnot really15:54
openstackgerritEric Fried proposed openstack/nova master: Document mitigation for Intel MDS security flaws  https://review.opendev.org/66157415:55
*** itlinux has joined #openstack-nova15:56
efriedkashyap: +2 ^ thanks for your patience15:56
*** _erlon_ has quit IRC15:57
openstackgerritJohn Garbutt proposed openstack/nova master: WIP: add scope check, see tests catch the change  https://review.opendev.org/65782315:59
*** dtantsur is now known as dtantsur|afk16:01
*** panda is now known as panda|off16:02
*** markvoelker has joined #openstack-nova16:04
jaypipesmriedem: for the record, I haven't died or anything. :P16:08
*** rpittau is now known as rpittau|afk16:08
mriedemjaypipes: i know you're not dead, but i also assume you don't want/need to be pinged for stuff you're not going to have the time to work on16:09
jaypipesmriedem: I'd chatted with Surya about that patch series in Denver and stated I'd rebase, fix merge conflicts and push them, which I did. I also stated I wouldn't have time to shepherd them through to completion and she mentioned she would do that.16:10
mdboothlyarwood: Question in your q35 patch: Any reason we can't be explicit about q35 machine type? Are there an unmanageable number of q35 machine types or something?16:10
jaypipesmriedem: I'm around, but as you say, not really time to spend. I'm still friendly, though. :)16:10
mriedemjaypipes: ok i didn't mean any offense16:11
mriedemjust trying to not distract you16:11
jaypipesno offense taken at all!16:11
lyarwoodmdbooth: so yeah there are a few and even more downstream iirc16:13
lyarwoodmdbooth: $ qemu-kvm --machine help | grep q35 | wc -l16:14
mdboothlyarwood: Can you enumerate the problem?16:14
lyarwoodmdbooth: 1116:14
mdboothThat is... quite annoying16:14
lyarwoodmdbooth: We should really but that's additional work outside of this bugfix IMHO16:15
mdboothWorthy of a comment?16:15
*** damien_r has quit IRC16:15
lyarwoodmdbooth: sure16:15
edleafejaypipes: "still" friendly?  :-P16:18
jaypipesedleafe: :(16:19
mdboothartom: You on top of review comments from dansmith ?16:19
artommdbooth, working on it, yeah16:19
kashyapefried: Was out for a bike ride; now here for a bit more.16:25
kashyapefried: Ah, you've fixed up the typos; thank you!16:27
*** lpetrut has quit IRC16:28
openstackgerritAdrian Chiris proposed openstack/nova stable/queens: Move get_pci_mapping_for_migration to MigrationContext  https://review.opendev.org/66157116:28
openstackgerritAdrian Chiris proposed openstack/nova stable/queens: Allow driver to properly unplug VIFs on destination on confirm resize  https://review.opendev.org/66157216:28
kashyapstephenfin: O Docs Aficionado, when you can, please deliver this from its misery: https://review.opendev.org/#/c/66157416:31
stephenfinkashyap: Might be better let alex_xu grab it since he's taken a look a few times already16:33
openstackgerritMatt Riedemann proposed openstack/nova master: Delete unused get_all_host_states method  https://review.opendev.org/66337716:33
kashyapOh, right.  I totally forgot that; #bumblebee's-memory-7-seconds16:33
*** panda|off has quit IRC16:33
kashyapmdbooth: On the number of machine types -- yes, *each* QEMU release comes with a versioned machine type16:34
kashyapWhy versioned machine type?  They preserve guest ABI.16:34
openstackgerritSylvain Bauza proposed openstack/nova master: Pass allocations to virt drivers when resizing  https://review.opendev.org/58908516:35
*** panda has joined #openstack-nova16:35
kashyapmdbooth: And the "naked" 'q35' aliases to the latest versioned machine type.16:35
*** xek has quit IRC16:37
*** panda has quit IRC16:39
*** aram1s has joined #openstack-nova16:41
sean-k-mooneykashyap: the version machine types also create vendor lock in as they are different between distro and make it hard to migrate form one to another in some cases16:41
sean-k-mooneyso there are pros and cons i prefer just q35 but there are reason to use the versioned form too16:42
kashyapI wouldn't call it "vendor lock-in".  Each distribution is *supposed* to pick machine types as they see fit.16:42
kashyapIt's like saying you can install DEBs on an RPM-based system.16:42
sean-k-mooneyit kind of is when each distro add the name of the distor into the machine type16:43
sean-k-mooneykashyap: well you can16:43
sean-k-mooneyusing alien16:43
kashyapYeah, unfortunately, given the "there are more number of Linux distros than Linux users", we have to live with it...16:43
sean-k-mooneybut its more complicated16:43
*** bnemec has quit IRC16:44
sean-k-mooneykashyap: it would be nice if we just had a propatable set defiend by qemu or libvirt that all distos used16:44
kashyapSorry, what is a "propatable"?16:44
sean-k-mooneyportable16:45
sean-k-mooneyor interoperable16:45
kashyapAaah, I don't know how feasible that is; need to think with a fresh brain :-)16:45
kashyapAlright, need to go cook make food.  See ya16:45
*** kashyap has quit IRC16:46
sean-k-mooneyi think recent version of libvirt or qemu have got better of checking compatibliy if you use the alais e.g. "q35"16:46
sean-k-mooneybut i dont know if it will allow q35-centos... to migrate to q35-rhel... even if they are the same16:47
sean-k-mooneyi know it did not work betweeen centos and ubunut in  the past but if sepcifically set them to the same machine type it did16:48
*** panda has joined #openstack-nova16:48
* sean-k-mooney goes to get food16:49
aram1sHi there! Does anyone know what the 'state' represents for hypervisors? I thought it reflected the state of nova compute service but when I disable it I still see it as up16:50
aram1show can I make it go down?16:50
aram1swithout explicitly setting it as down. Will it chance based on any other status?16:51
aram1schange*16:51
*** itlinux has quit IRC16:56
*** itlinux has joined #openstack-nova16:59
melwittaram1s: status will also change if you for example, stop the nova compute service17:00
*** derekh has quit IRC17:00
melwittother than that, there's the forced_down API https://developer.openstack.org/api-ref/compute/?expanded=update-forced-down-detail#update-forced-down17:00
stephenfinmriedem: Could you drop your -2 from these given my comments inline? https://review.opendev.org/#/c/662501/ https://review.opendev.org/#/c/662502/17:01
openstackgerritStephen Finucane proposed openstack/nova master: Unplug VIFs as part of cleanup of networks  https://review.opendev.org/66338217:03
*** itlinux has quit IRC17:04
*** xek has joined #openstack-nova17:05
mriedemstephenfin: of course the ec2 objects aren't used outside of nova https://review.opendev.org/#/c/662502/17:08
mriedemthe ec2 API shim within nova is what's going to be used by the ec2api code17:08
mriedemwhich uses those objects17:08
stephenfinIt doesn't though17:08
mriedemthe ec2utils stuff might be different17:08
*** xek has quit IRC17:08
stephenfinNot used anywhere outside of nova and not used inside nova either17:09
*** xek has joined #openstack-nova17:09
*** itlinux has joined #openstack-nova17:09
stephenfinAt least not once I've removed the unused functions from ec2utils17:09
mriedemi'd feel a lot more comfortable with this if we could get a tempest run on the ec2api with a dependency on this series17:10
stephenfinI can try figure out how to do that17:10
* stephenfin hopes the ec2api zuul config is set up for a Depends-On17:10
mriedemit should be as easy as adding openstack/nova to https://github.com/openstack/ec2-api/blob/master/.zuul.yaml#L7 and adding a depends-on to your series17:11
*** JamesBenson has quit IRC17:16
aram1sthanks melwitt!17:16
*** JamesBen_ has joined #openstack-nova17:17
openstackgerritStephen Finucane proposed openstack/nova master: ec2: Remove unused functions from 'ec2utils'  https://review.opendev.org/66250117:17
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove unused ec2 objects  https://review.opendev.org/66250217:17
openstackgerritStephen Finucane proposed openstack/nova master: ec2: Remove ec2.CloudController  https://review.opendev.org/66250317:17
openstackgerritStephen Finucane proposed openstack/nova master: ec2: Pre-move cleanup of utils  https://review.opendev.org/66250417:17
openstackgerritStephen Finucane proposed openstack/nova master: ec2: Move ec2utils functions to their callers  https://review.opendev.org/66250517:17
openstackgerritStephen Finucane proposed openstack/nova master: api: Remove 'Debug' middleware  https://review.opendev.org/66250617:17
stephenfinmriedem: Thanks for the tip. We'll see how this goes https://review.opendev.org/66338617:19
* stephenfin -> 🏃17:19
*** ralonsoh has quit IRC17:28
*** _hemna has joined #openstack-nova17:31
*** ociuhandu has joined #openstack-nova17:33
openstackgerritMatt Riedemann proposed openstack/nova master: Convert HostMapping.cells to a dict  https://review.opendev.org/66338717:34
openstackgerritMatt Riedemann proposed openstack/nova master: Cache host to cell mapping in HostManager  https://review.opendev.org/66338817:34
*** ociuhandu_ has quit IRC17:36
artomI feel like I've messed up my method if I need to mock like 42 things when unit testing it :(17:38
mriedemyour method is too big17:38
artomThat's never been a problem before17:38
*** ociuhandu has quit IRC17:39
*** maciejjozefczyk_ has quit IRC17:46
*** zul has quit IRC17:47
*** Li_Liu has joined #openstack-nova17:49
edleafeartom: generally a "unit" doesn't have 42 dependencies.17:50
artom42 is obviously an exaggeration, but yeah, this bit of code is heavily coupled to a lot of things17:51
*** xek has quit IRC17:54
edleafeartom: yeah, that's more of an integration test then.17:54
*** tesseract has quit IRC17:57
* artom tries to see if he can do a functional test instead17:58
*** _hemna has quit IRC18:02
artomI probably can't, because external events18:10
artomPretty sure the NeutronFixture doesn't handle those ;)18:10
artomI suppose I can mock that part out...18:10
dansmithartom: you understand that the concern is just that you didn't test that those parts are at all connected, and since you don't have a gate test to make mriedem happy, there really needs to be confirmation that they work together, right?18:11
dansmithI mean, I'm pretty sure I could have removed the actual change you made and no tests would fail18:11
artomdansmith, right, IOW, we need to test that if _uses_hybrid_plug returns true, we actually wait for events in the compute manager18:12
dansmithat a minimum, I want to see a list of vif network_info structure passed into that method, and have the method not wait for events because it calls the helper and it examines the vif structures properly (and one for the opposite case if not already covered elsewhere)18:12
dansmithartom: that's one piece yes18:13
dansmithI'm totally uninterested in discussing the meaning of "unit" and how it relates to this, and only really interested in seeing that it works18:14
artomdansmith, what's the other piece? By mocking _uses_hybrid_plug to return False, it's testing that the existing code paths continue to work18:14
dansmithartom: the other piece being that you actually called the helper in a compatible way.. if all you do is check that the thing called your mock with who-knows-what and the mock always returns true or false, that doesn't mean it actually works when the parent calls the actual child implementation18:15
dansmithby testing only units against mocks, you don't actually confirm that they're compatible with each other18:16
artomdansmith, you just put words on why I'm not liking my current mock-42-things approach18:16
dansmiththe world can't be reduced to tiny methods with only two external interactions each, so sometimes things get messy18:17
dansmithI'm sure that method is too complex and refactoring won't help for backportability, so.. reality strikes18:18
artomStupid reality18:18
*** Sundar has quit IRC18:21
*** damien_r has joined #openstack-nova18:21
*** zul has joined #openstack-nova18:23
edleafeartom: it does sound like you will be better off with a functional test that shows those parts working together as intended. Otherwise, you're just testing the python mock library :)18:23
*** damien_r has quit IRC18:26
*** weshay has quit IRC18:26
*** weshay has joined #openstack-nova18:27
sean-k-mooneydansmith: i just replied to your question on the other move operations https://review.opendev.org/#/c/644881/19/nova/compute/manager.py@4192 i belive they are safe but it would be good for someone else to double check my logic18:31
dansmithsean-k-mooney: I bet mriedem has thoughts on that18:31
sean-k-mooneydo we allow evacuate to be reverted by the way?18:32
*** itlinux has quit IRC18:32
sean-k-mooneyi did not think so be honestly i have never looked18:32
dansmithunfortunately we do, within a window18:33
sean-k-mooneyok so that is one case that porably needs to be handeled18:33
artomWait, evacuate can be reverted?18:36
artomAlso I just realized that the bug my patch links to is probably irrelevant :/18:36
sean-k-mooneythats the bug the waiting behavior was added to fix18:37
sean-k-mooneyi think18:37
dansmithartom: not revert in the conventional sense,18:37
artomsean-k-mooney, I mean https://bugs.launchpad.net/nova/+bug/181378918:37
openstackLaunchpad bug 1813789 in OpenStack Compute (nova) "Evacuate test intermittently fails with network-vif-plugged timeout exception" [Medium,In progress] - Assigned to Artom Lifshitz (notartom)18:37
sean-k-mooneyartom: yes i know18:38
dansmithbut if you start an evacuation, it fails, and then the original source comes back alive, you can keep it there, barring bugs and timing and all kinds of crazy18:38
artomEven if the symptoms are the same, it has to be a different root cause, because upstream doens't use hybrid plug18:38
sean-k-mooneyartom: that was the bug we intoduce the wait on revert to fix18:38
dansmithwhich I wish wasn't the case18:38
artomdansmith, that couldn't have been on purpose...18:38
sean-k-mooneydansmith: im assuming that only works if we have not updated the instance host yet18:39
dansmithartom: nothing about evacuate was done with a great sense of purpose, but it was decided not to make it explicitly disallowed (to stay put)18:39
sean-k-mooneye.g. we failed before that point18:39
dansmithpersonally I'd prefer that the instant you start an evac, the instance _has_ to move somewhere18:39
*** kaiokmo has quit IRC18:39
sean-k-mooneyand it jsut happend to work if the host became alive again?18:39
dansmithsean-k-mooney: yeah18:39
sean-k-mooneyok so its just happening because we dont keep retrying to move the instance after the failure18:40
*** kaiokmo has joined #openstack-nova18:40
sean-k-mooneyand when it fails we dont update the db18:40
*** ricolin has quit IRC18:41
dansmithit depends on when we fail18:41
dansmith.of course18:41
dansmithwhich is why it seems broken to me,18:41
sean-k-mooneyso i proably know the answer to this but do we really care about that edgecase?18:42
dansmithespecially because HA stuff that has made a decision to rebuild the instance is easier knowing it has fenced the original node, etc18:42
sean-k-mooneyi mean we proably should but other stuff is proably broken at that point18:42
dansmithsean-k-mooney: IIRC, mriedem (and maybe others) really want to keep the "can keep it on the source if it's not too late" behavior18:42
sean-k-mooneydansmith: no im kind of ok with that18:43
sean-k-mooneywhat i ment was for artom patch18:43
dansmithoh, yeah, I think that's worth investigating and fixing if it's related18:43
sean-k-mooneydo we need to add in extra code to handel that case18:43
artomsean-k-mooney, the evacuate case? Maybe in a different patch, but why put it in mine?18:44
sean-k-mooneyim trying to think how we would even fake that out in a functional test18:44
*** kaiokmo has quit IRC18:44
artomdansmith, so, turns out I was being too paranoid too soon about mocking things, and it actully works out pretty clean18:45
sean-k-mooneyartom: just because dansmith asked about the other move operation in yours18:45
sean-k-mooneybut it could be in another patch18:45
dansmithsean-k-mooney: and when mriedem reviews it, that's going to be one of the first things he says :)18:45
sean-k-mooneywell i dont  think artoms patch makes that case any worse but it also might not fix things in that case18:46
sean-k-mooneyassuming its currently broken in that case18:46
dansmithit's a matter of making sure we don't re-have this conversation in a year when someone reports it for evacuate, and maybe fix it a different way18:47
sean-k-mooneyya thats fair18:47
dansmithalso, I think hard reboot used to wait, now doesn't, potentially because we had this convo already and didn't go deep enough18:47
dansmithhttps://review.opendev.org/#/c/553035/18:47
artomBut... I thought the whole thing here is that hybrid plug is special in how it wires vifs18:48
dansmithheh, about a year ago18:48
sean-k-mooneywell not quite18:48
artomAnd resize is special in that it leaves in the instance paused on the source until confirm or revert18:48
sean-k-mooneysome network backeds only send events on port bind and we dont bind the ports on hard reboot or rebuild18:48
dansmithno, it's not paused on the source18:48
dansmithit's off18:48
artomSo.. how would that be applicable for evacuate, when the instance was never on the dest to begin with?18:48
artomdansmith, sorry, off (aka destoryed)18:48
artomsean-k-mooney, ah, so some backends might send the event as soon as we change the port binding to a host, regardless if it's wired or not?18:49
sean-k-mooneyartom: yes18:49
artomI'd say that's a bug in those backends18:49
sean-k-mooneyit was by design18:50
artomIt shouldn't be sending the event if the thing isn't actually plugged/wired18:50
sean-k-mooneynot all networking backend can support that or at least could back when this was firt intoduced18:50
artomThat doesn't invalidate my argument :)18:50
sean-k-mooneyodl took 2 years to catch up and intoduce a way for odl to send events to neutron which neutron could send to nova18:51
artomThe idea was for Nova to be sure we have networking for instance by the time it spawns18:51
artomSo things like DHCP work18:51
artomIf we get the event before that's happened, that's not for Nova to fix18:51
sean-k-mooneyyep i had this argument with the odl folk back in 201418:51
artomBecause we'd be acting like networking is ready, when in reality it isn't18:51
artom(yey, 5 years late)18:52
sean-k-mooneyfor what its worth im pretty sure netorking-aci still does not send it when the port is wireded up an send it on bind18:52
sean-k-mooneyand ovn is not doing the right thing either in all cases18:52
artomThe Cisco thing?18:52
sean-k-mooneyyes18:53
artomThat's just one more argument for people not to buy Cisco ;)18:53
mriedem"IIRC, mriedem (and maybe others) really want to keep the "can keep it on the source if it's not too late" behavior"18:53
mriedemi have no opinion on that18:53
mriedemthat i'm aware of18:53
mriedemi'm also assuming i don't want to cruft up an already complicated change to cover other cases in the same patch if we're doing backports18:54
mriedemb/c there is a >0% chance this will introduce a regression somehow18:54
mriedemb/c this is all very brittle sounding18:54
mriedemand super duper latent18:54
mriedemhow would one even recreate this hybrid ovs resize thing in the gate? configure devstack for that backend (is that easy?) and then put a sleep in the nova code between migrate_instance_start(finish?) and the call to the virt driver?18:55
artomLike osteoporosis18:55
sean-k-mooneymriedem: we have patches to recreate. you configure ovs of iptables and then we can race on teh revert tests18:56
sean-k-mooney*ovs to use the iptables firewall driver18:56
artomhttps://review.opendev.org/#/c/660782/5 specifically18:56
sean-k-mooneyour downstream ci default to iptables firewall still on older releases so that is why we are seeing it downstream. upstream use the openvswtich contrack firewall driver by default18:57
mriedemwhy does https://review.opendev.org/#/c/653498/ come after the fix in the series?18:58
artommriedem, because without hybrid plug it's actually irrelevant to the fix :/18:59
artomWell18:59
artomI suppose it tests the non-hybrid-plug case18:59
mriedemcorrect19:00
mriedemyou said in the ML it was the only job we run that is multi-node for the resize revert stuff right?19:00
mriedemor would be19:00
artomYeah19:00
artomI can move it below19:01
*** ociuhandu has joined #openstack-nova19:02
mriedemyou know,19:02
sean-k-mooneyartom: actuly i think you used to have it below and inverted it in a recent revision19:02
mriedemtest_server_connectivity_cold_migration_revert in the tempest-slow-py3 job would run resize revert in a multi-node job,19:02
mriedemif you removed the skip on the test19:02
mriedemand the test is skipped b/c of https://bugs.launchpad.net/nova/+bug/178840319:02
openstackLaunchpad bug 1788403 in OpenStack Compute (nova) "test_server_connectivity_cold_migration_revert randomly fails ssh check" [Medium,Fix released] - Assigned to Matt Riedemann (mriedem)19:02
mriedemwhich sounds very familiar to your issue yeah?19:02
*** itlinux has joined #openstack-nova19:03
artomIt would, except again, upstream gate doesn't use hybrid plug, so it's a different root cause19:03
dansmithmriedem: you emotionally scarred me with discussion of that opinion in the past, which is why I remember it19:03
mriedemdansmith: logs or it never happened!19:04
dansmithmriedem: and yeah, not saying fixing the other operations needs to be in this patch, but if we're undoing not only this wait, but also making previous ones (like the hard reboot) no longer accurate, I think fixing them all in the same way (re-using helpers if they apply, etc) is a good idea19:04
dansmithmriedem: I can show you the scars. those'19:04
dansmithre good enough yeah?19:04
mriedempictures or it didn't happen!19:04
* dansmith faxes mriedem copies of his therapy bills19:04
artomFaxes? Damn boomers19:05
*** priteau has quit IRC19:06
dansmithI know you didn't just confuse me with someone of baby boomer age19:06
sean-k-mooneymriedem: https://bugs.launchpad.net/nova/+bug/1788403 is marked as fix releaed and i think you fixed it by intoducing the waits on revert correct so the current skip of test_server_connectivity_cold_migration_revert probly should have been removed a while ago19:07
openstackLaunchpad bug 1788403 in OpenStack Compute (nova) "test_server_connectivity_cold_migration_revert randomly fails ssh check" [Medium,Fix released] - Assigned to Matt Riedemann (mriedem)19:07
*** priteau has joined #openstack-nova19:08
*** ociuhandu has quit IRC19:09
* sean-k-mooney get popcorn to watch how that plays out19:09
*** amodi has joined #openstack-nova19:11
*** panda has quit IRC19:19
*** panda has joined #openstack-nova19:20
sean-k-mooneyalex_xu: yonglihe i think https://review.opendev.org/#/c/658716/ look fine. sorry for not getting to it yesterday19:21
mriedemartom: dansmith: sean-k-mooney: i've dumped a bit in https://review.opendev.org/#/c/644881/ - i'm going to concentrate on something else now19:21
sean-k-mooneynow to go revew teh virtual perstent memory spec19:21
artommriedem, thank you for your dump :D19:22
mriedemsean-k-mooney: yeah i was wondering why i didn't remove the skip on test_server_connectivity_cold_migration_revert19:22
*** lpetrut has joined #openstack-nova19:23
sean-k-mooneymriedem: is the skip in tempest or in nova out of interest?19:24
mriedemtempest19:24
mriedemi'll post a tempest change to remove the skip and see what happens19:24
sean-k-mooneyah so its the skip decorator19:24
sean-k-mooneyi would expect it to pass since we default to the ovs firewall19:25
sean-k-mooneyi dont think neutorn has a multinode iptables job or any project currently so i doubt we will see failures19:25
sean-k-mooneybut i could be wrong about that19:26
*** lpetrut has quit IRC19:27
mriedemhttps://review.opendev.org/66340519:28
sean-k-mooneyi need to go stack a multi node env so ill see if i can run that locally too19:30
sean-k-mooneyefried: haha you got to before i did19:35
openstackgerritMatt Riedemann proposed openstack/nova master: Drop pre-cinder 3.44 version compatibility  https://review.opendev.org/62106119:36
sean-k-mooneyefried: i think we have so issues with those db unit test randomly failing19:36
sean-k-mooneyits not the first time i have seen them fail on py36 and pass on py27 and py3719:37
efriedsean-k-mooney: what are we talking about?19:37
sean-k-mooneythe hide hypervior id patch19:38
efriedsean-k-mooney: https://bugs.launchpad.net/nova/+bug/1823251 ?19:38
openstackLaunchpad bug 1823251 in OpenStack Compute (nova) "Spike in TestNovaMigrationsMySQL.test_walk_versions/test_innodb_tables failures since April 1 2019 on limestone-regionone" [High,Confirmed]19:38
efriedsean-k-mooney: You'll be my hero if you can figure that one out.19:38
sean-k-mooneyand yes i was refering to the failures of those tests19:38
efriedprobably even shiny nickel worthy19:39
sean-k-mooneywhat strang is they appear to be failing only in the limestone-regionone19:40
* artom needs to do some taxi'ing for amily19:41
artom*family19:41
artomGonna have to finish addressing your feedback later tonight, mriedem19:41
artomMoving to test_compute_mgr isn't as trivial as it first sounded :(19:42
sean-k-mooneyefried: looks like gibi is trying to fix it with https://review.opendev.org/#/c/662434/19:45
efriedOh, okay.19:46
sean-k-mooneywell its not actully a fix but just a cleanup to help find a fix19:46
efriedexcept it didn't work?19:46
efriedyeah19:46
sean-k-mooneywell its passing but i need to check if it ran on limestone or not19:47
efriedIt failed once19:47
*** slaweq has quit IRC19:47
efriedhttp://logs.openstack.org/34/662434/1/check/openstack-tox-py27/3ead2fd/testr_results.html.gz19:47
*** slaweq has joined #openstack-nova19:48
*** artom has quit IRC19:48
sean-k-mooneyv2 ran on ovh so the fact v2 pass doesnot tell us much19:48
sean-k-mooneythe one that failed ran on limestone http://logs.openstack.org/34/662434/1/check/openstack-tox-py27/3ead2fd/job-output.txt.gz#_2019-05-31_11_45_41_62531419:49
sean-k-mooneyin theory nodepool is building and uploading the same image to all providers so it should be the same but i guess we could check with the infra folks to confirm that19:50
sean-k-mooneyoh and thats interest so the failure also happens on py2719:52
*** imacdonn has quit IRC19:53
*** imacdonn has joined #openstack-nova19:53
*** brault has quit IRC19:58
*** _hemna has joined #openstack-nova19:59
*** BjoernT has quit IRC20:08
*** damien_r has joined #openstack-nova20:10
cfriesenmriedem: I'm hitting something interesting in pike.  when deleting a nova-compute service I'm still managing to hit the "Unable to delete resource provider X: Resource provider has allocations": error, even with your check to see if there are instances on the compute host.20:13
efrieddid you check placement for allocations?20:13
cfriesenmriedem: this leaves us with a stale resource_provider entry, whose UUID ends up out of sync with the nova compute_nodes table, which causes scheduling to fail when we add the node back with the same name20:14
cfriesenefried: checking that now20:14
sean-k-mooneycfriesen: there could be allocation related to stale migrations against that node20:14
efriedis this what nova manage heal allocations is for?20:15
efried(however that's spelled)20:15
sean-k-mooneyim not sure20:16
cfriesenefried: I see 14  allocations for the stale node for resource classes 0, 1, 2.  (cpu/ram/disk, I think)20:16
sean-k-mooneyi dont think so but it may be a sideffect20:16
efriedcfriesen: Good to know placement wasn't lying.20:17
sean-k-mooneycfriesen: do the allcoation consume ids match any instance or migrations20:17
*** itlinux has quit IRC20:17
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type  https://review.opendev.org/66301120:18
openstackgerritLee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type  https://review.opendev.org/66288720:18
*** itlinux has joined #openstack-nova20:19
cfriesensean-k-mooney: they match 6 instances that are currently running (they had been running on the node that I deleted)20:20
mriedemcfriesen: kvm or ironic service?20:21
cfriesenmriedem: kvm20:21
mriedemheal_allocations is for adding missing allocations to a provider that has instances on it20:21
sean-k-mooneycfriesen: ok so placement still thinks they are running on the wrong node20:22
cfriesenthis is coming from a customer test, but my way of reproducing is to have instances running, then power off the node uncleanly, and then try to delete the node while the automated tools are evacuating the instances that had been running on it.20:22
mriedemas sean-k-mooney said, there are probably allocations from migration records20:23
sean-k-mooneyheal_allocations would add allcotion for the node the vms are now running on but does it also clean up allocation where the vms are nolonger running20:23
mriedemb/c you're deleting during a resize or something20:23
cfriesensean-k-mooney: nope.  there are allocations with the same consumer id but two differnet resource_provider_id20:23
cfriesenmriedem: would there be allocations from the evacuate?20:24
mriedemhttps://bugs.launchpad.net/nova/+bug/179356920:24
openstackLaunchpad bug 1793569 in OpenStack Compute (nova) "Add placement audit commands" [Wishlist,Confirmed]20:24
mriedemcfriesen: i don't think there would be migration consumer allocatoins during an evac,20:25
mriedembut there could be allocations for the instances that were on that evacuated host20:25
sean-k-mooneyi dont think there is either but we should claim resouce on the destiation20:25
cfriesenthey would have all been live-migrated onto that host not too long before I killed the node20:25
mriedemwhen the old host is brought back, it should clean up those evacuated instance allocations on startup20:25
mriedemgibi recently had something merged for evacuate that sounds related https://review.opendev.org/#/c/512623/20:26
sean-k-mooneyoh ya i rember looking at this a few days ago but not having time to review20:28
mriedemcfriesen: see my note on https://review.opendev.org/#/c/657070/2/nova/scheduler/client/report.py as well20:32
sean-k-mooneymriedem: was this the patch you were asking about performace of "x in set()" vs "x in dict()"20:32
mriedemsean-k-mooney: no20:32
sean-k-mooneyok20:32
mriedemanywya, we don't have migration consumers for evac20:32
sean-k-mooneywe dont but we do claim an allcoation candate for teh destination node20:33
*** _hemna has quit IRC20:33
sean-k-mooneybut i dont know if we free the allcoation of the source node in all cases20:33
mriedemcorrect the scheduler will claim (or conductor if you're forcing the dest host) https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L92320:33
mriedemthe source host allocations should be cleaned up when the service is restarted20:34
openstackgerritJohn Garbutt proposed openstack/nova master: WIP: add functional test for admin_password  https://review.opendev.org/66342220:34
cfriesenwhen evacuating an instance, when are the allocations on the old node supposed to be cleaned up?20:34
mriedemin here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L62020:34
mriedemon restart of the service ^20:34
cfriesenokay, so if we never restart the service they'll just stay stale in the allocations table20:34
mriedemright,20:35
sean-k-mooneycfriesen: when you start up the compute agent on the souce node after fixing it meaning you wont be able to delete the RP until after that20:35
mriedembut presumably that node is dead and fenced anyway20:35
mriedemso you're not scheduling to it20:35
cfriesenyeah...the problem is that those allocations prevent us from deleting the resource_provider on compute node deletion20:35
sean-k-mooneymriedem: i think cfriesen was trying to remove teh RP before repovisoing the fixed node20:35
sean-k-mooneycfriesen: why are you delete in the compute node recored out of interest20:36
cfriesencustomer is deleting the node.  no idea why.  testing functionality?20:36
sean-k-mooneyif you are replacing the node with another and reusing the hostname it should not be needed20:36
sean-k-mooneyah ok20:36
sean-k-mooneycustomer always break things20:36
cfriesenwhen we add the new node back in with a different hostname it's all fine20:36
mriedemthe shitty thing i didn't realize until cdent pointed it out in an open review is that https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L2183 won't raise if deleting the provider fails, which means we'll continue to delete the compute service record20:37
cfriesenif we reuse the same hostname we get a different UUID in the compute_node table, but we don't get a new entry in the resource_provider table, so the UUIDs don't match and we never schedule anything to the node20:37
sean-k-mooneycfriesen: if you add it with the same host name it would be fine too just dont delete the compute node recored and it will fix everything up when the compute agent starts20:37
*** BjoernT has joined #openstack-nova20:37
cfriesensean-k-mooney: the compute node record is deleted by running the "delete service" api20:37
sean-k-mooneycfriesen: yes. which you dont need to do to replace teh server20:38
mriedemcfriesen: https://bugs.launchpad.net/nova/+bug/1829479 could also be related to your issue20:38
openstackLaunchpad bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Undecided,Incomplete]20:38
sean-k-mooneyand if you dont delete the compute service record you will get the same uuid when the new agent conencts20:38
cfriesensean-k-mooney: I suspect you're right as a workaround.  but it *should* work in an ideal world. :)20:40
cfriesenmriedem: yeah, that looks like what I'm seeing20:40
sean-k-mooneycfriesen: we could "fix it" by having the compute node when it fails to find a compute node record by hostname first check if there is a placemetn RP by looking it up by hostname and then reuse the uuid of the RP which was the old compute node uuid20:41
openstackgerritJohn Garbutt proposed openstack/nova master: WIP: add functional test for admin_password  https://review.opendev.org/66342220:41
cfriesensean-k-mooney: would work but seems kind of kludgy. can we delete allocations when deleting a resource_provider?20:42
sean-k-mooneywe current dont allow you to delete inventoryes if they have allocatin intentionally20:43
cfriesenI think this code might even have "cascade=true"20:43
sean-k-mooneycfriesen: im pretty sure we intentnioally dont use cascade=true20:44
cfriesensean-k-mooney: it's in here, actually20:44
mriedemcfriesen: ack i left a comment in https://bugs.launchpad.net/nova/+bug/182947920:44
openstackLaunchpad bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Undecided,Incomplete]20:44
*** dave-mccowan has quit IRC20:44
mriedemcfriesen: we do try to delete the allocations,20:45
mriedemthe problem in your case is it's doing it by instances.host,20:45
mriedemwhich if you've evacuated those instances, the instances.host points at the new dest compute20:45
mriedembut the old allocations are still there20:45
mriedemthis could be easily recreated in a functional test i think20:45
mriedem1. create server on host1, 2. force down and evacuate from host1, 3. delete compute service for host1, 4. assert provider and allocs still exist for host1 in placement20:46
mriedemand 5. restart host1 service should blow up20:46
mriedemb/c of the unique constraint on the provider name20:46
cfriesenah, that makes sense20:46
mriedemso https://github.com/openstack/nova/blob/653515a45032811b6bc2f1d0fb651472005496ec/nova/scheduler/client/report.py#L2173 is really just not right for (1) in-progress / unconfirmed migrations and (2) evacuated hosts20:48
cfriesenagreed20:49
mriedemi could start a rolling ball with said functional test to at least recreate the issue so we can throw fixes at it20:49
sean-k-mooneycfriesen: just looking at the placmenet fuctional test tehy expresly check that deleteing allocated resouce provider fails just an fyi https://github.com/openstack/placement/blob/master/placement/tests/functional/db/test_resource_provider.py#L363-L36720:49
cfriesensean-k-mooney: yeah, it's valid that it fails when there are allocations, but setting "cascade=false" is supposed to delete those allocations.  except it doesn't20:50
sean-k-mooney when calling delete_resource_provider20:52
mriedemcfriesen: you mean cascade=true20:52
sean-k-mooneyinitally i assumed when you said cascade=true you were refering to the db schema20:52
cfriesenbah, yes.  cascade=true20:52
mriedemlooks like that code was written specifically for an ironic case https://review.opendev.org/#/c/428375/6/nova/scheduler/client/report.py@77120:52
mriedemso not really thinking about migrations and evacuates and suh20:52
mriedem*such20:52
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Spec to pre-filter disabled computes with placement  https://review.opendev.org/65788420:53
mriedemdansmith: got that spec updated ^20:53
sean-k-mooneyi would need to check the placmeent api to confim but the allocation table has teh RP it was allcaoed from so we should be able to simply look up all the allocation for a given rp then delete tehm assuming that is exposed at the api level20:55
sean-k-mooneywhich i proably is not20:55
icarusfactorCan I have more than one compute_driver for nova.conf or is it limited to only one?20:56
sean-k-mooneyya its not20:56
sean-k-mooneyso we need to add a new endpoint which is /allocations?rp_uuid=XYZ to be be able to do this cleanly20:57
sean-k-mooneyicarusfactor: its one per nova.conf20:58
sean-k-mooneyicarusfactor: but you can have multiple agent on the same host in some cases20:58
sean-k-mooneyicarusfactor: are you trying to run ironc and libvirt on teh same host?20:58
icarusfactorsean-k-mooney, Nifty , I'm running libvirt currently. Was wondering how to do that.20:59
*** pcaruana has quit IRC20:59
sean-k-mooneyits generally not a great idea to do but if you have a second nova.conf that you pass to the second agent you can make it work20:59
icarusfactorsean-k-mooney, Just trying and experimenting with different methods , want to use the Stein docker nova driver.21:00
sean-k-mooneynormally i would recommend running the ironic driver assuming that is the other one you want to use on one of your contoler instead of colcating it on a libvirt compute node21:00
mriedemsean-k-mooney: right i asked that here https://review.opendev.org/#/c/428375/6/nova/scheduler/client/report.py@77121:01
mriedembut never got a response21:01
mriedemwe can get the allocations for a given provider with this API https://developer.openstack.org/api-ref/placement/?expanded=list-resource-provider-allocations-detail#list-resource-provider-allocations21:02
sean-k-mooneyicarusfactor: i had thought that dirver nova docker driver was nolonger mainatined21:02
sean-k-mooneymriedem: oh off the RP endpoint21:03
sean-k-mooneycool ya that seams more sane21:03
icarusfactorsean-k-mooney, Humm, that is what I was wondering , the Dashboard now shows the docker option.21:03
sean-k-mooneyat least that way we cant get out of sync21:03
*** _hemna has joined #openstack-nova21:03
*** brault has joined #openstack-nova21:03
sean-k-mooneyicarusfactor: dashboard as in horizon?21:03
icarusfactorSeeing it in Stien , I was wanting to try this option.21:03
icarusfactoryes21:03
sean-k-mooneyicarusfactor: could that be form zun?21:04
mriedemhttps://review.opendev.org/#/c/657016/ is my change where cdent pointed out that failure to delete the rp doesn't make us fail to delete the compute service21:04
mriedemfinally connecting all the dots21:04
mriedemi'm slow and dumb21:04
icarusfactorsean-k-mooney, Cant answer that.21:04
sean-k-mooneyicarusfactor: https://github.com/openstack/nova-docker21:04
sean-k-mooneyicarusfactor: it proably related to zun21:05
sean-k-mooneymriedem: oh this is a recent change21:05
icarusfactorsean-k-mooney, ok , will check zun out , that helps as I was going /dev/null fast.21:06
mriedemsean-k-mooney: which?21:06
sean-k-mooneyhttps://review.opendev.org/#/c/657016/21:06
sean-k-mooneyits from monday where cdent commented21:06
mriedemi think i wrote that at the ptg,21:08
mriedembut it's a follow on fix to https://review.opendev.org/#/q/I7b8622b178d5043ed1556d7bdceaf60f47e5ac8021:08
mriedemwhich isn't so new21:08
*** brault has quit IRC21:08
sean-k-mooneyoh may 3rd not june 3rd21:08
sean-k-mooneyi miss read teh commit date21:08
mriedemso we used to always orphan the rps when when deleting a compute service,21:08
mriedemthen we tried to delete the rps, but if it failed we still deleted the copute service and didn't try all nodes in the case of ironic,21:09
mriedemnow we realize that we can still fail to delete the rps b/c of evacs and unconfirmed migrations21:09
mriedemso not the worst, but still busted...21:09
mriedemmeanwhile, let's pile a bunch of new code into nova yay wee!!!!21:09
sean-k-mooneyhehe well stephen is trying to delete a tone of it too :)21:10
sean-k-mooneybut im guessing we shoudl update https://github.com/openstack/nova/blob/653515a45032811b6bc2f1d0fb651472005496ec/nova/scheduler/client/report.py#L217321:10
sean-k-mooneyto get teh allcotion form the RP via teh placmeent api right21:10
*** priteau has quit IRC21:10
mriedemstephen is deleting the stuff no one has been using for several years sure :)21:11
sean-k-mooneyand then if we combind that with your change for ironic that might do the right thing21:11
mriedemi need to write the functional recreate test first before we start throwing fixes at it,21:11
mriedembecause there are several issues here i think and i need to start with the tests21:11
sean-k-mooneysure but https://review.opendev.org/#/c/657016/2/nova/api/openstack/compute/services.py is calling delete_resource_provider21:13
mriedemi know21:13
mriedem^ is no worse off than what we have today, it just handles 1:M ironic nodes,21:13
sean-k-mooneyso if we fix and test delete_resource_provider for a singel provider then we can layer your other fix on top.21:14
sean-k-mooneyyes21:14
mriedemcdent's -1 is that the commit message is asserting that if we fail to delete the rp we won't delete the compute service which is false21:14
sean-k-mooneyi think they shoudl stay seperate patches too because its really two sperate problems21:14
mriedemso before refactoring delete_resource_provider and how that works for allocations, i would need to think about whether or not those should be separate changes (i think they should for sanity)21:15
mriedemright21:15
mriedembut right now i have familial duties so can't work on this until tomorrow21:15
sean-k-mooneymriedem: night o/ if you want me to try on work on part of this let me know21:16
sean-k-mooneyi need to go finish some spec reviews from yesterday21:16
*** tjgresha has quit IRC21:18
*** Sundar has joined #openstack-nova21:21
*** rcernin has joined #openstack-nova21:26
*** JamesBen_ has quit IRC21:35
*** _hemna has quit IRC21:36
*** damien_r has quit IRC21:39
*** aram1s has quit IRC21:44
openstackgerritAdam Spiers proposed openstack/nova master: Track inventory for new MEM_ENCRYPTION_CONTEXT resource class  https://review.opendev.org/66210521:45
*** gmann has joined #openstack-nova21:45
*** dave-mccowan has joined #openstack-nova21:47
*** itlinux has quit IRC21:50
*** slaweq has quit IRC21:52
*** Sundar has quit IRC21:52
*** itlinux has joined #openstack-nova21:57
*** whoami-rajat has quit IRC22:00
*** slaweq has joined #openstack-nova22:03
*** rcernin has quit IRC22:04
*** slaweq has quit IRC22:08
*** icarusfactor has quit IRC22:12
openstackgerritAdam Spiers proposed openstack/nova master: Track inventory for new MEM_ENCRYPTION_CONTEXT resource class  https://review.opendev.org/66210522:13
*** icarusfactor has joined #openstack-nova22:13
openstackgerritSundar Nadathur proposed openstack/nova-specs master: Nova Cyborg interaction specification.  https://review.opendev.org/60395522:13
*** icarusfactor has quit IRC22:14
*** icarusfactor has joined #openstack-nova22:15
*** itlinux has quit IRC22:15
*** icarusfactor has quit IRC22:16
*** icarusfactor has joined #openstack-nova22:16
*** icarusfactor has quit IRC22:18
*** mlavalle has quit IRC22:18
*** icarusfactor has joined #openstack-nova22:18
*** icarusfactor has quit IRC22:19
*** icarusfactor has joined #openstack-nova22:20
*** icarusfactor has quit IRC22:21
*** icarusfactor has joined #openstack-nova22:21
*** icarusfactor has quit IRC22:23
*** icarusfactor has joined #openstack-nova22:23
*** icarusfactor has quit IRC22:26
*** icarusfactor has joined #openstack-nova22:26
*** icarusfactor has quit IRC22:28
*** icarusfactor has joined #openstack-nova22:29
*** icarusfactor has quit IRC22:48
*** dave-mccowan has quit IRC22:56
*** tkajinam has joined #openstack-nova23:00
*** artom has joined #openstack-nova23:09
*** JamesBenson has joined #openstack-nova23:12
*** itlinux has joined #openstack-nova23:16
openstackgerritArtom Lifshitz proposed openstack/nova master: Run revert resize tests in nova-live-migration  https://review.opendev.org/65349823:26
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug  https://review.opendev.org/64488123:26
openstackgerritArtom Lifshitz proposed openstack/nova master: [DNM] use iptables in nova-multinode  https://review.opendev.org/66078223:26
artommriedem, dansmith, think I got everything ^^ Don't expect anything else to happen tonight, I'm gone after this anyways, just an FYI23:27
artom*I don't expect23:27
*** JamesBenson has quit IRC23:32
*** _hemna has joined #openstack-nova23:33
*** claudiub has quit IRC23:42
*** luksky has quit IRC23:46
*** itlinux has quit IRC23:46
*** slaweq has joined #openstack-nova23:48
*** brinzhang has joined #openstack-nova23:48
*** frankwang has joined #openstack-nova23:51

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!