| mnaser | i mean | 00:00 |
|---|---|---|
| melwitt | sean-k-mooney: well, at least I didn't think it's related, but wasn't thinking in that direction at all tbh | 00:00 |
| *** tbachman has quit IRC | 00:00 | |
| mnaser | oh this is interesting | 00:00 |
| mnaser | the compute service is getting a messagingtimeout | 00:00 |
| mnaser | even though conductor is up | 00:00 |
| melwitt | yeah, it should be recovering on its own | 00:00 |
| sean-k-mooney | melwitt: ok i just wondered since you were suggesting the vnc console call | 00:00 |
| mnaser | just looping on "Timed out waiting for reply.." | 00:01 |
| *** tbachman has joined #openstack-nova | 00:01 | |
| *** panda has quit IRC | 00:01 | |
| melwitt | sean-k-mooney: haha no, we were just trying to see if the cast vs call behavior was consistent | 00:01 |
| sean-k-mooney | just got back to the start of the converstation so now have a bit more context | 00:01 |
| mnaser | i'll try restarting it (i have bunch of other computes that are broken so at least it will say if a restart fixes it) | 00:01 |
| mnaser | ill still have a one in broken state | 00:01 |
| melwitt | good thing you have a lot of broken computes huh! | 00:02 |
| mnaser | hah | 00:02 |
| mnaser | looks like it's not going up, the capabilities xml string just got logged and its stuck | 00:02 |
| sean-k-mooney | we had an upstream or posible downstream bug that was similar to this | 00:02 |
| sean-k-mooney | not to long ago | 00:02 |
| mnaser | i assume it'll just blow up now complaining the message timed out | 00:03 |
| melwitt | hm, weird | 00:03 |
| melwitt | sean-k-mooney: lettuce know if you have any links | 00:03 |
| * mnaser restart in debug | 00:03 | |
| *** panda has joined #openstack-nova | 00:04 | |
| mnaser | sigh. | 00:04 |
| mnaser | two restarts and it works now. | 00:04 |
| mnaser | or 3 rather | 00:05 |
| mnaser | (that specific compute node works rather) | 00:05 |
| mnaser | the rest still broken | 00:05 |
| melwitt | 3 restarts made it work but not 1? | 00:05 |
| melwitt | ... | 00:05 |
| mnaser | yep, first restart it was hung | 00:06 |
| melwitt | O.o | 00:06 |
| mnaser | restarted once with debug enabled and accidnetally log levels without an s, restarted again right away with an s and it went up fine. | 00:06 |
| mnaser | wait | 00:06 |
| mnaser | it might actually have been okay | 00:06 |
| mnaser | the first time :\ | 00:06 |
| melwitt | ok, that is the only thing that could make sense there otherwise....mind blown | 00:07 |
| mnaser | let me see whta happened with th broken ones | 00:07 |
| sean-k-mooney | hehe if its a case that debug mode fixes it calling dibs on not finding out why :P | 00:07 |
| mnaser | hmm, looks like its been doing the same thing | 00:08 |
| mnaser | looping forever in messagingtimeout | 00:08 |
| mnaser | without recover | 00:08 |
| mnaser | it looks like its flapping | 00:08 |
| mnaser | http://paste.openstack.org/show/752617/ | 00:09 |
| sean-k-mooney | could it be a network/loadblancer issue | 00:10 |
| *** dpawlik has joined #openstack-nova | 00:10 | |
| melwitt | looks like that "Recovering" message is a lie. it always resets itself to that when catching Exception | 00:11 |
| *** slaweq has joined #openstack-nova | 00:11 | |
| sean-k-mooney | all of the rabbit nodes are now back up and in a quoram right | 00:11 |
| melwitt | https://github.com/openstack/nova/blob/master/nova/servicegroup/drivers/db.py#L98 | 00:11 |
| melwitt | so it doesn't mean anything like it's reconnected, it hasn't | 00:11 |
| mnaser | sean-k-mooney: yes | 00:13 |
| mnaser | oslo.messaging._drivers.impl_rabbit [-] Failed to consume message from queue: Queue.declare: (404) NOT_FOUND - failed to perform operation on queue 'compute' in vhost '/nova' due to timeout: NotFound: Queue.declare: (404) NOT_FOUND - failed to perform operation on queue 'compute' in vhost '/nova' due to timeout | 00:14 |
| mnaser | i wonder if the queue.declare is not recoverable | 00:14 |
| *** dpawlik has quit IRC | 00:14 | |
| sean-k-mooney | this is looking more an more familar with the other rabbitmq issues we were debuging | 00:15 |
| mnaser | i wonder if this fails, and then when i restart the control plane, they declare the queues | 00:16 |
| mnaser | and then you kinda have two refs of bindings | 00:16 |
| sean-k-mooney | this might be related https://bugs.launchpad.net/nova/+bug/1794706 | 00:16 |
| openstack | Launchpad bug 1794706 in OpenStack Compute (nova) "The instance left stuck when oslo.messaging raised MessageDeliveryFailure exception" [Undecided,In progress] - Assigned to Tao Li (eric-litao) | 00:16 |
| *** mriedem has joined #openstack-nova | 00:17 | |
| melwitt | if that's happening, mnaser should see a trace for MessageDeliveryFailure in the logs | 00:17 |
| sean-k-mooney | mnaser: when we were debugging the wsgi issue i think there was a question over would the connection recovery in oslo.messaging probaly redeclare the queue | 00:17 |
| mnaser | i have a bunch of those melwitt | 00:19 |
| melwitt | ohhhh damn | 00:20 |
| mnaser | Unable to connect to AMQP server on ctl1-xxxxx.vexxhost.cn:5671 after inf tries: Server unexpectedly closed connection | 00:20 |
| mnaser | looks like it gives up | 00:20 |
| sean-k-mooney | that is from here https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_rabbit.py#L767 | 00:21 |
| sean-k-mooney | i think https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_rabbit.py#L793 should redeclare teh queue | 00:22 |
| sean-k-mooney | but im not 100% sure about that | 00:23 |
| *** gyee has quit IRC | 00:23 | |
| sean-k-mooney | we should call that on reconnection https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_rabbit.py#L732 | 00:23 |
| *** slaweq has quit IRC | 00:24 | |
| sean-k-mooney | and before we execute the publish https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_rabbit.py#L741 | 00:24 |
| mnaser | indeed that adds up | 00:24 |
| sean-k-mooney | but i think that is only creating the consumer queues | 00:24 |
| sean-k-mooney | it may not be creating the targe topic queue | 00:24 |
| melwitt | mnaser: in which service(s) do you see MessageDeliveryFailure? I want to add more info that the LP bug | 00:25 |
| mnaser | nova-compute | 00:25 |
| sean-k-mooney | i wonder if _set_current_channel shoudl be ensuring all the exchanges and topic queus are created? | 00:26 |
| melwitt | hm.. not what I expected. I thought instance stuck in scheduling state does not reach compute | 00:26 |
| melwitt | so we wouldn't be able to handle it and put instance into ERROR state | 00:26 |
| mnaser | i wonder if this is a multithread/proc problem | 00:27 |
| mnaser | i mean i see a few reconnects after the disconnect | 00:27 |
| mnaser | and the reconnect is to different rabbitmq servers | 00:28 |
| *** markvoelker has joined #openstack-nova | 00:29 | |
| sean-k-mooney | mnaser: what is the topic/queue name its trying to publish too? | 00:29 |
| *** mriedem has quit IRC | 00:30 | |
| mnaser | thats not logged (not running in debug unfortunately) | 00:30 |
| sean-k-mooney | oh it is | 00:30 |
| sean-k-mooney | it was the compute queue on the /nova vhost | 00:30 |
| sean-k-mooney | the /nova vhost is the exchange name right? | 00:30 |
| mnaser | let me check | 00:31 |
| mnaser | seeing a bunch of nova.*, amq.*, reply_* and compute_* one | 00:31 |
| mnaser | i wonder if the compute_fanout was the missing one | 00:32 |
| sean-k-mooney | in theory if we we declared the fanout consuemr using https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_rabbit.py#L1086 | 00:33 |
| sean-k-mooney | when we created the connection it should be in our consumeer list and we shoudl hav erecreated it | 00:33 |
| melwitt | I added a comment to the LP bug | 00:34 |
| sean-k-mooney | but if we dont make our selves a consumer of a queue then we wont recarte it | 00:34 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299 | 00:34 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344 | 00:34 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673 | 00:35 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.opendev.org/576676 | 00:35 |
| mnaser | sean-k-mooney: but then if restarting recreates things, why dont the existing computes start working | 00:36 |
| mnaser | ooooooh hold on | 00:36 |
| mnaser | compute.<hostname> queue only exists for the one that i restarted. | 00:36 |
| mnaser | so when it recovers, its not declaring that again. nb: i don't know much about rabbitmq | 00:37 |
| sean-k-mooney | mnaser: yes its not the fanout queue its the topic queue for that host | 00:37 |
| *** igordc has joined #openstack-nova | 00:38 | |
| sean-k-mooney | e.g. the one that is used for calls | 00:39 |
| sean-k-mooney | mnaser: you could enable Durable queues on the rabbit side | 00:39 |
| mnaser | yeah.. i'm trying to find where that all gets declared | 00:40 |
| sean-k-mooney | we might have a config option for that | 00:40 |
| sean-k-mooney | in oslo its one of these two fucntion https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_rabbit.py#L1051-L1084 | 00:41 |
| sean-k-mooney | setting https://docs.openstack.org/nova/latest/configuration/config.html#oslo-messaging-rabbit will likely help | 00:42 |
| mnaser | yeah i guess, i just kinda wanna get to the bottom of it too | 00:42 |
| mnaser | openstack/nova doesnt seem to define any declare_topic_consumer | 00:43 |
| sean-k-mooney | well it will help by masking the issue so the queue persist across rabbit reboots but ya we should fix it | 00:43 |
| *** hongbin has quit IRC | 00:44 | |
| mnaser | imstruggling to find what creates those queues in nova | 00:46 |
| sean-k-mooney | i might be this https://github.com/openstack/nova/blob/master/nova/rpc.py#L66-L92 | 00:47 |
| mnaser | no hits on declare_topic_consumer | 00:47 |
| sean-k-mooney | actully i think its via this https://github.com/openstack/nova/blob/013aa1915c79cfcb90c4333ce1e16b3c40f16be8/nova/service.py#L184-L192 | 00:51 |
| mnaser | https://github.com/openstack/oslo.messaging/blob/40c25c2bde6d2f5a756e7169060b7ce389caf174/oslo_messaging/_drivers/amqpdriver.py#L650-L665 | 00:51 |
| sean-k-mooney | yes so https://github.com/openstack/nova/blob/013aa1915c79cfcb90c4333ce1e16b3c40f16be8/nova/service.py#L186 | 00:52 |
| sean-k-mooney | is where in the base nova serivce calse we declar the target for an rpc to the service based on the topic and host | 00:52 |
| mnaser | i think that is not being recreated.. | 00:54 |
| *** frankwang has joined #openstack-nova | 00:54 | |
| openstackgerrit | Daniel Speichert proposed openstack/nova-specs master: Directly download and upload images to RBD https://review.opendev.org/658903 | 00:54 |
| sean-k-mooney | i think so too | 00:55 |
| sean-k-mooney | it intally gets created here https://github.com/openstack/nova/blob/013aa1915c79cfcb90c4333ce1e16b3c40f16be8/nova/cmd/compute.py#L56-L58 | 00:55 |
| sean-k-mooney | when we start the agent | 00:55 |
| mnaser | and i think that ends up all the way down here when it starts listneing https://github.com/openstack/oslo.messaging/blob/40c25c2bde6d2f5a756e7169060b7ce389caf174/oslo_messaging/_drivers/amqpdriver.py#L650-L665 | 00:56 |
| mnaser | but declare_topic_consumer doesnt store state or anything, it just does it one time | 00:56 |
| mnaser | so if the queue disappears, declare_topic_consumer technically never runs | 00:56 |
| sean-k-mooney | right so we need to add it to our consumers | 00:57 |
| sean-k-mooney | that said | 00:58 |
| sean-k-mooney | https://github.com/openstack/oslo.messaging/blob/40c25c2bde6d2f5a756e7169060b7ce389caf174/oslo_messaging/_drivers/impl_rabbit.py#L946-L969 | 00:58 |
| sean-k-mooney | i think that shoudl be happening already | 00:58 |
| sean-k-mooney | so set_current_channel shoudl redeclar it here https://github.com/openstack/oslo.messaging/blob/40c25c2bde6d2f5a756e7169060b7ce389caf174/oslo_messaging/_drivers/impl_rabbit.py#L792-L793 | 01:00 |
| sapd1 | Hi everyone, I would like to regenerate metadata/properties in libvirt xml (I mean virsh dumpxml output) with running instances. How can I do that without reboot instances :D | 01:01 |
| sean-k-mooney | we do not call self._set_current_channel here however https://github.com/openstack/oslo.messaging/blob/40c25c2bde6d2f5a756e7169060b7ce389caf174/oslo_messaging/_drivers/impl_rabbit.py#L756 | 01:01 |
| sean-k-mooney | sapd1: you cant really what are you actully trying to do | 01:02 |
| mnaser | i didn't hit that ecxeption i think | 01:02 |
| *** markvoelker has quit IRC | 01:02 | |
| sean-k-mooney | sapd1: i mean you can update the xml with virsh edit but im not sure why you want to modify the metadata in the xml | 01:03 |
| *** _hemna has quit IRC | 01:03 | |
| sean-k-mooney | mnaser: ya if you are hitting the generic exception below that you shoudl end up redeclarign the queue | 01:03 |
| sean-k-mooney | mnaser: but that willl only happen after the heartbeat detects the connection is broken | 01:04 |
| sean-k-mooney | or you try to send an rpc form the compute node | 01:04 |
| mnaser | Failed to declare consumer for topic 'compute': Queue.declare: (404) NOT_FOUND - failed to perform operation on queue 'compute' in vhost '/nova' due to timeout: NotFound: Queue.declare: (404) NOT_FOUND - failed to perform operation on queue 'compute' in vhost '/nova' due to timeout | 01:05 |
| sean-k-mooney | mnaser: i think the issue is the api is not ensuring the queue exists before calling the compute node | 01:05 |
| mnaser | should the api ensure it exists though, or should the service recreate it when recovering? | 01:06 |
| sean-k-mooney | why not both | 01:06 |
| sapd1 | sean-k-mooney, ah. I put some key/value in properties option of each instance (our monitoring service), I have tried write a function to generate these properties when instances are created. But I want to update these properties after that. | 01:06 |
| sean-k-mooney | the api could ensure it exists so that the message is there for when the compute connects | 01:06 |
| *** slaweq has joined #openstack-nova | 01:06 | |
| sean-k-mooney | sapd1: right ... | 01:07 |
| sean-k-mooney | sapd1: virsh edit is your best bet but when you say you added a fucntion do you mean in the nova code | 01:07 |
| sean-k-mooney | because as im sure you know we delete and recreate teh domain every time we start/stop/hard-reboot the instance | 01:08 |
| sean-k-mooney | so if you did not modify nova those metadata values would be lost on basically any lifecycle operation | 01:09 |
| sean-k-mooney | generally form monitoring you better just pulling the instance uuid form the metadata and doing the corralation based on that | 01:09 |
| sapd1 | sean-k-mooney, I have handled these actions bro, I have modified this function to generate xml with properties (https://github.com/openstack/nova/blob/b0e71d80c3/nova/virt/libvirt/driver.py#L4271 | 01:10 |
| sapd1 | then if the instance is rebooted or hard-rebooted, It's still ok. | 01:10 |
| sapd1 | sean-k-mooney, in my case, this is a special requirement :D | 01:11 |
| mnaser | operation queue.declare caused a channel exception not_found: failed to perform operation on queue 'scheduler.ctl2-xxxxxx.vexxhost.cn' in vhost '/nova' due to timeout | 01:11 |
| sean-k-mooney | hehe ok ya that shoudl work. any reaon not to push the extra metadata upstream or is it specifc to your deployment | 01:11 |
| mnaser | that's from the rabbitmq logs | 01:11 |
| mnaser | it means that for some reason, its actually rabbitmq thats not lteting it declare? | 01:12 |
| sean-k-mooney | mnaser: im not sure what it means by channel exception not_found but ill ask google | 01:12 |
| mnaser | yeah im trying to ask google too | 01:12 |
| sapd1 | sean-k-mooney, it's a specific for my deployment :) | 01:12 |
| sean-k-mooney | mnaser: Binding a non-existing queue or a non-existing exchange will fail with a 404 NOT_FOUND error | 01:13 |
| sean-k-mooney | https://www.rabbitmq.com/channels.html | 01:14 |
| mnaser | i wonder if it tries to declare, fails, then binds, and fails, and then bombs out | 01:14 |
| sapd1 | sean-k-mooney, Does my case related this function (https://github.com/openstack/nova/blob/6657339a7393226c72b9c8a293a6b92695ecb4cb/nova/virt/driver.py#L1374)? | 01:18 |
| mnaser | bleh, i've been at this for 2.5h -- i dunno what to do at this point, its a bit too much | 01:18 |
| mnaser | https://github.com/rabbitmq/rabbitmq-server/issues/959 | 01:19 |
| sean-k-mooney | mnaser: i would proably set the quese to durable and enabel auto delete if this is an issue for you on production | 01:19 |
| mnaser | i wonder if this has to do with this | 01:19 |
| sean-k-mooney | at least untill we figure this out more direclty | 01:19 |
| *** slaweq has quit IRC | 01:19 | |
| mnaser | yeah ill just work around it for now.. my brain is toast | 01:21 |
| mnaser | and there you go, restarted them all, went into spawning state | 01:22 |
| mnaser | i bet neutron is suffering from teh same thing | 01:22 |
| sean-k-mooney | https://bugs.launchpad.net/oslo.messaging/+bug/1661510 | 01:22 |
| openstack | Launchpad bug 1661510 in oslo.messaging "topic_send may loss messages if the queue not exists" [Medium,In progress] - Assigned to Gabriele Santomaggio (gsantomaggio) | 01:22 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.opendev.org/576689 | 01:23 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.opendev.org/576709 | 01:23 |
| sean-k-mooney | mnaser: i think https://bugs.launchpad.net/oslo.messaging/+bug/1661510 is basically the issue right | 01:23 |
| openstack | Launchpad bug 1661510 in oslo.messaging "topic_send may loss messages if the queue not exists" [Medium,In progress] - Assigned to Gabriele Santomaggio (gsantomaggio) | 01:23 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.opendev.org/576712 | 01:23 |
| sean-k-mooney | https://bugs.launchpad.net/oslo.messaging/+bug/1437955 seams to be also related | 01:27 |
| openstack | Launchpad bug 1437955 in oslo.messaging "RPC calls and responses do not use the mandatory flag (AMQP)" [Wishlist,Confirmed] - Assigned to Gabriele Santomaggio (gsantomaggio) | 01:27 |
| mnaser | sean-k-mooney: that seems exactly it | 01:29 |
| sean-k-mooney | mnaser: melwitt so i cuess we want to encourage https://review.opendev.org/#/c/660373/ | 01:30 |
| mnaser | sean-k-mooney: I guess so! | 01:45 |
| sean-k-mooney | the current approch would require nova to be modified to handel the retry whic may or may not be what we want | 01:45 |
| sean-k-mooney | i left some feed back in the review | 01:46 |
| sean-k-mooney | but its shoudl help even if we need to do some extra work as a consumer of oslo.messaging | 01:46 |
| sean-k-mooney | mnaser: i was tired and when to sleep for 4 hours so while its 2 am from me here it must be getting pretty late for you | 01:47 |
| sean-k-mooney | well almost 3 but as i said i alreay got some sleep | 01:48 |
| mnaser | sean-k-mooney: where are you based out of? | 01:54 |
| sean-k-mooney | ireland | 01:54 |
| sean-k-mooney | but i tend to shift my day to overlap with the us more | 01:55 |
| * sean-k-mooney because im not a morning person and that a valid excusse :P | 01:55 | |
| sean-k-mooney | i would normally end my day and go to sleep at aound 1 am but i was tired and went to bed at 8pm today but when i do that i never get more then about 4 hours and then i get up and work for a bit and typically go back to sleep around 3-4 ish | 01:57 |
| sean-k-mooney | or 8-9 ish if my sleeping pattern is totally messed up | 01:58 |
| *** ccstone has joined #openstack-nova | 01:59 | |
| *** markvoelker has joined #openstack-nova | 01:59 | |
| *** frankwang has quit IRC | 02:01 | |
| *** tinwood has quit IRC | 02:10 | |
| *** dpawlik has joined #openstack-nova | 02:11 | |
| *** slaweq has joined #openstack-nova | 02:11 | |
| *** tinwood has joined #openstack-nova | 02:11 | |
| *** bbowen__ has quit IRC | 02:15 | |
| *** dpawlik has quit IRC | 02:15 | |
| *** slaweq has quit IRC | 02:24 | |
| *** dpawlik has joined #openstack-nova | 02:27 | |
| *** sean-k-mooney has quit IRC | 02:28 | |
| *** dpawlik has quit IRC | 02:32 | |
| *** markvoelker has quit IRC | 02:32 | |
| *** JamesBenson has joined #openstack-nova | 02:50 | |
| *** threestrands has joined #openstack-nova | 02:54 | |
| *** sean-k-mooney has joined #openstack-nova | 03:00 | |
| *** bbowen__ has joined #openstack-nova | 03:07 | |
| *** whoami-rajat has joined #openstack-nova | 03:10 | |
| *** slaweq has joined #openstack-nova | 03:11 | |
| *** sean-k-mooney has quit IRC | 03:14 | |
| *** sean-k-mooney has joined #openstack-nova | 03:16 | |
| *** JamesBenson has quit IRC | 03:23 | |
| *** JamesBenson has joined #openstack-nova | 03:24 | |
| *** slaweq has quit IRC | 03:25 | |
| *** igordc has quit IRC | 03:25 | |
| openstackgerrit | Daniel Speichert proposed openstack/nova-specs master: Directly download and upload images to RBD https://review.opendev.org/658903 | 03:28 |
| *** JamesBenson has quit IRC | 03:28 | |
| *** BjoernT has joined #openstack-nova | 03:31 | |
| *** BjoernT_ has joined #openstack-nova | 03:35 | |
| *** BjoernT has quit IRC | 03:36 | |
| *** ratailor has joined #openstack-nova | 03:54 | |
| *** threestrands has quit IRC | 04:12 | |
| *** slaweq has joined #openstack-nova | 04:16 | |
| *** sean-k-mooney has quit IRC | 04:19 | |
| *** lbragstad has quit IRC | 04:20 | |
| *** sean-k-mooney has joined #openstack-nova | 04:21 | |
| *** slaweq has quit IRC | 04:24 | |
| *** markvoelker has joined #openstack-nova | 04:30 | |
| *** udesale has joined #openstack-nova | 04:31 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Introduces the openstacksdk to nova https://review.opendev.org/643664 | 04:32 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use OpenStack SDK for placement https://review.opendev.org/656023 | 04:32 |
| *** dpawlik has joined #openstack-nova | 04:43 | |
| *** dpawlik has quit IRC | 04:48 | |
| *** BjoernT_ has quit IRC | 04:53 | |
| *** frankwang has joined #openstack-nova | 04:58 | |
| *** frankwang has quit IRC | 05:02 | |
| *** markvoelker has quit IRC | 05:03 | |
| *** slaweq has joined #openstack-nova | 05:13 | |
| *** slaweq has quit IRC | 05:24 | |
| *** dpawlik has joined #openstack-nova | 05:30 | |
| *** slaweq has joined #openstack-nova | 05:32 | |
| *** kaisers has quit IRC | 05:37 | |
| *** kaisers has joined #openstack-nova | 05:40 | |
| *** ratailor_ has joined #openstack-nova | 05:43 | |
| *** ratailor has quit IRC | 05:43 | |
| *** luksky has joined #openstack-nova | 05:44 | |
| *** slaweq has quit IRC | 05:44 | |
| *** markvoelker has joined #openstack-nova | 06:00 | |
| *** boxiang has joined #openstack-nova | 06:05 | |
| *** boxiang has quit IRC | 06:07 | |
| *** bhagyashris has joined #openstack-nova | 06:18 | |
| *** lpetrut has joined #openstack-nova | 06:19 | |
| *** sapd1_x has joined #openstack-nova | 06:21 | |
| *** hoonetorg has quit IRC | 06:21 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:32 | |
| *** markvoelker has quit IRC | 06:32 | |
| *** itlinux_ has joined #openstack-nova | 06:34 | |
| *** itlinux has quit IRC | 06:34 | |
| *** pcaruana has joined #openstack-nova | 06:35 | |
| *** hoonetorg has joined #openstack-nova | 06:38 | |
| *** itlinux_ has quit IRC | 06:54 | |
| *** damien_r has joined #openstack-nova | 06:56 | |
| *** slaweq has joined #openstack-nova | 06:59 | |
| *** itlinux has joined #openstack-nova | 06:59 | |
| *** itlinux has quit IRC | 07:05 | |
| *** tssurya has joined #openstack-nova | 07:07 | |
| *** ttsiouts has joined #openstack-nova | 07:08 | |
| *** mvkr has joined #openstack-nova | 07:09 | |
| *** tesseract has joined #openstack-nova | 07:09 | |
| *** itlinux has joined #openstack-nova | 07:12 | |
| *** imacdonn has quit IRC | 07:16 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: WIP:Specify availability_zone to unshelve https://review.opendev.org/663851 | 07:20 |
| *** dtantsur|afk is now known as dtantsur | 07:20 | |
| *** ttsiouts has quit IRC | 07:25 | |
| *** brinzhang has quit IRC | 07:26 | |
| *** ttsiouts has joined #openstack-nova | 07:26 | |
| *** ttsiouts_ has joined #openstack-nova | 07:28 | |
| *** markvoelker has joined #openstack-nova | 07:30 | |
| *** ttsiouts has quit IRC | 07:30 | |
| *** ttsiouts_ has quit IRC | 07:38 | |
| *** mcgigglier has joined #openstack-nova | 07:38 | |
| *** ttsiouts has joined #openstack-nova | 07:39 | |
| *** ccamacho has joined #openstack-nova | 07:41 | |
| *** ttsiouts has quit IRC | 07:43 | |
| *** jaosorior has joined #openstack-nova | 07:51 | |
| *** xek has joined #openstack-nova | 07:51 | |
| kashyap | sean-k-mooney: Yeah, I _did_ see the obscure "vm_mode" yesterday, and reading its documentation. It is a Xen-related term, but used as a general abstraction in Nova to represent any hypervisor | 07:55 |
| *** rcernin has quit IRC | 07:55 | |
| kashyap | tonyb: I wanted to do some tests on AArch64 host; got it from another dev. | 07:56 |
| kashyap | efried: No, that "pick guest arch" Blueprint is not for Train. (It's Tech Debt) | 07:56 |
| *** ralonsoh has joined #openstack-nova | 07:59 | |
| *** ttsiouts has joined #openstack-nova | 08:00 | |
| *** takashin has left #openstack-nova | 08:03 | |
| *** markvoelker has quit IRC | 08:03 | |
| *** JamesBenson has joined #openstack-nova | 08:08 | |
| *** JamesBenson has quit IRC | 08:12 | |
| *** sapd1_x has quit IRC | 08:15 | |
| *** trident has quit IRC | 08:35 | |
| *** derekh has joined #openstack-nova | 08:37 | |
| *** trident has joined #openstack-nova | 08:37 | |
| *** imacdonn has joined #openstack-nova | 08:37 | |
| tonyb[m] | kashyap: okay have fun | 08:39 |
| *** markvoelker has joined #openstack-nova | 09:00 | |
| *** mdbooth_ is now known as mdbooth | 09:05 | |
| *** _hemna has joined #openstack-nova | 09:12 | |
| *** davidsha has joined #openstack-nova | 09:12 | |
| *** _hemna has quit IRC | 09:16 | |
| *** cdent has joined #openstack-nova | 09:20 | |
| *** sapd1_x has joined #openstack-nova | 09:23 | |
| *** priteau has joined #openstack-nova | 09:25 | |
| *** zbr has joined #openstack-nova | 09:29 | |
| *** jaosorior has quit IRC | 09:30 | |
| *** markvoelker has quit IRC | 09:32 | |
| *** tkajinam has quit IRC | 09:37 | |
| *** lpetrut has quit IRC | 09:38 | |
| *** jaosorior has joined #openstack-nova | 09:47 | |
| *** jbernard has quit IRC | 09:49 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fold ComputeManager._resize to its only caller https://review.opendev.org/663873 | 09:50 |
| *** bhagyashris has quit IRC | 09:55 | |
| *** lpetrut has joined #openstack-nova | 10:04 | |
| *** lpetrut has quit IRC | 10:04 | |
| *** lpetrut has joined #openstack-nova | 10:05 | |
| *** luksky has quit IRC | 10:11 | |
| *** jaosorior has quit IRC | 10:13 | |
| *** sapd1_x has quit IRC | 10:18 | |
| stephenfin | RuntimeError: On Python 3, zvm sdk supports to Python 3.6 | 10:23 |
| stephenfin | and all I want to do is build docs | 10:23 |
| stephenfin | We need to find some way to move that out of requirements.txt. More hassle than it's worth. | 10:24 |
| *** ttsiouts has quit IRC | 10:24 | |
| *** ttsiouts has joined #openstack-nova | 10:25 | |
| *** ociuhandu has joined #openstack-nova | 10:25 | |
| *** ttsiouts has quit IRC | 10:29 | |
| *** ociuhandu has quit IRC | 10:30 | |
| *** ociuhandu has joined #openstack-nova | 10:31 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: docs: Don't version links to reno docs https://review.opendev.org/662178 | 10:37 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: tox: Use basepython of python3.5 https://review.opendev.org/663887 | 10:37 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: tox: Stop build *all* docs in 'docs' https://review.opendev.org/663888 | 10:37 |
| *** zbr is now known as zbr|rover | 10:44 | |
| *** luksky has joined #openstack-nova | 10:49 | |
| *** francoisp has quit IRC | 10:53 | |
| *** udesale has quit IRC | 10:53 | |
| *** udesale has joined #openstack-nova | 10:53 | |
| *** janki has joined #openstack-nova | 10:57 | |
| *** ttsiouts has joined #openstack-nova | 10:57 | |
| *** cdent has quit IRC | 11:00 | |
| *** jaypipes has joined #openstack-nova | 11:01 | |
| *** ttsiouts has quit IRC | 11:01 | |
| *** ttsiouts has joined #openstack-nova | 11:01 | |
| *** cdent has joined #openstack-nova | 11:01 | |
| *** jaosorior has joined #openstack-nova | 11:07 | |
| *** jbernard has joined #openstack-nova | 11:16 | |
| *** xek has quit IRC | 11:29 | |
| *** markvoelker has joined #openstack-nova | 11:30 | |
| sean-k-mooney | just an fyi but i have marked https://blueprints.launchpad.net/nova/+spec/libvirt-neutron-sriov-livemigration as implemented/complete since the documentation update we were waiting for is now merged in neutron. | 11:40 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova-specs master: Enable rebuild for instances in cell0 https://review.opendev.org/648686 | 11:48 |
| *** xek has joined #openstack-nova | 11:53 | |
| *** ratailor_ has quit IRC | 12:01 | |
| *** francoisp has joined #openstack-nova | 12:03 | |
| *** markvoelker has quit IRC | 12:03 | |
| *** udesale has quit IRC | 12:10 | |
| *** udesale has joined #openstack-nova | 12:11 | |
| *** slaweq_ has joined #openstack-nova | 12:23 | |
| *** slaweq has quit IRC | 12:27 | |
| *** udesale has quit IRC | 12:27 | |
| *** udesale has joined #openstack-nova | 12:27 | |
| *** aloga has quit IRC | 12:27 | |
| *** lpetrut has quit IRC | 12:27 | |
| *** aloga has joined #openstack-nova | 12:28 | |
| openstackgerrit | Merged openstack/nova master: Make nova-next archive using --before https://review.opendev.org/661002 | 12:28 |
| *** dansmith has quit IRC | 12:29 | |
| *** dansmith has joined #openstack-nova | 12:32 | |
| *** artom has quit IRC | 12:35 | |
| openstackgerrit | Merged openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.opendev.org/641806 | 12:35 |
| openstackgerrit | Merged openstack/nova master: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/658904 | 12:35 |
| *** rtjure has joined #openstack-nova | 12:40 | |
| *** markvoelker has joined #openstack-nova | 12:49 | |
| openstackgerrit | Dr. Clemens Hardewig proposed openstack/nova master: Fixes instance resizing/migration when swap volume is on lvm https://review.opendev.org/618621 | 12:50 |
| openstackgerrit | Dr. Clemens Hardewig proposed openstack/nova master: This patch is to fix bug #1831657 https://review.opendev.org/663926 | 12:50 |
| openstack | bug 1831657 in OpenStack Compute (nova) "Instance migration/Instance resize with lvm volumes" [Undecided,New] https://launchpad.net/bugs/1831657 | 12:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'ComputeManager._reschedule' https://review.opendev.org/660774 | 12:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance' https://review.opendev.org/651311 | 12:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312 | 12:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313 | 12:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314 | 12:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527 | 12:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reno for removed cells v1 policies https://review.opendev.org/662031 | 12:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411 | 12:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950 | 12:57 |
| stephenfin | gibi++ | 12:58 |
| stephenfin | Thanks for taking a look at those tests | 12:58 |
| *** ttsiouts has quit IRC | 13:01 | |
| *** lbragstad has joined #openstack-nova | 13:03 | |
| *** janki has quit IRC | 13:04 | |
| *** janki has joined #openstack-nova | 13:04 | |
| *** cdent has quit IRC | 13:06 | |
| *** ttsiouts has joined #openstack-nova | 13:08 | |
| *** mvkr has quit IRC | 13:09 | |
| *** mriedem has joined #openstack-nova | 13:10 | |
| *** BjoernT has joined #openstack-nova | 13:20 | |
| *** priteau has quit IRC | 13:23 | |
| *** lbragstad_ has joined #openstack-nova | 13:26 | |
| *** dpawlik has quit IRC | 13:27 | |
| *** lbragstad has quit IRC | 13:27 | |
| *** BjoernT_ has joined #openstack-nova | 13:28 | |
| mriedem | stephenfin: gibi: comments inline on https://review.opendev.org/#/c/660774/ | 13:28 |
| mriedem | for the notification sample test weirdness | 13:29 |
| stephenfin | in a meeting but I'll look after | 13:29 |
| stephenfin | mriedem: Actually, I did try to that. It failed miserably | 13:30 |
| stephenfin | The issue that I pointed out previously is that I want the call to succeed in the other places it's called | 13:31 |
| stephenfin | And just stub out that one caller | 13:31 |
| *** BjoernT has quit IRC | 13:31 | |
| gibi | stephenfin, mriedem: I can try to iterate on those tests sometime next week | 13:31 |
| *** tbachman has quit IRC | 13:31 | |
| *** rtjure has quit IRC | 13:32 | |
| *** tbachman has joined #openstack-nova | 13:33 | |
| *** priteau has joined #openstack-nova | 13:38 | |
| *** lbragstad_ is now known as lbragstad | 13:38 | |
| mriedem | i can play with it, maybe 3 sets of eyes can sort it out | 13:40 |
| *** rtjure has joined #openstack-nova | 13:42 | |
| *** artom has joined #openstack-nova | 13:42 | |
| gibi | mriedem: one hint, in those resize sample tests there is only one compute (as far as I see) but still there is a successfull re-schedule attempt | 13:42 |
| mriedem | which is totally unrealistic but ok | 13:43 |
| mriedem | maybe it's not unrealistic i guess, hard to know how this flow really works | 13:44 |
| mriedem | it would be unrealistic to reschedule and land back on the same host | 13:44 |
| sean-k-mooney | gibi: a rescuderl would only work in that case if the retry filter is disabled | 13:44 |
| gibi | mriedem: that two test are totally unrealistic :/ | 13:45 |
| mriedem | we don't go back through the scheduler on a reschedule | 13:45 |
| mriedem | since queens | 13:45 |
| gibi | mriedem: fault injection is hard | 13:45 |
| mriedem | in fact we could probably deprecate the RetryFilter | 13:45 |
| mriedem | i don't think it's ever used anymore | 13:45 |
| mriedem | anyway, bbiab | 13:46 |
| *** dpawlik has joined #openstack-nova | 13:46 | |
| sean-k-mooney | that worth looking into | 13:46 |
| sean-k-mooney | ill file a bug so we dont forget | 13:46 |
| *** JamesBenson has joined #openstack-nova | 13:52 | |
| *** JamesBenson has quit IRC | 13:53 | |
| *** JamesBenson has joined #openstack-nova | 13:53 | |
| stephenfin | mriedem: Yeah, if you've ideas I'd be happy to hear them. Those tests really aren't good but I'm out of ideas at this point | 13:53 |
| *** mlavalle has joined #openstack-nova | 13:55 | |
| *** ricolin has joined #openstack-nova | 13:55 | |
| *** slaweq_ is now known as slaweq | 14:00 | |
| *** hongbin has joined #openstack-nova | 14:06 | |
| *** janki has quit IRC | 14:08 | |
| *** liuyulong has joined #openstack-nova | 14:11 | |
| mriedem | i'll tinker | 14:15 |
| *** cdent has joined #openstack-nova | 14:21 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Deprecate RetryFilter https://review.opendev.org/663953 | 14:21 |
| mriedem | sean-k-mooney: let's see what blows up ^ | 14:21 |
| mriedem | edleafe: ^ | 14:21 |
| *** igordc has joined #openstack-nova | 14:23 | |
| *** tbachman has quit IRC | 14:23 | |
| stephenfin | mriedem: Would you be okay with the named kwargs thing if it was a separate patch? I think it's a nice readability improvement but it probably shouldn't be munged with other stuff alright | 14:24 |
| stephenfin | Referring to https://review.opendev.org/#/c/651311/ | 14:24 |
| mriedem | i disagree that it's a readability improvement... | 14:26 |
| mriedem | by that logic we'd use named kwargs on everything | 14:26 |
| mriedem | stephenfin: i'm going to pull the series down and tinker with those notification tests for reschedule and if i come up with someting cleaner i can push that up and remove the kwargs in the next patch in the series while i'm at it | 14:27 |
| sean-k-mooney | mriedem: i have disabled the retry filter in one of my nfv job iteration and it more orless seam to be fine so i suspect it will not blow up or not blow up too badly | 14:27 |
| *** dpawlik has quit IRC | 14:27 | |
| stephenfin | mriedem: Not everything. Just things that have a lot of arguments (it's subjective but I'd say > 5) | 14:27 |
| sean-k-mooney | im on a triage call but ill file the bug and coment on your patch when im done | 14:28 |
| mriedem | sean-k-mooney: bug? | 14:28 |
| mriedem | it's not really a bug that we forgot to deprecate the RetryFilter in Rocky | 14:28 |
| sean-k-mooney | ok | 14:28 |
| sean-k-mooney | in that case ill just keep an eye on the test results :) | 14:29 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance' https://review.opendev.org/651311 | 14:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312 | 14:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313 | 14:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314 | 14:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527 | 14:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reno for removed cells v1 policies https://review.opendev.org/662031 | 14:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411 | 14:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950 | 14:30 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Use named kwargs for resize_api https://review.opendev.org/663959 | 14:30 |
| artom | bauzas, thanks for the note on https://review.opendev.org/#/c/644881/21, will address after this call. Also need to address mriedem's commit message feedback, which I completely forgot about the first time around | 14:36 |
| mriedem | oh right you want to backport that.... | 14:37 |
| mriedem | i was going to say we don't need a release note for a virt driver interface change, | 14:37 |
| mriedem | but if we're backporting... | 14:37 |
| * artom shall buy a spot on CNN to make sure the message goes out ;) | 14:38 | |
| mriedem | we did this recently for an ironic driver related fix and handled a TypeError in the backportable version and removed it in a follow up on master | 14:38 |
| mriedem | https://github.com/openstack/nova/blob/stable/rocky/nova/compute/manager.py#L7648 | 14:39 |
| mriedem | given that, we may want to follow the same pattern here | 14:39 |
| mriedem | it is admittedly bending over backward for out of tree drivers which is being exceedingly nice | 14:39 |
| *** eharney has joined #openstack-nova | 14:40 | |
| artom | Wait, won't that leave vm_instance unset and blow up later? | 14:40 |
| artom | Oh, actually no. | 14:40 |
| artom | vm_power_state will be unset, but it's only used in an if | 14:41 |
| artom | OK, I'll do something similar when I backport | 14:41 |
| mriedem | for your change it would mean adding a try/except TypeError around the call to finish_revert_migration and if we get a TypeError, call again without the vifs_already_plugged kwarg | 14:41 |
| mriedem | when you backport? if we do this, you'd do it on master, | 14:41 |
| mriedem | and then follow up with a patch to remove that handling | 14:41 |
| mriedem | otherwise your backport has new extra logic in it which sucks to review | 14:42 |
| artom | Oh yeah *facepalm* | 14:42 |
| artom | Why remove on master though? | 14:42 |
| artom | That same method signature TypeError thing can also happen with oot drivers on master, no? | 14:43 |
| artom | If they're really slow to update | 14:43 |
| *** tbachman has joined #openstack-nova | 14:44 | |
| sean-k-mooney | artom: we have customers still running kilo | 14:44 |
| sean-k-mooney | artom: i assume those customers are also slow to update there out of tree stuff | 14:45 |
| artom | I doubt any of our customer have oot drivers :) | 14:45 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312 | 14:45 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313 | 14:45 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314 | 14:45 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527 | 14:45 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reno for removed cells v1 policies https://review.opendev.org/662031 | 14:45 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411 | 14:45 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950 | 14:45 |
| sean-k-mooney | well not any that we support in anycase | 14:46 |
| *** itlinux has quit IRC | 14:46 | |
| *** itlinux has joined #openstack-nova | 14:47 | |
| efried | I know for sure PowerVM oot driver is in production for real customers | 14:47 |
| bauzas | artom: cool with me | 14:48 |
| efried | if you change the virt driver interface on stable, they'll need to patch. | 14:48 |
| artom | efried, right, I'm sure they exist, just most likely not among our customers | 14:48 |
| mriedem | artom: with your upstream hat on, you shouldn't care about your downstream customers and OOT issues | 14:48 |
| mriedem | iow, saying "our customers won't care" isn't a valid reason to not do it | 14:49 |
| efried | artom: "our" meaning RH? | 14:49 |
| mriedem | the upstream argument would be, "oot? f'em" | 14:49 |
| mriedem | efried: yes | 14:49 |
| efried | I don't know what qualifies as a RH "customer", but the products that are based on the oot PowerVM driver are packaged as some form of RH distribution. | 14:50 |
| bauzas | mriedem: okay, I was thinking we could be good citizens and notify OOT maintainers, like asked in https://review.opendev.org/#/c/589085/ | 14:50 |
| efried | so whoever's using them is a RH "customer" in some capacity. | 14:50 |
| bauzas | anyway, I need to leave | 14:50 |
| stephenfin | Who's a good person to review resize flow bugfixes? https://review.opendev.org/#/c/662522/ | 14:51 |
| mriedem | stephenfin: i want to say alex_xu already had a bug / patch for that | 14:52 |
| mriedem | but you'd have to ask him | 14:52 |
| mriedem | stephenfin: gibi: i changed those notification sample resize reschedule tests to move the patching out of the side effect method, the diff is in here https://review.opendev.org/#/c/660774/4/nova/tests/functional/notification_sample_tests/test_instance.py | 14:52 |
| artom | mriedem, efried, yeah, I meant our = RH, but... I'm saying I'll do the nice things for oot drivers in my patch, as just replying to sean-k-mooney that RH customers are most likely *not* among those affected | 14:52 |
| mriedem | it's not a ton better, but it's different so see what you think | 14:52 |
| *** itlinux has quit IRC | 14:52 | |
| mriedem | https://review.opendev.org/#/c/620874/ | 14:54 |
| mriedem | stephenfin: -1 on your fix for the same reason i -1'ed alex_xu's change | 14:55 |
| mriedem | sean-k-mooney: heh you even said, "this is a provisional +1 as i think this is correct assumeing we confirm the request_spec is not saved in its modifed form." | 14:56 |
| mriedem | dangerous to +1 before you know that to be true | 14:56 |
| sean-k-mooney | mriedem: i suspected it was true because we had whitebox test that were passing that implied the request spec was updated correctly on compute node but yes you are right i should have checked it end ot end first before +1 | 14:57 |
| stephenfin | mriedem: Yeah, we were trying to figure out if it was saved anywhere but I haven't been able to trace a save on the request_spec anywhere | 14:57 |
| stephenfin | Is there any reason we need to persist the request_spec on the object, tbh? | 14:58 |
| mriedem | it's very clearly saved in the conductor | 14:58 |
| stephenfin | *numa_topology | 14:58 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L367 | 14:58 |
| mriedem | ^ is where i spend a good deal of my time fixing regressions | 14:58 |
| mriedem | https://review.opendev.org/#/q/topic:bug/1669054+(status:open+OR+status:merged) | 14:59 |
| *** itlinux has joined #openstack-nova | 14:59 | |
| mriedem | https://review.opendev.org/#/q/topic:bug/1830747+(status:open+OR+status:merged) | 14:59 |
| stephenfin | I saw that, but that's only for cold migrations? | 14:59 |
| mriedem | resize and cold migrate are the same flow stephen | 15:00 |
| stephenfin | oh yeah | 15:00 |
| sean-k-mooney | mriedem: so my original asstetion that we should use the temporay mutation context manager or somthing similar is proably correct? | 15:00 |
| mriedem | sean-k-mooney: correct you're right on the money here https://review.opendev.org/#/c/662522/1/nova/compute/api.py@3562 | 15:01 |
| mriedem | right on the MOONEY | 15:01 |
| mriedem | get it?! | 15:02 |
| sean-k-mooney | hehe i should frame that and put it on my wall | 15:02 |
| mriedem | get a bad ass trucker hate made out of it | 15:02 |
| sean-k-mooney | "mriedem: said i was right about somthing" :) | 15:02 |
| mriedem | you're right about lots of things | 15:02 |
| sean-k-mooney | :) ok so it should be a fairly simple fix so are you ok to proceed with stephens version or alex's | 15:04 |
| *** jbernard has quit IRC | 15:04 | |
| mriedem | they are both broken | 15:04 |
| mriedem | equally | 15:04 |
| mriedem | i've duplicated stephen's bug against alex's since alex's came first, | 15:04 |
| mriedem | but alex seems to have abandoned his change effectively | 15:04 |
| mriedem | by "simple fix" you mean shove the new numa topology into the migration contexT? | 15:05 |
| mriedem | i'm not sure we'd need to do that if we can, on revert, build the old numa topology from the old flavor that is in the migration context before we drop the migration context | 15:05 |
| *** sapd1_x has joined #openstack-nova | 15:07 | |
| *** cdent has quit IRC | 15:08 | |
| *** tbachman has quit IRC | 15:08 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove 'ComputeManager._reschedule' https://review.opendev.org/660774 | 15:08 |
| mriedem | gibi: stephenfin: ^ updated i'll +W | 15:08 |
| sean-k-mooney | by simpel fix i ment we jsut need to reset the change state on the field so that it does not get saved when the condoctor calls save. | 15:09 |
| gibi | mriedem: +2, thanks | 15:09 |
| mriedem | sean-k-mooney: but we actually do need to persist the new numa topology on the request spec for any subsequent move operations | 15:10 |
| sean-k-mooney | mriedem: yes but we update it on the compute host | 15:10 |
| mriedem | otherwise i can (1) create my server with flavor1 and numa1, (2) resize to flavor2/numa2, confirm, (3) cold migrate and now i'm scheduling with flavor1's numa1 | 15:10 |
| mriedem | sean-k-mooney: the request spec? | 15:11 |
| *** tbachman has joined #openstack-nova | 15:11 | |
| mriedem | that would be an up-call... | 15:11 |
| mriedem | that also doesn't solve your revert problem | 15:11 |
| sean-k-mooney | ya we i think recalualate the numa toplogy in the driver and store it in the ... instance not he request spec never mind | 15:11 |
| sean-k-mooney | so ya we need to actuly save it and then revert it | 15:12 |
| stephenfin | sean-k-mooney: Definitely? I know we used to mess with it in the filters https://github.com/openstack/nova/blob/master/nova/scheduler/filters/numa_topology_filter.py#L61-L68 | 15:12 |
| sean-k-mooney | well see the fact the numa_fit_instance_to_host fucntion modifes the request sepc is what made me suspect this would get updated by the compute node if we booted sucessfuly | 15:15 |
| sean-k-mooney | but honestly we need 1 trace teh code and two test it locally to confirm | 15:15 |
| stephenfin | We probably don't want to persist that change though, in any case | 15:15 |
| sean-k-mooney | proably. the compute node really should not need to modify the request_spec | 15:16 |
| sean-k-mooney | well in this instance | 15:16 |
| mriedem | the compute service should never be saving changes to the RequestSpec, ever, since it's an up-call to the API DB | 15:16 |
| mriedem | dansmith: agree with me here? ^ | 15:16 |
| mriedem | stephenfin: as i explained above, the RequestSpec.numa_topology is used in the scheduler so yes it needs to be persisted for subsequent move operations, | 15:17 |
| mriedem | however, on revert we have to make sure we revert the numa_topology in the request spec to the old flavor's values | 15:17 |
| dansmith | mriedem: of course | 15:17 |
| sean-k-mooney | we only added the request spec to the api db around rocky correct | 15:17 |
| mriedem | which is my -1 | 15:17 |
| mriedem | jesus gd | 15:17 |
| stephenfin | Any changes from the compute node, I mean | 15:17 |
| sean-k-mooney | buy you are right | 15:17 |
| mriedem | i would like to phone a friend | 15:18 |
| mriedem | see this code on revert https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3410 | 15:19 |
| mriedem | that's the thing you need to concern yourself with | 15:19 |
| mriedem | and why i -1'ed alex_xu's change | 15:19 |
| mriedem | and yours | 15:19 |
| mriedem | sean-k-mooney: request spec has been around since mitaka or newton at least, which is why when i have to fix a regression bug b/c of the request spec, i have to backport it through 20 releases | 15:21 |
| dansmith | sean-k-mooney: reqspec has been around a lot longer than rocky | 15:21 |
| mriedem | which makes me a sad panda | 15:21 |
| sean-k-mooney | oh i know the reqest spec has been | 15:22 |
| sean-k-mooney | i just tought we only strated storing it in the api db more recently | 15:23 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: allow getting resource request of every bound ports of an instance https://review.opendev.org/655110 | 15:23 |
| sean-k-mooney | i tought melwitt added it to the api db like 2-3 release ago but i could be wrong about that | 15:23 |
| dansmith | we've had it in the api db since we've had an api db AFAIK | 15:24 |
| mriedem | 4th api db migration | 15:24 |
| dansmith | yeah | 15:24 |
| sean-k-mooney | ah ok | 15:24 |
| mriedem | sweet laski | 15:24 |
| mriedem | apparently we aren't keeping track of runways anymore https://etherpad.openstack.org/p/nova-runways-train | 15:26 |
| sean-k-mooney | mriedem: i mentioned on irc that my one can be dropped form the runway | 15:28 |
| *** bnemec is now known as beekneemech | 15:29 | |
| panda | uh ? | 15:29 |
| panda | oh, the sad me. | 15:29 |
| panda | ok. | 15:29 |
| stephenfin | panda: Damn it man, look sadder! | 15:29 |
| *** mcgigglier has quit IRC | 15:29 | |
| sean-k-mooney | it still need a second +2 but its more or less done at this point | 15:29 |
| mriedem | i've got it in a tab | 15:32 |
| *** davidsha has quit IRC | 15:32 | |
| sean-k-mooney | mriedem: oh incase you missed it i set https://blueprints.launchpad.net/nova/+spec/libvirt-neutron-sriov-livemigration to implemented since the neutron docs change has merged too and updated the spec link to the renderd version instead of gerrit | 15:33 |
| mriedem | ack thanks | 15:33 |
| sean-k-mooney | im going to go grab lunch ill be around later for an hour or so o/ | 15:34 |
| stephenfin | sean-k-mooney: s/lunch/dinner/ | 15:36 |
| *** jbernard has joined #openstack-nova | 15:36 | |
| *** BjoernT has joined #openstack-nova | 15:37 | |
| *** ttsiouts has quit IRC | 15:38 | |
| *** ttsiouts has joined #openstack-nova | 15:39 | |
| *** cdent has joined #openstack-nova | 15:39 | |
| *** BjoernT_ has quit IRC | 15:40 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pass network API to the conducor's MigrationTask https://review.opendev.org/655111 | 15:40 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add request_spec to server move RPC calls https://review.opendev.org/655721 | 15:40 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: re-calculate provider mapping during migration https://review.opendev.org/655112 | 15:40 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422 | 15:40 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114 | 15:40 |
| *** gibi is now known as gibi_ogg | 15:41 | |
| *** gibi_ogg is now known as gibi_off | 15:41 | |
| *** ttsiouts has quit IRC | 15:43 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663011 | 15:44 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887 | 15:44 |
| *** markvoelker has quit IRC | 15:49 | |
| *** gyee has joined #openstack-nova | 15:51 | |
| *** wwriverrat has quit IRC | 15:54 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 15:56 |
| artom | mriedem, bauzas ^^ | 15:56 |
| * artom -> ph00d | 15:56 | |
| *** dtantsur is now known as dtantsur|afk | 15:58 | |
| *** jbernard has quit IRC | 16:00 | |
| *** jbernard has joined #openstack-nova | 16:03 | |
| openstackgerrit | Dr. Clemens Hardewig proposed openstack/nova master: Fixes instance resizing/migration when swap volume is on lvm https://review.opendev.org/618621 | 16:04 |
| openstackgerrit | Dr. Clemens Hardewig proposed openstack/nova master: Fixes instance resizing/migration when swap volume is on lvm https://review.opendev.org/663986 | 16:04 |
| *** stephenfin is now known as finucannot | 16:05 | |
| *** lbragstad is now known as lbragstad_runnin | 16:06 | |
| *** luksky has quit IRC | 16:11 | |
| *** xek has quit IRC | 16:11 | |
| *** panda is now known as panda|off | 16:13 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | 16:14 |
| finucannot | sean-k-mooney, mriedem: ^ that should do the trick...I think | 16:14 |
| finucannot | mriedem: I'm going to have to rebase https://review.opendev.org/#/c/651311/ otherwise Gerrit won't let it merge, so want me to add the TODO? | 16:15 |
| mriedem | sure | 16:18 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance' https://review.opendev.org/651311 | 16:23 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312 | 16:23 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313 | 16:23 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314 | 16:23 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527 | 16:23 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reno for removed cells v1 policies https://review.opendev.org/662031 | 16:23 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411 | 16:23 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950 | 16:23 |
| finucannot | done | 16:23 |
| *** tbachman has quit IRC | 16:24 | |
| *** damien_r has quit IRC | 16:24 | |
| *** priteau has quit IRC | 16:25 | |
| finucannot | whoops, missed the comments in the following patches. Fixed those too | 16:28 |
| *** mriedem has quit IRC | 16:28 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312 | 16:28 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313 | 16:28 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314 | 16:28 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527 | 16:28 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reno for removed cells v1 policies https://review.opendev.org/662031 | 16:28 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411 | 16:28 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950 | 16:28 |
| *** mriedem has joined #openstack-nova | 16:29 | |
| mriedem | done | 16:29 |
| mriedem | a couple of easy -1s to address in the next 2 after that | 16:29 |
| finucannot | yeah, just tackled those | 16:29 |
| *** Sundar has joined #openstack-nova | 16:30 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Refresh instance network info on deletion https://review.opendev.org/660761 | 16:33 |
| mriedem | easy fix ^ | 16:34 |
| *** tbachman has joined #openstack-nova | 16:39 | |
| finucannot | Indeed. +W | 16:40 |
| *** tesseract has quit IRC | 16:40 | |
| *** owalsh has quit IRC | 16:40 | |
| *** jaosorior has quit IRC | 16:42 | |
| *** cdent has quit IRC | 16:43 | |
| lyarwood | mdbooth: replied btw, the caps stub is still required. | 16:44 |
| Sundar | johnthetubguy: Hi, are you good with https://review.opendev.org/#/c/603955/ after the updates? | 16:45 |
| finucannot | lyarwood: If you add TODOs for the few things mdbooth called out (I left my own comments on same), I'm +2 | 16:48 |
| finucannot | and then I'm going home | 16:49 |
| efried | lyarwood: I gotta run, but you're hitting this code path in your tests | 16:50 |
| efried | https://opendev.org/openstack/nova/src/branch/master/nova/virt/libvirt/driver.py#L4835 | 16:50 |
| efried | which is patently wrong - should either be ... in (fields.Architecture.AARCH64,) <== tuple -- or just == | 16:50 |
| *** markvoelker has joined #openstack-nova | 16:50 | |
| Sundar | johnthetubaguy: ^ | 16:51 |
| efried | bbiab | 16:51 |
| *** efried is now known as fried_rolls | 16:51 | |
| *** owalsh has joined #openstack-nova | 16:52 | |
| *** gibi_off has quit IRC | 16:52 | |
| *** bbowen__ has quit IRC | 16:53 | |
| *** lbragstad_runnin is now known as lbragstad | 16:53 | |
| lyarwood | fried_rolls / finucannot: looking, thanks | 16:54 |
| artom | Note to self: bdms != bdsm | 16:59 |
| mriedem | tssurya: self.cells is a dict by the time we get to patch https://review.opendev.org/#/c/663388/ | 17:00 |
| mriedem | see the change below it | 17:00 |
| lyarwood | artom: always a risky search term at work | 17:00 |
| artom | Oh I don't need to search for it. | 17:00 |
| openstackgerrit | Dr. Clemens Hardewig proposed openstack/nova master: This patch is to fix bug #1831657 https://review.opendev.org/664000 | 17:01 |
| openstack | bug 1831657 in OpenStack Compute (nova) "Instance migration/Instance resize with lvm volumes" [Undecided,New] https://launchpad.net/bugs/1831657 - Assigned to Dr. Clemens Hardewig (bringha1) | 17:01 |
| *** derekh has quit IRC | 17:04 | |
| *** liuyulong has quit IRC | 17:06 | |
| tssurya | mriedem: sorry, I am super stupid, I didn't pull the other two changes below it | 17:08 |
| mriedem | don't worry about it | 17:08 |
| tssurya | was working witht his and Jay's patches | 17:08 |
| * mriedem makes note in personal records | 17:08 | |
| tssurya | hehe | 17:08 |
| *** tbachman has quit IRC | 17:09 | |
| *** ralonsoh has quit IRC | 17:09 | |
| *** tbachman has joined #openstack-nova | 17:13 | |
| *** factor has joined #openstack-nova | 17:14 | |
| *** ociuhandu_ has joined #openstack-nova | 17:15 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663011 | 17:15 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887 | 17:15 |
| lyarwood | fried_rolls / finucannot / mdbooth ; ^ thanks again for the reviews, just need to drop for dinner, I'll be back in ~45mins or so if there's any more follow up. | 17:15 |
| lyarwood | aaaaaactually I've done it again and butchered the tests, 2 mins | 17:18 |
| *** ociuhandu has quit IRC | 17:18 | |
| *** sapd1_x has quit IRC | 17:19 | |
| lyarwood | haha, now I see why, sshfs has made the directory I was working on read-only, bloody wonderful | 17:19 |
| *** ociuhandu_ has quit IRC | 17:20 | |
| *** ricolin has quit IRC | 17:24 | |
| *** markvoelker has quit IRC | 17:25 | |
| kashyap | lyarwood: Nice! The 'diffstat' is better. I only looked now at the newer iteration | 17:28 |
| * kashyap will read the comments on Tuesday; now --> cooking | 17:29 | |
| lyarwood | kashyap: thanks :) | 17:30 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663011 | 17:30 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM: Run tempest-full-py3 with q35 machine type https://review.opendev.org/662887 | 17:30 |
| lyarwood | ^ right I'm done, apologies again for all the noise with this | 17:31 |
| kashyap | [Should also start a broader discussion on 'openstack-discuss' to _actually_ test 'q35' machine type in a proper job; 'i440fx' is a "second rate citizen", but it's not going to go away anytime soon, though] | 17:33 |
| *** tssurya has quit IRC | 17:36 | |
| *** Sundar has quit IRC | 17:44 | |
| *** maciejjozefczyk has quit IRC | 17:55 | |
| *** luksky has joined #openstack-nova | 17:56 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 18:01 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Remove finish_revert_migration TypeError try/except https://review.opendev.org/664013 | 18:01 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: test legacy dsvm job base-test parent https://review.opendev.org/664014 | 18:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | 18:02 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper https://review.opendev.org/663102 | 18:02 |
| finucannot | mriedem: Didn't address your two todos but that adds the functional test requested ^ | 18:02 |
| finucannot | now I'm *really* going home | 18:02 |
| *** finucannot is now known as stephenfin | 18:02 | |
| artom | mriedem, I only *slightly* hate you :) | 18:03 |
| artom | ^^ | 18:03 |
| *** aram1s has joined #openstack-nova | 18:05 | |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899 | 18:06 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for node.list https://review.opendev.org/656027 | 18:06 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for validating instance and node https://review.opendev.org/656028 | 18:06 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for setting instance id https://review.opendev.org/659690 | 18:06 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: WIP: Use SDK instead of ironicclient for add/remove instance info from node https://review.opendev.org/659691 | 18:06 |
| *** ccamacho has quit IRC | 18:18 | |
| *** markvoelker has joined #openstack-nova | 18:22 | |
| openstackgerrit | Artom Lifshitz proposed openstack/python-novaclient stable/stein: Use SHA256 instead of MD5 in completion cache https://review.opendev.org/664023 | 18:32 |
| openstackgerrit | Artom Lifshitz proposed openstack/python-novaclient stable/rocky: Use SHA256 instead of MD5 in completion cache https://review.opendev.org/664025 | 18:32 |
| mriedem | sean-k-mooney: comments in https://review.opendev.org/#/c/647733/ | 18:42 |
| sean-k-mooney | thanks ill take a look at them shortly | 18:42 |
| mriedem | or monday... | 18:42 |
| mriedem | b/c you shouldn't be working | 18:42 |
| sean-k-mooney | :) ill finish up in the next 20 mins or so. | 18:43 |
| sean-k-mooney | ya they all make sense. ill try swaping out the mocking on monday as you suggested. regarding hw_architecture = aarch64 and hw_video_model = vga i dont know what will happen | 18:47 |
| sean-k-mooney | i suspect qemu will bitch if its not supported | 18:47 |
| *** markvoelker has quit IRC | 18:55 | |
| *** JamesBenson has quit IRC | 19:02 | |
| *** Sundar has joined #openstack-nova | 19:03 | |
| *** Nick_A has left #openstack-nova | 19:03 | |
| *** fried_rolls is now known as efried | 19:15 | |
| *** _hemna has joined #openstack-nova | 19:16 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: in-line machine_type_mappings into get_default_machine_type https://review.opendev.org/664036 | 19:17 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP fup: Replace call to get_capabilities within _has_uefi_support https://review.opendev.org/664037 | 19:17 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Fix some bogus `in (not_a_tuple)` uses https://review.opendev.org/664041 | 19:20 |
| *** _hemna has quit IRC | 19:20 | |
| efried | lyarwood: I suspect putting your patch together with ^ will have interesting side effects. | 19:21 |
| lyarwood | efried: ack thanks, I'm heading offline now but I'll rebase on that and see what shakes out on Monday | 19:25 |
| efried | lyarwood: They'll affect the tests (because `$string in $autospec_mock` doesn't work), but I don't think they can actually cause bugs in the code. | 19:25 |
| *** jdillaman has quit IRC | 19:30 | |
| *** BjoernT has quit IRC | 19:31 | |
| sean-k-mooney | efried: 'foo' in 'foo' check if the 'foo' charater sequence extis in the second string 'foo' | 19:38 |
| efried | right | 19:38 |
| sean-k-mooney | efried: so 'f' in 'foo' is a substring match where as 'foo' in ('foo') is a contains check | 19:39 |
| efried | contains in what sense? | 19:39 |
| sean-k-mooney | e.g. is 'foo' one of the values of the tuple | 19:39 |
| efried | 'foo' in ('foo') is the same as 'foo' in 'foo'. | 19:39 |
| efried | Because ('foo') is not a tuple. | 19:39 |
| efried | It's a string with redundant parens. | 19:39 |
| efried | ('foo',) is a tuple. | 19:39 |
| sean-k-mooney | ah well yes that too | 19:40 |
| sean-k-mooney | although 'foo' in ('foo',) should also be true | 19:40 |
| efried | 'foo' in ('foobar') # True | 19:40 |
| efried | 'foo' in ('foobar',) # False | 19:40 |
| sean-k-mooney | yes but that is not what i wrote | 19:41 |
| efried | what you wrote where? | 19:41 |
| sean-k-mooney | >>> 'foo' in ('foo',) | 19:41 |
| *** udesale has quit IRC | 19:41 | |
| sean-k-mooney | True | 19:41 |
| efried | yes | 19:41 |
| sean-k-mooney | if the string matachs a value in the tuple exactly it will be true | 19:42 |
| efried | right | 19:42 |
| efried | but only if it's a tuple | 19:42 |
| sean-k-mooney | but it wont to a substring match on each of the values of the tuple | 19:42 |
| efried | right | 19:42 |
| efried | we are in violent agreement | 19:42 |
| sean-k-mooney | yep :) | 19:42 |
| efried | And I think we're not broken here, because there's no arch const that's a substring of another arch const (is there?) | 19:43 |
| efried | but it's by luck. It's still wrong and should be fixed. | 19:43 |
| sean-k-mooney | i dont know if we have x86 and x86_64 but i think if we did we would threat them as an alias | 19:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix some bogus `in (not_a_tuple)` uses https://review.opendev.org/664041 | 19:44 |
| efried | Enhanced commit message which (hopefully) makes it clearer ^ | 19:44 |
| *** Sundar has quit IRC | 19:44 | |
| efried | (also fixed the other two spots in the nova codebase that do the same) | 19:44 |
| sean-k-mooney | this is the set we support https://github.com/openstack/nova/blob/master/nova/objects/fields.py#L112-L153 | 19:44 |
| sean-k-mooney | technically tere a few | 19:45 |
| sean-k-mooney | ppc64 and ppc64le | 19:45 |
| efried | mm, s390/s390x | 19:45 |
| efried | ppc is a substring of a bunch | 19:45 |
| sean-k-mooney | ya look like only ibm was broken | 19:45 |
| efried | sh4 | 19:45 |
| efried | xtensa | 19:45 |
| efried | mips | 19:45 |
| efried | arm7 | 19:46 |
| sean-k-mooney | ok | 19:46 |
| sean-k-mooney | look like only x86 is not broken :P | 19:46 |
| efried | the one in question was specifically saying in (AARCH64) | 19:46 |
| efried | which looks like it's probably okay. | 19:46 |
| sean-k-mooney | i dont think we use most of these constants anyway | 19:46 |
| sean-k-mooney | if only we had static types... | 19:49 |
| *** _hemna has joined #openstack-nova | 19:49 | |
| *** markvoelker has joined #openstack-nova | 19:52 | |
| *** maciejjozefczyk has joined #openstack-nova | 20:02 | |
| *** mriedem has quit IRC | 20:08 | |
| *** maciejjozefczyk has quit IRC | 20:10 | |
| *** mriedem has joined #openstack-nova | 20:11 | |
| openstackgerrit | Edward Hope-Morley proposed openstack/nova master: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/663607 | 20:14 |
| *** Nick_A has joined #openstack-nova | 20:19 | |
| *** markvoelker has quit IRC | 20:20 | |
| *** _hemna has quit IRC | 20:23 | |
| *** igordc has quit IRC | 20:28 | |
| *** Sundar has joined #openstack-nova | 20:31 | |
| *** artom has quit IRC | 20:39 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add SchedulerReportClient.get_provider_by_name https://review.opendev.org/664062 | 20:48 |
| *** cfriesen has quit IRC | 20:54 | |
| mriedem | well zuul just got restarted so i'm out of here for the weekend | 21:06 |
| mriedem | sniff you jerks later | 21:06 |
| *** mriedem has quit IRC | 21:06 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Hacking N363: `in (not_a_tuple)` https://review.opendev.org/664041 | 21:09 |
| *** markvoelker has joined #openstack-nova | 21:16 | |
| *** markvoelker has quit IRC | 21:21 | |
| *** Nick_A has left #openstack-nova | 21:26 | |
| *** whoami-rajat has quit IRC | 21:34 | |
| *** pcaruana has quit IRC | 21:51 | |
| *** luksky has quit IRC | 21:55 | |
| *** slaweq has quit IRC | 22:01 | |
| *** slaweq has joined #openstack-nova | 22:08 | |
| *** tbachman has quit IRC | 22:11 | |
| *** slaweq has quit IRC | 22:15 | |
| *** Sundar has quit IRC | 22:16 | |
| *** hamzy_ has joined #openstack-nova | 22:30 | |
| *** hamzy has quit IRC | 22:32 | |
| *** artom has joined #openstack-nova | 23:05 | |
| *** slaweq has joined #openstack-nova | 23:11 | |
| *** gyee has quit IRC | 23:12 | |
| *** Nick_A has joined #openstack-nova | 23:13 | |
| *** redkrieg has joined #openstack-nova | 23:14 | |
| redkrieg | Is there any way to run a virt-sparsify on a snapshot during creation? | 23:15 |
| *** slaweq has quit IRC | 23:15 | |
| *** markvoelker has joined #openstack-nova | 23:17 | |
| *** hongbin has quit IRC | 23:20 | |
| *** tjgresha has joined #openstack-nova | 23:29 | |
| *** hoonetorg has quit IRC | 23:35 | |
| *** markvoelker has quit IRC | 23:38 | |
| *** hoonetorg has joined #openstack-nova | 23:49 | |
| *** lbragstad has quit IRC | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!