| *** markvoelker has quit IRC | 00:00 | |
| *** tbachman has joined #openstack-nova | 00:09 | |
| *** hongbin has quit IRC | 00:25 | |
| *** med_ has quit IRC | 00:40 | |
| *** rnoriega has quit IRC | 00:40 | |
| *** kashyap has quit IRC | 00:40 | |
| *** rnoriega has joined #openstack-nova | 00:40 | |
| *** spatel has joined #openstack-nova | 00:45 | |
| *** tbachman has quit IRC | 00:47 | |
| *** zzzeek has quit IRC | 00:47 | |
| *** zzzeek has joined #openstack-nova | 00:47 | |
| *** bhagyashris has joined #openstack-nova | 00:49 | |
| *** markvoelker has joined #openstack-nova | 00:57 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Add regression recreate test for bug 1830747 https://review.opendev.org/662578 | 00:58 |
|---|---|---|
| openstack | bug 1830747 in OpenStack Compute (nova) rocky "Error 500 trying to migrate an instance after wrong request_spec" [High,In progress] https://launchpad.net/bugs/1830747 - Assigned to Matt Riedemann (mriedem) | 00:58 |
| openstackgerrit | Merged openstack/nova stable/rocky: Workaround missing RequestSpec.instance_group.uuid https://review.opendev.org/662895 | 00:58 |
| *** bhagyashris has quit IRC | 00:59 | |
| Sundar | Hi all, https://review.opendev.org/#/c/603955/ already has a +2 and a +1. Please review and help to close it. Thanks. | 01:12 |
| *** bhagyashris has joined #openstack-nova | 01:15 | |
| *** bhagyashris has quit IRC | 01:28 | |
| *** igordc has quit IRC | 01:28 | |
| *** markvoelker has quit IRC | 01:31 | |
| *** spatel has quit IRC | 01:31 | |
| *** dave-mccowan has quit IRC | 01:34 | |
| *** boxiang has joined #openstack-nova | 01:34 | |
| *** Sundar has quit IRC | 01:39 | |
| *** dave-mccowan has joined #openstack-nova | 01:39 | |
| *** spsurya has joined #openstack-nova | 01:51 | |
| *** bbowen has quit IRC | 01:55 | |
| *** bbowen has joined #openstack-nova | 01:56 | |
| *** yikun has joined #openstack-nova | 01:56 | |
| *** zzzeek has quit IRC | 01:57 | |
| *** zzzeek has joined #openstack-nova | 01:58 | |
| *** itlinux has joined #openstack-nova | 01:59 | |
| *** BjoernT_ has quit IRC | 02:02 | |
| *** BjoernT has joined #openstack-nova | 02:02 | |
| *** BjoernT has quit IRC | 02:06 | |
| *** zzzeek has quit IRC | 02:13 | |
| *** itlinux_ has joined #openstack-nova | 02:14 | |
| *** zzzeek has joined #openstack-nova | 02:16 | |
| *** itlinux has quit IRC | 02:18 | |
| *** bhagyashris has joined #openstack-nova | 02:25 | |
| *** markvoelker has joined #openstack-nova | 02:27 | |
| *** yaawang has quit IRC | 02:33 | |
| *** yaawang has joined #openstack-nova | 02:34 | |
| *** Sundar has joined #openstack-nova | 02:45 | |
| *** hongbin has joined #openstack-nova | 02:47 | |
| *** itlinux_ has quit IRC | 02:54 | |
| *** markvoelker has quit IRC | 03:01 | |
| *** yaawang has quit IRC | 03:03 | |
| *** yaawang has joined #openstack-nova | 03:06 | |
| *** brinzhang has quit IRC | 03:11 | |
| *** boxiang_ has joined #openstack-nova | 03:12 | |
| *** boxiang has quit IRC | 03:12 | |
| openstackgerrit | tonybrad proposed openstack/nova master: update constraints url https://review.opendev.org/664771 | 03:16 |
| *** spatel has joined #openstack-nova | 03:17 | |
| *** spatel has quit IRC | 03:22 | |
| *** cfriesen has quit IRC | 03:25 | |
| *** psachin has joined #openstack-nova | 03:29 | |
| *** takashin has joined #openstack-nova | 03:32 | |
| *** itlinux has joined #openstack-nova | 03:35 | |
| *** BjoernT has joined #openstack-nova | 03:36 | |
| *** itlinux has quit IRC | 03:36 | |
| *** dave-mccowan has quit IRC | 03:46 | |
| *** yikun has quit IRC | 03:51 | |
| *** jbernard_ has joined #openstack-nova | 03:52 | |
| *** jbernard has quit IRC | 03:52 | |
| *** BjoernT has quit IRC | 03:53 | |
| *** markvoelker has joined #openstack-nova | 03:58 | |
| *** yikun has joined #openstack-nova | 04:03 | |
| *** udesale has joined #openstack-nova | 04:16 | |
| *** markvoelker has quit IRC | 04:32 | |
| *** whoami-rajat has joined #openstack-nova | 04:51 | |
| *** sridharg has joined #openstack-nova | 04:53 | |
| *** pcaruana has joined #openstack-nova | 04:54 | |
| *** pcaruana has quit IRC | 04:59 | |
| *** hongbin has quit IRC | 05:01 | |
| *** ratailor has joined #openstack-nova | 05:12 | |
| *** Luzi has joined #openstack-nova | 05:22 | |
| *** markvoelker has joined #openstack-nova | 05:29 | |
| openstackgerrit | Merged openstack/nova master: Skip test_check_doubled_words hacking check UT https://review.opendev.org/664622 | 05:39 |
| *** luksky has joined #openstack-nova | 05:41 | |
| *** brinzhang has joined #openstack-nova | 05:46 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix default values in update_cell command https://review.opendev.org/662383 | 05:53 |
| *** igordc has joined #openstack-nova | 05:58 | |
| *** markvoelker has quit IRC | 06:02 | |
| *** rpittau|afk is now known as rpittau | 06:20 | |
| *** ricolin has joined #openstack-nova | 06:27 | |
| *** hamdyk has joined #openstack-nova | 06:31 | |
| *** hjensas has quit IRC | 06:32 | |
| *** luksky has quit IRC | 06:36 | |
| *** Sundar has quit IRC | 06:40 | |
| *** takamatsu has quit IRC | 06:46 | |
| *** gibi has joined #openstack-nova | 06:50 | |
| *** pcaruana has joined #openstack-nova | 06:56 | |
| *** markvoelker has joined #openstack-nova | 06:59 | |
| *** guozijn has joined #openstack-nova | 06:59 | |
| *** bhagyashris has quit IRC | 07:04 | |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support delete_on_termination in volume attach api https://review.opendev.org/612949 | 07:05 |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot https://review.opendev.org/580336 | 07:05 |
| *** brinzhang has quit IRC | 07:07 | |
| *** boxiang_ has quit IRC | 07:07 | |
| *** brinzhang has joined #openstack-nova | 07:07 | |
| *** boxiang_ has joined #openstack-nova | 07:07 | |
| *** hjensas has joined #openstack-nova | 07:14 | |
| *** tesseract has joined #openstack-nova | 07:14 | |
| openstackgerrit | Harald Jensås proposed openstack/nova master: cell_mapping - wrap IPv6 address in format_url https://review.opendev.org/664559 | 07:17 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Defaults missing group_policy to 'none' https://review.opendev.org/657796 | 07:17 |
| *** helenfm has joined #openstack-nova | 07:19 | |
| *** psachin has quit IRC | 07:19 | |
| *** nicolasbock has joined #openstack-nova | 07:20 | |
| *** yaawang has quit IRC | 07:20 | |
| *** nicolasbock has quit IRC | 07:22 | |
| *** rcernin has quit IRC | 07:22 | |
| *** nicolasbock has joined #openstack-nova | 07:23 | |
| *** nicolasbock has quit IRC | 07:23 | |
| *** nicolasbock has joined #openstack-nova | 07:24 | |
| *** damien_r has joined #openstack-nova | 07:25 | |
| *** yaawang has joined #openstack-nova | 07:25 | |
| *** nicolasbock has quit IRC | 07:26 | |
| *** tetsuro has joined #openstack-nova | 07:30 | |
| *** markvoelker has quit IRC | 07:33 | |
| *** dtantsur|afk is now known as dtantsur | 07:34 | |
| *** nicolasbock has joined #openstack-nova | 07:34 | |
| *** slaweq has joined #openstack-nova | 07:36 | |
| *** takamatsu has joined #openstack-nova | 07:37 | |
| *** nicolasbock has quit IRC | 07:37 | |
| *** nicolasbock has joined #openstack-nova | 07:41 | |
| *** ralonsoh has joined #openstack-nova | 07:42 | |
| *** slaweq has quit IRC | 07:44 | |
| *** slaweq has joined #openstack-nova | 07:48 | |
| *** luksky has joined #openstack-nova | 07:49 | |
| *** jangutter_ has joined #openstack-nova | 07:53 | |
| *** jangutter has quit IRC | 07:56 | |
| *** ttsiouts has joined #openstack-nova | 07:57 | |
| *** ccamacho has joined #openstack-nova | 07:58 | |
| *** boxiang_ has quit IRC | 07:59 | |
| *** kashyap has joined #openstack-nova | 07:59 | |
| *** boxiang_ has joined #openstack-nova | 08:00 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663011 | 08:00 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Merge machine_type_mappings into get_default_machine_type https://review.opendev.org/664036 | 08:01 |
| *** takashin has left #openstack-nova | 08:01 | |
| lyarwood | stephenfin: ^ would you mind +W'ing these again once they pass, had to rebase to pull in https://review.opendev.org/#/c/664622/ | 08:01 |
| *** guilhermesp has quit IRC | 08:01 | |
| *** seyeongkim has quit IRC | 08:02 | |
| *** seyeongkim has joined #openstack-nova | 08:03 | |
| *** guilhermesp has joined #openstack-nova | 08:03 | |
| *** tetsuro has quit IRC | 08:13 | |
| *** ttsiouts has quit IRC | 08:16 | |
| *** igordc has quit IRC | 08:17 | |
| *** ttsiouts has joined #openstack-nova | 08:17 | |
| *** slaweq has quit IRC | 08:19 | |
| *** tetsuro has joined #openstack-nova | 08:19 | |
| *** ttsiouts has quit IRC | 08:21 | |
| *** tkajinam has quit IRC | 08:23 | |
| *** ttsiouts has joined #openstack-nova | 08:24 | |
| *** tetsuro has quit IRC | 08:29 | |
| *** markvoelker has joined #openstack-nova | 08:30 | |
| *** tetsuro has joined #openstack-nova | 08:30 | |
| *** boxiang_ has quit IRC | 08:31 | |
| *** boxiang_ has joined #openstack-nova | 08:31 | |
| *** mdbooth has joined #openstack-nova | 08:34 | |
| *** tssurya has joined #openstack-nova | 08:35 | |
| *** tetsuro has quit IRC | 08:36 | |
| *** derekh has joined #openstack-nova | 08:37 | |
| *** imacdonn has quit IRC | 08:38 | |
| *** guozijn has quit IRC | 08:38 | |
| *** nicolasbock has quit IRC | 08:38 | |
| *** imacdonn has joined #openstack-nova | 08:39 | |
| *** takamatsu has quit IRC | 08:39 | |
| *** takamatsu has joined #openstack-nova | 08:40 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: [WIP] Add 'power-update' external event to listen to ironic https://review.opendev.org/645611 | 08:49 |
| *** jaosorior has quit IRC | 08:51 | |
| *** cdent has joined #openstack-nova | 08:58 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: WIP: Specify availability_zone to unshelve https://review.opendev.org/663851 | 08:59 |
| *** nicolasbock has joined #openstack-nova | 09:00 | |
| *** markvoelker has quit IRC | 09:03 | |
| *** slaweq has joined #openstack-nova | 09:03 | |
| *** luksky has quit IRC | 09:04 | |
| *** slaweq has quit IRC | 09:09 | |
| * asettle is re-reading backscroll | 09:09 | |
| asettle | efried, "is comprised of" is what gets you going :p love it | 09:09 |
| aspiers | asettle: this means you're a nova hacker now | 09:10 |
| asettle | I imagine that's correct, yep | 09:10 |
| *** takamatsu has quit IRC | 09:14 | |
| *** ociuhandu has joined #openstack-nova | 09:17 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: WIP: Specify availability_zone to unshelve https://review.opendev.org/663851 | 09:21 |
| openstackgerrit | Li Zhouzhou proposed openstack/nova stable/rocky: NumaTopolgyFilter dosen't work as expected as pci_numa_policy is 'legacy' https://review.opendev.org/664838 | 09:31 |
| *** maciejjozefczyk has joined #openstack-nova | 09:34 | |
| *** hjensas is now known as hjensas|afk | 09:38 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/457886 | 09:40 |
| asettle | sean-k-mooney, I should never have commented on that post. Now it's a fan fav :p | 09:40 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Skip test_check_doubled_words hacking check UT https://review.opendev.org/664841 | 09:41 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/664512 | 09:42 |
| *** maciejjozefczyk has quit IRC | 09:49 | |
| *** maciejjozefczyk has joined #openstack-nova | 09:50 | |
| *** takamatsu has joined #openstack-nova | 09:51 | |
| lyarwood | mdbooth: https://review.opendev.org/#/c/457886/ - would you mind taking a look at this today if you have time | 09:56 |
| mdbooth | lyarwood: Ack. I recall not liking it in a previous version? | 09:57 |
| lyarwood | mdbooth: well as long as you're going into this with an open mind | 09:59 |
| lyarwood | mdbooth: but yeah I've reworked it since then iirc | 09:59 |
| mdbooth | lyarwood: ;) | 09:59 |
| mdbooth | lyarwood: I saw. | 09:59 |
| *** markvoelker has joined #openstack-nova | 10:00 | |
| *** jangutter has joined #openstack-nova | 10:02 | |
| *** ttsiouts has quit IRC | 10:05 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | 10:05 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test https://review.opendev.org/664245 | 10:05 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper https://review.opendev.org/663102 | 10:05 |
| *** brinzh has joined #openstack-nova | 10:06 | |
| *** jangutter_ has quit IRC | 10:06 | |
| *** brinzhang has quit IRC | 10:08 | |
| sean-k-mooney | asettle: i found a book you will hate or love last night https://www.amazon.com/Accidence-Will-Happen-Non-Pedantic-English/dp/0297871935/ref=tmm_hrd_swatch_0?_encoding=UTF8&qid=1560294844&sr=8-2 | 10:09 |
| asettle | Ha! | 10:09 |
| asettle | I'm not entirely too sure I want to read that, you know | 10:09 |
| sean-k-mooney | i went donw the rabbit whole of is "is comprised of" correct to use in ireland vs other english speaking countries | 10:11 |
| sean-k-mooney | considering i the amount of govenment and university site in ireland that use it i have more or less come to the conclution that in ireland at least its an accepted usage but i came across that book in my adventures | 10:14 |
| *** sridharg has quit IRC | 10:15 | |
| *** maciejjozefczyk has quit IRC | 10:15 | |
| *** takamatsu has quit IRC | 10:16 | |
| cdent | asettle: step away from the usage books | 10:20 |
| asettle | sean-k-mooney, damn that is a rabbit hole | 10:21 |
| asettle | I'll admit - I don't care terribly ;) it took me a little while to wrap my head around the discussion | 10:21 |
| asettle | Thinking about it, I would usually put "is comprised of" but efried is right, it's not correct | 10:21 |
| asettle | cdent, I'm so very far away | 10:22 |
| *** rpittau is now known as rpittau|afk | 10:22 | |
| * cdent has learned not to question efried on grammar | 10:22 | |
| asettle | Yeah good call. I won't be doing that either :p | 10:24 |
| cdent | save your energy for philosophical debate | 10:25 |
| asettle | Which... I do... regularly? | 10:25 |
| *** jbernard_ is now known as jbernard | 10:26 | |
| cdent | I mean with efried in particular. It's a bizarre form of stimulating | 10:26 |
| cdent | with grammar you can't win, but philosophy, something else happens | 10:27 |
| *** guozijn has joined #openstack-nova | 10:32 | |
| *** markvoelker has quit IRC | 10:34 | |
| *** davidsha has joined #openstack-nova | 10:38 | |
| *** guozijn has quit IRC | 10:43 | |
| sean-k-mooney | cdent: actully that useage book basicly explains why many of the rules we use are no longer followed in common usage and advies that you use common sense when deciding if a rule should be followed or ignored | 10:48 |
| sean-k-mooney | cdent: which is why is said asettle will either love it or hate it :) | 10:48 |
| cdent | in truth, neither you, nor I, are in much of a position to be discussing usage :) | 10:49 |
| *** takamatsu has joined #openstack-nova | 10:49 | |
| sean-k-mooney | the second half of the book i belive tries to explain why some of the rule exist and actully teaches you why some of the rule exisit | 10:49 |
| sean-k-mooney | cdent: that is very true that said i at least can ligitamtly point to the fact i speak a different dialect of english which has idioms from irish carried over :) | 10:51 |
| * cdent thinks of an excuse | 10:51 | |
| cdent | hmm. born UK, raised US, now in UK? not really good enough | 10:52 |
| sean-k-mooney | oh i didnt know you grew up in the US what part? | 10:52 |
| *** jaosorior has joined #openstack-nova | 10:53 | |
| cdent | indiana, kentucky, ohio | 10:53 |
| sean-k-mooney | do you ever miss it? | 10:54 |
| sean-k-mooney | efried: did your hacking change merge last night? | 10:55 |
| cdent | For 4 years before I moved to the UK I lived in Seattle. I sometimes miss the pacific northwest, but don't really miss the other parts. | 10:58 |
| kashyap | sean-k-mooney: I think it did | 10:58 |
| cdent | it did, saw the launchpad update | 10:59 |
| sean-k-mooney | cool so i just need to rebase on top of master rather then that specific patch | 10:59 |
| *** ttsiouts has joined #openstack-nova | 11:01 | |
| *** hjensas|afk is now known as hjensas | 11:02 | |
| *** luksky has joined #openstack-nova | 11:14 | |
| *** jaosorior has quit IRC | 11:15 | |
| *** mdbooth has quit IRC | 11:18 | |
| * aspiers is dealing with the same hacking rebase | 11:20 | |
| *** adrianreza_ has joined #openstack-nova | 11:26 | |
| *** jaosorior has joined #openstack-nova | 11:28 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680 | 11:34 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Track inventory for new MEM_ENCRYPTION_CONTEXT resource class https://review.opendev.org/662105 | 11:34 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 11:34 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Use fake flavor instead of empty dict in test https://review.opendev.org/662555 | 11:34 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Pass extra_specs to flavor in vif tests https://review.opendev.org/662556 | 11:34 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | 11:34 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add <launchSecurity> element to guest config for AMD SEV https://review.opendev.org/636318 | 11:34 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Allow guest devices to include <driver iommu='on' /> https://review.opendev.org/644564 | 11:34 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: WIP: Detect that SEV is required and enable iommu for devices https://review.opendev.org/644565 | 11:34 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Use <launchSecurity> element when SEV is required https://review.opendev.org/662557 | 11:34 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Enable memory locking if SEV is requested https://review.opendev.org/662558 | 11:34 |
| aspiers | efried: all SEV stuff now in a single series ^^^ The top 3 can be ignored for now however, since the 3rd from top is still WIP. | 11:39 |
| *** ratailor has quit IRC | 11:41 | |
| *** hjensas has quit IRC | 11:57 | |
| *** francoisp has quit IRC | 12:07 | |
| *** francoisp has joined #openstack-nova | 12:09 | |
| *** udesale has quit IRC | 12:10 | |
| *** brinzh has quit IRC | 12:10 | |
| *** udesale has joined #openstack-nova | 12:11 | |
| *** bbobrov has quit IRC | 12:14 | |
| *** dave-mccowan has joined #openstack-nova | 12:17 | |
| *** guozijn has joined #openstack-nova | 12:25 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 12:25 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Include direct-physical in compute manager events check https://review.opendev.org/664431 | 12:25 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/664442 | 12:25 |
| *** boxiang_ has quit IRC | 12:27 | |
| *** boxiang_ has joined #openstack-nova | 12:27 | |
| alex_xu | efried: sean-k-mooney bauzas do you have any idea how can I process when the user specify both the hw:pmem and resources extraspec https://review.opendev.org/#/c/601596/14/specs/train/approved/virtual-persistent-memory.rst@261 | 12:29 |
| sean-k-mooney | im reading that spec at the moment | 12:29 |
| alex_xu | I thought we should have similar problem when we have numa on placement. how to deal with hw:numa_* stuff and resources | 12:29 |
| sean-k-mooney | well at present the resouces:* extra spec are merged with teh auto calluated set | 12:30 |
| sean-k-mooney | so we caluate teh vcpu and ram form the flavor and then you can override that using resouces:MEMORY_MB=X | 12:31 |
| sean-k-mooney | but ideally i think we would prefer people not to ues resouces: directly | 12:31 |
| alex_xu | +1 on not use resources directly | 12:32 |
| sean-k-mooney | if they use hw:pmem that give us the flexablity adapt to placment modeling changes without needing to modify flavors | 12:32 |
| alex_xu | sean-k-mooney: the problem is we have instance.vpmems field, and we extra the vpmem from extra spec, and put them in instance.vpmems. if the user uses resources directly, then we should parse resources, and put them back to the instance.vpmems? | 12:33 |
| sean-k-mooney | usign resouces:* directly works but its a leaky abstraction | 12:33 |
| alex_xu | also agree with that | 12:33 |
| *** hjensas has joined #openstack-nova | 12:34 | |
| alex_xu | I thought we will have same problem for instance.numa_topology. if the user use the resources directly, how can we parse the guest numa topo from resources extra spec, and put them back to isntance.numa_topology | 12:34 |
| sean-k-mooney | well today we dont model numa in placmenet | 12:35 |
| sean-k-mooney | if we did then it would be a proablem we would have to sovle yes | 12:35 |
| alex_xu | it is a problem for pmem now :) | 12:35 |
| sean-k-mooney | the hw:* extrapecs are the ahtoritive ones for how the guest is virtualised | 12:35 |
| sean-k-mooney | the resouces:* are authritive for resouce usage | 12:36 |
| sean-k-mooney | if there is a conflcit wew could rais an exception | 12:36 |
| sean-k-mooney | i need to finish re reading the spec but are we adding a request prefilter for this | 12:36 |
| *** rpittau|afk is now known as rpittau | 12:36 | |
| sean-k-mooney | i.e. to convert form hw:pmem to the placement requests? | 12:36 |
| alex_xu | do we need? or just parse the hw:pmem in the ResourceRequest.from_extra_specs ? | 12:37 |
| sean-k-mooney | if so then i would have it validate them and raise an exception if there is a conflict | 12:37 |
| aspiers | sean-k-mooney, alex_xu: I just did something very similar for SEV | 12:37 |
| aspiers | https://review.opendev.org/#/c/664420/4 | 12:37 |
| sean-k-mooney | alex_xu: am we could just parse it there yes | 12:37 |
| alex_xu | aspiers: nice | 12:37 |
| alex_xu | sean-k-mooney: yea | 12:38 |
| sean-k-mooney | aspiers: your using a request prefilter | 12:38 |
| aspiers | yes | 12:38 |
| alex_xu | at least request prefilter is better than mixing everything ResourceRequest.from_extra_specs | 12:39 |
| sean-k-mooney | right the ohter option is to do it here https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L387 | 12:39 |
| sean-k-mooney | and in resources_from_request_spec | 12:40 |
| sean-k-mooney | but the prefilter i think are cleaner | 12:40 |
| sean-k-mooney | both would work | 12:40 |
| alex_xu | yes, agree | 12:40 |
| alex_xu | we can add that for pmem | 12:40 |
| *** jaosorior has quit IRC | 12:41 | |
| sean-k-mooney | alex_xu: as aspiers has done you can do your validation like this https://review.opendev.org/#/c/664420/4/nova/scheduler/request_filter.py@197 | 12:41 |
| sean-k-mooney | to ensure there is no conflict | 12:42 |
| aspiers | right | 12:42 |
| alex_xu | sean-k-mooney: then the instance is going to error status? | 12:42 |
| sean-k-mooney | yes i think so | 12:42 |
| alex_xu | I guess people hate the instance is going to error status.... | 12:42 |
| sean-k-mooney | we will refuse to sechdule | 12:43 |
| sean-k-mooney | well if we did not validate it would still go into error | 12:43 |
| sean-k-mooney | but it woudl be a no valid host error | 12:43 |
| alex_xu | we can validate that in the API layer | 12:43 |
| sean-k-mooney | as teh livbrt driver would presuably fail to swapn it | 12:43 |
| alex_xu | the request prefilter is only do the placement translation | 12:44 |
| sean-k-mooney | where in the api laryer? | 12:44 |
| sean-k-mooney | on flavor setting properties on teh flaovr or on instance spawn | 12:44 |
| alex_xu | like somewhere we validate the hw:numa_* extra specs | 12:45 |
| sean-k-mooney | we dont | 12:45 |
| sean-k-mooney | well the first validation happens in the numa toplogy filter | 12:45 |
| sean-k-mooney | but its not really validation we try to use the values to filter a host and that either work or it doesnt | 12:46 |
| sean-k-mooney | so i think doing it in the prefilter which is even earlier in scheduling is fine | 12:46 |
| *** mdbooth has joined #openstack-nova | 12:46 | |
| alex_xu | wo do, let me find the link | 12:46 |
| alex_xu | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L659 | 12:47 |
| sean-k-mooney | oh ok i really never knew that was there | 12:48 |
| sean-k-mooney | in that case sure you can add the same validate for pmem | 12:48 |
| alex_xu | so we can resolve the conflict of hw:pmem and resource:* somewhere like that | 12:48 |
| alex_xu | \o/ finally find something sean-k-mooney doesn't know | 12:49 |
| * aspiers claps | 12:49 | |
| alex_xu | so I can override resources:* when hw:pmem present. | 12:49 |
| sean-k-mooney | hehe :) there are plenty of things i dont know like how to use a mac without breaking it or how to spell litrally everything | 12:49 |
| aspiers | XD | 12:50 |
| alex_xu | hah | 12:50 |
| aspiers | sean-k-mooney: maybe not, but I bet you can help me with this problem | 12:50 |
| *** _erlon_ has joined #openstack-nova | 12:50 | |
| alex_xu | the last question is what should I do for the user only specify the resources:*. so I can prase the resources:* and put them into instance.vpmems. | 12:50 |
| aspiers | https://review.opendev.org/#/c/644565/5/nova/virt/libvirt/driver.py@1625 | 12:50 |
| aspiers | I need to change _sev_required() so that it checks the resource allocations for the instance (the MEMORY_ENCRYPTION_CONTEXT class) | 12:51 |
| aspiers | but the callers don't have access to the resource allocations | 12:51 |
| aspiers | AFAICS | 12:51 |
| sean-k-mooney | alex_xu: i think we shoudl require uses to use hw:pmem personally as we might want to use the resouce class for something else in the future | 12:51 |
| aspiers | they have access to the request context and the instance, but not the allocations | 12:52 |
| sean-k-mooney | alex_xu: im thinking of the case where we might want to back guest ram by PMEM | 12:52 |
| sean-k-mooney | e.g. as an alternive to hugepages | 12:52 |
| sean-k-mooney | or file backed memeory | 12:52 |
| sean-k-mooney | aspiers: looking | 12:53 |
| *** zbr|rover is now known as zbr|flow | 12:53 | |
| alex_xu | good idea | 12:53 |
| aspiers | I found _instance_to_allocations_dict() in scheduler/client/report.py which maybe could extract the allocations from the instance, but I don't know if that's right | 12:53 |
| alex_xu | do you mean reject pmem resource class in extra spec resource:*? | 12:53 |
| aspiers | also, nothing uses that method any more, since Iec02942d38 removed the last callers of it | 12:53 |
| * aspiers looks at efried for that | 12:54 | |
| sean-k-mooney | alex_xu: we could but i was thinking just not populating the instance.vpmems from it | 12:54 |
| *** guozijn has quit IRC | 12:55 | |
| alex_xu | that will do an allocation in the placement, but in the end, the instance won't attach the pmem | 12:55 |
| sean-k-mooney | aspiers: do you need to cehck the resouce allocation or jsut the flavor | 12:55 |
| aspiers | sean-k-mooney: the allocation | 12:55 |
| aspiers | that's what efried said yesterday | 12:55 |
| sean-k-mooney | im not sure why checking the request_sepc or flavor/image would not be enough | 12:56 |
| aspiers | sean-k-mooney: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-06-11.log.html#t2019-06-11T16:49:51 | 12:56 |
| aspiers | sean-k-mooney: but maybe when efried wrote that he didn't know that _sev_required() needs to be called from multiple locations in the driver code which don't have access to allocations | 13:00 |
| aspiers | I guess I could set another instance variable | 13:00 |
| sean-k-mooney | the instance contains the request_sepc and the request spec contains the request_resouces | 13:00 |
| *** spatel has joined #openstack-nova | 13:00 | |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L98 | 13:00 |
| aspiers | but requested_resources is different from allocations, no? | 13:01 |
| sean-k-mooney | it is | 13:01 |
| sean-k-mooney | and it does not currenly hav the info you want see the comment above | 13:01 |
| *** markvoelker has joined #openstack-nova | 13:01 | |
| aspiers | right | 13:01 |
| sean-k-mooney | im just wondering is that better to use in the future | 13:01 |
| aspiers | in fact efried wants me to help fix that | 13:01 |
| aspiers | I'm guessing that code which wants to know whether to add SEV bits to the libvirt XML config should be checking what got allocated, not just what got requested | 13:02 |
| sean-k-mooney | they should be the same thing | 13:02 |
| sean-k-mooney | if placemnet returned an allcoation candatae then eveything that was requested was allcoated | 13:03 |
| aspiers | I guess in the MEM_ENCRYPTION_CONTEXT case where only 1 unit is requested they have to be the same | 13:03 |
| sean-k-mooney | looking at the instance object i dont see the allcoation stored anywhere | 13:03 |
| aspiers | yeah I couldn't either | 13:03 |
| aspiers | I found https://opendev.org/openstack/nova/src/branch/master/nova/compute/manager.py#L2434 | 13:05 |
| *** luksky has quit IRC | 13:05 | |
| aspiers | that passes allocations to spawn() via https://opendev.org/openstack/nova/src/branch/master/nova/compute/manager.py#L2203 | 13:07 |
| sean-k-mooney | ya we do pass them to the driver | 13:08 |
| sean-k-mooney | https://opendev.org/openstack/nova/src/branch/master/nova/compute/manager.py#L2207 | 13:08 |
| aspiers | that's 4 lines below my link :) | 13:08 |
| aspiers | same thing | 13:08 |
| aspiers | but then allocs doesn't get passed around to all the smaller methods called by spawn() | 13:08 |
| sean-k-mooney | right its only used to get teh mdevs | 13:09 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3237 | 13:09 |
| aspiers | so maybe I can set an _sev_required instance variable in spawn() | 13:09 |
| sean-k-mooney | well you could jsut pass the allcoation to _get_guest_xml | 13:10 |
| aspiers | or somewhere underneath that | 13:10 |
| aspiers | that's a good idea | 13:10 |
| aspiers | I guess I only need it for constructing XML | 13:10 |
| aspiers | so that would scope it correctly | 13:11 |
| aspiers | hopefully efried will come online before I disappear down this rathole :) | 13:11 |
| *** BjoernT has joined #openstack-nova | 13:12 | |
| sean-k-mooney | its still a little messy | 13:12 |
| sean-k-mooney | i think really we want to add the allcotion to the instance | 13:12 |
| sean-k-mooney | that way you dont need to pass a new param all over the place | 13:13 |
| aspiers | yeah | 13:13 |
| sean-k-mooney | and i think more things will need the allocation in the future anyway | 13:13 |
| sean-k-mooney | we track things like pci device allcotation in teh instance already so i think that is the best path forward. | 13:13 |
| aspiers | sounds reasonable but I can't really comment | 13:14 |
| *** eharney has joined #openstack-nova | 13:14 | |
| sean-k-mooney | efried: when you are online any objection to adding the allocations form placmenet to the instnace object? | 13:15 |
| *** lbragstad has joined #openstack-nova | 13:20 | |
| artom | sean-k-mooney, sorta like network_info in info_cache? | 13:21 |
| sean-k-mooney | not quite although kind of | 13:22 |
| sean-k-mooney | artom: we store the list of pci devices allocated to an instance in the instance | 13:23 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L200 | 13:23 |
| sean-k-mooney | so that we can use the same ones on reboot | 13:23 |
| sean-k-mooney | it would be somewhat like storing the vifs in the info_cache | 13:23 |
| sean-k-mooney | but keeping the allocation in the insantce so we dont have to look them up on swapn or reboot makes sense | 13:24 |
| sean-k-mooney | *start or reboot | 13:24 |
| *** mgariepy has quit IRC | 13:27 | |
| *** artom has quit IRC | 13:29 | |
| *** mgariepy has joined #openstack-nova | 13:29 | |
| *** pcaruana has quit IRC | 13:30 | |
| *** pcaruana|afk| has joined #openstack-nova | 13:30 | |
| sean-k-mooney | ... | 13:30 |
| sean-k-mooney | i think our vgpu code is busted | 13:30 |
| sean-k-mooney | bauzas: did you ever test stopping an instance with vgpus | 13:31 |
| sean-k-mooney | then starting it again | 13:31 |
| *** jaosorior has joined #openstack-nova | 13:32 | |
| sean-k-mooney | power_on in the libvirt driver delegate to _hard_reboot which assumes the xml still exists to get the mdevs from | 13:32 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2897-L2900 | 13:32 |
| sean-k-mooney | power_off calls destroy | 13:33 |
| sean-k-mooney | so if you shutdown an instance with vgpus and then start it again it wont have vgpus... | 13:33 |
| *** dklyle has quit IRC | 13:34 | |
| *** markvoelker has quit IRC | 13:34 | |
| kashyap | Speaking of assigned devices, somepeople might find this tool ("mdevctl") useful: https://github.com/awilliam/mdevctl | 13:39 |
| kashyap | More info and background about it here: | 13:39 |
| kashyap | https://www.redhat.com/archives/libvir-list/2019-May/msg00722.html | 13:39 |
| kashyap | ("mdevctl: A shoestring mediated device management and persistence utility") | 13:39 |
| kashyap | It's a shell tool. So, be gentle with your eyes :D | 13:40 |
| sean-k-mooney | ya maybe | 13:40 |
| sean-k-mooney | they are not that hard to manage i personlaly would praobly do it with systemd rather then udev personally | 13:41 |
| kashyap | I don't know, if the VFIO maintainer suggests that, then I'd go the route they suggest. | 13:42 |
| sean-k-mooney | perhaps if it existited when i started managing mdev like 2 years ago maybe i think its still failly tivial to do yourself too | 13:44 |
| sean-k-mooney | kashyap: this is the striped down lib we created for managian mdevs for smart nics last year https://github.com/intel-orchestration-software/networking-vhost-vfio/blob/master/networking_vhost_vfio/mdev/mdev.py | 13:47 |
| kashyap | sean-k-mooney: If it were "trivial", why would they write that tool? | 13:47 |
| sean-k-mooney | it does not do persistence but at the time i also looked into doing it with systemd | 13:47 |
| sean-k-mooney | kashyap: because they felt like it? just because its trivial to do does not mean you dont have to do it alot and still want to automate it | 13:48 |
| *** liuyulong has joined #openstack-nova | 13:49 | |
| *** rafaelweingartne has joined #openstack-nova | 13:49 | |
| *** mriedem has joined #openstack-nova | 13:49 | |
| openstackgerrit | Merged openstack/nova master: Make get_provider_by_name public and remove safe_connect https://review.opendev.org/664062 | 13:49 |
| rafaelweingartne | Hello guys, is there an "openstack server event list" command like that is able to list the events for deleted VMs? | 13:50 |
| *** jaosorior has quit IRC | 13:50 | |
| sean-k-mooney | im not sure that is what that is for | 13:52 |
| *** mlavalle has joined #openstack-nova | 13:52 | |
| rafaelweingartne | no? | 13:52 |
| *** ricolin_ has joined #openstack-nova | 13:52 | |
| sean-k-mooney | i think it list the life cycle events a server has undergone | 13:52 |
| sean-k-mooney | i dont think you can use it to wait for an event | 13:52 |
| rafaelweingartne | It looks like it is presenting he vents I need/want such as attaching something, and or creating the vm | 13:53 |
| rafaelweingartne | ah | 13:53 |
| rafaelweingartne | no, I do not want to wait | 13:53 |
| kashyap | sean-k-mooney: It's not "they felt like it"; there's a proper rationale there. | 13:53 |
| kashyap | [quote] | 13:53 |
| kashyap | Currently mediated device management, much like SR-IOV VF management, | 13:53 |
| kashyap | is largely left as an exercise for the user. This is an attempt to | 13:53 |
| kashyap | provide something and see where it goes. I doubt we'll solve | 13:53 |
| kashyap | everyone's needs on the first pass, but maybe we'll solve enough and | 13:53 |
| rafaelweingartne | I just want to list all events that already happened to a VM | 13:53 |
| kashyap | provide helpers for the rest. Without further ado, I'll point to what | 13:53 |
| kashyap | I have so far: | 13:53 |
| kashyap | [/quote] | 13:53 |
| rafaelweingartne | sean-k-mooney: I think your reply was not meant for me | 13:54 |
| rafaelweingartne | sorry ;) | 13:54 |
| sean-k-mooney | kashyap: sure but its proably not the first attempt to do that either | 13:54 |
| *** whoami-rajat has quit IRC | 13:55 | |
| sean-k-mooney | rafaelweingartne: no it was | 13:55 |
| *** ricolin has quit IRC | 13:55 | |
| sean-k-mooney | i was stating that cli command is to show the list of event that server has undergon. but im currently confiming | 13:55 |
| rafaelweingartne | ah o | 13:56 |
| rafaelweingartne | ok | 13:56 |
| rafaelweingartne | but that is actually what I want/need | 13:56 |
| rafaelweingartne | to list everything that has already happened to a VM | 13:56 |
| rafaelweingartne | the problem is that it only works for VMs that have not beeing deleted | 13:56 |
| rafaelweingartne | or at least, I was not able to use it for deleted VMs | 13:56 |
| sean-k-mooney | deleted or soft deleted | 13:58 |
| rafaelweingartne | the difference is not that clear to me | 13:58 |
| rafaelweingartne | deleted | 13:58 |
| *** whoami-rajat has joined #openstack-nova | 14:01 | |
| sean-k-mooney | this is basically showing the events form the instance action log | 14:01 |
| sean-k-mooney | i did not think we removed that when we deleted an instace provided you have not archive teh deleted instances or purged them form the db | 14:02 |
| sean-k-mooney | but maybe we do not allow you to retrive the info | 14:02 |
| rafaelweingartne | that is what I thought | 14:03 |
| rafaelweingartne | is this implemented in Nova API? | 14:03 |
| *** yankcrime has quit IRC | 14:03 | |
| rafaelweingartne | or is it somewhere else? where I can take a look and maybe propose a method to retrieve data for deleted VMs as well | 14:03 |
| sean-k-mooney | i think its hitting this endpoint https://developer.openstack.org/api-ref/compute/?expanded=list-server-usage-audits-detail | 14:04 |
| *** jaosorior has joined #openstack-nova | 14:04 | |
| sean-k-mooney | actully no that is not correct | 14:05 |
| sean-k-mooney | its hitting the server action endpoint | 14:06 |
| sean-k-mooney | https://developer.openstack.org/api-ref/compute/?expanded=list-server-usage-audits-detail,list-actions-for-server-detail#list-actions-for-server | 14:06 |
| rafaelweingartne | cool thanks | 14:07 |
| rafaelweingartne | I was looking for "/servers/{server_id}/events"... | 14:08 |
| rafaelweingartne | now I know why I did not find it | 14:08 |
| rafaelweingartne | What does this "Action information of deleted instances can be returned for requests starting with microversion 2.21." mean? | 14:08 |
| rafaelweingartne | Nova version? | 14:08 |
| rafaelweingartne | Nova-compute* | 14:09 |
| sean-k-mooney | the nova api support microversion form v2.1 on | 14:09 |
| sean-k-mooney | but the openstack client does not use them | 14:09 |
| sean-k-mooney | it default to 2.1 | 14:09 |
| sean-k-mooney | so if you want to get it to work you have to pass a a microverion of at lest 2.21 | 14:10 |
| sean-k-mooney | one sec | 14:10 |
| sean-k-mooney | add --os-compute-api-version 2.21 to the request | 14:11 |
| sean-k-mooney | *command | 14:11 |
| *** factor has quit IRC | 14:12 | |
| *** factor has joined #openstack-nova | 14:15 | |
| rafaelweingartne | something like? "openstack server event list 9b82ae8f-ac7e-47e9-819c-24105631df80 --os-compute-api-version 2.21" | 14:16 |
| rafaelweingartne | I just checked the code, and aren't the instances removed from "instance_mappings" table when they get deleted? | 14:16 |
| *** takamatsu has quit IRC | 14:18 | |
| *** igordc has joined #openstack-nova | 14:26 | |
| *** ttsiouts has quit IRC | 14:27 | |
| *** ttsiouts has joined #openstack-nova | 14:28 | |
| efried | sean-k-mooney: First blush, adding the allocations from placement to the Instance object sounds like a solid idea. | 14:29 |
| *** takamatsu has joined #openstack-nova | 14:31 | |
| *** markvoelker has joined #openstack-nova | 14:32 | |
| *** cdent has quit IRC | 14:32 | |
| *** ttsiouts has quit IRC | 14:32 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix double word hacking test https://review.opendev.org/664940 | 14:34 |
| stephenfin | efried: f*** me that was a rabbit hole and half ^ | 14:34 |
| efried | stephenfin: no doubt. Looking... | 14:35 |
| stephenfin | tl;dr: I can't decide if either the Python patch or pycodestyle is broken, but it's the edgiest of edge cases that we'd only really see in tests, so we can work around it | 14:35 |
| mriedem | rafaelweingartne: no, | 14:37 |
| rafaelweingartne | hmm | 14:37 |
| mriedem | the instance mappings are cleaned up when you archive | 14:37 |
| mriedem | nova-manage db archive_deleted_rows | 14:38 |
| mriedem | rafaelweingartne: 2.21 is about instance actions / events | 14:38 |
| *** takamatsu has quit IRC | 14:38 | |
| mriedem | rafaelweingartne: https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server-event.html | 14:39 |
| gibi | stephenfin: what a detective work! | 14:39 |
| dansmith | mriedem: can you quickly weigh in on this? I thought you might care about the use of a sentinel value in nova-manage. Otherwise I'm good with it: https://review.opendev.org/#/c/662383/5 | 14:42 |
| *** dklyle has joined #openstack-nova | 14:45 | |
| mriedem | ew | 14:45 |
| *** tetsuro has joined #openstack-nova | 14:46 | |
| * dansmith knew it | 14:46 | |
| dansmith | before you shame him, note that it was my idea :) | 14:47 |
| *** ttsiouts has joined #openstack-nova | 14:47 | |
| *** hamdyk has quit IRC | 14:48 | |
| mriedem | i'm just trying to think of alternatives, | 14:48 |
| mriedem | i saw melwitt pointed out https://review.opendev.org/#/c/603998/ but i'm not sure what that change is doing, | 14:49 |
| mriedem | with takashi's change, | 14:49 |
| mriedem | if you specify one but not the other it's an error, | 14:50 |
| mriedem | i was thinking, what if we change the logic such that if you specify one but not the other, we just don't read from the config for the other (don't set/update the other) | 14:50 |
| *** JamesBenson has joined #openstack-nova | 14:50 | |
| mriedem | if you don't specify either, we use config, | 14:50 |
| mriedem | if you specify both, we set/update both, | 14:50 |
| dansmith | that just seems confusing to me | 14:50 |
| mriedem | if you only provide one, we only use one | 14:50 |
| mriedem | i think that's more in line with how osc set commands work | 14:51 |
| dansmith | I was actually expecting to have a --transport_url=(keep|config|[url]) sort of thing, but.. | 14:51 |
| dansmith | the confusing bit is that we do the magic config thing if we don't specify either.. if we specify one, then we do a totally different set of things | 14:52 |
| mriedem | i'm assumine when this was written, we expected people were either using all of the command options or none to let config handle it | 14:52 |
| mriedem | not a mix | 14:52 |
| dansmith | this has tripped up more than one person who was surprised by one or the other behaviors | 14:52 |
| dansmith | well, | 14:52 |
| dansmith | I think it actually came from create, where that makes more sense | 14:53 |
| dansmith | and we imported the same behavior for update where it does not | 14:53 |
| *** Luzi has quit IRC | 14:54 | |
| mriedem | yeah ok i can see that, | 14:54 |
| mriedem | so in that case i think it makes more sense to only update the field provided via the option if only one option is provided, and ignore the other (don't use config) | 14:54 |
| dansmith | le sigh | 14:55 |
| mriedem | hey, you asked me | 14:57 |
| mriedem | anyway, i commented | 14:58 |
| mriedem | if we need a tie breaker i vote that we ask dean to weigh in | 14:58 |
| mriedem | mean dean okerlund | 14:58 |
| mriedem | from WWF fame | 14:58 |
| *** artom has joined #openstack-nova | 15:02 | |
| *** cdent has joined #openstack-nova | 15:04 | |
| *** cfriesen has joined #openstack-nova | 15:05 | |
| *** markvoelker has quit IRC | 15:05 | |
| *** jaosorior has quit IRC | 15:06 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix double word hacking test https://review.opendev.org/664940 | 15:07 |
| bauzas | sean-k-mooney: hey | 15:08 |
| bauzas | sean-k-mooney: yeah I tested it and it worked | 15:08 |
| bauzas | ie. stopping the instance and then restarting it | 15:09 |
| stephenfin | efried: I need to rebase this series now, right? https://review.opendev.org/#/c/651311/ | 15:09 |
| stephenfin | to pick up the fix to test_hacking.py | 15:09 |
| sean-k-mooney | bauzas: ok looking at the code im not sure where we figureout the mdevs in that case but i also didnt look | 15:09 |
| sean-k-mooney | to far | 15:09 |
| bauzas | sean-k-mooney: I provided a change for that | 15:09 |
| bauzas | sec | 15:09 |
| sean-k-mooney | my concern was we had to hit the placmenet api to look up the allcoation again | 15:10 |
| sean-k-mooney | which i dont think we shoudl have to do. | 15:10 |
| efried | stephenfin: I wouldn't think you need to rebase; I think zuul automatically rebases you against tip of master before starting tests | 15:10 |
| bauzas | sean-k-mooney: https://review.opendev.org/#/c/564257/ | 15:11 |
| bauzas | and https://review.opendev.org/#/c/533642/ | 15:11 |
| sean-k-mooney | bauzas: that wont fix it | 15:11 |
| sean-k-mooney | the second on might | 15:12 |
| stephenfin | efried: Yeah, I'm not sure. That said, I think I'm going to have to recheck every one of them again anyway so maybe a rebase would be the surer thing | 15:12 |
| stephenfin | Yeah, they're all -2 | 15:12 |
| * stephenfin rebases :( | 15:12 | |
| efried | stephenfin: Yeah, that would be an easy way to get them all back in the queue. Feel free to re+W the ones that were already +A. | 15:12 |
| sean-k-mooney | bauzas: quickly looking i dont think either of those will fix the edgecase i am thinking of | 15:12 |
| bauzas | sean-k-mooney: mmm N | 15:13 |
| bauzas | ? | 15:13 |
| sean-k-mooney | bauzas: if the instance is not found on the host in libvirt you retrun {] | 15:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance' https://review.opendev.org/651311 | 15:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312 | 15:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313 | 15:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314 | 15:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527 | 15:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reno for removed cells v1 policies https://review.opendev.org/662031 | 15:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'InstanceUnknownCell' exception https://review.opendev.org/662411 | 15:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950 | 15:13 |
| sean-k-mooney | bauzas: we can talk after standup | 15:13 |
| *** amodi has joined #openstack-nova | 15:14 | |
| *** Sundar has joined #openstack-nova | 15:16 | |
| sean-k-mooney | bauzas: basically if we stop the instance then we undefine the domain so if start it when we call _get_all_assigned_mediated_devices | 15:18 |
| sean-k-mooney | bauzas: we retrun {} | 15:18 |
| bauzas | I'm pretty sure I tested it | 15:18 |
| stephenfin | mriedem: Are you okay for me to rebase https://review.opendev.org/#/c/621061/ onto the cells v1 removal series (all but one +W'd now). It conflicts with that series and I'd like to use it as a new base for https://review.opendev.org/#/c/651315/ | 15:18 |
| mriedem | sure | 15:22 |
| mriedem | maybe you want to re-apply your +2 when doing so | 15:22 |
| *** nicolasbock has quit IRC | 15:24 | |
| *** pcaruana|afk| has quit IRC | 15:30 | |
| Sundar | sean-k-mooney: Re. tempest CI with a fake driver/device, I have some questions | 15:39 |
| Sundar | sean-k-mooney: When there is no real device, the VM bringup is going to fail. Not only that, there would be no VM in 'virsh list', so we can't do 'virsh dumpxml ...' to see if the right device(s) got attached. | 15:41 |
| Sundar | So, how would would one do any testing? | 15:41 |
| sean-k-mooney | Sundar: there are a few ways. one we can use dummy devices | 15:42 |
| sean-k-mooney | but the intent is to test teh end to end workflow not assert a spcific device exits | 15:43 |
| Sundar | What would be the success metric for the test? | 15:43 |
| mriedem | Sundar: tempest isn't going to be doing virsh list anyway | 15:46 |
| mriedem | tempest tests should be hypervisor agnostic, like the compute api should be hypervisor agnostic | 15:46 |
| mriedem | Sundar: the basic success metric for tempest tests are going to be that the API behaves as expected, | 15:47 |
| mriedem | i.e. if i create a server with a flavor configured for an ARQ device profile, that once the server is ACTIVE there is an attached ARQ in cyborg | 15:47 |
| mriedem | and when the server is deleted, the corresponding ARQ resource is also deleted | 15:48 |
| *** helenfm has quit IRC | 15:48 | |
| mriedem | Sundar: whitebox integration testing is something that would likely be done in a tempest plugin / tests that are configured to only run when there is real hardware in a 3rd party CI env | 15:49 |
| Sundar | mriedem: "once the server is ACTIVE" -- with a fake device, it never becomes active. It will go to error state. | 15:50 |
| mriedem | Sundar: because of the event not being sent from cyborg, or because libvirt will fail to start the domain? | 15:51 |
| Sundar | We need to ensure the device gets attached to the VM | 15:51 |
| *** jangutter has quit IRC | 15:51 | |
| sean-k-mooney | Sundar: not if we add a bus type for dummy devices and handel that in nova | 15:51 |
| Sundar | mridem: latter - libvirt will fail it | 15:51 |
| mriedem | then i agree with sean-k-mooney that we'd need to stub something out if we know we're using a fake device, | 15:52 |
| sean-k-mooney | Sundar: we dont we jsut need to pass info to nova to let it know its a fake device and libivirt can just not try to atach it | 15:52 |
| mriedem | which is gross, but i'd rather have that than no api integration testing | 15:52 |
| Sundar | sean-k-mooney: 'bus type for dumy devices' -- is this a new thing? It is not there today, right? | 15:52 |
| mriedem | wouldn't there be some metadata on the ARQ resource that can tell us (nova) that it's a fake device? | 15:52 |
| sean-k-mooney | sure but its useful for testing | 15:52 |
| mriedem | similar to vif type on a port | 15:53 |
| mriedem | or type on a volume | 15:53 |
| *** ttsiouts has quit IRC | 15:53 | |
| *** ttsiouts has joined #openstack-nova | 15:53 | |
| sean-k-mooney | Sundar: we have many thing we can do like have the fake driver create mdev or other software device like a loop device and tell nova to use those too | 15:54 |
| sean-k-mooney | or we can have a sentenel that just tells nova its a fake device for testing | 15:54 |
| Sundar | mriedem, sean-k-mooney: The attach handle in the ARQ, returned by Cyborg to Nova virt driver, will identify the type of the handle, e.g. 'PCI'. I could return a special type, say, 'testPCI', and modify Nova virt driver to ignore that | 15:55 |
| Sundar | That would be used solely for testing | 15:55 |
| sean-k-mooney | Sundar: yes that is basically what i was thinking wew would do | 15:55 |
| mriedem | i'd just calle it "fake" or something like that but yeah | 15:55 |
| Sundar | Ah ok. Got it. Thanks. :) | 15:56 |
| sean-k-mooney | Sundar: the real thing we want to test is teh end to end workflow | 15:56 |
| mriedem | s/real/main/ for now | 15:57 |
| sean-k-mooney | :) right | 15:57 |
| mriedem | real low-level whitebox integration testing can be done with 3rd party CI and real hardware, | 15:57 |
| mriedem | but let's not get the cart before the horse | 15:57 |
| sean-k-mooney | in a third party ci we can then also validate it with real hardware | 15:57 |
| sean-k-mooney | yep | 15:57 |
| *** ttsiouts has quit IRC | 15:58 | |
| stephenfin | mriedem: Cool. I spotted some other things when rebasing. Comments left and I've a follow-up patch I'll post. Feel free to squash it into yours if you want | 16:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Drop pre-cinder 3.44 version compatibility https://review.opendev.org/621061 | 16:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'MultiattachNotSupportedByVirtDriver' https://review.opendev.org/651315 | 16:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Follow-up for I6a777b4b7a5729488f939df8c40e49bd40aec3dd https://review.opendev.org/664967 | 16:01 |
| *** markvoelker has joined #openstack-nova | 16:02 | |
| *** gyee has joined #openstack-nova | 16:03 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'MultiattachSupportNotYetAvailable' exception https://review.opendev.org/651315 | 16:03 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109 | 16:07 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: func test for migrate server with ports having resource request https://review.opendev.org/655113 | 16:07 |
| *** pcaruana|afk| has joined #openstack-nova | 16:09 | |
| *** mdbooth_ has joined #openstack-nova | 16:10 | |
| *** mdbooth has quit IRC | 16:12 | |
| *** rafaelweingartne has quit IRC | 16:12 | |
| Nick_A | Do you guys have any tips for what we should look at to determine why cloud-init is working properly for us on lxd but not kvm? | 16:14 |
| *** mdbooth_ has quit IRC | 16:17 | |
| sean-k-mooney | if its working on lxd then the nova metadata service is working properly | 16:18 |
| sean-k-mooney | it might be a diffrence in how netwroking works | 16:19 |
| sean-k-mooney | you really need to try and trace the request | 16:20 |
| sean-k-mooney | so if you can log into one of your kvm instnce try an curl the metadata api via the 169... adress | 16:21 |
| sean-k-mooney | if you dont have a vm image with a password set for debuging then you can enable config drive to initally be able to log in to the vm and debug the issue | 16:22 |
| Nick_A | thank you | 16:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/457886 | 16:34 |
| *** markvoelker has quit IRC | 16:36 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | 16:37 |
| mriedem | stephenfin: this shouldn't be stable-only i don't think but you might want to verify if the bug is legit https://review.opendev.org/#/c/664838/1 | 16:42 |
| *** dtantsur is now known as dtantsur|afk | 16:45 | |
| aspiers | efried: Slightly out of my depth here. So shall I go ahead and change spawn() to persist allocations as a new field in the Instance object? | 16:48 |
| *** derekh has quit IRC | 16:50 | |
| *** cdent has quit IRC | 16:50 | |
| efried | aspiers: I wasn't following whatever conversation led up to this | 16:50 |
| efried | Is something we're doing with SEV requiring us to be able to look at the allocation some time after spawn? | 16:51 |
| efried | or is this related to some other topic? | 16:51 |
| aspiers | Yes | 16:51 |
| efried | Do tell | 16:51 |
| aspiers | http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-06-12.log.html#t2019-06-12T12:50:55 | 16:51 |
| aspiers | There are multiple places scattered through the code for building the guest config XML which need to know whether SEV is required | 16:52 |
| aspiers | but to perform the check in the way you requested, allocations need to be accessible at those points | 16:52 |
| efried | say wha now? | 16:53 |
| efried | you're telling me that every time libvirt attaches a volume, it rebuilds the whole XML from scratch? | 16:53 |
| aspiers | no | 16:53 |
| aspiers | it needs to know whether to use iommu | 16:53 |
| efried | you're telling me that attaching a volume needs to be SEV aware? | 16:53 |
| aspiers | not necessarily even attaching a volume | 16:53 |
| efried | okay, I see. | 16:54 |
| aspiers | just block devices and stuff at launch-time | 16:54 |
| aspiers | and also to decide whether to include <locked /> | 16:54 |
| aspiers | the latest 3 commits at the top of the series | 16:54 |
| efried | I think long term, having allocations on the instance object is a great idea. mriedem, dansmith, how do y'all feel about that? | 16:55 |
| efried | However, in this scenario, you could also solve by commonizing (libvirt/utils?) the code that inspects the flavor/image meta. | 16:55 |
| dansmith | efried: why? | 16:55 |
| aspiers | Yes, that possibility occurred to me too | 16:55 |
| *** tetsuro has quit IRC | 16:55 | |
| *** luksky has joined #openstack-nova | 16:55 | |
| *** rpittau is now known as rpittau|afk | 16:56 | |
| efried | dansmith: example here is SEV. We were considering doing the flavor/image parsing and validation just once, in the request filter, to add resources=MEM_ENCRYPTION_CONTEXT. Then after that, e.g. in spawn(), just looking at the allocation for MEM_ENCRYPTION_CONTEXT so we don't have to redo that parsing/validation. | 16:56 |
| aspiers | here's sean-k-mooney's take: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-06-12.log.html#t2019-06-12T13:13:16 | 16:57 |
| efried | In spawn specifically, we are getting the allocation as a param, so that's fine. But there are (aspiers tells me) other places where we need the same information but don't (currently) have access to the allocations. | 16:57 |
| dansmith | spawn having access to the allocations makes sense, but storing them on/with the instance doesn't really | 16:57 |
| aspiers | here's an example: https://review.opendev.org/#/c/662558/5/nova/virt/libvirt/driver.py | 16:57 |
| dansmith | I imagine bauzas would want access to allocations for gpu stuff as well, and I'm sure we discussed making that a param to spawn in the past | 16:58 |
| aspiers | currently this is broken because it's insufficient to pass only the flavor to _sev_required() | 16:58 |
| efried | allocations are already passed to spawn | 16:58 |
| dansmith | ack, okay I was sure we had discussed | 16:58 |
| aspiers | right, the problem is that they are not passed much further on | 16:58 |
| aspiers | sean-k-mooney's other suggestion was to pass from spawn() to _get_guest_xml() and so on | 16:58 |
| dansmith | yeah, pass them further if you want, but storing them .. no so much | 16:59 |
| aspiers | but that doesn't solve things like attaching volumes to an SEV instance | 16:59 |
| efried | you could cache a map of instance:allocations on the virt driver | 16:59 |
| dansmith | efried: dude | 16:59 |
| efried | but if you restart the compute driver you'd have to rebuild that by querying placement | 16:59 |
| dansmith | aspiers: so look them up and pass them in if you need | 16:59 |
| efried | we've said we don't like virt drivers talking to placement | 17:00 |
| dansmith | yeah | 17:00 |
| efried | though I guess `read` may be acceptable | 17:00 |
| dansmith | and caching placement data is also smelly, IMHO | 17:00 |
| dansmith | efried: no, make compute manager look them up and pass them in | 17:00 |
| efried | dansmith: You mean augment every ComputeDriver method to accept allocations? | 17:01 |
| dansmith | surely we don't need them on every call | 17:01 |
| efried | creeping death of a thousand cuts | 17:01 |
| efried | we already store other (pre-placement) allocation-like things on the Instance, don't we? PCI devices and such? | 17:02 |
| dansmith | but we own those things | 17:02 |
| dansmith | we cache the neutron port information and it's a disaster | 17:02 |
| efried | why? | 17:03 |
| efried | because that information can get changed via neutron? | 17:03 |
| efried | and then we have to figure out how to sync it? | 17:03 |
| efried | In this case nova does "own" the information. | 17:03 |
| efried | the allocation should not change unless nova changes it | 17:03 |
| efried | whereupon we're editing the Instance obj anyway. | 17:03 |
| aspiers | so how would something like DriverVolumeBlockDevice.attach() get hold of allocations? | 17:03 |
| dansmith | okay, whatever, you asked my my opinion.. I hate it. My opinion doesn't matter anyway, only mriedem's, so just do whatever he says | 17:04 |
| aspiers | if not via the Instance? | 17:04 |
| aspiers | (Yes, that is an honest stupid question) | 17:04 |
| efried | aspiers: If I'm understanding dansmith correctly, he's suggesting adding an allocations param to attach_volume and then passing it down through the call stack to DVBD.attach() | 17:04 |
| efried | doing that ^ as needed every time we encounter a ComputeDriver operation who(se guts) require access to the allocation | 17:05 |
| aspiers | efried: so through attach_volume() in the manager? | 17:05 |
| efried | yup. The compute manager would call placement to get the allocations for the instance before invoking the method. | 17:05 |
| aspiers | it seems pretty much every instance lifecycle method is already passing context and instance through | 17:05 |
| efried | yes | 17:06 |
| aspiers | looks like adding allocations would bloat the already long parameter lists of many methods | 17:07 |
| *** davidsha has quit IRC | 17:07 | |
| aspiers | long parameter lists seem like a code smell to me in general, but I don't really enough about nova to judge here | 17:08 |
| aspiers | I'll do whatever you gurus think is best :) | 17:08 |
| efried | let's see what mriedem thinks | 17:08 |
| aspiers | OK | 17:09 |
| dansmith | we have virtapi for compute drivers to ask compute manger for help. compute manager already has an in-memory cache of a bunch of this information, so letting the driver ask manager for allocation info for an instance when it needs it, which can be a readthrough cache operation would also be reasonable | 17:09 |
| efried | ah, that could work. What's that virtapi called? | 17:10 |
| dansmith | storing this on the instance is pointless to me because I think we always need to get it from placement to be sure it's right I think, and the instance record is already a massive thing we shoot across the stressed RPC bus with a ton of extra crap we don't need 90% of the time | 17:10 |
| efried | ComputeDriver.virtapi... | 17:11 |
| dansmith | but, as I said, it matters only what mriedem thinks, so ... no point in even discussing until he opines | 17:11 |
| aspiers | RPC bloat sounds like a very valid concern | 17:11 |
| *** mdbooth_ has joined #openstack-nova | 17:12 | |
| sean-k-mooney | RPC bloat being the reason not to put it in the instance? | 17:16 |
| aspiers | that's how I interpreted what dansmith said | 17:16 |
| efried | This virtapi thing is pretty small right now, basically just has wait_for_instance_event | 17:16 |
| aspiers | yeah | 17:16 |
| aspiers | also, I don't see allocations cached in the manager | 17:16 |
| sean-k-mooney | dansmith: the allcoation should not change over the lifetime of the instance without a server action to modify it | 17:17 |
| dansmith | efried: it used to have a bunch of services the driver used, but has whittled down | 17:17 |
| sean-k-mooney | e.g. it will only cahnge on move operattion/resize/rebulds/or attaches/detaches | 17:17 |
| dansmith | sean-k-mooney: in some future where I can allocate non-compute resources for the instance, the instance's allocation can change not from nova right? | 17:17 |
| efried | but if dansmith likes the idea of extending it with allocations_for_instance, which we can cache in the manager, I'm down with that idea. | 17:18 |
| dansmith | aspiers: no, we cache inventory AFAIK, but not allocations at the moment | 17:18 |
| sean-k-mooney | dansmith: im notsure about that | 17:18 |
| sean-k-mooney | are you thinking baout things like changing the bandwith allcoation via neutron | 17:18 |
| sean-k-mooney | e.g. by changing the qos policy | 17:18 |
| efried | aspiers: The inventory (basically all the provider tree information for all the hosts managed by this compute) is cached in the SchedulerReportClient today. But yeah, not the allocations. | 17:19 |
| sean-k-mooney | i guess that could happen in the future | 17:19 |
| *** spsurya has quit IRC | 17:19 | |
| dansmith | sean-k-mooney: I'm thinking of allocating things like a new volume, or even ephemeral things like networked secure enclave keys or something | 17:19 |
| sean-k-mooney | dansmith: well a new volume would be a volume attach right | 17:20 |
| efried | as long as those ^ things happen in nova, we're good, but yeah, if they happen outside of nova, weirdness. | 17:20 |
| dansmith | sean-k-mooney: it also means our rpc messages and database footprint scales with whatever else we add into the allocation in the future | 17:20 |
| efried | I think we have other problems to solve ("heal allocations"??) if we start allowing outside entities to modify instance allocations | 17:20 |
| dansmith | sean-k-mooney: not always in the case of manilla or similar higher level services | 17:20 |
| sean-k-mooney | that is true altheough we have a 64k userdata blob in there already | 17:21 |
| efried | I'm happy with the virtapi solution personally. | 17:21 |
| efried | I don't even think we need to bother caching it, at least initially. | 17:21 |
| sean-k-mooney | for mania the filesystem is not own by the instnace | 17:21 |
| efried | Since it's on demand and should be a pretty rare ask. | 17:21 |
| sean-k-mooney | the instace can have acess too it but its not tied to the lifetime of the instnace | 17:21 |
| *** mdbooth_ has quit IRC | 17:22 | |
| sean-k-mooney | efried: i do kindof dislike the idea that if placement goes offline you cant reboot an instnace | 17:22 |
| dansmith | sean-k-mooney: okay, you understand I'm talking about high-level services that sit on top of infra that would have per-instance allocations right? | 17:22 |
| sean-k-mooney | dansmith: yes | 17:22 |
| sean-k-mooney | and i get that it could be extendted that way in the future | 17:23 |
| sean-k-mooney | without storing the allcoation somewhere in nova then placment becmoes a singel point of failture for starting or stroping vms if they use sev or vgpus | 17:24 |
| dansmith | I definitely don't like that we'd depend on placement to reboot an instance or do other things, but I'd rather us not depend on the placement *data* in that case, | 17:25 |
| dansmith | and not just solve it by replicating everything everywhere | 17:25 |
| efried | yeah, when I found out we rebuild the domxml every time we reboot I was like whaaa? | 17:26 |
| sean-k-mooney | well that makes sense in some ways | 17:26 |
| efried | it must | 17:26 |
| efried | in some ways | 17:26 |
| sean-k-mooney | that is not really the root cause of the dependcy in the vgpu case | 17:26 |
| dansmith | is this all coming up because we've already translated a request into a "will have SEV" and the only way we can think to know that later is persist the whole allocation? | 17:26 |
| efried | dansmith: more or less | 17:26 |
| sean-k-mooney | no | 17:26 |
| efried | heh | 17:26 |
| efried | anti-jinx | 17:26 |
| sean-k-mooney | we can look at the request spec | 17:26 |
| dansmith | efried: well, that's a bad reason to do that, IMHO | 17:27 |
| *** eharney has quit IRC | 17:27 | |
| efried | dansmith: It's not "the only way we can think to know that later" | 17:27 |
| sean-k-mooney | and use the request for sev | 17:27 |
| efried | we could reinvoke the logic we used to decide the first time | 17:27 |
| dansmith | efried: point being, let's store what we need about that decision and not just couple the guts of the virt driver into the placement data | 17:27 |
| efried | by looking at the flavor & image - which we have access to via the Instance obj, right? | 17:27 |
| sean-k-mooney | ya we can compute it form the info in the request spec which these fucntion already have acess too | 17:27 |
| dansmith | because the other thing is, allocations are somewhat tied to a microversion in placement, and while it seems hard to imagine the core structure changing, we've changed a lot of the external data structures of placement since we started | 17:28 |
| sean-k-mooney | so once the comment is address i personally would have check the requestd_resouces object in the request spec https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L93-L100 | 17:29 |
| *** eharney has joined #openstack-nova | 17:29 | |
| sean-k-mooney | but we also have acess to the image and flavor via the instance yes | 17:30 |
| dansmith | efried: re: [10:27:05] <efried>dansmith: It's not "the only way we can think to know that later" | 17:31 |
| dansmith | efried: I know not the only way, but "the way", collapsed to "only" for dramatic effect | 17:31 |
| *** markvoelker has joined #openstack-nova | 17:33 | |
| sean-k-mooney | so the instance is already passed to all the places we need to check if the instace requested sev | 17:36 |
| sean-k-mooney | so why dont we jsut hav ea single function that takes the instance object and determins if sev is needed and reuse that everywhere we care. | 17:37 |
| sean-k-mooney | that could live in nova.virt.hardware.yp with the numa stuff? | 17:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 17:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Include direct-physical in compute manager events check https://review.opendev.org/664431 | 17:38 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/664442 | 17:38 |
| sean-k-mooney | like is_realtime_enabled https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1436-L1438 | 17:40 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: ComputeVirtAPI.allocations_for_instance https://review.opendev.org/664986 | 17:40 |
| efried | aspiers: for grins, you can try this out ^ | 17:40 |
| efried | dansmith: this what you had in mind? | 17:40 |
| dansmith | efried: mostly | 17:41 |
| efried | I explained why no caching in the commit message | 17:41 |
| sean-k-mooney | efried: but is there any reason to have to check the allotion the athoritive info is stored in the image/flavor not the allcoation | 17:41 |
| efried | sean-k-mooney: just to not have to duplicate that logic. | 17:42 |
| efried | but in this case, no, not really. | 17:42 |
| sean-k-mooney | an api call is a lot more expensive | 17:42 |
| dansmith | is a single call to that less expensive than calling the placement? | 17:42 |
| efried | Accessing the flavor/image meta from Instance is cheap | 17:42 |
| efried | dansmith: assuming we already have the flavor & image available in the Instance object, it's all local, yeah. | 17:42 |
| efried | well | 17:43 |
| efried | some of it involves pawing at sysfs | 17:43 |
| sean-k-mooney | we do | 17:43 |
| dansmith | it better not, | 17:43 |
| dansmith | because the api nodes' sysfs wouldn't be the same as compute | 17:43 |
| sean-k-mooney | we dont need to look at sysfs for schduling | 17:43 |
| efried | right, the compute pawed at sysfs to expose the inventory, so by virtue of having the MEM_ENC_CTX inventory at all, we know we did the sysfs stuff already. | 17:44 |
| *** ricolin_ has quit IRC | 17:44 | |
| sean-k-mooney | we may or may not for xml generation | 17:44 |
| dansmith | efried: ack, I see | 17:44 |
| efried | but how would I know that on the compute without looking at placement? :P | 17:44 |
| sean-k-mooney | efried: know what? | 17:44 |
| efried | know that I can SEV | 17:45 |
| sean-k-mooney | because its asked for in teh flavor/image | 17:45 |
| efried | no | 17:45 |
| sean-k-mooney | if we got to the compute node we know we were allocated everything we asked for | 17:45 |
| efried | well, yes, okay | 17:45 |
| *** ociuhandu has quit IRC | 17:45 | |
| efried | that's kind of a lot of assuming. | 17:45 |
| efried | including assuming nothing changed on the host that makes it no longer work | 17:46 |
| efried | but that's reasonable. | 17:46 |
| sean-k-mooney | assuming that if placment could not fulfil a request it returned no allcoation candates? | 17:46 |
| sean-k-mooney | that kind of fundemental no? | 17:46 |
| *** Sundar has quit IRC | 17:46 | |
| dansmith | definitely don't think that being sent an instance with sev required is good enough to assume we have it | 17:46 |
| dansmith | because we don't know what the scheduler policy is | 17:46 |
| dansmith | or if that node is old | 17:46 |
| efried | or got force migrated? | 17:46 |
| *** tssurya has quit IRC | 17:46 | |
| dansmith | or if the request has been sitting in a rabbit queue across config changes | 17:46 |
| sean-k-mooney | well the virt direver is going to check compatiblity | 17:47 |
| sean-k-mooney | right | 17:47 |
| efried | so then yeah, in order to truly fulfill "can and should do SEV" I would need to check the flavor/image *and* sysfs, every time. | 17:47 |
| efried | which is still going to be cheaper than calling placement across the wire | 17:47 |
| sean-k-mooney | well libvirt capablitys api | 17:47 |
| sean-k-mooney | rather then sysfs but same effect | 17:48 |
| efried | yeah, using "sysfs" to encompass "introspecting the host in whatever way is necessary" | 17:48 |
| efried | which should be all "local" one way or another. | 17:48 |
| efried | "local" to the system; not necessarily local to whatever's in process memory already, which would be even better. | 17:49 |
| sean-k-mooney | so back to https://review.opendev.org/#/c/664420/4/nova/scheduler/request_filter.py | 17:51 |
| sean-k-mooney | if we just move thos three funtion into nova/virt/hardware.py wiht all the cpu pinning and numa stuff and just call | 17:52 |
| dansmith | artom: I think maybe too much got removed, but see my comments and hopefully prove me wrong | 17:52 |
| artom | dansmith, looking | 17:53 |
| sean-k-mooney | required_encryped_memory support in both the dirver and filter that shoudl be fine right | 17:53 |
| efried | sean-k-mooney: that and the sysfs pawing part, yes. Not sure if hardware.py is the right place | 17:53 |
| sean-k-mooney | i think this is similarly to hugepages,realtime,cpupinning and numa | 17:54 |
| sean-k-mooney | all of which are in the hardware.py module | 17:54 |
| efried | does hardware.py also do the flavor interpretation bits associated with that? | 17:54 |
| *** owalsh has quit IRC | 17:54 | |
| sean-k-mooney | efried: yes | 17:54 |
| efried | I kind of object to hardware.py not being nova/virt/libvirt/hardware.py | 17:55 |
| *** owalsh has joined #openstack-nova | 17:55 | |
| efried | but that soapbox is gathering dust in my closet at this point. | 17:55 |
| sean-k-mooney | its used in other driver too | 17:55 |
| sean-k-mooney | its used in the hyperv driver | 17:55 |
| sean-k-mooney | and its used in the api | 17:55 |
| sean-k-mooney | and the scheduler | 17:55 |
| * efried drops it like a bad habit | 17:55 | |
| aspiers | I can never drop bad habits :-( | 17:55 |
| sean-k-mooney | the trick is to replace them with other sligly less bad habits | 17:56 |
| aspiers | true | 17:56 |
| sean-k-mooney | anyway it could go somewhere else | 17:57 |
| artom | Agile self-improvement ;) | 17:57 |
| efried | aspiers: not sure if you've been following along, but I think the consensus is to centralize the methods that do a) flavor/image parsing/validation, and b) host capability introspection; and call those from all the places (update_provider_tree calls b to expose inventory; request filter calls a to add to the request; virt driver lifecycle ops call a & b to decide whether SEV-y things should be done or not) | 17:58 |
| aspiers | OK | 17:59 |
| efried | but if you want to just play around, I made this for you: https://review.opendev.org/664986 | 17:59 |
| efried | ...for lifecycle ops to use to look for MEM_ENC_CTX in the alloc to bypass at least a). | 18:00 |
| * aspiers reads and thinks | 18:00 | |
| mriedem | umm, i just got back | 18:02 |
| mriedem | not going to read all of the scrollback | 18:02 |
| mriedem | without knowing more, i'd say i don't want to replicate allocation data per instance in nova | 18:03 |
| mriedem | source of truth is the external service and all that | 18:03 |
| sean-k-mooney | mriedem: the context was how to determin if sev is need. efried summerised where we landed a few lines up | 18:05 |
| *** markvoelker has quit IRC | 18:06 | |
| mriedem | isn't sev a required trait on the flavor? | 18:07 |
| sean-k-mooney | its a resouce class in the flavor | 18:07 |
| mriedem | if so, that is already information stored on the instance | 18:07 |
| mriedem | ok either way | 18:07 |
| efried | "stored on the instance" you mean via the flavor (and/or image in this case)? | 18:07 |
| sean-k-mooney | yes efried didnt want to duplicate the logic between the filter an the virt driver | 18:07 |
| mriedem | not the image | 18:07 |
| mriedem | if it's a resource class it's not on the image | 18:07 |
| mriedem | but yes if it's on the flavor it's embedded on the instance | 18:08 |
| efried | The flavor doesn't use a resource class directly | 18:08 |
| mriedem | instance.flavor.extra_spec | 18:08 |
| mriedem | it's an extra spec | 18:08 |
| mriedem | right? | 18:08 |
| efried | In this case we decide whether to SEV based on flavor extra spec *or* image meta prop | 18:08 |
| mriedem | resources:SEV=1 | 18:08 |
| mriedem | what image meta prop? | 18:08 |
| mriedem | i thought the image only had traits? | 18:08 |
| efried | no, no explicit placement-ese in flavor or image | 18:08 |
| efried | hw:memory_encryption=true <= flavor | 18:08 |
| efried | hw_memory_encryption=true <= img | 18:08 |
| mriedem | i have been deliberately ignoring / avoiding the sev talk going on in here for the last several months so idk wtf we are now | 18:08 |
| efried | (I may have spelled it wrong, but that's the idea) | 18:09 |
| efried | request filter interprets those into placement-ese | 18:09 |
| mriedem | as a trait? or a resource class? | 18:09 |
| mriedem | or both? | 18:09 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Raise if flavor and image disagree on hide_hypervisor_id https://review.opendev.org/663365 | 18:09 |
| efried | a resource class | 18:09 |
| mriedem | with what amount? 1 | 18:09 |
| efried | required=MEM_ENCRYPTION_CONTEXT:1 | 18:09 |
| mriedem | ? | 18:09 |
| sean-k-mooney | yes | 18:09 |
| efried | we got here because there's a limited number of SEVs you can do on a host | 18:10 |
| efried | and | 18:10 |
| mriedem | gimme all the sevs | 18:10 |
| * aspiers has caught up with the scrollback... sort of | 18:10 | |
| efried | we want the solution to be generic for memory encryption technologies, so e.g. MKTME can play in this space. | 18:10 |
| mriedem | is mktme that band from the 90s? | 18:10 |
| mriedem | with the cool album covers? | 18:10 |
| efried | yes | 18:10 |
| aspiers | :) | 18:10 |
| aspiers | whereas SEV is just terrible Euro-pop | 18:11 |
| mriedem | let me guess, mktme is intel something | 18:11 |
| aspiers | yes, Intel multi-key total memory encryption | 18:11 |
| edleafe | which sed | 18:12 |
| edleafe | doh! | 18:12 |
| sean-k-mooney | hehe this is one of the intel acronym that i dont auto expand when i see it | 18:12 |
| efried | or Right SEV Fred, who's too sexy for his RAM | 18:13 |
| aspiers | OK so are we still here? -> <efried> aspiers: not sure if you've been following along, but I think the consensus is to centralize the methods that do a) flavor/image parsing/validation, and b) host capability introspection; and call those from all the places (update_provider_tree calls b to expose inventory; request filter calls a to add to the request; virt driver lifecycle ops call a & b to decide | 18:14 |
| aspiers | whether SEV-y things should be done or not) | 18:14 |
| efried | unless mriedem has a different opinion on the other options discussed. | 18:15 |
| efried | he already -1'd allocations-on-Instance | 18:15 |
| efried | but has not weighed in on virtapi.allocations_for_instance | 18:15 |
| efried | but jumped right to "go look at the flavor" | 18:15 |
| efried | so that seems like the path | 18:16 |
| aspiers | What about https://review.opendev.org/#/c/664420/4/nova/scheduler/request_filter.py@223 | 18:16 |
| sean-k-mooney | i would emulate this https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L259 | 18:16 |
| aspiers | alex_xu seems to have a reasonable point there | 18:16 |
| sean-k-mooney | or maybe this is a little less scary https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L171 | 18:16 |
| efried | aspiers, alex_xu: How is this different from what's happening in require_tenant_aggregate ? | 18:17 |
| aspiers | sean-k-mooney: BTW you know that we have gitea running on opendev now :) | 18:17 |
| sean-k-mooney | aspiers: i do and the last time i used it it nova almost crashed it | 18:17 |
| efried | aspiers: Commenting on the review | 18:17 |
| aspiers | sean-k-mooney: interesting, gitea seems a lot more lightweight on my browser than github | 18:17 |
| aspiers | efried: thanks | 18:18 |
| sean-k-mooney | that was because they messed up a tempelate which is now fixed but still | 18:18 |
| *** BjoernT has quit IRC | 18:18 | |
| aspiers | efried: right, I copied the raise RequestFilterFailed() from that | 18:18 |
| sean-k-mooney | anyway im feeling really tired today so im going to go lie down. o/ talk to people tomorow | 18:19 |
| aspiers | sean-k-mooney: so what exception should I throw if the SEV extra spec and image property conflict with each other? | 18:19 |
| sean-k-mooney | am | 18:19 |
| sean-k-mooney | it depend on where you are thowing it | 18:20 |
| aspiers | well, you are suggesting to put it in hardware.py? | 18:20 |
| sean-k-mooney | alex asked you to add some validation in the api as well | 18:20 |
| aspiers | IIUC | 18:20 |
| *** udesale has quit IRC | 18:20 | |
| aspiers | it needs to be in a shared library, right? | 18:20 |
| *** boxiang_ has quit IRC | 18:20 | |
| *** boxiang_ has joined #openstack-nova | 18:20 | |
| sean-k-mooney | ya so nova.virt.hardware.py is called everywhere | 18:20 |
| aspiers | so that it can be called from the request_filter, from the driver, and maybe also from the api | 18:20 |
| sean-k-mooney | its in the virt dirver schduler and api already | 18:21 |
| aspiers | I'm talking about the exception currently at https://review.opendev.org/#/c/664420/4/nova/scheduler/request_filter.py@223 | 18:21 |
| aspiers | if I move it to a shared library, the exception needs to be more generic | 18:21 |
| aspiers | InvalidRequest? | 18:22 |
| sean-k-mooney | we have generally beein add new excpetion as needed for each check | 18:22 |
| aspiers | OK | 18:22 |
| sean-k-mooney | like this | 18:22 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1192-L1198 | 18:22 |
| aspiers | that sounds fine to me | 18:23 |
| aspiers | I can add one to exceptions.py | 18:23 |
| aspiers | I mean exception.py | 18:23 |
| aspiers | efried: does that work for you? | 18:23 |
| openstackgerrit | Eric Fried proposed openstack/nova master: update constraints url https://review.opendev.org/664771 | 18:23 |
| dansmith | efried: fwiw, my unmattering vote would be for just checking image+flavor for the sev thing and not doing the virtapi bit until we come up with a good reason | 18:24 |
| dansmith | this being, not a good enough reason | 18:24 |
| dansmith | in the future, when said reason exists, that's how we do it, IMHO | 18:24 |
| efried | dansmith: ack, that's where we're going | 18:24 |
| efried | thanks for the input sir | 18:25 |
| dansmith | cool | 18:25 |
| aspiers | wfm | 18:25 |
| efried | aspiers: Yes, the centralized method in hardware.py should raise some kind of generic conflict exception, which should be caught and converted to RequestFilterFailed (or whatever it's called today) in the request filter. | 18:25 |
| *** boxiang_ has quit IRC | 18:25 | |
| aspiers | efried: sean-k-mooney suggested making a new exception. ACK about the conversion to RFF | 18:26 |
| *** boxiang_ has joined #openstack-nova | 18:26 | |
| efried | (by "generic" I mean not request filter specific; it should still have the lovely and hard-fought message you've already composed) | 18:26 |
| aspiers | oh right, gotcha | 18:26 |
| sean-k-mooney | aspiers: right just copy this one and change the wording https://github.com/openstack/nova/blob/master/nova/exception.py#L2054 | 18:26 |
| efried | aspiers: you could use this: https://review.opendev.org/#/c/663365/2/nova/exception.py | 18:26 |
| sean-k-mooney | efried: oh ya you were adding a reusable one | 18:27 |
| sean-k-mooney | efried: that works too | 18:27 |
| aspiers | oh perfect | 18:27 |
| aspiers | Well, I might inherit from that one :) | 18:27 |
| aspiers | since my message is more informative | 18:27 |
| aspiers | class SEVFlavorImageConflict(FlavorImageConflict) | 18:28 |
| efried | you should introduce the exception (class name) in your own patch, cause there's no telling if/when ^ will merge | 18:28 |
| efried | and whoever comes second can resolve conflict. | 18:28 |
| sean-k-mooney | aspiers: non of the other conflcit ones inherit for efried new excetion at teh moment | 18:28 |
| efried | but yeah, make the exception name generic, and you can override the message in your method. | 18:28 |
| sean-k-mooney | they inherit for Invalid or Forbidden | 18:29 |
| aspiers | and NotFound | 18:29 |
| efried | Those have HTTP semantic baggage, swhy I avoided them. | 18:29 |
| sean-k-mooney | Forbidden when its disallows by policy and Invalid when the did not specify it correctly | 18:29 |
| sean-k-mooney | e.g mem_encyption_context=yes instead or true | 18:30 |
| aspiers | efried: why introduce the same new exception in two patches? can't we just land yours sooner? | 18:30 |
| aspiers | is it because you can +2 my patches but not your own? ;-) | 18:30 |
| efried | Your API invocation of new centralized message should convert generic exception to something that inherits from Invalid | 18:30 |
| efried | aspiers: I can't +2 my patches, no, and also, there doesn't seem to be an overwhelming consensus that that patch of mine is a good thing to do at all. | 18:31 |
| aspiers | efried: even if it's needed for SEV? | 18:31 |
| efried | so I don't have high confidence that it will land soon/ever. | 18:31 |
| efried | it's not | 18:31 |
| efried | only the exception is | 18:31 |
| aspiers | I'm confused | 18:31 |
| efried | so it should be extracted. | 18:31 |
| aspiers | ohhhhh | 18:31 |
| sean-k-mooney | efried: i think i found a bug in our vgpu code today that might use your patch | 18:31 |
| aspiers | I missed that that patch does other stuff | 18:31 |
| aspiers | OK | 18:31 |
| sean-k-mooney | e.g. without looking too close i think we dont handel stop followed by start proerly | 18:32 |
| efried | yeah, the patch I pointed to has nothing to do with SEV. It has to do with "hide hypervisor ID to make NVIDIA drivers work | 18:32 |
| efried | " | 18:32 |
| aspiers | yeah, got it now | 18:32 |
| aspiers | yikes, feels like I need another 40k spec just to remember all the plans we made in the last hour | 18:32 |
| efried | You don't need to update the spec with any of this. | 18:32 |
| aspiers | thank god for IRC logs | 18:32 |
| aspiers | I know, was just being silly :) | 18:33 |
| aspiers | it's a lot of detail for a newbie to remember, but I think I'll be ok | 18:33 |
| sean-k-mooney | anyway this time im really going to go and rest. o/ | 18:33 |
| aspiers | I guess my right to play the newbie card is gradually fading though | 18:33 |
| aspiers | cya sean-k-mooney, thanks for your help o/ | 18:33 |
| efried | - create two consolidated methods in hardware.py: a) parse/validate flavor/image for SEV yes-or-no; b) introspect host for SEV capability | 18:33 |
| efried | - ^ methods raise exceptions | 18:33 |
| efried | - existing usages of ^ logic cut over to using ^, converting exceptions to contextually-appropriate ones. | 18:33 |
| aspiers | I think b) and callers of b) do not need to change | 18:34 |
| aspiers | it's only a) | 18:34 |
| *** maciejjozefczyk has joined #openstack-nova | 18:34 | |
| efried | ight | 18:34 |
| aspiers | b) is all in the driver | 18:34 |
| aspiers | and available via the supports_amd_sev instance variable | 18:35 |
| efried | "instance" == compute driver instance, not "instance" == "nova server" | 18:35 |
| aspiers | sure :) | 18:35 |
| aspiers | and then there's Instance instances too :) | 18:36 |
| aspiers | OK, gonna take a break or probably stop for today | 18:36 |
| aspiers | thanks a lot all | 18:36 |
| efried | dustinc: Not rechecking the ironicclient part of the sdk series for yesterday's doubled_words snafu - pep8 needs resolving on the lowermost one. | 18:37 |
| dustinc | efried: saw that, once I am done with the spec update I am working on I will take care of it - thanks | 18:39 |
| efried | dustinc: no hurry, just letting you know why it's not going to be included in my "recheck everything" sweep :P | 18:40 |
| efried | dustinc: also lmk if at some point you want to talk through providers.yaml | 18:40 |
| dustinc | efried: providers.yaml: will do..I def. want to at some point | 18:42 |
| *** igordc has quit IRC | 18:43 | |
| *** BjoernT has joined #openstack-nova | 18:45 | |
| *** BjoernT_ has joined #openstack-nova | 18:50 | |
| *** BjoernT has quit IRC | 18:53 | |
| *** tesseract has quit IRC | 18:54 | |
| *** eharney has quit IRC | 18:57 | |
| *** markvoelker has joined #openstack-nova | 19:03 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Make RequestContext(instance_lock_checked) fail https://review.opendev.org/665003 | 19:10 |
| efried | mriedem: resolves a TODO of yours ^ | 19:10 |
| openstackgerrit | Merged openstack/nova master: Remove unnecessary setUp methods https://review.opendev.org/663179 | 19:11 |
| mriedem | efried: does it or does it not have to do with SEV | 19:12 |
| efried | does not | 19:13 |
| efried | I was looking into removing a hack for glance using get_endpoint_data through _ContextAuthPlugin (fail) and just happened to notice this. | 19:14 |
| efried | mriedem: what was that bug you opened for the doubled_words hacking test yesterday? Did you mark it as a dup of https://bugs.launchpad.net/nova/+bug/1804062 already? | 19:14 |
| openstack | Launchpad bug 1804062 in OpenStack Compute (nova) "test_hacking fails for python 3.6.7 and newer" [High,In progress] - Assigned to Stephen Finucane (stephenfinucane) | 19:14 |
| *** maciejjozefczyk has quit IRC | 19:14 | |
| mriedem | yes | 19:15 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1832392 | 19:15 |
| openstack | Launchpad bug 1804062 in OpenStack Compute (nova) "duplicate for #1832392 test_hacking fails for python 3.6.7 and newer" [High,In progress] - Assigned to Stephen Finucane (stephenfinucane) | 19:15 |
| mriedem | efried: question in your patch | 19:15 |
| melwitt | efried: after the discussion about nested magic 1 in office hours today, how are you feeling about the it vs the nova spec for numa affinity for vgpus? | 19:16 |
| *** factor has quit IRC | 19:16 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Make RequestContext(instance_lock_checked) fail https://review.opendev.org/665003 | 19:17 |
| efried | mriedem: done | 19:17 |
| melwitt | I wasn't sure if I understood whether nested magic 1 will take much more effort than previously believed | 19:18 |
| efried | melwitt: Components of it - specifically the ones that allow us to do NUMA modeling/affinity for simple cases like VGPU - are not under conflict. I still think the VGPU numa affinity thing doesn't move us forward in a useful way, and just introduces tech debt we'll have to remove very soon. | 19:19 |
| efried | but I don't feel strongly enough to downvote. | 19:19 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/644881 | 19:20 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Include direct-physical in compute manager events check https://review.opendev.org/664431 | 19:20 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/664442 | 19:20 |
| * efried bbiab | 19:20 | |
| melwitt | efried: ack. and do you know if there are people available to work on nested magic 1 or does it need an owner? | 19:21 |
| melwitt | for the implementation after the spec merges | 19:21 |
| dansmith | artom: ooh, did somebody find a bug while writing their tests? :) | 19:23 |
| artom | dansmith, I don't think so? | 19:23 |
| artom | But parts of the code were untested, yeah | 19:23 |
| dansmith | artom: okay, just looking at your events=None change in the latest patch | 19:23 |
| artom | Oh, err, yeah | 19:24 |
| artom | That may have been a problem :/ | 19:24 |
| dansmith | sweet | 19:24 |
| dansmith | now I feel less bad | 19:24 |
| *** xek_ has joined #openstack-nova | 19:24 | |
| *** maciejjozefczyk has joined #openstack-nova | 19:25 | |
| artom | dansmith, so not only am I making Nova better, I'm also contributing to your mental health | 19:27 |
| artom | Come to think of it, maybe the latter isn't an advantage >;) | 19:27 |
| * dansmith queues that up for his next therapy session | 19:27 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 19:30 | |
| *** maciejjozefczyk has quit IRC | 19:31 | |
| *** maciejjozefczyk has joined #openstack-nova | 19:36 | |
| *** maciejjozefczyk_ has quit IRC | 19:37 | |
| *** markvoelker has quit IRC | 19:37 | |
| *** jenglisch has quit IRC | 19:39 | |
| *** eharney has joined #openstack-nova | 19:41 | |
| *** jenglisch has joined #openstack-nova | 19:43 | |
| *** slaweq has joined #openstack-nova | 19:48 | |
| *** ralonsoh has quit IRC | 19:50 | |
| *** hoonetorg has quit IRC | 19:51 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 19:54 | |
| *** whoami-rajat has quit IRC | 19:55 | |
| *** maciejjozefczyk has quit IRC | 19:57 | |
| *** maciejjozefczyk_ has quit IRC | 19:59 | |
| *** hoonetorg has joined #openstack-nova | 20:03 | |
| *** factor has joined #openstack-nova | 20:08 | |
| *** factor has quit IRC | 20:21 | |
| *** cdent has joined #openstack-nova | 20:32 | |
| *** slaweq has quit IRC | 20:33 | |
| *** xek_ has quit IRC | 20:34 | |
| *** markvoelker has joined #openstack-nova | 20:34 | |
| *** cdent has quit IRC | 20:37 | |
| *** slaweq has joined #openstack-nova | 20:38 | |
| mriedem | dansmith: for when you're on the can http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007097.html | 20:39 |
| *** slaweq has quit IRC | 20:43 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Introduce live_migration_claim() https://review.opendev.org/635669 | 20:49 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827 | 20:49 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.opendev.org/634828 | 20:49 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.opendev.org/635229 | 20:49 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.opendev.org/634605 | 20:49 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606 | 20:50 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: CONF.enable_numa_live_migration is not needed >= Stein https://review.opendev.org/640021 | 20:50 |
| efried | melwitt: cdent has been picking up most of it one way or another. More bodies would be nice, but probably not critical. | 20:50 |
| efried | melwitt: and we've not been sticking to "spec must merge first" rules. We've already cut a microversion with part of the feature set. | 20:51 |
| melwitt | oh, interesting. ok | 20:51 |
| efried | yeah, it's the wild wild west over here in placement-land | 20:52 |
| melwitt | heh | 20:55 |
| melwitt | well, if there's anything I can do to help, give me a holler | 20:55 |
| *** artom has quit IRC | 20:59 | |
| efried | melwitt: oo, now you're in for it :P | 21:02 |
| melwitt | :) | 21:03 |
| *** markvoelker has quit IRC | 21:08 | |
| *** ivve has quit IRC | 21:11 | |
| *** pcaruana|afk| has quit IRC | 21:16 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.opendev.org/614012 | 21:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036 | 21:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123 | 21:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892 | 21:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | 21:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853 | 21:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | 21:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | 21:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | 21:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605 | 21:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | 21:23 |
| *** mriedem has quit IRC | 21:24 | |
| *** luksky has quit IRC | 21:25 | |
| efried | dansmith: Thanks for the review on the providers.yaml spec. I agree with you (mark your calendar). | 21:38 |
| *** takashin has joined #openstack-nova | 21:46 | |
| *** markvoelker has joined #openstack-nova | 22:05 | |
| *** spatel has quit IRC | 22:10 | |
| *** mlavalle has quit IRC | 22:14 | |
| *** markvoelker has quit IRC | 22:38 | |
| *** elod has quit IRC | 22:41 | |
| *** rcernin has joined #openstack-nova | 22:41 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.opendev.org/576020 | 22:54 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.opendev.org/576027 | 22:54 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.opendev.org/576031 | 22:54 |
| *** tkajinam has joined #openstack-nova | 22:56 | |
| *** lifeless has quit IRC | 23:05 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Fix live-migration when glance image deleted https://review.opendev.org/662153 | 23:10 |
| openstackgerrit | Merged openstack/nova master: Refresh instance network info on deletion https://review.opendev.org/660761 | 23:21 |
| openstackgerrit | sean mooney proposed openstack/os-vif master: set ignore_basepython_conflict = True in tox.ini https://review.opendev.org/665034 | 23:22 |
| *** markvoelker has joined #openstack-nova | 23:35 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.opendev.org/576299 | 23:36 |
| openstackgerrit | sean mooney proposed openstack/nova master: update comment on ignore_basepython_conflict https://review.opendev.org/665036 | 23:37 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.opendev.org/576344 | 23:37 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.opendev.org/576673 | 23:37 |
| *** JamesBenson has quit IRC | 23:37 | |
| openstackgerrit | Merged openstack/nova master: Fix double word hacking test https://review.opendev.org/664940 | 23:42 |
| *** elod has joined #openstack-nova | 23:42 | |
| openstackgerrit | sean mooney proposed openstack/os-vif master: set ignore_basepython_conflict = True in tox.ini https://review.opendev.org/665034 | 23:43 |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.opendev.org/602432 | 23:53 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!