Friday, 2019-06-14

*** brinzhang has joined #openstack-nova00:05
*** dave-mccowan has quit IRC00:13
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Microversion 2.74: Support Specifying AZ to unshelve  https://review.opendev.org/66513600:13
*** izza_ has joined #openstack-nova00:13
izza_Hi,can anybody here help me pls...i'm testing rally heat(scenario: create_stack_scale) and i'm encountering below error: ***heat-engine***** 2019-06-13 18:27:19,809.809 1 ERROR heat.engine.service ResourceFailure: resources.asg: HEAT-E99001 Service nova is not available for resource type OS::Nova::Server, reason: Authentication cannot be scoped to multiple targets. Pick one of: project, domain, trust or unscoped00:21
izza_***Rally Logs*** TimeoutException: Rally tired waiting 3600.00 seconds for Stack <Stack {u'parent': None, u'disable_rollback': True, u'description': u'No description', u'parameters': {u'OS::project_id': u'53ae40faef3d47938019d7eded6dc4d2', u'OS::stack_id': u'ba39558d-63f7-43de-9a7f-aee7e325f623', u'OS::stack_name': u's_rally_c10f9daf_7eSBDfas', u'image': u'cirros-0.4.0-x86_64-disk', u'scaling_adjustment': u'1', u'flavor': u'm100:21
*** markvoelker has joined #openstack-nova00:22
izza_i badly needed ur help guys...i have deadline Today00:23
*** markvoelker has quit IRC00:27
*** gyee has quit IRC00:38
*** slaweq has joined #openstack-nova00:43
sean-k-mooneyizza_: i think you need to try the heat or rally channel. this looks liek an issue with the heat templat that rally is using00:45
sean-k-mooneyizza_: i dont think this is related to nova from that error00:45
*** slaweq has quit IRC00:48
igordchello sean-k-mooney00:50
sean-k-mooneyigordc: o/00:51
igordcsean-k-mooney, since you're here, can I ask if you had a look at https://review.opendev.org/#/c/576607/ after Stamatis last comment?00:51
igordccc stephenfin00:51
sean-k-mooneyi have not00:51
izza_ok noted..i already sent message to rally channel...yet no answer..just looking for a chance..if anyone knows how to resolv that issue..but thanks:)00:51
*** awalende has joined #openstack-nova01:01
*** dave-mccowan has joined #openstack-nova01:03
*** awalende has quit IRC01:05
*** markvoelker has joined #openstack-nova01:23
*** rcernin has quit IRC01:27
*** rcernin has joined #openstack-nova01:27
*** markvoelker has quit IRC01:29
*** yedongcan has joined #openstack-nova01:29
*** guozijn has joined #openstack-nova01:33
*** brinzhang has quit IRC01:33
*** brinzhang has joined #openstack-nova01:34
*** igordc has quit IRC01:35
*** spatel has joined #openstack-nova02:03
*** oomichi_ has quit IRC02:04
*** spatel has quit IRC02:08
*** tinwood has quit IRC02:10
*** tinwood has joined #openstack-nova02:12
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Microversion 2.74: Support Specifying AZ to unshelve  https://review.opendev.org/66513602:22
*** bhagyashris has joined #openstack-nova02:32
*** rtjure has quit IRC02:46
*** mkrai_ has joined #openstack-nova02:48
*** rtjure has joined #openstack-nova02:52
*** guozijn has quit IRC02:52
*** guozijn has joined #openstack-nova02:56
openstackgerritMerged openstack/nova stable/rocky: [ironic] Don't remove instance info twice in destroy  https://review.opendev.org/66258402:56
*** guozijn has quit IRC03:05
*** guozijn has joined #openstack-nova03:06
*** adrianreza_ has quit IRC03:07
*** yikun_ has joined #openstack-nova03:08
*** yikun has quit IRC03:09
*** yikun_ is now known as yikun03:09
*** BjoernT has joined #openstack-nova03:14
*** BjoernT has quit IRC03:19
*** BjoernT has joined #openstack-nova03:20
*** mugsie has quit IRC03:22
*** dosaboy has quit IRC03:22
*** mkrai has quit IRC03:22
*** ab-a has quit IRC03:22
*** bbowen has quit IRC03:22
*** szaher has quit IRC03:22
*** guilhermesp has quit IRC03:22
*** mvkr has quit IRC03:22
*** mgagne has quit IRC03:22
*** dasp has quit IRC03:22
*** hamzy has quit IRC03:22
*** sean-k-mooney has quit IRC03:22
*** d34dh0r53 has quit IRC03:22
*** jamesdenton has quit IRC03:24
*** jenglisch has quit IRC03:25
*** markvoelker has joined #openstack-nova03:25
*** jenglisch has joined #openstack-nova03:27
*** guozijn has quit IRC03:28
*** markvoelker has quit IRC03:29
*** psachin has joined #openstack-nova03:31
*** licanwei has quit IRC03:32
*** mkrai has joined #openstack-nova03:38
*** mugsie has joined #openstack-nova03:38
*** dosaboy has joined #openstack-nova03:38
*** ab-a has joined #openstack-nova03:38
*** bbowen has joined #openstack-nova03:38
*** szaher has joined #openstack-nova03:38
*** guilhermesp has joined #openstack-nova03:38
*** mvkr has joined #openstack-nova03:38
*** mgagne has joined #openstack-nova03:38
*** dasp has joined #openstack-nova03:38
*** hamzy has joined #openstack-nova03:38
*** sean-k-mooney has joined #openstack-nova03:38
*** d34dh0r53 has joined #openstack-nova03:38
*** irclogbot_3 has quit IRC03:41
*** irclogbot_2 has joined #openstack-nova03:42
*** dave-mccowan has quit IRC03:49
*** ratailor has joined #openstack-nova03:49
*** udesale has joined #openstack-nova03:53
*** dasp has quit IRC03:58
openstackgerritzhufl proposed openstack/nova master: Fix :param: in docstring  https://review.opendev.org/66528904:00
*** cfriesen has quit IRC04:03
*** igordc has joined #openstack-nova04:12
*** guozijn has joined #openstack-nova04:15
*** igordc has quit IRC04:19
*** dasp has joined #openstack-nova04:21
*** guozijn has quit IRC04:25
*** markvoelker has joined #openstack-nova04:25
*** markvoelker has quit IRC04:30
*** lbragstad has quit IRC04:43
*** janki has joined #openstack-nova04:47
*** whoami-rajat has joined #openstack-nova04:47
*** pcaruana has joined #openstack-nova05:09
*** luksky has joined #openstack-nova05:26
*** markvoelker has joined #openstack-nova05:26
openstackgerritBoxiang Zhu proposed openstack/nova master: Validate requested host/node during servers create  https://review.opendev.org/66123705:27
openstackgerritBoxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server  https://review.opendev.org/64552005:27
*** boxiang has joined #openstack-nova05:28
*** markvoelker has quit IRC05:31
*** BjoernT has quit IRC05:33
*** guozijn has joined #openstack-nova05:40
*** guozijn has quit IRC05:48
*** tetsuro has joined #openstack-nova05:48
*** guozijn has joined #openstack-nova05:50
*** dpawlik has joined #openstack-nova06:04
*** ivve has joined #openstack-nova06:06
*** sapd1_x has joined #openstack-nova06:21
*** yaawang has quit IRC06:24
*** maciejjozefczyk has joined #openstack-nova06:25
*** markvoelker has joined #openstack-nova06:27
*** markvoelker has quit IRC06:31
openstackgerritMerged openstack/nova master: fup: Merge machine_type_mappings into get_default_machine_type  https://review.opendev.org/66403606:33
*** udesale has quit IRC06:34
*** takamatsu has joined #openstack-nova06:34
*** rpittau|afk is now known as rpittau06:35
*** udesale has joined #openstack-nova06:37
*** tetsuro has quit IRC06:39
*** guozijn has quit IRC06:44
*** sapd1_x has quit IRC06:49
*** sapd1_x has joined #openstack-nova06:54
*** guozijn has joined #openstack-nova06:58
*** gibi has joined #openstack-nova07:08
*** tesseract has joined #openstack-nova07:08
*** sapd1_x has quit IRC07:09
*** awalende has joined #openstack-nova07:10
*** awalende has quit IRC07:10
*** awalende has joined #openstack-nova07:10
*** awalende has quit IRC07:11
*** awalende has joined #openstack-nova07:12
*** damien_r has joined #openstack-nova07:15
*** boxiang has quit IRC07:16
*** boxiang has joined #openstack-nova07:17
*** rcernin has quit IRC07:22
*** shilpasd_ has joined #openstack-nova07:22
*** yaawang has joined #openstack-nova07:22
*** markvoelker has joined #openstack-nova07:28
*** markvoelker has quit IRC07:35
*** bhagyashris has quit IRC07:40
*** sapd1_x has joined #openstack-nova07:41
*** helenafm has joined #openstack-nova07:43
*** dtantsur|afk is now known as dtantsur07:44
openstackgerritMerged openstack/nova master: Warn for duplicate host mappings during discover_hosts  https://review.opendev.org/65194707:45
openstackgerritMerged openstack/nova master: Literalize CLI options in docs  https://review.opendev.org/66521707:45
openstackgerritMerged openstack/nova master: Fix a warning about flags in an expression string  https://review.opendev.org/66506507:45
*** izza_ has quit IRC07:49
*** udesale has quit IRC07:56
*** zbr|ooo is now known as zbr|ruck08:01
*** slaweq has joined #openstack-nova08:02
*** tetsuro has joined #openstack-nova08:09
*** tetsuro has quit IRC08:09
*** tetsuro has joined #openstack-nova08:10
*** tetsuro has quit IRC08:10
*** mrch_ has joined #openstack-nova08:13
mrch_is there redhat production support for? https://www.suse.com/documentation/sles-15/singlehtml/art.amd-sev/art.amd-sev.html08:13
*** ttsiouts has joined #openstack-nova08:15
*** jangutter has joined #openstack-nova08:18
*** stress_t has quit IRC08:18
*** ralonsoh has joined #openstack-nova08:20
*** priteau has joined #openstack-nova08:23
*** sapd1_x has quit IRC08:24
*** mdbooth has joined #openstack-nova08:24
*** derekh has joined #openstack-nova08:29
*** ccamacho has joined #openstack-nova08:30
aspiersmrch_: no. I'm working on it08:31
aspiersmrch_: I mean, I'm working on adding SEV support to OpenStack08:31
aspiersnot sure if anyone from Red Hat is working on SEV support in the OS08:31
openstackgerritYongli He proposed openstack/nova master: Clean up orphan instances virt driver  https://review.opendev.org/64891208:32
openstackgerritYongli He proposed openstack/nova master: clean up orphan instances  https://review.opendev.org/62776508:32
aspiersbut the RH folks are being very helpful with my work08:32
aspiersmrch_: see http://specs.openstack.org/openstack/nova-specs/specs/train/approved/amd-sev-libvirt-support.html08:32
aspiersmrch_: what's the nature of your interest?08:32
*** cdent has joined #openstack-nova08:33
mrch_aspiers: thx08:35
*** shilpasd_ has quit IRC08:36
*** shilpasd_ has joined #openstack-nova08:37
*** tkajinam has quit IRC08:38
*** imacdonn has quit IRC08:39
*** imacdonn has joined #openstack-nova08:39
*** davidsha has joined #openstack-nova08:42
*** sapd1_x has joined #openstack-nova08:48
*** bhagyashris_ has joined #openstack-nova08:50
*** yaawang has quit IRC08:50
*** udesale has joined #openstack-nova08:55
*** guozijn has quit IRC09:02
*** ociuhandu has joined #openstack-nova09:06
*** maciejjozefczyk has quit IRC09:12
*** maciejjozefczyk has joined #openstack-nova09:13
*** shilpsd has joined #openstack-nova09:15
*** shilpasd__ has joined #openstack-nova09:16
*** shilpasd_ has quit IRC09:17
*** shilpsd has quit IRC09:19
*** Luzi has joined #openstack-nova09:29
*** cdent has quit IRC09:43
*** yaawang has joined #openstack-nova10:02
*** bhagyashris_ has quit IRC10:07
*** ratailor_ has joined #openstack-nova10:11
*** ratailor has quit IRC10:14
*** brinzhang has quit IRC10:15
*** ratailor_ has quit IRC10:16
*** boxiang has quit IRC10:17
*** aarents has quit IRC10:18
*** ratailor has joined #openstack-nova10:18
*** luksky has quit IRC10:26
*** guozijn has joined #openstack-nova10:26
*** ttsiouts has quit IRC10:27
*** ttsiouts has joined #openstack-nova10:27
*** sapd1_x has quit IRC10:31
*** ttsiouts has quit IRC10:32
*** cdent has joined #openstack-nova10:32
*** markvoelker has joined #openstack-nova10:33
*** udesale has quit IRC10:35
*** psachin has quit IRC10:37
*** markvoelker has quit IRC10:37
*** udesale has joined #openstack-nova10:38
*** psachin has joined #openstack-nova10:38
*** guozijn has quit IRC10:48
*** helenafm has quit IRC10:57
*** luksky has joined #openstack-nova11:04
*** ttsiouts has joined #openstack-nova11:04
*** xek has joined #openstack-nova11:09
*** jaosorior has joined #openstack-nova11:20
*** panda is now known as panda|lunch11:28
*** markvoelker has joined #openstack-nova11:33
*** markvoelker has quit IRC11:38
*** udesale has quit IRC11:48
*** janki has quit IRC11:49
*** Luzi has quit IRC11:49
*** cdent has quit IRC11:58
*** xek has quit IRC12:02
*** xek has joined #openstack-nova12:02
*** xek has quit IRC12:04
*** jaosorior has quit IRC12:09
*** xek has joined #openstack-nova12:09
*** awalende has quit IRC12:10
*** awalende has joined #openstack-nova12:13
*** cdent has joined #openstack-nova12:16
*** factor has joined #openstack-nova12:23
*** derekh has quit IRC12:25
openstackgerritsean mooney proposed openstack/nova-specs master: add libvirt pqos spec  https://review.opendev.org/66226412:25
*** hamzy has quit IRC12:27
*** dave-mccowan has joined #openstack-nova12:29
*** davidsha has quit IRC12:31
*** markvoelker has joined #openstack-nova12:34
*** dave-mccowan has quit IRC12:35
*** mkrai_ has quit IRC12:36
*** xek has quit IRC12:39
*** markvoelker has quit IRC12:39
*** xek has joined #openstack-nova12:39
*** panda|lunch is now known as panda12:55
*** _erlon_ has joined #openstack-nova12:56
*** derekh has joined #openstack-nova12:58
*** lbragstad has joined #openstack-nova12:59
*** priteau has quit IRC12:59
*** hamzy has joined #openstack-nova13:02
*** davidsha has joined #openstack-nova13:03
*** ociuhandu has quit IRC13:09
*** awalende has quit IRC13:13
*** hamzy has quit IRC13:13
*** awalende has joined #openstack-nova13:13
*** awalende has quit IRC13:14
*** awalende has joined #openstack-nova13:14
*** kaisers1 has quit IRC13:15
*** awalende has quit IRC13:16
*** kaisers has joined #openstack-nova13:16
*** awalende has joined #openstack-nova13:16
*** hamzy has joined #openstack-nova13:17
*** hamzy has quit IRC13:19
*** hamzy has joined #openstack-nova13:20
*** awalende has quit IRC13:20
*** awalende has joined #openstack-nova13:21
*** BjoernT has joined #openstack-nova13:25
*** priteau has joined #openstack-nova13:27
*** sapd1_x has joined #openstack-nova13:30
*** eharney has joined #openstack-nova13:31
*** mchlumsky has joined #openstack-nova13:31
*** decrypt has joined #openstack-nova13:32
*** spatel has joined #openstack-nova13:35
*** markvoelker has joined #openstack-nova13:35
*** spatel has quit IRC13:39
*** markvoelker has quit IRC13:40
*** awalende_ has joined #openstack-nova13:48
dansmithlyarwood: did you see mriedem's query about "q35" on the master patch for the sata bus thing?13:48
*** awalende has quit IRC13:51
*** awalende_ has quit IRC13:52
*** mlavalle has joined #openstack-nova13:56
*** whoami-rajat has quit IRC13:57
*** mrjk has joined #openstack-nova14:02
*** spatel has joined #openstack-nova14:02
*** liuyulong has joined #openstack-nova14:02
*** sapd1_x has quit IRC14:06
*** sapd1_x has joined #openstack-nova14:08
*** JamesBenson has joined #openstack-nova14:08
*** BjoernT has quit IRC14:08
artomdansmith, lyarwood at a medial appointment, but we've volunteered kashyap to follow up on that just now during our internal bug call :)14:11
artomdansmith, while I have you, is looking at https://review.opendev.org/#/c/644881/ again anywhere near the top of your review list?14:13
*** nicolasbock has joined #openstack-nova14:13
dansmithartom: mriedem has been shitting on my reviews all week, so I'm going to wait for him to +2 that14:14
kashyapartom: Got a link to the backport patch?14:14
dansmithkashyap: the backport isn't in question, it's the merged master one14:14
* kashyap goes in search14:14
dansmithkashyap: https://review.opendev.org/#/c/663011/14:14
artomJinx!14:15
artomdansmith, :( for mriedem. I may have been too pestery with him yesterday14:15
*** ttsiouts has quit IRC14:16
*** ttsiouts has joined #openstack-nova14:17
*** dpawlik has quit IRC14:17
kashyapdansmith: Matt answered the casing question, just saw that :)14:17
dansmithkashyap: oh sorry, hadn't refreshed my tab14:18
kashyapdansmith: No-no, but still it's a good question, the answer is not "complete"14:18
openstackgerritStephen Finucane proposed openstack/nova master: docs: Rework all things metadata'y  https://review.opendev.org/64073014:18
openstackgerritStephen Finucane proposed openstack/nova master: conf: Rename 'configuration drive' to 'config drive'  https://review.opendev.org/64172314:18
dansmithI'm guessing that if someone puts Q35 we'll just break, but earlier because we pass that to qemu?14:18
kashyapdansmith: Yes, that's what I'd expect; I wonder if there's equivalent of 'ignore_case' for image properties14:19
dansmithkashyap: well, it's all in the handling of it really14:20
kashyapFor now, we're not in the ditch: as Matt noted, libvirt itself reports (in its capabilities) it in lower case14:20
dansmithyeah, the patch doesn't make it worse, which is all that matters for the backport, that's fine14:20
*** ttsiouts has quit IRC14:21
*** awalende has joined #openstack-nova14:22
kashyapAnd we can rely on "instinctive laziness" of most folks, in terms of casing: people tend to "default" to lower case, as it comes "naturally" :D14:23
* kashyap ducks before superdan hurls a stole14:24
kashyaps/stole/stone/14:24
*** mrch_ has quit IRC14:24
* kashyap wonders why folks (those who do)are not using their Friday nicks...14:26
* stephenfin forgot14:26
*** stephenfin is now known as finucannot14:26
*** awalende has quit IRC14:26
*** artom is now known as temka14:29
*** priteau has quit IRC14:30
*** mrch_ has joined #openstack-nova14:30
*** mdbooth has quit IRC14:33
*** hamzy has quit IRC14:36
*** hamzy has joined #openstack-nova14:37
*** cdent has quit IRC14:38
*** dklyle has quit IRC14:42
openstackgerritsean mooney proposed openstack/nova master: extend libvirt video model support  https://review.opendev.org/64773314:42
*** dklyle has joined #openstack-nova14:42
*** shilpasd has quit IRC14:43
*** yedongcan has left #openstack-nova14:45
*** lpetrut has joined #openstack-nova14:46
dansmithtemka: I'm having a hard time with instance.get_network_info().get_bind_time_events()14:47
*** bnemec has joined #openstack-nova14:48
temkadansmith, how so?14:49
openstackgerritStephen Finucane proposed openstack/nova master: docs: Document how to revert, confirm a cold migration  https://review.opendev.org/66439614:50
openstackgerritStephen Finucane proposed openstack/nova master: docs: Update resize doc  https://review.opendev.org/66541214:50
temka... could be None, I suppose14:50
*** ratailor has quit IRC14:50
*** mdbooth has joined #openstack-nova14:51
*** cdent has joined #openstack-nova14:51
dansmithtemka: commenting with some analysis14:52
temkadansmith, much thanks :)14:52
cdentefried: you aware of https://bugs.launchpad.net/nova/+bug/1832164 and https://review.opendev.org/#/c/664193/ . it's blocking placement because of subunit14:52
openstackLaunchpad bug 1832164 in OpenStack Compute (nova) "SADeprecationWarning: The joinedload_all() function is deprecated, and will be removed in a future release. Please use method chaining with joinedload() instead" [Undecided,In progress] - Assigned to Takashi NATSUME (natsume-takashi)14:52
kashyapfinucannot: If you're respinning https://review.opendev.org/#/c/664396/2, a small grammar thinko in there.14:58
finucannotgood catch14:59
*** cfriesen has joined #openstack-nova14:59
*** decrypt has quit IRC14:59
kashyapfinucannot: Otherwise, looks good.  Thanks for documenting.15:00
finucannotdone15:00
kashyapfinucannot: Speaking of docs, ... you might be horrified to know, that some of the PCIe-related command-line options in QEMU are not even documented :-(15:00
kashyapI asked them here:15:00
openstackgerritStephen Finucane proposed openstack/nova master: docs: Document how to revert, confirm a cold migration  https://review.opendev.org/66439615:01
openstackgerritStephen Finucane proposed openstack/nova master: docs: Update resize doc  https://review.opendev.org/66541215:01
kashyaphttps://lists.gnu.org/archive/html/qemu-devel/2019-06/msg01173.html15:01
kashyap[Err, main e-mail here: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg01093.html]15:01
sean-k-mooneykashyap: that is not that surprising15:01
*** hamzy has quit IRC15:01
kashyapI'll get them documented in the official docs.  I find it unacceptable that valid options are hidden like that15:02
*** hamzy has joined #openstack-nova15:02
kashyapsean-k-mooney: They're getting better, though.  From my observation.  Still a long way to go.15:02
*** mrjk has quit IRC15:02
kashyapOne of the thorny "problems with documentation" is that misaligned incentives.15:02
*** mrjk has joined #openstack-nova15:02
sean-k-mooneykashyap: ya i just am not surpirsed then the more obsucre/less used flags of complex features are not docuemtned15:02
sean-k-mooneysomethimgs its because the interfaces were experimental and they did not want to commit to it15:03
sean-k-mooneyother times it just slips through the cracks15:03
*** ratailor has joined #openstack-nova15:04
kashyapIn this case, it's officially supported, and not experimental (as you can see from the response).  It was the all-too-common: "slipping through the cracks"15:04
sean-k-mooneyone of the nice things about having docs in tree is that you can require docs with each change that add a new user faceing change15:05
sean-k-mooneyor wehre you have docs generated form code15:06
efriedcdent: Will look. Been kind of avoiding because out of my realm, but I can ride on your vote with clear conscience15:06
cdentI think in this case you can rely on the tests, not me15:07
openstackgerritStephen Finucane proposed openstack/nova master: docs: Remove references to nova-consoleauth  https://review.opendev.org/65296515:07
openstackgerritStephen Finucane proposed openstack/nova master: tests: Stop starting consoleauth in functional tests  https://review.opendev.org/65296615:07
openstackgerritStephen Finucane proposed openstack/nova master: xvp: Start using consoleauth tokens  https://review.opendev.org/65296715:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-status: Remove consoleauth workaround check  https://review.opendev.org/65296815:07
openstackgerritStephen Finucane proposed openstack/nova master: Remove nova-consoleauth  https://review.opendev.org/65296915:07
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict  https://review.opendev.org/65297015:07
openstackgerritStephen Finucane proposed openstack/nova master: docs: Rework nova console diagram  https://review.opendev.org/66014715:07
*** luksky has quit IRC15:08
*** bnemec is now known as beekneemech15:11
*** ratailor has quit IRC15:12
efriedcdent: That wasn't so scary, found a page that explains it clearly. dansmith, would you please send https://review.opendev.org/#/c/664193/ ?15:13
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug  https://review.opendev.org/64488115:14
openstackgerritArtom Lifshitz proposed openstack/nova master: WIP: Include direct-physical in compute manager events check  https://review.opendev.org/66443115:14
openstackgerritArtom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events  https://review.opendev.org/66444215:14
dansmithefried: link me to the page? because it looks scary on the surface15:14
efrieddansmith: https://docs.sqlalchemy.org/en/13/changelog/migration_09.html#new-query-options-api-load-only-option15:14
dansmithefried: that page says that the old methods will be supported "indefinitely"15:16
cdentthey spit warnings15:16
cdentlots and lots and lots of warnings15:16
dansmithoh, hmm, that's annoying given the statement15:17
dansmithcdent: your suggestion would be a lot tidier15:18
dansmithcdent: any chance you'd just do that real quick so I and efried can approve _that_ ?15:18
dansmithshould just be a few lines of change it looks like15:19
cdentyeah, can do15:19
cdentone mo15:19
*** damien_r has quit IRC15:19
efriedcdent, dansmith: tbh I would prefer going the other way15:28
efriedbut whatever15:28
dansmithefried: that's not as easy15:28
cdenti'm basically done15:28
dansmithbecause we calculate column names in places15:28
cdentyes, that15:28
efriedright, I get that, so I'm fine with it. But I actually prefer the explicitness of takashi's patch. But I'm fine either way.15:29
*** ivve has quit IRC15:29
cdentthe new diff is way tidier15:30
dansmithjoinedload, joinedload_all, joined, etc has brought plenty of confusion in the past, so more consistency for people to copy seems like a win to me15:30
dansmithalso, cdent and I are agreeing which means (1) jump on that shit and (2) go buy some lottery tickets15:30
cdent15:31
* cdent has some slow network...15:31
openstackgerritChris Dent proposed openstack/nova master: Replace joinedload_all with joinedload  https://review.opendev.org/66419315:32
cdenti didn't run any tests on that ^15:32
cdentwill start them now15:32
dansmithcdent: I was going to write a unit test for the helper too15:33
efriedlgtm cdent15:34
cdentyeah, I gotta run now, so hope that's suitable, but will leave it in dan's earlier in his day hands15:34
*** maciejjozefczyk has quit IRC15:37
*** markvoelker has joined #openstack-nova15:37
openstackgerritStephen Finucane proposed openstack/nova master: Follow-up for I6a777b4b7a5729488f939df8c40e49bd40aec3dd  https://review.opendev.org/66496715:38
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'MultiattachSupportNotYetAvailable' exception  https://review.opendev.org/65131515:38
*** maciejjozefczyk has joined #openstack-nova15:39
finucannotefried: I removed the additional test that I'd meant to remove in https://review.opendev.org/#/c/664967/. Fancy revisiting?15:39
efried...15:39
finucannotefried: Addressed this comment https://review.opendev.org/#/c/621061/8/nova/tests/unit/compute/test_compute_api.py@447715:40
finucannotin the follow-up15:40
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions  https://review.opendev.org/53741415:41
efriedfinucannot: +2, thanks for getting on the new=mock.Mock() bandwagon with me.15:41
*** markvoelker has quit IRC15:41
*** cdent_ has joined #openstack-nova15:42
*** cdent_ has quit IRC15:43
*** cdent has quit IRC15:43
dansmithefried: you have insulted me to my core15:48
efriedpayback is hell15:48
sean-k-mooneyefried: why use new=mock.mock() ? in what case is that needed?15:49
dansmithnew= prevents it from being passed as an arg15:50
efriedsean-k-mooney: When using decorator:15:50
efried@mock.patch("...") <== causes an argument to be created to your method15:50
efried@mock.patch("...", new=...)  <== no arg15:50
efriedyeah, what dansmith said15:50
sean-k-mooneydansmith: oh ok that makes sense if you never want to use of check it15:51
temkaefried, that's *massively* useful15:51
*** jaypipes has quit IRC15:51
temkaefried, I've been using _ where possible15:51
dansmithsean-k-mooney: yeah, but it's also a good thing to verify that the person isn't skirting some checking they should be doing as a result :)15:51
sean-k-mooneytemka: in a fucntion signiture15:51
efriedtemka: You mean it's a thing you didn't know, or you're agreeing that it's useful and you use it?15:51
temkaefried, yes ;)15:51
sean-k-mooneyefried: yes15:51
temkasean-k-mooney, yeah, you can have def blah(self, _)15:52
sean-k-mooneytemka: yes that would be an instance -1 form me15:52
temkasean-k-mooney, you'd be alone then :)15:52
sean-k-mooneyi really think that is poor api design15:52
temkaOnly in unit tests15:52
sean-k-mooneyyou are technically not overloading if you cange teh name to _15:53
sean-k-mooneyso even in unit tests you shoudl not do that15:53
temka[artom@zoe nova]$ grep def.*_\) -R nova/tests/ | wc -l15:53
temka1315:53
sean-k-mooneyi guess you are doingit for function that will be used in place of a mock?15:53
temkaWonder if all of those are mine15:53
openstackgerritDan Smith proposed openstack/nova master: Add a test for the _joinedload_all helper  https://review.opendev.org/66542115:54
dansmithefried: ^15:54
efrieddansmith: +2, nice. Added cdent15:55
sean-k-mooneytemka: i wonder if the new=mock.Mock works the same way when your apply the decorator to a class15:56
efriedit does15:56
sean-k-mooneynormally that results in the moc being passed to all fucntion or in this case not being based15:56
sean-k-mooneypassed15:56
sean-k-mooneyis mriedemn around today15:58
sean-k-mooneymriedemn: just droping off for the day but i adress your comments in https://review.opendev.org/#/c/647733/15:59
dansmithsean-k-mooney: he's out today15:59
sean-k-mooneyok no worries15:59
sean-k-mooneyi was just going to say if he spots anythin else ill adress it on monday15:59
*** hjensas is now known as hjensas|afk16:01
finucannotmelwitt: Should I drag https://review.opendev.org/#/c/652967/ to the front of the series and add a bug link?16:03
finucannoti.e. do we care enough about the XVP VNC proxy to both backporting?16:03
finucannot*bother16:03
melwittfinucannot: I was debating about it... because yeah it's a bug but we have like zero testing for this so it would have to be a testless bug fix else you'd have to figure out how to add testing for a thing no one's using. so I dunno16:04
finucannotYeah, we have zero tests for that and can probably remove it this cycle16:06
melwittoh and I would not expect to backport16:06
finucannotOkay, then I don't need to worry about opening a bug for this so16:07
*** takamatsu has quit IRC16:07
finucannotBobBall said on the ML some time back that they're not using it anymore16:07
*** cdent has joined #openstack-nova16:08
melwittyeah. I'd just leave it for now and see if mriedem complains16:11
melwitthe's the expert on these type of complicated matters16:11
*** rpittau is now known as rpittau|afk16:11
sean-k-mooneymtreinish: tonyb[m] would ye be able to take a look at these trivial test only stable backport for me on os-vif. https://review.opendev.org/#/c/665196/ and https://review.opendev.org/#/c/665195/16:12
openstackgerritStephen Finucane proposed openstack/nova master: xvp: Start using consoleauth tokens  https://review.opendev.org/65296716:17
openstackgerritStephen Finucane proposed openstack/nova master: nova-status: Remove consoleauth workaround check  https://review.opendev.org/65296816:17
openstackgerritStephen Finucane proposed openstack/nova master: Remove nova-consoleauth  https://review.opendev.org/65296916:17
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict  https://review.opendev.org/65297016:17
openstackgerritStephen Finucane proposed openstack/nova master: docs: Rework nova console diagram  https://review.opendev.org/66014716:18
openstackgerritStephen Finucane proposed openstack/nova master: xvp: Remove use of '_LI' marker  https://review.opendev.org/66542516:18
*** maciejjozefczyk has quit IRC16:19
*** dtantsur is now known as dtantsur|afk16:26
*** guozijn has joined #openstack-nova16:30
finucannotargparse is broken in so many little ways that it kind of hurts :(16:36
temkamoar liek arseparse, amirite?16:37
finucannottemka++16:37
*** derekh has quit IRC16:37
cdenttemka+++16:38
cdentargparse is so very very ugh16:38
finucannotIt tries to be too clever16:40
finucannotand fails miserably16:41
finucannotfwiw, click (which is A+) is based on optparse and not argparse for just that reason16:41
openstackgerritStephen Finucane proposed openstack/nova master: Always Set dhcp_server in network_info  https://review.opendev.org/65836216:44
*** jangutter has quit IRC16:47
efriedfinucannot: https://review.opendev.org/#/c/664396/ - missed one --?16:47
finucannotmy bad. On it16:48
openstackgerritStephen Finucane proposed openstack/nova master: docs: Document how to revert, confirm a cold migration  https://review.opendev.org/66439616:49
openstackgerritStephen Finucane proposed openstack/nova master: docs: Update resize doc  https://review.opendev.org/66541216:49
finucannotefried: ^16:50
*** davidsha has quit IRC16:51
efriedfinucannot: thx, +216:51
*** guozijn has quit IRC16:52
sean-k-mooneyam i missing somthing16:53
sean-k-mooney"openstack server migrate revert" is not a thing16:53
sean-k-mooneynor is "openstack server migrate confirm"16:54
sean-k-mooneyyou have to use openstack server resize --revert or openstack server resize --confirm16:54
sean-k-mooneyoh your adding them in the depnds on patch16:55
openstackgerritStephen Finucane proposed openstack/nova master: This patch is to fix bug #1831657  https://review.opendev.org/66392616:56
openstackbug 1831657 in OpenStack Compute (nova) "Instance migration/Instance resize with lvm volumes" [Medium,Triaged] https://launchpad.net/bugs/1831657 - Assigned to Dr. Clemens Hardewig (bringha1)16:56
*** guozijn has joined #openstack-nova17:00
*** sapd1_x has quit IRC17:00
openstackgerritEric Fried proposed openstack/nova master: xenapi: Remove dead host_call_plugin method  https://review.opendev.org/66543417:03
*** lbragstad is now known as lbragstad_runnin17:04
*** spatel has quit IRC17:04
efriedfinucannot: ^ totally unrelated to hacking patch IMO17:05
finucannotefried: Separate patch is a-okay (though perhaps it should come first). My objection was to touching dead code in general17:07
finucannotlookig17:07
finucannot*looking17:07
efriedI definitely don't understand by looking at that code why it would be unreachable or whatever, which you clearly do at a glance (heh).17:08
efriedBut the hacking rule seems straightforward to me, and uncontroversial, so I put the weird one after.17:09
efriedCould put them in parallel, but would have to resolve merge conflict then17:09
mtreinishsean-k-mooney: +217:12
*** cdent has quit IRC17:13
finucannotmelwitt: Fancy sanity checking this patch https://review.opendev.org/#/c/662570/ (it's mriedem's)17:18
melwittfinucannot: ah yep, meant to do that. looking17:18
openstackgerritStephen Finucane proposed openstack/nova master: Removing the stale parameters documented for kombu  https://review.opendev.org/66415317:19
*** mdbooth has quit IRC17:20
*** igordc has joined #openstack-nova17:22
*** hamzy has quit IRC17:23
*** priteau has joined #openstack-nova17:23
*** hamzy has joined #openstack-nova17:24
openstackgerritEric Fried proposed openstack/nova master: Raise if flavor and image disagree on hide_hypervisor_id  https://review.opendev.org/66336517:25
*** lpetrut has quit IRC17:30
*** ralonsoh has quit IRC17:31
*** markvoelker has joined #openstack-nova17:38
*** lbragstad_runnin is now known as lbragstad17:43
*** markvoelker has quit IRC17:43
*** hamzy has quit IRC17:47
openstackgerritEric Fried proposed openstack/nova master: Clarify --before help text in nova manage  https://review.opendev.org/66128917:47
*** spatel has joined #openstack-nova17:52
*** hamzy has joined #openstack-nova17:56
openstackgerritmelanie witt proposed openstack/nova master: Add 'path' query parameter to console access url  https://review.opendev.org/64937218:01
*** rtjure has quit IRC18:02
melwittfinucannot: updated ^18:02
efriedmelwitt: your co-authored-by email address is wrong, intentional?18:04
*** JamesBenson has quit IRC18:04
melwittefried: no, that's my actual email because someone else owns melwitt@18:04
efriedoh, no kidding, and I just noticed after all these years.18:05
melwitthaha, yeah I stubbornly wanted it to look like melwitt@ from a tidiness perspective but it's resulted in some people thinking they emailed me when they really didn't (oops)18:06
*** spatel has quit IRC18:07
*** psachin has quit IRC18:08
*** rtjure has joined #openstack-nova18:10
*** spatel has joined #openstack-nova18:12
*** JamesBenson has joined #openstack-nova18:13
*** hongbin has joined #openstack-nova18:16
*** jaosorior has joined #openstack-nova18:16
*** rtjure has quit IRC18:16
*** JamesBenson has quit IRC18:18
*** jaosorior has quit IRC18:18
*** tesseract has quit IRC18:18
*** rtjure has joined #openstack-nova18:25
*** spatel has quit IRC18:27
*** JamesBenson has joined #openstack-nova18:31
*** spatel has joined #openstack-nova18:31
*** dpawlik has joined #openstack-nova18:34
*** JamesBenson has quit IRC18:35
*** markvoelker has joined #openstack-nova18:39
*** markvoelker has quit IRC18:44
*** JamesBenson has joined #openstack-nova18:46
*** JamesBenson has quit IRC18:47
*** JamesBenson has joined #openstack-nova18:47
*** spatel has quit IRC18:53
*** Sundar has joined #openstack-nova18:56
*** spatel has joined #openstack-nova18:58
*** hamzy has quit IRC19:05
*** priteau has quit IRC19:26
*** pcaruana has quit IRC19:39
*** hamzy has joined #openstack-nova19:45
*** luksky has joined #openstack-nova19:56
*** factor has quit IRC20:05
*** spatel has quit IRC20:17
*** markvoelker has joined #openstack-nova20:41
*** markvoelker has quit IRC20:45
*** mchlumsky has quit IRC20:56
*** Sundar has quit IRC21:05
*** kaisers1 has joined #openstack-nova21:05
*** kaisers has quit IRC21:07
*** zbr|ruck has quit IRC21:13
*** zbr has joined #openstack-nova21:31
openstackgerritMerged openstack/nova master: Make RequestContext(instance_lock_checked) fail  https://review.opendev.org/66500321:52
openstackgerritMerged openstack/nova master: Fix invalid privsep.readpty test  https://review.opendev.org/65626221:52
openstackgerritMerged openstack/nova master: Add functional recreate test for bug 1829479 and bug 1817833  https://review.opendev.org/66373721:53
openstackbug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Medium,Triaged] https://launchpad.net/bugs/182947921:53
openstackbug 1817833 in OpenStack Compute (nova) "Check compute_id existence when nova-compute reports info to placement" [Undecided,In progress] https://launchpad.net/bugs/1817833 - Assigned to xulei (605423512-j)21:53
openstackgerritMerged openstack/nova master: Mock time.sleep() in unit tests  https://review.opendev.org/64876221:53
openstackgerritMerged openstack/nova master: Modifying install-guide to include public endpoint for identity service  https://review.opendev.org/66353021:53
*** xek has quit IRC22:03
openstackgerritMerged openstack/nova master: Handle PortLimitExceeded in POST /servers/{server_id}/os-interface  https://review.opendev.org/65009722:07
openstackgerritMerged openstack/nova master: Hacking N363: `in (not_a_tuple)`  https://review.opendev.org/66404122:08
openstackgerritMerged openstack/nova master: Update quota known issues docs  https://review.opendev.org/66257022:08
*** luksky has quit IRC22:08
*** spatel has joined #openstack-nova22:14
*** spatel has quit IRC22:19
openstackgerritMerged openstack/nova stable/stein: Fix double word hacking test  https://review.opendev.org/66514722:22
*** dpawlik has quit IRC22:29
*** slaweq has quit IRC22:35
*** markvoelker has joined #openstack-nova22:42
*** igordc has quit IRC22:45
*** dpawlik has joined #openstack-nova22:45
*** markvoelker has quit IRC22:47
*** dpawlik has quit IRC22:50
*** JamesBenson has quit IRC22:50
*** hongbin has quit IRC23:09
*** slaweq has joined #openstack-nova23:11
*** igordc has joined #openstack-nova23:13
*** _erlon_ has quit IRC23:18
*** slaweq has quit IRC23:24
*** nicolasbock has quit IRC23:34
*** markvoelker has joined #openstack-nova23:43
*** markvoelker has quit IRC23:48

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!