openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Add a guide to add a new microversion support https://review.opendev.org/667002 | 00:04 |
---|---|---|
openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot https://review.opendev.org/580336 | 00:07 |
openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support delete_on_termination in volume attach api https://review.opendev.org/612949 | 00:08 |
*** igordc has quit IRC | 00:13 | |
*** Sundar has quit IRC | 00:18 | |
*** hongbin has quit IRC | 00:19 | |
*** brinzhang has joined #openstack-nova | 00:25 | |
*** wwriverrat has quit IRC | 00:39 | |
*** spatel has joined #openstack-nova | 00:48 | |
*** _alastor_ has quit IRC | 00:58 | |
*** bbowen has joined #openstack-nova | 01:01 | |
*** brinzhang_ has joined #openstack-nova | 01:07 | |
*** brinzhang has quit IRC | 01:10 | |
openstackgerrit | Alex Xu proposed openstack/nova master: Correct the comment of RequestSpec's network_metadata https://review.opendev.org/667061 | 01:12 |
*** mkrai_ has joined #openstack-nova | 01:13 | |
*** spatel has quit IRC | 01:26 | |
*** BjoernT has quit IRC | 01:31 | |
*** rcernin has quit IRC | 01:48 | |
*** rcernin has joined #openstack-nova | 01:48 | |
*** hongbin has joined #openstack-nova | 02:04 | |
*** whoami-rajat has joined #openstack-nova | 02:07 | |
*** mkrai_ has quit IRC | 02:24 | |
*** brinzhang__ has joined #openstack-nova | 02:26 | |
*** brinzhang_ has quit IRC | 02:29 | |
*** mkrai_ has joined #openstack-nova | 02:30 | |
*** jaypipes has joined #openstack-nova | 02:36 | |
*** rcernin has quit IRC | 02:42 | |
*** rcernin has joined #openstack-nova | 02:42 | |
*** threestrands has joined #openstack-nova | 02:54 | |
*** rcernin has quit IRC | 03:04 | |
*** rcernin has joined #openstack-nova | 03:04 | |
*** sapd1_x has joined #openstack-nova | 03:07 | |
*** lbragstad has joined #openstack-nova | 03:18 | |
*** fyx has quit IRC | 03:18 | |
*** mnaser has quit IRC | 03:19 | |
*** fyx has joined #openstack-nova | 03:19 | |
*** mnaser has joined #openstack-nova | 03:20 | |
*** BjoernT has joined #openstack-nova | 03:26 | |
*** rcernin has quit IRC | 03:30 | |
*** rcernin has joined #openstack-nova | 03:31 | |
*** BjoernT has quit IRC | 03:31 | |
*** BjoernT has joined #openstack-nova | 03:35 | |
*** psachin has joined #openstack-nova | 03:39 | |
openstackgerrit | huichen proposed openstack/nova master: Support pagination for sever groups by sql https://review.opendev.org/667259 | 03:40 |
*** udesale has joined #openstack-nova | 03:53 | |
*** lbragstad has quit IRC | 03:59 | |
*** BjoernT has quit IRC | 04:18 | |
*** hongbin has quit IRC | 04:25 | |
*** hongbin has joined #openstack-nova | 04:42 | |
*** hongbin has quit IRC | 04:49 | |
*** ratailor has joined #openstack-nova | 04:58 | |
*** ivve has joined #openstack-nova | 05:04 | |
*** cf__ has joined #openstack-nova | 05:18 | |
*** dannins has joined #openstack-nova | 05:26 | |
*** sapd1_x has quit IRC | 05:34 | |
*** artom has joined #openstack-nova | 05:34 | |
*** artom is now known as artom|gmtplus3 | 05:35 | |
*** ysandeep has joined #openstack-nova | 05:43 | |
*** Luzi has joined #openstack-nova | 05:44 | |
cf__ | Hi! I asked in cinder channel yesterday regarding delete_on_termination and they pointed me towards nova, which make sense, however, when I do nova show <uuid>, I do not receive any information about delete_on_termination, even that I did set it when creating the instance.. What am I doing wrong, to check if the volume is going to be deleted on instance termnination? | 05:50 |
cf__ | $ nova show 83fcdb58-045a-4475-b4eb-5b9287daebcc |grep volume | 05:56 |
cf__ | | os-extended-volumes:volumes_attached | [{"id": "f3e192b6-f8b0-4a9b-8512-4e7ffa37756d"}] | 05:56 |
*** pcaruana has joined #openstack-nova | 05:56 | |
*** pcaruana has quit IRC | 05:57 | |
*** pcaruana has joined #openstack-nova | 05:57 | |
*** lpetrut has joined #openstack-nova | 06:01 | |
brinzhang__ | cf__: What about your volume? root disk? or data disk ? | 06:05 |
cf__ | brinzhang__: it's my root disk | 06:06 |
brinzhang__ | cf__: If it's a root disk, you can see the delete_on_termination from 'nova show server_id' | 06:06 |
brinzhang__ | [root@localhost ~]# nova show ec939a46-9e1e-4126-8214-6ceb3b95676a |grep volume | 06:06 |
brinzhang__ | | image | Attempt to boot from volume - no image supplied | | 06:06 |
brinzhang__ | | os-extended-volumes:volumes_attached | [{"id": "df191675-0ac1-4101-a590-7ad2f7607e89", "delete_on_termination": true}] | | 06:06 |
cf__ | The thing is, the person that started a bunch of instances did it with config_drive enabled which is kinda destroying the idea of a flexible environment, by making it extremely hard to live migrate running instances | 06:07 |
cf__ | Yeah, that's what i'm trying to find, however as pasted above, it dosnt show.. This is a test instance I made with delete_on_termination true, but I wanted to check if I was able to see it anywhere because for my production instances, i cannot risk to lose my volumes when i'm forced to delete the running instances and create new ones with the existing volumes in order to get rid of config_drive | 06:08 |
cf__ | for a random production instance i get: | 06:10 |
cf__ | stack@j3499-cp1-c1-m1-mgmt:~$ nova show f0c664e6-f161-41ac-93bd-cc2500644583 |grep volume | 06:10 |
cf__ | | image | Attempt to boot from volume - no image supplied | | 06:10 |
cf__ | | os-extended-volumes:volumes_attached | [{"id": "d86ea1ef-1b31-435d-8d3c-f106b61501ec"}, {"id": "d6fc7a5b-2cc0-4764-9a47-8cc89a609e0f"}, {"id": "9ff316b7-ff6d-4f63-a3fe-97dde0ba8803"}] | | 06:10 |
cf__ | ofcause this one, I do not know if delete_on_termination was set uppon creation - however it is on the first one I pasted, which was made only to check if I was able to find the info about delete_on_termination | 06:11 |
brinzhang__ | cf__: I think you can check it in block_device_mapping table, is that the delete_on_termination was set? | 06:12 |
cf__ | brinzhang__: so check the database? or is there a way to check it from cli? | 06:12 |
brinzhang__ | Because there is no scene for you, you can’t be sure that the problem exists. | 06:13 |
cf__ | Yeah, i just want to make sure not to lose data when I delete the running instances :) | 06:13 |
brinzhang__ | Currently, the delete_on_termination can only set when the server boot, there are two specs want to support config and reconfig that change, but not start working ... | 06:15 |
cf__ | It make sense.. maybe I should just create some backup before testing this :P | 06:16 |
brinzhang__ | Thanks, you can try test this, and report a but on launchpad https://bugs.launchpad.net/nova | 06:17 |
brinzhang__ | If ensure that issue exist :P | 06:18 |
cf__ | Will do, thanks :) | 06:19 |
cf__ | Oh btw, it's worth mentioning that this is a rather old instance of openstack since we're currently running Newton, but I guess that shouldnt do much of a difference | 06:19 |
brinzhang__ | Oh.. good luck. | 06:24 |
*** belmoreira has joined #openstack-nova | 06:30 | |
*** belmoreira has quit IRC | 06:31 | |
openstackgerrit | Yongli He proposed openstack/nova master: Clean up orphan instances virt driver https://review.opendev.org/648912 | 06:33 |
openstackgerrit | Yongli He proposed openstack/nova master: clean up orphan instances https://review.opendev.org/627765 | 06:33 |
*** belmoreira has joined #openstack-nova | 06:33 | |
*** slaweq has joined #openstack-nova | 06:38 | |
*** luksky has joined #openstack-nova | 06:41 | |
*** rcernin has quit IRC | 06:41 | |
*** altlogbot_0 has quit IRC | 06:46 | |
*** altlogbot_2 has joined #openstack-nova | 06:50 | |
*** altlogbot_2 has quit IRC | 06:50 | |
cf__ | brinzhang__: I found it! Turns out that the easiest way was to check it in the nova database... | 06:54 |
cf__ | mysql> select delete_on_termination from block_device_mapping where instance_uuid = '83fcdb58-045a-4475-b4eb-5b9287daebcc'; | 06:54 |
cf__ | +-----------------------+ | 06:54 |
cf__ | | delete_on_termination | | 06:54 |
cf__ | +-----------------------+ | 06:54 |
cf__ | | 1 | | 06:54 |
cf__ | +-----------------------+ | 06:54 |
*** dpawlik has joined #openstack-nova | 06:55 | |
*** altlogbot_1 has joined #openstack-nova | 06:55 | |
*** threestrands has quit IRC | 07:00 | |
*** threestrands has joined #openstack-nova | 07:00 | |
brinzhang__ | cf__:So, next, you should to check that 'nova show' why not return this attribute, is there some error? Or some useful log? | 07:01 |
brinzhang__ | I am sorry, I am not have the newton environment to support more help :P | 07:02 |
*** tesseract has joined #openstack-nova | 07:11 | |
*** artom has joined #openstack-nova | 07:13 | |
*** artom|gmtplus3 has quit IRC | 07:13 | |
*** rdopiera has joined #openstack-nova | 07:17 | |
*** xek has joined #openstack-nova | 07:22 | |
*** ttsiouts has joined #openstack-nova | 07:28 | |
*** ttsiouts has quit IRC | 07:33 | |
*** artom is now known as artom|gmtplus3 | 07:35 | |
*** jangutter has joined #openstack-nova | 07:41 | |
*** ccamacho has joined #openstack-nova | 07:41 | |
*** ccamacho has quit IRC | 07:41 | |
*** jangutter has quit IRC | 07:42 | |
*** jangutter_ has joined #openstack-nova | 07:42 | |
*** ccamacho has joined #openstack-nova | 07:43 | |
*** tssurya has joined #openstack-nova | 07:46 | |
*** damien_r has joined #openstack-nova | 07:54 | |
*** threestrands has quit IRC | 07:57 | |
openstackgerrit | zhaixiaojun proposed openstack/python-novaclient master: Modify the url of upper_constraints_file https://review.opendev.org/665934 | 07:59 |
*** ttsiouts has joined #openstack-nova | 08:00 | |
*** takashin has left #openstack-nova | 08:00 | |
*** udesale has quit IRC | 08:01 | |
*** udesale has joined #openstack-nova | 08:03 | |
*** udesale has quit IRC | 08:03 | |
*** udesale has joined #openstack-nova | 08:03 | |
*** ricolin has joined #openstack-nova | 08:05 | |
*** adrianc_ has quit IRC | 08:06 | |
*** ricolin has quit IRC | 08:13 | |
*** adrianc has joined #openstack-nova | 08:14 | |
*** ricolin has joined #openstack-nova | 08:22 | |
*** tkajinam has quit IRC | 08:27 | |
*** tkajinam has joined #openstack-nova | 08:28 | |
*** ralonsoh has joined #openstack-nova | 08:28 | |
*** Dinesh_Bhor has quit IRC | 08:29 | |
*** tkajinam has quit IRC | 08:29 | |
*** imacdonn has quit IRC | 08:42 | |
*** imacdonn has joined #openstack-nova | 08:42 | |
*** martinkennelly has joined #openstack-nova | 08:44 | |
*** priteau has joined #openstack-nova | 08:56 | |
*** tssurya has quit IRC | 08:59 | |
*** Dinesh_Bhor has joined #openstack-nova | 09:01 | |
openstackgerrit | Rui Zang proposed openstack/nova-specs master: support virtual persistent memory https://review.opendev.org/601596 | 09:02 |
*** jaosorior has joined #openstack-nova | 09:03 | |
openstackgerrit | Arnaud Morin proposed openstack/nova master: Do not refresh deleted instance info cache https://review.opendev.org/667294 | 09:06 |
*** jaosorior has quit IRC | 09:11 | |
*** ratailor_ has joined #openstack-nova | 09:14 | |
*** ratailor has quit IRC | 09:17 | |
*** tetsuro_ has joined #openstack-nova | 09:18 | |
*** mdbooth has joined #openstack-nova | 09:21 | |
*** tssurya has joined #openstack-nova | 09:29 | |
*** artom|gmtplus3 has quit IRC | 09:35 | |
*** davidsha has joined #openstack-nova | 09:37 | |
*** Bidwe_jay77 has joined #openstack-nova | 09:37 | |
*** tetsuro_ has quit IRC | 09:41 | |
*** shilpasd has joined #openstack-nova | 09:43 | |
*** mkrai_ has quit IRC | 09:47 | |
*** mrch_ has quit IRC | 09:49 | |
*** mrch_ has joined #openstack-nova | 09:50 | |
*** ratailor__ has joined #openstack-nova | 09:53 | |
openstackgerrit | huichen proposed openstack/nova master: Support pagination for sever groups by sql https://review.opendev.org/667259 | 09:53 |
*** panda has quit IRC | 09:55 | |
*** ratailor_ has quit IRC | 09:56 | |
*** gmann has quit IRC | 09:57 | |
openstackgerrit | huichen proposed openstack/nova master: Support pagination for sever groups by sql https://review.opendev.org/667259 | 10:00 |
*** panda has joined #openstack-nova | 10:00 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520 | 10:06 |
*** ociuhandu has joined #openstack-nova | 10:13 | |
*** artom has joined #openstack-nova | 10:16 | |
*** Dinesh_Bhor has quit IRC | 10:16 | |
*** artom is now known as artom|gmtplus3 | 10:16 | |
*** ociuhandu_ has joined #openstack-nova | 10:16 | |
*** ociuhandu has quit IRC | 10:16 | |
*** mkrai_ has joined #openstack-nova | 10:18 | |
*** ttsiouts has quit IRC | 10:21 | |
*** ttsiouts has joined #openstack-nova | 10:21 | |
*** brinzhang_ has joined #openstack-nova | 10:25 | |
*** ttsiouts has quit IRC | 10:26 | |
*** brinzhang__ has quit IRC | 10:28 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-status: Remove consoleauth workaround check https://review.opendev.org/652968 | 10:34 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove nova-consoleauth https://review.opendev.org/652969 | 10:34 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict https://review.opendev.org/652970 | 10:34 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rework nova console diagram https://review.opendev.org/660147 | 10:34 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Integrate 'sphinx.ext.imgconverter' https://review.opendev.org/665693 | 10:34 |
*** bbowen has quit IRC | 10:36 | |
*** brinzhang__ has joined #openstack-nova | 10:47 | |
*** brinzhang_ has quit IRC | 10:50 | |
*** mdbooth has quit IRC | 10:51 | |
*** mdbooth has joined #openstack-nova | 10:55 | |
*** gmann has joined #openstack-nova | 10:58 | |
*** jaosorior has joined #openstack-nova | 10:59 | |
*** jaosorior has quit IRC | 11:02 | |
*** jaosorior has joined #openstack-nova | 11:03 | |
*** mdbooth has quit IRC | 11:05 | |
*** mdbooth has joined #openstack-nova | 11:05 | |
*** udesale has quit IRC | 11:06 | |
*** udesale has joined #openstack-nova | 11:08 | |
*** ttsiouts has joined #openstack-nova | 11:16 | |
*** ratailor__ has quit IRC | 11:18 | |
*** mdbooth has quit IRC | 11:20 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Remove redundant group host setup https://review.opendev.org/667334 | 11:24 |
*** mdbooth has joined #openstack-nova | 11:31 | |
*** mmethot_ has quit IRC | 11:32 | |
*** lbragstad has joined #openstack-nova | 11:33 | |
*** priteau has quit IRC | 11:43 | |
*** bbowen has joined #openstack-nova | 11:43 | |
*** francoisp has quit IRC | 11:45 | |
*** _erlon_ has joined #openstack-nova | 11:48 | |
openstackgerrit | Arnaud Morin proposed openstack/nova stable/stein: Always Set dhcp_server in network_info https://review.opendev.org/667340 | 11:50 |
*** mlavalle has joined #openstack-nova | 11:53 | |
*** psachin has quit IRC | 11:54 | |
*** jamesdenton has quit IRC | 11:54 | |
*** spatel has joined #openstack-nova | 11:55 | |
*** luksky has quit IRC | 12:00 | |
*** spatel has quit IRC | 12:00 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/457886 | 12:04 |
lyarwood | mdbooth / dansmith ; ^ rebased and touched up slightly, should be ready for review again. | 12:05 |
*** mmethot has joined #openstack-nova | 12:07 | |
*** mlavalle has quit IRC | 12:07 | |
mdbooth | lyarwood: Hehe, I managed to avoid the external_events conflict with my patch by out-waiting it :) | 12:07 |
mdbooth | Ah, you didn't conflict with it. Lucky. | 12:08 |
mdbooth | artom|gmtplus3 sean-k-mooney: Do you expect your fixed hybrid vif plugged patch to land soon? | 12:16 |
sean-k-mooney | am i hope so but that depend on stealing review time from peole to land it | 12:17 |
sean-k-mooney | it looks like artom has some concerns | 12:19 |
sean-k-mooney | so maybe not right away | 12:20 |
sean-k-mooney | mdbooth: are you asking for you patch that is in merge conflict | 12:20 |
mdbooth | sean-k-mooney: Well it was in merge conflict while the patch was landed, but is now no longer conflicting but I need to rebase anyway because it seems gerrit can't tell that. | 12:20 |
sean-k-mooney | ah well you might as well rebase | 12:21 |
*** Bidwe_jay77 has quit IRC | 12:21 | |
mdbooth | sean-k-mooney: https://youtu.be/N0BkjvUOtX4?t=29 | 12:21 |
sean-k-mooney | have you got any review on it lately | 12:22 |
mdbooth | sean-k-mooney: Yeah, a bit. | 12:22 |
*** Bidwe_jay87 has joined #openstack-nova | 12:22 | |
*** mrch_ has quit IRC | 12:23 | |
sean-k-mooney | hum i havent seen fifth element in a while | 12:23 |
*** Bidwe_jay has joined #openstack-nova | 12:24 | |
mdbooth | Me neither, but I love that film. Your comment just reminded me of the 'I have a doubt' scene :) | 12:24 |
*** davidsha has quit IRC | 12:43 | |
*** martinkennelly has quit IRC | 12:43 | |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: Ignore hw_vif_type for direct, direct-physical vNIC types https://review.opendev.org/667354 | 12:46 |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Ignore hw_vif_type for direct, direct-physical vNIC types https://review.opendev.org/667355 | 12:46 |
stephenfin | lyarwood: Could you take a look at those two ^ Clean backports, both of them | 12:47 |
lyarwood | stephenfin: ack sure | 12:49 |
*** mriedem has joined #openstack-nova | 12:50 | |
*** jangutter_ is now known as jangutter | 12:51 | |
*** ttsiouts has quit IRC | 12:55 | |
*** ttsiouts has joined #openstack-nova | 12:56 | |
artom|gmtplus3 | mdbooth, if I'm right it's not as simple as we thought | 12:57 |
artom|gmtplus3 | I'll let sean-k-mooney respond | 12:57 |
*** ttsiouts has quit IRC | 13:01 | |
*** mdbooth has quit IRC | 13:01 | |
*** mdbooth has joined #openstack-nova | 13:02 | |
sean-k-mooney | artom|gmtplus3: well i dont know why we would recive plug time event for same host resize of hybrid plug | 13:03 |
sean-k-mooney | the vif is already plugged and the binding host does not change | 13:03 |
artom|gmtplus3 | sean-k-mooney, I don't either, but it looks like we do | 13:03 |
*** luksky has joined #openstack-nova | 13:03 | |
*** ysandeep has quit IRC | 13:04 | |
*** dave-mccowan has joined #openstack-nova | 13:05 | |
*** ttsiouts has joined #openstack-nova | 13:06 | |
sean-k-mooney | for what its worth the patch i have up passed the same host reszie test in tempest | 13:06 |
mriedem | mgoddard: johnthetubaguy: i have a few questions in https://bugs.launchpad.net/nova/+bug/1833542 for what you want to see | 13:06 |
sean-k-mooney | it was tested by the neutron iptables hybird job | 13:06 |
openstack | Launchpad bug 1833542 in OpenStack Compute (nova) "No mechanism to wait for computes to update service version before restarting to remove RPC version cap after upgrade" [Wishlist,Triaged] | 13:06 |
mgoddard | mriedem: fire away | 13:06 |
sean-k-mooney | i have not had time to go through your comment properly and read the logs however | 13:06 |
artom|gmtplus3 | sean-k-mooney, it would, because I think it just don't wait for any events in case of same host resize | 13:08 |
sean-k-mooney | right it wont be considerd a plug time event so we wont wait | 13:08 |
sean-k-mooney | we would wait for plug time events | 13:09 |
mriedem | mgoddard: they are in the bug report, answer when you have time | 13:09 |
mriedem | mgoddard: mostly asking about what interface you need | 13:09 |
artom|gmtplus3 | sean-k-mooney, in fact, I don't think tests would pick it up at all - even migrate revert guest connectivity tests would succeed eventually, assuming everything went well | 13:10 |
artom|gmtplus3 | There'd just be a few seconds (dozens of seconds?) between instance boot and network connectivity being established | 13:10 |
mgoddard | mriedem: ah, got it. Have to head out soon but will respond | 13:11 |
mriedem | mgoddard: feel free to post to the ML for other ops to weigh in if they need something like this | 13:12 |
bauzas | mriedem: efried: I'm working on https://bugs.launchpad.net/nova/+bug/1793569 | 13:16 |
openstack | Launchpad bug 1793569 in OpenStack Compute (nova) "Add placement audit commands" [Wishlist,Confirmed] - Assigned to Sylvain Bauza (sylvain-bauza) | 13:16 |
*** whoami-rajat has quit IRC | 13:16 | |
bauzas | mriedem: efried: should we use the reportclient or just calling the placement API directly? | 13:17 |
efried | bauzas: looking... | 13:17 |
mriedem | i'm pretty sure the other nova-manage placement commands use the reportclient | 13:17 |
bauzas | they do, yet | 13:17 |
bauzas | yes* | 13:18 |
*** dave-mccowan has quit IRC | 13:18 | |
mriedem | so yeah just use that | 13:18 |
bauzas | ok | 13:18 |
efried | bauzas: agree | 13:18 |
bauzas | I was about to do this, but I wonder whether the placement folks would prefer to just use other clients | 13:19 |
efried | bauzas: All nova code should go through SchedulerReportClient to talk to Placement. | 13:19 |
efried | SchedulerReportClient should really be called PlacementClient or similar | 13:20 |
bauzas | k | 13:20 |
mriedem | right...nova doesn't have any other placement client | 13:20 |
mriedem | nor is there a python-placementclient | 13:20 |
mriedem | only the sdk | 13:20 |
*** ratailor has joined #openstack-nova | 13:21 | |
mriedem | keep in mind that if this is something you think your customers on older branches might want, you're best to not introduce a bunch of new dependencies here | 13:21 |
mriedem | unrelated, doesn't suse and red hat have docs writers that could verify the install guide issue mentioned here https://bugs.launchpad.net/nova/+bug/1833650 ? | 13:21 |
openstack | Launchpad bug 1833650 in OpenStack Compute (nova) "Populate nova databases failed with mysql access denied" [Undecided,New] - Assigned to Chason Chan (chen-xing) | 13:21 |
efried | Note that as soon as this [1] is approved, we can merge this [2] and this [3], and then we'll be using openstacksdk for placement -- but still via the SchedulerReportClient. | 13:21 |
efried | [1] https://review.opendev.org/#/c/662881/ | 13:21 |
efried | [2] https://review.opendev.org/#/c/643664/ | 13:21 |
efried | [3] https://review.opendev.org/#/c/656023/ | 13:21 |
*** mkrai_ has quit IRC | 13:24 | |
yonglihe | mriedem, Hi, good morning. | 13:26 |
mriedem | alex_xu: john hou has a major problem with your patch :) https://review.opendev.org/#/c/667061/ | 13:27 |
mriedem | so major in fact he -1ed without a comment | 13:27 |
mriedem | yonglihe: hi | 13:27 |
artom|gmtplus3 | mriedem, I suspect ours only have ooo-related deployment docs | 13:28 |
lyarwood | yup was just about to say, manual steps would be out of scope for them. Should be something we (devel) can help with however. | 13:28 |
lyarwood | I've asked our deployment folks to take a look | 13:30 |
mriedem | i thought i heard at one of the last face to face things that red hat had a docs writer working on cinder upstream so that's where i got the idea | 13:31 |
*** dave-mccowan has joined #openstack-nova | 13:32 | |
mriedem | smcginnis might have just been making it all up | 13:32 |
smcginnis | Lies, all lies. | 13:33 |
smcginnis | mriedem: There was someone at the Vancouver Forum that said he was new there and had a whole team that was going to be switching focus to be more upstream on docs. Never saw anything come of that though. | 13:33 |
*** brinzhang__ has quit IRC | 13:33 | |
mriedem | ok that's about the level of expectation i'd have... | 13:34 |
openstackgerrit | Merged openstack/nova master: doc: Fix nova-manage cell_v2 list_cells output https://review.opendev.org/666995 | 13:34 |
*** mkrai_ has joined #openstack-nova | 13:34 | |
lyarwood | yeah I think there is a push to upstream more of their stuff but even then, if we don't support it downstream I can't see them working on it upstream. | 13:35 |
lyarwood | stephenfin knows more about the docs team tbh | 13:35 |
mriedem | red hat doesn't support installing nova on control nodes? | 13:35 |
lyarwood | not manually no | 13:35 |
artom|gmtplus3 | Docs is... touchy? IIUC the argument for *not* upstreaming docs more is that docs is part of the added value that a RH sub brings | 13:35 |
mriedem | oh gotcha | 13:35 |
artom|gmtplus3 | But yeah, stephenfin's your man | 13:36 |
mriedem | yeah that's fine, i'm just looking for someone with time to validate the bug and the fix but it seems correct | 13:36 |
yonglihe | need another +2 to move forward https://review.opendev.org/#/c/658716/ | 13:37 |
mriedem | yonglihe: if you're asking me for ^ that's not really my area | 13:37 |
sean-k-mooney | mriedem: redhat requires OSP to be installed via osp director(triplo) for it to be supported form OSP13 (queens) on | 13:37 |
efried | yonglihe: I was hoping johnthetubaguy would be able to look at that one. | 13:37 |
mriedem | efried: yonglihe: and i was hoping sean would ack or nack it | 13:37 |
*** BjoernT has joined #openstack-nova | 13:37 | |
*** mriedem is now known as mriedem_afk | 13:38 | |
efried | mriedem_afk: The delta since sean-k-mooney's last +1 is negligible, I'm assuming he's still +1. | 13:38 |
yonglihe | mriedem: that's ok. Sean already given a +1. we discussed that and got concern resolved. | 13:38 |
sean-k-mooney | efried: on which ? | 13:38 |
efried | https://review.opendev.org/#/c/658716/ | 13:38 |
sean-k-mooney | oh the show numa stuff | 13:38 |
yonglihe | sean-k-mooney: i do got your +1, and alex's comment, while i address that. i got +2 from alex. | 13:39 |
sean-k-mooney | ya it still has one nit but im fine with it | 13:39 |
artom|gmtplus3 | yonglihe, efried, it's missing the Train history bit | 13:40 |
artom|gmtplus3 | (I realize this is the epitome of late nitpicking) | 13:40 |
sean-k-mooney | "pagesize_kb": 4096, shoudl still be 4 if they inteded it to be the defaul 4k pages | 13:40 |
artom|gmtplus3 | (It's jut that I thought it looked familiar, and scrolled down to history immediately) | 13:40 |
yonglihe | sean-k-mooney: your are right. i can fix it. | 13:41 |
sean-k-mooney | i dont think its worth anothr respin | 13:41 |
*** munimeha1 has joined #openstack-nova | 13:41 | |
sean-k-mooney | it can be fixed but alex has +2'd and its not really that important | 13:41 |
sean-k-mooney | provide we do it correctly in the code | 13:42 |
yonglihe | artom: it's reopen from S to D, so lost some history. | 13:42 |
yonglihe | S to T | 13:42 |
sean-k-mooney | so im happy to leave that as an implemenatin detail and assume you ment 4MB pages for the spec :) | 13:42 |
artom|gmtplus3 | yonglihe, yeah, no need to respin just for that, you have a +2 already | 13:42 |
efried | Normally I would probably feel fine proxying sean-k-mooney's vote as a +2, but that would be three Intels on paper, so I'd rather wait for another core. | 13:42 |
*** Conqueror has joined #openstack-nova | 13:43 | |
*** eharney has joined #openstack-nova | 13:44 | |
yonglihe | sean-k-mooney: sure. efried: yeah, i also think so. | 13:44 |
sean-k-mooney | johnthetubaguy: you previously were ok with https://review.opendev.org/#/c/658716/5 feel like being the final +2+w ? | 13:45 |
yonglihe | another patch 'clean up orphan instances' , https://review.opendev.org/#/c/627765/. From S to T, not got enough core force ever, is that patch so mass or mess ? It's lots of detail stuff, though. | 13:46 |
Conqueror | Hello everybody, I want to move VM from one project to another. How can I do that? I was googling and found the using nova-image download and nova-image create commands.. But, there should be an easier way to do this... | 13:47 |
dansmith | sean-k-mooney: I'll take a look at this | 13:47 |
sean-k-mooney | dansmith: you will love it amost as much as jay would | 13:48 |
*** openstackgerrit has quit IRC | 13:48 | |
dansmith | Conqueror: there's not | 13:49 |
dansmith | Conqueror: you can try this, but it's just a POC. Worked at some point, but buyer beware: https://github.com/kk7ds/oschown | 13:49 |
sean-k-mooney | oh speaking of ^ we were ment to propose moving that to openstack/oschown at somepoint | 13:50 |
yonglihe | dansmith, sean-k-mooney: thanks. | 13:50 |
sean-k-mooney | and then moving each module into the indeivgual projects and importing it via stevador | 13:51 |
*** Bidwe_jay65 has joined #openstack-nova | 13:51 | |
sean-k-mooney | i wonder if we ever opensed a bug/blueprint or somthing to track that so we dont have the same converstaion next time | 13:51 |
*** med_ has joined #openstack-nova | 13:51 | |
*** spatel has joined #openstack-nova | 13:52 | |
*** spatel has quit IRC | 13:52 | |
*** francoisp has joined #openstack-nova | 13:52 | |
*** shilpasd has quit IRC | 13:53 | |
*** Bidwe_jay has quit IRC | 13:54 | |
*** Bidwe_jay87 has quit IRC | 13:54 | |
Conqueror | dansmith, wow this looks very good :) | 13:57 |
dansmith | Conqueror: trust me, it's not :) | 13:57 |
Conqueror | dansmith, :D | 13:57 |
*** mkrai_ has quit IRC | 13:58 | |
*** mkrai__ has joined #openstack-nova | 13:58 | |
*** ratailor has quit IRC | 14:04 | |
efried | dansmith: on a resize, does the 'flavor' arg to migrate_disk_and_power_off represent the new size? | 14:08 |
efried | ...and the old size can be had via instance.flavor? | 14:09 |
*** openstackgerrit has joined #openstack-nova | 14:18 | |
openstackgerrit | Merged openstack/nova-specs master: add spec "show-server-numa-topology" https://review.opendev.org/658716 | 14:18 |
dansmith | efried: argument, probably, but I'd have to look.. efried instance has an old_flavor and new_flavor property during resize | 14:19 |
efried | dansmith: Based on what the libvirt driver is doing with it, it looks like instance.flavor is the old one and flavor is the new one. | 14:19 |
efried | thanks | 14:19 |
dansmith | efried: instance.flavor doesn't change until it changes I think, but old_flavor and new_flavor should be set | 14:20 |
efried | cool | 14:20 |
*** mriedem_afk is now known as mriedem | 14:20 | |
mriedem | migrate_disk_and_power_off happens in resize_instance on the source, right? | 14:20 |
efried | yes | 14:20 |
mriedem | pretty sure that code flips the instance.flavor to new_flavor before calling the driver | 14:20 |
mriedem | i have this code mostly memorized by now | 14:21 |
dansmith | I thought it was after poweroff | 14:21 |
efried | I don't actually need to know the details right now; just wanted to make sure both flavors are available in some form to the virt driver at the early stage of the resize. See ML. | 14:21 |
mriedem | oh i was thinking of this https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4686 | 14:21 |
mriedem | we do'nt update the instance.flavor to the new flavor until finish_resize on the dest | 14:22 |
dansmith | yeah, that's what I thought | 14:22 |
mriedem | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4550 | 14:22 |
mriedem | instance_type in that case is the new flavor | 14:22 |
mriedem | instance.flavor is still the old flavor | 14:22 |
efried | tldr: ironic could theoretically implement a super-restricted same-node-only 'resize' to twiddle tunables in their deploy template. | 14:22 |
mriedem | and instance.new_flavor is set before that https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4338 | 14:22 |
mriedem | well you don't even need the flavor to determine if it's the same host | 14:23 |
mriedem | we pass in the dest host, so you'd just check if dest_host == CONF.host | 14:23 |
mriedem | that doesn't tell you it's the same node... | 14:24 |
efried | okay, but they also need to be able to make sure that nothing has changed outside the limited subset of allowable changes | 14:24 |
efried | swhy they would need the flavors | 14:24 |
*** Dinesh_Bhor has joined #openstack-nova | 14:25 | |
efried | but yeah, also some way to know it's same-node. Maybe that part wouldn't be wrong to do in the cond/api | 14:25 |
mriedem | so...gonna plumb this all up through the api and everything just to eventually have the ironic driver check if the only thing changing in the new flavor is the deploy template and fail if not? | 14:25 |
efried | well, except the plumbing is already there, no? | 14:26 |
efried | basically all they have to do is implement two virt driver methods to make it work the dumb way | 14:26 |
mriedem | i wouldn't assume so | 14:26 |
efried | and yeah, late fail | 14:26 |
efried | but that's no different than e.g. libvirt failing if you try to downsize the eph disk | 14:26 |
mriedem | the api / controller is pretty opinionated that during a move operation the host:node relationship is 1:1 b/c we don't support moving baremetal instances | 14:26 |
mriedem | and you've got the CONF.allow_resize_to_same_host issues | 14:27 |
mnaser | eh, it looks like there is no nested virt trait eh? | 14:27 |
mriedem | which reminds me of https://bugs.launchpad.net/nova/+bug/1819216 but that's for cold migration | 14:27 |
openstack | Launchpad bug 1819216 in OpenStack Compute (nova) "in devstack, "nova migrate <uuid>" will try to migrate to the same host (and then fail)" [Medium,Triaged] | 14:27 |
efried | mnaser: wha? | 14:27 |
*** dpawlik has quit IRC | 14:27 | |
mnaser | not all of our hypervisors have been updated to have nested virt enabled (its disabled by default on rhel based hosts) | 14:28 |
mnaser | so i was hoping to create a flavor for a user so they always got a machine that had nested virt | 14:28 |
mnaser | (rather than building a host aggregate and trying to keep it sync'd) | 14:28 |
*** _alastor_ has joined #openstack-nova | 14:30 | |
mriedem | does HW_CPU_X86_VMX only show up on your nested virt enabled hosts? | 14:30 |
efried | sorry, this isn't going to be very helpful, but what does "nested virt" mean? | 14:30 |
mnaser | efried: oh sorry, it means enabling an option in kvm to expose the vmx flag to the virtual machine | 14:31 |
mnaser | so that it can start up kvm accelerated vms (instead of qemu emulated ones) | 14:31 |
kashyap | efried: It means you're running on "turtles all the way down" | 14:31 |
* efried has days like that | 14:31 | |
kashyap | It's only a part troll; as the original nested virt paper was titled that way | 14:31 |
mnaser | HW_CPU_X86_VMX will probably always be exposed on the host i assume (though libvirt can give you the answer if its enabled or not) | 14:31 |
dansmith | efried: it means... if random() % 10 < 4, segfault() | 14:31 |
kashyap | https://www.usenix.org/legacy/events/osdi10/tech/slides/ben-yehuda.pdf | 14:31 |
mnaser | lolol | 14:31 |
kashyap | Sorry, here's the paper: "The Turtles Project": https://www.usenix.org/legacy/event/osdi10/tech/full_papers/Ben-Yehuda.pdf | 14:32 |
artom|gmtplus3 | mnaser, are flavors with more than 1 NUMA node also in the pipeline? | 14:32 |
mnaser | it's actually been pretty stable in kata's ci (in our nested virt hosts) and doing nested virt on newer kernels is pretty well | 14:32 |
mnaser | artom|gmtplus3: in this case, no | 14:32 |
mnaser | but we've looked into it in the past :> | 14:32 |
mnaser | but yeah, im gonna guess HW_CPU_X86_VMX is probably exposed in all kvm hosts | 14:32 |
* mnaser checks | 14:32 | |
dansmith | I would expect the same, FWIW | 14:33 |
dansmith | I think those come from host caps | 14:33 |
kashyap | mnaser: Nit-pick: "nested virt" can mean QEMU or KVM in level-1 :-). I use nested KVM to distinguish the "no emulator" part. | 14:33 |
artom|gmtplus3 | mnaser, because I will be eternally grateful when they come :) | 14:33 |
mnaser | kashyap: oh cool, good to know | 14:33 |
mnaser | artom|gmtplus3: i'll keep that in mind then :) | 14:33 |
artom|gmtplus3 | mnaser, heh, I don't need to tell you how badly we're missing NUMA test coverage with real hardware :) | 14:34 |
kashyap | mnaser: So, as mriedem said, assuming you have 'nested' as '1' on bare metal, and then set the flavor property: | 14:35 |
*** Luzi has quit IRC | 14:35 | |
kashyap | openstack flavor set 1 --property trait:HW_CPU_X86_VMX=required` | 14:35 |
kashyap | Then launching the level-1 guest (or "guest hypervisor") should have VMX exposed | 14:35 |
mriedem | yonglihe: regarding https://review.opendev.org/#/c/627765/ i remember hearing at the ptg that there were concerns that it duplicated too much of _cleanup_running_deleted_instances and asked if it could just be integrated into _cleanup_running_deleted_instances with new choices for the running_deleted_instance_action option, but i'm not sure how feasible that is (or beneficial) | 14:35 |
kashyap | mnaser: dansmith: By the way GCE officially supports nested KVM; they've even done (in the community) extensive security audit, FWIW. | 14:37 |
dansmith | kashyap: omg, I'm convinced. | 14:37 |
kashyap | Good; otherwise, you need to show data for not being convinced ;-) | 14:38 |
dansmith | kashyap: you don't remember this, | 14:38 |
*** lpetrut has quit IRC | 14:38 | |
dansmith | but when I joined redhat almost six years ago, my first interaction with you was you saying this exact thing | 14:38 |
dansmith | that nested virt was 110% ready for prime time and you were fine if your bank ran it | 14:39 |
dansmith | don't make me dig up the logs, 'cause I'll do it! | 14:39 |
kashyap | I'm pretty confident I don't make such superlative remarks. Do dig them up | 14:40 |
kashyap | I used to systematically file kernel bugs since 2013 for nested KVM | 14:40 |
dansmith | superlatives are mine :) | 14:40 |
kashyap | And 98% of them are resolved (https://kashyapc.fedorapeople.org/kernel-kvm-bugs.txt) | 14:40 |
*** Dinesh_Bhor has quit IRC | 14:40 | |
kashyap | Sure, there are cases where it doesn't work; but what exists already works for good number of cases | 14:40 |
kashyap | Heck, even upstream kernel itself now has 'nested' flag enabled by default for Intel | 14:41 |
mnaser | ^ yeah, i've seen this updated lately too | 14:41 |
*** panda has quit IRC | 14:41 | |
sean-k-mooney | it was enabled in 4.19 ish | 14:41 |
sean-k-mooney | maybe a little earlier | 14:42 |
kashyap | [https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1e58e5e] | 14:42 |
kashyap | ["KVM: VMX: enable nested virtualization by default | 14:42 |
kashyap | ] | 14:42 |
sean-k-mooney | there were some bug in both the ubuntu kernel however until 4.20 | 14:42 |
sean-k-mooney | fedora was broken too | 14:43 |
sean-k-mooney | but the upstream on was fine | 14:43 |
dansmith | heh, Celebrated-By.. that's one I haven't seen | 14:43 |
*** panda has joined #openstack-nova | 14:43 | |
kashyap | dansmith: Then you will enjoy this: https://lwn.net/Articles/503829/ | 14:43 |
kashyap | A sample from the KM-long list: | 14:44 |
kashyap | - Bitten-by-and-tested-by: | 14:44 |
kashyap | - Antagonized-by: | 14:44 |
kashyap | - Fatfingered-by: | 14:44 |
kashyap | - Signed-off-and-morning-tea-spilled-by: | 14:44 |
dansmith | yup, nice | 14:44 |
*** mdbooth has quit IRC | 14:45 | |
artom|gmtplus3 | Drive-by: Shoo Ting | 14:45 |
kashyap | mnaser: Live migrating level-1 guest (level-2 can be migrated fine) is the remaining gnarly problem that is being worked on (both in KVM and QEMU) | 14:45 |
sean-k-mooney | so Most-Definitely-Acked-by: | 14:46 |
sean-k-mooney | Mostly-acked-by: | 14:46 |
sean-k-mooney | NACKed-by: | 14:46 |
sean-k-mooney | are used as +2 +1 and -1 | 14:46 |
sean-k-mooney | also i like More-or-less-tested-by | 14:46 |
mriedem | kashyap: what are the chances GCE has forked everything to make nested KVM work for just their cloud? | 14:47 |
dansmith | *gasp* | 14:48 |
dansmith | they would NEVER do such a thing, surely | 14:48 |
*** igordc has joined #openstack-nova | 14:49 | |
kashyap | mriedem: The chances are 100% sunny :D I see what you mean, they do have their kernel; that said ... they contribute most KVM-related stuff back to the upstream, and post results of security audit, too | 14:49 |
*** mdbooth has joined #openstack-nova | 14:49 | |
sean-k-mooney | mriedem: from my past experience with kvm it works beeter if you use a vanial upstream kernel then a disto packaged one although that has change in the last 12-18 months or so as i think distors have got better at testing nested virt or just break it less | 14:50 |
mriedem | hmm, me checks notes...sean says things from a distro are better since about the time he started working for a distro...yup it checks out | 14:52 |
sean-k-mooney | goes back to his ubunut based laptop... | 14:53 |
dansmith | mmm, ubunut | 14:53 |
dansmith | that has to be about the best ubuntu type I've seen | 14:53 |
sean-k-mooney | my devstack vms are centos | 14:53 |
dansmith | *typo, hah | 14:53 |
* artom|gmtplus3 is more impressed they can make laptops out of them | 14:54 | |
mriedem | did you know a cashew is not a nut? | 14:54 |
dansmith | artom|gmtplus3: like a fancy brazilian walnut laptop, or the *really* fancy "ubunut" laptop | 14:54 |
sean-k-mooney | :) | 14:54 |
*** mkrai_ has joined #openstack-nova | 14:55 | |
*** mkrai__ has quit IRC | 14:55 | |
*** udesale has quit IRC | 14:55 | |
sean-k-mooney | mriedem: that was most based on the fact that centos finally started to wrok with nested vert although canonica broke it in 18.04 which made me sad | 14:55 |
mriedem | lyarwood: just so you're aware, stable/stein and rocky are essentially blocked until these devstack changes land https://review.opendev.org/#/q/I0d7f9f2baaee2836a719f199939156bd4f53f778 | 14:55 |
artom|gmtplus3 | Oh, not the whole laptop, just the CPU: Hazwellnut architecture :D | 14:56 |
sean-k-mooney | haha i would totally by that | 14:56 |
lyarwood | mriedem: was that behind tempest-slow etc timing out due to the network tests taking ages? | 14:57 |
lyarwood | ah nvm it doesn't look like it is | 14:58 |
*** munimeha1 has quit IRC | 14:59 | |
mriedem | the agent on the tempest-slow jobs blows up | 15:00 |
lyarwood | ah I see | 15:01 |
lyarwood | well thanks for the heads up, I've had a tab open to look at that all day, I'll get on with some reviews once that has started to land in stable. | 15:02 |
sean-k-mooney | dansmith: im always amazed by how many grammer and spelling issue my brain just completely ignores | 15:04 |
dansmith | sean-k-mooney: and they make it really difficult for me to concentrate on the content.. diff'rent strokes. | 15:05 |
sean-k-mooney | ya, it just show how differently we read. not that you have pointed them out they are obvious but without your commets my brain just fills in the gaps/corrects them on the fly unless i force myself to read word by word really slowly | 15:07 |
artom|gmtplus3 | Yeah, there's a "severity" boundary where it switches from "distracting but harmless" to "active sabotage" | 15:08 |
jangutter | artom|gmtplus3: the late, great Iain M Banks had one of the most frustratingly good stories that tripped that balance in "Feersum Endjinn" | 15:10 |
mriedem | yay everything i had in the gate last night failed with RETRY_LIMIT and now i get to recheck everything | 15:10 |
artom|gmtplus3 | jangutter, will read | 15:10 |
sean-k-mooney | jangutter: im kind of tempted to read that | 15:12 |
jangutter | I think he's much more known for the Culture work, but FE was a good diversion. Just be warned that some chapters are physically hard to read, intentionally. | 15:14 |
sean-k-mooney | i have no issue reading "Woak up. Got dresd. Had brekfast. Spoke wif Ergates thi ant who sed itz juss been wurk wurk wurk 4 u lately master Bascule, Y dont u ½ a holiday? & I agreed & that woz how we decided we otter go 2 c Mr Zoliparia in thi I-ball ov thi gargoyle Rosbrith. " | 15:15 |
*** sapd1_x has joined #openstack-nova | 15:16 | |
*** lpetrut has joined #openstack-nova | 15:17 | |
efried | mriedem: would you please give this a quick look for sanity https://review.opendev.org/655985 before I invest in test? | 15:19 |
*** ccamacho has quit IRC | 15:22 | |
artom|gmtplus3 | sean-k-mooney, your brain is weird, I can barely parse that | 15:23 |
*** lpetrut has quit IRC | 15:23 | |
*** xek has quit IRC | 15:26 | |
sean-k-mooney | artom|gmtplus3: "Woke up. Got dressed. Had breakfast. spoke with Ergates the ant, who said, it's just been work work work for you lately master Bascule, why dont you have a holiday? And i aggred, an that was how we decied we ought to go to see Mr Zoliparia in the eye ball of the gargoyle Rosbrith." :) | 15:29 |
*** BjoernT_ has joined #openstack-nova | 15:29 | |
artom|gmtplus3 | sean-k-mooney, aha, thi = the didn't register at all | 15:29 |
artom|gmtplus3 | I was thinking "thy", the old English possessive | 15:29 |
*** yan0s has joined #openstack-nova | 15:30 | |
*** BjoernT has quit IRC | 15:30 | |
* artom|gmtplus3 -> done | 15:30 | |
sean-k-mooney | o/ | 15:30 |
*** igordc has quit IRC | 15:32 | |
*** xek has joined #openstack-nova | 15:34 | |
mriedem | efried: comments inline | 15:34 |
*** artom|gmtplus3 has quit IRC | 15:34 | |
*** jaosorior has quit IRC | 15:38 | |
*** jaosorior has joined #openstack-nova | 15:38 | |
*** ttsiouts has quit IRC | 15:39 | |
*** ttsiouts has joined #openstack-nova | 15:40 | |
*** sapd1_x has quit IRC | 15:40 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: (Re-)enable vnc console tests in nova-multi-cell job https://review.opendev.org/667388 | 15:42 |
*** xek has quit IRC | 15:43 | |
*** tssurya has quit IRC | 15:43 | |
*** ttsiouts has quit IRC | 15:44 | |
*** mkrai_ has quit IRC | 15:50 | |
*** mkrai__ has joined #openstack-nova | 15:50 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova stable/stein: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.opendev.org/667389 | 15:51 |
*** sapd1_x has joined #openstack-nova | 15:51 | |
*** hamzy has quit IRC | 15:54 | |
*** rajinir has joined #openstack-nova | 15:55 | |
*** damien_r has quit IRC | 16:00 | |
*** luksky has quit IRC | 16:00 | |
*** BjoernT has joined #openstack-nova | 16:00 | |
*** sapd1_x has quit IRC | 16:02 | |
*** BjoernT_ has quit IRC | 16:02 | |
*** udesale has joined #openstack-nova | 16:03 | |
*** igordc has joined #openstack-nova | 16:04 | |
*** yan0s has quit IRC | 16:05 | |
*** mkrai__ has quit IRC | 16:05 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Functional reproduce for bug 1833581 https://review.opendev.org/667396 | 16:09 |
openstack | bug 1833581 in OpenStack Compute (nova) "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer) | 16:09 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Error out interrupted builds https://review.opendev.org/666857 | 16:09 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Functional reproduce for bug 1833581 https://review.opendev.org/667397 | 16:09 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enhance service restart in functional env https://review.opendev.org/512552 | 16:11 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add functional test coverage for bug 1724172 https://review.opendev.org/512553 | 16:11 |
openstack | bug 1724172 in OpenStack Compute (nova) rocky "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Medium,Confirmed] https://launchpad.net/bugs/1724172 | 16:11 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Functional reproduce for bug 1833581 https://review.opendev.org/667396 | 16:12 |
openstack | bug 1833581 in OpenStack Compute (nova) "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer) | 16:12 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/667164 | 16:13 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation https://review.opendev.org/667165 | 16:13 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Error out interrupted builds https://review.opendev.org/666857 | 16:14 |
stephenfin | dansmith: Want to take another look through this? https://review.opendev.org/#/c/666629/ | 16:16 |
*** maciejjozefczyk has quit IRC | 16:21 | |
*** belmoreira has quit IRC | 16:24 | |
dansmith | stephenfin: will in a bit | 16:29 |
stephenfin | no rush | 16:30 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove no longer required "inner" methods. https://review.opendev.org/655282 | 16:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.opendev.org/635431 | 16:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.opendev.org/635433 | 16:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Privsep the ebtables modification code. https://review.opendev.org/635435 | 16:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.opendev.org/635436 | 16:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.opendev.org/636508 | 16:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.opendev.org/639280 | 16:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.opendev.org/639281 | 16:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.opendev.org/639282 | 16:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Move setting of device trust to privsep. https://review.opendev.org/639283 | 16:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Move final bridge commands to privsep. https://review.opendev.org/639580 | 16:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.opendev.org/639581 | 16:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: We no longer need rootwrap. https://review.opendev.org/554438 | 16:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.opendev.org/639826 | 16:31 |
efried | thanks mriedem | 16:33 |
*** ricolin has quit IRC | 16:33 | |
*** tesseract has quit IRC | 16:35 | |
*** tesseract has joined #openstack-nova | 16:36 | |
mriedem | efried: how do you feel about having a mini personal goal of making https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L985-L997 obsolete for in-tree drivers so we could deprecate or remove it in Train - out of tree drivers could be hit so if we wanted to be nice we'd just log a deprecation warning in T and remove in U | 16:41 |
mriedem | the only in-tree drivers that would hit those paths are xenapi and hyperv, | 16:41 |
mriedem | the former implements get_inventory, | 16:41 |
mriedem | the latter implements neither get_inventory or upt | 16:41 |
mriedem | oh looky here the hyperv out of tree driver has upt implemented https://opendev.org/openstack/compute-hyperv/src/branch/master/compute_hyperv/nova/driver.py#L464 | 16:43 |
efried | mriedem: I'm big in favor of this. At some point I looked into doing it myself, but it (possibly hyperv) was going to be hairier than I was ready to deal with at that time. | 16:44 |
efried | mriedem: by "personal" you mean me or you? :P | 16:46 |
efried | stephenfin: I should wait to re-look at rootwrap series, yes? | 16:46 |
*** panda has quit IRC | 16:46 | |
mriedem | efried: as in something we call each other about late on a friday night to talk about yes | 16:47 |
efried | stephenfin: The 'done' on the ipv4 patch is still forthcoming? | 16:47 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix update_provider_tree signature in reference docs https://review.opendev.org/667408 | 16:47 |
stephenfin | efried: 2 secs | 16:47 |
efried | mriedem: ack, I like it. | 16:47 |
stephenfin | Actually, I want to test this more so I'll leave it til the morning | 16:48 |
*** panda has joined #openstack-nova | 16:48 | |
stephenfin | efried: Sort of. I'm going to drop the first patch and then address the open TODOs in the remainder. If you want to take a look at any you haven't reviewed yet though, that could be helpful | 16:48 |
efried | something weird just happened | 16:49 |
stephenfin | Ohh, that's interesting | 16:50 |
stephenfin | I Ctrl + C'd git-review during the upload once I realized I'd more work to do | 16:50 |
efried | bot didn't notify, and when I look at the review it seems... corrupted. | 16:50 |
efried | the series isn't showing up on the right | 16:51 |
stephenfin | Feck it, I'll push it again just to fix that | 16:51 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.opendev.org/635431 | 16:51 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.opendev.org/635433 | 16:51 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Privsep the ebtables modification code. https://review.opendev.org/635435 | 16:51 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.opendev.org/635436 | 16:51 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.opendev.org/636508 | 16:51 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.opendev.org/639280 | 16:51 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.opendev.org/639281 | 16:51 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.opendev.org/639282 | 16:51 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Move setting of device trust to privsep. https://review.opendev.org/639283 | 16:51 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Move final bridge commands to privsep. https://review.opendev.org/639580 | 16:51 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.opendev.org/639581 | 16:51 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: We no longer need rootwrap. https://review.opendev.org/554438 | 16:51 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.opendev.org/639826 | 16:51 |
*** admin0 has joined #openstack-nova | 16:52 | |
efried | that seems to have worked. | 16:53 |
stephenfin | Indeed | 16:53 |
stephenfin | and with that | 16:53 |
efried | why did you drop the bottom patch? | 16:53 |
sean-k-mooney | thats strang it should not have currpted it | 16:53 |
* stephenfin -> 🏡 | 16:53 | |
stephenfin | efried: It seemed like you didn't want it https://review.opendev.org/#/c/655282/ | 16:53 |
efried | stephenfin: just one piece of it. The rest was good. | 16:54 |
efried | anyway, can do it elsewhere in the series | 16:54 |
stephenfin | Ah, then I can come back and stick that back in higher up in the series | 16:54 |
efried | ++ thanks stephenfin | 16:54 |
*** igordc has quit IRC | 16:56 | |
*** tesseract has quit IRC | 16:59 | |
*** igordc has joined #openstack-nova | 16:59 | |
*** udesale has quit IRC | 17:07 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement update_provider_tree https://review.opendev.org/667417 | 17:11 |
*** hamzy has joined #openstack-nova | 17:12 | |
*** ralonsoh has quit IRC | 17:20 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Clean up test_virtapi https://review.opendev.org/667419 | 17:24 |
*** ociuhandu has joined #openstack-nova | 17:41 | |
*** ociuhandu_ has quit IRC | 17:44 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Add rbd_connect_timeout configurable https://review.opendev.org/667421 | 17:44 |
*** ociuhandu has quit IRC | 17:45 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Multiple API cleanup changes https://review.opendev.org/666889 | 18:05 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: xenapi: implement update_provider_tree https://review.opendev.org/667435 | 18:29 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: xenapi: implement update_provider_tree https://review.opendev.org/667435 | 18:32 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova stable/rocky: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.opendev.org/667436 | 18:39 |
*** luksky has joined #openstack-nova | 18:53 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Deprecate non-update_provider_tree compat code https://review.opendev.org/667442 | 18:54 |
mriedem | efried: thoughts on only logging the warning on startup in ^ or every update_available_resource periodic? | 18:55 |
mriedem | the latter would be really chatty, but maybe that's the level of annoying we want | 18:55 |
*** hongbin has joined #openstack-nova | 19:02 | |
NewBruce | evening all! mriedem have you seen this issue before mate? | 19:11 |
NewBruce | 2019-06-25 20:47:45.167 166805 INFO nova.compute.manager [req-bda9173a-31ed-447f-bf57-3ad85c565141 - - - - -] [instance: 5123fa51-512f-4f13-ae4b-5bbc7dd64e94] Migrating instance to cc-compute25-sto2 finished successfully. | 19:11 |
NewBruce | 2019-06-25 20:47:45.302 166805 WARNING nova.virt.libvirt.driver [req-bda9173a-31ed-447f-bf57-3ad85c565141 - - - - -] [instance: 5123fa51-512f-4f13-ae4b-5bbc7dd64e94] Error monitoring migration: Compute host cc-compute04-sto2 could not be found.: ComputeHostNotFound: Compute host cc-compute04-sto2 could not be found. | 19:11 |
*** mlavalle has joined #openstack-nova | 19:12 | |
NewBruce | got me stumped…. and why always me and migration issues? :) | 19:12 |
NewBruce | the instance is migrated, but is left in status ERROR | 19:12 |
*** cfriesen has joined #openstack-nova | 19:15 | |
*** mriedem has quit IRC | 19:15 | |
*** mriedem has joined #openstack-nova | 19:16 | |
*** lpetrut has joined #openstack-nova | 19:18 | |
NewBruce | Not sure if its related, but the source node is throwing this error… a lot | 19:21 |
NewBruce | File "/openstack/venvs/nova-18.0.0/lib/python2.7/site-packages/oslo_utils/timeutils.py", line 68, in parse_isotime | 19:21 |
NewBruce | raise ValueError(six.text_type(e)) | 19:21 |
NewBruce | ValueError: year is out of range | 19:21 |
*** lpetrut has quit IRC | 19:23 | |
Nick_A | why is nova (?) metadata sending all /24 routes in a region to each instance? http://paste.openstack.org/show/y0lE42EA59yhnu7G1KnY/ | 19:36 |
*** pcaruana has quit IRC | 19:38 | |
mriedem | bauzas: dansmith: i take it from the comments here https://github.com/openstack/nova/blob/master/nova/objects/compute_node.py#L150 that one shouldn't rely on ComputeNode.service_id is that correct? | 19:39 |
mriedem | the Service object has a compute_node field, and ComputeNode has a nullable service_id | 19:39 |
mriedem | but it looks like neither should really be used... | 19:39 |
dansmith | um, I dunno | 19:39 |
*** factor has joined #openstack-nova | 19:39 | |
*** icarusfactor has quit IRC | 19:40 | |
mriedem | ala https://github.com/openstack/nova/commit/551be2c52a29cb2755de4825a3fcb2c8f7d7b3f1 and https://github.com/openstack/nova/commit/0b177f18264ca842e16c2c989a081e773b3d86b7 | 19:40 |
mriedem | ok, lots of really old compat notes from bauzas in all of that code | 19:40 |
mriedem | going back to kilo/liberty era | 19:41 |
mriedem | wonder if we'll ever clean that stuff up | 19:41 |
dansmith | yeah, | 19:41 |
dansmith | I'd think that that comment is probably old and that a migration fixed the ambiguity long ago, but.. I haven't looked | 19:41 |
mriedem | https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L123 | 19:43 |
mriedem | i don't think there was ever a migration | 19:43 |
mriedem | just lots of todos from ~liberty | 19:44 |
dansmith | hrm | 19:45 |
mriedem | ok i'd think the migration would be pretty simple, | 19:45 |
mriedem | iterate cells looking for compute_nodes where host is null | 19:46 |
mriedem | if so, find their service record and update the compute_nodes.host value | 19:46 |
mriedem | or a migration run per-cell (we haven't really be consistent there) | 19:46 |
dansmith | or just have computes update compute nodes on RT update | 19:46 |
dansmith | no reason to make it a manual-only thing | 19:47 |
mriedem | yeah i don't think it's even possible to get through RT with a cn that doesn't have a host value set | 19:48 |
mriedem | we lookup the cn by host and node and if it doesn't exist we create it and always have those values set now | 19:48 |
mriedem | so...maybe this is as good as a simple nova-status upgrade check to sniff out anything lingering and in U drop all of this compat code | 19:48 |
dansmith | sure | 19:48 |
mriedem | not sure we'd want to do the db alter table statements to make the column non-nullable... | 19:48 |
mriedem | but that's less of an issue | 19:48 |
efried | mriedem: upt also gets called on spawn & delete, doesn't it? | 20:03 |
efried | via update_available_resource | 20:03 |
*** bbowen has quit IRC | 20:03 | |
mriedem | efried: i don't think so, you're thinking of instance_claim | 20:05 |
efried | okay | 20:05 |
mriedem | and rt.update_usage | 20:06 |
mriedem | ^ is the one that has the vm_state check for DELETED/SHELVED_OFFLOADED on the instance and if it's one of those it removes the usage | 20:06 |
mriedem | looks like _post_live_migration also hits update_available_resource for kicks | 20:07 |
mriedem | presumably b/c we don't do rt claims for live migration | 20:08 |
efried | okay, so chattier than just once every 10 minutes. | 20:12 |
sean-k-mooney | mriedem: well we do in some cases | 20:14 |
sean-k-mooney | mriedem: we claim pci devices for the sriov case and we will claim cpus and hugepages once artoms numa migration code lands | 20:14 |
mriedem | update_available_resource is once per minute i think | 20:15 |
mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.update_resources_interval | 20:15 |
mriedem | https://github.com/openstack/oslo.service/blob/master/oslo_service/periodic_task.py#L31 | 20:15 |
sean-k-mooney | its configurable in the config but i thought it was 300 seconds | 20:16 |
mriedem | i think you're both high on goofballs | 20:16 |
mriedem | efried: so every minute by default | 20:17 |
sean-k-mooney | on no its 60s you are right https://docs.openstack.org/nova/latest/configuration/config.html#scheduler.periodic_task_interval | 20:17 |
sean-k-mooney | oh wait is that only set for the schduler ? i though we had a compute node version too? | 20:18 |
*** factor has quit IRC | 20:20 | |
*** factor has joined #openstack-nova | 20:21 | |
*** ohwhyosa- has quit IRC | 20:24 | |
*** ivve has quit IRC | 20:24 | |
* mriedem hangs head | 20:24 | |
mriedem | what are you asking | 20:24 |
mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.update_resources_interval is used by the ComputeManager.update_available_resource periodic task | 20:24 |
*** francoisp has quit IRC | 20:25 | |
*** factor has quit IRC | 20:31 | |
*** factor has joined #openstack-nova | 20:32 | |
*** hamzy has quit IRC | 20:33 | |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models https://review.opendev.org/642030 | 20:40 |
*** factor has quit IRC | 20:52 | |
*** factor has joined #openstack-nova | 20:52 | |
*** ttsiouts has joined #openstack-nova | 20:55 | |
*** factor has quit IRC | 20:59 | |
*** slaweq has quit IRC | 20:59 | |
*** slaweq has joined #openstack-nova | 21:11 | |
*** slaweq has quit IRC | 21:15 | |
*** openstackgerrit has quit IRC | 21:18 | |
*** ttsiouts has quit IRC | 21:22 | |
*** ttsiouts has joined #openstack-nova | 21:22 | |
*** slaweq has joined #openstack-nova | 21:26 | |
*** ttsiouts has quit IRC | 21:27 | |
*** slaweq has quit IRC | 21:31 | |
*** factor has joined #openstack-nova | 21:37 | |
*** openstackgerrit has joined #openstack-nova | 21:38 | |
openstackgerrit | sean mooney proposed openstack/nova-specs master: add libvirt pqos spec https://review.opendev.org/662264 | 21:38 |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Add spec for expose-auto-converge-post-copy https://review.opendev.org/651681 | 21:39 |
*** jaypipes has quit IRC | 21:46 | |
*** tobberydberg has quit IRC | 21:49 | |
*** tobberydberg has joined #openstack-nova | 21:51 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add placement request filter for disabled computes https://review.opendev.org/654596 | 21:52 |
*** mriedem has quit IRC | 21:52 | |
*** rdopiera has quit IRC | 22:02 | |
*** _erlon_ has quit IRC | 22:18 | |
*** BjoernT has quit IRC | 22:23 | |
*** sean-k-mooney has quit IRC | 22:31 | |
*** luksky has quit IRC | 22:34 | |
*** mlavalle has quit IRC | 22:40 | |
*** sapd1_x has joined #openstack-nova | 22:41 | |
*** bbowen has joined #openstack-nova | 22:48 | |
*** tkajinam has joined #openstack-nova | 22:56 | |
*** rcernin has joined #openstack-nova | 23:05 | |
*** hongbin has quit IRC | 23:07 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!