Monday, 2019-07-01

« Sunday, 2019-06-30 Index Tuesday, 2019-07-02 »
adriantis there any documentation on what the difference (from a Nova perspective) of a volume snapshot vs an instance snapshot? I'm trying to figure out what workflow behind instance action 'createImage'00:00
adriantFrom what I can tell, if the instance is backed by a persistent volume, it creates a volume snapshot for me00:00
adriantif the instance is backed by an ephemeral volume it triggers the creation of an image (instance snapshot is what the horizon gui calls it).00:01
adriantI've also been told that '00:02
adriantthat an 'instance snapshot' also somehow can take into account multiple volumes attached to an instance and include all of that into a single snapshot, but that functionality isn't documented anywhere, or is it specific to certain volume drivers?00:03
*** brinzhang has joined #openstack-nova00:37
*** efried has joined #openstack-nova00:43
*** ricolin has joined #openstack-nova01:04
*** imacdonn has quit IRC01:10
*** imacdonn has joined #openstack-nova01:11
*** yonglihe has joined #openstack-nova01:30
*** tinwood has quit IRC02:08
*** tinwood has joined #openstack-nova02:10
*** yaawang has joined #openstack-nova02:11
*** sapd1_x has joined #openstack-nova03:02
*** BjoernT has joined #openstack-nova03:10
*** tbachman has quit IRC03:21
*** yaawang has quit IRC03:36
*** yaawang has joined #openstack-nova03:36
*** psachin has joined #openstack-nova03:39
*** tbachman has joined #openstack-nova03:42
*** sapd1_x has quit IRC04:01
*** BjoernT has quit IRC04:07
*** BjoernT has joined #openstack-nova04:09
*** hoonetorg has quit IRC04:16
*** BjoernT has quit IRC04:19
*** ratailor has joined #openstack-nova04:30
*** hoonetorg has joined #openstack-nova04:34
*** bhagyashris has joined #openstack-nova04:55
*** ricolin_ has joined #openstack-nova05:03
*** ricolin has quit IRC05:06
*** udesale has joined #openstack-nova05:18
*** bhagyashris has quit IRC05:39
*** ociuhandu has joined #openstack-nova05:40
*** rpittau|mtg is now known as rpittau|afk05:49
*** ociuhandu has quit IRC05:53
*** ociuhandu has joined #openstack-nova05:54
*** ociuhandu has quit IRC05:57
*** ociuhandu has joined #openstack-nova05:58
*** udesale has quit IRC05:59
*** ricolin_ has quit IRC06:09
*** ricolin has joined #openstack-nova06:09
openstackgerritArtom Lifshitz proposed openstack/nova master: Add neutron-tempest-iptables_hybrid job to experimental queue  https://review.opendev.org/66715406:12
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug  https://review.opendev.org/66717706:12
*** dpawlik has joined #openstack-nova06:15
*** maciejjozefczyk has joined #openstack-nova06:26
*** luksky has joined #openstack-nova06:28
*** ociuhandu has quit IRC06:36
*** bhagyashris_ has joined #openstack-nova06:41
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug  https://review.opendev.org/66717706:46
*** slaweq has joined #openstack-nova06:48
*** ccamacho has joined #openstack-nova06:50
*** ccamacho has quit IRC06:50
*** ccamacho has joined #openstack-nova06:50
*** rcernin has quit IRC06:55
*** damien_r has joined #openstack-nova07:02
*** ivve has joined #openstack-nova07:05
*** xek has joined #openstack-nova07:05
*** tesseract has joined #openstack-nova07:10
*** tssurya has joined #openstack-nova07:29
*** rdopiera has joined #openstack-nova07:33
*** ttsiouts has joined #openstack-nova07:38
*** pcaruana has joined #openstack-nova07:43
*** rpittau|afk is now known as rpittau07:44
*** ttsiouts has quit IRC07:49
*** helenafm has joined #openstack-nova07:49
*** ttsiouts has joined #openstack-nova07:49
*** mrch_ has quit IRC07:51
*** ralonsoh has joined #openstack-nova07:52
*** ttsiouts has quit IRC07:54
*** jangutter has joined #openstack-nova08:11
*** ttsiouts has joined #openstack-nova08:16
gibistephenfin: hi! could you please look back to https://review.opendev.org/#/c/641679/ ? you were +2 before08:18
*** tkajinam has quit IRC08:35
*** ricolin_ has joined #openstack-nova08:45
*** ricolin_ has quit IRC08:47
*** ricolin_ has joined #openstack-nova08:47
*** ricolin has quit IRC08:48
*** udesale has joined #openstack-nova08:55
kashyapgibi: Hi, can you ACK|NACK this stable/rocky backport, please? -- https://review.opendev.org/#/c/667436/ (libvirt: Rework 'EBUSY' (SIGKILL) error handling code path)09:06
kashyapIt already has a +2.  (And FWIW, its stable/queens counterpart is merged.)09:06
*** ricolin_ is now known as ricolin09:07
gibikashyap: I have no +2 power on stable, but the backport looks OK to me09:08
kashyapgibi: Hmm, very bizarre; johnthetubaguy ^  Want to put the stable/rocky one, too?09:08
gibikashyap: and I think you ment stable/stain counterpart :)09:08
kashyapgibi: Err, indeed :-)09:09
johnthetubaguyI can take a peak09:09
gibikashyap: this is the stable core group https://review.opendev.org/#/admin/groups/540,members09:09
kashyapYeah, saw that09:09
kashyapjohnthetubaguy: Thanks; you ACKed one of the backports09:09
kashyapjohnthetubaguy: Also, I'm almost done through reworking the OVMF spec, hope to push out a new version EOD or tomm.  Want to get it past the "finish line"09:10
kashyap(Addressing your feedback, i.e.)09:10
johnthetubaguykashyap: ah, cool, it is spec review day tomorrow, although I am on a train to bristol and all day meeting tomorrow, so going through stuff today09:11
kashyapjohnthetubaguy: Oh, okay; is tomm the last deadline or what for specs?09:12
kashyapRegardless, /me will work through it.  Was busy with some downstream stuff09:12
johnthetubaguymore just a big push, that you might want to get cought up in, if you can09:12
johnthetubaguykashyap: no worries, we all know that feeling of being pulled in 12 directions09:13
* kashyap nods; sure I guessed you'd relate to :-)09:14
johnthetubaguyactually little francis literately pulls at my leg now when he decides I am not listening09:14
kashyapHehe09:14
*** takashin has quit IRC09:18
openstackgerritpengyuesheng proposed openstack/python-novaclient master: Add Python 3 Train unit tests  https://review.opendev.org/66839509:18
*** ricolin has quit IRC09:20
openstackgerritpengyuesheng proposed openstack/python-novaclient master: Blacklist sphinx 2.1.0 (autodoc bug)  https://review.opendev.org/66839809:20
*** mdbooth has joined #openstack-nova09:22
*** brinzhang has quit IRC09:22
*** brinzhang has joined #openstack-nova09:23
*** mrch_ has joined #openstack-nova09:35
*** bhagyashris_ has quit IRC09:42
*** adrianreza has quit IRC09:48
*** whoami-rajat has joined #openstack-nova09:52
*** ociuhandu has joined #openstack-nova09:55
*** cdent has joined #openstack-nova09:55
*** ociuhandu has quit IRC10:00
*** ociuhandu has joined #openstack-nova10:01
*** ysandeep has joined #openstack-nova10:08
ysandeep#openstack-nova, Is there OpenStack cli alternative for this command "nova boot --flavor m1.medium --block-device source=image,id=<image-id>,dest=volume,size=10,shutdown=preserve,bootindex=0 --nic net-id=<net-id> --key-name mykey test_instance"10:09
*** brault has joined #openstack-nova10:17
*** jaosorior has joined #openstack-nova10:17
*** ttsiouts has quit IRC10:19
*** ttsiouts has joined #openstack-nova10:20
*** tbachman has quit IRC10:21
*** ttsiouts has quit IRC10:25
openstackgerritMerged openstack/nova master: Add integration testing for heal_allocations  https://review.opendev.org/66799410:37
*** brtknr has quit IRC10:41
*** tbachman has joined #openstack-nova10:41
*** brtknr has joined #openstack-nova10:42
tssuryabauzas: stable stein easy review if you have time - https://review.opendev.org/#/c/667948/10:46
tssuryaand the corresponding rocky one: https://review.opendev.org/#/c/667955/110:46
*** yaawang has quit IRC10:51
*** brtknr has quit IRC10:53
*** brtknr has joined #openstack-nova10:53
*** brault has quit IRC11:05
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug  https://review.opendev.org/66717711:06
*** brault has joined #openstack-nova11:06
*** takashin has joined #openstack-nova11:06
*** avolkov has joined #openstack-nova11:11
*** pcaruana has quit IRC11:36
*** yaawang has joined #openstack-nova11:40
*** tbachman has quit IRC11:44
*** luksky has quit IRC11:46
*** takashin has quit IRC11:49
*** ttsiouts has joined #openstack-nova11:50
*** jaosorior has quit IRC11:56
*** jaosorior has joined #openstack-nova11:56
*** jaosorior has quit IRC11:57
*** jaosorior has joined #openstack-nova11:57
*** takashin has joined #openstack-nova11:58
*** ratailor has quit IRC12:01
*** luksky has joined #openstack-nova12:37
*** eharney has quit IRC12:38
*** ysandeep has quit IRC12:38
openstackgerritBrin Zhang proposed openstack/nova master: Specify availability_zone to unshelve  https://review.opendev.org/66385112:53
*** cdent has quit IRC12:55
*** ttsiouts has quit IRC13:00
*** lbragstad has joined #openstack-nova13:00
*** takashin has left #openstack-nova13:00
*** ttsiouts has joined #openstack-nova13:01
*** cdent has joined #openstack-nova13:01
*** jaosorior has quit IRC13:03
*** jaosorior has joined #openstack-nova13:03
*** ttsiouts has quit IRC13:05
*** tbachman has joined #openstack-nova13:11
*** ttsiouts has joined #openstack-nova13:14
*** eharney has joined #openstack-nova13:15
openstackgerritya.wang proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models  https://review.opendev.org/64203013:21
openstackgerritya.wang proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models  https://review.opendev.org/64203013:22
openstackgerritBrin Zhang proposed openstack/nova master: Specify availability_zone to unshelve  https://review.opendev.org/66385113:24
*** BjoernT has joined #openstack-nova13:27
*** mriedem has joined #openstack-nova13:27
*** amodi has joined #openstack-nova13:30
*** BjoernT_ has joined #openstack-nova13:33
*** BjoernT has quit IRC13:34
openstackgerritMatt Riedemann proposed openstack/nova stable/ocata: Handle HostMappingNotFound when deleting a compute service  https://review.opendev.org/66687213:45
openstackgerritMatt Riedemann proposed openstack/nova stable/ocata: Delete resource providers for all nodes when deleting compute service  https://review.opendev.org/66687413:45
lyarwoodmriedem: https://review.opendev.org/#/c/668123/ - would you mind hitting that today if you have time?13:47
openstackgerritMerged openstack/nova stable/stein: Grab fresh power state info from the driver  https://review.opendev.org/66794813:48
*** dpawlik has quit IRC14:05
bauzastssurya: ack14:06
*** pcaruana has joined #openstack-nova14:06
*** belmoreira has joined #openstack-nova14:07
mriedemlyarwood: yeah i have a tab open for it already; i was wondering if it should wait until after the next queens release because i just did a rocky release and queens was next14:16
mriedemi.e. might be good to only release things in queens that have already been released in rocky already14:17
lyarwoodmriedem: ah yeah that's fair14:19
*** hemna has quit IRC14:22
kashyapI'm feeling stupid, can anyone tell why is this stable/rocky backport Zuul -2? -- https://review.opendev.org/#/c/667436/14:22
kashyap(It's cherry-picked from master; and it's merged.)14:23
*** hemna has joined #openstack-nova14:29
mriedemtempest-slow FAILURE in 2h 06m 01s14:29
openstackgerritMartin Midolesov proposed openstack/nova master: Implementing graceful shutdown.  https://review.opendev.org/66624514:32
*** mlavalle has joined #openstack-nova14:34
*** udesale has quit IRC14:34
*** udesale has joined #openstack-nova14:34
*** dklyle has joined #openstack-nova14:37
openstackgerritBalazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations  https://review.opendev.org/63795514:49
openstackgerritBalazs Gibizer proposed openstack/nova master: WIP: Add rollback to heal port allocation  https://review.opendev.org/66818414:49
*** mrch_ has quit IRC14:49
*** belmoreira has quit IRC14:53
*** rajinir has joined #openstack-nova14:55
*** pcaruana has quit IRC14:56
*** belmoreira has joined #openstack-nova15:01
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Disable limit if affinity(anti)/same(different)host is requested  https://review.opendev.org/65924615:02
*** tbachman has quit IRC15:04
kashyapmriedem: Thanks!  I'm blinder than a mole.15:08
kashyapGuess it's one of those fully useful timeouts.15:08
*** factor has joined #openstack-nova15:09
*** icarusfactor has quit IRC15:10
*** BjoernT_ is now known as BjoernT15:10
*** icarusfactor has joined #openstack-nova15:11
*** factor has quit IRC15:11
*** tbachman has joined #openstack-nova15:13
*** factor has joined #openstack-nova15:14
*** icarusfactor has quit IRC15:15
*** mvkr has quit IRC15:17
*** ricolin has joined #openstack-nova15:20
*** icarusfactor has joined #openstack-nova15:21
*** factor has quit IRC15:24
mriedemlyarwood: can you take a look at these queens backports? https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/queens+topic:bug/183074715:27
*** damien_r has quit IRC15:27
*** ivve has quit IRC15:30
*** tbachman has quit IRC15:31
openstackgerritMerged openstack/python-novaclient master: Blacklist sphinx 2.1.0 (autodoc bug)  https://review.opendev.org/66839815:32
mriedemneed another non-lee stable core for this queens backport https://review.opendev.org/#/c/662471/15:35
*** jaosorior has quit IRC15:42
*** ttsiouts has quit IRC15:49
*** ttsiouts has joined #openstack-nova15:49
openstackgerritBalazs Gibizer proposed openstack/nova master: WIP: Add rollback to heal port allocation  https://review.opendev.org/66818415:50
gibimriedem: what do you prefer? Should I squash the rollback code ^^ into the heal port allocation patch or keep it separate15:51
*** weshay is now known as weshay_PTO15:52
*** tssurya has quit IRC15:52
*** helenafm has quit IRC15:53
*** pcaruana has joined #openstack-nova15:53
*** ttsiouts has quit IRC15:54
mriedemgibi: we can drop the code in the original change that generates the list of manual commands to run if we have the rollback stuff right?15:54
gibimriedem: no, we have to tell the admin what to do when whe rollback fails15:55
mriedemi'd prefer that we rollback and drop the manual list of commands that get generated if possible15:55
gibimriedem: I mean I can drop it from the original patch and re-introduce it in the rollback patch15:55
gibiif you prefer15:56
*** luksky has quit IRC15:56
mriedemto be clear, the only manual set of commands you plan on dumping are for the port update rollbacks, right? not the thing for the allocations.15:58
mriedembecause now we'll be doing: 1. port updates - if good, put allocations, else rollback port updates, 2. if put allocations is good, we're done for that instance, else rollback port updates15:59
gibicommands are only for cleaning the allocation key from the binding:profile15:59
efriedI was thinking, does it cost us anything to *gather* those CLIs? Would be useful to print them if you selected --don't-heal-port-allocations-I'll-do-it-myself16:00
mriedemright so we don't need https://review.opendev.org/#/c/637955/29/nova/cmd/manage.py@1876 and _port_update_to_openstack_cli if we move the port updates to before the PUT allocatoins call16:00
mriedemefried: you mean --skip-port-allocations ?16:01
mriedemwe don't even hit this code if you specify that16:01
efriedyeah16:01
efriedi know16:01
efriedswhat I'm saying16:01
mriedemand i really don't want to chase CLIs16:01
*** whoami-rajat has quit IRC16:01
gibimriedem: we need a very similar piece of code in the rollback code https://review.opendev.org/#/c/668184/3/nova/cmd/manage.py@194716:01
*** maciejjozefczyk has quit IRC16:02
gibimriedem: so I can drop https://review.opendev.org/#/c/637955/29/nova/cmd/manage.py@1876 from that patch, but then I will re-introduce a similar CLI generating code in the rollback patch https://review.opendev.org/#/c/6681816:02
gibimriedem: or shall I only tell the admin to clean the allocation key but not generate the CLI for it?16:03
gibiefried: if we go and try to heal the port allocations then generating CLIs is cheap. But if we are asked not to heal port allocations with --skip-port-allocations then we don't even call neutron to see if there is anything to heal. So in that case it is expensive to generate CLIs16:04
mriedemi just don't really like generating CLIs from a CLI16:05
mriedemi think i'd prefer to describe something in https://docs.openstack.org/nova/latest/admin/support-compute.html and just link to that16:05
*** wwriverrat has joined #openstack-nova16:05
mriedemi think i'd also prefer to squash the changes16:06
gibimriedem: I can dump the port id's that needs to be updated and link to https://docs.openstack.org/nova/latest/admin/support-compute.html where I write a CLI template. But I don't see why I the admin needs to go through these hops to run a CLI at then end16:06
*** maciejjozefczyk has joined #openstack-nova16:07
mriedemit seems easier and more future proof to document the situation and recovery solution in the docs than in code is all16:07
mriedemif this needs to change, it would be easier to do it in the docs i think16:07
*** mrch_ has joined #openstack-nova16:08
gibimriedem: OK, I will go with your suggestion and write the CLI in the doc. (and squash the changes)16:08
gibimriedem: thanks16:08
*** damien_r has joined #openstack-nova16:08
*** belmoreira has quit IRC16:08
mriedemstephenfin: a couple of comments in this queens backport https://review.opendev.org/#/c/629597/16:10
*** ricolin has quit IRC16:13
*** damien_r has quit IRC16:13
efriedgibi: You going to fold in https://review.opendev.org/#/c/668062/ as well?16:15
mriedemjust rebase on top of it16:16
mriedemdon't squash it in16:16
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Fix double word hacking test  https://review.opendev.org/66578816:17
*** mdbooth_ has joined #openstack-nova16:22
openstackgerritMerged openstack/nova stable/stein: Delete resource providers for all nodes when deleting compute service  https://review.opendev.org/66684016:25
openstackgerritMerged openstack/nova stable/stein: Init HostState.failed_builds  https://review.opendev.org/66828216:25
*** ricolin has joined #openstack-nova16:25
*** mdbooth has quit IRC16:26
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Init HostState.failed_builds  https://review.opendev.org/66852016:27
*** mdbooth_ has quit IRC16:27
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Move get_pci_mapping_for_migration to MigrationContext  https://review.opendev.org/66157116:29
openstackgerritMerged openstack/nova stable/rocky: Grab fresh power state info from the driver  https://review.opendev.org/66795516:33
*** tssurya has joined #openstack-nova16:36
*** cdent has quit IRC16:36
*** rpittau is now known as rpittau|afk16:36
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Allow driver to properly unplug VIFs on destination on confirm resize  https://review.opendev.org/66157216:37
mriedemlyarwood: you can pull the trigger on https://review.opendev.org/#/c/661572/16:41
mriedemand then that's everything for queens and the next release16:41
mriedemhttps://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/queens+label:Code-Review=216:42
mriedemmelwitt: can you review this queens backport? https://review.opendev.org/#/c/662471/16:42
*** cdent has joined #openstack-nova16:42
*** udesale has quit IRC16:48
*** ricolin has quit IRC16:53
*** cdent has quit IRC16:56
*** tssurya has quit IRC16:57
*** maciejjozefczyk has quit IRC16:57
*** gyee has joined #openstack-nova17:01
*** ociuhandu has quit IRC17:13
*** ralonsoh has quit IRC17:16
*** admin0 has joined #openstack-nova17:29
admin0hi all ..  in horizon, right after login, in the usage summary, when I enter the date and click submit, the data comes out .. how is that data taken out? is it some sort of nova/compute api ?17:29
*** efried has quit IRC17:30
*** brault has quit IRC17:37
*** brault has joined #openstack-nova17:38
*** lbragstad has quit IRC17:38
*** lbragstad has joined #openstack-nova17:38
*** efried has joined #openstack-nova17:38
*** luksky has joined #openstack-nova17:39
*** ivve has joined #openstack-nova17:42
*** xek has quit IRC17:45
*** tbachman has joined #openstack-nova17:46
*** ociuhandu has joined #openstack-nova17:53
*** psachin has quit IRC17:55
sean-k-mooneyadmin0: i think its from the simple tenant usage api endpoint17:57
sean-k-mooneyadmin0: https://developer.openstack.org/api-ref/compute/?expanded=show-usage-statistics-for-tenant-detail#show-usage-statistics-for-tenant17:58
admin0sean-k-mooney, thanks18:01
*** ociuhandu has quit IRC18:02
*** igordc has joined #openstack-nova18:09
sean-k-mooneymriedem: by the way i am bumping the minium version fo os-traits in https://review.opendev.org/#/c/666914/ too. should we split that out into its own change so we both can depend on it too avoid our prefilter changes conflicting?18:13
melwittmriedem: can do18:14
*** igordc has quit IRC18:14
*** igordc has joined #openstack-nova18:15
*** igordc has quit IRC18:17
gibiefried, mriedem: I will rebase on top of https://review.opendev.org/#/c/668062/18:18
sean-k-mooneyefried: for https://review.opendev.org/#/c/651269/4/specs/train/approved/libvirt-pmu-configuration.rst@11 i understand what you ment by topic and commit message but what did you mean by filename? it already matches correct18:21
sean-k-mooneyfixing the other two now18:22
efriedsean-k-mooney: yup18:22
sean-k-mooneyoh you are just saying make all 3 match18:23
openstackgerritsean mooney proposed openstack/nova-specs master: Libvirt: add vPMU spec for train  https://review.opendev.org/65126918:24
sean-k-mooneyok they should all match now18:25
mriedemsean-k-mooney: i'm not too worried about conflicts at this point18:26
sean-k-mooneyok was just wondering if i made sense to have the requiremetns bump be its own thing but its also trival to fix anyway so ill leave it for now18:26
Nick_Adoes kvm instance I/O get "paused" so to speak during snapshots by default?18:29
sean-k-mooneyit depends on the image backend18:30
sean-k-mooneybut generally yes18:30
sean-k-mooneyat least file io is18:30
sean-k-mooneywe quiesce disk io the guest while we do the online snapshot18:31
sean-k-mooneynetwork io should not be affected unless it would have to write to disk as part of the packet processing18:32
sean-k-mooneyi think we rely on the qemu guest agent to do this18:32
sean-k-mooneyat least when using local qcow2 images18:32
sean-k-mooneyfor rbd or cinder backed instances the storage backend does the snapshot and im not sure if we quiesce the guest or not18:33
mriedemefried: guess what https://review.opendev.org/#/c/641138/1//COMMIT_MSG@1618:33
mriedemhttps://review.opendev.org/#/c/666959/1/nova/tests/functional/regressions/test_bug_1825537.py@5118:33
Nick_Athanks sean-k-mooney18:34
efriedmriedem: waitwait, do I get an I-told-you-so??18:34
mriedemyou do18:34
efriedf'in aye18:35
* efried celebrates18:35
efriedokay, I'm done.18:35
mriedemluxuriate18:35
Nick_Acould you also explain why snapshots take up twice the instance's used disk space on compute before they're uploaded to glance?18:36
lyarwoodmriedem: sorry was out, just getting to the stable reviews you pinged about earlier18:37
Nick_Aby that I mean if there's an instance using 4.9G, the snapshots dir will have two files of 4.9G each before upload18:39
sean-k-mooneyNick_A: one is likely the snapshot and the other the root disk18:41
sean-k-mooneyi have not really looked at the code so not sure18:41
Nick_AWhy would they be the same size then?18:42
mriedemNick_A: the source code is freely available so you could also dig into this18:43
mriedemthis isn't really a support channel18:43
*** bbowen has quit IRC19:12
*** ociuhandu has joined #openstack-nova19:12
*** anastop_ has joined #openstack-nova19:16
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: Add functional recreate test for regression bug 1825537  https://review.opendev.org/66695919:19
openstackbug 1825537 in OpenStack Compute (nova) stein "finish_resize failures incorrectly revert allocations" [Medium,In progress] https://launchpad.net/bugs/1825537 - Assigned to Matt Riedemann (mriedem)19:19
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: Drop source node allocations if finish_resize fails  https://review.opendev.org/66715519:19
*** anastop_ has quit IRC19:28
mriedemsean-k-mooney: left an idea in https://review.opendev.org/#/c/667177/ on how to avoid the driver interface change for backports19:29
mriedemsean-k-mooney: heh you thought of the same, "maybe there is a way we can use the migration_context which we have to lookup the migration object?"19:29
sean-k-mooneymriedem: hehe ya i looked at that very breifly in v1 https://review.opendev.org/#/c/667177/1/nova/virt/libvirt/driver.py@9138 and didnt foolow up as i didnt thinkwe initally needed too until artom looked at the logs.19:31
sean-k-mooneythe migration context does not have the migration object in it directly right19:33
mriedemno but it has the id primary key you can use to get it19:34
sean-k-mooneythis https://github.com/openstack/nova/blob/master/nova/objects/migration_context.py#L4519:34
sean-k-mooneyok19:34
sean-k-mooneythat was where i got lost and was not sure where to go from next to get the migration object19:34
sean-k-mooneyso we can just do nova.objects.migration.get_by_id https://github.com/openstack/nova/blob/master/nova/objects/migration.py#L13719:36
sean-k-mooneyya that simpler then i thought it would be. are we ok with the extra db lookup or is the api chage preferable?19:37
openstackgerritsean mooney proposed openstack/nova-specs master: add libvirt pqos spec  https://review.opendev.org/66226419:44
sean-k-mooneywhen a spec is under review should the blueprint definition be in Review, New or Pending Approval? or do we just not use that at and just go from new to approved when the spec is approved19:46
sean-k-mooneymriedem: oh just noiced you already said that in https://review.opendev.org/#/c/667177/5/nova/virt/driver.py@74119:51
*** maciejjozefczyk has joined #openstack-nova19:54
mriedemsean-k-mooney: "or do we just not use that at and just go from new to approved when the spec is approved" mostly that20:01
mriedemdefinition isn't really used (i didn't use it really anyway)20:02
mriedemif there was a spec i'd mark the definition as review or pending approval20:02
*** hamzy has quit IRC20:02
*** hamzy has joined #openstack-nova20:07
*** mvkr has joined #openstack-nova20:08
*** maciejjozefczyk has quit IRC20:09
*** eharney has quit IRC20:16
efriedmriedem, sean-k-mooney: If I cared more, I would enforce that "Direction: Approved" means "we want to do this" and "Design: Approved" means "and we know how we're gonna do it" (i.e. spec approved).20:18
*** ociuhandu has quit IRC20:20
sean-k-mooneyefried: i set https://blueprints.launchpad.net/nova/+spec/libvirt-pqos since the spec is under review20:20
*** ociuhandu has joined #openstack-nova20:20
sean-k-mooneythe direct is still needs approval and the implemetation technically should not started but i left it at teh default of unknown20:21
efriedsfine20:21
efriedmriedem: favor...20:23
openstackgerritEric Fried proposed openstack/nova master: Clean up TestDriverBlockDevice helper Of DOOOOOM  https://review.opendev.org/66855620:23
efriedmriedem: if you would please review (and hopefully merge) https://review.opendev.org/#/c/566153/46 so nobody ever has to do it again, and it doesn't have to keep being rebased...20:26
efriedI've proposed a fup (see above) to address the issues I noted there.20:26
efried(and that one is much smaller)20:27
openstackgerritMerged openstack/nova stable/queens: Stop logging traceback when skipping quiesce  https://review.opendev.org/66032820:27
mriedemjesus i really don't want to review a nearly 600 LOC mox->mock conversion patch20:28
mriedemas you know i've never really been on board with the push to de-mox-ify everything as a goal20:28
mriedemenforcing that new tests are in mock sure, but this is....20:29
openstackgerritMerged openstack/nova stable/queens: xenapi/agent: Change openssl error handling  https://review.opendev.org/65630820:33
openstackgerritMerged openstack/nova stable/queens: Fix {min|max}_version in ironic Adapter setup  https://review.opendev.org/65652320:34
openstackgerritMerged openstack/nova stable/queens: Fix retry of instance_update_and_get_original  https://review.opendev.org/65932020:34
openstackgerritMerged openstack/nova stable/queens: DRY up test_rollback_live_migration_set_migration_status  https://review.opendev.org/66247020:34
openstackgerritMerged openstack/nova stable/queens: Include all network devices in nova diagnostics  https://review.opendev.org/66615220:34
*** ociuhandu has quit IRC20:34
openstackgerritMerged openstack/nova stable/queens: Add regression recreate test for bug 1830747  https://review.opendev.org/66277420:34
openstackbug 1830747 in OpenStack Compute (nova) queens "Error 500 trying to migrate an instance after wrong request_spec" [High,In progress] https://launchpad.net/bugs/1830747 - Assigned to Matt Riedemann (mriedem)20:34
efriedaspiers: SEV series in merge conflict after the first patch :(20:35
*** pcaruana has quit IRC20:41
*** spatel has joined #openstack-nova20:49
spatelsean-k-mooney: yt20:49
spatelgetting this issue - https://bugzilla.redhat.com/show_bug.cgi?id=117602020:51
openstackbugzilla.redhat.com bug 1176020 in libvirt "libvirt should do a right check for numa cpus set" [Medium,Closed: errata] - Assigned to mprivozn20:51
*** Sundar has joined #openstack-nova20:55
*** eharney has joined #openstack-nova20:57
openstackgerritEric Fried proposed openstack/nova master: Rename CinderFixtureNewAttachFlow to CinderFixture  https://review.opendev.org/66856121:03
* efried kisses @$$ ^21:03
mriedemi see what you're doing21:07
mriedembbiab21:10
*** slaweq has quit IRC21:11
*** tesseract has quit IRC21:12
*** jaypipes has joined #openstack-nova21:15
openstackgerritMerged openstack/nova stable/queens: Workaround missing RequestSpec.instance_group.uuid  https://review.opendev.org/66311021:19
efriedo/ jaypipes, how goes?21:22
sean-k-mooneyspatel: you are getting that because you are livemigrating instance with a numa toplogy21:30
sean-k-mooneyspatel: when you do that we do not recalulate the guest xml currently21:30
*** bbowen has joined #openstack-nova21:31
sean-k-mooneyas a result if you live migrate form a host with more cpus to one with less you can have an xml on the dest that reference cpus that are not present21:31
spatelsean-k-mooney: now i am stuck and not sure how to get out21:31
sean-k-mooneyspatel: cold migration should work21:31
spateli tried all option but getting same error21:32
spatelnow thinking to re-build it...21:32
spatelwhen you said - you are getting that because you are livemigrating instance with a numa toplogy21:32
spatelwhat does that means?21:33
sean-k-mooneyi assume you are getting that error becasue you tried to do a live migration21:33
spatelif i have machine and i said live migrate, where numa comes in picture21:33
sean-k-mooneyif that is not the case how did you hit this issue21:33
sean-k-mooneyif your instance use hugepage or cpu pinning it will have a numa toplogy21:34
spatelsomeone from my team trying to do and it endup in this situation, i have to talk to him to get full picture21:34
spateloh.. yes that instance had hugepage/cpu pinning21:35
spatelyou are saying we can't do live migration if instance has hugepage/cpu pinning?21:35
spatelsean-k-mooney: ^21:36
sean-k-mooneytechnically it can work but its not properly supported by nova21:36
sean-k-mooneywe dont currently update teh xml when migrating21:36
sean-k-mooneyfor live migrations21:36
sean-k-mooneyspatel: its a knwon issue that is being adressed by https://review.opendev.org/#/q/topic:bp/numa-aware-live-migration+(status:open+OR+status:merged)21:37
spatelso it not merge yet?21:38
sean-k-mooneycold migrations are supported but until ^ is implemented nova will not update teh libvirt xml and you can get that error amoung others21:38
sean-k-mooneyno its not21:38
sean-k-mooneyfor stien we specifcialy disable live migration for instnace with numa toplogies21:39
sean-k-mooneyi think we started backporting that too21:39
spateloh!21:39
spatelthis is a big issue then..21:40
spatelhow to migrate instance if my compute node is dead and all vm running on shared storage?21:40
sean-k-mooneyif the compute node is dead and the vms are using shared storage you should use evacuate21:41
spatelhmm..21:41
sean-k-mooneyit will rebuild the instance on another host21:41
sean-k-mooneybut you should only use evacuate if the instance is stopped21:41
spatelwhat if i want to migrate specific vm ? any heck there?21:41
spatelsean-k-mooney: so you are saying i can shutdown instance and do evaluate ?21:42
sean-k-mooneyevacuate works for a specifc vm21:42
spatelThis is very important information, i was totally not aware of it..21:43
spatelI need to make big banner now to tell everyone don't do live migration period..21:43
sean-k-mooneyif you have not already read it the go to text on evacuate is http://www.danplanet.com/blog/2016/03/03/evacuate-in-nova-one-command-to-confuse-us-all/21:44
sean-k-mooneywhat release of openstack are you running21:44
spatelmy old cloud running on queens  and new cloud i am build on stein21:44
sean-k-mooneylooks we have the config option on rocky https://github.com/openstack/nova/blob/stable/rocky/nova/conf/workarounds.py#L22321:45
sean-k-mooneyah we havnt merged https://review.opendev.org/#/c/629597/21:46
spatelhmm is it config option which i can turn on to protect from accident ?21:48
sean-k-mooneyspatel: live migration with hugepage works most of the time. cpu pinning is much less likely to work correctly21:48
sean-k-mooneywith that patch by default we will not allow instace with a numa toplogy to be live migrated21:49
sean-k-mooneyso its safe by default21:49
jaypipesefried: ahoy! :) going well, ty!21:49
efriedgood to hear21:49
spatelsean-k-mooney: hmm we used both pinning/hugepage :)21:50
sean-k-mooney:) yes. this si something we have wanted to fix for several relese. it will get done this cycle one way or another.21:51
sean-k-mooneyunfortuanetly its not backportable21:51
spateldamn..21:52
*** BjoernT has quit IRC21:52
sean-k-mooneyjaypipes: life treating you well in aws land21:52
*** Sundar has quit IRC22:04
mriedemefried: i did your deed22:07
mriedemwith lots of comments about why i didn't want to22:07
mriedemalso, i'll have to redo https://review.opendev.org/#/c/541420/ which is 3 months older than takashin's de-mox-ification22:07
efriedThanks mriedem. You will be rewarded in the hereafter.22:07
mriedemsatan won't care about this22:07
*** mlavalle has quit IRC22:08
efriedmriedem: tell it to review 66666622:08
openstackgerritEric Fried proposed openstack/nova master: Get rid of args to RBDDriver.__init__()  https://review.opendev.org/66856422:11
*** mriedem has quit IRC22:13
*** hamzy has quit IRC22:18
*** rcernin has joined #openstack-nova22:30
*** jaypipes has quit IRC22:35
*** luksky has quit IRC22:47
sean-k-mooneyaspiers: have you seen https://review.opendev.org/#/c/666769/1 yet22:48
sean-k-mooneyefried: ^22:48
sean-k-mooneyi need to rereview it after fully rereading the sev spec. while not contradictory i think it makes more change then required at least for a v122:50
*** tkajinam has joined #openstack-nova22:53
*** hamzy has joined #openstack-nova22:57
*** spatel has quit IRC22:58
*** igordc has joined #openstack-nova23:03
*** igordc has quit IRC23:05
*** igordc has joined #openstack-nova23:06
openstackgerritMatt Riedemann proposed openstack/nova master: Set COMPUTE_STATUS_DISABLED trait from update_provider_tree flow  https://review.opendev.org/66856523:11
*** andreaf has quit IRC23:18
*** andreaf has joined #openstack-nova23:34
*** spatel has joined #openstack-nova23:49
*** spatel has quit IRC23:53
« Sunday, 2019-06-30 Index Tuesday, 2019-07-02 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!