Monday, 2019-07-22

*** tkajinam has quit IRC00:12
*** takamatsu has quit IRC00:18
*** dklyle has joined #openstack-nova00:28
*** brinzhang has joined #openstack-nova00:38
*** brinzhang_ has joined #openstack-nova00:45
*** brinzhang has quit IRC00:47
*** brinzhang_ has quit IRC00:52
*** brinzhang has joined #openstack-nova00:54
*** tetsuro has joined #openstack-nova00:56
*** mgoddard has quit IRC01:01
*** mgoddard has joined #openstack-nova01:05
*** tetsuro has quit IRC01:13
*** spatel has joined #openstack-nova01:16
*** imacdonn has quit IRC01:17
*** imacdonn has joined #openstack-nova01:18
*** tetsuro has joined #openstack-nova01:18
*** spatel has quit IRC01:20
brinzhanglyarwood: After you review this spec[1] 5/20, now this spec wait for your update, when do you have time to do it? [1]https://review.opendev.org/#/c/580336/01:31
*** zul has quit IRC02:09
*** bhagyashris has joined #openstack-nova02:26
*** tetsuro has quit IRC02:42
*** artom has quit IRC03:04
*** tetsuro has joined #openstack-nova03:24
*** tetsuro has quit IRC03:24
*** psachin has joined #openstack-nova03:33
*** udesale has joined #openstack-nova04:02
*** BjoernT has joined #openstack-nova04:08
*** BjoernT_ has joined #openstack-nova04:13
*** BjoernT has quit IRC04:14
*** BjoernT has joined #openstack-nova04:23
*** BjoernT_ has quit IRC04:24
*** tetsuro has joined #openstack-nova04:25
*** eandersson has joined #openstack-nova04:25
*** etp has joined #openstack-nova04:53
*** ircuser-1 has quit IRC04:57
*** threestrands has joined #openstack-nova05:00
*** Luzi has joined #openstack-nova05:03
*** tetsuro has quit IRC05:04
*** ratailor has joined #openstack-nova05:38
*** tetsuro has joined #openstack-nova05:42
*** tetsuro has quit IRC05:44
*** tetsuro has joined #openstack-nova05:45
alex_xuefried: bauzas Luyao found a problem https://review.opendev.org/#/c/671222/4/nova/virt/libvirt/device.py@119, I guess we should use the migration as the consumer when migrate, just like we did for the placement05:47
*** BjoernT has quit IRC06:02
-openstackstatus- NOTICE: Due to a failure on the logs.openstack.org volume, old logs are unavailable while partition is recovered. New logs are being stored. ETA for restoration probably ~Mon Jul 22 12:00 UTC 201906:05
*** whoami-rajat has joined #openstack-nova06:05
*** ChanServ changes topic to "Due to a failure on the logs.openstack.org volume, old logs are unavailable while partition is recovered. New logs are being stored. ETA for restoration probably ~Mon Jul 22 12:00 UTC 2019"06:05
*** udesale has quit IRC06:16
*** tetsuro has quit IRC06:17
*** ricolin__ is now known as ricolin06:20
*** jaosorior has joined #openstack-nova06:25
*** ChanServ changes topic to "Current runways: https://etherpad.openstack.org/p/nova-runways-train -- This channel is for Nova development. For support of Nova deployments, please use #openstack."06:25
-openstackstatus- NOTICE: logs.openstack.org volume has been restored. please report any issues in #openstack-infra06:25
*** markvoelker has quit IRC06:32
*** pcaruana has joined #openstack-nova06:32
*** belmoreira has joined #openstack-nova06:36
*** belmoreira has quit IRC06:46
*** udesale has joined #openstack-nova06:47
*** xek has joined #openstack-nova06:56
*** boxiang has joined #openstack-nova06:57
*** slaweq has joined #openstack-nova06:57
*** tesseract has joined #openstack-nova07:01
*** markvoelker has joined #openstack-nova07:04
*** rpittau|afk is now known as rpittau07:05
*** rcernin has quit IRC07:07
*** maciejjozefczyk has joined #openstack-nova07:08
*** tkajinam has joined #openstack-nova07:08
*** xek has quit IRC07:09
*** maciejjozefczyk_ has joined #openstack-nova07:09
*** xek has joined #openstack-nova07:10
*** maciejjozefczyk_ has quit IRC07:10
*** jaosorior has quit IRC07:18
*** jhesketh has quit IRC07:22
*** ileixe has quit IRC07:22
*** jhesketh has joined #openstack-nova07:24
*** ileixe has joined #openstack-nova07:24
*** ttsiouts has joined #openstack-nova07:24
openstackgerritwangwei1 proposed openstack/nova master: fix spelling error in nova/api/validation/__init__.py  https://review.opendev.org/66924407:32
*** tkajinam has quit IRC07:36
*** ttsiouts has quit IRC07:42
*** ttsiouts has joined #openstack-nova07:43
*** ttsiouts has quit IRC07:48
*** jangutter has joined #openstack-nova07:52
*** ileixe has quit IRC07:59
bauzasalex_xu: ack, I'll need to look08:03
*** ileixe has joined #openstack-nova08:03
*** ralonsoh has joined #openstack-nova08:04
*** davidsha has joined #openstack-nova08:06
*** threestrands has quit IRC08:14
*** zbr|out is now known as zbr08:22
*** ivve has joined #openstack-nova08:24
*** ttsiouts has joined #openstack-nova08:27
*** tssurya has joined #openstack-nova08:34
*** ociuhandu has joined #openstack-nova08:37
*** ociuhandu has quit IRC08:39
*** shilpasd has joined #openstack-nova08:39
*** ociuhandu has joined #openstack-nova08:39
*** cdent has joined #openstack-nova08:49
alex_xubauzas: thanks, after take a look the detail, I don't think the migration uuid works. in the end, I'm thinking passing the flavor id to the claim/unclaim_for_instance. Then claim/unclaim based on the (instance_uuid, flavor_id)09:00
*** mgoddard has quit IRC09:01
*** mgoddard has joined #openstack-nova09:04
*** mdbooth has joined #openstack-nova09:15
*** cdent has quit IRC09:21
*** cdent has joined #openstack-nova09:23
openstackgerrit**** proposed openstack/nova master: Nova: node should be deleted when last service is deleted  https://review.opendev.org/67173109:26
*** priteau has joined #openstack-nova09:29
*** udesale has quit IRC09:40
*** udesale has joined #openstack-nova09:40
*** mdbooth has quit IRC09:41
*** mdbooth has joined #openstack-nova09:41
*** udesale has quit IRC09:42
*** udesale has joined #openstack-nova09:42
*** FlorianFa has joined #openstack-nova09:42
*** ociuhandu has quit IRC09:45
*** ociuhandu has joined #openstack-nova09:48
*** mgoddard has quit IRC10:11
*** mgoddard has joined #openstack-nova10:18
*** artom has joined #openstack-nova10:24
*** ttsiouts has quit IRC10:27
*** ttsiouts has joined #openstack-nova10:28
*** udesale has quit IRC10:28
*** ccamacho has joined #openstack-nova10:29
*** ccamacho has quit IRC10:29
*** ccamacho has joined #openstack-nova10:29
*** ttsiouts has quit IRC10:32
*** jaosorior has joined #openstack-nova10:41
*** jaosorior has quit IRC10:43
*** jaosorior has joined #openstack-nova10:44
*** shilpasd has quit IRC10:50
*** sean-k-mooney has joined #openstack-nova10:52
*** tbachman has joined #openstack-nova10:55
*** bhagyashris has quit IRC10:59
*** ttsiouts has joined #openstack-nova11:10
*** tssurya has quit IRC11:11
*** shilpasd has joined #openstack-nova11:14
*** betherly has joined #openstack-nova11:19
*** betherly has quit IRC11:24
*** tssurya has joined #openstack-nova11:24
sean-k-mooneystephenfin: when you get back form lunch we have killed the cacheing schduler so maybe we should delete the core, ram and disk filters then nuke the filed for the resouce tracker?11:29
sean-k-mooneyit would be a change to the hyperviors api but you could always proxy the data from placement.11:30
*** kaisers has quit IRC11:35
*** kaisers has joined #openstack-nova11:36
openstackgerrit**** proposed openstack/nova master: Nova: node should be deleted when last service is deleted  https://review.opendev.org/67173111:37
*** jaosorior has quit IRC11:38
*** jaosorior has joined #openstack-nova11:39
sean-k-mooneyjohnthetubaguy: lyarwood  can ye take a look at this stable backport https://review.opendev.org/#/c/671532/ if ye have time11:41
*** psachin has quit IRC11:50
*** betherly has joined #openstack-nova11:50
*** jaypipes has joined #openstack-nova11:53
*** spatel has joined #openstack-nova11:54
*** betherly has quit IRC11:55
openstackgerritAlex Xu proposed openstack/nova master: Add the virt driver interface for claim and unclaim the devices  https://review.opendev.org/67078211:57
openstackgerritAlex Xu proposed openstack/nova master: Moves the allocation retrieving early  https://review.opendev.org/67078311:57
openstackgerritAlex Xu proposed openstack/nova master: Calling the virt driver's claim/unclaim_for_instance in resource tracker  https://review.opendev.org/67078411:57
openstackgerritAlex Xu proposed openstack/nova master: Add DeviceManager to the libvirt virt driver  https://review.opendev.org/67138811:57
openstackgerritAlex Xu proposed openstack/nova master: Populates the existing mediated devices in the libvirt device manager  https://review.opendev.org/67078711:57
openstackgerritAlex Xu proposed openstack/nova master: Using the claim/unclaim_for_instance for mdevs  https://review.opendev.org/67122211:57
openstackgerritAlex Xu proposed openstack/nova master: Adds functional test for creating the instance with vgpus  https://review.opendev.org/67139811:57
*** ygk_12345 has joined #openstack-nova12:01
ygk_12345hi all12:01
ygk_12345some of the vms on the compute node are eating too much of memory. Can someone point me to any links for finding out what is happening in those vms from the hypervisro prespective ?12:02
*** ratailor has quit IRC12:06
*** udesale has joined #openstack-nova12:07
*** etp has quit IRC12:13
*** spatel has quit IRC12:13
TheJuliasean-k-mooney: I never get enough sleep and if I don't take meds It would be even worse... so I always needssleep :)12:18
mdboothygk_12345: You're unlikely to find the right expertise here for that. Assuming you're using libvirt/kvm you'll want to talk to a libvirt/kvm forum. Or your vendor...12:18
ygk_12345mdbooth is there any irc channel for kvm in general ?12:19
*** _erlon_ has joined #openstack-nova12:21
openstackgerritsean mooney proposed openstack/nova master: Libvirt: add support for vPMU configuration.  https://review.opendev.org/67133812:23
mdboothygk_12345: Try #virt on irc.oftc.net12:23
ygk_12345mdbooth ok thanks12:23
sean-k-mooneyygk_12345: how much memory are they consuming over what you execpt12:24
ygk_12345sean-k-mooney what I observer is in general the cpu usage against those qemu-kvm processes is shooting above 150 sometimes and so I am suspecting them. If I shut them down it is normal again12:25
sean-k-mooneyygk_12345: are you seeing high cpu usage, or high memory usage or both12:26
ygk_12345both12:26
ygk_12345sometimes12:26
ygk_12345how to find out whats exactly happening at those times ?12:26
sean-k-mooneyyou would likely need to look at the guest journal/logs to be honest but you could check the host for kernel errors12:28
ygk_12345hmm12:28
sean-k-mooneye.g. check if the kernel is soft locking a core12:28
sean-k-mooneythat could be caused by the guest soft locking up12:29
ygk_12345ok12:29
sean-k-mooneyare you currently using q35 machine type or are your still using the pc i440 machine type12:29
ygk_12345we use dell with latest intel12:30
sean-k-mooneywe have seen that q35 while more modern tends to use more memory12:30
ygk_12345oh ok12:30
*** ivve has quit IRC12:35
*** dklyle has quit IRC12:36
*** david-lyle has joined #openstack-nova12:36
*** ygk_12345 has quit IRC12:39
*** irclogbot_3 has quit IRC12:39
*** irclogbot_2 has joined #openstack-nova12:43
*** boxiang_ has joined #openstack-nova12:44
*** francoisp has joined #openstack-nova12:46
boxiang_https://review.opendev.org/#/c/649963/ and https://review.opendev.org/#/c/651969/ Can someone help review these two patches? thanks :)12:49
*** boxiang has quit IRC12:50
*** jaosorior has quit IRC12:59
efriedalex_xu: I don't understand. Why would we not use the migration consumer to migrate?13:00
*** mchlumsky has quit IRC13:01
*** beraldo has joined #openstack-nova13:01
*** mchlumsky has joined #openstack-nova13:01
*** BjoernT has joined #openstack-nova13:02
sean-k-mooneygibi_off: not sure if your are on vaction/PTO this week but just an fyi that i should have adressed your feedback in https://review.opendev.org/67133813:08
*** aojea has joined #openstack-nova13:09
*** eharney has joined #openstack-nova13:10
*** artom has quit IRC13:11
*** mriedem has joined #openstack-nova13:11
openstackgerritMatt Riedemann proposed openstack/nova stable/stein: Restore RT.old_resources if ComputeNode.save() fails  https://review.opendev.org/67203813:14
sean-k-mooneyefried: i am also confused. isnt a migration consumer proposed for use when doing cold and live migrations to hold the allocation on the second node13:14
efriedsean-k-mooney: He's off for two weeks. It looks like the changes are minor; if so another core will probably proxy his +2.13:15
efriedsean-k-mooney: that's my confusion as well.13:15
efriedperhaps we only use the migration consumer for live migration?13:15
efriedI don't know.13:15
sean-k-mooneyefried: ah ok good to know.13:15
mriedemthey're used for both cold and live13:15
mriedemjust not evacuate13:16
sean-k-mooneymriedem: o/ welcome back, have a good vaction?13:16
mriedemthanks, yeah13:16
sean-k-mooneywe dont use them for evac because we dont use them in rebuild13:16
*** beraldo has left #openstack-nova13:16
mriedemum13:17
mriedemthat's not really the reason13:17
mriedemit's because for evac the source compute service is down, so it's not really the same flow for how the migration-based allocations are handled at the end13:17
mriedemwe have migration records for evac13:18
alex_xuefried: if we use migration as consumer for the dst, when we confirm the resize, there isn't a call to dest host to change migration consumer back to instance consumer13:18
sean-k-mooneyright however event with a down host we could still free the allocation on the source node in placment13:18
mriedemsean-k-mooney: we do that when the source compute service comes back up13:18
efriedalex_xu: oh, you're talking about swapping which side gets which consumer?13:19
alex_xuefried: if we use migration as consumer for the src, we will call the the dest host to claim the device, so we have no way to change the src host's claim consumer to migration.13:19
sean-k-mooneyyes that is true.13:19
alex_xuefried: yes13:19
mriedemwe *could* use migration-based consumers for evac, i just don't think it was really a priority when dansmith implemented that blueprint13:19
mriedemi'm obviously walking into something late here though13:20
mriedemwho is out for 2 weeks?13:20
efriedgibi_off:13:20
efriedmriedem: but that's a separate topic13:20
mriedemok, which series are you talking about?13:20
efriedmriedem: we're talking about alex_xu's work to make hypervisor-specific claiming (atm for VGPUs and VPMEMs) happen in the virt driver.13:21
alex_xumriedem: https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:claim_for_instance13:21
mriedemok and this is prep work for vpmem i guess13:22
* sean-k-mooney clicks, i thought they happened in the RT13:22
mriedemclaims do happen in the rt today13:22
mriedemthe only hypervisor-specific thing though is the overhead stuff13:22
*** sean-k-mooney has quit IRC13:22
alex_xumriedem: vgpu allocation has race problem also, in libvirt, we allocate vgpu out of rt, that means no lock13:22
efriedalso, it just makes sense for hypervisor-specific claiming to happen in the virt driver.13:23
mriedemalex_xu: it happens during driver.spawn correct?13:24
efriedSo tldr we're adding a hook from the various *_claimZ to call into a new ComputeDriver interface which interprets allocations etc to earmark the real devices corresponding to the allocations13:24
alex_xumriedem: yes, https://bugs.launchpad.net/nova/+bug/183620413:24
openstackLaunchpad bug 1836204 in OpenStack Compute (nova) "The allocation of VGPU has race problem" [High,Triaged] - Assigned to Alex Xu (xuhj)13:24
*** BjoernT has quit IRC13:24
*** BjoernT has joined #openstack-nova13:25
mriedemi guess we're not modeling each specific device in placement right? just the total number of available in inventory, and then it's up to the virt driver to pick one, which could conflict.13:25
*** BjoernT has quit IRC13:25
efriedexactly13:26
mriedemweee, so much for ever getting rid of the rt claims code...13:26
*** BjoernT has joined #openstack-nova13:26
*** BjoernT has quit IRC13:26
efriedThe RT claims *framework* will need to stay, but IMO eventually "all" of the guts should wind up moving into this ComputeDriver.claim_for_instance13:26
*** BjoernT has joined #openstack-nova13:27
efriedespecially for things like PCI devices13:27
*** BjoernT has quit IRC13:27
efriedand NUMA13:27
*** sean-k-mooney has joined #openstack-nova13:27
efriedthe line where it makes sense to cut things over is when we move to tracking a resource in placement.13:27
efriedthe messy ones obviously being VCPU, MEMORY_MB, DISK_GB13:28
*** BjoernT has joined #openstack-nova13:28
*** BjoernT has joined #openstack-nova13:28
*** BjoernT has quit IRC13:28
sean-k-mooneyefried: well placement just keeps a tally count. if we need to do device assignment we need to continue to do tracking the the RT13:28
efriedyup13:29
efriedwhere "device" will eventually encompass NUMA-split proc/mem13:29
*** BjoernT has joined #openstack-nova13:29
sean-k-mooneyram and cpus are just devices in disgiuse13:29
*** BjoernT has joined #openstack-nova13:30
*** BjoernT has quit IRC13:30
alex_xuI have too much fun with same host resize today13:30
efriedbbiab13:30
*** BjoernT has joined #openstack-nova13:31
*** BjoernT has joined #openstack-nova13:32
*** BjoernT has quit IRC13:32
*** BjoernT has joined #openstack-nova13:33
*** BjoernT has quit IRC13:33
*** BjoernT has joined #openstack-nova13:34
*** BjoernT has quit IRC13:34
*** BjoernT has joined #openstack-nova13:35
*** BjoernT has quit IRC13:35
*** lbragstad has joined #openstack-nova13:35
*** BjoernT has joined #openstack-nova13:35
*** BjoernT has joined #openstack-nova13:36
*** BjoernT has quit IRC13:36
*** needscoffee is now known as kmalloc13:36
stephenfinmriedem, efried: I'm hitting the boundaries of my resource tracking know how and could do with some help13:36
stephenfinI've got this patch to start tracking pcpus as a ComputeNode/HostState field https://review.opendev.org/#/c/671794/13:37
*** BjoernT has joined #openstack-nova13:37
*** BjoernT has quit IRC13:37
stephenfinIt's not complete, and it's also breaking some functional/tempest tests because one of those objects is being spat out for the os-hypervisors API13:37
*** BjoernT has joined #openstack-nova13:38
*** BjoernT has quit IRC13:38
stephenfinHowever, does any of the resource tracking claims stuff matter for vcpus, ram and disk anymore, given we're actually requesting things from placement?13:38
*** BjoernT has joined #openstack-nova13:39
openstackgerritsahid proposed openstack/nova master: cellv2: make update_cell to support cell0  https://review.opendev.org/67204513:39
stephenfinReferring specifically to this https://github.com/openstack/nova/blob/master/nova/compute/claims.py#L97-L10913:39
*** BjoernT has joined #openstack-nova13:39
*** BjoernT has quit IRC13:39
mriedemthey used to matter for scheduler drivers that didn't use placement, like the caching scheduler, but that's gone now,13:40
*** spatel has joined #openstack-nova13:40
mriedemthe overhead stuff comes from the driver and that's still part of the claim13:40
mriedemi know the libvirt driver claims overhead in certain case13:40
mriedem*cases13:40
*** BjoernT has joined #openstack-nova13:40
*** BjoernT has quit IRC13:40
mriedemhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L88413:40
stephenfinYup, for emulator threads, though I do have a chance to stop doing that now with the PCPU stuff13:40
mriedemthere are other drivers that implement that method as well13:41
mriedemhyperv i think is one13:41
*** BjoernT has joined #openstack-nova13:41
*** BjoernT has quit IRC13:41
mriedemhttps://github.com/openstack/nova/blob/master/nova/virt/hyperv/vmops.py#L11913:41
mriedembesides the overhead stuff i'm not sure anything cares about vcpus/ram/disk claims in the rt anymore since that should be handled by the scheduler + placement now13:42
*** BjoernT has joined #openstack-nova13:42
mriedemdansmith at one time had a patch to rip that out13:43
*** BjoernT has quit IRC13:43
stephenfinHmm, so it sounds like that alone prevents me from simply removing this stuff https://github.com/openstack/nova/blob/master/nova/compute/claims.py#L160-L16213:43
mriedemhttps://review.opendev.org/#/c/551026/13:43
dansmithhttps://review.opendev.org/#/c/551026/13:43
dansmithheh13:43
*** beekneemech is now known as bnemec13:43
stephenfinOkay, I might incorporate that into my series, if that makes sense?13:44
dansmithwe never removed cachingscheduler did we? but surely we can now yeah?13:44
mriedemwe did13:44
openstackgerritsahid proposed openstack/nova master: cellv2: make update_cell to support cell0  https://review.opendev.org/67204513:44
mriedemi just left a comment on dan's patch13:44
dansmithoh sweet13:44
*** BjoernT has joined #openstack-nova13:45
*** BjoernT has quit IRC13:45
mriedemin boston we talked about the overhead-from-driver problem for claims / placement and i think had mostly just shrugged it off saying as a workaround operators could bump up the reserved amount of inventory on hosts that would use vms that need the overhead space13:45
*** BjoernT has joined #openstack-nova13:45
*** BjoernT has quit IRC13:46
*** BjoernT has joined #openstack-nova13:46
mriedemcaching scheduler was removed in stein fwiw13:46
*** BjoernT has quit IRC13:46
*** BjoernT has joined #openstack-nova13:47
*** BjoernT has quit IRC13:47
stephenfinHmm, okay, I clearly need to think about this13:47
*** Luzi has quit IRC13:48
*** BjoernT has joined #openstack-nova13:48
stephenfinStarting with figuring out if anything else is using/cares about the ComputeNode.vcpus/vcpus_used field13:48
*** BjoernT has quit IRC13:48
stephenfin(and therefore whether I need a pcpu equivalent)13:48
*** shilpasd has quit IRC13:49
*** BjoernT has joined #openstack-nova13:49
*** BjoernT has quit IRC13:49
*** TxGirlGeek has joined #openstack-nova13:49
*** BjoernT has joined #openstack-nova13:49
*** BjoernT has quit IRC13:50
*** BjoernT has joined #openstack-nova13:50
*** BjoernT has quit IRC13:50
*** BjoernT has joined #openstack-nova13:51
*** BjoernT has joined #openstack-nova13:52
*** BjoernT has quit IRC13:52
*** TxGirlGeek has quit IRC13:52
stephenfinmriedem: Can/should 'Aggregate(Ram|Disk|Core)Filter' be deprecated?13:55
dansmiththose are widely used I believe13:55
*** tesseract has quit IRC13:55
dansmithand don't have placement-based alternatives because they work on aggregates13:55
dansmithwe broke the allocation ratio one and people revolted13:56
stephenfinI'm misreading this release note so, I guess :( https://github.com/openstack/nova/blob/master/releasenotes/notes/agg-resource-filters-6e24c92a69afa85f.yaml13:56
stephenfinThat suggests to me that aggregate-based overcommit ratios aren't a thing anymore13:56
stephenfinand the filters can be removed because they're useless13:57
dansmiththere are more functions in the aggregate filters than just allocation ratios right?13:57
dansmithhowever, that breakage was what led to the revolt I think13:57
dansmithi.e. that commit13:57
stephenfinOh, quite possibly :) Looking at the AggregateDiskFilter, I don't see much more happening https://github.com/openstack/nova/blob/master/nova/scheduler/filters/disk_filter.py13:58
mriedemthat release note was from ocata i thought, and yeah part of the misunderstanding13:59
stephenfin(Though the __init__.py for same should probably be overridden to not log the warning)13:59
mriedema more detailed description is in the docs now https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allocation-ratios13:59
stephenfinwait, nvm. I see DEPRECATED now13:59
*** tesseract has joined #openstack-nova14:00
dansmithstephenfin: yeah maybe I'm confused,but I thought there were a couple other aggregate-based operations other than just the ratio for those, but maybe I'm wrong14:00
dansmithor maybe the filters I'm thinking of aren't tied specifically to those three classes14:00
mriedemstephenfin: any out of tree filters/weighers could be using ComputeNode.vcpus/vcpus_used14:00
mriedemplus the os-hypervisors api is using them14:00
mriedem"clearly need to think about this" is probably the understatement of the year for that pcpu overhaul blueprint14:01
stephenfinFair point. So I probably can't outright remove them, but I'm thinking/hoping I don't need to distinguish between pcpus/vcpus at that particular level14:01
stephenfinAmen.14:02
stephenfinmriedem: fwiw, the doc linked says the exact same thing as the release note and gives me the same impression. If I'm reading it correctly, I assume that "Note" needs to be removed? https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#scheduling-considerations14:03
mriedemno,14:06
mriedemit's saying the allocation ratio set via the aggregate metadata is broken since ocata,14:06
mriedemand you *have* to set the allocation ratio per the computes / resource providers instead14:07
mriedemwhich leads into the usage scenarios section14:07
mriedemhttps://review.opendev.org/#/c/640898/ is also related14:09
mriedemand was something we talked about at the ptg in dublin14:09
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional test for resize crash compute restart revert  https://review.opendev.org/67039314:10
openstackgerritMatt Riedemann proposed openstack/nova master: Pass migration to finish_revert_migration()  https://review.opendev.org/66863114:10
openstackgerritMatt Riedemann proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events  https://review.opendev.org/66444214:10
stephenfinI guess (3) is the important piece from that? If you want to use aggregate-based allocation ratios, you *must* set e.g. '[DEFAULT] cpu_allocation_ratio' to 'None'14:11
*** aojea has quit IRC14:15
mriedemthose scenarios (1 and 3 specifically) are more about specific use cases when discussing this problem with operators, i.e. cern does everytihng with config mgmt and cares about scenario 1. iweb people exposed the host aggregate metadata stuff to users to control their own allocation ratios so they cared about the api part, which is scenario 314:15
*** ildikov has joined #openstack-nova14:16
*** ttsiouts has quit IRC14:16
mriedemit's been quite awhile since i've had to think about this much, and at this point i don't really know why someone would even enable those filters now14:16
*** ttsiouts has joined #openstack-nova14:16
stephenfinyeah, I've probably gone far enough down this rabbit hole myself14:16
mriedemhttps://review.opendev.org/#/c/544683/ was the related nova spec14:17
mriedemwhich was superseded with mel's osc-placement patch14:17
mriedemthe aggregates api sugar in nova is that you can set the allocation ratios per aggregate in one call, which you can't do in placement14:17
stephenfinsummary: Can't remove ComputeNode.vcpus(_used) or HostState.vcpus(_used) yet because they might be used by external filters...14:17
mriedemand the api right?14:17
stephenfinand the API, correct14:17
mriedemwe have talked a few times about the os-hypervisors API, or part of it, just proxying to placement rather than rely on those values set by the RT14:18
stephenfinMight want to put them behind "this field has been deprecated getters/setters, but that's a nice-to-have14:18
stephenfinNo one should have (Core|Disk|Ram)Filter enabled so I don't need to worry about those and could probably remove them (it's been long enough)14:19
stephenfinBecause of that, I probably don't need to distinguish between vcpus and pcpus in the ComputeNode object and can just lump them in together14:19
stephenfinThe os-hypervisors API is already lying about available vcpus (overcommit ratios aren't respected) so what's another lie14:20
stephenfinAs you say, could update that to proxy to placement but that's tangential to this and probably shouldn't be lumped into what is already a somewhat large series14:20
*** ttsiouts has quit IRC14:21
stephenfinand I can probably remove the resource claiming stuff for CPU, RAM and disk like dansmith was doing but I need to think of a workaround for handling overhead14:21
dansmithoverhead is handled by setting reserved in the compute configs right?14:22
stephenfinAfraid not. XenAPI seems to be adding some amount for each instance booted14:22
stephenfinand that's what we use to account for the extra CPU consumed when you enable emulator thread offloading in Libvirt using the 'isolate' policy14:23
dansmithright, we discussed that,14:23
dansmithand I think we just settled on "meh, set enough reserved to cover enough of your instances"14:23
dansmithin dublin, IIRC14:23
stephenfinI'm happy with that but am I going to break people?14:24
*** artom has joined #openstack-nova14:24
stephenfini.e. nova will now allow you to boot N+1 instances on a XenAPI host because overcommit is being ignored and the operator forgot to update their reserved14:24
mriedemdansmith: boston was the first time i remember talking about it, but yeah it was awhile ago and the agreed workaround was bumping reserved in config14:24
mriedemjay said he'd write a doc about how to calculate all that but...14:25
* dansmith nods14:25
mriedemhttps://bugs.launchpad.net/nova/+bug/1683858 has the details14:27
openstackLaunchpad bug 1683858 in OpenStack Compute (nova) "Allocation records do not contain overhead information" [Medium,Won't fix]14:27
stephenfinI'm already changing all the things, so what's another thing to that pile14:28
*** artom has quit IRC14:29
*** ttsiouts has joined #openstack-nova14:29
efried(stephenfin, I'm glad Matt & Dan answered you; I probably wouldn't have been much help there)14:35
bauzasI'm honestly not really paying attention to this channel, but I saw the above discussion14:37
bauzasstephenfin: dansmith: others: any stuff I can help ?14:37
stephenfinbauzas: I think I'm good for now, but keep your ears open :)14:39
bauzasokidoki14:42
efriedbauzas: mriedem, or johnthetubaguy: could I please ask you to do the final on https://review.opendev.org/#/c/651681/ ?  I was going to proxy sean-k-mooney's +1, but I think that would be three Intels.14:43
bauzasefried: lemme look14:43
efried(auto-converge/post-copy)14:43
* bauzas needs to be more there in the channel14:44
*** artom has joined #openstack-nova14:44
*** artom has quit IRC14:45
*** artom has joined #openstack-nova14:45
artomdansmith, could we get your stamp of (dis)approval on https://review.opendev.org/#/c/671471/ when you get a chance? tia :)14:45
bauzasefried: oh this one ?14:46
bauzassure, I can +W14:46
efriedthanks14:46
bauzasI already reviewed it once14:46
openstackgerritBence Romsics proposed openstack/os-vif master: Insert osprofiler trace info as external_ids to the bridge table  https://review.opendev.org/66571514:48
*** jaosorior has joined #openstack-nova14:53
*** spatel has quit IRC14:55
mnaserin nova, has there been some sort of 'standard' on what you do in code that is inherently race-y in the cases that you lose the race to another worker14:56
jaypipesstephenfin: hyperv has a completely different calculation as well for overhead, IIRC.14:57
*** belmoreira has joined #openstack-nova14:57
mnaserin cinder, there's a cast operation that involves a race between workers, and the worker that loses seems to be raising an exception14:57
*** ircuser-1 has joined #openstack-nova14:57
mnaserwhich to me seems a little too much, raising an exception for a non-failing scenario14:57
efriedmnaser: That sounds really broad to me. I would think one would need to know more about the specific situation.14:58
efriedSometimes you could retry. Sometimes you could log and continue. Sometimes you would have to fail the operation...14:59
mnaserhttps://github.com/openstack/cinder/blob/master/cinder/objects/cleanable.py#L142-L15514:59
mnaserso the code seems to pretty much gives me the indication that the other service created the worker, and now it'll resume happily after and we'll stop15:00
*** boxiang_ has quit IRC15:04
*** ccamacho has quit IRC15:05
openstackgerritStephen Finucane proposed openstack/nova master: Remove deprecated Core/Ram/DiskFilter  https://review.opendev.org/67206515:06
stephenfinjaypipes: ack. This is going to be fun15:06
stephenfinI might be kicking that can down the road...15:07
*** gyee has joined #openstack-nova15:08
efriedmnaser: If the code is saying "make sure this thing gets cleaned" and the exception indicates "another thread cleaned it" then it seems like the right thing is to log info ("Another thread took care of this for us, carrying on") and proceed.15:10
*** cdent has quit IRC15:11
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional test to resize volume-backed server with zero root disk  https://review.opendev.org/67206715:12
*** cdent has joined #openstack-nova15:13
efriedmriedem: Ima rebase & reapprove https://review.opendev.org/#/c/669523/1 unless you're already in the middle15:14
openstackgerritEric Fried proposed openstack/nova master: Remove Newton-era min compute checks for server create with device tags  https://review.opendev.org/66952315:15
*** Alphazero_ has joined #openstack-nova15:16
mriedemefried: haven't noticed15:16
efrieddone15:16
Alphazero_Hi All, I recently uninstalled and reinstalled keystone via Juju on an up and running cluster and have been receiving this message when trying to list existing instances:15:17
Alphazero_The server is currently unavailable. Please try again at a later time.<br /><br />15:18
Alphazero_ (HTTP 503) (Request-ID: req-22f009ce-d65c-4795-8dd5-ff7c2a351d6d)15:18
Alphazero_checked nova.conf and its being configured by JuJu15:18
Alphazero_Any help would be greatly app. thanks!15:19
*** priteau has quit IRC15:20
stephenfinAlphazero_: You probably want #openstack or, at a stretch, #openstack-keystone15:25
Alphazero_whoops sorry ^^ just noticed the message at the top - will shift over...15:25
* artom humbly asks for non-RH eyes on https://review.opendev.org/#/c/670593/. We have a +3, looking for that extra point :) efried again?15:27
artomHrmm, maybe wait for sean-k-mooney to weight, seems like he has doubts as to the completeness of the fix15:28
sean-k-mooneyi think you are still relying on the pf being bound to a networking driver and having a netdev15:29
sean-k-mooneyif the PF is bound to vfio-pci15:29
sean-k-mooneyit will not have a net dev15:29
sean-k-mooneyin which case im not sure pci_utils.get_mac_by_pci_address will work15:30
dansmithartom: sorry meant to say "ack" above, but...ack.15:30
sean-k-mooneyim looking at that code now15:30
artomdansmith, no worries, I saw the +W go through, and am thankful (in silence)15:30
dansmithartom: ack15:30
*** lpetrut has joined #openstack-nova15:30
sean-k-mooneyartom: so ya https://github.com/openstack/nova/blob/master/nova/pci/utils.py#L162-L180 relise on the PF being bound to a networking driver not vfio-pci15:31
sean-k-mooneyso in that case we will still skip exposing the metadata for that PF15:32
artomsean-k-mooney, so, I did test this (unlike the original patch :( ), what would cause the PF to use networking driver vs vfio-pci?15:32
artomBecause in the env I had it was using the former, going by what you're saying15:33
sean-k-mooneyudev15:33
sean-k-mooneyor the kernel configuration in general15:33
sean-k-mooneytry manually binding the PF driver to vfio-pci15:33
artomEnv is gone :(15:33
sean-k-mooneyit will still be usable by kvm but the metadata will be empty15:34
sean-k-mooneyyou change wont break anythin it just will end up in the except block and retrun none15:34
artomSo, strictly speaking, better than what we have now? ;)15:34
sean-k-mooneyso your fix is valid if the PF is boud to say i40e15:34
sean-k-mooneyyep15:34
sean-k-mooneyas i said i think its incomplte not wrong.15:35
artomSome of the PFs our there will start working, the others will remain device-tag-less15:35
sean-k-mooneyso maybe partial-bug?15:35
artomThat'd wfm15:35
sean-k-mooneyinstead of close-bug and i'd be +1 on it15:35
artomAck, leave a review and I'll update the commit message15:35
sean-k-mooneysure thing. ill do that in a few minutes. just grabbing something to drink brb15:36
artomAnd if I ever get an SRIOV env again, I'll come up with a patch to address vfio-pci-bound PFs, presumable with some new method to find the MAC address from the PCI address.15:36
artommriedem, thanks for looking, replied15:41
artomAnd welcome back, btw. No way 1 week was enough, but we're still happy to see you :)15:41
jangutterartom: I think if the PF is bound to vfio-pci then the kernel knows almost nothing about the device. Only way to get info is via some kind of backdoor (like another PCI device that happens to "manage" the PF).15:44
artomjangutter, so in those cases we should just give up on getting its MAC address?15:45
jangutterartom: the really ugly way is to rebind the PCI device to a kernel driver, let it probe, check what the MAC is, rebind it to vfio-pci.15:46
artomjangutter, I feel like that's not Nova's job...15:46
jangutterartom: I concur.15:46
artomWould the device's PCI address be the same in the guest as on the host? If so it'd be enough to just expose tag + PCI address in the metadata15:47
artomIf not, exposing just a device tag makes no sense15:47
sean-k-mooneyjangutter: well for neutron sriov passthouhg of PF we are ment to be discovering the PF mac and setting the neutron port to it15:47
sean-k-mooneyjangutter: im not sure exactly how we do that however15:48
sean-k-mooneyim hoping it more robost then we do for tagging15:48
sean-k-mooneyjangutter: but yes when its boud to vfio-pci the kernel only know what is reported in the pci config space15:49
sean-k-mooneyso what is reported by lspci15:49
sean-k-mooneybut i don think the mac is part of that15:49
jangutteryeah, the problem is that vfio-pci is _not_ a driver. It's technically just "hey, this is a raw pci device and I'm not going to interpret anything about it."15:49
jangutterthere's code in libvirt that does the whole "driver rebinding" thing for the MLX-3 series for VF's, because it needs info from the driver to figure out which port the VF is connected to.15:50
cdentefried: am I right that the shared disk spec is effectively dead: https://review.opendev.org/650188 (trying to trim my attention)15:50
jangutterIt would not be surprising to me if that's also done for PF's.15:51
artomMy stomach is angry, so I'm go going to get phood, but I'll read the scrollback when I get back15:51
janguttercould this be exposed via devlink? My spider-sense says 'unlikely'.15:52
*** mlavalle has joined #openstack-nova16:01
*** udesale has quit IRC16:08
openstackgerritAndreas Jaeger proposed openstack/nova master: Update api-ref location  https://review.opendev.org/67207716:09
*** belmoreira has quit IRC16:09
*** ttsiouts has quit IRC16:11
*** ttsiouts has joined #openstack-nova16:12
*** belmoreira has joined #openstack-nova16:16
*** lpetrut has quit IRC16:16
*** jaosorior has quit IRC16:17
*** belmoreira has quit IRC16:17
*** ttsiouts has quit IRC16:17
*** tssurya has quit IRC16:17
sean-k-mooneyartom: commented. i gave it a tentitive +1 rather then -1 given it looks like the vfio-pci case was never supported for metadata generation16:20
*** rpittau is now known as rpittau|afk16:21
artomsean-k-mooney, I'm all for respinning with Partial-bug16:21
artomI'll also improve the LOG message16:22
*** mlavalle has quit IRC16:23
artomsean-k-mooney, what does the passed through PF look like from the guest? I'm assuming its guest PCI address won't be the same as the host16:23
artomMy train of thought is - if we can't find its MAC, and we don't know what its guest PCI address it, there's no point in exposing just a tag, because the guest will have no way of associating that tag with a device16:24
*** davidsha has quit IRC16:24
sean-k-mooneyit wont but the guest pci address is stored in the target element of the host dev element and the host pci address is in the source element16:25
artomAh, so we ignore the MAC entirely, and just expose that along with the tag16:25
sean-k-mooneyyep16:25
artomI could do that in this patch as well, however I have no way if testing that16:26
artom*of16:26
sean-k-mooneyi could proably test it on my server that i use for sriov dev but im not in shannon at the moment16:26
openstackgerritAndreas Jaeger proposed openstack/nova master: Update api-ref location  https://review.opendev.org/67207716:28
*** cdent has quit IRC16:28
artomIt'd be a beefier change though16:28
artomCurrently LibvirtConfigGuestHostdevPCI doens't even understand <target>16:29
artomWhich actually means we're putting the wrong PCI address into the metadata, as we're using the <source>16:29
artom*facepalm*16:29
artom... but we have no concept of PCI address in the VIF data structure that we use to store the tags16:31
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Rename exception argument  https://review.opendev.org/67179516:53
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Remove unused function parameter  https://review.opendev.org/67179616:53
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'hardware.get_host_numa_usage_from_instance'  https://review.opendev.org/67179716:53
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'hardware.host_topology_and_format_from_host'  https://review.opendev.org/67179816:53
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'hardware.instance_topology_from_instance'  https://review.opendev.org/67179916:53
openstackgerritStephen Finucane proposed openstack/nova master: WIP: hardware: Differentiate between shared and dedicated CPUs  https://review.opendev.org/67180016:53
openstackgerritStephen Finucane proposed openstack/nova master: Add support translating CPU policy extra specs, image meta  https://review.opendev.org/67180116:53
openstackgerritStephen Finucane proposed openstack/nova master: Remove deprecated CPU, RAM, disk claiming in resource tracker  https://review.opendev.org/55102616:53
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'nova.virt.driver.ComputeDriver.estimate_instance_overhead'  https://review.opendev.org/67210616:53
*** igordc has joined #openstack-nova16:54
stephenfindansmith: ^ I think the reno I've added to https://review.opendev.org/551026 should cover how to handle overhead sufficiently, when combined with https://review.opendev.org/67180116:55
stephenfin(Just FYI. The series is still WIP)16:55
*** ricolin has quit IRC16:57
mriedemis it just me or are the zuul comments now always showing up regardless of the toggle CI button?16:58
dansmithstephenfin: commented on something you said in there16:58
artomsean-k-mooney, still around? Can I pick your brain for a thing?17:01
artom(Related to that device tagging patch)17:02
stephenfinmriedem: The zuul comments, yes. Third party CI are hidden17:02
stephenfinI suspect that was intentional, since the button now reads "Toggle Extra CI"17:02
stephenfindansmith: Think you might be right, in which case this is much ado about nothing. I'll respond once I've made sure17:07
efriedartom: looks like mriedem is engaged with https://review.opendev.org/#/c/670593/ ?17:07
artomefried, yep, thanks for looking17:07
dansmithstephenfin: I didn't realize you were worried about something acutely happening now when we discussed earlier, I thought you were just generally wondering about the impact of moving away from those filters17:08
artomand I think we're going back to drawing board for that one anyways17:08
efriedcdent: re shared disk spec, if it doesn't get some comeback from the author (or get picked up by someone else) then I guess it's dead, yeah.17:08
artomThe review process (sean-k-mooney mostly) unearthed other problems in that code17:08
stephenfinNo, it was pretty much the 'hw:emulator_threads_policy=isolate' case that I was worried about breaking17:08
*** Alphazero_ has quit IRC17:09
*** amodi has quit IRC17:13
*** mlavalle has joined #openstack-nova17:14
sean-k-mooneyartom: my mother just arrived home but yes im still around17:15
openstackgerritMerged openstack/nova master: libvirt: move checking CONF.my_ip to init_host()  https://review.opendev.org/67147117:16
artomsean-k-mooney, I thought I had a way of solving the tag <-> XML device problem for VFIO-PCI, but when writing it out in the review, turns out I didn't17:16
artomI was thinking of using instance.pci_devices, but they don't have any MAC either17:16
artomUnless we do a DB migration and start shoving them in there17:17
sean-k-mooneyyou can use the vif['binding_profile']['pci_slot']17:17
openstackgerritAndreas Jaeger proposed openstack/nova master: Update api-ref location  https://review.opendev.org/67207717:17
artomsean-k-mooney, that won't solve the problem17:18
sean-k-mooneythat will be the host pci address for that port17:18
*** mvkr_ has quit IRC17:18
*** _mlavalle_1 has joined #openstack-nova17:19
sean-k-mooneyartom: we can construct the NetworkInterfaceMetadata without setting the mac filed17:21
sean-k-mooneyor rather setting it condionally17:21
artomsean-k-mooney, I know, but we need to correlate the tag in nova/objects/network_request.py to the correct device in the instance XML17:22
artomCurrently that's done by MAC address, because it's the one piece of info that's common (sometimes) to both17:22
*** bbowen has quit IRC17:22
*** mlavalle has quit IRC17:22
sean-k-mooneyartom: but its not the "one" pices of info that is common17:23
sean-k-mooneythe pci address should be common too i belive17:23
artomsean-k-mooney, right, but all of the existing code assumes the MAC will be used17:23
artomSo we write the tag in a VirtualInterface object, which has the MAC and nothing else.17:24
sean-k-mooneywell that is entirly broken17:24
artomNow you tell me :P17:25
sean-k-mooneyyou can have two ports with the same mac on different networks and attach them both to the same instance17:25
*** panda has quit IRC17:25
artomWhere were you 3 years ago or whenever Newton happened17:25
artom;)17:25
artomSee, I though Neutron placed a MAC uniqueness constraint per instance as well, not just per-Network17:26
*** panda has joined #openstack-nova17:26
sean-k-mooneyi proably pointed that out 3 years ago if i reviewd it :)17:26
sean-k-mooneyno17:26
sean-k-mooneyit does not17:26
sean-k-mooneybut nova proably does17:27
artomI recall *something* of that sort17:27
sean-k-mooneyin anycase vifs_to_expose is a lis tof nova.model.Vif objects?17:27
artomNo, VirtualInterface17:27
sean-k-mooneyah that was what i was about to ask17:27
sean-k-mooneylooking at the object https://github.com/openstack/nova/blob/master/nova/objects/virtual_interface.py#L34-L4917:28
sean-k-mooneyyou have the neutorn pot uuid17:29
sean-k-mooneyso you can get the full vifs form the network info cache17:29
sean-k-mooneyand then get the mac for that17:29
artomWe have the network ID, not the port17:30
sean-k-mooneyis this not the port id https://github.com/openstack/nova/blob/master/nova/objects/virtual_interface.py#L4717:32
artomNO that17:32
artomThat's the VIF uuid itself17:32
sean-k-mooneywith is the VIF uuid?17:33
sean-k-mooneywhy would it need one?17:33
sean-k-mooneyalso is this really the unique constarit https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L860-L86117:33
*** _mlavalle_1 has quit IRC17:33
*** mlavalle has joined #openstack-nova17:34
*** jmlowe has quit IRC17:34
artomsean-k-mooney, IIRC there was something else higher up17:35
artom(About the constraint)17:35
sean-k-mooneywell that constiarint is wrong17:35
sean-k-mooneyit would only allow 1 instnace of the mac in a cell17:35
sean-k-mooneywhich is not required by neutorn17:35
artomMakes device tagging mostly work though ;)17:36
sean-k-mooneyim not sure we want to fix all the issue here in one patch17:37
sean-k-mooneywe could but im not sure you want to have to write db migrations to fix this17:37
sean-k-mooneythe uniqui constratint should be (address,deleted,uuid) if uuid is the network uuid17:39
artomsean-k-mooney, btw, just double checked, and the virtual_interface uuid does appear to be the interface UUID, not the port17:40
*** bbowen has joined #openstack-nova17:40
sean-k-mooneythe instance uuid should be in the instance_uuid field17:40
sean-k-mooneynot the uuid field17:40
artomI mean the virtual_interface has its own UUID, much like an instance17:41
artomDunno why, but that's what it is17:41
sean-k-mooneya ok17:41
artomI checked on my devstack, the UUIDs don't match between ports and virtal_interfaces17:42
sean-k-mooneyin that case the constratin would be (address,deleted,network_id)17:42
sean-k-mooneyok17:42
artomI don't disagree, but it has the side effect of allowing device tagging to work, and it's kinda too late to impose it now17:42
sean-k-mooneyit a fairly sever regression17:43
sean-k-mooneythat was intoduec a long time agp17:43
*** ralonsoh has quit IRC17:43
sean-k-mooneycan you try and boot two vms with ports that have the same mac on different network and see what happens?17:44
sean-k-mooneyi need to run to the shop to grab food for dinner17:44
artomSure, thanks for the help so far17:45
sean-k-mooneyill be back in an hour or so. for now i would suggest lets just fix the case we know is broken but should work17:45
artomI suppose17:45
sean-k-mooneywe can try and figureout how to make vfio-pci work as a sperate patch17:45
artomYeah, incremental improvement and all that17:46
sean-k-mooneyyep. i also agree with mriedem it would be nice to add a functional test for this if we can.17:46
sean-k-mooneyanyway ill be back in about an hour and a half after dinner17:47
artomThat's always the problem with functional tests - unless you *know* all the possible things the hardware can do, they're mostly useless17:47
*** ociuhandu_ has joined #openstack-nova17:47
mriedemi didn't necessary ask for a functional test,17:47
mriedemanything in functional testing for that would have to be stubbed with fakelibvirt anyway17:47
artomOtherwise you're essentially re-writing the same code, but shaped like a test17:47
mriedembbiab but i'll review https://review.opendev.org/#/c/667177/ when i get back17:48
artomAnd clearly I *don't* know all the possible things the hardware can do, that's why we're here in the first place17:48
*** ociuhandu has quit IRC17:49
*** ociuhandu_ has quit IRC17:52
sean-k-mooneyya i guess that is fair. i wont be back at my place in shannon until wednesday but i can look at recreating the vfio-pci case later this week or early next week.17:55
sean-k-mooneyi was assuming we would just extend https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_pci_sriov_servers.py to check metadtaa was generated.17:56
artomsean-k-mooney, for the record, 2 VMs with identical MACs on different networks (1 VM per network) work fine17:57
sean-k-mooneycool the unique constraint musts be changed somewhere17:59
artom... and actually, 1 VM with 2 ports, same MAC on both but different networks, also works fine17:59
artomWhich is... worrying17:59
*** jmlowe has joined #openstack-nova17:59
*** tesseract has quit IRC18:01
artomOh, the address is now being stored as MAC/port_uuid18:01
artomThis seems new...18:01
sean-k-mooneyoh right i rememebr that hack18:07
sean-k-mooneyok that makes sense18:07
sean-k-mooneywe did it that way because nova networks required a unique mac18:08
sean-k-mooneybut neutron did not18:08
artomSo https://review.opendev.org/#/c/304511/, which depends on MAC address global uniqueness (or at least per-instance uniqueness), merged the same say as https://review.opendev.org/#/c/336069/, which removed said uniquenss18:08
mriedemthat's from newton18:12
artomI know, I'm just going back in time and realizing that device tagging never fully worked18:12
dansmithWAT18:13
artomBecause if you had a VM with 2 identially-MAC'ed NICs, device tags could get switched around18:13
artomMost people probably have autogenerated MACs, so the likelihood of collisions is pretty low (made apparent by this not having been reported in 3 years), but still technically broken18:15
dansmithah well, that's less concerning to me I think18:16
dansmitha single machine with two identical macs on different networks would be confusing to the guest OS as well18:17
openstackgerritArtom Lifshitz proposed openstack/nova master: Device tags: don't pass pf_interface=True to get_mac_by_pci_address  https://review.opendev.org/67059318:27
openstackgerritArtom Lifshitz proposed openstack/nova master: WIP: Device tagging: expose target PCI address, not source  https://review.opendev.org/67212718:27
artommriedem, sean-k-mooney ^^18:27
artom(Thanks for hitting those backports!)18:28
mriedemyou didn't really need to rebase this... https://review.opendev.org/#/c/670593/1..218:29
sean-k-mooneydansmith: i think the usecase for identical mac on different networks had something to do with bonds/loadbalancing but its limited scope for when it actully makes sense18:34
dansmithsean-k-mooney: that only makes sense if you've got upstream filtering by the network or something.. normally boding two nics in linux uses two macs and the bonding agent chooses one18:34
sean-k-mooneyi know that people used to use it with sriov and custom physnets to force VF to come from differnet phyiscal  nic which they would bound in the guest18:35
sean-k-mooneyso they would create 2 netwroks with the same vlan on different physnets that were physically the same netwrok then create two ports with the same mac and bond them18:36
dansmithpresumably because neutron or ovs or whatever will not allow you to transmit as a different mac than the port expects right?18:37
sean-k-mooneydansmith: right the correct way to do it would be two mac and then use teh allow_adress pair extention to allow the ohter mac18:37
dansmithI understand the use as a workaround, but it's a nightmare for exactly this sort of confusion to nova and the guest inside18:37
sean-k-mooneyyes neutron mac anti spoofing rules would drop it if you didnt use the allowed adress pairs extention18:37
sean-k-mooneyat least for ovs18:38
dansmithaye18:38
sean-k-mooneyfor sriov i think it would similarly be drop by the nic unless you toll the nic specific ally to allow the other mac18:38
sean-k-mooneyim not sure if we support that or not18:38
*** jmlowe has quit IRC18:39
sean-k-mooneydansmith: but ya ist a pain in the ass and really just a hack18:39
artommriedem, failure to git review -R strikes again :(18:42
efriedartom: I think you skipped out the other day when I mentioned this, but you can put18:45
efried  [gitreview]18:45
efried  rebase = false18:45
efriedin your .gitconfig and you'll never have to remember -R again.18:45
artomefried, cheers for that18:46
artom(Though I think in this case I actually did a git rebase -i mindlessly when I realized I'd forgotten something in the patch below the new WIP one)18:47
*** efried is now known as efried_pto18:47
* efried_pto is out til tomorrow o/18:47
openstackgerritAndreas Jaeger proposed openstack/python-novaclient master: Update api-ref location  https://review.opendev.org/67213518:52
openstackgerritMatt Riedemann proposed openstack/nova master: Add FUP unit test for port heal allocations  https://review.opendev.org/67214219:06
sean-k-mooneygit review does not automaticlaly rebase19:07
sean-k-mooneyit check if the patch can be rebased/merged but it doesnt auto rebase19:08
sean-k-mooneyman git-review19:08
* sean-k-mooney wrong window19:09
mriedemmelwitt: i cherry picked this using the gerrit ui https://review.opendev.org/#/c/672038/19:10
mriedemso i'm not sure what merge conflict you're seeing19:10
melwittmriedem: I know. just saying when I cherry-pick -x it, the test conflicts. unless I've done something wrong19:11
mriedemi'm not sure why the gerrit ui wouldn't fail then19:13
mriedemusually the ui is pickier19:13
*** eharney has quit IRC19:23
openstackgerritMatt Riedemann proposed openstack/nova master: Correct project/user id descriptions for os-instance-actions  https://review.opendev.org/67002719:24
*** igordc has quit IRC19:27
*** Roamer` has quit IRC19:30
*** igordc has joined #openstack-nova19:30
mriedemeasy api-ref fix ^19:30
*** bbowen_ has joined #openstack-nova19:33
*** bbowen has quit IRC19:36
*** sean-k-mooney has quit IRC19:37
*** lbragstad has quit IRC19:37
*** sean-k-mooney has joined #openstack-nova19:39
openstackgerritArtom Lifshitz proposed openstack/nova stable/stein: libvirt: move checking CONF.my_ip to init_host()  https://review.opendev.org/67215419:44
openstackgerritArtom Lifshitz proposed openstack/nova stable/stein: libvirt: move checking CONF.my_ip to init_host()  https://review.opendev.org/67215419:47
openstackgerritArtom Lifshitz proposed openstack/nova stable/rocky: libvirt: move checking CONF.my_ip to init_host()  https://review.opendev.org/67215519:47
openstackgerritArtom Lifshitz proposed openstack/nova stable/stein: libvirt: move checking CONF.my_ip to init_host()  https://review.opendev.org/67215419:48
openstackgerritArtom Lifshitz proposed openstack/nova stable/rocky: libvirt: move checking CONF.my_ip to init_host()  https://review.opendev.org/67215519:49
openstackgerritArtom Lifshitz proposed openstack/nova stable/queens: libvirt: move checking CONF.my_ip to init_host()  https://review.opendev.org/67216120:00
*** eharney has joined #openstack-nova20:02
*** igordc has quit IRC20:03
*** maciejjozefczyk has quit IRC20:07
mriedemdansmith: Kevin_Zheng: maybe you have ideas on this spec https://review.opendev.org/#/c/667894/ - i feel like we've talked about this before, but in this case they basically just want to know who (among several admins) initiated a migration operation on a server. that could be determined via some existing APIs but it gets a bit clunky to handle client-side.20:07
*** igordc has joined #openstack-nova20:08
*** jmlowe has joined #openstack-nova20:10
*** bbowen_ has quit IRC20:24
dansmithugh20:24
openstackgerritArtom Lifshitz proposed openstack/nova stable/queens: libvirt: move checking CONF.my_ip to init_host()  https://review.opendev.org/67216120:30
*** ivve has joined #openstack-nova20:32
openstackgerritsean mooney proposed openstack/nova master: libvirt: harden get_domain_capabilities  https://review.opendev.org/67018920:37
openstackgerritsean mooney proposed openstack/nova master: Libvirt: report storage bus traits  https://review.opendev.org/66691420:37
openstackgerritsean mooney proposed openstack/nova master: use domain capablites to get supported device models  https://review.opendev.org/66691520:37
openstackgerritsean mooney proposed openstack/nova master: Add transform_image_metadata request filter  https://review.opendev.org/66577520:37
*** amodi has joined #openstack-nova20:38
*** luksky11 has joined #openstack-nova20:39
*** xek has quit IRC20:44
*** xek has joined #openstack-nova20:45
openstackgerritArtom Lifshitz proposed openstack/nova master: Pass migration to finish_revert_migration()  https://review.opendev.org/66863120:53
openstackgerritArtom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events  https://review.opendev.org/66444220:53
artomCheck it out, I updated a patch without giving reviewers a migraine because I rebased it20:54
*** vishwanathj has joined #openstack-nova20:57
*** whoami-rajat has quit IRC21:01
*** vishwanathj has quit IRC21:02
*** vishwanathj has joined #openstack-nova21:02
mriedemartom: +2 on that but remember to send the courtesy warning21:03
*** xek has quit IRC21:03
mriedemunless you already did21:03
*** xek has joined #openstack-nova21:04
*** mvkr_ has joined #openstack-nova21:04
artommriedem, not yet, I can send it now21:04
artomYour patch it below it, so it's not like a second +2 will send mine through the gate tomorrow21:05
artom(Not that your patch needs work, it just adds time)21:05
artomSent.21:09
*** pcaruana has quit IRC21:10
*** vishwanathj has quit IRC21:30
*** vishwanathj has joined #openstack-nova21:30
*** artom has quit IRC21:31
openstackgerritsean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif  https://review.opendev.org/60243221:33
*** vishwanathj has quit IRC21:35
*** luksky11 has quit IRC21:40
*** bbowen has joined #openstack-nova21:42
*** sean-k-mooney has quit IRC21:43
openstackgerritMerged openstack/nova stable/stein: Revert resize: wait for events according to hybrid plug  https://review.opendev.org/67064521:46
openstackgerritMerged openstack/nova master: Remove Newton-era min compute checks for server create with device tags  https://review.opendev.org/66952321:46
openstackgerritMerged openstack/nova master: nova-manage: heal port allocations  https://review.opendev.org/63795521:59
openstackgerritMerged openstack/nova master: Move consts from neutronv2/api to constants module  https://review.opendev.org/66894521:59
openstackgerritMerged openstack/nova master: Use neutron contants in cmd/manage.py  https://review.opendev.org/66894621:59
openstackgerritMerged openstack/nova master: Add 'resource_request' to neutronv2/constants  https://review.opendev.org/66894721:59
*** betherly has joined #openstack-nova22:00
*** slaweq has quit IRC22:01
*** betherly has quit IRC22:05
*** vishwanathj has joined #openstack-nova22:10
*** vishwanathj has quit IRC22:15
*** betherly has joined #openstack-nova22:23
*** betherly has quit IRC22:30
*** rcernin has joined #openstack-nova22:30
openstackgerritMatt Riedemann proposed openstack/nova master: Use the safe get_binding_profile  https://review.opendev.org/66981722:38
*** mriedem has quit IRC22:39
*** tkajinam has joined #openstack-nova22:39
openstackgerritDustin Cowles proposed openstack/nova master: Introduces the openstacksdk to nova  https://review.opendev.org/64366422:50
openstackgerritDustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get  https://review.opendev.org/64289922:50
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK for node.list  https://review.opendev.org/65602722:50
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK for validating instance and node  https://review.opendev.org/65602822:50
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK for setting instance id  https://review.opendev.org/65969022:50
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node  https://review.opendev.org/65969122:50
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node  https://review.opendev.org/67021322:50
*** ivve has quit IRC22:57
*** mlavalle has quit IRC23:00
*** artom has joined #openstack-nova23:05
*** vishwanathj has joined #openstack-nova23:20
*** threestrands has joined #openstack-nova23:42
*** TxGirlGeek has joined #openstack-nova23:54
*** TxGirlGeek has quit IRC23:56
*** jaypipes has quit IRC23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!