*** tbachman has quit IRC | 00:04 | |
*** slaweq has joined #openstack-nova | 00:11 | |
*** slaweq has quit IRC | 00:16 | |
*** tbachman has joined #openstack-nova | 00:23 | |
*** tetsuro has joined #openstack-nova | 00:55 | |
*** mkrai_ has joined #openstack-nova | 01:01 | |
*** ricolin has joined #openstack-nova | 01:01 | |
*** tbachman has quit IRC | 01:01 | |
*** tbachman has joined #openstack-nova | 01:03 | |
*** tbachman has quit IRC | 01:08 | |
*** ricolin has quit IRC | 01:31 | |
*** spatel has joined #openstack-nova | 01:33 | |
*** spatel has quit IRC | 01:36 | |
openstackgerrit | Merged openstack/nova master: Add functional recreate test for bug 1764556 https://review.opendev.org/562041 | 02:00 |
---|---|---|
openstack | bug 1764556 in OpenStack Compute (nova) ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Medium,In progress] https://launchpad.net/bugs/1764556 - Assigned to melanie witt (melwitt) | 02:00 |
*** tbachman has joined #openstack-nova | 02:00 | |
*** slaweq has joined #openstack-nova | 02:11 | |
*** mkrai_ has quit IRC | 02:11 | |
*** slaweq has quit IRC | 02:16 | |
*** tetsuro has quit IRC | 02:16 | |
*** tetsuro has joined #openstack-nova | 02:52 | |
*** rcernin has quit IRC | 02:57 | |
*** mkrai_ has joined #openstack-nova | 02:59 | |
*** rcernin has joined #openstack-nova | 03:13 | |
*** tetsuro has quit IRC | 03:28 | |
*** psachin has joined #openstack-nova | 03:37 | |
*** tbachman has quit IRC | 03:40 | |
*** tbachman has joined #openstack-nova | 03:45 | |
*** tetsuro has joined #openstack-nova | 03:46 | |
*** BjoernT has joined #openstack-nova | 03:55 | |
*** mkrai_ has quit IRC | 03:57 | |
*** mkrai has joined #openstack-nova | 03:57 | |
*** slaweq has joined #openstack-nova | 04:11 | |
*** slaweq has quit IRC | 04:16 | |
*** whoami-rajat has joined #openstack-nova | 04:19 | |
*** udesale has joined #openstack-nova | 04:20 | |
*** udesale has quit IRC | 04:21 | |
*** udesale has joined #openstack-nova | 04:21 | |
*** ratailor has joined #openstack-nova | 04:27 | |
*** Luzi has joined #openstack-nova | 04:30 | |
*** BjoernT has quit IRC | 04:36 | |
*** tkajinam has quit IRC | 05:04 | |
*** tkajinam has joined #openstack-nova | 05:05 | |
*** bhagyashris has joined #openstack-nova | 05:15 | |
*** ganso has quit IRC | 05:19 | |
*** ganso has joined #openstack-nova | 05:20 | |
*** boxiang_ has quit IRC | 05:21 | |
*** boxiang has joined #openstack-nova | 05:22 | |
*** gyee has quit IRC | 05:26 | |
*** jaosorior has quit IRC | 05:31 | |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242 | 05:36 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243 | 05:36 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | 05:36 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.opendev.org/631245 | 05:36 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Define new exceptions related to device profiles and ARQs. https://review.opendev.org/673733 | 05:36 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Refactor some methods for reuse by Cyborg code. https://review.opendev.org/673734 | 05:36 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735 | 05:36 |
*** ratailor has quit IRC | 05:39 | |
*** threestrands has joined #openstack-nova | 05:44 | |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243 | 05:47 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | 05:47 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.opendev.org/631245 | 05:47 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735 | 05:47 |
*** ratailor has joined #openstack-nova | 05:48 | |
*** mkrai has quit IRC | 06:08 | |
*** mkrai_ has joined #openstack-nova | 06:08 | |
*** slaweq has joined #openstack-nova | 06:11 | |
*** belmoreira has joined #openstack-nova | 06:13 | |
*** slaweq has quit IRC | 06:16 | |
*** kashyap has joined #openstack-nova | 06:22 | |
*** jaosorior has joined #openstack-nova | 06:23 | |
kashyap | aspiers: Morning, on the SEV experiment on Leap 15.0, I don't know you're getting stuck at the UEFI boot | 06:23 |
kashyap | aspiers: We can debug it when you're on. I'm hunkering down for a few hours to investigate something, so will be slow in the morning to respond. | 06:24 |
*** mkrai_ has quit IRC | 06:26 | |
*** mkrai__ has joined #openstack-nova | 06:26 | |
openstackgerrit | Merged openstack/nova master: Add functional regression test for bug 1778305 https://review.opendev.org/582407 | 06:32 |
openstack | bug 1778305 in OpenStack Compute (nova) "Nova may erronously look up service version of a deleted service, when hostname have been reused" [Medium,In progress] https://launchpad.net/bugs/1778305 - Assigned to melanie witt (melwitt) | 06:32 |
*** artom has quit IRC | 06:32 | |
*** artom has joined #openstack-nova | 06:33 | |
*** zhengMa has joined #openstack-nova | 06:37 | |
*** slaweq has joined #openstack-nova | 06:59 | |
*** rcernin has quit IRC | 07:02 | |
*** ratailor has quit IRC | 07:07 | |
*** ratailor has joined #openstack-nova | 07:08 | |
*** xek has joined #openstack-nova | 07:09 | |
*** takamatsu has quit IRC | 07:17 | |
*** brault has joined #openstack-nova | 07:19 | |
*** maciejjozefczyk has joined #openstack-nova | 07:19 | |
*** brault has quit IRC | 07:23 | |
*** udesale has quit IRC | 07:24 | |
*** udesale has joined #openstack-nova | 07:24 | |
*** tesseract has joined #openstack-nova | 07:27 | |
*** belmoreira has quit IRC | 07:28 | |
openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.opendev.org/621476 | 07:28 |
*** tssurya has joined #openstack-nova | 07:31 | |
*** mkrai__ has quit IRC | 07:34 | |
*** pcaruana has quit IRC | 07:35 | |
*** mkrai__ has joined #openstack-nova | 07:35 | |
*** ociuhandu has joined #openstack-nova | 07:35 | |
*** cdent has joined #openstack-nova | 07:36 | |
*** igordc has joined #openstack-nova | 07:37 | |
*** rpittau|afk is now known as rpittau | 07:37 | |
*** igordc has quit IRC | 07:38 | |
*** ociuhandu has quit IRC | 07:40 | |
*** ociuhandu has joined #openstack-nova | 07:44 | |
*** ociuhandu has quit IRC | 07:44 | |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Refactor some methods for reuse by Cyborg code. https://review.opendev.org/673734 | 07:51 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243 | 07:51 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | 07:51 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.opendev.org/631245 | 07:51 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735 | 07:51 |
*** betherly has joined #openstack-nova | 08:01 | |
*** belmoreira has joined #openstack-nova | 08:01 | |
*** dpawlik has joined #openstack-nova | 08:02 | |
*** mkrai__ has quit IRC | 08:03 | |
*** jaosorior has quit IRC | 08:03 | |
*** mkrai__ has joined #openstack-nova | 08:03 | |
*** lpetrut has joined #openstack-nova | 08:04 | |
*** tetsuro has quit IRC | 08:11 | |
*** ttsiouts has joined #openstack-nova | 08:11 | |
*** pcaruana has joined #openstack-nova | 08:13 | |
*** mkrai__ has quit IRC | 08:15 | |
*** ociuhandu has joined #openstack-nova | 08:15 | |
*** tetsuro has joined #openstack-nova | 08:17 | |
*** tkajinam has quit IRC | 08:19 | |
*** ttsiouts has quit IRC | 08:21 | |
*** ttsiouts has joined #openstack-nova | 08:22 | |
openstackgerrit | Merged openstack/nova master: Don't generate service UUID for deleted services https://review.opendev.org/582408 | 08:25 |
*** ttsiouts has quit IRC | 08:27 | |
*** mkrai__ has joined #openstack-nova | 08:27 | |
*** takamatsu has joined #openstack-nova | 08:32 | |
*** ttsiouts has joined #openstack-nova | 08:36 | |
*** derekh has joined #openstack-nova | 08:40 | |
*** ricolin has joined #openstack-nova | 08:40 | |
*** dikonoor has joined #openstack-nova | 08:43 | |
*** takamatsu_ has joined #openstack-nova | 08:48 | |
*** threestrands has quit IRC | 08:48 | |
*** takamatsu has quit IRC | 08:49 | |
*** panda has quit IRC | 08:58 | |
*** panda has joined #openstack-nova | 08:59 | |
*** jaosorior has joined #openstack-nova | 09:00 | |
*** belmoreira has quit IRC | 09:03 | |
*** ttsiouts has quit IRC | 09:05 | |
*** priteau has joined #openstack-nova | 09:05 | |
*** tetsuro has quit IRC | 09:06 | |
*** ttsiouts has joined #openstack-nova | 09:09 | |
*** ociuhandu has quit IRC | 09:12 | |
*** ociuhandu has joined #openstack-nova | 09:12 | |
*** ralonsoh has joined #openstack-nova | 09:13 | |
*** zhengMa has quit IRC | 09:17 | |
*** zhengMa has joined #openstack-nova | 09:22 | |
*** ttsiouts has quit IRC | 09:23 | |
*** ttsiouts has joined #openstack-nova | 09:24 | |
*** zhengMa has quit IRC | 09:25 | |
*** happy-ms-ge has joined #openstack-nova | 09:26 | |
*** ttsiouts has quit IRC | 09:28 | |
*** ivve has joined #openstack-nova | 09:28 | |
*** takamatsu_ has quit IRC | 09:30 | |
*** dikonoor has quit IRC | 09:36 | |
*** takamatsu has joined #openstack-nova | 09:37 | |
*** happy-ms-ge has quit IRC | 09:39 | |
*** betherly has quit IRC | 09:43 | |
*** ttsiouts has joined #openstack-nova | 09:45 | |
*** bhagyashris has quit IRC | 09:48 | |
*** jaosorior has quit IRC | 09:50 | |
openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.75: Support Specifying AZ to unshelve https://review.opendev.org/665136 | 09:52 |
*** ttsiouts has quit IRC | 10:00 | |
*** ttsiouts has joined #openstack-nova | 10:01 | |
*** ttsiouts has quit IRC | 10:06 | |
*** takamatsu has quit IRC | 10:08 | |
openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.75: Support Specifying AZ to unshelve https://review.opendev.org/665136 | 10:08 |
*** ratailor has quit IRC | 10:09 | |
*** ratailor has joined #openstack-nova | 10:10 | |
*** sapd1_x has joined #openstack-nova | 10:22 | |
*** takamatsu has joined #openstack-nova | 10:24 | |
*** lpetrut has quit IRC | 10:24 | |
*** cf__ has quit IRC | 10:26 | |
aspiers | kashyap: it's not urgent right now but I would like to get to the bottom of it. If you have any ideas let me know | 10:33 |
*** bbowen has joined #openstack-nova | 10:34 | |
kashyap | aspiers: Will do. Currently mired in parsing getDomainCapabilities(); /me is slow with it | 10:34 |
*** jaosorior has joined #openstack-nova | 10:34 | |
aspiers | kashyap: parsing how? | 10:35 |
aspiers | the UEFI bits? | 10:35 |
kashyap | aspiers: Yeah, /me gets a pastebin | 10:36 |
kashyap | Maybe you can get me out of the ditch :D | 10:36 |
kashyap | aspiers: http://paste.openstack.org/show/755161/ | 10:37 |
kashyap | Essentially: | 10:38 |
kashyap | # Only available from for libvirt 5.4 or above | 10:38 |
kashyap | $> virsh domcapabilities --machine q35 | xpath -q -e "//enum[@name='firmware']/value/text()" | 10:38 |
kashyap | efi | 10:38 |
kashyap | And this one (available for much older libvirts): | 10:39 |
kashyap | $> virsh domcapabilities --machine q35 | xpath -q -e "//loader/value/text()" | 10:39 |
kashyap | /usr/share/edk2/ovmf/OVMF_CODE.fd | 10:39 |
*** betherly has joined #openstack-nova | 10:44 | |
*** pcaruana has quit IRC | 10:45 | |
kashyap | aspiers: Ignore the pastebin; just spotted more problems w/ it | 10:46 |
aspiers | OK | 10:46 |
aspiers | I get Cannot open file '-q' at /usr/lib/perl5/vendor_perl/5.18.2/XML/XPath.pm line 53. | 10:46 |
aspiers | my xpath doesn't like -q or -e | 10:46 |
aspiers | from perl-XML-XPath-1.13-99.19.x86_64 | 10:47 |
*** belmoreira has joined #openstack-nova | 10:50 | |
*** ricolin_ has joined #openstack-nova | 11:01 | |
*** ricolin has quit IRC | 11:03 | |
*** ratailor has quit IRC | 11:10 | |
*** ratailor has joined #openstack-nova | 11:11 | |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Indroduce new LibvirtConfigGuestPMEM https://review.opendev.org/672956 | 11:13 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Populates existing pmems in libvirt device manager https://review.opendev.org/672957 | 11:13 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Report pmem namespaces resources by provider tree https://review.opendev.org/634551 | 11:13 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Support instance creation and resize with pmems https://review.opendev.org/672958 | 11:13 |
*** ttsiouts has joined #openstack-nova | 11:23 | |
*** fanzhang has joined #openstack-nova | 11:35 | |
*** ivve has quit IRC | 11:40 | |
fanzhang | Hey, I recently hit the bug https://bugs.launchpad.net/nova/+bug/1836204, and I was wondering why can't we just delete the mdevs after destroy the guest, and always create new mediated devices when booting instance? Is there any special reason why not clean mdevs up after deleting vms? | 11:41 |
openstack | Launchpad bug 1836204 in OpenStack Compute (nova) "The allocation of VGPU has race problem" [High,Triaged] - Assigned to Alex Xu (xuhj) | 11:41 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Parse the 'os' element from domainCapabilities https://review.opendev.org/673790 | 11:43 |
kashyap | aspiers: Okay, an idea for your problem | 11:44 |
* aspiers is listening | 11:44 | |
kashyap | aspiers: I learnt from Laszlo (OVMF maintainer) in the past that there's a QEMU debug port which captures OVMF error messages | 11:44 |
kashyap | aspiers: But, it requires you explicitly adding it in. This waY: | 11:44 |
kashyap | <qemu:commandline> | 11:45 |
kashyap | <qemu:arg value='-global'/> | 11:45 |
kashyap | <qemu:arg value='isa-debugcon.iobase=0x402'/> | 11:45 |
kashyap | <qemu:arg value='-debugcon'/> | 11:45 |
kashyap | <qemu:arg value='file:/tmp/ovmf.fedora.q35.log'/> | 11:45 |
kashyap | </qemu:commandline> | 11:45 |
kashyap | aspiers: To your test. (Yes, we're doing QEMU 'commandline' passthrough - because we're debugging) | 11:45 |
kashyap | s/test/guest/ | 11:45 |
kashyap | Then, the error message can be read there | 11:45 |
aspiers | I'm not expecting any error though | 11:46 |
aspiers | it just stops at the UEFI shell prompt | 11:46 |
aspiers | as if that's what was supposed to happen | 11:46 |
kashyap | Hmm. What is different in Leap, compared to SLES? | 11:46 |
*** udesale has quit IRC | 11:46 | |
aspiers | It's the same guest image | 11:46 |
aspiers | only the hypervisor stack changed | 11:47 |
kashyap | aspiers: And previously your host was Ubuntu? | 11:47 |
aspiers | what?! | 11:47 |
kashyap | Hehe | 11:47 |
aspiers | wash your mouth out! | 11:47 |
aspiers | heathen | 11:47 |
aspiers | ;-) | 11:47 |
*** udesale has joined #openstack-nova | 11:47 | |
kashyap | aspiers: I'm just trying to understand the env 'before' and 'after' | 11:48 |
aspiers | It was working fine on SLES12 SP4, broken on Leap 15.0 | 11:48 |
kashyap | Ah, okay. | 11:48 |
aspiers | which are supposed to be close IIRC | 11:48 |
*** jaosorior has quit IRC | 11:48 | |
kashyap | Right, Leap is upstream | 11:48 |
kashyap | aspiers: How about you try to create a guest from scratch on Leap 15.0? | 11:49 |
*** ociuhandu has quit IRC | 11:49 | |
kashyap | Ideally 'virt-install' + "kickstart" (assuming SUSE has such a concept, too) | 11:49 |
aspiers | autoyast | 11:50 |
kashyap | Right | 11:50 |
aspiers | I think I was writing ks.cfg files in the 1990s though | 11:50 |
aspiers | certainly a lot in the early 2000s | 11:50 |
kashyap | I just a plain minimal '@core' only | 11:50 |
*** ratailor has quit IRC | 11:51 | |
aspiers | autoyast was way more powerful, at least until 2010 | 11:51 |
kashyap | See the bits after "fkstart" here: https://kashyapc.fedorapeople.org/Create-a-SecureBoot-enabled-VM.bash | 11:51 |
aspiers | no idea these days | 11:51 |
kashyap | aspiers: You wouldn't believe, 10 years ago I _was_ using SUSE :-) | 11:51 |
aspiers | haha I would | 11:51 |
kashyap | Why wouldn't you believe? It's perfectly believable | 11:51 |
aspiers | many people did | 11:51 |
aspiers | especially in the 1990s | 11:51 |
kashyap | And my laptop has SUSE chamelon stickers, too | 11:52 |
aspiers | :-O | 11:52 |
aspiers | you didn't get fired for that? | 11:53 |
aspiers | X-D | 11:53 |
*** boxiang has quit IRC | 11:53 | |
kashyap | Not to mention: https://kashyapc.fedorapeople.org/geeko-key.jpg | 11:53 |
kashyap | aspiers: So back to the problem, I have no other ideas why it's stuck like that. Maybe as an experiment: re-install the image from scratch on Leap 15, _and_ try _that_ image on SLES12 SP4 | 11:55 |
aspiers | well the image was built in OBS using kiwi | 11:55 |
aspiers | not manually | 11:55 |
sean-k-mooney | aspiers: at least kashyap uses fedora as his distro on his laptop unlike me... | 11:55 |
kashyap | Hmm | 11:55 |
aspiers | ah you patched the win key, nice | 11:56 |
aspiers | sean-k-mooney: don't tell me, Ubuntu | 11:56 |
kashyap | I'm also an official Fedora packager. Also the Virt Stack support is unparalleled on Fedora. "Eating your own cooking" and all that. | 11:56 |
sean-k-mooney | aspiers: technically pop-OS but its based on ubuntu | 11:56 |
aspiers | We have a few SUSE employees who use Ubuntu as their base OS. My mind explodes every time I see it | 11:56 |
kashyap | aspiers: Unrelated, before I go for a break, I still need tests here, but please tell me if I did anything glaringly wrong: https://review.opendev.org/#/c/673790/ | 11:57 |
sean-k-mooney | aspiers: we also have people that use windows and mac | 11:57 |
aspiers | sean-k-mooney: I can almost understand that more | 11:57 |
sean-k-mooney | as long as you get your work donw people dont really care | 11:57 |
kashyap | sean-k-mooney: Not quite... | 11:57 |
aspiers | but if you're gonna use Linux, why not use the distro you're being paid to improve? | 11:57 |
sean-k-mooney | im not being paid to imporve it | 11:58 |
kashyap | I'd say, if you're at a Linux company, doing Linux-based dev. "Suffer the pain" and use Linux. | 11:58 |
sean-k-mooney | i dont work on rhel | 11:58 |
kashyap | No ifs, buts or maybes. | 11:58 |
aspiers | kashyap: I'm with you on this | 11:58 |
kashyap | It's not about "working on RHEL". | 11:58 |
sean-k-mooney | and i didnt join redhat for any of its products. i joined sole to work with people i enjoyed working with upstream | 11:58 |
* aspiers senses this conversation could rathole :) | 11:58 | |
sean-k-mooney | i am waiting for cento8 to come out however | 11:59 |
kashyap | Heh, yes | 11:59 |
sean-k-mooney | i would like to try it out | 11:59 |
aspiers | kashyap: you meant to add <enum> to the sparc fixture? | 12:00 |
aspiers | kashyap: https://review.opendev.org/#/c/673790/1/nova/virt/libvirt/config.py@165 that [] looks wrong | 12:01 |
aspiers | since you're not appending <os> to a list | 12:01 |
aspiers | kashyap: also please think about +1'ing https://review.opendev.org/#/c/348394/ as per my newest comment | 12:05 |
*** takamatsu has quit IRC | 12:10 | |
*** pcaruana has joined #openstack-nova | 12:10 | |
*** tbachman has quit IRC | 12:11 | |
kashyap | aspiers: Oh, right. That [] is wrong. Indeed, one 'os' element | 12:13 |
aspiers | Thank god I'm actually some use as a reviewer occasionally | 12:14 |
kashyap | aspiers: Don't be silly, you know you give useful remarks a lot of times | 12:14 |
aspiers | sometimes I wonder ;-) | 12:14 |
aspiers | journalctl -f | lnav is truly a gift from the gods | 12:14 |
aspiers | if you haven't discovered the joys of lnav, do so immediately | 12:14 |
aspiers | http://lnav.org/ | 12:15 |
kashyap | aspiers: On that other bug from Dirk -- I'll repost the patch with CentOS fix, too. And think more | 12:15 |
aspiers | kashyap: thanks. Yeah just upload a new patchset? | 12:15 |
kashyap | aspiers: Yea, brewing | 12:15 |
kashyap | aspiers: I take it that you've read my full comment on that patch; thanks | 12:16 |
kashyap | aspiers: On lnav - I noticed it, but haven't used it much | 12:16 |
aspiers | You should, it's insanely good | 12:16 |
aspiers | worth it for the histogram feature alone | 12:16 |
sean-k-mooney | yep | 12:16 |
sean-k-mooney | i found it like a year ago | 12:16 |
sean-k-mooney | its really nice | 12:16 |
aspiers | sean-k-mooney: did you know about "lnav -i extra" ? | 12:16 |
aspiers | my 3rd party repo gets included | 12:17 |
sean-k-mooney | i havent use that really but i like its ablity to filter things | 12:17 |
sean-k-mooney | no but -q should be on by default | 12:17 |
aspiers | sean-k-mooney: haha, did you see that issue? | 12:17 |
kashyap | aspiers: Installed; and began using. I heard it from sean-k-mooney, actually | 12:17 |
sean-k-mooney | is there an issue open for it | 12:17 |
kashyap | aspiers: Meanwhile, I take it that you haven't spotted anything _else_ that is spooky in https://review.opendev.org/#/c/673790/ | 12:18 |
aspiers | sean-k-mooney: https://github.com/tstack/lnav/issues/436 but it got closed because the author *still* isn't getting the point | 12:18 |
aspiers | about to comment | 12:18 |
sean-k-mooney | i have basically locked up my terminal after leaving the devstack logs open for a few days in it | 12:18 |
sean-k-mooney | anyway be right be time to grab coffee and post something by snail mail... | 12:20 |
sean-k-mooney | at least its not fax... | 12:20 |
* kashyap --> late lunch | 12:20 | |
*** kashyap has quit IRC | 12:20 | |
sean-k-mooney | my insurance company will acatully accept email copies of scans provided you eventually send them the forms which is nice | 12:21 |
* aspiers hates paper | 12:21 | |
aspiers | Jul 29 17:06:56 devstack systemd[1]: devstack@n-sch.service: Main process exited, code=dumped, status=11/SEGV | 12:22 |
aspiers | ummm... WTF?! | 12:22 |
*** ociuhandu has joined #openstack-nova | 12:22 | |
sean-k-mooney | that sound like the issue matt was hitting yesterday | 12:23 |
sean-k-mooney | are you using an old kernel or python 2? | 12:23 |
aspiers | python 2 | 12:23 |
aspiers | 4.12.14-95.24-default | 12:23 |
sean-k-mooney | on kernel? 4.15 ish? | 12:23 |
sean-k-mooney | ok older | 12:23 |
aspiers | is there a workaround/solution? | 12:23 |
sean-k-mooney | ya there may be an issue with one of our deps with python 2 and older kernels | 12:24 |
* aspiers reads scrollback | 12:24 | |
sean-k-mooney | we havnt track it down yet but if you can provide logs/version number it might help | 12:24 |
sean-k-mooney | you can try python3 | 12:24 |
aspiers | there's nothing useful in the log | 12:25 |
sean-k-mooney | just he seg fault | 12:25 |
aspiers | oh god | 12:25 |
aspiers | [35889.416395] cinder-volume[178403]: segfault at 7f2154837db7 ip 00007f20f299c9ca sp 00007ffea13d86d0 error 6 in libpython2.7.so.1.0[7f20f28b0000+1ac000] | 12:25 |
aspiers | not just nova | 12:25 |
sean-k-mooney | ya | 12:25 |
sean-k-mooney | are you using nested virt | 12:25 |
aspiers | no | 12:25 |
sean-k-mooney | ok so that rules out one possibelissue | 12:26 |
sean-k-mooney | matt was seeing similar isssues with python 2.7 on ubuntu 18.04 yesterday and last week | 12:26 |
aspiers | I guess I can try switching to python 3 | 12:27 |
aspiers | yikes | 12:27 |
sean-k-mooney | if leap 15 has python3 i would try that | 12:27 |
aspiers | this is not leap | 12:27 |
aspiers | sles12 sp4 | 12:27 |
*** fanzhang has quit IRC | 12:27 | |
aspiers | but yes leap and sles have both had python3 for years | 12:27 |
sean-k-mooney | make sure you use either 3.5 or 3.6 | 12:28 |
sean-k-mooney | we never really supported 3.4 and 3.7 may have issues | 12:28 |
aspiers | oh crap | 12:28 |
aspiers | default is 3.4.6 | 12:28 |
sean-k-mooney | 3.4 might work | 12:28 |
sean-k-mooney | we just never offially supported it | 12:28 |
sean-k-mooney | we went strait to 3.5 | 12:28 |
aspiers | ok | 12:28 |
*** takamatsu has joined #openstack-nova | 12:31 | |
stephenfin | gmann: Could you take a look at https://review.opendev.org/#/c/661391/ (DevStack stuff) when you've a chance? | 12:32 |
*** mchlumsky has joined #openstack-nova | 12:33 | |
aspiers | sean-k-mooney: https://github.com/tstack/lnav/issues/436#issuecomment-516829106 | 12:34 |
*** ivve has joined #openstack-nova | 12:35 | |
gmann | stephenfin: sure. do you have nova patch to test that ? only thing i want to verify is IPv6 job i added recently on nova gate works fine. I removed the setting of novnc addresses from base devstack job and let /lib/nova handle that. | 12:36 |
gmann | stephenfin: of let me add the same job on devstack on top of that patch which will test both. | 12:36 |
gmann | s/of/or | 12:36 |
*** priteau has quit IRC | 12:39 | |
*** psachin has quit IRC | 12:41 | |
*** jaosorior has joined #openstack-nova | 12:43 | |
aspiers | sean-k-mooney: I have a coredump now | 12:46 |
aspiers | sean-k-mooney: also https://github.com/aspiers/lnav-formats/blob/master/oslo_log.json | 12:46 |
aspiers | although I'm not sure that was necessary, it might be in other repos | 12:46 |
*** lpetrut has joined #openstack-nova | 12:50 | |
*** ricolin_ is now known as ricolin | 12:50 | |
stephenfin | gmann: Yeah, I think this one should do it https://review.opendev.org/#/c/667388/ | 12:51 |
gmann | stephenfin: thanks. rechecked that. | 12:54 |
*** Luzi has quit IRC | 12:54 | |
sean-k-mooney | aspiers: with python 3.4? | 12:56 |
aspiers | no | 12:56 |
aspiers | http://paste.openstack.org/show/755163/ | 12:56 |
sean-k-mooney | aspiers: also did you add oslo_log support to lnav as a plugin if so i might have to try that | 12:57 |
aspiers | sean-k-mooney: that's what the link above is | 12:57 |
aspiers | sean-k-mooney: it gets installed via "lnav -i extra" | 12:57 |
aspiers | just type that | 12:57 |
sean-k-mooney | ya i clicked and got confused with your core dump comment but imm looking at teh paste now | 12:58 |
*** lpetrut has quit IRC | 12:59 | |
*** lpetrut has joined #openstack-nova | 12:59 | |
sean-k-mooney | hum well i cant really tell what cased that seg fault other thin it appers to be a result of a getattr call on a randomp python object. so ill blame eventlest by default if you can repoduce with the pytho debuger instad of gdb that might help | 13:03 |
sean-k-mooney | aspiers: can you try running the conductor with pdb | 13:05 |
aspiers | sean-k-mooney: I'm trying to install the python gdb extensions so I can get the Python stacktrace | 13:05 |
aspiers | sean-k-mooney: I guess that might work too | 13:05 |
*** ivve has quit IRC | 13:06 | |
sean-k-mooney | i think its dieing pretty early in the nova-condoctor console script that is generated via pbr/setup tools | 13:07 |
aspiers | sean-k-mooney: what's the best way to start it? | 13:07 |
aspiers | oh wow | 13:08 |
aspiers | ● devstack@n-sch.service loaded failed failed Devstack devstack@n-sch.service | 13:08 |
aspiers | ● devstack@n-super-cond.service loaded failed failed Devstack devstack@n-super-cond.service | 13:08 |
aspiers | ● devstack@s-proxy.service loaded failed failed Devstack devstack@s-proxy.service | 13:08 |
aspiers | I've had 6 crashes in the last hour | 13:08 |
sean-k-mooney | i think just "pdb /usr/bin/python /usr/bin/nova-conductor --config-file /etc/nova/nova.conf" maybe with sudo | 13:08 |
sean-k-mooney | ya one of our deps really dislikes python2.7 apparently | 13:11 |
sean-k-mooney | was this a clean sles 14 deployment | 13:12 |
sean-k-mooney | im wondering if i can quickly spin up an container or something and try and repoduce | 13:12 |
*** tbachman has joined #openstack-nova | 13:13 | |
aspiers | gah | 13:17 |
aspiers | I just lost connection to the node | 13:18 |
*** brtknr has left #openstack-nova | 13:18 | |
sean-k-mooney | did you check dmesg before | 13:18 |
sean-k-mooney | there may have been other core dumps or crashes | 13:18 |
aspiers | coredumpctl shows them all | 13:19 |
aspiers | all 6 | 13:19 |
sean-k-mooney | all openstack services | 13:19 |
*** tesseract has quit IRC | 13:20 | |
*** tesseract has joined #openstack-nova | 13:24 | |
aspiers | no, just a few | 13:25 |
*** ttsiouts has quit IRC | 13:25 | |
*** ttsiouts has joined #openstack-nova | 13:26 | |
*** bbowen has quit IRC | 13:26 | |
sean-k-mooney | i ment were the 6 core dumps form opensack not did all the openstack services core dump | 13:26 |
aspiers | yes all openstack I think | 13:26 |
*** mriedem has joined #openstack-nova | 13:27 | |
aspiers | but I can't check because my connection died | 13:27 |
sean-k-mooney | maybe ssh coredumped... | 13:27 |
*** bbowen has joined #openstack-nova | 13:27 | |
aspiers | nope | 13:27 |
aspiers | no longer pingable | 13:27 |
sean-k-mooney | it could be a full kernel panic | 13:28 |
aspiers | well aren't you the optimist :) | 13:28 |
sean-k-mooney | do you have acess to the system to check? | 13:28 |
aspiers | maybe a PSU caught fire, and now the whole DC is a raging inferno | 13:28 |
aspiers | my colleague is checking via remote console | 13:28 |
aspiers | I'm going back to figure out why cloud-init is so broken | 13:29 |
*** bbowen has quit IRC | 13:29 | |
sean-k-mooney | sure :) let me know if they find anything via the remote console | 13:29 |
*** bbowen has joined #openstack-nova | 13:30 | |
aspiers | will do | 13:30 |
*** BjoernT has joined #openstack-nova | 13:30 | |
*** ttsiouts has quit IRC | 13:31 | |
*** ivve has joined #openstack-nova | 13:37 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Add functional recreate test for bug 1764556 https://review.opendev.org/673812 | 13:39 |
openstack | bug 1764556 in OpenStack Compute (nova) stein ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Medium,Confirmed] https://launchpad.net/bugs/1764556 | 13:39 |
*** ociuhandu has quit IRC | 13:39 | |
*** ociuhandu has joined #openstack-nova | 13:39 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Add functional regression test for bug 1778305 https://review.opendev.org/673813 | 13:40 |
openstack | bug 1778305 in OpenStack Compute (nova) stein "Nova may erronously look up service version of a deleted service, when hostname have been reused" [Medium,Confirmed] https://launchpad.net/bugs/1778305 | 13:40 |
*** spatel has joined #openstack-nova | 13:40 | |
*** ttsiouts has joined #openstack-nova | 13:41 | |
*** BjoernT_ has joined #openstack-nova | 13:42 | |
*** belmoreira has quit IRC | 13:43 | |
*** BjoernT has quit IRC | 13:44 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Don't generate service UUID for deleted services https://review.opendev.org/673814 | 13:44 |
*** belmoreira has joined #openstack-nova | 13:45 | |
*** spatel has quit IRC | 13:45 | |
*** liuyulong has joined #openstack-nova | 13:46 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add functional recreate test for bug 1764556 https://review.opendev.org/673816 | 13:48 |
openstack | bug 1764556 in OpenStack Compute (nova) stein ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Medium,In progress] https://launchpad.net/bugs/1764556 - Assigned to Matt Riedemann (mriedem) | 13:48 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add functional regression test for bug 1778305 https://review.opendev.org/673818 | 13:52 |
openstack | bug 1778305 in OpenStack Compute (nova) stein "Nova may erronously look up service version of a deleted service, when hostname have been reused" [Medium,In progress] https://launchpad.net/bugs/1778305 - Assigned to Matt Riedemann (mriedem) | 13:52 |
mriedem | lyarwood: could you poke https://review.opendev.org/#/c/673532/1 and the one above? | 13:54 |
*** eharney has joined #openstack-nova | 13:55 | |
*** belmoreira has quit IRC | 13:56 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Don't generate service UUID for deleted services https://review.opendev.org/673821 | 13:57 |
*** spatel has joined #openstack-nova | 13:59 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Add functional recreate test for bug 1764556 https://review.opendev.org/673824 | 14:00 |
openstack | bug 1764556 in OpenStack Compute (nova) stein ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Medium,In progress] https://launchpad.net/bugs/1764556 - Assigned to Matt Riedemann (mriedem) | 14:00 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Add functional regression test for bug 1778305 https://review.opendev.org/673825 | 14:01 |
openstack | bug 1778305 in OpenStack Compute (nova) stein "Nova may erronously look up service version of a deleted service, when hostname have been reused" [Medium,In progress] https://launchpad.net/bugs/1778305 - Assigned to Matt Riedemann (mriedem) | 14:01 |
lyarwood | mriedem: yup will try to get to them today | 14:02 |
mriedem | thanks | 14:03 |
*** spatel has quit IRC | 14:03 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Don't generate service UUID for deleted services https://review.opendev.org/673827 | 14:04 |
*** boxiang has joined #openstack-nova | 14:12 | |
*** belmoreira has joined #openstack-nova | 14:15 | |
*** brinzhang_ has quit IRC | 14:17 | |
*** brinzhang_ has joined #openstack-nova | 14:18 | |
*** brinzhang_ has joined #openstack-nova | 14:18 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add functional recreate test for bug 1764556 https://review.opendev.org/673830 | 14:20 |
openstack | bug 1764556 in OpenStack Compute (nova) stein ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Medium,In progress] https://launchpad.net/bugs/1764556 - Assigned to Matt Riedemann (mriedem) | 14:20 |
boxiang | mriedem: efried: gibi_off: two patches about live-migration and evacuation need to review https://review.opendev.org/#/c/649963/ https://review.opendev.org/#/c/651969/ | 14:20 |
mriedem | it'd be nice if mdbooth could look at the evacuate one since he also wrote https://review.openstack.org/#/c/605436/ - would also be nice if cfriesen were around to review those since i know starlingx has patches for these same issues | 14:21 |
*** brinzhang has quit IRC | 14:21 | |
mriedem | i'd prefer a functional test on https://review.opendev.org/#/c/651969/13 since i don't really trust unit tests for this kind of stuff | 14:21 |
mriedem | gibi is out until next week i think | 14:22 |
boxiang | ok, so I will add a functional test for this https://review.opendev.org/#/c/651969/13 | 14:23 |
* mdbooth notes that his already has that: https://review.opendev.org/#/c/605436/9/nova/tests/functional/regressions/test_bug_1735407.py | 14:23 | |
mdbooth | Meh | 14:23 |
boxiang | hi mdbooth | 14:23 |
mdbooth | Duplicated effort is the best effort | 14:23 |
boxiang | can you take a look for my two patches, thanks | 14:24 |
*** betherly has quit IRC | 14:24 | |
mdbooth | boxiang: Not any time soon, unfortunately. Working on stuff that might get used instead. | 14:25 |
*** takamatsu has quit IRC | 14:28 | |
*** sapd1_x has quit IRC | 14:30 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add functional regression test for bug 1778305 https://review.opendev.org/673832 | 14:31 |
openstack | bug 1778305 in OpenStack Compute (nova) stein "Nova may erronously look up service version of a deleted service, when hostname have been reused" [Medium,In progress] https://launchpad.net/bugs/1778305 - Assigned to Matt Riedemann (mriedem) | 14:31 |
mriedem | mdbooth: i meant the live migration patch, not the evacuate one | 14:31 |
*** trident has quit IRC | 14:32 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Don't generate service UUID for deleted services https://review.opendev.org/673833 | 14:33 |
sean-k-mooney | by the way https://review.opendev.org/#/c/669738/ has been sitting for a while is mainly functional tests | 14:33 |
sean-k-mooney | mdbooth: are you ok with this^ | 14:34 |
sean-k-mooney | mdbooth: i have your patch rebased on top | 14:34 |
sean-k-mooney | mriedem: i also added functional test as you requested since you last looked | 14:35 |
mdbooth | sean-k-mooney: Yep. IIRC that's what we discussed previously. | 14:35 |
sean-k-mooney | i think the backport is still on hold for the orginal change | 14:35 |
mriedem | dustinc: in case you haven't seen since i didn't vote, i've got some concerns in the base ironic+sdk patch https://review.opendev.org/#/c/642899/33 | 14:36 |
*** trident has joined #openstack-nova | 14:36 | |
sean-k-mooney | i belive my change can be applied to stable/X without breaking anything then the other chagne can be stacked on top | 14:36 |
mriedem | ugly tracebacks in the logs when nova-compute starts up before ironic-api is available | 14:36 |
*** boxiang has quit IRC | 14:36 | |
*** boxiang has joined #openstack-nova | 14:37 | |
dustinc | mriedem: been a bit distracted but did notice and will be looking into it when I get some time. Much appreciated! | 14:37 |
*** tbachman has quit IRC | 14:38 | |
*** dpawlik has quit IRC | 14:38 | |
*** trident has quit IRC | 14:47 | |
*** kashyap has joined #openstack-nova | 14:49 | |
*** trident has joined #openstack-nova | 14:50 | |
*** belmoreira has quit IRC | 14:51 | |
*** boxiang has quit IRC | 14:57 | |
*** prometheanfire has joined #openstack-nova | 14:58 | |
prometheanfire | I suspect that the new lxml has some ordering issues or something | 14:58 |
prometheanfire | http://logs.openstack.org/60/673160/3/check/cross-nova-py36/547e78c/testr_results.html.gz | 14:58 |
*** trident has quit IRC | 15:00 | |
*** trident has joined #openstack-nova | 15:03 | |
*** belmoreira has joined #openstack-nova | 15:03 | |
openstackgerrit | Merged openstack/nova master: Fix AttributeError in RT._update_usage_from_migration https://review.opendev.org/667687 | 15:04 |
openstackgerrit | Merged openstack/nova master: Fix RT init arg order in test_unsupported_move_type https://review.opendev.org/667688 | 15:04 |
*** zhengMa has joined #openstack-nova | 15:06 | |
*** zhengMa has left #openstack-nova | 15:06 | |
*** trident has quit IRC | 15:08 | |
openstackgerrit | ZhengMa proposed openstack/nova master: Check container_format on instance creation https://review.opendev.org/673407 | 15:15 |
*** trident has joined #openstack-nova | 15:16 | |
*** mlavalle has joined #openstack-nova | 15:18 | |
sean-k-mooney | prometheanfire: those xml fragment look identical so ya maybe | 15:19 |
*** zhengMa has joined #openstack-nova | 15:20 | |
*** trident has quit IRC | 15:24 | |
prometheanfire | kk, testing https://review.opendev.org/673848 | 15:25 |
*** bbowen has quit IRC | 15:26 | |
*** trident has joined #openstack-nova | 15:27 | |
mriedem | sean-k-mooney: comments in https://review.opendev.org/#/c/669738/ | 15:33 |
mriedem | maybe i'm just dumb | 15:34 |
*** tbachman has joined #openstack-nova | 15:34 | |
*** lpetrut has quit IRC | 15:34 | |
*** cdent has quit IRC | 15:34 | |
*** trident has quit IRC | 15:35 | |
sean-k-mooney | mriedem: thanks ill chack | 15:36 |
aspiers | sean-k-mooney: the new filter editor in lnav 0.8.5 is awesome (press tab) | 15:37 |
*** trident has joined #openstack-nova | 15:38 | |
*** ttsiouts has quit IRC | 15:42 | |
*** ttsiouts has joined #openstack-nova | 15:42 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Fix AttributeError in RT._update_usage_from_migration https://review.opendev.org/673856 | 15:45 |
*** tssurya has quit IRC | 15:46 | |
*** ttsiouts has quit IRC | 15:47 | |
*** belmoreira has quit IRC | 15:50 | |
*** gyee has joined #openstack-nova | 15:52 | |
*** nafiux has joined #openstack-nova | 15:56 | |
*** efried is now known as efried_rollin | 15:57 | |
nafiux | Good morning team, I’m trying to configure allocation ratio for CPU and Memory, but I’m getting this error from nova-scheduler: “Got no allocation candidates from the Placement API. This could be due to insufficient resources or a temporary occurrence as compute nodes start up.” | 15:57 |
openstackgerrit | Merged openstack/nova master: Introduces the openstacksdk to nova https://review.opendev.org/643664 | 15:57 |
openstackgerrit | Merged openstack/nova master: Use OpenStack SDK for placement https://review.opendev.org/656023 | 15:57 |
*** icarusfactor has joined #openstack-nova | 15:58 | |
nafiux | Any hint on how to setup that properly? | 15:58 |
*** ociuhandu has quit IRC | 15:59 | |
nafiux | I’m using kolla-ansible for deployment, and I already created the “/etc/kolla/config/nova/localhost/nova.conf” file which contains: cpu_allocation_ratio = 16.0 & ram_allocation_ratio = 5.0 under [DEFAULT] | 15:59 |
*** factor has quit IRC | 15:59 | |
*** mkrai__ has quit IRC | 16:06 | |
*** Sundar has joined #openstack-nova | 16:06 | |
mriedem | which release? do you even have compute nodes reporting into placement? i.e. does "openstack resource provider list" return anything? | 16:11 |
mriedem | https://docs.openstack.org/osc-placement/latest/ | 16:12 |
mriedem | https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allocation-ratios | 16:12 |
*** lpetrut has joined #openstack-nova | 16:14 | |
*** lpetrut has quit IRC | 16:15 | |
mriedem | efried_rollin: random musing in https://review.opendev.org/#/c/673706/ but i'll likely abandon that change and open a new bug for the other spurious warning in there | 16:15 |
*** lpetrut has joined #openstack-nova | 16:15 | |
*** gyee has quit IRC | 16:16 | |
*** trident has quit IRC | 16:16 | |
*** gyee has joined #openstack-nova | 16:17 | |
*** rpittau is now known as rpittau|afk | 16:18 | |
nafiux | “openstack resource provider list” isn’t found, should I install any additional python CLI package? | 16:19 |
nafiux | Oh, I saw… “pip install osc-placement”, let me try. | 16:20 |
*** xek has quit IRC | 16:20 | |
nafiux | Yes, I’m getting a node there | 16:20 |
*** trident has joined #openstack-nova | 16:21 | |
Sundar | Hi all, compute/manager.py::build_and_run_instance() (https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1859) requires the request_spec as an argument. But many unit test cases (e.g. https://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_compute.py#L9305) call it without the request_spec, which causes some u | 16:26 |
Sundar | nit tests to fail. Is this really kosher? | 16:26 |
*** mkrai__ has joined #openstack-nova | 16:30 | |
*** nafiux has quit IRC | 16:34 | |
*** mkrai__ has quit IRC | 16:34 | |
*** ociuhandu has joined #openstack-nova | 16:35 | |
*** igordc has joined #openstack-nova | 16:36 | |
melwitt | Sundar: that unit test is not doing something ideal by passing {} for those args. in the case where the args are not relevant to what's being tested, it's recommended to use mock.ANY instead. what do you mean by "causes some unit tests to fail"? | 16:37 |
*** lpetrut has quit IRC | 16:37 | |
*** panda has quit IRC | 16:39 | |
*** panda has joined #openstack-nova | 16:41 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: rt: soften warning case in _remove_deleted_instances_allocations https://review.opendev.org/673873 | 16:45 |
mriedem | Sundar: first thing is i'd avoid copying unit tests from the test_compute module, | 16:46 |
mriedem | base your tests off test_compute_mgr if you're looking for existing tests to start from | 16:47 |
*** takamatsu has joined #openstack-nova | 16:47 | |
mriedem | test_compute.py is historically running actual services and using the db, so it's more functional than unit-y | 16:47 |
mriedem | reserve more complicated tests for actual functional tests with fixtures and such | 16:47 |
*** trident has quit IRC | 16:48 | |
mriedem | like mel said, if your test doesn't care about the param, pass a Mock, else pass an actual nova.objects.RequestSpec object, not a dict | 16:48 |
*** zhengMa has quit IRC | 16:48 | |
mriedem | request specs as dicts are super legacy | 16:48 |
*** lpetrut has joined #openstack-nova | 16:48 | |
*** ricolin has quit IRC | 16:50 | |
*** trident has joined #openstack-nova | 16:51 | |
*** ociuhandu has quit IRC | 16:52 | |
*** BjoernT_ has quit IRC | 16:56 | |
*** derekh has quit IRC | 16:57 | |
*** takamatsu has quit IRC | 16:59 | |
*** lpetrut has quit IRC | 17:01 | |
*** BjoernT has joined #openstack-nova | 17:01 | |
*** BjoernT has quit IRC | 17:05 | |
Sundar | mriedem, melwitt: Sorry, was in a call. I am referring to existing Nova unit tests e.g. https://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_compute.py#L9305. My patches do not anything with flavors etc. but are failing due to this issue: http://logs.openstack.org/44/631244/25/check/openstack-tox-py27/f76bf93/job-output.txt.gz | 17:09 |
Sundar | #_2019-07-31_10_21_40_684847 | 17:09 |
Sundar | mriedem, melwitt: Sorry, was in a call. I am referring to existing Nova unit tests e.g. https://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_compute.py#L9305. My patches do not anything with flavors etc. but are failing due to this issue: http://logs.openstack.org/44/631244/25/check/openstack-tox-py27/f76bf93/job-output.txt.gz | 17:09 |
Sundar | #_2019-07-31_10_21_40_684847 | 17:09 |
*** icarusfactor has quit IRC | 17:10 | |
Sundar | [Yikes, message got duplicated] | 17:10 |
Sundar | IOW, these are not new test cases I am introducing. | 17:10 |
*** factor has joined #openstack-nova | 17:11 | |
melwitt | yeah, so that makes sense considering the code you added. you'll just need to adjust the unit tests to accommodate the new code, like making the test pass Mock objects instead of empty dicts like it is doing right now | 17:11 |
melwitt | this is a common thing, when adding new code, often existing unit tests will need to be adjusted along with the change. in this particular case, you uncovered a legacy thing (passing {} for objects) that should not be that way | 17:14 |
*** nafiux has joined #openstack-nova | 17:16 | |
* stephenfin notes mypy will help highlight these issues in our tests once we can start using it in U | 17:18 | |
Sundar | melwitt: Yes, I know. But there are a lot of unit tests like that. :( Was hoping to get some alternatives. | 17:19 |
*** ociuhandu has joined #openstack-nova | 17:21 | |
Sundar | melwitt, mriedem: I could adjust my code to check if request_spec is None. Hope that is also acceptable. | 17:22 |
*** ociuhandu has quit IRC | 17:26 | |
melwitt | if there's a chance for request_spec to be None in reality, then that would work. if not, it's not really ok to do something in the impl just to get around unit tests that should be fixed. I'm not as well-versed about request_spec as mriedem, he probably would know most whether request_spec could possibly be None in this case | 17:27 |
*** udesale has quit IRC | 17:27 | |
*** factor has quit IRC | 17:29 | |
Sundar | melwitt: Kinda expected that response, but tried my luck anyway. ;) Thank you. | 17:31 |
*** igordc has quit IRC | 17:32 | |
mriedem | Sundar: for tests that hit this code https://review.opendev.org/#/c/631244/25/nova/compute/manager.py@1865 you should be passing a real RequestSpec object. for *existing* tests hitting that code, if they are passing {} or None or something, then they need to be updated to pass either a RequestSpec object or a Mock | 17:40 |
mriedem | or, to simply mock out _create_and_bind_arqs | 17:41 |
mriedem | since those existing tests don't care about the details of that method | 17:41 |
mriedem | and your *new* tests would call _create_and_bind_arqs directly | 17:41 |
mriedem | with a RequestSpec object | 17:41 |
mriedem | - Failed: 159 | 17:41 |
mriedem | yikes | 17:41 |
mriedem | i'm guessing that's a lot of cumulative failures since it's later in the series | 17:41 |
mriedem | i.e. https://review.opendev.org/#/c/631243/27 | 17:42 |
Sundar | mriedem: Thanks. I counted 272 errors of that type over all. Mocking _create_and_bind_arqs is certainly easier. | 17:45 |
melwitt | Sundar: a bit of advice, what I would do in this situation is write the impl and get the tempest tests passing (I assume something has been or needs to be set up that runs cyborg in it) first, get some review feedback once tempest coverage is passing, then fix the unit test and func test failures after you get some code review. that way you don't have to go through the work to fix hundreds of tests when the impl might change during | 17:45 |
melwitt | code review | 17:45 |
mriedem | yeah, or just mock out the thing semi-globally to start, | 17:46 |
mriedem | e.g. in the patch that is failing tests on _create_and_bind_arqs, just stub that out in the test class setUp | 17:47 |
mriedem | melwitt: the tricky thing with tempest and this series is there is no tempest coverage with cyborg yet, | 17:47 |
mriedem | when there is, it'll be a fake cyborg driver, | 17:47 |
mriedem | but cyborg isn't hooked up with all of that yet, not even placement | 17:47 |
mriedem | so tempest is a loooong ways off | 17:47 |
melwitt | oh :\ ok | 17:48 |
Sundar | melwitt: Makes sense. mriedem: We are setting up tempest: https://review.opendev.org/#/c/670999/ | 17:48 |
*** maciejjozefczyk has quit IRC | 17:48 | |
Sundar | But I agree it is tough to predict when it'll land. | 17:49 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider config file schema and loader https://review.opendev.org/673341 | 17:49 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider config file schema and loader https://review.opendev.org/673341 | 17:52 |
*** ralonsoh has quit IRC | 17:57 | |
*** kashyap has quit IRC | 18:04 | |
*** tesseract has quit IRC | 18:05 | |
mriedem | melwitt: looks like https://review.opendev.org/#/c/668123/3 is ready to go in queens | 18:07 |
mriedem | lee was wanting that one | 18:07 |
melwitt | a-ha, cool. will review | 18:09 |
openstackgerrit | Merged openstack/nova master: Get rid of args to RBDDriver.__init__() https://review.opendev.org/668564 | 18:10 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Handle alternative UEFI firmware binary paths https://review.opendev.org/348394 | 18:15 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Parse the 'os' element from domainCapabilities https://review.opendev.org/673790 | 18:15 |
*** Sundar has quit IRC | 18:16 | |
*** altlogbot_1 has quit IRC | 18:19 | |
*** altlogbot_2 has joined #openstack-nova | 18:20 | |
nafiux | Team, what should I do to properly configure the overcommit of resources? I’m getting this error: “Got no allocation candidates from the Placement API. This could be due to insufficient resources or a temporary occurrence as compute nodes start up.” | 18:23 |
*** bbowen has joined #openstack-nova | 18:25 | |
mriedem | efried_rollin: since i'm not sure how this whole series works, i didn't vote on https://review.opendev.org/#/c/671072/2 but not sure if that should be using a set or list for forbidden_aggregates | 18:30 |
mriedem | nafiux: you said you listed some resource providers, did you check their inventories to see that they have the allocation_ratio values you configured in nova? you also didn't say what release you were using. | 18:30 |
mriedem | https://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-inventory-list | 18:30 |
nafiux | Thanks @mriedem. I’m using stein. Let me take a look on that documentation. | 18:31 |
nafiux | Here what I have: https://pastebin.com/MdXsJYs3 | 18:33 |
mriedem | nafiux: and https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#allocation-ratios if you didn't read that yet | 18:33 |
*** spatel has joined #openstack-nova | 18:33 | |
spatel | sean-k-mooney: are you there? | 18:33 |
mriedem | yeah so your compute nodes configured ram_allocation_ratio is being reported in the MEMORY_MB inventory for the provider | 18:33 |
mriedem | | MEMORY_MB | 5.0 | 49139 | 512 | 1 | 1 | 49139 | | 18:33 |
mriedem | that looks fine | 18:33 |
sean-k-mooney | spatel: kind of yes | 18:33 |
mriedem | nafiux: is this a fresh deploy or do you already have some servers on that node? | 18:34 |
nafiux | It’s a fresh deployment, I don’t have any instance running at this point. I used kolla-ansible. I checked the /etc/nova/nova.conf inside the nova_scheduler container and I was able to see the allocation values: | 18:35 |
nafiux | docker exec -it nova_scheduler bash | 18:35 |
spatel | Good, I have machine with 64G and with this setting in grub hugepagesz=2M hugepages=27500 | 18:35 |
spatel | I have this flavor setting - properties | hw:cpu_policy='dedicated', hw:mem_page_size='large', hw:numa_nodes='2' | 18:35 |
nafiux | vi /etc/nova/nova.conf, and I can see inside [DEFAULT] the cpu_allocation_ratio = 16.0 and ram_allocation_ratio = 5.0 | 18:35 |
nafiux | I’m able to launch a server with 16GB of Ram and 8 VPCU, but I’m not able to launch a second one. | 18:36 |
nafiux | Let me launch one, and provide you the report again. | 18:36 |
*** igordc has joined #openstack-nova | 18:36 | |
spatel | flavor has 8vcpu / 12G memory | 18:37 |
spatel | trying to create 2 VM but getting error, but i am able to create 1 vm ( not able to create 2) | 18:37 |
sean-k-mooney | you should have enough hugepages although the kerenl may not alwasys blance it perfectly | 18:38 |
sean-k-mooney | you have enough clearance however that that should not be the issue | 18:38 |
sean-k-mooney | how many cpu to you have | 18:39 |
spatel | 32 core | 18:39 |
-spatel- [root@ostack-compute-bld-gen-2-31 ~]# cat /sys/devices/system/node/node*/meminfo | fgrep Huge | 18:39 | |
-spatel- Node 0 AnonHugePages: 0 kB | 18:39 | |
-spatel- Node 0 HugePages_Total: 13750 | 18:39 | |
-spatel- Node 0 HugePages_Free: 10500 | 18:39 | |
-spatel- Node 0 HugePages_Surp: 0 | 18:39 | |
-spatel- Node 1 AnonHugePages: 0 kB | 18:39 | |
-spatel- Node 1 HugePages_Total: 13750 | 18:39 | |
-spatel- Node 1 HugePages_Free: 10500 | 18:39 | |
-spatel- Node 1 HugePages_Surp: 0 | 18:39 | |
nafiux | @mriedem: I was able to launch the first one, but whe I try to launch the second one I got the “Got no allocation candidates from the Placement API.” error | 18:39 |
sean-k-mooney | you have ~20G free per numa node and you need 12 so it should not be hugepage related | 18:40 |
sean-k-mooney | you have 32 cores is htat 2 16 core cpus or 2 8 core cpus with hyperthread or 1 32 core cpus | 18:41 |
mriedem | nafiux: how much disk in the flavor? or are these volume-backed servers? | 18:41 |
mriedem | nafiux: the placement-api also logs the allocation candidate filtering it does so you should trace the requestid through the placement logs - might need to enable debug | 18:41 |
spatel | sean-k-mooney: that is what i am trying to find.. what is wrong here :( | 18:41 |
sean-k-mooney | spatel: it would be useful to know what the vcpu_pin_set is set to in your nova.conf | 18:42 |
mriedem | that should tell you why it kicked out the provider | 18:42 |
nafiux | Ouch, I think that is it! Is the hard disk. Which actually doesn’t overcommit. | 18:42 |
nafiux | I have assigned a lot in the flavor, let me reduce it and test it again. | 18:42 |
mriedem | yeah your provider only has ~300 GB of disk | 18:43 |
*** takamatsu has joined #openstack-nova | 18:43 | |
spatel | grep vcpu_pin_set /etc/nova/nova.conf <--- empty | 18:43 |
spatel | I have queen cluster and same config works there... | 18:43 |
mriedem | nafiux: if you were doing volume-backed servers then you're probably fine, lots of vcpu and ram on that node | 18:43 |
spatel | i am running new cluster in stein | 18:43 |
mriedem | but very little disk | 18:43 |
spatel | which causing issue | 18:43 |
nafiux | @mriedem yes, that is true, only 300 GB free, and the flavor has 160 GB, so only 1 instance with that capacity will be allowed. | 18:44 |
mriedem | \o/ | 18:45 |
nafiux | Does "volume-backed" means the actuall physical hard disk of the hypervisor/nova node? | 18:46 |
mriedem | no | 18:46 |
mriedem | means the root disk is a cinder volume | 18:46 |
mriedem | https://docs.openstack.org/nova/latest/user/launch-instance-from-volume.html | 18:47 |
nafiux | Oh, I don’t have installed cinder. That will help a lot, if I understand correctly? | 18:48 |
mriedem | i don't know how to answer that question :) | 18:48 |
mriedem | if you have a compute node with 300 GB of disk and flavors with 160 GB of disk, you're not going to get far | 18:48 |
mriedem | so you'd have to carve down your flavors to have smaller disk, | 18:48 |
mriedem | or add more storage to your compute nodes, | 18:49 |
mriedem | or use cinder to back the root disk | 18:49 |
nafiux | Lol, yeah. How servers backed with cinder volumes behave? Do they use as needed and not the actual size specified at creation time? | 18:50 |
mriedem | for volume-backed servers the root gb on the flavor doesn't really apply | 18:53 |
mriedem | the size of the volume is whatever it is when it's created | 18:53 |
sean-k-mooney | mriedem: im not sure i did a good job of explaing but it tried to explain the issue again im my reponce to your comments | 18:53 |
sean-k-mooney | https://review.opendev.org/#/c/669738/2 | 18:54 |
mriedem | the user can pre-create a volume and provide that to nova when creating the server, or the user can give some parameters to nova and nova will create the volume and attach it to the server | 18:54 |
sean-k-mooney | but yes i can factor the functional test our into there own regression module | 18:54 |
mriedem | so many words....but i started that | 18:54 |
sean-k-mooney | and add teh rebuild/shelve tests | 18:54 |
mriedem | nafiux: some people use cinder exclusively for root volumes of their servers, some people use shared storage for their compute nodes, some mix both - it takes all kinds | 18:55 |
sean-k-mooney | nafiux: cinder backed volume behvior depend on teh dirver. some cinder backends support thin provisioning allowing over commit some dont | 18:57 |
sean-k-mooney | and some time the same dirver change behavior based on your config setting which makes it all the more fun to debug | 18:58 |
nafiux | Thanks @mridem & @sean-k-mooney. I will read more about those topics, so, in general which are the different options for volumens to the instances? | 18:58 |
sean-k-mooney | there are two sets of volumes, volumes that have independent lifetime form the vm usually called data volumes | 19:01 |
sean-k-mooney | thos are create via teh cinder api. | 19:01 |
sean-k-mooney | and then there are volumes that have ther life time cupled to a vm | 19:01 |
nafiux | Ok, which is the equivalent to the root volumes in AWS? | 19:02 |
nafiux | Can I have a root volume with cinder? | 19:02 |
sean-k-mooney | yes | 19:02 |
sean-k-mooney | we call that boot form volume or bfv for short | 19:02 |
sean-k-mooney | in that case you tell nova that the root disk should not be create using the compute nodes default driver and instad should be provide by cinder | 19:03 |
nafiux | Oh, so, due my current setup for learning, I will leverage cinder for both bfv and additional volumes as needed | 19:03 |
sean-k-mooney | you can optionl specifythat that volume should be deleted when the vm is or not | 19:03 |
sean-k-mooney | i wasnt following the full conversation but you can use cinder for both | 19:04 |
nafiux | Ok, yea, is just because I have a lot of CPU & Memory but few hard disk | 19:04 |
sean-k-mooney | the default backend for non bfv guest is to create a local file on the compute node for the root disk of the instance | 19:04 |
sean-k-mooney | you can also tell the compute node to use a differnt default image backend such as ceph | 19:05 |
sean-k-mooney | in which case nova will create a remote ceph volume out of band of cinder | 19:05 |
nafiux | Ok, I need to read a lot :D cinder, ceph, and will back later with more specific questions, this is really amazing. | 19:06 |
sean-k-mooney | other peopl in a similar situation somethime mount the default location where libvirt stores its disk image on nfs | 19:06 |
sean-k-mooney | so as mriedem said there are lots of way to do it and people do many different things but its better to keep it simple when learning | 19:07 |
*** whoami-rajat has quit IRC | 19:08 | |
nafiux | Agree. Thanks for the support. | 19:08 |
mriedem | nafiux: more info on cinder in their docs https://docs.openstack.org/cinder/latest/ | 19:11 |
mriedem | there is also the ops guide which is older but relevant https://docs.openstack.org/operations-guide/ | 19:11 |
sean-k-mooney | or if you like video content there are way more videos then you will have time to watch on teh offical youtube channel | 19:12 |
sean-k-mooney | https://www.youtube.com/user/OpenStackFoundation | 19:12 |
nafiux | Sure! I will take a look on this too: https://docs.openstack.org/arch-design/design-storage/design-storage-concepts.html | 19:13 |
*** bbowen has quit IRC | 19:31 | |
*** liuyulong has quit IRC | 19:35 | |
*** takamatsu has quit IRC | 19:47 | |
efried_rollin | mriedem: responded. TL;DR: a Set would be better, but a list will work just fine. | 19:47 |
*** efried_rollin is now known as efried | 19:47 | |
*** eharney has quit IRC | 19:48 | |
efried | I guess that's not FUPable since it's an OVO/RPC thing. No takesy backseys. | 19:49 |
efried | so if you feel strongly about it you should -1 | 19:49 |
mriedem | done | 19:52 |
mriedem | i've made more comments up that series but non-voting b/c i'm a coward | 19:53 |
mriedem | i'd really like dan to review that series but he's out this week | 19:53 |
efried | mriedem: FYI Dan was involved earlier, which is how we ended up with the query and filter in their current form. | 19:54 |
mriedem | yeah i knew he blew up the single megapatch | 19:55 |
efried | but also was the one who suggested the db function as it now exists. | 19:56 |
efried | much nicer than it was before | 19:56 |
mriedem | b/c it's mostly a copy of the one he added for his earlier (first) pre-filters | 19:56 |
mriedem | fwiw most of my comments are "can you document this?" | 19:57 |
mriedem | i also feel like forbidden is the wrong word for the user-facing side of this feature, it's really about host isolation | 19:57 |
mriedem | but it's probably too late to change that now | 19:57 |
mriedem | unless i'm just too slow to connect the dots, which is possible | 19:58 |
mriedem | lots of negative logic in this feature makes it hard for me to reason about | 19:58 |
mriedem | don't not give me the hosts i don't not want | 19:58 |
efried | I'll have another look at the documentation, but I thought it was ultimately explained the right way for users. | 19:59 |
efried | The logic is necessarily hairy and compound-negative-confusing | 19:59 |
efried | but the ux winds up being really crisp and clean imo | 19:59 |
*** nafiux has quit IRC | 20:02 | |
efried | ...you're right, the doc https://review.opendev.org/#/c/667952/10/doc/source/reference/forbidden-aggregates.rst still talks about forbidden aggregates. Though really, the explanation is very good, and "forbidden aggregates" is really just used as the name-of-feature. | 20:02 |
*** mchlumsky has quit IRC | 20:06 | |
mriedem | yeah i'm not -1 on it, it's just a bit confusing | 20:16 |
mriedem | some of the wording | 20:16 |
efried | I think you've got a valid point that we could s/forbidden/isolated/ and it would be more comprehensible. The docs could be fixed later, but if we want to rename the conf opt we should do it now. | 20:18 |
prometheanfire | sean-k-mooney: ya, looks like it's lxml https://review.opendev.org/673848 | 20:21 |
mriedem | efried: question in https://review.opendev.org/#/c/670182/1 | 20:23 |
*** BjoernT has joined #openstack-nova | 20:23 | |
efried | mriedem: responded | 20:24 |
*** BjoernT_ has joined #openstack-nova | 20:25 | |
*** BjoernT has quit IRC | 20:28 | |
*** med_ has quit IRC | 20:28 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/664513 | 20:29 |
mriedem | amorin: are you still working on https://review.opendev.org/#/c/667294/ ? | 20:31 |
*** eharney has joined #openstack-nova | 20:35 | |
*** trident has quit IRC | 20:44 | |
*** mriedem has quit IRC | 20:44 | |
openstackgerrit | Merged openstack/nova master: neutron: log something more useful in _get_instance_nw_info https://review.opendev.org/673694 | 20:45 |
*** mriedem has joined #openstack-nova | 20:45 | |
*** trident has joined #openstack-nova | 20:46 | |
*** mriedem has quit IRC | 20:54 | |
*** mriedem has joined #openstack-nova | 20:55 | |
*** dillaman has joined #openstack-nova | 21:11 | |
*** jdillaman has quit IRC | 21:15 | |
*** jdillaman1 has joined #openstack-nova | 21:19 | |
*** dillaman has quit IRC | 21:23 | |
*** nafiux has joined #openstack-nova | 21:34 | |
*** takamatsu has joined #openstack-nova | 21:40 | |
efried | mriedem: RequestContext question for ya | 21:43 |
efried | I've been tracking where nova-compute talks to Placement to do things like creating the compute node RP. | 21:43 |
*** spatel has quit IRC | 21:44 | |
efried | IIUC those interactions use a RequestContext that gets created when the service starts up, because they're done in a periodic, not based on a request coming from e.g. conductor or whatever. | 21:44 |
efried | which would be fine, except... | 21:45 |
efried | it doesn't seem to be the same context that's being used for logging. | 21:45 |
mriedem | b/c the request id changes etc | 21:45 |
mriedem | which is because of a thread local store for the context way up in oslo.context | 21:45 |
mriedem | and it's mega confusing | 21:45 |
efried | rightright, but it's a *different* context? | 21:45 |
mriedem | as mentioned https://bugs.launchpad.net/nova/+bug/1835958/comments/7 | 21:46 |
openstack | Launchpad bug 1835958 in OpenStack Compute (nova) "Nova sync power state on large clusters causes poor performance" [Undecided,New] | 21:46 |
efried | viz: http://logs.openstack.org/86/672986/2/check/nova-live-migration/0171fa9/logs/screen-n-cpu.txt.gz#_Jul_30_22_09_35_334853 | 21:46 |
efried | here ^ you can see that the log line is showing one request_id, but the context we're using for the placement request has a different request_id. | 21:46 |
mriedem | req-428963d8-bc71-4823-8e35-97db13886690 is just some admin context created when the compute service starts up right? | 21:47 |
mriedem | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1321 | 21:48 |
mriedem | so you're using a random context there with a random request_id | 21:48 |
efried | req-42... is the placement-side local request_id, just ignore that one. | 21:48 |
mriedem | because https://github.com/openstack/oslo.context/blob/master/oslo_context/context.py#L273 | 21:48 |
mriedem | i was looking at that one because | 21:49 |
mriedem | Jul 30 22:09:35.334349 ubuntu-bionic-rax-ord-0009499845 nova-compute[28986]: INFO nova.scheduler.client.report [None req-fb42d5e6-1c0d-41d0-88c5-a4f1ac127a41 None None] [req-428963d8-bc71-4823-8e35-97db13886690] Created resource provider record via placement API for resource provider with UUID 5dcb9522-0513-440a-80db-d985b5d45704 and name ubuntu-bionic-rax-ord-0009499845. | 21:49 |
efried | req-fb42d5e6-1c0d-41d0-88c5-a4f1ac127a41 is the oslo.context one that oslo.log is paying attention to | 21:49 |
efried | req-8a7e2cc5-3870-4118-b55f-4533d7a4de80 is the one in the RequestContext being used for the placement communication. | 21:49 |
efried | yeah, I know, I had to track that one down as well. I started this whole thing because I was wondering why tf we needed to print that reqid at all. | 21:50 |
efried | it's the one being sent *back* to us in the placement response headers, which turns out to be the (not-global!) request_id on the placement side | 21:50 |
efried | and because of this whole snafu, it's currently the only way for us to correlate the requests on the nova & placement sides | 21:50 |
efried | but that flies in the face of the entire global_request_id concept | 21:51 |
efried | if we get global_request_id working, we don't need that at all because we'll be able to correlate with global_request_id, which is the whole friggin point. | 21:51 |
efried | so my question is this | 21:51 |
mriedem | idk what oslo.log is doing really but i know things get wonky with this https://github.com/openstack/oslo.context/blob/master/oslo_context/context.py#L300 | 21:52 |
efried | what about if, when we create the RequestContext on compute startup, we a) set its global_request_id, and b) pass overwrite=True so oslo.context replaces it in the threadlocal | 21:52 |
efried | yeah, b) would call update_store and replace that. | 21:53 |
efried | I think having talked through this I've got enough to do that ^ in a WIP and see what shakes out. | 21:54 |
mriedem | ....ok | 21:55 |
openstackgerrit | Merged openstack/nova master: Move adding vlans to interfaces to privsep. https://review.opendev.org/635436 | 21:56 |
mriedem | i know melwitt https://review.opendev.org/#/c/524306/ and gibi https://review.opendev.org/#/c/542891/ have muddled in this and it's a mess | 21:56 |
mriedem | so i guess welcome to the tarpits | 21:56 |
efried | mriedem: I see that get_context() and get_admin_context() explicitly set overwrite=False. The former even says it's to not mess with logging. Why?? | 21:57 |
mriedem | oh eric, i could tell you but that would be too easy | 21:57 |
*** BjoernT_ has quit IRC | 21:58 | |
mriedem | if you can hunt down vishy from 2012 maybe he can answer https://review.opendev.org/#/c/2923/ | 21:58 |
mriedem | or i guess alaski from 2016 https://review.opendev.org/#/c/378941/ | 21:59 |
mriedem | the admin context stuff is also a bit legacy from when db apis were explicitly blocked unless you had an admin context, which alex_xu removed a long time ago | 22:01 |
mriedem | but still affects project_id filtering in the model_query | 22:01 |
mriedem | as melwitt can probably go into detail about | 22:01 |
mriedem | as for the logging and thread local stuff, ....idk | 22:01 |
*** slaweq has quit IRC | 22:04 | |
*** rcernin has joined #openstack-nova | 22:05 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Store a RequestContext on service to reuse for periodic tasks https://review.opendev.org/524306 | 22:05 |
openstackgerrit | Eric Fried proposed openstack/nova master: Poison context usage in periodic tasks https://review.opendev.org/542891 | 22:05 |
efried | melwitt, gibi_off: FYI, rebased & resolved merge conflicts ^. I'm going to throw one on top that overwrites the threadlocal context and creates a global_request_id so our logging might be sane. We'll see what explodes. | 22:07 |
efried | mriedem: fyi ^ | 22:07 |
*** mlavalle has quit IRC | 22:07 | |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Generate and log global_request_id properly https://review.opendev.org/673924 | 22:10 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.opendev.org/636508 | 22:13 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.opendev.org/639280 | 22:13 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.opendev.org/639281 | 22:13 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.opendev.org/639282 | 22:13 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move setting of device trust to privsep. https://review.opendev.org/639283 | 22:13 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move final bridge commands to privsep. https://review.opendev.org/639580 | 22:14 |
openstackgerrit | Eric Fried proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.opendev.org/639581 | 22:14 |
openstackgerrit | Eric Fried proposed openstack/nova master: We no longer need rootwrap. https://review.opendev.org/554438 | 22:14 |
openstackgerrit | Eric Fried proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.opendev.org/639826 | 22:14 |
openstackgerrit | Merged openstack/nova master: Remove Request Spec Migration upgrade status check https://review.opendev.org/673580 | 22:24 |
efried | o/ | 22:31 |
*** nafiux has quit IRC | 22:35 | |
*** nafiux has joined #openstack-nova | 22:37 | |
*** mriedem has quit IRC | 22:43 | |
*** threestrands has joined #openstack-nova | 22:55 | |
*** tkajinam has joined #openstack-nova | 22:57 | |
*** panda has quit IRC | 23:03 | |
*** panda has joined #openstack-nova | 23:04 | |
*** slaweq has joined #openstack-nova | 23:11 | |
*** slaweq has quit IRC | 23:15 | |
*** vishwanathj has quit IRC | 23:36 | |
*** betherly has joined #openstack-nova | 23:42 | |
*** eharney has quit IRC | 23:45 | |
*** betherly has quit IRC | 23:47 | |
*** takamatsu has quit IRC | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!