| *** slaweq has joined #openstack-nova | 00:11 | |
| *** tssurya has quit IRC | 00:13 | |
| *** ricolin__ has joined #openstack-nova | 00:13 | |
| *** slaweq has quit IRC | 00:15 | |
| *** ricolin_ has quit IRC | 00:16 | |
| *** betherly has joined #openstack-nova | 00:26 | |
| *** betherly has quit IRC | 00:31 | |
| *** ivve has quit IRC | 00:32 | |
| *** whoami-rajat has quit IRC | 00:34 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add database schema upgrade check https://review.opendev.org/667047 | 00:38 |
|---|---|---|
| *** markvoelker has joined #openstack-nova | 00:39 | |
| *** gyee has quit IRC | 00:43 | |
| *** tbachman has joined #openstack-nova | 00:50 | |
| *** mriedem has quit IRC | 00:52 | |
| *** spsurya has joined #openstack-nova | 01:05 | |
| *** betherly has joined #openstack-nova | 01:09 | |
| *** betherly has quit IRC | 01:14 | |
| *** igordc has quit IRC | 01:25 | |
| *** betherly has joined #openstack-nova | 01:30 | |
| *** whoami-rajat has joined #openstack-nova | 01:32 | |
| *** betherly has quit IRC | 01:35 | |
| *** tetsuro has joined #openstack-nova | 01:37 | |
| *** slaweq has joined #openstack-nova | 02:11 | |
| *** slaweq has quit IRC | 02:15 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Don't generate service UUID for deleted services https://review.opendev.org/673821 | 02:31 |
| openstackgerrit | Merged openstack/nova master: Skip test_migrate_disk_and_power_off_crash_finish_revert_migration https://review.opendev.org/675417 | 02:31 |
| openstackgerrit | Merged openstack/nova master: Dump versioned notifications when len assertions fail https://review.opendev.org/675404 | 02:31 |
| *** betherly has joined #openstack-nova | 02:34 | |
| *** betherly has quit IRC | 02:39 | |
| *** altlogbot_2 has quit IRC | 02:44 | |
| *** altlogbot_1 has joined #openstack-nova | 02:45 | |
| *** tetsuro has quit IRC | 02:46 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix rebuild of baremetal instance when vm_state is ERROR https://review.opendev.org/523559 | 02:49 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: run test_rebuild_server_in_error_state in ironic CI job https://review.opendev.org/675391 | 02:49 |
| *** betherly has joined #openstack-nova | 02:55 | |
| *** betherly has quit IRC | 03:00 | |
| *** markvoelker has quit IRC | 03:18 | |
| *** redrobot has quit IRC | 03:22 | |
| *** betherly has joined #openstack-nova | 03:28 | |
| *** betherly has quit IRC | 03:32 | |
| *** psachin has joined #openstack-nova | 03:36 | |
| *** tetsuro has joined #openstack-nova | 04:08 | |
| *** ricolin__ is now known as ricolin | 04:09 | |
| *** slaweq has joined #openstack-nova | 04:11 | |
| *** factor has quit IRC | 04:12 | |
| *** factor has joined #openstack-nova | 04:12 | |
| *** tetsuro has quit IRC | 04:12 | |
| *** tetsuro has joined #openstack-nova | 04:13 | |
| *** slaweq has quit IRC | 04:16 | |
| *** betherly has joined #openstack-nova | 04:21 | |
| *** dave-mccowan has quit IRC | 04:25 | |
| *** betherly has quit IRC | 04:26 | |
| *** mkrai has joined #openstack-nova | 04:29 | |
| *** betherly has joined #openstack-nova | 04:43 | |
| *** betherly has quit IRC | 04:47 | |
| *** markvoelker has joined #openstack-nova | 04:48 | |
| *** markvoelker has quit IRC | 04:52 | |
| *** ratailor has joined #openstack-nova | 04:56 | |
| *** tetsuro has quit IRC | 04:57 | |
| *** tetsuro_ has joined #openstack-nova | 04:57 | |
| openstackgerrit | Merged openstack/nova stable/queens: Replace non-nova server fault message https://review.opendev.org/674859 | 05:06 |
| *** slaweq has joined #openstack-nova | 05:11 | |
| *** betherly has joined #openstack-nova | 05:15 | |
| *** slaweq has quit IRC | 05:15 | |
| *** betherly has quit IRC | 05:19 | |
| *** udesale has joined #openstack-nova | 05:33 | |
| *** dave-mccowan has joined #openstack-nova | 05:38 | |
| *** panda has quit IRC | 05:47 | |
| openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.opendev.org/621476 | 05:48 |
| *** panda has joined #openstack-nova | 05:48 | |
| *** tssurya has joined #openstack-nova | 05:51 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing admin_actions policies https://review.opendev.org/657698 | 06:08 |
| *** betherly has joined #openstack-nova | 06:08 | |
| *** tetsuro_ has quit IRC | 06:10 | |
| *** slaweq has joined #openstack-nova | 06:11 | |
| *** jaosorior has joined #openstack-nova | 06:12 | |
| *** betherly has quit IRC | 06:13 | |
| *** slaweq has quit IRC | 06:15 | |
| *** tssurya has quit IRC | 06:22 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: trivial: Use NoDBTestCase instead of TestCase https://review.opendev.org/675529 | 06:24 |
| *** bhagyashris has joined #openstack-nova | 06:24 | |
| *** hemna has quit IRC | 06:24 | |
| *** betherly has joined #openstack-nova | 06:29 | |
| *** betherly has quit IRC | 06:35 | |
| *** takashin has left #openstack-nova | 06:35 | |
| openstackgerrit | ya.wang proposed openstack/nova master: Add releasenote and update docs. https://review.opendev.org/674526 | 06:35 |
| *** slaweq has joined #openstack-nova | 06:42 | |
| *** hemna has joined #openstack-nova | 06:48 | |
| *** betherly has joined #openstack-nova | 06:51 | |
| *** xek has joined #openstack-nova | 06:52 | |
| *** rpittau|afk is now known as rpittau | 06:52 | |
| *** betherly has quit IRC | 06:56 | |
| *** tesseract has joined #openstack-nova | 07:04 | |
| *** xek has quit IRC | 07:10 | |
| *** betherly has joined #openstack-nova | 07:12 | |
| *** betherly has quit IRC | 07:17 | |
| *** tssurya has joined #openstack-nova | 07:18 | |
| *** mjozefcz has joined #openstack-nova | 07:23 | |
| openstackgerrit | zhufl proposed openstack/nova master: [Trivial]Remove unused _last_bw_usage_cell_update https://review.opendev.org/675543 | 07:25 |
| *** betherly has joined #openstack-nova | 07:34 | |
| *** takamatsu has joined #openstack-nova | 07:35 | |
| *** betherly has quit IRC | 07:38 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | 07:42 |
| *** rcernin has quit IRC | 07:46 | |
| *** ratailor has quit IRC | 07:49 | |
| *** bhagyashris has quit IRC | 08:05 | |
| *** betherly has joined #openstack-nova | 08:05 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Prevent init_host test to interfere with other tests https://review.opendev.org/675553 | 08:06 |
| *** ralonsoh has joined #openstack-nova | 08:06 | |
| *** psachin has quit IRC | 08:07 | |
| *** psachin has joined #openstack-nova | 08:08 | |
| *** betherly has quit IRC | 08:10 | |
| *** bhagyashris has joined #openstack-nova | 08:10 | |
| *** hemna has quit IRC | 08:12 | |
| *** ivve has joined #openstack-nova | 08:15 | |
| *** ociuhandu has joined #openstack-nova | 08:18 | |
| *** betherly has joined #openstack-nova | 08:22 | |
| *** ratailor has joined #openstack-nova | 08:22 | |
| *** david-lyle has joined #openstack-nova | 08:24 | |
| *** dklyle has quit IRC | 08:24 | |
| *** jistr is now known as jistr|afk | 08:24 | |
| openstackgerrit | Bhagyashri Shewale proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | 08:26 |
| *** jaosorior has quit IRC | 08:29 | |
| *** xek has joined #openstack-nova | 08:35 | |
| *** hemna has joined #openstack-nova | 08:36 | |
| *** jaosorior has joined #openstack-nova | 09:01 | |
| *** derekh has joined #openstack-nova | 09:05 | |
| *** hemna has quit IRC | 09:10 | |
| *** markvoelker has joined #openstack-nova | 09:18 | |
| *** markvoelker has quit IRC | 09:23 | |
| *** tesseract has quit IRC | 09:28 | |
| *** tesseract has joined #openstack-nova | 09:28 | |
| *** tesseract has quit IRC | 09:29 | |
| *** tesseract has joined #openstack-nova | 09:29 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Correct nit with cpu-resources https://review.opendev.org/675276 | 09:29 |
| *** brinzhang has quit IRC | 09:30 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test heal port allocations in nova-next https://review.opendev.org/669879 | 09:34 |
| *** cdent has joined #openstack-nova | 09:37 | |
| *** shilpasd has joined #openstack-nova | 09:38 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Drop usage of lxml's deprecated getchildren() method https://review.opendev.org/675566 | 09:45 |
| *** claudiub has joined #openstack-nova | 09:47 | |
| alex_xu | sean-k-mooney: i feel we have problem for confirm and revert resize https://review.opendev.org/#/c/621646/23/nova/virt/libvirt/driver.py@1099 | 09:54 |
| *** hemna has joined #openstack-nova | 09:54 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add request_spec to server move RPC calls https://review.opendev.org/655721 | 09:56 |
| *** hoonetorg has quit IRC | 09:57 | |
| openstackgerrit | Merged openstack/nova-specs master: Correct nit with cpu-resources https://review.opendev.org/675276 | 09:57 |
| *** bhagyashris has quit IRC | 10:03 | |
| *** mkrai has quit IRC | 10:05 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hw:cpu_policy', 'hw:mem_page_size' extra specs from API samples https://review.opendev.org/675338 | 10:06 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Flatten 'ResourceRequest.from_extra_specs', 'from_image_props' https://review.opendev.org/674894 | 10:06 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | 10:06 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | 10:06 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: fakelibvirt: Stop distinguishing between NUMA, non-NUMA https://review.opendev.org/675570 | 10:06 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571 | 10:06 |
| stephenfin | alex_xu, efried, sean-k-mooney: Okay, with the exception of the reshaper, which still has some todo's in it, I _think_ the PCPU stuff is ready for review. It might look big but the bulk of it is handling tech debt. Let me know if you need advice on any part of it | 10:07 |
| alex_xu | stephenfin: cool~ | 10:07 |
| stephenfin | alex_xu, efried, sean-k-mooney: I'm going to continue working on the reshaper and then start manual testing once that's done. I particularly want to check Train controller <-> Stein compute node compatibility and upgrades | 10:08 |
| * stephenfin makes sure it's listed in https://etherpad.openstack.org/p/nova-runways-train | 10:08 | |
| *** yaawang has quit IRC | 10:09 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add database schema upgrade check https://review.opendev.org/667047 | 10:10 |
| *** hemna has quit IRC | 10:12 | |
| *** yaawang has joined #openstack-nova | 10:16 | |
| *** jistr|afk is now known as jistr | 10:18 | |
| *** hoonetorg has joined #openstack-nova | 10:20 | |
| *** hemna has joined #openstack-nova | 10:35 | |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Rename 'map' variable to avoid shadowing keywords https://review.opendev.org/675578 | 10:37 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Add a document that describes profiling eventlet services https://review.opendev.org/674865 | 10:38 |
| *** tbachman has quit IRC | 10:38 | |
| *** betherly has quit IRC | 10:38 | |
| *** jaosorior has quit IRC | 10:38 | |
| frickler | can someone help with fixing novnc multinode job config? see my latest comment in https://bugs.launchpad.net/nova/+bug/1669468 | 10:47 |
| openstack | Launchpad bug 1669468 in OpenStack Compute (nova) "tempest.api.compute.servers.test_novnc.NoVNCConsoleTestJSON.test_novnc fails intermittently in neutron multinode nv job" [Medium,Confirmed] | 10:47 |
| frickler | might actually be devstack's fault to properly set up the config, but I'm also not 100% sure how the correct config would look like | 10:49 |
| *** jaosorior has joined #openstack-nova | 10:55 | |
| *** tbachman has joined #openstack-nova | 10:57 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Follow up for I491eb7abe1405b27c552cdef142c688a46e914f2 https://review.opendev.org/675589 | 11:15 |
| *** dpawlik has quit IRC | 11:21 | |
| *** dpawlik has joined #openstack-nova | 11:22 | |
| *** ajo has left #openstack-nova | 11:22 | |
| *** belmoreira has joined #openstack-nova | 11:39 | |
| *** huaqiang has quit IRC | 11:47 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Indroduce new LibvirtConfigGuestPMEM https://review.opendev.org/672956 | 11:53 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Populates existing pmems in libvirt device manager https://review.opendev.org/672957 | 11:53 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Report pmem namespaces resources by provider tree https://review.opendev.org/634551 | 11:53 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Support instance creation and resize with pmems https://review.opendev.org/672958 | 11:53 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Add functional tests for persistent memory https://review.opendev.org/675592 | 11:53 |
| *** markvoelker has joined #openstack-nova | 11:59 | |
| *** jaosorior has quit IRC | 12:12 | |
| *** jamesdenton has quit IRC | 12:17 | |
| belmoreira | cdent nice blogpost about placement performance. You may also be interested in these results: https://docs.google.com/document/d/1UE3jpukdoX45l5ghUg0AlcWBh95glRiGUv7E3YazXNk/edit | 12:43 |
| belmoreira | I hope to publish it soon | 12:43 |
| belmoreira | also ^ efried mriedem | 12:44 |
| cdent | ah, excellent, I'll give that a read soon, just getting ready to go to lunch | 12:44 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test heal port allocations in nova-next https://review.opendev.org/669879 | 12:47 |
| *** cdent has quit IRC | 12:48 | |
| *** cdent has joined #openstack-nova | 12:48 | |
| *** cdent has quit IRC | 12:49 | |
| *** boxiang has quit IRC | 12:50 | |
| *** boxiang has joined #openstack-nova | 12:51 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Handle alternative UEFI firmware binary paths https://review.opendev.org/348394 | 12:54 |
| *** udesale has quit IRC | 12:56 | |
| *** udesale has joined #openstack-nova | 12:57 | |
| *** mkrai has joined #openstack-nova | 12:58 | |
| *** nweinber has joined #openstack-nova | 12:59 | |
| *** Guest1857 has joined #openstack-nova | 12:59 | |
| *** nweinber has quit IRC | 13:02 | |
| *** nweinber has joined #openstack-nova | 13:02 | |
| *** ociuhandu has quit IRC | 13:03 | |
| *** ociuhandu has joined #openstack-nova | 13:03 | |
| *** ociuhandu has quit IRC | 13:07 | |
| *** tbachman has quit IRC | 13:09 | |
| *** cdent has joined #openstack-nova | 13:09 | |
| *** mriedem has joined #openstack-nova | 13:10 | |
| *** panda has quit IRC | 13:14 | |
| *** panda has joined #openstack-nova | 13:15 | |
| mriedem | party people in the house say hey-o! | 13:16 |
| cdent | hey? o? | 13:17 |
| *** belmoreira has quit IRC | 13:17 | |
| mriedem | that's the kind of enthusiasm i'm looking for | 13:18 |
| mriedem | lyarwood: can you get this queens backport? https://review.opendev.org/672690 | 13:18 |
| mriedem | dansmith: can you get this one? https://review.opendev.org/668123 | 13:18 |
| mriedem | today is queens release day | 13:18 |
| *** shilpasd has quit IRC | 13:20 | |
| gibi | is it Friday yet? | 13:21 |
| *** jamesdenton has joined #openstack-nova | 13:21 | |
| *** jamesdenton has quit IRC | 13:22 | |
| mriedem | yes | 13:22 |
| mriedem | got another queens backport that needs +W https://review.opendev.org/#/c/669126/ | 13:23 |
| artom | mriedem, didn't know Elizabeth was in jail... | 13:23 |
| *** Conqueror has quit IRC | 13:24 | |
| mriedem | i'm missing the reference | 13:24 |
| cdent | artom: the life of a royal is constant imprisonment and suffering, don't ya know | 13:25 |
| mriedem | oh queens release day, i see | 13:26 |
| *** ociuhandu has joined #openstack-nova | 13:27 | |
| lyarwood | mriedem: ack done | 13:27 |
| mriedem | can you hit these as well? https://review.opendev.org/#/q/topic:bug/1837955+branch:stable/queens | 13:27 |
| lyarwood | sure thing | 13:28 |
| *** BjoernT has joined #openstack-nova | 13:28 | |
| gibi | based on the joke it is definitely Friday! | 13:28 |
| mriedem | could use a stable core on these as well https://review.opendev.org/#/q/topic:bug/1764556+branch:stable/queens | 13:28 |
| mriedem | johnthetubaguy: ^? | 13:28 |
| *** jistr is now known as jistr|call | 13:29 | |
| mriedem | another queens backport https://review.opendev.org/#/c/672161/2 | 13:32 |
| *** artom has quit IRC | 13:33 | |
| *** ivve has quit IRC | 13:33 | |
| *** belmoreira has joined #openstack-nova | 13:34 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Fix type error on call to mount device https://review.opendev.org/669629 | 13:35 |
| mriedem | and https://review.opendev.org/#/c/669629/ | 13:36 |
| *** jamesdenton has joined #openstack-nova | 13:36 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Disable limit if affinity(anti)/same(different)host is requested https://review.opendev.org/659247 | 13:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Disable limit if affinity(anti)/same(different)host is requested https://review.opendev.org/659247 | 13:38 |
| *** jistr|call is now known as jistr | 13:38 | |
| *** mkrai has quit IRC | 13:41 | |
| *** ociuhandu has quit IRC | 13:43 | |
| *** ociuhandu has joined #openstack-nova | 13:44 | |
| *** bnemec is now known as beekneemech | 13:45 | |
| *** stephenfin is now known as finucannot | 13:46 | |
| finucannot | aspiers: So apparently I can't access lxml documentation because it's Friday and that's not allowed (try navigating to lxml.de) | 13:46 |
| *** lbragstad has joined #openstack-nova | 13:46 | |
| *** david-lyle is now known as dklyle | 13:48 | |
| mordred | the code is self-documenting? | 13:48 |
| *** mkrai has joined #openstack-nova | 13:48 | |
| finucannot | I guess it _has_ to be | 13:48 |
| *** ociuhandu has quit IRC | 13:49 | |
| mriedem | you can get to https://lxml.de/tutorial.html | 13:49 |
| *** eharney has joined #openstack-nova | 13:50 | |
| mriedem | https://lxml.de/api/index.html | 13:50 |
| finucannot | Ah, sweet | 13:50 |
| finucannot | mriedem++ | 13:50 |
| mriedem | that'll be $5 please | 13:50 |
| finucannot | Darn, I'm fresh out of dollar bills. Crying shame, that | 13:51 |
| mriedem | i'll take 5 eu | 13:52 |
| finucannot | Britain refuses to take even one | 13:53 |
| mriedem | boris has it under control | 13:53 |
| *** tbachman has joined #openstack-nova | 13:53 | |
| * finucannot can sense lyarwood muttering under his breath from here | 13:54 | |
| mriedem | polite muttering i'm sure | 13:54 |
| *** spsurya has quit IRC | 13:54 | |
| * lyarwood sobs into his tea | 13:55 | |
| *** xek has quit IRC | 13:55 | |
| *** mlavalle has joined #openstack-nova | 13:55 | |
| *** ociuhandu has joined #openstack-nova | 13:55 | |
| *** lbragstad has quit IRC | 13:58 | |
| aspiers | mriedem: no swear-words in this channel please | 14:04 |
| *** lbragstad has joined #openstack-nova | 14:05 | |
| frickler | mriedem: I commented on https://bugs.launchpad.net/nova/+bug/1669468 earlier with what I think would be the reason for about 50% failure rate, but I'm not sure at which place to fix it | 14:05 |
| openstack | Launchpad bug 1669468 in OpenStack Compute (nova) "tempest.api.compute.servers.test_novnc.NoVNCConsoleTestJSON.test_novnc fails intermittently in neutron multinode nv job" [Medium,Confirmed] | 14:05 |
| *** jaypipes has joined #openstack-nova | 14:06 | |
| *** mkrai has quit IRC | 14:07 | |
| *** lbragstad has quit IRC | 14:14 | |
| melwitt | frickler: I think your assessment sounds probable. I think I could find where to fix it, I've done a few changes to console settings in devstack in the past | 14:15 |
| mriedem | sorry, on a call now but will take a look later | 14:16 |
| *** psachin has quit IRC | 14:16 | |
| cdent | good article belmoreira . I made a couple of suggested edits. It seems like "The provider_tree "deepcopy" should be re-evaluated" is the big takeaway. Based on my recent posting it _might_ make sense to add a __copy__ to provider tree | 14:19 |
| *** dpawlik has quit IRC | 14:26 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Disable limit if affinity(anti)/same(different)host is requested https://review.opendev.org/659247 | 14:27 |
| *** boxiang has quit IRC | 14:28 | |
| *** liuyulong has joined #openstack-nova | 14:28 | |
| *** boxiang has joined #openstack-nova | 14:28 | |
| *** ociuhandu has quit IRC | 14:34 | |
| *** ociuhandu has joined #openstack-nova | 14:35 | |
| openstackgerrit | Merged openstack/nova stable/queens: Stabilize unshelve notification sample tests https://review.opendev.org/674636 | 14:38 |
| *** artom has joined #openstack-nova | 14:38 | |
| *** boxiang has quit IRC | 14:39 | |
| *** ivve has joined #openstack-nova | 14:39 | |
| *** boxiang has joined #openstack-nova | 14:39 | |
| *** ociuhandu has quit IRC | 14:40 | |
| *** ociuhandu has joined #openstack-nova | 14:41 | |
| *** ociuhandu has quit IRC | 14:42 | |
| *** cdent has quit IRC | 14:42 | |
| mriedem | need a stable core for this queens one as well https://review.opendev.org/#/c/666862/ | 14:45 |
| *** cdent has joined #openstack-nova | 14:45 | |
| dansmith | mriedem: I can just +W that because the only conflict was a test yeah? | 14:47 |
| *** ratailor has quit IRC | 14:47 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Fix double word hacking test https://review.opendev.org/665790 | 14:47 |
| dansmith | (as in without looking very hard) | 14:48 |
| *** belmoreira has quit IRC | 14:49 | |
| *** belmoreira has joined #openstack-nova | 14:55 | |
| *** ricolin has quit IRC | 14:57 | |
| *** dklyle has quit IRC | 14:58 | |
| *** david-lyle has joined #openstack-nova | 14:58 | |
| mriedem | dansmith: yeah | 14:58 |
| *** liuyulong has quit IRC | 14:59 | |
| *** ricolin has joined #openstack-nova | 15:01 | |
| finucannot | aspiers, sean-k-mooney: We're touching an awful lot of the same code between the amd-sev-libvirt-support, image-metadata-prefiltering and cpu-resources specs. I forsee a lot of merge conflicts, but also a chance to share best practices | 15:03 |
| finucannot | aspiers, sean-k-mooney: Especially around the scheduler pre-filter stuff. Lots of comments left on both series | 15:04 |
| * finucannot is happy to be reviewing stuff instead of dealing with libvirt driver tech debt for the first time in a while | 15:05 | |
| mriedem | dansmith: since you just went through these for rocky, if you have a minute https://review.opendev.org/#/q/topic:bug/1764556+branch:stable/queens | 15:08 |
| mriedem | i'm trying to flush queens for the release | 15:08 |
| * dansmith groans | 15:09 | |
| aspiers | finucannot: I feel like libvirt/driver.py and test_driver.py are horrendously big and could do with splitting up somehow | 15:13 |
| melwitt | otherwise I can do those, I meant to but was watching the rocky change land first. I should have pre-reviewed | 15:13 |
| finucannot | aspiers: Aye, it regularly crashes the flake8 process in syntastic (Vim plugin). I don't even know where to start though | 15:14 |
| artom | mriedem, you're going for a royal flush? | 15:14 |
| mriedem | no, 4 of a kind | 15:14 |
| mriedem | shoot the moon | 15:14 |
| * finucannot groans | 15:14 | |
| artom | groaning \o/ | 15:14 |
| mriedem | this is the current +2'ed list of queens changes https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/queens+label:Code-Review=2 | 15:15 |
| mriedem | if that helps | 15:15 |
| *** tbachman has quit IRC | 15:15 | |
| *** david-lyle is now known as dklyle | 15:16 | |
| *** panda has quit IRC | 15:19 | |
| *** panda has joined #openstack-nova | 15:20 | |
| dansmith | mriedem: that service too old set looked like a clean pick from the previous yeah? | 15:21 |
| dansmith | makes sense I guess since most of the change is the added and then modified tests | 15:22 |
| *** spatel has joined #openstack-nova | 15:23 | |
| mriedem | yup no conflicts | 15:23 |
| belmoreira | thanks cdent | 15:29 |
| mriedem | melwitt: are you working on a patch for bug 1669468? otherwise i can throw one up quick to see if it explodes. | 15:32 |
| openstack | bug 1669468 in OpenStack Compute (nova) "tempest.api.compute.servers.test_novnc.NoVNCConsoleTestJSON.test_novnc fails intermittently in neutron multinode nv job" [Medium,Confirmed] https://launchpad.net/bugs/1669468 | 15:32 |
| melwitt | mriedem: I was planning to but haven't looked yet. if you have something to try, go ahead | 15:33 |
| mriedem | btw i've got most of the tests in https://review.opendev.org/#/c/675218/ fixed but there are 2 failing for some yet unknown reason https://review.opendev.org/#/c/675218/ | 15:33 |
| melwitt | ack | 15:34 |
| *** mjozefcz has quit IRC | 15:34 | |
| openstackgerrit | Merged openstack/nova stable/queens: fix cellv2 delete_host https://review.opendev.org/672690 | 15:41 |
| openstackgerrit | Merged openstack/nova stable/queens: Add functional regression test for bug 1837955 https://review.opendev.org/673567 | 15:41 |
| openstack | bug 1837955 in OpenStack Compute (nova) queens "MaxRetriesExceeded sometime fails with messaging exception" [Medium,In progress] https://launchpad.net/bugs/1837955 - Assigned to Matt Riedemann (mriedem) | 15:41 |
| openstackgerrit | Merged openstack/nova stable/queens: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/668123 | 15:42 |
| mriedem | frickler: melwitt: this might have been the regression https://review.opendev.org/#/c/672493/6 | 15:46 |
| mriedem | heh, and test_novnc failed on that change http://logs.openstack.org/93/672493/6/check/tempest-multinode-full/2e30174/testr_results.html.gz | 15:46 |
| mriedem | but the tempest-multinode-full job is non-voting in devstack so no one noticed | 15:46 |
| melwitt | ah, yeah looks like it | 15:47 |
| mriedem | that explains the recent up-tick in this failing all of a sudden again | 15:47 |
| *** belmoreira has quit IRC | 15:47 | |
| *** tbachman has joined #openstack-nova | 15:49 | |
| *** gyee has joined #openstack-nova | 15:50 | |
| cdent | ah, melwitt, we're around at the same time. I was tasked yesterday with checking with you (and others) about the urgency/priority of consumer types so we can determine if we need to push harder o nit | 15:52 |
| *** ash2307 has joined #openstack-nova | 15:55 | |
| melwitt | cdent: I wouldn't say it's "urgent" but definitely something important. the earliest we could integrate it in nova is U though | 15:55 |
| melwitt | and I expect the integration to be pretty involved | 15:56 |
| *** cdent has quit IRC | 15:57 | |
| *** ash2307 has left #openstack-nova | 15:57 | |
| *** udesale has quit IRC | 16:02 | |
| openstackgerrit | Merged openstack/nova stable/queens: Cleanup when hitting MaxRetriesExceeded from no host_available https://review.opendev.org/673576 | 16:03 |
| *** tssurya has quit IRC | 16:03 | |
| finucannot | mriedem: What's the difference between 'filter_by(foo == False)' and 'filter_by(foo == false())' in the context of SQLAlchemy? | 16:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: doc: Fix a parameter of NotificationPublisher https://review.opendev.org/670226 | 16:05 |
| *** dklyle has quit IRC | 16:06 | |
| mriedem | my understanding is that false() can be implemented by underlying db translation layers, e.g. ibm_db_sa, to translate what false means, so if the boolean type is an int (0 or 1) rather than False/True | 16:07 |
| mriedem | but, it's a question for zzzeek really | 16:07 |
| mriedem | https://docs.sqlalchemy.org/en/13/core/sqlelement.html?highlight=false#sqlalchemy.sql.expression.false | 16:07 |
| mriedem | "A backend which does not support true/false constants will render as an expression against 1 or 0:" | 16:07 |
| finucannot | I was looking at that (linked to it in a review) but didn't get whether we needed it or not | 16:08 |
| finucannot | I guess MySQL, Postgres and SQLite all support the constants | 16:08 |
| mriedem | for mysql/pg i don't think it's a problem | 16:08 |
| mriedem | yeah | 16:08 |
| finucannot | fair. Much of a muchness so | 16:08 |
| mriedem | https://www.postgresql.org/docs/9.1/datatype-boolean.html | 16:08 |
| *** atmark has quit IRC | 16:08 | |
| *** atmark has joined #openstack-nova | 16:11 | |
| mriedem | how do i know? because older versions of db2, when i needed to care, used 0/1 for booleans | 16:11 |
| mriedem | boolean booleans were for gen-x'ers and their ilk | 16:11 |
| finucannot | flashbacks to writing embedded C with Acme crap proprietary compilers back in uni | 16:12 |
| mriedem | but did you wear a uni in uni? https://photos.app.goo.gl/fu4qRMpbNGtbTDfU6 | 16:15 |
| mriedem | dansmith: i think https://bugs.launchpad.net/nova/+bug/1839621 is where you come in and say # in the password has to be encoded | 16:16 |
| openstack | Launchpad bug 1839621 in OpenStack Compute (nova) "Inappropriate split of transport_url string" [Undecided,New] | 16:16 |
| *** Guest1857 is now known as redrobot | 16:17 | |
| finucannot | Much to my dismay, no, I did not | 16:17 |
| * finucannot hangs head in shame | 16:17 | |
| *** ash2307 has joined #openstack-nova | 16:18 | |
| *** cdent has joined #openstack-nova | 16:22 | |
| cdent | thanks melwitt, I got your response out of the logs. Had a power outage just then. | 16:22 |
| cdent | melwitt: so from your perpective getting the funcitonality done in placement before U starts up would be helpful | 16:24 |
| *** spatel has quit IRC | 16:25 | |
| *** dklyle has joined #openstack-nova | 16:26 | |
| melwitt | cdent: I don't think it's critical, but I feel like the question would be better answered by someone like tssurya, who is planning to consume the changes | 16:27 |
| cdent | melwitt: she was involved in the earlier discussions and was hoping for more input from you | 16:27 |
| melwitt | heh. well, there are some quirks with counting quota usage from placement today which need consumer types to be resolved. but counting from placement is opt-in, and I'd be looking to operators to know how urgently they want the quirks resolved | 16:29 |
| melwitt | and AFAIK only CERN is planning to opt-in to counting quota usage from placement, the majority of folks will be running the default I expect | 16:30 |
| melwitt | so, I consider it as medium priority unless operators signal otherwise | 16:31 |
| cdent | I think in that case we can let CERN drive the bus then, and if tssurya needs an assist from other placement folk we can work that out. if this never ending performance improvement train in placement ever stops there may be some cycles spare | 16:31 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add 'Instance.get_vifs' helper method https://review.opendev.org/675665 | 16:31 |
| melwitt | cdent: sounds reasonable to me | 16:32 |
| dansmith | mriedem: yep, piled on | 16:34 |
| *** rpittau is now known as rpittau|afk | 16:35 | |
| melwitt | cdent: to be clear, on my side my plan is to start working on integration whenever the placement side is ready. we can't do it this cycle, it's too late, but whenever it's ready I would write up a spec to consume it | 16:37 |
| *** dklyle has quit IRC | 16:37 | |
| *** dklyle has joined #openstack-nova | 16:37 | |
| cdent | melwitt: one factor is that none of the regular active contributors to placement has any particular need for the feature, so it's good (and appropriate) that tssurya is willing and able to work on it | 16:38 |
| melwitt | cdent: yeah, makes sense. just wanted to be clear that it wouldn't get dropped on the floor once it's done. I'd write up the spec and do the integration once ready, but that said it's medium priority in my mind unless CERN turns up the priority | 16:40 |
| cdent | ✔ | 16:40 |
| *** ricolin_ has joined #openstack-nova | 16:41 | |
| *** markvoelker has quit IRC | 16:41 | |
| openstackgerrit | Merged openstack/nova stable/pike: Replace non-nova server fault message https://review.opendev.org/674877 | 16:42 |
| *** ricolin has quit IRC | 16:44 | |
| *** markvoelker has joined #openstack-nova | 16:44 | |
| *** irclogbot_1 has quit IRC | 16:47 | |
| *** irclogbot_2 has joined #openstack-nova | 16:48 | |
| *** irclogbot_2 has quit IRC | 16:49 | |
| *** irclogbot_2 has joined #openstack-nova | 16:50 | |
| *** eharney has quit IRC | 16:50 | |
| *** tssurya has joined #openstack-nova | 16:55 | |
| *** tesseract has quit IRC | 17:00 | |
| *** dklyle has quit IRC | 17:07 | |
| *** jcosmao has left #openstack-nova | 17:07 | |
| *** david-lyle has joined #openstack-nova | 17:07 | |
| *** david-lyle has quit IRC | 17:10 | |
| *** david-lyle has joined #openstack-nova | 17:10 | |
| mgoddard | hi mriedem, quick question about upgrade checks | 17:12 |
| efried | mgoddard: I think Matt's at lunch fyi | 17:13 |
| mgoddard | efried: oh ok, thanks | 17:13 |
| efried | dansmith knows things about upgrades tho | 17:13 |
| *** igordc has joined #openstack-nova | 17:17 | |
| mgoddard | here's the question, perhaps someone else can answer | 17:21 |
| openstackgerrit | Merged openstack/nova stable/queens: Delete resource providers for all nodes when deleting compute service https://review.opendev.org/666862 | 17:21 |
| mgoddard | it's my understanding that nova-status upgrade check should be run after DB sync and data migrations | 17:21 |
| openstackgerrit | Merged openstack/nova master: Filter UnsupportedServiceVersion warning https://review.opendev.org/674515 | 17:21 |
| mgoddard | could it be harmful to run it before starting an upgrade (using the new code)? | 17:22 |
| dansmith | no, | 17:22 |
| dansmith | it's expected to run before the upgrade to tell you what to look out for, | 17:22 |
| dansmith | and after to make sure everything went green | 17:22 |
| *** betherly has joined #openstack-nova | 17:22 | |
| mgoddard | that's how I wanted it to work, but when I've discussed it with mriedem previously I came away with the above impression | 17:23 |
| dansmith | nova-status does not *do* anything, so no damage could occur | 17:23 |
| *** ash2307 has left #openstack-nova | 17:24 | |
| mgoddard | no, but I don't want it to fail due to running it at the wrong time | 17:24 |
| mgoddard | Install new code | 17:24 |
| mgoddard | Sync the database schema for new models (nova-manage api_db sync; nova-manage db sync) | 17:24 |
| mgoddard | Run the online data migrations (nova-manage db online_data_migrations) | 17:24 |
| mgoddard | Run the upgrade check (nova-status upgrade check) | 17:24 |
| mgoddard | Restart services with new code | 17:25 |
| mgoddard | from https://docs.openstack.org/nova/latest/reference/upgrade-checks.html | 17:25 |
| dansmith | sure | 17:25 |
| dansmith | are you worried about it "failing" because you're scripting this and you want to know if you can always run it and expect a zero return or what? | 17:25 |
| mgoddard | right | 17:25 |
| dansmith | okay, well, it's probably not something you can do blindly regardless, | 17:26 |
| dansmith | because sometimes the checks are things like "yo dawg, you need to modify your flavors to remove X which we've deprecated" or whatever | 17:26 |
| mgoddard | can I safely run it before doing any part of the upgrade (including db sync)? | 17:26 |
| dansmith | which isn't going to get "fixed" by running them | 17:26 |
| dansmith | again, define "safely" | 17:26 |
| dansmith | if you mean "without breaking stuff" then ... of course | 17:27 |
| mgoddard | I don't mind if it tells me to do something that I do need to do | 17:27 |
| dansmith | nova-status is read-only | 17:27 |
| dansmith | it doesn't make changes | 17:27 |
| dansmith | you can run it any time you want and the worst thing that will happen is it will complain about something, end of story | 17:27 |
| mgoddard | but if it fails because I'm running it at the wrong point then that's bad | 17:27 |
| dansmith | you know that it will *usually* not return zero right? | 17:28 |
| dansmith | so I mean, again, define "fail" | 17:28 |
| mgoddard | yeah, we allow 0 or 1 | 17:28 |
| dansmith | IIRC, the point of it not using the db models is so it can run entirely against the old schema and do its checks, | 17:29 |
| mgoddard | let me try to rephrase | 17:29 |
| dansmith | so barring bugs, I think you will get constrained results even before db sync | 17:29 |
| mgoddard | in order to get the 'right' answer out of it, should I run upgrade checks only after doing the DB sync and migrations? | 17:29 |
| dansmith | I don't think it's that simple, | 17:30 |
| dansmith | because I think that we've had some checks which were "hey before you do anything you need to manually change X" | 17:30 |
| dansmith | mriedem has done 95% of the work on this and definitely has the current scope/intent in his head more than me, so I guess I'll just shut up, | 17:31 |
| mgoddard | so it could be useful to run both before DB sync, and after? | 17:31 |
| dansmith | but I think you're kinda assuming more about it than you should | 17:31 |
| mgoddard | perhaps | 17:31 |
| openstackgerrit | Merged openstack/nova stable/queens: Add functional recreate test for bug 1764556 https://review.opendev.org/673824 | 17:32 |
| openstack | bug 1764556 in OpenStack Compute (nova) queens ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Medium,In progress] https://launchpad.net/bugs/1764556 - Assigned to Matt Riedemann (mriedem) | 17:32 |
| openstackgerrit | Merged openstack/nova stable/queens: Add functional regression test for bug 1778305 https://review.opendev.org/673825 | 17:32 |
| openstack | bug 1778305 in OpenStack Compute (nova) queens "Nova may erronously look up service version of a deleted service, when hostname have been reused" [Medium,In progress] https://launchpad.net/bugs/1778305 - Assigned to Matt Riedemann (mriedem) | 17:32 |
| mgoddard | thanks for the input dansmith, I'll let mriedem weigh in if he disagrees otherwise I'll go with an early check | 17:34 |
| mgoddard | and possibly a second after the sync/migration | 17:35 |
| dansmith | just to be clear, | 17:35 |
| dansmith | well, nevermind | 17:36 |
| *** xek has joined #openstack-nova | 17:37 | |
| melwitt | mriedem: question in https://review.opendev.org/674908 | 17:39 |
| *** betherly has quit IRC | 17:39 | |
| *** bbowen__ has quit IRC | 17:41 | |
| *** eharney has joined #openstack-nova | 17:48 | |
| openstackgerrit | Merged openstack/nova stable/queens: Don't generate service UUID for deleted services https://review.opendev.org/673827 | 17:49 |
| mriedem | mgoddard: grenade runs the db syncs before the upgrade status check and fails if the return code is >= 2: https://github.com/openstack/grenade/blob/00ad9a89684360ca53d7cdda62763de37ba98510/projects/60_nova/upgrade.sh#L94 - which aligns with the doc (that's probably part of where i got that for writing the doc), | 17:49 |
| mriedem | running nova-status upgrade check *before* db sync is _undefined_ | 17:49 |
| mriedem | we don't test it that way | 17:49 |
| mriedem | we don't use the versioned object model code, we do straight sqlalchemy db execution stuff, | 17:50 |
| mriedem | but i wouldn't be surprised if at some point someone writes an upgrade check that is looking at maybe a column that doesn't exist until you've sync'ed, idk | 17:50 |
| mriedem | but like dansmith said, i think we try to avoid that and could justify saying something like that is a bug | 17:50 |
| *** betherly has joined #openstack-nova | 17:50 | |
| dansmith | mriedem: for things where we need to warn the person that a blocker migration is going to hork on their db state, they'd need to run it ahead of time right? | 17:52 |
| mriedem | i see takashin has a patch up for your bug https://bugs.launchpad.net/nova/+bug/1833278 | 17:52 |
| openstack | Launchpad bug 1833278 in OpenStack Compute (nova) "nova-status upgrade check should fail if db sync has not been performed" [Medium,In progress] - Assigned to Takashi NATSUME (natsume-takashi) | 17:52 |
| dansmith | meaning, if we're about to drop a column or add a constraint | 17:52 |
| dansmith | I thought we had one of those early on | 17:52 |
| mriedem | dansmith: takashi's patch would break that if we did | 17:52 |
| dansmith | I really thought one of the first uses for nova-status was to warn people before we added a constraint, but I don't remember the details | 17:53 |
| mriedem | earliest checks were for cells v2 and placement | 17:53 |
| mriedem | in ocata | 17:53 |
| mriedem | https://github.com/openstack/nova/blob/stable/ocata/nova/cmd/status.py#L358 | 17:53 |
| melwitt | dansmith: I thought the same thing. like, "you have homework to do before running db migrations" | 17:53 |
| melwitt | or maybe it's before online data migrations? | 17:54 |
| dansmith | it tells you if you *haven't* run online migrations, | 17:54 |
| mriedem | right for some definitely - there was a check for missing request specs which was solved with an online data migration, | 17:55 |
| dansmith | but I really thought we were prescribing running it before to handle things like column drops, constraints, etc | 17:55 |
| mriedem | and couldn't be done with a blocker migratoin b/c the records are in different dbs | 17:55 |
| melwitt | yeah ok | 17:55 |
| mriedem | as far as i know we haven't dropped a column or added a new constraint in a loong time | 17:57 |
| mriedem | so haven't really had to think about the ordering of that plus the upgrade check | 17:57 |
| *** xXraphXx has quit IRC | 17:58 | |
| dansmith | mriedem: but, if people are only ever running this after db sync, we can't rely on this to help us in that regard | 17:58 |
| dansmith | and basically have to stick to blocker migrations | 17:58 |
| mriedem | or you add the check in the n-1 release | 17:58 |
| mriedem | "i see you've got stuff in column x which is going to be dropped in the next release, you should do y to drain it" | 17:59 |
| mriedem | or whatever | 17:59 |
| mriedem | we've added checks that get backported, like for the ironic flavor migratoins in pike | 17:59 |
| dansmith | if we're going to require db sync first, why did we go with raw sqla access then? | 18:00 |
| mriedem | but i don't think we've ever said this is an end-all perfect tool, it's part of the whole box - blocker migratoins, online data migratoins, runtime data migrations, and the checks to automate release notes | 18:00 |
| dansmith | I mean, that was the whole point of doing that, AFAIK, so we could talk to the schema independent of the models | 18:00 |
| dansmith | sure | 18:00 |
| mriedem | i'm not saying db sync is required, | 18:00 |
| mriedem | i'm saying that's how we test it, and how it behaves before db sync is undefined | 18:00 |
| dansmith | ack, | 18:01 |
| mriedem | if we want to support both ways, we need to test it both ways | 18:01 |
| dansmith | but I think the question is about intent and assumptions and what-not, | 18:01 |
| dansmith | especially in the face of that patch to require it | 18:01 |
| mriedem | yup, which is a result of a bug that mgoddard opened | 18:01 |
| mriedem | to i guess make us shit or get off the pot | 18:01 |
| mriedem | i prefer to wallow thank you very much | 18:02 |
| mriedem | and i think he did that b/c he's getting pushback in kolla about adding the checks in | 18:02 |
| mriedem | https://review.opendev.org/#/c/665643/ | 18:02 |
| *** betherly has quit IRC | 18:03 | |
| *** xek has quit IRC | 18:03 | |
| dansmith | his patch actually doesn't make it required, so much as it just checks that you've done it I guess | 18:03 |
| dansmith | which is less concerning | 18:03 |
| dansmith | if the expectation of the tool is to tell you go/no-go for deploying new code, then it's probably fine to have that be an ERROR and not a WARN | 18:05 |
| mriedem | https://review.opendev.org/#/c/667047/10/nova/cmd/status.py@395 is a fail | 18:05 |
| dansmith | right, but ^ | 18:05 |
| mriedem | and https://review.opendev.org/#/c/667047/10/nova/cmd/status.py@370 | 18:05 |
| *** factor has quit IRC | 18:06 | |
| dansmith | it's still legit to run that before you do db sync to catch other soft changes knowing that the error is expected before you've done anything | 18:06 |
| *** icarusfactor has joined #openstack-nova | 18:06 | |
| mriedem | maybe, but then you have to build some logic into your ansible that detects which check failed and ignore this one if you know you're doing before-sync checks | 18:07 |
| dansmith | we could have a pre-upgrade command in that tool which doesn't run stuff like that, but does do things like sanity checks, | 18:07 |
| mriedem | which gets back to something mnaser originally asked for which was more machine-readable output | 18:07 |
| dansmith | we could also have the pre-upgrade run any of the checks from the previous release as error->fail, and any of the current release checks as error->warn or something | 18:07 |
| mriedem | separating the commands would make more sense imo | 18:07 |
| dansmith | and just move them each release | 18:07 |
| mriedem | then you have a defined behavior and we'd test that in grenade | 18:08 |
| dansmith | yeah | 18:08 |
| mnaser | i did this a really long time ago but yeah -- https://review.opendev.org/#/c/576944/ | 18:08 |
| mnaser | also just a friendly bringing up of this fun one https://bugs.launchpad.net/nova/+bug/1839560 | 18:12 |
| openstack | Launchpad bug 1839560 in OpenStack Compute (nova) "ironic: moving node to maintenance makes it unusable afterwards" [High,In progress] - Assigned to Matt Riedemann (mriedem) | 18:12 |
| mriedem | i've had it with friendship | 18:12 |
| mriedem | mnaser: i said we should ping dansmith about that in the morning, and now i've already exceeded my sweet dan quota for the day on upgrade checkers and queens backport reviews | 18:13 |
| dansmith | yeah you were done by 8am | 18:13 |
| mriedem | ha | 18:13 |
| dansmith | please try again on monday | 18:13 |
| mriedem | dan is out of the office and out of clothes | 18:13 |
| *** cdent has quit IRC | 18:15 | |
| mriedem | mnaser: i also feel like i woke up at 2am thinking about a way to avoid the revert and still fix the unique constraint thing in a backportable way, but i think it eludes me. something something catch DuplicateEntry on ComputeNode.create(), look for existing deleted node with the same uuid, and just update it and set deleted=0. | 18:15 |
| mriedem | but that's pretty hacky | 18:15 |
| *** betherly has joined #openstack-nova | 18:15 | |
| mnaser | that does feel pretty hacky | 18:16 |
| mnaser | does the compute_node entry get created after or before the 'hypervisor' entry | 18:16 |
| mnaser | aka maybe that hack can happen *only if* its using ironic but i dunno, seems like we're digging ourself a bigger hole | 18:16 |
| mriedem | hypervisor entry? | 18:17 |
| * tbachman just notices that he doesn’t see leakypipes any more | 18:17 | |
| mriedem | tbachman: he was gone after the last summit | 18:17 |
| mnaser | sorry its been a long day | 18:17 |
| tbachman | I’m so out of touch | 18:17 |
| mriedem | gone but not forgotten | 18:17 |
| tbachman | heh | 18:17 |
| mnaser | i think he's at aws | 18:17 |
| mriedem | i just chatted him up this morning | 18:17 |
| mriedem | he is | 18:17 |
| mnaser | i still see him respond to placement threads | 18:17 |
| mnaser | on the ML | 18:17 |
| mnaser | so not too far away :P | 18:17 |
| tbachman | Just when I thought I was out, they pull me right back in | 18:18 |
| mriedem | those are more like self-inflicted wounds | 18:19 |
| tbachman | LI profile says Principal Open Source Engineer at AWS | 18:19 |
| tbachman | ah, but I guess he’s a kubernetes guy now | 18:20 |
| mriedem | yes he's working on EKS | 18:20 |
| tbachman | thx for bringing me up to date | 18:20 |
| * tbachman pulls out his blackberry phone | 18:20 | |
| tbachman | checks yahoo email | 18:21 |
| tbachman | (that last one is actally true) | 18:21 |
| *** betherly has quit IRC | 18:23 | |
| mriedem | melwitt: replied, sort of | 18:26 |
| melwitt | mriedem: thanks. yeah, just thought it was weird if you happened to know what/why that is. I hadn't seen it before | 18:27 |
| mriedem | you must be on cve backport duty with lee | 18:38 |
| *** boxiang has quit IRC | 18:38 | |
| *** boxiang has joined #openstack-nova | 18:38 | |
| artom | mriedem, just come work for us, at this point. You know our internal better than we do ;) | 18:42 |
| artom | *internals | 18:42 |
| *** efried is now known as efried_pto | 18:42 | |
| artom | Actually don't - we already have too many cores on staff. | 18:43 |
| melwitt | heh, well, it's a cve so important to get the fixes merged and out there. and I had the context on the bug and fix for reviewing | 18:45 |
| *** brault has joined #openstack-nova | 18:45 | |
| mriedem | artom: but then i could support the same-company approvals policy! | 18:45 |
| artom | mriedem, sellout | 18:45 |
| mriedem | melwitt: yeah i know, i appreciate the quick reviews | 18:46 |
| *** brault has quit IRC | 18:49 | |
| mriedem | dansmith: if you prefer handling the DuplicateEntry-on-create-then-update-and-undelete thing here https://review.opendev.org/#/c/675496/ i can go that directoin | 18:53 |
| mriedem | personally i'd like to keep the ironic node id, compute node uuid and resource provider id all aligned for debuggability | 18:54 |
| mriedem | but it's low priority | 18:54 |
| mriedem | the alignment i mean, not the fix that mnaser is waiting on | 18:55 |
| dansmith | mriedem: un-deleting it lets you do that, no? | 19:00 |
| dansmith | but yeah, definitely my preference | 19:00 |
| *** ricolin_ has quit IRC | 19:02 | |
| *** xek has joined #openstack-nova | 19:05 | |
| mriedem | dansmith: right | 19:05 |
| mriedem | so if i can make that work i'll go with it, will work on a recreate test first, | 19:05 |
| mriedem | again, this was something i think i woke up to at ~2am | 19:05 |
| mriedem | and the cat howling down the hall | 19:05 |
| dansmith | okay | 19:07 |
| *** betherly has joined #openstack-nova | 19:25 | |
| *** betherly has quit IRC | 19:34 | |
| *** BjoernT has quit IRC | 19:44 | |
| *** ralonsoh has quit IRC | 19:57 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.opendev.org/635669 | 20:08 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827 | 20:08 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for augmenting migrate_data with info from claims https://review.opendev.org/634828 | 20:08 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.opendev.org/635229 | 20:08 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.opendev.org/634605 | 20:08 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606 | 20:08 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021 | 20:08 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Functional test for NUMA live migration https://review.opendev.org/672595 | 20:08 |
| artom | OK, that's basically ready. | 20:08 |
| artom | Although as the WIP indicates on the last func test patch, I need to fiddle with it some more to assert more things. | 20:08 |
| *** whoami-rajat has quit IRC | 20:12 | |
| *** betherly has joined #openstack-nova | 20:17 | |
| *** bbowen has joined #openstack-nova | 20:17 | |
| *** jaypipes has quit IRC | 20:22 | |
| *** betherly has quit IRC | 20:27 | |
| *** bbowen_ has joined #openstack-nova | 20:33 | |
| *** bbowen has quit IRC | 20:34 | |
| *** betherly has joined #openstack-nova | 20:36 | |
| *** nweinber has quit IRC | 20:37 | |
| *** derekh has quit IRC | 20:44 | |
| *** derekh has joined #openstack-nova | 20:46 | |
| *** mjozefcz has joined #openstack-nova | 20:52 | |
| *** betherly has quit IRC | 20:53 | |
| *** mjozefcz has quit IRC | 20:57 | |
| *** artom has quit IRC | 21:01 | |
| *** igordc has quit IRC | 21:01 | |
| *** markvoelker has quit IRC | 21:01 | |
| mriedem | ha | 21:04 |
| mriedem | another bug | 21:04 |
| mriedem | sumbitch | 21:05 |
| mriedem | https://github.com/openstack/nova/blob/6b7d0caad86fe32ffc49a8672de1eb7258f3b919/nova/compute/resource_tracker.py#L570 | 21:05 |
| mriedem | if cn.create() fails, | 21:05 |
| mriedem | we've already mapped it in self.compute_nodes | 21:05 |
| mriedem | so the next time around we won't create it | 21:05 |
| mriedem | sob | 21:05 |
| *** bbowen__ has joined #openstack-nova | 21:06 | |
| *** bbowen_ has quit IRC | 21:09 | |
| mriedem | mnaser: dansmith: ok i've got a functional recreate test coming forthwith | 21:10 |
| *** slaweq has quit IRC | 21:10 | |
| mriedem | after bashing my brains for about an hour | 21:10 |
| *** markvoelker has joined #openstack-nova | 21:11 | |
| *** bbowen__ has quit IRC | 21:14 | |
| mriedem | heh at least i didn't approve that back in ocata (but was +2) | 21:16 |
| *** artom has joined #openstack-nova | 21:17 | |
| artom | And on http://lists.openstack.org/pipermail/openstack-discuss/2019-August/008401.html's happy note, I'm calling it a week. | 21:19 |
| *** bbowen has joined #openstack-nova | 21:21 | |
| *** markvoelker has quit IRC | 21:21 | |
| *** bbowen has quit IRC | 21:26 | |
| *** slaweq has joined #openstack-nova | 21:27 | |
| *** bbowen has joined #openstack-nova | 21:30 | |
| *** betherly has joined #openstack-nova | 21:31 | |
| *** slaweq has quit IRC | 21:32 | |
| *** artom has quit IRC | 21:33 | |
| *** bbowen has quit IRC | 21:44 | |
| *** bbowen has joined #openstack-nova | 21:48 | |
| *** betherly has quit IRC | 21:48 | |
| *** slaweq has joined #openstack-nova | 21:51 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: rt: only map compute node if we created it https://review.opendev.org/675704 | 21:54 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression recreate test for bug 1839560 https://review.opendev.org/675705 | 21:54 |
| openstack | bug 1839560 in OpenStack Compute (nova) "ironic: moving node to maintenance makes it unusable afterwards" [High,In progress] https://launchpad.net/bugs/1839560 - Assigned to Matt Riedemann (mriedem) | 21:54 |
| *** bbowen has quit IRC | 21:54 | |
| mriedem | ^ later than i'd hoped but i wanted to split out that rt bug fix from the functional test since it goes back to ocata | 21:54 |
| *** slaweq has quit IRC | 21:56 | |
| *** xek has quit IRC | 22:02 | |
| *** betherly has joined #openstack-nova | 22:11 | |
| *** betherly has quit IRC | 22:15 | |
| *** mriedem has quit IRC | 22:17 | |
| *** francoisp has quit IRC | 22:18 | |
| *** betherly has joined #openstack-nova | 22:22 | |
| *** markvoelker has joined #openstack-nova | 22:23 | |
| *** betherly has quit IRC | 22:27 | |
| *** markvoelker has quit IRC | 22:28 | |
| *** panda has quit IRC | 22:30 | |
| openstackgerrit | Merged openstack/nova master: [Trivial]Remove unused _last_bw_usage_cell_update https://review.opendev.org/675543 | 22:31 |
| openstackgerrit | Merged openstack/nova master: docs: update 2.23 REST API version history https://review.opendev.org/674948 | 22:31 |
| openstackgerrit | Merged openstack/nova master: api-ref: document valid GET /os-migrations?migration_type values https://review.opendev.org/674949 | 22:32 |
| *** panda has joined #openstack-nova | 22:32 | |
| openstackgerrit | Merged openstack/nova master: Make nova-multi-cell job voting and gating https://review.opendev.org/674453 | 22:54 |
| openstackgerrit | Merged openstack/nova master: Add useful error log when _determine_version_cap raises DBNotAllowed https://review.opendev.org/675148 | 23:04 |
| openstackgerrit | Merged openstack/nova master: Convert HostMapping.cells to a dict https://review.opendev.org/663387 | 23:04 |
| *** weshay is now known as weshay_pto | 23:37 | |
| openstackgerrit | Merged openstack/nova master: Retrun 400 if invalid query parameters are specified https://review.opendev.org/670440 | 23:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!