| *** brinzhang has joined #openstack-nova | 00:33 | |
| *** yedongcan has joined #openstack-nova | 03:03 | |
| *** brinzhang_ has joined #openstack-nova | 03:25 | |
| *** brinzhang has quit IRC | 03:30 | |
| *** psachin has joined #openstack-nova | 03:35 | |
| *** udesale has joined #openstack-nova | 04:04 | |
| *** ash2307 has quit IRC | 04:15 | |
| *** ash2307 has joined #openstack-nova | 04:18 | |
| *** toabctl has quit IRC | 04:21 | |
| *** toabctl has joined #openstack-nova | 04:24 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Add the virt driver interface for claim and unclaim the devices https://review.opendev.org/670782 | 05:02 |
|---|---|---|
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Moves the allocation retrieving early https://review.opendev.org/670783 | 05:02 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Calling the virt driver's claim/unclaim_for_instance in resource tracker https://review.opendev.org/670784 | 05:02 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Add DeviceManager to the libvirt virt driver https://review.opendev.org/671388 | 05:02 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Populates the existing mediated devices in the libvirt device manager https://review.opendev.org/670787 | 05:02 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Using the claim/unclaim_for_instance for mdevs https://review.opendev.org/671222 | 05:02 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Adds functional test for creating the instance with vgpus https://review.opendev.org/671398 | 05:02 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Add functional tests for resize with VGPU https://review.opendev.org/675106 | 05:02 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Indroduce new LibvirtConfigGuestPMEM https://review.opendev.org/672956 | 05:02 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Populates existing pmems in libvirt device manager https://review.opendev.org/672957 | 05:02 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Report pmem namespaces resources by provider tree https://review.opendev.org/634551 | 05:02 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Support instance creation and resize with pmems https://review.opendev.org/672958 | 05:02 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Add functional tests for persistent memory https://review.opendev.org/675592 | 05:02 |
| *** pcaruana has joined #openstack-nova | 05:29 | |
| *** ratailor has joined #openstack-nova | 05:35 | |
| *** pcaruana has quit IRC | 05:37 | |
| *** janki has joined #openstack-nova | 05:48 | |
| *** pcaruana has joined #openstack-nova | 05:50 | |
| *** dpawlik has joined #openstack-nova | 06:08 | |
| *** mkrai has joined #openstack-nova | 06:11 | |
| *** markvoelker has joined #openstack-nova | 06:31 | |
| *** slaweq has joined #openstack-nova | 06:33 | |
| *** markvoelker has quit IRC | 06:36 | |
| *** mkrai has quit IRC | 06:45 | |
| *** mkrai_ has joined #openstack-nova | 06:45 | |
| *** yaawang has quit IRC | 07:00 | |
| *** yaawang has joined #openstack-nova | 07:01 | |
| *** mjozefcz has joined #openstack-nova | 07:04 | |
| *** ivve has joined #openstack-nova | 07:05 | |
| *** luksky has joined #openstack-nova | 07:09 | |
| *** rcernin has quit IRC | 07:13 | |
| *** tesseract has joined #openstack-nova | 07:14 | |
| lennyb | stephenfin: Hi, please review #https://review.opendev.org/#/c/675776/ revert that broke MacVtap. | 07:17 |
| *** aojea has joined #openstack-nova | 07:18 | |
| *** aojeagarcia has joined #openstack-nova | 07:18 | |
| *** damien_r has joined #openstack-nova | 07:23 | |
| *** aojea has quit IRC | 07:27 | |
| *** panda has quit IRC | 07:30 | |
| *** panda has joined #openstack-nova | 07:33 | |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support re-configure deleted_on_termination in server https://review.opendev.org/580336 | 07:40 |
| *** zbr is now known as zbr|flu | 07:47 | |
| *** mkrai_ has quit IRC | 07:54 | |
| *** helenafm has joined #openstack-nova | 07:54 | |
| *** rpittau|afk is now known as rpittau | 07:54 | |
| *** mkrai has joined #openstack-nova | 07:55 | |
| *** cdent has joined #openstack-nova | 08:12 | |
| *** janki has quit IRC | 08:16 | |
| *** janki has joined #openstack-nova | 08:17 | |
| *** jchhatbar has joined #openstack-nova | 08:18 | |
| *** janki has quit IRC | 08:22 | |
| *** cdent has quit IRC | 08:33 | |
| *** cdent has joined #openstack-nova | 08:33 | |
| *** derekh has joined #openstack-nova | 08:37 | |
| *** tesseract has quit IRC | 08:42 | |
| *** slaweq has quit IRC | 08:42 | |
| *** ash2307 has quit IRC | 08:42 | |
| *** brinzhang_ has quit IRC | 08:42 | |
| *** yedongcan has quit IRC | 08:42 | |
| *** irclogbot_1 has quit IRC | 08:42 | |
| *** yonglihe has quit IRC | 08:42 | |
| *** mordred has joined #openstack-nova | 08:43 | |
| *** brinzhang_ has joined #openstack-nova | 08:43 | |
| *** slaweq has joined #openstack-nova | 08:43 | |
| *** ash2307 has joined #openstack-nova | 08:43 | |
| *** tesseract has joined #openstack-nova | 08:43 | |
| *** brinzhang_ has quit IRC | 08:43 | |
| *** brinzhang_ has joined #openstack-nova | 08:44 | |
| *** jchhatbar has quit IRC | 08:44 | |
| *** brinzhang has joined #openstack-nova | 08:45 | |
| *** openstackgerrit has quit IRC | 08:45 | |
| *** yedongcan has joined #openstack-nova | 08:47 | |
| *** irclogbot_1 has joined #openstack-nova | 08:47 | |
| *** yonglihe has joined #openstack-nova | 08:47 | |
| *** irclogbot_1 has quit IRC | 08:49 | |
| *** irclogbot_3 has joined #openstack-nova | 08:52 | |
| *** ociuhandu has joined #openstack-nova | 09:05 | |
| *** jaosorior has joined #openstack-nova | 09:07 | |
| *** ociuhandu has quit IRC | 09:17 | |
| *** ociuhandu has joined #openstack-nova | 09:22 | |
| *** tssurya has joined #openstack-nova | 09:40 | |
| *** ociuhandu has quit IRC | 09:41 | |
| *** shilpasd has joined #openstack-nova | 09:45 | |
| *** mvkr has joined #openstack-nova | 09:47 | |
| *** xek has joined #openstack-nova | 09:57 | |
| *** ociuhandu has joined #openstack-nova | 09:59 | |
| *** ociuhandu has quit IRC | 10:01 | |
| *** ociuhandu has joined #openstack-nova | 10:01 | |
| *** brinzhang_ has joined #openstack-nova | 10:08 | |
| *** sapd1_x has joined #openstack-nova | 10:08 | |
| *** markvoelker has joined #openstack-nova | 10:09 | |
| *** brinzhang has quit IRC | 10:12 | |
| *** markvoelker has quit IRC | 10:14 | |
| *** kaisers has quit IRC | 10:16 | |
| *** sapd1_x has quit IRC | 10:16 | |
| *** artom has joined #openstack-nova | 10:17 | |
| *** kaisers has joined #openstack-nova | 10:18 | |
| *** ociuhandu has quit IRC | 10:20 | |
| *** ociuhandu has joined #openstack-nova | 10:21 | |
| *** ksdean has joined #openstack-nova | 10:28 | |
| *** ksdean has quit IRC | 10:28 | |
| *** ksdean has joined #openstack-nova | 10:29 | |
| sean-k-mooney | /away | 10:38 |
| *** openstackgerrit has joined #openstack-nova | 10:41 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: re-calculate provider mapping during migration https://review.opendev.org/655112 | 10:41 |
| *** pcaruana has quit IRC | 10:43 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422 | 10:43 |
| *** pcaruana has joined #openstack-nova | 10:43 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114 | 10:45 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109 | 10:47 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: func test for migrate server with ports having resource request https://review.opendev.org/655113 | 10:49 |
| *** yonglihe has quit IRC | 10:49 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | 10:51 |
| *** jaosorior has quit IRC | 10:54 | |
| *** janki has joined #openstack-nova | 11:08 | |
| *** whoami-rajat has joined #openstack-nova | 11:08 | |
| sean-k-mooney | stephenfin: im going to move the validate_trait function form https://review.opendev.org/#/c/665775/10 into the first patch https://review.opendev.org/#/c/666914/6 and cache it. once its cached i can then vaildate the traits more libarlly as i am creating them. | 11:13 |
| sean-k-mooney | what should be the behavior for invalid traits | 11:14 |
| sean-k-mooney | skip them and log a warning or something else | 11:14 |
| *** udesale has quit IRC | 11:18 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Add functional tests for persistent memory https://review.opendev.org/675592 | 11:21 |
| *** ratailor has quit IRC | 11:24 | |
| *** ociuhandu has quit IRC | 11:27 | |
| *** ociuhandu has joined #openstack-nova | 11:27 | |
| *** ociuhandu_ has joined #openstack-nova | 11:28 | |
| *** ociuhandu has quit IRC | 11:32 | |
| *** cooldharma06 has joined #openstack-nova | 11:36 | |
| cooldharma06 | hi all is nova rebuild option support uerdata.? | 11:37 |
| sean-k-mooney | cooldharma06: i cant recall if we added support for that or ssh keys recently but it support one fo the two | 11:40 |
| sean-k-mooney | cooldharma06: it support both on master https://docs.openstack.org/api-ref/compute/?expanded=rebuild-server-rebuild-action-detail#rebuild-server-rebuild-action | 11:41 |
| sean-k-mooney | New in version 2.57 | 11:41 |
| *** ociuhandu_ has quit IRC | 11:44 | |
| cooldharma06 | sean-k-mooney: https://review.opendev.org/#/c/431052/ in this commit they mentioned like it will be added later | 11:45 |
| cooldharma06 | i need to add some extra routes during nova rebuild so i thought i can acheive using rebuild | 11:46 |
| sean-k-mooney | that is a spec from pike i think we implemented it seperatly | 11:46 |
| cooldharma06 | ok thank you. In nova rebuild cli is there any explicit parameter or i need to pass userdata in some other form.? | 11:48 |
| sean-k-mooney | key pairs was added with https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/rebuild-keypair-reset.html in queens i dont see a spec for user data but sicne it was added in a later micro version it was added in or after queens | 11:49 |
| cooldharma06 | sean-k-mooney oops i am using pike in my environment | 11:51 |
| *** janki has quit IRC | 11:51 | |
| sean-k-mooney | on master you can do nova rebuild --os-compute-api-version '2.57' --user-data <data in base64> | 11:52 |
| sean-k-mooney | pike does not have support for this sorry | 11:52 |
| sean-k-mooney | cooldharma06: normally you would add routes via neutron | 11:52 |
| sean-k-mooney | not via userdata | 11:52 |
| sean-k-mooney | you would update teh subnet with addtional routes | 11:53 |
| sean-k-mooney | and they will be served via dhcp | 11:53 |
| *** janki has joined #openstack-nova | 11:53 | |
| *** brinzhang_ has quit IRC | 11:53 | |
| *** brinzhang_ has joined #openstack-nova | 11:54 | |
| cooldharma06 | actually i want to add route to only to that particular exiting machine | 11:58 |
| cooldharma06 | so i thought to try with rebuild option with extra routes | 11:58 |
| sean-k-mooney | a post boot ansible sricpt/ssh is proably a better option. | 11:59 |
| cooldharma06 | post boot will work i think.. thank you i ll try this one | 12:00 |
| cooldharma06 | thanks for your time and info.. :) | 12:01 |
| *** ociuhandu has joined #openstack-nova | 12:03 | |
| *** jaosorior has joined #openstack-nova | 12:03 | |
| *** ash2307 has left #openstack-nova | 12:04 | |
| *** ociuhandu has quit IRC | 12:08 | |
| *** pas-ha has quit IRC | 12:13 | |
| *** pas-ha has joined #openstack-nova | 12:14 | |
| *** vdrok has quit IRC | 12:14 | |
| *** vdrok has joined #openstack-nova | 12:14 | |
| *** priteau has joined #openstack-nova | 12:20 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: allow getting resource request of every bound ports of an instance https://review.opendev.org/655110 | 12:23 |
| *** mjozefcz has quit IRC | 12:23 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pass network API to the conducor's MigrationTask https://review.opendev.org/655111 | 12:25 |
| *** mjozefcz has joined #openstack-nova | 12:26 | |
| *** mjozefcz has quit IRC | 12:26 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add request_spec to server move RPC calls https://review.opendev.org/655721 | 12:27 |
| *** mjozefcz has joined #openstack-nova | 12:27 | |
| *** markvoelker has joined #openstack-nova | 12:28 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: re-calculate provider mapping during migration https://review.opendev.org/655112 | 12:28 |
| *** edleafe has joined #openstack-nova | 12:29 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422 | 12:30 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114 | 12:30 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109 | 12:34 |
| *** nweinber has joined #openstack-nova | 12:34 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: func test for migrate server with ports having resource request https://review.opendev.org/655113 | 12:36 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | 12:36 |
| *** ociuhandu has joined #openstack-nova | 12:36 | |
| *** nweinber_ has joined #openstack-nova | 12:37 | |
| *** nweinber has quit IRC | 12:40 | |
| *** ociuhandu has quit IRC | 12:41 | |
| *** jchhatbar has joined #openstack-nova | 12:47 | |
| *** jchhatbar has quit IRC | 12:48 | |
| *** jchhatbar has joined #openstack-nova | 12:48 | |
| *** janki has quit IRC | 12:50 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899 | 12:50 |
| *** _mmethot_ is now known as mmethot | 12:52 | |
| *** jchhatbar has quit IRC | 12:52 | |
| openstackgerrit | Merged openstack/nova master: Cache host to cell mapping in HostManager https://review.opendev.org/663388 | 12:55 |
| openstackgerrit | Merged openstack/nova master: Update comments in HostManager._get_instance_info https://review.opendev.org/674929 | 12:55 |
| *** jroll has quit IRC | 13:01 | |
| *** jroll has joined #openstack-nova | 13:02 | |
| *** yedongcan has left #openstack-nova | 13:03 | |
| *** beagles has joined #openstack-nova | 13:05 | |
| *** slaweq has quit IRC | 13:08 | |
| *** luksky has quit IRC | 13:08 | |
| *** janki has joined #openstack-nova | 13:09 | |
| *** efried_pto is now known as efried | 13:09 | |
| *** slaweq has joined #openstack-nova | 13:11 | |
| *** cooldharma06 has quit IRC | 13:15 | |
| *** mriedem has joined #openstack-nova | 13:18 | |
| *** frickler has quit IRC | 13:18 | |
| *** brinzhang_ has quit IRC | 13:18 | |
| *** priteau has quit IRC | 13:18 | |
| *** brinzhang_ has joined #openstack-nova | 13:18 | |
| *** priteau has joined #openstack-nova | 13:19 | |
| *** mchlumsky has joined #openstack-nova | 13:25 | |
| stephenfin | sean-k-mooney: | 13:29 |
| stephenfin | sean-k-mooney: I think we just skip them? | 13:29 |
| sean-k-mooney | ok | 13:29 |
| stephenfin | The alternative is to hardcode a mapping of vif types to traits, but maybe that's needlessly complex? | 13:29 |
| stephenfin | Or we can just add a unit test to validate things | 13:30 |
| *** udesale has joined #openstack-nova | 13:30 | |
| sean-k-mooney | well i am validating them | 13:30 |
| sean-k-mooney | just later | 13:30 |
| sean-k-mooney | when i am doing the actual update | 13:30 |
| sean-k-mooney | sorry im validating them in the filter | 13:30 |
| sean-k-mooney | not in the dirver | 13:31 |
| stephenfin | Oh, if they're already validated somewhere then it doesn't matter | 13:31 |
| sean-k-mooney | anyway ill skip them and log a warning | 13:31 |
| sean-k-mooney | i should filter them out in the driver | 13:31 |
| sean-k-mooney | but i want to cache the validation function as its not that cheap and i dont want to pay the cost on every request/update | 13:32 |
| sean-k-mooney | it would also be nice to be able to add new vif_models without needing ot update placement first | 13:32 |
| sean-k-mooney | i should still poing out however the validation only ensure that the version of placemetn install in the nova compute node thinks its valid not that the plamcent service thinks its valid | 13:33 |
| *** frickler has joined #openstack-nova | 13:34 | |
| sean-k-mooney | we really dont want to be making restcall to placemetn to validate it direclty | 13:35 |
| sean-k-mooney | that would be more expesive then the current validation | 13:35 |
| *** boxiang has quit IRC | 13:37 | |
| mriedem | lyarwood: can you hit this queens backport https://review.opendev.org/#/c/659247/ and then we can release queens | 13:38 |
| alex_xu | efried: dansmith, good morning, I updated the vpmem spec https://review.opendev.org/675024 | 13:38 |
| efried | noted | 13:39 |
| sean-k-mooney | oh disabling limit for affinity. i remember talking about that at the ptg | 13:39 |
| lyarwood | mriedem: ack done | 13:40 |
| *** mkrai has quit IRC | 13:41 | |
| sean-k-mooney | lyarwood: actully we had a customer issue related to no valid host with anti-affinity that coudl be releated too that? although have said that i dont think we set a limmit so the defualt would be 1000 and then had like 50 host so proably not | 13:42 |
| sean-k-mooney | that would be good for larger deployment in anycase. | 13:42 |
| lyarwood | sean-k-mooney: I can't recall it if we did | 13:43 |
| sean-k-mooney | dhill was handeling it but i tink we concluded they were just running out of space. | 13:43 |
| sean-k-mooney | e.g. the only host that still had enough capsaity were the host the anti afinity filter elminated | 13:44 |
| sean-k-mooney | i dont think there was actully something broken in the end. | 13:45 |
| *** ociuhandu has joined #openstack-nova | 13:50 | |
| *** mchlumsky has quit IRC | 13:52 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Multiple API cleanup changes https://review.opendev.org/666889 | 13:52 |
| *** mchlumsky has joined #openstack-nova | 13:53 | |
| *** beekneemech is now known as bnemec | 13:54 | |
| efried | stephenfin and/or johnthetubaguy, That ^ is pretty much a "rebase" if you want to reapprove. | 13:54 |
| *** KeithMnemonic has joined #openstack-nova | 13:54 | |
| *** nweinber__ has joined #openstack-nova | 13:56 | |
| *** janki has quit IRC | 13:57 | |
| *** BjoernT has joined #openstack-nova | 13:59 | |
| *** nweinber_ has quit IRC | 13:59 | |
| *** mkrai has joined #openstack-nova | 13:59 | |
| *** atmark has joined #openstack-nova | 14:00 | |
| stephenfin | efried: Sure thing | 14:00 |
| efried | thanks | 14:01 |
| *** BjoernT_ has joined #openstack-nova | 14:04 | |
| *** BjoernT has quit IRC | 14:05 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: DRY get_flavor in flavor manage tests https://review.opendev.org/668281 | 14:06 |
| *** luksky has joined #openstack-nova | 14:06 | |
| *** udesale has quit IRC | 14:06 | |
| *** udesale has joined #openstack-nova | 14:08 | |
| *** udesale has quit IRC | 14:08 | |
| *** udesale has joined #openstack-nova | 14:08 | |
| *** eharney has joined #openstack-nova | 14:15 | |
| efried | stephenfin, johnthetubaguy: If y'all are still in a reviewy mood, this series has my +2 all the way up and its runway slot expires today: https://review.opendev.org/#/q/topic:bp/placement-req-filter-forbidden-aggregates+(status:open+OR+status:merged) | 14:16 |
| efried | for whatever reason, I think it's a pretty cool feature | 14:16 |
| efried | mriedem: Wanna move cross-cell resize into the runway? | 14:17 |
| *** dpawlik has quit IRC | 14:17 | |
| mriedem | sure | 14:18 |
| openstackgerrit | Filippo Inzaghi proposed openstack/nova-specs master: Add Python 3 Train unit tests https://review.opendev.org/675908 | 14:20 |
| *** slaweq has quit IRC | 14:20 | |
| *** slaweq has joined #openstack-nova | 14:21 | |
| stephenfin | mriedem, efried: Dumb question, but the semaphore here means literally every other kind of operation (delete, (live) migrate, resize, etc.) on that instances is prevented until this eventually, returns, yeah? https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1867-L1868 | 14:21 |
| stephenfin | Assuming those operations are all wrapped with the same semaphore | 14:21 |
| mriedem | stephenfin: you can't live migrate/resize an instance that's being built | 14:22 |
| mriedem | delete yes https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2801 | 14:22 |
| stephenfin | Okay, cool. I'm trying to invent reproducers for both https://review.opendev.org/#/c/663382/ and https://review.opendev.org/#/c/667294/ | 14:23 |
| stephenfin | Something that doesn't involve Heat, that is | 14:24 |
| stephenfin | and trying to grok what could be stomping on what. Fun times :) | 14:25 |
| tssurya | efried, mriedem: whenever you have time could you circle back to https://review.opendev.org/#/c/645611/ ? I think you were mostly ok on it, but just want to confirm if there is anything more to do there before I go on vacation | 14:28 |
| tssurya | thanks in advance | 14:28 |
| *** mkrai has quit IRC | 14:35 | |
| mriedem | tssurya: i won't +2 that until the ironic side is happy, since without that there is no point in the nova changes | 14:35 |
| tssurya | mriedem: they are afaik, I will ask them to leave a comment in today's meeting | 14:36 |
| *** tbachman has joined #openstack-nova | 14:37 | |
| dansmith | mriedem: tssurya who is/are the ironic person(s) that we should look to for sign-off there? | 14:38 |
| mriedem | tssurya: also, you're going to have to rebase https://review.opendev.org/#/c/666889/ | 14:38 |
| tssurya | dansmith: dtantsur, TheJulia are the ones who have been reviewing it | 14:39 |
| dansmith | okay | 14:39 |
| tssurya | mriedem: gdi, thanks for letting me know | 14:39 |
| dansmith | hah | 14:40 |
| tssurya | that means I need to again change the version on the ironic side also | 14:40 |
| dansmith | we've ruined tssurya :) | 14:40 |
| tssurya | dansmith: tear emoji | 14:40 |
| mriedem | used to be so innocent | 14:40 |
| mriedem | https://review.opendev.org/#/q/file:%255Enova/api/openstack/compute/rest_api_version_history.rst+status:open | 14:40 |
| dansmith | tssurya: I meant ruined because we've got you swearing when api versions change :P | 14:40 |
| tssurya | dansmith: true that | 14:41 |
| dansmith | tssurya: I say rebase that one on the cleanup to fix the version, and the ironic side, and let's push to get the acks in place so we can try to get it landed before it happens again | 14:41 |
| tssurya | my office mate thinks I am swearing at him | 14:41 |
| dansmith | heh | 14:41 |
| tssurya | dansmith: ack, on it | 14:41 |
| *** mlavalle has joined #openstack-nova | 14:41 | |
| TheJulia | tssurya: will order of merging matter? Trying to figure out if I should try and get more eyes on the ironic side this week | 14:45 |
| tssurya | nova one has to land first technically, but they just want to know if the ironic client side change looks good | 14:46 |
| tssurya | TheJulia: more eyes this week would be great | 14:47 |
| dansmith | what tssurya said | 14:47 |
| TheJulia | tssurya: ack | 14:47 |
| *** aojeagarcia has quit IRC | 14:50 | |
| efried | tssurya: Do you have someone to take over for you if changes are needed while you're sipping mai tais on the beach? | 14:50 |
| *** ash2307 has joined #openstack-nova | 14:51 | |
| *** ash2307 has left #openstack-nova | 14:52 | |
| *** belmoreira has joined #openstack-nova | 14:53 | |
| *** nweinber_ has joined #openstack-nova | 14:54 | |
| *** nweinber__ has quit IRC | 14:57 | |
| cdent | mriedem, dansmith : What do you imagine the consequences of moving the get_by_host_node in _update_available_resource out from under the COMPUTE_RESOURCE_SEMAPHORE would be? https://github.com/openstack/nova/blob/52b9359d6c6f387b8b9728c723c9a2501136d605/nova/compute/resource_tracker.py#L744 | 14:58 |
| cdent | on a host with many insgtn | 14:58 |
| cdent | oopes | 14:58 |
| cdent | oh a host with many instances, that lock blocks new instance creation | 14:58 |
| cdent | and a large portion of the time under the lock is spent in get_by_host_and_node assuming the is_bfv cache is hot (if it's cold it is _all_ there) | 15:00 |
| sean-k-mooney | cdent: you might be able to optimise it without fully removing the lock. e.g. caulate the usage for each instance without the lock and keep track of the instace checked. aquire the lock and check that all instace check are still present and no others have been added then update the usage and release the lock. | 15:01 |
| sean-k-mooney | if an instance has been added or removed then you can just make that update under the lock. | 15:01 |
| mriedem | cdent: the consequence could be a race where we don't report usage or claim properly because the underlying resource usage changed since we got the lock | 15:02 |
| cdent | mriedem: are you certain? I'm not saying remove the lock. I'm saying not use the lock while getting the list of instances used by _update_available_resources | 15:03 |
| mriedem | i know what you're asking | 15:03 |
| cdent | lock _after_ getting the list | 15:03 |
| mriedem | you're saying move the get here https://github.com/openstack/nova/blob/52b9359d6c6f387b8b9728c723c9a2501136d605/nova/compute/resource_tracker.py#L710 | 15:03 |
| mriedem | and pass the instances into _update_available_resource | 15:04 |
| mriedem | sean-k-mooney: how would you know if an instance has been added or removed? | 15:04 |
| mriedem | between the time you got the list and got the lock? | 15:04 |
| mriedem | cdent: presumably you could have: | 15:05 |
| sean-k-mooney | you would have to key two list of instances. one that you got outside the lock and then inside it you would get the list again | 15:05 |
| sean-k-mooney | you can then caulated teh added and removed instances | 15:05 |
| mriedem | t0: thread 1 is getting the list of instances on the host, t1: thread 2 gets the lock and is adding a new instance claim to the host which won't be in the list returned in thread 1, t2: thread 1 gets the lock with a list of instances that doesn't include the one from thread2 | 15:05 |
| mriedem | sean-k-mooney: getting hte list again within the lock defeats the purpose of what cdent is trying to do | 15:06 |
| sean-k-mooney | if the list are the same the pending updats shoudl be correct if not you either need to recaulate it entirely or comute the delta | 15:06 |
| mriedem | which is reduce the amount of time spent *within* the lock | 15:06 |
| cdent | yes, that is the goal | 15:06 |
| mriedem | b/c vcenter has 1000+ instances on the same compute service host / RT | 15:06 |
| mriedem | so getting 1000+ instances for every instance operation on the same host is blocked by this big lock | 15:06 |
| sean-k-mooney | getting the list shouldnt be the moest expensive part though right its caulating the useage? | 15:06 |
| mriedem | it's 1000+ instances + several joins to other tables | 15:07 |
| sean-k-mooney | e.g. https://github.com/openstack/nova/blob/52b9359d6c6f387b8b9728c723c9a2501136d605/nova/compute/resource_tracker.py#L751-L752 | 15:07 |
| mriedem | over rpc as well.... | 15:07 |
| mriedem | cdent: i'm curious, what does vio set for rpc_response_timeout? | 15:07 |
| mriedem | considering something like this has to pull 1K instances from the db over rpc | 15:07 |
| cdent | getting the instances is by far the most expensive chunk of _update_avail when you have many instances | 15:07 |
| mriedem | reminds me of this https://review.opendev.org/#/c/633042/ | 15:08 |
| cdent | mriedem: something relatively high, but it's not _that_ slow as to cause a problem, rather that the lock can be around for a long time | 15:08 |
| sean-k-mooney | mriedem: 1000+ on vmware because its clustering multiple server under one compute service | 15:08 |
| mriedem | sean-k-mooney: yes | 15:08 |
| mriedem | cdent: but over the default 60 seconds? | 15:08 |
| *** ociuhandu has quit IRC | 15:08 | |
| sean-k-mooney | cdent: ok that is surprising to me but if that is the most expesnive part then yes my suggestion wont help | 15:09 |
| cdent | mriedem: I don't have the details to hand, but yes | 15:09 |
| mriedem | cdent: you could potentially detect if you lost a race if there is something in self.tracked_instances that isn't in the list of instances you just pulled from the db | 15:09 |
| cdent | sean-k-mooney: it depends on whether you are doing the loop the first time or subsequence times. 1st time is_bfv is the expensive part | 15:09 |
| *** ociuhandu has joined #openstack-nova | 15:10 | |
| sean-k-mooney | i had expected self._update_usage_from_instances ot be more costly | 15:10 |
| cdent | sean-k-mooney: yes, when bfv cache is cold, not but not otherwise | 15:10 |
| mriedem | cdent: i'm assuming is_bfv is expensive since it has to make the is_volume_backed call which needs to get the bdms | 15:10 |
| cdent | mriedem: yes | 15:10 |
| cdent | and 1000 of those adds up | 15:10 |
| mriedem | yeah...there is a change floating around where i asked someone if they could put a sqla joined field on the instances model to detect in a join query if an instance is volume-backed so we could optimize that | 15:11 |
| mriedem | sec | 15:11 |
| mriedem | the logic is pretty simple i think - is there a boot_index=0 bdm with destination_type=volume for this instance | 15:11 |
| mriedem | if so, it's bfv | 15:11 |
| cdent | once the cache is hot, it disappears as a problem which suggests that a similar instance cache would have similar properties... | 15:12 |
| cdent | but managing such a cache is...tricky | 15:12 |
| mriedem | well, my point is, | 15:12 |
| cdent | but is exactly what I would think a "resource tracker" would do... | 15:12 |
| mriedem | rather than (1) big InstanceList.get and then (2) big is_bfv cache build, if we could get the is_bfv value per instance in (1) then we avoid (2) | 15:12 |
| mriedem | https://review.opendev.org/#/c/612626/10/nova/db/sqlalchemy/api.py | 15:13 |
| cdent | sure, but that only helps on the first trip, right? | 15:13 |
| efried | tssurya: I left a handful of comments as well | 15:14 |
| cdent | btw: have you seen my comments about how the eventlet profiler gets all chundered up when RPC is in play? | 15:14 |
| mriedem | no | 15:14 |
| efried | cdent: just commented on that, I don't think n-cpu is supposed to talk to the db. | 15:14 |
| cdent | turning off the indirection_api fixes it | 15:14 |
| cdent | efried: only for hypervisor isolation, which is not a problem for vsphere... | 15:15 |
| * efried crawls back into ignorant hole | 15:15 | |
| mriedem | cdent: efried: it's not just isolation, it's also to support rolling upgrades | 15:15 |
| cdent | and for profiling/testing is not an issue | 15:15 |
| *** ociuhandu has quit IRC | 15:15 | |
| cdent | which vsphere doesn't do either :) | 15:15 |
| mriedem | temporarily disabling for profilng is one thing | 15:15 |
| *** tbachman has quit IRC | 15:15 | |
| cdent | yeah, I wouldn't suggest there being some kind of config setting for it | 15:16 |
| mriedem | we need a mogan for nova+ironic and a vogan for nova+vmware | 15:16 |
| mriedem | and nova can then just be kvm like it already is | 15:16 |
| cdent | i actually think that's probalby a good idea, sadly | 15:16 |
| cdent | trying to be all things to many things is terrible | 15:16 |
| mriedem | cdent: anyway, i'd probably investigate trying to detect races by comparing the instances you get from the db to the set of tracked_instances in the rt after you get the lock | 15:17 |
| mriedem | and determine if you need to adjust your 'instances' like which might just be re-getting it | 15:17 |
| mriedem | and then, like run rally against that to see if you can break it? idk. | 15:17 |
| cdent | I'm still unclear on where a lost race experiences a problem. what breaks | 15:17 |
| mriedem | claims related stuff, which at this point is numa/pci i think, | 15:18 |
| sean-k-mooney | i think it woudl only be an issue for resouce that are not tracked in placmenet | 15:18 |
| mriedem | since we just removed the cpu/ram/disk claims | 15:18 |
| *** tssurya has quit IRC | 15:18 | |
| mriedem | tracked_migrations could also be wonky but on a smaller scale / tighter race | 15:20 |
| *** ociuhandu has joined #openstack-nova | 15:20 | |
| * mriedem is fixing a bug in the RT as we speak | 15:20 | |
| cdent | go RT | 15:20 |
| *** dave-mccowan has joined #openstack-nova | 15:20 | |
| sean-k-mooney | well anythin relying on the perodic task to fix up allocation could be off but it should get fixed on the next run | 15:21 |
| *** tssurya has joined #openstack-nova | 15:21 | |
| sean-k-mooney | missing frees is not that concuerning but missing claims would be | 15:21 |
| cdent | sean-k-mooney: yeah, which ought to be fine | 15:21 |
| mriedem | sean-k-mooney: the periodic doesn't fix up allocations... | 15:21 |
| mriedem | not since ocata/pike anyway | 15:21 |
| sean-k-mooney | out side of the migration ones? i though it healed allcoation for instace once the migration was conrimed | 15:22 |
| mriedem | the rt does not do that | 15:23 |
| cdent | sure it does: it spends lots of time in here: https://github.com/openstack/nova/blob/52b9359d6c6f387b8b9728c723c9a2501136d605/nova/compute/resource_tracker.py#L1314 | 15:23 |
| mriedem | the compute manager explicitly does stuff with migration-based allocations | 15:23 |
| cdent | orphans | 15:23 |
| cdent | ever single allocation for instance.uuid is compared to each instance on the host | 15:23 |
| mriedem | cdent: that's about it since all of the other allocation "healing" code was removed | 15:23 |
| cdent | that chunk can get really loud becuase of https://github.com/openstack/nova/blob/52b9359d6c6f387b8b9728c723c9a2501136d605/nova/compute/resource_tracker.py#L1340 | 15:24 |
| cdent | commenting out that line can save a bunch of log noise | 15:24 |
| *** tbachman has joined #openstack-nova | 15:24 | |
| mriedem | debug("things are working normally") | 15:24 |
| cdent | and 1372 there is one last remove | 15:24 |
| sean-k-mooney | mriedem: i dont know im suspios that we normally would print that :P | 15:25 |
| *** luksky has quit IRC | 15:26 | |
| sean-k-mooney | but yes that does not really add much value | 15:26 |
| cdent | if you both agree, I can put up a patch to remove it? | 15:26 |
| cdent | meanwhile, I will create 1000 fake instances again | 15:26 |
| mriedem | there used to be an audit level which is lower than debug, i'm not sure i'm totally in favor of removing it, | 15:27 |
| mriedem | as the comment at the top says, | 15:27 |
| mriedem | # NOTE(jaypipes): All of this code sucks. | 15:27 |
| mriedem | but when i'm debugging rt issues, the more logging i have the better | 15:27 |
| cdent | true | 15:27 |
| mriedem | i frequently have to add logging to the rt when i'm debugging functional test fialures that involve it (like i was on friday for at least 2 hours) | 15:27 |
| cdent | me too | 15:27 |
| cdent | i have at least 6 additional LOG.debug in there right now | 15:28 |
| sean-k-mooney | ya that is fair | 15:28 |
| mriedem | https://review.opendev.org/#/c/366422/ | 15:28 |
| sean-k-mooney | we do have a way to filter out log messages via config too right | 15:28 |
| *** slaweq has quit IRC | 15:28 | |
| mriedem | i said AUDIT but i was thinking TRACE | 15:28 |
| redkrieg | lyarwood: Are you around by chance? I found your blueprint for stable disk devices in rescue mode and it's exactly what I need to offer my customers reliable ISO support. Just wanted to know what the status is and whether there's anything I can work on related to it to get it in a release in the future: https://blueprints.launchpad.net/nova/+spec/virt-rescue-stable-disk-devices | 15:29 |
| *** slaweq has joined #openstack-nova | 15:30 | |
| sean-k-mooney | just based on the ordering in the gate logs http://logs.openstack.org/38/671338/5/check/tempest-full-py3/12e1ea1/controller/logs/screen-n-cpu.txt.gz | 15:30 |
| sean-k-mooney | i would have guess audit and trace were both higher then info/debug | 15:31 |
| mriedem | i don't know how to filter specific messages from logging config | 15:31 |
| sean-k-mooney | i think we can do it at the module level but i dont know if we can do it at the function level. we cant do it on indigiual message via config so it proably too course for this usecase | 15:32 |
| sean-k-mooney | i.e. we dont want to jsut make the RT be info and everything else debug | 15:32 |
| sean-k-mooney | i guess that message does serve a use in confiming which branch is taken | 15:33 |
| sean-k-mooney | but for ops that run at debug level in production its proably noisier then they would like | 15:34 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Avoid timeout from service update notification tests https://review.opendev.org/675935 | 15:36 |
| mriedem | low-hanging-fruit test-only bug https://bugs.launchpad.net/nova/+bug/1839853 | 15:40 |
| openstack | Launchpad bug 1839853 in OpenStack Compute (nova) "Misuse of nova.objects.base.obj_equal_prims in tests" [Medium,Confirmed] | 15:40 |
| openstackgerrit | Jing Zhang proposed openstack/nova master: Remove the current host from cold migration target host list https://review.opendev.org/675025 | 15:41 |
| *** belmoreira has quit IRC | 15:44 | |
| *** priteau has quit IRC | 15:45 | |
| *** mkrai has joined #openstack-nova | 15:48 | |
| *** factor has joined #openstack-nova | 15:48 | |
| *** tbachman has quit IRC | 15:49 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Avoid timeout from service update notification tests https://review.opendev.org/675935 | 15:51 |
| *** helenafm has quit IRC | 15:53 | |
| *** gyee has joined #openstack-nova | 15:54 | |
| *** tbachman has joined #openstack-nova | 15:54 | |
| *** udesale has quit IRC | 15:56 | |
| *** damien_r has quit IRC | 15:56 | |
| *** dave-mccowan has quit IRC | 15:56 | |
| mriedem | cdent: up your vmware alley https://review.opendev.org/#/c/675025/2 | 15:56 |
| cdent | sounds a bit rude, that | 15:56 |
| mriedem | ha | 15:57 |
| mriedem | dansmith: efried: melwitt: what do you think about the [workarounds]/allow_cold_migrate_to_same_host idea in https://review.opendev.org/#/c/675025/ as a backportable thing until we can be smarter about scheduling for cold migrate based on compute capabilities / traits filtering? | 15:58 |
| *** dtruong has quit IRC | 15:59 | |
| *** dtruong has joined #openstack-nova | 16:00 | |
| dansmith | mriedem: meaning different behavior for cold migrate vs. resize? | 16:00 |
| mriedem | yeah | 16:01 |
| mriedem | the existing option conflates them which is bad for everything except vmware | 16:01 |
| dansmith | the intent of cold migration is always to land it on a different host, so I guess I'm not sure why the patch is wrong (in intent, I haven't looked at the reasoning) | 16:01 |
| mriedem | that's true for everything except vcenter | 16:02 |
| dansmith | okay so the workaround config knob would only need tweaking for vmware? | 16:02 |
| cdent | yet another raeson for vogan | 16:02 |
| mriedem | dansmith: yeah | 16:02 |
| melwitt | I'm not opposed to the patch but isn't this a super latent thing or? surprised this hasn't come up before | 16:02 |
| mriedem | and is a backportable thing until we can be smarter about filtering based on traits | 16:02 |
| mriedem | melwitt: it is, | 16:03 |
| mriedem | there are a bunch of related bugs | 16:03 |
| dansmith | mriedem: and that workaround would be read/honored in api or conductor when assembling the request to scheduler/ | 16:03 |
| mriedem | we just never do anything about fixing it :) | 16:03 |
| melwitt | heh, wow | 16:03 |
| mriedem | dansmith: api | 16:03 |
| mriedem | dansmith: same place that allow_resize_to_same_host is read | 16:03 |
| dansmith | yeah | 16:03 |
| dansmith | for some reason I feel like workarounds are usually per-host and thus read by the compute | 16:04 |
| dansmith | and further, | 16:04 |
| dansmith | if you have one vmware compute and a bunch of libvirt computes, you likely don't want that to be a global policy | 16:04 |
| mriedem | sure, but we already do, | 16:04 |
| dansmith | for resize you mean | 16:04 |
| mriedem | and that's why i think long-term we replace the workaround option with traits-based compute capability filtering, | 16:04 |
| mriedem | yes, but we treat reaize == cold migrate in the api from this regard | 16:05 |
| dansmith | sure, but the stated goal of allowing resize to same host makes more sense as a global I think | 16:05 |
| dansmith | but anyway, what I'm saying is: | 16:05 |
| dansmith | maybe the knob should be read by compute and factor in to what traits it exposes and then let the control side throw some required or forbidden trait in there | 16:06 |
| mriedem | you can't backport that | 16:06 |
| dansmith | sure | 16:06 |
| mriedem | but yes, that's what i'm saying we do with https://review.opendev.org/#/c/666604/ | 16:06 |
| mriedem | compute exposes a trait for if it can do a thing, api reads that and configures the request spec for scheduler filtering appropriately, | 16:06 |
| dansmith | but if we add it as honored by control, then backport that, then we kinda need deprecation or a dance to move to the per-compute way | 16:06 |
| mriedem | which replaces the workaround thing i'm suggesting for backports | 16:06 |
| mriedem | correct | 16:07 |
| mriedem | workaround option -> backports -> eventual deprecation with the new thing https://review.opendev.org/#/c/666604/ | 16:07 |
| dansmith | right, so point is, since this is latent since the beginning of time, I don't care so much about the backport | 16:07 |
| dansmith | but if it's super important to you then, I guess whatever | 16:07 |
| mriedem | it's not super important to me, it's just i've dealt with it more than once and it continues to come up as a bug for *us* | 16:08 |
| mriedem | my fear is the longer we don't do something, the more hack patches like this show up | 16:08 |
| dansmith | ack | 16:08 |
| sean-k-mooney | mriedem: speaking about https://review.opendev.org/#/c/666604/? | 16:09 |
| mriedem | related yes | 16:10 |
| mriedem | prompted by https://review.opendev.org/#/c/675025/ | 16:10 |
| sean-k-mooney | we spoke about it a bit on irc and understand the motivaition more now | 16:10 |
| mriedem | the royal we? | 16:10 |
| sean-k-mooney | as in i pinging you about it last week | 16:10 |
| sean-k-mooney | or the week before | 16:10 |
| sean-k-mooney | and you explained what it was for | 16:10 |
| sean-k-mooney | it is not a trait i would expect to see in a flavor or image | 16:11 |
| sean-k-mooney | but i can see how it could be useful in this specific case | 16:11 |
| melwitt | I'm ok with the wokraround conceptually, I'm not sure why we didn't just do that years ago. I'm assuming it's a really simple change to consider resize different than cold migrate for "allow same host" | 16:12 |
| mriedem | sean-k-mooney: nor are several of our compute-capability based traits | 16:12 |
| mriedem | melwitt: yeah i think it would be a small change | 16:13 |
| mriedem | if allow_resize_to_same_host: | 16:13 |
| mriedem | if cold_migrate and allow_cold_migrate_to_same_host: | 16:13 |
| sean-k-mooney | a workaround config option has the benifit that it could be backported were as the trait could not | 16:13 |
| mriedem | dude | 16:13 |
| melwitt | lol | 16:13 |
| sean-k-mooney | i know dansmith just said he does not care | 16:14 |
| sean-k-mooney | and ye just finished that conversation | 16:14 |
| sean-k-mooney | but it is a minor pluse to the workaround still for me | 16:14 |
| sean-k-mooney | *workaround conf | 16:15 |
| melwitt | the reason I ask is because I wouldn't support a workaround like this for a super latent thing if it's a big complicated change. but if it's a tiny one liner and would solve a lot of pain for people, then it seems like a worthwhile thing to do | 16:15 |
| *** rpittau is now known as rpittau|afk | 16:15 | |
| melwitt | my concern would be more like, do we really expect to deprecate it from [workarounds] or not | 16:16 |
| dansmith | I don't think it's a lot of people, and I just want to avoid the deprecation dance, effectively introducing something as deprecated | 16:16 |
| dansmith | but yes, it's small and the deprecation is the major impact, so whatever | 16:16 |
| *** mkrai has quit IRC | 16:16 | |
| dansmith | melwitt: I assume we'd land it, and deprecate it in the next patch, then just backport the first one | 16:17 |
| melwitt | oh, right, I see | 16:17 |
| mriedem | yes that would be what i'd do | 16:17 |
| sean-k-mooney | dansmith: that depend on the long term fix no? e.g. if we make it work transparently in the fureure then the deprecation/removal should not break people | 16:18 |
| dansmith | sean-k-mooney: we can't | 16:18 |
| dansmith | sean-k-mooney: we're talking about moving what honors the thing from global/scheduler to local/compute | 16:18 |
| dansmith | didn't we already discuss that part? | 16:18 |
| sean-k-mooney | oh i missed that part of the discussion. ill go back to fixing my typos :) | 16:19 |
| sean-k-mooney | i had assumed the workaround option would be set globally | 16:20 |
| melwitt | if the trait thing is simple and we're sure we're going to land it this cycle, then deprecate immediately "works". immediate deprecation is definitely a weird thing to do having left it latent for so long, but if it's such a minor tiny change, I'm not opposed about it | 16:21 |
| melwitt | *backport + immediate deprecation | 16:22 |
| sean-k-mooney | it would not be the first workaound option that has been in that state | 16:22 |
| sean-k-mooney | e.g the numa migration one was intended to be intoduced backported and deprecated all in one cycle | 16:23 |
| openstackgerrit | Merged openstack/nova stable/queens: Disable limit if affinity(anti)/same(different)host is requested https://review.opendev.org/659247 | 16:24 |
| sean-k-mooney | we even change default behavior with that backport | 16:24 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: rt: only map compute node if we created it https://review.opendev.org/675704 | 16:29 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression recreate test for bug 1839560 https://review.opendev.org/675705 | 16:29 |
| openstack | bug 1839560 in OpenStack Compute (nova) "ironic: moving node to maintenance makes it unusable afterwards" [High,In progress] https://launchpad.net/bugs/1839560 - Assigned to Matt Riedemann (mriedem) | 16:29 |
| sean-k-mooney | if we treated the new can_cold_migrate_to_same_node workaround option the same way as enable_numa_live_migration is there a reason we cant just set this gloably the scheduler? | 16:30 |
| sean-k-mooney | i know that would not be desirebal for mix hyperviors | 16:30 |
| sean-k-mooney | but its simplifies thing greatly | 16:31 |
| dansmith | sean-k-mooney: could you read the backscroll please? | 16:31 |
| dansmith | we've already discussed that too | 16:31 |
| dansmith | or even the comments on the patch | 16:31 |
| sean-k-mooney | ok im just confused why we would treat this differently then enable_numa_live_migration which is effectivly the same | 16:31 |
| sean-k-mooney | ill read both | 16:32 |
| dansmith | it probably should be the same, I haven't really seen anything about that knob myself | 16:32 |
| *** Sundar has joined #openstack-nova | 16:33 | |
| *** dklyle_ is now known as dklyle | 16:34 | |
| sean-k-mooney | enable_numa_live_migration is used in the api i think and reject any live migration if the instnace has a numa toplogy when set to false which we made the defaul. | 16:35 |
| sean-k-mooney | the reasoning being while it was a behavior change teh people that understand how to deploy numa toployg are the people that modify thing in the config anyway and we whould not let most people break things by migaint with out understandint its broken with numa | 16:36 |
| sean-k-mooney | we may have done the check late in teh scheduler in teh enable_numa_live_migration case but i cant see why we would not have done it in the api | 16:37 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Unplug VIFs as part of cleanup of networks https://review.opendev.org/663382 | 16:37 |
| *** mjozefcz has quit IRC | 16:40 | |
| Sundar | Hi dansmith: Thanks for your reviews. For https://review.opendev.org/#/c/631243/30/nova/objects/flavor.py@230, I am trying to understand the alternative you recommend. "Let the versioned fields be properties" --> extra_specs is just a DictOfStrings, so how do you propose to change that to include a devic eprofile name explicitly? | 16:40 |
| mriedem | sean-k-mooney: it's not in the api, it's in conductor, | 16:41 |
| mriedem | and it's after we've picked a host to check if it's qemu | 16:41 |
| mriedem | the allow resize to same host option is read in the api before calling the scheduler | 16:41 |
| sean-k-mooney | mriedem: oh yep your right | 16:42 |
| mriedem | efried: https://review.opendev.org/#/c/675935/ | 16:43 |
| mriedem | easy test fix to make func job runs go faster | 16:43 |
| efried | mriedem, gibi: Left a comment in there. If you disagree, I'll +W | 16:46 |
| dansmith | Sundar: just access the extra specs whenever you're going to look at the device profile | 16:48 |
| dansmith | Sundar: i.e. code should be: flavor.extra_specs['device_profile'] ... instead of flavor.device_profile | 16:48 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: API microversion 2.76: Add 'power-update' external event https://review.opendev.org/645611 | 16:54 |
| dansmith | tssurya: found something I think is a problem that wasn't obvious until your clean-up | 16:58 |
| *** tbachman has quit IRC | 16:58 | |
| dansmith | tssurya: let me know if I'm missing something there | 16:59 |
| tssurya | dansmith: checking | 16:59 |
| *** derekh has quit IRC | 17:01 | |
| mriedem | efried: i'm ok either way | 17:01 |
| efried | mriedem, gibi: I just don't like lambda *a, **k: None if we don't need it. | 17:01 |
| mriedem | efried: if you want to change i'll test it and approve | 17:01 |
| efried | ... | 17:01 |
| efried | mriedem: f it, would need to import (the real) fixtures. +W | 17:03 |
| mriedem | heh | 17:03 |
| tssurya | dansmith: replied, hope I am not messing something up | 17:04 |
| *** shilpasd has quit IRC | 17:08 | |
| *** ociuhandu_ has joined #openstack-nova | 17:09 | |
| dansmith | tssurya: ah, I was confused, yeah, but in your comment you mean avoid L4768 not 4770 right? | 17:10 |
| dansmith | you're trying to avoid queuing this event because it's a no-op? | 17:10 |
| tssurya | dansmith: right sorry I am trying to avoid L4768 | 17:10 |
| tssurya | dansmith: yes I don't want the event to go down to the manager | 17:11 |
| dansmith | so I was going to say this earlier, but I'm not really sure why we need to do the (almost) silent drop of those in the api | 17:11 |
| tssurya | I am being strict with the task/vm/power states of the vm | 17:11 |
| dansmith | because it seems like the manager/driver would know better about whether or not that is still important | 17:11 |
| dansmith | but, the thing I -1d for is wrong, so I'll drop that | 17:11 |
| tssurya | I understand your point, but since I sort of copied the start/stop logic in the api, | 17:12 |
| tssurya | it would blow up here: https://review.opendev.org/#/c/645611/11/nova/compute/api.py@4705 | 17:12 |
| tssurya | when I save the instance since the expected state is None and so on | 17:12 |
| tssurya | its mostly because when I was testing if there is a power sync/receving of event almost close to each it could mess up things | 17:13 |
| *** ociuhandu has quit IRC | 17:13 | |
| tssurya | mostly a fail safe that I did in the beginning itself | 17:13 |
| *** ociuhandu_ has quit IRC | 17:14 | |
| dansmith | tssurya: ah, okay that's fair | 17:16 |
| dansmith | tssurya: I'll let mriedem lead with a +2 on the api stuff and versioning bits but otherwise I think I'm good with it | 17:20 |
| tssurya | dansmith: thank you :D ! yea let's wait for the CI to run | 17:21 |
| *** nweinber__ has joined #openstack-nova | 17:21 | |
| *** BjoernT_ is now known as BjoernT | 17:23 | |
| *** nweinber_ has quit IRC | 17:24 | |
| *** tbachman has joined #openstack-nova | 17:26 | |
| *** ivve has quit IRC | 17:27 | |
| *** ociuhandu has joined #openstack-nova | 17:28 | |
| *** nweinber_ has joined #openstack-nova | 17:32 | |
| *** ociuhandu has quit IRC | 17:32 | |
| *** nweinber__ has quit IRC | 17:35 | |
| *** whoami-rajat has quit IRC | 17:38 | |
| *** tssurya has quit IRC | 17:42 | |
| *** ircuser-1 has joined #openstack-nova | 17:43 | |
| *** cdent has quit IRC | 17:49 | |
| *** rouk has joined #openstack-nova | 17:53 | |
| *** atmark has quit IRC | 17:59 | |
| *** atmark has joined #openstack-nova | 18:00 | |
| *** ociuhandu has joined #openstack-nova | 18:04 | |
| *** luksky has joined #openstack-nova | 18:12 | |
| *** markvoelker has quit IRC | 18:13 | |
| *** mjozefcz has joined #openstack-nova | 18:19 | |
| *** markvoelker has joined #openstack-nova | 18:20 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: add support for vPMU configuration. https://review.opendev.org/671338 | 18:20 |
| sean-k-mooney | gibi: stephenfin mriedem i think i have adress most of the comments | 18:20 |
| mriedem | ok | 18:34 |
| *** dpawlik has joined #openstack-nova | 18:36 | |
| *** markvoelker has quit IRC | 18:39 | |
| *** markvoelker has joined #openstack-nova | 18:40 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Restore soft-deleted compute node with same uuid https://review.opendev.org/675496 | 18:41 |
| mriedem | mnaser: ^ | 18:43 |
| mnaser | mriedem: seems very sane | 18:46 |
| openstackgerrit | sean mooney proposed openstack/nova master: WIP: Add a placement audit command https://review.opendev.org/670112 | 18:53 |
| *** ociuhandu has quit IRC | 18:54 | |
| sean-k-mooney | cdent i think i have adressed your comments on ^ but im not fully sure what sylvain was trying to do so ill take a look again tomorow after i read the bug | 18:55 |
| *** ociuhandu has joined #openstack-nova | 18:55 | |
| *** ivve has joined #openstack-nova | 18:58 | |
| *** ociuhandu has quit IRC | 19:00 | |
| *** bbowen has quit IRC | 19:12 | |
| *** ociuhandu has joined #openstack-nova | 19:12 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Add useful error log when _determine_version_cap raises DBNotAllowed https://review.opendev.org/675714 | 19:12 |
| *** eharney has quit IRC | 19:14 | |
| *** factor has quit IRC | 19:17 | |
| *** abaindur has joined #openstack-nova | 19:21 | |
| *** ociuhandu has quit IRC | 19:25 | |
| *** ociuhandu has joined #openstack-nova | 19:26 | |
| *** igordc has joined #openstack-nova | 19:26 | |
| *** Sundar has quit IRC | 19:30 | |
| *** ociuhandu has quit IRC | 19:32 | |
| *** tesseract has quit IRC | 19:32 | |
| *** psachin has quit IRC | 19:37 | |
| *** igordc has quit IRC | 19:41 | |
| *** mjozefcz has quit IRC | 19:51 | |
| *** dave-mccowan has joined #openstack-nova | 19:54 | |
| mriedem | dansmith: melwitt: just had another thought on this allow cold-migrate to same host thing, which wouldn't involve a workaround and soon-to-be-deprecated config option, | 19:54 |
| mriedem | if allow_resize_to_same_host=true, get the compute node for the instance and check it's hypervisor type, if it's anything besides vcenter we don't allow it | 19:55 |
| mriedem | that would be a hack fix for any in-tree drivers and could be replaced with the more dynamic traits filtering later | 19:55 |
| mriedem | don't allow cold migration to the same host that is | 19:56 |
| mriedem | maybe that's *too* hacky | 19:58 |
| dansmith | that check in the api seems like a high crime | 19:58 |
| mriedem | impeachable? | 20:00 |
| dansmith | automatic impeachment | 20:00 |
| dansmith | and subsequent special counsel investigation | 20:00 |
| mriedem | heh | 20:00 |
| dansmith | all your dirty laundry will be aired | 20:01 |
| mriedem | bnemec: for a BoolOpt, is it possible to leave it unset so you can set the default at runtime somehow, e.g. it's based on another options value? | 20:01 |
| *** eharney has joined #openstack-nova | 20:01 | |
| bnemec | mriedem: It is. I believe the default for BoolOpt is actually None, which implies that it was unset since that's not a valid boolean value. | 20:02 |
| bnemec | Which I actually think is a bug (https://bugs.launchpad.net/oslo.config/+bug/1764782) but as Doug points out there's no way to know if people have been relying on that behavior. | 20:02 |
| openstack | Launchpad bug 1764782 in oslo.config "BoolOpt defaults to None" [Medium,Triaged] | 20:02 |
| mriedem | ah i see, looks like boolean type opts are really str opt under the covers and they get cast to booleans | 20:03 |
| mriedem | something like strutils.bool_from_string | 20:03 |
| mriedem | ok in my case i want to add a new option but have it's default be backward compatible to whatever is set for another option | 20:04 |
| mriedem | unless you explicitly override it | 20:04 |
| *** ccamacho has quit IRC | 20:05 | |
| bnemec | I guess I should note that the more "correct" way to do this is to use get_location: https://docs.openstack.org/oslo.config/latest/reference/api/oslo_config.html#oslo_config.cfg.ConfigOpts.get_location | 20:06 |
| bnemec | That will tell you if a user set the option or not in an unambiguous way. | 20:06 |
| bnemec | Or maybe even better, use set_default and set the new opt's default to the value of the old opt: https://docs.openstack.org/oslo.config/latest/reference/api/oslo_config.html#oslo_config.cfg.ConfigOpts.set_default | 20:08 |
| mriedem | the get_location stuff is relatively new right? | 20:10 |
| mriedem | like, newer than ocata? | 20:10 |
| *** igordc has joined #openstack-nova | 20:11 | |
| mriedem | yeah rocky https://review.opendev.org/#/c/537397/ | 20:13 |
| mriedem | i don't plan on backporting this nova workaround too far, but it is super latent (much older than ocata anyway) | 20:13 |
| bnemec | Yeah, although set_default has been around forever and is probably the right thing to do here conceptually. | 20:21 |
| bnemec | You're setting a default for an opt based on a thing calculated in code (in this case from the value of another opt) but want the user to be able to override it if they set the opt explicitly. | 20:22 |
| mriedem | where would i call set_default? where i'm using the new option? | 20:23 |
| bnemec | Sometime between when you register the old opt and when you use the new one. | 20:23 |
| mriedem | iow it's like dict.set_default | 20:23 |
| mriedem | *setdefault | 20:23 |
| bnemec | Something like that, but you just call it once and the config object remembers that you overrode the default for that opt. | 20:25 |
| bnemec | I guess dict inserts the key with the default so that is actually the same. | 20:26 |
| mriedem | this is what i've got right now http://paste.openstack.org/show/756357/ | 20:26 |
| *** nweinber_ has quit IRC | 20:27 | |
| *** tbachman has quit IRC | 20:27 | |
| mriedem | this is probably better to avoid calling set_default when i don't need to | 20:28 |
| mriedem | http://paste.openstack.org/show/756358/ | 20:28 |
| mriedem | otherwise i have to do this somewhere in wsgi init after parsing options and starting the service | 20:28 |
| mriedem | which takes it quite far away from where it's used, which is ok but kind of hard to remember all of this | 20:29 |
| bnemec | Heh, if you're still checking for None then I'm not sure you gain much from using set_default. | 20:29 |
| bnemec | But either should work. | 20:29 |
| *** bbowen has joined #openstack-nova | 20:31 | |
| mriedem | yeah true :/ | 20:33 |
| bnemec | It's probably not worth satisfying my pet peeve about the BoolOpt default by moving the setdefault call to some weird location though. | 20:35 |
| *** efried has quit IRC | 20:39 | |
| sean-k-mooney | dict not only set the defult i return the value in the dict. so if it was already set it returns the value that was found in the dict and if not it returns you default after setting it in the dict | 20:39 |
| sean-k-mooney | you can discard the return if you dont care but its a nice behavior to have | 20:40 |
| *** efried has joined #openstack-nova | 20:40 | |
| sean-k-mooney | so if we had a CONF.set_default it would be nice to keep it the same | 20:40 |
| sean-k-mooney | that would change your example to http://paste.openstack.org/show/756359/ | 20:41 |
| *** dpawlik has quit IRC | 20:42 | |
| sean-k-mooney | its a minor change but its basicly free to return the value and it makes the useage terser | 20:43 |
| *** artom has quit IRC | 20:46 | |
| *** pcaruana has quit IRC | 20:56 | |
| *** gryf has quit IRC | 20:58 | |
| *** xek has quit IRC | 21:02 | |
| *** mjozefcz has joined #openstack-nova | 21:02 | |
| *** mjozefcz has quit IRC | 21:11 | |
| *** markvoelker has quit IRC | 21:24 | |
| *** tbachman has joined #openstack-nova | 21:25 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Allow disabling cold migration to the same host https://review.opendev.org/676022 | 21:31 |
| *** ociuhandu has joined #openstack-nova | 21:36 | |
| *** abaindur has quit IRC | 21:38 | |
| *** abaindur has joined #openstack-nova | 21:39 | |
| *** ociuhandu has quit IRC | 21:42 | |
| *** slaweq has quit IRC | 21:46 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova-lxc job to the experimental queue https://review.opendev.org/676024 | 22:02 |
| mriedem | donnyd: sean-k-mooney: ^ and now i'm out o/ | 22:02 |
| *** mriedem is now known as mriedem_afk | 22:03 | |
| *** markvoelker has joined #openstack-nova | 22:03 | |
| donnyd | Yesssss | 22:05 |
| *** BjoernT has quit IRC | 22:07 | |
| *** lbragstad has joined #openstack-nova | 22:09 | |
| *** vishwanathj has quit IRC | 22:10 | |
| *** mchlumsky has quit IRC | 22:14 | |
| *** spatel has joined #openstack-nova | 22:14 | |
| openstackgerrit | Merged openstack/nova stable/queens: libvirt: move checking CONF.my_ip to init_host() https://review.opendev.org/672161 | 22:16 |
| *** mlavalle has quit IRC | 22:16 | |
| openstackgerrit | Merged openstack/nova master: Avoid timeout from service update notification tests https://review.opendev.org/675935 | 22:16 |
| *** lbragstad has quit IRC | 22:17 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027 | 22:22 |
| *** ociuhandu has joined #openstack-nova | 22:30 | |
| *** ivve has quit IRC | 22:33 | |
| *** ociuhandu has quit IRC | 22:35 | |
| *** markvoelker has quit IRC | 22:35 | |
| *** spatel has quit IRC | 22:37 | |
| *** hoonetorg has quit IRC | 22:48 | |
| *** hoonetorg has joined #openstack-nova | 22:50 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add nova-lxc job to the experimental queue https://review.opendev.org/676024 | 22:52 |
| *** hoonetorg has quit IRC | 22:57 | |
| *** vishwanathj has joined #openstack-nova | 22:58 | |
| *** macz has joined #openstack-nova | 23:00 | |
| *** markvoelker has joined #openstack-nova | 23:00 | |
| *** hoonetorg has joined #openstack-nova | 23:01 | |
| *** vishwanathj has quit IRC | 23:03 | |
| *** abaindur has quit IRC | 23:04 | |
| *** markvoelker has quit IRC | 23:05 | |
| *** abaindur has joined #openstack-nova | 23:05 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Limit get_sdk_adapter to requested service type https://review.opendev.org/674678 | 23:09 |
| *** rcernin has joined #openstack-nova | 23:11 | |
| *** dave-mccowan has quit IRC | 23:17 | |
| *** markvoelker has joined #openstack-nova | 23:18 | |
| *** mriedem_afk has quit IRC | 23:19 | |
| *** luksky has quit IRC | 23:31 | |
| *** dave-mccowan has joined #openstack-nova | 23:37 | |
| *** takashin has joined #openstack-nova | 23:38 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/stein: Retrun 400 if invalid query parameters are specified https://review.opendev.org/676026 | 23:40 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/rocky: Retrun 400 if invalid query parameters are specified https://review.opendev.org/676027 | 23:53 |
| *** spatel has joined #openstack-nova | 23:54 | |
| *** alex_xu has quit IRC | 23:57 | |
| *** spatel has quit IRC | 23:59 | |
| *** alex_xu has joined #openstack-nova | 23:59 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/queens: Retrun 400 if invalid query parameters are specified https://review.opendev.org/676028 | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!