Thursday, 2019-08-22

*** TxGirlGeek has joined #openstack-nova00:08
*** TxGirlGeek has quit IRC00:08
*** pvradu has joined #openstack-nova00:12
openstackgerritmelanie witt proposed openstack/nova master: Handle websockify v0.9.0 in console proxy  https://review.opendev.org/67785600:12
*** panda has quit IRC00:17
*** takamatsu has quit IRC00:17
*** panda has joined #openstack-nova00:19
*** markvoelker has joined #openstack-nova00:25
*** markvoelker has quit IRC00:30
*** gyee has quit IRC00:32
*** takashin has quit IRC00:55
*** bbobrov has quit IRC00:55
*** lbragstad has quit IRC00:55
*** tbachman has quit IRC00:55
*** edleafe has quit IRC00:55
*** dtantsur|afk has quit IRC00:55
*** ChanServ has quit IRC00:55
*** tkajinam has quit IRC00:55
*** threestrands has quit IRC00:55
*** factor has quit IRC00:55
*** owalsh|away has quit IRC00:55
*** cfriesen has quit IRC00:55
*** jhesketh has quit IRC00:55
*** prometheanfire has quit IRC00:55
*** frickler has quit IRC00:55
*** aarents__ has quit IRC00:55
*** NostawRm has quit IRC00:55
*** mtreinish has quit IRC00:55
*** tobias-urdin has quit IRC00:55
*** rcernin has quit IRC00:55
*** ebbex has quit IRC00:55
*** Conqueror has quit IRC00:55
*** dpawlik has quit IRC00:55
*** hamzy_ has quit IRC00:56
*** mrjk has quit IRC00:56
*** alex_xu has quit IRC00:56
*** mandre has quit IRC00:56
*** eandersson has quit IRC00:56
*** evrardjp has quit IRC00:56
*** amorin has quit IRC00:56
*** lifeless has quit IRC00:56
*** sorrison has quit IRC00:56
*** weshay has quit IRC00:56
*** igordc has quit IRC00:56
*** aojea has quit IRC00:56
*** ircuser-1 has quit IRC00:56
*** yaawang has quit IRC00:56
*** smcginnis has quit IRC00:56
*** stephenfin has quit IRC00:56
*** knikolla has quit IRC00:56
*** kukacz has quit IRC00:56
*** sean-k-mooney has quit IRC00:56
*** sapd1 has quit IRC00:56
*** dansmith has quit IRC00:56
*** dulek has quit IRC00:56
*** rnoriega- has quit IRC00:56
*** tbarron has quit IRC00:56
*** Vek has quit IRC00:56
*** antonym has quit IRC00:56
*** jlvillal has quit IRC00:56
*** panda has quit IRC00:56
*** klindgren has quit IRC00:56
*** artom has quit IRC00:56
*** licanwei has quit IRC00:56
*** Alon_KS has quit IRC00:56
*** hoonetorg has quit IRC00:56
*** lyarwood has quit IRC00:56
*** openstackgerrit has quit IRC00:56
*** lennyb has quit IRC00:56
*** cgoncalves has quit IRC00:56
*** dasp has quit IRC00:56
*** jenglisch has quit IRC00:56
*** Li_Liu has quit IRC00:56
*** johnthetubaguy has quit IRC00:56
*** tonyb has quit IRC00:56
*** pots has quit IRC00:56
*** johanssone has quit IRC00:56
*** jamiec has quit IRC00:56
*** mchlumsky has quit IRC00:56
*** irclogbot_2 has quit IRC00:56
*** brinzhang_ has quit IRC00:56
*** dosaboy has quit IRC00:56
*** cervigni has quit IRC00:56
*** jangutter has quit IRC00:56
*** gibi has quit IRC00:56
*** mgariepy has quit IRC00:56
*** gryf has quit IRC00:56
*** johnsom has quit IRC00:56
*** tjgresha has quit IRC00:56
*** purplerbot has quit IRC00:56
*** ianw has quit IRC00:56
*** gary_perkins has quit IRC00:56
*** Anticimex has quit IRC00:56
*** redkrieg has quit IRC00:56
*** tobberydberg has quit IRC00:56
*** jbryce has quit IRC00:56
*** kmalloc has quit IRC00:56
*** jmlowe has quit IRC00:56
*** logan- has quit IRC00:56
*** mrhillsman has quit IRC00:56
*** yikun has quit IRC00:56
*** bbowen__ has quit IRC00:56
*** tinwood has quit IRC00:56
*** cz2 has quit IRC00:56
*** fungi has quit IRC00:56
*** whoami-rajat has quit IRC00:56
*** yonglihe has quit IRC00:56
*** rouk has quit IRC00:56
*** jroll has quit IRC00:56
*** pas-ha has quit IRC00:56
*** lchabert has quit IRC00:56
*** ildikov has quit IRC00:56
*** tonyb[m] has quit IRC00:56
*** seyeongkim has quit IRC00:56
*** ashish2307 has quit IRC00:56
*** rajinir has quit IRC00:56
*** dustinc has quit IRC00:56
*** jrosser has quit IRC00:56
*** fyx has quit IRC00:56
*** jbernard has quit IRC00:56
*** lxkong has quit IRC00:56
*** mugsie has quit IRC00:56
*** dannins has quit IRC00:56
*** andreaf has quit IRC00:56
*** masayukig has quit IRC00:56
*** gmann has quit IRC00:56
*** donnyd has quit IRC00:56
*** jungleboyj has quit IRC00:56
*** pvradu has quit IRC00:56
*** KeithMnemonic1 has quit IRC00:56
*** DinaBelova has quit IRC00:56
*** kaisers has quit IRC00:56
*** efried has quit IRC00:56
*** Nick_A has quit IRC00:56
*** jistr has quit IRC00:56
*** zzzeek has quit IRC00:56
*** umbSublime has quit IRC00:56
*** ttx has quit IRC00:56
*** hemna_ has quit IRC00:56
*** amotoki has quit IRC00:56
*** mordred has quit IRC00:56
*** arne_wiebalck has quit IRC00:56
*** csatari has quit IRC00:56
*** gregwork has quit IRC00:56
*** coreycb has quit IRC00:56
*** portdirect has quit IRC00:56
*** zbr has quit IRC00:56
*** d34dh0r53 has quit IRC00:56
*** luyao has quit IRC00:56
*** vdrok has quit IRC00:56
*** rpittau|afk has quit IRC00:56
*** samc-bbc has quit IRC00:56
*** mnaser has quit IRC00:56
*** NobodyCam has quit IRC00:56
*** TheJulia has quit IRC00:56
*** PrinzElvis has quit IRC00:56
*** guilhermesp has quit IRC00:56
*** rm_work has quit IRC00:56
*** fnordahl has quit IRC00:56
*** _erlon_ has quit IRC00:56
*** mnasiadka has quit IRC00:56
*** melwitt has quit IRC00:56
*** Hazelesque has quit IRC00:56
*** BlackDex has quit IRC00:56
*** rabel has quit IRC00:56
*** icey has quit IRC00:56
*** StevenK has quit IRC00:56
*** aspiers has quit IRC00:56
*** awestin1 has quit IRC00:56
*** mgagne has quit IRC00:56
*** bauzas has quit IRC00:56
*** ab-a has quit IRC00:56
*** Jeffrey4l has quit IRC00:56
*** dtruong has quit IRC00:56
*** jdillaman has quit IRC00:56
*** dklyle has quit IRC00:56
*** adriant has quit IRC00:56
*** redrobot has quit IRC00:56
*** elod has quit IRC00:56
*** mgoddard has quit IRC00:56
*** adrianc has quit IRC00:56
*** toabctl has quit IRC00:56
*** obre has quit IRC00:56
*** gouthamr has quit IRC00:56
*** spotz has quit IRC00:56
*** szaher has quit IRC00:56
*** kevinbenton has quit IRC00:56
*** larsks has quit IRC00:56
*** arxcruz has quit IRC00:56
*** mmedvede has quit IRC00:56
*** mmedvede has joined #openstack-nova01:14
*** larsks has joined #openstack-nova01:14
*** kevinbenton has joined #openstack-nova01:14
*** arxcruz has joined #openstack-nova01:14
*** szaher has joined #openstack-nova01:14
*** spotz has joined #openstack-nova01:14
*** gouthamr has joined #openstack-nova01:14
*** obre has joined #openstack-nova01:14
*** toabctl has joined #openstack-nova01:14
*** adrianc has joined #openstack-nova01:14
*** mgoddard has joined #openstack-nova01:14
*** elod has joined #openstack-nova01:14
*** redrobot has joined #openstack-nova01:14
*** adriant has joined #openstack-nova01:14
*** dklyle has joined #openstack-nova01:14
*** jdillaman has joined #openstack-nova01:14
*** dtruong has joined #openstack-nova01:14
*** Jeffrey4l has joined #openstack-nova01:14
*** weshay has joined #openstack-nova01:14
*** sorrison has joined #openstack-nova01:14
*** lifeless has joined #openstack-nova01:14
*** amorin has joined #openstack-nova01:14
*** evrardjp has joined #openstack-nova01:14
*** eandersson has joined #openstack-nova01:14
*** mandre has joined #openstack-nova01:14
*** alex_xu has joined #openstack-nova01:14
*** mrjk has joined #openstack-nova01:14
*** hamzy_ has joined #openstack-nova01:14
*** dpawlik has joined #openstack-nova01:14
*** Conqueror has joined #openstack-nova01:14
*** ebbex has joined #openstack-nova01:14
*** rcernin has joined #openstack-nova01:14
*** jamiec has joined #openstack-nova01:14
*** johanssone has joined #openstack-nova01:14
*** tonyb has joined #openstack-nova01:14
*** pots has joined #openstack-nova01:14
*** johnthetubaguy has joined #openstack-nova01:14
*** Li_Liu has joined #openstack-nova01:14
*** jenglisch has joined #openstack-nova01:14
*** dasp has joined #openstack-nova01:14
*** cgoncalves has joined #openstack-nova01:14
*** lennyb has joined #openstack-nova01:14
*** openstackgerrit has joined #openstack-nova01:14
*** lyarwood has joined #openstack-nova01:14
*** hoonetorg has joined #openstack-nova01:14
*** licanwei has joined #openstack-nova01:14
*** artom has joined #openstack-nova01:14
*** Alon_KS has joined #openstack-nova01:14
*** klindgren has joined #openstack-nova01:14
*** panda has joined #openstack-nova01:14
*** edleafe has joined #openstack-nova01:14
*** tbachman has joined #openstack-nova01:14
*** lbragstad has joined #openstack-nova01:14
*** bbobrov has joined #openstack-nova01:14
*** takashin has joined #openstack-nova01:14
*** ab-a has joined #openstack-nova01:14
*** bauzas has joined #openstack-nova01:14
*** mgagne has joined #openstack-nova01:14
*** jlvillal has joined #openstack-nova01:14
*** antonym has joined #openstack-nova01:14
*** Vek has joined #openstack-nova01:14
*** rnoriega- has joined #openstack-nova01:14
*** dansmith has joined #openstack-nova01:14
*** sapd1 has joined #openstack-nova01:14
*** sean-k-mooney has joined #openstack-nova01:14
*** kukacz has joined #openstack-nova01:14
*** knikolla has joined #openstack-nova01:14
*** stephenfin has joined #openstack-nova01:14
*** tbarron has joined #openstack-nova01:14
*** yaawang has joined #openstack-nova01:14
*** smcginnis has joined #openstack-nova01:14
*** ircuser-1 has joined #openstack-nova01:14
*** aojea has joined #openstack-nova01:14
*** dulek has joined #openstack-nova01:14
*** igordc has joined #openstack-nova01:14
*** dtantsur|afk has joined #openstack-nova01:14
*** tobias-urdin has joined #openstack-nova01:14
*** NostawRm has joined #openstack-nova01:14
*** aarents__ has joined #openstack-nova01:14
*** frickler has joined #openstack-nova01:14
*** prometheanfire has joined #openstack-nova01:14
*** jhesketh has joined #openstack-nova01:14
*** cfriesen has joined #openstack-nova01:14
*** mtreinish has joined #openstack-nova01:14
*** owalsh|away has joined #openstack-nova01:14
*** factor has joined #openstack-nova01:14
*** threestrands has joined #openstack-nova01:14
*** tkajinam has joined #openstack-nova01:14
*** awestin1 has joined #openstack-nova01:14
*** aspiers has joined #openstack-nova01:14
*** StevenK has joined #openstack-nova01:14
*** icey has joined #openstack-nova01:14
*** rabel has joined #openstack-nova01:14
*** BlackDex has joined #openstack-nova01:14
*** Hazelesque has joined #openstack-nova01:14
*** melwitt has joined #openstack-nova01:14
*** mnasiadka has joined #openstack-nova01:14
*** _erlon_ has joined #openstack-nova01:14
*** fnordahl has joined #openstack-nova01:14
*** rm_work has joined #openstack-nova01:14
*** guilhermesp has joined #openstack-nova01:14
*** PrinzElvis has joined #openstack-nova01:14
*** TheJulia has joined #openstack-nova01:14
*** mnaser has joined #openstack-nova01:14
*** NobodyCam has joined #openstack-nova01:14
*** samc-bbc has joined #openstack-nova01:14
*** rpittau|afk has joined #openstack-nova01:14
*** vdrok has joined #openstack-nova01:14
*** luyao has joined #openstack-nova01:14
*** d34dh0r53 has joined #openstack-nova01:14
*** zbr has joined #openstack-nova01:14
*** portdirect has joined #openstack-nova01:14
*** coreycb has joined #openstack-nova01:14
*** gregwork has joined #openstack-nova01:14
*** csatari has joined #openstack-nova01:14
*** arne_wiebalck has joined #openstack-nova01:14
*** mordred has joined #openstack-nova01:14
*** ChanServ has joined #openstack-nova01:14
*** card.freenode.net sets mode: +o ChanServ01:14
*** cervigni has joined #openstack-nova01:14
*** jangutter has joined #openstack-nova01:14
*** mgariepy has joined #openstack-nova01:14
*** gryf has joined #openstack-nova01:14
*** johnsom has joined #openstack-nova01:14
*** purplerbot has joined #openstack-nova01:14
*** ianw has joined #openstack-nova01:14
*** gary_perkins has joined #openstack-nova01:14
*** tobberydberg has joined #openstack-nova01:14
*** KeithMnemonic1 has joined #openstack-nova01:15
*** DinaBelova has joined #openstack-nova01:15
*** kaisers has joined #openstack-nova01:15
*** efried has joined #openstack-nova01:15
*** Nick_A has joined #openstack-nova01:15
*** jistr has joined #openstack-nova01:15
*** zzzeek has joined #openstack-nova01:15
*** umbSublime has joined #openstack-nova01:15
*** ttx has joined #openstack-nova01:15
*** hemna_ has joined #openstack-nova01:15
*** amotoki has joined #openstack-nova01:15
*** mandre has quit IRC01:17
*** sorrison has quit IRC01:17
*** roukoswarf has joined #openstack-nova01:21
*** mugsie has joined #openstack-nova01:21
*** bbowen has joined #openstack-nova01:21
*** brinzhang has joined #openstack-nova01:21
*** mandre has joined #openstack-nova01:21
*** Anticimex has joined #openstack-nova01:21
*** lchabert has joined #openstack-nova01:22
openstackgerritBrin Zhang proposed openstack/nova master: Add docstring to check_availability_zone function  https://review.opendev.org/67785801:22
*** tinwood has joined #openstack-nova01:22
*** gmann has joined #openstack-nova01:23
*** jmlowe has joined #openstack-nova01:23
*** irclogbot_1 has joined #openstack-nova01:24
*** hongbin has joined #openstack-nova01:26
*** swamireddy has joined #openstack-nova01:27
*** gmann has quit IRC01:27
*** gmann has joined #openstack-nova01:28
*** igordc has quit IRC01:32
*** fungi has joined #openstack-nova01:36
*** aojea has quit IRC01:39
*** aojea has joined #openstack-nova01:39
*** larainema has joined #openstack-nova01:53
*** jbernard has joined #openstack-nova01:54
*** morgan has joined #openstack-nova02:02
*** jroll has joined #openstack-nova02:03
openstackgerritmelanie witt proposed openstack/nova master: Handle websockify v0.9.0 in console proxy  https://review.opendev.org/67785602:06
*** ricolin has joined #openstack-nova02:21
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies  https://review.opendev.org/64848002:21
*** igordc has joined #openstack-nova02:26
*** markvoelker has joined #openstack-nova02:32
*** hamzy has joined #openstack-nova02:36
*** hamzy_ has quit IRC02:36
*** licanwei has quit IRC02:36
*** BjoernT has joined #openstack-nova02:55
*** markvoelker has quit IRC03:20
*** markvoelker has joined #openstack-nova03:21
*** markvoelker has quit IRC03:25
*** janki has joined #openstack-nova03:45
*** markvoelker has joined #openstack-nova03:46
*** artom has quit IRC03:53
*** markvoelker has quit IRC03:56
*** markvoelker has joined #openstack-nova03:57
*** markvoelker has quit IRC03:57
*** markvoelker has joined #openstack-nova03:58
*** markvoelker has quit IRC04:08
*** markvoelker has joined #openstack-nova04:09
*** hongbin has quit IRC04:13
*** markvoelker has quit IRC04:14
*** udesale has joined #openstack-nova04:16
*** pvradu has joined #openstack-nova04:22
*** mkrai has joined #openstack-nova04:25
*** pvradu has quit IRC04:27
*** mkrai has quit IRC04:34
*** mkrai has joined #openstack-nova04:36
*** BjoernT_ has joined #openstack-nova04:48
*** mkrai has quit IRC04:49
*** BjoernT has quit IRC04:50
*** mkrai has joined #openstack-nova04:51
*** bhagyashris has joined #openstack-nova05:00
*** mkrai has quit IRC05:04
*** mkrai has joined #openstack-nova05:06
openstackgerritMichael Still proposed openstack/nova master: Remove zVM requirement from the top level requirements.  https://review.opendev.org/67787005:11
*** BjoernT_ has quit IRC05:15
*** ratailor has joined #openstack-nova05:18
*** igordc has quit IRC05:20
*** janki has quit IRC05:26
openstackgerritMerged openstack/nova master: Fix missing rule description in HACKING.rst  https://review.opendev.org/67758905:28
*** jaosorior has joined #openstack-nova05:29
*** janki has joined #openstack-nova05:43
*** udesale has quit IRC05:44
*** udesale has joined #openstack-nova05:45
*** takamatsu has joined #openstack-nova05:47
*** aarents__ has quit IRC06:09
*** jawad_axd has joined #openstack-nova06:20
*** pvradu has joined #openstack-nova06:24
*** tetsuro has joined #openstack-nova06:38
*** yonglihe has joined #openstack-nova06:47
*** rpittau|afk is now known as rpittau06:51
*** damien_r has joined #openstack-nova06:56
*** takamatsu has quit IRC06:57
*** pvradu has quit IRC06:57
*** maciejjozefczyk has joined #openstack-nova07:01
*** udesale has quit IRC07:02
*** udesale has joined #openstack-nova07:02
*** udesale has quit IRC07:02
*** udesale has joined #openstack-nova07:03
openstackgerritMerged openstack/nova master: Add a hacking rule for non-existent assertions  https://review.opendev.org/67759607:05
*** trident has quit IRC07:06
alex_xuefried: sean-k-mooney this doesn't sounds right https://review.opendev.org/#/c/664420/42/nova/scheduler/request_filter.py@205, looks like we can't do the translate in request filter07:09
*** udesale has quit IRC07:11
*** udesale has joined #openstack-nova07:11
*** trident has joined #openstack-nova07:14
*** takashin has quit IRC07:17
*** ivve has joined #openstack-nova07:20
openstackgerritBhagyashri Shewale proposed openstack/nova master: Ignore root_gb for BFV in simple tenant usage API  https://review.opendev.org/61262607:29
*** xek has joined #openstack-nova07:36
*** takashin has joined #openstack-nova07:44
*** gibi has joined #openstack-nova07:56
*** threestrands has quit IRC08:01
*** priteau has joined #openstack-nova08:06
*** jangutter_ has joined #openstack-nova08:11
openstackgerritBrin Zhang proposed openstack/nova master: Specify availability_zone to unshelve  https://review.opendev.org/66385108:11
openstackgerritMerged openstack/nova master: Move final bridge commands to privsep.  https://review.opendev.org/63958008:12
openstackgerritMerged openstack/nova master: Cleanup the _execute shim in nova/network.  https://review.opendev.org/63958108:13
openstackgerritMerged openstack/nova master: We no longer need rootwrap.  https://review.opendev.org/55443808:13
openstackgerritMerged openstack/nova master: Cleanup no longer required filters and add a release note.  https://review.opendev.org/63982608:13
openstackgerritMerged openstack/nova master: Make a failure to purge_db fail in post_test_hook.sh  https://review.opendev.org/67780608:13
openstackgerritMerged openstack/nova master: Split fake host capabilities into reusable variables  https://review.opendev.org/67771008:14
*** jangutter has quit IRC08:15
*** mdbooth has joined #openstack-nova08:20
*** shilpasd has joined #openstack-nova08:21
*** sorrison has joined #openstack-nova08:21
*** takamatsu has joined #openstack-nova08:21
*** tkajinam has quit IRC08:23
*** lpetrut has joined #openstack-nova08:24
*** dtantsur|afk is now known as dtantsur08:28
openstackgerritBrin Zhang proposed openstack/nova master: Add delete_on_termination to volume-attach API  https://review.opendev.org/67313308:31
*** gibi has quit IRC08:33
*** gibi has joined #openstack-nova08:33
*** markvoelker has joined #openstack-nova08:37
*** ralonsoh has joined #openstack-nova08:39
openstackgerritBrin Zhang proposed openstack/nova master: Specify availability_zone to unshelve  https://review.opendev.org/66385108:40
*** pvradu has joined #openstack-nova08:41
*** markvoelker has quit IRC08:45
shilpasdgibi: thanks for reviewing patches for 'isolate aggregates', will fix small nits08:49
gibishilpasd: I'm moving forward on that series right now, so you can expect more votes from me08:50
shilpasdgibit: thanks08:51
*** tetsuro has quit IRC08:53
*** tetsuro has joined #openstack-nova08:53
*** rcernin has quit IRC08:54
openstackgerritBrin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration  https://review.opendev.org/67399008:58
*** takamatsu has quit IRC09:08
openstackgerritBrin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id  https://review.opendev.org/67424309:26
*** tetsuro has quit IRC09:27
*** takashin has left #openstack-nova09:30
openstackgerritBrin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration  https://review.opendev.org/67399009:31
*** mdbooth has quit IRC09:32
*** mdbooth has joined #openstack-nova09:37
*** tetsuro has joined #openstack-nova09:37
shilpasdgibi: https://review.opendev.org/#/c/671074/8/nova/objects/aggregate.py@472, we are accepting ignored_keys as [], to make function generalized, So based on 'value' one can get list of aggregates by using this function.09:43
gibishilpasd: do we call the function with such generalized parameters? or do you have a plan short term to add such a call?09:44
openstackgerritBrin Zhang proposed openstack/nova master: Add delete_on_termination to volume-attach API  https://review.opendev.org/67313309:45
shilpasdgibi: no any plan as such, ok, will address this comment, tnx09:47
gibishilpasd: I suggest not to add complexity that will not be used right now. If we figure out that we need a more generic call then we can make the necessary changes in the function any time09:47
shilpasdgibi: sure Gibi, will work on review comments09:49
gibishilpasd: thanks09:49
aspiersalex_xu: I think we need to talk to efried about https://review.opendev.org/#/c/664420/42/nova/scheduler/request_filter.py@206 and https://review.opendev.org/#/c/664420/42/nova/virt/hardware.py@122509:50
aspiersalex_xu: oh, you already said that09:50
openstackgerritAdam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption  https://review.opendev.org/66442009:51
*** mdbooth has quit IRC10:04
*** mdbooth has joined #openstack-nova10:04
*** bhagyashris has quit IRC10:12
*** ociuhandu has joined #openstack-nova10:13
*** tetsuro has quit IRC10:14
stephenfindansmith: Could I get your thoughts on https://review.opendev.org/#/c/537414/ today? I think it's sane, but maybe there's something I've missed or should be doing in addition10:28
stephenfinalex_xu: Fancy hitting these trivial changes? https://review.opendev.org/#/c/671791/ https://review.opendev.org/#/c/675570/10:28
stephenfin#success nova no longer needs rootwrap (well, except for starting privsep daemons and os-brick, for some strange reason)10:33
openstackstatusstephenfin: Added success to Success page (https://wiki.openstack.org/wiki/Successes)10:33
*** shilpasd has quit IRC10:35
openstackgerritStephen Finucane proposed openstack/nova master: Address nits from privsep series  https://review.opendev.org/67721010:37
*** bbowen has quit IRC10:39
openstackgerritBrin Zhang proposed openstack/nova master: Add delete_on_termination to volume-attach API  https://review.opendev.org/67313310:40
*** markvoelker has joined #openstack-nova10:40
*** mdbooth has quit IRC10:45
*** markvoelker has quit IRC10:45
*** mkrai has quit IRC10:47
*** mkrai_ has joined #openstack-nova10:47
openstackgerritStephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize  https://review.opendev.org/66252210:50
openstackgerritStephen Finucane proposed openstack/nova master: Update docstring of 'revert_resize' function  https://review.opendev.org/66597610:50
openstackgerritStephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test  https://review.opendev.org/66424510:50
openstackgerritStephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper  https://review.opendev.org/66310210:50
*** takamatsu has joined #openstack-nova10:55
sean-k-mooneyefried: o/ i have a process question for you. when can we submit blueprints/specs for approval for Ussuri. i think its normally after m3 but you mentions posible targeting stuff to U early a week or two back10:58
*** mkrai_ has quit IRC10:59
sean-k-mooneyfrom a downstream persective we will normally only consider a feature bacport if said feature is merged on master, and we will only commit to trying to backport it if the feature is approved and the design allows it to be11:00
sean-k-mooneythe context is i have a customer asking when we will know if we can backport https://review.opendev.org/#/c/674072/ and currenly we have said october/november but just trying to figure out if we can let them know before then.11:01
openstackgerritsahid proposed openstack/nova master: cellv2: fix update_cell to support cell0  https://review.opendev.org/67204511:01
alex_xuaspiers: yea, that is really strange11:03
alex_xustephenfin: yea, checking11:03
*** tesseract has joined #openstack-nova11:07
*** ash2307 has joined #openstack-nova11:09
*** markvoelker has joined #openstack-nova11:10
alex_xustephenfin: done11:11
stephenfinalex_xu: Thanks :)11:12
alex_xunp11:12
openstackgerritStephen Finucane proposed openstack/nova master: WIP: Move DB dependencies to 'extras'  https://review.opendev.org/67747511:13
openstackgerritStephen Finucane proposed openstack/nova master: setup.cfg: Cleanup  https://review.opendev.org/67796911:13
*** jamesdenton has joined #openstack-nova11:14
*** udesale has quit IRC11:14
*** markvoelker has quit IRC11:15
aspiersalex_xu: sorry, what's strange?11:17
stephenfinalex_xu: There's one more non-functional change here actually, if you have time https://review.opendev.org/#/c/672336/ :)11:18
*** tbachman has quit IRC11:20
*** takamatsu has quit IRC11:25
*** shilpasd has joined #openstack-nova11:35
*** aojea has quit IRC11:36
*** ash2307 has quit IRC11:37
*** ash2307 has joined #openstack-nova11:38
*** bbowen has joined #openstack-nova11:38
*** markvoelker has joined #openstack-nova11:40
*** tbachman has joined #openstack-nova11:41
*** markvoelker has quit IRC11:45
*** takamatsu has joined #openstack-nova11:45
*** ociuhandu has quit IRC11:53
*** markvoelker has joined #openstack-nova11:54
*** jangutter_ is now known as jangutter12:02
*** larainema has quit IRC12:07
shilpasdgibi: hi12:12
gibishilpasd: hi12:12
shilpasdgibi: if we don't have traits sets either on flavor or image, then we should skip this filter, since https://review.opendev.org/#/c/667952/18/nova/tests/functional/test_aggregates.py@516 is failing if raise ValueError if ignored_keys is empty12:13
shilpasdIMO, we should return false at https://review.opendev.org/#/c/671075/9/nova/scheduler/request_filter.py@79, if keys is empty12:15
openstackgerritMerged openstack/nova master: FUP for I5576fa2a67d2771614266022428b4a95487ab6d5  https://review.opendev.org/67776912:15
shilpasdgibi: please confirm12:15
shilpasdIMO we should skip filter if keys are empty12:17
gibishilpasd: if there is no traits in image or in flavor we still want to prevent the instance to land in an aggregate that needs to be isolated. isn't it?12:17
*** belmoreira has joined #openstack-nova12:18
gibishilpasd: it is how I understand the spec https://review.opendev.org/#/c/609960/8/specs/train/approved/placement-req-filter-forbidden-aggregates.rst@2012:19
shilpasdgibi: yes12:19
gibiso if the keys are empty then we have to forbid every aggregates that has some kind of metadata set12:19
shilpasdso we shouldn't raise ValueError in DB for ignored_keys empty12:20
shilpasdhttps://review.opendev.org/#/c/671074/8/nova/objects/aggregate.py@47212:21
*** ratailor has quit IRC12:21
gibishilpasd: you are correct. so if there is no ignored_keys then we have to return every aggregate that has metadata.value set to "required"12:22
gibishilpasd: so my comment is wrong in  https://review.opendev.org/#/c/671074/8/nova/objects/aggregate.py@47212:23
shilpasdgibi: ok, will skip this12:23
*** ociuhandu has joined #openstack-nova12:24
*** takashin has joined #openstack-nova12:24
gibishilpasd: I guess i mixed up ignored_keys and key_prefix. See https://review.opendev.org/#/c/671074/8/nova/objects/aggregate.py@47312:25
shilpasdgibi: no prob, tnx for discussion12:26
gibishilpasd: thanks for double checking my comment12:26
*** adriant has quit IRC12:26
shilpasdwill have ValueError at beginning only for key_prefix12:26
*** adriant has joined #openstack-nova12:27
gibishilpasd: ack12:27
shilpasdthank you12:27
*** nweinber has joined #openstack-nova12:29
*** mdbooth has joined #openstack-nova12:29
*** mmethot has quit IRC12:31
*** donnyd has joined #openstack-nova12:32
*** ociuhandu has quit IRC12:33
openstackgerritAdam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported  https://review.opendev.org/63868012:54
*** nweinber_ has joined #openstack-nova12:56
aspiersstephenfin: thanks for your recheck on https://review.opendev.org/#/c/673151/16 - but any idea why it's rerunning the check jobs not the gate jobs?12:58
*** nweinber has quit IRC12:58
stephenfinaspiers: no idea. That's just the way it's always done it. It's a zuul thing, I imagine12:59
aspiersOh, I thought that once it hit the gate, recheck would only redo the gate jobs12:59
aspiersThought I'd seen that behaviour before12:59
*** jmlowe has quit IRC12:59
aspiersSeems kinda pointless to rerun the check jobs when nothing has changed there12:59
aspiersOh well, check is almost finished, gate soon13:00
openstackgerritMerged openstack/nova master: Make memtune parameters consistent with libvirt docs and code  https://review.opendev.org/63630113:10
openstackgerritMerged openstack/nova master: fakelibvirt: Stop distinguishing between NUMA, non-NUMA  https://review.opendev.org/67557013:10
belmoreiramelwitt I'm upgrading nova to stein and i'm having issues with novnc13:11
belmoreiraas part of the consoleauth deprecation where are the tokens stored?13:13
openstackgerritShilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter  https://review.opendev.org/67107213:13
*** tbachman has quit IRC13:16
*** gbarros has joined #openstack-nova13:16
*** ociuhandu has joined #openstack-nova13:17
*** tbachman has joined #openstack-nova13:18
*** ociuhandu has quit IRC13:19
*** BjoernT has joined #openstack-nova13:19
*** ociuhandu has joined #openstack-nova13:20
*** mriedem has joined #openstack-nova13:21
*** ociuhandu has quit IRC13:21
*** ociuhandu has joined #openstack-nova13:22
openstackgerritShilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata  https://review.opendev.org/67107413:22
*** ash2307 has quit IRC13:22
openstackgerritShilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates  https://review.opendev.org/67107513:24
*** ash2307 has joined #openstack-nova13:26
*** jmlowe has joined #openstack-nova13:26
*** ociuhandu has quit IRC13:27
openstackgerritShilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates  https://review.opendev.org/66795213:27
*** ociuhandu has joined #openstack-nova13:27
*** belmoreira has quit IRC13:28
*** bnemec has joined #openstack-nova13:29
*** belmoreira has joined #openstack-nova13:30
belmoreiraI would really appreciate some help with vnc13:32
belmoreirawhen using workarounds/enable_consoleauth=true we don't keep the previous behaviour?13:32
belmoreiratokens are now stored in the cell db.13:33
*** BjoernT_ has joined #openstack-nova13:33
openstackgerritStephen Finucane proposed openstack/nova master: Update docstring of 'revert_resize' function  https://review.opendev.org/66597613:33
openstackgerritStephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize  https://review.opendev.org/66252213:33
openstackgerritStephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test  https://review.opendev.org/66424513:33
openstackgerritStephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper  https://review.opendev.org/66310213:33
belmoreirathe was I'm running novnc is global, so is not connecting to the db to check the token13:33
belmoreiras/was/way13:34
adriancstephenfin, sean-k-mooney : do we have a verdict on: https://review.opendev.org/#/c/675776/ ?13:34
*** BjoernT has quit IRC13:34
sean-k-mooneywe could revert it and not that this is need due to a bug in the sriov nic agent13:35
stephenfinbelmoreira: melwitt will hopefully correct me if I say anything wrong, but '[workarounds] enable_consoleauth' enables a fallback path to help with migration to the new DB-based system13:36
*** ociuhandu has quit IRC13:36
sean-k-mooneythere is nolonger a need to set the mac for libvirt but it valid to still set it untill the sriov nic agent is updated. it is a bug that the agent depens on the mack however13:36
stephenfinEmphasis on fallback. We'll use the DB tokens first and foremost and only fallback if no tokens are found13:37
*** ociuhandu has joined #openstack-nova13:37
adrianc"a historic design decision" :)13:37
belmoreirastephenfin I'm trying to use that without success.13:37
sean-k-mooneyadrianc: the historic design descis being the only thing that was allowed to be depeded on is the pci address :)13:38
sean-k-mooneyat somepoint i guess neutron forgot that13:38
*** ociuhandu has quit IRC13:39
sean-k-mooneythe sriov nic agent is in principal ment to be able to work with non libvirt virt drivers too13:39
belmoreirastephenfin token validation fails13:39
*** lbragstad has left #openstack-nova13:39
*** ociuhandu has joined #openstack-nova13:40
sean-k-mooneylike xen or powervm although i dont know if it is used with either13:40
yonglihesean-k-mooney: thanks given your valuable +1 for https://review.opendev.org/#/c/621476/13:40
stephenfinbelmoreira: Odd. I'm looking at commit 969239029d4a13956747e6e0b850d6c6ab4035f0 rn to see what could possibly be going wrong13:40
stephenfinbelmoreira: Dumb question, but you have this option set on the conf files used by the 'nova-novncproxy' service, right?13:41
belmoreirastephenfin yes13:41
stephenfinCool. Just checking :)13:41
sean-k-mooneystephenfin: feel like sending https://review.opendev.org/#/c/621476/ on its way and closing out that blueprint13:42
stephenfinI'd been holding off on that because I still wasn't sure how I feel about that whole thing, heh13:42
stephenfinBut yeah. Let me finish looking into this consoleauth thing first though13:43
*** tbachman has quit IRC13:43
sean-k-mooneyok if you have time to add it to your review queue then its an easy win assumeing you decide how you feel about it13:43
adriancsean-k-mooney: ill open a bug in neutron, once the revert is in ill abandon https://review.opendev.org/#/c/67671313:43
sean-k-mooneyadrianc: why abandon that? it would be good to open the bug first and update the comment to reference the new bug13:44
sean-k-mooneyoh because it still depens on the mac13:44
sean-k-mooneyjsut looks at a different source13:44
adriancyah, we talked that changes will be required from server side13:45
adrianci.e the mechanism driver13:45
*** priteau has quit IRC13:45
*** mmethot has joined #openstack-nova13:46
*** ociuhandu has quit IRC13:46
stephenfinbelmoreira: Have you tracebook to look at? There are a couple of InvalidToken exceptions that could be raised in that code13:46
stephenfin*trackback13:46
stephenfin*traceback13:46
stephenfinthird time lucky13:46
*** tbachman has joined #openstack-nova13:46
*** altlogbot_1 has joined #openstack-nova13:47
openstackgerritAlexandre arents proposed openstack/nova master: Abort live-migration during instance_init  https://review.opendev.org/67801613:48
*** altlogbot_1 has quit IRC13:48
stephenfinI can't see anything obvious there, though I was wrong with my statement about it being a fallback. If that's toggled, we check the consoleauth service first, not after13:48
belmoreirastephenfin: from consoleauth: Checking Token: ***, False13:51
shilpasdgibi: Hi, i have pushed revised patches (waiting for zuul) but i have lost your +2s, requesting you to review/vote further, thanks13:52
*** altlogbot_2 has joined #openstack-nova13:52
shilpasdAddressed your review comments and uploaded patches for isolated aggregates patches.13:53
belmoreirastephenfin: from nova-novncproxy: https://www.codepile.net/pile/O1P8ee1q13:54
stephenfinbelmoreira: Should I see something there?13:54
*** igordc has joined #openstack-nova13:55
openstackgerritMatt Riedemann proposed openstack/nova master: Update docstring of 'revert_resize' function  https://review.opendev.org/66597613:55
belmoreirastephenfin: the way that is deployed is global. nova-novncproxy and consoleauth are not deployed per cell13:56
*** Sundar has joined #openstack-nova13:57
stephenfinOh, that could be problematic13:57
belmoreirastephenfin: that is the trace that I get. the "code 404, message File not found" is new to me13:58
*** davee_ has joined #openstack-nova13:59
efriednova meeting now14:00
Sundardansmith, sean-k-mooney, mriedem, gibi: Can you please review https://review.opendev.org/#/q/status:open+project:openstack/nova+bp/nova-cyborg-interaction ? I have added the notification and addressed the main comments. Will add more UT, tempest CI framework is making progress.14:00
SundarWell, all are welcome to review.14:00
stephenfinbelmoreira: I think you're going to need to open a bug for this. I don't know if this has been discussed as an issue before (I don't recall it having been so)14:00
efriedsean-k-mooney: We were going to wait until the name was official to start creating the artifacts in lp and nova-specs. If you have a spec you want to open right now, you can write it against backlog/ and then move it.14:01
sean-k-mooney Sundar what os are you deveoping on? i can try and deploy the series in a vm14:01
efriedalex_xu, sean-k-mooney, aspiers: request filter stuff after the meeting?14:01
*** davee_ has quit IRC14:01
alex_xuefried: yea14:01
sean-k-mooneyit will be next week before i can spend a lot of time on ith however14:02
belmoreirastephenfin ok thanks14:02
sean-k-mooneyefried: ya i can do that. its going to be really short anyway14:02
*** hemna has joined #openstack-nova14:02
*** davee_ has joined #openstack-nova14:02
sean-k-mooneyefried: stephenfin and i have an internal team meeting after the nova meeting but we will be still on irc14:03
Sundarsean-k-mooney: It  is Centos 7.6, kernel 3.10.0-95714:03
SundarThanks14:03
sean-k-mooneySundar: im assuming you testing with python 2 still? or python 314:03
SundarYes, python 214:04
sean-k-mooneyok i have been having issue with centos and python2 lately but ill spin up a vm and try and deploy it14:04
belmoreirastephenfin is there any recommendation how to setup nonvc with multiple cells?14:04
aspiersefried: sure14:04
dansmithbelmoreira: I think you really want to talk to melwitt14:05
sean-k-mooneythe fake driver merged in cyborg right so i should be able to test with that14:05
belmoreirastephenfin I'm thinking how this should work now. We will need to have nova-novncproxy available per cell. This means that the vnc url that I will get will include the cell controller. Is this correct?14:05
*** jawad_axd has quit IRC14:05
*** jawad_axd has joined #openstack-nova14:06
Sundarsean-k-mooney: Yes, the fake driver has merged. Please deploy https://review.opendev.org/#/q/project:openstack/cyborg+branch:master+topic:nova-integ+status:open . The part where Cyborg reports to Placement, https://review.opendev.org/#/c/659233/, is also WIP. But the combination works today with some massaging. We will sort out the wrinkles before14:08
Sundarmerging these patches.14:08
stephenfinbelmoreira: I really don't know, I'm afraid :( melwitt is your person14:08
belmoreiradansmith stephenfin thanks, will try to talk with melwitt14:09
stephenfinI know you'll need a service per cell, yes, but how that will look I'm not sure14:09
stephenfinhttps://github.com/openstack/devstack/blob/master/lib/nova#L947-L97314:09
*** jawad_axd has quit IRC14:10
*** spsurya has joined #openstack-nova14:10
*** janki has quit IRC14:11
*** hemna has quit IRC14:12
*** nweinber_ has quit IRC14:13
*** Sundar has quit IRC14:15
*** ociuhandu has joined #openstack-nova14:16
openstackgerritAdrian Chiris proposed openstack/nova master: Revert "vif: Resolve a TODO and update another"  https://review.opendev.org/67577614:17
*** nweinber_ has joined #openstack-nova14:17
*** ociuhandu has quit IRC14:19
*** ociuhandu has joined #openstack-nova14:19
*** eharney has joined #openstack-nova14:20
*** tbachman has quit IRC14:22
*** tbachman has joined #openstack-nova14:23
*** ash2307 has quit IRC14:27
*** Sundar has joined #openstack-nova14:27
*** Sundar has quit IRC14:28
*** ash2307 has joined #openstack-nova14:28
mriedemdtantsur: TheJulia: did you find out if https://review.opendev.org/#/q/topic:bug/1839560+branch:stable/stein fixed your grenade issue with rebalancing?14:30
TheJuliamriedem: upon issuing a change on master branch, zuul immediately comes back and says there is a branch merge failure with dependencies of a dependent patch on stable/stein14:32
TheJuliaIt used to work, but... I guess not anymore.14:32
aspierssean-k-mooney: recheck is apparently not working for https://review.opendev.org/#/c/666915/14:33
stephenfinyonglihe, sean-k-mooney: Think there's a bug with that NUMA API change14:34
stephenfincomments left14:34
sean-k-mooneyit hit a post failure again or there was a zuul restart and it got droped im guess14:35
stephenfintl;dr: I'd kill the summary view entirely. I don't think it's possible for it to be reliable14:35
sean-k-mooneystephenfin: ya just read good cache on the mutable data in kwargs14:35
sean-k-mooneystephenfin: i though we had a hacking check for that14:35
yonglihestephenfin: post me a comment, i gonna fix it soon. and you got new update next day. thanks.14:35
stephenfinyonglihe: Cool. Thanks :)14:35
*** gbarros has quit IRC14:38
yonglihestephenfin:  for most important of -1, it's we should drop instance.vcpu_model, right?14:39
stephenfinyonglihe: In a meeting. Give me 1014:39
yonglihesure.14:39
*** hemna has joined #openstack-nova14:43
*** jhesketh has quit IRC14:44
*** cfriesen has quit IRC14:44
*** jaosorior has quit IRC14:44
*** nweinber__ has joined #openstack-nova14:45
*** jhesketh has joined #openstack-nova14:45
stephenfinyonglihe: to be honest, I'd personally like to drop the 'cpu_topology' element [1] from the response [1] https://review.opendev.org/#/c/621476/57/doc/api_samples/os-server-topology/v2.77/servers-topology-resp-user.json@214:46
stephenfinso we'd just include the 'nodes' element14:46
stephenfinyonglihe: The reason being asymmetric topologies, which we support14:47
stephenfinI can do this:14:47
yongliheOk, got your concern.  That's seems very right thing to do.14:48
stephenfinopenstack flavor create --vcpus 3 --ram 768 --disk 20 test.asymmetric14:48
*** nweinber_ has quit IRC14:48
*** ash2307 has left #openstack-nova14:48
yongliheI know that stuff,  but it slipped away while wrote spec -:).14:49
stephenfinopenstack flavor set test.asymmetric --property 'hw:numa_nodes=2' --property 'hw:numa_cpus.0=0' --property 'hw:numa_cpus.0=1,2' --property 'hw:numa_mem.0=256' --property 'hw:numa_mem.1=512'14:49
stephenfinOkay, sweet :)14:49
*** mdbooth has quit IRC14:50
stephenfinAlso, I wonder if we should rename 'vcpu_set' to 'cpus' ?14:50
yongliheI bet alex_xu also buy in this solution.14:50
stephenfinThe reason being that we're overloading the term vcpu now with the cpu-resources work14:50
stephenfinand it's also not a set14:50
yonglihecpus seems enough,14:50
stephenfinCool cool14:50
yongliheit's list?14:51
stephenfinIn your response, yeah14:51
yonglihei wonder the does json had a set?14:51
stephenfinI don't know if JSON supports sets or similar14:51
stephenfinjinx14:51
stephenfinI don't think we need it14:51
stephenfinEven if it did14:51
stephenfinSince this is read-only14:51
stephenfinsean-k-mooney: You happy with all that ^ RE: https://review.opendev.org/#/c/621476/14:52
yonglihejinx? what's that, i'm lost here.14:52
*** mdbooth has joined #openstack-nova14:52
stephenfinyonglihe: people say "jinx" when two people say the same thing at the same time14:52
sean-k-mooneyreading back14:53
yonglihe-:0) new to me . thanks.14:53
sean-k-mooneyyou have a typo14:53
stephenfinUrban Dictionary is a rarely a good resource but here you go, heh https://www.urbandictionary.com/define.php?term=Jinx14:53
sean-k-mooneyopenstack flavor set test.asymmetric --property 'hw:numa_nodes=2' --property 'hw:numa_cpus.0=0' --property 'hw:numa_cpus.1=1,2' --property 'hw:numa_mem.0=256' --property 'hw:numa_mem.1=512'14:53
*** tbachman has quit IRC14:53
mdboothstephenfin: I'd assumed that was a British thing?14:54
*** ash2307 has joined #openstack-nova14:54
mdboothstephenfin: Although you are part Essex boy, of course14:54
*** artom has joined #openstack-nova14:54
stephenfinsean-k-mooney: Oops, yeah. Generally though, do those comments make sense14:55
sean-k-mooneymdbooth: jinx is a thing in ireland too14:55
mdboothmriedem dansmith: https://review.opendev.org/#/c/677736/ Do those unit tests look better? Dropped the libvirt dep.14:55
stephenfinmdbooth: Definitely an Irish thing too, I assure you14:55
sean-k-mooneystephenfin: i have not read all the comments in the review but i will14:55
*** takamatsu has quit IRC14:55
mdboothstephenfin: Perhaps it's a general anglophone thing, too14:55
stephenfinthough the variant I knew growing up involved not speaking 'til you were freed from the jinx :-\14:56
mdboothstephenfin: Yep, that's the one I remember14:56
sean-k-mooneystephenfin: and being punched in the sholder if you did14:56
stephenfinyuuuup14:56
*** ash2307 has left #openstack-nova14:56
mdboothyonglihe: It's a cultural rabbit hole :)14:56
dansmithmdbooth: just using fakelibvirt but otherwise the same? yes :)14:56
mdboothdansmith: Yarp. I had to add some additional fakeness to fakelibvirt14:57
mdboothBut not a lot14:57
dansmithaye14:57
mdboothdansmith: I've given the customer a test build, so hopefully we'll get some feedback on whether it addresses the real issue.14:58
alex_xustephenfin: yonglihe still checking that whether we will have empty sockets https://github.com/openstack/nova/blob/f9ba1192c4/nova/virt/libvirt/driver.py#L521914:58
dansmithmdbooth: cool14:58
stephenfinalex_xu: Yeah, that branch could be invalid (it wouldn't be the first time). Just as importantly though, what does that do for the asymmetric topology case?14:59
*** mlavalle has joined #openstack-nova15:00
alex_xustephenfin: whether drop the cpu_topology field probably a decision for yonglihe, I remember lasttime talk with sean-k-mooney, we said if he want the cpu_topology, then it must be a field out of nova cell15:00
yonglihealex_xu, stephenfin,  sean-k-mooney: drop it seems safe enough.15:01
alex_xustephenfin: I think instance.vcpu_model is for the whole machine, doesn't related to numa15:01
alex_xuokay15:01
sean-k-mooneyyes it is for the whole vm15:01
sean-k-mooneyit not related to numa15:02
sean-k-mooneyyou can have cpu_sockets=1 and numa_nodes=2 or cpu_sockets=2 and numa_nodes=115:02
*** munimeha1 has joined #openstack-nova15:02
*** gbarros has joined #openstack-nova15:03
sean-k-mooneyif you use the numa_cpu.X=y syntax you can even make it more disjoint15:03
yongliheif it  for whole VM , does it related to asyc cpu number? how it going to behavior under such configurations?15:03
yongliheopenstack flavor set test.asymmetric --property 'hw:numa_nodes=2' --property 'hw:numa_cpus.0=0' --property 'hw:numa_cpus.1=1,2' --property 'hw:numa_mem.0=256' --property 'hw:numa_mem.1=512'15:03
sean-k-mooneynone of those option affect eh cpu toployg at all15:04
sean-k-mooneyit change what memory contolr the cpu is mapped too15:04
alex_xusean-k-mooney: and the numa can across a socket, right?15:04
sean-k-mooneythe coup toplogy is contoled by hw:cpu_sockets, hw:cpu_threads and hw:cpu_cores15:04
sean-k-mooneyyep15:04
sean-k-mooneyor you can have multple numa node ins the same socket15:05
sean-k-mooneythey are treated entirely seperatly15:05
alex_xuyea, so numa is totally a logic partition for the cpu15:05
alex_xuand memory15:05
*** jmlowe has quit IRC15:05
sean-k-mooneyyou can technical configure a 2 core vm where differente hyperthreas are in different  numa nodes if you want too15:05
*** takashin has left #openstack-nova15:07
alex_xunice15:07
yonglihesure, so  expose cpu_topology  is not related to asyc cpu.15:07
*** jmlowe has joined #openstack-nova15:07
alex_xusean-k-mooney: but stephenfin point out https://github.com/openstack/nova/blob/f9ba1192c4/nova/virt/libvirt/driver.py#L5219, the vcpu_topology may empty15:08
alex_xuI just doesn't figure out what case we will have yet15:08
sean-k-mooneysure it will be empty unless you use teh hw:cpu_* extrapecs15:08
sean-k-mooneyso we need to not just check the vcpu_model but allso all of the sub fields to see if they are set15:09
alex_xuoh, I thought we will have a default one15:09
sean-k-mooneythe default is virt driver speficic15:09
sean-k-mooneyso unless the virt driver populated it in the instance no15:10
sean-k-mooneyif it does we might15:10
melwittbelmoreira: hi, as of rocky, console proxies need to be deployed per cell https://docs.openstack.org/nova/stein/user/cellsv2-layout.html#consoleauth-service-and-console-proxies and then if you need to keep consoles working during a live upgrade, set [workarounds]enable_consoleauth = True to enable nova-consoleauth to be a fall back https://docs.openstack.org/releasenotes/nova/stein.html15:12
efriedalex_xu, sean-k-mooney, aspiers: so what's up with this request_filters thing?15:12
alex_xuefried: I thought we always getting the info from extra spec, not put something back to extra spec https://review.opendev.org/#/c/664420/42/nova/scheduler/request_filter.py@20615:13
alex_xuthat feel strange15:13
aspiersalex_xu: did you see the eavesdrop discussions I linked to?15:14
sean-k-mooney alex_xu the reques filter do modify the tempory flavor15:14
efriedyeah, it's an unfortunate temporary measure15:14
alex_xuaspiers: sorry, I didn't get a chance yet15:14
efriedaspiers and I discussed at the PTG the longer road to restructuring the code so we wouldn't have to do that, we could just update the request spec (I think)15:15
efriedbut afaik aspiers hasn't rewritten all of that for us yet :P15:15
aspiersalex_xu: hw:mem_encryption=True is the extra spec visible to users/operators, but it needs to be translated into resources:MEM_ENCRYPTION_CONTEXT=1 behind the scenes just within the RequestSpec15:15
aspiersusers/ops shouldn't have to know about the resource class15:16
efried++ ^ this15:16
alex_xuyea, I see15:16
efriedalex_xu: There's precedent in the other request filters, which I think aspiers pointed to.15:16
sean-k-mooneywe do the same thing with request filters that add required/forbiding tratis15:16
alex_xuprobably we can have request group obj in request spec, then it will be more beatiful15:16
belmoreiramelwitt thanks. I'm reading more about this change15:16
efriedyes alex_xu, that's the idea, but it's not simple to do.15:16
efriedaspiers and I talked about it for like 2h on Saturday at the PTG.15:17
alex_xuok, got it, seem that is already thing we agree on can do now15:17
sean-k-mooneyyep we were not planning to use the request spec in train right15:17
aspiersI'd love the chance to improve things in the future, but it would be great if we don't have to block SEV for this15:17
sean-k-mooneythat was for U15:17
melwittbelmoreira: k. let me know if you have questions. also, mnaser went through this same novnc "challenge" when he upgraded, so maybe he can help answer questions too15:17
efriedsean-k-mooney: we were tentatively thinking it could happen in T, but at this point, yeah, we should probably punt.15:18
*** ash2307 has joined #openstack-nova15:18
alex_xuI won't block on that15:18
mnasero/15:18
melwittbelmoreira: from an operator perspective, I mean15:18
aspiersefried: having said all that, alex_xu's suggestion to put the translation into scheduler/utils.py sounded interesting15:18
aspiersbut I don't know enough to understand how that relates to this discussion right now15:19
sean-k-mooneyefried: we have a few new request filters this cycle. i think it makes sense to prot them all in U15:19
efriedmelwitt: Thank you for the fix around websockify. And stephenfin thanks for digging into the symbol alias business. I guess we're stuck supporting the dual-location business :(15:19
efriedaspiers: where was that part?15:19
sean-k-mooneyaspiers: we were moving away form that intentionally15:19
aspiersefried: let me find it15:19
belmoreiramelwitt: workarounds/enable_consoleauth = True is only for the leftovers, right? becasue in stein the DB will be always used to store the token15:19
*** macz has joined #openstack-nova15:20
sean-k-mooneye.g. we do some traslation in utils but we disucess not doing that and using request filster intead15:20
melwittmnaser: belmoreira just upgraded to stein and novnc started failing to work, console proxies are not yet deployed per cell. I'm thinking he needs to set [workarounds]enable_consoleauth = True during the live upgrade and then deploy proxies per cell and then after upgrade be able to turn  [workarounds]enable_consoleauth = False15:20
sean-k-mooneyaspiers: efried that said we do translate vcpu/ram/disk in the scheulder/utils15:20
alex_xuvpmem also need that, and stephenfin's standard cpu tracking need that also15:20
aspiersefried: https://review.opendev.org/#/c/664420/42/nova/scheduler/request_filter.py@20615:20
sean-k-mooney alex_xu ya so stephenfin's change will do it in the sculder utils replace this https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L43215:22
efriedaspiers: So is the suggestion to put the translation from hw_mem_enc extra spec to MEM_ENC_CTX resource class into the sched/utils from_request_spec (or from_extra_specs) method instead of the request filter?15:22
belmoreiramelwitt, the main issue is because I'm running the novnc/console_auth globally (not per cell). And after the rocky->stein upgrade it can check tokens anymore (even when using [workarounds]enable_consoleauth=true)15:22
sean-k-mooneybut in general im not sure we shoudl keep doing that15:22
melwittbelmoreira: right, for leftovers and also needed during the live upgrade to handle consoles while you're changing the deployment to deploy proxies per cell. once you have proxies per cell and upgrade complete, you can turn workarounds/enable_consoleauth = False and stop the nova-consoleauth service and stop having to deploy it15:22
stephenfinmelwitt: I think belmoreira is saying that it's still not working with 'workarounds/enable_consoleauth = True' though15:23
aspiersefried: yes I think that's what alex_xu is suggesting15:23
melwittbelmoreira, stephenfin: hm, ok. thinking...15:24
sean-k-mooneyaspiers: efried we could but i though we talked about this at the ptg and decied not to do that15:24
alex_xuI'm ok with both, just want to figure out what is the plan for T release since we have serveal patch will do the same thing15:24
sean-k-mooneyi could be miss rememebring that15:24
belmoreirastephenfin, melwitt it doesn't work with workarounds/enable_consoleauth = True (with everything running stein)15:24
aspierssean-k-mooney, alex_xu: what are the pros / cons?15:25
melwittbelmoreira: I guess... that does make sense after the TTL has expired for already existing tokens, if you have not deployed proxies per cell yet15:25
melwittbecause new tokens are *not* stored in nova-consoleauth15:25
melwitt*new token auths15:26
aspiersboth code paths run in the scheduler, right?15:26
efriedaspiers, alex_xu: Perhaps after we've merged stephenfin's patch to consolidate all that request spec mess, we could refactor the various request filters to do that. (I would still want it modular so it's not a monolithic mass of conversions.) But for now, that from_request_spec/from_extra_specs code is a bloody mess and it would be pretty hard to work the logic into the right places. So for now I say leave it in the request filte15:26
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Get instances outside of update_available_resource lock  https://review.opendev.org/67779015:26
alex_xuefried: ok, got it15:26
stephenfinefried: Are you referring to https://review.opendev.org/#/c/674894/ ?15:26
aspiersefried: OK thanks15:26
*** ivve has quit IRC15:27
aspiersalex_xu: so that means https://review.opendev.org/#/c/664420/42 is ready for re-review15:27
*** ash2307 has quit IRC15:27
efriedstephenfin: yes, that's the one.15:27
belmoreiramelwitt right... is there any easy way to enable tokens in nova-consoleauth again? (I'm in the middle of a crisis here)15:27
alex_xuaspiers: yea15:27
aspiersalex_xu: oops sorry I mean https://review.opendev.org/#/c/664420/ previous link was an old PS15:28
stephenfinI think I could move that to the top of the list of approved patches if you want it now? I don't think it has a dependency on any of my other functional changes15:28
efriedstephenfin: I wonder, is there a way it could be moved out/earlier?... jinx15:28
stephenfincoke!15:28
aspiersalex_xu, stephenfin: also I fixed the tiny bug in https://review.opendev.org/#/c/63868015:28
efriedstephenfin: as discussed above, we're not blocking on it, we're going to continue to do the logic in the request filter for now. So don't worry about it unless it's easy.15:28
stephenfinSure. Let me try15:29
*** ash2307 has joined #openstack-nova15:29
*** macz has quit IRC15:30
*** ash2307 has left #openstack-nova15:30
*** macz has joined #openstack-nova15:31
melwittbelmoreira: hm, looking at the code, it should still work if you have workarounds/enable_consoleauth = True in stein. I see in nova/compute/api.py it still stores the token console auth in nova-consoleauth in addition to in the cell database. so I can't see why it wouldn't work yet15:32
belmoreiramelwitt from the consoleauth I only get: Checking Token: ***, False15:33
belmoreiramelwitt from nova-novncproxy: https://www.codepile.net/pile/O1P8ee1q15:34
melwittbelmoreira: did you set workarounds/enable_consoleauth = True on hosts where nova-api and nova-novncproxy runs?15:34
stephenfinbelmoreira: Maybe it's just me, but I don't see anything in that codepile link15:35
*** tbachman has joined #openstack-nova15:38
belmoreiramelwitt workarounds/enable_consoleauth it's also for the nova-api? I'm only running it in the vnc nodes15:38
melwittbelmoreira: you need it for nova-api to tell it to store token auth in nova-consoleauth service15:38
melwittand you need it for nonvcproxy to tell it to look in nova-consoleauth to find token auths when validating15:39
melwittso you need both15:39
belmoreirathat will be easy to change. Let me do it15:39
openstackgerritMerged openstack/nova master: Track libvirt host/domain capabilities for multiple machine types  https://review.opendev.org/67315115:41
openstackgerritMerged openstack/nova master: Extract new base class for provider usage functional tests  https://review.opendev.org/67696415:41
*** macz has quit IRC15:43
*** tbachman has quit IRC15:47
*** lpetrut has quit IRC15:48
*** tbachman has joined #openstack-nova15:49
*** dave-mccowan has joined #openstack-nova15:49
*** gyee has joined #openstack-nova15:50
efriedmriedem: clarkb suggested trying to repro the innodb thing with a post that copies database logs.15:53
efriedI'm trying to hack up a patch to do that, but there's at least three things about it that I don't understand.15:53
*** pvradu has quit IRC15:53
*** dave-mccowan has quit IRC15:55
openstackgerritAdam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported  https://review.opendev.org/63868015:56
openstackgerritStephen Finucane proposed openstack/nova master: claims: Remove useless caching  https://review.opendev.org/67179115:56
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Rename exception argument  https://review.opendev.org/67179515:56
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'hardware.get_host_numa_usage_from_instance'  https://review.opendev.org/67179715:56
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'hardware.host_topology_and_format_from_host'  https://review.opendev.org/67179815:56
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'hardware.instance_topology_from_instance'  https://review.opendev.org/67179915:56
openstackgerritStephen Finucane proposed openstack/nova master: Rework 'hardware.numa_usage_from_instances'  https://review.opendev.org/67256515:56
openstackgerritStephen Finucane proposed openstack/nova master: tests: Split NUMA object tests  https://review.opendev.org/67233615:56
openstackgerritStephen Finucane proposed openstack/nova master: scheduler: Flatten 'ResourceRequest.from_extra_specs', 'from_image_props'  https://review.opendev.org/67489415:56
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions  https://review.opendev.org/53741415:56
openstackgerritStephen Finucane proposed openstack/nova master: Add '[compute] cpu_dedicated_set' option  https://review.opendev.org/67179215:56
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement  https://review.opendev.org/67179315:56
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available'  https://review.opendev.org/67269315:56
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Rewrap definitions of 'NUMACell'  https://review.opendev.org/67439515:56
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs  https://review.opendev.org/67180015:56
openstackgerritStephen Finucane proposed openstack/nova master: objects: Rename 'fields' import to 'obj_fields'  https://review.opendev.org/67410315:56
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait  https://review.opendev.org/67557115:56
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'hw:cpu_policy', 'hw:mem_page_size' extra specs from API samples  https://review.opendev.org/67533815:56
openstackgerritStephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta  https://review.opendev.org/67180115:56
stephenfinefried: Yeah, trivial to rebase15:57
efriednice, thanks stephenfin15:57
* stephenfin goes to re-learn how to do online migrations15:57
openstackgerritAdam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection  https://review.opendev.org/63633415:57
openstackgerritAdam Spiers proposed openstack/nova master: Add <launchSecurity> and <driver iommu='on' /> to config.py  https://review.opendev.org/63631815:57
openstackgerritAdam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required  https://review.opendev.org/64456515:58
openstackgerritAdam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption  https://review.opendev.org/66661615:58
*** jmlowe has quit IRC15:59
efriedmriedem: Any idea what this [1] would look like if I wanted to copy "the database logs" ?16:00
efried[1] https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/playbooks/infra-puppet-apply/post.yaml16:00
*** ociuhandu has quit IRC16:00
*** ricolin_ has joined #openstack-nova16:01
*** shilpasd has quit IRC16:02
*** tbachman has quit IRC16:04
*** ricolin has quit IRC16:04
*** tbachman has joined #openstack-nova16:04
*** ricolin_ is now known as ricolin16:05
*** ociuhandu has joined #openstack-nova16:05
openstackgerritmelanie witt proposed openstack/nova master: Handle websockify v0.9.0 in console proxy  https://review.opendev.org/67785616:06
mriedemefried: i know devstack based jobs copy the mysqldb logs16:06
mriedemwell they used to anyway16:06
openstackgerritEric Fried proposed openstack/nova master: DNM: Try to repro bug 1823251 with mysql logs  https://review.opendev.org/67805116:08
openstackbug 1823251 in OpenStack Compute (nova) "Spike in TestNovaMigrationsMySQL.test_walk_versions/test_innodb_tables failures since April 1 2019 on limestone-regionone" [High,Confirmed] https://launchpad.net/bugs/182325116:08
mriedemefried: i'd guess it's a matter of adding a post-run play to collect the db logs https://github.com/openstack/nova/blob/master/playbooks/legacy/nova-lvm/post.yaml16:08
mriedemlike ^16:08
mriedemwhich i think runs after some other tempest/devstack post task copies things to /logs16:08
mriedemwhere the sqlite lots are stored, idk - or does this only fail in mysql?16:09
mriedemdevstack-gate for legacy jobs would save off the mysql logs here https://github.com/openstack/devstack-gate/blob/9459f44cb5f604b84ca6b5642b89d7aeceae9f35/functions.sh#L66716:09
*** ociuhandu has quit IRC16:11
mriedemso we need a play that copies those to devstack_log_dir16:11
mriedem$devstack_log_dir16:11
*** ricolin has quit IRC16:11
*** ricolin has joined #openstack-nova16:11
mriedemok i see something in devstack-base16:12
mriedemhttps://github.com/openstack/devstack/blob/master/.zuul.yaml#L24316:12
mriedemthough that must not be working b/c i'm not seeing mysql logs in tempest job output16:12
openstackgerritEric Fried proposed openstack/nova master: DNM: Try to repro bug 1823251 with mysql logs  https://review.opendev.org/67805116:12
openstackbug 1823251 in OpenStack Compute (nova) "Spike in TestNovaMigrationsMySQL.test_walk_versions/test_innodb_tables failures since April 1 2019 on limestone-regionone" [High,Confirmed] https://launchpad.net/bugs/182325116:12
*** altlogbot_2 has quit IRC16:14
efriedmriedem: trying there --^16:14
efriedif you can see immediate problems, please lmk.16:14
belmoreiramelwitt I get the same result. Doesn't work16:14
*** mdbooth has quit IRC16:15
melwittbelmoreira: and you tried a fresh vnc console for an instance? it won't work for the already existing ones16:15
*** altlogbot_3 has joined #openstack-nova16:15
belmoreiramelwitt fresh16:15
sean-k-mooneystephenfin: before i forget yes the comment you left in the toplogy api patch make sense to me16:16
stephenfin(y)16:16
*** xek has quit IRC16:17
belmoreiramelwitt can you see the trace? https://www.codepile.net/pile/pVkj75Ll16:18
*** morgan is now known as kmalloc16:19
mriedemefried: looks like by default mysql doesn't enable logging16:19
mriedemhttps://dev.mysql.com/doc/refman/5.7/en/server-logs.html16:19
mriedemso that's probably why we don't get them in the devstack job16:19
belmoreiramelwitt but is going to the nova-consoleauth because nova-consoleauth also fails to verify the token16:20
melwittbelmoreira: yeah. actually, that's showing it not falling back to nova-consoleauth. it's failing the database-based validation (expected). but with CONF.workarounds.enable_consoleauth = True it should fall back. checking the code again...16:20
efriedmriedem: iiuc this bug happens on unit tests, not devstacks; is there something we need to do to enable logging there?16:20
mriedemefried: it's not devstack, but the unit test jobs setup mysql and postgresql for opportunistic db testing for the schema migrations16:20
melwittbelmoreira: you see it going to nova-consoleauth too? I'm missing it in the trace16:21
mriedemthat's what nova/tools/test-setup.sh is for16:21
mriedemefried: so likely just means we need to configure mysql for logging in that script16:21
belmoreiramelwitt I see the consoleauth log: Checking Token: a86d2dcb-a8e3-4fa6-b707-92ae1243c96f, False16:22
melwittoh, I see yeah. sorry. I got it backward, with enable_consoleauth = True it will try nova-consoleauth first and then fall back to the database16:23
belmoreiraand actually I see the token being sent to the nova-consoleauth: Received Token: ***16:24
efriedmriedem: sorry if I'm getting lost here; are you telling me my patch right now won't actually have anything to copy unless we do something to that test-setup.sh?16:24
mriedemefried: we can see, but i think so16:24
mriedemfrom what i've been reading16:24
mriedemand seeing in the devstack jobs16:24
mriedemor not seeing really16:24
mriedemdevstack jobs will attempt to copy /var/log/mysql.log/.err but i don't see those in devstack job logs that get published,16:25
mriedemand the mysql docs say logging is not enabled by deafult16:25
mriedem*default16:25
mriedemso that's probably why i'm not seeing anything published16:25
belmoreiramelwitt can you point me to this code?16:25
melwittbelmoreira: yeah... so this implies the original get_vnc_console call isn't storing the auth in nova-consoleauth. but it should be as long as you've set enable_consoleauth = True on the nova-api configs...16:25
melwittyes. one sec16:25
melwittbelmoreira: https://github.com/openstack/nova/blob/stable/stein/nova/compute/api.py#L3948-L396416:26
melwittthat's what stores the token auth in nova-consoleauth when enabled16:26
melwittand you already the other side working, the console proxy is looking there16:27
melwittso something is missing about the nova-api side16:27
*** rpittau is now known as rpittau|afk16:28
efriedstephenfin: Would you please hit https://review.opendev.org/#/c/677856/ again before you leave?16:29
belmoreiramelwitt thanks a lot for your help16:29
* stephenfin clicks16:29
belmoreiramelwitt what was really missing in my side was enable_consoleauth = True in the nova-api16:29
stephenfinYup, done16:30
efriedmriedem: would you mind making that edit, since you seem to have at least some idea how that would be done? I'm flying blind here.16:30
efriedOr did you want to wait until this one finishes and verify that the logs are absent?16:30
belmoreiraafter that I see nova-consoleauth getting the token16:30
efriedthanks stephenfin16:30
melwittbelmoreira: yeah, but you said you added that and restarted the nova-api's right? and it's still not working?16:30
belmoreiramelwiit but it was falling... and the log in the nonvc was confusing16:30
belmoreiramelwitt the issue was memcache for some reason needed a restart16:31
belmoreiramelwitt it's working \o/ Thanks a lot again16:31
*** panda is now known as panda|out16:31
melwittbelmoreira: oh, weird. I don't understand why that would be needed but relieved it's working now16:32
belmoreiraI will add "enable_consoleauth = True" into my prod apis. This will give more time to better decide how to setup this per cell16:33
belmoreiramelwitt the main issue that I see for this new setup is because I have a lot of cells and we allow vnc console access from outside world. With this means that I will need to have an "ingress" to match the vnc url to the correct server.16:35
melwittbelmoreira: good call. just please be sure to get the per cell setup worked out before Train because all of the workaround stuff gets removed at that time. so you will want the per cell setup working in Stein *before* you upgrade to Train16:36
belmoreiramelwitt that's why I'm using vnc as a central service16:36
belmoreiramelwitt thanks a lotn again. This gives me some time to properly plan. I didn't follow all this refactor done in the vnc16:37
melwittbelmoreira: yeah... well, the key thing is the proxies need access to the cell databases. so if you can set that up in a way without having to give ingress to your cell controllers (if you made them separate maybe?) then there are some options. maybe talk to mnaser to see how he does it16:39
*** ivve has joined #openstack-nova16:39
*** dtantsur is now known as dtantsur|afk16:39
melwittbelmoreira: you're not alone. this has been a troublesome one :( maybe there is yet more I need to add to the documentation16:40
*** ociuhandu has joined #openstack-nova16:41
mriedemefried: "Or did you want to wait until this one finishes and verify that the logs are absent?" let's go with that16:42
efriedack, thx16:43
mriedemit's 11:43 and i feel like i haven't really settled into being productive today16:43
*** N3l1x has joined #openstack-nova16:43
efriedit's like being PTL all over again, eh?16:44
efriedMaybe doing PTL stuff felt productive to you16:44
mriedemi wasn't doing "ptl stuff" most days16:44
sean-k-mooneydo we still need n-cauth? just noticed its enabled in some of the tempest jobs16:45
mriedemsean-k-mooney: we should'nt no16:45
mriedemhell i thought stephenfin had patches to remove it in train16:45
sean-k-mooneyok ya he did16:45
mnaserim pretty sure i saw it removed16:46
sean-k-mooneyoh never mind i was looking at a stable run16:46
mriedemzoinks16:46
*** ociuhandu has quit IRC16:46
sean-k-mooneyi was looking at a stable/rocky log master is correct16:48
openstackgerritMatt Riedemann proposed openstack/nova master: docs: pretty up return code table or heal_allocations  https://review.opendev.org/67806316:53
*** belmoreira has quit IRC16:54
*** psachin has joined #openstack-nova16:55
openstackgerritEric Fried proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get  https://review.opendev.org/64289916:55
openstackgerritEric Fried proposed openstack/nova master: Use SDK for node.list  https://review.opendev.org/65602716:55
openstackgerritEric Fried proposed openstack/nova master: Use SDK for validating instance and node  https://review.opendev.org/65602816:55
openstackgerritEric Fried proposed openstack/nova master: Use SDK for setting instance id  https://review.opendev.org/65969016:55
openstackgerritEric Fried proposed openstack/nova master: Use SDK for add/remove instance info from node  https://review.opendev.org/65969116:55
openstackgerritEric Fried proposed openstack/nova master: Use SDK for getting network metadata from node  https://review.opendev.org/67021316:55
*** markvoelker has quit IRC16:57
openstackgerritMatt Riedemann proposed openstack/nova master: doc: pretty up return code table for sync_aggregates  https://review.opendev.org/67806416:57
*** markvoelker has joined #openstack-nova17:00
openstackgerritBalazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth  https://review.opendev.org/67698017:00
*** bnemec has quit IRC17:00
mriedemlyarwood: if you're back, can you hit these stein backports when you get a chance? https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/stein+topic:bug/1839560 - regressoin since rocky for baremetal nodes so would be good to get those in17:01
openstackgerritBalazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request  https://review.opendev.org/67149717:02
*** jmlowe has joined #openstack-nova17:05
*** hemna has quit IRC17:07
stephenfindansmith, mriedem: When a compute node record is deleted, can it ever come back?17:09
dansmithwellllll17:09
dansmithabout that...17:09
dansmithstephenfin: last week? no.. this week? yes17:10
dansmithhttps://review.opendev.org/#/c/675496/17:10
stephenfindansmith: We should probably remove the deleted check from this online migration, in that case? https://github.com/openstack/nova/blob/master/nova/objects/compute_node.py#L50417:11
melwittdoes anyone know how/where notifications are logged?17:11
dansmithstephenfin: no17:11
*** psachin is now known as psachin|away17:12
dansmithstephenfin: you don't want to count deleted nodes for anything until/unless they're undeleted17:12
dansmithand we'll do all the migratory behavior when we resurrect and then subsequently save it17:12
sean-k-mooneymelwitt: i guess its proably depned on what is sending them. i would expect to see some notifiaciotn logs in n-cpu17:12
stephenfindoesn't that mean we need to keep that online migration around forever then?17:12
sean-k-mooneye.g. if the compute service is emmiting vm lifecycle notifications17:13
dansmithstephenfin: no, because we do the migration activity upon resurrection17:13
melwittsean-k-mooney: yeah, I don't know where or how they are logged. there's a CONF.notifications.default_level for the log level but I don't see it used anywhere in nova code17:13
melwittand I can't find what logs the notifications or what format they're in17:13
*** tesseract has quit IRC17:13
dansmithstephenfin: if we ever want to remove *that* behavior we'll need a blocker type migration17:14
stephenfingotcha17:14
* stephenfin duplicates check for the numa_topology migration17:14
*** ash2307 has joined #openstack-nova17:14
sean-k-mooneymelwitt: its unlikely but the only other place that would make sense would be the conductor17:14
*** igordc has quit IRC17:15
sean-k-mooneybut it feel inefficnet to need to send them form the conductor so i doubt we would do that17:15
sean-k-mooneymelwitt: are you trying to find the ones used by nova join17:16
melwittI'm trying to find the ones anywhere in nova17:16
*** panda|out has quit IRC17:16
melwittI don't see how or where they are logged17:16
melwittlooks like the only use of CONF.notifications.default_level was removed here https://github.com/openstack/nova/commit/9f48aee9b0ea68f7c8eba6a1f3d076e4194d804d#diff-2f33aae68e09a2fe816870ac389cfe9517:20
melwittI'm guessing that decorator somehow logged things?17:20
*** panda has joined #openstack-nova17:20
melwittI dunno17:20
sean-k-mooneymelwitt: maybe this https://github.com/openstack/nova/blob/master/nova/rpc.py#L42017:21
melwittmriedem: do you know if we intentionally stopped logging notifications in rocky? commit linked above ^17:23
melwittsean-k-mooney: that looks like some kind of error condition. not general log of any notification17:23
dansmithdid we ever log them?17:23
dansmiththey'd be spread all over the place if we did17:23
melwittbased on the existence of the CONF.notifications.default_level option we did17:24
melwittyeah17:24
melwittbut the option is no longer used anywhere after that commit17:24
melwittso I wonder if that decorator used to result in logging somehow. I don't know how it worked17:24
dansmithisn't that level something about which notifcations we emit, not the log level?17:25
dansmith"Default notification level for outgoing notifications."17:26
melwittI dunno, sounds like a log level https://github.com/openstack/nova/blob/master/nova/conf/notifications.py#L51-L5717:26
melwittbut yeah, I guess it could have meant that notifications used to be categorized and you could prune down which to emit?17:27
dansmithright, like only emit started/stopped type things and not progress-related ones17:27
dansmithor "I checked on a thing" ones17:27
dansmithI could definitely be wrong17:27
sean-k-mooneymelwitt: we have some failutre logs here https://github.com/openstack/nova/blob/master/nova/notifications/base.py#L134-L13917:27
melwittmaybe we never logged notifications. guh, I don't know17:27
dansmithI didn't really think we did, tbh17:27
melwittsean-k-mooney: yeah, I know we have failure logs17:28
*** psachin|away has quit IRC17:32
*** psachin has joined #openstack-nova17:33
*** igordc has joined #openstack-nova17:34
mriedemmelwitt: we do'nt log notificatoins17:40
mriedemlike dan said, that's not a log level17:41
mriedemeach event has a level associated with it17:41
mriedemwhy? what customer is saying they had notifications logged?17:42
mriedemnote - you can configure oslo.messaging to just log notifications17:42
mriedemthat's not a nova thing, that's an oslo thing17:42
melwittthanks. fyi, the default_level option is no longer used anywhere so that might be a bug? but unrelated to what I was looking for17:42
*** ociuhandu has joined #openstack-nova17:42
mriedemhttps://docs.openstack.org/oslo.messaging/latest/configuration/opts.html#oslo_messaging_notifications.driver17:43
mriedem[oslo_messaging_notifications]/driver=log17:43
melwittmriedem: no, we're trying to debug something and trying to verify that nova is sending notifications. and were looking for a clue about how to tell if it is17:43
melwittthanks17:43
mriedembtw, gibi's last summit talk about versioned notifications (which i think you're in the video) has some nice stuff about configuring and testing notificaoins out to see them17:44
mriedemhttps://www.openstack.org/videos/summits/denver-2019/nova-versioned-notifications-the-result-of-a-3-year-journey17:44
mriedemoh let me guess - something something heat isn't getting notifications17:45
mriedemmaybe the customer flipped on versioned notifications only and heat only listens for unversioned17:45
melwittnovajoin, the vendordata service17:45
melwittso yeah, pretty much17:45
melwittyeah, we checked and both are set to use unversioned so it's not something obvious17:46
*** ociuhandu has quit IRC17:47
melwitthaha, indeed I attended that talk. I'll look at that again17:47
*** psachin has quit IRC17:50
melwittlooks like something is afoot with the driver setting, it's set to 'noop' which seems bad :(17:51
melwittgood thing you pointed that out, I had forgotten about it17:52
melwitt[oslo_messaging_notifications]/driver17:52
*** ralonsoh has quit IRC17:54
*** macz has joined #openstack-nova17:54
*** tbachman has quit IRC17:55
efriedsean-k-mooney: were you one who was vocal about what "privsep stage 3" should look like?17:59
efriednm, I see you're already on the cyborg privsep review, which is where this was going.18:03
*** tbachman has joined #openstack-nova18:08
*** tbachman has quit IRC18:11
*** irclogbot_1 has quit IRC18:14
*** irclogbot_0 has joined #openstack-nova18:15
melwittlooks like there was a recent change to tripleo to disable notification drivers when telemetry is disabled, so this deploy got caught up in that18:16
melwittthanks again for the hint about the [oslo_messaging_notifications]/driver setting. mriedem++18:17
*** maciejjozefczyk has quit IRC18:17
mriedemworked?18:23
melwittthey haven't tried yet with driver=messagingv2 but I'm sure this is the issue18:24
mriedemah yeah18:24
melwittthere was an assumption that only telemetry needed the notifications and since it's disabled, it set driver=noop to avoid needless notification traffic,18:25
melwittbut novajoin is in the mix here too and needs the notifications to work18:25
mriedemsilly tripleo18:28
mriedemi thought heat also consumed nova notifications, or maybe that's indirectly via ceilometer?18:28
mriedembut yeah lots of projects listen to nova notifications besides those, you've also got designate, watcher, blazar, etc - though maybe tripleo doesn't support those18:28
*** altlogbot_3 has quit IRC18:29
*** edleafe has quit IRC18:29
melwittyeah, this is the undercloud and that confuses me, but maybe that's why18:29
melwittI think notifications are always on in the overcloud18:29
melwittin order for other things to work, I assume we have some other service that needs them18:29
mriedemoh yeah, forgot about the cloud turducken18:30
melwittyeah18:30
mriedemwell i suppose it always feels good to come back and say, "this isn't a nova problem, it's a tripleo problem"18:30
melwittheh, indeed18:31
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions  https://review.opendev.org/53741418:31
openstackgerritStephen Finucane proposed openstack/nova master: Add '[compute] cpu_dedicated_set' option  https://review.opendev.org/67179218:31
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement  https://review.opendev.org/67179318:31
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available'  https://review.opendev.org/67269318:31
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Rewrap definitions of 'NUMACell'  https://review.opendev.org/67439518:31
openstackgerritStephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs  https://review.opendev.org/67180018:31
openstackgerritStephen Finucane proposed openstack/nova master: objects: Rename 'fields' import to 'obj_fields'  https://review.opendev.org/67410318:31
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait  https://review.opendev.org/67557118:31
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'hw:cpu_policy', 'hw:mem_page_size' extra specs from API samples  https://review.opendev.org/67533818:31
openstackgerritStephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta  https://review.opendev.org/67180118:31
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Fold in argument to '_update_provider_tree_for_vgpu'  https://review.opendev.org/67672918:31
openstackgerritStephen Finucane proposed openstack/nova master: Add reshaper for PCPU  https://review.opendev.org/67489518:31
*** bnemec has joined #openstack-nova18:34
*** edleafe has joined #openstack-nova18:35
openstackgerritEric Fried proposed openstack/nova master: Add docstring to check_availability_zone function  https://review.opendev.org/67785818:38
mriedemanyone else have an opinion about nova migration-list with --migration-type or just --type in https://review.opendev.org/#/c/675117/ ?18:40
*** jbernard has quit IRC18:43
*** jbernard has joined #openstack-nova18:43
*** factor has quit IRC18:51
*** factor has joined #openstack-nova18:52
*** spsurya has quit IRC18:52
*** factor has quit IRC18:54
*** factor has joined #openstack-nova18:54
efriedmriedem: sans click, I would say --migration-type just because --type is so generic.18:59
*** ricolin has quit IRC18:59
*** factor has quit IRC19:01
artommriedem, make it --kind-of-migration and watch the comments pour in19:02
*** tbachman has joined #openstack-nova19:03
mriedem--migration-flavour?19:04
artomPoints for the UK spelling :D19:05
artom(aka the *correct* spelling. Yours truly, a Canadian)19:06
*** bbowen_ has joined #openstack-nova19:06
artom(except when I feel like being Quebecois or Russian - yay absence of national identity!)19:06
*** bbowen has quit IRC19:08
efriedmriedem: I left helpful comments on https://review.opendev.org/#/c/678051/19:14
mriedemartom: how would you do it in old russ?19:20
*** boxiang has quit IRC19:20
artomGather 'round a bottle of vodka (or two) and let the solution emerge by itself19:20
mriedemefried: you might need:19:22
mriedembecome: yes19:22
*** boxiang has joined #openstack-nova19:23
*** panda has quit IRC19:23
artommriedem, FWIW, I'd say just --type, because 'migration' is already explicitly implied (ha!) in the command19:24
mriedemthe devstack tasks that use synchronize all have some form of "become: true" for sudo19:24
artomIn (server-)list and flavor-list, we don't repeat the thing we're list in the args19:24
artomSo it's just flavor-list --extra-specs, not flavor-list --flavor-extra-specs19:25
melwittI don't know if it's just me but I didn't understand which option dtroyer was for in his comment19:25
artomBut I agree that --type is trickier, because it's more vague on its own than something like --extra-specs19:25
*** jrosser has joined #openstack-nova19:29
mriedemmelwitt: dean was saying since nova uses --*-type as a convention be consistent in nova cli19:29
*** panda has joined #openstack-nova19:29
mriedemosc uses --type for the most part19:29
mriedemsince context is derived from the command you're using19:30
melwittdoes a nova osc command count as 'nova cli'?19:30
mriedemso since nova cli uses --key-type, --console-type and --backup-type, use --migration-type19:30
mriedemno19:30
mriedemosc is osc19:30
melwitthaha ok, that's what I was thinking19:30
*** ozzzo has joined #openstack-nova19:35
*** gbarros has quit IRC19:36
melwittoh, geez, I didn't realize that change was for python-novaclient. ugh19:37
melwittI thought it was for osc 'openstack server' command19:37
melwittyeah I agree stay consistent with other python-novaclient things19:38
efriedmriedem: it looks like logging is enabled by default?19:39
openstackgerritEric Fried proposed openstack/nova master: DNM: Try to repro bug 1823251 with mysql logs  https://review.opendev.org/67805119:41
openstackbug 1823251 in OpenStack Compute (nova) "Spike in TestNovaMigrationsMySQL.test_walk_versions/test_innodb_tables failures since April 1 2019 on limestone-regionone" [High,Confirmed] https://launchpad.net/bugs/182325119:41
mnasersean-k-mooney: do you happen to know if you're able to backport the os-vif bug to stable/stein ?19:41
efriedmriedem: if it's writing to "the console"... is that the same console that tests are being run in?19:42
mriedemefried: no,19:44
mriedemlikely the journal?19:44
mriedemi.e. mysql systemd journal log19:44
mriedemif i had a devstack handy i'd poke at this but i don't19:44
mriedemefried: if this were an IMM or VIOS, wwyd?!19:45
efriedmriedem: How destructive is the poking? I have one you can jump on19:45
openstackgerritJonathan Rosser proposed openstack/os-vif stable/stein: only disable mac ageing for ovs hybrid plug  https://review.opendev.org/67809819:46
efriedI don't know what IMM is. If it were VIOS I would phone a friend.19:47
efriedThe problem is that I have basically no understanding of the chain of events that's leading to mysqld running and/or being used in this environment.19:47
mnasersean-k-mooney: jrosser has backported the os-vif issue which fixes deployments letting vms see other vms traffic :)19:48
mriedemintegrated management module19:49
mriedemlike the CMM in a bladecenter19:49
mriedemDOY19:50
mriedemwhere is dansmith when i need him for ibm jokes19:50
mriedemefried: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/test-setup is the role for hitting the test-setup script in the unit test jobs19:51
efriedby the time we run tools/test-setup.sh, mysqld is already running, right?19:51
*** tbachman has quit IRC19:51
mriedemhas to be19:51
mriedemsince we're issuing commands against it19:51
efriedso whatever we're doing we need to do well before that19:52
efriedunless it's possible to restart mysqld from that script, is that what you were suggesting above?19:52
*** bbowen_ has quit IRC19:52
*** tbachman has joined #openstack-nova19:53
melwittmnaser: isn't that a pretty serious security issue? looked in the bug and it didn't look treated as such19:56
openstackgerritMerged openstack/nova master: Remove deprecated [neutron]/url option  https://review.opendev.org/67775519:57
*** adriant has quit IRC19:57
mriedemefried: the mysql docs seem to suggest you can change logging config at runtime and flush the settings20:01
mriedembut w/o an env to play with idk20:01
mriedemefried: otherwise yeah i'd think you could restart from within the script just by doing: sudo systemctl restart mysqld20:01
efriedI'm looking at a default-y devstack and /var/log/mysql has files in it20:05
*** tbachman_ has joined #openstack-nova20:05
*** nweinber__ has quit IRC20:05
*** davee_ has quit IRC20:07
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Fail compute service delete if resource provider delete fails  https://review.opendev.org/67810020:07
*** tbachman has quit IRC20:07
*** tbachman_ is now known as tbachman20:07
mriedemefried: huh yeah i guess my devstack patch works20:08
mriedemhttps://ccb62560c9b6fbee62ac-3bdb45e74ea7431452edb68e5fcaf6be.ssl.cf5.rackcdn.com/678053/1/check/neutron-tempest-linuxbridge/d0d8b63/controller/logs/mysql/20:08
mriedemhttps://review.opendev.org/#/c/678053/20:09
mriedemmaybe the ubuntu packages changed where the log files go?20:09
mriedemsince...trusty?20:09
efriedmriedem: Presumably that ^ will just work for dsvm jobs anyway since by default tox jobs don't copy *any* logs?20:11
openstackgerritMerged openstack/nova master: Limit get_sdk_adapter to requested service type  https://review.opendev.org/67467820:13
openstackgerritMerged openstack/nova master: Add a hacking rule for useless assertions  https://review.opendev.org/67761020:13
openstackgerritMerged openstack/nova master: doc: remove confusing docs about aggregate allocation ratios  https://review.opendev.org/67747220:13
*** tbachman has quit IRC20:14
*** markvoelker has quit IRC20:16
mnasermelwitt: it is a very serious secuity issue20:28
mnaserwith linuxbridge, a vm can see traffic to other vms20:28
melwittok. argh, so by default we get no OSSA handling with it because of the way os-vif project is tagged? feels like we need to fix that (I don't know how)20:29
melwittI commented on the lp bug20:29
*** markvoelker has joined #openstack-nova20:30
*** tbachman has joined #openstack-nova20:34
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Find instance in another cell during floating IP re-association  https://review.opendev.org/65659420:36
mriedemefried: tox jobs copy logs, like the tox logs and testr results20:36
*** boxiang has quit IRC20:37
*** boxiang has joined #openstack-nova20:38
openstackgerritMichael Still proposed openstack/nova master: Remove zVM requirement from the top level requirements.  https://review.opendev.org/67787020:42
*** ociuhandu has joined #openstack-nova21:03
*** nweinber__ has joined #openstack-nova21:05
*** tbachman has quit IRC21:06
mriedemdansmith: i looked at mdbooths thing here https://review.opendev.org/#/c/677736/ and it seems sane, just some nits and such, and maybe some unnecessary test code21:06
mriedemguess we're just waiting on a customer feedback21:06
openstackgerritMerged openstack/nova master: Update docstring of 'revert_resize' function  https://review.opendev.org/66597621:07
*** ociuhandu has quit IRC21:08
jrossermnaser: melwitt i can already see that this is failing https://review.opendev.org/#/c/678098/21:21
openstackgerritArtom Lifshitz proposed openstack/nova master: Introduce live_migration_claim()  https://review.opendev.org/63566921:21
openstackgerritArtom Lifshitz proposed openstack/nova master: New objects for NUMA live migration  https://review.opendev.org/63482721:21
openstackgerritArtom Lifshitz proposed openstack/nova master: LM: add support for augmenting migrate_data with info from claims  https://review.opendev.org/63482821:21
openstackgerritArtom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source  https://review.opendev.org/63522921:21
openstackgerritArtom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration  https://review.opendev.org/63460521:21
openstackgerritArtom Lifshitz proposed openstack/nova master: NUMA live migration support  https://review.opendev.org/63460621:21
openstackgerritArtom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration  https://review.opendev.org/64002121:21
openstackgerritArtom Lifshitz proposed openstack/nova master: [WIP] Functional test for NUMA live migration  https://review.opendev.org/67259521:21
melwittjrosser: hm, yeah I see it too. will probably need sean-k-mooney help to fix21:23
jrosserwhilst the cherry-pick was trivial, i'm not really familiar with the code and imminent PTO means someone else really needs to take a look21:23
artomdansmith, ^^ finally have something21:23
melwittjrosser: ack. sean-k-mooney or I or someone can get it into shape while you're away21:23
artomI posted a note in the middle that only the patches below it have had feedback addressed21:24
*** tbachman has joined #openstack-nova21:24
artomBut I wanted to let CI do its thing21:24
jrossermelwitt: excellent thankyou - we have some anxious folk on the OSA side with stein deploys affected by this21:24
* artom -> home21:25
melwittjrosser: understood. this is bad for everyone, will want to fix asap21:25
openstackgerritMerged openstack/nova master: Address nits from privsep series  https://review.opendev.org/67721021:27
*** artom has quit IRC21:29
*** tbachman has quit IRC21:31
*** markvoelker has quit IRC21:35
*** mmethot has quit IRC21:37
*** BjoernT_ has quit IRC21:40
melwittfun, I just learned that the reverts_task_state decorator tries to update the resource tracker and if that fails (e.g. libvirtd stopped), it blows up and prevents further decorators from running, namely wrap_instance_fault21:41
melwittso then we get no server fault in the instance21:41
*** nweinber__ has quit IRC21:48
mriedemefried: sean-k-mooney: alex_xu: dansmith (in absentia): i've replied on the vpmem persistence ML thread, enjoy21:52
mriedemi can't say i read all of sean-k-mooney's legalize reply21:52
mriedemi got to like bullet 4-a-ii and my head exploded21:52
efriedagreed21:53
mriedemwith that i need to get the hell outside for awhile21:53
*** mriedem is now known as mriedem_away21:54
sean-k-mooneythanks and ya sorry my reply were a bit dense on info21:58
*** munimeha1 has quit IRC21:59
sean-k-mooneymelwitt: i can take a look and fix up the backport22:01
openstackgerritEric Fried proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get  https://review.opendev.org/64289922:01
openstackgerritEric Fried proposed openstack/nova master: Use SDK for node.list  https://review.opendev.org/65602722:01
openstackgerritEric Fried proposed openstack/nova master: Use SDK for validating instance and node  https://review.opendev.org/65602822:01
melwittsean-k-mooney: thanks!22:01
openstackgerritEric Fried proposed openstack/nova master: Use SDK for setting instance id  https://review.opendev.org/65969022:01
openstackgerritEric Fried proposed openstack/nova master: Use SDK for add/remove instance info from node  https://review.opendev.org/65969122:01
openstackgerritEric Fried proposed openstack/nova master: Use SDK for getting network metadata from node  https://review.opendev.org/67021322:01
*** bnemec has quit IRC22:03
sean-k-mooneymelwitt: im pretty sure that add is missing here https://github.com/openstack/os-vif/blob/stable/stein/os_vif/internal/command/ip/__init__.py22:03
sean-k-mooneywe remove a layer of indirection in train22:04
sean-k-mooneyso ther is 1 addtion plays we need to add the parmater in stien22:04
melwittyou mean it does not accept a ageing kwarg?22:04
melwittoh22:04
sean-k-mooneycorrect it does not currently the patch that was backported did not have to update that file because we removed it in master22:05
sean-k-mooneymelwitt: mnaser in attion to adding the aging parmater to 1 more location i will need to update the functional test or backport a second patch22:19
sean-k-mooneybut yes we shoudl be able to make this work22:19
dansmithmriedem_away: I assume by "outside" you mean either (a) out in super mario world or (b) three feet from your door to plant something22:20
*** markvoelker has joined #openstack-nova22:21
melwittsuper mario world?22:21
dansmithmelwitt: i.e. some video game as opposed to actually going outside22:23
melwitthaha, ok. that's an old super nintendo game22:24
sean-k-mooneyit is a good game. unfortunetly i dont have my snes anymore. i do have a saga meadrive with sonic plug into by tv22:24
melwittI didn't know mriedem_away is a SNES person22:25
*** markvoelker has quit IRC22:25
melwittI liked it ok but not a huge fan of super mario. I prefer rpgs22:25
sean-k-mooney... tries not to feel old for having fond memories of snes and sage games22:25
*** ivve has quit IRC22:26
melwittI <3 snes22:27
openstackgerritsean mooney proposed openstack/os-vif stable/stein: only disable mac ageing for ovs hybrid plug  https://review.opendev.org/67809822:28
sean-k-mooneythe againg parmater was jsut missing in that one spot after all22:28
sean-k-mooneybut now i need to fiture out why i was getting test failures on rhel822:29
*** mmethot has joined #openstack-nova22:29
dansmithmelwitt: yeah, I know.. mriedem_away likes snes, which is why I chose it22:29
*** mmethot has quit IRC22:34
*** tbachman has joined #openstack-nova22:35
*** TxGirlGeek has joined #openstack-nova22:35
*** markvoelker has joined #openstack-nova22:41
sean-k-mooneyefried: if you have the link to the cyborg privsep patch that would be useful i have several cyborg patches added to my review queue and i did comment on there use of privsep i think in the past bug i cant recall which one it was22:45
sean-k-mooneyefried: ah its https://review.opendev.org/#/c/673957/22:47
sean-k-mooneyi was added to it but i have not reviewd it yet ill take a look tomorow.22:48
sean-k-mooney"This code is modelled strongly on how nova and cinder[0] has chosen22:48
sean-k-mooneyto use privsep.22:48
sean-k-mooney"22:48
sean-k-mooney^ that is not a good start.22:49
*** markvoelker has quit IRC22:51
*** rcernin has joined #openstack-nova22:55
*** nweinber__ has joined #openstack-nova22:57
*** rcernin is now known as rcernin|brb23:00
*** igordc has quit IRC23:02
*** igordc has joined #openstack-nova23:02
*** tkajinam has joined #openstack-nova23:03
*** macz has quit IRC23:07
*** rcernin|brb has quit IRC23:09
*** rcernin has joined #openstack-nova23:10
*** nweinber__ has quit IRC23:11
*** takashin has joined #openstack-nova23:33
*** eharney has quit IRC23:36
openstackgerritMerged openstack/nova master: Handle websockify v0.9.0 in console proxy  https://review.opendev.org/67785623:49
*** igordc has quit IRC23:57
*** owalsh|away has quit IRC23:57
*** ricolin has joined #openstack-nova23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!