Friday, 2019-09-06

*** derekh has quit IRC00:08
*** derekh has joined #openstack-nova00:08
*** gyee has quit IRC00:10
*** mlavalle has quit IRC00:29
*** avolkov has quit IRC00:34
*** artom has quit IRC00:38
*** ricolin has joined #openstack-nova00:43
brinzhangamotoki: What do you mean https://review.opendev.org/#/c/673485/3/novaclient/v2/shell.py@2609 ?00:45
amotokibrinzhang: sorry, I looked some wrong line when scrolling the review... I will add a comment.00:46
brinzhangas mriedem said, this patch do the ``nova volume-attach`` CLI, not server create00:46
brinzhangamotoki: np00:46
brinzhangamotoki: And I want to keep the option delete-on-termination in novaclient with '--delete-on-termination', but I am not sure use this in OSC is fine?00:48
brinzhangamotoki: As sain in PS3, how about add enable/disable befor the 'delete-on-termination', what do you think?00:49
amotokibrinzhang: sounds good for --delete-on-termination.00:49
brinzhangamotoki: I will keep --delete-on-termination in novaclient.00:50
amotokibrinzhang: if we need an option to specify 'delete_on_termination=False', I see several options: (a) --delete-on-termination / --no-delete-on-termination (b) --enable-delete-on-termination/--disable-delete-on-termination (c) --delete-on-termination / --keep-on-termination00:51
*** markvoelker has joined #openstack-nova00:51
amotokibrinzhang: thought?00:52
brinzhangamotoki: I tend to (b) --enable-delete-on-termination/--disable-delete-on-termination00:53
brinzhangamotoki: I will rebase the novaclient patch, could please review the OSC patch, and you can leave that comment in it? Or after I rebased it. https://review.opendev.org/#/c/673725/6 ^^00:54
*** markvoelker has quit IRC00:56
*** brinzhang_ has joined #openstack-nova00:57
amotokibrinzhang: sure.00:57
amotokibrinzhang: btw, is there any compute API ref corresponding to this?00:58
*** brinzhang has quit IRC01:00
brinzhang_amotoki: is this what dou you want?https://docs.openstack.org/api-ref/compute/#attach-a-volume-to-an-instance01:01
amotokibrinzhang_: but I cannot find information on delete_on_termination.01:02
brinzhang_amotoki: this field in this compute API is new, after https://review.opendev.org/#/c/673133/ is merged, you can look at it.01:04
amotokibrinzhang_: thanks. It would help me when reviewing CLI patch.01:04
brinzhang_amotoki: but in create server API in request body(block_device_mapping_v2.delete_on_termination (Optional)) has this field, you can reference https://docs.openstack.org/api-ref/compute/?expanded=create-server-detail#create-server01:05
amotokibrinzhang_: mainly I would like to check the default value of the option.01:06
openstackgerritAkira KAMIO proposed openstack/nova master: VMware: disk_io_limits settings are not reflected when resize  https://review.opendev.org/68029601:08
gmannamotoki: this one - https://review.opendev.org/#/c/673133/16/nova/api/openstack/compute/volumes.py L34201:08
amotokigmann: thanks.01:10
*** slaweq has joined #openstack-nova01:11
*** slaweq has quit IRC01:16
*** spsurya has joined #openstack-nova01:27
*** BjoernT has joined #openstack-nova01:36
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Microversion 2.79: Add delete_on_termination to volume-attach API  https://review.opendev.org/67348501:37
openstackgerritMerged openstack/nova master: Handle VirtDriverNotReady in _cleanup_running_deleted_instances  https://review.opendev.org/67947301:39
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Microversion 2.79: Add delete_on_termination to volume-attach API  https://review.opendev.org/67348501:41
*** hongbin has joined #openstack-nova02:13
*** derekh has quit IRC02:29
*** derekh has joined #openstack-nova02:29
*** dave-mccowan has quit IRC02:38
*** gbarros has joined #openstack-nova02:39
*** tinwood has quit IRC02:49
*** tinwood has joined #openstack-nova02:50
*** larainema has joined #openstack-nova03:01
openstackgerritAkihiro Motoki proposed openstack/nova master: PDF documentation build  https://review.opendev.org/67673003:06
*** slaweq has joined #openstack-nova03:11
*** slaweq has quit IRC03:16
*** slaweq has joined #openstack-nova03:32
*** mvkr has joined #openstack-nova03:34
*** gbarros has quit IRC03:45
*** BjoernT has quit IRC03:57
*** nicolasbock has quit IRC03:58
*** yedongcan has joined #openstack-nova04:02
*** derekh has quit IRC04:02
*** derekh has joined #openstack-nova04:03
*** igordc has joined #openstack-nova04:10
*** etp has joined #openstack-nova04:17
*** igordc has quit IRC04:23
*** jaosorior has quit IRC04:34
*** jaosorior has joined #openstack-nova04:34
*** hongbin has quit IRC04:35
*** HagunKim has joined #openstack-nova04:39
*** Luzi has joined #openstack-nova04:52
*** shilpasd has joined #openstack-nova04:53
*** shilpasd has quit IRC04:57
*** ileixe has left #openstack-nova05:05
*** mkrai has joined #openstack-nova05:08
*** markvoelker has joined #openstack-nova05:15
*** markvoelker has quit IRC05:20
*** pcaruana has joined #openstack-nova05:25
*** ratailor has joined #openstack-nova05:43
*** etp has quit IRC05:47
*** lpetrut has joined #openstack-nova05:49
*** jaosorior has quit IRC05:49
*** jaosorior has joined #openstack-nova05:51
*** udesale has joined #openstack-nova05:54
*** yedongcan has quit IRC05:54
*** etp has joined #openstack-nova05:55
*** maciejjozefczyk has joined #openstack-nova05:55
*** itlinux has joined #openstack-nova06:00
*** markvoelker has joined #openstack-nova06:06
openstackgerritMichael Davies proposed openstack/os-traits master: Add support for ppc64le platforms  https://review.opendev.org/68058006:10
*** markvoelker has quit IRC06:10
*** brinzhang_ has quit IRC06:14
*** brinzhang_ has joined #openstack-nova06:15
*** brinzhang_ has quit IRC06:16
*** lpetrut has quit IRC06:16
*** etp has quit IRC06:16
*** lpetrut has joined #openstack-nova06:16
*** etp has joined #openstack-nova06:16
openstackgerritya.wang proposed openstack/nova master: vCPU model selection  https://review.opendev.org/67029806:31
openstackgerritya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags  https://review.opendev.org/67029906:31
openstackgerritya.wang proposed openstack/nova master: Support reporting multi CPU model traits  https://review.opendev.org/67030006:31
*** markvoelker has joined #openstack-nova06:36
*** jawad_axd has joined #openstack-nova06:38
*** ildikov has joined #openstack-nova06:40
*** markvoelker has quit IRC06:41
*** trident has quit IRC06:53
*** trident has joined #openstack-nova07:04
*** markvoelker has joined #openstack-nova07:06
*** brault has joined #openstack-nova07:07
*** itlinux has quit IRC07:09
*** threestrands has quit IRC07:10
*** rcernin|brb has quit IRC07:10
*** tesseract has joined #openstack-nova07:11
*** luksky has joined #openstack-nova07:11
*** markvoelker has quit IRC07:11
*** ccamacho has joined #openstack-nova07:13
gibibauzas: hi! I'm about the start changing the bottom of the bw series https://review.opendev.org/#/c/656422 Yesterday we agreed with mriedem that the bottom can be fixed in a follow up, so if you are about to +A that patch then I will go with the followup. If not then I go and fix the patch itself instead07:14
bauzasgibi: yup, I was reviewing and I saw matt's comments07:14
bauzasgibi: as you want07:14
bauzasgibi: I'm not done with reviewing your bottom change but I'm absolutely not opposed to a followup07:15
gibibauzas: then please continue reviewing it and I do a follow up07:15
bauzascool07:15
gibibauzas: and thank you :)07:15
bauzas(on a train with limited connection but whatever :) )07:15
* bauzas 's getting audited for his first visa application and is afraid :)07:16
*** markvoelker has joined #openstack-nova07:16
* gibi is about to file that visa application today07:16
gibifun times07:16
cervignios summit?07:16
gibiyepp07:17
*** brinzhang has joined #openstack-nova07:17
cervignioh god... I will procrastinate that until 2 weeks before07:17
bauzasyeah07:17
bauzasI need to provide my fingerprints07:17
cervigniI don't even know if taking my laptop or not07:17
bauzashence me traveling to the closest consulate place07:17
cervignireally?07:17
bauzasyeah, even my passport is biometrical07:18
bauzasand already having my 10 fingerprints07:18
cervigniis this country dependant or not?07:18
cervigniI don't think I have a Chinese consulate here07:18
bauzasbut you basically need to go to a visa app center that'll retain your passport by the time it'll take them to check your application07:18
cervigniWHAT?07:19
cervignihahaha07:19
cervigniRETAIN your passport?07:19
bauzasfor Lyon, France, the average delay is 8 working days07:19
bauzascorrect07:19
cervigniI don't want anyone to "retain" my passport07:19
cervigniI cannot be legally here without my passport07:19
gibithat sounds pretty bad. I thought in Hungary I only need to send a photocopy of my passport07:19
bauzascervigni: https://visaforchina.org07:19
cervigni"org"07:20
cervignihaha07:20
bauzasgibi: you don't need to be present yourself ?07:20
cervigniwow nice website07:20
cervigniis this an official website?07:20
gibibauzas: it seems the travell agencyt can make it work without mee07:20
*** markvoelker has quit IRC07:20
bauzasgibi: you can pay a TA07:20
gibimy employer pays for it (i hope)07:20
bauzasgibi: but for us, it will still mean that we have to physically move to an appointment to get our fingerprints taken07:21
bauzasgibi: me too07:21
cervigniare we on the F category?07:21
cervignior M ?07:21
gibithis information is still missing for me, I trust the TA07:21
bauzascervigni: some asked for F but were said it should be a M07:21
bauzasgibi: just check the website above07:21
cervigniyeah, I don't think we are though commerce and trade07:22
bauzasgibi: if they don't tell you to physically attend an appointment, then cool07:22
bauzascervigni: I should be able to tell you in 3 hours -ish07:22
bauzasI filed a M07:22
cervigniok, could you write it in a PM?07:22
cervignihere gmt+807:22
bauzassure07:23
cervignimany thanks07:23
gibibauzas: there is not even a service center in hungary based on that page. But we have a consulate07:23
gibianyhow good luck bauzas07:23
cervignion that website from Australia it seems there is no fingerprint requirements07:24
cervignithough I am italian so it is very confusing07:24
bauzasgibi: good luck for you too then07:25
bauzasgibi: that's probably why it's a good idea for you to follow a TA :)07:25
gibibauzas: yepp. I saw it working. One of my collague went to China last year07:25
gibisuccessfully :)07:26
bauzascervigni: I guess you have to look at the closest service center in Australia07:26
bauzasthey should be able to give you instructions07:26
cervigniYeah I check and thanks god there is one in Perth07:26
bauzaseven if you're not Aussie07:26
cervigniWill do that... or I will just forget to come to the os summit and wait for the next one07:27
cervigniI don't think I will give my fingerprints to the chinese governament for any reasons07:27
bauzasoh dear god, I paid for a 1st class train which *has* power plugs but which are dysfunctional07:27
cervigniI already give them allto the Australian one and I was pissed of for a month07:27
cervignibauzas: I guess it is an Italian train07:28
bauzasAlstom, take it as you wish07:28
cervigniI have never found an outlet working in an Italian train07:28
cervignigoing home, good luck with your visas07:29
cervignilet me know how it goes07:29
*** macz has joined #openstack-nova07:31
*** macz has quit IRC07:36
bauzasgibi: +Wd with concerns07:42
bauzasgibi: my understanding is that you'll fail the resize when you wanna migrate/resize from host A to B when B isn't upgraded, right?07:43
*** ralonsoh has joined #openstack-nova07:45
* bauzas drops since the train arrives at destination07:47
bauzasttyl07:47
*** avolkov has joined #openstack-nova07:54
*** ivve has joined #openstack-nova08:01
openstackgerritYongli He proposed openstack/python-novaclient master: Microversion 2.78 - show server topology  https://review.opendev.org/67079008:01
*** macz has joined #openstack-nova08:04
*** pcaruana has quit IRC08:08
kashyapDoes anyone here how to remove an instance that is stuck in 'pre-migrating' (it's the migration status) state?08:12
kashyapI mean, not _remove_ the instance, but more unjamming it from that state.  (Besides some database muckery)08:12
*** ociuhandu has joined #openstack-nova08:13
*** pcaruana has joined #openstack-nova08:13
*** ociuhandu has quit IRC08:18
*** cdent has joined #openstack-nova08:19
yaawangalex_xu: stephenfin Hi, I have updated patches of vCPU models selection, can you review them if you have time :)  https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/cpu-model-selection08:24
*** macz has quit IRC08:27
*** tkajinam has quit IRC08:32
*** trident has quit IRC08:40
*** gbarros has joined #openstack-nova08:40
*** cdent has quit IRC08:44
gibibauzas: thanks. replied.08:46
* gibi was pulled in to a downstream discussion in the mean time08:47
*** trident has joined #openstack-nova08:51
*** zigo has quit IRC08:57
*** zigo has joined #openstack-nova09:02
*** slaweq has quit IRC09:06
aspierskashyap: some trivial changes for you to review: https://review.opendev.org/#/c/680527/09:07
aspiershttps://review.opendev.org/#/c/680526/09:07
kashyapaspiers: Stuck in something urgent; but already have them open.09:08
openstackgerritGuo Jingyu proposed openstack/nova master: Define and catch InstanceAgentNotRunning for set-password failure  https://review.opendev.org/66146609:08
*** markvoelker has joined #openstack-nova09:10
kashyapaspiers: FWIW, ACK to the tests move; nice catch (by "SEV work")09:16
aspierskashyap: thanks!09:17
*** markvoelker has quit IRC09:20
*** cdent has joined #openstack-nova09:25
*** spatel has joined #openstack-nova09:31
openstackgerritMerged openstack/nova master: Add delete_on_termination to volume-attach API  https://review.opendev.org/67313309:31
*** shilpasd has joined #openstack-nova09:33
*** spatel has quit IRC09:35
*** yedongcan has joined #openstack-nova09:35
*** ivve has quit IRC09:36
*** slaweq has joined #openstack-nova09:36
*** dtantsur|afk is now known as dtantsur09:37
*** ivve has joined #openstack-nova09:39
dtantsurmorning folks, we seem to have broken ironic with the recent nova patches09:44
cdentdtantsur: sounds fun09:45
dtantsuras always!09:46
cdentwhen did it stop working?09:50
dtantsurcdent: it's because of https://review.opendev.org/#/c/656027/, a fix is already posted09:51
cdentah09:51
dtantsurefried: and I also wonder why our regular job did not detect ^^09:51
dtantsurmaybe list_instances is not normally hit or is not critical?09:51
cdenti would guess that most of the time individual instances are retrieved09:55
cdentbut that's totally a guess09:55
openstackgerrithulina proposed openstack/nova master: Nova raise exceptions when extending volume fails  https://review.opendev.org/68064810:00
*** artom has joined #openstack-nova10:07
artomstephenfin, sean-k-mooney, can I get your thoughts on a thing?10:09
artomYou know this bit: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4525-L452810:10
artomNormally on a host not intended for NUMA instances, https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4549 will return None because vcpu_pin_set will not be set10:10
stephenfinlooking10:11
stephenfinartom: Yeah, correct10:12
artomIf, however, an instance without a NUMA topology lands on a host with vcpu_pin_set not None, guest.cpuset being not None ends up triggering https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py#L2587-L2590 and we end up pinning guest CPUs that way10:12
artom(via https://libvirt.org/formatdomain.html#elementsCPUAllocation, not our usual vcpupin XML bits)10:13
* bauzas was released from the visa application center10:14
artomDo we care about *that* form of CPU pinning (the one via <vcpu cpuset=blah>) for live migration?10:14
stephenfinartom: um, I think that's correct, yeah10:14
artomTheoretically we should be recalculating it10:14
bauzasnow I'm a bit afraid of my application be rejected because of some coffee traces on my passport :/10:14
stephenfinyup10:14
stephenfinwe should10:14
artomBut... in practice, does it actually happen?10:14
stephenfinohh10:14
stephenfinhmm, I'm not actually sure10:15
*** ricolin has quit IRC10:15
artomWe tell everyone to split NUMA instances into host aggregates10:15
bauzasstephenfin: I also think we should correctly document the weird case you mention in https://review.opendev.org/#/c/680107/310:15
stephenfinI had this written off as being fixed by your series10:15
artomSo a non-NUMA instances landing on a host with vcpu_pin_set is... unlikely?10:15
artomstephenfin, hah, I've just noticed that it's a thing10:15
bauzasstephenfin: because the behaviour will change for those not RTFM'ing10:15
stephenfinbauzas: Nope, it won't change10:15
*** ociuhandu has joined #openstack-nova10:15
stephenfin*Break10:15
stephenfinbauzas: see here10:15
stephenfinbauzas: https://review.opendev.org/#/c/680107/3/nova/compute/manager.py@86110:16
stephenfinI'm only warning10:16
stephenfinNot raising10:16
stephenfinbauzas: For those other two conditionals, not that I'm only checking the _new_ options (cpu_dedicated_set, cpu_shared_set)10:17
bauzassee my comment10:17
stephenfin*note10:17
stephenfinYup. The conditional is here https://review.opendev.org/#/c/680107/3/nova/compute/manager.py@82710:17
openstackgerritLuyao Zhong proposed openstack/nova master: db: Add resources column in instance_extra table  https://review.opendev.org/67844710:17
openstackgerritLuyao Zhong proposed openstack/nova master: object: Introduce Resource and ResourceList objs  https://review.opendev.org/67844810:17
openstackgerritLuyao Zhong proposed openstack/nova master: Add resources dict into _Provider  https://review.opendev.org/67844910:17
openstackgerritLuyao Zhong proposed openstack/nova master: Retrieve the allocations early  https://review.opendev.org/67845010:17
openstackgerritLuyao Zhong proposed openstack/nova master: Claim resources in resource tracker  https://review.opendev.org/67845210:17
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: Enable driver discovering PMEM namespaces  https://review.opendev.org/67845310:17
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree  https://review.opendev.org/67845410:17
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup  https://review.opendev.org/67845510:17
openstackgerritLuyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec  https://review.opendev.org/67845610:17
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces  https://review.opendev.org/67964010:17
openstackgerritLuyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory  https://review.opendev.org/67847010:17
openstackgerritLuyao Zhong proposed openstack/nova master: doc: attaching virtual persistent memory to guests  https://review.opendev.org/68030010:17
stephenfinand I early return here https://review.opendev.org/#/c/680107/3/nova/compute/manager.py@83910:17
stephenfinso lines 841 etc. will only be triggered if the instance has a NUMA topology and that topology has pinning enabled10:18
bauzasoh shit, that's what happen when you review in a crowded Starbucks place10:18
bauzasyou're totally right10:18
stephenfinbauzas: but at least you've mediocre coffee on hand :P10:18
stephenfinIf it's not clear, I can rework to use an if-else10:18
* stephenfin tends to favour early returns since they need less indentation, but maybe they're less clear10:19
*** jawad_axd has quit IRC10:19
*** ociuhandu has quit IRC10:19
openstackgerritMerged openstack/nova master: update allocation in binding profile during migrate  https://review.opendev.org/65642210:20
bauzasstephenfin: nah nah, it's cool10:21
bauzasstephenfin: we could nitpick on getting an extra comment, but meh10:21
bauzasand yeah Starbucks is mediocre, but that's the only place where you can guaranttee both decent wifi coverage and working outlets10:22
stephenfinIn the code or the commit message? I can do the latter in a follow-up10:22
stephenfinYeah, agreed. Costa just isn't the same (and it's UK only)10:23
bauzasI wish I could afford a Regus usage :)10:23
bauzasstephenfin: well, I was thinking of just a comment line in the code itself but that's gross10:23
bauzasnevermind it10:23
bauzasit's just me who can't read coee10:23
bauzascode*10:24
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Microversion 2.79: Add delete_on_termination to volume-attach API  https://review.opendev.org/67348510:24
stephenfin'sall good :D10:24
*** shilpasd has quit IRC10:25
*** ociuhandu has joined #openstack-nova10:29
*** ociuhandu has quit IRC10:30
*** luksky has quit IRC10:36
stephenfinartom: how do you decide to recalculate the '<cpuset>' values on a destination host in your series?10:36
artomstephenfin, I currently don't, at all10:37
sean-k-mooneyyou just always recaluate it right10:37
sean-k-mooneyas part of the claim10:37
*** maciejjozefczyk has quit IRC10:37
artomsean-k-mooney, no, currently it's not handled at all10:37
sean-k-mooneywhich cpuset10:38
artomBut in theory it should happen when https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4525-L452810:38
artomsean-k-mooney, the one in https://libvirt.org/formatdomain.html#elementsCPUAllocation10:38
sean-k-mooneyoh that should be the union of hte cores used for the vcpus10:38
sean-k-mooneyand should be updated10:38
artomIt only matters when an instance without a NUMA topology lands on a host with vcpu_pin10:38
stephenfinalex_xu: You around today? I'm planning to work through the VPMEM series again, but is there any chance you could look at https://review.opendev.org/#/c/671800 ?10:38
sean-k-mooneyartom: yes10:38
artomsean-k-mooney, right, so is that... a real thing?10:39
artomWe tell people to split them by aggregates10:39
sean-k-mooneyyes10:39
stephenfinartom: wait for it10:39
artomThey don't?10:39
sean-k-mooneyyou shoudl set vcpu_pin_set on all host ideally10:39
stephenfin(sean-k-mooney is about to tell you that vcpu_pin_set has nothing to do with pinning and should always be set)10:39
sean-k-mooneyand it will be need for the new stuff stephenfin is working on10:39
artomHaha10:39
sean-k-mooneystephenfin: :)10:39
openstackgerritGorka Eguileor proposed openstack/nova master: Use os-brick locking for volume attach and detach  https://review.opendev.org/61419010:40
stephenfinbut yeah, vcpu_pin_set != pinning (or NUMA, for that matter)10:40
stephenfinwe use it for this stuff10:40
sean-k-mooneyits the set of core that the hypvervior may use for vms10:40
stephenfinand also to decide how much VCPU inventory to report to placement10:40
sean-k-mooneynothing more or less10:40
*** tbachman has quit IRC10:40
sean-k-mooneyyep its used for the inventory in the RT which is used for plamcent10:41
stephenfinI don't agree with it being set by default, but yeah, it being set even when you don't have NUMA or pinning is a thing10:41
artomOK, so it needs to be handled10:41
stephenfinafraid so10:41
sean-k-mooneystephenfin: you realise that for you vcpu work10:41
sean-k-mooneywe shoudl also be handelign shared and dedicated sets10:41
artomsean-k-mooney, I'll most likely as you to test that bit when it's implemented10:42
stephenfinsean-k-mooney: what do you mean?10:42
artomOr if we can set it in the gate and show that working...10:42
sean-k-mooneystephenfin: well for non pinned instance the cpuset will need to be updated based on the dest cpu_shared_set10:42
sean-k-mooneyand for pinned instnce it need to be updated based on the dedicated set10:43
sean-k-mooneyalthough the second half will be done by artoms exisitng code10:43
stephenfinsean-k-mooney: Yeah, correct. That code has been updated here https://review.opendev.org/#/c/671800/28/nova/virt/libvirt/driver.py10:44
openstackgerritLuyao Zhong proposed openstack/nova master: object: Introduce Resource and ResourceList objs  https://review.opendev.org/67844810:44
openstackgerritLuyao Zhong proposed openstack/nova master: Add resources dict into _Provider  https://review.opendev.org/67844910:44
openstackgerritLuyao Zhong proposed openstack/nova master: Retrieve the allocations early  https://review.opendev.org/67845010:44
openstackgerritLuyao Zhong proposed openstack/nova master: Claim resources in resource tracker  https://review.opendev.org/67845210:44
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: Enable driver discovering PMEM namespaces  https://review.opendev.org/67845310:44
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree  https://review.opendev.org/67845410:44
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup  https://review.opendev.org/67845510:44
openstackgerritLuyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec  https://review.opendev.org/67845610:44
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces  https://review.opendev.org/67964010:44
openstackgerritLuyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory  https://review.opendev.org/67847010:44
openstackgerritLuyao Zhong proposed openstack/nova master: doc: attaching virtual persistent memory to guests  https://review.opendev.org/68030010:44
sean-k-mooney by the way people know that cpuset in the vcpu element is funtionally the same as generatin vcpuin elemnt for each core pinning  the core to the set of host core set in vcpu pin set10:46
artomstephenfin, sean-k-mooney, actually, while we're on the topic, I thought you could get CPU pinning with https://libvirt.org/formatdomain.html#elementsCPUTuning without NUMA pinning with https://libvirt.org/formatdomain.html#elementsNUMATuning10:46
artomFor example by using only the cpu_policy=dedicated extra spec10:46
sean-k-mooneyartom: yes you can10:46
sean-k-mooneyno10:46
sean-k-mooneyif you use cpu_policy=dedicated10:47
*** maciejjozefczyk has joined #openstack-nova10:47
sean-k-mooneyyou will have a numa toplogy10:47
sean-k-mooneyif you set vcpu_pin_set on the host10:47
artomBut looking at the code of _get_guets_numa_config, IIUC if it sets vcpupin, it'll also set the memnode stuff10:47
sean-k-mooneyand set nothing on the flavor10:47
sean-k-mooneyyou get  <vcpu placement='static' cpuset="1-4,^3,6" current="1">2</vcpu>10:47
artomsean-k-mooney, right, that's the case with <vcpu cpuset=blah> that I'm not handling10:47
sean-k-mooneyor whatever the vcpu_pin_set is but no numa affinity10:47
artomI was talking about <cputune> without <numatune>10:48
artomIs that possible? Don't think so10:48
sean-k-mooneyoh libvirt allows that but we never generate it10:48
artomAha, ok10:48
artomConfirms what I was seeing in the code, thanks10:48
sean-k-mooneywe only generate the cputune element if you have pinning nebaled which give you a numa toplogy10:49
sean-k-mooneywe do generate numatune without cpu tune i think10:49
sean-k-mooneye.g. if you just enable hugepages but no pinning10:49
sean-k-mooneyor hw:numa_nodes=X10:49
artomsean-k-mooney, you sure? It would happen only if https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4609 doesn't iterate at all10:50
sean-k-mooneywe definitly numa affine hugepages10:50
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree  https://review.opendev.org/67845410:50
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup  https://review.opendev.org/67845510:50
openstackgerritLuyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec  https://review.opendev.org/67845610:50
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces  https://review.opendev.org/67964010:50
openstackgerritLuyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory  https://review.opendev.org/67847010:50
openstackgerritLuyao Zhong proposed openstack/nova master: doc: attaching virtual persistent memory to guests  https://review.opendev.org/68030010:50
sean-k-mooneyim just not sure if we use vcpupin to pin the cores to the numa node or cpuset10:51
artomsean-k-mooney, right, I'm saying in those cases we also affine guest CPUs with cputune10:51
sean-k-mooneyah ok10:51
sean-k-mooneywell as i said cpuset is just a shortcurt for vcpupin10:51
sean-k-mooneylet me give an example10:51
*** ivve has quit IRC10:52
sean-k-mooneythose are the same10:52
sean-k-mooney <vcpu placement='static' cpuset="1-4" current="1">2</vcpu>10:52
sean-k-mooney <cputune>10:52
sean-k-mooney    <vcpupin vcpu="0" cpuset="1-4"/>10:52
sean-k-mooney    <vcpupin vcpu="1" cpuset="1,2,3,4"/>10:52
sean-k-mooney <cputune>10:52
sean-k-mooneylibvirt internally generate the vcpupin element form the cpu set10:52
sean-k-mooneyand generge the same qemu commandline10:53
artomWait a second.10:53
*** shilpasd has joined #openstack-nova10:53
artomMy *entire* code triggers if the instance has a NUMA topology10:53
sean-k-mooneyyes10:53
artomSo the insance with no NUMA topology on a host with vcpu_pin_set case will have to...?10:53
sean-k-mooneyyou will need to add support for it10:54
sean-k-mooneywell you or stepen10:54
*** mkrai has quit IRC10:54
sean-k-mooneytechnically this is a long standing issue10:54
*** mkrai has joined #openstack-nova10:54
sean-k-mooneywe always should have been updating the xml10:54
sean-k-mooneyit will be fixed via a hard reboot however10:54
sean-k-mooneylibvirt will reject the migration if the cores do not exist on the dest10:55
artomRight, true10:55
*** ociuhandu has joined #openstack-nova10:55
artomI'm surprised more people haven't been hitting that10:55
*** ivve has joined #openstack-nova10:55
openstackgerritBrin Zhang proposed openstack/nova master: Follow-up: Add delete_on_termination to volume-attach API  https://review.opendev.org/68065510:55
sean-k-mooneywell the havent be casue we tell peole ot use the same cpu_set on all host in teh same aggreagte/az10:56
stephenfinartom: You wouldn't see an issue if you had the same hardware and the same vcpu_pin_set on all hosts10:56
stephenfinyeah10:56
aspierssean-k-mooney: I've implemented your suggestions from yesterday in https://review.opendev.org/#/c/680065/ and https://review.opendev.org/#/c/644565/10:56
sean-k-mooneyand as i said since its fixed on a hard reboot sicne we dont claim anything and just regenreate it form the config10:56
sean-k-mooneyaspiers: did it fix the import loop?10:57
aspierssean-k-mooney: yes10:57
sean-k-mooney:)10:57
stephenfinsean-k-mooney: Has https://blueprints.launchpad.net/nova/+spec/image-metadata-prefiltering been punted to U?10:57
aspierssean-k-mooney: it worked very nicely as you should see from the comments I just posted10:57
stephenfinIf so, can I kick it out of the runway?10:57
sean-k-mooneystephenfin: so i was suggesting since your code and aspiers keeps breaking it10:57
sean-k-mooneyand no one is revieing it10:57
stephenfinI was, in fairness10:58
sean-k-mooneythat we could kick it out to get your stuff landed instead10:58
aspierssean-k-mooney: I'm hoping SEV is now done10:58
aspiersall feedback should be now addressed, even stephenfin's request for extra API checks10:58
sean-k-mooneystephenfin: well yes but you wer also reviing the sev stuff which keeps breaking it10:58
stephenfinTrue10:59
sean-k-mooneyi had hoped that it would merge before either the cpu or sev stuff starte merging to avoid that10:59
sean-k-mooneyso im ok with punting ot U10:59
sean-k-mooneywe did it internally10:59
*** mkrai has quit IRC10:59
sean-k-mooneyor i can rebase and we can merge it quickly10:59
stephenfinI was going to suggest rebasing on top of cpu-resources and I'd review11:00
stephenfinsince it's small11:00
stephenfinbut just on master could be fine too11:00
sean-k-mooneyerric alredy -2'd it since i said he could11:00
stephenfinthe merge conflicts should be slight11:00
sean-k-mooneyso ill kick it out of the run way11:00
sean-k-mooneystephenfin: they are11:00
aspiersstephenfin: the list of SEV patches got slightly bigger but don't be fooled, it's just 2 trivial extra refactorings plus the API checks you requested11:01
*** spatel has joined #openstack-nova11:01
* aspiers just realised he forgot to add the extra reviews to the runway etherpad :-(11:01
* aspiers updates the etherpad11:01
sean-k-mooneystephenfin: focus on the sev series and your own11:02
aspierssean-k-mooney: hopefully there will be no more major changes to SEV to cause further merge conflicts11:04
sean-k-mooneyaspiers: sev conflict with the cpu series i think11:05
sean-k-mooneybut we should finish the sev seires as soon as we can i think11:05
sean-k-mooneythen push to land the cpu series11:05
aspiers+1 for that ;-)11:05
*** luksky has joined #openstack-nova11:05
*** spatel has quit IRC11:05
aspiersIt's unfortunate that there was a Gerrit issue causing the current Zuul backlog11:06
aspiersBut hopefully it should catch up over the weekend11:06
bauzasaspiers: gtk, then we should avoid asking for respins in case of nits11:14
aspiersbauzas: yes, currently some jobs are in the check queue for >20 hours11:14
gibiaspiers: I think those jobs stuck, as other, newly proposed patches went through11:16
aspiersgibi: hrmm :-( I'll ask on #openstack-infra11:17
aspiersgibi: Which ones do you see going through which are newer? I don't see them11:19
openstackgerritBrin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration  https://review.opendev.org/67399011:19
openstackgerritBrin Zhang proposed openstack/nova master: Add operator user_id/project_id to the migrations  https://review.opendev.org/67941311:19
openstackgerritBrin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id  https://review.opendev.org/67424311:19
gibiaspiers: bauzas approved this couple of hours ago https://review.opendev.org/#/c/656422/11:19
*** brinzhang has quit IRC11:19
gibiaspiers: and it went through the gate since11:20
* bauzas finds it fun to review things around some corner in some crowdy starbucks11:20
bauzasbut the flakey network makes me crazy11:20
bauzasdudes, move out my lawn !11:21
bauzas(and don't take all bandwith for crazy netflix thingies)11:21
aspiersgibi: but the most recent patch set was uploaded yesterday afternoon11:21
aspiersgibi: so I don't think it jumped the queue11:21
gibiaspiers: true, so it can be that the check queue is owercrowded but the gate queue isny11:22
bauzasaspiers: gibi: I haven't paid attention to the status recently11:22
gibiisnt11:22
aspiersgibi: yes exactly that is the case11:22
bauzasaspiers: you know the difference between the gate and check pipelines, right?11:22
aspiersI don't know why they are different resource pools11:22
aspiersbauzas: yes of course11:22
gibicould be that patches sitting in the check queue consuming resouce but now moving forward?11:22
* bauzas looks at the status page then11:23
bauzasoh, freaky11:23
bauzashttp://zuul.openstack.org/status11:23
aspiersbauzas: yes this is what we are talking about :)11:23
bauzashard to see with a flakey connection :)11:24
aspiersThe gate looks fine, but not check11:25
sean-k-mooneygibi: infra were seeing quota issue causing nodepool failures11:25
sean-k-mooneyas a result the queue built up a bit11:25
gibisean-k-mooney: thanks, so we need to be patient11:25
sean-k-mooneyi think they were fixed yesterday evening11:25
sean-k-mooneyyes11:25
sean-k-mooneyit will just take a while11:25
aspiersyup11:26
sean-k-mooneyalthough if it does not wew might need a zuul restart to clear the queue11:26
*** cdent has quit IRC11:32
*** nicolasbock has joined #openstack-nova11:38
*** cdent has joined #openstack-nova11:43
*** johnsom has quit IRC11:53
*** johnsom has joined #openstack-nova11:55
*** bnemec has quit IRC11:55
*** bnemec has joined #openstack-nova11:56
*** etp has quit IRC11:57
openstackgerritShilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter  https://review.opendev.org/67107212:02
openstackgerritShilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata  https://review.opendev.org/67107412:02
openstackgerritShilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates  https://review.opendev.org/67107512:02
openstackgerritShilpa Devharakar proposed openstack/nova master: Docs for isolated aggregates request filter  https://review.opendev.org/66795212:02
*** rcernin|brb has joined #openstack-nova12:03
openstackgerritBalazs Gibizer proposed openstack/nova master: Add min service level check for migrate with bandwidth  https://review.opendev.org/68039412:04
openstackgerritDongcan Ye proposed openstack/nova master: Get pci_devices from _list_devices  https://review.opendev.org/68067412:06
*** tbachman has joined #openstack-nova12:08
*** ratailor has quit IRC12:09
dtantsurefried, dustinc, update: the grenade failure in our CI probably is not caused by the instance_id problem..12:09
*** maciejjozefczyk_ has joined #openstack-nova12:12
*** ociuhandu has quit IRC12:14
*** ociuhandu has joined #openstack-nova12:15
*** tbachman has quit IRC12:15
*** maciejjozefczyk has quit IRC12:16
*** jawad_axd has joined #openstack-nova12:17
*** larainema has quit IRC12:17
*** tbachman has joined #openstack-nova12:17
gibibauzas: if you still have energy then this is the next patch in the bw series. I fixed up mriedem's comments https://review.opendev.org/#/c/68039412:19
*** ociuhandu has quit IRC12:19
*** ociuhandu has joined #openstack-nova12:21
*** spsurya has quit IRC12:26
*** mdbooth has joined #openstack-nova12:29
*** rcernin|brb has quit IRC12:30
*** dave-mccowan has joined #openstack-nova12:30
*** dave-mccowan has quit IRC12:31
*** yedongcan has quit IRC12:32
*** dave-mccowan has joined #openstack-nova12:33
*** dave-mccowan has quit IRC12:38
*** markvoelker has joined #openstack-nova12:45
*** mriedem has joined #openstack-nova12:46
bauzasgibi: heh, sure, I'm now waiting for my train12:49
gibibauzas: meanwhile I found that I left some debug print statement in that patch :/ so I will need to go back and remove them.12:49
bauzasgibi: oh, which one ? did I miss it too ?12:50
bauzasif so, Starbucks, I hate you12:50
gibibauzas: in https://review.opendev.org/68039412:50
gibibauzas: not in the patch you approved12:50
* bauzas whispers12:50
mriedemyonglihe: will you have time to address these comments in https://review.opendev.org/#/c/670790/ today or should someone else do those?12:58
*** BjoernT has joined #openstack-nova13:05
mriedemartom: let me know if you want to talk about any of my comments before you push changes13:12
mdboothmriedem dansmith: Looks like I've got another customer report affected by https://review.opendev.org/#/c/677736/13:14
mdboothAny chance we could merge that?13:14
artommriedem, ack - you saw I noticed a thing we all missed until now? The -1 on the massive patch13:15
*** nweinber_ has joined #openstack-nova13:15
*** jawad_axd has quit IRC13:15
artomNot that hard a fix, but kind of a bitch to only spot it now13:15
mriedemi haven't looked back on responses yet13:15
artommriedem, https://review.opendev.org/#/c/635229/58/nova/virt/libvirt/driver.py@7345 for when you're ready to look13:16
*** jawad_axd has joined #openstack-nova13:16
mriedemyonglihe: also, as i said on that novaclient change, i'd like to see what it actually looks like in the output13:16
mriedemif it's just a bunch of json blobs dumped to the console that's not very useful13:16
mriedemartom: is that because i was asking about guest_cpu_tune and guest_numa_tune being exclusive?13:18
openstackgerritDmitry Tantsur proposed openstack/nova master: Fix incorrect invocation of openstacksdk's baremetal.nodes()  https://review.opendev.org/68068413:18
dtantsurefried, dustinc, mriedem, another issue ^^^13:18
dtantsurthis one probably affects ironic CI as well13:18
artommriedem, yeah, that's what lead me down that path13:18
mriedem\o/13:18
*** eharney has joined #openstack-nova13:18
artommriedem, indeed :)13:18
mriedemmdbooth: i'll follow dansmith's lead on that one13:18
*** jawad_ax_ has joined #openstack-nova13:19
*** nweinber_ has quit IRC13:19
mriedemdustinc: commented13:20
*** nweinber has joined #openstack-nova13:20
*** jawad_a__ has joined #openstack-nova13:21
*** jawad_axd has quit IRC13:21
yonglihemriedem: do you mean put json to release notes? It is definitely json blob.13:23
yonglihehttps://review.opendev.org/#/c/621476/62/doc/api_samples/os-server-topology/v2.78/servers-topology-resp.json13:23
*** jawad_ax_ has quit IRC13:23
dtantsurmriedem: I can try to reproduce my thoughts process in a bug, although it was a bit of guessing initially :) do you still use launchpad?13:23
yonglihemriedem: BTW, I'm afraid i don't have time to do it today, sorry.13:25
*** jawad_a__ has quit IRC13:25
mdboothmriedem: Ack, thanks.13:26
mriedemyonglihe: no i meant i'd like to see what the CLI output looks like13:26
mriedemdtantsur: yeah13:26
dtantsurso old school :)13:26
mriedembest school13:26
mriedemdtantsur: btw how is that we're not seeing issues in ironic CI?13:27
mriedemor is it just because the job is non-voting in nova?13:27
dtantsurmriedem: it has only one node at all. so picking a random node works.13:27
dtantsurour multinode grenade uses several nodes, so it got hard broken on this.13:27
dtantsurI'm writing a bug with explanation.13:27
mriedemok well just a link to a failed instance of one of those jobs with logs would be good in a bug report13:27
mriedemthanks13:27
yonglihemriedem: then i need to running it after this weekend, sorry.13:28
*** macz has joined #openstack-nova13:29
*** macz has quit IRC13:29
*** macz has joined #openstack-nova13:29
mriedemok, maybe sean-k-mooney or stephenfin or artom have a system with servers that have numa topology and they can pull this down and see what it looks like13:30
dtantsurmriedem: https://bugs.launchpad.net/nova/+bug/184305013:30
openstackLaunchpad bug 1843050 in OpenStack Compute (nova) "Regression in the ironic driver: wait_for_active checks a random node" [Undecided,New]13:30
yonglihemriedem: that's so nice.13:31
stephenfinmriedem: This is the patch to expose NUMA topology API change in novaclient?13:31
openstackgerritDmitry Tantsur proposed openstack/nova master: Fix incorrect invocation of openstacksdk's baremetal.nodes()  https://review.opendev.org/68068413:31
mriedemstephenfin: yeah13:31
artommriedem, they could probably pile on to sean-k-mooney's new nfv job13:31
mriedemartom: it's novaclient13:31
mriedemi just want someone to show me a paste13:32
stephenfinSure, I can do that, though to be clear it doesn't need a NUMA-based system13:32
stephenfinwell, a two node+ system13:32
artommriedem, ah, my machine's under my desk at the office, and not responding to ping. Since daughter started school I haven't had a chance to get over there.13:32
mriedemstephenfin: i could probably also just hack it up with the fake data fixtures in novaclient using the api-ref sample from the docs and trigger a failure in shell tests to see the output13:34
mriedemmy goal is to get that change merged so we can also get the 2.79 novaclient change merged, which is much simpler, but is held up on the 2.78 change13:34
mriedemi can ffffart around with that today13:34
stephenfinWhatever suits. I'll take it as an opportunity to redeploy my DevStack node so I'll have something but it'll be a few hours?13:35
*** nweinber has quit IRC13:35
*** nweinber has joined #openstack-nova13:35
mriedemstephenfin: if you want, but it's friday and you've probably got other plates spinning13:35
mriedemdtantsur: do we have an ironic change that depends-on the nova fix to see the multinode grenade job pass with the fix? knowing that even if we do, it could be several hours before it even runs13:36
stephenfinmany plates. much spinning :)13:36
dtantsurmriedem: https://review.opendev.org/#/c/680643/ (depends on both fixes)13:36
mriedemoh i didn't know there were 213:37
mriedemok will get those merged today13:37
dtantsurthx!13:37
*** jawad_axd has joined #openstack-nova13:38
mriedemdtantsur: is this the job we care about? ironic-grenade-dsvm-multinode-multitenant13:41
dtantsurlemme double-check13:41
mriedemthat's the only multinode grenade job i see in zuul on that change13:42
dtantsurmriedem: oh, it seems to be a normal (non-grenade) multinode job: ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode13:42
*** jawad_axd has quit IRC13:42
mriedemack13:43
dtantsuralthough I did see something similar on one or two grenade runs, but they don't seem consistently broken13:43
mriedemmaybe randomly picking the correct node13:43
dtantsuryep13:43
dansmithmriedem: mdbooth decided to talk about some details about that patch downstream, so let me fill you in13:43
dansmithmriedem: there are (suddenly?) two customer cases he thinks are caused by this issue, yet we apparently have no confirmation from either see a problem solved by applying this13:44
dansmithmriedem: one clearly isn't fixed by it, and we don't have logs to show why13:44
alex_xustephenfin: thanks, actually I already go through that patch, I didn't found problem, I'm just waiting for huaqiang to do some manual test, then I will go through all the left patches and +213:45
dansmithmriedem: so while the rationale for making the change seems fairly legit to me, I don't know if (a) that one place was never wrapped for some reason or (b) whether changing that is going to cause other thread interaction or timing-related problems13:45
dansmithmriedem: so I'm not sure what to say... we could just merge it and watch carefully and hope that any negative impact is not in two years when people actually roll to it, as it seems likely to be just an oversight13:46
yonglihemriedem: sorry this is a barrier, i did not bring back my laptop today, and stephenfin, thanks.13:46
dansmithbut it definitely makes me nervous not having any "yes this fixes my problem" confirmation for code that has been around for ten years13:47
*** macz has quit IRC13:47
mriedemdansmith: an oversight that we don't know if it has caused problems until now, though that code hasn't changed in a long time13:47
stephenfinalex_xu: Huzzah. Good to hear (y)13:47
mriedemdansmith: any chance of some weird eventlet patches in these customer environments?13:47
mriedemso it would be rhosp specific?13:47
*** ociuhandu has quit IRC13:47
mriedemor python-libvirt patches, something external to nova?13:48
dansmithmriedem: I doubt it, but if they did and it was related, then they'd have been fixed by this (if that's what you mean)13:48
mriedemalso, if we land this on master, will backports be proposed upstream?13:48
dansmithmriedem: they're probably on newer *libvirt*, but I dunno how often python-libvirt changes13:48
mriedemi think you have to rebuild python-libvirt from whatever version of libvirt binary you're using13:49
mriedemotherwise things get weird13:49
dansmithmriedem: I dunno, ask mdbooth. I would expect he would want to13:49
mriedemi remember we had issues in the past with running libvirt x in the gate jobs but python-libvirt was built against y and reporting y to nova, so we'd try to use features that weren't actually there13:49
dansmithmriedem: right but that's just because the bindings are auto-generated I think13:49
mriedemok, so i'm less comfortable with backporting a thing that we're not sure fixes the issue13:50
mriedemit's one thing to land on master and let it simmer until people get to it,13:50
mriedemthan to backport it and force it on people with otherwise stable environments13:50
dansmithalthough we are right before FF, so not as much runway13:50
mriedemrh probably just cares that it's merged on master and can backport internally is less of an issue yeah?13:51
mriedemmerge conflict risk on stable branches and such i know13:51
dansmithmaybe we could get efried to comment on the risk, and maybe cdent on the actual eventlet bits?13:51
dansmithI'm not sure what context cdent has on eventlet, but it seems like sometimes he has a lot13:51
cdenthello what?13:51
cdentwhich thing?13:51
mriedemefried isn't a stable branch maintainer though, or you just mean risk for FF?13:51
dansmithmriedem: I mean for merging to master right now or in general yeah13:52
mriedemcdent: https://review.opendev.org/#/c/677736/13:52
* cdent reads13:52
mriedemcdent: tl;dr old ass code,13:52
mriedemsuddenly 2 rhosp customers are seeing weird issues which mdbooth thinks are related to libvirt + python + eventlet,13:52
dansmith(I wish I was working on things that *have* to merge by FF right now)13:52
mriedembut there isn't a clear indication that patch fixes those problems13:52
openstackgerritAdam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption  https://review.opendev.org/66661613:52
aspiersstephenfin: Your doc feedback should be addressed now ^^^13:53
dansmithmriedem: I see no indication that it fixes those problems.. I think the only indication is that it "seems wrong" and "these tests pass"13:53
mriedemsure, so ruling it out i guess13:53
*** ratailor has joined #openstack-nova13:53
mriedemi also need to investigate these fixes that are blocking the ironic gate atm13:53
mriedemsince i'm guessing ironic would like to merge code before FF13:54
aspiersstephenfin: https://review.opendev.org/#/c/666616/47..48/nova/conf/libvirt.py13:54
donnydsean-k-mooney: Is the NUMA job still throwing errors?13:54
*** mlavalle has joined #openstack-nova13:54
aspiersstephenfin: BTW I've checked that the rst all renders OK13:54
sean-k-mooneydonnyd: i have not re run it13:54
sean-k-mooneywith the queue thats in the gate i was going to wiat until the weekend13:55
sean-k-mooneydonnyd: i can kick it off now if you like and see13:55
donnydsure13:55
* cdent reads the code13:55
*** udesale has quit IRC13:56
*** udesale has joined #openstack-nova13:57
sean-k-mooneydonnyd: there is a build stitting in the experimental pipeline now13:58
sean-k-mooneydonnyd: ill let you know how it goes13:58
donnydkk13:58
donnydwhere can i check its status?13:58
sean-k-mooneyhttp://zuul.openstack.org/status13:58
sean-k-mooneyfilter by 67965613:58
sean-k-mooneycurrently all jobs are queued13:59
openstackgerritAdam Spiers proposed openstack/nova master: Reject live migration and suspend on SEV guests  https://review.opendev.org/68015813:59
*** Luzi has quit IRC13:59
luyaodansmith, efried: I updated the patch for 'resource' object, many thanks for your detailed comments. It helps me a lot. https://review.opendev.org/#/c/678448/1714:00
cdentmriedem, dansmith : I'd be inclined to think that the non-proxy original code was wrong and the fix is good and we've tended to get lucky. However, without any clear proof that presenting problem(s) is fixed by the change...hard to say. I would think merge to master and watch wouldn't be a bad thing.14:00
sean-k-mooneyi proably should have kicked off one of the later patces to run less tests14:00
sean-k-mooneybut i did want that to report back in anycase14:00
aspiersmriedem: thanks for feedback; addressed - https://review.opendev.org/#/c/680158/4..5/nova/compute/api.py14:00
openstackgerritAdam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption  https://review.opendev.org/66661614:01
alex_xuanyone can tell me...can we boot instance without allocation14:01
sean-k-mooneyam we should be able to start them. but create new instances no14:02
sean-k-mooneye.g. you deleted the allocation in placmenet for an instance nova should still be able to start/stop the vm14:02
dansmithcdent: specifically one customer clearly *still* has the problem after applying this patch14:03
cdentah14:03
cdentwell14:03
dansmithcdent: but I agree that it *seems* like the change we'd want to make, I'd just like confirmation that it does something positive you know :)14:03
alex_xusean-k-mooney: probably we can before https://github.com/openstack/nova/blob/master/nova/tests/functional/test_nova_manage.py#L40514:04
cdentis there concrete evidence it is stuck in eventlet, or just that it is stuck?14:04
*** lbragstad has quit IRC14:04
dansmithcdent: there's some guru meditation that makes it look like it, but we don't get to control when that happens and thus it's pretty likely to always be blocking on some C call on a busy system I think14:05
artommriedem, FWIW, I've done an inital read-through of all your comments, and they all make sense, so I should have answers/fixes later today14:05
alex_xusean-k-mooney: that functional test ensure we can boot instance without allocation, but the goal is testing the heal_allocations.14:06
*** ociuhandu has joined #openstack-nova14:06
cdentdansmith: terrific! Does it happen often? Therapuetic process kills to the rescue?14:06
*** lbragstad has joined #openstack-nova14:07
dansmithyeah, just nuke the compute service I think14:07
dansmithand sometimes they can't reproduce it, like when we got on a call to watch :)14:07
dansmithwhat's strange to me is that this code has been in place for ages and suddenly there are two customers hitting it simultaneously, but not fixed by this patch14:07
*** markvoelker has quit IRC14:07
dansmithjust makes me highly skeptical :)14:07
cdentyeah. eventlet, libc, libvirt changes all possible contributors14:08
melwittdoes anyone know anything about the nova.task_log table? we have customers whose nova.task_log table grows indefinitely and I found there's no methods for ever deleting task_log entries. does anyone know what people usually do about this? manually truncate the task_log table? what are these records for? is arbitrary truncation safe?14:10
mriedemdtantsur: dustinc: efried: what do you think about these comments? https://review.opendev.org/#/c/680684/214:10
mriedemthe fix is fine, but wondering about the 'this shouldn't happen' case14:10
dtantsurwill check in a few minutes14:13
dtantsuryeah, I was also unsure whether to log or to raise14:13
mriedemalex_xu: with the caching scheduler yes it was possible to create an instance with no allocations in placement,14:15
mriedembecause the caching scheduler didn't use placement or GET /allocatoin_candidates14:15
mriedemthe caching scheduler was removed in stein,14:15
mriedembut you can still load up out of tree scheduler drivers that may not use placement14:15
mriedemalex_xu: coincidentally, see https://review.opendev.org/#/c/680521/14:15
cdentmriedem: that mention of logging reminds me of something I wanted to ask about: In python 2, when using oslo_log and LOG.error it includes whatever the most recent exception was, even if it is out of scope. In pytyhon3 sys.exc_info() "expires" sooner, more predictably. This means that error messages in the scheduler report client often include bogus tails in the message14:16
cdentdo we care? or can we just ignore python2 soon enough?14:16
mriedemcdent: i think i know what you're talking about, and melwitt/dhellmann had made some fixes to oslo.log to squash that weirdness, but maybe that was only for warning level logs,14:18
mriedeme.g. you'd see a stacktrace for a ComputeNodeNotFound_Remote warning even though you weren't using exc_info=True on LOG.warning,14:18
cdentit's warning and worse where oslo_log does the inspection exc_info14:18
mriedemsomething like that14:18
melwittoh yeah, good memory14:18
* melwitt gets a link14:19
melwitthttps://review.opendev.org/52803614:19
mriedemmelwitt: i'm pretty sure task log is related to https://docs.openstack.org/api-ref/compute/#server-usage-audit-log-os-instance-usage-audit-log which is related to ceilometer which no one uses14:19
mriedemi'd like to burn out all of that code14:19
melwittthanks. I was surprised in all my time working on nova, I've never heard of the task_log table before now14:20
melwittso I'd support burning the code that no one uses if indeed no one uses it14:21
efrieddtantsur: I looked briefly at the ironic CI job to see why it didn't hit that bug; I think it's just because those methods are used in the course of specific operations that tempest doesn't cover. We should add that, for sure. I'm not completely sure how to get started with that though.14:21
dtantsuryeah14:21
dtantsurthe 2nd bug is hit when you have >1 nodes14:21
mriedemrackspace probably had internal scripts or something to purge task log14:21
mriedemmelwitt: well clearly your customer is using it14:22
cdentthanks melwitt, I think that corresponds to something I was looking at when poking at the problem, but doesn't address the issue with the exception name being included in the log even though it was "elsewhere". I'm inclined to ignore it if nobody is complaining, since it gets better with python3. I only noticed becasue somebody asked why there was a "NotImplemted" at the end of rp generation conflict message14:22
melwittmriedem: oh, you think table grow means they are using the audit APIs? I had assumed task_log entries get added regardless (like on any instance action)14:22
openstackgerritDmitry Tantsur proposed openstack/nova master: Fix incorrect invocation of openstacksdk's baremetal.nodes()  https://review.opendev.org/68068414:22
dtantsurmriedem: better ^^?14:22
*** ociuhandu has quit IRC14:23
alex_xumriedem: I'm talking to luyao, we should stop the instance booting if there is no allocation, since vgpu and vpmem should depend on allocation14:23
melwittI need to check14:23
mriedemmelwitt: it's a periodic task in the compute service which you have to enable, and it's disabled by default14:23
mriedemso if they have task log table entries they are configured to run that task14:23
melwittoh, dang14:23
mriedemhttps://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.instance_usage_audit14:23
mriedemand they are probably using ceilometer to hit that compute api14:23
mriedemif they aren't, then they should disable the task and purge the db14:24
melwittthanks. I shouldn't have assumed14:24
mriedemplease see topic new contributor :P14:24
melwitt:(14:24
mriedemalex_xu: yeah that's probably fine, there is no real contract on support for out of tree scheduler drivers14:25
*** macz has joined #openstack-nova14:25
mriedemalex_xu: see https://opendev.org/openstack/nova/src/branch/master/nova/scheduler/driver.py#L3514:25
*** brault has quit IRC14:27
efrieddansmith: risk on https://review.opendev.org/#/c/677736/ I really have no idea I'm afraid. If cdent thinks it's okay to merge-and-watch, that's good enough for me. Remember FF is FF so we have a little bit of time before the release to flush out issues; so I don't think current proximity to FF is a reason to block it.14:27
dansmithefried: ack14:28
*** cdent has quit IRC14:28
mriedemdansmith: before artom moves forward with this rpc/object change in the numa lm series https://review.opendev.org/#/c/634827/57//COMMIT_MSG@12 might want to see if you are on board14:33
mriedemi'm basically asking that we're consistent in the flags saying both source and dest are ready for action14:33
alex_xumriedem: i see now, thanks14:33
dansmithmriedem: ack looking14:34
artommriedem, actually yeah, thanks. I think it should be fine, but dansmith's lack of veto would boost confidence14:34
dansmithartom: mriedem you're thinking set that field on the dest using the same can-do-numa thing in rpcapi? because without that, the only way to know is to pass a new param and have it *not* show up at the other end14:35
dansmithwe resolved that first, and then artom added the can-do check to rpcapi for the source, who has nobody to call14:35
dansmithso if you're saying make the source and dest both call that, and set their corresponding field, yeah I guess that's okay14:35
artomdansmith, not quite - I'm saying the dest doesn't need to actually send RPC 5.3, so check_can_live_migrate_source doesn't need that numa_live_migraiton flag, the dest can just shove it in migrate_data14:37
aspiersJust asked in #openstack-qa but figured worth asking here too: Is it considered good/bad practice for tempest tests to check the message string of nova exceptions returned by assertRaises?14:38
dansmithartom: but the dest needs to support the 5.3 inbound call, but you're saying actually report the conductor side? meaning the did-i-get-the-migration-from-conductor flag?14:38
*** jaosorior has quit IRC14:38
aspiersI'm thinking that if we wanted to reword an exception's message string, this could break tempest, and then you'd need a circular Depends-On across repos to fix it14:38
artomdansmith, right, the dest needs to receive 5.3 - specifically migration and limits form the conductor14:39
artomSo if gets those, it can set the flag inside migrate_data14:39
dansmithartom: and the new drop call14:39
dansmithfrom source14:39
artomdansmith, yeah14:39
artomNo, not from source14:39
artomThe source still needs to send 5.314:39
openstackgerritMatt Riedemann proposed openstack/nova master: Fix incorrect invocation of openstacksdk's baremetal.nodes()  https://review.opendev.org/68068414:39
mriedemdtantsur: +2 now ^14:39
mriedemefried:  ^14:39
dansmithartom: the source calls the new drop-claim against the dest right?14:39
artomdansmith, yeah14:40
artomSo if the dest sets the flag in migrate_data, these things could happen on the source:14:40
dansmithartom: that's what I mean by inbound 5.314:40
*** mtreinish has joined #openstack-nova14:40
dansmithanyway, yeah I think that's okay14:40
mriedemaspiers: error messages in the api aren't a contract14:41
mriedemonly error codes like placement uses, but nova doesn't14:41
mriedemdansmith: yeah basically remove the numa_live_migration flag that goes from dest to source and instead put that as an attribute in migrate_data instead14:42
efrieddustinc: I'm merging https://review.opendev.org/#/c/680684/ but please have a look at it when you get in.14:42
mriedemfor consistency14:42
artomdansmith, right, dest needs to receive 5.314:42
artomBut nothing needs to actually send it14:42
aspiersmriedem: OK thanks, so I'll just check for HTTPBadRequest and leave it there14:42
efriedmriedem, dtantsur: +A14:42
artomSo if it sets the flag in migrate_data, we know it's the new code that can receive 5.314:42
artomAnd then on the source:14:42
artomEither it's old code and that flag gets dropped by the conductor14:42
dansmithmriedem: right I was just confirming how we calculate that because right now the flag making it through the dest's rpcapi to the source is the sentinel14:42
artomEither it's new code but pinned, in which case the can_send check will fail14:43
artomOr it's new code unpinned, and we proceed with the NUMA LM14:43
mriedemdansmith: yup14:44
mriedemi didn't want to start a pattern of putting random feature flags on those compute rpc api methods, like sev=True, vpmems=True, suchandsuch=True14:44
*** sapd1_x has joined #openstack-nova14:45
dansmithmriedem: yeah, but we needed it to figure out if the dest could *send* 5.3, but that's actually not a thing we need to know14:45
dansmithand now we have that can-do method to tell us without actually trying to make the call14:46
artomdansmith, that's the thing, I don't think dest actually needs to send 5.314:46
artomThe changes are all in objects14:46
artomFrom its POV14:46
dansmithartom: no it doesn't, I'm agreeing14:48
dansmithartom: I think we just kinda munged the "does it support" with "is it configured to allow sending" ... 5.3 when we first discussed it14:48
artomdansmith, yep14:48
dansmithif we were adding new calls on both sides, they'd both need to be configured for 5.3, but in this case, we can cheat14:48
artomdansmith, ack, looks like we're all on the same page, I'll continue down that route and with the rest of mriedem's feedback after the bug call14:50
dansmithcool14:51
*** markvoelker has joined #openstack-nova14:51
mriedemstephenfin: alex_xu: yonglihe: on that topology cli change, this is wrong, correct? https://review.opendev.org/#/c/670790/7/doc/source/cli/nova.rst@366314:52
mriedemcompute:server:topology:host:index is admin-only by default and used to expose host fields14:53
*** jawad_axd has joined #openstack-nova14:53
*** jawad_axd has quit IRC14:53
mriedemhttps://review.opendev.org/#/c/621476/62/nova/api/openstack/compute/server_topology.py@5814:54
mriedemyeah looks like it14:54
*** ociuhandu has joined #openstack-nova14:54
*** markvoelker has quit IRC14:55
donnydsean-k-mooney: looks like we are still getting a node failure14:56
stephenfinlooking14:58
*** ociuhandu has quit IRC14:59
openstackgerritBalazs Gibizer proposed openstack/nova master: Add min service level check for migrate with bandwidth  https://review.opendev.org/68039414:59
stephenfinmriedem: Yup, good catch15:01
mriedemefried: i'm +2 on the other ironic fix https://review.opendev.org/#/c/680542/ but we can wait until the test patch passes https://review.opendev.org/#/c/680643/ - given the state of the gate that might be sometime this weekend though, so maybe you want to +2 and one of us can approve once we have results?15:01
sean-k-mooneydonnyd: it might be because its requesting two vms getting one and timeing out getting the second?15:01
mriedemactually that ironic patch already got test nodes, it must be nice to not be nova15:02
efriedmriedem: I was thinking along the same lines. But iiuc dtantsur followed up later and said the grenade fix wasn't actually related to this bug. We (still) don't have CI coverage that will hit it. I just proposed https://review.opendev.org/680718 in tripleo which will hopefully hit the job that originally uncovered the problem.15:02
openstackgerritBalazs Gibizer proposed openstack/nova master: migrate: Add bw min service level check of source compute  https://review.opendev.org/68039515:02
efrieds/grenade fix/grenade failure/15:03
*** Sundar has joined #openstack-nova15:03
*** lpetrut has quit IRC15:03
mriedemalright then15:03
mriedemmoving on15:03
sean-k-mooneydonnyd: ill check it at the weekend agian when the ci does not have as high a load15:04
efriedmriedem: but given how simple and obviously-right the fix is, and that dtantsur says it is legit, I think we might want to merge it anyway.15:04
dtantsurefried: I'd make your tripleo patch depending on both fixes. I'm not sure which one of them is most breaking.15:04
mriedemefried: i'm good with that15:04
mriedemi definitely trust dtantsur here and these are simple fixes15:04
efrieddtantsur: the symptoms would be different15:04
*** bnemec is now known as beekneemech15:04
*** luksky has quit IRC15:05
dtantsurokie15:06
openstackgerritBalazs Gibizer proposed openstack/nova master: resize: Add bw min service level check of source compute  https://review.opendev.org/68039615:06
*** ociuhandu has joined #openstack-nova15:07
efrieddtantsur, mriedem: +A15:08
dtantsurnow let's see if you'll regret trusting me :D15:08
openstackgerritBalazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth  https://review.opendev.org/65510915:09
efriedIt's not clear that the tripleo patch will work as is; I don't understand the job chain that would get us there, or whether nova needs to be added to required_projects *somewhere* (but where??). So it may take a few iterations to figure that out.15:09
mriedemdtantsur: please don't break my achy breaky heart15:10
dtantsurokay15:11
mriedemi'm assuming you get early 90s billy ray cyrus references of course15:11
openstackgerritBalazs Gibizer proposed openstack/nova master: Func test for migrate server with ports having resource request  https://review.opendev.org/65511315:11
openstackgerritBalazs Gibizer proposed openstack/nova master: Make _rever_allocation nested allocation aware  https://review.opendev.org/67613815:14
*** ratailor has quit IRC15:17
openstackgerritBalazs Gibizer proposed openstack/nova master: Support reverting migration / resize with bandwidth  https://review.opendev.org/67614015:18
gibimriedem, bauzas: the next 5 patches in the bw series is up-to-date. first patch: https://review.opendev.org/#/c/680394/ last up-to-date patch: https://review.opendev.org/#/c/65511315:18
mriedemgibi: yup, on my list for today15:19
gibimriedem: thanks. I still have to work on comments in th second half of the patch series and also need to do a follow up for the already merged https://review.opendev.org/#/c/65642215:20
openstackgerritBalazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth  https://review.opendev.org/67697215:21
*** cdent has joined #openstack-nova15:22
openstackgerritBalazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth  https://review.opendev.org/67698015:24
mriedemstephenfin: is it not possible to deprecate an entire group of config options?15:25
mriedemyou have to do them all individually?15:25
stephenfinyou can deprecate opts but not groups, afaik15:25
stephenfinso no15:25
mriedemblast15:25
stephenfinsoz15:25
mriedemis that hipster millenial for sorry?15:26
* mriedem writes it down15:26
mriedemi had to look up what a "stan" was last night15:26
stephenfinlet's say...yes15:26
cdentyou'll be cool, eventually, mriedem15:26
* stephenfin Googles "stan"15:26
cdenteach day, get better and better15:26
openstackgerritBalazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request  https://review.opendev.org/67149715:27
mriedemhttps://media1.tenor.com/images/fc73ef705412eeaeb838763055918587/tenor.gif?itemid=565322915:27
mriedemoooo https://www.youtube.com/watch?v=BGrfhsxxmdE15:28
jangutterThe only "stan" I know is https://mc-stan.org15:28
openstackgerritBalazs Gibizer proposed openstack/nova master: Do not query allocations twice in finish_revert_resize  https://review.opendev.org/67882715:30
*** avolkov has quit IRC15:33
*** maciejjozefczyk has joined #openstack-nova15:34
*** bbobrov has quit IRC15:36
*** trident has quit IRC15:37
openstackgerritBalazs Gibizer proposed openstack/nova master: Allow resizing server with port resource request  https://review.opendev.org/67901915:37
*** johnthetubaguy has quit IRC15:37
*** maciejjozefczyk_ has quit IRC15:37
openstackgerritMatt Riedemann proposed openstack/nova master: Deprecate the XenAPIDriver  https://review.opendev.org/68073215:41
mriedemefried: dansmith: gibi: bauzas: alex_xu: melwitt: stephenfin: fyi ^15:41
dansmithhoo boy15:41
*** bbobrov has joined #openstack-nova15:41
mriedemi'll post to the ML15:42
stephenfinIma +2 that so hard.15:42
stephenfinafter the ML post, of course15:42
* aspiers grabs some popcorn15:42
*** dtantsur is now known as dtantsur|afk15:44
*** trident has joined #openstack-nova15:46
mriedemhttp://lists.openstack.org/pipermail/openstack-discuss/2019-September/009180.html15:46
mriedemstephenfin: since you smelled it, maybe you should deal up an etherpad for rc todo stuff like the prelude reno15:47
mriedemi'm auto delegating efried delegating that to me15:47
stephenfinmriedem: Sure https://etherpad.openstack.org/p/nova-train-prelude15:48
efriedthanks15:51
efriedis a prelude related to cycle highlights?15:51
mriedemsort of,15:51
efriedcause I could use a delegate for that as well15:51
mriedemthe prelude generally feeds into highlights15:51
mriedemthe highlights have to be wordsmithed a bit for marketing speak15:52
efriedit's cruel that first draft of highlights is due the day of FF.15:52
*** tesseract has quit IRC15:52
mriedem"the compute team leveraged the synergy of the cloud to...deprecate the xenapi driver"15:52
mriedemefried: yup15:52
mriedemi've complained about that before15:52
mriedemsmcginnis is good at suggestions on the highlights,15:53
mriedemhe's nearly executive level management at this point15:53
stephenfinefried: I'm hoping to put together one of those internally to figure out what we need to test/document for Train/OSP16. I'll share it but it won't be 'til Wednesday week, which is probably too late?15:53
mriedemhe only speaks that langauge15:53
mriedemstephenfin: FF is thursday15:53
efriedstephenfin: unless you accept that this task has been delegated to you.15:53
efriedthen Thursday is the "deadline" for the "first draft", so Wednesday is a whole day early!15:54
efriediow, it's all yours, and I don't need to vet/edit/revise it.15:54
smcginnisefried: I'm not happy about the deadline either, but the OSF marketing folks said they needed that info earlier. :/15:55
*** gyee has joined #openstack-nova15:55
mriedemneed to copy/paste into a chart asap15:55
stephenfinefried, mriedem: okay, I'll do it Monday15:55
* stephenfin writes that down to make sure he doesn't forget15:56
*** shilpasd has quit IRC15:56
mriedemmaybe we should put an easter egg in the highlights...15:56
mriedemsee who's paying attention15:56
efriedI'm not blaming anyone, and I'm sure there's a "good" reason. It's just like, we're already all one-armed paper hangers already.15:56
efriedmriedem: love that idea.15:56
mriedem"nova is deprecated, all hail serverless"15:56
*** ivve has quit IRC15:56
stephenfinThere's one non-doc patch left in the remove-consoleauth series that I thought had already merged. If anyone has bandwidth to push it through (melwitt is +2), that'd be dandy https://review.opendev.org/#/c/652970/16:00
stephenfinI'm just going to abandon the other two16:00
dustincmriedem, efried, dtantsur|afk: all caught up, thanks for your help16:02
efriedstephenfin: left a question there16:04
efriedit looks like a behavior change to me16:04
mriedemefried: +2 on that deps update for the sighup fix https://review.opendev.org/#/c/679974/ - mnaser / dansmith fyi on that16:05
efriedthanks mriedem16:05
mriedemdefinitely rc blocker16:05
dansmithefried: I was thinking you had tested something related to sighup and decided that it was *not* properly restarting us after the fix16:06
dansmithefried: did I misunderstand that or did something else change?16:06
efrieddansmith: that was at the point where we only had the oslo.service fix. I dug further and fixed the oslo.privsep issue. With both fixes together, shit works.16:07
dansmithgotcha okay cool16:07
efriedlinks from that patch --^16:07
dansmithefried: yeah okay I didn't get that from the reno when I first read it,16:07
dansmithbut I didn't study both bugs and just wanted to make sure16:08
*** sapd1_x has quit IRC16:08
efried++16:08
melwittefried, stephenfinI think you're right :/ I didn't notice that. commenting16:08
openstackgerritsean mooney proposed openstack/nova master: [DNM] testing with new lable.  https://review.opendev.org/68073816:08
openstackgerritsean mooney proposed openstack/nova master: [DNM] testing with old lable  https://review.opendev.org/68073916:08
efriedmelwitt: looking again, I think the one I commented on is okay, but the one a couple lines down should be access_url, not access_url_base.16:08
sean-k-mooneyignore those by the way ^16:08
sean-k-mooneyim trying to debug stuff.16:09
openstackgerritMatt Riedemann proposed openstack/nova master: Find instance in another cell during floating IP re-association  https://review.opendev.org/65659416:09
melwittefried: I think they should both be access_url. the second one works because it's just checking the scheme, which would be the same on both access_url_base and access_url16:09
efriedmelwitt: access_url is a @property tho, not a field.16:09
melwittyeah, but I think you need to get the access_url first and if None, raise16:10
melwittthat check is supposed to be checking whether there is an access_url available and the property can return None16:11
stephenfinefried: Yeah, what melwitt is saying. I've replied on the patch16:11
melwittbut I dunno, maybe it doesn't really matter because all that method is doing is validating the scheme16:11
*** mriedem is now known as mriedem_lunch16:11
melwittit's never going to look at anything beyond the "https" or whatever the scheme is16:11
efriedah, that makes sense16:12
efriedarguably a bit unrelated, but sokay I guess.16:12
melwittyeah, I'd agree that using the actual access_url here would be unrelated to what this method is doing16:13
efriedmelwitt: If you're still good, I'll +A16:14
melwitt(realized that as I typed the next two sentences)16:14
melwittefried: yeah I think it's fine after thinking through16:15
* melwitt wonders if I went through this thought loop before and completely forgot16:16
efriedack, thanks for bearing with me melwitt & stephenfin16:16
melwittprobably did16:16
stephenfinthanks for the review (y)16:16
efriedsean-k-mooney: can you please ack this https://review.opendev.org/#/c/680094/ ?16:22
sean-k-mooneyoh the os-vif request16:23
sean-k-mooneyyes i wanned to double check one thing16:24
sean-k-mooneybut i think its fine16:24
efriedsean-k-mooney: ...per http://lists.openstack.org/pipermail/openstack-discuss/2019-September/009182.html16:24
efriedthank you16:24
sean-k-mooneywe did 2 train release already for m1 and m2 so this tecnically is not the first os-vif release of train16:24
sean-k-mooneybut i think 1.17.0 still make sense for other reasons16:24
efriedsean-k-mooney: right, that was the main thing I was concerned about. It looked like there were two bugfixes since the last release, but one of them seemed like it might be feature-y.16:25
efriedI'm sure it's not the end of the world if we go feature bump when we should have gone bugfix bump... is it smcginnis?16:25
sean-k-mooneyone of them was a securiy bug which has been backported16:25
sean-k-mooneyhonestly version number are cheap so i would rather bump more then we neeeded too then not so 1.17 looks good to me16:26
sean-k-mooneyefried: no if we bump major it would be an issue but bumping feature should not be16:27
sean-k-mooneystien is on the 1.15.x seriese anyway16:27
efriedI guess the only downside could be confusion of having .16 and .17 both in train. But meh.16:28
smcginnisefried: So that one wasn't a new feature? I didn't go much further than the commit message.16:28
efriedsmcginnis: the commit message sounded feature-y for sure, but there was a bug (not a bp) associated. This is what I wanted sean-k-mooney to confirm for us.16:29
efriedI could look at the code, but...16:29
efriedjangutter: you have an opinion here?16:29
efriedspecifically: is this https://review.opendev.org/#/c/658786/ a "feature" or a "bugfix", for purposes of release numbering?16:30
jangutterefried: it leans more to "feature" than bugfix, especially since the original idea was "feature".16:31
efriedjangutter: Okay, good enough for me, thanks.16:31
efriedsean-k-mooney, smcginnis: ^ cool?16:31
smcginnisWorks for me.16:31
jangutterefried: os-vif uses bugs to track features (like neutron)16:32
efriedsmcginnis: acked, thanks for your patience.16:32
efriedjangutter: okay, gtk, then I'm going to have this question every release :P16:32
jangutterefried, sean-k-mooney: is there a way to distinguish between [RFE] bugs and your run of the mill annoyances?16:33
smcginnisThanks for following up on that.16:33
efriedjangutter: With careful use of tagging, I'm sure there is. You may have even had that in place in this case - I admit I didn't look.16:34
smcginnisIt's been pretty common in my experience that new "features" also fix bugs, so I've never really used BPs vs bugs as an indicator.16:34
efriedBut that would also require an understanding of whatever tag scheme by whoever's doing the looking16:35
efriedand yeah, more broadly, what smcginnis says.16:35
efriedit's on a team by team basis, so really we need team members to make this call one way or another (either by proposing the release patches themselves and noting this reasoning in the commit message, or by being pestered like this when releases are proposed "automatically" or otherwise externally to the team)16:36
sean-k-mooneyjangutter: we use RFE bugs in os-vif to track feature16:37
sean-k-mooneyjangutter: because we dont want to have to use specs or blueprints16:37
sean-k-mooneyso RFE bugs cant be backported as they are features16:37
sean-k-mooneyother then that no16:37
*** pcaruana has quit IRC16:37
efriedaspiers: I'm looking at https://review.opendev.org/#/c/680065/8/nova/tests/unit/scheduler/test_utils.py -- I was digging for this answer myself, but am being pulled in multiple directions -- can you confirm that there are other tests covering the behavior when hw_machine_type is absent (which is to allow it through) ?16:40
efriedI think tests above those are doing it, yah?16:40
aspiersefried: checking16:40
efriediow I wanted to say "hey, instead of doing this to all three, just do it to one or two, so it proves the other thing" -- but don't want to block on that if other tests are already covering that.16:41
aspiersefried: testing hw_machine_type being absent was missing until very recently, I just added it like 2 days ago16:41
aspierslet me find where16:41
aspiersit's mentioned in a commit message somewhere16:41
aspiersoh yeah it's this review16:41
aspierslet me find the lines16:42
*** derekh has quit IRC16:42
aspiersefried: https://review.opendev.org/#/c/680065/8/nova/tests/unit/virt/test_hardware.py@383716:42
efriedthat's asserting failure due to no uefi...16:43
aspiersdoh16:43
aspiersbrain fried16:43
efriedwhere's a case that succeeds with no mach type16:43
aspiersah OK16:43
aspierschecking16:43
efriedperhaps L3926 could have a None in it too?16:43
aspiersah that has to be tested in the driver16:44
aspierssince with no machine type in the image, it relies on pulling it from utils16:44
aspierswhich reads nova.conf on compute node16:44
aspiersI think it's maybe in a later patch16:44
aspierschecking ...16:44
aspiersefried: https://review.opendev.org/#/c/644565/52/nova/tests/unit/virt/libvirt/test_driver.py@270016:46
aspiersalthough maybe there is a test missing for when CONF.libvirt.hw_machine_type is set to x86_64=q3516:47
efriedaspiers: that one is *also* a failure scenario16:47
aspiersyeah that's what I'm saying16:48
*** vesper11 has quit IRC16:48
aspiersCONF.libvirt.hw_machine_type set to x86_64=q35 would be the non-failure scenario16:48
aspiersI can add that16:48
*** vesper11 has joined #openstack-nova16:48
aspiersefried: kudos for eagle eyes as usual :)16:48
efriedwhere are you going to add it?16:49
efriedaspiers: is it adequate to undo one of those three lines of delta here https://review.opendev.org/#/c/680065/8/nova/tests/unit/scheduler/test_utils.py ?16:50
efriedand then maybe also add the case next to the one in the fourth patch?16:50
*** pcaruana has joined #openstack-nova16:51
efriedaspiers: there's one more comment in there, in case you agree and want to make that change at the same time.16:51
* efried moves on to other things.16:51
*** efried is now known as efried_afk16:51
aspiersefried_afk: ok thanks!16:51
*** gyee has quit IRC16:56
*** gyee has joined #openstack-nova16:56
*** cdent has quit IRC16:58
*** ociuhandu has quit IRC17:03
*** gbarros has quit IRC17:08
*** markvoelker has joined #openstack-nova17:25
*** udesale has quit IRC17:27
*** mriedem_lunch is now known as mriedem17:38
mriedemdansmith: so linkedin told me it was a big day for you and i was looking at the suggested comments and i thought this one was a good fit https://photos.app.goo.gl/WrC1wjQYu7Btfz2g817:45
dansmithheh17:48
dansmithyeah, I wish linkedin wouldn't ask people to do  that17:48
dansmithand/or I wish people would ignore all that crap like I do :)17:48
sean-k-mooneyi think mose people do17:49
aspiershaha17:50
sean-k-mooneydansmith: the real question is does it feel like 6 or 1217:51
dansmithsean-k-mooney: see, you're doing it, although indirectly :)17:51
*** gbarros has joined #openstack-nova17:53
*** jangutter has quit IRC17:54
*** jawad_axd has joined #openstack-nova17:55
mriedemi just laugh at the AI/ML generated auto responses17:55
*** mvkr has quit IRC17:55
mriedemi hate them on my phone but am too lazy to figure out how to disable17:55
mriedembecause no my every response to my wife's text messages shouldn't be, "I know, right?"17:55
melwittI know that you can disable profile updates from notifying the world but I don't know if that encompasses work anniversaries too17:56
mriedemheh, messaging > settings > smart reply (disable)17:56
mriedemthat was easy17:56
*** markvoelker has quit IRC17:57
mriedem"I know, right?"17:57
*** markvoelker has joined #openstack-nova18:03
sean-k-mooneyok i havent got anything useful done in an hour some im goign to get dinner. i might be back online later. if not have a nice weekend o/18:05
dansmithsean-k-mooney: it's friday. turn. off. the. laptop.18:05
*** markvoelker has quit IRC18:12
*** tbachman has quit IRC18:13
mriedembut is bauzas still up working on a friday night?18:13
mriedemb/c i'm +2 on https://review.opendev.org/#/c/680394/4 and the 2 above it18:13
*** luksky has joined #openstack-nova18:13
*** markvoelker has joined #openstack-nova18:15
mriedemgibi: when you're back and collecting comments, i approved but left a comment about defining constants for https://review.opendev.org/#/c/655109/2418:16
*** tbachman has joined #openstack-nova18:20
*** factor has joined #openstack-nova18:24
*** markvoelker has quit IRC18:26
*** ralonsoh has quit IRC18:27
mriedemif anyone is adventurous, there are +2s waiting for a +W on 4 of the bw provider move series https://review.opendev.org/#/q/topic:bp/support-move-ops-with-qos-ports+status:open+label:Code-Review=218:27
mriedemthey are all about min compute service version checking and functional tests18:28
mriedemso pretty easy18:28
*** markvoelker has joined #openstack-nova18:28
mriedemthe bottom one is only big b/c of a lot of test coverage18:28
*** maciejjozefczyk has quit IRC18:36
*** markvoelker has quit IRC18:38
mriedemdansmith: so i've got an rpc compat thing i'd like to remove but need to get out of my head,18:38
mriedembefore this change, https://review.opendev.org/#/c/582417/ conductor would always send a legacy request spec dict to compute's prep_resize method during cold migrate/resize and compute would never send it back to conductor on reschedule,18:39
mriedemwith that change, prep_resize on the comput takes a RequestSpec object if you're not pinned18:39
mriedemand compute passes back whatever it gets18:39
mriedemthere were no changes to the conductor compute task api rpc interface b/c it always took a request spec and passed it through (for the api calling conductor initially)18:40
mriedemwhat i'd really like to do is remove this compat code when compute doesn't send a request spec back on reschedule https://review.opendev.org/#/c/582417/7/nova/conductor/manager.py18:40
mriedemwhich should be possible if we aren't supporting older-than-stein computes in train or ussuri,18:41
dansmithviolates the rpcapi though18:41
mriedemwhere i think i f'ed up was that the compat code in conductor isn't handling request spec being a dict18:41
mriedemno i don't think it violates the rpc api because there was no change to the conductor rpc api to remove the request spec that compute passes back18:41
mriedemit's just a pass through18:41
mriedemthe only interface that changed was the compute rpc api18:41
*** jawad_axd has quit IRC18:42
mriedemso the only time compute won't send a request spec back up is if it's pre-stein18:42
dansmiththe object could be None there which means old version right?18:42
mriedemwell, if you're pinned to less than conductor 1.13 yeah...18:42
dansmithright18:42
mriedemwhich was mitaka https://review.opendev.org/#/c/277800/ but yeah18:43
dansmithso you can't remove the ability to take an N.0 call unless you bump majors18:43
dansmithI mean,18:43
mriedemright so conductor 2.0 to make request spec required and RequestSpec object18:43
dansmithI realize other shit will break if you go that old, but either we stick to these rules or we don't18:43
mriedemyeah18:43
mriedemi just came across that todo while reviewing gibi's series and though i'm glad we have that, and was going to remove the compat, but then realized i can't18:44
mriedemso i'll be amending that todo comment i guess since i don't feel like taking on a conductor 2.0 bump18:44
dansmithaye18:45
openstackgerritMerged openstack/nova master: objects: Remove ConsoleAuthToken.to_dict  https://review.opendev.org/65297018:51
*** igordc has joined #openstack-nova18:53
*** efried_afk is now known as efried18:54
*** gbarros has quit IRC19:03
*** markvoelker has joined #openstack-nova19:11
*** markvoelker has quit IRC19:15
*** gbarros has joined #openstack-nova19:24
openstackgerritMatt Riedemann proposed openstack/nova master: Handle legacy request spec dict in ComputeTaskManager._cold_migrate  https://review.opendev.org/68076219:25
mriedemok i think that handles both issues (bad comment and dict compat)19:25
openstackgerritMerged openstack/nova master: Bump min for oslo.service & .privsep to fix SIGHUP  https://review.opendev.org/67997419:34
openstackgerritMatt Riedemann proposed openstack/nova master: Cleanup request spec handling in _cold_migrate  https://review.opendev.org/68076319:40
openstackgerritMatt Riedemann proposed openstack/nova master: Isolate request spec handling from _cold_migrate  https://review.opendev.org/68076319:40
*** markvoelker has joined #openstack-nova19:41
efrieddansmith: I haven't looked at all yet, but it's almost 3 and I'm still not dug out, and wanted to catch you today if possible -- did a) the vpmem Resource ovo stuff and b) the forbidden aggs stuff shake out satisfactorily?19:41
dansmithI haven't gotten to them yet19:41
*** markvoelker has quit IRC19:45
dansmithefried: do you know why the isolated aggs set was rebased this morning?19:50
dansmithdoesnt' seem like anything changed and it means we still don't have a ci run on it yet19:50
efrieddansmith: I don't. Maybe so the owner can retain commiter-hood?19:50
* efried looks...19:51
dansmiththat's not how that works19:51
aspiersefried: on further thought, I think https://review.opendev.org/#/c/680065/ is fine as it stands - see the comments I just posted19:51
efrieddansmith: oh, it looks like the bottom patch needed an ovo hash bump -- oops, that's my bad.19:51
dansmithoh okay I thought I checked all the files but maybe I missed that one19:52
dansmith(for changes I mean)19:52
efriedhttps://review.opendev.org/#/c/671072/14..15/nova/tests/unit/objects/test_objects.py19:52
dansmithyeah I know19:53
efriedaspiers: beaut, thanks for following up. +A19:59
*** nweinber has quit IRC20:00
aspiersefried: yw. Don't hesitate to ask if I can (attempt to) help explain other oddities in the remaining two patches20:04
*** BjoernT has quit IRC20:06
*** ricolin has joined #openstack-nova20:08
*** markvoelker has joined #openstack-nova20:19
* efried ==> chauffeur20:19
*** efried is now known as efried_afk20:19
mriedemartom: dansmith: since stephen and sean aren't around, i'll ask you this https://review.opendev.org/#/c/621476/62/nova/api/openstack/compute/server_topology.py@6620:22
mriedemsince i don't know numa20:22
dansmithsame pagesize on all cells, is that what you mean?20:22
mriedemyeah20:22
*** tbachman has quit IRC20:23
dansmiththey will all have a pagesize and they'll all be identical20:23
dansmithI asked that earlier in artom's series20:23
mriedemif they will all have a page size why is that conditional?20:23
dansmithoh, not sure they will all always have a pagesize, but if any do, they'll be the same20:24
dansmithnow, that's a libvirt/x86 thing.. I can imagine power allowing multiples because some team in DB2 asked for it in 199620:24
mriedemok, that works for me20:24
dansmithall that probably depends on the hypervisor and arch20:24
mriedemthis is an intel (tm) api so don't worry about it20:25
dansmithso I'm sure this api will be broken for other ones that aren't considered here20:25
dansmithWONderful20:25
mriedempowerstackers was burned out of governance b/c eric wouldn't lead them anymore20:25
mriedemand the z folks have moved onto openshift on mainframes20:25
dansmithshocking20:26
mriedemhas to be weird when the german customers ask for sles + openshift on their z mainframe20:26
*** markvoelker has quit IRC20:29
*** tbachman has joined #openstack-nova20:30
*** gbarros has quit IRC20:44
*** markvoelker has joined #openstack-nova20:50
mriedemso this is the 2.78 server numa topology command output right now in the proposed change: http://paste.openstack.org/show/772110/20:52
mriedemthat....sucks20:52
*** markvoelker has quit IRC20:54
sean-k-mooneylibvirt/qemu support having muliple page size even in the same numa node but we dont support that in openstack and likely never will20:58
mriedemsean-k-mooney: ok i'll stop writing up that spec for ussuri20:58
mriedemi thought you'd be on board20:58
mriedembut i guess you don't like that kind of excitement20:58
sean-k-mooneyif you want to debug it when it does not work feel free20:59
mriedemheh20:59
mriedemobviously i'm joking20:59
mriedemi've been trying to come up with some kind of hardware schmorgasbord name generator thing to get your goat20:59
*** gbarros has joined #openstack-nova21:00
sean-k-mooneyjust pick 3 random letters and its proably some future NFV hardware thing21:00
mriedemFUK21:00
sean-k-mooney:)21:01
mriedemfailover uber kernel21:01
mriedemit's a new DR thing21:01
sean-k-mooneyi thought it was a brexit reference21:01
sean-k-mooneybut ok :)21:01
mriedemyou've been boris'ed21:01
*** tbachman has quit IRC21:01
mriedembtw https://www.youtube.com/watch?v=dXyO_MC9g3k if you haven't seen that, it's pretty good21:01
sean-k-mooneyi have not, i look forword to it :)21:02
mriedemok, time for some cli design,21:04
mriedemwho's in?21:04
mriedemhttp://paste.openstack.org/show/772111/21:04
*** ociuhandu has joined #openstack-nova21:04
mriedemthat's better than before, but the list of nodes in json string is not great,21:05
sean-k-mooneyis that the output for the toplogy api?21:05
mriedembut if you dumped each node dict as a separate property, what would you name the property? because that host_node field is only in the response for admins,21:05
mriedemyeah, in the cli21:05
mriedemproposed cli21:05
mriedemso if you're an admin, you could name each one as node{host_node} so like node0 and node121:05
sean-k-mooneycan we pretty print the json blob21:06
mriedembut if you're not admin, calling them node0 or node1 could make the user think they are actually on those physical host numa nodes21:06
mriedemhmm, maybe21:06
*** ricolin has quit IRC21:14
sean-k-mooneyits a litte more readable. http://paste.openstack.org/show/772112/ i didnt put it in the ascis table21:14
*** ociuhandu has quit IRC21:15
sean-k-mooneybut you could also do somithing like21:15
mriedemthat's what i already have http://paste.openstack.org/show/772111/21:15
sean-k-mooney|node.[0].cpu_pinning | {"0": 0,"1": 5}21:16
mriedemanyway, i've got this better than it was so i'll push it up and someone else can hack on it21:16
mriedemit's not even my patch21:16
sean-k-mooneythe latest windows update sucks ...21:17
mriedem10...?21:17
sean-k-mooneyya21:18
mriedemi'm rocking 721:18
sean-k-mooneyit install an update last night and now its haning if i boot it in a vm21:18
sean-k-mooneyif i reboot the host indo the same windwos install its fine21:18
*** rcernin|brb has joined #openstack-nova21:19
sean-k-mooneyi did like 7. i think i still have my 7 ultimate 64bit dvd around somewhere.21:21
mnaserefried_afk: thanks for driving the SIGHUP patches stuff, i ran out of bandwidth21:21
*** efried_afk is now known as efried21:22
efriedmnaser: yahyoubetcha. Glad to have that fixed finally.21:22
*** prometheanfire has joined #openstack-nova21:22
prometheanfireos-brick update is breaking nova :(  https://review.opendev.org/68033921:22
efriedprometheanfire: does cinder know?21:22
efried(I didn't click yet)21:23
mnaserAttributeError: 'module' object has no attribute 'NVMeConnector'21:23
mnaserhttps://github.com/openstack/os-brick/commit/0f057aee6e0351bdef68fadf1fc56ac315027c9821:23
prometheanfireno, test fails were in nova so pinged you first21:23
mnaserim guessing those are the fails21:24
mnaserthe module was renamed21:24
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: Microversion 2.78 - show server topology  https://review.opendev.org/67079021:24
sean-k-mooneyare the nova unit test mocking stuff in os-bricks21:25
prometheanfiretry import except import?21:25
mnaserbtw21:25
mnaserthere is some context here https://review.opendev.org/#/c/643421/21:25
sean-k-mooneyok so we are importing the conector object in the test21:27
mnaser`initiator.NVME` that was left around for backwards compat21:27
mnaserbut the connector did not keep a backwards compat21:28
mnaseri mean as a work around you could fall back to asserting the initiator used instead of the connector used21:29
*** macz has quit IRC21:29
sean-k-mooneyso the real driver code use the factory method to consurct it21:29
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume/nvme.py#L3421:29
mnasersean-k-mooney: it uses `initiator.NVME` which is still around21:30
sean-k-mooneyi think the real fix is to not assert thing abot the data type of an external lib21:30
*** macz has joined #openstack-nova21:30
mnaserhttps://github.com/openstack/os-brick/blob/0f057aee6e0351bdef68fadf1fc56ac315027c98/os_brick/initiator/connector.py#L117-L12221:30
mnasercause thats still around21:30
sean-k-mooneymnaser: yes but i guess they considerd as part of the public interface21:30
sean-k-mooneyand the conector object are not21:31
mnasermaybe the test should mock `connector.InitiatorConnector.factory` and make sure it calls it with initiator.NVME ?21:31
mnaserwhich is enough to know we are doing the right thing(tm)21:31
sean-k-mooneymaybe but its stil mocking stuff we dont own21:32
sean-k-mooneybut that seams safer21:32
sean-k-mooneysice we are mocking somethign we are calling21:32
mnaserwell at least it makes sure that we're creating a connector with the right type of initiator21:32
mnaserwhich i think is the biggest thing that test is supported to do..21:32
sean-k-mooneyright but that is not novas job to test21:32
openstackgerritMatt Riedemann proposed openstack/nova master: api-ref: fix server topology "host_numa_node" field param name  https://review.opendev.org/68077521:32
sean-k-mooneythat is os-bricks job to test21:32
sean-k-mooneywe shoudl jsut assert we called ti with the correct input21:33
*** rcernin|brb has quit IRC21:33
mnaserexactly thats what i meant about mocking `connector.InitiatorConnector.factory`21:33
mnaseraka make sure we're calling it with initiator.NVME as an argument (instead of $some_other_weird_thing)21:33
sean-k-mooneyya which seams more robust21:33
sean-k-mooneyyep21:33
mnaserits friday and im waiting for my food21:33
efrieddansmith: responded in https://review.opendev.org/67107521:34
mnaserlet me push up a patch quick..21:34
dansmithefried: ack, but I'm EOD21:35
efriednod21:35
dansmithreplied for action21:36
* dansmith &21:36
efriedthanks21:38
*** KeithMnemonic1 has quit IRC21:40
mriedemit's in-law o'clock21:41
mriedemo/21:41
*** mriedem has quit IRC21:41
*** macz has quit IRC21:43
*** gbarros has quit IRC21:45
openstackgerritAdam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required  https://review.opendev.org/64456521:48
openstackgerritAdam Spiers proposed openstack/nova master: Reject live migration and suspend on SEV guests  https://review.opendev.org/68015821:49
openstackgerritMohammed Naser proposed openstack/nova master: Decouple NVMe tests from os-brick  https://review.opendev.org/68077921:52
mnasersean-k-mooney: ^ unit tests and flake8 passes here locally21:52
openstackgerritAdam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption  https://review.opendev.org/66661621:53
mnaserefried: fyi the requirements breakage should be solved by that ^21:53
mnaseroh rap21:53
mnaseri have an extra file there21:53
openstackgerritMohammed Naser proposed openstack/nova master: Decouple NVMe tests from os-brick  https://review.opendev.org/68077921:53
efriedmnaser: ugh, do we really need root helper?21:54
mnaserefried: i mean i can skip the mock and import utils ?21:55
mnaserbut i mean its being passed down there21:55
efriedsorry, I just remember recently seeing where we were trying to get rid of that thing, so adding another reference to it feels like increasing tech debt.21:55
mnaserhttps://docs.openstack.org/os-brick/stein/reference/os_brick/initiator/connector.html21:55
mnaserwell i only touched the tests, it was already referencing it21:56
mnaserand it looks like the library relies on needing it21:56
efriedyeah, it just makes me sad.21:56
efriedmnaser, prometheanfire: Ima update the req patch to dep-on this guy to make sure it clears up, mkay?21:56
*** macz has joined #openstack-nova21:56
mnaserefried: i mean i can get rid of the mock and have it call the real function but still gonna have a reference at the end of teh day21:57
efrieddon't worry about it.21:57
mnasercools21:57
* mnaser goes back to food21:57
aspiersefried: woot, SEV tempest test is working, exercising many code paths, and even found a bug which is now fixed :)22:07
aspiersnow I just have to wait a week for Zuul to catch up :(22:07
efriednice22:12
efriedaspiers: did you do the tempest work?22:12
aspiersyes22:12
aspiersI'd never touched tempest before yesterday22:12
aspiersIt's pretty straight-forward though, and nicely documented22:12
efriedfeel like writing one to cover https://review.opendev.org/#/c/680542/ ?22:12
aspiersNot right now ;-) It's 11am and yet another week where I'm about 20 hours over time22:13
efriedit was worth a try22:13
aspiersBut hey, if all the SEV stuff lands early next week then I'd have spare time on my hands ... hint hint ;-)22:13
aspiersIn fixing the designer.py found by tempest, the code got a lot simpler - look: https://review.opendev.org/#/c/644565/53/nova/virt/libvirt/designer.py@20222:14
aspiers*missing "bug" in above sentence22:15
*** markvoelker has joined #openstack-nova22:15
efriedack22:15
aspiersOther than reinstating W+1 on the rebased https://review.opendev.org/#/c/680158/, there's only that patch and the final master switch one left needing reviews22:16
aspiersso it feels like we're close, CI permitting22:17
*** markvoelker has quit IRC22:20
prometheanfireefried: sgtm22:25
*** luksky has quit IRC22:51
openstackgerritMerged openstack/nova master: doc: cleanup references to conductor doc  https://review.opendev.org/68053522:54
*** ociuhandu has joined #openstack-nova23:15
*** ociuhandu has quit IRC23:20
openstackgerritMerged openstack/nova master: Remove old comments about caching scheduler compat  https://review.opendev.org/68052123:28
*** mdbooth has quit IRC23:42
*** mdbooth has joined #openstack-nova23:44
*** gyee has quit IRC23:45
*** mtreinish has quit IRC23:49
*** efried has quit IRC23:51
*** gyee has joined #openstack-nova23:55
*** gyee has quit IRC23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!