| *** hemna has joined #openstack-nova | 00:02 | |
| *** markvoelker has quit IRC | 00:02 | |
| *** brinzhang has joined #openstack-nova | 00:17 | |
| *** rcernin has quit IRC | 00:30 | |
| *** macz has quit IRC | 00:30 | |
| *** hemna has quit IRC | 00:35 | |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.79: Add delete_on_termination to volume-attach API https://review.opendev.org/673485 | 00:35 |
|---|---|---|
| *** ccamacho has quit IRC | 00:51 | |
| *** yedongcan has joined #openstack-nova | 00:59 | |
| *** hemna has joined #openstack-nova | 01:03 | |
| *** mdbooth has quit IRC | 01:25 | |
| *** mdbooth has joined #openstack-nova | 01:26 | |
| *** hemna has quit IRC | 01:37 | |
| *** rcernin has joined #openstack-nova | 01:45 | |
| *** hemna has joined #openstack-nova | 01:49 | |
| *** hemna has quit IRC | 01:54 | |
| *** dave-mccowan has quit IRC | 01:58 | |
| *** hemna has joined #openstack-nova | 02:29 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | 02:32 |
| gregwork | does nova have any concept of compute balancing after an instance is up | 02:38 |
| gregwork | for example, if you evacuate a compute node for maintenance, how do you rebalance what got moved around once that node is back up | 02:38 |
| *** rchurch has joined #openstack-nova | 02:45 | |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.81: Add user_id/project_id to migration-list API https://review.opendev.org/675023 | 03:02 |
| *** hemna has quit IRC | 03:04 | |
| *** mkrai has joined #openstack-nova | 03:18 | |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.81: Add user_id/project_id to migration-list API https://review.opendev.org/675023 | 03:21 |
| *** dklyle has quit IRC | 03:29 | |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.80: Add user_id/project_id to migration-list API https://review.opendev.org/675023 | 03:31 |
| *** hemna has joined #openstack-nova | 03:42 | |
| *** sapd1_x has joined #openstack-nova | 03:49 | |
| *** macz has joined #openstack-nova | 03:50 | |
| *** udesale has joined #openstack-nova | 03:53 | |
| *** macz has quit IRC | 03:55 | |
| *** mdbooth has quit IRC | 04:03 | |
| *** sapd1_x has quit IRC | 04:03 | |
| *** etp has joined #openstack-nova | 04:13 | |
| *** hemna has quit IRC | 04:17 | |
| *** Luzi has joined #openstack-nova | 04:48 | |
| *** markvoelker has joined #openstack-nova | 04:55 | |
| *** ratailor has joined #openstack-nova | 05:00 | |
| *** markvoelker has quit IRC | 05:00 | |
| *** jaosorior has joined #openstack-nova | 05:03 | |
| *** ricolin has joined #openstack-nova | 05:08 | |
| *** Tianhao_Hu has joined #openstack-nova | 05:19 | |
| *** Tianhao_Hu has left #openstack-nova | 05:20 | |
| *** yaawang has quit IRC | 05:22 | |
| *** yaawang has joined #openstack-nova | 05:24 | |
| *** abhishekk has joined #openstack-nova | 05:33 | |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.80: Add user_id/project_id to migration-list API https://review.opendev.org/675023 | 05:35 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Follow-up: Add delete_on_termination to volume-attach API https://review.opendev.org/680655 | 05:44 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Introduce Resource and ResourceList objs https://review.opendev.org/678448 | 05:45 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Add resources dict into _Provider https://review.opendev.org/678449 | 05:45 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Retrieve the allocations early https://review.opendev.org/678450 | 05:45 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Claim resources in resource tracker https://review.opendev.org/678452 | 05:45 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver discovering PMEM namespaces https://review.opendev.org/678453 | 05:45 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree https://review.opendev.org/678454 | 05:45 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455 | 05:45 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456 | 05:45 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/679640 | 05:45 |
| *** hemna has joined #openstack-nova | 05:45 | |
| *** macz has joined #openstack-nova | 05:51 | |
| *** macz has quit IRC | 05:56 | |
| *** mdbooth has joined #openstack-nova | 06:08 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:08 | |
| brinzhang | takashin:https://review.opendev.org/#/c/674243/23/nova/api/openstack/compute/schemas/migrations.py@55 | 06:12 |
| brinzhang | takashin: I am using the same as query_params_v21 used here [1], they do the same thing, need to be defined again? . | 06:12 |
| brinzhang | [1]https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L570-L571 | 06:12 |
| brinzhang | takashin: should I replaced this with single_sample({'type': 'string'}) | 06:13 |
| *** hemna has quit IRC | 06:14 | |
| takashin | brinzhang: If multiple same query params (e.g. ?user_id=usera&user_id=userb) are not allowed, single_param should be used. | 06:19 |
| brinzhang | takashin: Yeah, got it, will be replace it with single_param, thanks. | 06:21 |
| *** tetsuro has joined #openstack-nova | 06:39 | |
| openstackgerrit | Akira KAMIO proposed openstack/nova master: VMware: disk_io_limits settings are not reflected when resize https://review.opendev.org/680296 | 06:40 |
| *** ccamacho has joined #openstack-nova | 06:42 | |
| *** slaweq_ has joined #openstack-nova | 06:49 | |
| *** yaawang has quit IRC | 06:51 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | 06:52 |
| *** luksky has joined #openstack-nova | 06:53 | |
| *** Tianhao_Hu has joined #openstack-nova | 07:01 | |
| *** rcernin has quit IRC | 07:02 | |
| *** tetsuro has quit IRC | 07:06 | |
| *** slaweq_ has quit IRC | 07:06 | |
| *** slaweq has joined #openstack-nova | 07:08 | |
| *** tetsuro has joined #openstack-nova | 07:08 | |
| *** jawad_axd has joined #openstack-nova | 07:09 | |
| *** trident has quit IRC | 07:10 | |
| *** tesseract has joined #openstack-nova | 07:13 | |
| *** mdbooth has quit IRC | 07:13 | |
| *** damien_r has joined #openstack-nova | 07:14 | |
| *** Tianhao_Hu has quit IRC | 07:16 | |
| *** Tianhao_Hu has joined #openstack-nova | 07:17 | |
| *** yaawang has joined #openstack-nova | 07:18 | |
| *** hamzy_ has quit IRC | 07:19 | |
| *** trident has joined #openstack-nova | 07:21 | |
| *** cfriesen has quit IRC | 07:23 | |
| *** hamzy_ has joined #openstack-nova | 07:29 | |
| *** owalsh has quit IRC | 07:32 | |
| *** owalsh has joined #openstack-nova | 07:33 | |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter https://review.opendev.org/671072 | 07:36 |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata https://review.opendev.org/671074 | 07:36 |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates https://review.opendev.org/671075 | 07:36 |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Docs for isolated aggregates request filter https://review.opendev.org/667952 | 07:36 |
| *** avolkov has joined #openstack-nova | 07:42 | |
| *** brinzhang has quit IRC | 07:44 | |
| *** brinzhang has joined #openstack-nova | 07:45 | |
| *** jangutter has joined #openstack-nova | 07:47 | |
| *** pcaruana has joined #openstack-nova | 07:49 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 07:50 | |
| *** markvoelker has joined #openstack-nova | 07:50 | |
| *** maciejjozefczyk has quit IRC | 07:50 | |
| *** macz has joined #openstack-nova | 07:52 | |
| *** markvoelker has quit IRC | 07:55 | |
| *** rpittau|afk is now known as rpittau | 07:55 | |
| *** macz has quit IRC | 07:56 | |
| *** tetsuro has quit IRC | 07:57 | |
| *** takashin has left #openstack-nova | 08:00 | |
| *** cdent has joined #openstack-nova | 08:09 | |
| *** panda has quit IRC | 08:09 | |
| *** mdbooth has joined #openstack-nova | 08:11 | |
| *** panda has joined #openstack-nova | 08:11 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470 | 08:12 |
| *** mdbooth has quit IRC | 08:17 | |
| *** mdbooth has joined #openstack-nova | 08:18 | |
| *** ralonsoh has joined #openstack-nova | 08:18 | |
| *** damien_r has quit IRC | 08:22 | |
| *** damien_r has joined #openstack-nova | 08:26 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Note about Destination.forbidden_aggregates https://review.opendev.org/680945 | 08:34 |
| gibi | shilpasd: ^^ | 08:40 |
| *** tetsuro has joined #openstack-nova | 08:41 | |
| *** tkajinam has quit IRC | 08:42 | |
| *** derekh has joined #openstack-nova | 08:43 | |
| *** tetsuro has quit IRC | 08:45 | |
| *** Tianhao_Hu has left #openstack-nova | 08:52 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: doc: attaching virtual persistent memory to guests https://review.opendev.org/680300 | 08:54 |
| *** shilpasd has joined #openstack-nova | 09:01 | |
| *** hamzy_ has quit IRC | 09:07 | |
| *** ociuhandu has joined #openstack-nova | 09:08 | |
| *** ociuhandu has quit IRC | 09:10 | |
| *** ociuhandu has joined #openstack-nova | 09:10 | |
| *** ociuhandu has quit IRC | 09:14 | |
| *** ociuhandu_ has joined #openstack-nova | 09:14 | |
| *** ociuhandu_ has quit IRC | 09:18 | |
| *** tssurya has joined #openstack-nova | 09:22 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.opendev.org/651969 | 09:24 |
| *** ociuhandu has joined #openstack-nova | 09:27 | |
| *** arxcruz_pto is now known as arxcruz | 09:27 | |
| yaawang | stephenfin: Hi, I have updated the patches of vCPU model selection, could you take a review if you have time :) https://review.opendev.org/#/c/670298 https://review.opendev.org/#/c/670299 | 09:28 |
| bauzas | gibi: stephenfin: had no time this morning for both your series but this is planned today | 09:36 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | 09:47 |
| *** kaisers has quit IRC | 09:48 | |
| *** kaisers has joined #openstack-nova | 09:50 | |
| *** jawad_axd has quit IRC | 09:51 | |
| *** markvoelker has joined #openstack-nova | 09:51 | |
| *** macz has joined #openstack-nova | 09:53 | |
| *** ricolin_ has joined #openstack-nova | 09:55 | |
| *** lpetrut has joined #openstack-nova | 09:55 | |
| *** macz has quit IRC | 09:57 | |
| *** ricolin has quit IRC | 09:57 | |
| *** markvoelker has quit IRC | 10:00 | |
| *** brinzhang has quit IRC | 10:02 | |
| *** brinzhang has joined #openstack-nova | 10:03 | |
| *** jawad_axd has joined #openstack-nova | 10:05 | |
| *** rcernin has joined #openstack-nova | 10:08 | |
| *** jawad_axd has quit IRC | 10:10 | |
| *** brinzhang_ has joined #openstack-nova | 10:11 | |
| *** damien_r has quit IRC | 10:13 | |
| *** brinzhang has quit IRC | 10:14 | |
| *** ricolin_ has quit IRC | 10:15 | |
| *** spsurya has joined #openstack-nova | 10:21 | |
| *** brinzhang has joined #openstack-nova | 10:27 | |
| *** brinzhang_ has quit IRC | 10:30 | |
| alex_xu | stephenfin: good morning, I think luyao get her vpmem pathces ready https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/virtual-persistent-memory, appreciate if you can take a look at them again | 10:32 |
| stephenfin | alex_xu: Will do. I'm just working through your comments on the cpu-resource spec first then I'll move onto that (y) | 10:33 |
| *** sapd1_x has joined #openstack-nova | 10:35 | |
| alex_xu | stephenfin: thanks, I will do another around test on your patch after you updated. Then I think we are pretty ready to go | 10:36 |
| aspiers | alex_xu, stephenfin: let me know if I can help in any way with reviews on the last 2 SEV patches | 10:39 |
| alex_xu | aspiers: I will give a try tomorrow if the last few patches doesn't merge yet | 10:40 |
| artom | sean-k-mooney or stephenfin, heya, there's a request from mriedem to review a new bit of XML generation for NUMA LM in https://review.opendev.org/#/c/635229/58..61/nova/virt/libvirt/driver.py and https://review.opendev.org/#/c/635229/58..61/nova/virt/libvirt/migration.py | 10:40 |
| artom | It's the vcpu_pin_set stuff we talked about on... Friday? | 10:41 |
| aspiers | alex_xu: There are only 2 left waiting for review | 10:41 |
| aspiers | alex_xu: but the runway ends on Thursday and then it's the feature freeze, so I am getting a bit worried :-/ | 10:41 |
| *** panda is now known as panda|rover | 10:42 | |
| alex_xu | aspiers: I'm pretty sure everybody worries this week :) | 10:43 |
| aspiers | alex_xu: ;) | 10:43 |
| *** kaisers has quit IRC | 10:44 | |
| *** ociuhandu has quit IRC | 10:45 | |
| *** tbachman has quit IRC | 10:49 | |
| *** awalende has joined #openstack-nova | 10:50 | |
| *** mkrai_ has joined #openstack-nova | 10:53 | |
| *** ricolin_ has joined #openstack-nova | 10:53 | |
| *** dave-mccowan has joined #openstack-nova | 10:55 | |
| *** mkrai has quit IRC | 10:56 | |
| *** tetsuro has joined #openstack-nova | 10:58 | |
| *** tetsuro has quit IRC | 10:59 | |
| *** nicolasbock has joined #openstack-nova | 11:02 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Follow-up: Add delete_on_termination to volume-attach API https://review.opendev.org/680655 | 11:05 |
| gibi | bauzas: ack, thanks | 11:08 |
| *** yedongcan has left #openstack-nova | 11:10 | |
| sean-k-mooney | artom: ill take a look at it today | 11:11 |
| *** rpittau is now known as rpittau|bbl | 11:12 | |
| sean-k-mooney | im going to finish reviewing stephenfin pcpu seriese and then ill start revering the numa series | 11:13 |
| artom | sean-k-mooney, ack, rhanks | 11:13 |
| *** udesale has quit IRC | 11:15 | |
| *** ricolin_ is now known as ricolin | 11:15 | |
| *** ociuhandu has joined #openstack-nova | 11:17 | |
| *** abhishekk has quit IRC | 11:18 | |
| *** bbowen has joined #openstack-nova | 11:18 | |
| *** sapd1_x has quit IRC | 11:20 | |
| sean-k-mooney | artom looking at those links i dont see the question. you seam to have already ansered all the questions that were asked. but as i said ill go through the series fully today | 11:21 |
| *** ociuhandu has quit IRC | 11:22 | |
| artom | sean-k-mooney, it's about making sure the way I generate LibvirtLiveMigrateNUMAInfo on the dest and use it to update the XML on the source is sane, specifically around updating the <vcpu> element from cpu_set | 11:23 |
| artom | sean-k-mooney, mriedem's review on PS60 of https://review.opendev.org/#/c/635229/ | 11:24 |
| artom | "Looks OK compared to PS58 but with the changes for allocation pin set I'm going to need to have Sean and Stephen look at this first." | 11:24 |
| *** kaisers has joined #openstack-nova | 11:28 | |
| *** tbachman has joined #openstack-nova | 11:39 | |
| *** ociuhandu has joined #openstack-nova | 11:41 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Validate CPU config options against running instances https://review.opendev.org/680107 | 11:48 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Use sane indent https://review.opendev.org/680229 | 11:48 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add 'NUMACell.pcpuset' field https://review.opendev.org/680108 | 11:48 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800 | 11:48 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571 | 11:48 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | 11:48 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | 11:48 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Interim follow ups for cpu-resources series https://review.opendev.org/680983 | 11:48 |
| *** macz has joined #openstack-nova | 11:54 | |
| *** markvoelker has joined #openstack-nova | 11:56 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make _revert_allocation nested allocation aware https://review.opendev.org/676138 | 11:57 |
| *** macz has quit IRC | 11:58 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support reverting migration / resize with bandwidth https://review.opendev.org/676140 | 11:59 |
| *** markvoelker has quit IRC | 12:02 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972 | 12:02 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980 | 12:05 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | 12:07 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Do not query allocations twice in finish_revert_resize https://review.opendev.org/678827 | 12:09 |
| *** ivve has joined #openstack-nova | 12:10 | |
| *** hamzy_ has joined #openstack-nova | 12:11 | |
| *** markvoelker has joined #openstack-nova | 12:12 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow resizing server with port resource request https://review.opendev.org/679019 | 12:12 |
| *** jawad_axd has joined #openstack-nova | 12:21 | |
| *** ociuhandu has quit IRC | 12:21 | |
| *** rcernin has quit IRC | 12:22 | |
| *** jawad_axd has quit IRC | 12:25 | |
| *** ratailor has quit IRC | 12:26 | |
| *** luksky has quit IRC | 12:29 | |
| efried | alex_xu: cpu-resources, can you assert that https://review.opendev.org/#/c/671800/ is at least the right design, just needs a few tweaks? If so, I can take the hold off the bottom and we can start merging these. | 12:34 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extract pf$N literals as constants from func test https://review.opendev.org/680991 | 12:34 |
| *** jawad_axd has joined #openstack-nova | 12:39 | |
| *** nweinber has joined #openstack-nova | 12:42 | |
| *** tbachman has quit IRC | 12:42 | |
| *** ociuhandu has joined #openstack-nova | 12:43 | |
| *** damien_r has joined #openstack-nova | 12:43 | |
| *** jawad_axd has quit IRC | 12:44 | |
| *** tbachman has joined #openstack-nova | 12:45 | |
| *** jawad_axd has joined #openstack-nova | 12:45 | |
| *** ociuhandu has quit IRC | 12:48 | |
| *** damien_r has quit IRC | 12:48 | |
| *** jawad_axd has quit IRC | 12:50 | |
| *** jawad_ax_ has joined #openstack-nova | 12:50 | |
| *** rpittau|bbl is now known as rpittau | 12:55 | |
| *** BjoernT has joined #openstack-nova | 12:56 | |
| *** gbarros has joined #openstack-nova | 12:56 | |
| *** mriedem has joined #openstack-nova | 12:57 | |
| mriedem | bauzas: the bottom 5 changes of the bw provider migration series is +2ed starting at https://review.opendev.org/#/c/680394/ if you have time today to look through those | 13:02 |
| bauzas | mriedem: yup, I told gibi I was planning to do it today | 13:02 |
| bauzas | for the moment, cpu-resources | 13:02 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Improve dest service level func tests https://review.opendev.org/680998 | 13:02 |
| gibi | mriedem: I've fixed up the 6th patch in the series https://review.opendev.org/#/c/676138 (was -W before) | 13:03 |
| gibi | mriedem: and proposed the followups | 13:03 |
| gibi | mriedem: from the earlier patches | 13:03 |
| mriedem | gibi: yup i saw, i will review those today | 13:03 |
| gibi | mriedem: thanks! | 13:03 |
| gibi | I'm +2 on the forbidden agregates series, but I guess we need dansmith for that | 13:04 |
| mriedem | artom: on the numa live migration series you said that https://review.opendev.org/#/c/680739/ should be good for the test job we're looking at (with the old label) but we haven't had a run of that on the latest patch series you posted on saturday, right? | 13:06 |
| mriedem | i just kicked it off so we'll hopefully have results today | 13:06 |
| Luzi | efried, i wanted to restore the image encryption spec, but i don't have the restore button as it seems. Could you restore it for me? Thank you :) | 13:09 |
| mriedem | Luzi: you have to re-propose it for ussuri anyway | 13:09 |
| mriedem | and address feedback from the train spec | 13:09 |
| mriedem | oh but i guess you want the same change id, | 13:09 |
| mriedem | yeah sec | 13:09 |
| mriedem | Luzi: got a link? | 13:10 |
| mriedem | https://review.opendev.org/#/c/608696/ | 13:10 |
| artom | mriedem, I thought we did - sean-k-mooney told me to use recheck, not check experimental | 13:10 |
| *** tbachman has quit IRC | 13:10 | |
| mriedem | artom: if it's in the experimental queue you have to do "check experimental" since it's on-demand | 13:10 |
| artom | mriedem, right, https://zuul.opendev.org/t/openstack/build/435aded2c1934212a87c6efcc3df0f44 | 13:10 |
| mriedem | Luzi: done | 13:10 |
| Luzi | mriedem, thank you :) | 13:10 |
| artom | mriedem, I'm not sure how he set it up, but it ran and passed | 13:10 |
| mriedem | artom: yeah but i don't think on the latest changes | 13:11 |
| mriedem | Zuul experimentalSep 7 2:36 AM was the last run | 13:11 |
| artom | mriedem, Sep 7 10:54 AM Hrmm maybe not | 13:11 |
| mriedem | Artom Lifshitz Uploaded patch set 60. Sep 7 8:26 AM | 13:11 |
| artom | mriedem, in any case, 'recheck' is definitely the thing to do on the DNM patches | 13:11 |
| *** etp has quit IRC | 13:12 | |
| artom | Zuul | 13:12 |
| artom | Sep 7 10:54 AM | 13:12 |
| artom | Patch Set 1: Verified+1 | 13:12 |
| artom | Build succeeded (check pipeline). | 13:12 |
| artom | nova-nfv-multi-numa-multinode SUCCESS in 56m 56s | 13:12 |
| mriedem | oh i guess it is in check https://review.opendev.org/#/c/680739/1/.zuul.yaml@573 | 13:12 |
| artom | mriedem, and in case you missed it, I set up https://review.opendev.org/#/c/680806/ to run in the gate with the vcpu_pin_set configured, to give the new allocation_cpu_tuning stuff a smoke check | 13:13 |
| mriedem | it also showed up in experimental which is why i was confused | 13:13 |
| artom | It won't change allocation_cpu_pins because vcpu_pin_set is identical on both hosts, but it'll run through the code | 13:13 |
| *** luksky has joined #openstack-nova | 13:14 | |
| *** tbachman has joined #openstack-nova | 13:16 | |
| *** udesale has joined #openstack-nova | 13:20 | |
| *** KeithMnemonic has joined #openstack-nova | 13:24 | |
| openstackgerrit | Ivaylo Mitev proposed openstack/nova master: VMware: Update flavor-related metadata upon instance resize https://review.opendev.org/681004 | 13:25 |
| brinzhang | mriedem: https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/add-user-id-field-to-the-migrations-table | 13:25 |
| brinzhang | mriedem: this patch can be merged in Train? | 13:25 |
| mriedem | brinzhang: maybe, i have higher priority things to review first today | 13:26 |
| brinzhang | mriedem: thanks | 13:26 |
| sean-k-mooney | mriedem: the DNM test pataches have it in check with all other jobs disable so that it runs when i upload a patch and does not wast gate time by running all the other experimental jobs | 13:29 |
| sean-k-mooney | mriedem: sorry for the confusion | 13:29 |
| mriedem | yeah this is confusing https://review.opendev.org/#/c/680739/1/.zuul.yaml@629 | 13:30 |
| sean-k-mooney | mriedem: im not really sure why the old lable works and the new one does not but im going update the base patch to use the old lable after the current jobs complete | 13:30 |
| mriedem | brinzhang: can you rebase https://review.opendev.org/#/c/673485/12 on https://review.opendev.org/#/c/670790/8 ? | 13:30 |
| mriedem | there is a merge conflict | 13:30 |
| brinzhang | mriedem: Today, I was rebased it, now has a merge conflict? | 13:32 |
| *** ganso has joined #openstack-nova | 13:32 | |
| mriedem | it has to be rebased on the latest patch set of 670790 | 13:33 |
| sean-k-mooney | mriedem: by the way i configured the jobs to run in expermental and perodic since we only have 1 provider but would you be open to adding it as non voting in check at some point. non voiting jobs dont break the pipeline if they cant run because the provider is down. | 13:33 |
| brinzhang | mriedem: Okay, I will reabse it now. | 13:33 |
| ganso | hello folks! I am trying to use "openstack usage list" which according to this commit https://review.opendev.org/#/c/639652/2/openstackclient/compute/v2/usage.py should be able to handle microversions 2.40, but using --debug I see it is always using 2.1. Is there any way to force openstack CLI to use nova microversions 2.40? My OpenStack CLI is version 3.19 | 13:33 |
| mriedem | sean-k-mooney: maybe | 13:34 |
| *** Luzi has quit IRC | 13:34 | |
| artom | ganso, openstack --help, you'll see an option named something like --os-compute-api-version | 13:34 |
| *** ociuhandu has joined #openstack-nova | 13:34 | |
| *** jangutter_ has joined #openstack-nova | 13:34 | |
| artom | ganso, osc defaults to using the lowest possible microversion, aka 2.1 | 13:34 |
| sean-k-mooney | mriedem: ok well im beign conservitve and wanted to get some confidence form the periodic job before proposing that. | 13:35 |
| ganso | artom: thanks! | 13:35 |
| *** jangutter has quit IRC | 13:35 | |
| artom | ganso, also, in the future, please direct similar questions to #openstack (see /topic) | 13:35 |
| mriedem | the help on that osc command should be updated to mention using 2.40 or above for paging otherwise the user would have no way of knowing that w/o looking at code | 13:35 |
| ganso | artom: will do! thank you very much! | 13:36 |
| ganso | mriedem: +1 | 13:36 |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.79: Add delete_on_termination to volume-attach API https://review.opendev.org/673485 | 13:37 |
| brinzhang | mriedem: Done of that reabased. | 13:38 |
| *** ociuhandu has quit IRC | 13:39 | |
| luyao | dansmith: Hi Dan, could you have a look again at https://review.opendev.org/#/c/678447/ and https://review.opendev.org/#/c/678448/, about 'resource' db and object. I'll appreciate that . | 13:39 |
| *** BjoernT_ has joined #openstack-nova | 13:41 | |
| *** BjoernT has quit IRC | 13:44 | |
| *** awalende has quit IRC | 13:44 | |
| *** awalende has joined #openstack-nova | 13:45 | |
| *** prometheanfire has quit IRC | 13:49 | |
| *** awalende has quit IRC | 13:49 | |
| *** prometheanfire has joined #openstack-nova | 13:50 | |
| *** beekneemech is now known as bnemec | 13:54 | |
| *** priteau has joined #openstack-nova | 13:54 | |
| stephenfin | If I cold migrate an instance but don't confirm it, I should expect to see VCPU usage for the instance on both the source and destination, right? | 13:55 |
| bauzas | stephenfin: what's your concern ? | 13:56 |
| bauzas | allocations, you mean ? | 13:56 |
| stephenfin | yeah | 13:57 |
| stephenfin | allocations | 13:57 |
| bauzas | if so, yeah | 13:57 |
| stephenfin | an allocation for the instance, an allocation for the migration record | 13:57 |
| bauzas | correct | 13:57 |
| artom | stephenfin, you mean based on other existing behaviour? | 13:57 |
| artom | I believe so - the instance is consuming resources on the source, the migration on the dest | 13:57 |
| stephenfin | sweet | 13:57 |
| bauzas | the original allocation is transformed to have the consumer to be the migration UUID instead of the instance | 13:58 |
| *** BjoernT_ has quit IRC | 13:58 | |
| bauzas | and then we create a new allocation for the instance | 13:58 |
| bauzas | having the consumer be the instance UUID | 13:58 |
| bauzas | artom: the other way | 13:58 |
| artom | bauzas, I was talking about the old-school resources tracker | 13:59 |
| stephenfin | next question: I thought by default a cold migration would never land on another host, but that's not what I'm seeing in functional tests | 13:59 |
| artom | ... which I guess stephenfin no longer cares about? | 13:59 |
| bauzas | artom: stephenfin: https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/migration-allocations.html | 13:59 |
| artom | stephenfin, other way around, I think | 13:59 |
| artom | By default it always goes to different host | 14:00 |
| bauzas | correct ^ | 14:00 |
| stephenfin | artom: yeah, sorry, never land on the _same_ host | 14:00 |
| artom | And then if you set the allow_resize_to_same_host option, it can land on the same host | 14:00 |
| bauzas | unless you modify an option $ | 14:00 |
| bauzas | yeah what artom said | 14:00 |
| artom | (Or whatever it's called) | 14:00 |
| bauzas | artom: that is the correct option name | 14:00 |
| stephenfin | weeird | 14:02 |
| stephenfin | there must be something else going on here so | 14:02 |
| * stephenfin dives deeper | 14:02 | |
| artom | stephenfin, so, dunno if this is relevant, but while working on the the NUMA LM func tests, I noticed there was an issue in how you started computes with different fakelibvirt connections for each | 14:02 |
| stephenfin | shoot | 14:02 |
| artom | stephenfin, https://review.opendev.org/#/c/672595/45/nova/tests/functional/libvirt/base.py | 14:02 |
| artom | Again, no idea if that's what's causing your thing now, but could be relevant | 14:03 |
| stephenfin | oh, fun | 14:04 |
| *** eharney has joined #openstack-nova | 14:04 | |
| *** BjoernT has joined #openstack-nova | 14:08 | |
| *** BjoernT_ has joined #openstack-nova | 14:12 | |
| *** jawad_ax_ has quit IRC | 14:12 | |
| stephenfin | artom: The other approach is this one https://review.opendev.org/#/c/678470/24/nova/tests/unit/virt/libvirt/fakelibvirt.py | 14:12 |
| *** jawad_axd has joined #openstack-nova | 14:13 | |
| stephenfin | which I think accomplishes much the same thing | 14:13 |
| *** ociuhandu has joined #openstack-nova | 14:13 | |
| *** BjoernT has quit IRC | 14:13 | |
| stephenfin | there are quite a few in-flight changes with those files atm :) | 14:13 |
| *** jawad_axd has quit IRC | 14:13 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Follow-up: Add delete_on_termination to volume-attach API https://review.opendev.org/680655 | 14:15 |
| artom | stephenfin, and then you stub that connection into each compute manager I guess? | 14:15 |
| artom | Oh, that's not your patch | 14:15 |
| artom | Hrmm | 14:15 |
| kashyap | aspiers: Any reason you know this method is in virt/hardware.py -- _get_flavor_image_meta()? It can be used by "non-hardware"-related features, too | 14:17 |
| aspiers | kashyap: git blame? | 14:17 |
| kashyap | Maybe a question for stephenfin, as he wrote that :-) | 14:17 |
| *** ociuhandu has quit IRC | 14:17 | |
| kashyap | aspiers: Already did; 48e0c000fefe561ec5cfa1364ef2cac2f6ce9244 | 14:17 |
| kashyap | aspiers: stephenfin: Actually, disregard...it makes sense, because of the 'hw' key :D | 14:18 |
| *** rouk has joined #openstack-nova | 14:20 | |
| *** awalende has joined #openstack-nova | 14:25 | |
| *** belmoreira has joined #openstack-nova | 14:27 | |
| *** awalende has quit IRC | 14:29 | |
| *** dklyle has joined #openstack-nova | 14:29 | |
| *** lpetrut has quit IRC | 14:30 | |
| *** bhagyashris has joined #openstack-nova | 14:35 | |
| dansmith | mriedem: assume you'll take another trip through the numa patches today? I'm about to start into the forbidden garden of aggregates | 14:35 |
| *** ociuhandu has joined #openstack-nova | 14:35 | |
| *** maciejjozefczyk has joined #openstack-nova | 14:35 | |
| bhagyashris | mriedem: Hi | 14:35 |
| mriedem | dansmith: i was going over them over the weekend but stopped short of the big one | 14:36 |
| mriedem | waiting on ci results in the special job | 14:36 |
| dansmith | ah cool | 14:36 |
| mriedem | https://review.opendev.org/#/c/635229/ has new wizardry that is going to require stephenfin and/or sean-k-mooney | 14:37 |
| *** Tianhao_Hu has joined #openstack-nova | 14:37 | |
| *** Tianhao_Hu has left #openstack-nova | 14:37 | |
| *** maciejjozefczyk_ has quit IRC | 14:39 | |
| *** ociuhandu has quit IRC | 14:39 | |
| *** markvoelker has quit IRC | 14:41 | |
| *** mtreinish has quit IRC | 14:41 | |
| sean-k-mooney | mriedem: is that the patch you had question relating to the xml generation on | 14:42 |
| sean-k-mooney | mriedem: if there is a specific thing you wanted me to look at i can do it quickly otherwise im going to finish with stephenfin series then start on artoms | 14:44 |
| artom | sean-k-mooney, the new allocation_cpu_tuning, to cover the case when an instance with no NUMA topology is on a host with vcpu_pin_set | 14:45 |
| sean-k-mooney | ah right | 14:45 |
| sean-k-mooney | this https://review.opendev.org/#/c/635229/60/nova/virt/libvirt/migration.py@101 | 14:46 |
| artom | So actually the field is new in https://review.opendev.org/#/c/634827/ | 14:46 |
| artom | sean-k-mooney, well, PS61 is the latest but yeah | 14:46 |
| dansmith | efried: shilpasd: I found something else on the base patch for forbidden aggregates | 14:47 |
| dansmith | I'm pretty sure we don't deepcopy() the default value, which is why I did default=None for the "aggregates" field right above it. | 14:47 |
| dansmith | either way, it should be consistent I think, and I expect =None is more clearly safe than a default of something mutable (like mutable default arguments for methods in python) | 14:48 |
| *** macz has joined #openstack-nova | 14:48 | |
| sean-k-mooney | mriedem: artom so the context for this is that since we added the vcpu_pin_set option, if you have used it we have relied on operators ensuring that all host in the same host aggrate/availablity zone (depending on how you choose to defien the region you can live migrate vm within) has vcpu_pin_set set to the same value | 14:48 |
| *** luksky has quit IRC | 14:48 | |
| shilpasd | dansmith: Thanks for review | 14:49 |
| *** maciejjozefczyk_ has joined #openstack-nova | 14:49 | |
| dansmith | shilpasd: does my comment make sense? | 14:49 |
| dansmith | shilpasd: also, if you're not able to make this change right away I could probably just do it myself | 14:50 |
| sean-k-mooney | mriedem: more specifically if you define vcpu_pin_set we copy the value into <vcpu cpuset=vcpu_pin_set> for all instnace but we never updated that on live migration | 14:50 |
| *** maciejjozefczyk_ has quit IRC | 14:50 | |
| shilpasd | dansmith: yes, your comment make sense, will have test cases with default config (i.e. no filter remove or append) and with remove and with append | 14:50 |
| *** belmoreira has quit IRC | 14:50 | |
| *** maciejjozefczyk_ has joined #openstack-nova | 14:50 | |
| sean-k-mooney | so since artom is fixing it for numa instance we asked him to fix non numa instance too | 14:50 |
| mriedem | sean-k-mooney: the config option help for that says nothing about that assumption/requirement https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.vcpu_pin_set | 14:51 |
| stephenfin | TIL 'functional.libvirt.base.ServersTestBase' uses API v2.0 by default. That's two hours I won't get back \o/ | 14:51 |
| dansmith | shilpasd: oh you're talking about the later one | 14:51 |
| dansmith | shilpasd: I +2d that already, so don't change it, and/or change it in a followup | 14:51 |
| *** maciejjozefczyk has quit IRC | 14:51 | |
| dansmith | shilpasd: I _just_ left a more complicated comment on the base patch, so go look at that real quick | 14:51 |
| sean-k-mooney | mriedem: that is the entire orginal reason it was intoduced. to define the set of cpu that guest can run on. it was not just for pinned/numa instance | 14:52 |
| *** ociuhandu has joined #openstack-nova | 14:52 | |
| mriedem | sean-k-mooney: ok....that doesn't mean much to me since i'm not familiar with when or why that was added, | 14:52 |
| mriedem | i'm just saying, "if you have used it we have relied on operators ensuring that all host in the same host aggrate/availablity zone (depending on how you choose to defien the region you can live migrate vm within) has vcpu_pin_set set to the same value" is not documented | 14:52 |
| mriedem | so undocumented assertions are kind of....hairy | 14:53 |
| artom | mriedem, yep, which why with this new allocation_cpu_tuning stuff, it won't be necessary | 14:53 |
| artom | Previously we hoped both dest and source had it set the same for LM to work | 14:53 |
| artom | Now we handle them being different | 14:53 |
| mriedem | i see there is a todo about it in https://docs.openstack.org/nova/latest/user/flavors.html?highlight=vcpu_pin_set | 14:53 |
| sean-k-mooney | mriedem: ah ok its not documented upstream correct. it used to be documented in intels referece architecure as the way we advised people to partition cpu for the host/guest | 14:54 |
| *** tbachman has quit IRC | 14:54 | |
| *** jangutter has joined #openstack-nova | 14:54 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | 14:54 |
| *** jangutter_ has quit IRC | 14:55 | |
| sean-k-mooney | mriedem: the behavior if you did not have them the same was that provide all the cores existed on the destinatinon, the migration would suceeed but the vm would use the wrong cores until it was hard rebooted | 14:55 |
| *** mlavalle has joined #openstack-nova | 14:55 | |
| sean-k-mooney | mriedem: if the core did not exist on the dest host then libvirt would reject the migration | 14:55 |
| sean-k-mooney | so it was a self correcting problem once the guest hard rebooted | 14:55 |
| mriedem | super | 14:56 |
| *** belmoreira has joined #openstack-nova | 14:56 | |
| stephenfin | mriedem: can we easily mutate policy in tests? | 14:56 |
| mriedem | so tl;dr artom's series fixes that now so you don't have to have strict isolation and config in aggregates now? | 14:56 |
| mriedem | stephenfin: yes | 14:56 |
| sean-k-mooney | mriedem: yes | 14:56 |
| mriedem | stephenfin: check functional tests thta use the PolicyFixture | 14:56 |
| stephenfin | sweet. ta | 14:56 |
| artom | mriedem, for that particular option, anyways | 14:57 |
| artom | (vcpu_pin_set) | 14:57 |
| mriedem | stephenfin: e.g. self.policy_fixture.set_rules({ | 14:57 |
| mriedem | servers_policies.ZERO_DISK_FLAVOR: base_policies.RULE_ADMIN_API}, | 14:57 |
| mriedem | overwrite=False) | 14:57 |
| shilpasd | dansmith: yes cleared, will address for now 'complicated comment on the base patch' | 14:58 |
| dansmith | heh okay | 14:59 |
| *** jroll has joined #openstack-nova | 15:00 | |
| *** markmcclain has joined #openstack-nova | 15:02 | |
| *** gyee has joined #openstack-nova | 15:07 | |
| *** markmcclain has quit IRC | 15:12 | |
| *** jaosorior has quit IRC | 15:12 | |
| *** maciejjozefczyk_ has quit IRC | 15:14 | |
| openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.78 - show server topology https://review.opendev.org/670790 | 15:14 |
| sean-k-mooney | artom: mriedem by the way we will need the <vcpu cpuset> xml update code for stephens pcup series too | 15:15 |
| sean-k-mooney | so this is generally good to have anyway. it would be needed for non pinned guests when cpu_share_set is defiended | 15:16 |
| mriedem | i don't really know anything about that series or how it's going to work but ok | 15:16 |
| sean-k-mooney | *when cpu_shared_set is defined to different value on different hosts | 15:16 |
| sean-k-mooney | mriedem: well we are just using cpu_shared_set instead of vcpu_pinned_set for the same behavior | 15:17 |
| sean-k-mooney | e.g. defineing the set of core floating vms can float over | 15:17 |
| *** tbachman has joined #openstack-nova | 15:18 | |
| *** ivve has quit IRC | 15:19 | |
| mriedem | so do we expect instances using PCPU resources to be able to live migrate in Train with that series? | 15:21 |
| *** shilpasd has quit IRC | 15:21 | |
| sean-k-mooney | yes | 15:22 |
| *** jawad_axd has joined #openstack-nova | 15:22 | |
| sean-k-mooney | if both seris merge we expect to be able to live migrate with PCPUs or VCPUs and have the xmls updated correctly in both cases | 15:22 |
| bauzas | mriedem: this series will only support PCPU allocations once *all* computes are Train | 15:23 |
| sean-k-mooney | mriedem: we defered instance have both pcpus and vcpus at the same time to U or later | 15:23 |
| bauzas | mriedem: once the operator modifies an option | 15:23 |
| sean-k-mooney | bauzas: correct. all of this is opt in. if you dont modify the configs for the PCPU seriese then you keep the old behavior | 15:24 |
| sean-k-mooney | which is what we need for upgrades. and hopeful in U we can start enableing thing by defualt before removing the legacy options in V | 15:24 |
| mriedem | bauzas: that wasn't what i asked | 15:25 |
| bauzas | hum okay | 15:25 |
| sean-k-mooney | bauzas: mriedem was asing will the numa migration feature wokr with instance that have PCPU allocations | 15:26 |
| sean-k-mooney | *asking | 15:26 |
| bauzas | ok | 15:26 |
| *** jawad_axd has quit IRC | 15:26 | |
| donnyd | sean-k-mooney: just an FYI got an electrician out this weekend to do my standby generator. Which means power had to be shutdown for 8 hours.. which means FN was taken out of the pool on Saturday | 15:27 |
| *** bhagyashris has quit IRC | 15:27 | |
| artom | sean-k-mooney, and it will? To me it seems like black magic that it would, but I guess it makes sense | 15:28 |
| donnyd | So the NUMA job won't schedule until it comes back online. If I am really lucky the propane guy will be here today to finish up that install and then FN will be back online whether I have commercial power or not | 15:28 |
| artom | NUMA LM just consumes _get_guest_numa_config, and then plays with the XML | 15:28 |
| mriedem | sean-k-mooney: sort of, but without numa | 15:28 |
| sean-k-mooney | donnyd: yep i saw the update on openstack infra | 15:29 |
| mriedem | sean-k-mooney: since you said the pcpu stuff would need what artom is adding anyway, i was wondering if we expected instances with pcpu allocations to live migrate in train, not specific to numa though | 15:29 |
| mriedem | b/c i think pcpu in train is already very risky, and trying to say that live migration would work for those as well was doubly risky | 15:29 |
| sean-k-mooney | mriedem: all instance with pcpus have a numa toplogy | 15:29 |
| mriedem | oh | 15:29 |
| sean-k-mooney | hw:cpu_policy=dedicate create a numa toplogy of 1 the same as hw:numa_nodes=1 | 15:30 |
| *** tssurya has quit IRC | 15:30 | |
| sean-k-mooney | same with hw:mem_page_size set to anything | 15:30 |
| artom | sean-k-mooney, I think he means stephenfin's new PCPU resource class | 15:30 |
| sean-k-mooney | yep | 15:30 |
| sean-k-mooney | the only thing that will use that are things with hw:cpu_policy=dedicated | 15:30 |
| artom | Oh, right, that's how we end up with instances with that resource | 15:30 |
| mriedem | hmm, is that just libvirt specific or actually codified into how the code outside of the driver works? | 15:31 |
| artom | By doing anything NUMA-y | 15:31 |
| sean-k-mooney | so all things with PCPUs will have numa | 15:31 |
| *** ociuhandu has quit IRC | 15:31 | |
| sean-k-mooney | mriedem: technically just libvirt but no other dirver currely support pinning | 15:31 |
| sean-k-mooney | mriedem: the api does not require the guest to have a numa toplogy of 1 | 15:31 |
| sean-k-mooney | so people should not rely on it | 15:32 |
| sean-k-mooney | but that is what the only implmentaion does | 15:32 |
| stephenfin | sean-k-mooney: bikeshedding time. I need a name for this variable https://review.opendev.org/#/c/674895/30/nova/virt/libvirt/driver.py@7439 | 15:34 |
| stephenfin | I can't use allocations because that conflicts with an existing variable, and instance_allocations doesn't work since we're tracking migrations for both instances and migration records | 15:35 |
| stephenfin | instance_migration_allocations is too ugly | 15:35 |
| efried | bad_allocs? | 15:36 |
| *** shilpasd has joined #openstack-nova | 15:36 | |
| efried | although 'bad' isn't really a good adjective for them, in instances_with_bad_allocations either. | 15:36 |
| stephenfin | yeah, I've renamed the latter to 'allocations_needing_reshape' | 15:37 |
| efried | but instances_with_allocations_that_need_to_be_reshaped is unwieldy, as I'm sure you realized while you were working on this. | 15:37 |
| *** jawad_axd has joined #openstack-nova | 15:38 | |
| efried | stephenfin: btw, you've noticed there's a tox failure somewhere down the series yah? | 15:38 |
| stephenfin | Damn. I had not | 15:38 |
| * stephenfin fixes https://review.opendev.org/#/c/680107/ | 15:38 | |
| efried | looks like https://review.opendev.org/#/c/680983/1 | 15:39 |
| efried | stephenfin: at least ^ | 15:39 |
| *** cfriesen has joined #openstack-nova | 15:39 | |
| artom | stephenfin, "legacy_instances"? | 15:40 |
| stephenfin | artom: The list also contains UUIDs of migration records | 15:40 |
| stephenfin | so not quite right either | 15:40 |
| stephenfin | think I'll just stick '_' at the end and be done :) | 15:41 |
| artom | What, what are you trying to find a name for? instances_with_bad_allocations? | 15:41 |
| artom | "legacy_consumers", then? | 15:42 |
| stephenfin | oh, legacy_consumers it is | 15:42 |
| bauzas | stephenfin: a bit late but I do propose 'consumer_allocations' for your naming bikeshed | 15:42 |
| artom | mriedem, so, for my own information, did you get what you wanted out of sean-k-mooney, or do you need his "official" vote on that review? | 15:45 |
| bauzas | stephenfin: looks like something is fscked up https://c4d77360c4f137c70770-625a0eb0440aa527fbdb216e8991f5a6.ssl.cf1.rackcdn.com/680108/4/check/openstack-tox-py27/2b51adb/testr_results.html.gz | 15:46 |
| bauzas | stephenfin: I guess you have to modify the conf opt for vcpu_pin_set somewhere obviously :) | 15:47 |
| *** mkrai_ has quit IRC | 15:48 | |
| stephenfin | bauzas: sec | 15:49 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Interim follow ups for cpu-resources series https://review.opendev.org/680983 | 15:49 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Validate CPU config options against running instances https://review.opendev.org/680107 | 15:49 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Use sane indent https://review.opendev.org/680229 | 15:49 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add 'NUMACell.pcpuset' field https://review.opendev.org/680108 | 15:49 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800 | 15:49 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571 | 15:49 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | 15:49 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | 15:49 |
| mriedem | artom: i want an ack on the patch | 15:50 |
| mriedem | to show he's actually looked at your code change | 15:50 |
| bauzas | stephenfin: oh heh | 15:50 |
| artom | mriedem, understood | 15:52 |
| *** rpittau is now known as rpittau|afk | 15:54 | |
| bauzas | gibi: still looking at the cpu-resource series but you're next :) | 15:54 |
| *** igordc has joined #openstack-nova | 15:54 | |
| bauzas | not sure I'll have time before EOB, but tomorrow you're up :) | 15:54 |
| gibi | bauzas: no worries. I will end my day soon too | 15:54 |
| bauzas | gibi: the check pipeline is a bit late but if tomorrow we can send you some patches, it should be on time | 15:55 |
| gibi | fingers crossed :) | 15:56 |
| openstackgerrit | Merged openstack/nova master: doc: Fix a broken reference link https://review.opendev.org/680892 | 15:58 |
| mriedem | maybe melwitt can jump into that series | 16:00 |
| mriedem | those bottom 6 or so changes are min version validation and functional testing | 16:00 |
| mriedem | so there isn't a ton of context required | 16:00 |
| mriedem | losing a day this week with the gate backed up likely means missing feature freeze | 16:01 |
| bauzas | mriedem: I can work a bit overlate | 16:01 |
| mriedem | or we can have more cores reviewing more code for FF | 16:02 |
| *** jawad_axd is now known as JAX | 16:02 | |
| melwitt | gibi's series? I can help | 16:02 |
| mriedem | yeah, the bottom 6 changes are +2'ed, | 16:03 |
| gibi | melwitt: series starts here https://review.opendev.org/#/c/680394 | 16:03 |
| mriedem | the runtime code is just about min compute service version compat | 16:03 |
| gibi | melwitt: thanks in advance | 16:03 |
| melwitt | ok, thanks | 16:03 |
| mriedem | and then there are functional test changes on top of those | 16:03 |
| *** JAX is now known as JAX_ | 16:03 | |
| mriedem | melwitt: for context, compute rpc api 5.2 (service version 39) is what enables the compute side stuff https://review.opendev.org/#/c/655721/18/nova/objects/service.py | 16:04 |
| mriedem | so that's what those min compute service version checks are looking for | 16:04 |
| *** belmoreira has quit IRC | 16:04 | |
| melwitt | cool thanks | 16:05 |
| zbr | any chance to get pre-commit merged? https://review.opendev.org/#/c/665518/ | 16:06 |
| *** JAX_ is now known as JAX | 16:06 | |
| *** ircuser-1 has joined #openstack-nova | 16:07 | |
| *** tesseract has quit IRC | 16:07 | |
| *** igordc has quit IRC | 16:09 | |
| *** JAX has quit IRC | 16:12 | |
| *** jawad_axd has joined #openstack-nova | 16:12 | |
| *** sapd1_x has joined #openstack-nova | 16:14 | |
| *** jawad_axd has quit IRC | 16:14 | |
| sean-k-mooney | mriedem: artom i think donnyd said this earlier but FN is set to 0 capastiy currently as donnyd was having electical work done over the weekend. so the numa jobs are currenly not going to run | 16:16 |
| mriedem | sean-k-mooney: couldn't we use vexxhost? | 16:17 |
| artom | mriedem, sean-k-mooney, FWIW, the passing job ran with the allocations_cpu_tuning stuff | 16:18 |
| artom | I did the recheck at Sep 7 9:52 AM | 16:19 |
| sean-k-mooney | mriedem im going to reach out to mnaser to see if we can in the future but we need multi numa flaovr whic i dont think vexxhost currenly provide to the gate | 16:19 |
| artom | Having uploaded PS60 of https://review.opendev.org/#/c/635229/60/ at Sep 7 9:26 AM | 16:20 |
| mriedem | artom: did you confirm things in the logs as you'd expect? | 16:20 |
| mriedem | like xml you'd expect to see? | 16:20 |
| sean-k-mooney | mriedem: if vexxhost would be will to add one like the ones FN have added then yes we could use both vexxhost and FN for this | 16:20 |
| artom | The changes since then are basically comments: https://review.opendev.org/#/c/635229/60..61/nova/tests/unit/virt/libvirt/test_driver.py | 16:20 |
| artom | mriedem, yep, I even added debug logging to the _update_numa_xml method | 16:20 |
| mriedem | artom: yeah i saw and commented on PS61 | 16:20 |
| *** markvoelker has joined #openstack-nova | 16:21 | |
| sean-k-mooney | mnaser: not to put you on the spot but is creating a custom flavor for the upstream ci to consume possible/something you/vexxhost would be willing to consider? | 16:22 |
| artom | So for example input: https://zuul.opendev.org/t/openstack/build/dd0f5dad770d40a2afb3c506327d1b3e/log/compute/logs/screen-n-cpu.txt.gz#2081 | 16:22 |
| sean-k-mooney | mnaser: i can provide the detail later if so. | 16:22 |
| artom | And then output: https://zuul.opendev.org/t/openstack/build/dd0f5dad770d40a2afb3c506327d1b3e/log/compute/logs/screen-n-cpu.txt.gz#2195 | 16:22 |
| artom | We see the vcpupin go from 0-3 and 4-6 to 1-3 and 4-7 | 16:23 |
| *** dtantsur is now known as dtantsur|afk | 16:23 | |
| artom | And then for the allocations_cpu_tuning, I have https://review.opendev.org/#/c/680806/ | 16:23 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Don't duplicate PlacementFixture in libvirt func tests https://review.opendev.org/681059 | 16:24 |
| cdent | mriedem, efried ^ | 16:24 |
| artom | Again, input: https://zuul.opendev.org/t/openstack/build/f79144ae28114cea96e708d0bb5ebfb1/log/logs/screen-n-cpu.txt.gz#2565 | 16:24 |
| artom | And output: https://zuul.opendev.org/t/openstack/build/f79144ae28114cea96e708d0bb5ebfb1/log/logs/screen-n-cpu.txt.gz#2666 | 16:24 |
| donnyd | sean-k-mooney: artom correct FN is at zero for the moment | 16:24 |
| artom | <vcpu placement="static" cpuset="0">1</vcpu> in both cases | 16:24 |
| artom | Because I couldn't figure out how to set vcpu_pin_set per-node | 16:25 |
| artom | But at least it runs through the code | 16:25 |
| donnyd | The electrical work is all done.... Now just waiting on propane and FN will be back in business | 16:25 |
| sean-k-mooney | artom: i have set vcpu pin set per node in one of them | 16:25 |
| sean-k-mooney | artom: https://review.opendev.org/#/c/679805/ | 16:25 |
| sean-k-mooney | artom: and that also passed on saturday | 16:26 |
| artom | sean-k-mooney, what's with a NUMA flavor though, right? | 16:26 |
| mriedem | artom: ok can you link those into the patch for reference later? | 16:26 |
| sean-k-mooney | https://zuul.opendev.org/t/openstack/build/43f69768e18a4e1594810e606f101b6a | 16:26 |
| sean-k-mooney | artom: oh yes | 16:26 |
| artom | My DNM thing hits the other, non-NUMA case, to show that allocation_cpu_pins works | 16:26 |
| sean-k-mooney | well we could do it without a numa flavor later or i can stack and check it by hand now | 16:27 |
| *** spsurya has quit IRC | 16:27 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | 16:27 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: fakelibvirt: Make 'Connection.getHostname' unique https://review.opendev.org/681060 | 16:27 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Mock 'libvirt_utils.file_open' properly https://review.opendev.org/681061 | 16:27 |
| stephenfin | artom: https://review.opendev.org/#/c/681060/ | 16:29 |
| artom | stephenfin, way to steal credit brah ;) | 16:30 |
| stephenfin | desperate times /o\ | 16:31 |
| mriedem | co-authored-by | 16:31 |
| artom | stephenfin, you proll'y want to explain in more details what those lambda scoping issues were | 16:31 |
| stephenfin | I should have set the authorship now that I'm thinking about it | 16:31 |
| cdent | mriedem: I did a quick survey to look for other duplicate placement fixtures and did not find | 16:31 |
| bauzas | melwitt: gibi: I'm +W with the first 3 changes | 16:32 |
| artom | mriedem, to be fair, I didn't write *that* solution | 16:32 |
| artom | I just found the problem | 16:32 |
| cdent | that's me done for today I reckon | 16:32 |
| mriedem | cool | 16:32 |
| mriedem | thanks | 16:32 |
| bauzas | melwitt: gibi: see you tomorrow | 16:32 |
| artom | stephenfin, because they're really not obviousy | 16:32 |
| artom | *obvious | 16:32 |
| *** shilpasd has quit IRC | 16:32 | |
| *** N3l1x has joined #openstack-nova | 16:33 | |
| sean-k-mooney | i just clicked on it and no ideay lambda were related to this other then th efact i saw lambdas in the code so ya | 16:33 |
| *** sapd1_x has quit IRC | 16:38 | |
| artom | sean-k-mooney, btw, Matt's expecting a vote from you on that NUMA LM patch - just making sure everyone's on the same page :) | 16:44 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.79: Add delete_on_termination to volume-attach API https://review.opendev.org/673485 | 16:44 |
| *** jawad_axd has joined #openstack-nova | 16:45 | |
| mriedem | ^ i'm +2 on that novaclient change for 2.79 now | 16:47 |
| mriedem | need to get that merged and released by thursday, | 16:47 |
| mriedem | the osc change is also dependent o nit | 16:47 |
| *** ociuhandu has joined #openstack-nova | 16:48 | |
| sean-k-mooney | artom: ok i keep getting distracted by jumping between your stuff stephns patach and email. | 16:48 |
| sean-k-mooney | ill kick off a local devstack run with your latest patches then finish my review of stephns code and then review your code | 16:49 |
| artom | sean-k-mooney, I'll stop harassing you - just making sure expectations were clear | 16:49 |
| sean-k-mooney | sorry i ment to finish reviewing stephens code already | 16:49 |
| *** cdent has quit IRC | 16:50 | |
| sean-k-mooney | no worries i just need to focus. i started late today so ill be around for another few hours today | 16:50 |
| mnaser | sean-k-mooney, artom: i know we talked about this but i dont know what that implies on my side | 16:54 |
| mnaser | i can do the custom flavor side if someone wants to volunteer to update the nodepool/infra side of things, i'm a little backed up on things right now | 16:54 |
| artom | mnaser, thanks, but we may have jumped the gun on that | 16:55 |
| mnaser | np :) | 16:55 |
| sean-k-mooney | mnaser: i can do the nodepool/project-config changes | 16:55 |
| sean-k-mooney | mnaser: ideally in U it would be nice to have two providers | 16:56 |
| mnaser | someone will have to let me know how to do/setup the flavor | 16:56 |
| artom | sean-k-mooney, is that... necessary, at this point? | 16:56 |
| sean-k-mooney | artom: nessisary no prefered yes | 16:56 |
| artom | I know FN is... intermittent, but we got the runs we needed, didn't we? | 16:56 |
| artom | sean-k-mooney, agree on that. I guess you're thinking long term? | 16:56 |
| sean-k-mooney | artom: i want to get a perminet job running in U even if its only nightly | 16:57 |
| sean-k-mooney | artom: yes | 16:57 |
| artom | I was concentrating on the short term of getting the series merged | 16:57 |
| sean-k-mooney | we dont need a second provider to merge it correct | 16:57 |
| artom | No | 16:57 |
| sean-k-mooney | mnaser: its relitivly simple change i was going to wait until after feature freeze when you were less busy to bring it up | 16:58 |
| artom | So, mnaser, while I would definitely love to work with you and Sean (or, let's he honest, let Sean do all the work ;) on getting multi-NUMA flavors from vexxhost, I think we can wait until after FF | 16:58 |
| *** trident has quit IRC | 16:58 | |
| mnaser | no worries, does it require a patch or is it just a flavor with some extra_specs? | 16:58 |
| artom | mnaser, the latter | 16:58 |
| mnaser | ok so thats easy | 16:58 |
| sean-k-mooney | mnaser: but bassicaly jsut need to add hw:numa_nodes=2 an preferably also add hw:cpu_socket=2 and hw:cpu_threads=2 | 16:58 |
| donnyd | mnaser: yea I put in the flavor data and it just worked on FN | 16:59 |
| mnaser | cool, it should be ok for me to do that | 16:59 |
| donnyd | https://www.irccloud.com/pastebin/KXLeMoFH/ | 16:59 |
| donnyd | mnaser: snippet from FN | 17:00 |
| *** derekh has quit IRC | 17:00 | |
| sean-k-mooney | mnaser: donnyd create a multi-numa lable in nodepool for FN so ideally we woudl use the same one for vexhost to allow it to run on either. again thats a long term thing | 17:00 |
| sean-k-mooney | if we had that it would allow us to propaly test all the numa/pinning/hugepage things in the first party ci | 17:00 |
| sean-k-mooney | with multiple providers to make it redundatnt | 17:00 |
| artom | If we have multiple provider we could even make it more than just experimental (eventually) | 17:01 |
| sean-k-mooney | artom: yep, which is why longter i was hoping to reach out to vexhost and maybe packet to be addtional provier of this lable/flavor | 17:02 |
| sean-k-mooney | but that is a U thing not a now thing | 17:02 |
| artom | yep | 17:05 |
| *** trident has joined #openstack-nova | 17:06 | |
| *** gbarros has quit IRC | 17:09 | |
| *** gbarros has joined #openstack-nova | 17:13 | |
| donnyd | sean-k-mooney: I am going to put the compute service back in operation for FN | 17:13 |
| donnyd | Time is a little short and these resources are kinda needed...I don't want to hold up progress on the *hope that the propane guy actaully even makes it here today | 17:13 |
| *** gbarros has quit IRC | 17:14 | |
| donnyd | electrical work is all done.. | 17:14 |
| sean-k-mooney | we had good test result form satusrday and im locall redeploying the latest code | 17:15 |
| *** jmlowe has quit IRC | 17:18 | |
| donnyd | sean-k-mooney: just waiting on https://review.opendev.org/#/c/681075/ | 17:19 |
| donnyd | FN is up.. .just waiting on this to be able to run jobs | 17:20 |
| sean-k-mooney | ack. thanks | 17:20 |
| *** gbarros has joined #openstack-nova | 17:29 | |
| *** luksky has joined #openstack-nova | 17:33 | |
| *** ociuhandu has quit IRC | 17:34 | |
| *** jmlowe has joined #openstack-nova | 17:35 | |
| *** ociuhandu has joined #openstack-nova | 17:36 | |
| *** jangutter has quit IRC | 17:38 | |
| *** ricolin has quit IRC | 17:40 | |
| *** ociuhandu has quit IRC | 17:40 | |
| *** awalende has joined #openstack-nova | 17:46 | |
| mriedem | sean-k-mooney: when you're dug out from the current set of tasks, i found this last week and it's a question for you (or adrianc): https://review.opendev.org/#/c/634606/75..80/nova/compute/manager.py@a6504 | 17:48 |
| *** udesale has quit IRC | 17:49 | |
| *** ralonsoh has quit IRC | 17:49 | |
| *** awalende has quit IRC | 17:50 | |
| sean-k-mooney | mriedem: the sriov claim. ill look into that and respond. after im done with the rest of artoms stuff | 17:51 |
| *** spatel has joined #openstack-nova | 17:52 | |
| spatel | sean-k-mooney: ping | 17:52 |
| sean-k-mooney | spatel: hi. sorry dont really have much time to talk today. reviewing/testing several things in parallel | 17:53 |
| spatel | how do i rename instance name in command line? ( i can do that in GUI but i need command line) | 17:53 |
| *** ociuhandu has joined #openstack-nova | 17:53 | |
| spatel | sean-k-mooney: no worry, you keep going.. | 17:53 |
| sean-k-mooney | i didnt know you could rename an instance after it was booted so maybe. if its supported in the api it should be doable on the cli | 17:54 |
| sean-k-mooney | if not file a bug for the feature gap | 17:54 |
| artom | spatel, "rename"? Are you sure the GUI doesn't just delete it and create a new one? | 17:56 |
| spatel | I think "update" command should do that, rename is depricated | 17:56 |
| artom | It used to do that for "edit" flavor | 17:56 |
| donnyd | https://www.irccloud.com/pastebin/yhNgJLIr/ | 17:56 |
| spatel | In GUI i can just edit Instance name but i wanted to do with command line. | 17:56 |
| artom | spatel, huh, update seems to do it: https://docs.openstack.org/api-ref/compute/?expanded=update-server-detail#update-server | 17:57 |
| donnyd | openstack server set --name new name old-name | 17:57 |
| donnyd | sean-k-mooney: artom just like that | 17:58 |
| spatel | donnyd: it works :) openstack server set --name iptest-11 iptest-1 | 17:58 |
| donnyd | :) glad I could help | 17:58 |
| spatel | Thanks! | 17:59 |
| sean-k-mooney | im getting distracted but does that update the hostname in the metadata service extra or is it just in nova | 18:00 |
| sean-k-mooney | * in the server show | 18:00 |
| spatel | sean-k-mooney: in server show it changed hostname, i didn't check metadata | 18:03 |
| *** brault has joined #openstack-nova | 18:06 | |
| mriedem | artom: some fresh comments in https://review.opendev.org/#/c/634606/ | 18:08 |
| artom | mriedem, much thanks, looking | 18:10 |
| mriedem | sean-k-mooney: yes you're getting distracted, | 18:10 |
| mriedem | it updates the display name on the server | 18:10 |
| mriedem | not the underlying hostname presented to the guest | 18:10 |
| *** brault has quit IRC | 18:11 | |
| *** gbarros has quit IRC | 18:21 | |
| *** priteau has quit IRC | 18:23 | |
| *** jmlowe has quit IRC | 18:25 | |
| sean-k-mooney | artom: are you expecting your code to handel the non numa instances | 18:27 |
| artom | sean-k-mooney, yes... | 18:27 |
| sean-k-mooney | you code is not running in that case | 18:27 |
| artom | Well, only when vcpu_pin_set is configured | 18:28 |
| artom | Otherwise there's nothing to do | 18:28 |
| sean-k-mooney | i dont see the migration objecte being logged and the xml is not updated | 18:28 |
| sean-k-mooney | i have it configured | 18:28 |
| sean-k-mooney | and set to different values on each host | 18:28 |
| sean-k-mooney | oh wait | 18:28 |
| artom | Oh, made me realize a thing | 18:29 |
| artom | If the source has it, but dest doesn | 18:29 |
| artom | doesn't | 18:29 |
| artom | We need to remove cpuset from <vcpus> | 18:29 |
| sean-k-mooney | i still have the the versions pinned | 18:29 |
| artom | Which I don't think I'm doing | 18:29 |
| sean-k-mooney | for the rpc | 18:29 |
| sean-k-mooney | that is why its disabled | 18:29 |
| * dansmith puts sean-k-mooney's beating heart back in his chest | 18:29 | |
| sean-k-mooney | ill unping the rpc and test again | 18:30 |
| sean-k-mooney | shoudl i resterat all nova service for it to pick up the new rpc version | 18:31 |
| sean-k-mooney | oh both hosts | 18:31 |
| mriedem | artom: dansmith: comments in the big patch https://review.opendev.org/#/c/634606/80 | 18:31 |
| sean-k-mooney | *on | 18:32 |
| mriedem | -1 since changes need to be made, but we can decide if they can just be in a follow up after dansmith goes through it | 18:32 |
| artom | mriedem, dansmith, I need to fix https://review.opendev.org/#/c/635229/61 anyways | 18:32 |
| mriedem | i have to run to an appointment, back in a couple of hours | 18:32 |
| dansmith | I think we can just integrate the fixes into the main patch, if artom is okay with it | 18:33 |
| dansmith | and still have time to get it all landed tomorrow | 18:33 |
| mriedem | artom: ok, well try to coordinate that with sean's local testing and if dan is actively doing a review | 18:33 |
| dansmith | I'm still mulling this pcpu series, so I'm cool waiting until artom has put all your comments into the latest version | 18:33 |
| artom | dansmith, you're suggesting we start +W'ing the bottom patches and fix my own -1 later? | 18:34 |
| dansmith | I can plan to hit that one first thing tomorrow and hopefully be all good for mriedem to be happy with it | 18:34 |
| dansmith | artom: no I'm saying go ahead and fix those things | 18:34 |
| artom | OK rihgt, for a second there I didn't recognize you ;) | 18:34 |
| dansmith | glad we cleared that up :) | 18:35 |
| dansmith | I mean, we could land the bottom patch since its just setup, but I don't think we're down to that level of panic just yet | 18:36 |
| sean-k-mooney | dansmith: artom ok it does work correctly. and i guess i also confim that if you pin the rpc i also gets disabled as we expect | 18:36 |
| sean-k-mooney | sorry about that :) | 18:36 |
| dansmith | heh, good | 18:36 |
| sean-k-mooney | artom: ill try removing the vcpu_pin_set form one of the nodes and test that next. then ill go back to reviewing | 18:38 |
| sean-k-mooney | xml before and after http://paste.openstack.org/show/774347/ | 18:38 |
| artom | sean-k-mooney, if it's the dest I expect the XML to not be updated and still have cpuset | 18:38 |
| artom | (In <vcpu>) | 18:39 |
| dansmith | artom: isn't fixing LM for pinned non-numa instances kindof a happy side effect of this code? | 18:39 |
| dansmith | but not really the primary purpose? | 18:39 |
| sean-k-mooney | dansmith: yes it is | 18:39 |
| sean-k-mooney | so i dont think its a blocker for this | 18:39 |
| artom | dansmith, it's technically a tangent, correct | 18:40 |
| sean-k-mooney | its a very very latent bug/feature | 18:40 |
| dansmith | yeah, so I would be fine with that being a follow-on patch *if* it makes things easier | 18:40 |
| sean-k-mooney | ya i think a follow up patch makes sense | 18:40 |
| sean-k-mooney | provided this does not explode | 18:40 |
| dansmith | yeah, kinda like "now we have the infra in place to be able to fix this long-standing bug" | 18:40 |
| dansmith | artom: make sense? | 18:40 |
| artom | dansmith, hrmm. What I wanted to avoid was an objects version bump, but I suppose we could add allocation_cpu_tuning now in the object, and just not use it until the fup | 18:40 |
| dansmith | oh does that require extra fields? | 18:41 |
| artom | Yeah : | 18:41 |
| artom | :/ | 18:41 |
| *** ociuhandu has quit IRC | 18:41 | |
| dansmith | hmm, well, then maybe keeping that separate is also good just from the perspective of not increasing the scope of this already-large patch | 18:41 |
| sean-k-mooney | artom: you dont need extra fileds | 18:42 |
| sean-k-mooney | the ones in the current patch are enough | 18:42 |
| sean-k-mooney | you jsut wont populate it if its not set on the souce or dest | 18:42 |
| artom | sean-k-mooney, I mean adding allocations_cpu_pins | 18:42 |
| artom | We can't get around that, reusing cpu_pins isn't an option | 18:42 |
| sean-k-mooney | oh well you added that already | 18:42 |
| sean-k-mooney | but yes that was an extra filed that was needed | 18:43 |
| artom | sean-k-mooney, right, we're debating taking it back out to simplify things | 18:43 |
| dansmith | artom: this must have been added since the last time I looked? | 18:43 |
| artom | dansmith, yeah, over the weekend I think, or Friday | 18:43 |
| dansmith | okay I see it now | 18:44 |
| dansmith | well, I dunno.. another object bump isn't very impactful, tbh, so putting that in the follow-on patch to actually do the right thing for that case doesn't seem too bad, | 18:44 |
| dansmith | but also more churn doesn't make re-review easier | 18:44 |
| sean-k-mooney | if its not set then we shoudl ensure the cpuset attibute is not in the final xml othersize set it to its value | 18:45 |
| dansmith | so use your judgment I think | 18:45 |
| dansmith | but I think it's okay to exclude fixing that longstanding bug in your series and follow up with the actual fix, however that looks | 18:45 |
| sean-k-mooney | ok so if the souce does not have vcpu_pin_set and the dest has we go form <vcpu placement='static'>1</vcpu> to <vcpu placement='static' cpuset='4-7,12-15'>1</vcpu> | 18:46 |
| artom | dansmith, I know sunk costs is a fallacy, but I think at this point it'd be as much work (for me, anyways) to take it out as it would be to fix it | 18:46 |
| sean-k-mooney | which is what we expect | 18:46 |
| sean-k-mooney | now to check the other way around | 18:47 |
| dansmith | artom: copy that | 18:47 |
| artom | sean-k-mooney, I expect that to be broken | 18:47 |
| sean-k-mooney | well it works correctly | 18:47 |
| sean-k-mooney | source no vcpu_pin_set dest vcpu_pin_set works | 18:47 |
| sean-k-mooney | i need to test the other way now | 18:47 |
| artom | Yes *that's* the broken bit :) | 18:48 |
| sean-k-mooney | kind of | 18:48 |
| sean-k-mooney | it migrated but did not update | 18:49 |
| sean-k-mooney | which is the existing master behavior | 18:49 |
| artom | Yeah, it's what I mean by broken | 18:49 |
| artom | Technically I could it as is :D | 18:49 |
| sean-k-mooney | and a hard reboot fixes it | 18:49 |
| *** mdbooth has quit IRC | 18:49 | |
| artom | Talk about half-assed | 18:49 |
| artom | "I started fixing it, but then I saw something shiny" | 18:49 |
| sean-k-mooney | well you fix 3 or the 4 combindations | 18:50 |
| sean-k-mooney | it works when the dest has it set or both have it set | 18:50 |
| sean-k-mooney | just not when the souce only has it set | 18:50 |
| *** factor has joined #openstack-nova | 18:50 | |
| sean-k-mooney | so that is better then without your code by a large margin and in the final case it matains the old behavior | 18:51 |
| artom | Eh, I'd not be comfortable leaving it as is | 18:51 |
| sean-k-mooney | so its better or equal to the old behavior so i woudl leave it in and maybe add a todo which we can fix and backport later when we have time | 18:51 |
| artom | Take out completely, sure | 18:52 |
| artom | Fix it, yeah | 18:52 |
| artom | But not this half-assedness | 18:52 |
| *** vesper11 has quit IRC | 18:52 | |
| sean-k-mooney | ok well its up to you. either fix it or revert it out. im going to get stuff for dinner then contiue reviewing | 18:52 |
| sean-k-mooney | ill be afk for about an hour then ill be back | 18:53 |
| artom | sean-k-mooney, cheers! | 18:53 |
| *** BjoernT has joined #openstack-nova | 18:59 | |
| *** gbarros has joined #openstack-nova | 19:00 | |
| *** BjoernT_ has quit IRC | 19:00 | |
| openstackgerrit | Merged openstack/nova master: Add min service level check for migrate with bandwidth https://review.opendev.org/680394 | 19:09 |
| openstackgerrit | Merged openstack/nova master: migrate: Add bw min service level check of source compute https://review.opendev.org/680395 | 19:10 |
| *** BjoernT_ has joined #openstack-nova | 19:12 | |
| *** BjoernT has quit IRC | 19:13 | |
| *** henriqueof1 has joined #openstack-nova | 19:18 | |
| *** henriqueof1 has quit IRC | 19:20 | |
| *** eharney has quit IRC | 19:20 | |
| *** henriqueof has joined #openstack-nova | 19:20 | |
| openstackgerrit | Merged openstack/nova master: resize: Add bw min service level check of source compute https://review.opendev.org/680396 | 19:21 |
| openstackgerrit | Merged openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109 | 19:21 |
| *** bnemec has quit IRC | 19:27 | |
| *** bnemec has joined #openstack-nova | 19:32 | |
| artom | mriedem, finished addressing your "code" feedback, the tests feedback will be after school run and supper | 19:33 |
| artom | Oh, there's still https://review.opendev.org/#/c/634606/75/nova/compute/manager.py@7223 | 19:34 |
| artom | dansmith, ^^ you might have ideas, if you have time | 19:34 |
| artom | Sorry to ping and run, but that's what I have to do | 19:34 |
| * artom -> food prep/school run | 19:34 | |
| *** vesper11 has joined #openstack-nova | 19:41 | |
| *** ociuhandu has joined #openstack-nova | 19:51 | |
| *** jmlowe has joined #openstack-nova | 19:55 | |
| *** igordc has joined #openstack-nova | 20:00 | |
| *** ociuhandu has quit IRC | 20:03 | |
| *** ociuhandu has joined #openstack-nova | 20:03 | |
| *** jmlowe has quit IRC | 20:05 | |
| *** markmcclain has joined #openstack-nova | 20:10 | |
| *** nicolasbock has quit IRC | 20:11 | |
| openstackgerrit | Merged openstack/nova master: Func test for migrate server with ports having resource request https://review.opendev.org/655113 | 20:12 |
| *** nweinber has quit IRC | 20:14 | |
| *** trident has quit IRC | 20:15 | |
| *** ganso has quit IRC | 20:17 | |
| *** shilpasd has joined #openstack-nova | 20:18 | |
| *** ganso has joined #openstack-nova | 20:18 | |
| *** nicolasbock has joined #openstack-nova | 20:18 | |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter https://review.opendev.org/671072 | 20:19 |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata https://review.opendev.org/671074 | 20:19 |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates https://review.opendev.org/671075 | 20:19 |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Docs for isolated aggregates request filter https://review.opendev.org/667952 | 20:19 |
| *** gbarros has quit IRC | 20:22 | |
| *** ociuhandu has quit IRC | 20:22 | |
| *** ociuhandu has joined #openstack-nova | 20:22 | |
| dansmith | efried: around? | 20:23 |
| efried | dansmith: yah | 20:23 |
| dansmith | efried: gibi was +2 on this before I found one more thing that needed fixing in the object: https://review.opendev.org/#/c/671072/17..18/nova/objects/request_spec.py | 20:23 |
| efried | yah | 20:23 |
| dansmith | efried: permission to fast-approve since she made the change | 20:23 |
| efried | please do | 20:24 |
| efried | she had to fix some stuff up the pile for the new non-defaulting-to-set() as well. | 20:24 |
| dansmith | I saw | 20:25 |
| dansmith | efried: this one had a couple test tweaks from me which she also did, so I shan't fast-approve it, but maybe you can skim and get it underway: https://review.opendev.org/#/c/671075/20 | 20:25 |
| efried | on it now | 20:26 |
| dansmith | I don't think I've looked at the doc patch since it was megasplit so I'll leave that to you and gibi which have looked recently | 20:26 |
| *** ociuhandu has quit IRC | 20:27 | |
| *** trident has joined #openstack-nova | 20:27 | |
| efried | ack. Thanks for your work on this dansmith | 20:29 |
| shilpasd | dansmith: Gibi: Eric:Stephan: thank you for review | 20:30 |
| dansmith | aye | 20:30 |
| *** trident has quit IRC | 20:32 | |
| *** trident has joined #openstack-nova | 20:33 | |
| *** shilpasd has quit IRC | 20:38 | |
| *** jmlowe has joined #openstack-nova | 20:40 | |
| *** ociuhandu has joined #openstack-nova | 20:44 | |
| *** shilpasd has joined #openstack-nova | 20:48 | |
| *** mvkr has joined #openstack-nova | 20:48 | |
| openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Docs for isolated aggregates request filter https://review.opendev.org/667952 | 20:52 |
| openstackgerrit | Eric Fried proposed openstack/nova master: DNM: uncover func tests with mismatched allocations https://review.opendev.org/681122 | 20:52 |
| *** shilpasd76 has joined #openstack-nova | 20:56 | |
| *** shilpasd76 has quit IRC | 20:58 | |
| *** shilpasd has quit IRC | 20:59 | |
| *** jawad_axd has quit IRC | 21:01 | |
| *** markvoelker has quit IRC | 21:02 | |
| *** ociuhandu has quit IRC | 21:09 | |
| melwitt | mriedem: downstream this bug (fill_virtual_interface_list fails on second attempt) was hit and they proposed a patch with a different approach from the workaround you had worked on the past. I'm curious what you think about it https://review.opendev.org/678776 | 21:12 |
| *** markvoelker has joined #openstack-nova | 21:16 | |
| mriedem | ack, just getting caught up with scrollback | 21:20 |
| mriedem | dansmith: so tl;dr on artom's series is we're not sure about all of the non-numa vpu pinning stuff that was recently added? | 21:22 |
| mriedem | yeah this "now we have the infra in place to be able to fix this long-standing bug" | 21:23 |
| artom | mriedem, sean-k-mooney tested it, there's an edge case that we're missing, but otherwise we're pretty confident | 21:23 |
| mriedem | that's what i was thinking about that cpu pinning stuff being munged in | 21:23 |
| artom | As I said to dansmith, at this point, it'd be more work to yank it out than to fix it | 21:23 |
| artom | But I can go either way, if we want to be safe | 21:24 |
| artom | It is indeed technically out of scope, for a long-standing latent thing | 21:24 |
| mriedem | "also more churn doesn't make re-review easier" yup | 21:24 |
| mriedem | i feel like this is mostly a re-review each time for me | 21:24 |
| mriedem | it's not terrible though, but it definitely made me not able to feel comfortable with +2ing https://review.opendev.org/#/c/635229/ | 21:25 |
| artom | mriedem, I get you. I keep finding more stuff to fix. Maybe the non-NUMA instance thing I jumped the gun on | 21:26 |
| artom | Should have left it as is | 21:26 |
| *** spatel has quit IRC | 21:28 | |
| sean-k-mooney | mriedem: in the one case that is not covered by atroms code for the non numa instances it reverts to the master behavior | 21:40 |
| sean-k-mooney | mriedem: in the other cases the behaivor appears to be correct | 21:40 |
| sean-k-mooney | that said we could drop that change or add support for the last edgecase | 21:40 |
| sean-k-mooney | both of which are tangental to the main content of the series | 21:41 |
| mriedem | melwitt: i left comments, that's a bit hard to follow | 21:43 |
| mriedem | obviously needs tests and such | 21:43 |
| mriedem | it's been a long time since i remembered what triggered that bug | 21:44 |
| mriedem | sean-k-mooney: mo cases mo problems | 21:44 |
| *** lbragstad_ has joined #openstack-nova | 21:44 | |
| *** lbragstad has quit IRC | 21:44 | |
| mriedem | also, if that non-numa stuff is tracked in the LibvirtLiveMigrateNUMAInfo object, isn't that confusing given the name of the object? | 21:45 |
| sean-k-mooney | mriedem: well as i said the behvior is either identical to the behavior on master or fixed so its stitcly better. yes that did occure to me but i didnt think of a better name yet | 21:46 |
| melwitt | mriedem: ack, thanks | 21:46 |
| mriedem | sean-k-mooney: how about just not putting non-numa things a numa object for migrate_data? | 21:47 |
| sean-k-mooney | we could uses LibvirtLiveMigrateTopologyInfo | 21:47 |
| sean-k-mooney | to mirror the toplogy api? | 21:47 |
| sean-k-mooney | ya we could do that too | 21:47 |
| mriedem | that or just put a different field on LibvirtLiveMigrateData | 21:47 |
| mriedem | or otherwise yeah you need to make LibvirtLiveMigrateNUMAInfo more generic | 21:47 |
| artom | mriedem, in any case, it seems we have enough misgivings about this first whack at it to not go ahead | 21:47 |
| artom | And yeah, it's tangential to the NUMA case | 21:48 |
| artom | I lumped it in because it's triggered by the same code | 21:48 |
| artom | (driver._get_guest_numa_config) | 21:48 |
| mriedem | sure, scope creep | 21:49 |
| mriedem | killer of dreams and introducerer of regression bugs | 21:49 |
| artom | Ack | 21:49 |
| artom | Supper time, back after | 21:49 |
| sean-k-mooney | this fell like a thing we would fix if we had an extra week but since we dont if ye prefer to remove it or move it to a patch at the end i guess that makes sense | 21:50 |
| sean-k-mooney | i would perfer to keep it in in its half fixed state personllay but i also know how to work around it so ill leave that to ye to decided | 21:51 |
| sean-k-mooney | this is a behavior i have been ware of for years so i kind of just assume this was going to be fixed as part of either artoms work or stephens | 21:51 |
| *** BjoernT_ has quit IRC | 21:54 | |
| mriedem | i felt pretty happy with the progress we had by thursday last week, we had a working CI run, you had done manual testing of upgrade paths, etc. dan and i did solid reviews, so i was thinking just fixing up those comments and going over again would do it, but the non-numa scope creep stuff threw a wrench into the mix adding what appears to be unnecessary risk | 21:54 |
| mriedem | and this isn't the only thing i'm trying to review this week to get in so i'm not 100% focused on this, so frequently changing is costly | 21:55 |
| sean-k-mooney | mriedem: well we can always jsut revert to that version that had been tested | 21:55 |
| sean-k-mooney | ack | 21:55 |
| mriedem | he'll still have to make changes, but yeah i know | 21:55 |
| mriedem | it's going to need re-test either way i think since there were non-trivial changes outside of the non-numa pinning stuff since last week | 21:56 |
| mriedem | melwitt: maybe we can get imacdonn to re-test, but he doesn't appear to be around, | 21:56 |
| mriedem | but fwiw i was able to reproduce in devstack - i think i left notes in the bug report on how to do that | 21:56 |
| mriedem | so i'm also not against just recreating in devstack w/o the fix, then applying the fix and assert the issue is gone | 21:57 |
| mriedem | this security groups crap all gets burned out with nova-net at some point anyway | 21:57 |
| mriedem | the fact we create a default security group when using neutron is pointless anyway since it's not used | 21:57 |
| *** markvoelker has quit IRC | 21:59 | |
| *** markvoelker has joined #openstack-nova | 22:01 | |
| sean-k-mooney | artom: dansmith mriedem. if ye come to a decision on a path forward i will retest everything tommorow with whatever ye choose. | 22:01 |
| *** markvoelker has quit IRC | 22:06 | |
| *** ociuhandu has joined #openstack-nova | 22:10 | |
| mriedem | idk, i hate to make artom undo a bunch of work, but also don't like munging a bunch of other stuff in here just b/c it's convenient though out of scope | 22:10 |
| mriedem | i'd prefer to separate the non-numa pinning stuff out | 22:11 |
| mriedem | and deal with that later | 22:11 |
| *** lbragstad_ is now known as lbragstad | 22:11 | |
| sean-k-mooney | i.e. make it a patch at the end | 22:11 |
| sean-k-mooney | that we can merge when we get to it | 22:11 |
| mriedem | yes | 22:12 |
| mriedem | think of it like someone pushing a bug fix that also refactors a bunch of code unnecessarily, we're generally not cool with that | 22:12 |
| sean-k-mooney | ya its an unrelated or tangentally related change in a non trivial feature | 22:13 |
| *** ociuhandu has quit IRC | 22:15 | |
| *** luksky has quit IRC | 22:15 | |
| *** mlavalle has quit IRC | 22:17 | |
| *** slaweq has quit IRC | 22:18 | |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.80: Add user_id/project_id to migration-list API https://review.opendev.org/675023 | 22:20 |
| openstackgerrit | Merged openstack/nova master: Don't duplicate PlacementFixture in libvirt func tests https://review.opendev.org/681059 | 22:25 |
| *** markvoelker has joined #openstack-nova | 22:36 | |
| melwitt | mriedem: ack, gonna add more comments to the review as far as why this patch gets around the problem | 22:40 |
| melwitt | (based on my read of the bug and code) | 22:40 |
| *** factor has quit IRC | 22:41 | |
| *** factor has joined #openstack-nova | 22:41 | |
| mriedem | gibi: as for your series (when you're back) you've got a real failure in the cold migration revert with a mixed compute grenade scenario https://review.opendev.org/#/c/676140/18 | 22:42 |
| mriedem | good thing you added that test coverage though :) | 22:42 |
| efried | dansmith: would you please have another (hopefully last) look at the bottom two patches in the vpmem series https://review.opendev.org/#/c/678447/ | 22:42 |
| efried | stephenfin: If you can hit the currently-bottom SEV patch, the rest is +A https://review.opendev.org/#/c/644565/ | 22:45 |
| efried | (I would feel better if it was you doing that than me) | 22:45 |
| efried | TIA. | 22:45 |
| *** markvoelker has quit IRC | 22:46 | |
| *** macz has quit IRC | 22:48 | |
| *** macz has joined #openstack-nova | 22:49 | |
| *** icarusfactor has joined #openstack-nova | 22:51 | |
| *** mriedem has quit IRC | 22:51 | |
| *** factor has quit IRC | 22:53 | |
| *** prometheanfire has left #openstack-nova | 22:55 | |
| *** tkajinam has joined #openstack-nova | 22:55 | |
| *** rcernin has joined #openstack-nova | 22:59 | |
| *** owalsh has quit IRC | 23:11 | |
| *** owalsh has joined #openstack-nova | 23:14 | |
| *** threestrands has joined #openstack-nova | 23:14 | |
| *** takashin has joined #openstack-nova | 23:32 | |
| *** icarusfactor has quit IRC | 23:41 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/stein: doc: Fix a broken reference link https://review.opendev.org/681141 | 23:47 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/rocky: doc: Fix a broken reference link https://review.opendev.org/681142 | 23:48 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/queens: doc: Fix a broken reference link https://review.opendev.org/681143 | 23:49 |
| alex_xu | efried: yes, I don't found design problem and upgrade plan makes sense for me also. What I'm just doing is the manual test of the upgrade process, ensure thing works as expected now | 23:49 |
| *** sapd1_x has joined #openstack-nova | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!