| *** gbarros has quit IRC | 00:20 | |
| *** markvoelker has quit IRC | 00:26 | |
| *** gyee has quit IRC | 00:27 | |
| *** igordc has quit IRC | 01:26 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Allow versioned discovery unauthenticated https://review.opendev.org/685181 | 01:33 |
|---|---|---|
| *** hongbin has joined #openstack-nova | 01:55 | |
| *** macz has joined #openstack-nova | 02:19 | |
| *** brinzhang has joined #openstack-nova | 02:19 | |
| *** macz has quit IRC | 02:23 | |
| *** brinzhang_ has joined #openstack-nova | 02:24 | |
| *** brinzhang has quit IRC | 02:27 | |
| *** hongbin has quit IRC | 02:33 | |
| *** hongbin has joined #openstack-nova | 02:34 | |
| *** SonPham has joined #openstack-nova | 02:41 | |
| SonPham | hi | 02:47 |
| SonPham | had any project to create live-snapshot for openstack? | 02:47 |
| *** BjoernT has joined #openstack-nova | 02:47 | |
| SonPham | snapshot with save ram state | 02:47 |
| brinzhang_ | Now, nova not support to do for that | 03:01 |
| *** mkrai has joined #openstack-nova | 03:04 | |
| openstackgerrit | Seyeong Kim proposed openstack/nova master: block_device: Optionally recreate attachments when refreshing connection_info https://review.opendev.org/579004 | 03:04 |
| brinzhang_ | SonPham: sorry for above said, current, cannot do a live-snapshot for hte paused server of libvirt/qemu driver. | 03:07 |
| brinzhang_ | paused and shutdown status server. | 03:08 |
| melwitt | dansmith, mriedem: the doc reference got removed here https://github.com/openstack/nova/commit/009fd0f35bcb88acc80f12e69d5fb72c0ee5391f | 03:10 |
| *** psachin has joined #openstack-nova | 03:12 | |
| *** BjoernT has quit IRC | 03:14 | |
| *** BjoernT has joined #openstack-nova | 03:18 | |
| *** nweinber has joined #openstack-nova | 03:19 | |
| SonPham | brinzhang_ Can we save VM state (save Ram) in the snapshot? | 03:26 |
| *** cfriesen has quit IRC | 03:26 | |
| *** spsurya has joined #openstack-nova | 03:29 | |
| *** BjoernT has quit IRC | 03:29 | |
| brinzhang_ | SonPham: I think you can, bug I am not sure, you can review that and try, with "disable_libvirt_livesnapshot" configuration in you env. | 03:31 |
| brinzhang_ | SonPham: https://docs.openstack.org/nova/stein/configuration/config.html#workarounds.disable_libvirt_livesnapshot | 03:31 |
| *** cfriesen has joined #openstack-nova | 03:31 | |
| *** SonPham has quit IRC | 03:32 | |
| *** gmann_afk is now known as gmann | 03:33 | |
| *** markvoelker has joined #openstack-nova | 03:41 | |
| *** markvoelker has quit IRC | 03:42 | |
| *** markvoelker has joined #openstack-nova | 03:43 | |
| *** SonPham has joined #openstack-nova | 03:52 | |
| *** SonPham has joined #openstack-nova | 03:54 | |
| SonPham | brinzhang_ I'm using libvirt to create snapshot for instance | 03:54 |
| *** hongbin has quit IRC | 03:56 | |
| *** udesale has joined #openstack-nova | 03:57 | |
| *** igordc has joined #openstack-nova | 03:58 | |
| *** SonPham has quit IRC | 04:12 | |
| *** nweinber has quit IRC | 04:16 | |
| *** ricolin has joined #openstack-nova | 04:16 | |
| *** macz has joined #openstack-nova | 04:20 | |
| *** SonPham has joined #openstack-nova | 04:23 | |
| *** macz has quit IRC | 04:25 | |
| *** macz has joined #openstack-nova | 04:28 | |
| *** macz has quit IRC | 04:30 | |
| *** macz has joined #openstack-nova | 04:30 | |
| *** macz has quit IRC | 04:35 | |
| *** spsurya has quit IRC | 04:37 | |
| *** spsurya has joined #openstack-nova | 04:37 | |
| *** mkrai has quit IRC | 04:46 | |
| *** pcaruana has joined #openstack-nova | 05:01 | |
| *** Luzi has joined #openstack-nova | 05:02 | |
| *** jaosorior has joined #openstack-nova | 05:05 | |
| *** dpawlik has joined #openstack-nova | 05:07 | |
| *** ratailor has joined #openstack-nova | 05:07 | |
| *** mkrai has joined #openstack-nova | 05:40 | |
| *** markvoelker has quit IRC | 05:47 | |
| *** igordc has quit IRC | 05:52 | |
| *** bbowen_ has joined #openstack-nova | 06:14 | |
| *** bbowen has quit IRC | 06:15 | |
| *** avolkov has joined #openstack-nova | 06:17 | |
| *** sapd1_x has joined #openstack-nova | 06:23 | |
| *** lpetrut has joined #openstack-nova | 06:31 | |
| *** macz has joined #openstack-nova | 06:32 | |
| *** ttsiouts has joined #openstack-nova | 06:35 | |
| *** macz has quit IRC | 06:36 | |
| *** francoisp has quit IRC | 06:40 | |
| *** hongbin has joined #openstack-nova | 06:56 | |
| *** slaweq has joined #openstack-nova | 06:57 | |
| *** hongbin has quit IRC | 07:00 | |
| *** rpittau|afk is now known as rpittau | 07:04 | |
| *** damien_r has joined #openstack-nova | 07:07 | |
| *** zbr is now known as zbr|ruck | 07:08 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:08 | |
| *** awalende has joined #openstack-nova | 07:10 | |
| *** xek has joined #openstack-nova | 07:12 | |
| *** tesseract has joined #openstack-nova | 07:16 | |
| *** cfriesen has quit IRC | 07:17 | |
| *** SonPham has quit IRC | 07:19 | |
| *** parlos has joined #openstack-nova | 07:21 | |
| *** dtantsur|afk is now known as dtantsur | 07:23 | |
| *** luksky has joined #openstack-nova | 07:38 | |
| *** ttsiouts has quit IRC | 07:43 | |
| *** ralonsoh has joined #openstack-nova | 07:45 | |
| *** markvoelker has joined #openstack-nova | 07:47 | |
| *** markvoelker has quit IRC | 07:51 | |
| *** jangutter has quit IRC | 07:56 | |
| *** sapd1_x has quit IRC | 07:57 | |
| *** ttsiouts has joined #openstack-nova | 07:57 | |
| *** Jeffrey4l has quit IRC | 07:59 | |
| *** Jeffrey4l has joined #openstack-nova | 08:00 | |
| *** ociuhandu has joined #openstack-nova | 08:02 | |
| *** rcernin has quit IRC | 08:02 | |
| *** rcernin has joined #openstack-nova | 08:03 | |
| *** tkajinam has quit IRC | 08:04 | |
| *** brinzhang has joined #openstack-nova | 08:05 | |
| *** brinzhang_ has quit IRC | 08:08 | |
| *** ttsiouts has quit IRC | 08:12 | |
| *** jangutter has joined #openstack-nova | 08:14 | |
| *** jaosorior has quit IRC | 08:16 | |
| *** ttsiouts has joined #openstack-nova | 08:18 | |
| *** ociuhandu has quit IRC | 08:21 | |
| *** ociuhandu has joined #openstack-nova | 08:22 | |
| *** derekh has joined #openstack-nova | 08:32 | |
| mgoddard | mriedem: yeah, I meant multiple cells. We would be quite behind to not have any support for cells v2... | 08:33 |
| *** brinzhang_ has joined #openstack-nova | 08:37 | |
| *** brinzhang_ has quit IRC | 08:38 | |
| *** brinzhang_ has joined #openstack-nova | 08:39 | |
| *** brinzhang has quit IRC | 08:40 | |
| *** macz has joined #openstack-nova | 08:51 | |
| *** macz has quit IRC | 08:55 | |
| *** ociuhandu has quit IRC | 09:02 | |
| *** ociuhandu has joined #openstack-nova | 09:23 | |
| *** ratailor_ has joined #openstack-nova | 09:24 | |
| *** ratailor has quit IRC | 09:26 | |
| *** ociuhandu has quit IRC | 09:28 | |
| *** parlos has quit IRC | 09:35 | |
| *** mkrai has quit IRC | 09:40 | |
| *** tssurya has joined #openstack-nova | 09:41 | |
| *** ricolin has quit IRC | 09:44 | |
| *** ratailor__ has joined #openstack-nova | 09:48 | |
| *** markvoelker has joined #openstack-nova | 09:48 | |
| *** ratailor_ has quit IRC | 09:50 | |
| *** markvoelker has quit IRC | 09:53 | |
| *** avolkov has quit IRC | 09:57 | |
| bauzas | gibi: can I ask you something about how to create a new allocation ? | 09:57 |
| gibi | bauzas: sure hit me | 10:01 |
| bauzas | gibi: to explain it : http://paste.openstack.org/show/780546/ | 10:03 |
| bauzas | gibi: I want to recreate the migration allocation that was deleted when confirming the resize | 10:03 |
| bauzas | gibi: so after that, after running my audit command, it would find it | 10:03 |
| bauzas | but then, I need a consumer_generation, right? | 10:04 |
| bauzas | or should I just update the allocations ? | 10:04 |
| bauzas | ie. https://docs.openstack.org/api-ref/placement/?expanded=update-allocations-detail#id72 | 10:05 |
| gibi | bauzas: you want to recreate the migration allocation so I assume that there is no allocation with that consumer. In that case the consumer generation when you create the allocation should be 0 | 10:05 |
| bauzas | gibi: that's correct | 10:06 |
| bauzas | I no longer have allocations for the migration UUID | 10:06 |
| bauzas | if so, we don't need to provide a generation version | 10:06 |
| bauzas | gibi: do we have any helper for putting a new allocation in the functional tests ? | 10:07 |
| gibi | I mean: "The generation of the consumer. Should be set to null when indicating that the caller expects the consumer does not yet exist." | 10:07 |
| gibi | bauzas: I think I never needed to manually create allocation in the functional test | 10:07 |
| bauzas | ok | 10:08 |
| *** ttsiouts has quit IRC | 10:08 | |
| *** brinzhang has joined #openstack-nova | 10:08 | |
| *** ttsiouts has joined #openstack-nova | 10:09 | |
| stephenfin | gmann: Still about? I'm stuck with https://review.opendev.org/#/c/684335/5/doc/api_samples/servers/v2.69/servers-details-resp.json | 10:10 |
| stephenfin | gibi: You might be able to advise on ^ too | 10:11 |
| *** brinzhang_ has quit IRC | 10:12 | |
| *** tetsuro has joined #openstack-nova | 10:12 | |
| *** ttsiouts has quit IRC | 10:13 | |
| *** mkrai has joined #openstack-nova | 10:17 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_server_tags' functional tests https://review.opendev.org/684335 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345 | 10:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Correctly mock out security groups in NeutronFixture https://review.opendev.org/685927 | 10:20 |
| *** ociuhandu has joined #openstack-nova | 10:20 | |
| openstackgerrit | Matthew Booth proposed openstack/nova master: libvirt: Ignore DiskNotFound during update_available_resource https://review.opendev.org/685391 | 10:21 |
| *** jaosorior has joined #openstack-nova | 10:24 | |
| gibi | stephenfin: do I understand the situation that the nova net base sample tests was not covered the sec group case and now that you add neutron based sample tests which has sec group you discovered a bug in the api behavior? | 10:25 |
| stephenfin | that seems to be my understanding | 10:25 |
| stephenfin | *that is my understanding :) | 10:25 |
| stephenfin | gibi: Basically, I'm not sure if https://review.opendev.org/685927 is correct or not | 10:26 |
| stephenfin | I mean, the addition of that field to two APIs | 10:26 |
| stephenfin | I guess I will need to look at a real cloud with a down cell to see what actually comes back | 10:26 |
| stephenfin | Or spend ages trying to trace stuff :( | 10:27 |
| *** udesale has quit IRC | 10:27 | |
| *** tetsuro has quit IRC | 10:28 | |
| *** udesale has joined #openstack-nova | 10:28 | |
| gibi | your fixture is coded with the assumption that neutron returns at least the default security group for every instance. If this assumption correct then what I think what you see in the test is the actual nova behavior | 10:28 |
| gibi | if that leads to unexpecte API response then that is a bug | 10:29 |
| stephenfin | Sort. I think it's more like I'm assuming an instance has at least one security group regardless of its state | 10:29 |
| gibi | stephenfin: yeah your view is more precies you would need to validate that assumption first | 10:30 |
| gibi | I think neutron behavior should not be cell dependent | 10:30 |
| stephenfin | Yeah, neither do I | 10:31 |
| stephenfin | I've no idea where to start on validating that assumption though so ima wait til sean-k-mooney or mriedem are about :) | 10:31 |
| gibi | :) | 10:31 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Remove 'adv-config', 'system-admin' subdocs https://review.opendev.org/684402 | 10:34 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Replacing underscores with dashes https://review.opendev.org/685929 | 10:34 |
| gibi | in devstack if I do nothing special I get the default sec group | 10:34 |
| *** tetsuro has joined #openstack-nova | 10:34 | |
| stephenfin | Yeah, that's what I was seeing too | 10:35 |
| stephenfin | gibi: https://docs.openstack.org/nova/pike/admin/security-groups.html | 10:36 |
| stephenfin | "All projects have a default security group which is applied to any instance that has no other defined security group. Unless you change the default, this security group denies all incoming traffic and allows only outgoing traffic to your instance." | 10:36 |
| gibi | after I stop the n-cond-cell1 service in my devstack I still see the default sec group returned by nova | 10:37 |
| gibi | stephenfin: based on that doc your assumption is valid | 10:38 |
| stephenfin | gibi: Just discussed with slaweq on #openstack-neutron. While it's possible to create ports with no security, that's not the default and none of our tests are checking for that, so expecting the default security group seems sane | 10:45 |
| stephenfin | Left comments on https://review.opendev.org/#/c/685927/ to that effect | 10:45 |
| stephenfin | I think we still have a bug though, in as far as there are times where the security_groups key is omitted rather than being set to an empty list or null. I need to discuss with gmann or mriedem later | 10:46 |
| gibi | OK, cool | 10:47 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336 | 10:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337 | 10:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340 | 10:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341 | 10:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342 | 10:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343 | 10:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344 | 10:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345 | 10:51 |
| *** macz has joined #openstack-nova | 10:52 | |
| *** bbowen_ has quit IRC | 10:52 | |
| *** mkrai has quit IRC | 10:54 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova stable/train: Imported Translations from Zanata https://review.opendev.org/685534 | 10:56 |
| *** macz has quit IRC | 10:57 | |
| *** artom has joined #openstack-nova | 10:59 | |
| *** udesale has quit IRC | 11:05 | |
| *** udesale has joined #openstack-nova | 11:06 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Use nova-net explicitly in functional tests https://review.opendev.org/684326 | 11:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_availability_zone' functional tests https://review.opendev.org/684332 | 11:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ip_pools' functional tests https://review.opendev.org/684333 | 11:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_quota_sets' functional tests https://review.opendev.org/684334 | 11:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Correctly mock out security groups in NeutronFixture https://review.opendev.org/685927 | 11:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_server_tags' functional tests https://review.opendev.org/684335 | 11:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336 | 11:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337 | 11:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_rescue' functional tests https://review.opendev.org/684339 | 11:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340 | 11:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341 | 11:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342 | 11:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343 | 11:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344 | 11:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345 | 11:13 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove explicit 'USE_NEUTRON = True' https://review.opendev.org/685937 | 11:13 |
| *** ttsiouts has joined #openstack-nova | 11:16 | |
| *** udesale has quit IRC | 11:17 | |
| lyarwood | stephenfin: https://github.com/lyarwood/nova/blob/a51921fe195ba6d8ccf60941b12c07ed304496da/nova/tests/functional/libvirt/base.py#L102-L105 - I don't understand what you're suggesting here | 11:25 |
| lyarwood | stephenfin: AssertionError: 16 not greater than 16 : Host.get_online_cpus is only accounting for 16 CPUs but you're requesting 16; change the mock or your test currently showing up in https://review.opendev.org/#/c/682621/2 as a result | 11:26 |
| lyarwood | stephenfin: https://review.opendev.org/#/c/682621/2/nova/tests/functional/regressions/test_bug_1843639.py@57 - should I be setting some additional things in the HostInfo I'm providing? | 11:27 |
| *** tetsuro has quit IRC | 11:28 | |
| *** tssurya has quit IRC | 11:31 | |
| *** tssurya_ has joined #openstack-nova | 11:31 | |
| lyarwood | stephenfin: I don't see why this has to be greater | 11:39 |
| *** markvoelker has joined #openstack-nova | 11:49 | |
| *** markvoelker has quit IRC | 11:54 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM libvirt: extract _start_heterogeneous_computes https://review.opendev.org/682620 | 11:56 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1843639 https://review.opendev.org/682621 | 11:56 |
| openstack | bug 1843639 in OpenStack Compute (nova) "libvirt: post_live_migration failures to disconnect volumes result in the rollback of live migrations" [Medium,In progress] https://launchpad.net/bugs/1843639 - Assigned to Lee Yarwood (lyarwood) | 11:56 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Ignore volume exceptions during post_live_migration https://review.opendev.org/682622 | 11:56 |
| *** bbowen has joined #openstack-nova | 12:03 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add a way to spy on function calls in test https://review.opendev.org/685949 | 12:13 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Replace mock with spy in test https://review.opendev.org/685950 | 12:14 |
| *** brinzhang_ has joined #openstack-nova | 12:21 | |
| *** brinzhang has quit IRC | 12:24 | |
| *** lpetrut has quit IRC | 12:24 | |
| *** ricolin has joined #openstack-nova | 12:32 | |
| *** trident has quit IRC | 12:34 | |
| stephenfin | lyarwood: That should be assertGreaterEqual | 12:34 |
| stephenfin | lyarwood: It exists because of this https://github.com/lyarwood/nova/blob/a51921fe195ba6d8ccf60941b12c07ed304496da/nova/tests/functional/libvirt/base.py#L67-L69 | 12:34 |
| stephenfin | That's saying cores 0-15 (so 16 cores) are online | 12:35 |
| *** trident has joined #openstack-nova | 12:35 | |
| lyarwood | stephenfin: yeah understood, couldn't see why it was just greater tbh. | 12:35 |
| lyarwood | stephenfin: thanks | 12:35 |
| *** brinzhang has joined #openstack-nova | 12:35 | |
| *** brinzhang_ has quit IRC | 12:39 | |
| *** tetsuro has joined #openstack-nova | 12:42 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_servers' functional tests https://review.opendev.org/684336 | 12:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hosts' functional tests https://review.opendev.org/684337 | 12:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_rescue' functional tests https://review.opendev.org/684339 | 12:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_hypervisors' functional tests https://review.opendev.org/684340 | 12:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341 | 12:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342 | 12:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343 | 12:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344 | 12:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345 | 12:43 |
| stephenfin | gibi: Could you push this through, please? https://review.opendev.org/#/c/662505/4 | 12:44 |
| *** tetsuro has quit IRC | 12:47 | |
| *** gbarros has joined #openstack-nova | 12:49 | |
| gibi | stephenfin: donstedone | 12:50 |
| * gibi hates mobilenemobilenet | 12:50 | |
| stephenfin | :D | 12:50 |
| stephenfin | thanks | 12:50 |
| *** francoisp has joined #openstack-nova | 12:52 | |
| *** macz has joined #openstack-nova | 12:53 | |
| *** Luzi has quit IRC | 12:55 | |
| *** macz has quit IRC | 12:57 | |
| *** jaosorior has quit IRC | 12:58 | |
| *** rcernin has quit IRC | 12:58 | |
| *** jaosorior has joined #openstack-nova | 13:02 | |
| *** nweinber has joined #openstack-nova | 13:06 | |
| *** dpawlik has quit IRC | 13:12 | |
| *** jawad_axd has joined #openstack-nova | 13:14 | |
| *** dave-mccowan has joined #openstack-nova | 13:15 | |
| *** mriedem has joined #openstack-nova | 13:15 | |
| *** ratailor__ has quit IRC | 13:19 | |
| *** dave-mccowan has quit IRC | 13:19 | |
| *** trident has quit IRC | 13:22 | |
| *** trident has joined #openstack-nova | 13:23 | |
| *** BjoernT has joined #openstack-nova | 13:26 | |
| *** dpawlik has joined #openstack-nova | 13:29 | |
| *** awalende has quit IRC | 13:38 | |
| *** awalende has joined #openstack-nova | 13:39 | |
| *** ociuhandu has quit IRC | 13:42 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite host aggregate, availability zone docs https://review.opendev.org/667133 | 13:42 |
| stephenfin | bauzas: Can you review that today, pretty please? ^ It keeps going into merge conflict and I'm sick of it \o/ | 13:42 |
| *** ivve has joined #openstack-nova | 13:42 | |
| *** ociuhandu has joined #openstack-nova | 13:42 | |
| *** awalende has quit IRC | 13:43 | |
| bauzas | stephenfin: I can try, rushing to provide a new patch for the audit command | 13:43 |
| stephenfin | bauzas: Nah, if you've something higher priority do that | 13:43 |
| bauzas | customers, customers, customers | 13:46 |
| *** ociuhandu has quit IRC | 13:48 | |
| *** markvoelker has joined #openstack-nova | 13:50 | |
| *** jaosorior has quit IRC | 13:51 | |
| mriedem | dansmith: for versioned objects tests, you know how we have a local and remote version with a mixin that usually holds the actual tests run by both? if the method being tested isn't remotable but is just some classmethod, is there any value in having it part of the mixin that gets run by the remote test since it's not remotable? seems like duplication for no gain. | 13:52 |
| mriedem | iow, is it fine to just put it in the local test version (not the mixin)? | 13:52 |
| dansmith | mriedem: correct | 13:52 |
| *** jawad_axd has quit IRC | 13:54 | |
| *** markvoelker has quit IRC | 13:55 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Selection.availability_zone field https://review.opendev.org/685807 | 13:56 |
| *** markvoelker has joined #openstack-nova | 13:57 | |
| *** markvoelker has quit IRC | 14:01 | |
| bauzas | gibi: thanks for your comments on https://review.opendev.org/#/c/670112/5/nova/cmd/manage.py | 14:01 |
| bauzas | gibi: I see you tested on your devstack, cool | 14:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Selection.availability_zone field https://review.opendev.org/685807 | 14:02 |
| bauzas | gibi: if you don't disagree, I'll make some modifications for your comments and try to see the cell-targeted issue | 14:02 |
| *** artom has quit IRC | 14:03 | |
| *** doude has joined #openstack-nova | 14:08 | |
| *** ociuhandu has joined #openstack-nova | 14:10 | |
| *** awalende has joined #openstack-nova | 14:16 | |
| *** awalende has quit IRC | 14:21 | |
| *** markvoelker has joined #openstack-nova | 14:22 | |
| *** ttsiouts has quit IRC | 14:25 | |
| *** ttsiouts has joined #openstack-nova | 14:25 | |
| *** markvoelker has quit IRC | 14:26 | |
| *** markvoelker has joined #openstack-nova | 14:27 | |
| *** ttsiouts has quit IRC | 14:30 | |
| *** munimeha1 has joined #openstack-nova | 14:31 | |
| *** mkrai has joined #openstack-nova | 14:31 | |
| stephenfin | mriedem, lyarwood: Can one of you merge the stable/stein tox/gitreview patches for novaclient, please https://review.opendev.org/#/c/683626/ https://review.opendev.org/#/c/683625/ | 14:34 |
| *** tbachman has joined #openstack-nova | 14:34 | |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Add 'Core Liaison' section to spec template https://review.opendev.org/685857 | 14:34 |
| lyarwood | stephenfin: can do | 14:35 |
| lyarwood | stephenfin: done | 14:35 |
| stephenfin | thanks (y) | 14:36 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/train: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685980 | 14:36 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/stein: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685981 | 14:37 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/rocky: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685983 | 14:38 |
| mriedem | stephenfin: i have an itch saying we should have a release note for that if you're going to backport it | 14:39 |
| mriedem | it's proper hardening but also changes something from silently pass to outright fail | 14:39 |
| stephenfin | Yeah, good call. I can put one together for master now, but should I squash the release notes into the backport or keep them separate? | 14:40 |
| mriedem | i'm fine with squashing in the backports | 14:40 |
| stephenfin | ack | 14:40 |
| *** lpetrut has joined #openstack-nova | 14:40 | |
| *** mlavalle has joined #openstack-nova | 14:42 | |
| *** dpawlik has quit IRC | 14:43 | |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Add release note for bug 1845322 https://review.opendev.org/685986 | 14:45 |
| openstack | bug 1845322 in python-novaclient train "'--hint' argument to 'nova boot ' should be a key-value pair" [Low,In progress] https://launchpad.net/bugs/1845322 - Assigned to Stephen Finucane (stephenfinucane) | 14:45 |
| *** lpetrut has quit IRC | 14:47 | |
| gibi | bauzas: sure, go ahead | 14:48 |
| *** ttsiouts has joined #openstack-nova | 14:49 | |
| gibi | bauzas: if you push a new PS I can try to run that in my devstack with bandwidth | 14:49 |
| stephenfin | mriedem: 'upgrade' or 'fixes' reno? I've gone with the former but could go with the latter | 14:49 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/train: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685980 | 14:54 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/stein: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685981 | 14:55 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/rocky: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685983 | 14:55 |
| *** artom has joined #openstack-nova | 14:57 | |
| mriedem | stephenfin: i initially thought 'fixes' but could see 'upgrade' as well | 14:57 |
| *** artom has quit IRC | 14:57 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add a way to spy on function calls in test https://review.opendev.org/685949 | 14:57 |
| *** artom has joined #openstack-nova | 14:58 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Replace mock with spy in test https://review.opendev.org/685950 | 14:59 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/train: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685980 | 14:59 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/stein: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685981 | 14:59 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/rocky: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685983 | 15:00 |
| *** tbachman has quit IRC | 15:02 | |
| *** tbachman has joined #openstack-nova | 15:04 | |
| *** BjoernT has quit IRC | 15:12 | |
| *** tetsuro has joined #openstack-nova | 15:12 | |
| *** lpetrut has joined #openstack-nova | 15:13 | |
| *** tetsuro has quit IRC | 15:17 | |
| *** ociuhandu has quit IRC | 15:17 | |
| *** BjoernT has joined #openstack-nova | 15:18 | |
| *** ociuhandu has joined #openstack-nova | 15:18 | |
| *** ttsiouts has quit IRC | 15:22 | |
| *** ociuhandu has quit IRC | 15:24 | |
| *** ociuhandu has joined #openstack-nova | 15:25 | |
| openstackgerrit | Merged openstack/nova master: ec2: Move ec2utils functions to their callers https://review.opendev.org/662505 | 15:25 |
| *** ociuhandu has quit IRC | 15:30 | |
| *** ociuhandu has joined #openstack-nova | 15:31 | |
| stephenfin | gibi: Since you looked at the functional change, care to send this reno on its way, please? https://review.opendev.org/685986 | 15:32 |
| *** tesseract has quit IRC | 15:33 | |
| gibi | stephenfin: sure, looking | 15:33 |
| stephenfin | Thanks | 15:33 |
| *** gyee has joined #openstack-nova | 15:34 | |
| artom | gibi, a couple of -1s on your spy stack, but they're really more for visibility/discussion | 15:34 |
| gibi | stephenfin: that was an easy one :) | 15:34 |
| stephenfin | gibi: hang on, pretty sure I've a 1kloc patch sitting around here somewhere ;) | 15:35 |
| *** itlinux has joined #openstack-nova | 15:35 | |
| gibi | artom: yeah, that is basically an experiment, so any discussion starter is warmly welcome. I will check back to that patch later | 15:35 |
| *** lpetrut has quit IRC | 15:35 | |
| gibi | stephenfin: I'm sure you have one :) | 15:35 |
| stephenfin | I probably do :( | 15:35 |
| *** ociuhandu has quit IRC | 15:36 | |
| artom | gibi, ack, no rush :) | 15:38 |
| *** BjoernT has quit IRC | 15:39 | |
| *** damien_r has quit IRC | 15:39 | |
| openstackgerrit | Merged openstack/python-novaclient stable/train: Update .gitreview for stable/train https://review.opendev.org/683625 | 15:41 |
| efried | mriedem, stephenfin: Can I get some help/advice moving forward with unauthed versioned discovery? https://review.opendev.org/685181 | 15:41 |
| efried | I've got this working, but there are a couple of points I'd like to discuss. | 15:42 |
| mriedem | still no alex or john around huh | 15:42 |
| *** ociuhandu has joined #openstack-nova | 15:42 | |
| efried | Alex is on vacation. John I haven't seen in a while. | 15:42 |
| *** rpittau is now known as rpittau|afk | 15:42 | |
| stephenfin | I can try, but this is not my wheelhouse | 15:43 |
| efried | oh, sure you're fine removing an unused middleware though | 15:43 |
| efried | :P | 15:43 |
| efried | so first | 15:43 |
| stephenfin | deleting code is a significantly easier endeavour ;) | 15:43 |
| efried | mordred: your advice would be helpful here too | 15:44 |
| *** xek has quit IRC | 15:44 | |
| *** BjoernT has joined #openstack-nova | 15:44 | |
| efried | http://host:port/v2 and /v2.1 used to do a 302 redirect to .../v2/ and /v2.1/ (with the trailing slash). The trailing-slash version then returned the version document with a 200. | 15:44 |
| *** xek has joined #openstack-nova | 15:44 | |
| efried | Now /v2, /v2.1, /v2/, and /v2.1/ all just return the version document with 200. | 15:44 |
| efried | Is that a behavior change that could possibly cause a problem for anyone? | 15:45 |
| efried | perhaps gmann could also advise? | 15:45 |
| mordred | efried: it shouldn't cause a problem for SDK - we treat the version document payload as authoritative | 15:46 |
| *** ociuhandu has quit IRC | 15:46 | |
| mordred | but - if there are people who are doing blind url appending - maybe that's a behavior change that would break them? | 15:46 |
| mriedem | i want to say novaclient has had to deal with the trailing slash stuff to get the version document and avoid the 302 | 15:47 |
| efried | what do you mean, blind url appending? | 15:47 |
| mriedem | i think sdague added that and alex is probably familiar with it | 15:47 |
| efried | mriedem: so worst case novaclient is doing an extra thing that's no longer necessary, rite? | 15:47 |
| mriedem | probably, details are in here https://github.com/openstack/python-novaclient/blob/003ac57d9af74aa4658a7bf6cc6b6b3bafa58c11/novaclient/v2/versions.py#L36 | 15:48 |
| efried | mordred: /v2/stuff will still go into the real API, not hit version discovery | 15:48 |
| mordred | ah - yeah | 15:48 |
| *** BjoernT_ has joined #openstack-nova | 15:48 | |
| *** BjoernT has quit IRC | 15:49 | |
| mordred | I mean - then in that case, I think it's no problem - because what a person is looking for is the version document | 15:49 |
| mordred | and they'll be getting it | 15:49 |
| mriedem | i also remember this craziness that andreykurilin fixed https://github.com/openstack/python-novaclient/blob/003ac57d9af74aa4658a7bf6cc6b6b3bafa58c11/novaclient/v2/versions.py#L83 | 15:49 |
| mordred | I agree with "novaclient might be doing an extra step it doesn't need to do anymore" part | 15:49 |
| stephenfin | efried: I assume there's a very good reason that it's not possible to retain the 302 redirect? | 15:49 |
| *** ociuhandu has joined #openstack-nova | 15:49 | |
| mordred | stephenfin: bunny rabbits | 15:50 |
| efried | mriedem: yeah, so that novaclient blip would become unnecessary - but only for deployments actually running this code, so I'm not gonna like rip it out right away or anything. | 15:50 |
| mriedem | more like ever | 15:50 |
| mordred | yah- that's why we're fixing sdk to DTRT with older nova too | 15:50 |
| mriedem | api-paste is config and deployments can do whatever, even if it's dumb | 15:51 |
| mriedem | see the comments in there about rax | 15:51 |
| efried | stephenfin: I suppose with some extra hacking I could figure out a way to re-add the 302, but if it's not problematic to remove it, this is way simpler, less code, etc. | 15:51 |
| stephenfin | gotcha | 15:52 |
| efried | mriedem: that second novaclient blip should also continue to work fine. | 15:52 |
| mriedem | i have no idea if external tooling things would rely on that 302 actually happening | 15:52 |
| efried | yeah, that would be just... crazy I would think. | 15:52 |
| efried | but it's what I'm asking. | 15:52 |
| efried | Second thing: | 15:52 |
| efried | Do we have any need to retain full compatibility for [api]auth_strategy=noauth2 in the wild? | 15:53 |
| *** ivve has quit IRC | 15:55 | |
| efried | I had to change NoAuthMiddleware a little bit because it used to be relying (hardcoded) on the auth_url being the versioned endpoint -- i.e. http://server:port/v2 or .../v2.1 -- because it would return that in the X-Server-Management-Url header. | 15:55 |
| efried | But the whole point of the change was to make those URLs *not* go through auth middleware | 15:55 |
| efried | so I had to make it so you use a different auth_url, and NoAuthMiddleware (still hardcoded) massages it appropriately so you still get the right X-Server-Management-Url header back. | 15:56 |
| mriedem | noauth is for tests only | 15:57 |
| efried | good, that's what I wanted to hear. | 15:58 |
| mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#api.auth_strategy | 15:58 |
| mriedem | it's also in the config option help | 15:58 |
| efried | Yeah, I just didn't know if the fact that we mention it in the conf help means we kinda have to support it and not break existing uses | 15:58 |
| efried | Cool, so the last thing: | 15:59 |
| efried | and this is obvious, because it's the point of the patch: | 15:59 |
| efried | You no longer go through auth to get the versioned discovery documents | 15:59 |
| mriedem | WHAT?! | 15:59 |
| efried | I think it's possible this means there are some headers you used to get back that you wouldn't anymore. | 16:00 |
| efried | We seem to have tests for things we care about, like Accept. | 16:02 |
| efried | I suppose it would be duly diligent of me to go find out exactly what that diff looks like... | 16:02 |
| *** macz has joined #openstack-nova | 16:04 | |
| efried | thanks for the talk mriedem mordred stephenfin | 16:05 |
| openstackgerrit | Merged openstack/python-novaclient stable/train: Update TOX/UPPER_CONSTRAINTS_FILE for stable/train https://review.opendev.org/683626 | 16:10 |
| openstackgerrit | Merged openstack/python-novaclient master: Add release note for bug 1845322 https://review.opendev.org/685986 | 16:11 |
| openstack | bug 1845322 in python-novaclient train "'--hint' argument to 'nova boot ' should be a key-value pair" [Low,In progress] https://launchpad.net/bugs/1845322 - Assigned to Stephen Finucane (stephenfinucane) | 16:11 |
| *** ociuhandu has quit IRC | 16:11 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Selection.availability_zone field https://review.opendev.org/685807 | 16:12 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle get_host_availability_zone error during reschedule https://review.opendev.org/685997 | 16:12 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression test for bug 1781286 https://review.opendev.org/685998 | 16:12 |
| openstack | bug 1781286 in OpenStack Compute (nova) "CantStartEngineError in cell conductor during reschedule - get_host_availability_zone up-call" [Medium,Triaged] https://launchpad.net/bugs/1781286 - Assigned to Matt Riedemann (mriedem) | 16:12 |
| *** lpetrut has joined #openstack-nova | 16:22 | |
| *** ociuhandu has joined #openstack-nova | 16:25 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Do not print default dicts during heal_allocations https://review.opendev.org/686001 | 16:26 |
| *** ociuhandu has quit IRC | 16:29 | |
| gibi | mriedem: finally ticked off this TODO as well ^^ | 16:29 |
| mriedem | ack, would be nice to see that in https://review.opendev.org/#/c/669879/ but i won't make you rebase it | 16:32 |
| mriedem | maybe time to nudge efried and/or stephenfin to come back on ^ | 16:32 |
| mriedem | though stephen had comments | 16:32 |
| mriedem | unrelated, while writing a resize reschedule test i realize that if we fail the resize claim we temporarily put the instance into ERROR state while rescheduling, and it will end up that way if rescheduling fails, which seems wrong b/c we didn't actually do anything with the guest, we just failed a claim | 16:33 |
| mriedem | dansmith: agree? ^ | 16:33 |
| *** ricolin has quit IRC | 16:33 | |
| dansmith | agree with what? that leaving it in error state is wrong? | 16:34 |
| mriedem | yeah | 16:34 |
| mriedem | we should just fail the resize, mark the migration as error, inject a fault, etc | 16:34 |
| mriedem | but the vm_state should still be active or stopped | 16:34 |
| dansmith | I dunno, I guess I thought it was always a design goal that ERROR is your indication that something failed, and you start or stop the instance to get it back to normal state | 16:35 |
| mriedem | that's a pretty big hammer for a user when resize fails b/c they lost a claim race | 16:36 |
| mriedem | and the guest is otherwise untouched | 16:36 |
| mriedem | the instance action will tell you as a user if the thing failed | 16:36 |
| dansmith | isn't that why we can go from ACTIVE->ERROR->ACTIVE and the user can do the start operation from ERROR state? | 16:36 |
| gibi | mriedem: ack, I will check back to the nova-next patch tomorrow | 16:36 |
| mriedem | you can't start from error state | 16:37 |
| mriedem | you can hard reboot | 16:37 |
| dansmith | yeah, but you have to either poll it or something to know when to look right? | 16:37 |
| * gibi leaves for today | 16:37 | |
| mriedem | sure, poll until the task_state is reset to None | 16:37 |
| mriedem | if the status is not what you expect, investigate the instance action | 16:37 |
| dansmith | er, I really thought you could start to get out of error state | 16:38 |
| dansmith | I had this long conversation with vish about it eons ago | 16:38 |
| dansmith | although admittedly lots could have changed since then | 16:38 |
| mriedem | hard reboot would do it but then you've hard to hard reboot your guest even though there is nothing wrong with it | 16:38 |
| mriedem | *had to | 16:38 |
| dansmith | no, I mean start or stop being a no-op from whatever real state it was in | 16:38 |
| efried | mriedem: RC2 candidate, merged in master, wouldyouplease https://review.opendev.org/#/c/685742/ | 16:39 |
| dansmith | mriedem: well, stop works from error at least: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2401 | 16:39 |
| efried | and yes, on https://review.opendev.org/#/c/669879/ I'm waiting for stephenfin's questions to be answered. | 16:40 |
| *** BjoernT has joined #openstack-nova | 16:40 | |
| *** dtantsur is now known as dtantsur|afk | 16:40 | |
| mriedem | dansmith: ok, but still, the user shouldn't have to stop and then start to get out of that, or hard reboot, when the thing that failed is a resize claim race | 16:40 |
| dansmith | mriedem: so maybe it's just stop I'm thinking of.. anyway, I dunno.. it's very annoying as a user to do something, come back later and have it not obvious that the thing has happened, or failed or whatever | 16:41 |
| dansmith | mriedem: if you're going to retry the operation for them, I agree. if you're not, then being super obvious about what has happened is best, IMHO | 16:41 |
| *** BjoernT_ has quit IRC | 16:42 | |
| aspiers | sean-k-mooney: got a response from AMD SEV guy | 16:42 |
| sean-k-mooney | cool do we need to take acount of the qemu channels? | 16:42 |
| aspiers | He didn't say so I'm following up explicitly on that | 16:43 |
| aspiers | See my comment | 16:43 |
| aspiers | https://review.opendev.org/#/c/684825/4/nova/virt/libvirt/designer.py@214 | 16:43 |
| sean-k-mooney | ok ya so we are missing the gpu supprot in the video model section | 16:44 |
| aspiers | I'll add that now | 16:45 |
| sean-k-mooney | and i think we do need the channels too since the channesl allow you to create virtio-serial deivces | 16:45 |
| sean-k-mooney | a qemu channel has two parts a host backend and a guest front end | 16:46 |
| sean-k-mooney | the guest front end is typeically a virtio-serial port | 16:46 |
| *** imacdonn has quit IRC | 16:48 | |
| aspiers | oops, the attribute for GuestVideo is 'type' not 'model' | 16:48 |
| sean-k-mooney | we call it model in the image property | 16:48 |
| sean-k-mooney | but maybe | 16:49 |
| sean-k-mooney | oh its the type atribute in the model elemnt | 16:49 |
| aspiers | yeah | 16:49 |
| sean-k-mooney | that does not mean the class varible is called type | 16:50 |
| aspiers | no but it is anyway | 16:50 |
| aspiers | which IMHO is a bad choice because type is kind of reserved, but whatever | 16:50 |
| sean-k-mooney | ya it is type https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py#L1859 | 16:50 |
| sean-k-mooney | well its self.type | 16:51 |
| sean-k-mooney | type as a variable would alisa the type fucntion which would be bad | 16:51 |
| aspiers | sure | 16:51 |
| sean-k-mooney | in class scope its kindo fo ok | 16:51 |
| aspiers | emacs Python mode is too stupid to realise the difference | 16:51 |
| sean-k-mooney | ya i can see that messing with alot of regex based syntax highlighting | 16:52 |
| sean-k-mooney | so ya the guest agent is defulting to a virtio channel | 16:53 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py#L2135-L2152 | 16:53 |
| aspiers | sean-k-mooney: vvvvvvv | 16:54 |
| openstackgerrit | Adam Spiers proposed openstack/nova master: Also enable iommu for virtio controllers and video in libvirt https://review.opendev.org/684825 | 16:54 |
| aspiers | It may need another PS for virtio channels, waiting to see what Brijesh says | 16:54 |
| sean-k-mooney | ya i would keep that seperate | 16:54 |
| aspiers | OK | 16:55 |
| sean-k-mooney | although you proably could jsut try enableing the qemu guest agent too and see if it works | 16:55 |
| aspiers | how do I do that? | 16:55 |
| sean-k-mooney | you need to install it in the guest image and set an image property let me get it | 16:55 |
| aspiers | urgh | 16:56 |
| aspiers | by install, do you mean at build-time not post launch? | 16:56 |
| sean-k-mooney | you can do it post launch i think | 16:56 |
| sean-k-mooney | you set hw_qemu_guest_agent=yes in the image metadata | 16:57 |
| sean-k-mooney | that will be enough to triger the generation of the qemu channel | 16:57 |
| aspiers | ok I'll try that thanks | 16:57 |
| sean-k-mooney | then you should be able to ssh in and install it | 16:57 |
| aspiers | I wonder what the package will be called | 16:57 |
| sean-k-mooney | on suse i have no idea | 16:58 |
| aspiers | what is it on RH? | 16:58 |
| sean-k-mooney | proably qemu-somthing | 16:58 |
| aspiers | haha no shit :) | 16:58 |
| sean-k-mooney | i dont know | 16:58 |
| sean-k-mooney | i have only ever installed it on ubunutu | 16:58 |
| sean-k-mooney | yum install qemu-guest-agent | 16:58 |
| sean-k-mooney | https://wiki.libvirt.org/page/Qemu_guest_agent | 16:59 |
| *** derekh has quit IRC | 17:01 | |
| mnaser | mriedem: did the cross-cell resizes end up finishing in train? | 17:03 |
| aspiers | sean-k-mooney: it's the same on SUSE | 17:03 |
| mnaser | looks like it just all still needs review and probably isnt landing in train, from what i see? | 17:03 |
| sean-k-mooney | aspiers: its a pretty good name for it | 17:03 |
| aspiers | sean-k-mooney: very catchy ;-) | 17:03 |
| sean-k-mooney | aspiers: the main reason it exists is to provide a way to quiesce the diesk when doing an online snapshot | 17:04 |
| sean-k-mooney | it has other uses too | 17:04 |
| aspiers | sean-k-mooney: does it do more than just a sync? since stuff could still be writing | 17:04 |
| sean-k-mooney | i think it does a flush then prevents any addtional wirtes untill the snapshot completes | 17:05 |
| aspiers | ah ok | 17:05 |
| aspiers | how does it prevent? some kernel voodoo? | 17:06 |
| sean-k-mooney | aspiers: dansmith told me it was important to not currupt things and i took him at his word | 17:06 |
| sean-k-mooney | i havent really looked in to how it does it but i assume its acting as a broker between qemu and the guest kernel block deice layer in some way | 17:07 |
| sean-k-mooney | this covers part of it https://www.sebastien-han.fr/blog/2015/02/09/openstack-perform-consistent-snapshots-with-qemu-guest-agent/ | 17:12 |
| openstackgerrit | Merged openstack/nova master: api: Remove 'Debug' middleware https://review.opendev.org/662506 | 17:13 |
| mriedem | mnaser: not done in train no | 17:15 |
| mriedem | mnaser: do you have multiple cells yet? | 17:15 |
| sean-k-mooney | aspiers: apparently you have to write your own freeze hooks | 17:15 |
| *** tbachman has quit IRC | 17:20 | |
| *** tssurya_ has quit IRC | 17:22 | |
| *** ralonsoh has quit IRC | 17:27 | |
| mnaser | mriedem: nope not yet | 17:30 |
| *** lpetrut has quit IRC | 17:31 | |
| *** tbachman has joined #openstack-nova | 17:32 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle get_host_availability_zone error during reschedule https://review.opendev.org/685997 | 17:33 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression test for build part of bug 1781286 https://review.opendev.org/685998 | 17:33 |
| openstack | bug 1781286 in OpenStack Compute (nova) "CantStartEngineError in cell conductor during reschedule - get_host_availability_zone up-call" [Medium,In progress] https://launchpad.net/bugs/1781286 - Assigned to Matt Riedemann (mriedem) | 17:33 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Selection.availability_zone field https://review.opendev.org/685807 | 17:33 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression test for migrate part of bug 1781286 https://review.opendev.org/686017 | 17:33 |
| *** igordc has joined #openstack-nova | 17:37 | |
| mriedem | hemna: fyi that https://review.opendev.org/#/c/683008/ nor anything on stable/pike will pass tempest jobs until https://review.opendev.org/#/c/684769/ or an alternative fix is merged | 17:41 |
| *** ivve has joined #openstack-nova | 17:41 | |
| *** mkrai has quit IRC | 17:43 | |
| mriedem | melwitt: when you get a chance can you hit these stable/stein backports? https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/stein+topic:bug/1843090 | 17:46 |
| mriedem | those are an upgrade regression in stein so i'd like to get those into the next point release | 17:46 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Allow versioned discovery unauthenticated https://review.opendev.org/685181 | 17:50 |
| efried | mriedem, stephenfin, mordred: The response headers were indeed different, fixed ^ | 17:52 |
| efried | ready for your enthusiastic +2s now. | 17:52 |
| *** artom has quit IRC | 17:55 | |
| aspiers | OK here's a really dumb question - why am I getting this after updating my devstack? Unknown column 'migrations.user_id' in 'field list | 17:58 |
| aspiers | I did a db sync and restarted services | 17:58 |
| mriedem | you likely didn't sync cell1 | 17:59 |
| aspiers | ah thanks | 17:59 |
| mriedem | nova-manage db sync --config-file /etc/nova/nova.conf --config-file /etc/nova/nova-cond_cell1.conf | 18:00 |
| mriedem | something like that | 18:00 |
| aspiers | trying ... | 18:00 |
| mriedem | former only syncs cell0, latter syncs cell1 | 18:00 |
| * mriedem jumps on a call | 18:00 | |
| aspiers | mriedem: nova-manage --config-file /etc/nova/nova.conf --config-file /etc/nova/nova_cell1.conf db sync was the winning combo, thanks! | 18:05 |
| mriedem | \o/ | 18:07 |
| *** artom has joined #openstack-nova | 18:10 | |
| *** psachin has quit IRC | 18:10 | |
| melwitt | mriedem: sure | 18:10 |
| *** psachin has joined #openstack-nova | 18:13 | |
| openstackgerrit | Merged openstack/nova stable/train: make virtual pmem feature compatible with python3 https://review.opendev.org/685742 | 18:13 |
| *** artom has quit IRC | 18:15 | |
| *** artom has joined #openstack-nova | 18:17 | |
| *** psachin has quit IRC | 18:17 | |
| sean-k-mooney | efried: can i mark this as fix released https://bugs.launchpad.net/nova/+bug/1715374 | 18:25 |
| openstack | Launchpad bug 1715374 in OpenStack Compute (nova) "Reloading compute with SIGHUP prevents instances from booting" [High,In progress] - Assigned to Ralf Haferkamp (rhafer) | 18:25 |
| sean-k-mooney | it should be in rc1 right as of https://github.com/openstack/nova/commit/73f1fda7e93325d3ca2b2c62afb17fe011d650f3 | 18:25 |
| efried | sean-k-mooney: Yeah, that makes sense, please do. | 18:26 |
| sean-k-mooney | cool im doing some downstream bug traige and linking them to the upstream ones | 18:29 |
| mnaser | hmm | 18:34 |
| mnaser | how nova-friendly is https://docs.openstack.org/releasenotes/zun/train.html#upgrade-notes ? | 18:34 |
| mnaser | [compute]/host_shared_with_nova = true | 18:34 |
| *** ociuhandu has joined #openstack-nova | 18:34 | |
| mnaser | so looks like its integrated with placement and gets the rp that nova uses and makes claims against it | 18:35 |
| sean-k-mooney | i assume that is in the zun.conf | 18:35 |
| sean-k-mooney | not the nova.conf | 18:35 |
| mnaser | which i (thinking out loud) don't think that it can do bad things(tm) | 18:36 |
| mnaser | because placement would just not return that compute host as a likely candidate at that point | 18:36 |
| sean-k-mooney | am it depends | 18:36 |
| sean-k-mooney | it could do bad things if you are using cpu pinning or hugepages | 18:37 |
| *** ociuhandu has quit IRC | 18:37 | |
| mnaser | true, i guess its mostly focusing around ram and cpu claims (blindly) | 18:37 |
| sean-k-mooney | well if they claim VCPU not PCUP then they woudl be required to enusre that the contaiern swapen on the cpu_shared_set | 18:38 |
| sean-k-mooney | if they do not then thants a problemn | 18:38 |
| *** ociuhandu has joined #openstack-nova | 18:39 | |
| mnaser | looks like its claiming VCPU | 18:39 |
| mnaser | but i think it might not know to pin workloads | 18:40 |
| mnaser | dont even think thats possible with docker | 18:40 |
| sean-k-mooney | it is | 18:40 |
| sean-k-mooney | you can pass a cpuset | 18:40 |
| mnaser | https://github.com/openstack/zun/commit/7b3b1c5e07eb8b9e81031fa6ee4625ff6870b41d | 18:40 |
| mnaser | this is the big commit and i dont think they have that (yet) | 18:40 |
| sean-k-mooney | ya so without that it would not be safe to run zun on a nova host that has a PCPU inventory | 18:41 |
| sean-k-mooney | s/safe/correct/ as the contianer could steal cpu time from the pinned instnace | 18:41 |
| sean-k-mooney | mnaser: i also see this being an issue if we delet the nova compute service on that host but not the zun service | 18:44 |
| mnaser | yeah i think that's an operator problem at that point because setting the zun setting would be invalid | 18:44 |
| sean-k-mooney | unless they intentally took acount of that | 18:44 |
| sean-k-mooney | not really | 18:44 |
| mnaser | but then i think if you swap out that setting in flight | 18:44 |
| sean-k-mooney | if i deploy with both | 18:44 |
| mnaser | you probably lose all your allocation | 18:44 |
| sean-k-mooney | and then later wanted to remvoe nova to just have zun | 18:44 |
| sean-k-mooney | then wen we delete the compute node rp as part of service deleteion it might cause issue for zuun | 18:45 |
| sean-k-mooney | right we will try to delete all the allcoation against the compute node ro | 18:45 |
| sean-k-mooney | *RP | 18:45 |
| *** ociuhandu has quit IRC | 18:46 | |
| sean-k-mooney | i dont recal the zun team discussing this with the nova team at the denver PTG did i miss a session on this? | 18:46 |
| *** ociuhandu has joined #openstack-nova | 18:46 | |
| mnaser | yeah i think i remember talking about it with dansmith saying "it would be cool if" but i think they mentioned that "nova assumes it owns the rp, there is no such thing as rp sharing" | 18:47 |
| sean-k-mooney | mnaser: right as of today it does | 18:48 |
| sean-k-mooney | back in the dublin ptg i was suggestign nova should not own the compute node RP | 18:48 |
| mnaser | ok so compute node rp sharing is a thing that isn't an antipattern | 18:48 |
| sean-k-mooney | and each service should have there own nested RP subtree runder a shared compute node RP with no inventories | 18:48 |
| sean-k-mooney | mnaser: right now it not a thing | 18:49 |
| sean-k-mooney | well not really a thing im not 100% sure that neutorn bandwith based schduleing is not shareing an RP with nova | 18:50 |
| sean-k-mooney | gibi: ^ do you know the answer to that | 18:50 |
| sean-k-mooney | mnaser: im not aware of share where not is not the owner of the compute node RP. | 18:50 |
| *** brinzhang_ has joined #openstack-nova | 18:51 | |
| *** brinzhang_ has joined #openstack-nova | 18:51 | |
| *** brinzhang_ has joined #openstack-nova | 18:52 | |
| *** brinzhang has quit IRC | 18:54 | |
| *** tbachman has quit IRC | 18:54 | |
| sean-k-mooney | looking at the zun patch tehy seam to have ported alot of code form nova which is not nessisarlly a good thing. | 18:54 |
| efried | mnaser, sean-k-mooney: For some definition of "sharing". It doesn't matter who creates the RP (neutron vs nova for bw, cyborg vs nova for accels, etc) -- the important thing is that, if you're creating an instance, the entire *claim* needs to be atomic, and therefore done by nova. | 18:55 |
| sean-k-mooney | or zun | 18:55 |
| efried | as long as nova doesn't think it's going to come in afterwards and do some other claim, sure. | 18:56 |
| sean-k-mooney | well zun has its own top level api | 18:56 |
| efried | I don't really know what zun is or what it does | 18:56 |
| sean-k-mooney | its a container as a service project that started as a replacment for nova-docker | 18:57 |
| efried | I do recall seeing they were porting in a bunch of nova's resource tracker and scheduler gorp | 18:57 |
| sean-k-mooney | so it can be used as a nova virt driver or as a standalone service | 18:57 |
| efried | basically inheriting a mountain of technical debt | 18:57 |
| efried | and we told them not to do that | 18:57 |
| efried | and they did it anyway. | 18:57 |
| sean-k-mooney | yes hence my comment above | 18:57 |
| *** tbachman has joined #openstack-nova | 18:58 | |
| sean-k-mooney | when i see patches merge with TODO comments from jaypipes i assume that was not a recent TODO and there for form nova | 18:59 |
| sean-k-mooney | the bit that worres my is fi the share with nova flag is set | 19:00 |
| *** maciejjozefczyk has quit IRC | 19:01 | |
| sean-k-mooney | the pass the full provider tree for the nova compute node RP to there update_provider_tree function | 19:02 |
| sean-k-mooney | they are also modifing trait possible on the root RP | 19:03 |
| *** ociuhandu has quit IRC | 19:07 | |
| *** spsurya has quit IRC | 19:09 | |
| mriedem | sean-k-mooney: bw providers are nested under the compute node rp | 19:17 |
| mriedem | the case that sean-k-mooney mentioned about nova deleting the compute node and root resource provider when you delete a compute service, i can definitely see that screwing with zun if they assume the same resource provider with the same uuid is going to exist, i don't know how they link that up, maybe via hostname | 19:18 |
| mriedem | we have our own problems managing that stuff, i.e. the orphaned allocations/providers bug we have right now, | 19:19 |
| mriedem | let alone worrying about how we're going to be breaking external things | 19:19 |
| efried | mriedem: Did you have something to do with https://review.opendev.org/#/c/684326/ not being combined with its (current) successor https://review.opendev.org/#/c/685937/ ? (USE_NEUTRON refactoring in tests) | 19:19 |
| sean-k-mooney | ya so depending on the valude of "share with nova" they either create there own root RP or share nova | 19:19 |
| sean-k-mooney | and they use the hostname to look up the one created by nova if "shareing" is enabled | 19:20 |
| mriedem | efried: you can see my comments on PS1, i don't know why it changed like it did, i haven't looked yet, but it definitely isn't what i was expecting | 19:20 |
| mriedem | efried: he had https://review.opendev.org/#/c/684326/1 | 19:20 |
| mriedem | and then in the next patch in the series reverted a bunch of what he added with https://review.opendev.org/#/c/684327/ | 19:20 |
| efried | mriedem: yeah, the earlier comments have been addressed to squash together a now-abandoned change | 19:20 |
| mriedem | i said just squash those | 19:20 |
| mriedem | sure, he did but then there were other things tacked on that i wasn't expecting | 19:21 |
| efried | I'm just wondering why there's still two patches, one that sets False and the other that removes True | 19:21 |
| mriedem | and haven't taken the time to grok the diff | 19:21 |
| *** markvoelker has quit IRC | 19:21 | |
| mriedem | iow, i said "just do x" and he did x + 4 | 19:21 |
| * sean-k-mooney sees nova net and walk away before i have to grok nova net code. | 19:22 | |
| mriedem | btw, unrelated to this, but we have another train rc2 fix on master with a +2 and ack from the bug reporter that it fixes the regression https://review.opendev.org/#/c/685194/ | 19:22 |
| efried | o, I was reviewing that and then... didn't finish for some reason. | 19:23 |
| efried | stand by. | 19:23 |
| sean-k-mooney | i was going to say we shoudl navoe nova serial testing in the gate but it actuly just i nthe unit tests | 19:24 |
| sean-k-mooney | getting spice testing should be pretty simple we jus tneed to pick one of our exisitg jobs to swap over ot it | 19:25 |
| sean-k-mooney | im not sure if devstack deploy nova-serial | 19:25 |
| sean-k-mooney | it proably does but i have never used it | 19:25 |
| sean-k-mooney | melwitt: ^ | 19:25 |
| *** artom has quit IRC | 19:26 | |
| efried | mriedem, melwitt: +A | 19:27 |
| mriedem | hot | 19:27 |
| sean-k-mooney | if we change greande-py3 to nova-serial-proxy and sawped nova-greade-multione to spice and kept the neturon-greade multinoe as the default novnc it should cover all three? | 19:28 |
| efried | above my pay grade, sounds like a melwitt question. | 19:38 |
| zigo | Heya ! Got my first VM running on Train with all the RC1 packaged and uploaded to Debian already ! :) | 19:42 |
| zigo | It's never been that smooth ... :P | 19:42 |
| * mriedem waits for the "but x is broken" | 19:46 | |
| mriedem | zigo: that's good news, thanks for sharing | 19:46 |
| mriedem | we'll have an RC2, just fyi | 19:46 |
| zigo | mriedem: For the moment, there's no "but x is broken" part, as much as I know... :P | 19:46 |
| zigo | Still waiting for Glance RC1 though, it still not out. | 19:47 |
| zigo | Looks like it Glance from Stein is enough. :) | 19:47 |
| *** bbowen has quit IRC | 19:49 | |
| *** brinzhang has joined #openstack-nova | 19:54 | |
| *** brinzhang_ has quit IRC | 19:57 | |
| *** slaweq has quit IRC | 19:59 | |
| *** nweinber has quit IRC | 20:00 | |
| *** markvoelker has joined #openstack-nova | 20:00 | |
| *** brinzhang_ has joined #openstack-nova | 20:02 | |
| *** brinzhang has quit IRC | 20:05 | |
| *** tbachman has quit IRC | 20:11 | |
| *** tbachman has joined #openstack-nova | 20:20 | |
| mnaser | hmm | 20:23 |
| mnaser | i remember there was the rabbitmq api stuff we talked about a while ago | 20:23 |
| mnaser | is it possible that at some point if nova heartbeats get messed up, all processes seem to be forever stuck (heartbeat misses accumulate) | 20:23 |
| mnaser | >missed heartbeats from client, timeout: 60s | 20:24 |
| mnaser | with some "client unexpectedly closed TCP connection" | 20:25 |
| mnaser | and a whole bunch of: Unexpected error during heartbeart thread processing, retrying...: ConnectionForced: Too many heartbeats missed | 20:25 |
| mnaser | but also "Unexpected error during heartbeart thread processing, retrying...: error: [Errno 104] Connection reset by peer" (assuming this is when rabbitmq kills it cause it hasnt gotten heartbeat) | 20:25 |
| mnaser | and for context this is a very busy api so its not sitting idle | 20:25 |
| mriedem | are you thinking of this? https://review.opendev.org/#/c/662095/5/releasenotes/notes/eventlet-monkey-patch-5f734ef581aa550e.yaml | 20:26 |
| mnaser | hmm, threads=1 in this deployment (osa with uwsgi) | 20:27 |
| mnaser | and again this is a quite busy api endpoint so i dont imagine it sat idle for more than.. 5-10s at a time | 20:27 |
| mriedem | maybe check this out https://review.opendev.org/#/c/663074/ | 20:28 |
| mnaser | simple math shows 1000 requests per last 26 minutes so 38 requests per minute.. doubt thats enough to trigger something lik ethis | 20:28 |
| mnaser | hmm | 20:31 |
| mnaser | it'll be hard to run that | 20:31 |
| mnaser | but im also a bit curious why its triggering here at all | 20:31 |
| *** pcaruana has quit IRC | 20:33 | |
| mnaser | also we run HEAD / every few seconds too | 20:36 |
| mriedem | efried: explain to me why this wouldn't work in a test: | 20:43 |
| mriedem | 1. do something, | 20:43 |
| mriedem | 2. patch x | 20:43 |
| mriedem | 3. do something else | 20:43 |
| mriedem | 4. stop the patch on | 20:43 |
| mriedem | x | 20:43 |
| mriedem | 5. do another thing that hits the real thing that x was patching | 20:43 |
| *** xek has quit IRC | 20:43 | |
| mriedem | 5 is blowing up b/c it doesn't appear that stop is stopping the patch | 20:43 |
| mriedem | seems like it should work given https://docs.python.org/3.6/library/unittest.mock.html#patch-methods-start-and-stop | 20:44 |
| mriedem | calling mock.patch.stopall() seems to do what 4 isn't | 20:46 |
| *** gbarros has quit IRC | 20:48 | |
| mnaser | welp, it restarted happenign again not long after a service restart | 20:48 |
| mriedem | maybe a bug in the mock library | 20:50 |
| mriedem | anyway, i have a workaround, ignore me | 20:52 |
| efried | mriedem: without seeing the code... | 20:58 |
| efried | can I see the code? | 20:58 |
| efried | Cause what you're describing seems like it ought to work | 20:58 |
| efried | mriedem: a classic blunder is calling stop() on the *mock* (rather than the patcher) | 21:00 |
| mriedem | yeah it wasn't that | 21:00 |
| mriedem | p = mock.patch('x') | 21:00 |
| mriedem | p.start() | 21:00 |
| mriedem | ... | 21:00 |
| mriedem | p.stop() | 21:00 |
| mriedem | x() -> kablammo | 21:01 |
| *** tbachman has quit IRC | 21:01 | |
| mriedem | err, p = mock.patch('x', side_effect=kablammo) | 21:01 |
| mriedem | threads could be at play somehow, idk | 21:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression test for build part of bug 1781286 https://review.opendev.org/685998 | 21:03 |
| openstack | bug 1781286 in OpenStack Compute (nova) "CantStartEngineError in cell conductor during reschedule - get_host_availability_zone up-call" [Medium,In progress] https://launchpad.net/bugs/1781286 - Assigned to Matt Riedemann (mriedem) | 21:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional regression test for migrate part of bug 1781286 https://review.opendev.org/686017 | 21:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Selection.availability_zone field https://review.opendev.org/685807 | 21:03 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set Instance AZ from Selection AZ during build reschedule https://review.opendev.org/686047 | 21:03 |
| mriedem | if you're a glutton for punishment, what i was doing was at this point https://review.opendev.org/#/c/686047/1/nova/tests/functional/regressions/test_bug_1781286.py@72 | 21:04 |
| efried | In [8]: foo() | 21:04 |
| efried | real | 21:04 |
| efried | In [9]: p.start() | 21:04 |
| efried | Out[9]: <MagicMock name='foo' id='139999791540112'> | 21:04 |
| efried | In [10]: foo() | 21:04 |
| mriedem | i changed that to be something like: | 21:04 |
| efried | patched | 21:04 |
| efried | In [11]: p.stop() | 21:04 |
| efried | In [12]: foo() | 21:04 |
| efried | real | 21:04 |
| mriedem | self.agg_mock = mock.patch(...) | 21:04 |
| mriedem | self.agg_mock.start() | 21:04 |
| mriedem | and then later after fake_notifier.wait_for_versioned_notifications where i have mock.patch.stopall(), i had self.agg_mock.stop() | 21:04 |
| mriedem | and that wasn't working | 21:04 |
| efried | because you subsequently called get_by_host? | 21:05 |
| efried | as opposed to build_and_run_instance? | 21:06 |
| mriedem | the test goes on to call self._wait_for_state_change which hits the API which hit the thing i had previously mockd to fail yeah | 21:06 |
| efried | cause if you had called build_and_run_instance again, it would have reinstated your mock. | 21:06 |
| efried | but stop_all would have reverted your mock of build_and_run_instance | 21:07 |
| mriedem | what probably happened is there were 2 mocks | 21:07 |
| mriedem | and i only stopped one | 21:07 |
| efried | mm, because two instances? | 21:07 |
| mriedem | https://github.com/testing-cabal/mock/blob/master/mock/mock.py#L1533 | 21:07 |
| mriedem | 2 calls to build_and_run_instance | 21:07 |
| mriedem | 2 hosts | 21:07 |
| mriedem | it's a reschedule test | 21:07 |
| efried | that'd do it :) | 21:07 |
| mriedem | yup, so stopall to the rescue | 21:08 |
| efried | well, except that's going to stop... *all* of your mocks. | 21:08 |
| efried | o | 21:08 |
| *** ociuhandu has joined #openstack-nova | 21:08 | |
| efried | only the ones you started with start() | 21:08 |
| efried | brittle | 21:08 |
| mriedem | that's fine for this test; anyway, thanks for making me think through it - now i can explain why i'm using stopall when artom -1s my change | 21:08 |
| * mriedem adds the comment now | 21:09 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set Instance AZ from Selection AZ during build reschedule https://review.opendev.org/686047 | 21:10 |
| *** bbowen has joined #openstack-nova | 21:11 | |
| *** ociuhandu has quit IRC | 21:12 | |
| *** gbarros has joined #openstack-nova | 21:32 | |
| *** openstackstatus has quit IRC | 21:32 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set Instance AZ from Selection AZ during migrate reschedule https://review.opendev.org/686050 | 21:33 |
| *** openstackstatus has joined #openstack-nova | 21:35 | |
| *** ChanServ sets mode: +v openstackstatus | 21:35 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Set Instance AZ from Selection AZ during migrate reschedule https://review.opendev.org/686050 | 21:36 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update cells v2 up-call caveats doc https://review.opendev.org/686053 | 21:46 |
| *** tbachman has joined #openstack-nova | 21:49 | |
| *** munimeha1 has quit IRC | 21:51 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Re-propose policy-defaults-refresh spec for Ussuri https://review.opendev.org/686058 | 21:55 |
| *** mriedem has quit IRC | 21:56 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/stein: Reduce scope of 'path' query parameter to noVNC consoles https://review.opendev.org/686063 | 22:08 |
| *** luksky has quit IRC | 22:10 | |
| efried | melwitt: did you miss the train cherry-pick? | 22:14 |
| efried | or did I? | 22:14 |
| melwitt | efried: no, I missed it. sorry, I forgot the branch was cut | 22:15 |
| melwitt | will fix | 22:15 |
| efried | at least it's clean :P | 22:15 |
| openstackgerrit | melanie witt proposed openstack/nova stable/train: Reduce scope of 'path' query parameter to noVNC consoles https://review.opendev.org/686066 | 22:16 |
| openstackgerrit | melanie witt proposed openstack/nova stable/stein: Reduce scope of 'path' query parameter to noVNC consoles https://review.opendev.org/686063 | 22:17 |
| openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Reduce scope of 'path' query parameter to noVNC consoles https://review.opendev.org/686067 | 22:22 |
| *** tkajinam has joined #openstack-nova | 22:50 | |
| *** BjoernT has quit IRC | 23:04 | |
| *** macz has quit IRC | 23:05 | |
| *** macz has joined #openstack-nova | 23:07 | |
| *** macz has quit IRC | 23:10 | |
| *** gbarros has quit IRC | 23:25 | |
| *** mlavalle has quit IRC | 23:31 | |
| *** BjoernT has joined #openstack-nova | 23:33 | |
| *** rcernin has joined #openstack-nova | 23:33 | |
| openstackgerrit | Merged openstack/nova stable/stein: Make nova.compute.rpcapi.ComputeAPI.router a singleton https://review.opendev.org/684405 | 23:36 |
| openstackgerrit | Merged openstack/nova stable/stein: Func test for migrate reschedule with pinned compute rpc https://review.opendev.org/684406 | 23:36 |
| openstackgerrit | Merged openstack/nova stable/stein: Handle legacy request spec dict in ComputeTaskManager._cold_migrate https://review.opendev.org/684407 | 23:36 |
| openstackgerrit | Merged openstack/nova master: Reduce scope of 'path' query parameter to noVNC consoles https://review.opendev.org/685194 | 23:36 |
| *** markvoelker has quit IRC | 23:38 | |
| *** bbowen_ has joined #openstack-nova | 23:39 | |
| *** bbowen has quit IRC | 23:41 | |
| *** gbarros has joined #openstack-nova | 23:42 | |
| *** markvoelker has joined #openstack-nova | 23:44 | |
| *** ivve has quit IRC | 23:47 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!