*** gyee has quit IRC | 00:06 | |
*** tetsuro has joined #openstack-nova | 00:15 | |
openstackgerrit | Merged openstack/nova stable/stein: Reduce scope of 'path' query parameter to noVNC consoles https://review.opendev.org/686063 | 00:22 |
---|---|---|
*** gbarros has joined #openstack-nova | 00:28 | |
*** tetsuro has quit IRC | 00:29 | |
*** tetsuro has joined #openstack-nova | 00:29 | |
*** artom has quit IRC | 00:54 | |
*** hongbin has joined #openstack-nova | 01:01 | |
*** munimeha1 has quit IRC | 01:05 | |
*** tetsuro has quit IRC | 01:06 | |
*** avolkov has quit IRC | 01:18 | |
*** tetsuro has joined #openstack-nova | 01:39 | |
*** tetsuro has quit IRC | 01:44 | |
*** igordc has quit IRC | 02:01 | |
*** SonPham has joined #openstack-nova | 02:13 | |
*** BjoernT has joined #openstack-nova | 02:15 | |
*** tetsuro has joined #openstack-nova | 02:17 | |
*** gbarros has quit IRC | 02:17 | |
SonPham | have any project for nova for snapshot(keep memory and process state) like bp? : https://blueprints.launchpad.net/nova/+spec/live-snapshot-vms | 02:21 |
*** tetsuro has quit IRC | 02:21 | |
openstackgerrit | Merged openstack/nova stable/queens: Hook resource_tracker to remove stale node information https://review.opendev.org/676282 | 02:23 |
*** mkrai has joined #openstack-nova | 02:37 | |
*** mkrai_ has joined #openstack-nova | 02:37 | |
*** factor has joined #openstack-nova | 02:47 | |
*** tinwood has quit IRC | 02:50 | |
*** hongbin has quit IRC | 02:51 | |
*** tinwood has joined #openstack-nova | 02:52 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/train: Restore console proxy deployment info to cells v2 layout doc https://review.opendev.org/686325 | 03:03 |
*** markvoelker has joined #openstack-nova | 03:07 | |
*** markvoelker has quit IRC | 03:11 | |
*** markvoelker has joined #openstack-nova | 03:21 | |
*** markvoelker has quit IRC | 03:24 | |
openstackgerrit | Merged openstack/nova master: Test heal port allocations in nova-next https://review.opendev.org/669879 | 03:28 |
*** markvoelker has joined #openstack-nova | 03:30 | |
*** takashin has left #openstack-nova | 03:30 | |
*** markvoelker has quit IRC | 03:32 | |
*** markvoelker has joined #openstack-nova | 03:32 | |
*** markvoelker has quit IRC | 03:37 | |
*** dave-mccowan has quit IRC | 03:37 | |
*** markvoelker has joined #openstack-nova | 04:07 | |
*** BjoernT has quit IRC | 04:09 | |
*** udesale has joined #openstack-nova | 04:13 | |
*** ociuhandu has joined #openstack-nova | 04:14 | |
*** ociuhandu has quit IRC | 04:18 | |
*** sapd1_x has joined #openstack-nova | 04:20 | |
SonPham | hi | 04:23 |
SonPham | I would like to propose a new feature for Nova | 04:23 |
SonPham | after i create a blueprint | 04:23 |
SonPham | What should I do next? | 04:24 |
*** rcernin has quit IRC | 04:29 | |
*** rcernin has joined #openstack-nova | 04:32 | |
*** markvoelker has quit IRC | 04:37 | |
*** markvoelker has joined #openstack-nova | 05:01 | |
*** mkrai has quit IRC | 05:01 | |
*** mkrai_ has quit IRC | 05:01 | |
*** mkrai_ has joined #openstack-nova | 05:02 | |
*** mkrai has joined #openstack-nova | 05:02 | |
*** spsurya has joined #openstack-nova | 05:04 | |
*** markvoelker has quit IRC | 05:06 | |
*** sapd1_x has quit IRC | 05:06 | |
*** markvoelker has joined #openstack-nova | 05:11 | |
*** markvoelker has quit IRC | 05:15 | |
*** dpawlik has joined #openstack-nova | 05:17 | |
*** markvoelker has joined #openstack-nova | 05:20 | |
*** markvoelker has quit IRC | 05:24 | |
*** ratailor has joined #openstack-nova | 05:26 | |
*** markvoelker has joined #openstack-nova | 05:29 | |
*** markvoelker has quit IRC | 05:34 | |
*** markvoelker has joined #openstack-nova | 05:38 | |
*** markvoelker has quit IRC | 05:43 | |
*** markvoelker has joined #openstack-nova | 05:47 | |
*** ratailor_ has joined #openstack-nova | 05:48 | |
*** markvoelker has quit IRC | 05:52 | |
*** ratailor has quit IRC | 05:52 | |
*** mkrai_ has quit IRC | 05:56 | |
*** mkrai__ has joined #openstack-nova | 05:57 | |
*** markvoelker has joined #openstack-nova | 05:57 | |
*** markvoelker has quit IRC | 06:02 | |
*** lpetrut has joined #openstack-nova | 06:02 | |
*** lpetrut has quit IRC | 06:03 | |
*** lpetrut has joined #openstack-nova | 06:03 | |
*** markvoelker has joined #openstack-nova | 06:06 | |
*** markvoelker has quit IRC | 06:10 | |
*** markvoelker has joined #openstack-nova | 06:15 | |
*** markvoelker has quit IRC | 06:20 | |
*** jaosorior has joined #openstack-nova | 06:21 | |
*** markvoelker has joined #openstack-nova | 06:24 | |
*** markvoelker has quit IRC | 06:29 | |
*** xek has joined #openstack-nova | 06:32 | |
*** markvoelker has joined #openstack-nova | 06:33 | |
SonPham | hi | 06:37 |
*** markvoelker has quit IRC | 06:38 | |
*** markvoelker has joined #openstack-nova | 06:43 | |
*** markvoelker has quit IRC | 06:47 | |
*** SonPham has quit IRC | 06:51 | |
*** markvoelker has joined #openstack-nova | 06:52 | |
*** mkrai has quit IRC | 06:52 | |
*** mkrai has joined #openstack-nova | 06:52 | |
*** mkrai_ has joined #openstack-nova | 06:52 | |
*** mkrai__ has quit IRC | 06:56 | |
*** markvoelker has quit IRC | 06:57 | |
*** udesale has quit IRC | 06:58 | |
*** udesale has joined #openstack-nova | 06:59 | |
*** mkrai has quit IRC | 06:59 | |
*** mkrai_ has quit IRC | 06:59 | |
*** mkrai has joined #openstack-nova | 06:59 | |
*** mkrai_ has joined #openstack-nova | 06:59 | |
*** lpetrut has quit IRC | 06:59 | |
*** lpetrut has joined #openstack-nova | 07:00 | |
*** markvoelker has joined #openstack-nova | 07:01 | |
*** udesale has quit IRC | 07:02 | |
*** udesale has joined #openstack-nova | 07:02 | |
*** maciejjozefczyk has joined #openstack-nova | 07:04 | |
*** damien_r has joined #openstack-nova | 07:05 | |
*** markvoelker has quit IRC | 07:05 | |
*** rcernin has quit IRC | 07:06 | |
*** ttsiouts has joined #openstack-nova | 07:07 | |
*** markvoelker has joined #openstack-nova | 07:10 | |
*** tesseract has joined #openstack-nova | 07:12 | |
*** markvoelker has quit IRC | 07:15 | |
*** luksky has joined #openstack-nova | 07:16 | |
*** markvoelker has joined #openstack-nova | 07:19 | |
*** ociuhandu has joined #openstack-nova | 07:22 | |
*** ociuhandu has quit IRC | 07:23 | |
*** markvoelker has quit IRC | 07:24 | |
*** ttsiouts has quit IRC | 07:26 | |
*** ttsiouts has joined #openstack-nova | 07:27 | |
*** pcaruana has joined #openstack-nova | 07:28 | |
*** markvoelker has joined #openstack-nova | 07:29 | |
kashyap | SonPham: The blueprint needs to get 'approved' by "cores" for the current development cycle. | 07:30 |
*** ttsiouts has quit IRC | 07:31 | |
*** SonPham has joined #openstack-nova | 07:31 | |
kashyap | SonPham: For that, you might want to hang around here on this channel and ask when you see 'activity' | 07:32 |
kashyap | SonPham: Another way to socialize your idea is to write a quick email to the 'openstack-discuss' list with [nova] tag, describing the potential feature. | 07:33 |
*** ttsiouts has joined #openstack-nova | 07:33 | |
*** markvoelker has quit IRC | 07:34 | |
*** ratailor__ has joined #openstack-nova | 07:35 | |
SonPham | kashyap who 'activity' ? | 07:35 |
SonPham | the core review? | 07:35 |
*** ociuhandu has joined #openstack-nova | 07:36 | |
kashyap | SonPham: I mean, people are spread over all. But the most majority of maintainers are in EST / CET timezones. | 07:36 |
*** ratailor_ has quit IRC | 07:37 | |
kashyap | s/"over all"/"over different timezones"/ | 07:38 |
*** markvoelker has joined #openstack-nova | 07:38 | |
*** markvoelker has quit IRC | 07:43 | |
*** jangutter has joined #openstack-nova | 07:46 | |
*** markvoelker has joined #openstack-nova | 07:47 | |
*** udesale has quit IRC | 07:48 | |
*** udesale has joined #openstack-nova | 07:48 | |
*** ttsiouts has quit IRC | 07:48 | |
*** lpetrut has quit IRC | 07:48 | |
*** ttsiouts has joined #openstack-nova | 07:49 | |
*** lpetrut has joined #openstack-nova | 07:49 | |
*** markvoelker has quit IRC | 07:52 | |
*** ttsiouts has quit IRC | 07:53 | |
*** rpittau|afk is now known as rpittau | 07:59 | |
*** SonPham has quit IRC | 08:00 | |
*** tkajinam has quit IRC | 08:00 | |
*** ociuhandu has quit IRC | 08:04 | |
*** ociuhandu has joined #openstack-nova | 08:04 | |
*** ociuhandu has quit IRC | 08:05 | |
*** ociuhandu has joined #openstack-nova | 08:05 | |
*** markvoelker has joined #openstack-nova | 08:06 | |
*** slaweq has joined #openstack-nova | 08:06 | |
*** ttsiouts has joined #openstack-nova | 08:07 | |
*** markvoelker has quit IRC | 08:11 | |
*** markvoelker has joined #openstack-nova | 08:15 | |
*** tssurya has joined #openstack-nova | 08:18 | |
*** jaosorior has quit IRC | 08:19 | |
*** markvoelker has quit IRC | 08:20 | |
*** panda|off is now known as panda | 08:20 | |
bauzas | good morning Nova | 08:22 |
*** mkrai_ has quit IRC | 08:24 | |
*** mkrai has quit IRC | 08:24 | |
*** markvoelker has joined #openstack-nova | 08:24 | |
*** mkrai has joined #openstack-nova | 08:25 | |
*** mkrai_ has joined #openstack-nova | 08:25 | |
*** markvoelker has quit IRC | 08:29 | |
*** ccamacho has joined #openstack-nova | 08:31 | |
*** markvoelker has joined #openstack-nova | 08:34 | |
*** markvoelker has quit IRC | 08:39 | |
*** slaweq has quit IRC | 08:41 | |
*** derekh has joined #openstack-nova | 08:42 | |
*** markvoelker has joined #openstack-nova | 08:52 | |
*** slaweq has joined #openstack-nova | 08:52 | |
*** tetsuro has joined #openstack-nova | 08:55 | |
*** markvoelker has quit IRC | 08:57 | |
kashyap | Morning | 08:59 |
kashyap | stephenfin: sean-k-mooney: Do you know if any operators care about CPU hotplug? | 09:00 |
kashyap | (Or anyone) | 09:00 |
kashyap | (At least I see an old blueprint for it - https://blueprints.launchpad.net/nova/+spec/instance-mem-and-cpu-hot-plugging) | 09:01 |
*** markvoelker has joined #openstack-nova | 09:01 | |
*** markvoelker has quit IRC | 09:06 | |
*** markvoelker has joined #openstack-nova | 09:10 | |
*** markvoelker has quit IRC | 09:15 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't create instance_extra entry for deleted instance https://review.opendev.org/412771 | 09:15 |
*** ricolin has quit IRC | 09:15 | |
*** markvoelker has joined #openstack-nova | 09:20 | |
*** aloga has quit IRC | 09:22 | |
*** sapd1_x has joined #openstack-nova | 09:24 | |
*** aloga has joined #openstack-nova | 09:24 | |
*** markvoelker has quit IRC | 09:25 | |
*** markvoelker has joined #openstack-nova | 09:29 | |
openstackgerrit | Merged openstack/nova master: Add functional regression test for build part of bug 1781286 https://review.opendev.org/685998 | 09:29 |
openstack | bug 1781286 in OpenStack Compute (nova) "CantStartEngineError in cell conductor during reschedule - get_host_availability_zone up-call" [Medium,In progress] https://launchpad.net/bugs/1781286 - Assigned to Matt Riedemann (mriedem) | 09:29 |
*** markvoelker has quit IRC | 09:34 | |
openstackgerrit | Merged openstack/nova master: Add functional regression test for migrate part of bug 1781286 https://review.opendev.org/686017 | 09:35 |
openstack | bug 1781286 in OpenStack Compute (nova) "CantStartEngineError in cell conductor during reschedule - get_host_availability_zone up-call" [Medium,In progress] https://launchpad.net/bugs/1781286 - Assigned to Matt Riedemann (mriedem) | 09:35 |
*** markvoelker has joined #openstack-nova | 09:38 | |
openstackgerrit | Merged openstack/python-novaclient stable/stein: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685981 | 09:39 |
*** markvoelker has quit IRC | 09:43 | |
*** markvoelker has joined #openstack-nova | 09:48 | |
*** ociuhandu has quit IRC | 09:50 | |
*** ociuhandu has joined #openstack-nova | 09:51 | |
*** markvoelker has quit IRC | 09:52 | |
*** udesale has quit IRC | 09:53 | |
*** udesale has joined #openstack-nova | 09:54 | |
*** markvoelker has joined #openstack-nova | 09:57 | |
*** jaosorior has joined #openstack-nova | 09:59 | |
*** jawad_axd has joined #openstack-nova | 10:00 | |
*** markvoelker has quit IRC | 10:01 | |
*** jawad_axd has quit IRC | 10:02 | |
*** jawad_axd has joined #openstack-nova | 10:02 | |
bauzas | gibi: <3 | 10:03 |
bauzas | gibi: you're totally right, I forgot to update my cell check when looking at the RPs | 10:03 |
bauzas | gibi: for the audit command | 10:03 |
bauzas | gibi: so that's why https://paste.ubuntu.com/p/J4S3Y3r4fh/ | 10:04 |
*** markvoelker has joined #openstack-nova | 10:06 | |
*** jaosorior has quit IRC | 10:06 | |
*** markvoelker has quit IRC | 10:11 | |
*** yan0s has joined #openstack-nova | 10:12 | |
*** tetsuro has quit IRC | 10:14 | |
*** markvoelker has joined #openstack-nova | 10:15 | |
*** markvoelker has quit IRC | 10:20 | |
*** mgoddard has quit IRC | 10:23 | |
*** jaosorior has joined #openstack-nova | 10:24 | |
*** markvoelker has joined #openstack-nova | 10:24 | |
*** mgoddard has joined #openstack-nova | 10:26 | |
*** cdent has joined #openstack-nova | 10:27 | |
*** cdent has left #openstack-nova | 10:28 | |
*** markvoelker has quit IRC | 10:29 | |
*** ttsiouts has quit IRC | 10:31 | |
*** ttsiouts has joined #openstack-nova | 10:31 | |
*** markvoelker has joined #openstack-nova | 10:34 | |
*** ttsiouts has quit IRC | 10:36 | |
*** markvoelker has quit IRC | 10:38 | |
sean-k-mooney | kashyap: both memory and cpu hotplug have been reject in the past both as an api do explcitly added/remove each resource to/form an instnace and in the form of live reszie | 10:38 |
sean-k-mooney | but there has been requests for it | 10:39 |
sean-k-mooney | arbiatry hotplug was rejected as it basical breaks flavors | 10:39 |
sean-k-mooney | and how flavors are used for billing | 10:40 |
*** tbachman has quit IRC | 10:40 | |
sean-k-mooney | i also suspec based on comment made by dansmith in the past that while we try to ues the embeded flavor everywhere that it maters there may be edgecase where we dont so adding hotplug support that is not flavor based could have implciations for move operations | 10:41 |
sean-k-mooney | the flavor based appach was reject for a diffrent reason | 10:41 |
sean-k-mooney | resize down if very hard | 10:42 |
sean-k-mooney | you technially can offline cpus or dimms in the linux kernel then hot unplug them but that requries guest coperation | 10:42 |
*** markvoelker has joined #openstack-nova | 10:43 | |
sean-k-mooney | hot adding of cpus and memory generaly requires you to forward declare a set of free dimm slots or cpu sockets | 10:43 |
*** rcernin has joined #openstack-nova | 10:43 | |
sean-k-mooney | and like the pcie ports i suspect there is qemu overhead required to support that so if you were to do that by default you would waste ram | 10:44 |
sean-k-mooney | so ya im not sure it fits with the cloud model where i think the spot isntance model is much more correct. e.g. burst horizontally not vertically | 10:45 |
*** markvoelker has quit IRC | 10:47 | |
*** tetsuro has joined #openstack-nova | 10:48 | |
kashyap | sean-k-mooney: Hi, reading the scroll now | 10:50 |
kashyap | sean-k-mooney: (Yeah, I recall the perils of the resize down) | 10:50 |
kashyap | sean-k-mooney: Thanks for the input. | 10:51 |
*** jaosorior has quit IRC | 10:51 | |
*** markvoelker has joined #openstack-nova | 10:52 | |
*** tetsuro has quit IRC | 10:54 | |
*** markvoelker has quit IRC | 10:57 | |
gibi | bauzas: I'm happy that I could help | 10:58 |
*** bbowen has quit IRC | 10:58 | |
*** ttsiouts has joined #openstack-nova | 11:01 | |
*** markvoelker has joined #openstack-nova | 11:01 | |
*** ociuhandu has quit IRC | 11:02 | |
*** ociuhandu has joined #openstack-nova | 11:02 | |
bauzas | gibi: around ? I wonder how to fix the cells issue | 11:04 |
gibi | bauzas: partially, I'm on a full day internal workshop | 11:05 |
gibi | bauzas: but I think there is good example in the heal_allocations code about cell handling | 11:05 |
*** markvoelker has quit IRC | 11:06 | |
*** ociuhandu has quit IRC | 11:07 | |
gibi | bauzas: https://github.com/openstack/nova/blob/caffac7bb06cf7606f7447d0f2ee37ba50dd0b48/nova/cmd/manage.py#L2448 | 11:08 |
bauzas | gibi: the problem is that I need to find the cell for a compute node UUID | 11:09 |
bauzas | gibi: the problem is that I don't know yet the hostname | 11:09 |
*** gbarros has joined #openstack-nova | 11:09 | |
bauzas | anyway, /me needs to go the school for his daughters | 11:09 |
bauzas | back | 11:09 |
gibi | bauzas: talk to you later | 11:10 |
*** markvoelker has joined #openstack-nova | 11:10 | |
*** luksky has quit IRC | 11:13 | |
*** markvoelker has quit IRC | 11:15 | |
*** udesale has quit IRC | 11:17 | |
*** markvoelker has joined #openstack-nova | 11:20 | |
*** ociuhandu has joined #openstack-nova | 11:23 | |
*** tetsuro has joined #openstack-nova | 11:24 | |
*** markvoelker has quit IRC | 11:24 | |
*** gbarros has quit IRC | 11:25 | |
*** ociuhandu has quit IRC | 11:25 | |
*** ociuhandu has joined #openstack-nova | 11:26 | |
*** tetsuro has quit IRC | 11:28 | |
*** markvoelker has joined #openstack-nova | 11:29 | |
*** markvoelker has quit IRC | 11:34 | |
*** rcernin has quit IRC | 11:34 | |
*** markvoelker has joined #openstack-nova | 11:38 | |
*** markvoelker has quit IRC | 11:42 | |
*** dosaboy has quit IRC | 11:45 | |
*** ociuhandu has quit IRC | 11:47 | |
*** ociuhandu has joined #openstack-nova | 11:47 | |
*** markvoelker has joined #openstack-nova | 11:47 | |
*** ociuhandu has quit IRC | 11:48 | |
*** ociuhandu has joined #openstack-nova | 11:49 | |
*** ratailor__ has quit IRC | 11:50 | |
*** markvoelker has quit IRC | 11:52 | |
*** sapd1_x has quit IRC | 11:52 | |
*** dosaboy has joined #openstack-nova | 11:54 | |
stephenfin | gibi: Replied on https://review.opendev.org/#/c/684334/ | 11:54 |
*** ociuhandu has quit IRC | 11:54 | |
*** markvoelker has joined #openstack-nova | 11:57 | |
*** markvoelker has quit IRC | 12:01 | |
*** dosaboy has quit IRC | 12:03 | |
*** dosaboy has joined #openstack-nova | 12:03 | |
*** ociuhandu has joined #openstack-nova | 12:03 | |
*** markvoelker has joined #openstack-nova | 12:05 | |
*** bbowen has joined #openstack-nova | 12:07 | |
gibi | stephenfin: thanks for the explanation. | 12:07 |
*** ociuhandu has quit IRC | 12:07 | |
*** luksky has joined #openstack-nova | 12:07 | |
*** gbarros has joined #openstack-nova | 12:12 | |
*** mkrai_ has quit IRC | 12:13 | |
*** mkrai has quit IRC | 12:13 | |
*** takashin has joined #openstack-nova | 12:15 | |
*** markvoelker has quit IRC | 12:17 | |
*** ttsiouts has quit IRC | 12:17 | |
*** markvoelker has joined #openstack-nova | 12:17 | |
*** ttsiouts has joined #openstack-nova | 12:17 | |
*** mkrai has joined #openstack-nova | 12:18 | |
*** mkrai_ has joined #openstack-nova | 12:18 | |
*** ttsiouts has quit IRC | 12:19 | |
*** markvoelker has quit IRC | 12:19 | |
*** ttsiouts has joined #openstack-nova | 12:19 | |
*** gbarros has quit IRC | 12:27 | |
*** ociuhandu has joined #openstack-nova | 12:29 | |
*** ociuhandu has quit IRC | 12:36 | |
*** ociuhandu has joined #openstack-nova | 12:38 | |
*** ociuhandu has quit IRC | 12:44 | |
*** tbachman has joined #openstack-nova | 12:55 | |
*** jmlowe has quit IRC | 12:57 | |
*** markvoelker has joined #openstack-nova | 13:01 | |
*** ociuhandu has joined #openstack-nova | 13:01 | |
*** mkrai_ has quit IRC | 13:01 | |
*** mkrai has quit IRC | 13:01 | |
*** mkrai has joined #openstack-nova | 13:02 | |
*** mkrai_ has joined #openstack-nova | 13:02 | |
*** yan0s has quit IRC | 13:04 | |
*** BjoernT has joined #openstack-nova | 13:18 | |
*** yan0s has joined #openstack-nova | 13:20 | |
*** mriedem has joined #openstack-nova | 13:22 | |
*** luksky has quit IRC | 13:23 | |
*** jmlowe has joined #openstack-nova | 13:25 | |
*** ociuhandu has quit IRC | 13:29 | |
mriedem | stephenfin: ping me when you get https://review.opendev.org/667133 updated and i'll take a look, don't want to lose track of that since it's huge | 13:29 |
*** mkrai_ has quit IRC | 13:29 | |
*** mkrai has quit IRC | 13:29 | |
*** BjoernT has quit IRC | 13:29 | |
*** ociuhandu has joined #openstack-nova | 13:30 | |
*** BjoernT has joined #openstack-nova | 13:31 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Skip test_parallel_evacuate_with_server_group until fixed https://review.opendev.org/686402 | 13:33 |
*** udesale has joined #openstack-nova | 13:33 | |
gibi | bauzas: I think I see your compute node uuid -> cell mapping issue in https://review.opendev.org/#/c/670112 | 13:39 |
gibi | bauzas: we cannot map a compute node back to a cell easily. | 13:40 |
gibi | bauzas: if we assume that the compute node RP's name is the hostname of the compute host, then we can map to cells. But the we cannot support virt drivers using more than one node per host | 13:41 |
mriedem | you can map the compute node to a host mapping which is in a cell | 13:43 |
bauzas | gibi: the problem is that we only know the RP UUID | 13:43 |
mriedem | rp uuid == compute node uuid == get the compute node == get the host mapping == get the cell | 13:43 |
*** artom has joined #openstack-nova | 13:44 | |
bauzas | mriedem: sure, but in the nova-manage, I can't just ask https://review.opendev.org/#/c/670112/5/nova/cmd/manage.py@2669 directly, right? | 13:44 |
mriedem | oh i see, chicken and egg | 13:46 |
mriedem | you can scatter/gather cells looking for hte compute node by uuid | 13:46 |
dansmith | scatter/gather? | 13:46 |
dansmith | yeah | 13:46 |
mriedem | that's what the api does i think | 13:47 |
*** ociuhandu has quit IRC | 13:47 | |
*** ociuhandu has joined #openstack-nova | 13:47 | |
gibi | yeah you have to search for the root RP UUID as a compute node id in every cell | 13:47 |
mriedem | well i guess it doesn't https://github.com/openstack/nova/blob/master/nova/compute/api.py#L5261 but it could | 13:47 |
bauzas | I can scatter/gather for sure | 13:48 |
bauzas | but it will take time | 13:48 |
bauzas | I mean, it's a performance issue | 13:48 |
*** ociuhandu has quit IRC | 13:48 | |
dansmith | eh? | 13:48 |
gibi | bauzas: would be better scatter / gather once to get all the compute node objects from all cells? | 13:48 |
*** ociuhandu has joined #openstack-nova | 13:48 | |
bauzas | when calling the audit command, then we would have to look at all the cells to find the one having the CN UUID | 13:48 |
mriedem | scatter/gather non-cell0 cells since you shouldn't have compute nodes in cell0, | 13:48 |
mriedem | and for most deployments that's only going to be 1 cell to query | 13:49 |
dansmith | bauzas: you need to scatter/gather a get_by_uuid() right? | 13:49 |
dansmith | that should be uber fast | 13:49 |
bauzas | I did this for PS1 https://review.opendev.org/#/c/670112/1/nova/cmd/manage.py@2309 | 13:49 |
bauzas | dansmith: okay, lemme try to do it | 13:50 |
bauzas | and then we could for example ask CERN to verify the performance | 13:50 |
bauzas | or mnaser :) | 13:50 |
mriedem | my comment wasn't about using scatter/gather, it was about starting with compute nodes and working backward to resource providers | 13:51 |
bauzas | mriedem: gibi: dansmith: thanks for the help | 13:51 |
gibi | bauzas: np | 13:51 |
bauzas | mriedem: yeah, no worries, I already understood this, I just tried to explain that I already used scatter_gather so I already know it :) | 13:51 |
mriedem | being an audit / heal style command, i don't think blazying fast performance is the primary concern | 13:51 |
mriedem | *blazing even | 13:52 |
mriedem | do you allow passing in a single uuid to audit? if not you probably should so you don't have to audit all 20K nodes just to heal one of them that is a problem. | 13:52 |
mnaser | yeah i think we should loop over RPs instead of CNs | 13:53 |
gibi | mriedem: yes, the command has a --resource_provider flag | 13:53 |
mriedem | 20K compute services + x number of ironic VMs... | 13:53 |
mriedem | *ironic BMs / instances | 13:53 |
dansmith | mriedem: you know, this has come up before.. we really should move HostMapping to use (or at least have) the compute uuid in there | 13:53 |
mriedem | dansmith: the cardinality isn't correct for that | 13:54 |
mriedem | for ironic you have 1 host mapping to x nodes | 13:54 |
mriedem | gibi: ok good - except let's drop the underscore in the option name, i hate that | 13:54 |
mriedem | e.g. --max_rows | 13:54 |
mriedem | options should use dashes | 13:54 |
dansmith | mriedem: right, which also causes us trouble and why we need thatother mechanism of hostmapping discovery... | 13:54 |
mriedem | i think stephenfin and i might agree on one thing and that's probably it | 13:54 |
dansmith | mriedem: I the point is we kinda need nodes and hosts in there, by uuid or name depending :D | 13:55 |
mriedem | dansmith: so for an ironic compute service, the HostMapping just wouldn't have uuid set? | 13:55 |
sean-k-mooney | well we can still have a 1:n mapping in the 1:1 case it jsut a specific value of n | 13:55 |
*** david-lyle has quit IRC | 13:55 | |
*** david-lyle has joined #openstack-nova | 13:55 | |
sean-k-mooney | so we could model it in the db using a mapping table | 13:56 |
mriedem | .... | 13:56 |
sean-k-mooney | and in the object as a list right? | 13:56 |
sean-k-mooney | which might be what we alreday do | 13:56 |
sean-k-mooney | i was not following the conversation | 13:56 |
mriedem | from a coding api perspective, if i'm relying on the host mapping uuid to get/match the compute node uuid, then how do i know if that host is managing one or many nodes | 13:57 |
mriedem | also, | 13:57 |
dansmith | mriedem: maybe I dunno | 13:57 |
mriedem | the host mapping name doesn't / shouldn't change (the hostname on the host would have to change which is bad), | 13:57 |
*** ociuhandu has quit IRC | 13:57 | |
mriedem | but i can guarantee you that the compute node uuid generated by the compute service will change | 13:57 |
mriedem | and that would be an up-call or new discovery from the controller to sync those up | 13:57 |
*** ociuhandu has joined #openstack-nova | 13:58 | |
sean-k-mooney | its unfortunate that we are not usign a uuid5 based on teh host name for the compute node uuid | 13:58 |
mriedem | all you have to is (1) start the service, (2) discover it to create the host mapping, (3) delete the compute service (4) restart it and bam you have a new compute node with a new uuid | 13:58 |
mriedem | sean-k-mooney: that's not a bad idea...in the non-ironic case, | 13:59 |
mriedem | for ironic, since rocky we make the compute node == resource provider == ironic node all use the ironic node uuid | 13:59 |
mriedem | that has caused some problems... | 13:59 |
bauzas | mriedem: yup, either the audit command loops over RPs, or asks for a specific RP UUID | 13:59 |
sean-k-mooney | the ironic node id often matche the chassis uuid backed into the hardware | 13:59 |
mriedem | meeting time | 14:00 |
dansmith | mriedem: sorry I lost track of that convo because I was having two | 14:00 |
mriedem | this is the problem i'm talking about with using static uuids https://review.opendev.org/#/q/Iafba419fe86446ffe636721f523fb619f8f787b3 | 14:01 |
mriedem | sean-k-mooney: ^ | 14:01 |
mriedem | somewhat related https://review.opendev.org/#/c/684849/ | 14:01 |
sean-k-mooney | oh ya i vaguely rememebr that it was related to the phyical node reblanice to a different compute service | 14:02 |
mriedem | the first is related to maintenance mode on a node, the latter is rebalance | 14:02 |
sean-k-mooney | ack | 14:02 |
*** ociuhandu has quit IRC | 14:03 | |
stephenfin | mriedem: <3 | 14:03 |
sean-k-mooney | i need to grab somthing to eat before another meeting in an hour so ill join the nova meeting in link 20-30 mins | 14:03 |
sean-k-mooney | brb | 14:03 |
mordred | mriedem: in microversion 2.64, os-server-group changed from accepting policies=[] to policy="" ... what happens to additional policies created with lower microversion? | 14:04 |
mriedem | it was unpossible on lower microversions | 14:04 |
mriedem | shitty api design allowed a list but the backing db model didn't | 14:04 |
mriedem | something like that - the json schema only allowed a list with an entry of exactly 1 | 14:04 |
mordred | ah - cool | 14:05 |
mordred | so that makes it super easy to support properly in sdk | 14:05 |
*** tbachman has quit IRC | 14:05 | |
mriedem | mordred: yeah see the description of the parameter in the ref https://docs.openstack.org/api-ref/compute/?expanded=create-server-group-detail#create-server-group | 14:06 |
*** ociuhandu has joined #openstack-nova | 14:06 | |
mriedem | before 2.64: "A list of exactly one policy name to associate with the server group." | 14:06 |
*** rnoriega- has joined #openstack-nova | 14:06 | |
mordred | that's amazing | 14:06 |
mriedem | the poor api design before or the fact it was actually documented? | 14:07 |
mriedem | both?! | 14:07 |
mordred | both! | 14:07 |
mordred | also - I'm glad the answer this time does not require me to figure out how to do more complex logic | 14:07 |
mordred | sg_attrs['policy'] = policies[0] # this is awesome | 14:07 |
mriedem | yup | 14:08 |
mordred | oh - although - I still probably want to figure out how to switch somethign there - because older mvs won't have the policy parameter | 14:08 |
mordred | maybe I'll just wait until someone complains | 14:08 |
*** rnoriega_ has quit IRC | 14:09 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Add reserved schema migrations for Ussuri https://review.opendev.org/686411 | 14:09 |
*** JamesBenson has joined #openstack-nova | 14:09 | |
*** ociuhandu has quit IRC | 14:10 | |
*** tbachman has joined #openstack-nova | 14:11 | |
stephenfin | melwitt: I assume I can kill the entire 'networks' quota thing when nova-net is removed? | 14:12 |
stephenfin | It seems it's not enabled by default atm anyway | 14:12 |
efried | sean-k-mooney: do you understand the SEV bug well enough to phrase a docs & reno warning saying it's broke? In case the fix doesn't make Train? | 14:13 |
*** jawad_axd has quit IRC | 14:14 | |
*** lpetrut has quit IRC | 14:16 | |
stephenfin | mriedem++ lyarwood++ thanks for getting those novaclient fixes in so quickly | 14:16 |
mriedem | np | 14:16 |
stephenfin | efried: I'll take a lash at it now | 14:17 |
efried | thanks stephenfin | 14:17 |
*** ricolin has joined #openstack-nova | 14:17 | |
*** mkrai has joined #openstack-nova | 14:22 | |
*** mkrai_ has joined #openstack-nova | 14:22 | |
sean-k-mooney | efried: if you mean the virto/dma issue yes i can proably write something up | 14:23 |
sean-k-mooney | i dont understand all the lowlevel details but i think i understand enough for a reno listing it as known issues | 14:24 |
sean-k-mooney | if stephenfin give it a go ill be happy to review too | 14:25 |
sean-k-mooney | the metting is in #openstack-meeting right | 14:25 |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: docs: Highlight the current broken state of SEV https://review.opendev.org/686414 | 14:26 |
stephenfin | sean-k-mooney: yeah, #openstack-meeting | 14:27 |
stephenfin | and that's the reno ^^ I don't know if I need more details or if it's more nuanced than that (are there only certain conditions where virtio-scsi will be present, for example)? | 14:27 |
*** mkrai_ has quit IRC | 14:28 | |
*** mkrai has quit IRC | 14:28 | |
sean-k-mooney | yes | 14:28 |
sean-k-mooney | you have to opt in to it | 14:28 |
sean-k-mooney | ill review and add details as needed | 14:28 |
sean-k-mooney | then you can translate form sean-speak to english | 14:28 |
mriedem | stephenfin: comments inline | 14:30 |
*** ociuhandu has joined #openstack-nova | 14:31 | |
*** ociuhandu has quit IRC | 14:33 | |
*** tbachman has quit IRC | 14:39 | |
*** yan0s has quit IRC | 14:43 | |
*** mlavalle has joined #openstack-nova | 14:44 | |
*** TxGirlGeek has joined #openstack-nova | 14:45 | |
*** luksky has joined #openstack-nova | 14:45 | |
*** ttsiouts has quit IRC | 14:51 | |
*** ttsiouts has joined #openstack-nova | 14:51 | |
*** ttsiouts has quit IRC | 14:53 | |
*** ociuhandu has joined #openstack-nova | 14:53 | |
*** ttsiouts has joined #openstack-nova | 14:53 | |
kashyap | efried: Have not decided anything yet here: https://review.opendev.org/#/c/684375/ (on that 'preferred' thing). Will respond on the change | 14:57 |
*** ociuhandu has quit IRC | 14:57 | |
*** yan0s has joined #openstack-nova | 14:58 | |
efried | ack | 14:58 |
*** cdent has joined #openstack-nova | 14:59 | |
*** tetsuro has joined #openstack-nova | 15:00 | |
efried | tetsuro: o/ are you an hour off? :P | 15:00 |
dansmith | efried: you should approve my spec so you can include the sponsor revision in your template patch :) https://review.opendev.org/#/c/686232/ | 15:00 |
*** takashin has left #openstack-nova | 15:00 | |
efried | dansmith: you should add the core liaison section so I don't have to :) | 15:01 |
dansmith | efried: before it's in the template? | 15:01 |
efried | sure, there's nothing preventing additional untemplated sections afaik | 15:01 |
cdent | efried, mriedem : we got rid of healing of any allocations for healthy instance in nova-compute, yes? So if a nova-compute comes up and can't find a resource provider for itself, it will create one and its inventory but that's it. To fix things 'heal allocations' in nova-manage is the way to go. | 15:01 |
efried | dansmith: I'm only half serious, will review | 15:02 |
dansmith | efried: not sure I could get behind that heresy | 15:02 |
sean-k-mooney | while we are talking about specs ill jsut leave this one here https://review.opendev.org/#/c/683174/ | 15:02 |
efried | cdent: I don't remember, would have to go look | 15:02 |
sean-k-mooney | efried: is there a patch i should rebase it on? | 15:03 |
cdent | efried: if it's gone, I'm considering ways of putting it back... | 15:03 |
sean-k-mooney | or just wait for the template change to merge | 15:03 |
dansmith | efried: well, if you find something to -1 over I'll add it in there | 15:03 |
efried | sean-k-mooney: https://review.opendev.org/#/c/685857/ | 15:03 |
*** jmlowe has quit IRC | 15:03 | |
efried | dansmith: ack. May be a little bit, though, I'm kinda backed up. | 15:03 |
sean-k-mooney | efried: thanks | 15:03 |
*** mlavalle has quit IRC | 15:03 | |
efried | (insert metamucil joke) | 15:03 |
dansmith | my spec is very fiber-rich, fwiw | 15:04 |
*** tetsuro has quit IRC | 15:04 | |
openstackgerrit | Merged openstack/python-novaclient stable/rocky: Stop silently ignoring invalid 'nova boot --hint' options https://review.opendev.org/685983 | 15:04 |
efried | sean-k-mooney: hold on a tick, I need to make an update to that. | 15:04 |
dansmith | melwitt: you probably would also be interested in approving my patch: https://review.opendev.org/#/c/686232/ if you're around :) | 15:04 |
*** mlavalle has joined #openstack-nova | 15:05 | |
*** _mlavalle_1 has joined #openstack-nova | 15:07 | |
sean-k-mooney | efried: sure im on another meeting so im not going to update it until after | 15:07 |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Add 'Core Liaison' section to spec template https://review.opendev.org/685857 | 15:09 |
efried | mriedem, sean-k-mooney: done ^ | 15:09 |
*** mlavalle has quit IRC | 15:09 | |
*** maciejjozefczyk has quit IRC | 15:09 | |
efried | dansmith: it would be neat if you would volunteer to sponsor https://review.opendev.org/#/c/685857/3/specs/ussuri/approved/provider-config-file.rst@319 | 15:12 |
efried | Since it was, like, your idea | 15:12 |
efried | (I know, I know. But still.) | 15:12 |
dansmith | efried: uh, wut | 15:15 |
dansmith | oh you mean I said something in a PTG a year ago? | 15:15 |
efried | yes | 15:15 |
efried | you can't un-say it | 15:15 |
mriedem | cdent: correct | 15:15 |
efried | it was more like six months ago | 15:15 |
efried | statute of limitations | 15:16 |
* cdent bows to mriedem | 15:16 | |
dansmith | sure, but just because I think that's the way it should be done if we're going to do it, doesn't mean I think we should or that I want to put my neck out there for it, right? | 15:16 |
dansmith | I guess it depends on whether we tie the sponsorship thing purely to "help the contributor with the process" or "I plan to review this myself" | 15:17 |
efried | yeah, good point; I would definitely like you to be involved in the reviews; I'm mentoring dustinc either way. | 15:18 |
dansmith | I'll look it over and see what I think, but I kinda feel like I want to know what the ratelimiting number is going to be before I decide what I'm going to throw my support behind | 15:18 |
efried | (and reviewing the code either way) | 15:18 |
*** xek has quit IRC | 15:18 | |
*** BjoernT has quit IRC | 15:18 | |
*** yan0s has quit IRC | 15:18 | |
efried | dansmith: fair, though for simplicity, it may help to keep those things mentally separate. You can sponsor a thing, but it could still fall off the bottom at spec freeze time. | 15:18 |
dansmith | efried: not at spec freeze time, but at the "what are the top 25 things" point right? | 15:19 |
sean-k-mooney | that i would expect to be around ptg time | 15:19 |
sean-k-mooney | or just after ptg but before spec freeze | 15:20 |
dansmith | neither of us are going to be at ptg, so... | 15:20 |
mriedem | efried: comments on https://review.opendev.org/#/c/685857/ | 15:20 |
efried | dansmith: yes, I was thinking spec freeze time would be when we do the cut | 15:20 |
*** ivve has joined #openstack-nova | 15:20 | |
efried | but tbd | 15:20 |
dansmith | efried: wait, what? | 15:20 |
*** BjoernT has joined #openstack-nova | 15:20 | |
dansmith | efried: so we're going to put a bunch of specs in and then draw some line and what, remove the ones that aren't above the line? | 15:21 |
dansmith | maybe we need a different directory for almost-approved ? :) | 15:21 |
*** mkrai has joined #openstack-nova | 15:21 | |
*** mkrai_ has joined #openstack-nova | 15:21 | |
dansmith | btw, | 15:21 |
efried | yeah, something like that; if they're still unapproved we leave them unapproved (abandon, propose to backlog, whatever) and if they're already approved in the specs repo, we pull them out (and shunt them to backlog or whatever) | 15:21 |
dansmith | we should put them not in the approved directory then, IMHO | 15:22 |
dansmith | and btw, | 15:22 |
efried | this is probably why "direction" and "definition" are different fields in lp | 15:22 |
dansmith | I'm not trying to be too demanding, I just think we need to figure out what this process is if we're going to do it, | 15:22 |
mriedem | specs/ussuri/foreplay/ | 15:22 |
dansmith | because if I got my spec in the approved directory and then it gets ripped out later I'm going to be more confused than any of your bullets in your commit message :) | 15:22 |
efried | approving "definition" means "if we're going to do this, this is how we're going to do it"; approving "direction" means "we're going to do it, now" | 15:22 |
mriedem | i think i've been out-processed for once | 15:23 |
mriedem | gold star | 15:23 |
dansmith | okay so we're going to gate the real approval in launchpad? | 15:23 |
dansmith | and any code that makes it in before the spec freeze is golden, and then we make the 25 cut at spec freeze time of things that aren't done? | 15:24 |
efried | dansmith: I agree. Ideally I would like to have left all specs and bps unapproved until cut time, and the only merge the ones above the line. But since we've already merged some, that's messy. | 15:24 |
dansmith | efried: well, unmerge them if you want | 15:24 |
*** gyee has joined #openstack-nova | 15:24 | |
dansmith | but yes, this is sounding pretty messy one way or the other | 15:24 |
*** tbachman has joined #openstack-nova | 15:24 | |
efried | yeah, thought about that too. stephenfin has code proposed for nova-net removal; we could merge some and then if that bp doesn't make the cut... in that case probably nbd to have partially done. | 15:25 |
stephenfin | in nova-net case, we've removes parts of it for a few cycles now | 15:26 |
efried | mriedem: Sigh, yeah, I continue trying to figure out how to make it as process-lite as possible. | 15:26 |
stephenfin | removing things like the os-fping API in past releases | 15:26 |
stephenfin | that doesn't apply to everything though, of course | 15:26 |
dansmith | efried: I guess my point is, this is not going to be better for visibility to the contributors if it seems like we're figuring out the rules as we go, and things drag on as late as spec freeze | 15:27 |
efried | dansmith: but yes, quite seriously, if we can get some kind of consensus that we're going to do this thing (even if the actual number is still open for negotiation), I could go unapprove everything. | 15:27 |
dansmith | efried: so being upfront with them is good, but let's not have that backfire | 15:27 |
dansmith | efried: okay, so if we do that, can I still land code for my spec that has not been approved? normally we would try to avoid that.. landing code until the design is accepted | 15:28 |
dansmith | efried: or do you want some sort of half-approval for the design but not the schedule or something? | 15:28 |
efried | good questions, Daniel-san | 15:29 |
efried | so | 15:29 |
dansmith | not trying to be a dick, just thinking through this for my own spec | 15:29 |
efried | totally, much appreciated. | 15:30 |
sean-k-mooney | if the feature merges before we do the cut maybe we jsut ingore it for quota | 15:30 |
mriedem | spec freeze is feb 13 so yeah... | 15:30 |
dansmith | sean-k-mooney: that's not the only question | 15:30 |
mriedem | that's a long time to be figuring things out | 15:30 |
dansmith | right | 15:30 |
sean-k-mooney | mriedem: ah cool so its m2 not m1 | 15:30 |
efried | even for approved blueprints and specs, we have a kind of all-or-nothing criterion we apply, where if it's important, we block the whole series until it's done. Otherwise (things like mox/nova-net/consoleauth removal etc) we allow partial as we go along. | 15:30 |
efried | so | 15:31 |
mriedem | so.. if cross-cell resize is unapproved, does that mean none of it can be approved code-wise until after spec freeze? | 15:31 |
dansmith | mriedem: that can't work, of course | 15:31 |
mriedem | cross-cell resize is not totally blocked, | 15:31 |
efried | we can do "definition approved" but "direction pending" until cut date, and things that can go partial can be merged during that time. | 15:31 |
mriedem | the switch is flipped at the n-1 patch in the series | 15:31 |
efried | and if we decide to cut that one, we just stop merging those | 15:31 |
sean-k-mooney | efried: would that not force most code to merge between m2 and m3 | 15:32 |
efried | that way work can continue while we're in planning limbo. | 15:32 |
sean-k-mooney | which is the opisite of what you want | 15:32 |
dansmith | efried: so we land the spec in approved, but the direction field in LP is the "are you in the critical quota" indication? | 15:32 |
efried | that would work, yah? | 15:32 |
dansmith | it's quite a departure from our process where most people totally ignore launchpad, so we just need to document it and raise the alarms so people know | 15:33 |
efried | ++ | 15:34 |
mriedem | what would storyboard do... | 15:34 |
* mriedem shows himself out | 15:34 | |
dansmith | heh | 15:34 |
dansmith | mriedem: take storyboard with you | 15:34 |
* cdent gives mriedem a cookie | 15:34 | |
dansmith | efried: so, the spec still gets a core sponsor field in this case? because launchpad has lots of other fields we could use instead | 15:35 |
dansmith | efried: and that might help decouple the "am I sponsoring this spec for review or...?" question | 15:35 |
*** udesale has quit IRC | 15:35 | |
efried | dansmith: Yes, I would like core sponsor in the spec to stay, because it's more indelible than lp | 15:35 |
*** udesale has joined #openstack-nova | 15:35 | |
efried | also I see lp as more of an administrative tool and the spec as more of a technical thing | 15:36 |
efried | i.e. devs should be able to ignore lp for the most part | 15:36 |
dansmith | okay, so then I need to consider whether I'm going to sponsor a thing now when it lands, in anticipation that it may be chosen for the top 25 later and I'll be on the hook to review it in that case? | 15:36 |
efried | yes | 15:36 |
*** tesseract has quit IRC | 15:36 | |
*** ttsiouts has quit IRC | 15:37 | |
dansmith | okay so I will still be conservative with what I'm willing to sponsor in spec reviews | 15:37 |
efried | and btw, that could inform how you vote for what gets cut | 15:37 |
*** ttsiouts has joined #openstack-nova | 15:37 | |
efried | dansmith: that's a legit approach. It ought to end up limiting the number of things on the table at cut time, which is productive in itself. | 15:38 |
*** ivve has quit IRC | 15:38 | |
mriedem | are we still confusing sponsor with on the hook to review? | 15:39 |
dansmith | aight, so artom you need to get your tests landed so you can get your spec up so I can shoot my wad on it | 15:39 |
mriedem | i keep getting confused if those are meant to be the same | 15:39 |
efried | mriedem: not confusing. That's one of the stated purposes of sponsor | 15:39 |
*** mkrai has quit IRC | 15:39 | |
mriedem | then...why don't we have sponsors for core-proposed specs? | 15:39 |
artom | dansmith, what your what on my what now? | 15:39 |
mriedem | i.e. i can't review and +2 my own changes | 15:39 |
dansmith | efried: don't say it's not confusing because it has confused at least two of us already | 15:39 |
*** mkrai__ has joined #openstack-nova | 15:39 | |
mriedem | there are really 2 things: | 15:40 |
artom | dansmith, you mean land the NUMA LM func tests so that I can propose the SRIOV LM Claims spec? | 15:40 |
dansmith | artom: spec for sriov LM claims | 15:40 |
mriedem | 1. official hand holder | 15:40 |
dansmith | artom: cha | 15:40 |
mriedem | 2. designated reviewer | 15:40 |
artom | dansmith, ok, I guess that answers my question of whether we need a spec for it :) | 15:40 |
mriedem | sponsor is munging both of those concepts it seems | 15:40 |
dansmith | artom: I was going to say in the meeting I think it's worthwhile, but this process also tells me that you need a spec in order for me to document that I want to spend my time reviewing it | 15:40 |
mriedem | and #2 doesn't jive with "i'll sponsor my own spec thanks" | 15:40 |
artom | dansmith, oh i c | 15:41 |
dansmith | mriedem: Designated Reviewer is a new series on ABC this fall starring Keifer Sutherland | 15:41 |
mriedem | as long as it's not cop drama on cbs | 15:42 |
mriedem | NDISLKD | 15:42 |
*** macz has joined #openstack-nova | 15:42 | |
artom | CSI: Gerrit | 15:42 |
efried | mriedem: There's nothing stopping a core from having a separate sponsor. I just didn't want to make it a hard requirement that owner != sponsor. Because cores (and experienced nova devs) know how to go ask for reviews, so they don't need it written down. | 15:42 |
*** ttsiouts has quit IRC | 15:42 | |
efried | mriedem: I agree it would be nice to have someone on the hook committed to reviewing your thing. | 15:43 |
mriedem | so how is sean-k-mooney a sponsor on his own spec in your liaison patch? | 15:43 |
mriedem | i guess for the same reason dan is on his? | 15:43 |
mriedem | i'm still confused | 15:43 |
mriedem | but whatever | 15:43 |
mriedem | it's nearly 11am and i haven't done anything useful | 15:43 |
efried | artom suggested that experienced devs are culturally indoctrinated enough to know how to go ask for reviews. | 15:43 |
efried | I updated the template language accordingly | 15:44 |
dansmith | efried: so then sponsor is not the designated reviewer but the designated "tell them to ask for reviews" person? | 15:44 |
mriedem | i'm hearing it's .... both? | 15:44 |
efried | "help me get this reviewed" | 15:44 |
mriedem | but only on thursdays | 15:44 |
efried | Also noting that reviews from experienced devs are valuable even if they aren't able to approve | 15:45 |
mriedem | examples would be good for thinking through this, | 15:45 |
mriedem | so on dan's spec, if i am listed as an official sponsor, it's not because i need to hold dan's hand, it's because i'm signing up to be an official reviewer feet to the fire person | 15:46 |
mriedem | and he has all rights to harass me in irc if i do'nt do so | 15:46 |
efried | yes | 15:46 |
mriedem | on the other hand, i could approve some non-core newb contributor but not sponsor them and absolve myself of all review responsibility | 15:46 |
mriedem | and thus being quite a dick | 15:47 |
efried | sure, I'm not trying to create a process to prevent dickishness. | 15:47 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add reserved schema migrations for Ussuri https://review.opendev.org/686411 | 15:47 |
mriedem | in reality i just wouldn't approve the spec | 15:47 |
mriedem | if i don't intend to review it | 15:47 |
dansmith | that's what I'm hearing, | 15:48 |
efried | We need more than one reviewer (hopefully more than two, but I'm a realist) to approve code anyway. | 15:48 |
dansmith | and I think it's important to make sure all the cores get that message | 15:48 |
efried | If we had some way of making that message clear and making it stick, I would be all over it. | 15:49 |
mriedem | it probably needs to at least be documented in the specs review for code review process | 15:49 |
mriedem | *specs repo | 15:49 |
mriedem | https://specs.openstack.org/openstack/nova-specs/readme.html#specification-review-policies | 15:50 |
mriedem | i have voted on the liaison patch forewith | 15:52 |
mriedem | forthwith? | 15:52 |
mriedem | yes | 15:52 |
*** luksky has quit IRC | 15:52 | |
efried | thanks | 15:55 |
mriedem | btw i know this isn't fun, | 15:57 |
mriedem | welcome to process land | 15:57 |
mriedem | and my world for 2 years | 15:57 |
efried | thanks | 15:57 |
mriedem | yo'ure also very handsome | 15:57 |
* mriedem was going for the thanks bot trifecta | 15:58 | |
gmann | efried: i have re-proposed the policy spec for ussuri - https://review.opendev.org/#/c/686058/ | 15:58 |
*** TxGirlGeek has quit IRC | 16:00 | |
*** TxGirlGeek has joined #openstack-nova | 16:01 | |
efried | mriedem: is that a thing? Three thank-yous and the bot automatically picks it up? | 16:02 |
efried | I'll have to be more careful. | 16:02 |
efried | gmann: ack | 16:02 |
mriedem | efried: ha, no | 16:02 |
mriedem | not what i meant | 16:02 |
efried | gmann: stay tuned for an update on how we're going to be deciding on approvals (once we figure it out ourselves...) | 16:03 |
gmann | efried: you mean the on ML thread ? but this is re-proposal of already approved spec | 16:06 |
efried | gmann: yup, that's understood. We're leaning towards making even those conform to the same criteria. | 16:06 |
*** damien_r has quit IRC | 16:07 | |
gmann | humm | 16:07 |
efried | gmann: mriedem makes a good point about needing to update the nova-specs readme accordingly, because previously-reviewed specs will need more than just a random single-core +2 now. | 16:08 |
gmann | I thought re-approved things are fast approved one and new one goes into that criteria | 16:08 |
efried | gmann: not an unreasonable assumption. We're still working out the details. | 16:08 |
dansmith | gmann: that's being changed | 16:09 |
dansmith | well, potentially | 16:09 |
dansmith | efried: fwiw, I think the re-approval of specs has always been flawed because we just kick things down the road instead of requiring them to muster enough support to be approved again | 16:10 |
cdent | if a pre-approved spec didn't get done in the previous cycle, one would think that it deserves extra inspection to see if it is maybe a lost cause | 16:10 |
cdent | yeah, what dansmith said | 16:10 |
dansmith | yup | 16:10 |
efried | ++ | 16:10 |
efried | requiring the sponsor to +2 might be enough | 16:11 |
efried | or we could just completely do away with official special treatment, understanding that previously-approved specs will probably require less technical scrutiny just naturally. | 16:11 |
mriedem | dansmith: i hope i answered your question in https://review.opendev.org/#/c/686047/ and the one after it | 16:17 |
*** cdent has quit IRC | 16:18 | |
dansmith | mriedem: not really, but doesn't matter | 16:23 |
*** ociuhandu has joined #openstack-nova | 16:24 | |
*** SonPham has joined #openstack-nova | 16:24 | |
SonPham | hi | 16:24 |
SonPham | any way to create live-snapshot + keep vms state ( process) ? | 16:25 |
*** rpittau is now known as rpittau|afk | 16:27 | |
*** udesale has quit IRC | 16:28 | |
*** jmlowe has joined #openstack-nova | 16:29 | |
gmann | ok, i will wait for the new process or let me know if spec sponsor thing is final so that i can add the same in policy spec. | 16:29 |
*** ociuhandu has quit IRC | 16:30 | |
*** ccamacho has quit IRC | 16:31 | |
mriedem | would be nice if someone can check my assertions here http://lists.openstack.org/pipermail/openstack-discuss/2019-October/009937.html | 16:37 |
mriedem | i'm writing a bug | 16:37 |
*** maciejjozefczyk has joined #openstack-nova | 16:41 | |
mriedem | mgoddard: https://bugs.launchpad.net/nova/+bug/1846527 if that makes sense to you | 16:42 |
openstack | Launchpad bug 1846527 in OpenStack Compute (nova) "online_data_migrations docs don't mention using --config-file to run the migrations per cell db" [Undecided,New] | 16:42 |
*** luksky has joined #openstack-nova | 16:42 | |
mgoddard | mriedem: the --config-file option is useful, but the upgrade doc doesn't say ODM needs to be run multiple times at all | 16:43 |
mriedem | multiple times meaning once per cell db right? | 16:44 |
mgoddard | mriedem: would be nice if it just clearly said "run at least once with an API DB connection, and for each cell (including cell0?)" | 16:44 |
mgoddard | mriedem: yeah | 16:44 |
*** david-lyle has quit IRC | 16:44 | |
mriedem | right | 16:44 |
*** david-lyle has joined #openstack-nova | 16:45 | |
mgoddard | --config-file option makes that easier for some | 16:45 |
*** david-lyle has quit IRC | 16:45 | |
*** igordc has joined #openstack-nova | 16:46 | |
SonPham | hi If I want to suggest a new feature? What do I do after writing the blueprint? | 16:46 |
*** dklyle has joined #openstack-nova | 16:46 | |
mriedem | an --all-cells would make it uber easy for deployment tooling | 16:47 |
mriedem | *option | 16:47 |
mgoddard | mriedem: +1 | 16:47 |
mriedem | SonPham: https://docs.openstack.org/nova/latest/contributor/blueprints.html | 16:47 |
mgoddard | mriedem: is it possible to run ODM for a cell DB before other cells have been upgraded? | 16:48 |
mriedem | possible? sure | 16:49 |
mgoddard | just wondering about the upgrade one cell at a time scenario, should I include the data migrations as part of that cell's upgrade, or all together at the end? | 16:49 |
mgoddard | advisable? | 16:49 |
mriedem | i'm not sure | 16:49 |
mriedem | dansmith: ^? | 16:49 |
mriedem | i would think it's ok to do it per cell upgrade | 16:50 |
dansmith | mriedem: mgoddard at the end | 16:50 |
mgoddard | dansmith: ack, thanks | 16:50 |
dansmith | mriedem: do you mean target the cell and do data migrations just within that cell? | 16:50 |
mriedem | i think that's the question yeah | 16:50 |
dansmith | I mean, I guess that's okay, but since they don't need to be run until later, I would just do them later I guess, | 16:51 |
dansmith | and if the api is all upgraded first then those migrations would be fine | 16:51 |
dansmith | so I guess either way, but I'd just do it later personally | 16:51 |
dansmith | mgoddard: ^ | 16:51 |
mriedem | mayhap we should be capturing some of this in the faqs https://docs.openstack.org/nova/latest/user/cells.html#faqs | 16:51 |
mriedem | not it | 16:52 |
*** maciejjozefczyk has quit IRC | 16:53 | |
*** derekh has quit IRC | 16:55 | |
efried | Does takashin usually propose the move-implemented-specs thing? | 16:58 |
efried | we're probably ready for that now | 16:58 |
mriedem | idk, just do it | 17:01 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Use scatter/gather in HostAPI.compute_node_get https://review.opendev.org/686442 | 17:01 |
mriedem | takashi usually does the 'prep for the next release' thing | 17:01 |
efried | fiber mriedem. fiber. | 17:01 |
mriedem | delegate to someone else to do it | 17:01 |
mriedem | that's not me | 17:01 |
mriedem | dude, you want to talk about fiber. i've been eating raisin bran for breakfast and leftover chili for lunch most of this week. | 17:02 |
efried | ye gods | 17:02 |
mriedem | i only put together the reason for the side effects last night | 17:02 |
sean-k-mooney | lol isnit awsome that everything we type is archive for ever :) | 17:05 |
dansmith | artom: by "double download niggle" you mean "what happens if an image is re-cached" and/or "what happens if two requests come in for the same image quickly" right? | 17:06 |
*** mkrai__ has quit IRC | 17:06 | |
*** mkrai_ has quit IRC | 17:06 | |
*** mkrai has joined #openstack-nova | 17:06 | |
*** mkrai_ has joined #openstack-nova | 17:06 | |
sean-k-mooney | dansmith: i assume we have some kind of lock in the image cache to prevent that already right? | 17:06 |
dansmith | sean-k-mooney: we do, which is what I was going to say when he replied | 17:07 |
sean-k-mooney | cool ya because if we didnt it would be an issue for booting two vms on the same host concurrenly | 17:07 |
dansmith | sean-k-mooney: which is what I said in the review when we were discussing this yesterday yes :) | 17:08 |
sean-k-mooney | i still have that open to review. i got as far as the commit message then got distracted this morining | 17:08 |
sean-k-mooney | form what i skimed it makes sense to me so far | 17:09 |
SonPham | after i write the blueprint , i must upload new spec to https://opendev.org/openstack/nova-specs/src/branch/master/specs ? | 17:10 |
* mnaser barges in | 17:11 | |
*** mkrai has quit IRC | 17:11 | |
*** mkrai_ has quit IRC | 17:11 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix exception translation when creating volume https://review.opendev.org/678991 | 17:11 |
mnaser | is there a point where placement will be the ultimate authority in nova for resource usage | 17:11 |
mnaser | (like, in the actual reporting too) | 17:11 |
mnaser | (i understand if no one wrote the code for it yet, but wondering if its more of a "no we wont do that) | 17:12 |
mriedem | SonPham: yes https://specs.openstack.org/openstack/nova-specs/readme.html | 17:12 |
mriedem | mnaser: i think that's the utopian goal | 17:13 |
mriedem | you can already configure nova to use placement for counting cpu and ram usage | 17:13 |
artom | dansmith, yes | 17:13 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Group IPs by network UUID, not network names https://review.opendev.org/686444 | 17:13 |
artom | dansmith, the second one, specifically | 17:14 |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add a placement audit command https://review.opendev.org/670112 | 17:14 |
mnaser | wait, really (about nova for counting cpu and ram usage) | 17:14 |
mriedem | artom: also note that the windriver krew added a semaphore on image downloads awhile back | 17:14 |
mriedem | i think by default it's unbounded but they use it to serialize at edge sites | 17:14 |
mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#compute.max_concurrent_disk_ops | 17:15 |
artom | mriedem, if that does what I think it does, then that's the piece I was missing | 17:15 |
bauzas | mriedem: gibi: dansmith: I know you folks are pretty busy those days but reviews would be appreciated for https://review.opendev.org/#/c/670112 | 17:15 |
bauzas | (placement audit command) | 17:15 |
mriedem | mnaser: https://docs.openstack.org/nova/latest/configuration/config.html#quota.count_usage_from_placement | 17:15 |
mriedem | artom: note that's relatively new, | 17:16 |
artom | Although if set to 2 or more, it doesn't strictly speaking solve the simultaneous requests for the same image problem | 17:16 |
mriedem | the image cache might already have a lock on the image id | 17:16 |
bauzas | mriedem: gibi: dansmith: it's now in a good shape with a few functests, so before I'm writing unittests, I'd appreciate comments | 17:16 |
mriedem | if only the code were freely available and online... | 17:16 |
SonPham | any way to make a snapshot keep vms state? | 17:16 |
artom | But... since booting an image had the same problem, we probably have something in place fo that | 17:16 |
artom | *for | 17:16 |
dansmith | artom: ack, then it's already handled by a lock.. I looked it up but didn't call it out in the spec because it's existing | 17:16 |
dansmith | artom: so just FYI | 17:16 |
mnaser | mriedem: oh neat, that's pretty cool | 17:17 |
artom | mriedem, aww, but it's way more fun to blindly rant and speculate | 17:17 |
artom | dansmith, yeah that's fair, thanks for taking the time to look it up | 17:17 |
mriedem | artom: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/imagebackend.py#L257 i think? | 17:18 |
artom | mriedem, looks like it, yeah | 17:19 |
artom | That imagecache code though... *shudder* | 17:20 |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add a placement audit command https://review.opendev.org/670112 | 17:20 |
mriedem | dansmith: that reminds me, one thing we'll likely want documented with using your thing is making sure a service user token is configured to avoid the user token timing out while triyng to download an image across a bunch of computes | 17:20 |
mriedem | https://docs.openstack.org/nova/latest/admin/support-compute.html#user-token-times-out-during-long-running-operations | 17:20 |
dansmith | mriedem: ack | 17:21 |
*** openstackgerrit has quit IRC | 17:21 | |
* bauzas disappears | 17:22 | |
mriedem | bauzas: easy and fast -1 from me | 17:23 |
mriedem | you're welcome | 17:23 |
* mnaser might just have no context | 17:25 | |
mnaser | but i dont think a token timing out during download might an issue | 17:25 |
mnaser | cause the request will be done with the download is done anyways | 17:25 |
mnaser | i think image upload are an issue for things like submitting properties/etc when dnoe | 17:25 |
dansmith | mnaser: we're talking about image pre-caching, where the process may take an hour | 17:26 |
dansmith | mnaser: so by the time the last compute starts doing the work, the token may have expired and it can't pull the image | 17:26 |
mnaser | oh i see, this isnt necessarily the on-vm-launch thing | 17:27 |
mriedem | lyarwood: i'm not sure i got your question correct in https://review.opendev.org/#/c/541420/ | 17:27 |
dansmith | mnaser: unrelated to vm launch entirely | 17:27 |
mnaser | okay, right :> | 17:27 |
dansmith | mnaser: is image pre-caching a thing you care about btw? I think your cloud is too general purpose to care maybe, but... ? | 17:28 |
dansmith | or you use ceph so not a thing anyway | 17:29 |
mnaser | dansmith: i think in our case most of our stuff is ceph based, and yeah, too general purpose to have images precached *but* it might be something as we are considering having VMs that are entirely local storage | 17:29 |
dansmith | okay | 17:29 |
*** gbarros has joined #openstack-nova | 17:29 | |
mnaser | so maybe having a glance property that we'd use to maintain a bunch of 'hot' images that we expect users to launch often (then precache those images in some ci job) | 17:30 |
sean-k-mooney | mnaser: with ceph we do the whole cow clone in ceph to cache the image once its added to ceph the first time but precaching could still be useful in edge deployment if they had ceph too right? | 17:31 |
*** Garyx has quit IRC | 17:31 | |
dansmith | mnaser: well, it won't be that automatic yet, but you could write a script to key it off of an image prop | 17:31 |
sean-k-mooney | it might not help vexhosts usecase but precaching with ceph chould still be useful | 17:31 |
mnaser | precache with ceph COULD solve that thing i talkeda bout a long time when multiple cells with their own ceph cluster each | 17:32 |
dansmith | sean-k-mooney: ceph at the edge doesn't work very well right now | 17:32 |
sean-k-mooney | dansmith: due to the 3 node requiremnet? | 17:32 |
mnaser | dansmith: yep, but at least id have the tool available in that case yeah | 17:32 |
dansmith | sean-k-mooney: because nova will do the pathologically terrible thing with ceph if it's not the same one as glance uses | 17:32 |
dansmith | mnaser: yep | 17:32 |
sean-k-mooney | download the image from glance and uplaod ti to ceph repeatedly? | 17:33 |
stephenfin | efried: I recall seeing a comment from you about doing this kind of thing differently https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/api_sample_base.py#L133 | 17:33 |
*** ivve has joined #openstack-nova | 17:33 | |
stephenfin | I should know what that alternative way is but I'm having a senior moment. Care to remind me? | 17:34 |
stephenfin | (allows us avoid the 'fake_noop' arg) | 17:34 |
dansmith | sean-k-mooney: yes so you end up with no re-use, but silently | 17:34 |
sean-k-mooney | ya that sucks | 17:34 |
*** ricolin has quit IRC | 17:35 | |
sean-k-mooney | and wastes space on a ceph cluster that is proably already constratied | 17:35 |
*** TxGirlGeek has quit IRC | 17:35 | |
dansmith | sean-k-mooney: s'mah point. This is what I mentioned at the last PTG which I will fix when glance gets the backend management APIs | 17:35 |
sean-k-mooney | and bandwith over a potentially slow link. isnt the multipl glace locaiton feature ment to help with that | 17:35 |
dansmith | sean-k-mooney: it is, but nova only has one it can handle, so if it's not already stored there, it will silently do the bad thing | 17:36 |
sean-k-mooney | ya i recall you talking about this | 17:36 |
sean-k-mooney | do you intend to adress that as part of the precaching spec or declare it out of scope and adress that seperatly | 17:37 |
sean-k-mooney | i woudl think seperatly | 17:37 |
dansmith | completely unrelated | 17:37 |
sean-k-mooney | well they both adress image distubution but ya that is what i was hoping you would say | 17:38 |
sean-k-mooney | im just preempting the possiblity of scope creap | 17:38 |
*** Garyx has joined #openstack-nova | 17:39 | |
*** noonedeadpunk has joined #openstack-nova | 17:49 | |
*** SonPham has quit IRC | 17:52 | |
*** bbowen_ has joined #openstack-nova | 17:54 | |
sean-k-mooney | has anyone ever tried to do an FFU across more then 3 release? | 17:55 |
sean-k-mooney | e.g. form say newton to train | 17:55 |
sean-k-mooney | i feel like that would be kind of a pain | 17:56 |
*** bbowen has quit IRC | 17:57 | |
efried | stephenfin: I was probably just griping about stub_out being a thin wrapper around | 17:58 |
efried | self.useFixture(fixtures.MockPatch(...)) | 17:58 |
efried | you could replace it everywhere | 17:58 |
mriedem | stephenfin: are you thinking of efried always saying to use new= on a mock to avoid the method signature change? | 17:58 |
efried | in many stub_out cases where the replacement is actually a no-op, you can MockPatch('just.the.thing') and you get a default mock, i.e. you can do away with the replacement stub function | 17:59 |
efried | in this case if the noop's return is actually important, you would do like | 18:00 |
efried | self.useFixture(fixtures.MockPatch('path.to.thing', return_value=('',''))) | 18:00 |
stephenfin | hmm, that does rely on us not doing a truthiness check somewhere though | 18:00 |
stephenfin | or using return_value | 18:00 |
stephenfin | since bool(mock.Mock()) == True | 18:00 |
efried | if you use return_value it would be functionally identical to what's already there. | 18:01 |
sean-k-mooney | it depens on what you are testing | 18:01 |
sean-k-mooney | for what its woth i prefer using mock.patch and avoiding the stub_out stuff whenever possible | 18:02 |
efried | stub_out is a holdover from mox transition; at this point it can and should diaf | 18:04 |
*** spsurya has quit IRC | 18:07 | |
stephenfin | mriedem: Could I ask you to look at https://review.opendev.org/#/c/684326/ and https://review.opendev.org/#/c/685937/ again at some point so I can keep that train moving | 18:08 |
stephenfin | I've another batch of those ready to go, including a lot of API removals/deprecations | 18:08 |
mriedem | stephenfin: just commented on https://review.opendev.org/#/c/684326/ | 18:08 |
stephenfin | niiiiice | 18:08 |
mriedem | "I can't say I understand all of these but it looks like for at least some of them, which I think can extend to all of them, that there is likely something in the API samples response that is different when using neutron over nova-network and as such to change those tests to use neutron we also have to regenerate the samples which should be done an individual basis rather than en masse." | 18:08 |
mriedem | if that's correct, then good | 18:08 |
stephenfin | that is correct | 18:09 |
mriedem | cool | 18:10 |
sean-k-mooney | an example of that is the way security groups are reported when using nova-net vs neturon right | 18:10 |
*** ralonsoh has quit IRC | 18:10 | |
sean-k-mooney | its in the server show with nova net but not when using neturon | 18:10 |
mriedem | sean-k-mooney: | 18:11 |
mriedem | remember how you said you were too distracted to review dansmith's spec twice now? | 18:11 |
mriedem | put. the. irc. down. | 18:11 |
dansmith | lol | 18:11 |
sean-k-mooney | yes im on line 60 ish | 18:11 |
mriedem | i'm sure i'm not the only one that does this, but i've got irc in a separate monitor and when i need to focus on something i minimize it on that monitor, otherwise the scrolling chatter draws me in like a deadly siren | 18:12 |
dansmith | mriedem: any thoughts on where the parallelism conf knob should be? It'll be honored in conductor, but putting it in conf/conductor seems kinda weird for operators | 18:12 |
stephenfin | mriedem: Replied to the questions on that, if you were curious | 18:13 |
mriedem | dansmith: i'm fine with it being in conductor. if you think we might make it generally available elsewhere later then i guess DEFAULT? | 18:13 |
stephenfin | sean-k-mooney: Sort of. They _should_ be reported but weren't because the NeutronFixture was incomplete https://review.opendev.org/#/c/685927/2 | 18:13 |
stephenfin | fixed in that change | 18:13 |
dansmith | mriedem: given that the imagecache things are all in DEFAULT still, I kinda think that's the right call | 18:14 |
sean-k-mooney | ah ok | 18:14 |
* stephenfin wonders how long before NeutronFixture becomes an effective neutron simulator | 18:14 | |
stephenfin | and it's only a small step from there to Skynet | 18:14 |
mriedem | dansmith: or, | 18:15 |
mriedem | we actually group the imagecache options properly and do it there | 18:15 |
mriedem | i'm sure stephenfin would be up for such toil | 18:15 |
mriedem | having said that i only see 2 image_cache_* options today | 18:17 |
mriedem | oh and remove_unused_base_images | 18:17 |
mriedem | oh and | 18:18 |
mriedem | remove_unused_original_minimum_age_seconds | 18:18 |
dansmith | guh | 18:18 |
dansmith | I almost had the easy option | 18:19 |
mriedem | well, | 18:19 |
mriedem | you could be the first to start an [imagecache] group | 18:19 |
mriedem | and we move the others over after | 18:19 |
mriedem | that's still easy | 18:19 |
dansmith | okay yeah, nice | 18:19 |
* mriedem high fives | 18:19 | |
mriedem | smells like synergy in here | 18:19 |
dansmith | smells more like cheating | 18:23 |
mriedem | stephenfin: https://review.opendev.org/#/c/684334/6 | 18:24 |
stephenfin | mriedem: Think you can hold your nose and ignore that for now? I have a patch to remove the entire thing locally | 18:25 |
stephenfin | But I can't push because I'm afraid it'll rebase everything else in that queue | 18:25 |
mriedem | reply with a link to the thing that removes it | 18:25 |
mriedem | if it's like 20 patches down the line i'll be sad | 18:25 |
stephenfin | it's not on Gerrit yet - it'll be 20 patches anyway | 18:26 |
stephenfin | lemme push to GitHub | 18:26 |
mriedem | you're going to have to rebase that series anyway aren't you? once the bottom 2 changes merged | 18:26 |
mriedem | *merge | 18:26 |
stephenfin | will I? | 18:26 |
stephenfin | I was hoping to avoid that | 18:27 |
stephenfin | mriedem: https://github.com/stephenfin/nova/commit/066e60572877dbc00c42f62ee6d02fd00c10ee4e | 18:27 |
mriedem | blech, i don't really want to wait for that, and if you have to rebase anyway (gerrit is showing the bottom two patches being diverged from later in the series)... | 18:31 |
mriedem | though i'm not sure that means you'll actually have to rebase | 18:31 |
mriedem | how about just following up with a simple patch on top of the one i'm cranky about? | 18:31 |
stephenfin | Sure, I can do that | 18:31 |
mriedem | again, m'fing synergy | 18:31 |
*** openstackgerrit has joined #openstack-nova | 18:44 | |
openstackgerrit | Merged openstack/nova stable/train: Restore console proxy deployment info to cells v2 layout doc https://review.opendev.org/686325 | 18:44 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Migrate 'test_quota_sets' functional tests https://review.opendev.org/684334 | 18:45 |
stephenfin | Hurrah, it worked | 18:45 |
stephenfin | mriedem: ^ | 18:45 |
* stephenfin goes home | 18:45 | |
*** gbarros has quit IRC | 18:48 | |
*** gbarros has joined #openstack-nova | 18:49 | |
mriedem | got it | 18:50 |
*** gbarros has quit IRC | 18:52 | |
sean-k-mooney | dansmith: mriedem: i left some question in the precache spec regarding image lifetime https://review.opendev.org/#/c/686232/5 | 18:54 |
sean-k-mooney | im +0.5 on that sepc as it is so i like that its simple. just want to ensure we dont end up with tones of cached images that are never used and on the flip side that if it take a long time to cache it on alot of host that by the time it finsihes we dont race with cleaning them up | 18:56 |
dansmith | sean-k-mooney: what line? | 18:56 |
sean-k-mooney | 158 ish | 18:57 |
sean-k-mooney | also see the comment on line 95 about the isolateHostfilter and aggreateImageProertiesIsolation filter | 18:58 |
dansmith | sean-k-mooney: I'm specifically excluding any GET reporting on this, FWIW, but I said elsewhere that the standard imagecache purge rules would apply to these images | 18:58 |
sean-k-mooney | those are used to geofence where instacne with certin image can land | 18:58 |
*** TxGirlGeek has joined #openstack-nova | 18:58 | |
dansmith | sean-k-mooney: which is why when we re-cache an image we already have, we touch it | 18:58 |
*** lpetrut has joined #openstack-nova | 18:58 | |
dansmith | sean-k-mooney: right, but this is admin-controlled, by aggregate, so they control where the images go, and may want to pre-cache an image somewhere before they allow the scheduler to place it there | 18:59 |
dansmith | s/it/an instance/ | 18:59 |
*** lpetrut has quit IRC | 18:59 | |
openstackgerrit | Merged openstack/nova master: nova-net: Use nova-net explicitly in functional tests https://review.opendev.org/684326 | 18:59 |
sean-k-mooney | sure im just wondering if it could be a foot gun that we shoudl docuemtn | 19:00 |
*** lpetrut has joined #openstack-nova | 19:00 | |
sean-k-mooney | e.g. call out tha twe wont run the isolation filters with teh aggreate you provided | 19:00 |
sean-k-mooney | so as an operator its your responcablity to ensure it does not violate any polices | 19:00 |
dansmith | sure, the docs will say lots of "this is very basic" things | 19:01 |
sean-k-mooney | ya ok honestly those were my two main concernes | 19:02 |
mriedem | what's the worst that would happen in that case? you push an image to a host that doesn't get used b/c the scheduler is configured to exclude that image from that host, so the image just ages out and is removed | 19:02 |
dansmith | right | 19:02 |
dansmith | which you may want, and if you don't, it gets purged later | 19:02 |
*** itlinux has quit IRC | 19:02 | |
sean-k-mooney | mriedem: you push an image across a contry bountry and violate export contol | 19:02 |
dansmith | sean-k-mooney: ...which you asked for explicitly :) | 19:03 |
sean-k-mooney | as an admin you should know what edge sites your host aggretes map too | 19:03 |
sean-k-mooney | but that filter was added to prevent that case form happening | 19:03 |
sean-k-mooney | dansmith: yes its user error | 19:03 |
mriedem | a future improvement could be to validate the images against the host aggregate using the configured filters, something like that - the old scheduler as library idea | 19:03 |
sean-k-mooney | ya | 19:03 |
mriedem | hence the list o dicts so you could single out a particularly hairy image to validate | 19:04 |
sean-k-mooney | i was also sugestiong a follow on could be to run the weighs | 19:04 |
mriedem | and the others are just like ubuntu images and it doesn't matter | 19:04 |
dansmith | sean-k-mooney: *admin error | 19:04 |
mriedem | spray em while you got em | 19:04 |
sean-k-mooney | to priortise the order the miages are pushed out | 19:04 |
*** henriqueof1 has joined #openstack-nova | 19:04 | |
dansmith | sean-k-mooney: I mentioned priorities as a future thing, in the spec | 19:04 |
sean-k-mooney | yep i saw | 19:04 |
mriedem | yeah sounds like what's proposed doesn't make building the fancy in later hard, so that's the goal | 19:05 |
sean-k-mooney | and it was what came to mind i saw mriedem ask about it being a dict then read the paragpgh where you mentioned priorties and ttls | 19:05 |
sean-k-mooney | dansmith: i do like the design you are proposing | 19:06 |
*** henriqueof has quit IRC | 19:07 | |
openstackgerrit | Eric Fried proposed openstack/os-traits master: Add method to visualize the os-traits tree https://review.opendev.org/686464 | 19:08 |
sean-k-mooney | oh i remembered what i was going to ask. do we have docuemntation for how the normal caching works | 19:09 |
sean-k-mooney | if yes i can find it myself | 19:09 |
*** gbarros has joined #openstack-nova | 19:10 | |
dansmith | sean-k-mooney: I dunno, let me know :) | 19:10 |
sean-k-mooney | if i dont find it im sure mdbooth could tell me over beer | 19:11 |
*** lbragstad has quit IRC | 19:11 | |
mriedem | no | 19:12 |
mriedem | we don't have anything for docs on image caching | 19:12 |
mriedem | i've complained about, but done nothing about, many a time | 19:12 |
mriedem | we definitely should though since it's a not very well understood area of the code, obviously | 19:13 |
mriedem | i elect mdbooth to write something up | 19:13 |
dansmith | I could maybe do some of that in the process of writing up these | 19:14 |
*** zbr|ruck is now known as zbr | 19:14 | |
sean-k-mooney | dansmith: you mentioned in the spec that libvirt,vmware and hyperv share teh same imagecache module but i also supece part of the reason we pass around partial methods in that code is because its "generic" code that has to deal with driver specific edgecases | 19:16 |
dansmith | sean-k-mooney: it's much worse than you could even imagine, trust me | 19:16 |
*** jmlowe has quit IRC | 19:17 | |
sean-k-mooney | oh i have seen it and ran away before. i mentioned in the spec it would be nice to add image caching for the lvm image backend at some point usign lvm snapshots. then i rememerbed what that code looked like | 19:17 |
dansmith | yeah, I replied to that.. I'm not sure that it's not implemented for LVM, or at least, not smartly unimplemented | 19:18 |
dansmith | but I could be wrong | 19:18 |
sean-k-mooney | im deploy with lvm at the weekend and i did not see lvm volumes beign used as cache but i did not check if there were snapshots or if the backing file was cached a different way | 19:19 |
*** bbowen__ has joined #openstack-nova | 19:19 | |
dansmith | no, it would be cached on disk as a file in the same way | 19:19 |
dansmith | and then used to write into the volume | 19:19 |
dansmith | the cache is always files on disk, regardless | 19:19 |
sean-k-mooney | ah ok | 19:20 |
sean-k-mooney | that less efficent but it makes sense | 19:20 |
dansmith | it's just naïveté in the code | 19:21 |
mriedem | gmann: re the down cell / security groups thing you mentioned before https://review.opendev.org/#/c/685927/2/nova/tests/functional/test_servers.py@1264 | 19:21 |
dansmith | and a result of nobody (that I know of) really using LVM seriously as a backend | 19:21 |
dansmith | we don't even support it, AFAIK | 19:21 |
*** bbowen_ has quit IRC | 19:21 | |
sean-k-mooney | we down suport it downstream becasue the osp iamges are not lvm based | 19:22 |
mriedem | we == rhosp right? | 19:22 |
sean-k-mooney | yes | 19:22 |
*** gbarros has quit IRC | 19:22 | |
mriedem | windriver was using lvm for a long time | 19:22 |
mriedem | then moved to ceph | 19:22 |
dansmith | sean-k-mooney: I'm pretty sure we do not | 19:22 |
sean-k-mooney | sorry yes i ment to say we do not | 19:22 |
dansmith | it doesn't really matter if the osp images are flat or not, I think we don't support it for overcloud | 19:24 |
sean-k-mooney | the lvm backed performs better the qcow2 for write intensive workloads which is why imt thinking of using it | 19:24 |
dansmith | we used to I think, but dropped it probably because lyarwood threatened to quit :) | 19:24 |
mriedem | dansmith: btw, unrelated to image caching, question for you on the prep resize patch at the bottom of the cross-cell series https://review.opendev.org/#/c/633293/ | 19:24 |
dansmith | sure | 19:24 |
mriedem | dansmith: while it's fresh in your head, earlier i had posted a diff of what it might look like to re-use the existing prep_resize | 19:24 |
*** bbowen__ has quit IRC | 19:24 | |
mriedem | it's not terrible...but i'd need to freshen that diff up to see what it looks like now after the vpmem stuff changed how normal prep_resize works | 19:25 |
dansmith | mriedem: I though we discussed that in here | 19:25 |
gmann | mriedem: yeah, i was thinking to mock the get_all or multi cell function or something in DownCellFixture and not return the down cell instances. but did not check yet. | 19:25 |
mriedem | i think we did a bit before i wrote the code to see what the diff would actually look like | 19:25 |
dansmith | mriedem: I think I said I wish we could make them more the same, but I'm probably just being too idealistic, and then the numa LM came along with a similar requirement | 19:26 |
mriedem | gmann: tl;dr you're right and we'll return security groups and proxy to neutron even for down cell responses | 19:26 |
mriedem | gmann: that was hidden in functional tests b/c of the bad fixture | 19:26 |
mriedem | dansmith: ok for prep_resize (of the 5 compute resize related methods) it's not terrible to munge support into the existing thing if we want to do that, | 19:28 |
mriedem | but it's not really tenable for the others imo | 19:28 |
dansmith | mriedem: ack, well, do whatever you think is best for all of them and I won't complain again either way | 19:29 |
mriedem | the only worry i have is eventually having something like rebuild_instance where it's double duty based on conditional and is hairy as hell | 19:29 |
gmann | mriedem: you mean only in func tests ? GET /server/detail would not return any down cell instances and so does not include the sec grp right ? | 19:29 |
dansmith | yeah, that was the outcome of our original discussion I think | 19:29 |
mriedem | gmann: incorrect | 19:29 |
mriedem | gmann: with the down cell stuff, we return a partial set of information about an instance based on the api db | 19:30 |
mriedem | https://docs.openstack.org/api-guide/compute/down_cells.html | 19:30 |
gmann | yeah which is from show method. so true for GET /servers/<server-id> | 19:30 |
mriedem | the down cell func tests were not using a fixture that returned security groups properly | 19:31 |
mriedem | stephen's patch exposes that | 19:31 |
mriedem | anyway, as i said in https://review.opendev.org/#/c/685927/2/nova/tests/functional/test_servers.py@1264 i think it's just a matter of a docs fix for down cell | 19:31 |
mriedem | tssurya: ^ | 19:31 |
*** ociuhandu has joined #openstack-nova | 19:31 | |
mriedem | gmann: fwiw it's also possible to test this stuff in devstack, here is a guide https://docs.openstack.org/nova/latest/contributor/testing/down-cell.html | 19:32 |
gmann | but Show never return sec grp so my point was inconsistent response between SHow and detail | 19:32 |
mriedem | ah yeah | 19:33 |
mriedem | fair point | 19:33 |
mriedem | well, changing that now would be a new microversion | 19:33 |
gmann | yeah, same i was thinking whether it is worth to fix or just doc update work fine. | 19:33 |
gmann | doc update works fine i think | 19:33 |
mriedem | fix it with a new microversion? i don't think it's worth it | 19:34 |
mriedem | agree | 19:34 |
mriedem | if you want to know security groups for a server in a down cell, you can get them from neutron directly | 19:34 |
gmann | true. | 19:34 |
efried | dansmith: Does the db migrationy thingy get backported? | 19:34 |
efried | ...is it for train or ussuri | 19:35 |
efried | I'm confused... | 19:35 |
mriedem | ussuri, | 19:35 |
mriedem | it's in case we backport a db migratoin to train | 19:35 |
dansmith | efried: it's for U | 19:35 |
dansmith | backporting it would defeat the purpose | 19:35 |
mriedem | rare, but it's happened | 19:35 |
efried | k, just confused by the stein one that was proposed in train and its message says stein. | 19:35 |
dansmith | proposed in train for stein backports | 19:36 |
dansmith | like this is proposed in u for train backports | 19:36 |
efried | rite. | 19:36 |
efried | thanks | 19:36 |
*** ociuhandu has quit IRC | 19:37 | |
*** lpetrut has quit IRC | 19:41 | |
mriedem | gmann: 1846559 | 19:42 |
mriedem | oops, bug 1846559 | 19:42 |
openstack | bug 1846559 in OpenStack Compute (nova) "Handling Down Cells in nova - security_groups can be in the response for GET /servers/detail" [Medium,Confirmed] https://launchpad.net/bugs/1846559 | 19:42 |
gmann | thanks | 19:42 |
sean-k-mooney | if you use nova network instead of neutron you will get the security grous too | 19:43 |
openstackgerrit | Merged openstack/nova master: nova-net: Remove explicit 'USE_NEUTRON = True' https://review.opendev.org/685937 | 19:44 |
openstackgerrit | Merged openstack/nova master: docs: Document how to revert, confirm a cold migration https://review.opendev.org/664396 | 19:44 |
openstackgerrit | Merged openstack/nova master: docs: Update resize doc https://review.opendev.org/665412 | 19:45 |
mriedem | sean-k-mooney: no you wont | 19:45 |
sean-k-mooney | there is a delta in the beahviro for server show that stephenfin found | 19:45 |
mriedem | because in a down cell case, the security groups for nova net are in the cell db, which is down, so this is at best going to have None as a value https://github.com/openstack/nova/blob/867401e575d2b27b9bc63ceda41cd85233545cd5/nova/api/openstack/compute/views/servers.py#L607 | 19:45 |
mriedem | sean-k-mooney: you mean the thing that gmann and i were just talking about for 10 minutes above? | 19:45 |
*** TxGirlGeek has quit IRC | 19:46 | |
sean-k-mooney | i need to scoll back but it was not related to down cells | 19:46 |
sean-k-mooney | aparent show will retrun the security group with nova networks | 19:46 |
sean-k-mooney | that is what stephenfin told me he found when remvoing the nova networks code | 19:47 |
mriedem | and it will with neutron too | 19:48 |
mriedem | if the instance isn't in a down cell | 19:48 |
gmann | sean-k-mooney: you mean this one - https://review.opendev.org/#/c/684335/2//COMMIT_MSG@10 | 19:48 |
gmann | that was missing in Fixture | 19:48 |
sean-k-mooney | oh no it was the neutron fixture https://review.opendev.org/#/c/685927/ | 19:49 |
gmann | yeah | 19:49 |
sean-k-mooney | ok never mind then | 19:49 |
mriedem | sean-k-mooney: and that's specifically because of the 2.69 down cell test | 19:49 |
mriedem | which is the wrinkle | 19:49 |
sean-k-mooney | ok so the fixture emulated the down cell behavior uncondtionally | 19:50 |
sean-k-mooney | ok im going to grab something to eat o/ back in a while | 19:51 |
*** gmann is now known as gmann_afk | 19:52 | |
*** jmlowe has joined #openstack-nova | 19:55 | |
*** TxGirlGeek has joined #openstack-nova | 19:59 | |
*** TxGirlGeek has quit IRC | 19:59 | |
*** _mlavalle_1 has quit IRC | 20:06 | |
*** mlavalle has joined #openstack-nova | 20:16 | |
*** pcaruana has quit IRC | 20:18 | |
*** TxGirlGeek has joined #openstack-nova | 20:25 | |
*** lbragstad has joined #openstack-nova | 20:29 | |
*** TxGirlGeek has quit IRC | 20:46 | |
*** factor has quit IRC | 20:49 | |
*** TxGirlGeek has joined #openstack-nova | 21:04 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: nova-net: Migrate 'test_availability_zone' functional tests https://review.opendev.org/684332 | 21:04 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: nova-net: Migrate 'test_floating_ip_pools' functional tests https://review.opendev.org/684333 | 21:04 |
*** slaweq has quit IRC | 21:14 | |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Add 'Core Liaison' spec process https://review.opendev.org/685857 | 21:19 |
efried | dansmith, mriedem, gmann_afk, sean-k-mooney, stephenfin: etc etc ^ | 21:19 |
mriedem | make way | 21:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: FUP to I30916d8d10d70ce25523fa4961007cedbdfe8ad7 https://review.opendev.org/676228 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: FUP to I4d181b44494f3b0b04537d5798537831c8fdf400 https://review.opendev.org/676231 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: FUP for I66d8f06f19c5c631e33208580428aa843abb38d2 https://review.opendev.org/678951 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451 | 21:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler https://review.opendev.org/669012 | 21:25 |
mriedem | gibi: stephenfin: i rebased the cross cell series ^ to move some of the FUPs that were outside the series back into the fold and toward the bottom. that might mean some things that were previously +2ed might have changed slightly but hopefully not much. | 21:27 |
*** bbowen has joined #openstack-nova | 21:30 | |
*** JamesBenson has quit IRC | 21:32 | |
*** JamesBenson has joined #openstack-nova | 21:33 | |
*** JamesBenson has quit IRC | 21:37 | |
*** dking_desktop has joined #openstack-nova | 21:44 | |
*** takashin has joined #openstack-nova | 21:47 | |
*** TxGirlGeek has quit IRC | 21:49 | |
*** rcernin has joined #openstack-nova | 22:08 | |
openstackgerrit | Merged openstack/nova master: Add reserved schema migrations for Ussuri https://review.opendev.org/686411 | 22:14 |
*** gbarros has joined #openstack-nova | 22:17 | |
*** gbarros has quit IRC | 22:20 | |
*** markvoelker has quit IRC | 22:30 | |
*** BjoernT has quit IRC | 22:31 | |
*** TxGirlGeek has joined #openstack-nova | 22:34 | |
*** gbarros has joined #openstack-nova | 22:34 | |
*** panda is now known as panda|off | 22:35 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Migrate old style volume attachments on nova-compute startup https://review.opendev.org/549130 | 22:51 |
*** henriqueof1 has quit IRC | 22:58 | |
*** tkajinam has joined #openstack-nova | 23:01 | |
*** macz has quit IRC | 23:02 | |
*** luksky has quit IRC | 23:14 | |
*** ivve has quit IRC | 23:15 | |
*** gbarros has quit IRC | 23:23 | |
*** gbarros has joined #openstack-nova | 23:25 | |
*** mriedem has quit IRC | 23:26 | |
*** mlavalle has quit IRC | 23:31 | |
*** igordc has quit IRC | 23:36 | |
*** TxGirlGeek has quit IRC | 23:49 | |
openstackgerrit | Merged openstack/nova master: nova-net: Migrate 'test_availability_zone' functional tests https://review.opendev.org/684332 | 23:51 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!