*** brinzhang has joined #openstack-nova | 00:13 | |
*** spatel has joined #openstack-nova | 00:15 | |
*** brinzhang_ has quit IRC | 00:16 | |
*** gyee has quit IRC | 00:40 | |
*** brinzhang_ has joined #openstack-nova | 00:41 | |
*** brinzhang has quit IRC | 00:45 | |
*** kaisers has quit IRC | 00:45 | |
*** tbachman has quit IRC | 00:56 | |
*** kaisers has joined #openstack-nova | 00:57 | |
*** mdbooth has quit IRC | 01:00 | |
*** mdbooth has joined #openstack-nova | 01:01 | |
*** slaweq has joined #openstack-nova | 01:11 | |
*** brinzhang has joined #openstack-nova | 01:13 | |
*** tbachman has joined #openstack-nova | 01:15 | |
*** brinzhang_ has quit IRC | 01:16 | |
*** slaweq has quit IRC | 01:16 | |
*** yaawang has quit IRC | 01:28 | |
*** yaawang has joined #openstack-nova | 01:28 | |
*** dklyle has quit IRC | 01:35 | |
*** spatel has quit IRC | 01:46 | |
*** brinzhang_ has joined #openstack-nova | 01:49 | |
*** dklyle has joined #openstack-nova | 01:50 | |
*** brinzhang has quit IRC | 01:52 | |
*** brinzhang has joined #openstack-nova | 01:57 | |
*** brinzhang_ has quit IRC | 02:00 | |
*** markvoelker has joined #openstack-nova | 02:11 | |
*** brinzhang_ has joined #openstack-nova | 02:13 | |
*** brinzhang has quit IRC | 02:16 | |
*** markvoelker has quit IRC | 02:21 | |
*** markvoelker has joined #openstack-nova | 02:22 | |
*** markvoelker has quit IRC | 02:26 | |
*** hongbin has joined #openstack-nova | 02:37 | |
*** brinzhang has joined #openstack-nova | 02:39 | |
*** brinzhang_ has quit IRC | 02:42 | |
*** slaweq has joined #openstack-nova | 03:02 | |
*** spatel has joined #openstack-nova | 03:06 | |
*** slaweq has quit IRC | 03:06 | |
*** spatel has quit IRC | 03:11 | |
*** yaawang has quit IRC | 03:13 | |
*** yaawang has joined #openstack-nova | 03:15 | |
*** yaawang has quit IRC | 03:16 | |
*** yaawang has joined #openstack-nova | 03:16 | |
*** brinzhang_ has joined #openstack-nova | 03:19 | |
*** brinzhang has quit IRC | 03:22 | |
*** hongbin has quit IRC | 03:24 | |
*** mkrai has joined #openstack-nova | 03:27 | |
*** lbragstad_ has joined #openstack-nova | 03:31 | |
*** lbragstad has quit IRC | 03:31 | |
*** ociuhandu has joined #openstack-nova | 04:01 | |
*** ociuhandu has quit IRC | 04:06 | |
*** slaweq has joined #openstack-nova | 04:11 | |
*** slaweq has quit IRC | 04:16 | |
*** lbragstad has joined #openstack-nova | 04:25 | |
*** abhishekk has joined #openstack-nova | 04:27 | |
*** lbragstad_ has quit IRC | 04:28 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | 04:32 |
---|---|---|
*** lbragstad_ has joined #openstack-nova | 04:33 | |
*** lbragstad has quit IRC | 04:34 | |
*** boxiang has quit IRC | 04:36 | |
*** boxiang has joined #openstack-nova | 04:36 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | 04:36 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Fix legacy issues in Filter migrations by user_id/project_id https://review.opendev.org/682198 | 04:37 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Fix legacy issues in filter migrations by user_id/project_id https://review.opendev.org/682198 | 04:38 |
*** dave-mccowan has quit IRC | 04:39 | |
*** lbragstad has joined #openstack-nova | 04:40 | |
*** lbragstad_ has quit IRC | 04:41 | |
*** pcaruana has joined #openstack-nova | 04:55 | |
*** tkajinam has quit IRC | 05:01 | |
*** tkajinam has joined #openstack-nova | 05:02 | |
*** brinzhang_ has quit IRC | 05:08 | |
*** brinzhang_ has joined #openstack-nova | 05:08 | |
*** tkajinam has quit IRC | 05:23 | |
*** tkajinam has joined #openstack-nova | 05:23 | |
*** brinzhang has joined #openstack-nova | 05:28 | |
*** brinzhang_ has quit IRC | 05:31 | |
*** eandersson has quit IRC | 05:45 | |
*** eandersson has joined #openstack-nova | 05:47 | |
*** evrardjp_ has joined #openstack-nova | 05:49 | |
*** tbarron has quit IRC | 05:54 | |
*** Vek has quit IRC | 05:55 | |
*** evrardjp has quit IRC | 05:55 | |
*** antonym has quit IRC | 05:55 | |
*** antonym has joined #openstack-nova | 05:55 | |
*** udesale has joined #openstack-nova | 05:56 | |
*** irclogbot_0 has quit IRC | 05:56 | |
*** irclogbot_3 has joined #openstack-nova | 05:57 | |
openstackgerrit | ya.wang proposed openstack/nova master: libvirt: Change _compare_cpu to raise InternalError https://review.opendev.org/687808 | 06:00 |
*** lbragstad_ has joined #openstack-nova | 06:00 | |
*** brinzhang has quit IRC | 06:00 | |
*** brinzhang has joined #openstack-nova | 06:01 | |
*** lbragstad has quit IRC | 06:01 | |
*** lpetrut has joined #openstack-nova | 06:04 | |
*** slaweq has joined #openstack-nova | 06:09 | |
*** xek_ has joined #openstack-nova | 06:09 | |
*** slaweq_ has joined #openstack-nova | 06:13 | |
*** brinzhang_ has joined #openstack-nova | 06:14 | |
*** slaweq has quit IRC | 06:14 | |
*** brinzhang has quit IRC | 06:17 | |
openstackgerrit | Luyao Zhong proposed openstack/nova master: support live migration with vpmems https://review.opendev.org/687856 | 06:20 |
*** jawad_axd has joined #openstack-nova | 06:21 | |
*** jawad_axd has quit IRC | 06:21 | |
*** jawad_axd has joined #openstack-nova | 06:22 | |
*** jawad_axd has quit IRC | 06:25 | |
*** jawad_axd has joined #openstack-nova | 06:26 | |
*** mkrai has quit IRC | 06:30 | |
*** mkrai_ has joined #openstack-nova | 06:30 | |
*** SonPham has joined #openstack-nova | 06:41 | |
*** SonPham has quit IRC | 06:42 | |
openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Change the primary assignee to the mainly contributor https://review.opendev.org/688042 | 06:45 |
*** brinzhang has joined #openstack-nova | 06:46 | |
openstackgerrit | Yongli He proposed openstack/nova master: Clean up orphan instances virt driver https://review.opendev.org/648912 | 06:46 |
openstackgerrit | Yongli He proposed openstack/nova master: clean up orphan instances https://review.opendev.org/627765 | 06:46 |
*** slaweq_ is now known as slaweq | 06:48 | |
*** brinzhang_ has quit IRC | 06:49 | |
*** trident has quit IRC | 06:53 | |
*** trident has joined #openstack-nova | 06:55 | |
*** damien_r has joined #openstack-nova | 06:55 | |
*** cfriesen has quit IRC | 06:56 | |
*** ttsiouts has joined #openstack-nova | 07:00 | |
*** rcernin has quit IRC | 07:03 | |
*** tesseract has joined #openstack-nova | 07:03 | |
*** ccamacho has joined #openstack-nova | 07:04 | |
*** tssurya has joined #openstack-nova | 07:09 | |
*** lpetrut has quit IRC | 07:15 | |
*** brinzhang_ has joined #openstack-nova | 07:18 | |
*** tobberydberg has quit IRC | 07:20 | |
*** brinzhang has quit IRC | 07:21 | |
*** ttsiouts has quit IRC | 07:24 | |
*** ttsiouts has joined #openstack-nova | 07:25 | |
*** tobberydberg has joined #openstack-nova | 07:26 | |
*** awalende has joined #openstack-nova | 07:28 | |
*** brinzhang has joined #openstack-nova | 07:29 | |
*** ttsiouts has quit IRC | 07:30 | |
*** brinzhang_ has quit IRC | 07:33 | |
*** lpetrut has joined #openstack-nova | 07:34 | |
*** jaosorior has joined #openstack-nova | 07:38 | |
*** Vek has joined #openstack-nova | 07:43 | |
*** brinzhang_ has joined #openstack-nova | 07:47 | |
*** brinzhang_ has quit IRC | 07:48 | |
*** brinzhang_ has joined #openstack-nova | 07:49 | |
*** brinzhang_ has quit IRC | 07:50 | |
*** brinzhang has quit IRC | 07:50 | |
*** rpittau|afk is now known as rpittau | 07:53 | |
*** lpetrut has quit IRC | 07:53 | |
*** ivve has joined #openstack-nova | 07:55 | |
*** ralonsoh has joined #openstack-nova | 07:56 | |
*** tkajinam has quit IRC | 07:58 | |
*** ttsiouts has joined #openstack-nova | 08:00 | |
openstackgerrit | Merged openstack/nova master: Fix exception translation when creating volume https://review.opendev.org/678991 | 08:07 |
openstackgerrit | Merged openstack/python-novaclient master: PDF documentation build https://review.opendev.org/687966 | 08:17 |
openstackgerrit | Merged openstack/nova master: Fix unit of hw_rng:rate_period https://review.opendev.org/683051 | 08:20 |
*** markvoelker has joined #openstack-nova | 08:25 | |
*** markvoelker has quit IRC | 08:30 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Stop sending bad values from libosinfo to libvirt https://review.opendev.org/688067 | 08:32 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Stop sending bad values from libosinfo to libvirt https://review.opendev.org/688068 | 08:33 |
*** mkrai_ has quit IRC | 08:33 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Stop sending bad values from libosinfo to libvirt https://review.opendev.org/688069 | 08:34 |
trident | Any thoughts on https://bugs.launchpad.net/nova/+bug/1741364 ? | 08:39 |
openstack | Launchpad bug 1741364 in OpenStack Compute (nova) "ceph ephemeral info not updated during live migrate" [Medium,Confirmed] | 08:39 |
openstackgerrit | Fan Zhang proposed openstack/nova stable/train: Fix exception translation when creating volume https://review.opendev.org/688072 | 08:41 |
openstackgerrit | Fan Zhang proposed openstack/nova stable/stein: Fix exception translation when creating volume https://review.opendev.org/688073 | 08:43 |
openstackgerrit | Fan Zhang proposed openstack/nova stable/stein: Fix exception translation when creating volume https://review.opendev.org/688073 | 08:43 |
*** mkrai has joined #openstack-nova | 08:44 | |
*** liuyulong has joined #openstack-nova | 08:48 | |
*** mkrai has quit IRC | 08:48 | |
*** takamatsu has joined #openstack-nova | 08:49 | |
*** mkrai has joined #openstack-nova | 08:51 | |
*** mkrai has quit IRC | 08:54 | |
*** mkrai_ has joined #openstack-nova | 08:54 | |
*** macz has joined #openstack-nova | 08:57 | |
*** macz has quit IRC | 09:02 | |
*** mkrai_ has quit IRC | 09:02 | |
*** liuyulong has quit IRC | 09:03 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova stable/train: Fix unit of hw_rng:rate_period https://review.opendev.org/688083 | 09:03 |
openstackgerrit | ya.wang proposed openstack/nova master: libvirt: Change _compare_cpu to raise InvalidCPUInfo https://review.opendev.org/687808 | 09:08 |
*** takashin has left #openstack-nova | 09:10 | |
*** ivve has quit IRC | 09:10 | |
*** ivve has joined #openstack-nova | 09:18 | |
*** mkrai has joined #openstack-nova | 09:20 | |
openstackgerrit | Fan Zhang proposed openstack/nova stable/stein: Fix exception translation when creating volume https://review.opendev.org/688073 | 09:21 |
openstackgerrit | Fan Zhang proposed openstack/nova stable/rocky: Fix exception translation when creating volume https://review.opendev.org/688089 | 09:26 |
openstackgerrit | Nicolas Belouin proposed openstack/nova master: Add support for Xen PVH VM Mode in libvirt driver https://review.opendev.org/687827 | 09:31 |
stephenfin | did we not have a meeting last night | 09:39 |
openstackgerrit | Fan Zhang proposed openstack/nova stable/queens: Fix exception translation when creating volume https://review.opendev.org/688090 | 09:41 |
*** ociuhandu has joined #openstack-nova | 09:49 | |
*** kaisers has quit IRC | 09:52 | |
*** mvkr has quit IRC | 09:56 | |
*** kaisers has joined #openstack-nova | 09:56 | |
*** ttsiouts has quit IRC | 09:57 | |
*** ttsiouts has joined #openstack-nova | 09:58 | |
*** derekh has joined #openstack-nova | 09:58 | |
*** mkrai has quit IRC | 10:02 | |
*** mkrai_ has joined #openstack-nova | 10:02 | |
*** ttsiouts has quit IRC | 10:02 | |
*** brinzhang has joined #openstack-nova | 10:07 | |
*** rcernin has joined #openstack-nova | 10:08 | |
*** mvkr has joined #openstack-nova | 10:09 | |
*** rpittau is now known as rpittau|bbl | 10:15 | |
*** mkrai_ has quit IRC | 10:15 | |
*** rcernin has quit IRC | 10:21 | |
*** jmlowe has quit IRC | 10:24 | |
*** ociuhandu has quit IRC | 10:25 | |
*** jmlowe has joined #openstack-nova | 10:26 | |
*** ivve has quit IRC | 10:28 | |
*** tbachman has quit IRC | 10:29 | |
*** tbachman has joined #openstack-nova | 10:30 | |
*** ivve has joined #openstack-nova | 10:44 | |
*** tbachman has quit IRC | 10:44 | |
*** abhishekk has quit IRC | 10:50 | |
*** mkrai has joined #openstack-nova | 10:52 | |
*** dave-mccowan has joined #openstack-nova | 10:58 | |
*** macz has joined #openstack-nova | 10:58 | |
*** ttsiouts has joined #openstack-nova | 11:01 | |
*** macz has quit IRC | 11:03 | |
*** ociuhandu has joined #openstack-nova | 11:04 | |
*** ociuhandu has quit IRC | 11:04 | |
*** ttsiouts has quit IRC | 11:06 | |
*** ttsiouts has joined #openstack-nova | 11:06 | |
*** brinzhang_ has joined #openstack-nova | 11:16 | |
*** ociuhandu has joined #openstack-nova | 11:17 | |
*** mkrai has quit IRC | 11:18 | |
*** brinzhang has quit IRC | 11:19 | |
kashyap | Any stable cores, mind having a look at this stable/queens thing? It has also merged in other stable branches: https://review.opendev.org/#/c/668111/ (libvirt: Rework 'EBUSY' (SIGKILL) error handling code path | 11:20 |
kashyap | ) | 11:20 |
kashyap | (It has merged in Rocky and Stein.) | 11:21 |
*** brinzhang has joined #openstack-nova | 11:21 | |
*** brinzhang_ has quit IRC | 11:24 | |
*** mkrai has joined #openstack-nova | 11:25 | |
*** xek_ has quit IRC | 11:31 | |
*** brinzhang_ has joined #openstack-nova | 11:31 | |
lyarwood | kashyap: yup sorry looking now | 11:34 |
*** brinzhang has quit IRC | 11:34 | |
kashyap | Gracias | 11:34 |
*** yoctozepto has joined #openstack-nova | 11:52 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/pike: Error out interrupted builds https://review.opendev.org/687918 | 11:56 |
*** HagunKim has joined #openstack-nova | 11:56 | |
kashyap | Needs a second stable core +2 here: https://review.opendev.org/#/c/668111/ | 11:59 |
*** tbachman has joined #openstack-nova | 12:12 | |
frickler | this bug is targeted on tempest, but I'd like to know from nova ppl how valuable testing the hard reboot is to you, as I'm considering to propose dropping this test if it can't be made more reliable https://bugs.launchpad.net/tempest/+bug/1847759 | 12:21 |
openstack | Launchpad bug 1847759 in tempest "reboot_server_hard can trigger corrupted file system" [Undecided,New] | 12:21 |
*** yaawang has quit IRC | 12:23 | |
lyarwood | frickler: IMHO it's useful and that sounds worrying as a bug report | 12:25 |
frickler | lyarwood: I'm even more worried after seeing how many matches my logstash query has, though I haven't verified yet how many of those match the bug http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22self._test_reboot_server('HARD')%5C%22 | 12:28 |
*** markvoelker has joined #openstack-nova | 12:28 | |
lyarwood | frickler: I wonder if we even need to boot an instance using an image to test hard reboot | 12:29 |
lyarwood | frickler: if corruption of the image by the guest OS dying suddenly is the issue here | 12:30 |
*** markvoelker has quit IRC | 12:33 | |
*** rpittau|bbl is now known as rpittau | 12:33 | |
*** markvoelker has joined #openstack-nova | 12:34 | |
frickler | lyarwood: o.k., I checked some of the failure logs. 2/3 seem to fail to connect to the instance on the initial boot already, 1/3 looks like fs corruption after the hard reboot, so still a relevant set. if you have any idea how to make that more stable, I think that would be pretty useful | 12:36 |
*** awalende has quit IRC | 12:40 | |
*** awalende has joined #openstack-nova | 12:41 | |
*** mkrai has quit IRC | 12:45 | |
*** mkrai has joined #openstack-nova | 12:45 | |
*** awalende has quit IRC | 12:46 | |
bauzas | stephenfin: nope, the nova meeting was cancelled, see ML | 12:57 |
*** macz has joined #openstack-nova | 12:59 | |
*** macz has quit IRC | 13:03 | |
*** nweinber_ has joined #openstack-nova | 13:04 | |
*** mkrai has quit IRC | 13:08 | |
*** dklyle has quit IRC | 13:11 | |
*** BjoernT has joined #openstack-nova | 13:17 | |
*** lbragstad_ is now known as lbragstad | 13:18 | |
*** BjoernT_ has joined #openstack-nova | 13:21 | |
stephenfin | bauzas: ah, yes, thanks | 13:23 |
stephenfin | bauzas: Would you do me the honours? https://review.opendev.org/#/c/684402/ https://review.opendev.org/#/c/685929/ https://review.opendev.org/#/c/687264// ? | 13:24 |
* bauzas clicks clicks clicks | 13:24 | |
*** BjoernT has quit IRC | 13:24 | |
*** READ10 has joined #openstack-nova | 13:24 | |
openstackgerrit | Matthew Booth proposed openstack/nova master: Don't take a lock when fetching a cached cell mapping https://review.opendev.org/688122 | 13:25 |
*** ttsiouts has quit IRC | 13:25 | |
*** dklyle has joined #openstack-nova | 13:26 | |
*** lbragstad has quit IRC | 13:26 | |
*** ttsiouts has joined #openstack-nova | 13:26 | |
stephenfin | bauzas: ta | 13:29 |
*** ttsiouts has quit IRC | 13:31 | |
*** brinzhang_ has quit IRC | 13:32 | |
*** brinzhang_ has joined #openstack-nova | 13:32 | |
openstackgerrit | Merged openstack/nova master: api-guide: Fix available info in handling down cells https://review.opendev.org/686520 | 13:35 |
openstackgerrit | Merged openstack/nova-specs master: Change the primary assignee to the mainly contributor https://review.opendev.org/688042 | 13:41 |
openstackgerrit | Merged openstack/nova-specs master: Fix followup comments of policy-defaults-refresh spec https://review.opendev.org/669196 | 13:41 |
*** jawad_axd has quit IRC | 13:51 | |
*** eharney has joined #openstack-nova | 13:52 | |
mdbooth | lyarwood: Re https://code.engineering.redhat.com/gerrit/182841 GAH! and thanks. Mind if we don't wait for tempest after I update the commit message? | 13:54 |
lyarwood | mdbooth: wrong window but yeah of course | 13:54 |
*** ttsiouts has joined #openstack-nova | 13:55 | |
mdbooth | lyarwood: Hah, so it is | 13:55 |
*** xek_ has joined #openstack-nova | 13:55 | |
*** ociuhandu has quit IRC | 13:57 | |
*** udesale has quit IRC | 13:57 | |
*** udesale has joined #openstack-nova | 13:58 | |
*** mlavalle has joined #openstack-nova | 13:58 | |
*** gbarros has joined #openstack-nova | 13:59 | |
*** lbragstad has joined #openstack-nova | 13:59 | |
*** artom has joined #openstack-nova | 14:00 | |
*** boxiang_ has joined #openstack-nova | 14:01 | |
*** boxiang_ has quit IRC | 14:02 | |
*** tssurya has quit IRC | 14:03 | |
*** HagunKim has quit IRC | 14:07 | |
*** jawad_axd has joined #openstack-nova | 14:09 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Avoid using image with kernel in BDM large request func test https://review.opendev.org/688132 | 14:11 |
*** liuyulong has joined #openstack-nova | 14:12 | |
*** ociuhandu has joined #openstack-nova | 14:14 | |
*** TxGirlGeek has joined #openstack-nova | 14:21 | |
*** READ10 has quit IRC | 14:22 | |
*** BjoernT_ is now known as BjoernT | 14:25 | |
*** ociuhandu has quit IRC | 14:28 | |
*** cfriesen has joined #openstack-nova | 14:29 | |
*** ociuhandu has joined #openstack-nova | 14:34 | |
*** READ10 has joined #openstack-nova | 14:38 | |
*** macz has joined #openstack-nova | 14:38 | |
*** munimeha1 has joined #openstack-nova | 14:39 | |
gibi | stephenfin: quick question in https://review.opendev.org/#/c/686802/6//COMMIT_MSG@18 | 14:40 |
*** jawad_axd has quit IRC | 14:42 | |
*** awalende has joined #openstack-nova | 14:43 | |
*** macz has quit IRC | 14:43 | |
stephenfin | gibi: replied | 14:47 |
*** awalende has quit IRC | 14:47 | |
gibi | stephenfin: +2 | 14:47 |
stephenfin | ta | 14:47 |
*** ivve has quit IRC | 14:50 | |
stephenfin | gibi: If you're on a reviewing streak, I'd appreciate your eyes on the following patch too since it's NeutronFixture'y and you know that stuff, heh https://review.opendev.org/#/c/684344/ | 14:55 |
stephenfin | Feel free to chuck something my way too | 14:56 |
gibi | stephenfin: reviewing it right no | 14:56 |
gibi | w | 14:56 |
stephenfin | nice :D | 14:56 |
dansmith | gibi: there are a few patches in this stack for which you reviewed the spec that you could +W if you want :) | 14:56 |
dansmith | gibi: https://review.opendev.org/#/c/687137/4 | 14:56 |
gibi | dansmith: ack, I will look at it after stephenfin's patch | 14:57 |
*** KeithMnemonic has joined #openstack-nova | 14:57 | |
dansmith | gibi: thanks | 14:57 |
gibi | stephenfin: -1 due to https://review.opendev.org/#/c/684344/15/nova/tests/functional/api_sample_tests/test_floating_ips.py@158 | 14:57 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_images() to conductor https://review.opendev.org/687139 | 14:58 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140 | 14:58 |
openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Add image precaching docs for aggregates https://review.opendev.org/687348 | 14:58 |
stephenfin | gibi: Would a follow-up be okay? Can post that now | 14:58 |
gibi | stephenfin: sure | 14:59 |
gibi | let me change my vote | 14:59 |
*** FlorianFa has quit IRC | 15:03 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Use deepcopy on value returned by NeutronFixture https://review.opendev.org/688139 | 15:03 |
*** lpetrut has joined #openstack-nova | 15:04 | |
*** macz has joined #openstack-nova | 15:04 | |
*** ttsiouts has quit IRC | 15:08 | |
*** ociuhandu has quit IRC | 15:09 | |
*** amodi has quit IRC | 15:16 | |
*** udesale has quit IRC | 15:23 | |
*** ociuhandu has joined #openstack-nova | 15:27 | |
stephenfin | gibi: Back at you https://review.opendev.org/#/c/688132/ | 15:29 |
*** damien_r has quit IRC | 15:29 | |
gibi | stephenfin: thanks. Make sense. I need to get back to that | 15:30 |
*** jawad_axd has joined #openstack-nova | 15:30 | |
*** READ10 has quit IRC | 15:32 | |
*** jawad_axd has quit IRC | 15:35 | |
*** ozzzo has quit IRC | 15:40 | |
*** ozzzo has joined #openstack-nova | 15:41 | |
*** bnemec has quit IRC | 15:43 | |
*** rpittau is now known as rpittau|afk | 15:44 | |
*** bnemec has joined #openstack-nova | 15:44 | |
*** gbarros has quit IRC | 15:49 | |
*** jangutter has quit IRC | 15:50 | |
*** gbarros has joined #openstack-nova | 15:53 | |
gibi | dansmith: reviewd the image chache series left some comments here and there | 15:53 |
dansmith | gibi: so the return dict thing is leaving us some room for improvement in the future without having to bump the compute rpc version again | 15:55 |
*** jaosorior has quit IRC | 15:55 | |
*** macz has quit IRC | 15:55 | |
dansmith | gibi: are you -1 on that or the logging asserts? | 15:55 |
*** tbachman has quit IRC | 15:55 | |
dansmith | oh you said, because the driver bit is unused | 15:55 |
gibi | dansmith: you mean that now the rpc returns a dict so later we can add whatever we want to that dict without rpc bump? | 15:56 |
dansmith | gibi: no, it's returning that so that I could follow on with some stats logging in conductor.. not expecting to add stuff to the dict later, just expecting to use it | 15:56 |
dansmith | gibi: there was some discussion in those patches (IIRC) but definitely some here about what we might do in the future to log some stats, | 15:56 |
dansmith | gibi: like "image X seemed to fail on every host" or "34 new downloads, 127 existing", that kind of thing | 15:57 |
gibi | dansmith: if it will be used in the future then I'm OK with it | 15:57 |
dansmith | gibi: yep, plan is to use it, just trying to keep the base functionality to these patches and then we can hem and haw over how to calculate some stats in a future patch | 15:57 |
*** boxiang has quit IRC | 15:59 | |
*** zhubx has joined #openstack-nova | 15:59 | |
*** zhubx has quit IRC | 16:00 | |
*** zhubx has joined #openstack-nova | 16:01 | |
gibi | dansmith: cool. changed my votes as the rest of my comments can be done in a fup | 16:01 |
dansmith | gibi: roger, just saw as I was replying, I'll post a fup for the nits and get a WIP enqueued for the stats so I can point at that if the question comes up again :D | 16:01 |
gibi | dansmith: thanks | 16:02 |
dansmith | gibi: oh, heh on that libvirt test name... it's totally opposite, I dunno how I did that :P | 16:04 |
*** lpetrut has quit IRC | 16:05 | |
gibi | :) | 16:05 |
dansmith | I'll call it a "testing gibi's attention to detail" easter egg | 16:06 |
gibi | it worked :) | 16:06 |
dansmith | yeah you passed the test this time | 16:06 |
gibi | I'm wondering was there other tests I did not even notice?! | 16:07 |
dansmith | gibi: muahah :D | 16:09 |
gibi | stephenfin: do you want me to refactor the fake image service ? https://review.opendev.org/#/c/688132/1/nova/tests/functional/test_boot_from_volume.py@203 | 16:09 |
*** med has joined #openstack-nova | 16:10 | |
*** med is now known as medberry | 16:10 | |
*** ivve has joined #openstack-nova | 16:11 | |
gibi | stephenfin: https://github.com/openstack/nova/blob/ef6e49d5bc721840b331c87c6391a69309253ade/nova/tests/unit/image/fake.py#L45 | 16:11 |
stephenfin | gibi: If you have time, but I won't block on that now | 16:12 |
gibi | stephenfin: I can do that later. making a todo... | 16:12 |
stephenfin | tbh, I'd like to stop using the 'stub_out_image_service' function entirely since it obscures things | 16:13 |
stephenfin | I've a big functional test cleanup in-progress. Can include that | 16:13 |
gibi | stephenfin: OK, I will ping you when I reach my todo to see if you have already started on it | 16:15 |
stephenfin | (y) | 16:15 |
stephenfin | +2 | 16:16 |
gibi | Im leaving for today. Have a nice weeked you all! | 16:18 |
*** medberry has quit IRC | 16:20 | |
stephenfin | O/ | 16:22 |
*** ociuhandu has quit IRC | 16:23 | |
*** tbachman has joined #openstack-nova | 16:26 | |
*** ociuhandu has joined #openstack-nova | 16:26 | |
*** bbowen has quit IRC | 16:29 | |
*** markvoelker has quit IRC | 16:38 | |
*** BjoernT_ has joined #openstack-nova | 16:39 | |
*** BjoernT has quit IRC | 16:41 | |
*** xek_ has quit IRC | 16:44 | |
*** markvoelker has joined #openstack-nova | 16:48 | |
*** derekh has quit IRC | 16:48 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Fix up some feedback on image precache support https://review.opendev.org/688172 | 16:53 |
openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Log some stats for image pre-cache https://review.opendev.org/688173 | 16:53 |
*** gyee has joined #openstack-nova | 16:53 | |
*** bnemec has quit IRC | 16:57 | |
*** bnemec has joined #openstack-nova | 16:58 | |
*** BjoernT_ has quit IRC | 17:00 | |
*** dklyle has quit IRC | 17:14 | |
*** markvoelker has quit IRC | 17:18 | |
*** READ10 has joined #openstack-nova | 17:30 | |
*** eharney has quit IRC | 17:34 | |
*** ociuhandu_ has joined #openstack-nova | 17:34 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140 | 17:37 |
openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Add image precaching docs for aggregates https://review.opendev.org/687348 | 17:37 |
openstackgerrit | Dan Smith proposed openstack/nova master: Fix up some feedback on image precache support https://review.opendev.org/688172 | 17:37 |
openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Log some stats for image pre-cache https://review.opendev.org/688173 | 17:37 |
*** ociuhandu has quit IRC | 17:37 | |
*** ociuhandu_ has quit IRC | 17:42 | |
*** ociuhandu has joined #openstack-nova | 17:43 | |
*** ociuhandu has quit IRC | 17:48 | |
*** dklyle has joined #openstack-nova | 17:49 | |
*** dklyle has quit IRC | 17:56 | |
*** ceryx has quit IRC | 17:58 | |
*** slaweq has quit IRC | 18:00 | |
*** dklyle has joined #openstack-nova | 18:02 | |
*** gbarros has quit IRC | 18:06 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: setup.cfg: Cleanup https://review.opendev.org/677969 | 18:06 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop testing Python 2 https://review.opendev.org/687954 | 18:06 |
*** ivve has quit IRC | 18:09 | |
*** ivve has joined #openstack-nova | 18:10 | |
*** tbachman has quit IRC | 18:11 | |
melwitt | o/ | 18:13 |
*** gbarros has joined #openstack-nova | 18:14 | |
*** eharney has joined #openstack-nova | 18:16 | |
*** tbachman has joined #openstack-nova | 18:19 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop testing Python 2 https://review.opendev.org/687954 | 18:19 |
openstackgerrit | Merged openstack/nova master: Add cache_image() driver method and libvirt implementation https://review.opendev.org/687137 | 18:28 |
*** ganso has quit IRC | 18:40 | |
openstackgerrit | Merged openstack/nova master: Add cache_image() support to the compute/{rpcapi,api,manager} https://review.opendev.org/687138 | 18:41 |
*** med_ has quit IRC | 18:43 | |
melwitt | zzzeek: hey, are you around? | 18:52 |
zzzeek | melwitt: heya | 18:52 |
melwitt | o. | 18:52 |
melwitt | o/ | 18:52 |
melwitt | question for you | 18:52 |
zzzeek | yep | 18:53 |
melwitt | zzzeek: do you happen to know why if this write adds a record in a single request with project_id=NULL, a non-independent read of records matching project_id=NULL will return no rows? https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L4101 | 18:55 |
zzzeek | melwitt: well in SQL there is no "= NULL" that works, it has to be "is NULL" | 18:55 |
*** pcaruana has quit IRC | 18:55 | |
zzzeek | melwitt: SQLAlchemy makes that conversion in most cases | 18:55 |
zzzeek | melwitt: however, sometimes it cant | 18:56 |
zzzeek | melwitt: depends on context | 18:56 |
melwitt | zzzeek: I did learn that recently and found that our query does make the conversion correctly. what I found is that if the insert of the record happens with "independent" and a read *without* independent happens in the same request looking for "is NULL" it will not find the record that was written. it behaves as though the inserted record is not reflected in the current session | 18:57 |
zzzeek | melwitt: im not seeing what the query is here but if you were to do query(Foo).with_parent(Bar(id=None)) you might see that this does not in fact return Foo with bar_id=NULL | 18:57 |
zzzeek | melwitt: ah well that is a transaction isolation issue | 18:58 |
melwitt | and if I use "independent" in the read, it _will_ find the record. that could make some sense if the session caches stuff it knows about in the current transaction | 18:58 |
*** ganso has joined #openstack-nova | 18:58 | |
melwitt | the weird thing is that it does not behave this way if it is not project=NULL. when project_id is not NULL, it will find the record fine without using "independent" on the read | 18:58 |
zzzeek | melwitt: OK so there are two levels to that. the first is, if you want to assume your transaction is non-isolated, you can say query(MyObject).populate_existing().filter(...)... | 18:59 |
zzzeek | melwitt: that asusmes you already have MyObject loaded and some related part of it is not being updated | 18:59 |
zzzeek | melwitt: if it is straight up, query(MyObject) returns no row, and the row is there, then this would be like a repeatable read problem | 19:00 |
*** tbachman has quit IRC | 19:00 | |
* melwitt googles | 19:01 | |
zzzeek | melwitt: basically if transaction A starts, then you do sometihgn in transaction B, you can't rely that transaction A can see what you just committed in B | 19:01 |
melwitt | ohhhh | 19:01 |
zzzeek | melwitt: with a list of caveats a mile long | 19:01 |
melwitt | so transaction A inserts the record, transaction B reads the record and doesn't see it, yet transaction C (if added) will see what A committed. is the behavior I'm observing | 19:03 |
*** xek_ has joined #openstack-nova | 19:03 | |
zzzeek | melwitt: yes if transaction C started after A was finished doing its work. transaction A would only have had to have committed if isolatoin level is serializable which it is not | 19:04 |
zzzeek | melwitt: it's mostly about, im a transaction, I read some data, now that data is part of a "version" that i will forever see until my transaction ends | 19:05 |
zzzeek | if i didnt read that data yet, then i dont know anything about it and based on isolation i might see the work of other transations | 19:05 |
zzzeek | also my previous line about A not having to commit is incorrect. it has to have committed unless isoaltion is read uncommitted, or if theres some quirky mysql behavior going on | 19:06 |
* zzzeek bah tries | 19:06 | |
zzzeek | melwitt: yeah mysql is doing repeatable read by default over here. transaction A runs INSERT, but hasnt committed, B can see nothing no matter when it was started | 19:08 |
zzzeek | A then commits. B can only see something if it hasn't tried to read that table already | 19:08 |
melwitt | zzzeek: that makes sense. it seems to work fine though when NULL are not involved in the where of the read. I would have thought it should act the same in both cases | 19:09 |
zzzeek | melwitt: Im not sure about the NULL part. i would need to see the SQL conversation in detail | 19:10 |
* melwitt nods | 19:10 | |
melwitt | oh you know what, it's because there's a unique constraint on the project_id, so the second insert won't go through | 19:11 |
melwitt | (I keep mixing everything up in my head) | 19:11 |
melwitt | er, it will not read the newly inserted record, same as the NULL case. it's just that I can't detect on the surface that it did that, because the evidence was creation of a dupe project_id record | 19:12 |
melwitt | tl;dr it does act the same no matter the project_id | 19:13 |
*** zhubx has quit IRC | 19:14 | |
*** tbachman has joined #openstack-nova | 19:14 | |
*** zhubx has joined #openstack-nova | 19:14 | |
zzzeek | melwitt: OK if it works for you :) | 19:15 |
*** eharney has quit IRC | 19:16 | |
*** zhubx has quit IRC | 19:16 | |
*** zhubx has joined #openstack-nova | 19:16 | |
melwitt | zzzeek: haha :) well, it seems to resolve find if I do the read in a new transaction C, but based on what I understand that's not guaranteed to do what I want. if the insert doesn't commit by the time C tries to read, it will still get 0 rows yeah? | 19:17 |
*** zhubx has quit IRC | 19:18 | |
*** markvoelker has joined #openstack-nova | 19:18 | |
*** zhubx has joined #openstack-nova | 19:18 | |
*** zhubx has quit IRC | 19:20 | |
*** zhubx has joined #openstack-nova | 19:20 | |
*** zhubx has quit IRC | 19:22 | |
*** zhubx has joined #openstack-nova | 19:22 | |
*** zhubx has quit IRC | 19:24 | |
*** zhubx has joined #openstack-nova | 19:24 | |
*** tbachman has quit IRC | 19:25 | |
*** zhubx has quit IRC | 19:26 | |
*** zhubx has joined #openstack-nova | 19:26 | |
*** markvoelker has quit IRC | 19:30 | |
*** READ10 has quit IRC | 19:32 | |
*** markvoelker has joined #openstack-nova | 19:33 | |
*** gbarros has quit IRC | 19:36 | |
*** markvoelker has quit IRC | 19:41 | |
*** gbarros has joined #openstack-nova | 19:42 | |
*** gbarros has quit IRC | 19:52 | |
*** bbowen has joined #openstack-nova | 19:58 | |
*** nweinber_ has quit IRC | 20:06 | |
*** eharney has joined #openstack-nova | 20:30 | |
*** BjoernT has joined #openstack-nova | 20:31 | |
*** zhubx has quit IRC | 20:33 | |
*** zhubx has joined #openstack-nova | 20:33 | |
*** zhubx has quit IRC | 20:34 | |
*** BjoernT_ has joined #openstack-nova | 20:43 | |
*** BjoernT has quit IRC | 20:45 | |
*** markvoelker has joined #openstack-nova | 20:49 | |
*** markvoelker has quit IRC | 20:53 | |
*** bbowen_ has joined #openstack-nova | 21:17 | |
*** bbowen has quit IRC | 21:18 | |
*** tesseract has quit IRC | 21:18 | |
*** munimeha1 has quit IRC | 21:22 | |
*** eharney has quit IRC | 21:25 | |
openstackgerrit | melanie witt proposed openstack/nova master: Add regression test for bug 1824435 https://review.opendev.org/688205 | 21:25 |
openstack | bug 1824435 in OpenStack Compute (nova) stein "fill_virtual_interface_list migration fails on second attempt" [Medium,Triaged] https://launchpad.net/bugs/1824435 | 21:25 |
openstackgerrit | melanie witt proposed openstack/nova master: Use a separate transaction to read default security group https://review.opendev.org/688206 | 21:25 |
*** tbachman has joined #openstack-nova | 21:40 | |
*** BjoernT_ has quit IRC | 21:42 | |
*** BjoernT has joined #openstack-nova | 21:43 | |
*** mdbooth has quit IRC | 22:02 | |
*** mdbooth has joined #openstack-nova | 22:03 | |
*** ralonsoh has quit IRC | 22:09 | |
*** gbarros has joined #openstack-nova | 22:19 | |
*** tbachman has quit IRC | 22:33 | |
*** KeithMnemonic has quit IRC | 22:38 | |
*** rcernin has joined #openstack-nova | 22:41 | |
*** xek_ has quit IRC | 22:42 | |
*** xek_ has joined #openstack-nova | 22:45 | |
*** bbowen_ has quit IRC | 22:48 | |
*** bbowen has joined #openstack-nova | 22:54 | |
*** bbowen has quit IRC | 22:54 | |
*** bbowen has joined #openstack-nova | 22:56 | |
*** xek_ has quit IRC | 22:57 | |
*** BjoernT has quit IRC | 23:01 | |
*** BjoernT has joined #openstack-nova | 23:01 | |
*** ivve has quit IRC | 23:07 | |
*** gbarros has quit IRC | 23:08 | |
*** artom has quit IRC | 23:12 | |
*** BjoernT has quit IRC | 23:15 | |
*** BjoernT has joined #openstack-nova | 23:16 | |
*** BjoernT has quit IRC | 23:17 | |
*** BjoernT has joined #openstack-nova | 23:18 | |
*** BjoernT has quit IRC | 23:19 | |
*** BjoernT has joined #openstack-nova | 23:21 | |
*** tbachman has joined #openstack-nova | 23:21 | |
*** BjoernT has quit IRC | 23:36 | |
*** tbachman has quit IRC | 23:46 | |
*** medberry has joined #openstack-nova | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!