Wednesday, 2019-10-16

*** markvoelker has joined #openstack-nova00:16
*** brinzhang has joined #openstack-nova00:22
*** xek__ has quit IRC00:23
*** xek__ has joined #openstack-nova00:23
*** brinzhang_ has quit IRC00:24
*** markvoelker has quit IRC00:27
brinzhanggood morning, nova.00:31
brinzhangefried: good morning ^^00:31
*** markvoelker has joined #openstack-nova00:36
*** gyee has quit IRC00:45
*** markvoelker has quit IRC00:46
*** mdbooth has quit IRC01:00
openstackgerritBrin Zhang proposed openstack/nova master: Add image caching API for aggregates  https://review.opendev.org/68714001:01
*** mdbooth has joined #openstack-nova01:02
*** dlbewley has joined #openstack-nova01:03
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask  https://review.opendev.org/62789001:05
openstackgerritMatt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method  https://review.opendev.org/63483201:05
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask  https://review.opendev.org/62789101:05
openstackgerritMatt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method  https://review.opendev.org/63508001:05
openstackgerritMatt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask  https://review.opendev.org/63564601:05
openstackgerritMatt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask  https://review.opendev.org/63566801:05
openstackgerritMatt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize()  https://review.opendev.org/63568401:05
openstackgerritMatt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted()  https://review.opendev.org/63622401:05
openstackgerritMatt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize  https://review.opendev.org/63625301:06
openstackgerritMatt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor  https://review.opendev.org/64259101:06
openstackgerritMatt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing  https://review.opendev.org/64259201:06
openstackgerritMatt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate  https://review.opendev.org/64345001:06
openstackgerritMatt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing  https://review.opendev.org/64345101:06
openstackgerritMatt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler  https://review.opendev.org/66901201:06
openstackgerritMatt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing  https://review.opendev.org/66901301:06
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize_at_source compute method  https://review.opendev.org/63705801:06
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add ConfirmResizeTask  https://review.opendev.org/63707001:06
openstackgerritMatt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method  https://review.opendev.org/63707501:06
*** nanzha has joined #openstack-nova01:21
openstackgerritMatt Riedemann proposed openstack/nova master: Add image caching API for aggregates  https://review.opendev.org/68714001:22
*** xek__ has quit IRC01:27
*** igordc has quit IRC01:47
*** TxGirlGeek has joined #openstack-nova01:50
*** ricolin has joined #openstack-nova01:57
*** spsurya has joined #openstack-nova01:59
*** brault has joined #openstack-nova02:09
*** TxGirlGeek has quit IRC02:11
openstackgerritzhangyujun proposed openstack/nova master: Should not raise when restore power on failed  https://review.opendev.org/62485402:11
*** TxGirlGeek has joined #openstack-nova02:11
*** dviroel has quit IRC02:14
*** yaawang_ has quit IRC02:16
*** yaawang_ has joined #openstack-nova02:18
openstackgerritBrin Zhang proposed openstack/nova master: Follow-up: Add delete_on_termination to volume-attach API  https://review.opendev.org/68065502:21
*** HagunKim has joined #openstack-nova02:36
*** markvoelker has joined #openstack-nova02:47
*** markvoelker has quit IRC02:51
*** mkrai_ has joined #openstack-nova02:56
*** dave-mccowan has quit IRC02:56
*** brinzhang_ has joined #openstack-nova02:56
*** brinzhang has quit IRC02:59
*** factor has joined #openstack-nova03:04
*** brinzhang has joined #openstack-nova03:12
*** brinzhang_ has quit IRC03:15
*** brinzhang_ has joined #openstack-nova03:16
*** brinzhang has quit IRC03:18
*** brinzhang has joined #openstack-nova03:36
*** brinzhang_ has quit IRC03:38
*** psachin has joined #openstack-nova04:02
*** brinzhang_ has joined #openstack-nova04:04
*** brinzhang has quit IRC04:07
*** TxGirlGeek has quit IRC04:08
*** brinzhang_ has quit IRC04:14
*** yaawang_ has quit IRC04:14
*** brinzhang_ has joined #openstack-nova04:15
*** yaawang_ has joined #openstack-nova04:15
*** pcaruana has joined #openstack-nova04:37
*** HagunKim has quit IRC04:45
*** tkajinam has quit IRC05:04
*** pcaruana has quit IRC05:14
*** brinzhang has joined #openstack-nova05:14
*** brinzhang_ has quit IRC05:17
*** Luzi has joined #openstack-nova05:18
*** lpetrut has joined #openstack-nova05:21
*** ratailor has joined #openstack-nova05:23
*** brinzhang_ has joined #openstack-nova05:24
*** lpetrut has quit IRC05:26
*** brinzhang has quit IRC05:27
*** ratailor has quit IRC05:29
*** hoonetorg has quit IRC05:35
*** bnemec has joined #openstack-nova05:38
*** brinzhang has joined #openstack-nova05:39
*** brinzhang_ has quit IRC05:42
*** tkajinam has joined #openstack-nova05:42
*** udesale has joined #openstack-nova05:44
*** hoonetorg has joined #openstack-nova05:48
*** jawad_axd has joined #openstack-nova05:59
*** mkrai_ has quit IRC06:00
*** brault has quit IRC06:06
*** brault has joined #openstack-nova06:08
*** mkrai_ has joined #openstack-nova06:11
*** pcaruana has joined #openstack-nova06:13
*** brinzhang_ has joined #openstack-nova06:24
*** brinzhang has quit IRC06:27
openstackgerritMerged openstack/nova master: Update compute rpc version alias for train  https://review.opendev.org/68841806:30
*** nanzha has quit IRC06:34
*** jmlowe has quit IRC06:38
*** dpawlik has joined #openstack-nova06:39
*** nanzha has joined #openstack-nova06:43
*** ralonsoh has joined #openstack-nova06:44
*** slaweq has joined #openstack-nova06:47
*** brault has quit IRC06:49
*** brault has joined #openstack-nova06:50
*** dpawlik has quit IRC06:53
*** dpawlik has joined #openstack-nova06:54
*** yedongcan has joined #openstack-nova06:56
*** brinzhang has joined #openstack-nova06:59
*** ileixe has joined #openstack-nova07:00
*** brinzhang_ has quit IRC07:01
*** maciejjozefczyk has joined #openstack-nova07:03
*** brinzhang_ has joined #openstack-nova07:07
*** takamatsu has joined #openstack-nova07:08
*** brinzhang has quit IRC07:10
*** yedongcan has quit IRC07:11
*** yaawang_ has quit IRC07:11
*** dpawlik has quit IRC07:12
*** yedongcan has joined #openstack-nova07:12
*** yaawang_ has joined #openstack-nova07:12
*** tesseract has joined #openstack-nova07:12
*** tesseract has quit IRC07:14
*** tesseract has joined #openstack-nova07:14
*** jmlowe has joined #openstack-nova07:17
*** ivve has joined #openstack-nova07:19
openstackgerritBrin Zhang proposed openstack/nova master: Follow-up: Add delete_on_termination to volume-attach API  https://review.opendev.org/68065507:22
*** damien_r has joined #openstack-nova07:24
*** trident has quit IRC07:27
gibigood morning07:27
*** priteau has quit IRC07:29
*** priteau has joined #openstack-nova07:30
*** Liang__ has joined #openstack-nova07:31
*** Liang__ is now known as LiangFang07:31
*** trident has joined #openstack-nova07:31
*** ociuhandu has joined #openstack-nova07:33
*** ociuhandu has quit IRC07:37
*** tssurya has joined #openstack-nova07:38
*** dpawlik has joined #openstack-nova07:42
*** dpawlik has quit IRC07:46
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Add minor version [21] to the test_versions  https://review.opendev.org/68859907:47
*** brinzhang has joined #openstack-nova07:47
*** brinzhang_ has quit IRC07:50
*** mkrai_ has quit IRC07:51
*** ttsiouts has joined #openstack-nova07:57
*** ileixe has quit IRC07:57
*** ileixe has joined #openstack-nova07:58
*** mkrai_ has joined #openstack-nova08:03
LiangFanghi, where can I find the plan of Shanghai PTG? Thanks08:06
LiangFange.g. the topics08:07
LiangFanghow to add topic please?08:07
*** rpittau|afk is now known as rpittau08:12
*** lpetrut has joined #openstack-nova08:12
*** jangutter has joined #openstack-nova08:14
*** larainema has joined #openstack-nova08:15
melwittLiangFang: http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010126.html08:15
*** tkajinam has quit IRC08:16
*** dpawlik has joined #openstack-nova08:17
kashyapmelwitt: Wauw, you're still awake?08:18
LiangFangmelwitt: thanks08:20
*** dpawlik has quit IRC08:21
*** takamatsu has quit IRC08:21
melwittkashyap: yeah :( going to bed soon08:23
* kashyap wishes a restful sleep.08:23
melwittthanks o/08:24
*** brinzhang_ has joined #openstack-nova08:25
*** yedongcan has quit IRC08:27
*** brinzhang has quit IRC08:28
*** tssurya has quit IRC08:34
*** brinzhang has joined #openstack-nova08:34
*** mkrai_ has quit IRC08:34
*** takamatsu has joined #openstack-nova08:36
*** brinzhang_ has quit IRC08:37
*** nanzha has quit IRC08:40
*** nanzha has joined #openstack-nova08:43
fricklerKeithMnemonic: I haven't tested that scenario yet, but we're running the same setup, so I'd be interested in hearing more about your findings. If you discover a reproducible issue, it would probably be best to create a bug report on lp08:43
*** xek__ has joined #openstack-nova08:51
*** gibi is now known as gibi_off08:58
*** mkrai_ has joined #openstack-nova08:59
*** brinzhang_ has joined #openstack-nova08:59
*** awalende has joined #openstack-nova09:01
*** brinzhang has quit IRC09:03
*** dtantsur|afk is now known as dtantsur09:07
*** ttsiouts has quit IRC09:09
*** ttsiouts has joined #openstack-nova09:09
openstackgerritsunjiyun-inspur proposed openstack/nova master: first modify  https://review.opendev.org/68888409:13
*** nanzha has quit IRC09:14
*** nanzha has joined #openstack-nova09:21
*** panda is now known as panda|drappt09:23
openstackgerritHuachang Wang proposed openstack/nova master: Set instance CPU policy to 'share' through image property  https://review.opendev.org/68860309:31
*** LiangFang has quit IRC09:35
*** victor286 has joined #openstack-nova09:37
*** ociuhandu has joined #openstack-nova09:42
*** dpawlik has joined #openstack-nova09:47
*** dpawlik has quit IRC09:52
*** rcernin has quit IRC09:54
*** brinzhang has joined #openstack-nova10:00
*** ileixe has quit IRC10:02
*** brinzhang_ has quit IRC10:04
*** dpawlik has joined #openstack-nova10:06
*** ociuhandu has quit IRC10:13
*** victor286 has quit IRC10:14
*** ttsiouts has quit IRC10:20
*** ttsiouts has joined #openstack-nova10:21
*** ttsiouts has quit IRC10:26
*** dpawlik has quit IRC10:28
*** brinzhang_ has joined #openstack-nova10:32
*** brinzhang has quit IRC10:35
*** mkrai_ has quit IRC10:39
*** mkrai_ has joined #openstack-nova10:40
*** tbachman has quit IRC10:43
*** markvoelker has joined #openstack-nova10:50
*** yedongcan has joined #openstack-nova10:51
*** ttsiouts has joined #openstack-nova10:53
*** markvoelker has quit IRC10:56
*** ttsiouts has quit IRC10:58
*** dpawlik has joined #openstack-nova11:01
*** brinzhang has joined #openstack-nova11:03
*** awalende has quit IRC11:05
*** brinzhang_ has quit IRC11:06
*** awalende has joined #openstack-nova11:06
*** maciejjozefczyk has quit IRC11:07
openstackgerritwangfaxin proposed openstack/nova master: Fix misspell word  https://review.opendev.org/68890111:07
*** ociuhandu has joined #openstack-nova11:07
*** awalende has quit IRC11:10
*** mkrai_ has quit IRC11:10
*** yedongcan has quit IRC11:12
*** ratailor has joined #openstack-nova11:20
*** maciejjozefczyk has joined #openstack-nova11:21
*** awalende has joined #openstack-nova11:21
*** awalende has quit IRC11:25
*** ttsiouts has joined #openstack-nova11:25
*** ttsiouts has quit IRC11:26
*** ttsiouts has joined #openstack-nova11:26
*** dpawlik has quit IRC11:28
*** rcernin has joined #openstack-nova11:30
*** ratailor has quit IRC11:30
*** dpawlik has joined #openstack-nova11:30
*** brinzhang_ has joined #openstack-nova11:33
*** brinzhang has quit IRC11:36
*** markvoelker has joined #openstack-nova11:44
*** dave-mccowan has joined #openstack-nova11:50
*** markvoelker has quit IRC11:55
*** nanzha has quit IRC11:55
*** sapd1 has joined #openstack-nova12:00
*** mkrai_ has joined #openstack-nova12:01
*** brinzhang has joined #openstack-nova12:03
*** ivve has quit IRC12:03
*** tbachman has joined #openstack-nova12:05
*** brinzhang_ has quit IRC12:06
*** markvoelker has joined #openstack-nova12:10
*** Luzi has quit IRC12:11
*** larainema has quit IRC12:11
*** sapd1 has quit IRC12:12
*** ivve has joined #openstack-nova12:18
*** priteau has quit IRC12:22
*** Luzi has joined #openstack-nova12:27
*** tbachman has quit IRC12:31
*** dviroel has joined #openstack-nova12:31
*** tbachman has joined #openstack-nova12:33
*** awalende has joined #openstack-nova12:34
*** nweinber__ has joined #openstack-nova12:36
*** brinzhang_ has joined #openstack-nova12:41
*** CeeMac has quit IRC12:41
*** brinzhang_ has quit IRC12:42
*** brinzhang_ has joined #openstack-nova12:42
*** brinzhang_ has quit IRC12:42
*** brinzhang_ has joined #openstack-nova12:43
*** brinzhang_ has quit IRC12:43
*** mkrai_ has quit IRC12:43
*** brinzhang has quit IRC12:44
*** liuyulong has joined #openstack-nova12:49
openstackgerritBalazs Gibizer proposed openstack/nova master: Mask the token used to allow access to consoles  https://review.opendev.org/22062212:53
*** eharney has joined #openstack-nova12:56
*** Luzi has quit IRC13:02
*** ociuhandu has quit IRC13:06
*** derekh has joined #openstack-nova13:09
*** mriedem has joined #openstack-nova13:15
*** dpawlik has quit IRC13:15
*** bauzas has quit IRC13:21
*** bauzas has joined #openstack-nova13:28
mriedembauzas: another scenario where we could leak allocations https://bugs.launchpad.net/nova/+bug/184834313:29
openstackLaunchpad bug 1848343 in OpenStack Compute (nova) "MigrationTask rollback can leak allocations for a deleted server" [Undecided,Triaged]13:29
mriedemdoes your audit command detect the scenario that a resource provider has VCPU allocations but the instance consumer does not exist?13:29
dansmithmriedem: guh, sorry about those last few issues, but thanks for fixing them13:30
mriedemnp13:32
mriedemi reckon i'll spend some time today to write a recreate test for same-cell resize for that latent bug above13:32
*** davee_ has joined #openstack-nova13:34
*** davee__ has joined #openstack-nova13:35
*** dpawlik has joined #openstack-nova13:35
*** udesale has quit IRC13:37
*** udesale has joined #openstack-nova13:37
*** ociuhandu has joined #openstack-nova13:38
*** ociuhandu has quit IRC13:43
*** markvoelker has quit IRC13:46
openstackgerritHuachang Wang proposed openstack/nova master: [WIP] To create single NUMA node instance in function '_get_numa_topology_auto'  https://review.opendev.org/68893213:48
openstackgerritHuachang Wang proposed openstack/nova master: [WIP] Assign and track instance pinning cpu through 'cpu_pinning' field  https://review.opendev.org/68893313:48
openstackgerritHuachang Wang proposed openstack/nova master: [WIP] Add a new instance CPU allocation policy: mixed  https://review.opendev.org/68893413:48
openstackgerritHuachang Wang proposed openstack/nova master: [WIP] virt/libvirt: Get host pin cpuset according instance  cpu_pinning  https://review.opendev.org/68893513:48
openstackgerritHuachang Wang proposed openstack/nova master: [WIP] metadata: export the vCPU IDs that are pinning on the host CPUs  https://review.opendev.org/68893613:48
*** mkrai_ has joined #openstack-nova13:50
*** jawad_axd has quit IRC13:51
*** markvoelker has joined #openstack-nova13:56
*** jangutter_ has joined #openstack-nova13:57
*** rcernin has quit IRC13:57
KeithMnemonicfrickler i will let you know what i find out. so far it seems some sort of access issue with the backend rbd disk during an evacuation13:57
*** tbachman has quit IRC13:58
*** gbarros has joined #openstack-nova13:59
*** jangutter_ has quit IRC14:00
*** jangutter has quit IRC14:00
*** jangutter has joined #openstack-nova14:01
*** dpawlik has quit IRC14:05
*** jawad_axd has joined #openstack-nova14:05
openstackgerritDan Smith proposed openstack/python-novaclient master: Add aggregate-cache-images command and client routines  https://review.opendev.org/68714114:06
*** tssurya has joined #openstack-nova14:07
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: Microversion 2.80: Add user_id/project_id to migration-list API  https://review.opendev.org/67502314:07
*** liuyulong has quit IRC14:08
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: Add aggregate-cache-images command and client routines  https://review.opendev.org/68714114:09
bauzasmriedem: sorry, got some network issues last hour, just saw your ping14:15
* bauzas looks at the bug14:15
*** derekh has quit IRC14:15
*** derekh has joined #openstack-nova14:15
bauzasmriedem: FWIW, what I do with the audit command is that I look at all the RPs and then look at all the allocations14:16
bauzasif some allocation is not either related to an instance or a migration, I tell it14:16
*** mdbooth has quit IRC14:17
*** mdbooth has joined #openstack-nova14:18
*** ociuhandu has joined #openstack-nova14:19
mriedemwith an option to delete the allocation?14:20
bauzasyup14:21
bauzasmriedem: I still have an issue with some placement call because I need to pass a microversion14:21
bauzasbut for the moment, I'm updating some unittests14:21
mriedemdo you filter the resource providers at all based on inventory or trait to know they are compute nodes, e.g. GET /resource_providers?resources=VCPU:114:22
mriedemto like weed out things we won't care about14:22
mriedemMEMORY_MB would probably be more appropriate given PCPU could complicate things now if a node never reports VCPU inventory14:23
*** mgoddard has quit IRC14:28
*** mgoddard has joined #openstack-nova14:30
*** spatel has joined #openstack-nova14:30
bauzasmriedem: we get all allocations but we skip those not related to nova RCs https://review.opendev.org/#/c/670112/7/nova/cmd/manage.py@279414:34
*** ociuhandu has quit IRC14:35
*** mkrai_ has quit IRC14:38
*** mkrai__ has joined #openstack-nova14:38
*** jangutter has quit IRC14:39
*** jangutter has joined #openstack-nova14:40
openstackgerritDan Smith proposed openstack/nova master: Fix up some feedback on image precache support  https://review.opendev.org/68817214:40
openstackgerritDan Smith proposed openstack/nova master: WIP: Add image precaching docs for aggregates  https://review.opendev.org/68734814:40
openstackgerritDan Smith proposed openstack/nova master: WIP: Log some stats for image pre-cache  https://review.opendev.org/68817314:40
*** TxGirlGeek has joined #openstack-nova14:40
*** awalende has quit IRC14:42
openstackgerritMerged openstack/nova-specs master: Add 'Feature Liaison' spec process  https://review.opendev.org/68585714:43
*** awalende has joined #openstack-nova14:43
*** jangutter_ has joined #openstack-nova14:44
*** spatel has quit IRC14:45
*** mrch_ has joined #openstack-nova14:46
mriedembauzas: i'm saying we could optimize here https://review.opendev.org/#/c/670112/7/nova/cmd/manage.py@2921 by filtering out providers that aren't going to be compute nodes14:46
mriedemi.e. providers that don't provide MEMORY_MB inventory14:47
mriedemalthough,14:47
mriedemi guess that would break ironic node providers...14:47
*** mrch_ has quit IRC14:47
mriedemso nevermind14:47
*** jangutter has quit IRC14:47
*** awalende has quit IRC14:47
*** jawad_axd has quit IRC14:48
bauzasmriedem: well, maybe we could use consumer types once it's done14:48
*** mrch_ has joined #openstack-nova14:48
*** awalende has joined #openstack-nova14:48
bauzasie. asking for RPs having some "Nova" consumer type14:48
*** mrch_ has quit IRC14:50
*** ociuhandu has joined #openstack-nova14:51
*** priteau has joined #openstack-nova14:51
*** ociuhandu has quit IRC14:52
*** awalende has quit IRC14:52
*** ociuhandu has joined #openstack-nova14:53
*** markvoelker has quit IRC14:54
*** ociuhandu has quit IRC14:54
*** markvoelker has joined #openstack-nova14:54
*** ociuhandu has joined #openstack-nova14:54
*** munimeha1 has joined #openstack-nova14:59
*** jangutter has joined #openstack-nova14:59
*** xek_ has joined #openstack-nova15:02
*** jangutter_ has quit IRC15:03
*** xek__ has quit IRC15:05
*** ivve has quit IRC15:05
*** mkrai__ has quit IRC15:07
*** panda|drappt is now known as panda15:09
*** maciejjozefczyk has quit IRC15:10
mriedembauzas: not that i was actively reviewing it, but approving a policy change like https://review.opendev.org/#/c/685857/ without at least the majority of the core team acking it seems wrong15:13
*** trident has quit IRC15:13
mriedemi guess my fault for not being more involved15:13
efriedhttps://www.zdnet.com/article/the-openstack-train-keeps-chugging-on/  Nova features are mentioned (albeit pretty inaccurately)15:13
mriedemi heard there is a cyborg spec!15:14
mriedemthe marketing machine does it's job again15:14
mriedem*its15:14
efriedikr15:14
mriedemi guess that was because of https://releases.openstack.org/train/highlights.html#cyborg-accelerator-life-cycle-management15:15
*** trident has joined #openstack-nova15:17
efriedI guess now that we've made such a big deal about SEV, AMD had better find someone to support it. I like how they plastered SUSE's departure all over the place without connecting the two at all.15:22
*** dpawlik has joined #openstack-nova15:27
*** gyee has joined #openstack-nova15:28
*** dpawlik has quit IRC15:31
*** ociuhandu has quit IRC15:33
mriedem"we" :)15:34
dansmithugh.15:36
*** ttsiouts has quit IRC15:39
*** ttsiouts has joined #openstack-nova15:40
dansmithmriedem: a couple questions on your reviews from that client patch15:40
dansmithif you please15:40
*** damien_r has quit IRC15:41
*** tssurya has quit IRC15:43
*** aluria has joined #openstack-nova15:43
*** ttsiouts has quit IRC15:44
*** maciejjozefczyk has joined #openstack-nova15:46
*** dpawlik has joined #openstack-nova15:47
*** maciejjozefczyk is now known as mjozefcz|afk15:47
*** jawad_axd has joined #openstack-nova15:47
bauzasmriedem: I feel bad then, my apologies15:48
mriedemdansmith: replied15:48
bauzasmriedem: we can honestly revert the change for asking at least for more15:48
bauzasmriedem: do you want me to provide the revert change (and then the revert of revert) ?15:49
bauzasefried: WFY ?15:49
mriedemno15:49
mriedemi'd say if someone on the core team has a stink about what was merged we can amend later15:49
bauzasok, I can write a ML email to mention it got merged then15:50
mriedemsure15:50
bauzasand ask for people to provide some change if they disagree with some stuff15:50
bauzasok, doing15:50
bauzasmriedem: and again, apologies15:50
bauzasFWIW, those were my notes for the +2 "OK, after commenting a lot about this spec process, I think I'm quite +2 with it, even if I could still have some concerns. Given it's important to have a consensus about this, I think it's more important to just accept it and then providing other follow-ups if there would be some points."15:51
*** jawad_axd has quit IRC15:52
*** ociuhandu has joined #openstack-nova15:55
*** ociuhandu has quit IRC15:56
*** ociuhandu has joined #openstack-nova15:56
efriedbauzas: I already wrote an email mentioning it's merged.16:00
bauzasefried: ack16:00
efriedhttp://lists.openstack.org/pipermail/openstack-discuss/2019-October/010158.html16:01
efriedLet's be honest, if we waited for a majority of cores, we would be waiting forever. Not because they necessarily object, but because they don't care.16:02
mriedemthat's why i said it's fine to just amend if people care or take issue with it at this point16:03
efried++16:03
*** gbarros has quit IRC16:03
*** lpetrut has quit IRC16:04
*** TxGirlGeek has quit IRC16:08
*** tesseract has quit IRC16:08
*** xek__ has joined #openstack-nova16:08
*** gbarros has joined #openstack-nova16:09
*** xek_ has quit IRC16:10
*** macz has joined #openstack-nova16:14
*** sapd1 has joined #openstack-nova16:16
*** gbarros has quit IRC16:19
*** gbarros has joined #openstack-nova16:20
mriedemdansmith: replied on https://review.opendev.org/#/c/688832/ - that's just a wip right now that i pushed late last night, it's definitely not in final form,16:21
mriedemi'm working on a recreate test for the latent same-cell resize bug16:21
*** mjozefcz|afk has quit IRC16:21
openstackgerritEric Fried proposed openstack/os-traits master: Add COMPUTE_NODE trait  https://review.opendev.org/68896916:22
*** jawad_axd has joined #openstack-nova16:24
melwittmriedem: question on this in case you didn't see https://review.opendev.org/68742716:26
dansmithmriedem: aight16:28
*** psachin has quit IRC16:29
dansmithmriedem: so on this object-or-id thing,16:30
dansmithmriedem: if I take either are you expecting me to validate the uuid if it was given, or just pass that in the body? Like, leave the actually-check-with-glance part in the CLI shell, and just make the python API able to do either, but not validate?16:31
*** TxGirlGeek has joined #openstack-nova16:32
*** gbarros has quit IRC16:34
dansmithmriedem: I guess based on the other examples, just include and not validate16:37
mriedemthe cli would get the image from glance based on name or id,16:37
mriedemthe python api binding method would just pass through16:37
dansmithyeah16:38
mriedemthat's how other api methods like create, rebuild, rescue work16:38
dansmithI'm not a fan, but consistency is more important for usre16:38
*** markvoelker has quit IRC16:39
mriedemif going directly to the api we'll barf and return a 400 if the image doesn't exist16:39
mriedemso i think we're ok16:39
*** udesale has quit IRC16:40
dansmithyeah16:40
*** gbarros has joined #openstack-nova16:42
mriedemmelwitt: replied, thanks16:45
melwittack thanks16:46
openstackgerritDan Smith proposed openstack/python-novaclient master: Add aggregate-cache-images command and client routines  https://review.opendev.org/68714116:46
*** markvoelker has joined #openstack-nova16:49
*** rpittau is now known as rpittau|afk16:50
*** ociuhandu_ has joined #openstack-nova16:51
*** dtantsur is now known as dtantsur|afk16:51
*** ociuhandu has quit IRC16:54
*** ociuhandu_ has quit IRC16:58
openstackgerritEric Fried proposed openstack/nova master: Always trait the compute node RP with COMPUTE_NODE  https://review.opendev.org/68897917:00
*** derekh has quit IRC17:01
*** markvoelker has quit IRC17:01
*** tbachman has joined #openstack-nova17:09
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1848343  https://review.opendev.org/68898017:11
openstackbug 1848343 in OpenStack Compute (nova) "MigrationTask rollback can leak allocations for a deleted server" [Medium,Triaged] https://launchpad.net/bugs/184834317:11
mriedemdansmith: here is a pretty simple recreate of that latent allocation leak bug ^17:11
dansmithschwing17:12
*** markvoelker has joined #openstack-nova17:13
*** markvoelker has quit IRC17:13
*** markvoelker has joined #openstack-nova17:14
*** gbarros has quit IRC17:15
mriedemthis is your reward https://www.youtube.com/watch?v=vKDx_66nnAw17:16
efriedye gods, save me from SRV17:17
efried<eyeroll>17:17
*** jangutter has quit IRC17:17
*** ociuhandu has joined #openstack-nova17:18
*** munimeha1 has quit IRC17:18
dansmithI will say17:19
dansmithI didn't think you could get too much SRV, but living in Austin made it clear that you can17:19
efriedexactly17:19
dansmithwhich is too bad, because SRV is awesome and Austin just kinda messes that up17:20
efriedbecause you not only get SRV, you get every freaking SRV clone ever17:20
efriedthough I've never been a fan of that style of blues personally. Way too homogeneous.17:20
*** gbarros has joined #openstack-nova17:20
efriedbut SRV+clones took it from meh to active dislike17:20
melwittsame thing in houston, I grew to hate SRV from oversaturation17:22
*** ociuhandu has quit IRC17:23
*** sapd1 has quit IRC17:27
*** priteau has quit IRC17:27
*** ociuhandu has joined #openstack-nova17:30
*** ociuhandu has quit IRC17:35
*** ricolin has quit IRC17:36
*** jangutter has joined #openstack-nova17:49
* mriedem digs up some minnesota blues17:51
mriedemit's all about hotdish17:51
mriedemand bad sports teams17:51
*** jangutter has quit IRC17:53
*** spsurya has quit IRC17:58
openstackgerritMerged openstack/python-novaclient master: Microversion 2.80: Add user_id/project_id to migration-list API  https://review.opendev.org/67502317:59
*** dklyle has quit IRC18:00
*** david-lyle has joined #openstack-nova18:00
openstackgerritGhanshyam Mann proposed openstack/nova-specs master: Re-propose policy-defaults-refresh spec for Ussuri  https://review.opendev.org/68605818:01
*** davee_ has quit IRC18:01
KeithMnemonicfrickler I will let you know what I find out. my guess is it is some config issue in this one env, as so far i can not reproduce it18:01
gmannmelwitt:   I added you as 'Feature Liaison' in policy spec re-proposed for U. https://review.opendev.org/#/c/686058/18:01
KeithMnemonicah did not see i posted already, too much going on today18:01
KeithMnemonicif anyone has time to please review https://review.opendev.org/683008 i appreciate it18:02
melwittgmann: ok, thanks18:02
gmannmelwitt: I will rebase the code patches once the spec is merged. looking for your review on this re-proposed spec.18:03
melwittack18:03
gmannthanks18:03
openstackgerritMatt Riedemann proposed openstack/nova master: Add live migration recreate test for bug 1848343  https://review.opendev.org/68899418:05
openstackbug 1848343 in OpenStack Compute (nova) "MigrationTask rollback can leak allocations for a deleted server" [Medium,Triaged] https://launchpad.net/bugs/184834318:05
artomgmann, since you're around, gentle poke, re: whitebox spec: https://review.opendev.org/#/c/656890/18:05
gmannartom: thanks for reminder. I will surly review this week, (as done for train release things.)18:06
*** tbachman has quit IRC18:14
mriedemdansmith: do you want to fix this nit otherwise i'm +2 https://review.opendev.org/#/c/687141/18:18
dansmithmriedem: oh sure, just a sec18:19
openstackgerritDan Smith proposed openstack/python-novaclient master: Add aggregate-cache-images command and client routines  https://review.opendev.org/68714118:19
dansmithmriedem: spanks ^18:20
mriedemhow did you know i was wearing those?18:20
mriedemoh s/k/x/18:20
dansmithI think you mean Spanx(tm)18:20
dansmithI was saying18:20
dansmith"spanks for catching that"18:20
mriedemyeah i know18:21
mriedemi just wanted to make a spanx joke18:21
dansmithnoted18:21
*** tbachman has joined #openstack-nova18:21
*** jangutter has joined #openstack-nova18:22
*** dpawlik has quit IRC18:30
*** dpawlik has joined #openstack-nova18:32
*** ralonsoh has quit IRC18:37
*** dpawlik has quit IRC18:39
mriedemargh,18:44
mriedemInstance.save(expected_state_state=)18:44
mriedemthat's a tuple or lits,18:44
mriedem*list18:44
mriedemthe singular in the name *always* screws me up18:44
mriedemwe should maybe guard against that in the save method18:44
dansmithexcept that it takes None too, IIRC18:44
mriedemyeah,18:44
mriedemso if not None, assert it's an iterable18:44
mriedemhttps://review.opendev.org/#/c/627891/63/nova/conductor/tasks/cross_cell_migrate.py@42318:45
efriedmelwitt: in case you haven't been following closely, note that we no longer do fast approvals for unchanged spec reproposals.18:46
melwittefried: I had read that in one of the emails, then forgot about it, so thanks for reminding18:47
mriedemyeah we have several places where we pass a string to expected_task_state18:50
artomexpected_attrs all over again18:53
mriedemhttps://bugs.launchpad.net/nova/+bug/184837318:53
openstackLaunchpad bug 1848373 in OpenStack Compute (nova) "Instance.save(expected_task_state=) is passed string in many locations" [Medium,Triaged]18:53
melwittdynamic types ftw18:54
mriedemback in 2012 the db api handled it.... https://review.opendev.org/#/c/12222/5/nova/db/sqlalchemy/api.py18:57
efriedgmann: was os-cells a cellsv1 thing?18:57
mriedemyes18:57
efriedthx18:58
gmannyeah18:58
melwitthah, I wonder why that was removed18:58
mriedemhttps://review.opendev.org/#/c/202593/18:59
mriedemsince liberty18:59
mriedemso i don't even know if expected_task_state is even enforced in the DB API anymore18:59
mriedemdansmith: ^ does that jive with you?18:59
mriedemhttps://github.com/openstack/nova/blob/1a226aaa9e8c969ddfdfe198c36f7966b1f692f3/nova/db/sqlalchemy/api.py#L2783 is definitely no longer true19:00
* melwitt brain has failed processing19:00
mriedemwtf, that expected= kwarg in instance_update_and_get_original isn't even used anywhere19:01
dansmithmriedem: I don't think I know anything about that change19:01
mriedemi remember mdbooth pushing for it way back when19:02
dansmithI remember talking about the comnpare-and-swap thing19:02
mriedemand i reverted the first attempt https://review.opendev.org/#/c/201771/19:03
melwitttime for another revert19:05
melwittJUST KIDDING19:05
mriedemdon't tempt me19:05
mriedemoh i see where expected_task_state is used19:07
mriedemtricky19:07
mriedemhttps://github.com/openstack/nova/blob/1a226aaa9e8c969ddfdfe198c36f7966b1f692f3/nova/db/sqlalchemy/api.py#L285019:07
dansmith# Coerce all single values to singleton lists19:09
mriedemyeah i see that too19:09
mriedemi'll abandon the bug since even though we're using the object interface incorrectly the db api is hiding it19:10
mriedemthe expected= kwarg is still never used from anywhere19:11
mriedemso it just adds to confusion19:12
*** tbachman has quit IRC19:17
openstackgerritMatt Riedemann proposed openstack/nova master: Add compute side revert allocation test for bug 1848343  https://review.opendev.org/68901319:25
openstackbug 1848343 in OpenStack Compute (nova) "Reverting migration-based allocations leaks allocations if the server is deleted" [Medium,Triaged] https://launchpad.net/bugs/184834319:25
mriedemheh, just got a random code review comment from someone on a merged commit in github,19:27
mriedemi appreciate the stat padding but19:28
*** jawad_axd has quit IRC19:30
mriedemstable/train is open so i've start +2ing things we were holding https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/train19:38
mriedem*started19:38
mriedembauzas: since you brought up queens reviews last week maybe you can go through some of these tomorrow https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/queens+label:Code-Review=119:39
openstackgerritAndreas Jaeger proposed openstack/nova master: Switch to opensuse-15 nodeset  https://review.opendev.org/68902019:42
*** lbragsta_ has joined #openstack-nova19:48
mriedemefried: some rambling in https://review.opendev.org/#/c/687416/ if it means anything to you, probably not worth pursuing19:51
*** markvoelker has quit IRC19:58
*** markvoelker has joined #openstack-nova19:58
efriedmriedem: separate pursuit though, yah?20:07
efriedI was also considering making False the default throughout, since that's the more "modern" thing, but that would obv be a separate change as well.20:08
mriedemefried: yeah20:08
*** igordc has joined #openstack-nova20:15
* efried chauffeurs20:16
*** efried is now known as efried_afk20:16
*** pcaruana has quit IRC20:28
*** tbachman has joined #openstack-nova20:28
KeithMnemonicfrickler: we found the issue,  they needed -on-shared-storage.20:44
*** nweinber__ has quit IRC21:08
*** efried_afk is now known as efried21:19
*** igordc has quit IRC21:19
*** igordc has joined #openstack-nova21:29
openstackgerritMatt Riedemann proposed openstack/nova master: Delete source allocations in move_allocations if target no longer exists  https://review.opendev.org/68904921:37
*** jangutter has quit IRC21:40
*** mriedem is now known as mriedem_afk21:46
*** takashin has joined #openstack-nova21:51
*** slaweq has quit IRC22:00
*** TxGirlGeek has quit IRC22:04
openstackgerritTakashi NATSUME proposed openstack/nova master: Update keypairs in saving an instance object  https://review.opendev.org/68304322:05
*** TxGirlGeek has joined #openstack-nova22:05
*** TxGirlGeek has quit IRC22:05
openstackgerritTakashi NATSUME proposed openstack/nova master: Move Destination object tests to their own test class  https://review.opendev.org/68301722:05
*** brault has quit IRC22:12
*** brault has joined #openstack-nova22:12
*** jamesdenton has quit IRC22:13
*** jamesden_ has joined #openstack-nova22:13
*** markvoelker has quit IRC22:14
*** lbragsta_ has quit IRC22:26
*** TxGirlGeek has joined #openstack-nova22:30
*** david-lyle has quit IRC22:34
*** xek__ has quit IRC22:35
*** dklyle has joined #openstack-nova22:43
*** macz has quit IRC22:56
*** dviroel has quit IRC22:57
*** bbowen has quit IRC23:02
*** gyee has quit IRC23:16
openstackgerritMerged openstack/nova stable/train: Fix unit of hw_rng:rate_period  https://review.opendev.org/68808323:24
*** tkajinam has joined #openstack-nova23:31
*** TxGirlGeek has quit IRC23:33
*** lbragsta_ has joined #openstack-nova23:35
*** nweinber__ has joined #openstack-nova23:41
*** lbragsta_ has quit IRC23:45
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Add functional test for migration-list in v2.80  https://review.opendev.org/68863523:52
*** nweinber__ has quit IRC23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!