*** beekneemech has joined #openstack-nova | 00:06 | |
*** bnemec has quit IRC | 00:08 | |
*** takashin has joined #openstack-nova | 00:11 | |
*** beekneemech has quit IRC | 00:12 | |
*** bnemec has joined #openstack-nova | 00:14 | |
openstackgerrit | Merged openstack/nova stable/queens: Fix rebuild of baremetal instance when vm_state is ERROR https://review.opendev.org/680873 | 00:18 |
---|---|---|
*** markvoelker has joined #openstack-nova | 00:49 | |
*** dpawlik has joined #openstack-nova | 00:53 | |
*** dpawlik has quit IRC | 00:58 | |
*** Liang__ has joined #openstack-nova | 01:02 | |
*** nanzha has joined #openstack-nova | 01:06 | |
*** sapd1 has joined #openstack-nova | 01:09 | |
*** nweinber has quit IRC | 01:11 | |
*** Liang__ is now known as LiangFang | 01:19 | |
*** tbachman_ has joined #openstack-nova | 01:21 | |
*** tbachman has quit IRC | 01:22 | |
*** tbachman_ is now known as tbachman | 01:22 | |
*** mkrai_ has joined #openstack-nova | 01:24 | |
*** igordc has quit IRC | 01:25 | |
*** sapd1 has quit IRC | 01:39 | |
*** mkrai_ has quit IRC | 01:55 | |
*** guozijn has joined #openstack-nova | 01:58 | |
*** artom has quit IRC | 01:59 | |
*** artom has joined #openstack-nova | 01:59 | |
*** artom has joined #openstack-nova | 02:00 | |
*** gbarros has joined #openstack-nova | 02:02 | |
*** Garyx_ has joined #openstack-nova | 02:17 | |
*** Garyx has quit IRC | 02:19 | |
*** sapd1 has joined #openstack-nova | 02:37 | |
*** ricolin_ has joined #openstack-nova | 02:51 | |
*** dpawlik has joined #openstack-nova | 02:54 | |
*** dpawlik has quit IRC | 02:58 | |
*** sapd1 has quit IRC | 03:06 | |
*** dave-mccowan has quit IRC | 03:21 | |
*** jangutter has joined #openstack-nova | 03:22 | |
*** jangutter has quit IRC | 03:26 | |
*** dviroel has quit IRC | 03:28 | |
*** psachin has joined #openstack-nova | 03:37 | |
*** gbarros has quit IRC | 04:07 | |
*** guozijn has quit IRC | 04:33 | |
*** igordc has joined #openstack-nova | 04:35 | |
*** igordc has quit IRC | 04:35 | |
*** igordc has joined #openstack-nova | 04:35 | |
openstackgerrit | Merged openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140 | 04:41 |
*** ratailor has joined #openstack-nova | 04:48 | |
*** Luzi has joined #openstack-nova | 04:50 | |
*** dpawlik has joined #openstack-nova | 04:55 | |
*** guozijn has joined #openstack-nova | 04:55 | |
*** adriant has joined #openstack-nova | 04:57 | |
*** dpawlik has quit IRC | 04:59 | |
*** igordc has quit IRC | 05:05 | |
openstackgerrit | Merged openstack/nova master: Fix up some feedback on image precache support https://review.opendev.org/688172 | 05:06 |
*** dpawlik has joined #openstack-nova | 05:15 | |
*** awalende has joined #openstack-nova | 05:18 | |
*** tetsuro has quit IRC | 05:18 | |
*** awalende has quit IRC | 05:22 | |
*** mdbooth has quit IRC | 05:35 | |
*** mdbooth has joined #openstack-nova | 05:36 | |
*** maciejjozefczyk has joined #openstack-nova | 05:50 | |
*** tetsuro has joined #openstack-nova | 06:00 | |
*** tetsuro has quit IRC | 06:01 | |
*** jawad_axd has joined #openstack-nova | 06:09 | |
*** jawad_axd has quit IRC | 06:13 | |
*** jawad_axd has joined #openstack-nova | 06:13 | |
*** tetsuro has joined #openstack-nova | 06:15 | |
*** dpawlik has quit IRC | 06:20 | |
*** dpawlik has joined #openstack-nova | 06:27 | |
*** slaweq has joined #openstack-nova | 06:30 | |
*** ociuhandu has joined #openstack-nova | 06:31 | |
*** nanzha has quit IRC | 06:31 | |
*** ociuhandu has quit IRC | 06:35 | |
*** nanzha has joined #openstack-nova | 06:37 | |
*** ratailor has quit IRC | 06:49 | |
*** sapd1 has joined #openstack-nova | 06:50 | |
*** trident has quit IRC | 07:00 | |
*** trident has joined #openstack-nova | 07:04 | |
openstackgerrit | Huachang Wang proposed openstack/nova master: [WIP] To create single NUMA node instance in function '_get_numa_topology_auto' https://review.opendev.org/688932 | 07:05 |
*** lpetrut has joined #openstack-nova | 07:05 | |
*** udesale has joined #openstack-nova | 07:08 | |
openstackgerrit | Huachang Wang proposed openstack/nova master: [WIP] Assign and track instance pinning cpu through 'cpu_pinning' field https://review.opendev.org/688933 | 07:09 |
openstackgerrit | Huachang Wang proposed openstack/nova master: [WIP] Add a new instance CPU allocation policy: mixed https://review.opendev.org/688934 | 07:11 |
openstackgerrit | Huachang Wang proposed openstack/nova master: [WIP] virt/libvirt: Get host pin cpuset according instance cpu_pinning https://review.opendev.org/688935 | 07:11 |
*** ratailor has joined #openstack-nova | 07:12 | |
*** tetsuro has quit IRC | 07:13 | |
*** tetsuro has joined #openstack-nova | 07:20 | |
*** tesseract has joined #openstack-nova | 07:22 | |
*** awalende has joined #openstack-nova | 07:25 | |
*** pcaruana has joined #openstack-nova | 07:26 | |
bauzas | morning fellows | 07:28 |
*** ricolin_ is now known as ricolin | 07:30 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Pass RequestContext to oslo_policy https://review.opendev.org/674038 | 07:41 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add test coverage of existing os-services policies https://review.opendev.org/669181 | 07:43 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add test coverage of existing os-agents policies https://review.opendev.org/669578 | 07:43 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Introduce scope_types in os-services https://review.opendev.org/645427 | 07:44 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles and mapping in policy base class https://review.opendev.org/645452 | 07:44 |
*** tssurya has joined #openstack-nova | 07:45 | |
*** brinzhang has joined #openstack-nova | 07:47 | |
*** ralonsoh has joined #openstack-nova | 07:51 | |
*** jangutter has joined #openstack-nova | 07:54 | |
*** jangutter_ has joined #openstack-nova | 07:54 | |
*** brinzhang_ has joined #openstack-nova | 07:56 | |
*** jangutter has quit IRC | 07:58 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Pass RequestContext to oslo_policy https://review.opendev.org/674038 | 07:59 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add test coverage of existing os-services policies https://review.opendev.org/669181 | 07:59 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Introduce scope_types in os-services https://review.opendev.org/645427 | 07:59 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles and mapping in policy base class https://review.opendev.org/645452 | 07:59 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add policy deprecation fixture and Suppress warnings in tests https://review.opendev.org/676670 | 07:59 |
*** brinzhang has quit IRC | 07:59 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Pass RequestContext to oslo_policy https://review.opendev.org/674038 | 08:01 |
*** rpittau|afk is now known as rpittau | 08:01 | |
*** tetsuro has quit IRC | 08:02 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add test coverage of existing os-services policies https://review.opendev.org/669181 | 08:03 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Introduce scope_types in os-services https://review.opendev.org/645427 | 08:03 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | 08:04 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles and mapping in policy base class https://review.opendev.org/645452 | 08:07 |
*** xek__ has joined #openstack-nova | 08:07 | |
*** brinzhang has joined #openstack-nova | 08:16 | |
*** tssurya has quit IRC | 08:17 | |
*** brinzhang_ has quit IRC | 08:19 | |
*** ttsiouts has joined #openstack-nova | 08:23 | |
*** ratailor_ has joined #openstack-nova | 08:26 | |
*** ratailor has quit IRC | 08:28 | |
*** tssurya has joined #openstack-nova | 08:30 | |
*** takashin has left #openstack-nova | 08:30 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add policy deprecation fixture and Suppress warnings in tests https://review.opendev.org/676670 | 08:30 |
*** damien_r has joined #openstack-nova | 08:33 | |
*** priteau has joined #openstack-nova | 08:36 | |
*** hamzy_ has joined #openstack-nova | 08:41 | |
*** hamzy has quit IRC | 08:43 | |
*** guozijn has quit IRC | 08:44 | |
*** guozijn has joined #openstack-nova | 08:46 | |
*** brinzhang_ has joined #openstack-nova | 08:49 | |
*** brinzhang has quit IRC | 08:53 | |
*** ileixe has joined #openstack-nova | 08:58 | |
*** ileixe has left #openstack-nova | 08:59 | |
*** sapd1 has quit IRC | 09:01 | |
*** brinzhang_ has quit IRC | 09:02 | |
*** dansmith has quit IRC | 09:07 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor rebuild_instance https://review.opendev.org/688419 | 09:14 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow evacuating server with port resource request https://review.opendev.org/688387 | 09:14 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable evacuation with qos ports https://review.opendev.org/688688 | 09:14 |
*** LiangFang has quit IRC | 09:19 | |
*** dansmith has joined #openstack-nova | 09:25 | |
*** dtantsur|afk is now known as dtantsur | 09:31 | |
*** dpawlik has quit IRC | 09:47 | |
*** ociuhandu has joined #openstack-nova | 09:47 | |
*** ttsiouts has quit IRC | 09:51 | |
*** ttsiouts has joined #openstack-nova | 09:51 | |
*** sapd1 has joined #openstack-nova | 09:53 | |
openstackgerrit | Matthew Booth proposed openstack/nova master: Functional test for UnexpectedDeletingTaskStateError https://review.opendev.org/689278 | 09:55 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Unplug VIFs as part of cleanup of networks https://review.opendev.org/663382 | 09:55 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Fix incorrect vm and task state after build failure race https://review.opendev.org/689388 | 09:55 |
mdbooth | stephenfin sean-k-mooney: ^^^ | 09:55 |
*** ttsiouts has quit IRC | 09:56 | |
mdbooth | sean-k-mooney: The bottom of that stack is the new test base we discussed, btw, which also has a +1 from zuul. It would be useful to do the rounds on that one sooner rather than later. If you could rebase your patch on top of it so we can show it's useful that would be even better. | 10:00 |
sean-k-mooney | ya i can do that | 10:02 |
*** xek__ has quit IRC | 10:08 | |
*** dpawlik has joined #openstack-nova | 10:09 | |
*** xek has joined #openstack-nova | 10:11 | |
*** priteau has quit IRC | 10:13 | |
*** bnemec has quit IRC | 10:13 | |
*** bnemec has joined #openstack-nova | 10:15 | |
*** xek_ has joined #openstack-nova | 10:15 | |
*** xek has quit IRC | 10:16 | |
*** ygk_12345 has joined #openstack-nova | 10:28 | |
*** guozijn has quit IRC | 10:34 | |
*** cdent has joined #openstack-nova | 10:34 | |
*** xek_ has quit IRC | 10:38 | |
*** xek has joined #openstack-nova | 10:40 | |
ygk_12345 | hi all | 10:40 |
ygk_12345 | I am going thru the nova code on github. Van anyone point me to the exact code which says the libvirt to use qemu-kvm binary to launch a new process for the vm ? | 10:41 |
ygk_12345 | *Can anyone | 10:41 |
openstackgerrit | Merged openstack/nova master: Add support for 'initenv' elements https://review.opendev.org/667975 | 10:41 |
openstackgerrit | Matthew Booth proposed openstack/nova master: Unplug VIFs as part of cleanup of networks https://review.opendev.org/663382 | 10:43 |
openstackgerrit | Surya Seetharaman proposed openstack/nova master: Include removal of ephemeral backing files in the image cache manager https://review.opendev.org/689422 | 10:47 |
*** tbachman has quit IRC | 10:48 | |
*** zigo has quit IRC | 10:54 | |
*** ttsiouts has joined #openstack-nova | 10:59 | |
*** zigo has joined #openstack-nova | 11:04 | |
*** ratailor_ has quit IRC | 11:09 | |
*** dpawlik has quit IRC | 11:09 | |
*** tssurya has quit IRC | 11:15 | |
*** tkajinam has quit IRC | 11:16 | |
*** xek has quit IRC | 11:16 | |
*** tbachman has joined #openstack-nova | 11:16 | |
artom | ygk_12345, you mean you want to see a os.exec('qemu') in the code? You won't find it | 11:17 |
artom | ygk_12345, that's in the libvirt code itself | 11:17 |
ygk_12345 | @artom where exactly ? | 11:17 |
artom | ygk_12345, Nova just defines a domain with some XML | 11:17 |
artom | ygk_12345, I dunno, use grep, or ask in #libvirt | 11:17 |
artom | But mostly grep | 11:18 |
cdent | "But mostly grep" is my mantra | 11:18 |
ygk_12345 | @artom I have installed libvirt-python and used recursive grep but could not find the qemu-kvm pattern | 11:18 |
artom | Mostly Grep is my rap name | 11:18 |
cdent | oh, that's a good one | 11:19 |
artom | ygk_12345, that's because those are just the Python bindings for libvirt | 11:19 |
artom | ygk_12345, you want libvirtd | 11:19 |
artom | We form wht Unix Krew with Oh Snap it's Sed, Aw man it's Awk, and Who Let Perl In? | 11:21 |
artom | *the Unix | 11:21 |
ygk_12345 | @artom things at the OS level are weird but interesting | 11:24 |
cdent | ygk_12345: out of curiosity, why are you looking for the exec call? are you trying to solve a problem, exploring, something else? | 11:26 |
ygk_12345 | @cdent I am trying to understand and trace the vm create event through nova code :) | 11:27 |
cdent | I think what artom said is the key bit: nova creates some xml and gives it to libvirt, libvirt does the rest | 11:27 |
ygk_12345 | @cdent so its libvirt API internally | 11:28 |
* cdent nods | 11:28 | |
ygk_12345 | @cdent awesome | 11:28 |
ygk_12345 | @cdent u see no limits to curiosity until we hit the hardware | 11:29 |
cdent | :) | 11:29 |
cdent | plenty of room for curiosity on the hardware too | 11:29 |
ygk_12345 | @cdent appreciate Linus Torvalds for his first version of Linux | 11:30 |
* cdent does | 11:31 | |
*** cdent has quit IRC | 11:37 | |
*** ygk_12345 has quit IRC | 11:38 | |
*** awalende has quit IRC | 11:46 | |
*** awalende has joined #openstack-nova | 11:47 | |
*** awalende has quit IRC | 11:47 | |
*** awalende has joined #openstack-nova | 11:47 | |
*** cdent has joined #openstack-nova | 11:52 | |
*** dpawlik has joined #openstack-nova | 11:56 | |
*** nanzha has quit IRC | 12:02 | |
*** awalende has quit IRC | 12:03 | |
*** bbowen has quit IRC | 12:06 | |
*** cdent has quit IRC | 12:07 | |
*** mgariepy has joined #openstack-nova | 12:07 | |
*** awalende has joined #openstack-nova | 12:07 | |
*** awalende has quit IRC | 12:09 | |
*** nanzha has joined #openstack-nova | 12:10 | |
*** ygk_12345 has joined #openstack-nova | 12:10 | |
*** awalende has joined #openstack-nova | 12:11 | |
*** udesale has quit IRC | 12:13 | |
*** udesale has joined #openstack-nova | 12:16 | |
ygk_12345 | HI all ? | 12:17 |
ygk_12345 | which wsgi framework is used in nova ? | 12:17 |
sean-k-mooney | we kind of have our own https://github.com/openstack/nova/blob/master/nova/api/wsgi.py | 12:19 |
ygk_12345 | ok | 12:19 |
ygk_12345 | does it have a standalone web server ? | 12:20 |
sean-k-mooney | it can run in several different modes | 12:20 |
sean-k-mooney | it can run on the built in python webserver with eventlets | 12:21 |
sean-k-mooney | or you can run the wsgi service via mod_wsgi or uwsgi | 12:21 |
ygk_12345 | as of now when we install nova-api, in which mode deso it erun ? | 12:21 |
ygk_12345 | *does it | 12:22 |
sean-k-mooney | the nova api console script uses https://github.com/openstack/nova/blob/master/nova/cmd/api.py | 12:22 |
sean-k-mooney | which uses eventlet | 12:22 |
sean-k-mooney | but | 12:22 |
sean-k-mooney | if you use devstack | 12:22 |
sean-k-mooney | or most installers | 12:22 |
sean-k-mooney | the nova-api service is not calling that script | 12:22 |
*** tbachman has quit IRC | 12:22 | |
*** ociuhandu has quit IRC | 12:22 | |
sean-k-mooney | its running the service under uwsgi i think | 12:22 |
ygk_12345 | oh | 12:23 |
*** tbachman has joined #openstack-nova | 12:23 | |
*** ociuhandu has joined #openstack-nova | 12:23 | |
*** dtantsur is now known as dtantsur|brb | 12:24 | |
*** macz has joined #openstack-nova | 12:24 | |
sean-k-mooney | ygk_12345: cdent know more about this then i but we moved to testing with extrenal wsgi server implemenation a few release ago | 12:25 |
ygk_12345 | oh ok | 12:25 |
*** larsks has quit IRC | 12:25 | |
*** larsks has joined #openstack-nova | 12:32 | |
*** cdent has joined #openstack-nova | 12:33 | |
*** eharney has joined #openstack-nova | 12:44 | |
*** Luzi has quit IRC | 12:46 | |
*** bbowen has joined #openstack-nova | 12:53 | |
*** ttsiouts has quit IRC | 12:53 | |
*** ttsiouts has joined #openstack-nova | 12:54 | |
*** dviroel has joined #openstack-nova | 12:55 | |
*** ttsiouts has quit IRC | 12:58 | |
*** larsks has quit IRC | 13:00 | |
*** mgariepy has quit IRC | 13:00 | |
*** nweinber has joined #openstack-nova | 13:01 | |
*** larsks has joined #openstack-nova | 13:01 | |
*** ttsiouts has joined #openstack-nova | 13:10 | |
*** awalende has quit IRC | 13:12 | |
*** jangutter_ is now known as jangutter | 13:13 | |
*** jawad_axd has quit IRC | 13:15 | |
*** jawad_axd has joined #openstack-nova | 13:16 | |
*** mriedem has joined #openstack-nova | 13:16 | |
*** bbowen has quit IRC | 13:19 | |
*** ygk_12345 has quit IRC | 13:20 | |
*** jawad_ax_ has joined #openstack-nova | 13:21 | |
*** jawad_axd has quit IRC | 13:21 | |
*** ociuhandu has quit IRC | 13:25 | |
*** jawad_ax_ has quit IRC | 13:26 | |
*** ociuhandu has joined #openstack-nova | 13:26 | |
*** ociuhandu has quit IRC | 13:31 | |
*** bbowen has joined #openstack-nova | 13:31 | |
*** eharney has quit IRC | 13:33 | |
*** rcernin has quit IRC | 13:40 | |
KeithMnemonic | mriedem Good day, what is the best was to get some reviews on the patch you submitted for me ? https://review.opendev.org/#/c/683008/ | 13:42 |
*** ircuser-1 has quit IRC | 13:42 | |
*** ricolin has quit IRC | 13:43 | |
mriedem | KeithMnemonic: umm | 13:43 |
mriedem | you know we won't release that right? | 13:43 |
mriedem | since pike is in extended maintenance mode. we can merge stuff to pike but it won't be released. | 13:43 |
mriedem | so if you really need it you could probably just cherry pick it downstream | 13:44 |
*** larsks has quit IRC | 13:44 | |
*** larsks has joined #openstack-nova | 13:46 | |
*** mgariepy has joined #openstack-nova | 13:46 | |
KeithMnemonic | ok, i can do that, i was hoping it would get merged at least , is that not an option anymore even it if it is not released | 13:46 |
*** dave-mccowan has joined #openstack-nova | 13:46 | |
mriedem | it could be merged upstream but finding people to care about pike at this point upstream is hard, and that patch isn't exactly trivial | 13:47 |
mriedem | with all of the conflicts | 13:47 |
dansmith | mriedem: api patch landed, can you kick this in? https://review.opendev.org/#/c/687141/ | 13:48 |
KeithMnemonic | ok let me try and cherry pick it locally | 13:48 |
mriedem | dansmith: were you going to reply to andrey again before doing so? | 13:49 |
mriedem | he is a core so i feel sort of bad if i just overrule him without a reply | 13:50 |
dansmith | okay | 13:51 |
*** xek has joined #openstack-nova | 13:52 | |
*** mlavalle has joined #openstack-nova | 13:53 | |
*** pcaruana has quit IRC | 13:53 | |
*** ab-a has quit IRC | 13:53 | |
mdbooth | Oh, that's evil | 13:54 |
*** psachin has quit IRC | 13:54 | |
*** ab-a has joined #openstack-nova | 13:54 | |
mdbooth | In python2, if your module is in nova.tests.functional and you 'import fixtures', you get nova.tests.functional.fixtures. In python3 you get 'fixtures'. | 13:54 |
mdbooth | Apart from renaming nova.tests.functional.fixtures, I'm not immediately sure wtf to do about that. | 13:55 |
*** dave-mccowan has quit IRC | 13:56 | |
*** munimeha1 has joined #openstack-nova | 13:57 | |
mdbooth | Fun fact 2: emojis in review comments elicit a 500 from gerrit. | 13:57 |
sean-k-mooney | mdbooth: that to do with relitive imports and what happens if you have a module in the local director that alisas a module in your path | 13:58 |
mdbooth | sean-k-mooney: Any idea how to disable in py2 in a manner which doesn't break py3? | 13:58 |
sean-k-mooney | there might be a futre thing for this. absolute import or something like htat | 13:58 |
melwitt | KeithMnemonic, mriedem: I started reviewing that patch yesterday but not done yet. it's taking forever bc of all the conflicts. I'll finish reviewing today | 13:59 |
KeithMnemonic | thanks! | 13:59 |
sean-k-mooney | https://www.python.org/dev/peps/pep-0328/ | 13:59 |
sean-k-mooney | from __future__ import absolute_import | 13:59 |
sean-k-mooney | but that shoudl be enabled by default in py 2.7 | 14:00 |
mdbooth | Apparently not | 14:00 |
bauzas | mdbooth: to make it clear, nobody should just import any module like "import <module>" but rather doing "from <where> import <module>" | 14:05 |
bauzas | if I'm reviewing any change like this, I'd -1 it | 14:06 |
melwitt | mdbooth: there shouldn't be a module nova.tests.functional.fixtures module, there's one in nova.tests.fixtures though | 14:09 |
melwitt | I think that's how this hasn't come up before | 14:09 |
*** jawad_axd has joined #openstack-nova | 14:09 | |
*** jawad_axd has quit IRC | 14:10 | |
*** jawad_ax_ has joined #openstack-nova | 14:11 | |
*** jawad_ax_ has quit IRC | 14:11 | |
efried_afk | mdbooth: you need | 14:11 |
efried_afk | from __future__ import absolute_import | 14:11 |
*** efried_afk is now known as efried | 14:11 | |
efried | oh, I'm late to the party. | 14:12 |
efried | if we could just merge the "kill py2" patch, we could stop doing this ick | 14:12 |
sean-k-mooney | yes | 14:14 |
sean-k-mooney | although we shoudl still keep it in mind if we backport things | 14:14 |
*** macz has quit IRC | 14:17 | |
*** dpawlik has quit IRC | 14:18 | |
*** jangutter has quit IRC | 14:19 | |
melwitt | bauzas: well, if you need to import the base fixtures module (https://pypi.org/project/fixtures/) there's no other way than 'import fixtures', right? | 14:27 |
*** larsks has quit IRC | 14:29 | |
*** larsks has joined #openstack-nova | 14:30 | |
mriedem | melwitt: nova.tests.functional.fixtures is where the placement fixture is | 14:34 |
mriedem | it got moved there after ripping placement out of nova | 14:35 |
melwitt | oh, I see. I forgot it was just 'fixtures' there | 14:36 |
melwitt | mah bad | 14:36 |
openstackgerrit | Eric Fried proposed openstack/nova master: Always trait the compute node RP with COMPUTE_NODE https://review.opendev.org/688979 | 14:43 |
openstackgerrit | Eric Fried proposed openstack/nova master: ItemsMatcher: mock call list arg in any order https://review.opendev.org/689487 | 14:43 |
efried | gibi: You'll like ^ :) | 14:44 |
*** sapd1 has quit IRC | 14:47 | |
*** bnemec has quit IRC | 14:49 | |
*** sapd1 has joined #openstack-nova | 14:52 | |
bauzas | melwitt: sorry was afk, I meant to not import any module by relative | 14:52 |
bauzas | any import should be absolute | 14:53 |
bauzas | that's it | 14:53 |
melwitt | bauzas: np. I know, I'm saying how do you do the "from <where> import <module>" if you need https://pypi.org/project/fixtures ? | 14:53 |
bauzas | melwitt: "import fixtures" is absolute for it :) | 14:54 |
bauzas | I meant for packages | 14:54 |
bauzas | fixtures is both the package and the module you wanna import | 14:54 |
bauzas | nova.tests.unit.fixtures isn't | 14:54 |
*** bnemec has joined #openstack-nova | 14:55 | |
* bauzas would love sam&max to be English | 14:55 | |
bauzas | http://sametmax.com/les-imports-en-python/ | 14:55 |
melwitt | right, but if your test is in nova/tests/functional/my_test.py and you need 'import fixtures' and there is a nova/tests/functional/fixtures.py it would pick up the latter, we now know | 14:56 |
melwitt | anyway, just saying I don't see a way to avoid the problem other than using 'from __future__ import absolute_import' as has been mentioned earlier | 14:56 |
*** psachin has joined #openstack-nova | 14:57 | |
*** dtantsur|brb is now known as dtantsur | 14:57 | |
mdbooth | Thanks, all! I'll update the test. | 14:58 |
*** gbarros has joined #openstack-nova | 14:58 | |
* mdbooth notes that the following did not work: | 14:59 | |
mdbooth | import fixtures as fucking_fixtures | 14:59 |
mdbooth | __future__ works :) | 15:00 |
*** tbachman has quit IRC | 15:00 | |
*** FlorianFa has quit IRC | 15:01 | |
openstackgerrit | Matthew Booth proposed openstack/nova master: Unplug VIFs as part of cleanup of networks https://review.opendev.org/663382 | 15:02 |
*** bnemec is now known as beekneemech | 15:02 | |
*** ttsiouts has quit IRC | 15:03 | |
*** mgariepy has quit IRC | 15:03 | |
*** ttsiouts has joined #openstack-nova | 15:03 | |
mdbooth | efried: I split out the regression test from the new bugfix, btw. Turned it into a double regression test with 2 separate fixes: https://review.opendev.org/#/c/689278/ | 15:03 |
efried | mdbooth: I was thinking that might be appropriate, but I was too fried to make a stink about it yesterday. Thanks. | 15:04 |
mdbooth | efried: Yeah, np. Thanks for looking. | 15:05 |
efried | cdent, gibi, bauzas, mriedem: I think all the ducks are lined up for: Always trait the compute node RP with COMPUTE_NODE https://review.opendev.org/688979 | 15:06 |
mdbooth | efried: I was also fried, and extremely annoyed at finding a new bug I wasn't looking for. | 15:06 |
efried | and btw, "if you build it, they will come" -- I came across another use case for it yesterday https://review.opendev.org/#/c/676522/21/nova/compute/resource_tracker.py@1823 | 15:06 |
*** gyee has joined #openstack-nova | 15:07 | |
*** sapd1 has quit IRC | 15:08 | |
bauzas | efried: cool, I'll just honestly leave it for monday | 15:08 |
*** ociuhandu has joined #openstack-nova | 15:08 | |
*** ttsiouts has quit IRC | 15:08 | |
bauzas | (and with no kids at home, my productivity will dramatically increase) | 15:08 |
efried | bauzas: are they "not at home" like moved out, or just on vacation? | 15:09 |
bauzas | both, grand-parents care | 15:10 |
bauzas | for the week \o/ | 15:10 |
efried | woot | 15:10 |
bauzas | indeed | 15:10 |
mdbooth | bauzas: Party at your house :) | 15:10 |
*** udesale has quit IRC | 15:10 | |
bauzas | technically, our friends and us have no kids at same time | 15:11 |
bauzas | I don't wanna rush into details about the fact we already planned the whole week | 15:11 |
*** udesale has joined #openstack-nova | 15:11 | |
mdbooth | bauzas: Why haven't you taken the week off? | 15:11 |
bauzas | because I still love my job and despite the fact it looks like, I'm not on perpetual PTO (c) mriedem | 15:12 |
*** ociuhandu has quit IRC | 15:12 | |
mdbooth | He's just jealous | 15:13 |
bauzas | I'm pretty sure France still provides work permits for people who'd like to :p | 15:14 |
bauzas | there is one drawback tho | 15:14 |
bauzas | you have to leave in France | 15:14 |
*** TxGirlGeek has joined #openstack-nova | 15:14 | |
* mdbooth would like a little British enclave in the alps where everybody speaks english and you can get normal tea. Something like the Costa Del Alps. | 15:16 | |
*** mgariepy has joined #openstack-nova | 15:16 | |
cdent | "normal tea" | 15:17 |
cdent | such a british thing to say :P | 15:17 |
bauzas | mdbooth: it exists, it's called Courchevel | 15:17 |
bauzas | well, you also have to speak russian too | 15:17 |
mdbooth | cdent: You know, tea that's just normal. Like PG Tips or Yorkshire Tea. Not fancy. Just... normal. | 15:19 |
bauzas | mdbooth: do you think British MPs would be more inclined to accept the deal if we would add a clause for selling Courchevel ? Honestly, it's not like we miss anything | 15:19 |
bauzas | (sorry, Friday here) | 15:19 |
mdbooth | bauzas: I tried to put myself in the mind of a British MP once. I awoke from a coma 2 months later. Haven't tried again. | 15:20 |
*** gbarros has quit IRC | 15:20 | |
cdent | only 2 months? | 15:23 |
* cdent steps outside | 15:23 | |
sean-k-mooney | cdent: my mother refers to barrys or lyons tea as normal tea | 15:24 |
sean-k-mooney | cdent: so it translate to ireland too | 15:24 |
*** tbachman has joined #openstack-nova | 15:30 | |
*** eharney has joined #openstack-nova | 15:30 | |
*** igordc has joined #openstack-nova | 15:32 | |
*** beekneemech has quit IRC | 15:34 | |
*** macz has joined #openstack-nova | 15:38 | |
*** ociuhandu has joined #openstack-nova | 15:43 | |
*** ociuhandu has quit IRC | 15:43 | |
*** ociuhandu has joined #openstack-nova | 15:44 | |
mriedem | efried: i'm going to have to take a different approach on https://review.opendev.org/#/c/689049/ where the caller has the context, like this: http://paste.openstack.org/show/784726/ | 15:46 |
mriedem | and pretty much leave move_allocations as-is | 15:46 |
mriedem | if we had consumer types i could determine from move_allocations if the instance still exists or not... | 15:46 |
mriedem | or just pass the types into move_allocations but that kind of sucks | 15:47 |
efried | mriedem: don't we still have a race in that situation? | 15:48 |
mriedem | as in when i refresh the instance is still exists but is gone by the time move_allocations does the POST? | 15:48 |
efried | yeah | 15:49 |
efried | Small window -- but the window you're closing is pretty durn small too. | 15:49 |
mriedem | i guess that's possible, but i i'm not sure how to detect that when consumers in placement are ephemeral | 15:49 |
mriedem | meaning when we get the consumer allocs we pass the generation if we have one otherwise we just pass None if it's a new consumer | 15:50 |
efried | iow you need to know *before* you decide what to do in placement? | 15:50 |
efried | Instead of refreshing the instance, you could GET its allocations from placement. | 15:51 |
efried | then the window is n/a because when you push back if the generation doesn't match you'll blow up. | 15:51 |
mriedem | which is what move_allocations does | 15:51 |
*** damien_r has quit IRC | 15:52 | |
efried | mriedem: let me stare at it a bit after my meeting here. | 15:52 |
efried | (by which time you'll have probably figured it out anyway) | 15:52 |
mriedem | dealing with a head cold so my brain isn't really functioning | 15:53 |
*** dtantsur is now known as dtantsur|afk | 16:01 | |
*** panda has quit IRC | 16:01 | |
*** panda has joined #openstack-nova | 16:03 | |
*** rpittau is now known as rpittau|afk | 16:04 | |
*** ociuhandu has quit IRC | 16:11 | |
*** nanzha has quit IRC | 16:11 | |
openstackgerrit | Dan Smith proposed openstack/python-novaclient master: Add aggregate-cache-images command and client routines https://review.opendev.org/687141 | 16:16 |
openstackgerrit | Dan Smith proposed openstack/python-novaclient master: Add images.GlanceManager.find_images() bulk query https://review.opendev.org/689537 | 16:16 |
*** ociuhandu has joined #openstack-nova | 16:19 | |
*** gbarros has joined #openstack-nova | 16:23 | |
*** ociuhandu has quit IRC | 16:24 | |
*** markvoelker has quit IRC | 16:26 | |
*** markvoelker has joined #openstack-nova | 16:27 | |
*** dlbewley has quit IRC | 16:35 | |
*** igordc has quit IRC | 16:40 | |
*** gbarros has quit IRC | 16:51 | |
*** gbarros has joined #openstack-nova | 16:57 | |
*** lpetrut has quit IRC | 17:09 | |
efried | mriedem: when an instance is in CONFIRM_RESIZE, is the migration allocation still on the dest? | 17:09 |
eandersson | Would enabling randomize_allocation_candidates help with race conditions (RescheduleException)? | 17:15 |
eandersson | We heavily favor stacking, which tends to cause race conditions when deploying a lot of small flavors. | 17:15 |
eandersson | Especially bad when deploying 1k+ VMs | 17:16 |
*** ociuhandu has joined #openstack-nova | 17:18 | |
efried | eandersson: are you deploying them with a single command (max_instances=N or whatever that thing is) or multiple concurrent/quick operations? | 17:18 |
*** tesseract has quit IRC | 17:18 | |
*** tbachman has quit IRC | 17:19 | |
eandersson | multiple concurrent using terraform or ansible | 17:20 |
eandersson | if I do a single command it works fine | 17:20 |
dansmith | efried: the migration one is yeah | 17:20 |
eandersson | we have a lot of custom weighers and filters that probably make things.. slower (more likely to end in a race condition) | 17:20 |
dansmith | efried: the instance one is on the dest | 17:20 |
dansmith | efried: sorry, the migration allocation is on the _source_, the instance is on the _dest_ | 17:21 |
dansmith | assume that's what you meant | 17:21 |
eandersson | We used host_subset_size and max_attempts to counter it | 17:21 |
*** ociuhandu has quit IRC | 17:22 | |
*** cdent has quit IRC | 17:25 | |
efried | mriedem: Correct me if I'm wrong, move_allocations needs to deal with these scenarios: | 17:34 |
efried | - (live/cold) migrate execute: source is instance, target is migration. | 17:34 |
efried | - revert, including from a failed migration: source is migration, target is instance. | 17:34 |
efried | - In either case, if instance disappears, we want the operation fail, but that's something the caller needs to be aware of, not move_allocations itself. | 17:34 |
efried | - If an oob operation updates the instance's allocs (which only applies to the execute case; I assume you can't resize an instance that's in CONFIRM_RESIZE or ERROR, right?) we also want the migration to fail. | 17:34 |
efried | However, just like the delete thing that started you down this rathole, we can't close that window effectively while doing the GET from within move_allocations | 17:34 |
efried | So here's what I think needs to happen: | 17:34 |
efried | - move_allocations should always use 'allocations': {} to delete, never DELETE. | 17:34 |
efried | - move_allocations should *not retry on a consumer 409*; it should raise AllocationMoveFailed. It *should* retry on a *provider* 409 though. (This is a little complicated, and we have seen this issue elsewhere -- gibi L@@K.) | 17:34 |
efried | - Eventually (probably not now) the calling flows should be responsible for pulling the instance consumer (at least the generation, if not the whole allocation record) *early*, before entering the "critical path", and funneling that information into move_allocations. This is the only way we're going to effectively detect the race. | 17:34 |
efried | TL;DR the only thing that should change right now is: don't retry on consumer 409. | 17:34 |
*** markvoelker has quit IRC | 17:34 | |
efried | eandersson: randomize sounds like it would help there, yes. | 17:35 |
efried | eandersson: when you said you favor "stacking", did you mean "packing" (as opposed to "spread")? | 17:36 |
efried | If you're doing that ^ via your weighers/filters, then randomize probably won't do you a lot of good. | 17:37 |
efried | because your weigher will trawl down the list, random or not, and pick the fullest host anyway. | 17:38 |
melwitt | eandersson: what version are you running again? as of claims in placement, the rescheduling due to racing parallel requests shouldn't be a thing | 17:38 |
efried | melwitt: he's using separate parallel processes | 17:39 |
melwitt | I know | 17:39 |
efried | so each is doing a GET /a_c at the same time, getting the same answers, and all thinking they can hit the same host at the same time. | 17:39 |
efried | even with three retries, that'll race easily. | 17:39 |
melwitt | the whole point of claims in placement was to stop that though, that was the "multiple schedulers" problem of old. am I missing something? | 17:40 |
efried | more likely I am | 17:40 |
eandersson | efried, correct, packing | 17:41 |
efried | eandersson: If you did randomize and then fiddled around with a small ?limit= you might be able to reduce a little bit. But none of this sounds like a really good approach. | 17:41 |
eandersson | we have a lot of game servers that, and our goal is to fit as many game servers as possible | 17:42 |
eandersson | game servers take up one numa | 17:42 |
eandersson | but usually there are 2-4 vcpus left | 17:42 |
eandersson | so our filter/weighers tries to put small vms on top of that | 17:42 |
eandersson | without taking up enough to prevent a "game server" from fitting | 17:43 |
eandersson | e.g. if small vms take up 6 cores of a numa, no large server could fit | 17:43 |
efried | are the races happening on "small vm" or "game server"? | 17:43 |
eandersson | small vms only | 17:43 |
efried | well, you said "numa", which could be the crux of the problem. | 17:43 |
efried | placement doesn't know about numa yet. | 17:43 |
eandersson | because I think what is happening is that we have 2-3 computes with the "perfect fit" so they all try to land at those | 17:43 |
melwitt | placement claims were added in pike https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/placement-claims.html | 17:43 |
eandersson | this is rocky btw | 17:44 |
melwitt | oh, numa isn't checked until after it lands on the compute, so that's why you're hitting this | 17:44 |
melwitt | yeah | 17:44 |
efried | So if you have 1vcpu in each of two numas and you ask for 2VCPU, placement will give you what it thinks is a viable candidate | 17:44 |
melwitt | (as efried said earlier) | 17:44 |
efried | but the numa topo filter will punt it. | 17:44 |
efried | eandersson: does your "small vm" have a numa topo specified? | 17:45 |
*** eharney has quit IRC | 17:45 | |
eandersson | yea | 17:45 |
efried | does it need to? :P | 17:45 |
efried | if you allow it to float across numas, I suspect your race will go away. | 17:45 |
eandersson | I would assume so, but not 100% sure | 17:45 |
eandersson | If just ranzomizing the results a bit fixes it I probably prefer that route | 17:46 |
eandersson | but if that isn't enough I could look into doing that | 17:46 |
melwitt | fwiw I think you're already doing all you can to mitigate, by increasing the subset size and increasing retries. there's another option that could help, https://docs.openstack.org/nova/rocky/configuration/config.html#filter_scheduler.shuffle_best_same_weighed_hosts | 17:47 |
melwitt | (assuming you can't change anything about the numa) | 17:48 |
eandersson | interesting, didn't know about that setting | 17:48 |
melwitt | yeah, that's the only other one involved in all this that you haven't looked at already | 17:48 |
efried | eandersson: if the problem is numa as described, randomizing won't help at all. | 17:49 |
openstackgerrit | Dan Smith proposed openstack/python-novaclient master: Add images.GlanceManager.find_images() bulk query https://review.opendev.org/689537 | 17:49 |
openstackgerrit | Dan Smith proposed openstack/python-novaclient master: Add aggregate-cache-images command and client routines https://review.opendev.org/687141 | 17:49 |
eandersson | I see - I think what melwitt just linked might be the issue | 17:49 |
melwitt | eandersson: the randomize_allocation_candidates won't help you I don't think because it returns things in a deterministic order (so as not to necessarily break scheduling stacking) | 17:49 |
openstackgerrit | Dan Smith proposed openstack/python-novaclient master: Add images.GlanceManager.find_images() bulk query https://review.opendev.org/689537 | 17:50 |
openstackgerrit | Dan Smith proposed openstack/python-novaclient master: Add aggregate-cache-images command and client routines https://review.opendev.org/687141 | 17:50 |
efried | melwitt: "it returns things" <== "it" being the filter? | 17:51 |
melwitt | no, placement | 17:51 |
efried | with randomize_allocation_candidates placement does *not* return things in deterministic order. | 17:52 |
melwitt | oh, lol, sorry I read the help backwards | 17:52 |
efried | yeah, with it *off* the order is deterministic (but inscrutable, based on natural db order of some nonobvious kind) | 17:53 |
melwitt | right | 17:53 |
melwitt | eandersson: ^ ignore what I said earlier about randomize_allocation_candidates | 17:54 |
eandersson | randomize_allocation_candidates = good? | 17:54 |
*** udesale has quit IRC | 17:56 | |
efried | eandersson: if the problem is the numa thing, randomize_allocation_candidates = irrelevant. | 17:56 |
*** TxGirlGeek has quit IRC | 17:57 | |
melwitt | eandersson: what efried said. it won't help you because your problem is the numa fitment. I was just correcting what I said about it being a deterministic order, it would be the opposite of that, a random order | 17:57 |
eandersson | I see - I assumed so, but wanted to make sure | 17:57 |
melwitt | I read the help backwards and... I don't have much of an excuse | 17:57 |
efried | The only way it would be at all likely to help you is if $number_of_concurrent_deploys < $number_of_possible_hosts *and* you use a ?limit < $number_of_possible_hosts | 17:58 |
efried | but like I said, that's a pretty hacky thing to try to figure out | 17:58 |
melwitt | eandersson: the shuffle_best_same_weighed_hosts might help you, I think. numa stuff might be why it was added in the first place | 17:59 |
*** TxGirlGeek has joined #openstack-nova | 17:59 | |
eandersson | Yea - sounds super promising. | 17:59 |
melwitt | +1 efried. eandersson: the randomize_allocation_candidates use case is for very large deployments where the default limit for returned candidates is < the total number of compute hosts in the deployment. think CERN with multiple cells | 18:02 |
eandersson | Just fyi we have ~1k nodes in each deployment | 18:02 |
melwitt | ack | 18:03 |
eandersson | per cell | 18:04 |
melwitt | oh, ok that is a lot | 18:06 |
eandersson | We use regions instead of cells at the moment, but might want to change that in the future | 18:06 |
melwitt | here's the background on the option https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/allocation-candidates-limit.html | 18:08 |
eandersson | We limit ourself to 1k nodes today because we don't know if neutron can handle it | 18:08 |
eandersson | (used to be nova + neutron, but doubt nova will have a problem today) | 18:09 |
eandersson | when we upgraded to rocky neutron used up like 500GB memory lol | 18:09 |
eandersson | each neutron process peaked at 8.2GB memory used | 18:10 |
melwitt | gotcha. belmiro from CERN would be the one to chat with about neutron scaling | 18:10 |
eandersson | We work with them a lot | 18:10 |
melwitt | I don't remember if they are doing something special re: neutron | 18:10 |
eandersson | They use one big Layer 2 network | 18:10 |
melwitt | ok cool | 18:10 |
melwitt | and that's... a lot of memory O.o | 18:11 |
eandersson | Yea it's nuts. I tend to ping the neutron channel but no one ever replies | 18:11 |
eandersson | Nova channel is way better :p | 18:11 |
melwitt | ah yeah, I think they might be mostly EU timezone | 18:12 |
eandersson | Some awesome people here, melwitt efried sean-k-mooney mnaser mriedem to name a few ;) | 18:12 |
melwitt | :) | 18:12 |
mnaser | \o/ | 18:13 |
mnaser | eandersson: will you be at shanghai? | 18:13 |
eandersson | I will miss shanghai :'( | 18:13 |
eandersson | Will be attending the next one for sure | 18:13 |
*** psachin has quit IRC | 18:15 | |
eandersson | Which is a bummer, especially since Train has been the largest contribution from us yet :P | 18:15 |
eandersson | 90% of that was to Designate hehe | 18:16 |
*** igordc has joined #openstack-nova | 18:17 | |
openstackgerrit | Merged openstack/nova stable/queens: Drop source node allocations if finish_resize fails https://review.opendev.org/682722 | 18:17 |
mnaser | eandersson: awesome | 18:20 |
eandersson | btw some more shameless pr, but if you know anyone in South California or Austin Texas, we are hiring OpenStack people (systems and/or software) | 18:25 |
eandersson | *that is looking for work | 18:25 |
*** tbachman has joined #openstack-nova | 18:26 | |
*** nsherry4 has joined #openstack-nova | 18:32 | |
*** nsherry4 has quit IRC | 18:32 | |
*** ircuser-1 has joined #openstack-nova | 18:43 | |
efried | eandersson: not that I'm looking, who's "we"? | 18:50 |
efried | I'm in Austin, but have a cushy wfh gig. Wouldn't consider anything with a commute longer than eleven seconds. | 18:51 |
dansmith | agree, although the traffic on my commute is getting ridiculous | 18:52 |
dansmith | earlier this week, I had to wait for the cat to pass before I made a left at the stairs | 18:52 |
dansmith | major road rage situation | 18:52 |
*** trident has quit IRC | 18:57 | |
*** eharney has joined #openstack-nova | 18:58 | |
*** TxGirlGeek has quit IRC | 18:59 | |
*** trident has joined #openstack-nova | 19:00 | |
mordred | efried: I believe eandersson is at blizzard | 19:02 |
efried | that makes sense | 19:03 |
efried | Are game companies still as crazy as they were in the 90s? That's the last time I paid attention. | 19:04 |
efried | people living in their office for a month at a time, kind of thing | 19:05 |
mordred | I live in my office for a month at a time | 19:06 |
efried | aaand you're crazy, what's your point? | 19:09 |
efried | oh, that things other than game companies can be crazy, got it. | 19:09 |
*** dave-mccowan has joined #openstack-nova | 19:10 | |
*** ircuser-1 has quit IRC | 19:15 | |
*** ircuser-1 has joined #openstack-nova | 19:17 | |
openstackgerrit | Eric Fried proposed openstack/nova master: ItemsMatcher: mock call list arg in any order https://review.opendev.org/689487 | 19:18 |
openstackgerrit | Eric Fried proposed openstack/nova master: Always trait the compute node RP with COMPUTE_NODE https://review.opendev.org/688979 | 19:18 |
* efried procrastinates ^ | 19:18 | |
mordred | efried: yeah. I mostly meant, you know - like, my house, which is also my office | 19:23 |
mordred | efried: I'm maybe not as funny or cleve as I sometimes think | 19:24 |
efried | Oh, you are, but probably not for the *reasons* you think. | 19:24 |
*** osmanlicilegi has joined #openstack-nova | 19:24 | |
efried | See, my funniness is inversely proportional to how much I'm trying. There's no surprise funny from me. | 19:25 |
*** markvoelker has joined #openstack-nova | 19:36 | |
*** mdbooth has quit IRC | 19:37 | |
*** markvoelker has quit IRC | 19:38 | |
*** markvoelker has joined #openstack-nova | 19:38 | |
*** mdbooth has joined #openstack-nova | 19:39 | |
*** gyee has quit IRC | 19:39 | |
*** TxGirlGeek has joined #openstack-nova | 19:39 | |
*** gyee has joined #openstack-nova | 19:39 | |
*** ociuhandu has joined #openstack-nova | 19:45 | |
*** mgariepy has quit IRC | 19:47 | |
*** ociuhandu has quit IRC | 19:50 | |
*** igordc has quit IRC | 19:54 | |
*** ralonsoh has quit IRC | 20:08 | |
*** igordc has joined #openstack-nova | 20:23 | |
*** TxGirlGeek has quit IRC | 20:35 | |
eandersson | efried, yea unfortunately still all about that office | 20:50 |
eandersson | https://careers.blizzard.com/en-us/openings/o6vmbfwS (Austin) https://careers.blizzard.com/en-us/openings/ohdYafwm (Irvine) | 20:53 |
*** nweinber has quit IRC | 21:03 | |
*** lpetrut has joined #openstack-nova | 21:06 | |
*** lpetrut has quit IRC | 21:13 | |
*** markvoelker has quit IRC | 21:14 | |
*** maciejjozefczyk has quit IRC | 21:19 | |
*** dklyle has quit IRC | 21:30 | |
mriedem | gmann: remember how we thought host_status would be returned for GET /servers/detail with servers from down cells? i found that won't happen | 21:38 |
mriedem | because of this filtering https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/views/servers.py#L590 | 21:38 |
mriedem | efried: sorry about the late reply, i've been not around so much today - i took your comments and threw them into my patch so i can process them on monday | 21:39 |
efried | saw dat, get some rest and feel better. | 21:39 |
efried | (How) does nova (via oslo.config?) vet permissions of nova.conf? | 21:53 |
efried | or is that completely the responsibility of the admin? | 21:54 |
sean-k-mooney | efried: i think its up to the admin/installer | 22:00 |
sean-k-mooney | e.g. we dont check that the config is 600 or 660 as far as i am aware | 22:01 |
efried | so if /etc/nova and contents were 5777 and owned by $random we would truck happily along? | 22:01 |
mriedem | gmann: melwitt: a couple of questions in the host_status_unknown patch - mostly for gmann about policy rule naming and the docs on the policy rule since 2.75+ https://review.opendev.org/#/c/679181/ | 22:01 |
sean-k-mooney | efried: i think so | 22:01 |
efried | o...kay. | 22:02 |
sean-k-mooney | nova does not create the file and we never write to it | 22:02 |
mriedem | efried: likely a question for bnemec | 22:02 |
sean-k-mooney | so its really up to the install to make sure that files with password in them are not world readable | 22:02 |
mriedem | i thought there was some talk of some how vaultifying that stuff but i might be dreaming that up | 22:03 |
efried | sean-k-mooney: well, that and if they're writable in any way a malicious user could make nova do horrible things to the system | 22:03 |
efried | mriedem: I think sdk does something like that. | 22:03 |
efried | or at least supports it. | 22:03 |
efried | for clouds.yaml | 22:03 |
efried | mordred: ^ | 22:04 |
efried | not that that's relevant here | 22:04 |
efried | I'll ML this sucker. | 22:04 |
sean-k-mooney | efried: i mean programs like ssh refuse to work if you dont set the right permisions in your ssh .config or key | 22:04 |
sean-k-mooney | so its not unresonable | 22:04 |
mordred | aroo? | 22:04 |
efried | right, swhat I'm sayin, it wouldn't be unreasonable for oslo and/or nova to enforce something like that. | 22:05 |
efried | but that doesn't mean we do | 22:05 |
mordred | oh - yeah - so - sdk supports clouds.yaml being split into clouds.yaml and secure.yaml | 22:05 |
mordred | we do not enforce that secure.yaml is actually secure - although I agree, it would be a reasonably sane thing to do | 22:05 |
efried | mordred: before I blast the ML, do you know off the top whether oslo.config does any such validation either? | 22:06 |
mriedem | https://specs.openstack.org/openstack/oslo-specs/specs/stein/secret-management-store.html ? | 22:06 |
sean-k-mooney | it looks like kolla atleast makes it 660 https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/nova/tasks/config.yml#L57 | 22:07 |
mordred | efried: I do not know anything about oslo.config | 22:07 |
sean-k-mooney | they will be own by the kolla:kolla user and group by default | 22:07 |
sean-k-mooney | well on the host | 22:08 |
sean-k-mooney | they will be own by nova in the containers | 22:08 |
mriedem | efried: that spec looks pretty close but i don't see any code ever showed up for it | 22:08 |
efried | even if it was coded per the spec, though, it would only mean that you *could* secure your configs; it'd still be n/a for anyone using nova.conf | 22:09 |
sean-k-mooney | mriedem: i do think your recalection is right we did talk about vaultifing this at some point | 22:09 |
sean-k-mooney | im not sure it was that oslo spec specificaly but seam likely that was related | 22:10 |
*** dklyle has joined #openstack-nova | 22:10 | |
mriedem | anywho, i'm going to drop now, have a good weekend o/ | 22:13 |
efried | o/ | 22:13 |
*** mriedem has quit IRC | 22:13 | |
efried | drink lots of fluids. Suck on zinc. | 22:13 |
sean-k-mooney | o/ | 22:13 |
sean-k-mooney | efried: looks like kolla locks it down to 600 in the containers https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/nova-cell/templates/nova-compute.json.j2#L8 | 22:14 |
efried | gtk | 22:14 |
sean-k-mooney | yep it means that at least implcitly there is nothing that requires the group to be able to read nova.conf | 22:15 |
sean-k-mooney | that makes sense however nothing out side of nova should read nova's config | 22:15 |
*** dklyle has quit IRC | 22:15 | |
*** david-lyle has joined #openstack-nova | 22:15 | |
sean-k-mooney | mordred: by the way is there any reason not to use the cloud.yml vs the old rc files | 22:17 |
sean-k-mooney | i assume no but just said i woudl ask | 22:17 |
efried | you mean in nova? | 22:18 |
mordred | sean-k-mooney: you should never use old rc files they are evil and horrible | 22:18 |
efried | or in sdk? | 22:18 |
efried | oh, I don't know what an "old rc file" is, /me stfu | 22:18 |
sean-k-mooney | i mean when im runing the openstack cli | 22:18 |
mordred | efried: the files with env vars set in them | 22:18 |
sean-k-mooney | ya those | 22:18 |
sean-k-mooney | the openrc file that devstack has | 22:18 |
mordred | sean-k-mooney: yeah - definitely not - clouds.yaml is much betterer than env var files | 22:18 |
mordred | the only reason to keep those openrc files around are the legacy cli clients | 22:19 |
sean-k-mooney | right which im trying not to use anymore | 22:19 |
sean-k-mooney | we should file a bug with horizon to not default to the RC files | 22:19 |
mordred | ++ | 22:20 |
sean-k-mooney | you can download the cloud.yaml too but its not the default | 22:20 |
mordred | sean-k-mooney: I've also been meaning to write something like "openstack login" or similar that would let you slurp in a clouds.yaml you downloaded and maybe prompt you for your password and write it to secure.yaml or something like that | 22:21 |
mordred | but - you know - ENOTIME | 22:21 |
sean-k-mooney | i totaly dont just edit to add my password... | 22:21 |
sean-k-mooney | you know what i would love | 22:21 |
sean-k-mooney | a way to use keystoen with an ssh key | 22:21 |
sean-k-mooney | just let me upload my public key as an alternitive to a password then never ask me again. | 22:22 |
mordred | sean-k-mooney: ++ | 22:23 |
*** slaweq has quit IRC | 22:24 | |
mordred | sean-k-mooney: I truly do not understand why this is not an actual option | 22:24 |
sean-k-mooney | time | 22:24 |
sean-k-mooney | also i dont think we ever asked the keystone folks | 22:24 |
mordred | I guess that's our fault | 22:25 |
sean-k-mooney | that would also be a way to secure the secure.yml i guess | 22:26 |
sean-k-mooney | anyway i shoudl actully finish up. enjoy the weekend o/ | 22:27 |
*** tbachman has quit IRC | 22:28 | |
mordred | you too! | 22:29 |
*** gbarros has quit IRC | 22:49 | |
*** macz has quit IRC | 22:50 | |
*** gbarros has joined #openstack-nova | 22:51 | |
efried | I'm outta here as well o/ | 23:01 |
*** slaweq has joined #openstack-nova | 23:11 | |
*** markvoelker has joined #openstack-nova | 23:15 | |
*** slaweq has quit IRC | 23:15 | |
*** gbarros has quit IRC | 23:16 | |
*** markvoelker has quit IRC | 23:19 | |
*** tbachman has joined #openstack-nova | 23:35 | |
*** gyee has quit IRC | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!