Thursday, 2019-11-14

*** brault has joined #openstack-nova00:00
*** TxGirlGeek has joined #openstack-nova00:26
*** JamesBenson has joined #openstack-nova00:29
*** JamesBenson has quit IRC00:33
*** TxGirlGeek has quit IRC00:35
*** mriedem has quit IRC00:38
*** mdbooth has quit IRC00:51
*** mdbooth has joined #openstack-nova00:53
*** Liang__ has joined #openstack-nova00:53
openstackgerritMerged openstack/nova master: Drop compat for non-update_provider_tree code paths  https://review.opendev.org/69343500:54
openstackgerritMerged openstack/nova master: Delete _normalize_inventory_from_cn_obj  https://review.opendev.org/69343600:59
openstackgerritMerged openstack/nova master: Remove unused CannotMigrateWithTargetHost  https://review.opendev.org/69393600:59
*** ileixe has joined #openstack-nova01:00
openstackgerritMerged openstack/nova master: Restrict RequestSpec to cell when evacuating  https://review.opendev.org/65042901:10
openstackgerritMerged openstack/nova stable/rocky: doc: fix and clarify --block-device usage in user docs  https://review.opendev.org/69355401:17
openstackgerritMerged openstack/nova stable/rocky: Revert "openstack server create" to "nova boot" in nova docs  https://review.opendev.org/69324001:17
*** ricolin has joined #openstack-nova01:25
openstackgerritMerged openstack/nova master: Fix review link.  https://review.opendev.org/68961201:46
*** gyee has quit IRC01:46
*** ileixe has left #openstack-nova01:50
*** boxiang has quit IRC01:51
*** boxiang has joined #openstack-nova01:52
*** ociuhandu has joined #openstack-nova01:54
*** tbachman has quit IRC01:54
*** ociuhandu has quit IRC01:59
*** sridharg has joined #openstack-nova02:07
*** sridharg has quit IRC02:21
*** ociuhandu has joined #openstack-nova02:28
*** ociuhandu has quit IRC02:32
*** chenhaw has joined #openstack-nova02:36
*** links has joined #openstack-nova02:41
*** boxiang has quit IRC02:50
*** boxiang has joined #openstack-nova02:50
*** sridharg has joined #openstack-nova02:51
*** abaindur has quit IRC03:04
*** abaindur has joined #openstack-nova03:04
openstackgerritMerged openstack/nova master: Use named kwargs in compute.API.resize  https://review.opendev.org/69342503:08
openstackgerritMerged openstack/nova master: "SUSPENDED" description changed in server_concepts guide and API REF  https://review.opendev.org/66359003:08
*** takashin has left #openstack-nova03:08
*** tinwood has quit IRC03:10
*** tinwood has joined #openstack-nova03:12
*** sridharg has quit IRC03:14
*** JamesBenson has joined #openstack-nova03:30
*** mkrai_ has joined #openstack-nova03:31
*** awalende has joined #openstack-nova03:34
*** psachin has joined #openstack-nova03:38
*** awalende has quit IRC03:39
*** udesale has joined #openstack-nova03:50
*** bhagyashris has joined #openstack-nova03:56
*** chenhaw has quit IRC04:07
*** chenhaw has joined #openstack-nova04:08
*** ociuhandu has joined #openstack-nova04:25
*** ociuhandu has quit IRC04:30
*** chenhaw has quit IRC04:38
*** chenhaw has joined #openstack-nova04:47
*** ociuhandu has joined #openstack-nova04:50
*** dtantsur|afk has quit IRC04:50
*** bhagyashris has quit IRC04:53
*** ociuhandu has quit IRC04:54
*** dtantsur has joined #openstack-nova04:55
*** ociuhandu has joined #openstack-nova05:02
*** chenhaw has quit IRC05:04
*** ociuhandu has quit IRC05:12
*** spatel has joined #openstack-nova05:15
*** spatel has quit IRC05:20
*** JamesBenson has quit IRC05:24
alex_xustephenfin: yea, Intel have proxy.05:24
alex_xustephenfin: let me know if you come to Beijing, I can treat you local food :)05:24
alex_xubauzas: nice, one more place catch you for review ;)05:25
*** ociuhandu has joined #openstack-nova05:30
*** bhagyashris has joined #openstack-nova05:31
*** zhanglong has joined #openstack-nova05:33
*** ociuhandu has quit IRC05:36
*** ratailor has joined #openstack-nova05:39
openstackgerritAbhishek Kekane proposed openstack/nova-specs master: Support multiple store of Glance  https://review.opendev.org/64121005:49
*** mkrai_ has quit IRC05:49
*** mkrai has joined #openstack-nova05:49
*** igordc has joined #openstack-nova05:55
*** ricolin has quit IRC06:00
openstackgerritAbhishek Kekane proposed openstack/nova-specs master: Support multiple store of Glance  https://review.opendev.org/64121006:02
*** Luzi has joined #openstack-nova06:08
*** yedongcan has joined #openstack-nova06:09
*** boxiang has quit IRC06:25
*** boxiang has joined #openstack-nova06:25
*** nanzha has joined #openstack-nova06:40
*** rcernin has quit IRC06:53
*** yedongcan has quit IRC06:59
*** yedongcan has joined #openstack-nova07:02
*** Liang__ has quit IRC07:04
*** ociuhandu has joined #openstack-nova07:04
*** chenhaw has joined #openstack-nova07:07
*** ociuhandu has quit IRC07:13
*** ociuhandu has joined #openstack-nova07:13
*** jkulik has joined #openstack-nova07:13
*** ociuhandu has quit IRC07:16
*** ociuhandu has joined #openstack-nova07:17
*** cervigni has quit IRC07:17
*** ociuhandu has quit IRC07:22
*** yedongcan has quit IRC07:23
*** ociuhandu has joined #openstack-nova07:24
*** yedongcan has joined #openstack-nova07:29
*** ociuhandu has quit IRC07:33
*** ociuhandu has joined #openstack-nova07:34
*** ociuhandu has quit IRC07:35
*** ociuhandu has joined #openstack-nova07:36
*** ociuhandu has quit IRC07:36
*** ociuhandu has joined #openstack-nova07:37
*** igordc has quit IRC07:39
*** yedongcan has quit IRC07:45
*** ociuhandu has quit IRC07:45
*** elod is now known as elod_off07:47
*** damien_r has joined #openstack-nova07:57
openstackgerritGuo Jingyu proposed openstack/nova-specs master: Proposal for a safer noVNC console with password authentication  https://review.opendev.org/62312008:00
*** xek has joined #openstack-nova08:05
*** maciejjozefczyk has joined #openstack-nova08:12
*** zhubx has joined #openstack-nova08:16
*** tesseract has joined #openstack-nova08:17
*** boxiang has quit IRC08:18
*** jangutter has joined #openstack-nova08:19
*** ivve has joined #openstack-nova08:20
*** maciejjozefczyk has quit IRC08:21
*** awalende has joined #openstack-nova08:22
openstackgerritMerged openstack/nova master: Require Migration object arg to migrate_instance_finish method  https://review.opendev.org/69010608:29
*** tkajinam has quit IRC08:29
openstackgerritMerged openstack/nova master: Consolidate [image_cache] conf options  https://review.opendev.org/69072308:29
openstackgerritMerged openstack/nova master: Add image caching to the support matrix  https://review.opendev.org/69074808:29
openstackgerritMerged openstack/nova master: Stop converting Migration objects to dicts for migrate_instance_start  https://review.opendev.org/69011508:30
*** ociuhandu has joined #openstack-nova08:30
*** slaweq has joined #openstack-nova08:30
*** udesale has quit IRC08:35
*** udesale has joined #openstack-nova08:37
*** jraju__ has joined #openstack-nova08:44
*** links has quit IRC08:45
*** links has joined #openstack-nova08:48
*** jraju__ has quit IRC08:48
openstackgerritMerged openstack/nova master: Make API always RPC cast to conductor for resize/migrate  https://review.opendev.org/69393708:49
*** ociuhandu has quit IRC08:51
*** ociuhandu has joined #openstack-nova08:52
*** ralonsoh has joined #openstack-nova08:54
openstackgerritBrin Zhang proposed openstack/nova-specs master: Add flavor extra specs group  https://review.opendev.org/66356308:55
*** rpittau|afk is now known as rpittau08:57
*** slaweq has quit IRC09:01
*** brinzhang has joined #openstack-nova09:03
*** ccamacho has joined #openstack-nova09:06
*** udesale has quit IRC09:08
*** slaweq has joined #openstack-nova09:09
*** udesale has joined #openstack-nova09:09
*** ociuhandu has quit IRC09:10
*** ociuhandu has joined #openstack-nova09:11
*** tinwood has quit IRC09:12
*** chenhaw has quit IRC09:13
*** tinwood has joined #openstack-nova09:13
*** abaindur has joined #openstack-nova09:15
*** trident has quit IRC09:16
*** nanzha has quit IRC09:22
*** trident has joined #openstack-nova09:26
*** tetsuro has joined #openstack-nova09:33
*** ociuhandu has quit IRC09:34
*** ociuhandu has joined #openstack-nova09:35
*** ociuhandu has quit IRC09:35
*** ociuhandu has joined #openstack-nova09:36
*** ociuhandu has quit IRC09:37
*** nanzha has joined #openstack-nova09:37
*** ociuhandu has joined #openstack-nova09:37
*** chenhaw has joined #openstack-nova09:40
*** ociuhandu has quit IRC09:45
openstackgerritStephen Finucane proposed openstack/nova master: Convert legacy nova-live-migration and nova-multinode-grenade to py3  https://review.opendev.org/69237409:46
openstackgerritStephen Finucane proposed openstack/nova master: Stop testing Python 2  https://review.opendev.org/68795409:46
openstackgerritStephen Finucane proposed openstack/nova master: zuul: Make functional job inherit from openstack parents  https://review.opendev.org/68842509:46
*** kaisers has quit IRC09:49
*** spatel has joined #openstack-nova09:50
*** ociuhandu has joined #openstack-nova09:54
*** pcaruana has joined #openstack-nova09:54
*** spatel has quit IRC09:55
*** ociuhandu has quit IRC10:03
*** ralonsoh has quit IRC10:03
*** ralonsoh has joined #openstack-nova10:03
*** kaisers has joined #openstack-nova10:05
*** lpetrut has joined #openstack-nova10:06
*** lpetrut has quit IRC10:07
*** lpetrut has joined #openstack-nova10:07
*** ociuhandu has joined #openstack-nova10:12
*** ociuhandu has quit IRC10:19
*** mkrai has quit IRC10:21
*** ociuhandu has joined #openstack-nova10:22
*** chenhaw has quit IRC10:22
*** ociuhandu has quit IRC10:23
*** sridharg has joined #openstack-nova10:23
*** ociuhandu has joined #openstack-nova10:24
openstackgerritBalazs Gibizer proposed openstack/nova stable/pike: Only nil az during shelve offload  https://review.opendev.org/69383910:28
openstackgerritMerged openstack/nova master: Remove dead set_admin_password code to generate password  https://review.opendev.org/69187310:28
openstackgerritMerged openstack/nova master: doc: add troubleshooting guide for cleaning up orphaned allocations  https://review.opendev.org/69142710:29
*** ociuhandu has quit IRC10:29
*** sridharg has quit IRC10:31
openstackgerritBalazs Gibizer proposed openstack/nova stable/pike: Only nil az during shelve offload  https://review.opendev.org/69383910:31
*** dpawlik has joined #openstack-nova10:34
*** zhanglong has quit IRC10:37
*** yan0s has joined #openstack-nova10:43
*** mkrai has joined #openstack-nova11:05
brinzhanggibi_off: Thanks for your review https://review.opendev.org/#/c/663563/, how about rename the bp as "resource metadata of instance"? and change the new db table's name as "resource_metadata"?11:13
*** udesale has quit IRC11:14
brinzhanggibi_off: I think we also should establish the association for the "instance_uuid" and "resource_metadata_id". here, a) create a new table, contain the columns of "instance_uuid" and "resource_metadata_id".  b) add "resource_metadata_id" to the "instance_metadata" db table, and mapping the choosed (key, value) to the instance.(I think this is compatible with current usage.)11:20
*** ociuhandu has joined #openstack-nova11:21
*** jaosorior has joined #openstack-nova11:25
*** ociuhandu has quit IRC11:27
*** dpawlik has quit IRC11:30
*** brinzhang_ has joined #openstack-nova11:35
openstackgerritStephen Finucane proposed openstack/nova master: functional: Change order of two classes  https://review.opendev.org/68917811:36
openstackgerritStephen Finucane proposed openstack/nova master: functional: Rework '_delete_server'  https://review.opendev.org/68917911:36
openstackgerritStephen Finucane proposed openstack/nova master: functional: Make '_wait_for_state_change' behave consistently  https://review.opendev.org/68918011:36
openstackgerritStephen Finucane proposed openstack/nova master: functional: Unify '_wait_until_deleted' implementations  https://review.opendev.org/68918111:36
openstackgerritStephen Finucane proposed openstack/nova master: functional: Make 'ServerTestBase' subclass 'InstanceHelperMixin'  https://review.opendev.org/68918211:36
*** dpawlik has joined #openstack-nova11:37
*** brinzhang has quit IRC11:38
*** mkrai has quit IRC11:42
openstackgerritStephen Finucane proposed openstack/nova master: DNM: Try to figure out why rbd import fails  https://review.opendev.org/69426011:42
*** mdbooth has quit IRC11:45
*** mkrai has joined #openstack-nova11:45
*** mdbooth has joined #openstack-nova11:47
*** brinzhang has joined #openstack-nova11:53
*** henriqueof has joined #openstack-nova11:55
*** maciejjozefczyk has joined #openstack-nova11:57
*** brinzhang_ has quit IRC11:57
*** dave-mccowan has joined #openstack-nova12:00
*** huaqiang has joined #openstack-nova12:02
*** maciejjozefczyk has quit IRC12:02
*** ratailor has quit IRC12:05
*** trident has quit IRC12:09
*** trident has joined #openstack-nova12:18
openstackgerritStephen Finucane proposed openstack/nova master: DNM: python3 experiments  https://review.opendev.org/69428112:22
*** tesseract has quit IRC12:28
*** tesseract has joined #openstack-nova12:29
*** mkrai has quit IRC12:29
*** mgariepy has joined #openstack-nova12:38
*** bhagyashris has quit IRC12:45
*** damien_r has quit IRC12:51
*** Luzi has quit IRC12:51
*** psachin has quit IRC12:51
*** jistr has quit IRC12:52
*** ccstone has quit IRC12:52
*** nicholas has quit IRC12:52
*** d34dh0r53 has quit IRC12:52
*** ianw has quit IRC12:52
*** amotoki has quit IRC12:52
*** Anticimex has quit IRC12:52
*** adrianc has quit IRC12:52
*** rha has quit IRC12:52
*** coreycb has quit IRC12:52
*** knikolla has quit IRC12:52
*** ildikov has quit IRC12:52
*** rchurch has quit IRC12:53
*** openstackstatus has quit IRC12:53
*** damien_r has joined #openstack-nova12:53
*** Luzi has joined #openstack-nova12:53
*** psachin has joined #openstack-nova12:53
*** jistr has joined #openstack-nova12:53
*** nicholas has joined #openstack-nova12:53
*** ccstone has joined #openstack-nova12:53
*** d34dh0r53 has joined #openstack-nova12:53
*** ianw has joined #openstack-nova12:53
*** amotoki has joined #openstack-nova12:53
*** Anticimex has joined #openstack-nova12:53
*** adrianc has joined #openstack-nova12:53
*** rha has joined #openstack-nova12:53
*** coreycb has joined #openstack-nova12:53
*** knikolla has joined #openstack-nova12:53
*** ildikov has joined #openstack-nova12:53
*** brinzhang has quit IRC12:56
*** brinzhang has joined #openstack-nova12:56
*** rchurch has joined #openstack-nova12:57
*** brinzhang has quit IRC12:57
*** zhubx has quit IRC13:00
*** brault has quit IRC13:00
*** zhubx has joined #openstack-nova13:00
*** brault has joined #openstack-nova13:03
*** brinzhang has joined #openstack-nova13:14
*** brinzhang has quit IRC13:16
*** brinzhang has joined #openstack-nova13:17
openstackgerritLee Yarwood proposed openstack/nova-specs master: Virtual instance rescue with stable disk devices  https://review.opendev.org/69384913:26
openstackgerritLee Yarwood proposed openstack/nova-specs master: Boot from volume instance rescue  https://review.opendev.org/69406313:26
*** brinzhang has joined #openstack-nova13:27
*** brinzhang has quit IRC13:27
*** brinzhang has joined #openstack-nova13:28
*** spatel has joined #openstack-nova13:30
*** maciejjozefczyk has joined #openstack-nova13:32
*** spatel has quit IRC13:34
*** ociuhandu has joined #openstack-nova13:34
*** brinzhang_ has joined #openstack-nova13:36
*** maciejjozefczyk has quit IRC13:39
*** henriqueof has quit IRC13:40
*** brinzhang has quit IRC13:40
*** ociuhandu has quit IRC13:40
*** mkrai has joined #openstack-nova13:42
*** mriedem has joined #openstack-nova13:45
*** udesale has joined #openstack-nova13:46
*** nweinber_ has joined #openstack-nova13:48
*** efried has joined #openstack-nova14:00
*** ociuhandu has joined #openstack-nova14:05
*** ociuhandu has quit IRC14:05
*** brinzhang_ has quit IRC14:06
*** ociuhandu has joined #openstack-nova14:06
*** brinzhang_ has joined #openstack-nova14:06
*** shilpasd has joined #openstack-nova14:08
*** psachin has quit IRC14:14
*** ociuhandu has quit IRC14:18
*** ociuhandu has joined #openstack-nova14:18
efriedo/ nova14:19
efriedIs anyone around for the meeting?14:19
efriedFirst meeting since PTG+USADST, so an hour earlier for many of us.14:20
*** henriqueof has joined #openstack-nova14:20
gibi_offefried: I have to skip it today14:23
efriedOkay. You and bauzas and stephenfin were going to be the stars of the show, so...14:24
efriedand next week's (at 2100 utc) is going to be inconvenient for all of you.14:24
bauzassorry, on 1:1 meeting now14:24
gibi_offefried: yeah 2100 is bad, but today (and yesterday) I have to be present on an internal conference demoing the bandwidth stuff repeatedly14:26
efriedthat sounds like more fun than a nova meeting anyway.14:26
gibi_offefried: and as this is done in an open demo area I don't know when somebody pops up at our booth14:26
*** eharney has joined #openstack-nova14:27
gibi_offI can imagine there is a way to define fun that applies to me now :)14:27
efriedHeh, hang an "out to lunch" placard :P14:27
gibi_off:)14:27
* efried caffeinates más14:28
*** Luzi has quit IRC14:33
*** ociuhandu has quit IRC14:34
stephenfinefried: I got confused with the timezones. Drat /o\14:34
stephenfinDST--14:34
*** ociuhandu has joined #openstack-nova14:35
*** tbachman has joined #openstack-nova14:40
*** links has quit IRC14:42
*** ociuhandu has quit IRC14:42
mriedemhuh, i forgot to change my calendar as well :)14:43
*** brinzhang has joined #openstack-nova14:46
*** brinzhang_ has quit IRC14:48
mriedemefried: was there anything you wanted to go over? my thing in open discussion is in the ML and i'm just going to do a quick PoC I think14:48
mriedemthere were a few stable branch releases14:49
mriedemand elod was added to the nova-stable-maint team14:49
efriedmriedem: The other open (which luyao hadn't put on the agenda as of meeting start time) was whether the LM bits of vPMEM need a BP/spec or not. What are your thoughts?14:52
*** ricolin has joined #openstack-nova14:52
*** belmoreira has quit IRC14:53
mriedemmy gut reaction is vPMEM hasn't even baked to the point of thinking about supporting live migration14:55
mriedemi.e. i don't think we even support live migration with vgpus do we?14:55
mriedemand people might actually be using that by now14:55
mriedemvpmem and live migration is likely complicated that a short spec probably doesn't hurt14:56
mriedem*complicated enough14:56
mriedemstephenfin: i commented on https://review.opendev.org/#/c/692374/14:56
mriedemtl;dr i don't think USE_PYTHON3=True is making it to the devstack-plugin-ceph run when the post-test script runs it14:57
mriedemstephenfin: also, in trying to convert the nova-live-migration job to zuulv3 here https://review.opendev.org/#/c/693364/ oi14:57
mriedemi'm coming to the conclusion that it would be a ton simpler to just split the nova-live-migration job in two,14:57
*** tbachman has quit IRC14:58
mriedemone for block migration and local disk and one with ceph + shared disk14:58
efriedmriedem: Pretty sure the impl is already done, it just didn't make Train. Anyway, I agree it could do with a short spec, as I think it needs new object fields, so we should at least be able to bikeshed the names of those. <== luyao14:58
mriedemefried: is the vpmem 3rd party ci stable?14:58
mriedemand if it's stable, can they run it multinode to test live migration?14:58
efrieddunno. alex_xu luyao ^ ?14:58
mriedemat least periodically?14:58
efriedI thought the CI was stable at the end of train, for single node. Don't know the status of LM CI.14:59
mriedemi just don't have a ton of energy to invest in building feature functionality on top of a thing that i don't know if anyone is using it14:59
mriedemlike SEV in that way...14:59
mriedemhaving said all that, i think dansmith would be totally on board with building in live migration support for vpmems, that's right up his alley15:00
* dansmith scowls15:00
efriedI think of it less as "tack a feature onto this thing" and more as "piece of the puzzle that didn't quite get finished with the rest".15:01
efriedoh, maybe I'm wrong. I see the patch wasn't proposed until Oct.15:02
mriedemso looking at a recent pmem ci run http://52.27.155.124/79/694179/2/check/pmem-tempest-plugin-filtered/1123b99/job-output.txt15:02
mriedemit runs 3 tests in less than a minute15:02
mriedemthe entire job takes about 30 minutes15:02
mriedemsurely there is more testing that could be done with operations on a server with pmems, though i'm not sure what test_server_basic_ops does15:03
mriedeme.g. if resize works, cold migration should work, so maybe first steps are making that ci job multinode and testing cold migrate15:03
sean-k-mooneylooking at http://ciwatch.mmedvede.net/project?project=nova it seams somewhat statble although it is missing some patches15:04
*** belmoreira has joined #openstack-nova15:04
mriedemok here is the basic ops test https://github.com/LuyaoZhong/vpmem-tempest-plugin/blob/master/vpmem_tempest_plugin/tests/scenario/test_server_basic_ops.py#L12715:04
mriedemcreate a server, ssh into it, delete the server...15:04
mriedemso reboot + pmem isn't being tested15:05
stephenfinmriedem: https://review.opendev.org/#/c/694281/115:05
mriedemshelve/unshelve15:05
stephenfinI think that fixes the Python 3 issues, right?15:05
stephenfinOr have I missed something obvious?15:05
*** brinzhang_ has joined #openstack-nova15:06
sean-k-mooneymriedem: i suspect pause/unpause and suspend/resume are also missing15:06
stephenfinobviously converting things to zuul v3 native would be better though, of course, but maybe I should squash that back so we can continue working on the Python 3 only'ification in parallel15:06
mriedemstephenfin: looks like it does yeah, py3 is being used here https://zuul.opendev.org/t/openstack/build/2850353a84da4ec08b4f7cda7a08a781/log/logs/subnode-2/screen-n-cpu.txt.gz#315:07
sean-k-mooneymriedem: they have a resize test https://github.com/LuyaoZhong/vpmem-tempest-plugin/blob/master/vpmem_tempest_plugin/tests/scenario/test_server_pmem_ops.py#L10515:07
mriedemsean-k-mooney: that would be resize to the same host though15:07
stephenfin\o/15:07
sean-k-mooneyyes15:07
mriedemstephenfin: so you want to squash that into https://review.opendev.org/#/c/692374/ ?15:07
stephenfinyeah15:08
sean-k-mooneybut if resize on same host work then they should be able to resize to a different host no? if it was run multinode15:08
mriedemgo for it15:08
stephenfinthough maybe I should fix the devstack plugin first?15:08
*** mkrai has quit IRC15:08
* stephenfin wonders who maintains that/if it's maintained15:08
mriedemstephenfin: mostly the cinder core team15:08
mriedemhttps://review.opendev.org/#/admin/groups/1196,members15:08
stephenfinokay, they'll want this too so15:08
stephenfinI'll fix that and add depends-on15:08
* stephenfin does the needful15:08
luyaomriedem, efried : VPMEM CI is stable, but we haven't LM test yet.15:09
mriedemthe zuulv3 conversion of nova-live-migration gets super wonky with that post-test-script because the script assumes devstack-gate and still requires that for the nova-multinode-grenade job15:09
*** brinzhang has quit IRC15:09
mriedemso that's kind of why i'm tempted to convert nova-live-migration to zuulv3 and split it into two jobs, one with -ceph15:09
efriedluyao: I agree with mriedem that it would be good to expand the CI with more scenarios testing the existing code before adding LM support, see scrollback.15:10
mriedemluyao: could you start by making the pmem ci job multinode and adding a test for cold migrate?15:10
mriedemand shelve/unshelve15:10
stephenfinYeah, I spent the bones of a day pre-PTO trying to convert it and got nowhere so I'm glad you're working on it 😅15:10
stephenfinSplitting it up makes sense to me15:10
mriedemit was pretty easy until i got to the script15:11
mriedemwhich is a nightmare15:11
*** udesale has quit IRC15:11
luyaomriedem, efried : OK, I will start preparing more CI tests15:12
*** udesale has joined #openstack-nova15:13
efriedluyao: So I still think because of the RPC (and therefore upgrade) impacts, we should definitely have a short spec for LM. In that spec, we should state that moving forward with LM will be contingent on first demonstrating CI coverage for $stuff above.15:13
luyaoefried: get it, thanks15:14
huaqiangsean-k-mooney: about the per-vm-pci-NUMA-policy spec, I want to confirm that it defines a policy applied to all PCI devices for whole VM, right?15:15
gibi_offeandersson: hi! have you opened a bug for the false error log in case of https://github.com/openstack/nova/commit/a5269012a3b442a9e4055a7d523faff45f105f2b#diff-77f9348ab09642ba46409b6828af4af0R1327 being hit on an empty compute?15:15
stephenfinDumb question, but does Ubuntu allow you to install e.g. 'python-foo' and 'python3-foo' side-by-side without them stomping on each other?15:15
efriedstephenfin: shore15:15
* stephenfin assumes so since that works for pip/rpm but is not certain15:15
stephenfinkewl15:15
sean-k-mooneyhuaqiang: yes15:16
sean-k-mooneyhuaqiang: and it takes precidnce over the alias in the config15:16
sean-k-mooneyso it applies to both neutron sriov ports and to flavor based pci passthough15:16
huaqiangsean-k-mooney: then it is impossible to set three and more than three NUMA policies to PCI devices in a VM15:17
huaqiangand we have three PCI numa policies in total15:17
sean-k-mooneyif you mean you cant have different policies for different devices correct15:17
*** brinzhang_ has quit IRC15:18
huaqiangyes, that is I want to confirm15:18
sean-k-mooneythat is why its titled vm-scoped-sriov-numa-affinity15:18
*** brinzhang_ has joined #openstack-nova15:18
*** dpawlik has quit IRC15:19
sean-k-mooneyif we want to do interface scoped sriov polices we still can as a seperate qos policy on the neuton port15:19
sean-k-mooneyi would like to enable that too at some point but after this initall effort is done once we see if its required15:19
luyaoefried, mriedem: I have another question for "track error mirations and orphans in resource tracker", I think it is a bug, which have some effects on vpmem feature.  Do I need put all vpmem live migration stuff based on the bug fixed. I'm not sure how to address this bug at the moment. Could you help me figure it out, I sent an emaila few days ago.15:20
*** dviroel has joined #openstack-nova15:21
sean-k-mooneyluyao: i think those are two different topics15:22
luyaoI put my solution on this etherpad. I hope it is clear for you. We can discuss on the etherpad. https://etherpad.openstack.org/p/track-err-migr-and-orphans-in-RT15:22
efriedluyao: I'll try to look, but it sounds daunting. If you think there's a bug (vpmem notwithstanding) we would welcome a patch to fix it.15:23
*** tbachman has joined #openstack-nova15:23
sean-k-mooneyefried: part of it is a design choice. which is been adressed in a bugfix already15:24
huaqiangsean-k-mooney: Got. thanks15:25
sean-k-mooneyspecificly there is a patch to reap orpahanded vms that have a nova metada in there domain xml but were deleted in the db15:25
luyaoefried, sean-k-mooney : so I can do the vpmem live migration and bug fix parallelly,right?15:25
sean-k-mooneyas an extention to the existing periodic task15:25
efriedmriedem: https://review.opendev.org/#/c/694248/ FYI (wait to recheck patches failing requirements check until ^ merges)15:25
efried(per smcginnis)15:25
*** JamesBenson has joined #openstack-nova15:25
sean-k-mooneyluyao: provided you dont need to modify the same code sure even then you can factor out the common code into a shared patch15:26
sean-k-mooneyluyao: from a review persepective it will be simpler if they are seperate15:26
openstackgerritMatt Riedemann proposed openstack/nova master: docs: update SUSPENDED server status wrt supported drivers  https://review.opendev.org/69432915:27
mriedemefried: i'm not sure what you're showing me15:27
mriedemis that related to why my sqla-migrate change failed?15:28
efriedmriedem: the reqs job is broken until that merges. We've got a couple patches in the pipe that keep failing on reqs. yes.15:28
mriedemack, thanks15:28
*** maciejjozefczyk has joined #openstack-nova15:28
*** JamesBenson has quit IRC15:30
luyaosean-k-mooney: OK, get it, they should be  separate if  there is no surprise. :)15:30
*** JamesBenson has joined #openstack-nova15:31
*** JamesBenson has quit IRC15:31
*** JamesBenson has joined #openstack-nova15:32
*** shilpasd has quit IRC15:35
mriedemsean-k-mooney: did you ever write a functional test for trying to delete a compute service while a server is in VERIFY_RESIZE status for the host? i vaguely recall that coming up when i wrote test_evacuate_then_delete_compute_service15:44
*** mkrai has joined #openstack-nova15:45
openstackgerritStephen Finucane proposed openstack/nova master: Convert legacy nova-live-migration and nova-multinode-grenade to py3  https://review.opendev.org/69237415:45
sean-k-mooneyam no i rememebr that but i think i ended up getting pulled into something else15:45
sean-k-mooneyi think we were conserned the resize confim would fail if the source was deleted right15:46
sean-k-mooneybecause we would not be able to do the source host clean up15:47
mriedemlikely yes15:47
mriedemor same if the dest is deleted and you try to revert15:47
sean-k-mooneyya15:48
mriedemok i'll just write those tests today15:48
*** ociuhandu has joined #openstack-nova15:49
sean-k-mooneyill freely admint while is am begining to understand the functional test better of late i still am less comfortable writing them then i woudl like to be15:49
*** TxGirlGeek has joined #openstack-nova15:49
mriedemcopy/paste/modify15:49
mriedemthat + stackforge = highly paid professional software engineer15:50
sean-k-mooneyya so that i can do but im trying to understand some of the fixture and how they related a llitle more os if i need to write one i can15:50
*** ociuhandu has quit IRC15:50
mriedemwell, the best way to learn is to get started15:50
sean-k-mooneyhehe which is a good segway for me to go back to writign the ones you asked for yesterday15:51
*** ociuhandu has joined #openstack-nova15:52
sean-k-mooneywhen i do have them working they are a nice way to test the code. bauzas has been suggestign we try to do more test driven developemnt usign functional tests15:52
sean-k-mooneyi do tend to rely on deploying things on really hardware or nested vert more then i proably should in my intally dev sometimes15:53
* bauzas looks15:54
sean-k-mooneybauzas: might also be motivated by a lack of hardware to test his things15:56
*** ociuhandu has quit IRC15:57
openstackgerritLee Yarwood proposed openstack/nova-specs master: Boot from volume instance rescue  https://review.opendev.org/69406315:59
openstackgerritStephen Finucane proposed openstack/nova master: Stop testing Python 2  https://review.opendev.org/68795416:00
*** nanzha has quit IRC16:00
*** belmoreira has quit IRC16:01
*** ivve has quit IRC16:02
*** brinzhang has joined #openstack-nova16:06
openstackgerritStephen Finucane proposed openstack/nova master: Convert legacy nova-live-migration and nova-multinode-grenade to py3  https://review.opendev.org/69237416:06
openstackgerritStephen Finucane proposed openstack/nova master: Stop testing Python 2  https://review.opendev.org/68795416:06
*** brinzhang has quit IRC16:07
*** brinzhang has joined #openstack-nova16:08
openstackgerritStephen Finucane proposed openstack/nova master: zuul: Make functional job inherit from openstack parents  https://review.opendev.org/68842516:08
*** brinzhang has quit IRC16:09
*** brinzhang_ has quit IRC16:09
*** brinzhang has joined #openstack-nova16:09
*** brinzhang has quit IRC16:10
*** gyee has joined #openstack-nova16:11
*** xek_ has joined #openstack-nova16:14
*** xek has quit IRC16:14
openstackgerritLee Yarwood proposed openstack/os-traits master: Add COMPUTE_RESCUE_BFV trait  https://review.opendev.org/69403316:18
*** ccamacho has quit IRC16:19
mriedemlyarwood: i've got some things for your stable rescue disk device spec https://review.opendev.org/#/c/693849/16:20
*** ricolin has quit IRC16:20
lyarwoodmriedem: ack thanks, just in yet another meeting, will review once this ends.16:21
mriedemi should likely open a docs bug b/c we don't have any documentatoin about rescue16:22
*** mlavalle has joined #openstack-nova16:22
mriedemi guess https://docs.openstack.org/nova/latest/user/reboot.html kind of16:23
*** macz has joined #openstack-nova16:24
lyarwoodmriedem: yeah we can break that out into a seperate section tbh16:25
* lyarwood is happy to look into that as part of this spec16:25
mriedemhow about just a docs bug https://bugs.launchpad.net/nova/+bug/185260916:27
openstackLaunchpad bug 1852609 in OpenStack Compute (nova) "Reboot an instance in nova - split the rescue part out" [Undecided,New]16:27
*** udesale has quit IRC16:33
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1852610  https://review.opendev.org/69435116:39
openstackbug 1852610 in OpenStack Compute (nova) "API allows source compute service/node deletion while instances are pending a resize confirm/revert" [Medium,Triaged] https://launchpad.net/bugs/185261016:39
*** yan0s has quit IRC16:40
*** gshippey has joined #openstack-nova16:47
*** amodi has joined #openstack-nova16:55
mriedemdansmith: how are you feeling (besides gross) about this filter duplicate migrations change https://review.opendev.org/#/c/636224/ ? is there anything you want me to do there besides burn it all down and start over?16:56
openstackgerritArchit Modi proposed openstack/nova stable/queens: doc: fix and clarify --block-device usage in user docs  https://review.opendev.org/69435716:56
*** TxGirlGeek has quit IRC16:56
dansmithbesides, gross.. hmm.. is "procrastinatey" a word?16:57
mriedemit is now16:57
mriedemif we want to genericify that i can move it to NovaBase later16:58
*** TxGirlGeek has joined #openstack-nova16:58
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'os-consoles' API  https://review.opendev.org/68790716:58
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'nova-console' service, 'os-consoles' API  https://review.opendev.org/68790816:58
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'nova-xvpvncproxy'  https://review.opendev.org/68790916:58
*** TxGirlGeek has quit IRC16:59
dansmithmriedem: honestly, I want someone else to +W that so I can happily move onto the later patches and forget about it16:59
mriedemstephenfin: efried: ^17:00
*** KeithMnemonic has joined #openstack-nova17:00
stephenfinin a meeting, but I'll take a look after (if efried doesn't grab it first)17:01
*** ociuhandu has joined #openstack-nova17:01
*** TxGirlGeek has joined #openstack-nova17:02
bauzasefried: around ?17:03
*** rpittau is now known as rpittau|afk17:04
bauzasefried: I was evaluating how much checking the COMPUTE_NODE trait would help the placement audit command https://review.opendev.org/#/c/67011217:04
dansmithmriedem: replied about the upgrade aspect on that stable rescue thing17:05
dansmithmriedem: not sure if you saw the previous discussion on that spec about it, but once I found out those properties already exist I figured there's no point in trying to be strict about them now, and it's actually less compatible if we do, since they're silently ignored today17:05
mriedemtrue they are silently ignored today, they also aren't documented so i'm not sure anyone would know to use them17:07
*** ociuhandu has quit IRC17:07
dansmithmriedem: yeah, so I figure if someone did have them in an image today, found out they didn't work, left them, then started to upgrade...shit stops working for no obvious reason17:07
dansmith(until fully upgraded)17:08
openstackgerritArchit Modi proposed openstack/nova stable/queens: doc: fix and clarify --block-device usage in user docs  https://review.opendev.org/69435717:09
openstackgerritArchit Modi proposed openstack/nova stable/queens: Revert "openstack server create" to "nova boot" in nova docs  https://review.opendev.org/69323917:09
mriedemreplied in the spec17:10
mriedemit might just be that the documented replies to my questions/edge cases are done in a follow up i could drop the -117:10
mriedemas it reads today, the spec is very much like "if you're using libvirt and everything is fully upgraded, you're golden" but i think it's worth documenting if those aren't true and what happens17:11
mriedemplus there is no liaison and that's just like, -517:11
*** mkrai has quit IRC17:12
dansmithmriedem: well, fwiw, I asked him to remove the hard fail, and also encouraged him to remove some of the upgrade impact,17:13
dansmithwell, nevermind, that's more the BFV one17:13
dansmithanyway, whatever17:14
mriedemok. i'm just asking that rather than remove things and leave questions (which i obviously had b/c it wasn't documented), i'm asking that we're clear about intent17:14
mriedemso in a year or 2 people aren't like, "why does it work this way? was x considered?"17:14
dansmithyeah, not arguing against that,17:15
*** damien_r has quit IRC17:15
dansmithmore like hoping I didn't lead him too astray asking him to pare down some of it, specifically around the start-failing-when-we-didn't-before stuff17:15
*** tesseract has quit IRC17:15
mriedemack17:15
mriedemnever lead sweet lee astray17:15
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional recreate revert resize test for bug 1852610  https://review.opendev.org/69436417:18
openstackbug 1852610 in OpenStack Compute (nova) "API allows source compute service/node deletion while instances are pending a resize confirm/revert" [Medium,Triaged] https://launchpad.net/bugs/185261017:18
mriedemsean-k-mooney: ^ and the one below it are the tests we talked about17:20
efriedbauzas: Hi, here now, sorry.17:21
bauzasefried: no worries17:21
bauzasefried: traits from a root RP aren't automatically cascaded to their siblings, right?17:22
efriedcorrect17:22
bauzasefried: because I really want to iterate over the list of RPs17:22
efriedsiblings/descendants17:22
bauzasso in a world with nested RPs, I'll look over every RP and call its root RP to see whether it's COMPUTE_NODE17:23
efriedbauzas: I need to remind myself what you're doing here. If you really just want the compute node RPs, you ought to be able to do it with GET /resource_providers?required=COMPUTE_NODE17:23
efriedand not need to iterate17:23
bauzasefried: I want to look at every RP to see whether it has orphaned allocs17:23
bauzasefried: scrubbing if you prefer17:24
*** jangutter has quit IRC17:24
*** ivve has joined #openstack-nova17:24
*** ociuhandu has joined #openstack-nova17:25
mriedemhow are you going to determine that for nested providers?17:25
bauzasand for that, I'm 1/ looking at the RP, 2/ ask for its allocs, 3/ see whether those allocs are compute-related (and I was using RCs for this, but I could use traits), 4/ get instances and migrations from the compute it relases, 5/ do the comparison17:25
bauzasmriedem: the code I wrote atm is getting the root RP and get its instance and migrations17:25
mriedemtrying to build in support for nested providers from the first iteration of that audit command seems like something that will keep it from ever getting done17:25
bauzasmriedem: and then only comparing allocations of RCs we manage17:25
mriedembauzas: but like efried just said, you can get the compute node roots today17:26
bauzasmriedem: that doesn't really overcomplexify the logic17:26
mriedemor with that trait i guess17:26
mriedemso, "i want to do x but the slow way"17:26
bauzasmriedem: yup, that's what I'm changing as of now, instead of looking at Nova RCs, I'm just looking whether the root RP is havint the trait17:26
bauzashaving*17:26
efriedOkay, that was the missing piece: if we're truly not trying to implement support for nested (or sharing) then using the trait will get you back all and only roots in one query.17:26
efriedthough I'm not fully grasping why we wouldn't include logic for nested right now.17:27
mriedemefried: i'm not saying those aren't cases to consider, but i wouldn't in v117:27
mriedemefried: he's been working on this for like a year17:27
bauzasmriedem: the current patch is managing nested17:27
efriedheh17:27
sean-k-mooneymriedem: thanks i have added them to my review list17:27
bauzasmriedem: nah, I was working on it since maybe 3 weeks of time17:27
bauzasand I just want to get rid of it17:28
mriedembauzas: but you've been *talking* about this audit command for a long time17:28
bauzasoh hell yeah17:28
mriedemso you know, i'm just saying shit or get off the pot17:28
mriedemdo the more complex stuff in v217:28
bauzasI can split the change17:28
mriedemfwiw heal_allocations still doesn't supported nested17:28
bauzasthe change is actually already big17:28
mriedemwell, except qos ports which gibi added and that took awhile17:29
mriedembauzas: right that's my point17:29
bauzasmakes sens17:29
bauzassense*17:29
bauzasI'll try to split into two17:29
* bauzas now has to switch over to bug triage (internally)17:29
*** TxGirlGeek has quit IRC17:32
* artom can't help but think of the flavor explosion ML thread as an advertisement for chewing gym.17:32
bauzasartom: we really wanted to leave it optional17:34
bauzasI mean, that would be a totally separate and desperate API17:34
bauzasall words thought17:35
mriedemgum?17:35
mriedemjim?17:35
mriedemare you chewing on jroll?!17:35
jrollO_o17:35
jrollpls don't.17:35
mriedemjroll requires consent to be chewed upon17:35
jrollmy baby bites me enough as it is17:35
mriedembabies are like puppies, just give it a chew toy17:36
mriedemand let it poop somewhere random17:36
jrollindeed17:36
bauzasmriedem: I guess you saw the flavor explosion thread17:38
mriedemi'm not getting involved17:38
bauzasmriedem: most of the crux is to say : "whatever you want, make it not impactful to any other API that already exists, and don't change what a flavor means"17:39
bauzashah, that was dansmith and efried, my bad :)17:39
*** TxGirlGeek has joined #openstack-nova17:41
efriedI need to catch up on that thread, but unless we got a bunch of hands in the air in the last two weeks saying "Oh, I love this and I'm gonna use it in my cloud," I'm still likely to think it's not worth the effort to implement.17:41
*** TxGirlGeek has quit IRC17:41
*** TxGirlGeek has joined #openstack-nova17:42
*** TxGirlGeek has quit IRC17:42
dansmithnone of my deeply-rooted concerns are addressed in the discussion17:42
dansmithmore definition of how it's expected to be used (although still missing stuff),  but nothing about how to provide some affinity17:43
dansmithand I'm super concerned about altering this fundamental part of nova, especially without serious planning17:43
bauzasefried: sounded like people were interested in, including mnaser17:43
bauzasdansmith: that's the reason why we asked to *not* change the notion of a flavor17:44
bauzasa flavor remains a flavor17:44
bauzasthey can compose bits of something, but the result of this API is a flavor17:45
dansmithyep, and that helps, but it still brings a lot of complexity to everything that looks at flavors (which is lots of stuff) and also, with no affinity, it's just a toy for single-tenant clouds where everyone is trusted, IMHO17:45
efrieddansmith: I all along have assumed that backward compat of current flavor usage would not be affected, period. Agree that part is worth -1ing all day until addressed in the spec. My -2 was for "not worth the effort" -- but if folks are clamoring, I can be persuaded otherwise.17:45
bauzasdansmith: honestly, that's why I don't want this to be in for example POST /servers17:45
bauzasit would be just a os-stuff-my-flavor API, that's it17:45
mriedemaren't you describing basically a flavor template?17:46
dansmithefried: keeping the flavor whole helps the loss of feature, but doesn't help needing to touch everywhere that handles flavors17:46
bauzasmriedem: -ish17:46
mriedemwouldn't a flavor template be a lot simpler?17:46
mriedemcreate a flavor based on a generic template with extra specs and then override whatever things are unique to that flavor17:47
efrieddansmith: Also been assuming/pushing for the composition to happen just once, at spawn time, whereupon all the contents go into the instance's existing flavor record.17:47
bauzasmriedem: that's one of the approaches17:47
mriedemthough that doesn't help with the explosion17:47
bauzasmriedem: correct, and we said that too17:47
mriedemnested flavors!17:47
efriedThat (composition at spawn only) hits POST /servers, but nothing else. No explosion.17:47
bauzasI just feel people want a Domino's Make-My-Pizza generator thingy17:48
mriedemefried: if you add it to spawn people are going to want it in resize also17:48
efriedyes17:48
bauzasthat's a reasonable concern17:48
dansmithI think people that want the pair-anything-with-anything also don't realize how much that is going to kill their packing and capacity planning,17:48
efriedokay, but not "everywhere that touches flavors" (internally).17:48
bauzasdansmith: I exacly had that concern !17:48
dansmithso when we do that, it will be not very usable even by the people that think they want it, and we will have to iterate17:48
bauzasdansmith: and I said 'well, let's not overthink over that API, it's the operator's responsibility to stuff in it'17:49
mriedembauzas: do they counter the capacity management argument with "we'll just use watcher to fix things in post"17:49
bauzaswatcher never went into discussion17:49
*** amodi has quit IRC17:52
*** TxGirlGeek has joined #openstack-nova17:59
*** ociuhandu has quit IRC18:00
*** ociuhandu has joined #openstack-nova18:05
*** mvkr has quit IRC18:10
openstackgerritsean mooney proposed openstack/nova master: block rebuild when numa topology changed  https://review.opendev.org/68795718:11
openstackgerritsean mooney proposed openstack/nova master: Disable NUMATopologyFilter on rebuild  https://review.opendev.org/68986118:11
*** maciejjozefczyk has quit IRC18:15
*** lpetrut has quit IRC18:15
*** dviroel has quit IRC18:20
*** awalende has quit IRC18:25
*** awalende has joined #openstack-nova18:25
*** dave-mccowan has quit IRC18:26
*** ralonsoh has quit IRC18:28
*** awalende has quit IRC18:29
*** artom has quit IRC18:32
*** dave-mccowan has joined #openstack-nova18:34
*** jaosorior has quit IRC18:34
efriedWhat does "signed-off-by" actually mean in a commit message, to those who care about it?18:37
jrollefried: it means it was signed by that person's GPG key18:38
jrollwait, no18:38
jrollhttps://git-scm.com/docs/git-commit#Documentation/git-commit.txt--s18:39
efriedspecifically for the vtpm patch, which bears almost no resemblance to when it was last touched by cfriesen or Paul-Emile, I'm wondering if I should remove their Signed-off-by lines18:39
jrollI think I would18:40
efriedI was actually considering putting it under a new change-id.18:40
efriedbut decided no harm in having the history in one place.18:40
*** amodi has joined #openstack-nova18:40
dansmithefried: S-o-B is a legal construct from the linux kernel community18:40
dansmithefried: it's their accepted mechanism to declare that you have permission to submit the code you're submitting18:41
dansmithsome people have hooks in their git config to add it automatically, and/or some orgs may require people to put it in there regardless of the community for some perceived legal shield18:41
efriedOkay. So it's really only relevant when it's the same as the uploader for a given patch set, because otherwise it's n/a whether you have permission to submit, because you're not submitting.18:42
dansmithwell, not quite18:42
efriedReally in the case of openstack gerrit, you've already declared that by signing the things, which are a prereq to being able to submit code at all.18:42
dansmithright which is why it's just noise for our patches18:43
dansmithand really shouldn't be in there18:43
efriedack, makes sense. I'll just axe it.18:43
openstackgerritEric Fried proposed openstack/nova master: WIP: Add emulated TPM support to Nova  https://review.opendev.org/63136318:43
openstackgerritEric Fried proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files  https://review.opendev.org/63993418:43
efriedjroll: I should do a visual inspection quick, but I think the bottom patch ^ is "done" from the impl & docs side. Test is basically not started, but if you want to skim the non-test bits and let me know if anything stands out horribly, that would be helpful.18:44
*** xek__ has joined #openstack-nova18:45
efrieddansmith: I fully expect you to say "split this sucker".18:45
jrollefried: can do today or tomorrow sometime18:45
efriedjroll: cool, thanks.18:45
*** ociuhandu has quit IRC18:45
dansmithefried: noted18:45
*** ociuhandu has joined #openstack-nova18:46
*** jdillaman has quit IRC18:46
*** xek_ has quit IRC18:47
*** ociuhandu has quit IRC18:52
sean-k-mooneyby the way anyone know what might be preventing us form using self.assertRaises in nova as a context manager18:53
sean-k-mooneyi have worked around it for now18:53
sean-k-mooneybut i suspect we have some legcy code form the py2.6 days18:54
*** igordc has joined #openstack-nova18:54
sean-k-mooneyim doing  "with self.assertRaisesRegex(ValueError, '.*'):" instead for now18:54
*** TxGirlGeek has quit IRC18:59
*** TxGirlGeek has joined #openstack-nova19:04
*** henriqueof has quit IRC19:05
efrieddansmith, mriedem: offhand, do you have a problem adding a context param to the `unrescue` compute driver method?19:07
efriedWill heads-up the ML etc.19:07
dansmithwhat I have a problem with is notifying the ML when we change an internal interface19:07
dansmithbut otherwise, no19:07
sean-k-mooneywell its a heads up not asking permission but i get what you mean19:08
efriedHeh, it has ever been thus.19:08
efriedI have the scars from my initial contact with nova when the oot powervm driver was my whole world.19:09
sean-k-mooneyi ment the ml message by they way19:09
sean-k-mooneyyes is anyone looking after that now19:10
sean-k-mooneyi found out recently a vendor is bypassing the blocks we put in place to prevent people form import stuff form the os-vif internal module19:11
efriedyeah, there's a new team struggling to come to grips with it.19:11
efriedbarely treading water keeping up with nova changes that break it, and still trying to resurrect the CI.19:11
* sean-k-mooney is still waiting untill ibm power becomes a redhat problem to maintian ...19:14
mriedemit's only a problem for tonyb19:15
openstackgerritMerged openstack/nova master: Filter duplicates from compute API get_migrations_sorted()  https://review.opendev.org/63622419:22
openstackgerritMatt Riedemann proposed openstack/nova master: Block deleting compute services with in-progress migrations  https://review.opendev.org/69438919:24
*** TxGirlGeek has quit IRC19:25
* efried ==> food19:28
*** TxGirlGeek has joined #openstack-nova19:28
openstackgerritMatt Riedemann proposed openstack/nova master: Block deleting compute services with in-progress migrations  https://review.opendev.org/69438919:30
*** abaindur has quit IRC19:37
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Fail compute service delete if resource provider delete fails  https://review.opendev.org/67810019:43
*** zbr is now known as zbr|ooo19:46
*** k_mouza has joined #openstack-nova19:48
*** k_mouza has left #openstack-nova19:49
openstackgerritMerged openstack/nova master: Start functional testing for cross-cell resize  https://review.opendev.org/63625319:52
openstackgerritMerged openstack/nova master: Helper to start computes with different HostInfos  https://review.opendev.org/68683219:52
*** mriedem has quit IRC19:55
*** mriedem has joined #openstack-nova19:57
mriedemdansmith: can you hit these 3 bug fix backports to train from gibi https://review.opendev.org/#/q/owner:balazs.gibizer%2540est.tech+status:open+project:openstack/nova+branch:stable/train ?20:11
mriedemi think at least 2 of those still have to go to stein20:11
*** abaindur has joined #openstack-nova20:13
efriedmriedem: grenade seems very ill lately. Do we have any idea what the deal is, yo?20:14
dansmithmriedem: so, there was a bug recently under security review that makes me think about this stuff now...20:16
mriedemefried: yes20:16
mriedemefried: have you seen my recent state of the gate thread?20:16
mriedemdansmith: the qos ports stuff?20:17
efriedmriedem: Recent like a week or two ago? Yes.20:17
mriedemefried: yeah halloween20:17
dansmithmriedem: any chance the user could provide someone else's port id and get access to it or even just validate that they guessed right?20:17
mriedemefried: same problems, no progress20:17
efriedmmph20:17
dansmithmriedem: I'm not sure what the actual call path on this actual patch is,20:17
mriedemdansmith: provide where? during server create?20:17
dansmithbut the move to using an admin client makes me think..20:17
dansmithmriedem: either there or anything that calls this20:18
mriedemports are under a project so you'd have to be able to GET the port given your token20:18
mriedemfwiw we use admin client all over the place for dealing with ports b/c the binding stuff is admin-only by default policy in neutron20:19
dansmithmriedem: I know we do and that was the problem this other bug indicated20:19
mriedemi think the resource_request stuff is the same issue - admin only like port binding details20:19
dansmithI don't understand how we've gotten to this point but it seems kinda wrong20:20
mriedemif it makes you feel better, ports are better protected than volume attachments - those leak host connector details weeeee20:21
mriedemhttps://bugs.launchpad.net/cinder/+bug/174095020:21
openstackLaunchpad bug 1740950 in Cinder "Volume details shows attached compute host for non-admins" [Undecided,New]20:21
sean-k-mooneythe port binding_profile is admin only by default as only  nova or ironic e.g. not an end user should ever write to it20:22
sean-k-mooneyand the binding_detials are readonly i think20:22
*** ociuhandu has joined #openstack-nova20:22
*** eharney has quit IRC20:22
mriedemthe volume attachment stuff is admin or owner ever since the nova/cinder split20:23
mriedembecause that's how nova gets the connection_info and passes the host connector20:23
mriedemchanging that now would break a lot of deployments unless they configured nova with service creds to talk to cinder with an admin role, which is what we've required for working with neutron b/c of port binding details since forever20:23
sean-k-mooneyya whcih is not ideal as that  means your ceph mon ips/fqdns are exposed20:23
sean-k-mooneyamong other things20:24
*** eharney has joined #openstack-nova20:24
*** henriqueof has joined #openstack-nova20:26
*** abaindur has quit IRC20:28
*** abaindur has joined #openstack-nova20:28
dansmithmriedem: I hope it's clear that I'm not arguing that this is doing something new, or not consistent with behavior "since forever", just that the other bug made me think about how often we use the neutron admin client to do stuff on behalf of the user and wonder why that's not a problem20:29
*** ociuhandu has quit IRC20:30
*** eharney has quit IRC20:30
mriedemi suspect it's not a problem b/c the non-admin can't GET the port details with the host binding details20:31
sean-k-mooneydansmith: in the port bining case you are not exactly doing it on behalf of the user in all cases. nova is setting admin only filed to comninciate infomation to neutron that the network backend needs to know to wire up the port that the teant should not known20:31
sean-k-mooneymriedem: yep20:31
mriedemunlike that volume attachment bug20:32
dansmithsean-k-mooney: yeah, understand that for the binding case20:32
sean-k-mooneyfor what its wroth im not realy sure why we chose to make the port resouce requests admin only20:33
sean-k-mooneythe allocations sure20:33
mriedemhuh, looks like as a non-admin I can also do GET /v3/{project_id}/attachments/{attachment_id} on any volume attached to my server and get the host connection info20:33
mriedemwhich is great20:33
sean-k-mooneywell that is needed for standalone cinder20:34
mriedemheh20:34
mriedemok20:34
mriedem..20:34
mriedemthere is no policy rule on GET /v3/{project_id}/attachments/{attachment_id}20:34
openstackgerritMerged openstack/nova master: libvirt: Ignore DiskNotFound during update_available_resource  https://review.opendev.org/68539120:34
sean-k-mooneyi assume you mean the conintion info20:34
openstackgerritMerged openstack/nova master: Log reason for remove_host action failing  https://review.opendev.org/69283320:34
mriedemi would assume that standalone cinder would be single tenant with admin access to everything20:34
openstackgerritMerged openstack/nova master: docs: update SUSPENDED server status wrt supported drivers  https://review.opendev.org/69432920:34
mriedemsean-k-mooney: yes, connection_info20:34
*** artom has joined #openstack-nova20:38
*** jbernard has quit IRC20:39
sean-k-mooneyoh i remember why we made port resouce request admin only20:40
sean-k-mooneyits so you can request random crap via the port20:41
sean-k-mooneyah the made it readonly https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/port_resource_request.py#L31-L3420:41
sean-k-mooneygood20:41
mriedemrandom crap is the best kind of nfv crap20:43
openstackgerritArchit Modi proposed openstack/nova stable/queens: Revert "openstack server create" to "nova boot" in nova docs  https://review.opendev.org/69323920:44
amodimriedem: https://review.opendev.org/#/c/694357/2 i think this is ready to be merged and then the above ^^ one20:45
openstackgerritEric Fried proposed openstack/nova-specs master: Spec: Ussuri: Encrypted Emulated Virtual TPM  https://review.opendev.org/68680420:45
efriedjohnthetubaguy, mriedem (as approvers of the original stein spec), dansmith (because we've been talking about it): This spec ^ is ready for your discerning eyes. Please and thank you.20:47
efriedjroll: minor updates, fyi ^20:48
jrollnoted20:48
openstackgerritMatt Riedemann proposed openstack/nova stable/queens: Revert "openstack server create" to "nova boot" in nova docs  https://review.opendev.org/69323920:51
*** slaweq has quit IRC20:52
mriedemamodi: done20:52
amodithanks!20:52
mriedemefried: i don't even remember approving those. i think it was someone that hacked my account.20:52
efriedmriedem: This ain't discover card. You ARE responsible for charges made on your account.20:53
openstackgerritMatt Riedemann proposed openstack/nova master: Reset vm_state to original value if rebuild claim fails  https://review.opendev.org/69218520:58
*** gshippey has quit IRC21:09
*** slaweq has joined #openstack-nova21:09
*** henriqueof has quit IRC21:10
*** eharney has joined #openstack-nova21:17
*** slaweq has quit IRC21:18
*** henriqueof has joined #openstack-nova21:19
tonybmriedem, sean-k-mooney: Not if I do my job right.  It'll be everyone's problem21:27
sean-k-mooneypower i could live with if they gave me a machine. im not sure i would have room for a mainframe in my hallway21:28
*** rcernin has joined #openstack-nova21:28
sean-k-mooneyso z is not a think i want to deal with21:29
*** TxGirlGeek has quit IRC21:29
openstackgerritEric Fried proposed openstack/nova master: WIP: Add emulated TPM support to Nova  https://review.opendev.org/63136321:29
openstackgerritEric Fried proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files  https://review.opendev.org/63993421:29
tonybsean-k-mooney: Well I'd hope you have access to some at work, at home you're on your own but https://www.raptorcs.com/TALOSII/ is about the same price I paid for my x86_64 dev box21:30
sean-k-mooneyya i have seen those before21:30
*** slaweq has joined #openstack-nova21:33
*** henriqueof has quit IRC21:33
*** henriqueof has joined #openstack-nova21:34
sean-k-mooneytonyb: im sure there is a less painful way to get acesss to hardware at work but i generally do all my deve either my my personal server i bought or on my laptop in a vm where i fake out numa toploiges with libvirt21:36
sean-k-mooneytechnically i could also just fake a power system that way too i guess i just would be slow without kvm21:36
tonybsean-k-mooney: Yes it works but is slow21:37
sean-k-mooneyya its just because kvm only supprot acclerate of your native instruction set21:38
tonybyeah TCG is nice but slow21:39
sean-k-mooneyhave you played with the multi threaded tcg backend e.g. mttcg21:39
*** nweinber_ has quit IRC21:39
sean-k-mooneythats actully not bad in the little i have used it21:39
tonybNo, I didn't know that existed21:40
sean-k-mooneyyou need really new qemu21:40
tonybI have F30, is that new enough?21:40
sean-k-mooneyit was added for acclerating other architure mainly arm21:40
sean-k-mooneyi can check. it getts enabeld automaticaly if you cpu model is supproted21:41
*** slaweq has quit IRC21:41
tonybI'll go googling ;p21:41
sean-k-mooneyoh looks like you can force it too now https://wiki.qemu.org/Features/tcg-multithread21:41
sean-k-mooneylooks like aarch64 was in 2.921:43
sean-k-mooneynot sure if power has been added21:43
* tonyb will look21:43
*** igordc has quit IRC21:45
*** jaosorior has joined #openstack-nova21:45
*** igordc has joined #openstack-nova21:45
sean-k-mooneylook like mips,arm,aarch64,x86_64 and aplha have support in the latest version but no power supprot at elast form the release notes21:48
tonybPfft21:48
*** artom has quit IRC21:52
openstackgerritMerged openstack/nova master: Join migration_context and flavor in Migration.instance  https://review.opendev.org/68984621:57
openstackgerritMerged openstack/nova master: Improve metadata server performance with large security groups  https://review.opendev.org/65608421:57
*** henriqueof has quit IRC21:58
*** henriqueof has joined #openstack-nova22:00
*** TxGirlGeek has joined #openstack-nova22:00
*** TxGirlGeek has quit IRC22:00
*** henriqueof has quit IRC22:00
*** slaweq has joined #openstack-nova22:01
*** ociuhandu has joined #openstack-nova22:02
*** jaosorior has quit IRC22:02
*** jaosorior has joined #openstack-nova22:03
sean-k-mooney...22:04
sean-k-mooneyi was just about to push and then call it a day and now i have a merg conflcit22:04
*** slaweq has quit IRC22:05
*** slaweq has joined #openstack-nova22:06
openstackgerritsean mooney proposed openstack/nova master: support pci numa affinity policies in flavor and image  https://review.opendev.org/67407222:06
openstackgerritMatt Riedemann proposed openstack/nova stable/train: Join migration_context and flavor in Migration.instance  https://review.opendev.org/69440822:06
sean-k-mooneyill fix that tomorrow but it now has the func tests and artoms nits adressed22:07
openstackgerritMatt Riedemann proposed openstack/nova stable/train: Improve metadata server performance with large security groups  https://review.opendev.org/69440922:07
*** eharney has quit IRC22:08
*** TxGirlGeek has joined #openstack-nova22:09
*** ociuhandu has quit IRC22:11
*** slaweq has quit IRC22:18
sean-k-mooneyactully it looks trivial ill fix it now22:18
openstackgerritsean mooney proposed openstack/nova master: support pci numa affinity policies in flavor and image  https://review.opendev.org/67407222:19
*** slaweq has joined #openstack-nova22:29
*** kaisers1 has joined #openstack-nova22:32
*** kaisers has quit IRC22:33
*** slaweq has quit IRC22:34
*** JamesBenson has quit IRC22:35
*** slaweq has joined #openstack-nova22:39
*** slaweq has quit IRC22:45
*** slaweq has joined #openstack-nova22:48
*** jaosorior has quit IRC22:51
*** tkajinam has joined #openstack-nova22:54
*** slaweq has quit IRC23:00
*** dave-mccowan has quit IRC23:02
*** slaweq has joined #openstack-nova23:11
*** mvkr has joined #openstack-nova23:11
*** ivve has quit IRC23:14
*** KeithMnemonic has quit IRC23:15
*** slaweq has quit IRC23:16
*** dave-mccowan has joined #openstack-nova23:18
*** xek__ has quit IRC23:27
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Store instance action event exc_val fault details  https://review.opendev.org/69442823:30
*** ociuhandu has joined #openstack-nova23:31
*** slaweq has joined #openstack-nova23:31
*** ociuhandu has quit IRC23:35
*** slaweq has quit IRC23:39
*** zhubx has quit IRC23:48
*** boxiang has joined #openstack-nova23:49
*** mdbooth has quit IRC23:52
*** slaweq has joined #openstack-nova23:53
*** mdbooth has joined #openstack-nova23:54
*** zhanglong has joined #openstack-nova23:56
*** slaweq has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!