*** ociuhandu has quit IRC | 00:01 | |
*** owalsh has quit IRC | 00:03 | |
*** owalsh has joined #openstack-nova | 00:03 | |
*** rcernin_ has joined #openstack-nova | 00:04 | |
*** owalsh_ has joined #openstack-nova | 00:05 | |
*** rcernin has quit IRC | 00:07 | |
*** owalsh has quit IRC | 00:08 | |
*** ociuhandu has joined #openstack-nova | 00:10 | |
*** ociuhandu has quit IRC | 00:14 | |
*** artom has joined #openstack-nova | 00:16 | |
*** ociuhandu has joined #openstack-nova | 00:17 | |
*** artom has joined #openstack-nova | 00:17 | |
*** rcernin_ has quit IRC | 00:19 | |
*** ociuhandu has quit IRC | 00:21 | |
*** ociuhandu has joined #openstack-nova | 00:23 | |
*** gyee has quit IRC | 00:24 | |
*** rcernin has joined #openstack-nova | 00:27 | |
*** ociuhandu has quit IRC | 00:28 | |
*** awalende has joined #openstack-nova | 00:28 | |
*** dave-mccowan has joined #openstack-nova | 00:29 | |
*** gshippey has quit IRC | 00:29 | |
*** ociuhandu has joined #openstack-nova | 00:31 | |
*** dave-mccowan has quit IRC | 00:33 | |
*** awalende has quit IRC | 00:33 | |
*** ociuhandu has quit IRC | 00:36 | |
*** dave-mccowan has joined #openstack-nova | 00:36 | |
*** Sundar has quit IRC | 00:39 | |
*** ociuhandu has joined #openstack-nova | 00:41 | |
*** ociuhandu has quit IRC | 00:46 | |
*** zhanglong has joined #openstack-nova | 00:47 | |
*** brinzhang has joined #openstack-nova | 00:50 | |
*** ociuhandu has joined #openstack-nova | 00:51 | |
*** dave-mccowan has quit IRC | 00:52 | |
*** ociuhandu has quit IRC | 00:57 | |
*** ociuhandu has joined #openstack-nova | 01:02 | |
*** ociuhandu has quit IRC | 01:06 | |
*** ircuser-1 has joined #openstack-nova | 01:07 | |
*** ociuhandu has joined #openstack-nova | 01:12 | |
*** ociuhandu has quit IRC | 01:16 | |
*** Liang__ has joined #openstack-nova | 01:18 | |
*** ociuhandu has joined #openstack-nova | 01:21 | |
*** zhanglong has quit IRC | 01:25 | |
*** ociuhandu has quit IRC | 01:26 | |
*** zhanglong has joined #openstack-nova | 01:27 | |
*** huaqiang_ has quit IRC | 01:28 | |
*** ociuhandu has joined #openstack-nova | 01:29 | |
*** huaqiang has joined #openstack-nova | 01:35 | |
*** ociuhandu has quit IRC | 01:37 | |
*** larainema has joined #openstack-nova | 01:38 | |
*** ociuhandu has joined #openstack-nova | 01:42 | |
*** ociuhandu has quit IRC | 01:47 | |
*** ociuhandu has joined #openstack-nova | 01:49 | |
openstackgerrit | xulei proposed openstack/nova master: Optimization for nova-api _checks_for_create_and_rebuild https://review.opendev.org/698125 | 01:49 |
---|---|---|
*** ociuhandu has quit IRC | 01:57 | |
*** ociuhandu has joined #openstack-nova | 02:08 | |
*** nicolasbock has quit IRC | 02:10 | |
*** ociuhandu has quit IRC | 02:13 | |
*** ociuhandu has joined #openstack-nova | 02:14 | |
*** slaweq has joined #openstack-nova | 02:17 | |
*** abaindur has quit IRC | 02:21 | |
*** brinzhang_ has joined #openstack-nova | 02:22 | |
*** slaweq has quit IRC | 02:22 | |
*** ociuhandu has quit IRC | 02:22 | |
*** igordc has quit IRC | 02:24 | |
*** brinzhang has quit IRC | 02:25 | |
*** zhanglong has quit IRC | 02:27 | |
*** zhanglong has joined #openstack-nova | 02:32 | |
*** lvbin01 has quit IRC | 02:36 | |
*** ociuhandu has joined #openstack-nova | 02:38 | |
*** vesper11 has quit IRC | 02:45 | |
*** tridde has joined #openstack-nova | 02:45 | |
*** trident has quit IRC | 02:46 | |
*** vesper11 has joined #openstack-nova | 02:46 | |
*** ociuhandu has quit IRC | 02:47 | |
*** lvbin01 has joined #openstack-nova | 02:50 | |
*** brinzhang has joined #openstack-nova | 02:56 | |
*** nweinber has joined #openstack-nova | 02:59 | |
*** brinzhang_ has quit IRC | 02:59 | |
*** brinzhang_ has joined #openstack-nova | 03:00 | |
*** brinzhang has quit IRC | 03:03 | |
openstackgerrit | Merged openstack/nova stable/stein: compute: Use long_rpc_timeout in reserve_block_device_name https://review.opendev.org/696955 | 03:05 |
*** slaweq has joined #openstack-nova | 03:06 | |
*** Kevin_Zheng has joined #openstack-nova | 03:10 | |
*** slaweq has quit IRC | 03:10 | |
*** brinzhang has joined #openstack-nova | 03:12 | |
*** brinzhang_ has quit IRC | 03:15 | |
*** slaweq has joined #openstack-nova | 03:25 | |
*** slaweq has quit IRC | 03:30 | |
*** psachin has joined #openstack-nova | 03:32 | |
openstackgerrit | Eric Xie proposed openstack/nova master: Report trait 'COMPUTE_IMAGE_TYPE_PLOOP' https://review.opendev.org/698132 | 03:37 |
*** awalende has joined #openstack-nova | 03:39 | |
*** brinzhang_ has joined #openstack-nova | 03:42 | |
*** awalende has quit IRC | 03:44 | |
*** brinzhang has quit IRC | 03:46 | |
*** ociuhandu has joined #openstack-nova | 03:47 | |
*** hongbin has joined #openstack-nova | 03:50 | |
*** ociuhandu has quit IRC | 03:51 | |
*** nicolasbock has joined #openstack-nova | 04:02 | |
*** bhagyashris has joined #openstack-nova | 04:23 | |
*** mkrai has joined #openstack-nova | 04:23 | |
*** slaweq has joined #openstack-nova | 04:29 | |
*** slaweq has quit IRC | 04:36 | |
*** slaweq has joined #openstack-nova | 04:39 | |
*** ociuhandu has joined #openstack-nova | 04:41 | |
*** hongbin has quit IRC | 04:41 | |
*** udesale has joined #openstack-nova | 04:41 | |
*** slaweq has quit IRC | 04:44 | |
*** brinzhang_ has quit IRC | 04:44 | |
*** brinzhang_ has joined #openstack-nova | 04:45 | |
*** ociuhandu has quit IRC | 04:46 | |
*** nicolasbock has quit IRC | 04:46 | |
*** brinzhang_ has quit IRC | 04:46 | |
*** brinzhang_ has joined #openstack-nova | 04:47 | |
*** brinzhang has joined #openstack-nova | 04:52 | |
*** brinzhang has quit IRC | 04:53 | |
*** brinzhang has joined #openstack-nova | 04:54 | |
*** brinzhang_ has quit IRC | 04:55 | |
*** nweinber has quit IRC | 04:57 | |
*** brinzhang_ has joined #openstack-nova | 05:12 | |
*** brinzhang_ has joined #openstack-nova | 05:13 | |
*** brinzhang has quit IRC | 05:15 | |
*** bhagyashris has quit IRC | 05:20 | |
*** ociuhandu has joined #openstack-nova | 05:35 | |
*** slaweq has joined #openstack-nova | 05:35 | |
*** ociuhandu has quit IRC | 05:40 | |
*** slaweq has quit IRC | 05:40 | |
openstackgerrit | XiaojueGuan proposed openstack/nova master: Fix error out with an UnboundException when in build_and_run_instance https://review.opendev.org/698140 | 05:41 |
*** slaweq has joined #openstack-nova | 05:46 | |
*** slaweq has quit IRC | 05:50 | |
*** links has joined #openstack-nova | 05:53 | |
*** bhagyashris has joined #openstack-nova | 06:00 | |
*** slaweq has joined #openstack-nova | 06:01 | |
*** avolkov has joined #openstack-nova | 06:03 | |
*** sapd1 has joined #openstack-nova | 06:04 | |
*** Luzi has joined #openstack-nova | 06:04 | |
*** slaweq has quit IRC | 06:05 | |
*** dpawlik has joined #openstack-nova | 06:12 | |
*** slaweq has joined #openstack-nova | 06:18 | |
*** dpawlik has quit IRC | 06:18 | |
*** dpawlik has joined #openstack-nova | 06:20 | |
*** slaweq has quit IRC | 06:23 | |
*** dpawlik has quit IRC | 06:27 | |
*** ociuhandu has joined #openstack-nova | 06:29 | |
*** slaweq has joined #openstack-nova | 06:34 | |
*** ociuhandu has quit IRC | 06:34 | |
openstackgerrit | xulei proposed openstack/nova master: Optimization for nova-api _checks_for_create_and_rebuild https://review.opendev.org/698125 | 06:35 |
*** slaweq has quit IRC | 06:39 | |
openstackgerrit | xulei proposed openstack/nova master: Optimization for nova-api _checks_for_create_and_rebuild https://review.opendev.org/698125 | 06:40 |
*** psachin has quit IRC | 06:42 | |
*** dpawlik has joined #openstack-nova | 06:43 | |
*** psachin has joined #openstack-nova | 06:50 | |
*** brinzhang has joined #openstack-nova | 06:50 | |
*** brinzhang_ has quit IRC | 06:54 | |
*** lpetrut has joined #openstack-nova | 07:00 | |
*** ociuhandu has joined #openstack-nova | 07:02 | |
*** ociuhandu has quit IRC | 07:06 | |
*** sapd1 has quit IRC | 07:14 | |
*** brinzhang_ has joined #openstack-nova | 07:24 | |
*** brinzhang_ has quit IRC | 07:26 | |
*** ociuhandu has joined #openstack-nova | 07:26 | |
*** brinzhang_ has joined #openstack-nova | 07:26 | |
*** damien_r has quit IRC | 07:27 | |
*** brinzhang has quit IRC | 07:27 | |
*** brinzhang_ has quit IRC | 07:28 | |
*** brinzhang_ has joined #openstack-nova | 07:28 | |
*** zhanglong has quit IRC | 07:29 | |
*** brinzhang_ has quit IRC | 07:30 | |
*** brinzhang_ has joined #openstack-nova | 07:30 | |
*** zhanglong has joined #openstack-nova | 07:30 | |
*** brinzhang_ has quit IRC | 07:31 | |
*** ociuhandu has quit IRC | 07:32 | |
*** mkrai has quit IRC | 07:35 | |
*** mkrai has joined #openstack-nova | 07:38 | |
*** pcaruana has joined #openstack-nova | 07:39 | |
*** ociuhandu has joined #openstack-nova | 07:46 | |
*** damien_r has joined #openstack-nova | 07:52 | |
*** rcernin has quit IRC | 07:54 | |
*** slaweq has joined #openstack-nova | 08:01 | |
*** bhagyashris has quit IRC | 08:05 | |
*** tkajinam has quit IRC | 08:06 | |
*** maciejjozefczyk has joined #openstack-nova | 08:08 | |
*** factor has quit IRC | 08:10 | |
*** tosky has joined #openstack-nova | 08:11 | |
*** shilpasd has joined #openstack-nova | 08:14 | |
*** awalende has joined #openstack-nova | 08:18 | |
*** tesseract has joined #openstack-nova | 08:27 | |
*** cgoncalves has quit IRC | 08:40 | |
*** rpittau|afk is now known as rpittau | 08:41 | |
*** mkrai has quit IRC | 08:45 | |
*** mkrai has joined #openstack-nova | 08:46 | |
*** ociuhandu has quit IRC | 08:48 | |
*** ralonsoh has joined #openstack-nova | 08:48 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove MIN_QEMU_FILE_BACKED_DISCARD_VERSION https://review.opendev.org/695915 | 09:00 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_FILE_BACKED_VERSION https://review.opendev.org/695942 | 09:00 |
*** priteau has joined #openstack-nova | 09:00 | |
*** Luzi has quit IRC | 09:11 | |
*** ociuhandu has joined #openstack-nova | 09:17 | |
*** martinkennelly has joined #openstack-nova | 09:20 | |
*** ociuhandu has quit IRC | 09:22 | |
*** johnthetubaguy has joined #openstack-nova | 09:22 | |
*** spsurya has joined #openstack-nova | 09:25 | |
*** Luzi has joined #openstack-nova | 09:26 | |
*** tssurya has joined #openstack-nova | 09:30 | |
luyao | efried, stephenfin : I invite you to look at spec for live migration with vpmem if you get time. https://review.opendev.org/#/c/695863 | 09:32 |
*** derekh has joined #openstack-nova | 09:37 | |
*** owalsh_ is now known as owalsh | 09:37 | |
*** ociuhandu has joined #openstack-nova | 09:42 | |
*** martinkennelly has quit IRC | 09:46 | |
shilpasd | bauzas: thanks for review https://review.opendev.org/#/c/650188 >> NFS spec | 10:00 |
*** gshippey has joined #openstack-nova | 10:01 | |
*** priteau has quit IRC | 10:05 | |
bauzas | shilpasd: I'll try to look more | 10:05 |
bauzas | still working downstream unfortunately | 10:05 |
shilpasd | bauzas: ok, thank you | 10:07 |
shilpasd | attending nova weekly to have more review from nova core | 10:07 |
shilpasd | this just for FYI | 10:08 |
openstackgerrit | Eric Xie proposed openstack/nova master: Report trait 'COMPUTE_IMAGE_TYPE_PLOOP' https://review.opendev.org/698132 | 10:12 |
*** dtantsur|afk is now known as dtantsur | 10:15 | |
*** slaweq has quit IRC | 10:17 | |
*** slaweq has joined #openstack-nova | 10:19 | |
*** derekh has quit IRC | 10:20 | |
*** bhagyashris has joined #openstack-nova | 10:22 | |
*** Liang__ has quit IRC | 10:26 | |
*** martinkennelly has joined #openstack-nova | 10:28 | |
*** salmankhan has joined #openstack-nova | 10:29 | |
*** salmankhan has quit IRC | 10:35 | |
*** salmankhan has joined #openstack-nova | 10:36 | |
*** salmankhan has joined #openstack-nova | 10:36 | |
*** bhagyashris has quit IRC | 10:50 | |
*** zhanglong has quit IRC | 10:53 | |
*** bhagyashris has joined #openstack-nova | 10:58 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Switch to uses_virtio to enable iommu driver for AMD SEV https://review.opendev.org/696697 | 11:01 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Also enable iommu for virtio controllers and video in libvirt https://review.opendev.org/684825 | 11:01 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Create a controller for qga when SEV is used https://review.opendev.org/693072 | 11:01 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Drop nova-network-base security group tests https://review.opendev.org/696508 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Convert remaining API tests to use neutron https://review.opendev.org/696509 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Convert remaining unit tests to neutron https://review.opendev.org/696510 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'is_neutron_security_groups' function https://review.opendev.org/696511 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove nova-network security group driver https://review.opendev.org/696512 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Correct some broken VIF tests https://review.opendev.org/696513 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove firewall support https://review.opendev.org/696514 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Copy shared utils from nova-net module https://review.opendev.org/696515 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove final references to nova-network https://review.opendev.org/696516 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'MetadataManager' https://review.opendev.org/696748 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs to remove security group-related objects https://review.opendev.org/696517 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove dependency on nova-net from fake cache https://review.opendev.org/696749 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Kill it https://review.opendev.org/696518 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Rename 'nova.network.neutronv2' -> 'nova.network' https://review.opendev.org/696745 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Make the security group API as module https://review.opendev.org/696746 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unnecessary 'neutronv2' prefixes https://review.opendev.org/696776 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unused exceptions https://review.opendev.org/697149 | 11:07 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove db methods for ProviderMethod https://review.opendev.org/697150 | 11:07 |
*** ociuhandu has quit IRC | 11:13 | |
*** ociuhandu has joined #openstack-nova | 11:13 | |
*** ociuhandu has quit IRC | 11:28 | |
*** bhagyashris has quit IRC | 11:42 | |
*** bhagyashris has joined #openstack-nova | 11:42 | |
*** dtantsur is now known as dtantsur|ikea | 11:54 | |
*** tbachman has quit IRC | 11:56 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add unified '_build_server' helper function https://review.opendev.org/697537 | 11:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add unified '_(build|create)_flavor' helper functions https://review.opendev.org/697538 | 11:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add '_delete_server' to 'InstanceHelperMixin' https://review.opendev.org/697539 | 11:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add '_create_server' helper https://review.opendev.org/697540 | 11:58 |
*** nicolasbock has joined #openstack-nova | 12:00 | |
*** udesale has quit IRC | 12:01 | |
*** lvbin01 has quit IRC | 12:02 | |
*** cgoncalves has joined #openstack-nova | 12:09 | |
*** owalsh has quit IRC | 12:14 | |
*** lvbin01 has joined #openstack-nova | 12:17 | |
*** ociuhandu has joined #openstack-nova | 12:23 | |
*** ociuhandu has quit IRC | 12:27 | |
*** brault has joined #openstack-nova | 12:32 | |
*** spsurya has quit IRC | 12:35 | |
*** larainema has quit IRC | 12:44 | |
*** owalsh has joined #openstack-nova | 12:46 | |
*** cgoncalves has quit IRC | 12:47 | |
*** mkrai has quit IRC | 12:48 | |
*** alex_xu has joined #openstack-nova | 12:56 | |
*** bhagyashris has quit IRC | 12:58 | |
openstackgerrit | Merged openstack/nova master: Nix os-server-external-events 404 condition https://review.opendev.org/698037 | 12:58 |
openstackgerrit | Merged openstack/nova master: Disable NUMATopologyFilter on rebuild https://review.opendev.org/689861 | 12:58 |
*** dpawlik has quit IRC | 13:01 | |
*** owalsh has quit IRC | 13:08 | |
*** owalsh has joined #openstack-nova | 13:08 | |
*** cgoncalves has joined #openstack-nova | 13:23 | |
*** mdbooth has quit IRC | 13:28 | |
*** owalsh has quit IRC | 13:29 | |
*** mdbooth has joined #openstack-nova | 13:30 | |
*** owalsh has joined #openstack-nova | 13:35 | |
*** yaawang has quit IRC | 13:39 | |
*** yaawang has joined #openstack-nova | 13:39 | |
*** tssurya has quit IRC | 13:43 | |
*** tssurya has joined #openstack-nova | 13:45 | |
*** tbachman has joined #openstack-nova | 13:46 | |
*** Liang__ has joined #openstack-nova | 14:00 | |
*** tkajinam has joined #openstack-nova | 14:01 | |
*** mriedem has joined #openstack-nova | 14:01 | |
*** liuyulong has joined #openstack-nova | 14:02 | |
*** eharney has quit IRC | 14:07 | |
*** awalende has quit IRC | 14:13 | |
*** awalende has joined #openstack-nova | 14:14 | |
*** awalende has quit IRC | 14:14 | |
*** awalende has joined #openstack-nova | 14:14 | |
efried | gmann, mriedem, dansmith: How do we feel about backporting the external events fix? | 14:22 |
*** mkrai has joined #openstack-nova | 14:23 | |
dansmith | efried: find on principle, but unless there's something that is going to use it, I'm not sure there's a point | 14:23 |
dansmith | efried: cyborg master tests against nova master yeah? | 14:23 |
efried | Yeah, tight dependency, several things they're relying on (including your event cancel) | 14:23 |
efried | I can buy "wait until needed". It should be isolated enough that it would be easy to do at any point. | 14:24 |
dansmith | sure, but seems about like any other cross-service dependency, | 14:25 |
dansmith | unless they're going to run against the older service, there's no reason to backport something like that, and they clearly aren't going to get all of nova's cyborg integration stuff backported | 14:25 |
openstackgerrit | sean mooney proposed openstack/nova master: FUP for in-place numa rebuild https://review.opendev.org/698260 | 14:28 |
sean-k-mooney | efried: ^ that should adress the comments on the first two patches. i have a checkup at my doctors in 15 mins so ill look at the final patch when i get back | 14:29 |
*** Luzi has quit IRC | 14:29 | |
mriedem | i agree with what dan said | 14:29 |
efried | dansmith: right, I wasn't thinking of cyborg, I was thinking of some other service that needs to be able to operate against different levels of nova. If they have to change code for the fix, it might be easier for them if the fix was backported rather than them having to code for either possibility. | 14:30 |
dansmith | well, | 14:30 |
efried | I guess "other service" is just neutron, ironic, cinder | 14:30 |
dansmith | I thought we said we didn't expect anyone else to notice, | 14:30 |
efried | famous last words | 14:30 |
sean-k-mooney | neutron is the only one one that i think would send events maybe cinder and i dont think neutron ever checks the responce code | 14:31 |
dansmith | so I'd want to know what actual service would care in what actual situation | 14:31 |
dansmith | not doubting that it's possible, just saying.. backports like that need reasons, IMHO | 14:31 |
efried | ironic does too now for the power state thing | 14:31 |
efried | Fine by me, just talking it through. | 14:31 |
dansmith | efried: if they're going to notice, then backporting something they'll notice is really much worse | 14:31 |
sean-k-mooney | efried: but does it actully check the responce code | 14:31 |
* efried looks | 14:31 | |
sean-k-mooney | most of the external events usage just fired the event and forgot about it | 14:32 |
efried | dansmith: yeah, that makes sense, because we can't count on the backport being applied in a given field situation, right? | 14:32 |
*** liuyulong has quit IRC | 14:32 | |
dansmith | efried: backports need to be things that can be applied (or not) in any order to a running deployment.. | 14:32 |
sean-k-mooney | also in the ironic case the only failure mode we know of would be for shelved instaces. is that a thing with ironic? | 14:32 |
sean-k-mooney | it could be form bfv i guess but in general i woudl guess not? | 14:32 |
sean-k-mooney | anyway got to run | 14:33 |
dansmith | efried: if we backport it, you should expect someone would have yum upgraded one machine at a time, in any order, potentially without upgrading neutron or anything else, before or after | 14:33 |
dansmith | efried: so if we introduce some different behavior, there are lots of ways that could be much worse than a coordinated upgrade, which would generally be smoked out ahead of time, rolled to prod in a maintenance window, etc | 14:33 |
efried | sean-k-mooney: It just uses the code for logging purposes https://review.opendev.org/#/c/664842/19/ironic/common/nova.py | 14:34 |
efried | so the behavior would change, but the result (error or not) would be the same. | 14:34 |
*** ociuhandu has joined #openstack-nova | 14:35 | |
*** mmethot has joined #openstack-nova | 14:35 | |
*** mmethot is now known as mmethot|conferen | 14:35 | |
*** pcaruana has quit IRC | 14:36 | |
efried | oh, I lied. | 14:37 |
efried | it will return True in the 207/4xx case. | 14:37 |
efried | ...which is only ever checked in UT. Phew. | 14:39 |
openstackgerrit | Merged openstack/nova stable/rocky: Do not update root_device_name during guest config https://review.opendev.org/696353 | 14:39 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add NodeOwnerFilter https://review.opendev.org/697331 | 14:43 |
*** eharney has joined #openstack-nova | 14:47 | |
*** links has quit IRC | 14:48 | |
*** tkajinam has quit IRC | 14:52 | |
*** tssurya has quit IRC | 14:58 | |
*** igordc has joined #openstack-nova | 14:58 | |
*** lbragsta_ has joined #openstack-nova | 14:59 | |
*** pcaruana has joined #openstack-nova | 15:01 | |
stephenfin | efried: Think I could entice you to burn through a few more of those nova-net patches today? | 15:11 |
efried | stephenfin: Totally. When do you bugger off til 2020? | 15:11 |
stephenfin | I'm around until the 27th, minus the 25th/26th | 15:12 |
stephenfin | gone the new years week | 15:12 |
stephenfin | *week of new years | 15:12 |
efried | stephenfin: cool. So, can I trade you nova-net for vTPM (not today, I've got some more updates to make)? | 15:13 |
*** seba has joined #openstack-nova | 15:14 | |
efried | dun dun dahhh | 15:14 |
stephenfin | I'll allow it. | 15:15 |
efried | Thanks. | 15:15 |
*** bnemec has quit IRC | 15:15 | |
efried | Is gibi_off off for the remainder? | 15:15 |
*** munimeha1 has joined #openstack-nova | 15:17 | |
aarents | kashyap: thks for the review https://review.opendev.org/#/c/696084/ I added some remarks about if go on rebase versus flatten | 15:24 |
kashyap | aarents: No problem; will look. I'm running around like a head-less chicken doing last-minute stuff | 15:25 |
aarents | k no prob | 15:27 |
efried | dansmith, mriedem, sean-k-mooney: https://review.opendev.org/698273 (ironic refactor for the external events fix) | 15:28 |
kashyap | efried: If you're curious about yesterday's "competition", I won ... the "loser's final", if that makes sense | 15:30 |
sean-k-mooney | i have not seen us use the ddt stuff much i should look into that more closely sometime | 15:30 |
kashyap | (There were 10 folks; two groups of 5 each.) | 15:30 |
efried | As a veteran of tournaments, both single elimination and round robin, it makes perfect sense. How many in the bracket? | 15:30 |
efried | disregard, race condition. | 15:30 |
kashyap | Hehe | 15:30 |
efried | sean-k-mooney: I actually stole that from dustinc, whom I now consider to be our ddt expert. | 15:31 |
efried | kashyap: congratulations. There are many reasons competition is a positive experience, and winning is only a small (and IMO not close to the most important) aspect. | 15:32 |
sean-k-mooney | thanks for adding the comment on the ddt elements, it makes it easier to follow without having to figure it out | 15:32 |
kashyap | efried: Yeah, I barely practised the last few Mondays; and went in there just to see how _different_ players play in a game vs. routine practise | 15:32 |
efried | kashyap: On that note: http://www.taylorbjj.com/why-i-dont-compete/ | 15:33 |
kashyap | efried: I fully agree on the positive experience; I didn't mind "losing", but was definitely fun | 15:33 |
*** tssurya has joined #openstack-nova | 15:33 | |
efried | o/ tssurya. Is this coincidence, or did you just happen to see my ironic patch? | 15:34 |
tssurya | efried: saw the ironic patch comment :) | 15:35 |
tssurya | I'll see if I can clean that up | 15:36 |
efried | tssurya: I put up https://review.opendev.org/698273 already | 15:36 |
efried | ...and need to go note it on the original... | 15:36 |
*** lbragsta_ has quit IRC | 15:36 | |
tssurya | efried: aha! thanks a lot | 15:36 |
efried | tssurya: Figured since I made the mess, I ought to clean it up :P | 15:37 |
efried | Your review would be most appreciated though. | 15:37 |
*** mgariepy has quit IRC | 15:37 | |
*** lbragsta_ has joined #openstack-nova | 15:37 | |
efried | kashyap: Most of that blog post is anti-what we talked about. The bottom three bullets though... | 15:38 |
* efried bbiab | 15:39 | |
*** adriant has quit IRC | 15:40 | |
*** mgariepy has joined #openstack-nova | 15:40 | |
openstackgerrit | Alexandre arents proposed openstack/nova stable/queens: Do not update root_device_name during guest config https://review.opendev.org/696469 | 15:44 |
*** tssurya has quit IRC | 15:54 | |
*** lbragsta_ has quit IRC | 15:55 | |
*** jmlowe has joined #openstack-nova | 16:00 | |
*** ociuhandu has quit IRC | 16:02 | |
*** dtantsur|ikea is now known as dtantsur | 16:02 | |
*** tbachman has quit IRC | 16:03 | |
*** awalende has quit IRC | 16:08 | |
*** awalende has joined #openstack-nova | 16:08 | |
*** mlavalle has joined #openstack-nova | 16:10 | |
*** igordc has quit IRC | 16:11 | |
*** awalende has quit IRC | 16:13 | |
kashyap | efried: Thanks for the executive summary; have the URL open :-) | 16:18 |
*** iurygregory has joined #openstack-nova | 16:19 | |
*** damien_r has quit IRC | 16:22 | |
kashyap | efried: Yeah, indeed the last three bullets hit the point right on its mazard | 16:22 |
*** lpetrut has quit IRC | 16:29 | |
openstackgerrit | Mykola Yakovliev proposed openstack/nova master: Validate aggregate IDs before querying database https://review.opendev.org/698094 | 16:31 |
*** Liang__ has quit IRC | 16:33 | |
*** tbachman has joined #openstack-nova | 16:34 | |
*** gyee has joined #openstack-nova | 16:37 | |
openstackgerrit | Alexandre arents proposed openstack/nova stable/queens: Do not update root_device_name during guest config https://review.opendev.org/696469 | 16:38 |
*** lpetrut has joined #openstack-nova | 16:39 | |
*** awalende has joined #openstack-nova | 16:45 | |
*** mmethot|conferen is now known as mmethot | 16:48 | |
openstackgerrit | Alexandre arents proposed openstack/nova stable/queens: Do not update root_device_name during guest config https://review.opendev.org/696469 | 16:49 |
*** jmlowe has quit IRC | 16:50 | |
*** awalende has quit IRC | 16:50 | |
*** lpetrut has quit IRC | 16:50 | |
*** jaosorior has joined #openstack-nova | 16:50 | |
*** tesseract has quit IRC | 16:58 | |
*** mkrai has quit IRC | 17:02 | |
*** iurygregory has quit IRC | 17:02 | |
*** maciejjozefczyk has quit IRC | 17:08 | |
openstackgerrit | Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040 | 17:09 |
*** nweinber has joined #openstack-nova | 17:11 | |
sean-k-mooney | efried: do you have a minute to talk about the notifcaiton changes in https://review.opendev.org/#/c/674072/14 | 17:13 |
efried | sean-k-mooney: hmu in half an hour? | 17:14 |
efried | otp | 17:14 |
sean-k-mooney | sure im goint to adress the other comments in the interim | 17:14 |
*** ociuhandu has joined #openstack-nova | 17:25 | |
*** tosky has quit IRC | 17:27 | |
*** lbragstad_ has joined #openstack-nova | 17:27 | |
*** ociuhandu has quit IRC | 17:29 | |
*** rpittau is now known as rpittau|afk | 17:29 | |
*** lbragstad has quit IRC | 17:30 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: debug cross-cell resize https://review.opendev.org/698304 | 17:34 |
*** dtantsur is now known as dtantsur|afk | 17:38 | |
openstackgerrit | Merged openstack/nova stable/rocky: compute: Use long_rpc_timeout in reserve_block_device_name https://review.opendev.org/696956 | 17:42 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Update orphaned allocations troubleshooting doc for unset command https://review.opendev.org/696582 | 17:49 |
*** links has joined #openstack-nova | 17:58 | |
*** jaosorior has quit IRC | 17:59 | |
*** martinkennelly has quit IRC | 18:12 | |
efried | sean-k-mooney: that took longer than expected, sorry. Ready to talk about notifications? | 18:20 |
sean-k-mooney | no worries | 18:22 |
sean-k-mooney | so basicaly im a littel fuzzy on our policy | 18:22 |
sean-k-mooney | i did not need to extend the notifciaiton payload but i though we were ment to every time we added an image property | 18:23 |
sean-k-mooney | gmann: ^ maybe you know | 18:23 |
*** salmankhan has quit IRC | 18:23 | |
sean-k-mooney | i know we have to update the notifcaiton object if i extend a field that is used in an existing notifcation | 18:23 |
sean-k-mooney | but i dont know if its requried when we add new image properties | 18:24 |
sean-k-mooney | efried: i assume that was what you wanted to know regarding the notification change in https://review.opendev.org/#/c/674072/14 right | 18:25 |
efried | Yes, that's what I wanted to know. It struck me because I'm adding (and have seen recently added) image properties and haven't seen corresponding notifications changes. | 18:26 |
sean-k-mooney | right so i was asked to add them for https://review.opendev.org/#/c/647733/ where i exetended the video_model field | 18:28 |
sean-k-mooney | but i did not add them for my vPMU change | 18:29 |
sean-k-mooney | i can drop them but i jsut dont know if we should be keeping them in sync or not | 18:29 |
sean-k-mooney | efried: would you perfer i drop them? | 18:31 |
efried | This may be a question for gibi_off | 18:31 |
efried | but he's... off | 18:31 |
efried | mriedem: do you know this answer? | 18:31 |
efried | TLDR: What is the policy for keeping image meta notification payload fields consistent with image meta fields? Always, never, based on some criteria...? | 18:32 |
*** links has quit IRC | 18:36 | |
mriedem | otp, will get back | 18:37 |
*** ociuhandu has joined #openstack-nova | 18:39 | |
*** nweinber_ has joined #openstack-nova | 18:39 | |
*** nweinber has quit IRC | 18:41 | |
*** ociuhandu has quit IRC | 18:44 | |
*** mmethot has quit IRC | 18:46 | |
*** mmethot has joined #openstack-nova | 18:46 | |
*** psachin has quit IRC | 19:02 | |
* efried ==> doc | 19:06 | |
*** efried is now known as efried_afk | 19:06 | |
*** nweinber__ has joined #openstack-nova | 19:16 | |
*** nweinber_ has quit IRC | 19:18 | |
*** tbachman has quit IRC | 19:20 | |
*** kashyap has quit IRC | 19:29 | |
mriedem | cripes, i didn't know we have a notification payload ImageMetaPropsPayload that was 1:1 with ImageMetaProps | 19:31 |
mriedem | given that, it seems it's meant to be 1:1 | 19:31 |
mriedem | i don't think we have a policy but i'm assuming that's the intent, but would have to confirm with gibi | 19:32 |
mriedem | if those are meant to be 1:1 then we need a test that asserts they are | 19:32 |
mriedem | efried_afk: sean-k-mooney: ^ | 19:32 |
mriedem | "# NOTE(takashin): If fields are not set in the ImageMetaProps object, | 19:32 |
mriedem | # it will not set the fields in the ImageMetaPropsPayload | 19:32 |
mriedem | # in order to avoid too many fields whose values are None." | 19:32 |
*** spatel has joined #openstack-nova | 19:33 | |
mriedem | seems ImageMetaPropsPayload, or what uses it, would have been better off with a simple DictOfStrings thing where the values are the coerced ImageMetaProps | 19:34 |
mriedem | because keeping that all 1:1 seems a bit nuts | 19:34 |
mriedem | https://review.opendev.org/#/c/482629/ | 19:35 |
*** lbragstad_ is now known as lbragstad | 19:36 | |
mriedem | the request spec payload is not as beefy but it's....beefy | 19:36 |
mriedem | lite beef | 19:36 |
*** igordc has joined #openstack-nova | 19:39 | |
*** gmann is now known as gmann_afk | 19:40 | |
mriedem | dansmith: are you aware of any poison fixtures off the top of your head for the api db? like say i want to do some stuff in a test, then nuke the api db global conf connection and run some more test code | 19:41 |
dansmith | mriedem: no, since it requires using the fixture, I don't think we've ever needed one | 19:42 |
dansmith | needs the actual fixture for the api db I mean | 19:42 |
mriedem | wanted to test a 'no upcall' kind of thing | 19:42 |
dansmith | I imagine you could add something to the db fixture to let you break it midway if that's what you're tryingto do | 19:42 |
mriedem | i was able to do something by just getting a handle to the api db fixture and calling cleanup() on it which drops the schema on the db | 19:44 |
mriedem | so you get DBNonExistentTable rather than like DBConnectionError or whatever | 19:44 |
mriedem | might be good enough for what i need | 19:44 |
dansmith | yeah, that's what I was thinking | 19:47 |
*** eharney has quit IRC | 19:55 | |
*** awalende has joined #openstack-nova | 20:09 | |
*** ralonsoh has quit IRC | 20:10 | |
sean-k-mooney | mriedem: ya so i think it was added as part of the version notification work | 20:12 |
sean-k-mooney | but it has to be manually updated each time | 20:12 |
*** awalende has quit IRC | 20:14 | |
sean-k-mooney | mriedem: so should i keep the payload notificion updates in the patch. i could post something to the mailing list if we want to change this longer term | 20:14 |
mriedem | fun https://bugs.launchpad.net/nova/+bug/1855927 | 20:16 |
openstack | Launchpad bug 1855927 in OpenStack Compute (nova) "_poll_unconfirmed_resizes may not retry later if confirm_resize fails in API" [Low,New] | 20:16 |
*** rcernin has joined #openstack-nova | 20:16 | |
mriedem | sean-k-mooney: idk, ask gibi | 20:16 |
*** pcaruana has quit IRC | 20:16 | |
mriedem | you get one shot at confirming a resize and if it fails you can't retry | 20:17 |
mriedem | without db surgery | 20:17 |
sean-k-mooney | oh interesting. | 20:18 |
sean-k-mooney | would it be valid to include both finished and confiming migration in the periodic | 20:20 |
mriedem | maybe | 20:20 |
mriedem | that doesn't change the api behavior though - you'd have to do the same in the api | 20:20 |
mriedem | i think like an instance task_state you likely need to reset the migration status on error | 20:21 |
sean-k-mooney | true | 20:21 |
sean-k-mooney | i can see the logic of rolling back the migration to the finished state but we dont want to keep retrying forever | 20:22 |
sean-k-mooney | if we go to error can we reset teh migration status to finished via the api or only via the db | 20:22 |
mriedem | only the db | 20:22 |
mriedem | there is no api to update migration records | 20:23 |
mriedem | it's an extremely latent bug so not high priority, just something i noticed while writing a test around that periodic | 20:24 |
*** sorrison has quit IRC | 20:24 | |
sean-k-mooney | right /os-migrations is just a list of all migration and the server migration enpoint does not have a put | 20:25 |
*** sorrison has joined #openstack-nova | 20:26 | |
sean-k-mooney | we check for both finished and confriming here https://github.com/openstack/nova/blob/5a3ef39539ca112ae0552aef5cbd536338db61b7/nova/compute/manager.py#L4267 do we arrive at that form finished from teh periodic task | 20:30 |
mriedem | yes | 20:30 |
sean-k-mooney | ah ok | 20:30 |
mriedem | https://github.com/openstack/nova/blob/5a3ef39539ca112ae0552aef5cbd536338db61b7/nova/compute/manager.py#L8866 | 20:31 |
mriedem | the periodic on the dest host calls the api method which calls confirm_resize on the source host | 20:31 |
sean-k-mooney | right but the compute api method set it to confirming https://github.com/openstack/nova/blob/5a3ef39539ca112ae0552aef5cbd536338db61b7/nova/compute/api.py#L3684 | 20:32 |
mriedem | correct | 20:32 |
mriedem | and after the api does that, if anything fails you can't re-confirm the resize | 20:32 |
sean-k-mooney | yes but in the compute manager do_confirm_resize which is an inner function of confirm_resize seams to exepct the migration could be in finished or confriming so i was trying to figure out when could it be finish since i think it shoudld only be in confirming based on that code flow | 20:34 |
sean-k-mooney | anyway its proably not important i just thought it was odd | 20:34 |
mriedem | it's probably leftover | 20:35 |
mriedem | or when deleting a resized server | 20:35 |
mriedem | see _confirm_resize_on_deleting | 20:35 |
sean-k-mooney | oh so we clean up the resouce on the source node then delete it on the dest | 20:36 |
mriedem | yes | 20:37 |
*** nweinber_ has joined #openstack-nova | 20:37 | |
*** nweinber__ has quit IRC | 20:37 | |
sean-k-mooney | that still calls confirm_resize via rpc but ya it looks like it " for status in ('finished', 'confirming'):" code was copied between the two functions | 20:38 |
*** nweinber__ has joined #openstack-nova | 20:39 | |
*** jcosmao has joined #openstack-nova | 20:40 | |
*** jcosmao has left #openstack-nova | 20:40 | |
*** nweinber_ has quit IRC | 20:41 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: debug cross-cell resize https://review.opendev.org/698304 | 20:41 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross-cell resize tests for _poll_unconfirmed_resizes https://review.opendev.org/698322 | 20:41 |
*** jcosmao has joined #openstack-nova | 20:42 | |
*** tbachman has joined #openstack-nova | 20:48 | |
*** eharney has joined #openstack-nova | 21:02 | |
*** smcginnis has joined #openstack-nova | 21:05 | |
*** jaosorior has joined #openstack-nova | 21:05 | |
*** nweinber__ has quit IRC | 21:12 | |
*** adriant has joined #openstack-nova | 21:26 | |
*** mriedem has quit IRC | 21:29 | |
*** abaindur has joined #openstack-nova | 21:36 | |
*** abaindur has quit IRC | 21:37 | |
*** abaindur has joined #openstack-nova | 21:38 | |
*** damien_r has joined #openstack-nova | 21:57 | |
*** jaosorior has quit IRC | 22:01 | |
openstackgerrit | sean mooney proposed openstack/nova master: support pci numa affinity policies in flavor and image https://review.opendev.org/674072 | 22:02 |
*** mriedem has joined #openstack-nova | 22:05 | |
*** spatel has quit IRC | 22:09 | |
*** slaweq has quit IRC | 22:10 | |
*** awalende has joined #openstack-nova | 22:10 | |
*** nicolasbock has quit IRC | 22:12 | |
*** awalende has quit IRC | 22:15 | |
*** abaindur has quit IRC | 22:20 | |
*** efried_afk is now known as efried | 22:25 | |
efried | well that took rather longer than expected. | 22:25 |
efried | sean-k-mooney: So I guess the right thing here is to hold off making irreversible OVO changes until we can get the word from gibi_off. Can you live with that? | 22:25 |
sean-k-mooney | yep that is fine with me | 22:26 |
sean-k-mooney | i address some of your nits | 22:26 |
sean-k-mooney | but i have not done the functional test changes yet | 22:26 |
efried | okay | 22:29 |
sean-k-mooney | do you want the extra functional test in the same patch or a follow up. i need to think about how to do it smartly instead of just copy pasting and tweeking | 22:30 |
*** awalende has joined #openstack-nova | 22:30 | |
efried | sean-k-mooney: stephenfin isn't disappearing until well after you do, so getting his re+2 ought to be easy enough; same patch seems reasonable. | 22:34 |
openstackgerrit | sean mooney proposed openstack/nova master: fix imports of typeing module https://review.opendev.org/698334 | 22:35 |
efried | we may not even be able to move on it until the new year -- not sure whether gibi is thoroughly gone until then. | 22:35 |
sean-k-mooney | i think artom is going to pick up the patch if its not reay before i do | 22:35 |
*** awalende has quit IRC | 22:35 | |
sean-k-mooney | hum ok that would less then ideal but ok | 22:36 |
sean-k-mooney | i could split the notifciation change into a second patch if that helped | 22:36 |
*** abaindur has joined #openstack-nova | 22:37 | |
sean-k-mooney | anyway im done for today so that is tommorows problem | 22:37 |
sean-k-mooney | night o/ | 22:37 |
efried | yeah, let's talk again about this tomorrow, hopefully I'll have a clearer head too. | 22:37 |
efried | dansmith, sean-k-mooney, mriedem: FYI the cinder use of external events appears sane https://opendev.org/openstack/cinder/src/branch/master/cinder/compute/nova.py#L145 | 22:44 |
efried | uhm | 22:45 |
efried | actually no | 22:45 |
efried | it should be setting response_error=True on L168 | 22:45 |
efried | So that's actually a latent bug | 22:47 |
efried | Previously it would have triggered if they were extending volumes attached to multiple instances and a subset failed; | 22:49 |
efried | With our fix it would also trigger if they were extending volumes attached to one or more instances and all failed. | 22:49 |
efried | in this case the bug is simply that they wouldn't send the error through their messaging API. | 22:50 |
mriedem | rain hell fire upon them | 22:55 |
efried | I'm doing so in -cinder | 22:57 |
*** tkajinam has joined #openstack-nova | 23:05 | |
*** gmann_afk is now known as gmann | 23:06 | |
*** slaweq has joined #openstack-nova | 23:08 | |
*** slaweq has quit IRC | 23:14 | |
*** mriedem has quit IRC | 23:17 | |
*** tbachman has quit IRC | 23:18 | |
*** abaindur has quit IRC | 23:25 | |
*** abaindur has joined #openstack-nova | 23:25 | |
efried | ...and neutron is okay https://opendev.org/openstack/neutron/src/branch/master/neutron/notifiers/nova.py#L244 | 23:28 |
efried | They're just using the codes to print log messages, and they're doing it correctly. | 23:28 |
efried | and those are all the relevant hits | 23:29 |
efried | FYI I opened https://bugs.launchpad.net/cinder/+bug/1855940 and put up https://review.opendev.org/698340 in cinder. | 23:30 |
openstack | Launchpad bug 1855940 in Cinder "Messages sometimes not sent when nova fails to accept "extend volume" events" [Undecided,In progress] - Assigned to Eric Fried (efried) | 23:30 |
efried | and with that... o/ | 23:30 |
*** tbachman has joined #openstack-nova | 23:34 | |
*** avolkov has quit IRC | 23:43 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!