Tuesday, 2019-12-10

*** ociuhandu has quit IRC00:01
*** owalsh has quit IRC00:03
*** owalsh has joined #openstack-nova00:03
*** rcernin_ has joined #openstack-nova00:04
*** owalsh_ has joined #openstack-nova00:05
*** rcernin has quit IRC00:07
*** owalsh has quit IRC00:08
*** ociuhandu has joined #openstack-nova00:10
*** ociuhandu has quit IRC00:14
*** artom has joined #openstack-nova00:16
*** ociuhandu has joined #openstack-nova00:17
*** artom has joined #openstack-nova00:17
*** rcernin_ has quit IRC00:19
*** ociuhandu has quit IRC00:21
*** ociuhandu has joined #openstack-nova00:23
*** gyee has quit IRC00:24
*** rcernin has joined #openstack-nova00:27
*** ociuhandu has quit IRC00:28
*** awalende has joined #openstack-nova00:28
*** dave-mccowan has joined #openstack-nova00:29
*** gshippey has quit IRC00:29
*** ociuhandu has joined #openstack-nova00:31
*** dave-mccowan has quit IRC00:33
*** awalende has quit IRC00:33
*** ociuhandu has quit IRC00:36
*** dave-mccowan has joined #openstack-nova00:36
*** Sundar has quit IRC00:39
*** ociuhandu has joined #openstack-nova00:41
*** ociuhandu has quit IRC00:46
*** zhanglong has joined #openstack-nova00:47
*** brinzhang has joined #openstack-nova00:50
*** ociuhandu has joined #openstack-nova00:51
*** dave-mccowan has quit IRC00:52
*** ociuhandu has quit IRC00:57
*** ociuhandu has joined #openstack-nova01:02
*** ociuhandu has quit IRC01:06
*** ircuser-1 has joined #openstack-nova01:07
*** ociuhandu has joined #openstack-nova01:12
*** ociuhandu has quit IRC01:16
*** Liang__ has joined #openstack-nova01:18
*** ociuhandu has joined #openstack-nova01:21
*** zhanglong has quit IRC01:25
*** ociuhandu has quit IRC01:26
*** zhanglong has joined #openstack-nova01:27
*** huaqiang_ has quit IRC01:28
*** ociuhandu has joined #openstack-nova01:29
*** huaqiang has joined #openstack-nova01:35
*** ociuhandu has quit IRC01:37
*** larainema has joined #openstack-nova01:38
*** ociuhandu has joined #openstack-nova01:42
*** ociuhandu has quit IRC01:47
*** ociuhandu has joined #openstack-nova01:49
openstackgerritxulei proposed openstack/nova master: Optimization for nova-api _checks_for_create_and_rebuild  https://review.opendev.org/69812501:49
*** ociuhandu has quit IRC01:57
*** ociuhandu has joined #openstack-nova02:08
*** nicolasbock has quit IRC02:10
*** ociuhandu has quit IRC02:13
*** ociuhandu has joined #openstack-nova02:14
*** slaweq has joined #openstack-nova02:17
*** abaindur has quit IRC02:21
*** brinzhang_ has joined #openstack-nova02:22
*** slaweq has quit IRC02:22
*** ociuhandu has quit IRC02:22
*** igordc has quit IRC02:24
*** brinzhang has quit IRC02:25
*** zhanglong has quit IRC02:27
*** zhanglong has joined #openstack-nova02:32
*** lvbin01 has quit IRC02:36
*** ociuhandu has joined #openstack-nova02:38
*** vesper11 has quit IRC02:45
*** tridde has joined #openstack-nova02:45
*** trident has quit IRC02:46
*** vesper11 has joined #openstack-nova02:46
*** ociuhandu has quit IRC02:47
*** lvbin01 has joined #openstack-nova02:50
*** brinzhang has joined #openstack-nova02:56
*** nweinber has joined #openstack-nova02:59
*** brinzhang_ has quit IRC02:59
*** brinzhang_ has joined #openstack-nova03:00
*** brinzhang has quit IRC03:03
openstackgerritMerged openstack/nova stable/stein: compute: Use long_rpc_timeout in reserve_block_device_name  https://review.opendev.org/69695503:05
*** slaweq has joined #openstack-nova03:06
*** Kevin_Zheng has joined #openstack-nova03:10
*** slaweq has quit IRC03:10
*** brinzhang has joined #openstack-nova03:12
*** brinzhang_ has quit IRC03:15
*** slaweq has joined #openstack-nova03:25
*** slaweq has quit IRC03:30
*** psachin has joined #openstack-nova03:32
openstackgerritEric Xie proposed openstack/nova master: Report trait 'COMPUTE_IMAGE_TYPE_PLOOP'  https://review.opendev.org/69813203:37
*** awalende has joined #openstack-nova03:39
*** brinzhang_ has joined #openstack-nova03:42
*** awalende has quit IRC03:44
*** brinzhang has quit IRC03:46
*** ociuhandu has joined #openstack-nova03:47
*** hongbin has joined #openstack-nova03:50
*** ociuhandu has quit IRC03:51
*** nicolasbock has joined #openstack-nova04:02
*** bhagyashris has joined #openstack-nova04:23
*** mkrai has joined #openstack-nova04:23
*** slaweq has joined #openstack-nova04:29
*** slaweq has quit IRC04:36
*** slaweq has joined #openstack-nova04:39
*** ociuhandu has joined #openstack-nova04:41
*** hongbin has quit IRC04:41
*** udesale has joined #openstack-nova04:41
*** slaweq has quit IRC04:44
*** brinzhang_ has quit IRC04:44
*** brinzhang_ has joined #openstack-nova04:45
*** ociuhandu has quit IRC04:46
*** nicolasbock has quit IRC04:46
*** brinzhang_ has quit IRC04:46
*** brinzhang_ has joined #openstack-nova04:47
*** brinzhang has joined #openstack-nova04:52
*** brinzhang has quit IRC04:53
*** brinzhang has joined #openstack-nova04:54
*** brinzhang_ has quit IRC04:55
*** nweinber has quit IRC04:57
*** brinzhang_ has joined #openstack-nova05:12
*** brinzhang_ has joined #openstack-nova05:13
*** brinzhang has quit IRC05:15
*** bhagyashris has quit IRC05:20
*** ociuhandu has joined #openstack-nova05:35
*** slaweq has joined #openstack-nova05:35
*** ociuhandu has quit IRC05:40
*** slaweq has quit IRC05:40
openstackgerritXiaojueGuan proposed openstack/nova master: Fix error out with an UnboundException when in build_and_run_instance  https://review.opendev.org/69814005:41
*** slaweq has joined #openstack-nova05:46
*** slaweq has quit IRC05:50
*** links has joined #openstack-nova05:53
*** bhagyashris has joined #openstack-nova06:00
*** slaweq has joined #openstack-nova06:01
*** avolkov has joined #openstack-nova06:03
*** sapd1 has joined #openstack-nova06:04
*** Luzi has joined #openstack-nova06:04
*** slaweq has quit IRC06:05
*** dpawlik has joined #openstack-nova06:12
*** slaweq has joined #openstack-nova06:18
*** dpawlik has quit IRC06:18
*** dpawlik has joined #openstack-nova06:20
*** slaweq has quit IRC06:23
*** dpawlik has quit IRC06:27
*** ociuhandu has joined #openstack-nova06:29
*** slaweq has joined #openstack-nova06:34
*** ociuhandu has quit IRC06:34
openstackgerritxulei proposed openstack/nova master: Optimization for nova-api _checks_for_create_and_rebuild  https://review.opendev.org/69812506:35
*** slaweq has quit IRC06:39
openstackgerritxulei proposed openstack/nova master: Optimization for nova-api _checks_for_create_and_rebuild  https://review.opendev.org/69812506:40
*** psachin has quit IRC06:42
*** dpawlik has joined #openstack-nova06:43
*** psachin has joined #openstack-nova06:50
*** brinzhang has joined #openstack-nova06:50
*** brinzhang_ has quit IRC06:54
*** lpetrut has joined #openstack-nova07:00
*** ociuhandu has joined #openstack-nova07:02
*** ociuhandu has quit IRC07:06
*** sapd1 has quit IRC07:14
*** brinzhang_ has joined #openstack-nova07:24
*** brinzhang_ has quit IRC07:26
*** ociuhandu has joined #openstack-nova07:26
*** brinzhang_ has joined #openstack-nova07:26
*** damien_r has quit IRC07:27
*** brinzhang has quit IRC07:27
*** brinzhang_ has quit IRC07:28
*** brinzhang_ has joined #openstack-nova07:28
*** zhanglong has quit IRC07:29
*** brinzhang_ has quit IRC07:30
*** brinzhang_ has joined #openstack-nova07:30
*** zhanglong has joined #openstack-nova07:30
*** brinzhang_ has quit IRC07:31
*** ociuhandu has quit IRC07:32
*** mkrai has quit IRC07:35
*** mkrai has joined #openstack-nova07:38
*** pcaruana has joined #openstack-nova07:39
*** ociuhandu has joined #openstack-nova07:46
*** damien_r has joined #openstack-nova07:52
*** rcernin has quit IRC07:54
*** slaweq has joined #openstack-nova08:01
*** bhagyashris has quit IRC08:05
*** tkajinam has quit IRC08:06
*** maciejjozefczyk has joined #openstack-nova08:08
*** factor has quit IRC08:10
*** tosky has joined #openstack-nova08:11
*** shilpasd has joined #openstack-nova08:14
*** awalende has joined #openstack-nova08:18
*** tesseract has joined #openstack-nova08:27
*** cgoncalves has quit IRC08:40
*** rpittau|afk is now known as rpittau08:41
*** mkrai has quit IRC08:45
*** mkrai has joined #openstack-nova08:46
*** ociuhandu has quit IRC08:48
*** ralonsoh has joined #openstack-nova08:48
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Remove MIN_QEMU_FILE_BACKED_DISCARD_VERSION  https://review.opendev.org/69591509:00
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_FILE_BACKED_VERSION  https://review.opendev.org/69594209:00
*** priteau has joined #openstack-nova09:00
*** Luzi has quit IRC09:11
*** ociuhandu has joined #openstack-nova09:17
*** martinkennelly has joined #openstack-nova09:20
*** ociuhandu has quit IRC09:22
*** johnthetubaguy has joined #openstack-nova09:22
*** spsurya has joined #openstack-nova09:25
*** Luzi has joined #openstack-nova09:26
*** tssurya has joined #openstack-nova09:30
luyaoefried, stephenfin : I invite you to look at  spec for live migration with vpmem if you get time.  https://review.opendev.org/#/c/69586309:32
*** derekh has joined #openstack-nova09:37
*** owalsh_ is now known as owalsh09:37
*** ociuhandu has joined #openstack-nova09:42
*** martinkennelly has quit IRC09:46
shilpasdbauzas: thanks for review https://review.opendev.org/#/c/650188 >> NFS spec10:00
*** gshippey has joined #openstack-nova10:01
*** priteau has quit IRC10:05
bauzasshilpasd: I'll try to look more10:05
bauzasstill working downstream unfortunately10:05
shilpasdbauzas: ok, thank you10:07
shilpasdattending nova weekly to have more review from nova core10:07
shilpasdthis just for FYI10:08
openstackgerritEric Xie proposed openstack/nova master: Report trait 'COMPUTE_IMAGE_TYPE_PLOOP'  https://review.opendev.org/69813210:12
*** dtantsur|afk is now known as dtantsur10:15
*** slaweq has quit IRC10:17
*** slaweq has joined #openstack-nova10:19
*** derekh has quit IRC10:20
*** bhagyashris has joined #openstack-nova10:22
*** Liang__ has quit IRC10:26
*** martinkennelly has joined #openstack-nova10:28
*** salmankhan has joined #openstack-nova10:29
*** salmankhan has quit IRC10:35
*** salmankhan has joined #openstack-nova10:36
*** salmankhan has joined #openstack-nova10:36
*** bhagyashris has quit IRC10:50
*** zhanglong has quit IRC10:53
*** bhagyashris has joined #openstack-nova10:58
openstackgerritStephen Finucane proposed openstack/nova master: Switch to uses_virtio to enable iommu driver for AMD SEV  https://review.opendev.org/69669711:01
openstackgerritStephen Finucane proposed openstack/nova master: Also enable iommu for virtio controllers and video in libvirt  https://review.opendev.org/68482511:01
openstackgerritStephen Finucane proposed openstack/nova master: Create a controller for qga when SEV is used  https://review.opendev.org/69307211:01
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Drop nova-network-base security group tests  https://review.opendev.org/69650811:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Convert remaining API tests to use neutron  https://review.opendev.org/69650911:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Convert remaining unit tests to neutron  https://review.opendev.org/69651011:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove 'is_neutron_security_groups' function  https://review.opendev.org/69651111:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove nova-network security group driver  https://review.opendev.org/69651211:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Correct some broken VIF tests  https://review.opendev.org/69651311:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove firewall support  https://review.opendev.org/69651411:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Copy shared utils from nova-net module  https://review.opendev.org/69651511:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove final references to nova-network  https://review.opendev.org/69651611:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove 'MetadataManager'  https://review.opendev.org/69674811:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Add TODOs to remove security group-related objects  https://review.opendev.org/69651711:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove dependency on nova-net from fake cache  https://review.opendev.org/69674911:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Kill it  https://review.opendev.org/69651811:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Rename 'nova.network.neutronv2' -> 'nova.network'  https://review.opendev.org/69674511:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Make the security group API as module  https://review.opendev.org/69674611:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove unnecessary 'neutronv2' prefixes  https://review.opendev.org/69677611:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove unused exceptions  https://review.opendev.org/69714911:07
openstackgerritStephen Finucane proposed openstack/nova master: nova-net: Remove db methods for ProviderMethod  https://review.opendev.org/69715011:07
*** ociuhandu has quit IRC11:13
*** ociuhandu has joined #openstack-nova11:13
*** ociuhandu has quit IRC11:28
*** bhagyashris has quit IRC11:42
*** bhagyashris has joined #openstack-nova11:42
*** dtantsur is now known as dtantsur|ikea11:54
*** tbachman has quit IRC11:56
openstackgerritStephen Finucane proposed openstack/nova master: functional: Add unified '_build_server' helper function  https://review.opendev.org/69753711:58
openstackgerritStephen Finucane proposed openstack/nova master: functional: Add unified '_(build|create)_flavor' helper functions  https://review.opendev.org/69753811:58
openstackgerritStephen Finucane proposed openstack/nova master: functional: Add '_delete_server' to 'InstanceHelperMixin'  https://review.opendev.org/69753911:58
openstackgerritStephen Finucane proposed openstack/nova master: functional: Add '_create_server' helper  https://review.opendev.org/69754011:58
*** nicolasbock has joined #openstack-nova12:00
*** udesale has quit IRC12:01
*** lvbin01 has quit IRC12:02
*** cgoncalves has joined #openstack-nova12:09
*** owalsh has quit IRC12:14
*** lvbin01 has joined #openstack-nova12:17
*** ociuhandu has joined #openstack-nova12:23
*** ociuhandu has quit IRC12:27
*** brault has joined #openstack-nova12:32
*** spsurya has quit IRC12:35
*** larainema has quit IRC12:44
*** owalsh has joined #openstack-nova12:46
*** cgoncalves has quit IRC12:47
*** mkrai has quit IRC12:48
*** alex_xu has joined #openstack-nova12:56
*** bhagyashris has quit IRC12:58
openstackgerritMerged openstack/nova master: Nix os-server-external-events 404 condition  https://review.opendev.org/69803712:58
openstackgerritMerged openstack/nova master: Disable NUMATopologyFilter on rebuild  https://review.opendev.org/68986112:58
*** dpawlik has quit IRC13:01
*** owalsh has quit IRC13:08
*** owalsh has joined #openstack-nova13:08
*** cgoncalves has joined #openstack-nova13:23
*** mdbooth has quit IRC13:28
*** owalsh has quit IRC13:29
*** mdbooth has joined #openstack-nova13:30
*** owalsh has joined #openstack-nova13:35
*** yaawang has quit IRC13:39
*** yaawang has joined #openstack-nova13:39
*** tssurya has quit IRC13:43
*** tssurya has joined #openstack-nova13:45
*** tbachman has joined #openstack-nova13:46
*** Liang__ has joined #openstack-nova14:00
*** tkajinam has joined #openstack-nova14:01
*** mriedem has joined #openstack-nova14:01
*** liuyulong has joined #openstack-nova14:02
*** eharney has quit IRC14:07
*** awalende has quit IRC14:13
*** awalende has joined #openstack-nova14:14
*** awalende has quit IRC14:14
*** awalende has joined #openstack-nova14:14
efriedgmann, mriedem, dansmith: How do we feel about backporting the external events fix?14:22
*** mkrai has joined #openstack-nova14:23
dansmithefried: find on principle, but unless there's something that is going to use it, I'm not sure there's a point14:23
dansmithefried: cyborg master tests against nova master yeah?14:23
efriedYeah, tight dependency, several things they're relying on (including your event cancel)14:23
efriedI can buy "wait until needed". It should be isolated enough that it would be easy to do at any point.14:24
dansmithsure, but seems about like any other cross-service dependency,14:25
dansmithunless they're going to run against the older service, there's no reason to backport something like that, and they clearly aren't going to get all of nova's cyborg integration stuff backported14:25
openstackgerritsean mooney proposed openstack/nova master: FUP for in-place numa rebuild  https://review.opendev.org/69826014:28
sean-k-mooneyefried: ^ that should adress the comments on the first two patches. i have a checkup at my doctors in 15 mins so ill look at the final patch when i get back14:29
*** Luzi has quit IRC14:29
mriedemi agree with what dan said14:29
efrieddansmith: right, I wasn't thinking of cyborg, I was thinking of some other service that needs to be able to operate against different levels of nova. If they have to change code for the fix, it might be easier for them if the fix was backported rather than them having to code for either possibility.14:30
dansmithwell,14:30
efriedI guess "other service" is just neutron, ironic, cinder14:30
dansmithI thought we said we didn't expect anyone else to notice,14:30
efriedfamous last words14:30
sean-k-mooneyneutron is the only one one that i think would send events maybe cinder and i dont think neutron ever checks the responce code14:31
dansmithso I'd want to know what actual service would care in what actual situation14:31
dansmithnot doubting that it's possible, just saying.. backports like that need reasons, IMHO14:31
efriedironic does too now for the power state thing14:31
efriedFine by me, just talking it through.14:31
dansmithefried: if they're going to notice, then backporting something they'll notice is really much worse14:31
sean-k-mooneyefried: but does it actully check the responce code14:31
* efried looks14:31
sean-k-mooneymost of the external events usage just fired the event and forgot about it14:32
efrieddansmith: yeah, that makes sense, because we can't count on the backport being applied in a given field situation, right?14:32
*** liuyulong has quit IRC14:32
dansmithefried: backports need to be things that can be applied (or not) in any order to a running deployment..14:32
sean-k-mooneyalso in the ironic case the only failure mode we know of would be for shelved instaces. is that a thing with ironic?14:32
sean-k-mooneyit could be form bfv i guess but in general i woudl guess not?14:32
sean-k-mooneyanyway got to run14:33
dansmithefried: if we backport it, you should expect someone would have yum upgraded one machine at a time, in any order, potentially without upgrading neutron or anything else, before or after14:33
dansmithefried: so if we introduce some different behavior, there are lots of ways that could be much worse than a coordinated upgrade, which would generally be smoked out ahead of time, rolled to prod in a maintenance window, etc14:33
efriedsean-k-mooney: It just uses the code for logging purposes https://review.opendev.org/#/c/664842/19/ironic/common/nova.py14:34
efriedso the behavior would change, but the result (error or not) would be the same.14:34
*** ociuhandu has joined #openstack-nova14:35
*** mmethot has joined #openstack-nova14:35
*** mmethot is now known as mmethot|conferen14:35
*** pcaruana has quit IRC14:36
efriedoh, I lied.14:37
efriedit will return True in the 207/4xx case.14:37
efried...which is only ever checked in UT. Phew.14:39
openstackgerritMerged openstack/nova stable/rocky: Do not update root_device_name during guest config  https://review.opendev.org/69635314:39
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add NodeOwnerFilter  https://review.opendev.org/69733114:43
*** eharney has joined #openstack-nova14:47
*** links has quit IRC14:48
*** tkajinam has quit IRC14:52
*** tssurya has quit IRC14:58
*** igordc has joined #openstack-nova14:58
*** lbragsta_ has joined #openstack-nova14:59
*** pcaruana has joined #openstack-nova15:01
stephenfinefried: Think I could entice you to burn through a few more of those nova-net patches today?15:11
efriedstephenfin: Totally. When do you bugger off til 2020?15:11
stephenfinI'm around until the 27th, minus the 25th/26th15:12
stephenfingone the new years week15:12
stephenfin*week of new years15:12
efriedstephenfin: cool. So, can I trade you nova-net for vTPM (not today, I've got some more updates to make)?15:13
*** seba has joined #openstack-nova15:14
efrieddun dun dahhh15:14
stephenfinI'll allow it.15:15
efriedThanks.15:15
*** bnemec has quit IRC15:15
efriedIs gibi_off off for the remainder?15:15
*** munimeha1 has joined #openstack-nova15:17
aarentskashyap: thks for the review https://review.opendev.org/#/c/696084/ I added some remarks about if go on rebase versus flatten15:24
kashyapaarents: No problem; will look.  I'm running around like a head-less chicken doing last-minute stuff15:25
aarentsk no prob15:27
efrieddansmith, mriedem, sean-k-mooney: https://review.opendev.org/698273 (ironic refactor for the external events fix)15:28
kashyapefried: If you're curious about yesterday's "competition", I won ... the "loser's final", if that makes sense15:30
sean-k-mooneyi have not seen us use the ddt stuff much i should look into that more closely sometime15:30
kashyap(There were 10 folks; two groups of 5 each.)15:30
efriedAs a veteran of tournaments, both single elimination and round robin, it makes perfect sense. How many in the bracket?15:30
efrieddisregard, race condition.15:30
kashyapHehe15:30
efriedsean-k-mooney: I actually stole that from dustinc, whom I now consider to be our ddt expert.15:31
efriedkashyap: congratulations. There are many reasons competition is a positive experience, and winning is only a small (and IMO not close to the most important) aspect.15:32
sean-k-mooneythanks for adding the comment on the ddt elements, it makes it easier to follow without having to figure it out15:32
kashyapefried: Yeah, I barely practised the last few Mondays; and went in there just to see how _different_ players play in a game vs. routine practise15:32
efriedkashyap: On that note: http://www.taylorbjj.com/why-i-dont-compete/15:33
kashyapefried: I fully agree on the positive experience; I didn't mind "losing", but was definitely fun15:33
*** tssurya has joined #openstack-nova15:33
efriedo/ tssurya. Is this coincidence, or did you just happen to see my ironic patch?15:34
tssuryaefried: saw the ironic patch comment :)15:35
tssuryaI'll see if I can clean that up15:36
efriedtssurya: I put up https://review.opendev.org/698273 already15:36
efried...and need to go note it on the original...15:36
*** lbragsta_ has quit IRC15:36
tssuryaefried: aha! thanks a lot15:36
efriedtssurya: Figured since I made the mess, I ought to clean it up :P15:37
efriedYour review would be most appreciated though.15:37
*** mgariepy has quit IRC15:37
*** lbragsta_ has joined #openstack-nova15:37
efriedkashyap: Most of that blog post is anti-what we talked about. The bottom three bullets though...15:38
* efried bbiab15:39
*** adriant has quit IRC15:40
*** mgariepy has joined #openstack-nova15:40
openstackgerritAlexandre arents proposed openstack/nova stable/queens: Do not update root_device_name during guest config  https://review.opendev.org/69646915:44
*** tssurya has quit IRC15:54
*** lbragsta_ has quit IRC15:55
*** jmlowe has joined #openstack-nova16:00
*** ociuhandu has quit IRC16:02
*** dtantsur|ikea is now known as dtantsur16:02
*** tbachman has quit IRC16:03
*** awalende has quit IRC16:08
*** awalende has joined #openstack-nova16:08
*** mlavalle has joined #openstack-nova16:10
*** igordc has quit IRC16:11
*** awalende has quit IRC16:13
kashyapefried: Thanks for the executive summary; have the URL open :-)16:18
*** iurygregory has joined #openstack-nova16:19
*** damien_r has quit IRC16:22
kashyapefried: Yeah, indeed the last three bullets hit the point right on its mazard16:22
*** lpetrut has quit IRC16:29
openstackgerritMykola Yakovliev proposed openstack/nova master: Validate aggregate IDs before querying database  https://review.opendev.org/69809416:31
*** Liang__ has quit IRC16:33
*** tbachman has joined #openstack-nova16:34
*** gyee has joined #openstack-nova16:37
openstackgerritAlexandre arents proposed openstack/nova stable/queens: Do not update root_device_name during guest config  https://review.opendev.org/69646916:38
*** lpetrut has joined #openstack-nova16:39
*** awalende has joined #openstack-nova16:45
*** mmethot|conferen is now known as mmethot16:48
openstackgerritAlexandre arents proposed openstack/nova stable/queens: Do not update root_device_name during guest config  https://review.opendev.org/69646916:49
*** jmlowe has quit IRC16:50
*** awalende has quit IRC16:50
*** lpetrut has quit IRC16:50
*** jaosorior has joined #openstack-nova16:50
*** tesseract has quit IRC16:58
*** mkrai has quit IRC17:02
*** iurygregory has quit IRC17:02
*** maciejjozefczyk has quit IRC17:08
openstackgerritMykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata  https://review.opendev.org/69804017:09
*** nweinber has joined #openstack-nova17:11
sean-k-mooneyefried: do you have a minute to talk about the notifcaiton changes in https://review.opendev.org/#/c/674072/1417:13
efriedsean-k-mooney: hmu in half an hour?17:14
efriedotp17:14
sean-k-mooneysure im goint to adress the other comments in the interim17:14
*** ociuhandu has joined #openstack-nova17:25
*** tosky has quit IRC17:27
*** lbragstad_ has joined #openstack-nova17:27
*** ociuhandu has quit IRC17:29
*** rpittau is now known as rpittau|afk17:29
*** lbragstad has quit IRC17:30
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: debug cross-cell resize  https://review.opendev.org/69830417:34
*** dtantsur is now known as dtantsur|afk17:38
openstackgerritMerged openstack/nova stable/rocky: compute: Use long_rpc_timeout in reserve_block_device_name  https://review.opendev.org/69695617:42
openstackgerritMatt Riedemann proposed openstack/nova master: Update orphaned allocations troubleshooting doc for unset command  https://review.opendev.org/69658217:49
*** links has joined #openstack-nova17:58
*** jaosorior has quit IRC17:59
*** martinkennelly has quit IRC18:12
efriedsean-k-mooney: that took longer than expected, sorry. Ready to talk about notifications?18:20
sean-k-mooneyno worries18:22
sean-k-mooneyso basicaly im a littel fuzzy on our policy18:22
sean-k-mooneyi did not need to extend the notifciaiton payload but i though we were ment to every time we added an image property18:23
sean-k-mooneygmann: ^ maybe you know18:23
*** salmankhan has quit IRC18:23
sean-k-mooneyi know we have to update the notifcaiton object if i extend a field that is used in an existing notifcation18:23
sean-k-mooneybut i dont know if its requried when we add new image properties18:24
sean-k-mooneyefried: i assume that was what you wanted to know regarding the notification change in https://review.opendev.org/#/c/674072/14 right18:25
efriedYes, that's what I wanted to know. It struck me because I'm adding (and have seen recently added) image properties and haven't seen corresponding notifications changes.18:26
sean-k-mooneyright so i was asked to add them for https://review.opendev.org/#/c/647733/ where i exetended the video_model field18:28
sean-k-mooneybut i did not add them for my vPMU change18:29
sean-k-mooneyi can drop them  but i jsut dont know if we should be keeping them in sync or not18:29
sean-k-mooneyefried: would you perfer i drop them?18:31
efriedThis may be a question for gibi_off18:31
efriedbut he's... off18:31
efriedmriedem: do you know this answer?18:31
efriedTLDR: What is the policy for keeping image meta notification payload fields consistent with image meta fields? Always, never, based on some criteria...?18:32
*** links has quit IRC18:36
mriedemotp, will get back18:37
*** ociuhandu has joined #openstack-nova18:39
*** nweinber_ has joined #openstack-nova18:39
*** nweinber has quit IRC18:41
*** ociuhandu has quit IRC18:44
*** mmethot has quit IRC18:46
*** mmethot has joined #openstack-nova18:46
*** psachin has quit IRC19:02
* efried ==> doc19:06
*** efried is now known as efried_afk19:06
*** nweinber__ has joined #openstack-nova19:16
*** nweinber_ has quit IRC19:18
*** tbachman has quit IRC19:20
*** kashyap has quit IRC19:29
mriedemcripes, i didn't know we have a notification payload ImageMetaPropsPayload that was 1:1 with ImageMetaProps19:31
mriedemgiven that, it seems it's meant to be 1:119:31
mriedemi don't think we have a policy but i'm assuming that's the intent, but would have to confirm with gibi19:32
mriedemif those are meant to be 1:1 then we need a test that asserts they are19:32
mriedemefried_afk: sean-k-mooney: ^19:32
mriedem"# NOTE(takashin): If fields are not set in the ImageMetaProps object,19:32
mriedem        # it will not set the fields in the ImageMetaPropsPayload19:32
mriedem        # in order to avoid too many fields whose values are None."19:32
*** spatel has joined #openstack-nova19:33
mriedemseems ImageMetaPropsPayload, or what uses it, would have been better off with a simple DictOfStrings thing where the values are the coerced ImageMetaProps19:34
mriedembecause keeping that all 1:1 seems a bit nuts19:34
mriedemhttps://review.opendev.org/#/c/482629/19:35
*** lbragstad_ is now known as lbragstad19:36
mriedemthe request spec payload is not as beefy but it's....beefy19:36
mriedemlite beef19:36
*** igordc has joined #openstack-nova19:39
*** gmann is now known as gmann_afk19:40
mriedemdansmith: are you aware of any poison fixtures off the top of your head for the api db? like say i want to do some stuff in a test, then nuke the api db global conf connection and run some more test code19:41
dansmithmriedem: no, since it requires using the fixture, I don't think we've ever needed one19:42
dansmithneeds the actual fixture for the api db I mean19:42
mriedemwanted to test a 'no upcall' kind of thing19:42
dansmithI imagine you could add something to the db fixture to let you break it midway if that's what you're tryingto do19:42
mriedemi was able to do something by just getting a handle to the api db fixture and calling cleanup() on it which drops the schema on the db19:44
mriedemso you get DBNonExistentTable rather than like DBConnectionError or whatever19:44
mriedemmight be good enough for what i need19:44
dansmithyeah, that's what I was thinking19:47
*** eharney has quit IRC19:55
*** awalende has joined #openstack-nova20:09
*** ralonsoh has quit IRC20:10
sean-k-mooneymriedem: ya so i think it was added as part of the version notification work20:12
sean-k-mooneybut it has to be manually updated each time20:12
*** awalende has quit IRC20:14
sean-k-mooneymriedem: so should i keep the payload notificion updates in the patch. i could post something to the mailing list if we want to change this longer term20:14
mriedemfun https://bugs.launchpad.net/nova/+bug/185592720:16
openstackLaunchpad bug 1855927 in OpenStack Compute (nova) "_poll_unconfirmed_resizes may not retry later if confirm_resize fails in API" [Low,New]20:16
*** rcernin has joined #openstack-nova20:16
mriedemsean-k-mooney: idk, ask gibi20:16
*** pcaruana has quit IRC20:16
mriedemyou get one shot at confirming a resize and if it fails you can't retry20:17
mriedemwithout db surgery20:17
sean-k-mooneyoh interesting.20:18
sean-k-mooneywould it be valid to include both finished and confiming migration in the periodic20:20
mriedemmaybe20:20
mriedemthat doesn't change the api behavior though - you'd have to do the same in the api20:20
mriedemi think like an instance task_state you likely need to reset the migration status on error20:21
sean-k-mooneytrue20:21
sean-k-mooneyi can see the logic of rolling back the migration to the  finished state but we dont want to keep retrying forever20:22
sean-k-mooneyif we go to error can we reset teh migration status to finished via the api or only via the db20:22
mriedemonly the db20:22
mriedemthere is no api to update migration records20:23
mriedemit's an extremely latent bug so not high priority, just something i noticed while writing a test around that periodic20:24
*** sorrison has quit IRC20:24
sean-k-mooneyright /os-migrations is just a list of all migration and the server migration enpoint does not have a put20:25
*** sorrison has joined #openstack-nova20:26
sean-k-mooneywe check for both finished and confriming here https://github.com/openstack/nova/blob/5a3ef39539ca112ae0552aef5cbd536338db61b7/nova/compute/manager.py#L4267 do we arrive at that form finished from teh periodic task20:30
mriedemyes20:30
sean-k-mooneyah ok20:30
mriedemhttps://github.com/openstack/nova/blob/5a3ef39539ca112ae0552aef5cbd536338db61b7/nova/compute/manager.py#L886620:31
mriedemthe periodic on the dest host calls the api method which calls confirm_resize on the source host20:31
sean-k-mooneyright but the compute api method set it to confirming https://github.com/openstack/nova/blob/5a3ef39539ca112ae0552aef5cbd536338db61b7/nova/compute/api.py#L368420:32
mriedemcorrect20:32
mriedemand after the api does that, if anything fails you can't re-confirm the resize20:32
sean-k-mooney yes but in the compute manager do_confirm_resize which is an inner function of confirm_resize seams to exepct the migration could be in finished or confriming so i was trying to figure out when could it be finish since i think it shoudld only be in confirming based on that code flow20:34
sean-k-mooneyanyway its proably not important i just thought it was odd20:34
mriedemit's probably leftover20:35
mriedemor when deleting a resized server20:35
mriedemsee _confirm_resize_on_deleting20:35
sean-k-mooneyoh so we clean up the resouce on the source node then delete it on the dest20:36
mriedemyes20:37
*** nweinber_ has joined #openstack-nova20:37
*** nweinber__ has quit IRC20:37
sean-k-mooneythat still calls confirm_resize via rpc but ya it looks like it " for status in ('finished', 'confirming'):" code was copied between the two functions20:38
*** nweinber__ has joined #openstack-nova20:39
*** jcosmao has joined #openstack-nova20:40
*** jcosmao has left #openstack-nova20:40
*** nweinber_ has quit IRC20:41
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: debug cross-cell resize  https://review.opendev.org/69830420:41
openstackgerritMatt Riedemann proposed openstack/nova master: Add cross-cell resize tests for _poll_unconfirmed_resizes  https://review.opendev.org/69832220:41
*** jcosmao has joined #openstack-nova20:42
*** tbachman has joined #openstack-nova20:48
*** eharney has joined #openstack-nova21:02
*** smcginnis has joined #openstack-nova21:05
*** jaosorior has joined #openstack-nova21:05
*** nweinber__ has quit IRC21:12
*** adriant has joined #openstack-nova21:26
*** mriedem has quit IRC21:29
*** abaindur has joined #openstack-nova21:36
*** abaindur has quit IRC21:37
*** abaindur has joined #openstack-nova21:38
*** damien_r has joined #openstack-nova21:57
*** jaosorior has quit IRC22:01
openstackgerritsean mooney proposed openstack/nova master: support pci numa affinity policies in flavor and image  https://review.opendev.org/67407222:02
*** mriedem has joined #openstack-nova22:05
*** spatel has quit IRC22:09
*** slaweq has quit IRC22:10
*** awalende has joined #openstack-nova22:10
*** nicolasbock has quit IRC22:12
*** awalende has quit IRC22:15
*** abaindur has quit IRC22:20
*** efried_afk is now known as efried22:25
efriedwell that took rather longer than expected.22:25
efriedsean-k-mooney: So I guess the right thing here is to hold off making irreversible OVO changes until we can get the word from gibi_off. Can you live with that?22:25
sean-k-mooneyyep that is fine with me22:26
sean-k-mooneyi address some of your nits22:26
sean-k-mooneybut i have not done the functional test changes yet22:26
efriedokay22:29
sean-k-mooneydo you want the extra functional test in the same patch or a follow up. i need to think about how to do it smartly instead of just copy pasting and tweeking22:30
*** awalende has joined #openstack-nova22:30
efriedsean-k-mooney: stephenfin isn't disappearing until well after you do, so getting his re+2 ought to be easy enough; same patch seems reasonable.22:34
openstackgerritsean mooney proposed openstack/nova master: fix imports of typeing module  https://review.opendev.org/69833422:35
efriedwe may not even be able to move on it until the new year -- not sure whether gibi is thoroughly gone until then.22:35
sean-k-mooneyi think artom is going to pick up the patch if its not reay before i do22:35
*** awalende has quit IRC22:35
sean-k-mooneyhum ok that would less then ideal but ok22:36
sean-k-mooneyi could split the notifciation change into a second patch if that helped22:36
*** abaindur has joined #openstack-nova22:37
sean-k-mooneyanyway im done for today so that is tommorows problem22:37
sean-k-mooneynight o/22:37
efriedyeah, let's talk again about this tomorrow, hopefully I'll have a clearer head too.22:37
efrieddansmith, sean-k-mooney, mriedem: FYI the cinder use of external events appears sane https://opendev.org/openstack/cinder/src/branch/master/cinder/compute/nova.py#L14522:44
efrieduhm22:45
efriedactually no22:45
efriedit should be setting response_error=True on L16822:45
efriedSo that's actually a latent bug22:47
efriedPreviously it would have triggered if they were extending volumes attached to multiple instances and a subset failed;22:49
efriedWith our fix it would also trigger if they were extending volumes attached to one or more instances and all failed.22:49
efriedin this case the bug is simply that they wouldn't send the error through their messaging API.22:50
mriedemrain hell fire upon them22:55
efriedI'm doing so in -cinder22:57
*** tkajinam has joined #openstack-nova23:05
*** gmann_afk is now known as gmann23:06
*** slaweq has joined #openstack-nova23:08
*** slaweq has quit IRC23:14
*** mriedem has quit IRC23:17
*** tbachman has quit IRC23:18
*** abaindur has quit IRC23:25
*** abaindur has joined #openstack-nova23:25
efried...and neutron is okay https://opendev.org/openstack/neutron/src/branch/master/neutron/notifiers/nova.py#L24423:28
efriedThey're just using the codes to print log messages, and they're doing it correctly.23:28
efriedand those are all the relevant hits23:29
efriedFYI I opened https://bugs.launchpad.net/cinder/+bug/1855940 and put up https://review.opendev.org/698340 in cinder.23:30
openstackLaunchpad bug 1855940 in Cinder "Messages sometimes not sent when nova fails to accept "extend volume" events" [Undecided,In progress] - Assigned to Eric Fried (efried)23:30
efriedand with that... o/23:30
*** tbachman has joined #openstack-nova23:34
*** avolkov has quit IRC23:43

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!