*** slaweq has joined #openstack-nova | 00:11 | |
*** slaweq has quit IRC | 00:16 | |
*** TxGirlGeek has quit IRC | 00:16 | |
*** NostawRm has quit IRC | 00:57 | |
*** brinzhang has joined #openstack-nova | 01:02 | |
*** NostawRm has joined #openstack-nova | 01:07 | |
openstackgerrit | Merged openstack/nova stable/stein: Zuul v3: use devstack-plugin-nfs-tempest-full https://review.opendev.org/699924 | 01:12 |
---|---|---|
*** mlavalle has quit IRC | 01:16 | |
*** larainema has joined #openstack-nova | 01:22 | |
*** awalende has joined #openstack-nova | 01:25 | |
*** awalende has quit IRC | 01:30 | |
*** Liang__ has quit IRC | 01:59 | |
*** tbachman has quit IRC | 02:10 | |
*** slaweq has joined #openstack-nova | 02:11 | |
*** slaweq has quit IRC | 02:16 | |
*** brinzhang_ has joined #openstack-nova | 02:18 | |
*** brinzhang_ has quit IRC | 02:20 | |
*** brinzhang_ has joined #openstack-nova | 02:20 | |
*** brinzhang has quit IRC | 02:21 | |
*** brinzhang_ has quit IRC | 02:21 | |
*** gyee has quit IRC | 02:57 | |
*** Liang__ has joined #openstack-nova | 03:10 | |
*** awalende has joined #openstack-nova | 03:26 | |
*** awalende has quit IRC | 03:31 | |
*** kukacz_ has quit IRC | 03:37 | |
*** kukacz has joined #openstack-nova | 03:39 | |
*** psachin has joined #openstack-nova | 03:39 | |
*** slaweq has joined #openstack-nova | 04:11 | |
*** slaweq has quit IRC | 04:15 | |
*** bhagyashris has joined #openstack-nova | 04:37 | |
*** mkrai has joined #openstack-nova | 04:56 | |
*** links has joined #openstack-nova | 04:57 | |
*** ociuhandu has joined #openstack-nova | 05:30 | |
*** bhagyashris has quit IRC | 05:34 | |
*** ociuhandu has quit IRC | 05:35 | |
*** abhishekk has joined #openstack-nova | 05:50 | |
*** pcaruana has joined #openstack-nova | 05:52 | |
*** bhagyashris has joined #openstack-nova | 05:59 | |
*** slaweq has joined #openstack-nova | 06:11 | |
*** larainema has quit IRC | 06:12 | |
*** slaweq has quit IRC | 06:16 | |
*** lpetrut has quit IRC | 06:29 | |
*** rcernin has quit IRC | 06:31 | |
*** mmethot_ has joined #openstack-nova | 06:35 | |
*** mmethot has quit IRC | 06:37 | |
openstackgerrit | Merged openstack/nova master: Add functional cross-cell revert test with detached volume https://review.opendev.org/695335 | 06:41 |
openstackgerrit | Merged openstack/nova master: Refresh target cell instance after finish_snapshot_based_resize_at_dest https://review.opendev.org/698787 | 06:41 |
*** awalende has joined #openstack-nova | 07:30 | |
*** awalende has quit IRC | 07:35 | |
*** zhanglong has joined #openstack-nova | 07:36 | |
*** slaweq has joined #openstack-nova | 07:47 | |
*** maciejjozefczyk has joined #openstack-nova | 07:49 | |
*** bhagyashris has quit IRC | 07:57 | |
*** tkajinam has quit IRC | 08:14 | |
*** tosky has joined #openstack-nova | 08:19 | |
*** awalende has joined #openstack-nova | 08:19 | |
*** dikonoor has joined #openstack-nova | 08:20 | |
openstackgerrit | Luigi Toscano proposed openstack/nova stable/rocky: Zuul v3: use devstack-plugin-nfs-tempest-full https://review.opendev.org/700121 | 08:23 |
*** slaweq has quit IRC | 08:23 | |
openstackgerrit | XiaojueGuan proposed openstack/nova master: Fix error out with an UnboundException when in build_and_run_instance https://review.opendev.org/698140 | 08:26 |
*** awalende has quit IRC | 08:29 | |
*** awalende has joined #openstack-nova | 08:30 | |
*** chenhaw has joined #openstack-nova | 08:32 | |
*** chenhaw has quit IRC | 08:43 | |
*** chenhaw has joined #openstack-nova | 08:44 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add api for instance action details https://review.opendev.org/700123 | 08:50 |
*** chenhaw has quit IRC | 08:55 | |
*** ccamacho has joined #openstack-nova | 09:03 | |
*** brinzhang has joined #openstack-nova | 09:03 | |
openstackgerrit | XiaojueGuan proposed openstack/nova master: Fix error out with an UnboundException when in build_and_run_instance https://review.opendev.org/698140 | 09:04 |
*** chenhaw has joined #openstack-nova | 09:04 | |
openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Add composable flavor properties https://review.opendev.org/663563 | 09:05 |
*** chenhaw has quit IRC | 09:08 | |
*** chenhaw has joined #openstack-nova | 09:08 | |
*** bhagyashris has joined #openstack-nova | 09:08 | |
*** rcernin has joined #openstack-nova | 09:08 | |
openstackgerrit | Chason Chan proposed openstack/nova master: Add description of live_migration_timeout_action option https://review.opendev.org/700124 | 09:10 |
*** chenhaw has quit IRC | 09:14 | |
*** chenhaw has joined #openstack-nova | 09:17 | |
*** Liang__ has quit IRC | 09:18 | |
*** awalende has quit IRC | 09:21 | |
*** awalende has joined #openstack-nova | 09:21 | |
*** ociuhandu has joined #openstack-nova | 09:25 | |
*** awalende has quit IRC | 09:26 | |
*** ociuhandu has quit IRC | 09:29 | |
*** chenhaw has quit IRC | 09:31 | |
*** chenhaw has joined #openstack-nova | 09:38 | |
*** derekh has joined #openstack-nova | 09:42 | |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: FUP for in-place numa rebuild https://review.opendev.org/700127 | 09:42 |
*** martinkennelly has joined #openstack-nova | 09:46 | |
*** lpetrut has joined #openstack-nova | 09:47 | |
*** brinzhang_ has joined #openstack-nova | 09:49 | |
*** ociuhandu has joined #openstack-nova | 09:52 | |
*** brinzhang has quit IRC | 09:52 | |
*** ociuhandu has quit IRC | 09:56 | |
*** ivve has joined #openstack-nova | 09:57 | |
*** awalende has joined #openstack-nova | 10:13 | |
*** dikonoor has quit IRC | 10:16 | |
*** chenhaw has quit IRC | 10:22 | |
*** brinzhang has joined #openstack-nova | 10:28 | |
*** brinzhang has quit IRC | 10:30 | |
*** brinzhang has joined #openstack-nova | 10:30 | |
*** brinzhang_ has quit IRC | 10:31 | |
*** abhishekk has quit IRC | 10:35 | |
*** bhagyashris has quit IRC | 10:48 | |
*** rcernin has quit IRC | 10:49 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Add note about an image signature validation limitation when using rbd https://review.opendev.org/700152 | 10:50 |
lyarwood | stephenfin: ^ simple doc wrinkle if you have time today | 10:50 |
stephenfin | looks sane. +2 | 10:51 |
*** mkrai has quit IRC | 10:54 | |
*** mkrai has joined #openstack-nova | 10:54 | |
*** mkrai_ has joined #openstack-nova | 10:56 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: FakeDriver: adding and removing instances on live migration. https://review.opendev.org/243613 | 10:59 |
*** mkrai has quit IRC | 10:59 | |
*** mkrai_ has quit IRC | 11:00 | |
*** brinzhang has quit IRC | 11:01 | |
*** mkrai has joined #openstack-nova | 11:05 | |
*** zhanglong has quit IRC | 11:15 | |
*** bhagyashris has joined #openstack-nova | 11:22 | |
*** mkrai has quit IRC | 11:33 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Print help if nova-manage subcommand is not specified https://review.opendev.org/694806 | 11:41 |
openstackgerrit | Merged openstack/nova master: FUP for in-place numa rebuild https://review.opendev.org/698260 | 11:41 |
openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Handle new is_volume_backend join column query https://review.opendev.org/694462 | 11:47 |
openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Instance object changes for the new 'is_volume_backed' expected_attr https://review.opendev.org/694463 | 11:47 |
openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Ignore root_gb if instance is booted from volume https://review.opendev.org/612626 | 11:47 |
*** maciejjozefczyk has quit IRC | 11:51 | |
*** priteau has joined #openstack-nova | 12:03 | |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: FUP for in-place numa rebuild https://review.opendev.org/700127 | 12:09 |
stephenfin | lyarwood: fixed https://review.opendev.org/#/c/700127/ | 12:10 |
*** lbragstad_ has joined #openstack-nova | 12:15 | |
*** lbragstad has quit IRC | 12:15 | |
lyarwood | stephenfin: ack, grabbing lunch and then I'll queue that series up | 12:15 |
*** bhagyashris_ has joined #openstack-nova | 12:20 | |
*** bhagyashris has quit IRC | 12:22 | |
stephenfin | bauzas: You bored? I have a load of patches with single +2 that could do with a little push | 12:28 |
stephenfin | And I think you're the only other core still around. Lucky you ;) | 12:28 |
*** martinkennelly has quit IRC | 12:30 | |
*** bhagyashris_ is now known as bhagyashris | 12:32 | |
*** dviroel has joined #openstack-nova | 12:35 | |
*** bhagyashris has quit IRC | 12:53 | |
*** adriant has quit IRC | 12:57 | |
*** adriant has joined #openstack-nova | 12:58 | |
*** mkrai has joined #openstack-nova | 13:28 | |
*** artom has quit IRC | 13:29 | |
*** martinkennelly has joined #openstack-nova | 13:38 | |
*** tbachman has joined #openstack-nova | 13:45 | |
*** mkrai has quit IRC | 13:49 | |
*** spotz has joined #openstack-nova | 13:59 | |
bauzas | stephenfin: heh, sure | 13:59 |
bauzas | stephenfin: sorry, I was on gym :) | 14:00 |
*** nweinber has joined #openstack-nova | 14:02 | |
*** mriedem has joined #openstack-nova | 14:06 | |
mriedem | lyarwood: i'm +2 on these train numa rebuild backports now if you want to send them on https://review.opendev.org/#/q/topic:bug/1763766+status:open | 14:09 |
*** lpetrut has quit IRC | 14:09 | |
lyarwood | mriedem: ack, have them open now, looking. | 14:10 |
TheJulia | Can anyone provide background on the "forbidden trait COMPUTE_STATUS_DISABLED" ? | 14:11 |
mriedem | TheJulia: https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#compute-disabled-status-support | 14:12 |
TheJulia | hmm... then the question becomes why does nova think the nova-compute for ironic is no longer working when it just deleted an instance :\ | 14:14 |
TheJulia | well, minutes before in the same running process :\ | 14:15 |
* TheJulia goes back to ogs | 14:15 | |
TheJulia | logs | 14:15 |
TheJulia | mriedem: is it the conductor that is making that declaration ? | 14:18 |
mriedem | no, | 14:20 |
mriedem | if the compute service is enabled/disabled in the rest api then the trait added to or removed from the associated nodes that service is managing | 14:21 |
mriedem | some virt drivers (i think only libvirt) will auto-enable/disable if the hypervisor is down/up | 14:21 |
mriedem | so it could also be the compute via the driver that sets it | 14:21 |
mriedem | you can disable a compute service and still delete instances from it | 14:22 |
TheJulia | I was thought that there was some automagical thing close to the compute driver... sifting through the n-cpu logs very carefully at the moment | 14:22 |
mriedem | disable != down | 14:22 |
TheJulia | disable from scheduling, that makes sense | 14:22 |
mriedem | correct | 14:22 |
* TheJulia wonders how in the world n-cpu for nova.virt.ironic is getting disabled in grenade | 14:22 | |
mriedem | are you seeing the logging from here? https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L546-L553 | 14:27 |
TheJulia | mriedem: nope :\ | 14:28 |
mriedem | does the ironic grenade multinode job disable one compute before upgrading it which triggers a rebalance of nodes from one compute to another? | 14:29 |
*** awalende has quit IRC | 14:30 | |
TheJulia | this is a single stack job so everything get stopped and restarted | 14:31 |
TheJulia | I see a get to os-service early on, but no puts | 14:32 |
TheJulia | err, posts | 14:32 |
mriedem | and the ironic virt driver doesn't auto enable/disable the compute service does it? | 14:32 |
mriedem | the disable/enable is a PUT | 14:32 |
TheJulia | oh, good, then none at all in the nova api log :) | 14:33 |
mriedem | https://docs.openstack.org/api-ref/compute/#compute-services-os-services | 14:33 |
*** links has quit IRC | 14:33 | |
TheJulia | I'm honestly don't remember if we auto-disable or not. I guess that is the next thing to look at | 14:33 |
mriedem | i don't see anything in the driver | 14:34 |
*** eharney has joined #openstack-nova | 14:44 | |
*** tbachman has left #openstack-nova | 14:45 | |
*** ccamacho has quit IRC | 14:57 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle cell failures in get_compute_nodes_by_host_or_node https://review.opendev.org/700186 | 15:06 |
*** pcaruana has quit IRC | 15:25 | |
*** mkrai has joined #openstack-nova | 15:25 | |
*** ivve has quit IRC | 15:50 | |
*** derekh has quit IRC | 15:51 | |
*** mkrai has quit IRC | 15:53 | |
*** mkrai_ has joined #openstack-nova | 15:53 | |
bauzas | stephenfin: don't hesitate to ping me the changes you'd like me to review | 15:54 |
TheJulia | mriedem: by chance is that last patch related to our discussion? :) | 15:55 |
mriedem | TheJulia: nope | 15:55 |
mriedem | bauzas: bottom 4 nova-net removal changes are +2ed and ready to go https://review.opendev.org/#/c/696510/ | 15:56 |
mriedem | starting at ^ | 15:56 |
bauzas | mriedem: thanks ! | 15:56 |
bauzas | I'm finally back upstream this week FWIW | 15:56 |
*** dave-mccowan has joined #openstack-nova | 15:58 | |
*** mkrai_ has quit IRC | 15:59 | |
TheJulia | mriedem: rats, I was hopeful :) | 16:00 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: guestfs: Log a useful error when the required vmlinuz isn't found https://review.opendev.org/700193 | 16:01 |
*** mlavalle has joined #openstack-nova | 16:03 | |
openstackgerrit | Merged openstack/nova stable/train: Remove 'test_cold_migrate_with_physnet_fails' test https://review.opendev.org/700021 | 16:10 |
mriedem | gibi_pto: nits in https://review.opendev.org/#/c/699015/ for when you want to start a FUP patch for that series | 16:12 |
mriedem | bauzas: also, the bottom few changes in the live migration + qos ports series ^ are +2ed and need another core | 16:16 |
mriedem | per usual gibi has done a lot of good functional testing | 16:17 |
*** yan0s has quit IRC | 16:22 | |
*** mkrai_ has joined #openstack-nova | 16:26 | |
bauzas | mriedem: ack, will review it too on monday | 16:33 |
mriedem | johnthetubaguy: are you ok with me fixing https://review.opendev.org/#/c/697162/7/nova/tests/unit/compute/test_shelve.py@168 in a follow up? | 16:36 |
johnthetubaguy | mriedem: yeah | 16:37 |
johnthetubaguy | I assumed I miss-read it, no worries | 16:37 |
mriedem | thanks | 16:40 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add negative test to delete server during cross-cell resize claim https://review.opendev.org/688832 | 16:43 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Implement reschedule logic for cross-cell resize/migrate https://review.opendev.org/696213 | 16:43 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: FUP to Iff8194c868580facb1cc81b5567d66d4093c5274 https://review.opendev.org/700202 | 16:44 |
*** stephenfin has quit IRC | 16:49 | |
*** stephenfin has joined #openstack-nova | 16:50 | |
*** gyee has joined #openstack-nova | 16:51 | |
*** stephenfin has quit IRC | 16:52 | |
*** stephenfin has joined #openstack-nova | 16:53 | |
*** mkrai_ has quit IRC | 16:53 | |
gmann | johnthetubaguy: i can change the default target logic in policy.py. cannot remember what case i thought it can break if moving to common place - https://review.opendev.org/#/c/676688/5 | 17:04 |
gmann | johnthetubaguy: also, do you have time to discuss the admin policy case - https://review.opendev.org/#/c/676682/5 | 17:05 |
johnthetubaguy | gmann: sure | 17:10 |
gmann | johnthetubaguy: in this case, new default (base.SYSTEM_ADMIN) has special string 'system=all' which will not match with existing project admin even enforce_scope is flase | 17:12 |
gmann | that is why i think we need to deprecate it to support the existing user's token keep working | 17:12 |
johnthetubaguy | but I am not sure we need to add it yet | 17:13 |
johnthetubaguy | in the admin_only case, that is | 17:14 |
johnthetubaguy | but... I get your point for admin_or_owner, hmm | 17:15 |
gmann | you mean 'system=all' ? | 17:15 |
johnthetubaguy | yeah | 17:15 |
johnthetubaguy | because in the admin_only case, we already check via the scope check | 17:16 |
gmann | that is needed for the window when we remove the deprecated rule and make enforce_scope=True by default. in that window project admin should not be able to do system admin operation. | 17:16 |
gmann | if enforce_scope if false then scope check is not checked right. | 17:16 |
johnthetubaguy | yeah, I just assumed those two things happened at the same time | 17:17 |
*** martinkennelly has quit IRC | 17:17 | |
johnthetubaguy | gmann: maybe we should do the admin_password API, its admin_or_owner | 17:18 |
johnthetubaguy | I think what works there we probably want to apply to the admin api too | 17:18 |
johnthetubaguy | I think the points you made above, I totally agree with you for the admin_or_owner case | 17:19 |
gmann | if both things happen at same time then yes i agree with your point for admin case. | 17:19 |
gmann | yeah admin_or_owner and any lower role like member or reader we need that string. | 17:20 |
gmann | so that we do not expose any project level reader to system level reader | 17:20 |
johnthetubaguy | what about doing the deprecation at this level: https://review.opendev.org/#/c/645452/17/nova/policies/base.py | 17:21 |
gmann | s/system level reader to project level reader | 17:21 |
johnthetubaguy | we spoke about someone wanting to use this sooner they can override the base policy rule to always to the system check, if they want to opt into the new world early | 17:21 |
gmann | yeah | 17:22 |
gmann | did not get your last point on deprecation at base level ? | 17:23 |
johnthetubaguy | so thinking about this: https://github.com/openstack/nova/blob/b953db09e8b9195c6a922c03a57f44cd790adcb6/nova/policies/base.py#L79 | 17:23 |
johnthetubaguy | what if we move the APIs over to the new rule | 17:23 |
johnthetubaguy | but we add a deprecated bit to the new rule, so it falls back to allowing the old check in there? | 17:24 |
johnthetubaguy | ... i am not explaining this well | 17:24 |
gmann | i think i got your point and deprecate to RULE_ADMIN_API | 17:25 |
johnthetubaguy | yeah | 17:25 |
johnthetubaguy | so when an operator wants the new world, its only a few rules they change | 17:25 |
gmann | but what if any API rule changing from RULE_ADMIN_OR_OWNER - > SYSTEM_ADMIN ? i think no.. | 17:26 |
gmann | it will be -> either PROJECT_MEMBER_OR_SYSTEM_ADMIN or PROJECT_READER_OR_SYSTEM_READER that what we have in table | 17:27 |
johnthetubaguy | yeah, that is the only option I believe | 17:27 |
johnthetubaguy | and it should work OK for those two | 17:27 |
johnthetubaguy | hopefully the unit tests will keep us honest here anyways | 17:28 |
johnthetubaguy | once we have added them :) | 17:28 |
gmann | johnthetubaguy: then all case we can do in base rules as per this tabel? -https://github.com/openstack/nova/blob/b953db09e8b9195c6a922c03a57f44cd790adcb6/nova/policies/base.py#L41 | 17:28 |
johnthetubaguy | yeah, I hope so | 17:28 |
johnthetubaguy | so if we go through the cases... | 17:29 |
gmann | until we encounter any such policy conflicting that table but we can check that if we encounter such case | 17:29 |
johnthetubaguy | 1) no overrides, just use default, they keep working | 17:29 |
gmann | ahh 1 min | 17:29 |
gmann | so override would not work in that case | 17:29 |
johnthetubaguy | ah, why is that? | 17:30 |
johnthetubaguy | I think if you override, it skips doing an or with the deprecated rule | 17:30 |
gmann | because override is done with specific policy rules not base rules | 17:30 |
johnthetubaguy | right, but I think that is OK | 17:30 |
johnthetubaguy | in the sense that if the override it to something special, that something special stays the same | 17:31 |
gmann | yeah override rule is first pick in oslo policy. | 17:32 |
johnthetubaguy | maybe another question... what upgrade check should we when we want to make enforce_scope = true? | 17:33 |
johnthetubaguy | we could warn if they have any policy rules overriden that they need checking, but not sure what else we can do really | 17:33 |
gmann | we need deprecation at specific policy level when we do granularity where rule name change like- https://review.opendev.org/#/c/648480/23/nova/policies/services.py | 17:33 |
johnthetubaguy | this is more for "next" release, after we make the initial backwards compatible change | 17:33 |
johnthetubaguy | gmann: +1 | 17:34 |
johnthetubaguy | that case we totally need that | 17:34 |
johnthetubaguy | but that is a sort of independent issue, its because we added more granularity | 17:34 |
gmann | yeah | 17:35 |
johnthetubaguy | and folks make have overriden the old rule | 17:35 |
johnthetubaguy | cool, does that mean we are all set? | 17:35 |
gmann | for upgrade check, i was thinking auto correction but it need more thought. | 17:36 |
johnthetubaguy | yeah, although I don't think it blocks this release's work a such | 17:36 |
johnthetubaguy | the simplest check is probably to see if the override is the old default | 17:37 |
johnthetubaguy | in case people haven't deleted their old policy files they always used to deploy | 17:37 |
johnthetubaguy | there is an ops meetup after christmas, I could ask around there if policy comes up | 17:37 |
gmann | +1, that will be great. | 17:38 |
johnthetubaguy | cool, happy holidays when that happens | 17:38 |
gmann | seems all set for now. thanks for discussion. | 17:38 |
johnthetubaguy | no problem, thanks for pushing this, so many of our customers are wanting to see this move forward | 17:39 |
gmann | you too. i will try to make other policy ready once you are back | 17:39 |
johnthetubaguy | cool | 17:39 |
gmann | also waiting for stephenfin to reply on this, i could not understand his query (if something interesting to care at initial level)- https://review.opendev.org/#/c/657698/14 | 17:40 |
johnthetubaguy | gmann: I think stephenfin was meaning we could have left the unit tests where they were, under api, rather than "moving" to policy | 17:43 |
gmann | ohk | 17:44 |
johnthetubaguy | personally, I had assumed we were putting the unit tests under api/ before I saw your patches, but I wasn't against moving it | 17:45 |
gmann | i think doing under separate dir is more explicit and easy to check coverage. inside API it was very hidden kind of testing. but may be it just me ? | 17:45 |
johnthetubaguy | the other thing, is when you cut and paste all the tests when adding a new API, you might not see the policy tests | 17:45 |
johnthetubaguy | not that people do that, of course (cough) | 17:45 |
gmann | i actually went with the code structure. policies is not under API code | 17:45 |
johnthetubaguy | but we are testing the context.can call, and that is under the API code | 17:46 |
johnthetubaguy | I should be clear, my +2 stands, I don't mind the idea, for the reasons you just said | 17:46 |
johnthetubaguy | really just playing devils advocate to make sure we are sure | 17:47 |
gmann | ok. i can move as its not big deal. may be under ./nova/tests/unit/api or nova/tests/unit/api/openstack/compute ? | 17:48 |
johnthetubaguy | I think for that patch, basically it goes where those deleted tests are | 17:49 |
johnthetubaguy | but I would +2 either approach, until I hear a stronger argument for one or the other | 17:50 |
gmann | i think we should do under separate dir but under API dir or api/openstack/compute | 17:50 |
johnthetubaguy | oh... in some ways that is worse | 17:50 |
gmann | inside API test files it is very hidden honestly. | 17:51 |
johnthetubaguy | lets stick with what you have already, assuming stephenfin is OK with it after we tell him why | 17:51 |
gmann | in doc we can say 'any API change or policy, review can check the tests under this folder' | 17:51 |
gmann | ok | 17:51 |
johnthetubaguy | I think either we consider it testing the policy file or the api file, its basically testing both | 17:52 |
johnthetubaguy | hence I am OK with either next to all the API unit tests (like the old broken tests we delete) or in the new place you chose | 17:53 |
johnthetubaguy | its easy enough to move if we decide we made the wrong call | 17:53 |
johnthetubaguy | cool, I should run, was good to catch up | 17:54 |
gmann | ok. let's see what stephenfin say. | 17:54 |
johnthetubaguy | +1 | 17:54 |
gmann | sure, thanks | 17:54 |
*** CeeMac has quit IRC | 18:06 | |
*** psachin has quit IRC | 18:13 | |
*** priteau has quit IRC | 18:21 | |
*** eharney has quit IRC | 18:35 | |
*** hamzy_ has quit IRC | 18:42 | |
*** tbachman has joined #openstack-nova | 18:43 | |
*** tosky has quit IRC | 18:45 | |
*** tbachman has quit IRC | 18:47 | |
*** tbachman has joined #openstack-nova | 18:48 | |
openstackgerrit | Merged openstack/nova stable/train: Block rebuild when NUMA topology changed https://review.opendev.org/698530 | 18:49 |
*** tbachman has quit IRC | 18:49 | |
*** tbachman has joined #openstack-nova | 18:49 | |
*** hamzy has joined #openstack-nova | 19:07 | |
*** brault has quit IRC | 19:17 | |
*** eharney has joined #openstack-nova | 19:24 | |
*** openstackgerrit has quit IRC | 19:27 | |
*** tbachman has quit IRC | 19:36 | |
*** tbachman has joined #openstack-nova | 19:40 | |
*** factor has quit IRC | 19:54 | |
*** factor has joined #openstack-nova | 19:54 | |
*** openstackgerrit has joined #openstack-nova | 19:58 | |
openstackgerrit | Merged openstack/nova stable/stein: Cache security group driver https://review.opendev.org/697480 | 19:58 |
openstackgerrit | Merged openstack/nova stable/stein: Improve metadata server performance with large security groups https://review.opendev.org/695925 | 20:10 |
*** liuyulong has quit IRC | 20:21 | |
*** dave-mccowan has quit IRC | 21:13 | |
openstackgerrit | Merged openstack/nova master: FakeDriver: adding and removing instances on live migration. https://review.opendev.org/243613 | 21:18 |
mriedem | stephenfin: some easy things to cleanup in the xvpvncproxy removal change https://review.opendev.org/#/c/687909/ - i'm sure i'll probably be poking around in gerrit next week to avoid my in-laws so if you get that updated i'm +2 | 21:24 |
*** nweinber has quit IRC | 21:37 | |
*** dviroel has quit IRC | 21:41 | |
openstackgerrit | Merged openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | 21:48 |
*** rcernin has joined #openstack-nova | 21:55 | |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | 21:55 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | 21:55 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522 | 21:55 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: WIP: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460 | 21:55 |
*** dustinc is now known as dustinc_inandout | 22:17 | |
mriedem | gmann: nova.tests.unit.test_policy.RealRolePolicyTestCase.test_all_rules_in_sample_file is dumping a lot to the console log | 22:38 |
mriedem | https://zuul.opendev.org/t/openstack/build/3a837b550b2344aca69eaf747dc5a0c2/log/job-output.txt#20581 | 22:38 |
*** ccstone has joined #openstack-nova | 23:08 | |
*** artom has joined #openstack-nova | 23:09 | |
*** rcernin has quit IRC | 23:27 | |
*** gyee has quit IRC | 23:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!