*** threestrands has joined #openstack-nova | 00:38 | |
*** jistr has quit IRC | 00:45 | |
*** jistr has joined #openstack-nova | 00:48 | |
*** yedongcan has joined #openstack-nova | 00:53 | |
*** Liang__ has joined #openstack-nova | 00:58 | |
*** mvkr has joined #openstack-nova | 01:15 | |
*** yedongcan has quit IRC | 01:20 | |
*** lvbin02 has joined #openstack-nova | 01:41 | |
*** threestrands has quit IRC | 01:43 | |
*** lvbin01 has quit IRC | 01:44 | |
*** lvbin02 is now known as lvbin01 | 01:44 | |
*** yedongcan has joined #openstack-nova | 02:11 | |
*** tbachman has joined #openstack-nova | 02:20 | |
*** awalende has joined #openstack-nova | 02:45 | |
*** awalende has quit IRC | 02:49 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Populate 'updated_at' when aggregate is updated https://review.opendev.org/580271 | 03:09 |
---|---|---|
*** threestrands has joined #openstack-nova | 03:10 | |
*** threestrands has quit IRC | 03:11 | |
*** threestrands has joined #openstack-nova | 03:11 | |
*** huaqiang has quit IRC | 03:24 | |
*** mkrai has joined #openstack-nova | 04:00 | |
*** davee__ has joined #openstack-nova | 04:03 | |
*** yedongcan has quit IRC | 04:04 | |
*** davee_ has quit IRC | 04:05 | |
*** davee___ has quit IRC | 04:05 | |
*** davee_ has joined #openstack-nova | 04:06 | |
*** nweinber__ has joined #openstack-nova | 04:08 | |
*** bhagyashris has joined #openstack-nova | 04:11 | |
*** nweinber__ has quit IRC | 04:22 | |
*** bhagyashris has quit IRC | 04:42 | |
*** bhagyashris has joined #openstack-nova | 05:04 | |
*** TxGirlGeek has joined #openstack-nova | 05:10 | |
alex_xu | efried: sean-k-mooney, if we only support placement-ese, then we will get mixing case like, user specified the cpu_policy=dedicated or shared, also specified PCPU and VCPU in resources. | 05:12 |
*** awalende has joined #openstack-nova | 05:18 | |
alex_xu | efried: sean-k-mooney, huaqiang reminder me, we currently refuse both cpu_policy and PCPU/VPCU are specified, so it should be ok | 05:18 |
*** TxGirlGeek has quit IRC | 05:18 | |
alex_xu | efried: sean-k-mooney i'm ok with that algo, I guess that algo will be done at API layer,not the virt layer. | 05:19 |
*** awalende has quit IRC | 05:22 | |
*** evrardjp has quit IRC | 05:33 | |
*** evrardjp has joined #openstack-nova | 05:34 | |
*** threestrands has quit IRC | 05:38 | |
alex_xu | efried: sean-k-mooney and if the user specified PCPU and VCPU in resources, then the value of InstanceNUMACell.cpu_policy will be 'dedicated'. then we didn't introduce new policy 'mixed' anymore, does sounds make sense to you? | 05:51 |
*** huaqiang has joined #openstack-nova | 05:55 | |
*** ratailor has joined #openstack-nova | 05:58 | |
*** zhanglong has joined #openstack-nova | 06:00 | |
*** yedongcan has joined #openstack-nova | 06:00 | |
*** huaqiang has quit IRC | 06:03 | |
*** huaqiang has joined #openstack-nova | 06:03 | |
*** zhanglong has quit IRC | 06:04 | |
*** zhanglong has joined #openstack-nova | 06:05 | |
*** yedongcan has quit IRC | 06:07 | |
*** huaqiang has quit IRC | 06:09 | |
*** udesale has joined #openstack-nova | 06:09 | |
*** huaqiang has joined #openstack-nova | 06:09 | |
*** udesale is now known as udesale_ | 06:28 | |
*** udesale_ is now known as udesale | 06:29 | |
*** Luzi has joined #openstack-nova | 06:35 | |
*** zhanglong has quit IRC | 06:36 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Populate 'updated_at' when aggregate is updated https://review.opendev.org/580271 | 06:39 |
*** ratailor_ has joined #openstack-nova | 06:41 | |
*** ratailor has quit IRC | 06:42 | |
*** zhanglong has joined #openstack-nova | 06:44 | |
*** ratailor__ has joined #openstack-nova | 06:46 | |
*** zhanglong has quit IRC | 06:49 | |
*** ratailor_ has quit IRC | 06:49 | |
*** zhanglong has joined #openstack-nova | 06:51 | |
*** shilpasd has joined #openstack-nova | 06:55 | |
*** awalende has joined #openstack-nova | 07:01 | |
*** jawad-axd has joined #openstack-nova | 07:02 | |
*** awalende_ has joined #openstack-nova | 07:03 | |
*** awalende has quit IRC | 07:05 | |
*** jawad-axd has quit IRC | 07:06 | |
*** slaweq has joined #openstack-nova | 07:07 | |
*** jawad-axd has joined #openstack-nova | 07:07 | |
*** jawad-ax_ has joined #openstack-nova | 07:10 | |
*** jawad-axd has quit IRC | 07:12 | |
*** slaweq has quit IRC | 07:12 | |
*** rcernin has quit IRC | 07:13 | |
*** slaweq has joined #openstack-nova | 07:16 | |
*** zhanglong has quit IRC | 07:18 | |
*** dpawlik has joined #openstack-nova | 07:21 | |
*** zhanglong has joined #openstack-nova | 07:21 | |
*** brinzhang has joined #openstack-nova | 07:24 | |
*** ralonsoh has joined #openstack-nova | 07:29 | |
*** ircuser-1 has quit IRC | 07:33 | |
*** aarents has joined #openstack-nova | 07:34 | |
*** brinzhang_ has joined #openstack-nova | 07:36 | |
*** brinzhang has quit IRC | 07:39 | |
*** maciejjozefczyk has joined #openstack-nova | 07:47 | |
*** brinzhang has joined #openstack-nova | 07:48 | |
*** brinzhang_ has quit IRC | 07:51 | |
*** bhagyashris has quit IRC | 07:58 | |
*** trident has joined #openstack-nova | 08:02 | |
*** ganso has quit IRC | 08:08 | |
*** ganso has joined #openstack-nova | 08:09 | |
*** damien_r has joined #openstack-nova | 08:10 | |
*** brinzhang_ has joined #openstack-nova | 08:10 | |
*** brinzhang has quit IRC | 08:13 | |
*** tesseract has joined #openstack-nova | 08:21 | |
*** tosky has joined #openstack-nova | 08:22 | |
*** jangutter has joined #openstack-nova | 08:33 | |
*** rpittau|afk is now known as rpittau | 08:35 | |
*** zbr is now known as zbr|rover | 08:37 | |
*** iurygregory has joined #openstack-nova | 09:02 | |
*** bhagyashris has joined #openstack-nova | 09:05 | |
*** ociuhandu has joined #openstack-nova | 09:07 | |
*** ociuhandu has quit IRC | 09:12 | |
*** xek has joined #openstack-nova | 09:16 | |
*** ociuhandu has joined #openstack-nova | 09:20 | |
*** brinzhang_ has quit IRC | 09:32 | |
*** Liang__ is now known as Liangfang | 09:33 | |
*** Liangfang is now known as LiangFang | 09:33 | |
*** brinzhang_ has joined #openstack-nova | 09:33 | |
*** derekh has joined #openstack-nova | 09:38 | |
*** ociuhandu has quit IRC | 09:39 | |
*** ociuhandu has joined #openstack-nova | 09:40 | |
*** brinzhang has joined #openstack-nova | 09:41 | |
*** martinkennelly has joined #openstack-nova | 09:43 | |
*** ociuhandu has quit IRC | 09:44 | |
*** brinzhang_ has quit IRC | 09:45 | |
*** pcaruana has joined #openstack-nova | 09:49 | |
*** brinzhang_ has joined #openstack-nova | 09:51 | |
*** mkrai has quit IRC | 09:53 | |
*** brinzhang has quit IRC | 09:55 | |
openstackgerrit | Liang Fang proposed openstack/nova-specs master: Support volume local cache https://review.opendev.org/689070 | 09:55 |
*** ociuhandu has joined #openstack-nova | 09:56 | |
*** pcaruana has quit IRC | 09:56 | |
*** ociuhandu has quit IRC | 09:58 | |
*** ratailor has joined #openstack-nova | 09:59 | |
*** ociuhandu has joined #openstack-nova | 09:59 | |
*** LiangFang has quit IRC | 09:59 | |
*** ratailor__ has quit IRC | 10:01 | |
*** brinzhang has joined #openstack-nova | 10:02 | |
*** ociuhandu has quit IRC | 10:03 | |
*** zhanglong has quit IRC | 10:04 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Mask the token used to allow access to consoles https://review.opendev.org/702181 | 10:04 |
*** ociuhandu has joined #openstack-nova | 10:05 | |
*** brinzhang_ has quit IRC | 10:06 | |
*** jawad-ax_ has quit IRC | 10:07 | |
*** ociuhandu has quit IRC | 10:07 | |
*** ratailor_ has joined #openstack-nova | 10:17 | |
*** iurygregory has quit IRC | 10:18 | |
*** ratailor has quit IRC | 10:19 | |
*** brinzhang_ has joined #openstack-nova | 10:21 | |
*** brinzhang has quit IRC | 10:24 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use EphemeralObject for non DB versioned objects https://review.opendev.org/702184 | 10:25 |
*** iurygregory has joined #openstack-nova | 10:28 | |
*** brinzhang has joined #openstack-nova | 10:30 | |
*** ociuhandu has joined #openstack-nova | 10:32 | |
*** dtantsur|afk is now known as dtantsur | 10:32 | |
*** brinzhang_ has quit IRC | 10:33 | |
*** ociuhandu has quit IRC | 10:34 | |
*** brinzhang_ has joined #openstack-nova | 10:40 | |
*** brinzhang has quit IRC | 10:43 | |
*** jawad-axd has joined #openstack-nova | 10:49 | |
*** jawad-axd has quit IRC | 10:53 | |
*** rpittau is now known as rpittau|bbl | 11:03 | |
*** ociuhandu has joined #openstack-nova | 11:06 | |
*** rcernin has joined #openstack-nova | 11:11 | |
*** jawad-axd has joined #openstack-nova | 11:14 | |
*** brinzhang has joined #openstack-nova | 11:30 | |
*** brinzhang_ has quit IRC | 11:34 | |
*** dviroel has joined #openstack-nova | 11:38 | |
*** brinzhang_ has joined #openstack-nova | 11:39 | |
*** brinzhang has quit IRC | 11:42 | |
*** tbachman has quit IRC | 11:47 | |
*** bhagyashris has quit IRC | 11:50 | |
*** brinzhang_ has quit IRC | 11:52 | |
*** brinzhang_ has joined #openstack-nova | 11:52 | |
*** brinzhang has joined #openstack-nova | 11:54 | |
*** zhanglong has joined #openstack-nova | 11:56 | |
*** brinzhang_ has quit IRC | 11:58 | |
*** bhagyashris has joined #openstack-nova | 12:02 | |
*** brinzhang has quit IRC | 12:06 | |
*** brinzhang has joined #openstack-nova | 12:07 | |
*** zzzeek has quit IRC | 12:16 | |
*** zzzeek has joined #openstack-nova | 12:17 | |
*** ociuhandu has quit IRC | 12:23 | |
*** udesale has quit IRC | 12:23 | |
*** abhishekk has quit IRC | 12:23 | |
*** abhishekk has joined #openstack-nova | 12:24 | |
*** ociuhandu has joined #openstack-nova | 12:31 | |
*** mlycka has joined #openstack-nova | 12:34 | |
*** brinzhang_ has joined #openstack-nova | 12:38 | |
*** brinzhang_ has quit IRC | 12:40 | |
*** brinzhang_ has joined #openstack-nova | 12:41 | |
brinzhang_ | Hi all, https://review.opendev.org/#/c/580271/ this patch I was resolved the functional test and python test, but there are some errors I donot know why. | 12:41 |
brinzhang_ | is there need some dependency packges? | 12:41 |
*** brinzhang has quit IRC | 12:42 | |
*** brinzhang_ has quit IRC | 12:42 | |
*** brinzhang_ has joined #openstack-nova | 12:43 | |
brinzhang_ | any professional python expert can give some guide? thanks ^^ | 12:43 |
lyarwood | brinzhang_: https://storyboard.openstack.org/#!/story/2007084 | 12:44 |
*** brinzhang_ has quit IRC | 12:44 | |
*** brinzhang has joined #openstack-nova | 12:45 | |
*** brinzhang has quit IRC | 12:46 | |
*** brinzhang has joined #openstack-nova | 12:47 | |
*** adriant has quit IRC | 12:48 | |
*** adriant has joined #openstack-nova | 12:49 | |
lyarwood | brinzhang: I'm not sure if you saw this, https://storyboard.openstack.org/#!/story/2007084 | http://lists.openstack.org/pipermail/openstack-discuss/2020-January/011956.html | 12:50 |
brinzhang | lyarwood: Oh no, see it by your send | 12:51 |
*** ociuhandu has quit IRC | 12:52 | |
*** tbachman has joined #openstack-nova | 13:16 | |
*** ociuhandu has joined #openstack-nova | 13:16 | |
*** ociuhandu has quit IRC | 13:16 | |
*** shilpasd has quit IRC | 13:16 | |
*** ociuhandu has joined #openstack-nova | 13:16 | |
*** brinzhang_ has joined #openstack-nova | 13:20 | |
*** brinzhang_ has quit IRC | 13:21 | |
*** brinzhang_ has joined #openstack-nova | 13:21 | |
*** zhanglong has quit IRC | 13:22 | |
*** tbachman has quit IRC | 13:22 | |
*** brinzhang_ has quit IRC | 13:22 | |
*** brinzhang_ has joined #openstack-nova | 13:23 | |
*** brinzhang has quit IRC | 13:23 | |
*** tbachman has joined #openstack-nova | 13:23 | |
*** brinzhang_ has quit IRC | 13:24 | |
*** brinzhang_ has joined #openstack-nova | 13:24 | |
*** nweinber__ has joined #openstack-nova | 13:24 | |
brinzhang_ | gibi: hi, I am not very clear what did you mean, can you give me more details about this https://review.opendev.org/#/c/699669/2/specs/ussuri/approved/action-event-fault-details.rst@128 | 13:25 |
brinzhang_ | gibi: thanks :) | 13:25 |
*** derekh has quit IRC | 13:30 | |
*** rpittau|bbl is now known as rpittau | 13:32 | |
*** ratailor_ has quit IRC | 13:35 | |
*** brinzhang has joined #openstack-nova | 13:37 | |
*** brinzhang_ has quit IRC | 13:40 | |
*** brinzhang_ has joined #openstack-nova | 13:42 | |
*** brinzhang has quit IRC | 13:45 | |
*** mriedem has joined #openstack-nova | 13:51 | |
*** rcernin has quit IRC | 13:53 | |
*** KeithMnemonic has joined #openstack-nova | 13:59 | |
*** brinzhang has joined #openstack-nova | 14:01 | |
*** brinzhang has quit IRC | 14:03 | |
*** brinzhang has joined #openstack-nova | 14:03 | |
*** brinzhang_ has quit IRC | 14:04 | |
efried | alex_xu: I don't fully have in my head all the combinations that would or would not make sense. | 14:05 |
efried | But somebody should | 14:05 |
efried | And then block the ones that don't make sense. | 14:05 |
efried | I don't know if cpu_policy=$anything makes sense in the mixed CPU case, because you're dedicating some and sharing some. | 14:05 |
efried | So perhaps those should be mutually exclusive. | 14:05 |
efried | but that ^ kind of decision just needs to be made, in a way that makes sense, for all the relevant options. | 14:06 |
efried | ...by someone who knows what makes sense, which ain't me :P | 14:06 |
*** derekh has joined #openstack-nova | 14:06 | |
efried | But tl;dr we're not going to freak out about combining placement-ese and other syntaxes, because dansmith beat me down. I'm now a husk of my former self. | 14:07 |
*** Luzi has quit IRC | 14:12 | |
*** brinzhang_ has joined #openstack-nova | 14:31 | |
*** brinzhang has quit IRC | 14:34 | |
*** pcaruana has joined #openstack-nova | 14:34 | |
*** brinzhang has joined #openstack-nova | 14:37 | |
*** amodi has quit IRC | 14:38 | |
*** brinzhang_ has quit IRC | 14:40 | |
gibi | brinzhang_: extended my comment in https://review.opendev.org/#/c/699669/2/specs/ussuri/approved/action-event-fault-details.rst@128 | 14:40 |
*** ociuhandu has quit IRC | 14:41 | |
sean-k-mooney | efried: we were going to use an expcitly cpu_policy=mixed for mixed cpus if you dont set that you cant use the feature | 14:45 |
efried | 'mixed' is a new value? | 14:46 |
sean-k-mooney | yes | 14:46 |
efried | And why do we need it? | 14:47 |
efried | Is cpu_policy a required field otherwise? | 14:47 |
sean-k-mooney | it how you enable pinning | 14:47 |
efried | I would expect we could infer 'mixed' based on the fact you specified both vcpu and pcpu | 14:47 |
sean-k-mooney | and it need to be set for realtime | 14:47 |
sean-k-mooney | and we do not want to use cpu_policy=dedicated with mixed cpus | 14:47 |
sean-k-mooney | all the pinning code check the cpu_policy values so if stephen enabeld pinning with resouces:PCPU he is implcitly setting that internally | 14:49 |
sean-k-mooney | i am 90% sure he did not remove all the check that were based on cpu_policy | 14:50 |
sean-k-mooney | ya we still use it https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1482-L1520 | 14:51 |
huaqiang | the internal logic need a cpu_policy, no matter it is specified by flavor/image or specified implicitly through resources:RC | 14:51 |
*** tbachman has quit IRC | 14:51 | |
*** bhagyashris has quit IRC | 14:51 | |
sean-k-mooney | this is where translation for the placement request https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L252-L298 | 14:53 |
sean-k-mooney | he would have to infer the cpu_policy before that | 14:54 |
huaqiang | sean-k-mooney: I ma not intent to object the new policy 'mixed', but if this new mixed policy is added, we have to find the CPU quantity information from resources:RC. The 'mixed' policy will not work if no CPU quantity information is found in resources:RC. This is not like the way that dedicated or shared policy works. | 14:57 |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/pike: Skip checking of target_dev for vhostuser https://review.opendev.org/702231 | 14:57 |
sean-k-mooney | huaqiang: well we have to find it form resouce:* or have a hw:* extra spec yes | 14:58 |
huaqiang | This is something weired if we comapring the requirements for creating 'mixed' instance and 'dedicated' or 'shared' instance. | 14:58 |
sean-k-mooney | i think it shoudl be a error to jsut set mixed on its own | 14:59 |
huaqiang | technically we can do as you said | 14:59 |
sean-k-mooney | well for realtime instance we have two thing that must be set. you must enabel it with a boolean and then provide a mask | 15:00 |
sean-k-mooney | we did that in the realtime case to allow the image to provide the mask | 15:00 |
huaqiang | this will a little different with the 'mixed' instance case | 15:01 |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/pike: Skip checking of target_dev for vhostuser https://review.opendev.org/702231 | 15:01 |
huaqiang | because we don't have a mask | 15:01 |
*** eharney has quit IRC | 15:02 | |
sean-k-mooney | well we either have a mask or you have to use the placement syntax unless we are goint to placement syntax only. if we do that then i think that is problematic as long as we support groups in the flavor | 15:02 |
huaqiang | efried said in his conclusion that if the plamenent-ness works, then the placement interface is the only interface I think, that is no mask for it | 15:05 |
efried | what does "realtime" mean? | 15:06 |
sean-k-mooney | we have the ablity to mark the gust cpus as executing with realtime priority | 15:06 |
huaqiang | sean-k-mooney: What kind of problem? Do we have spec for how to support placement groups in nova? | 15:06 |
efried | sean-k-mooney: so that's not the same thing as pinning? | 15:07 |
sean-k-mooney | and when you enable that feature you have to set a mask of which cpus are realtime and which are not | 15:07 |
sean-k-mooney | efried: its seperate but can only be enabled if you are using pinning | 15:07 |
efried | What I'm getting at is: I don't mind if we have to change some internal logic/data to represent "mixed", but for the UX it seems unnecessary, because we can infer it. | 15:07 |
sean-k-mooney | huaqiang: it has been supported for several release | 15:07 |
sean-k-mooney | efried: if we have it as an internal value i think we should allow it to be set | 15:08 |
efried | But you can't set mixed unless you mix, and if you mix, you can't set it to any other value. That doesn't seem like good UX to me. | 15:08 |
sean-k-mooney | efried: but also i really reallly want to make sure that this new bevaior is only enabeld if we do it intentionally | 15:08 |
sean-k-mooney | efried: so there is a discoverabliy aspect too | 15:09 |
efried | As a user, I don't want to say VCPU=$n,PCPU=$m only to have my build rejected with a message like "if you set both VCPU and PCPU, you must say cpu_policy=mixed as well" | 15:09 |
sean-k-mooney | if we dont set mixed as teh cpu_policy | 15:09 |
sean-k-mooney | i now need to prse the Resouces:* to figure out if this flavor is mixed pinnend or floating | 15:09 |
efried | be like, "No, you can't do mixed CPUs unless you also set this option that says you really mean it" | 15:09 |
*** ociuhandu has joined #openstack-nova | 15:10 | |
efried | sean-k-mooney: we're doing that anyway to make sure they're not f'ing up the combination. | 15:10 |
*** artom has joined #openstack-nova | 15:10 | |
sean-k-mooney | no i mean as an end user | 15:10 |
sean-k-mooney | who is tryign to fine a flavor to use | 15:10 |
efried | mmph, I don't buy that. | 15:10 |
sean-k-mooney | that havign to check both cpu policy and Resocues: is a pain? | 15:11 |
efried | If you really think your user can't handle realizing VCPU=$n,PCPU=$m means mixed, name the flavor "mixed_cpu_XXX" | 15:11 |
efried | I just don't like the redundancy. | 15:11 |
sean-k-mooney | efried: a human can programing it is just annoying but ok | 15:11 |
efried | I don't see why programming it is annoying. | 15:12 |
*** lpetrut has joined #openstack-nova | 15:12 | |
sean-k-mooney | because i now instead of looking at just the cpu policy i also need to look at resouces:* | 15:12 |
sean-k-mooney | when cpu_policy is not set | 15:13 |
efried | You have to look at it anyway | 15:13 |
sean-k-mooney | also if cpu_polciy is not set it allows the image to set any cpu_policy | 15:13 |
sean-k-mooney | you didnt before stephens change | 15:13 |
huaqiang | can we create an instance through PCPU and VCPU resources without naming it 'dedicated' or 'shared'. It is just an instance? | 15:13 |
sean-k-mooney | but yes technically you would have | 15:13 |
efried | sorry, are you telling me that every internal field maps to a user input?? | 15:14 |
sean-k-mooney | huaqiang: apparently yes however i have not found where in the code that works | 15:14 |
sean-k-mooney | efried: the cpu_polciy is not an internal field | 15:14 |
sean-k-mooney | if we consider resouces:* to be then users proably should not set them | 15:15 |
efried | It's probably just ignorance on my part. But it seems to me that if I say resources:PCPU, cpu_policy=pinned is implied and I shouldn't be *required* to say it. | 15:17 |
efried | Likewise if I say resources:PCPU+resources:VCPU, cpu_policy=mixed is implied and I shouldn't be required to say it. | 15:17 |
sean-k-mooney | efried: so in theory stephens PCPU in placment feature allows you to say that and make it so you don thave to set cpu_policy=dedicated | 15:17 |
sean-k-mooney | but as i argured in the spec review i think that is a regression in functionality as you have to ensure the PCPU vaule now matches the flavor.vcpus | 15:18 |
huaqiang | sean-k-mooney: in current code, each instance a policy, either 'dedicated' or 'shared', no matter you named it explicitly or implicitly. | 15:19 |
sean-k-mooney | actuuly it shared dedicated or unset | 15:19 |
efried | IMO we should bite the bullet and start allowing flavor.vcpus=0 | 15:19 |
sean-k-mooney | when its unset itst treated as shared but the image can set it | 15:19 |
*** tbachman has joined #openstack-nova | 15:20 | |
sean-k-mooney | efried: i disagree unless we remove all out resouce filed form the flavor or allow them all too be 0 | 15:20 |
sean-k-mooney | also doing that will break the world | 15:20 |
sean-k-mooney | there is plenty of logic built up around search on flavor by flavor.* | 15:20 |
efried | "bite the bullet" means it will be hard and breaking but will result in a better world. | 15:21 |
sean-k-mooney | im not sold on that | 15:21 |
sean-k-mooney | e.g. that its better but sure we could | 15:22 |
*** awalende_ has quit IRC | 15:22 | |
sean-k-mooney | we woudl effectivly be saying that the only filed that maters in the falvor is the unversion dict of string that is the extra specs | 15:22 |
efried | The alternative is making flavor.pcpus | 15:22 |
sean-k-mooney | no | 15:22 |
sean-k-mooney | flavor.vcpu has nothing to do with if its floating or pinned or mixed | 15:23 |
*** awalende has joined #openstack-nova | 15:23 | |
sean-k-mooney | it is the number of logical guest cpus | 15:23 |
efried | okay, I can buy that. | 15:23 |
efried | Then flavor.vcpus must equal resources:VCPUS+resources:PCPUS | 15:23 |
efried | which is confusing as shit IMO | 15:23 |
sean-k-mooney | as of train yes | 15:23 |
sean-k-mooney | before train no | 15:23 |
sean-k-mooney | actully even now no | 15:24 |
sean-k-mooney | if you use emulator thread polciy = isolate | 15:24 |
huaqiang | efried: for PCPU we have to consider emulator thread | 15:24 |
efried | then it's 2x or something? | 15:24 |
sean-k-mooney | it will be resources:VCPUS+resources:PCPUS+1 | 15:24 |
huaqiang | it might be isolate emulator thread | 15:24 |
efried | right | 15:24 |
efried | But my point is, | 15:24 |
efried | flavor.vcpus and resources:VCPU are not the same thing | 15:24 |
efried | which is confusing as shit. | 15:24 |
sean-k-mooney | corrrect | 15:24 |
sean-k-mooney | well we should not have used VCPUs as the resouce class name | 15:25 |
efried | Almost like we should make a resources:SCPUS or something | 15:25 |
efried | right | 15:25 |
sean-k-mooney | it should be SCPUs | 15:25 |
efried | Perhaps we should do that. | 15:25 |
efried | And just tell people not to use the r-t releases | 15:25 |
sean-k-mooney | yep i had this argument after we had already commited the VCPUs resouce class code in plament and no one wnated to change it | 15:26 |
* efried bbiab | 15:26 | |
*** awalende_ has joined #openstack-nova | 15:27 | |
*** jawad-axd has quit IRC | 15:27 | |
*** awalende has quit IRC | 15:27 | |
huaqiang | efried,sean-k-mooney: do we have conclusion on adding a new cpu policy 'mixed' or just don't naming it as policy if we don't provided a policy? | 15:28 |
huaqiang | for later case we just create an instance through PCPU&VCPU and we don't assign any policy to it internally | 15:30 |
sean-k-mooney | that will triger alot of the "shared" policy code paths and break realtime cpus | 15:30 |
*** awalende_ has quit IRC | 15:31 | |
sean-k-mooney | given realtime guest is one of the primary usecase it think that would be bad unless you also modify the logic so that we take into account the realtime mask | 15:31 |
sean-k-mooney | i mean we shoudl do that anyway but the more things we make implcit the more edgecase you will have to handel interanlly | 15:32 |
huaqiang | the logic for creating a mixed instance follows the code path of 'dedicated' policy mostly. | 15:36 |
sean-k-mooney | yes both most of the code check expcitly check for dedicated then assuem if that is not set that it is shared | 15:37 |
huaqiang | but we have to create a internal variable to represent of mixed instance, not a policy but works paraelly with policies. | 15:37 |
sean-k-mooney | so if you dont set a policy it will be treated as shared | 15:37 |
sean-k-mooney | i think that would be a mistake | 15:37 |
sean-k-mooney | this is a policy | 15:37 |
huaqiang | I also think that is a problem | 15:37 |
sean-k-mooney | having yet another thing to check would just make the code more complcatedd | 15:38 |
huaqiang | How about tell user, the 'dedicated' is extended with the concept that not all CPUs are pinning CPUs. | 15:39 |
huaqiang | this was denied byefore | 15:39 |
sean-k-mooney | noop | 15:39 |
sean-k-mooney | i really hate that idea | 15:40 |
huaqiang | for inconsistent behavior | 15:40 |
sean-k-mooney | yes it would have different meaning on different versions of openstack | 15:41 |
sean-k-mooney | we could add teh mixed policy and make it optional | 15:43 |
sean-k-mooney | so we have an internal value to use and the user can choose not to set it and just use the placmenet syntax | 15:43 |
sean-k-mooney | i would still always recomend setting it but if we can infer the mixed case the it woudl not be required | 15:44 |
sean-k-mooney | however that woudl allwo you to do something like flavor.vcpu=8 hw:cpu_policy=mixed resouces:vcpu:2 | 15:45 |
sean-k-mooney | and because we know its mixed we know the other 6 cpus must be pinned | 15:45 |
huaqiang | and the number of PCPU could be derived from the give information | 15:46 |
sean-k-mooney | you could also do flavor.vcpu=8 resouces:vcpu:2 resouces:PCPUS:6 | 15:46 |
sean-k-mooney | yep | 15:46 |
huaqiang | if emulator thread policy is isolate | 15:46 |
huaqiang | then another PCPU is requred | 15:46 |
sean-k-mooney | yep | 15:46 |
sean-k-mooney | but again we can derive that form the info availble | 15:47 |
*** dave-mccowan has joined #openstack-nova | 15:47 | |
*** derekh has quit IRC | 15:47 | |
huaqiang | yes | 15:47 |
huaqiang | works for me | 15:47 |
sean-k-mooney | knowing its a mixed cpu explictly makes it eairer to derive thing in my view | 15:47 |
sean-k-mooney | but makeing it optional as long as you tell us how much of each type you want keeps it clean | 15:48 |
sean-k-mooney | if that is what you prefer | 15:48 |
efried | Yeah, I really don't understand why it needs to be explicitly stated by the user. | 15:49 |
efried | "will trigger X code paths by default" <== we will be changing those code paths as part of this feature, right?? That's what code changes are for?? | 15:49 |
efried | Mixed means you have to take shared code paths in some places, dedicated in other places. | 15:50 |
efried | That's gonna happen internally regardless. | 15:50 |
sean-k-mooney | i think we only ever check for dedicated so i think you would always take the shared path | 15:50 |
sean-k-mooney | but yes it will be changed in anycase by this feature | 15:50 |
efried | I'm not refuting that we need "mixed" logic internally. | 15:51 |
sean-k-mooney | by the way im still looking for the code that allows resouce:PCPU=4 to actully give you a pinned guest | 15:51 |
efried | I'm saying, why require it to be stated by the user if it can be inferred 100% from the fact that they MIXED THEIR CPUs in the flavor? | 15:51 |
*** dave-mccowan has quit IRC | 15:52 | |
sean-k-mooney | well the field is an ovo filed and i dont like adding another seperate variable | 15:52 |
efried | an OVO field in what, the Flavor? | 15:52 |
sean-k-mooney | so if we extend the ovo filed defintion it will alther the api check implcitly to allow it | 15:52 |
sean-k-mooney | no in the image metadata | 15:52 |
sean-k-mooney | and in the numa objects | 15:52 |
efried | but it's not a required field. | 15:53 |
sean-k-mooney | yes it can be unset or set to shraed explcitly for floating instance or set to dedicated | 15:53 |
efried | Fine. | 15:53 |
efried | but don't require it. | 15:53 |
efried | I assume you can set it from either the flavor or the image? | 15:54 |
sean-k-mooney | the sematica are that if its not set in the flavor it means the image can requst pinning. so unset and set to shared are different | 15:54 |
*** derekh has joined #openstack-nova | 15:54 | |
efried | So we funnel those into the numa object | 15:54 |
sean-k-mooney | yes | 15:54 |
sean-k-mooney | and it becomes part of the numa constratin used in the numa toplogy filter and on the compute node | 15:55 |
efried | we logically evaluate cpu policy-ness from the flavor and the image to determine the value in the internal numa object | 15:55 |
efried | ? ^ | 15:55 |
sean-k-mooney | we store it as cpu_polciy in the instnace numa topology | 15:55 |
*** eharney has joined #openstack-nova | 15:56 | |
sean-k-mooney | by reading the flavor and image properties yes | 15:56 |
efried | cool, | 15:56 |
efried | so what I'm saying is, | 15:56 |
efried | if neither the flavor nor the image dictates a cpu_policy, and the flavor specifies both VCPUs and PCPUs, we set the value internally to mixed. | 15:56 |
efried | but we do not require the flavor or image to say 'mixed'. | 15:56 |
sean-k-mooney | yep | 15:56 |
sean-k-mooney | ya we coudl do that | 15:56 |
efried | because they already did, by specifying VCPU+PCPU | 15:56 |
efried | and, | 15:56 |
sean-k-mooney | but i think we should not block it either | 15:56 |
efried | if they say VCPU+PCPU and specify cpu_policy=$anything_other_than_mixed, we have to fail. | 15:56 |
sean-k-mooney | am yes i think we can do that | 15:57 |
sean-k-mooney | infact i think we should already be doint that in the api somewhere | 15:57 |
efried | so if we're going to do that, I don't see why we even need to bother exposing the *ability* for them to say cpu_policy=mixed in the flavor/image. | 15:57 |
efried | but I won't die on a hill for that. | 15:57 |
sean-k-mooney | it would be more work to not expose it | 15:57 |
efried | fine | 15:57 |
*** maciejjozefczyk has quit IRC | 15:58 | |
sean-k-mooney | efried: huaqiang are we really sure we supprot enabling cpu_pinning by using PCPUs | 15:59 |
sean-k-mooney | https://github.com/openstack/nova/blob/0012fdfdc387da97d1d396e5ebda152d7c10b091/nova/objects/instance_numa.py#L111-L112 | 15:59 |
sean-k-mooney | well i guess maybe if we have set that internally | 15:59 |
sean-k-mooney | i still need to find that code | 16:00 |
huaqiang | sean-k-mooney: in hardware.py I'll find it for yo | 16:03 |
huaqiang | https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1860 | 16:04 |
sean-k-mooney | thanks ok and https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1840-L1843 is where we block the mixed case | 16:06 |
sean-k-mooney | so the transformation happens in the api | 16:06 |
sean-k-mooney | numa_get_constraints is invoked form teh api to validate teh request and it si used when constuction teh numa toplogy object that is passed to the schduler | 16:07 |
*** ociuhandu has quit IRC | 16:07 | |
huaqiang | it will be permitted for mixed case | 16:07 |
sean-k-mooney | yes so basicaly at line 1840 you will replace that with a check that will set the polciy to mixed internally | 16:08 |
openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/nova master: Add ironic hypervisor doc https://review.opendev.org/701998 | 16:08 |
sean-k-mooney | then make the if on line 1845 an elif | 16:08 |
sean-k-mooney | so we only take it if its a non mixed case | 16:08 |
*** tbachman has quit IRC | 16:09 | |
*** pcaruana has quit IRC | 16:12 | |
huaqiang | https://review.opendev.org/#/c/696009/1/nova/virt/hardware.py | 16:13 |
huaqiang | this is my poc code for this part | 16:13 |
*** gyee has joined #openstack-nova | 16:15 | |
*** macz has joined #openstack-nova | 16:16 | |
*** iurygregory has quit IRC | 16:17 | |
huaqiang | sean-k-mooney, efried: It is too late for me, I'll go to sleep, and I caught the current idea is using an interal policy 'mixed' in code path, but without exposing it to end user for using in flavor or image properties. | 16:21 |
*** ociuhandu has joined #openstack-nova | 16:26 | |
sean-k-mooney | huaqiang: good night o/ | 16:27 |
efried | huaqiang: to be clear, I'm saying don't *require* it from the end user. I would prefer not to expose it, but if doing so (as optional) makes something significantly easier, I won't object to it. | 16:31 |
*** gentoorax has quit IRC | 16:32 | |
*** gentoorax has joined #openstack-nova | 16:32 | |
*** TxGirlGeek has joined #openstack-nova | 16:33 | |
*** tbachman has joined #openstack-nova | 16:42 | |
*** nweinber__ has quit IRC | 16:42 | |
*** derekh has quit IRC | 16:49 | |
*** jmlowe has quit IRC | 16:51 | |
*** jmlowe has joined #openstack-nova | 16:53 | |
*** mlavalle has joined #openstack-nova | 16:54 | |
*** icarusfactor has quit IRC | 16:55 | |
*** rpittau is now known as rpittau|afk | 17:02 | |
*** damien_r has quit IRC | 17:03 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove extra instance.save() calls related to qos SRIOV ports https://review.opendev.org/702261 | 17:06 |
*** Sundar has joined #openstack-nova | 17:11 | |
*** pcaruana has joined #openstack-nova | 17:13 | |
*** mlycka has quit IRC | 17:18 | |
*** nicolasbock has joined #openstack-nova | 17:21 | |
*** maciejjozefczyk has joined #openstack-nova | 17:31 | |
*** jawad-axd has joined #openstack-nova | 17:33 | |
*** evrardjp has quit IRC | 17:33 | |
*** eharney has quit IRC | 17:34 | |
*** evrardjp has joined #openstack-nova | 17:34 | |
*** maciejjozefczyk has quit IRC | 17:41 | |
*** eharney has joined #openstack-nova | 17:41 | |
*** martinkennelly has quit IRC | 17:49 | |
*** TxGirlGeek has quit IRC | 17:52 | |
*** dtantsur is now known as dtantsur|afk | 17:53 | |
*** lpetrut has quit IRC | 17:54 | |
*** ociuhandu_ has joined #openstack-nova | 17:55 | |
*** TxGirlGeek has joined #openstack-nova | 17:56 | |
*** derekh has joined #openstack-nova | 17:58 | |
*** ociuhandu has quit IRC | 17:58 | |
*** ociuhandu_ has quit IRC | 17:59 | |
*** tbachman has quit IRC | 18:00 | |
artom | I can never remember this, what's the order of assertEqual(expected, actual)? | 18:02 |
*** jawad-axd has quit IRC | 18:04 | |
dansmith | expected,actual | 18:12 |
*** bnemec has quit IRC | 18:14 | |
*** lpetrut has joined #openstack-nova | 18:17 | |
mriedem | fyi https://github.com/testing-cabal/testtools/blob/master/testtools/testcase.py | 18:17 |
* artom eyes mriedem suspiciously... | 18:18 | |
*** bnemec has joined #openstack-nova | 18:18 | |
*** TxGirlGeek has quit IRC | 18:18 | |
mriedem | just your friendly neighborhood lurker | 18:19 |
artom | Are we... are we like crack to you? | 18:20 |
mriedem | just eating lunch | 18:21 |
mriedem | my artom sense went off | 18:21 |
artom | Aww, you have a sense for me | 18:21 |
*** TxGirlGeek has joined #openstack-nova | 18:25 | |
*** lpetrut has quit IRC | 18:28 | |
*** tbachman has joined #openstack-nova | 18:32 | |
*** jawad-axd has joined #openstack-nova | 18:45 | |
*** tesseract has quit IRC | 18:53 | |
*** jawad-axd has quit IRC | 19:00 | |
efried | someone should | 19:01 |
efried | <tsssss> | 19:01 |
*** Sundar has quit IRC | 19:19 | |
*** awalende has joined #openstack-nova | 19:23 | |
*** awalende has quit IRC | 19:28 | |
*** ociuhandu has joined #openstack-nova | 19:45 | |
*** ociuhandu has quit IRC | 19:50 | |
*** eharney has quit IRC | 20:03 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | 20:15 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404 | 20:15 |
openstack | bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms) | 20:15 |
artom | *finally* | 20:15 |
sean-k-mooney | oh its stacked ... | 20:19 |
*** ralonsoh has quit IRC | 20:34 | |
efried | dustinc: You have a couple of notes in https://review.opendev.org/#/c/676522/ about needing more UT coverage. Is that still true? | 20:35 |
efried | (I haven't dug in yet to verify) | 20:35 |
openstackgerrit | Dan Smith proposed openstack/nova master: Add NovaEphemeralObject class for non-persistent objects https://review.opendev.org/702049 | 20:41 |
*** artom has quit IRC | 20:51 | |
openstackgerrit | Merged openstack/nova-specs master: Update provider config spec for identification conflicts https://review.opendev.org/693414 | 20:55 |
*** eharney has joined #openstack-nova | 20:57 | |
*** bbowen has quit IRC | 20:57 | |
*** eharney has quit IRC | 21:01 | |
dustinc | efried: I thought it was good and I just forgot to remove the note, but I checked again just to be sure and actually found another scenario I want to write a test for.. | 21:10 |
efried | dustinc: I just finished reviewing the code side and found some things that need to be fixed anyway. | 21:10 |
dustinc | I have to step away for a few minutes, but I will check it out in a few. Thanks! | 21:11 |
efried | no hurry | 21:13 |
*** derekh has quit IRC | 21:30 | |
*** mriedem has left #openstack-nova | 21:44 | |
*** ociuhandu has joined #openstack-nova | 21:55 | |
*** ociuhandu has quit IRC | 22:00 | |
*** vesper has joined #openstack-nova | 22:00 | |
*** vesper11 has quit IRC | 22:01 | |
*** slaweq has quit IRC | 22:12 | |
*** xek has quit IRC | 22:24 | |
*** brinzhang_ has joined #openstack-nova | 22:35 | |
*** brinzhang has quit IRC | 22:39 | |
*** tkajinam has joined #openstack-nova | 22:49 | |
*** rcernin has joined #openstack-nova | 22:57 | |
*** tosky has quit IRC | 23:06 | |
*** awalende has joined #openstack-nova | 23:19 | |
*** awalende has quit IRC | 23:23 | |
*** Liang__ has joined #openstack-nova | 23:25 | |
*** TxGirlGeek has quit IRC | 23:27 | |
*** ociuhandu has joined #openstack-nova | 23:30 | |
*** TxGirlGeek has joined #openstack-nova | 23:31 | |
*** ociuhandu has quit IRC | 23:35 | |
*** mlavalle has quit IRC | 23:49 | |
*** Liang__ has quit IRC | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!