*** macz has quit IRC | 00:32 | |
*** TxGirlGeek has quit IRC | 00:33 | |
*** zhanglong has joined #openstack-nova | 00:49 | |
*** Liang__ has joined #openstack-nova | 01:13 | |
*** Sundar has quit IRC | 01:13 | |
*** Liang__ is now known as LiangFang | 01:14 | |
*** mlavalle has quit IRC | 01:21 | |
*** gentoorax has quit IRC | 01:30 | |
*** gentoorax has joined #openstack-nova | 01:30 | |
brinzhang | Sunda: just use "reno new < some-short-name-of-thing>" under the project also can create the releasenote file, that depend-on reno packages, so you should installed in your env. | 01:34 |
---|---|---|
brinzhang | Sundar | 01:35 |
*** adriant has quit IRC | 01:36 | |
brinzhang | Sundar: creating releasenote guide:https://docs.openstack.org/reno/latest/user/usage.html#creating-new-release-notes | 01:41 |
*** adriant has joined #openstack-nova | 01:48 | |
*** TxGirlGeek has joined #openstack-nova | 01:52 | |
openstackgerrit | Merged openstack/nova master: Print help if nova-manage subcommand is not specified https://review.opendev.org/694806 | 01:55 |
openstackgerrit | Merged openstack/nova master: nova-net: Copy shared utils from nova-net module https://review.opendev.org/696515 | 01:55 |
openstackgerrit | Merged openstack/nova master: nova-net: Remove final references to nova-network https://review.opendev.org/696516 | 01:55 |
openstackgerrit | Merged openstack/nova master: nova-net: Remove 'MetadataManager' https://review.opendev.org/696748 | 01:55 |
*** hongbin has joined #openstack-nova | 02:02 | |
*** hongbin has quit IRC | 02:02 | |
*** hongbin has joined #openstack-nova | 02:03 | |
*** hongbin has quit IRC | 02:03 | |
*** hongbin has joined #openstack-nova | 02:04 | |
*** hongbin has quit IRC | 02:04 | |
*** hongbin has joined #openstack-nova | 02:06 | |
openstackgerrit | Merged openstack/nova master: nova-net: Add TODOs to remove security group-related objects https://review.opendev.org/696517 | 02:12 |
openstackgerrit | Merged openstack/nova master: nova-net: Remove dependency on nova-net from fake cache https://review.opendev.org/696749 | 02:12 |
openstackgerrit | Merged openstack/nova master: nova-net: Kill it https://review.opendev.org/696518 | 02:12 |
*** hamzy_ has joined #openstack-nova | 02:15 | |
openstackgerrit | Merged openstack/nova stable/pike: Skip checking of target_dev for vhostuser https://review.opendev.org/702231 | 02:19 |
openstackgerrit | Merged openstack/nova stable/pike: cleanup evacuated instances not on hypervisor https://review.opendev.org/687912 | 02:25 |
*** macz has joined #openstack-nova | 02:30 | |
*** macz has quit IRC | 02:35 | |
*** awalende has joined #openstack-nova | 02:38 | |
*** awalende has quit IRC | 02:43 | |
*** TxGirlGeek has quit IRC | 03:06 | |
*** factor has quit IRC | 03:27 | |
*** dave-mccowan has quit IRC | 03:29 | |
openstackgerrit | Merged openstack/nova stable/pike: Move restart_compute_service to a common place https://review.opendev.org/699488 | 03:30 |
openstackgerrit | Merged openstack/nova stable/pike: Add functional test for resize crash compute restart revert https://review.opendev.org/687913 | 03:30 |
openstackgerrit | Merged openstack/nova stable/pike: Prevent init_host test to interfere with other tests https://review.opendev.org/687916 | 03:30 |
openstackgerrit | Merged openstack/nova stable/pike: Functional reproduce for bug 1833581 https://review.opendev.org/687917 | 03:30 |
openstack | bug 1833581 in OpenStack Compute (nova) train "instance stuck in BUILD state if nova-compute is restarted" [Low,Fix committed] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer) | 03:30 |
*** rmk has quit IRC | 03:32 | |
*** rmk has joined #openstack-nova | 03:35 | |
*** tkajinam has quit IRC | 03:48 | |
*** gyee has quit IRC | 03:56 | |
*** hongbin_ has joined #openstack-nova | 04:12 | |
*** hongbin has quit IRC | 04:15 | |
*** tkajinam has joined #openstack-nova | 04:28 | |
*** macz has joined #openstack-nova | 04:30 | |
openstackgerrit | Merged openstack/nova master: pre-commit: Use Python 3 to run checks https://review.opendev.org/702453 | 04:34 |
*** macz has quit IRC | 04:34 | |
*** hongbin_ has quit IRC | 04:37 | |
*** sapd1_x has joined #openstack-nova | 04:40 | |
*** evrardjp has quit IRC | 05:34 | |
*** evrardjp has joined #openstack-nova | 05:34 | |
*** sapd1_x has quit IRC | 05:44 | |
*** davee___ has joined #openstack-nova | 06:04 | |
*** HagunKim has joined #openstack-nova | 06:05 | |
*** davee_ has quit IRC | 06:06 | |
*** mugsie has quit IRC | 06:11 | |
*** mugsie has joined #openstack-nova | 06:14 | |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | 06:25 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522 | 06:25 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460 | 06:25 |
*** iurygregory has quit IRC | 07:13 | |
*** KeithMnemonic1 has joined #openstack-nova | 07:15 | |
*** davee__ has quit IRC | 07:16 | |
*** davee_ has joined #openstack-nova | 07:16 | |
*** KeithMnemonic has quit IRC | 07:19 | |
*** ralonsoh has joined #openstack-nova | 07:27 | |
*** belmoreira has joined #openstack-nova | 07:57 | |
*** tesseract has joined #openstack-nova | 07:58 | |
*** tesseract has quit IRC | 07:58 | |
*** tesseract has joined #openstack-nova | 07:59 | |
*** awalende has joined #openstack-nova | 08:04 | |
*** maciejjozefczyk has joined #openstack-nova | 08:06 | |
*** slaweq has joined #openstack-nova | 08:09 | |
*** Luzi has joined #openstack-nova | 08:14 | |
*** tosky has joined #openstack-nova | 08:19 | |
*** arxcruz|off is now known as arxcruz | 08:20 | |
*** iurygregory has joined #openstack-nova | 08:21 | |
*** rpittau|afk is now known as rpittau | 08:22 | |
*** dpawlik has joined #openstack-nova | 08:25 | |
*** damien_r has joined #openstack-nova | 08:48 | |
*** tkajinam has quit IRC | 08:48 | |
*** jcosmao has joined #openstack-nova | 09:10 | |
openstackgerrit | Arnaud Morin proposed openstack/nova master: Force refresh of instance info cache on event https://review.opendev.org/702394 | 09:14 |
*** ccamacho has joined #openstack-nova | 09:15 | |
openstackgerrit | Riccardo Pittau proposed openstack/nova master: Fix typos for update_available_resource reference https://review.opendev.org/702602 | 09:22 |
*** martinkennelly has joined #openstack-nova | 09:23 | |
*** xek has joined #openstack-nova | 09:25 | |
*** zhanglong has quit IRC | 09:36 | |
*** derekh has joined #openstack-nova | 09:36 | |
*** tonyb has joined #openstack-nova | 09:38 | |
*** pcaruana has joined #openstack-nova | 09:42 | |
*** iurygregory is now known as iury_mtg | 09:50 | |
*** LiangFang has quit IRC | 09:58 | |
openstackgerrit | waleed mousa proposed openstack/os-vif master: [Follow Up] OVS DPDK port representors support https://review.opendev.org/665965 | 10:00 |
*** jaosorior has joined #openstack-nova | 10:12 | |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Print help if nova-manage subcommand is not specified https://review.opendev.org/702637 | 10:29 |
brinzhang | efried, alex_xu: https://review.opendev.org/#/c/699669/ this spec was +2 by gibi, and sean-k-mooney +1, could you please review this, determinate if it does to go. | 10:29 |
brinzhang | stephenfin: could you please review this bug fix https://review.opendev.org/#/c/580271/, it is ready. | 10:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add unified '_build_server' helper function https://review.opendev.org/697537 | 10:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add unified '_(build|create)_flavor' helper functions https://review.opendev.org/697538 | 10:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add '_delete_server' to 'InstanceHelperMixin' https://review.opendev.org/697539 | 10:31 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: functional: Add '_create_server' helper https://review.opendev.org/697540 | 10:31 |
*** dtantsur|afk is now known as dtantsur | 10:32 | |
stephenfin | brinzhang: sure | 10:32 |
brinzhang | stephenfin: cool, thanks ^^ | 10:32 |
luyao | stephenfin: Do you have time look at spec 'support live migration with vpmem' today? https://review.opendev.org/#/c/695863' | 10:44 |
stephenfin | yup, will do (y) | 10:44 |
luyao | stephenfin: thanks. :D | 10:44 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unused exceptions https://review.opendev.org/697149 | 10:54 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unnecessary 'neutronv2' prefixes https://review.opendev.org/696776 | 10:54 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove layer of indirection in 'nova.network' https://review.opendev.org/696745 | 10:54 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Make the security group API a module https://review.opendev.org/696746 | 10:54 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove remaining nova-network quotas https://review.opendev.org/697152 | 10:54 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'FloatingIP' object https://review.opendev.org/697153 | 10:54 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'Network' object https://review.opendev.org/697154 | 10:54 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'SecurityGroup' object https://review.opendev.org/697155 | 10:54 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove now unnecessary nova-net workaround https://review.opendev.org/702440 | 10:55 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova.image.api' module https://review.opendev.org/702451 | 10:55 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: nova-net: Remove unused nova-network objects https://review.opendev.org/697156 | 10:55 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove layer of indirection in 'nova.network' https://review.opendev.org/696745 | 10:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Make the security group API a module https://review.opendev.org/696746 | 10:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove remaining nova-network quotas https://review.opendev.org/697152 | 10:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'FloatingIP' object https://review.opendev.org/697153 | 10:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'Network' object https://review.opendev.org/697154 | 10:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'SecurityGroup' object https://review.opendev.org/697155 | 10:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove now unnecessary nova-net workaround https://review.opendev.org/702440 | 10:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova.image.api' module https://review.opendev.org/702451 | 10:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: nova-net: Remove unused nova-network objects https://review.opendev.org/697156 | 10:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova.image.api' module https://review.opendev.org/702451 | 11:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: nova-net: Remove unused nova-network objects https://review.opendev.org/697156 | 11:08 |
stephenfin | gibi: Could you have a look at https://review.opendev.org/#/c/695733/, when you have a chance? | 11:09 |
*** melwitt has quit IRC | 11:09 | |
*** pcaruana has quit IRC | 11:12 | |
brinzhang | stephenfin: about https://review.opendev.org/#/c/580271/6/nova/compute/api.py@5258 what do you mean, add "aggregate.updated_at = timeutils.utcnow()" to that api? https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/aggregates.py#L179 | 11:24 |
brinzhang | stephenfin: under line179 | 11:25 |
stephenfin | brinzhang: No, I'm referring to the 'Aggregate.remove_host' method in 'nova.objects.aggregate' | 11:25 |
stephenfin | brinzhang: So in here https://github.com/openstack/nova/blob/master/nova/objects/aggregate.py#L394-L401 | 11:26 |
gibi | stephenfin: ack, added to my queue | 11:26 |
stephenfin | ta | 11:26 |
kashyap | Potentially stupid question, what's invalid about this syntax here: https://paste.centos.org/view/5d8c9d97 | 11:27 |
stephenfin | kashyap: it's only invalid on Python 2 | 11:28 |
stephenfin | you need to use python3 now | 11:28 |
stephenfin | kashyap: Look at https://github.com/openstack/nova/blob/master/nova/compute/utils.py#L1374-L1375 then look at https://www.python.org/dev/peps/pep-3102/ | 11:30 |
kashyap | stephenfin: Ah, darn, when I modified my single test-run I forgot to pass py36 | 11:31 |
kashyap | Thanks for the references :-) | 11:31 |
stephenfin | np | 11:31 |
brinzhang | stephenfin: I will check, thanks | 11:32 |
*** tbachman has quit IRC | 11:39 | |
*** shilpasd has joined #openstack-nova | 11:43 | |
*** jaosorior has quit IRC | 11:46 | |
*** dave-mccowan has joined #openstack-nova | 11:48 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default Virtio RNG device to guests https://review.opendev.org/616603 | 11:54 |
*** mgoddard has quit IRC | 11:55 | |
*** dviroel has joined #openstack-nova | 11:58 | |
*** iury_mtg has quit IRC | 12:00 | |
*** mgoddard has joined #openstack-nova | 12:01 | |
*** iurygregory has joined #openstack-nova | 12:01 | |
*** mgoddard has quit IRC | 12:05 | |
openstackgerrit | Merged openstack/os-traits master: Add COMPUTE_RESCUE_BFV trait https://review.opendev.org/694033 | 12:07 |
*** mgoddard has joined #openstack-nova | 12:15 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Populate 'updated_at' when aggregate is updated https://review.opendev.org/580271 | 12:24 |
*** ociuhandu has joined #openstack-nova | 12:26 | |
brinzhang | stephenfin: I removed the duplicate handle in compute api. In the object.aggregate was done it, updated. | 12:26 |
*** damien_r has quit IRC | 12:27 | |
*** HagunKim has quit IRC | 12:35 | |
*** rchurch has quit IRC | 12:44 | |
*** udesale has joined #openstack-nova | 12:45 | |
*** rchurch has joined #openstack-nova | 12:46 | |
*** pcaruana has joined #openstack-nova | 12:49 | |
*** cgoncalves has quit IRC | 12:58 | |
*** ociuhandu has quit IRC | 12:59 | |
*** cgoncalves has joined #openstack-nova | 13:00 | |
*** mriedem has joined #openstack-nova | 13:00 | |
*** cgoncalves has quit IRC | 13:04 | |
*** cgoncalves has joined #openstack-nova | 13:10 | |
*** damien_r has joined #openstack-nova | 13:10 | |
*** eharney has quit IRC | 13:20 | |
*** dpawlik has quit IRC | 13:23 | |
*** ociuhandu has joined #openstack-nova | 13:27 | |
*** bhagyashris has joined #openstack-nova | 13:31 | |
*** dave-mccowan has quit IRC | 13:33 | |
*** dave-mccowan has joined #openstack-nova | 13:36 | |
*** jmlowe has joined #openstack-nova | 13:38 | |
*** jmlowe has quit IRC | 13:39 | |
*** nweinber__ has joined #openstack-nova | 13:39 | |
*** liuyulong has joined #openstack-nova | 13:41 | |
*** Liang__ has joined #openstack-nova | 13:45 | |
*** mnaser has quit IRC | 13:54 | |
*** mnaser has joined #openstack-nova | 13:55 | |
*** Liang__ is now known as LiangFang | 14:01 | |
*** eharney has joined #openstack-nova | 14:01 | |
*** Sundar has joined #openstack-nova | 14:03 | |
kashyap | sean-k-mooney: Hey, finally got around to this RNG thing, mind having a gander when you can - https://review.opendev.org/#/c/616603/ | 14:03 |
*** rcernin has quit IRC | 14:04 | |
*** bhagyashris has quit IRC | 14:06 | |
*** yan0s has joined #openstack-nova | 14:10 | |
Sundar | dansmith, efried: I am here if there are any questions on https://review.opendev.org/#/c/631244/ or related stuff. | 14:16 |
*** jungleboyj has quit IRC | 14:20 | |
*** jungleboyj has joined #openstack-nova | 14:21 | |
dansmith | Sundar: I just got up, so I haven't seen, but I'm assuming you pushed a new rev? | 14:37 |
Sundar | I published comments, will push patches after you agree. | 14:38 |
Sundar | dansmith: Thanks, no rush | 14:40 |
Sundar | brinzhang: Thanks for the release notes pointers | 14:40 |
*** bhagyashris has joined #openstack-nova | 14:40 | |
stephenfin | kashyap: I hit that | 14:41 |
* kashyap goes to check | 14:41 | |
kashyap | stephenfin: Thank you | 14:41 |
*** artom has joined #openstack-nova | 14:42 | |
kashyap | Okay, read your remarks, will respond there. | 14:43 |
*** dpawlik has joined #openstack-nova | 14:45 | |
sean-k-mooney | kashyap: sure ill take a look | 14:47 |
kashyap | Thanks | 14:48 |
sean-k-mooney | Sundar: when you push the new version be sure to rebase all the patches in the chain against master | 14:48 |
Sundar | Yes, already done internally | 14:49 |
sean-k-mooney | Sundar: i deployed https://review.opendev.org/#/c/699554/2 yesterday but it does not work because it is missing depencies | 14:49 |
Sundar | sean-k-mooney: I think you mean the root_required patch, which has been merged now? | 14:51 |
sean-k-mooney | yes | 14:51 |
sean-k-mooney | on the cyborg side i notice the device v2 api has merged on monday/tuseday | 14:52 |
sean-k-mooney | are the arq v2 https://review.opendev.org/#/c/696089/ and deployable v2 https://review.opendev.org/#/c/698190/ changes required for this work? | 14:52 |
sean-k-mooney | i deployed with cyborg master which had the device v2 changes when i was testing | 14:54 |
Sundar | sean-k-mooney: Yes, I am updating the patch sets with these dependencies | 14:54 |
Sundar | sean-k-mooney: Yes, device v2 API merged, but that should be tangential to Nova. The main thing that Nova patches needs is https://review.opendev.org/698846 | 14:55 |
Sundar | *need | 14:55 |
*** awalende_ has joined #openstack-nova | 14:57 | |
*** macz has joined #openstack-nova | 14:57 | |
sean-k-mooney | ok well i was trying to use the cyborg placemtn client so haveing the api to validate the existing of the fake device and compare with placment was useful | 14:58 |
Sundar | sean-k-mooney: You don;t need https://review.opendev.org/#/c/698190/. Looking at the other one | 14:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove layer of indirection in 'nova.network' https://review.opendev.org/696745 | 14:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Make the security group API a module https://review.opendev.org/696746 | 14:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove remaining nova-network quotas https://review.opendev.org/697152 | 14:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'FloatingIP' object https://review.opendev.org/697153 | 14:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'Network' object https://review.opendev.org/697154 | 14:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'SecurityGroup' object https://review.opendev.org/697155 | 14:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove now unnecessary nova-net workaround https://review.opendev.org/702440 | 14:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova.image.api' module https://review.opendev.org/702451 | 14:58 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: nova-net: Remove unused nova-network objects https://review.opendev.org/697156 | 14:58 |
Sundar | Sure, that has been there since Train release | 14:58 |
sean-k-mooney | well the device api has but the support in the client only seams to work with v2 | 15:00 |
sean-k-mooney | Sundar: by the way this is what i found http://paste.openstack.org/show/788372/ | 15:00 |
Sundar | sean-k-mooney: You don't need https://review.opendev.org/#/c/696089/ either | 15:00 |
sean-k-mooney | Sundar: cool i did not have either applied so ill only use the first one you linked | 15:00 |
*** awalende has quit IRC | 15:00 | |
sean-k-mooney | https://review.opendev.org/#/c/698846/ | 15:01 |
*** awalende_ has quit IRC | 15:01 | |
*** ociuhandu has quit IRC | 15:01 | |
dansmith | Sundar: replying to those comments is a lot harder 1-2 weeks after I make them, vs sooner | 15:02 |
Sundar | dansmith: Got it, I had to fix the Cyborg side event nptification patch and its dependencies before I got to this | 15:02 |
dansmith | Sundar: I'm trying to make an effort to drop whatever I'm doing to review those patches as soon as you put them up to keep things moving, so it'd be helpful if you could at least reply to them quicker, even if the code isn't coming immediately | 15:02 |
dansmith | I think I've replied to all the ones you're expecting to hear about, but if I missed one let me know | 15:03 |
*** bhagyashris has quit IRC | 15:03 | |
*** Luzi has quit IRC | 15:04 | |
Sundar | dansmith: OK, but without trying the code changes, the best I could say is 'will consider/try it out'. Presumably you want a firmer reply than that. | 15:04 |
Sundar | dansmith: Thanks, looking now | 15:04 |
dansmith | Sundar: well, some of the comments were not needing code changes. anyway, just saying, faster responses would be nice | 15:05 |
Sundar | sena-k-mooney: Not sure if 'openstack accelerator device profile' is ready for prime time yet. But here it seems to be fine. Do you have the cyborg API logs? | 15:05 |
Sundar | sean-k-mooney: ^ | 15:05 |
sean-k-mooney | am i still have it deploy it seamed to create the profile fine as the list shows | 15:10 |
sean-k-mooney | its a littel weird to just dump the raw json on the command line | 15:11 |
sean-k-mooney | when defining the groups | 15:11 |
sean-k-mooney | as far as i can tell the issue was the root_required patch not being present on the branch i tested | 15:12 |
sean-k-mooney | Sundar: next time i try goign though the work flow of deploying a vm ill see if i can capture the api logs too | 15:14 |
gibi | stephenfin, efried: the qos live migration patches are ready for review, if you have some time https://review.opendev.org/#/q/status:open++topic:bp/support-move-ops-with-qos-ports-ussuri | 15:14 |
Sundar | sean-k-mooney: Thanks | 15:16 |
Sundar | dansmith: Re. https://review.opendev.org/#/c/631244/53/nova/tests/unit/compute/test_compute_mgr.py@6098 , I stepped through the code and noticed that the return value was a dict, not a list. In fact, the first dict from the list. | 15:18 |
Sundar | dansmith: Your concerns about clarity are probably addressed by having mock_get_arqs.assert_has_calls() and clarifying the comments, right? | 15:19 |
dansmith | Sundar: then I think something else is going on: https://pastebin.com/7Rr1CVfd | 15:19 |
dansmith | Sundar: side_effect is the one that behaves the way you're describing (as you know): https://pastebin.com/PHiKTtew | 15:21 |
Sundar | dansmith: let me take another look and get back | 15:22 |
dansmith | thanks | 15:22 |
*** awalende has joined #openstack-nova | 15:24 | |
*** ociuhandu has joined #openstack-nova | 15:28 | |
*** awalende has quit IRC | 15:28 | |
*** dpawlik has quit IRC | 15:33 | |
*** shilpasd has quit IRC | 15:33 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.opendev.org/552924 | 15:39 |
bauzas | huzzah ^ | 15:39 |
* bauzas is eventually back upstream | 15:39 | |
*** ociuhandu has quit IRC | 15:39 | |
*** ociuhandu has joined #openstack-nova | 15:40 | |
sean-k-mooney | well it nice that you rejoin us with such a simple and non contorviral proposal :P | 15:42 |
*** LiangFang has quit IRC | 15:46 | |
*** eharney has quit IRC | 15:48 | |
artom | Controviral? | 15:49 |
artom | I kinda like that. Becomes viral because it's so controversial | 15:50 |
sean-k-mooney | hehe | 15:50 |
sean-k-mooney | you figured it out so its close enough | 15:50 |
sean-k-mooney | but yes i think the decieion we have been making related to mixed cpus makes modeing numa in plamcent more controversial | 15:51 |
stephenfin | gibi: Done (the QoS live migration series) | 15:52 |
gibi | stephenfin: thanks a lot! | 15:52 |
*** eharney has joined #openstack-nova | 15:52 | |
*** mlavalle has joined #openstack-nova | 15:52 | |
sean-k-mooney | i was less concerned when we used the hw:* syntax but if we go with the placementese syntax then i have deep concerns with granuarl request groups and the group_policy as they exist today | 15:52 |
*** udesale_ has joined #openstack-nova | 15:54 | |
Sundar | dansmith: Please see http://paste.openstack.org/show/788413/. The main change I made is http://paste.openstack.org/show/788415/. The first call to get_arqs_for_instance is mocked properly, but the second call hits a StopIteration error. | 15:55 |
*** bhagyashris has joined #openstack-nova | 15:55 | |
*** efried is now known as efried_afk | 15:56 | |
* efried_afk doc appt | 15:56 | |
dansmith | Sundar: no, return_value will work as many times as you want: https://pastebin.com/2Wdgb64J | 15:57 |
*** udesale has quit IRC | 15:57 | |
sean-k-mooney | if you want to have a limited number of retruns or different retrun i think you use sideffect with an iterable | 15:58 |
Sundar | Ah, my bad, I still have it as side_effect. Will fix that | 15:58 |
dansmith | ... | 15:58 |
*** melwitt has joined #openstack-nova | 16:01 | |
Sundar | I think it should work with these changes. This was the only pending point, AFAICS. Are you good with updating the patch set once this is resolved? | 16:01 |
Sundar | dansmith: ^ | 16:01 |
dansmith | Sundar: unless you've replied to other comments I had, I think so | 16:01 |
Sundar | I pretty much agreed to other changes, even if it is a matter of preference. | 16:02 |
*** gyee has joined #openstack-nova | 16:03 | |
aarents | lyarwood: I replied to your remark https://review.opendev.org/#/c/696084 maybe kashyap can confirm that implemeting finish_unshelved as you suggest is the way to go | 16:03 |
*** mrch_ has joined #openstack-nova | 16:08 | |
*** mrch_ has quit IRC | 16:08 | |
*** mrch_ has joined #openstack-nova | 16:08 | |
*** damien_r has quit IRC | 16:10 | |
*** damien_r has joined #openstack-nova | 16:11 | |
*** TxGirlGeek has joined #openstack-nova | 16:14 | |
openstackgerrit | Sundar Nadathur proposed openstack/os-traits master: Add a trait that compute manager can handle accelerator requests. https://review.opendev.org/698961 | 16:23 |
*** damien_r has quit IRC | 16:26 | |
*** bhagyashris has quit IRC | 16:37 | |
*** ociuhandu has quit IRC | 16:39 | |
*** ociuhandu has joined #openstack-nova | 16:39 | |
*** Sundar has quit IRC | 16:40 | |
*** openstackgerrit has quit IRC | 16:43 | |
*** openstackgerrit has joined #openstack-nova | 16:43 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: DNM: try to trace bug 1859766 https://review.opendev.org/702700 | 16:43 |
openstack | bug 1859766 in OpenStack Compute (nova) stein "functional tests intermittently fails with "ReadOnlyFieldError: Cannot modify readonly field uuid"" [Undecided,New] https://launchpad.net/bugs/1859766 - Assigned to Balazs Gibizer (balazs-gibizer) | 16:43 |
*** pcaruana has quit IRC | 16:45 | |
*** udesale_ has quit IRC | 16:45 | |
*** bhagyashris has joined #openstack-nova | 16:46 | |
*** Sundar has joined #openstack-nova | 16:51 | |
*** ociuhandu has quit IRC | 16:59 | |
*** maciejjozefczyk has quit IRC | 17:04 | |
*** iurygregory has quit IRC | 17:04 | |
*** maciejjozefczyk has joined #openstack-nova | 17:04 | |
*** ociuhandu has joined #openstack-nova | 17:08 | |
*** nweinber__ has quit IRC | 17:09 | |
*** gmann has quit IRC | 17:09 | |
*** gmann has joined #openstack-nova | 17:09 | |
*** bhagyashris has quit IRC | 17:10 | |
*** bhagyashris has joined #openstack-nova | 17:11 | |
*** iurygregory has joined #openstack-nova | 17:14 | |
*** rpittau is now known as rpittau|afk | 17:15 | |
*** bhagyashris has quit IRC | 17:17 | |
*** tesseract has quit IRC | 17:26 | |
*** iurygregory has quit IRC | 17:26 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova-specs master: Re-propose "Secure Boot support for KVM & QEMU guests" for Ussuri https://review.opendev.org/693844 | 17:27 |
kashyap | aarents: Sorry, I wasn't ignoring that change, just been buried. | 17:28 |
*** arxcruz is now known as arxcruz|off | 17:29 | |
*** guilhermesp has quit IRC | 17:31 | |
*** guilhermesp has joined #openstack-nova | 17:32 | |
*** awalende has joined #openstack-nova | 17:33 | |
*** ociuhandu has quit IRC | 17:33 | |
*** evrardjp has quit IRC | 17:34 | |
*** evrardjp has joined #openstack-nova | 17:34 | |
*** dtantsur is now known as dtantsur|afk | 17:35 | |
stephenfin | efried_afk: not sure if you're gone for the day, but https://review.opendev.org/#/c/697537/ could probably be revisited now that x-cell resize has merged | 17:46 |
stephenfin | and melwitt, I think I've clarified my (new) intent in https://review.opendev.org/#/c/696745/, which should assuage some of your concerns hopefully | 17:47 |
stephenfin | with that | 17:47 |
* stephenfin bails 🪂 | 17:47 | |
melwitt | stephenfin: ack | 17:47 |
*** awalende has quit IRC | 17:54 | |
*** TxGirlGeek has quit IRC | 18:01 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404 | 18:02 |
openstack | bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms) | 18:02 |
artom | dansmith, could I ask you to look at that 2-patch series ^^ when you get a chance? stephenfin's the other reviewer, but your +1 or +W'less +2 can still carry weight and help the evential non-RH approver (efried, I'm guessing) | 18:03 |
*** jcosmao has left #openstack-nova | 18:06 | |
*** TxGirlGeek has joined #openstack-nova | 18:07 | |
*** derekh has quit IRC | 18:08 | |
dansmith | artom: yeah, although I'm a couple layers deep on the stack and have a call in 18 minutes | 18:12 |
dansmith | artom: meaning, don't let me forget | 18:12 |
fungi | anybody remember how far back nova started providing configdrive by default without needing to manually enable it in the config? | 18:14 |
fungi | (i mean providing it if the client requests it at boot) | 18:14 |
dansmith | a long time | 18:14 |
*** ociuhandu has joined #openstack-nova | 18:14 | |
fungi | cool, config reference only goes back as far as pike but seemed to indicate it was available by default at least that far back | 18:15 |
fungi | thanks dansmith! | 18:15 |
dansmith | yeah I'm pretty sure it's been around for a real (real) long time | 18:15 |
sean-k-mooney | fungi: its been availabel via the api | 18:15 |
sean-k-mooney | its not on by defualt unless you request it or set the force config drive options in the config | 18:15 |
sean-k-mooney | it might predate micorverions | 18:16 |
fungi | yep, thanks. trying to help a user in #zuul figure out whether they have to do anything fancy in nova's config to make configdrive available to nodepool | 18:16 |
dansmith | it definitely predates microversions | 18:16 |
fungi | sounds like no, just make sure nodepool asks for a configdrive | 18:16 |
dansmith | well, isn't there a way to configure it to *not* honor the user's configdrive request? | 18:17 |
dansmith | ah, nevermind, looks like they can always ask for it | 18:17 |
dansmith | so yeah I think you're good | 18:17 |
*** xek_ has joined #openstack-nova | 18:18 | |
sean-k-mooney | fungi: the only thing they shoudl have to do is make sure the iso vfat tools are installed so nova can actully create the config drive | 18:18 |
sean-k-mooney | but they will be on any normal install | 18:18 |
fungi | right, already suggested that to them | 18:19 |
fungi | either genisofs or mkisofs depending on the vintage | 18:19 |
sean-k-mooney | yep | 18:19 |
*** ociuhandu has quit IRC | 18:19 | |
fungi | i have a feeling they just need to adjust their nodepool launcher config | 18:19 |
*** xek has quit IRC | 18:20 | |
fungi | they provided a `openstack show server` paste which indicated config_drive was not True and i expect that comes down to the boot parameters it provided | 18:20 |
sean-k-mooney | right. it could be forced in there config but nodepool has a setting for that too right | 18:22 |
sean-k-mooney | you can use https://zuul-ci.org/docs/nodepool/configuration.html#attr-providers.[openstack].diskimages.config-drive | 18:23 |
sean-k-mooney | actully it looks like node pool does not use the boot parmater since that is on the image and instead is using the image metadata right? | 18:24 |
sean-k-mooney | there are 3 ways to trun on cofig drive, the force_config_drive config option, the api boot request or the image metadata | 18:24 |
*** eharney has quit IRC | 18:26 | |
*** TheJulia has quit IRC | 18:29 | |
*** rpittau|afk has quit IRC | 18:30 | |
*** vdrok has quit IRC | 18:30 | |
*** masayukig has quit IRC | 18:30 | |
*** _erlon_ has quit IRC | 18:30 | |
*** coreycb has quit IRC | 18:30 | |
*** donnyd has quit IRC | 18:30 | |
*** csatari has quit IRC | 18:30 | |
*** cz3 has quit IRC | 18:30 | |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242 | 18:31 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243 | 18:31 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Define Cyborg ARQ binding notification event. https://review.opendev.org/692707 | 18:31 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | 18:31 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Pass accelerator requests to each virt driver from compute manager. https://review.opendev.org/698581 | 18:31 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Compose accelerator PCI devices into domain XML in libvirt driver. https://review.opendev.org/631245 | 18:31 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735 | 18:31 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940 | 18:31 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553 | 18:31 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554 | 18:31 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999 | 18:31 |
*** ildikov has quit IRC | 18:31 | |
*** arne_wiebalck_ has joined #openstack-nova | 18:31 | |
*** mnaser has quit IRC | 18:31 | |
*** awestin1 has quit IRC | 18:31 | |
*** donnyd has joined #openstack-nova | 18:31 | |
*** tonyb[m] has quit IRC | 18:31 | |
*** arne_wiebalck has quit IRC | 18:31 | |
*** arne_wiebalck_ is now known as arne_wiebalck | 18:31 | |
*** TheJulia has joined #openstack-nova | 18:32 | |
*** openstackstatus has quit IRC | 18:32 | |
*** coreycb has joined #openstack-nova | 18:32 | |
*** ildikov has joined #openstack-nova | 18:33 | |
*** vdrok has joined #openstack-nova | 18:33 | |
*** csatari has joined #openstack-nova | 18:33 | |
*** cz3 has joined #openstack-nova | 18:33 | |
*** mnaser has joined #openstack-nova | 18:33 | |
*** johnsom has quit IRC | 18:33 | |
*** tosky has quit IRC | 18:33 | |
*** awestin1 has joined #openstack-nova | 18:33 | |
*** awestin1 has quit IRC | 18:34 | |
*** tonyb[m] has joined #openstack-nova | 18:35 | |
*** johnsom has joined #openstack-nova | 18:35 | |
*** awestin1 has joined #openstack-nova | 18:36 | |
*** masayukig has joined #openstack-nova | 18:36 | |
*** csatari has quit IRC | 18:38 | |
*** eharney has joined #openstack-nova | 18:38 | |
openstackgerrit | waleed mousa proposed openstack/os-vif master: [Follow Up] OVS DPDK port representors support https://review.opendev.org/665965 | 18:39 |
*** rcernin has joined #openstack-nova | 18:40 | |
*** cz3 has quit IRC | 18:40 | |
*** TheJulia has quit IRC | 18:40 | |
*** donnyd has quit IRC | 18:40 | |
*** sorrison has quit IRC | 18:42 | |
*** donnyd has joined #openstack-nova | 18:42 | |
artom | dansmith, sorry, was on a 1:1 | 18:43 |
artom | dansmith, thanks! I'll be sure to hound your ass then | 18:43 |
*** sorrison has joined #openstack-nova | 18:46 | |
*** slaweq has quit IRC | 18:47 | |
*** efried_afk is now known as efried | 18:55 | |
efried | #success With the merging of https://review.opendev.org/#/c/696518/ mox is finally purged from nova \o/ | 19:01 |
sean-k-mooney | cool | 19:02 |
efried | takashin, stephenfin: ^ I closed out the bp | 19:02 |
efried | hm, no response from successbot | 19:02 |
efried | shrug | 19:02 |
sean-k-mooney | it was so amazed that its finally done it need a minute | 19:02 |
sean-k-mooney | or its borked | 19:03 |
dansmith | maybe it is opinionated now and doesn't agree it's a successbot-worthy moment? | 19:06 |
sean-k-mooney | in that case can we get it to do code reviews for us too | 19:06 |
sean-k-mooney | its tallens are clearly being wasted | 19:07 |
*** Sundar has quit IRC | 19:08 | |
*** TxGirlGeek has quit IRC | 19:10 | |
openstackgerrit | Merged openstack/nova master: libvirt: Remove MIN_LIBVIRT_KVM_AARCH64_VERSION https://review.opendev.org/695901 | 19:11 |
*** martinkennelly has quit IRC | 19:11 | |
*** TxGirlGeek has joined #openstack-nova | 19:15 | |
efried | stephenfin: done, and the one a couple further up the series. | 19:16 |
fungi | openstackstatus is not present in here. checking to see if it's fallen victim to a netsplit or something, hold on | 19:19 |
*** openstackstatus has joined #openstack-nova | 19:22 | |
*** ChanServ sets mode: +v openstackstatus | 19:22 | |
fungi | efried: okay, try again! | 19:22 |
efried | #success With the merging of https://review.opendev.org/#/c/696518/ mox is finally purged from nova \o/ | 19:22 |
openstackstatus | efried: Added success to Success page (https://wiki.openstack.org/wiki/Successes) | 19:22 |
efried | nice, thanks fungi! | 19:22 |
fungi | it was disconnected for the past 50 minutes due to some shakeup in freenode | 19:23 |
fungi | but should be fine now | 19:23 |
efried | you da person | 19:23 |
fungi | efried: thanks for communicating the moxtermination! | 19:23 |
fungi | i think we've all been looking forward to it for a *very* long time | 19:23 |
* sean-k-mooney waits for dansmith and mriedem | 19:24 | |
fungi | heh | 19:24 |
sean-k-mooney | fungi: while you are here. do you know what the plan will be regarding ubuntu 20.04 i assume we will move to it sometime in V | 19:25 |
sean-k-mooney | i guess that decsion wont be made untill closer to the start of V but just said i would ask | 19:26 |
fungi | sean-k-mooney: it's slated to be released around ussuri rc1 last i looked, so we'll likely have images available before ussuri releases but maybe not as soon as master reopens for victoria commits | 19:26 |
sean-k-mooney | is it actully victoria. i did not see a poll for the name although i might have missed it | 19:27 |
fungi | aiui, the tc is ready to declare ubuntu 20.04 a release platform for victoria though: https://review.opendev.org/693743 | 19:28 |
sean-k-mooney | ok cool we were discussing a kerenl 5.4 feature downstream earlier and the reason i asked is i think 20.04 will be based on 5.4 | 19:29 |
fungi | sean-k-mooney: yeah, voting on the v cycle name happened in early december, collecting ideas started in mid-november | 19:30 |
fungi | http://lists.openstack.org/pipermail/openstack-discuss/2019-November/010880.html | 19:30 |
fungi | http://lists.openstack.org/pipermail/openstack-discuss/2020-January/011947.html | 19:30 |
sean-k-mooney | ah ok i saw the tread on the proposal but i obviously missed the vote likely when i went on vaction | 19:31 |
fungi | announcement was ^ last week after legal was done with trademark searches and risk eval | 19:31 |
fungi | and the w cycle naming process is about to get underway: https://review.opendev.org/702414 | 19:32 |
*** iurygregory has joined #openstack-nova | 19:36 | |
*** dklyle has quit IRC | 19:36 | |
*** ociuhandu has joined #openstack-nova | 19:36 | |
sean-k-mooney | cool thanks for the update :) | 19:36 |
*** dklyle has joined #openstack-nova | 19:37 | |
*** dklyle has quit IRC | 19:37 | |
*** dklyle has joined #openstack-nova | 19:38 | |
sean-k-mooney | efried: dansmith i currently have sundars latest update stacking. ill likely test it out tomorow however since im about to call it a day | 19:38 |
dansmith | cool | 19:38 |
openstackgerrit | Merged openstack/os-traits master: Add a trait that compute manager can handle accelerator requests. https://review.opendev.org/698961 | 20:02 |
*** TheJulia has joined #openstack-nova | 20:08 | |
*** _erlon_ has joined #openstack-nova | 20:11 | |
*** mrch_ has quit IRC | 20:14 | |
*** ccamacho has quit IRC | 20:16 | |
openstackgerrit | Merged openstack/nova master: nova-net: Remove unused exceptions https://review.opendev.org/697149 | 20:33 |
openstackgerrit | Merged openstack/nova master: nova-net: Remove unnecessary 'neutronv2' prefixes https://review.opendev.org/696776 | 20:34 |
*** eharney has quit IRC | 20:36 | |
*** slaweq has joined #openstack-nova | 20:36 | |
*** iurygregory has quit IRC | 20:37 | |
*** gentoorax is now known as gentoorax_away | 20:41 | |
*** gentoorax_away is now known as gentoorax | 20:41 | |
openstackgerrit | waleed mousa proposed openstack/os-vif master: [Follow Up] OVS DPDK port representors support https://review.opendev.org/665965 | 20:42 |
*** vishalmanchanda has quit IRC | 20:44 | |
*** mrch_ has joined #openstack-nova | 20:45 | |
efried | lyarwood: I updated your os-traits release patch to pick up COMPUTE_ACCELERATORS which just merged. | 20:46 |
sean-k-mooney | ya i had to use libs_from_git to pull that in for testing the cyborg changes so that would be useful | 20:46 |
*** ralonsoh has quit IRC | 20:57 | |
*** mrch_ has quit IRC | 21:00 | |
*** dviroel has quit IRC | 21:10 | |
*** cz3 has joined #openstack-nova | 21:14 | |
*** slaweq has quit IRC | 21:19 | |
*** luyao has quit IRC | 21:23 | |
openstackgerrit | Merged openstack/nova stable/rocky: Improve metadata server performance with large security groups https://review.opendev.org/697517 | 21:27 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522 | 21:28 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460 | 21:28 |
*** igordc has joined #openstack-nova | 21:29 | |
*** CeeMac has quit IRC | 21:40 | |
*** rcernin has quit IRC | 21:42 | |
efried | msg diablo_rojo | 21:45 |
efried | sigh | 21:45 |
openstackgerrit | Merged openstack/nova stable/stein: block_device: Copy original volume_type when missing for snapshot based volumes https://review.opendev.org/696686 | 21:46 |
*** eharney has joined #openstack-nova | 21:48 | |
*** ociuhandu has quit IRC | 21:54 | |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460 | 22:18 |
*** xek_ has quit IRC | 22:24 | |
*** ganso has quit IRC | 22:35 | |
*** maciejjozefczyk has quit IRC | 22:35 | |
*** mriedem has left #openstack-nova | 22:36 | |
*** dosaboy has quit IRC | 22:36 | |
*** dklyle has quit IRC | 22:40 | |
*** nweinber__ has joined #openstack-nova | 22:44 | |
efried | dustinc: ready for re-review? | 22:49 |
*** dklyle has joined #openstack-nova | 22:49 | |
*** ganso has joined #openstack-nova | 22:53 | |
*** dosaboy has joined #openstack-nova | 22:53 | |
*** rcernin has joined #openstack-nova | 22:55 | |
*** nweinber__ has quit IRC | 22:56 | |
*** tkajinam has joined #openstack-nova | 23:03 | |
*** igordc has quit IRC | 23:09 | |
*** igordc has joined #openstack-nova | 23:10 | |
*** mlavalle has quit IRC | 23:15 | |
*** tobiash has quit IRC | 23:38 | |
*** tobiash has joined #openstack-nova | 23:39 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!