*** zhanglong has quit IRC | 00:03 | |
*** brinzhang has joined #openstack-nova | 00:08 | |
*** mriedem has quit IRC | 00:11 | |
*** brinzhang_ has quit IRC | 00:12 | |
*** igordc has quit IRC | 00:25 | |
*** igordc has joined #openstack-nova | 00:25 | |
*** brinzhang has quit IRC | 00:39 | |
*** zhanglong has joined #openstack-nova | 00:41 | |
*** igordc has quit IRC | 00:49 | |
*** brinzhang has joined #openstack-nova | 00:52 | |
*** brinzhang has quit IRC | 00:54 | |
*** artom has quit IRC | 01:00 | |
*** xiaolin has joined #openstack-nova | 01:03 | |
*** brinzhang has joined #openstack-nova | 01:07 | |
*** jistr has quit IRC | 01:17 | |
*** jistr has joined #openstack-nova | 01:19 | |
*** gentoorax has quit IRC | 01:38 | |
*** gentoorax has joined #openstack-nova | 01:43 | |
*** ircuser-1 has joined #openstack-nova | 02:03 | |
*** macz has joined #openstack-nova | 02:15 | |
*** hoonetorg has quit IRC | 02:17 | |
*** macz has quit IRC | 02:20 | |
*** hoonetorg has joined #openstack-nova | 02:31 | |
*** damien_r has joined #openstack-nova | 02:34 | |
*** damien_r has quit IRC | 02:35 | |
*** damien_r has joined #openstack-nova | 02:35 | |
*** ociuhandu has joined #openstack-nova | 02:47 | |
alex_xu | gibi: yea, I can be the liaison for that | 02:50 |
---|---|---|
*** awalende has joined #openstack-nova | 02:50 | |
alex_xu | melwitt: i have few question for https://review.opendev.org/602201, still on the road to familar the spec | 02:51 |
*** ociuhandu has quit IRC | 02:51 | |
*** awalende has quit IRC | 02:55 | |
*** zhanglong has quit IRC | 03:03 | |
*** dklyle has joined #openstack-nova | 03:07 | |
*** damien_r has quit IRC | 03:10 | |
*** brinzhang has quit IRC | 03:27 | |
*** hongbin has joined #openstack-nova | 04:03 | |
*** tetsuro has quit IRC | 04:18 | |
*** mkrai_ has joined #openstack-nova | 04:18 | |
*** tetsuro has joined #openstack-nova | 04:19 | |
*** tetsuro has quit IRC | 04:23 | |
*** hongbin has quit IRC | 04:39 | |
*** udesale has joined #openstack-nova | 04:44 | |
*** udesale has quit IRC | 04:44 | |
*** udesale has joined #openstack-nova | 04:44 | |
*** links has joined #openstack-nova | 04:49 | |
*** tetsuro has joined #openstack-nova | 05:03 | |
*** sridharg has joined #openstack-nova | 05:09 | |
*** macz has joined #openstack-nova | 05:20 | |
*** macz has quit IRC | 05:22 | |
*** evrardjp has quit IRC | 05:34 | |
*** evrardjp has joined #openstack-nova | 05:34 | |
*** udesale_ has joined #openstack-nova | 05:34 | |
*** udesale has quit IRC | 05:37 | |
*** rchurch has quit IRC | 05:52 | |
*** rchurch has joined #openstack-nova | 05:54 | |
*** lpetrut has joined #openstack-nova | 06:08 | |
*** lpetrut has quit IRC | 06:09 | |
*** lpetrut has joined #openstack-nova | 06:10 | |
*** adriant has quit IRC | 06:40 | |
*** adriant has joined #openstack-nova | 06:41 | |
*** lpetrut has quit IRC | 06:49 | |
*** TxGirlGeek has joined #openstack-nova | 06:59 | |
*** TxGirlGeek has quit IRC | 07:07 | |
*** ociuhandu has joined #openstack-nova | 07:30 | |
*** ociuhandu has quit IRC | 07:35 | |
*** lpetrut has joined #openstack-nova | 07:38 | |
*** maciejjozefczyk_ has joined #openstack-nova | 07:48 | |
*** slaweq has joined #openstack-nova | 08:03 | |
*** shilpasd has quit IRC | 08:06 | |
*** bnemec has joined #openstack-nova | 08:06 | |
*** awalende has joined #openstack-nova | 08:07 | |
*** tkajinam has quit IRC | 08:10 | |
*** iurygregory has joined #openstack-nova | 08:11 | |
*** tesseract has joined #openstack-nova | 08:20 | |
*** priteau has joined #openstack-nova | 08:29 | |
*** ralonsoh has joined #openstack-nova | 08:30 | |
*** shilpasd has joined #openstack-nova | 08:43 | |
*** links has quit IRC | 08:47 | |
*** rpittau|afk is now known as rpittau | 08:48 | |
*** martinkennelly has joined #openstack-nova | 08:49 | |
gibi | alex_xu: thanks | 08:49 |
*** links has joined #openstack-nova | 08:53 | |
*** dtantsur|afk is now known as dtantsur | 08:57 | |
*** iurygregory has quit IRC | 08:59 | |
*** tosky has joined #openstack-nova | 09:07 | |
*** shilpasd has quit IRC | 09:12 | |
*** iurygregory has joined #openstack-nova | 09:13 | |
*** brinzhang has joined #openstack-nova | 09:16 | |
*** jaosorior has joined #openstack-nova | 09:19 | |
*** brinzhang has quit IRC | 09:22 | |
*** brinzhang has joined #openstack-nova | 09:23 | |
*** xek has joined #openstack-nova | 09:24 | |
*** udesale_ has quit IRC | 09:28 | |
*** udesale_ has joined #openstack-nova | 09:28 | |
*** derekh has joined #openstack-nova | 09:28 | |
*** mkrai_ has quit IRC | 09:28 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Stop setting Flavor.id https://review.opendev.org/703568 | 09:51 |
stephenfin | alex_xu, gibi, bauzas: Can you folks take a look at ^ since it's causing intermittent gate failures | 09:51 |
*** jaosorior has quit IRC | 09:54 | |
stephenfin | I also need someone to add me to nova-drivers again so I can triage bugs :/ | 09:54 |
stephenfin | https://launchpad.net/~nova-drivers | 09:54 |
*** tetsuro has quit IRC | 09:56 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova.image.api' module https://review.opendev.org/702451 | 09:57 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: nova-net: Remove unused nova-network objects https://review.opendev.org/697156 | 09:57 |
brinzhang | stephenfin: https://review.opendev.org/#/c/702790/ this I was fixed the functional test fails, and leave the failed reason, please review again, while you are free | 09:59 |
*** sapd1_x has joined #openstack-nova | 09:59 | |
brinzhang | alex_xu: please reivew https://review.opendev.org/#/c/580271 and https://review.opendev.org/#/c/702790/ when you are free | 10:00 |
brinzhang | stephenfin, alex_xu: thanks :) | 10:00 |
stephenfin | brinzhang: Done. I want to get dansmith to hit that again when he's online | 10:01 |
brinzhang | stephenfin: yeah | 10:02 |
brinzhang | dansmith: please reivew https://review.opendev.org/#/c/580271 and https://review.opendev.org/#/c/702790/ with bug 1663456 fix code, in your free time | 10:03 |
openstack | bug 1663456 in OpenStack Compute (nova) "Field 'updated_at' always 'None' when show aggregate" [Low,In progress] https://launchpad.net/bugs/1663456 - Assigned to Brin Zhang (zhangbailin) | 10:03 |
*** links has quit IRC | 10:04 | |
stephenfin | brinzhang: Does my comment on https://review.opendev.org/#/c/702790/ make sense? | 10:04 |
brinzhang | stephenfin: ack | 10:05 |
*** links has joined #openstack-nova | 10:07 | |
*** ivve has joined #openstack-nova | 10:07 | |
*** mkrai_ has joined #openstack-nova | 10:08 | |
brinzhang | stephenfin: yeah, that's ture, your comment is makes sense. | 10:09 |
*** openstackgerrit has quit IRC | 10:12 | |
bauzas | stephenfin: sorry had some internal network issues since yesterday evening, but will add you | 10:23 |
bauzas | stephenfin: oh, actually it's the wrong team | 10:24 |
stephenfin | well, that would explain things :-D | 10:24 |
bauzas | stephenfin: you need to be in https://launchpad.net/~nova-bugs | 10:25 |
stephenfin | perfect. thanks | 10:26 |
bauzas | and +2 | 10:29 |
bauzas | stephenfin: but I said we should wait a little bit for the CI to return first | 10:29 |
*** sapd1_x has quit IRC | 10:29 | |
stephenfin | Coolness | 10:30 |
kashyap | To those using Bash ... here's something useful (and fun): | 10:31 |
kashyap | To intelligently prepend an env. variable: | 10:32 |
kashyap | export LD_LIBRARY_PATH=/mypath${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH} | 10:32 |
kashyap | [ Source: http://stackoverflow.com/a/9631350 ] | 10:32 |
kashyap | [And: https://www.gnu.org/savannah-checkouts/gnu/bash/manual/bash.html#Shell-Parameter-Expansion] | 10:32 |
kashyap | It's yet another obscure/magical-yet-useful combination of characters in Bash :D | 10:34 |
*** priteau has quit IRC | 10:41 | |
*** CeeMac has joined #openstack-nova | 10:43 | |
*** _rajat_ has joined #openstack-nova | 10:48 | |
*** mkrai_ has quit IRC | 10:50 | |
*** mkrai__ has joined #openstack-nova | 10:50 | |
*** udesale_ has quit IRC | 10:51 | |
*** mrch_ has joined #openstack-nova | 10:56 | |
*** awalende has quit IRC | 11:13 | |
*** awalende has joined #openstack-nova | 11:14 | |
*** rpittau is now known as rpittau|bbl | 11:15 | |
*** dviroel has joined #openstack-nova | 11:25 | |
gibi | stephenfin: does the flavor ids in conflict within a test case or in between test cases running in the same test executor worker? | 11:27 |
stephenfin | gibi: It appears to be the latter, although I'm not sure if the DB fixture is supposed to prevent that or not | 11:33 |
stephenfin | i.e. if we tear down the DB after every test | 11:33 |
gibi | stephenfin: I think we should tear down the db after each step | 11:33 |
gibi | stephenfin: but there could be some global state that leaks | 11:34 |
gibi | stephenfin: your fix is still OK, I'm just wondering if we have a bigger problem somewhere deep | 11:37 |
*** zhanglong has joined #openstack-nova | 11:44 | |
*** maciejjozefczyk_ has quit IRC | 11:45 | |
stephenfin | gibi: I wonder where we'd start. Probably examine the SQLite DB after N tests | 11:47 |
gibi | yeah something like that | 11:53 |
*** zhanglong has quit IRC | 11:53 | |
gibi | but don't spend too much time on this | 11:53 |
*** dtantsur is now known as dtantsur|bbl | 12:01 | |
*** maciejjozefczyk_ has joined #openstack-nova | 12:04 | |
*** priteau has joined #openstack-nova | 12:07 | |
*** mkrai__ has quit IRC | 12:10 | |
*** ociuhandu has joined #openstack-nova | 12:12 | |
*** ociuhandu has quit IRC | 12:13 | |
*** tkajinam has joined #openstack-nova | 12:14 | |
*** openstackgerrit has joined #openstack-nova | 12:17 | |
openstackgerrit | sean mooney proposed openstack/nova master: Revert "Skip cpu comparison on AArch64" https://review.opendev.org/703596 | 12:17 |
*** artom has joined #openstack-nova | 12:24 | |
*** mkrai_ has joined #openstack-nova | 12:25 | |
*** rcernin has quit IRC | 12:28 | |
*** Luzi has joined #openstack-nova | 12:28 | |
*** nweinber__ has joined #openstack-nova | 12:34 | |
*** Liang__ has joined #openstack-nova | 12:46 | |
*** dpawlik has joined #openstack-nova | 12:46 | |
*** Liang__ is now known as LiangFang | 12:46 | |
*** nicolasbock has joined #openstack-nova | 12:50 | |
*** ociuhandu has joined #openstack-nova | 12:52 | |
*** udesale has joined #openstack-nova | 12:59 | |
*** ociuhandu has quit IRC | 13:01 | |
*** _rajat_ has quit IRC | 13:02 | |
*** nearyo has joined #openstack-nova | 13:03 | |
*** priteau has quit IRC | 13:05 | |
*** rpittau|bbl is now known as rpittau | 13:05 | |
*** rouk has joined #openstack-nova | 13:05 | |
*** mkrai_ has quit IRC | 13:06 | |
*** zbr|drover has quit IRC | 13:18 | |
sean-k-mooney | stephenfin: the db fixture should be createing and delete the sqlite db for each test | 13:18 |
sean-k-mooney | tox will execute the test in effectivly a random order so we cannot have an ordering depencies in how the tests are run so all the tests must use a clean copy | 13:19 |
*** zbr has joined #openstack-nova | 13:19 | |
*** damien_r has joined #openstack-nova | 13:24 | |
*** damien_r has quit IRC | 13:24 | |
*** damien_r has joined #openstack-nova | 13:24 | |
*** dpawlik has quit IRC | 13:33 | |
*** ganso has quit IRC | 13:33 | |
*** ganso has joined #openstack-nova | 13:34 | |
*** iurygregory has quit IRC | 13:35 | |
*** Liang__ has joined #openstack-nova | 13:37 | |
stephenfin | sean-k-mooney: Yeah, that's what we're thinking. Just seems unlikely that you'd have a randint conflict in the scope of one test | 13:37 |
stephenfin | But I guess not | 13:37 |
*** LiangFang has quit IRC | 13:38 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for failed and aborted live migration https://review.opendev.org/699065 | 13:39 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove extra instance.save() calls related to qos SRIOV ports https://review.opendev.org/702261 | 13:41 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use common server create function for qos func tests https://review.opendev.org/701353 | 13:41 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable live migration with qos ports https://review.opendev.org/699066 | 13:45 |
*** ociuhandu has joined #openstack-nova | 13:47 | |
*** ociuhandu has quit IRC | 13:53 | |
*** tbachman has joined #openstack-nova | 13:55 | |
*** nearyo has quit IRC | 13:59 | |
*** dtantsur|bbl is now known as dtantsur | 14:01 | |
*** iurygregory has joined #openstack-nova | 14:05 | |
*** bhagyashris_ has joined #openstack-nova | 14:09 | |
*** bhagyashris_ has quit IRC | 14:10 | |
openstackgerrit | Alexandre arents proposed openstack/nova master: Avoid allocation leak when deleting instance stuck in BUILD https://review.opendev.org/702368 | 14:11 |
*** mkrai_ has joined #openstack-nova | 14:13 | |
*** awalende has quit IRC | 14:16 | |
*** links has quit IRC | 14:24 | |
*** mgariepy has joined #openstack-nova | 14:37 | |
*** Luzi has quit IRC | 14:46 | |
*** sridharg has quit IRC | 14:47 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603 | 14:56 |
kashyap | gibi: Thanks for the review; hope the above looks better. | 14:56 |
*** tbachman has quit IRC | 14:58 | |
efried_pto | stephenfin: I'm trying to find out who the admins of lp nova-drivers are... | 15:03 |
sean-k-mooney | its owned by openstack adminstrators | 15:04 |
sean-k-mooney | https://launchpad.net/~nova-drivers | 15:04 |
sean-k-mooney | efried_pto: https://launchpad.net/~nova-drivers/+members#active | 15:05 |
*** efried_pto is now known as efried | 15:05 | |
sean-k-mooney | but melwitt is an admin | 15:05 |
sean-k-mooney | so she can make you one if you need it | 15:05 |
efried | oh, why didn't I see that status column before? | 15:06 |
sean-k-mooney | the openstack amdinstartor group is https://launchpad.net/~openstack-admins/+members#active by the way | 15:06 |
efried | yeah, melwitt probably a good idea to give yourself a backup who's actually still on the core team. | 15:06 |
sean-k-mooney | in case you need them to change something | 15:06 |
efried | me or dansmith | 15:06 |
efried | thanks sean-k-mooney | 15:06 |
sean-k-mooney | no worries | 15:07 |
* sean-k-mooney goes to get coffee | 15:07 | |
efried | We should do the same for nova-bugs, if we can raise mriedem or mikal... | 15:08 |
*** Liang__ is now known as LiangFang | 15:09 | |
sean-k-mooney | if you cant then corvus can fix it for us | 15:09 |
sean-k-mooney | actully anyone in the openstack administratros group should be able to do it | 15:11 |
johnthetubaguy | efried: I can take a look | 15:14 |
johnthetubaguy | I should have been removed from some of these mind! | 15:15 |
bauzas | we no longer really need nova-drivers FWIW | 15:15 |
bauzas | it was for blueprints IIRC | 15:15 |
johnthetubaguy | bauzas: yeah, its mostly permissions around blueprints, from my memory | 15:16 |
*** tkajinam has quit IRC | 15:16 | |
sean-k-mooney | yes the drivers group are teh one that can apporve blueprints i thin | 15:16 |
bauzas | just to set 'Accepted' | 15:16 |
johnthetubaguy | looks like efried got added in nova-drivers now | 15:16 |
sean-k-mooney | i think its also used to create series and milestones too | 15:18 |
*** LiangFang has quit IRC | 15:18 | |
openstackgerrit | Merged openstack/nova master: functional: Stop setting Flavor.id https://review.opendev.org/703568 | 15:24 |
gibi | kashyap: did you forget to publish your answer to https://review.opendev.org/#/c/616603/12..13/nova/virt/libvirt/driver.py@a5116 ? | 15:24 |
kashyap | gibi: Whoops, indeed | 15:24 |
kashyap | Let me hit 'submit' | 15:25 |
gibi | :) | 15:25 |
kashyap | Done. Sorry :-) | 15:25 |
gibi | no problem | 15:25 |
kashyap | gibi: In short, although good catch on the negation, we'd need the 'and' there. | 15:25 |
*** Sundar has joined #openstack-nova | 15:25 | |
efried | johnthetubaguy: thanks, I appear to be admin-y now. | 15:26 |
gibi | if this is intentional then I'm OK with it. let me read your answer :) | 15:26 |
kashyap | gibi: Unrelated to this change: /me has a TODO to allow two more possible values for 'hw_rng_model', besides "virtio". Hence we need to retain that extra spec | 15:26 |
johnthetubaguy | efried: cool | 15:26 |
efried | ...on -drivers. johnthetubaguy do you have power in nova-bugs? | 15:26 |
kashyap | gibi: Yes, it is intentional; but of course your observation was correct | 15:26 |
johnthetubaguy | efried: it seems not sadly | 15:26 |
kashyap | gibi: And I noticed that you didn't frame it as "this is wrong", but rather "thinking it out loud; is this intentional" :-) | 15:27 |
*** ociuhandu has joined #openstack-nova | 15:30 | |
gibi | kashyap: I'm still confused. If the user sets hw_rng:allowed = False but but does not set anything to hw_rng_model then he gets no rng device, but then if he sets anything to hw_rng_model the he will get an rng device even if hw_rng:allowed is still false | 15:31 |
kashyap | gibi: 'hw_rng_model' will have no effect if 'hw_rng:allowed' is not set to True | 15:35 |
kashyap | gibi: And the only currently allowable value for 'hw_rng_model' is "virtio" | 15:36 |
gibi | kashyap: I guess that "no effect" is outside fo Hi Balazs, | 15:36 |
gibi | kashyap: I guess that "no effect" is outside of _add_rng_device | 15:36 |
gibi | because in _add_rng_device if hw_rng:allowed is False but hw_rng_model is not empty then we are adding a device | 15:37 |
kashyap | gibi: Yeah | 15:37 |
sean-k-mooney | well if hw_rng:allowed=False we shoudl nto add a RNG device | 15:38 |
sean-k-mooney | regardless of what the hw_rng_model is set to | 15:38 |
kashyap | gibi: sean-k-mooney: Yes: | 15:40 |
kashyap | - if not rng_is_virtio and not rng_allowed: | 15:40 |
kashyap | + if not rng_allowed: | 15:40 |
kashyap | Then 'hw_rng_model' will be "useless" (but we want to enhance the prop to allow two more values), as it isn't used outside this method. | 15:42 |
gibi | kashyap: if the value of hw_rng_model is not need to decide to add the device that is fine. As soon as we (you) add support the new model values then such change will make hw_rng_model used again, in the device parameters (I guess) | 15:43 |
kashyap | gibi: Yes, I'll go with the above 'diff' and document the TODO the image props to extend it for new values | 15:44 |
kashyap | gibi: Sounds okay? | 15:44 |
gibi | kashyap: yes, sounds good | 15:45 |
kashyap | (The extended two values will also be virtio variants.) | 15:45 |
sean-k-mooney | we have not added new values in several cycle and like will not in the future | 15:45 |
sean-k-mooney | so we might just want to deprecate the model | 15:45 |
sean-k-mooney | is there support in qemu for other RNGs? | 15:46 |
gibi | sean-k-mooney: I guess kashyap disagrees ^^ | 15:46 |
*** lpetrut has quit IRC | 15:46 | |
kashyap | sean-k-mooney: Wait: how do you know "not in the future"? The new values were added to fix certain bugs with guest compat with old operating systems | 15:46 |
kashyap | As I mentioned on the change. | 15:46 |
sean-k-mooney | well im just asking is can it have other value form a qemu point of view | 15:46 |
kashyap | sean-k-mooney: Yes: | 15:47 |
kashyap | https://libvirt.org/formatdomain.html#elementsVirtioTransitional | 15:47 |
sean-k-mooney | the model has noting to do with tanstional devices | 15:47 |
kashyap | sean-k-mooney: Hang on. | 15:48 |
kashyap | sean-k-mooney: 'virtio-transitional' is another possible value, instead of 'virtio' | 15:48 |
kashyap | Please take two minutes to read what the page is saying. | 15:48 |
sean-k-mooney | oh i see they aded that in 5.2 | 15:48 |
kashyap | I also quoted *specific* bits in the Gerrit change! | 15:49 |
sean-k-mooney | so im not sure we should be exposing that to end users | 15:49 |
kashyap | So you haven't read the comment that clearly explains it here: https://review.opendev.org/#/c/616603/10/nova/virt/libvirt/driver.py@5114 | 15:50 |
kashyap | In short: we should _not_ deprecate it. | 15:50 |
kashyap | (Where "it" == hw_rng_model) | 15:50 |
kashyap | sean-k-mooney: I'm sure we should expose them as possible values for the user | 15:51 |
sean-k-mooney | im wondering if nova can just make the chioce itself without exposeing it to the user | 15:51 |
kashyap | Hmm, I don't think we have enough info about it. | 15:51 |
sean-k-mooney | sure we do | 15:51 |
*** ociuhandu has quit IRC | 15:51 | |
sean-k-mooney | if qemu/libvirt support the virtio-non-transitional version shoudl we not always use it | 15:52 |
kashyap | I'm of course not saying we should unconditionally enable anything what QEMU/libvirt support. | 15:52 |
* gibi needs to leave | 15:53 | |
kashyap | Anyway, we're going into the weeds here. The point being: we should not be in a hurry to deprecate that prop | 15:53 |
sean-k-mooney | ok | 15:53 |
sean-k-mooney | we also shoudl not be in a hurry to extend it | 15:53 |
sean-k-mooney | that is not relevent to your patch however | 15:53 |
kashyap | Yes, I'm not hurrying to extend it; I wanted to keep it a potential option. | 15:54 |
sean-k-mooney | i guess we might need to expose it for legacy os support | 15:54 |
kashyap | sean-k-mooney: gibi: To conclude the discussion: my previous comment still stands: will go with the `diff` noted earlier w/ a TODO in code | 15:54 |
sean-k-mooney | but they could jsut disbael the RNG | 15:54 |
kashyap | sean-k-mooney: Yeah, indeed on the legacy OS | 15:55 |
sean-k-mooney | ya the diff is fine with me | 15:55 |
kashyap | Okido | 15:55 |
kashyap | Thanks for bearing with me | 15:55 |
kashyap | Completely unrelated: I can't even do Ctrl-c in Grrrrrit-- anymore. Is it just me? | 15:56 |
sean-k-mooney | i got it working but i know other have had issues | 15:57 |
sean-k-mooney | its a browser thing i think | 15:57 |
sean-k-mooney | i dont think our gerrit was updated | 15:57 |
*** TxGirlGeek has joined #openstack-nova | 15:58 | |
*** udesale has quit IRC | 15:59 | |
kashyap | sean-k-mooney: I tried it in both FF and Chromium :-( | 16:00 |
kashyap | (To no effect) | 16:00 |
*** iurygregory has quit IRC | 16:01 | |
*** maciejjozefczyk_ has quit IRC | 16:04 | |
sean-k-mooney | kashyap: so in chrome i has the "webkit-user-select: none" css property applied | 16:12 |
sean-k-mooney | to the comment | 16:12 |
*** openstackgerrit has quit IRC | 16:13 | |
sean-k-mooney | in firfox 67 it does not | 16:14 |
kashyap | sean-k-mooney: I see, will fiddle. Thank you for the tip | 16:14 |
kashyap | sean-k-mooney: Unrelated: do we have any examples of this: | 16:15 |
kashyap | "* Some properties recognized by Nova may have no effect unless a corresponding property is enabled in the server flavor." | 16:15 |
kashyap | (The 'hw_rng_model' / 'hw_rng:allowed' used to be one; but now we're changing it.) | 16:16 |
kashyap | I quoted it from Glance docs; as I'm updating them | 16:16 |
*** mrch_ has quit IRC | 16:17 | |
sean-k-mooney | am hw:mem_page_size in the image will only have an effect if hw:mem_page_size=any or hw:mem_page_size=large | 16:21 |
sean-k-mooney | i think the realtime mask in the image will also be ignored if you dont enable in in the flaovr but we normally try to make it an irror rather then ignore it | 16:22 |
sean-k-mooney | this is slightly different however | 16:22 |
*** ociuhandu has joined #openstack-nova | 16:23 | |
sean-k-mooney | in that its more qulatitive. i.e. it is saying if i have a random number generateor make it of this type | 16:23 |
*** mriedem has joined #openstack-nova | 16:23 | |
*** ociuhandu has quit IRC | 16:28 | |
kashyap | sean-k-mooney: Yeah, the hw:mem_page_size is not dependent on any other property; so it's different indeed | 16:29 |
*** tbachman has joined #openstack-nova | 16:29 | |
sean-k-mooney | i think the realtime mask is the best example | 16:29 |
sean-k-mooney | realtiem cpus can only be enabled in the falvor | 16:30 |
sean-k-mooney | but you can set the mask in the flavor or image | 16:30 |
sean-k-mooney | and the image mask only works if its enabled in the flavor | 16:30 |
sean-k-mooney | also http://paste.openstack.org/show/788651/ is what i think is going on with gerrit | 16:30 |
kashyap | sean-k-mooney: Got the exact property names, please? So I can fix the Gerrit document right away | 16:30 |
* kashyap clicks | 16:30 | |
*** macz has joined #openstack-nova | 16:31 | |
sean-k-mooney | i should have added https://developer.mozilla.org/en-US/docs/Web/CSS/initial | 16:32 |
kashyap | sean-k-mooney: Thank you :-) | 16:32 |
sean-k-mooney | so ya inial restores a property to its defaul state which may have changed | 16:32 |
sean-k-mooney | hehe i like that note " On inherited properties, the initial value may be unexpected. " | 16:33 |
*** tosky has quit IRC | 16:33 | |
sean-k-mooney | in other words if you use it it will break | 16:33 |
sean-k-mooney | eventually | 16:33 |
*** eharney has quit IRC | 16:35 | |
*** openstackgerrit has joined #openstack-nova | 16:35 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603 | 16:35 |
kashyap | sean-k-mooney: When you can, does the TODO & NOTE added above make sense to you? | 16:36 |
*** ociuhandu has joined #openstack-nova | 16:36 | |
sean-k-mooney | im not sure i agree with likely to be extended :P but yes they make sense although i proably woudl make them both NOTE | 16:38 |
*** gyee has joined #openstack-nova | 16:39 | |
sean-k-mooney | mainlly because virtion 1.0 was standarised in 2016 | 16:39 |
*** iurygregory has joined #openstack-nova | 16:40 | |
sean-k-mooney | so im not sure how relevent support of explecitly running operating systems that predate that is given libvirt we will default to tansitional device model if you are using the pc machien type | 16:40 |
sean-k-mooney | rhel 6 or windows server 2013 are the two main things that come to mind but they are not going to be deploy on q35 anyway | 16:41 |
*** bnemec has quit IRC | 16:48 | |
kashyap | sean-k-mooney: :-) I don't want to be overly confident and remove it yet | 16:52 |
kashyap | Hence I just wanted to make triple-sure before we remove it (and then later realize, "oh, we need to re-introduce" :-)) | 16:53 |
*** nweinber__ has quit IRC | 16:55 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603 | 16:56 |
kashyap | sean-k-mooney: Okay, satisfied your request :-) --^ | 16:56 |
kashyap | sean-k-mooney: I even added "if a good reason shows up" :D | 16:56 |
*** mkrai_ has quit IRC | 17:00 | |
*** tesseract has quit IRC | 17:01 | |
*** TxGirlGeek has quit IRC | 17:02 | |
*** rpittau is now known as rpittau|afk | 17:04 | |
*** mkrai_ has joined #openstack-nova | 17:11 | |
artom | Has the XMLMatcher utility for unit tests not moved to oslo? | 17:14 |
artom | Keystone has one, we have one... | 17:14 |
artom | Can't find it in oslo anywhere | 17:14 |
sean-k-mooney | kashyap: lol ok didnt i mark it as a nit | 17:15 |
sean-k-mooney | kashyap: e.g. you dont need to respin but sure | 17:15 |
sean-k-mooney | we have one in nova | 17:16 |
sean-k-mooney | at least we used too | 17:16 |
*** mkrai_ has quit IRC | 17:16 | |
artom | sean-k-mooney, yeah, but I'd like to suggest amodi use it in his whitebox patch | 17:17 |
sean-k-mooney | you can do self.assertXmlEqual | 17:17 |
artom | Not in tempest... | 17:18 |
sean-k-mooney | this is the implementaion https://github.com/openstack/nova/blob/e80300ac20388890539a7f709e526a0a5ba8e63d/nova/test.py#L534-L535 | 17:18 |
artom | And actually that method just uses the XMLMatcher :) | 17:18 |
sean-k-mooney | yes from nova.tests.unit import matchers | 17:19 |
sean-k-mooney | there https://github.com/openstack/nova/blob/e80300ac20388890539a7f709e526a0a5ba8e63d/nova/tests/unit/matchers.py#L404 | 17:20 |
kashyap | sean-k-mooney: You did, but I aim to please :-) | 17:22 |
artom | sean-k-mooney, yeah, so I'd rather not import nova bits into whitebox ;) | 17:26 |
* amodi agrees with artom | 17:27 | |
sean-k-mooney | ya we shoudl not but we shoudl have a similar function | 17:27 |
sean-k-mooney | we dont need 90% of what that is doing as it has extra complexity to be able to ignore things | 17:28 |
sean-k-mooney | for the whitebox tests i woudl probaly use xpath expression to pull out the content we want to compre from the two doms | 17:29 |
sean-k-mooney | and then compare teh normalised pretty printed version | 17:30 |
sean-k-mooney | but i really wold depend on why we were comparing | 17:30 |
sean-k-mooney | we should not try to have precreated expected xmls for the rebuild tests | 17:32 |
sean-k-mooney | we shoudl be comparing the relevent xml section between the instance before an after rebuild | 17:32 |
sean-k-mooney | which i think you already have example of for vcpus | 17:32 |
artom | That's exactly what it is | 17:32 |
artom | For the CPUs we pull out the individual IDs | 17:33 |
artom | Actually yeah, could do that here as well | 17:33 |
*** TxGirlGeek has joined #openstack-nova | 17:33 | |
sean-k-mooney | yep for the test that tried to change the number of numa nodes you jsut need to count the numer of cell elements before and after | 17:33 |
*** evrardjp has quit IRC | 17:34 | |
sean-k-mooney | you dont need to do a full xml match. it shoudl be rejected at teh api and the xml should not change for the negitive tests | 17:34 |
*** evrardjp has joined #openstack-nova | 17:34 | |
sean-k-mooney | for the positive test the numa/pinning related element also shoudl not change | 17:35 |
sean-k-mooney | the <nova:metadata/> element will be update with the image uuid however | 17:35 |
kashyap | sean-k-mooney: And here is the update to Glance's doc: https://review.opendev.org/#/c/703657/ | 17:37 |
* kashyap stops the spam now :D | 17:37 | |
sean-k-mooney | :) im about to go have dinner but ill review it later this evening | 17:37 |
*** tbachman has quit IRC | 17:42 | |
*** tbachman_ has joined #openstack-nova | 17:42 | |
*** eharney has joined #openstack-nova | 17:46 | |
*** iurygregory has quit IRC | 17:51 | |
kashyap | No rush. Thanks for review so far! (Likewise, off for dinner) | 17:54 |
*** TxGirlGeek has quit IRC | 18:01 | |
*** macz has quit IRC | 18:03 | |
*** dtantsur is now known as dtantsur|afk | 18:11 | |
*** ociuhandu_ has joined #openstack-nova | 18:13 | |
*** ociuhandu has quit IRC | 18:17 | |
*** TxGirlGeek has joined #openstack-nova | 18:17 | |
*** ociuhandu_ has quit IRC | 18:18 | |
*** martinkennelly has quit IRC | 18:18 | |
openstackgerrit | Merged openstack/os-vif master: [Follow Up] OVS DPDK port representors support https://review.opendev.org/665965 | 18:21 |
*** slaweq_ has joined #openstack-nova | 18:26 | |
*** slaweq has quit IRC | 18:27 | |
*** ralonsoh has quit IRC | 18:31 | |
*** tbachman has joined #openstack-nova | 18:40 | |
*** tbachman_ has quit IRC | 18:41 | |
*** CeeMac has quit IRC | 18:51 | |
*** TxGirlGeek has quit IRC | 18:56 | |
openstackgerrit | Adrian Chiris proposed openstack/os-vif master: Revert "[Follow Up] OVS DPDK port representors support" https://review.opendev.org/703672 | 18:57 |
openstackgerrit | Adrian Chiris proposed openstack/os-vif master: Revert "[Follow Up] OVS DPDK port representors support" https://review.opendev.org/703672 | 19:00 |
*** TxGirlGeek has joined #openstack-nova | 19:06 | |
*** TxGirlGeek has quit IRC | 19:13 | |
*** dustinc|PTO is now known as dustinc | 19:13 | |
dustinc | gibi: thanks for the feedback on provider config, going through it now/this week | 19:14 |
*** TxGirlGeek has joined #openstack-nova | 19:14 | |
*** TxGirlGeek has quit IRC | 19:22 | |
*** tosky has joined #openstack-nova | 19:25 | |
*** TxGirlGeek has joined #openstack-nova | 19:26 | |
*** TxGirlGe_ has joined #openstack-nova | 19:31 | |
*** TxGirlGeek has quit IRC | 19:31 | |
*** iurygregory has joined #openstack-nova | 19:33 | |
melwitt | efried: re: nova-drivers, yeah I hadn't looked at that in awhile. and nova-bugs is an open team, anyone can join on their own | 19:33 |
efried | oh, gtk | 19:36 |
melwitt | and what others said is correct, nova-drivers is just for doing blueprint-fu, for those involved in administrative tasks around releases, milestones, bp status, etc | 19:36 |
melwitt | I didn't join nova-drivers until I was ptl, then I used it to do some of the launchpad stuff described in the ptl guide I wrote | 19:37 |
openstackgerrit | Merged openstack/nova master: Add ironic hypervisor doc https://review.opendev.org/701998 | 19:37 |
openstackgerrit | Merged openstack/nova master: functional: Add '_create_server' helper https://review.opendev.org/697540 | 19:37 |
*** nicolasbock has quit IRC | 19:57 | |
*** mlavalle has joined #openstack-nova | 20:15 | |
*** eharney has quit IRC | 20:27 | |
*** rcernin has joined #openstack-nova | 20:42 | |
*** jmlowe has joined #openstack-nova | 21:00 | |
*** eharney has joined #openstack-nova | 21:28 | |
*** maciejjozefczyk_ has joined #openstack-nova | 21:28 | |
*** seba has quit IRC | 21:29 | |
openstackgerrit | sean mooney proposed openstack/nova stable/queens: Block rebuild when NUMA topology changed https://review.opendev.org/703140 | 21:33 |
openstackgerrit | sean mooney proposed openstack/nova stable/queens: Disable NUMATopologyFilter on rebuild https://review.opendev.org/703141 | 21:33 |
openstackgerrit | sean mooney proposed openstack/nova stable/queens: FUP for in-place numa rebuild https://review.opendev.org/703142 | 21:33 |
efried | frickler: Seen | 21:35 |
efried | 2020-01-21 18:21:18.373 | ERROR: Cannot uninstall 'PyYAML'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall. | 21:35 |
efried | a couple of times today. I noticed you seemed to have some clue what this was about when you were helping with https://review.opendev.org/#/c/649097/ -- can you help? | 21:35 |
*** maciejjozefczyk_ has quit IRC | 21:35 | |
efried | frickler: ^ was in the nova-live-migration job btw. | 21:36 |
efried | gmann: ^ any ideas? | 21:36 |
*** nweinber__ has joined #openstack-nova | 21:36 | |
*** seba has joined #openstack-nova | 21:37 | |
*** nweinber__ has quit IRC | 21:51 | |
*** TxGirlGe_ has quit IRC | 21:54 | |
*** TxGirlGeek has joined #openstack-nova | 21:56 | |
*** rchurch has quit IRC | 21:57 | |
*** rchurch has joined #openstack-nova | 22:00 | |
*** eharney has quit IRC | 22:06 | |
*** jmlowe has quit IRC | 22:09 | |
*** jmlowe has joined #openstack-nova | 22:14 | |
*** slaweq_ has quit IRC | 22:16 | |
*** jmlowe has quit IRC | 22:17 | |
*** Sundar has quit IRC | 22:36 | |
*** tkajinam has joined #openstack-nova | 22:57 | |
efried | dustinc: I went through gibi's comments on the provider config series and answered a few of them. I think the main thing is going to be the missing checks for duplicates by name+uuid. | 23:05 |
dustinc | efried: Thanks! I am also working through the nits and other small stuff since I need to update series anyway. I am only able to work on this bits at a time right this minute but plan to get it all done this week. | 23:06 |
*** mriedem has quit IRC | 23:07 | |
*** rchurch has quit IRC | 23:13 | |
*** rchurch has joined #openstack-nova | 23:14 | |
efried | cool | 23:14 |
*** Liang__ has joined #openstack-nova | 23:20 | |
sean-k-mooney | efried: so the PYYAML distutils thing is proably related to the fact we pin pip to a really old version in devstack. | 23:28 |
sean-k-mooney | we try to pin to a version below 10 to work around that so that pip will remove it anyway | 23:29 |
sean-k-mooney | without configuring devstack to install in virutal envs with no site packages i dont know if there is a clean way to complete work around package conflict with teh os packages | 23:30 |
openstackgerrit | Merged openstack/nova stable/ocata: ocata-only: drop non-voting ceph job https://review.opendev.org/700077 | 23:37 |
gmann | efried: sean-k-mooney pip 10 cap is removed now - https://review.opendev.org/#/c/561597/21 | 23:46 |
gmann | which job is failing | 23:47 |
*** tosky has quit IRC | 23:47 | |
sean-k-mooney | nova livemigration which is a legacy job | 23:48 |
sean-k-mooney | gmann: efried was asking about https://review.opendev.org/#/c/649097/ | 23:49 |
sean-k-mooney | but i think that was unrealted | 23:49 |
gmann | ok | 23:50 |
sean-k-mooney | oh that was just context for why he tought you would know | 23:50 |
sean-k-mooney | hum ya it looks like there are a decent number of failure on master https://zuul.opendev.org/t/openstack/builds?job_name=nova-live-migration | 23:51 |
*** damien_r has quit IRC | 23:51 | |
sean-k-mooney | oh ya th ecompression thing is not fix on legacy jobs... | 23:53 |
*** dviroel has quit IRC | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!